[00:20:23] 3Wikipedia App / 3Android App: Allow easier change of default language of Wikipedia - 10https://bugzilla.wikimedia.org/71136#c1 (10Hay Kranen) Created attachment 16902 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16902&action=edit Example of fast search language switching in Wikiamo app [00:30:08] 3Wikipedia App / 3Android App: Allow easier change of default language of Wikipedia - 10https://bugzilla.wikimedia.org/71136#c2 (10Hay Kranen) +1 for this feature. This is actually one of the very few things i miss from the honourable old Wikiamo (iOS) app. I'm from the Netherlands and i switch between the D... [06:55:58] (03CR) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [07:18:53] (03CR) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [07:30:28] (03PS3) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 [07:31:28] (03CR) 10jenkins-bot: [V: 04-1] Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [07:43:04] (03PS4) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 [07:43:53] (03CR) 10jenkins-bot: [V: 04-1] Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [11:05:39] 3Wikipedia App / 3Android App: Text Looks garbled when using Bengali - 10https://bugzilla.wikimedia.org/66125 (10Andre Klapper) [11:16:24] 3Wikipedia App / 3Localization/Translation/Language: RTL bugs in the Wikimedia Mobile Android app (tracking) - 10https://bugzilla.wikimedia.org/34166 (10Amir E. Aharoni) [11:16:27] 3Wikipedia App / 3Android App: Inconsistent directionality in the Android App's nearby screen - 10https://bugzilla.wikimedia.org/72554 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 16906 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16906&action=edit a screenshot wi... [11:18:08] 3Wikipedia App / 3Android App: Inconsistent directionality in the Android App's nearby screen - 10https://bugzilla.wikimedia.org/72554#c1 (10Amir E. Aharoni) (Looking at the screenshot, it may be that the names that are longer than one line get aligned to the left, but it may be just a coincidence. In any ca... [14:04:09] 3Wikipedia App / 3Android App: the nearby function doesn't work in some locales - 10https://bugzilla.wikimedia.org/33704#c10 (10Dmitry Brant) It looks like the "geosearch" API is not available/enabled in Hebrew Wikipedia... [14:09:30] dbrant, is it on the english wikipedia? [14:09:35] http://en.wikipedia.org/w/api.php?action=help&modules=query doesn't llist it [14:09:41] yet the android app source code uses it... ? [14:11:28] https://en.wikipedia.org/w/api.php?action=query&prop=coordinates&format=jsonfm&colimit=10&generator=geosearch&ggscoord=37.786688999999996%7C-122.3994771999999&ggsradius=10000&ggslimit=10 -> Unknown generator=geosearch [14:11:47] Krenair: hmm... oook then! Something must be going on with the site as a whole. (Nearby in enwiki isn't working right now, either!) [14:12:04] yeah [14:12:19] Krenair: seeing a lot of chatter in operations... :) [14:13:39] heh [14:13:46] tried to search for 'geosearch' on mediawikiwiki [14:14:06] "An error has occurred while searching: Pool queue is full". Guess that's what they're busy with [14:16:14] dbrant, what extension is geosearch in? does it rely on cirrussearch? [14:16:42] Krenair: I don't know the internals of it, i'm afraid [14:18:16] GeoData extension [14:21:01] dbrant, yeah, see wmf-config/CommonSettings.php in the operations/mediawiki-config.git repo [14:21:09] require_once( "$IP/extensions/GeoData/GeoData.php" ); [14:21:09] $wgGeoDataBackend = 'elastic'; [14:21:18] but only if cirrus is in use [14:21:20] and cirrus was disabled [14:21:22] so no geosearch [14:21:27] aha... [14:23:24] 3Wikipedia App / 3Android App: the nearby function doesn't work in some locales - 10https://bugzilla.wikimedia.org/33704#c11 (10Alex Monk) It's not enabled anywhere right now - Cirrus is disabled due to issues (see operations channel) and therefore GeoData is not enabled. [14:32:24] (03CR) 10Dbrant: "I have to admit I'm a little confused by this feature. Here are my concerns:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [14:56:22] (03PS5) 10Deskana: Refactor handling of shared preferences and feature install IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168772 [14:59:35] (03CR) 10Alex Monk: "I don't think MW's watchlist is supposed to benefit readers much..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [15:02:57] (03CR) 10Phuedx: [C: 04-1] Fix missing edit preview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [15:25:29] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168971 [15:27:38] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168972 [15:31:38] 3Wikipedia App / 3Android App: the nearby function doesn't work in some locales - 10https://bugzilla.wikimedia.org/33704#c12 (10Andyrom75) https://it.wikivoyage.org and other language versions are suffering majors issues due to the multiple visualization of the #coordinates: code (see bug 72559). Please fix... [15:32:48] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [15:33:01] Morning folks. [15:33:29] yo [15:33:35] good afternoon :) [15:33:42] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [15:35:00] there it is… [15:50:29] (03PS1) 10Dbrant: A few Search refinements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 [16:24:52] And now, to head to the office. [16:24:56] See you in a bit! [16:26:00] good journey Deskana|Away :P [16:26:34] (03PS4) 10Florianschmidtwelzow: Fix missing edit preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) [16:27:27] (03CR) 10jenkins-bot: [V: 04-1] Fix missing edit preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [16:40:50] (03CR) 10Dbrant: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168971 (owner: 10BearND) [16:45:26] YuviPanda: pm? [16:52:36] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [16:53:36] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [16:56:51] any Android root phone owner? [16:57:00] rooted [16:57:07] matanya: yep [16:57:38] dbrant: i need the hangout apk can you please send it to me? [16:58:45] matanya: I'll see if I can get it... [16:59:08] thank you [17:03:37] phuedx are you standing with us? [17:03:45] ah [17:03:46] dern [17:04:37] ok [17:04:39] i owe money [17:05:05] 62 p [17:16:16] bearND [17:26:11] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566 (10Chris H-C) 3UNCO p:3Unprio s:3normal a:3None When visiting Wikipedia articles with expandable sections, mouse events (from a bluetooth mouse or using a device that supports mouse-like interacti... [17:27:39] (03CR) 10Jdlrobson: [C: 04-1] Fix missing edit preview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [17:28:47] (03PS1) 10Jdlrobson: Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 [17:29:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 (owner: 10Jdlrobson) [17:30:21] i'm sure jerkins was giving growth the same problems [17:30:24] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/iJcO2LLD [17:30:27] but i can't remember how it was fixed [17:31:27] Phuedx today is the last late meeting day… [17:31:59] sorry, just got back [17:32:50] bearND do the kids have bright shiny teeths? [17:33:20] kristenlans: yes, and they are also good wrestlers [17:33:48] bearND: lol [17:34:10] kristenlans: \o/ [17:34:23] thanks for all yer hard work organising that stuff [17:34:29] also, timezones! [17:34:43] (03CR) 10Florianschmidtwelzow: Fix missing edit preview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [17:34:52] phuedx thank YOU for bearign with the late meets [17:35:00] (03CR) 10Jhernandez: [C: 032] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [17:35:23] matanya: wish i could help, try here? [17:35:32] matanya needs hangout apk urgently [17:35:55] for fdc meeting [17:36:05] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [17:36:19] thanks mutante :) [17:38:53] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c2 (10Jon) Hi Chris H-C thanks for the heads up. I'll look to get this fixed asap. I can't replicate with Chrome developer tools but I will take a look on a Blackberry device. FYI, I notice the @blackber... [17:43:46] (03PS1) 10Jdlrobson: Hygiene: Comment out broken browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169007 [17:44:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Comment out broken browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169007 (owner: 10Jdlrobson) [17:45:40] sigh that doesn't even fix the browser tests [17:52:52] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c3 (10Chris H-C) You have to enable mobile emulation for viewport and user-agent string, but disable the touch screen emulation, so it's a bit tricky to finagle Chrome into place... I wasn't sure if you h... [17:55:24] (03CR) 10BearND: [C: 04-1] "I don't think we need to do this." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 (owner: 10Dbrant) [17:58:22] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/oYZOkg [17:58:22] 13WikipediaMobile/06master 14afe9eb8 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [17:58:31] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [17:58:46] (03PS10) 10MaxSem: Backend for picking questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [17:59:15] kaldari: something is not right with qunit tests, I'm trying to fix that first which should take care of ^ [18:00:49] Err, thanks wikipedia-github for that update. [18:01:10] kaldari: Jenkins doesn't like you. :( [18:01:20] Or anyone else in Mobile Web. [18:01:43] YuviPanda: as what user does the new alpha build run? [18:02:10] tfinc: attempting to join, should be there shortly [18:02:15] bearND: android-builds, I think? [18:04:39] YuviPanda: is there a way for us dbrant and i to become android-build user? The become command doesn't seem to be available [18:06:37] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c4 (10Jon) We have a couple but right now we are struggling to even power them on to investigate :) [18:08:49] (03PS1) 10Jdlrobson: Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169019 [18:09:39] (03CR) 10jenkins-bot: [V: 04-1] Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169019 (owner: 10Jdlrobson) [18:09:49] (03Abandoned) 10Jdlrobson: Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169019 (owner: 10Jdlrobson) [18:11:29] (03PS1) 10Bmansurov: fix failing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169020 [18:11:40] bearND: sorry was in a meeting [18:11:50] bearND: sudo -u android-builds /bin/bash? [18:12:01] jdlrobson, kaldari, please review https://gerrit.wikimedia.org/r/169020, this will help merge other patches [18:12:18] (03CR) 10jenkins-bot: [V: 04-1] fix failing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169020 (owner: 10Bmansurov) [18:12:48] (03PS1) 10Jdlrobson: Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169022 [18:13:13] YuviPanda: do I have access to the build server? :) [18:13:44] dbrant: checking... [18:13:45] (03CR) 10jenkins-bot: [V: 04-1] Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169022 (owner: 10Jdlrobson) [18:14:11] YuviPanda: hmm, it asks for a password. BTW, the user name is android-build (without the s) [18:14:42] (03PS2) 10Jdlrobson: Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169022 [18:15:33] (03CR) 10jenkins-bot: [V: 04-1] Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169022 (owner: 10Jdlrobson) [18:15:37] bearND: hmm, try sudo -s first, and then sudo -u android-build /bin/bash? [18:16:00] (03Abandoned) 10Jdlrobson: Testing testing 123 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169022 (owner: 10Jdlrobson) [18:16:35] bmansurov: Why does it have to do deleteUserSetting with both true and false for the cookie setting? Shouldn't just using true be adequate? [18:17:06] isn't one expandedSections and the other is expandSections? [18:17:16] jdlrobson: can you clarify what you mean with "TalkOverlay uses section indirectly"? :/ [18:17:26] bmansurov: LOL, you're right :) [18:17:31] FlorianSW: grep for '.line' in TalkOverlay [18:17:37] I read them as the same [18:17:50] kaldari: maybe I should rename one to something else [18:18:17] (03PS2) 10Jdlrobson: Fix failing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169020 (https://bugzilla.wikimedia.org/72506) (owner: 10Bmansurov) [18:18:22] bmansurov: that's ok, I'll test the tests now [18:18:29] (03CR) 10Jdlrobson: [C: 032] Fix failing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169020 (https://bugzilla.wikimedia.org/72506) (owner: 10Bmansurov) [18:18:33] ok [18:18:45] (03Abandoned) 10Jdlrobson: Hygiene: Comment out broken browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169007 (owner: 10Jdlrobson) [18:18:51] jdlrobson: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/talk/TalkOverlay.js#L111 only match [18:19:01] it's not related to section.hogan [18:19:04] dbrant: what's your wikitech user name? [18:19:07] Deskana: also, PM? [18:19:08] (03CR) 10jenkins-bot: [V: 04-1] Fix failing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169020 (https://bugzilla.wikimedia.org/72506) (owner: 10Bmansurov) [18:19:15] YuviPanda: Sure. [18:19:43] FlorianSW: basically you are making an unrelated change [18:19:49] YuviPanda: "Dbrant" [18:19:52] do not remove line from https://gerrit.wikimedia.org/r/#/c/168822/4/javascripts/Section.js [18:19:59] do the bare minimum for it to be fixed :) [18:20:07] especially given we will want to lightning deploy this :) [18:20:20] also section.hogan should probably be renamed Section.hogan (capitalised s) [18:20:34] jdlrobson: but then we have a useless tag? :) [18:20:43] jdlrobson: LD is my goal, too :P [18:21:04] (03CR) 10Kaldari: [C: 032 V: 032] Fix failing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169020 (https://bugzilla.wikimedia.org/72506) (owner: 10Bmansurov) [18:21:20] FlorianSW: let me dig and work out where Section.hogan got removed [18:21:35] to the git bisect cave! [18:21:36] in your patch with the remove of Ajax related thing [18:21:39] *things [18:21:46] jdlrobson ^ [18:21:47] kaldari, jdlrobson: how's jenkins looking? [18:21:47] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [18:22:13] dbrant: you should have access now [18:22:23] phuedx: not good. can't find Krinkle|detached or antoine [18:22:24] sigh [18:22:30] YuviPanda: what's the host name? [18:22:53] jdlrobson: https://gerrit.wikimedia.org/r/#/c/164141/ [18:22:58] dbrant: ah, you need some slightly special config to ssh in (need to set up a bastion) [18:23:05] let me find link [18:23:30] YuviPanda: ok, I'm in, but where do i find the log files? I want to find out why the build hasn't published a new apk since 10/20. [18:23:55] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [18:24:49] bearND: I never got around to adding logging. Got distracted by ops work... :( [18:25:03] boo [18:25:11] bearND: am looking through things now and tomorrow. My last week here and will make sure this thing finishes up properly... [18:25:30] jdlrobson: can you reply to the last comment in https://gerrit.wikimedia.org/r/#/c/168708/ [18:25:41] YuviPanda: thanks [18:25:52] dbrant: https://wikitech.wikimedia.org/wiki/Help:Access url for docs for setting up access [18:27:16] (03CR) 10jenkins-bot: [V: 04-1] EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [18:28:05] (03CR) 10Phuedx: [C: 032] "The major-ish points that I brought up during review have been addressed. Let's tidy up the rest/any more we spot later." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [18:28:17] +2 limbo! [18:28:34] (03CR) 10Bmansurov: "now recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [18:28:54] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [18:31:34] (03CR) 10Jhernandez: [C: 032] Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 (owner: 10Jdlrobson) [18:32:23] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 (owner: 10Jdlrobson) [18:35:07] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c5 (10Chris H-C) Not my department :) (if you're running into a wall, let me know what you're seeing and I might be able to help. I'm Browser dev, but I've picked up a few things over the years.) [18:35:09] (03PS1) 10Legoktm: Use MovePageIsValidMove hook if possible [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 [18:35:15] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Document when classes use things (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 (owner: 10Jdlrobson) [18:38:45] (03CR) 10Bmansurov: EditorApi: Check for sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [18:40:05] (03PS5) 10Florianschmidtwelzow: Fix missing edit preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) [18:40:54] (03CR) 10jenkins-bot: [V: 04-1] Fix missing edit preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [18:41:03] YuviPanda: i'm in, thanks! [18:41:08] getting george to bed [18:41:13] dbrant: cool! [18:41:22] phuedx: goodnight george! [18:44:20] (03CR) 10Kaldari: [C: 032 V: 032] Fix missing edit preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168822 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [18:44:51] (03PS1) 10Florianschmidtwelzow: Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 [18:45:11] (03PS1) 10Florianschmidtwelzow: Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169039 (https://bugzilla.wikimedia.org/72522) [18:45:25] (03PS1) 10Florianschmidtwelzow: Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169040 (https://bugzilla.wikimedia.org/72522) [18:46:17] MaxSem: I merged the edit preview fix: https://gerrit.wikimedia.org/r/#/c/168822 . You wanna backport and SWAT deploy? [18:47:18] kaldari ^ changes above [18:47:26] kaldari, SWAT or immediately? [18:47:53] MaxSem: ah, looks like FlorianSW already backported :) [18:48:29] kaldari: right :) MaxSem, if could update the submodule, too, after the changes are merged, if you want :) [18:48:58] MaxSem: Is there a deployment window currently? If not, we can probably wait until this afternoon. [18:49:23] well, we can't deploy atm anyway due to an ongoing outage [18:49:49] oops :P [18:49:57] (03CR) 10Florianschmidtwelzow: EditorApi: Check for sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [18:50:15] (03CR) 10jenkins-bot: [V: 04-1] Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [18:50:51] (03CR) 10jenkins-bot: [V: 04-1] Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169039 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [18:50:54] (03CR) 10jenkins-bot: [V: 04-1] Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169040 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [18:50:54] * FlorianSW gives some cookies to Jenkins [18:51:23] note to ppl testing nearby in prod: GeoData is currently down [18:55:26] (03CR) 10Jhernandez: "Some suggestions," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [18:56:28] (03CR) 10Jhernandez: "To restore scroll with something like window.scrollBy" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [18:58:32] (03CR) 10Bmansurov: "Thanks, Jhernandez, the problem I'm having is that this will save the scroll position and restore it whenever the user visits the Nearby p" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [19:00:16] bmansurov: yeah, knowing when it comes from the back button is not possible [19:00:32] joakino: so maybe we should not implement it [19:00:45] joakino: because scrolling to some random position is even more confusing [19:01:32] bmansurov: that's why i was suggesting saving the options hashmap stringified with the scroll position, so that when trying to restore you only restore scroll position if you have those search parameters saved [19:02:09] bmansurov: i personally think that this kind of things lead to hell [19:03:41] bmansurov: also localstorage is sync, so instead of on window scroll if we do something like this we should probably save scroll position when clicking on the results [19:05:18] joakino: what search parameters? Will I get two different options when I visit Special:Nearby by hitting the back button vs. when I visit that page by typing the url in the address bar? [19:07:22] 3MobileFrontend / 3Hygiene: QUnit failures in browser for toggling tests - 10https://bugzilla.wikimedia.org/72506 (10Jon) 5PATC>3RESO/FIX [19:08:54] (03CR) 10Bmansurov: [C: 032] EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [19:09:45] (03CR) 10jenkins-bot: [V: 04-1] EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [19:13:22] What's wrong with jenkins-bot?! Can't it just accept my +2s. [19:14:59] hello.. just realized i wasn't on irc [19:15:48] if anyone is having brew issues after yosemite update i wrote up a quick fix for it on my blog: http://sane.ly/fix-homebrew-for-os-x-10-10-yosemite/ [19:18:53] well that was easy [19:20:25] i just removed my /usr/local and reinstalled ;) [19:20:46] is anyone on 10.10 having the problem that their hostname keeps having numbers appended to it? [19:20:59] it’s apparently some mDNS/Bonjour-related bug and it’s driving me nuts [19:21:29] i've noticed that wifi drops whenever i come out of sleep [19:21:43] ^ weird sentence if i were talking about myself [19:21:47] oh .0 releases :D [19:22:12] someday we’ll all have wifi in our brains [19:22:14] it’ll be great [19:22:17] except for the NSA spying [19:22:28] and the brain cancer [19:22:57] brion: that is another way to fix it I suppose :) I must not be running bonjour on this machine as my hostname looks normal [19:23:16] maybe it just hates my home network [19:23:21] hasn’t triggered yet at the office this morning [19:23:47] I had one severe crash coming back from sleep, screen was stuck in between workspaces and there was two apple icons in top left [19:23:56] (03CR) 10Jdlrobson: [C: 04-1] Fix useless tag in editor preview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:24:29] (03CR) 10Jdlrobson: Fix useless tag in editor preview (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:25:56] 3MobileFrontend / 3stable: Edit preview doesn't work for article pages (no JS error) - 10https://bugzilla.wikimedia.org/72522 (10Jon) 5PATC>3RESO/FIX [19:26:12] (03CR) 10Florianschmidtwelzow: Fix useless tag in editor preview (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:26:13] jdlrobson: What do you need [19:26:24] Krinkle: !!! [19:26:32] so we have an issue with the jenkins qunit build for mobile [19:26:44] it everything in MobileFrontend and Mantle gets rejected by jenkins [19:26:57] e.g. https://gerrit.wikimedia.org/r/#/c/169039/ [19:27:11] actually that's a bad example [19:27:38] https://gerrit.wikimedia.org/r/#/c/168138/ [19:27:44] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/6213/console complains 'PhantomJS timed out, possibly due to a missing QUnit start() call.' [19:28:00] ^ Krinkle this is happening everywhere and started friday. Tests pass fine locally [19:28:31] i'm not sure if anything changed on friday around this code [19:28:48] jdlrobson: That first gerrit link links to https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/6218/consoleFull [19:28:54] 18:50:39 test.mediawiki.qunit.testrunner - Loader status...ERROR [19:28:55] 18:50:39 >> Message: Modules in error state [19:28:55] 18:50:39 >> Actual: [ [19:29:00] yeh ignore first gerrit link that was a bad example [19:29:17] the 2nd gerrit link is a better example of what we are seeing [19:29:17] all mobile and minerva modules have a load error, presumably a missing resource file or missing target declaration [19:29:20] k [19:29:58] (03CR) 10Jdlrobson: [C: 04-1] "Seems to be a genuine QUnit error here." [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169039 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [19:30:19] (03CR) 10Jdlrobson: [C: 04-1] "Seems to be a genuine QUnit error here." [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169040 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [19:30:50] Krinkle: https://gerrit.wikimedia.org/r/#/c/169000/ is another example [19:31:03] (03CR) 10Bmansurov: Add role 'button' to section heading text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [19:31:24] i've tried all sorts of things including removing all our unit tests but i still hit the same problem which makes me think there is something wrong with jenkins [19:32:55] jdlrobson: ok. going through mediawiki-debug.log file now (attached to the build artefact from the Status view on that build) [19:32:59] (03PS2) 10Florianschmidtwelzow: Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 [19:33:05] thanks Krinkle [19:33:17] jdlrobson: I think it has to do with grunt, can you disable grunt and run tests again? [19:33:27] bmansurov: grunt didn't get +2ed [19:33:46] Krinkle: but could a patch with a Gruntfile.js being uploaded have started this? I did notice the issues around that time [19:33:49] 18:50:33 Reading "Gruntfile.js" Gruntfile...OK [19:33:49] 18:50:33 [19:33:49] 18:50:33 Registering Gruntfile tasks. [19:33:52] (03CR) 10jenkins-bot: [V: 04-1] Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:34:02] bmansurov: there is a Gruntfile somewhere in jenkins land - not our Gruntfile [19:34:10] oh ok [19:34:33] ^ Krinkle example 3 :) [19:35:00] > [deprecated] Use of SkinTemplate::outputPage was deprecated in MediaWiki 1.25. [Called from SkinMinerva::outputPage in /srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-qunit-mobile/src/extensions/MobileFrontend/includes/skins/SkinMinerva.php at line 926] [19:35:19] > [resourceloader] ResourceLoaderFileModule::getStyles: failed to update DB: exception 'DBQueryError' with message 'A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script [19:35:20] > Query: REPLACE INTO module_deps (md_module,md_skin,md_deps) VALUES ('skins.minerva.special.styles','minerva','["/srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-qunit-mobile/src/extensions/MobileFrontend/less/specials/common.less","/srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-qunit-mobile/src/extensions/MobileFrontend/less/minerva.less/minerva.variables.less","/srv/ssd/jenkins-slave/ [19:35:20] workspace/mwext-MobileFrontend-qunit-mobile/src/resources/src/mediawiki.less/mediawiki.ui/variables.less","/srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-qunit-mobile/src/extensions/MobileFrontend/less/minerva.less/minerva.mixins.less","/srv/ssd/jenkins-slave/workspace/mwext-MobileFrontend-qunit-mobile/src/resources/src/mediawiki.less/mediawiki.mixins.less"]') [19:35:44] those are the only two things that stand out [19:36:05] Krinkle, jdlrobson: jenkins test against master mediawiki core, right? [19:36:09] (03PS2) 10Jdlrobson: Remove deprecated call of SkinTemplate::outputPage() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168747 (owner: 10Florianschmidtwelzow) [19:36:17] Krinkle: ohh interesting... [19:36:20] FlorianSW: Yes, unless the commit is against a non-master branch [19:36:24] exact, Jon found the patch :) [19:36:27] i wonder if jenkins likes this one [19:36:41] i think it's a problem of the deprectaed warning [19:36:42] probably doesn't make a difference, though it'd be nice [19:36:50] of SkinTemplate::outputPage() [19:36:57] wow maybe it is the solution.. [19:36:58] ok, hmm :/ [19:37:01] (03CR) 10Jdlrobson: [C: 032] Remove deprecated call of SkinTemplate::outputPage() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168747 (owner: 10Florianschmidtwelzow) [19:37:13] why would that effect qunit? Because of the way modules get added in outputPage function? [19:37:39] (03Merged) 10jenkins-bot: Remove deprecated call of SkinTemplate::outputPage() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168747 (owner: 10Florianschmidtwelzow) [19:37:50] (03PS2) 10Jdlrobson: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [19:38:05] ^ let's see if Jenkins likes this patch now [19:38:44] (03CR) 10jenkins-bot: [V: 04-1] EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [19:38:46] (03PS2) 10Jdlrobson: Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 [19:39:05] jdlrobson: Hm.. it merged the patch? [19:39:10] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:39:17] grrrit-wm: (Merged) jenkins-bot: Remove deprecated call of SkinTemplate::outputPage() [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/168747 (owner: Florianschmidtwelzow) [19:39:22] Krinkle: yeh that one merged... [19:39:23] looks like it works now? [19:39:26] so i'm wondering if that is the reason [19:39:31] Odd. [19:39:34] (03PS3) 10Jdlrobson: Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:39:47] Krinkle: yeh looks like it fixed everything. most strange.. [19:39:48] So Krinkle why would that effect qunit tests? [19:39:59] also../me hugs Krinkle and florian [19:40:11] jdlrobson: Well, look at what MediaWiki outputs when you install latest mw-core with MF and useformat=mobile [19:40:11] (03PS2) 10Jdlrobson: Generate WikiGrok prefix correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168695 [19:40:17] I suspect it broke the output [19:40:40] Krinkle, jdlrobson: jap, it's a output out of OutputPage (on top of the page) [19:40:41] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [19:40:43] In such a way that the base layer (div#qunit) didn't exist. And thus QUnit wouldn't even start. [19:40:46] *an [19:40:52] You tested it locally with useformat=mobile ? [19:41:25] yes, that's why i wonder that it doesn't work in jenkins [19:41:27] Krinkle: yeh it was working fine [19:41:45] even with my local phantomjs runner [19:42:06] php deprecatios do not afffect qunit tests [19:42:06] does php ignore extra parameters under certain conditions? [19:42:14] It always does [19:42:18] (03PS6) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) [19:42:49] (03CR) 10Jdlrobson: [C: 04-1] "Issues with tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [19:43:25] php > function foo($a, $b) { return $a * $b;} [19:43:25] php > var_dump(foo(4,5)); [19:43:25] int(20) [19:43:27] php > var_dump(foo(5,6,7)); [19:43:29] int(30) [19:43:31] just like javascript [19:43:54] (03PS6) 10Jdlrobson: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [19:43:57] (03PS10) 10Jdlrobson: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [19:44:01] (03PS16) 10Jdlrobson: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [19:44:18] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [19:44:54] Krinkle: this is all very weird. [19:45:02] i'm just going to pick up my lunch but i'll be back soon [19:45:41] k [19:46:27] (03PS3) 10Florianschmidtwelzow: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) [19:51:22] (03PS2) 10Florianschmidtwelzow: Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169040 (https://bugzilla.wikimedia.org/72522) [19:51:54] (03CR) 10Jdlrobson: [C: 032] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [19:52:28] (03Merged) 10jenkins-bot: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [19:53:16] (03PS2) 10Florianschmidtwelzow: Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169039 (https://bugzilla.wikimedia.org/72522) [19:53:40] (03CR) 10Jdlrobson: [C: 032] Generate WikiGrok prefix correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168695 (owner: 10Jdlrobson) [19:53:47] (03CR) 10Jdlrobson: [C: 032] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [19:54:01] (03CR) 10Jdlrobson: [C: 032] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [19:55:39] c-c-c-c-c combo breaker! [19:55:49] * phuedx really needs to write a bot to automate that ^ [19:56:46] FlorianSW, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7911603 - another german query about location access [19:58:23] Krenair: oh, i should read my unread E-Mails :/ thanks for info :) [19:59:07] (03Merged) 10jenkins-bot: Generate WikiGrok prefix correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168695 (owner: 10Jdlrobson) [19:59:09] (03Merged) 10jenkins-bot: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [19:59:16] (03Merged) 10jenkins-bot: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [19:59:18] kaldari: can you take a look at https://gerrit.wikimedia.org/r/#/c/168722/ when you get a chance? [19:59:28] why has https://bugzilla.wikimedia.org/show_bug.cgi?id=71331 suddenly become the most popular crash report? [19:59:35] are the servers suddenly erroring a lot? [20:02:38] bmansurov: sorry i went out for lunch [20:02:56] joakino: np and welcome again [20:03:33] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [20:04:21] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [20:07:22] https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AqEdtQuSLdAxdGF0Unlob2MtRmZTeU4tODJXbk9rQ1E&usp=drive_web#gid=1 [20:14:37] 3MobileFrontend / 3Hygiene: MobileFrontend should use mw-ui-icon in beta - 10https://bugzilla.wikimedia.org/71181#c6 (10Jon) 5PATC>3NEW Now this code is in alpha. Let's move it to beta. [20:14:45] dbrant, bearND: Everything going okay? Anything I can help with? :) [20:15:08] https://en.m.wikipedia.org/wiki/Plancks_constant [20:15:13] shows fine on my desktop [20:15:25] Deskana: yep, reviewing your refactoring :) [20:15:37] blank on my mobile though [20:15:39] 3MobileFrontend / 3Hygiene: MobileFrontend should use mw-ui-icon in beta - 10https://bugzilla.wikimedia.org/71181#c7 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JTZl1RkW [20:15:42] dbrant: \o/ [20:16:02] Deskana: sorry i missed the standup earlier. just one minor question. pm ok? [20:16:23] (reported to me in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7911744 ) [20:16:51] bearND: Sure. [20:24:03] yurikR: got a preliminary code to review? [20:24:18] dbrant: I'm curious whether that patch is any good. I *think* I was barking up the right tree, but maybe I just got the wrong end of the stick. [20:24:19] dr0ptp4kt, not yet [20:24:33] yurikR: kk [20:26:22] Deskana: oh sure, it's a worthy refactor [20:44:59] (03CR) 10Jdlrobson: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [20:45:05] (03CR) 10Jdlrobson: [C: 032] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [20:45:43] (03Merged) 10jenkins-bot: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [20:45:59] (03PS1) 10Dr0ptp4kt: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 [20:46:32] (03PS1) 10Florianschmidtwelzow: Add tests for EditorPreview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169211 [20:46:37] 3MobileFrontend / 3Feature requests: Allow user to enter a location on Special:Nearby - 10https://bugzilla.wikimedia.org/49413 (10Jon) 5PATC>3RESO/FIX [20:47:00] (03PS2) 10Florianschmidtwelzow: Add test for EditorOverlay preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169211 [20:55:54] 3MobileFrontend / 3stable: Redirect to editor after login doesn't work for lead section - 10https://bugzilla.wikimedia.org/72580 (10Florian) 3NEW p:3Unprio s:3normal a:3None If you click on the edit pencil (you're not logged in) on a section heading, you'll have a returnquery in the login link (retur... [20:58:31] I'm having an issue with the latest build. [20:58:35] I pulled from master, and I get this... [20:58:36] Error:(20, 8) org.wikipedia.zero.WikipediaZeroHandler is not abstract and does not override abstract method onHeaderCheck(org.mediawiki.api.json.ApiResult) in org.mediawiki.api.json.OnHeaderCheckListener [20:58:40] I can't build the app :( [20:58:55] dbrant|brb, bearND [20:59:25] I was going to show Lydia, the PM for Wikidata, our search work [20:59:42] Deskana: ah, you need to update your Gradle dependencies [21:00:10] Deskana: ./gradlew --refresh-dependencies [21:00:37] 3MobileFrontend / 3stable: Redirect to editor after login doesn't work for lead section - 10https://bugzilla.wikimedia.org/72580#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oYoUc6Vh [21:00:38] Hmm, okay. [21:01:03] Deskana: we made changes in the java-mwapi dependency that need to be synced. [21:01:24] Hmm, I ran that but it didn't work. [21:01:49] Deskana: I also recommend this: rm -rf ~/.m2/repository/org/mediawiki/api [21:02:09] Deskana: and in Android Studio: trigger Gradle sync (fifth icon from the right in the toolbar) [21:02:20] Right, that's probably the bit I'm missing. [21:04:21] Deskana: dbrant: next time we do an incompatible change we should increment the java-mwapi version number, sorry for not doing that this time [21:04:40] yep... [21:06:54] 3MobileFrontend / 3stable: Redirect to editor after login doesn't work for lead section - 10https://bugzilla.wikimedia.org/72580 (10Florian) 5NEW>3ASSI a:3Florian [21:08:33] moizsyed: http://www.instructables.com/id/Hamster-Wheel-Standing-Desk/ [21:08:54] phuedx: that looks kinda cool [21:09:01] inorite!? [21:09:12] (03PS3) 10Jdlrobson: Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 [21:09:40] (03PS2) 10Dr0ptp4kt: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 [21:10:29] http://hatjitsu.wmflabs.org/56144 [21:10:56] (03PS3) 10Dr0ptp4kt: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 [21:11:10] (03PS1) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) [21:12:18] (03PS1) 10BearND: Add menu entry to delete recent search entries when in search mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169217 [21:13:20] http://hatjitsu.wmflabs.org/56144 [21:17:32] dbrant, bearND: Lydia loved the wikidata descriptions in search! [21:17:44] I have a sound bite from her [21:18:03] Deskana: props to bearND for that! [21:18:08] "In terms of performance... this is a very reasonable, sensible thing to be wanting to do with Wikidata, and if there are performance problems then it's our job to make sure we fix it." [21:18:38] Deskana: that's awesome to hear! [21:18:42] I said I'd hold her to that. ;) [21:19:08] (03Abandoned) 10Dr0ptp4kt: Try to redirect ineligible zerodot more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165659 (owner: 10Dr0ptp4kt) [21:19:10] Deskana: great to hear! Thanks! Couldn't have done it without legoktm's help. [21:19:19] :o [21:19:20] :D [21:19:24] (03CR) 10Dr0ptp4kt: "Supersedes I4eac7a69060639d5c013cc89241997fb0fc9a3ba." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt) [21:20:44] legoktm: Thanks again for pointing me to the search generator! [21:20:53] np :) [21:23:07] bearND, legoktm: Nice work. :) [21:27:37] (03PS12) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [21:30:54] (03PS6) 10Dbrant: Refactor handling of shared preferences and feature install IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168772 (owner: 10Deskana) [21:32:21] brion: it fixed that weird squished article table text issue too! :) [21:32:48] \o/ [21:32:49] awesome [21:39:14] (03CR) 10Dbrant: [C: 032] Refactor handling of shared preferences and feature install IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168772 (owner: 10Deskana) [21:44:10] dbrant, do you want me to handle https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7911042 ? [21:45:06] Krenair: sure, please! [21:46:32] dbrant: :D [21:46:42] (I audibly just squealed "YES!" when I saw that was merged) [21:47:04] Deskana: lol nicely done [21:51:07] (03CR) 10Bmansurov: [C: 032] Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 (owner: 10Jdlrobson) [21:52:04] dbrant, done [21:52:11] thx! [21:54:47] (03Merged) 10jenkins-bot: Hygiene: Document when classes use things [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169000 (owner: 10Jdlrobson) [21:55:09] http://etherpad.wikimedia.org/p/G__________________ [21:56:10] http://en.wikipedia.org/wiki/List_of_films:_H [21:57:21] testing? [22:01:35] i really thought it was going to be hackers [22:01:36] boo [22:01:56] boo with a hat on [22:03:13] phuedx: just to contradict max we voteshifted [22:03:14] kaldari|2: can you test and merge https://gerrit.wikimedia.org/r/168722 asap? [22:03:26] i can live with that [22:04:41] jdlrobso_, joakino: i was devils advocating about jerkins because i didn't want us to get lost on it [22:05:19] could have put it better in the meeting [22:05:25] s/could/i could/ [22:05:42] vimmer? [22:05:53] phuedx: ^ [22:06:03] yup [22:06:10] although, a little less these days [22:06:22] phuedx: why? [22:06:29] YEAH! Maryana signed off on thi while we were meeting: https://trello.com/c/7Z21Hl6t/87-3-add-other-claim-types-to-wikigrok-version-a-to-match-version-b [22:06:50] joakino: that's hard to put into words [22:10:01] joakino: i think in being so configurable it sorta lost me [22:10:17] (03CR) 10Bmansurov: "So the only way to get it working is by changing the window hash before the user leaves the page?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [22:10:23] configurable? hackable maybe [22:10:32] phuedx: so what do you use [22:11:18] phuedx: i've been with it for about 7 years so it's pretty hard to change to anything else [22:11:28] i tried out atom, i've tried phpstorm, i used to use textmate [22:11:49] i've yet to find an editor that i really like [22:12:26] (03CR) 10MaxSem: [C: 032] Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169039 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [22:12:40] (03CR) 10MaxSem: [C: 032] Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169040 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [22:12:48] * Deskana is looking at the iOS app code. [22:12:57] mhurd: I don't know how you even read this. [22:13:13] alright folks [22:13:16] g'night [22:13:18] phuedx: yeah programming editors is the ultimate yak shaving [22:13:24] yup yup [22:13:25] phuedx: gn [22:13:26] (03PS1) 10MaxSem: Fix edit section icon regression [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169233 (https://bugzilla.wikimedia.org/72484) [22:13:33] Deskana: haha the wierdness wears off in 6 months or so [22:13:35] joakino: might just switch to nano [22:13:36] gn from me too :P [22:13:42] ;) [22:13:43] (same timezone?) [22:13:44] Deskana: mhurd: the last time I tried to learn objective-c, I had the same reaction. [22:13:46] haha [22:14:01] FlorianSW: gmt! gmt! gmt! [22:14:07] I had to do a web search for how to concatenate two strings. [22:14:11] And I got about five different answers. [22:14:15] What a language. [22:14:30] phuedx: pah, gmt+1 :D [22:14:33] :D [22:14:39] Deskana: what an internet ;) [22:14:41] Deskana, was the shortest one 10 lines long? [22:15:47] (03CR) 10Bmansurov: EditorApi: Check for sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [22:16:11] (03CR) 10MaxSem: [C: 032] Fix edit section icon regression [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169233 (https://bugzilla.wikimedia.org/72484) (owner: 10MaxSem) [22:16:49] (03Merged) 10jenkins-bot: Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169039 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [22:16:53] (03Merged) 10jenkins-bot: Fix missing edit preview [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/169040 (https://bugzilla.wikimedia.org/72522) (owner: 10Florianschmidtwelzow) [22:16:58] (03Merged) 10jenkins-bot: Fix edit section icon regression [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169233 (https://bugzilla.wikimedia.org/72484) (owner: 10MaxSem) [22:21:13] kaldari|2: also https://gerrit.wikimedia.org/r/#/c/168724/ [22:21:28] (03PS2) 10Jdlrobson: Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 [22:22:05] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [22:22:41] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169217 (owner: 10BearND) [22:23:03] (03CR) 10Jdlrobson: [C: 04-2] "If we are doing this we should just use ResourceLoaderUserModule and update that to have a concept of targets." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [22:24:53] 3MobileFrontend / 3stable: Regression: Section edit links always show as locked - 10https://bugzilla.wikimedia.org/72484 (10Ryan Kaldari) 5PATC>3RESO/FIX [22:24:58] (03CR) 10Jdlrobson: [C: 032] Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [22:25:35] (03Merged) 10jenkins-bot: Fix useless tag in editor preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169038 (owner: 10Florianschmidtwelzow) [22:26:14] dbrant, bearND|brb, mhurd, kristenlans: Email sent out. Product ownership of SUL officially transferred to Keegan as of this moment. :) [22:26:27] Deskana: yay! [22:26:30] :) [22:26:30] (03CR) 10Florianschmidtwelzow: EditorApi: Check for sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [22:26:37] Deskana: alright!! [22:26:44] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Notice for me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [22:26:46] * kristenlans raises virtual champagne glass to Deskana [22:26:48] YOU ARE WELCOME :P [22:26:59] Keegan: Thank you, my friend. :) [22:27:07] HAHAHAHAHA SUCKERRRRRR [22:27:10] * Deskana giggles. [22:27:11] haha [22:27:45] Like that's a secret ;) [22:28:08] (03CR) 10Jdlrobson: [C: 032] "Florian is awesome :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169211 (owner: 10Florianschmidtwelzow) [22:28:14] Keegan: I think we've got enough in place for this to be a success, and I'll still be around helping make sure it happens. :) [22:28:40] (03PS3) 10Jdlrobson: Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 [22:28:45] (03Merged) 10jenkins-bot: Add test for EditorOverlay preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169211 (owner: 10Florianschmidtwelzow) [22:28:57] (03PS1) 10Kaldari: Adding Florian to the MobileFrontend author list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169241 [22:29:04] (03CR) 10Dbrant: [C: 032] "wfm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169217 (owner: 10BearND) [22:29:08] (03CR) 10Jdlrobson: [C: 04-1] "needs a rebase :-S" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 (owner: 10Jhernandez) [22:29:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [22:30:11] (03CR) 10Jdlrobson: [C: 031] "\o/ definitely should do this :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169241 (owner: 10Kaldari) [22:31:05] (03CR) 10Jhernandez: [C: 032] Adding Florian to the MobileFrontend author list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169241 (owner: 10Kaldari) [22:31:41] (03Merged) 10jenkins-bot: Adding Florian to the MobileFrontend author list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169241 (owner: 10Kaldari) [22:34:00] tfinc2: 1:1? [22:34:18] (03CR) 10Aaron Schulz: [C: 031] Use MovePageIsValidMove hook if possible [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 (owner: 10Legoktm) [22:34:23] rmoen: i have none on my calendar [22:34:37] (03PS2) 10Jdlrobson: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [22:34:54] tfinc2: hmm it says you're invited [22:37:34] Deskana: do you have a second? [22:37:59] dbrant: does the android app download a file of css that has app specific settings? [22:38:23] rmoen: never made it to my calendar and i'm booked till 4:30. lets do it then [22:38:30] dbrant: *android* specific settings [22:38:49] mhurd: I don't believe there are any android-specific things in the CSS... [22:38:53] tfinc2: strange. ok, 4:30 will work [22:39:42] (03Abandoned) 10Jdlrobson: Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [22:39:53] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c6 (10Bahodir Mansurov) Chris, I've tried replicating the issue using Chrome and your instructions, but I'm able to successfully collapse and expand sections. What OS and Chrome version should I try? Than... [22:40:13] (03CR) 10Jdlrobson: [C: 031] Fix no-redirecting Cta in Edit-workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [22:40:16] mhurd: we just download the main CSS file, then a supplemental CSS file for Night mode. [22:40:21] (03CR) 10Florianschmidtwelzow: "Big thanks for this great change and beautiful words :) I'm going to bed with a big grin now :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169241 (owner: 10Kaldari) [22:40:40] dbrant: where’s the repo that builds the apps css? [22:41:42] mhurd: mediawiki/extensions/MobileApp [22:48:02] rmoen: looks like it was just moved on your calendar. thats why i never saw it [22:49:04] tfinc2: what is strange is it still says your cal. http://i.imgur.com/QA4jVE2.png which, was confusing [22:49:14] wacky [22:49:42] (03CR) 10Bmansurov: "I think we should add pagination not infinite scroll." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [22:49:56] well done jdlrobson, well done https://trello.com/b/oDLgJr8w/mobile-web-current-sprint-34-hitchhiker-s-guide-to-the-galaxy [22:50:42] kristenlans: jdlrobson should not be able to change my background :(( [22:51:24] uhoh bmansurov: is the white on white giving you a headache? [22:51:34] or just the principle? [22:51:46] kristenlans: yes, i'm bleeding from my eyes [22:51:55] bmansurov: lol [22:52:11] kristenlans: seriously though white and white don't match well [22:52:47] bmansurov: yeah, I agree, groundhog day had a better contrast [22:53:15] kristenlans: i wonder what happens if I change the background myself, I hope it only affects me [22:53:39] (03CR) 10Florianschmidtwelzow: "The inline comment is a hygiene task, so can be done in a seperate patchset, so if someone wants to merge :P" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [22:54:10] bmansurov: give it a try, there are a few options we could try here too https://commons.wikimedia.org/w/index.php?search=hitchhikers+guide&title=Special%3ASearch&go=Go [22:54:28] kristenlans: did your background change too? [22:54:45] bmansurov: yep, grey now [22:54:59] kristenlans: sorry, i don't have the original background [22:55:24] bmansurov: haha uhoh, we need to revert ;-) [22:57:17] dbrant: thanks! turns out the issue i was seeing (go to “East Lothian” on a tablet and there’s a big gray area to the right of the infobox) is a know issue with mobile css [22:57:36] mhurd: i see! [22:57:41] kristenlans: I think only jdlrobson can do so, he has trello gold. [22:58:00] dbrant: dan is filing a bug. kaldari said they could make that gray transparent so it would look a bit less weird [22:58:26] bmansurov: yes, I think you’re right. Just poke him when he gets back. We can urge him to find more contarsty background :D [22:58:37] ok [22:58:52] dbrant: i was so confused. i thought i caused it or there was some ios less file being used by MobileApp extension putting weirdness in the css file :) [22:59:04] ha! [22:59:59] Haha [23:00:03] https://bug-attachment.wikimedia.org/attachment.cgi?id=16918 [23:00:07] USE THE MENU BUTTON ON THE TOP RIGHT [23:00:09] I COMMAND YOU [23:00:11] LOOK AT IT [23:00:13] I'M POINTING AT IT [23:01:35] Deskana: it's actually pointing to the space between search and menu icons haha [23:05:28] 3MobileFrontend / 3General/Unknown: MobileFrontend: Infoboxes should not have grey panels floating to the right of them - 10https://bugzilla.wikimedia.org/72596#c2 (10Dan Garry) Sorry for the blank original comment, I accidentally hit submit too early. :-) See attachment 16919 for the bug. That weird grey p... [23:05:29] 3MobileFrontend / 3General/Unknown: MobileFrontend: Infoboxes should not have grey panels floating to the right of them - 10https://bugzilla.wikimedia.org/72596#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/klKG8I18 [23:05:31] 3MobileFrontend / 3alpha: Language selectors looks out of place in alpha login page - 10https://bugzilla.wikimedia.org/72597#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/MymsQ4Ns [23:05:32] 3MobileFrontend / 3General/Unknown: MobileFrontend: Infoboxes should not have grey panels floating to the right of them - 10https://bugzilla.wikimedia.org/72596#c1 (10Dan Garry) Created attachment 16919 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16919&action=edit Weird grey panel floating to the... [23:05:34] 3MobileFrontend / 3alpha: Language selectors looks out of place in alpha login page - 10https://bugzilla.wikimedia.org/72597 (10Florian) 3NEW p:3Unprio s:3minor a:3None Created attachment 16920 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16920&action=edit alpha login page See image. The l... [23:09:25] 3Wikipedia App / 3Android App: ToC tutorial screen not dismissable. - 10https://bugzilla.wikimedia.org/72595 (10Dmitry Brant) 3NEW p:3Unprio s:3critic a:3None Created attachment 16918 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16918&action=edit how it looks on my tablet. On one of my tab... [23:15:52] 3MobileFrontend / 3alpha: Language selectors looks out of place in alpha login page - 10https://bugzilla.wikimedia.org/72597#c2 (10Jon) 5NEW>3RESO/INV Yeh this is a result of trying to repurpose the desktop login form in alpha. I've added this to acceptance criteria in https://trello.com/c/jt1O10K2/16-us... [23:18:37] 3MobileFrontend / 3General/Unknown: MobileFrontend: Infoboxes should not have grey panels floating to the right of them - 10https://bugzilla.wikimedia.org/72596#c4 (10Jon) 5NEW>3RESO/INV Infoboxes are templates. The grey background is a result of a hack trying to make large infoboxes scrollable (we canno... [23:19:16] kristenlans: why is everything in "In analysis" shouldn't it be in ready for dev [23:19:34] dbrant: Doing a bit of testing of the app on my Nexus 7 today and I found one or two strange things. [23:19:46] jdlrobson: true story bro! [23:19:52] Deskana: do tell [23:19:55] great story great story [23:20:12] dbrant: With the new search stuff, the top of the buttons is sliced off. [23:20:29] jdlrobson: fixed [23:20:50] jdlrobson: thanks for the poke :-) [23:20:58] :) [23:21:12] Deskana: pics, or didn't happen! [23:21:22] dbrant: I want to see if I can fix it myself first. ;-) [23:22:07] dbrant: If this doesn't fix it, I'll send documentary evidence. [23:22:34] Cool, that made it worse. [23:24:07] kristenlans: also seems that some cards went awol e.g. templates in core [23:24:39] jdlrobson: moving them from groundhog day right now, you’re too quick for me! [23:24:40] jdlrobson: https://gerrit.wikimedia.org/r/#/c/168718/1/dev-scripts/pre-commit hey wouldn't the git add fuck up if you are adding just some parts of the file for commiting? [23:25:02] kristenlans: i wish my internet connection in this cafe was as quick [23:25:42] jdlrobson: I was originally going to just extend ResourceLoaderUserModule, but it would have required also modifying the Skin code to let skins opt out of User:X:common files, which is a weird thing to add just for 1 skin. [23:26:26] kaldari|2: it adds User common files too? [23:26:29] mmmm [23:26:49] i wouldn't be against that. Might encourage people to fix their gadgets [23:26:51] ResourceLoaderUserModule::getPages() does, yes. [23:26:55] kaldari|2: what do you think, should I just move this in to Hitchhiker’s? I was going to wait until the end of the day to see what it’s fate was, but my day is coming to an end ;-) https://trello.com/c/I0FGO8hF/17-13-rewrite-wikigrok-backend-data-consumption [23:27:57] dbrant: http://i.imgur.com/VJkMWk4.png [23:28:19] jdlrobson: if you think that makes sense, it would definitely simplify things [23:28:31] kaldari|2: yeh check with maryana [23:28:34] i'd expect some explosions [23:28:38] but these would be valuable explosions [23:28:48] would force people to rethink their gadgets on mobile [23:28:49] dbrant: That also exposes the other issue... isn't that search bar a bit narrow considering the width of the screen? [23:28:51] as long as that doesn't leak into the global namespace [23:29:05] kaldari|2: also did you see italian wikipedia want to enable anon editing? [23:29:08] kristenlans: Yeah, move it over. I haven't been able to get in touch with csteipp today :( [23:29:09] Deskana: oh, *those* buttons! hmm, we are indeed hard-coding the expected height of the ActionBar, and it looks like yours is thicker than expected. [23:29:24] [that's what she said] [23:29:25] I'm cool with that but a bit scared about whether are code is good enough and worried we might end up firefighting stuff for them. [23:29:33] kaldari|2: will do, thanks :-) [23:30:04] rmoen: any objections to be simply cleaning up all our documentation? [23:30:08] i have an hour free ;-) [23:30:29] jdlrobson: no objections, that's what i'm working on [23:30:48] Deskana: i'm aware of the other issue, too... it's trickier than one might think. [23:30:55] rmoen: oh you are ? It was in ready for dev so i didn't think you started working on it [23:31:02] i'll move it into in dev then and let you do it [23:31:22] dbrant: I can imagine. I went rooting around in the code and couldn't find anything that would control that. [23:31:37] jdlrobson: I imagine the biggest problem would be people's user scripts causing JS errors for them on mobile and not loading other JS, but there is always a simple solution: move the scripts to user:vector.js or user:monobook.js. [23:31:38] dbrant: Probably because we're using a built-in component that's not really designed to be tweaked? [23:31:43] tfinc2: https://plus.google.com/hangouts/_/wikimedia.org/rmoen-tfinc?authuser=0 [23:32:16] Deskana: yep... [23:32:45] jdlrobson: this is good for me because i'm learning more about classes [23:32:47] dbrant: Well, whatever. Bigger fish to fry than the width of the bar. [23:33:01] dbrant: The slicing though, can we be a bit more intelligent about that? [23:33:22] rmoen: check out https://gerrit.wikimedia.org/r/#/c/169234/3 btw [23:33:24] (03PS2) 10Jhernandez: Tools: JS beautify code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 [23:33:28] that will clean up a bunch of them [23:33:33] Deskana: i do believe so. it's on my checklist of items to look at. [23:34:41] jdlrobson: If we went down that road, I would want to announce the change publicly so that people have a chance to move their scripts from common.js beforehand. [23:34:42] Cool. [23:34:57] dbrant: There's also a glitch with Nearby's loading indicator. [23:35:06] Go to Nearby and hit refresh after it's loaded. [23:35:10] kaldari|2: Nah. Give them 2 weeks notice. [23:35:14] The loading indicator appears on top of the items. [23:35:16] (This isn't a tablet bug) [23:35:18] people fix broken things quicker. [23:35:39] Deskana: we were planning to switch to using the linear progress bar (inside the actionbar) for that. [23:36:15] dbrant: In light of Lollipop's new bar not having that, is that wise? :) [23:36:44] Deskana: well, I was hoping to roll all of this into a card :) [23:36:46] (03CR) 10Jhernandez: "Done" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 (owner: 10Jhernandez) [23:38:46] dbrant: Do you want to write that then? :) [23:39:21] Deskana: yep! I'll add it. [23:43:53] (03PS4) 10Jdlrobson: Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 [23:45:28] bmansurov: u still here? [23:45:31] kaldari|2: do you think during the next scrum of scrums you could moan about https://bugzilla.wikimedia.org/show_bug.cgi?id=64374 ? [23:45:37] joakino: yes [23:45:54] bmansurov: do we abandon the idea of restoring scroll position? [23:46:21] (03PS1) 10Dbrant: Fix dismissability of ToC tutorial on certain screens. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169267 (https://bugzilla.wikimedia.org/72595) [23:46:21] joakino: I think it depends on how we are using hashes in URL. [23:46:58] joakino: does the Nearby page rely on having coordinates in the location hash? [23:46:58] jdlrobson: as far as publishing it, see https://trello.com/c/z20ly9Su/32-add-mobilefrontend-to-https-doc-wikimedia-org [23:47:03] bmansurov: with that last merge hashes are now for routing, so we can't use them for the scrolling [23:47:17] joakino: I see [23:47:30] joakino: maybe jdlrobson has an idea [23:47:43] bmansurov: it has 3 routes, default is geolocation, #/coords/lat,lon and #/page/page-title [23:48:08] (03PS1) 10Dr0ptp4kt: Make zero-rating dialog and inspection less intrusive [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169269 [23:48:28] bmansurov: jdlrobson: it wasn't working before this commits so can probably let it be for the moment [23:48:34] joakino: can we change the last to and include the scroll position? [23:48:50] to -> two [23:49:12] (03CR) 10Dbrant: "BearND, do you recall the rationale for having separate dimensions for h480dp? And is there anything wrong with not having them?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169267 (https://bugzilla.wikimedia.org/72595) (owner: 10Dbrant) [23:49:22] kaldari|2: we will need help from platform [23:49:41] bmansurov: you want me to take over that card? I know that code pretty well... [23:49:43] jdlrobson: I have no idea what the procedure for that is, though. MaxSem might know more about it. Hey MaxSem, who do we poke about getting our JSduck output published to docs.wikimedia.org? [23:49:54] kaldari|2: we can use the gruntfile now [23:50:00] jdlrobson: ok [23:50:01] we just need to lock krinkle in a room :) [23:50:02] hashar? :P [23:50:07] or hashar yeh [23:50:14] kaldari|2: VisualEditor do it post build [23:50:50] too bad hashar is never available. guess I'll email him [23:52:19] bmansurov: we could probably do something like that for all 3 routes [23:52:50] joakino: yes I think that's what we should do. I think jdlrobson is taking over the card [23:52:56] did any mobile web people get a moment to take a look at https://en.m.wikipedia.org/wiki/Plancks_constant ? [23:53:14] (it looks fine on my desktop but not phone) [23:53:30] jdlrobson: Do we have a JSDuck config file in our repo now? [23:53:33] jdlrobson: how do I enable debug for javascript files? [23:53:47] bmansurov: ok! [23:53:56] kaldari|2: not yet but with a bit of handholding that should be easy to setup [23:56:33] ?debug=true bmansurov [23:56:48] jdlrobson: where? [23:56:50] Krenair: context? [23:56:59] bmansurov: just apply it to the url [23:57:05] ok thanks [23:57:21] Krenair: oh i think that's the issue with the Math extension? [23:57:50] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=72165 ?