[00:00:39] jdlrobson, it pretty much displays no content on my phone [00:01:59] Krenair: look fine on my phone (mobile safari). What are you using? [00:02:23] chrome on android [00:04:51] Krenair: Will check as soon as my android is charged up... [00:06:06] kaldari|2, jdlrobson: https://dl.dropboxusercontent.com/u/10971457/Wikimedia/Screenshot_2014-10-28-00-03-10-184.png [00:06:30] Krenair: wow [00:06:44] that's pretty broken :P [00:07:03] someone else brought this to my attention, so it's obviously not just me [00:07:17] (03CR) 10Jdlrobson: [C: 032] "Single quotes and onevar are not beautified but this is a step in the right direction" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 (owner: 10Jhernandez) [00:07:28] Krenair: that's super weird [00:07:51] (03Merged) 10jenkins-bot: Tools: JS beautify code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 (owner: 10Jhernandez) [00:08:12] (03CR) 10Jhernandez: "For those for the moment we will have to rely on jscs" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 (owner: 10Jhernandez) [00:08:35] i can replicate on firefox.. [00:08:48] i wonder if this is related to the outpagePage deprecation kaldari|2? [00:09:04] wtf it's back again.. [00:09:37] i can't replicate any more [00:10:20] (03Abandoned) 10Jdlrobson: Allow overriding Nearby coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) (owner: 10MaxSem) [00:17:24] bmansurov: in terms of https://gerrit.wikimedia.org/r/#/c/148363/2/javascripts/modules/toggling/toggle.js let's just do what thedj suggests and remove the role [00:17:38] this patch is taking far too long to fix [00:20:10] (03PS3) 10Bmansurov: Remove role 'button' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [00:22:51] (03PS2) 10Dr0ptp4kt: Make zero-rating dialog and inspection less intrusive [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169269 [00:28:58] Deskana: http://www.touchstoneclimbing.com/first-timers [00:43:53] (03PS1) 10Jhernandez: Add qunit and file watching support with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169292 [00:44:44] (03CR) 10jenkins-bot: [V: 04-1] Add qunit and file watching support with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169292 (owner: 10Jhernandez) [00:49:41] (03PS2) 10Jhernandez: Add qunit and file watching support with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169292 [00:56:01] (03PS1) 10Jhernandez: Fix make task [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169299 [01:03:23] (03PS2) 10Jhernandez: Fix make task [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169299 [01:07:28] (03PS1) 10Jhernandez: Beautified all the files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169302 [01:10:59] (03CR) 10MaxSem: [C: 04-1] Beautified all the files (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169302 (owner: 10Jhernandez) [01:17:01] (03CR) 10Kaldari: [C: 032] Fix make task [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169299 (owner: 10Jhernandez) [01:17:34] (03Merged) 10jenkins-bot: Fix make task [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169299 (owner: 10Jhernandez) [01:17:37] (03CR) 10MaxSem: Beautified all the files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169302 (owner: 10Jhernandez) [01:22:43] (03PS1) 10Jhernandez: Disable beautify on pre-commit hook for now. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169304 [01:23:37] (03CR) 10Kaldari: [C: 032] Disable beautify on pre-commit hook for now. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169304 (owner: 10Jhernandez) [01:24:10] (03Merged) 10jenkins-bot: Disable beautify on pre-commit hook for now. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169304 (owner: 10Jhernandez) [01:31:59] (03PS1) 10Mhurd: Change "Credits" to "About". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169305 [04:01:36] (03CR) 10Jdlrobson: [C: 031] Remove role 'button' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [04:30:46] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 (owner: 10Dbrant) [05:23:16] (03PS1) 10Deskana: Change ActionBar search text every time a "Did you mean" query is run. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169319 [05:28:40] 3Wikipedia App / 3Android App: Android app: Changing to night mode while searching cancels the search - 10https://bugzilla.wikimedia.org/72604 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Changing to night mode while searching cancels the search. It shouldn't. :-) [05:44:55] 3Wikipedia App / 3Android App: Android app: Overflow menu items relating to pages should not be usable during search - 10https://bugzilla.wikimedia.org/72605 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None If you're searching there are lots of overflow menu options available: * Clear recent searches... [06:57:47] (03PS3) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) [07:07:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix no-redirecting Cta in Edit-workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [07:18:43] (03PS4) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) [07:19:18] (03CR) 10jenkins-bot: [V: 04-1] Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [07:27:21] (03CR) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [07:34:56] 3Wikipedia App / 3iOS App: iOS app: the strings for the About screen are not translatable - 10https://bugzilla.wikimedia.org/72607 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None The strings for the about screen are not translatable. These are strings such as "About the Wikipedia app" "contribu... [07:35:07] 3Wikipedia App / 3iOS App: iOS app: the strings for the About screen are not translatable - 10https://bugzilla.wikimedia.org/72607 (10Amir E. Aharoni) [07:35:22] 3Wikipedia App / 3iOS App: iOS app: Credits screen needs improvement - 10https://bugzilla.wikimedia.org/64391 (10Amir E. Aharoni) [07:38:39] 3Wikipedia App / 3iOS App: iOS app: contributors and libraries lists in the credits screen must be forced to LTR direction - 10https://bugzilla.wikimedia.org/72608 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None In the credits/about screen in the iOS app there are lists of contributors and libra... [08:29:25] 3MobileFrontend / 3stable: VisualEditor edit summary is not saved - 10https://bugzilla.wikimedia.org/72612 (10Florian) 3NEW p:3Unprio s:3normal a:3None Example: https://www.mediawiki.org/w/index.php?title=Project%3ASandbox&diff=1242918&oldid=1242833 Summary input: "Test". The summary was not saved. [08:30:22] 3MobileFrontend / 3stable: VisualEditor edit summary is not saved - 10https://bugzilla.wikimedia.org/72612#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9UaadG2M [08:37:26] (03PS5) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) [08:58:10] (03PS4) 10Florianschmidtwelzow: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) [08:59:09] (03PS5) 10Florianschmidtwelzow: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) [12:01:09] (03CR) 10Florianschmidtwelzow: [C: 031] Remove role 'button' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [12:23:25] 3MobileFrontend / 3alpha: mw-ui-icon causes strange problem in Firefox - 10https://bugzilla.wikimedia.org/72620 (10Florian) 3NEW p:3Unprio s:3critic a:3None Created attachment 16926 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16926&action=edit mw-ui-icon in FF 24 It's difficult to describ... [12:24:52] 3MobileFrontend / 3alpha: mw-ui-icon causes strange problem in Firefox - 10https://bugzilla.wikimedia.org/72620#c1 (10Florian) 5NEW>3UNCO s:5critic>3major Setting to unconfirmed, bc i don't know, which browsers maybe have the same problem or if it is a special thing of FF. [12:25:09] 3MobileFrontend / 3Feature requests: Lots of background images not using data URI embedding - 10https://bugzilla.wikimedia.org/64101 (10Florian) [12:25:09] 3MobileFrontend / 3Hygiene: MobileFrontend should use mw-ui-icon in beta - 10https://bugzilla.wikimedia.org/71181 (10Florian) [12:25:09] 3MobileFrontend / 3alpha: mw-ui-icon causes strange problem in Firefox - 10https://bugzilla.wikimedia.org/72620 (10Florian) [12:25:22] 3MobileFrontend / 3alpha: mw-ui-icon causes strange problem in Firefox - 10https://bugzilla.wikimedia.org/72620#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/68iikLSK [12:25:28] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [12:42:24] 3Wikipedia App / 3Android App: Allow easier change of default language of Wikipedia - 10https://bugzilla.wikimedia.org/71136#c3 (10Alex Monk) IIRC, some users instead suggested allowing searching multiple languages at the same time... [13:36:37] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c7 (10Chris H-C) I was running Chrome 38 on Linux Mint 16. Ah-ha, there's a trick! Look for a line like "if ('ontouchstart' in window) {" Basically, if there's touch, listen for touch. If there isn't t... [14:40:52] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c8 (10Jon) We do fall back to click. I'm pretty sure this was working in desktop IE8 which is what I find so strange. Will take a closer look today. I'd rather we used a real device to debug this one Bah... [15:27:36] (03CR) 10BearND: "The values in the default dimens.xml were for small devices where I had to shrink the image; whereas the h480 dimens were for making the i" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169267 (https://bugzilla.wikimedia.org/72595) (owner: 10Dbrant) [15:32:24] (03PS1) 10Dbrant: Don't expose fragment-specific action items when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169507 (https://bugzilla.wikimedia.org/72605) [15:35:37] 3Wikipedia App / 3Android App: Android app: Overflow menu items relating to pages should not be usable during search - 10https://bugzilla.wikimedia.org/72605#c2 (10Bernd Sitzmann) I think only the first should be visible. Then you don't run into https://bugzilla.wikimedia.org/show_bug.cgi?id=72604. [15:36:59] bearND: I have a couple of small devices (with 2.3, one mdpi and one ldpi), and the onboarding image looks just fine on them without resizing... [15:41:42] bearND: pardon, one hdpi and one mdpi [15:47:43] dbrant: density doesn't matter here since we use dp. I looked at the smallest prepared device i could find in the layout preview: the 2.7" QVGA under generic devices [15:47:58] it seems that those are busted as well [15:48:06] haven't tried your patch yet [15:56:22] 3Wikipedia App / 3Android App: Android app: Overflow menu items relating to pages should not be usable during search - 10https://bugzilla.wikimedia.org/72605#c3 (10Dan Garry) (In reply to Bernd Sitzmann from comment #2) > I think only the first should be visible. Then you don't run into > https://bugzilla.wi... [16:03:03] (03PS1) 10Florianschmidtwelzow: Hygiene: Fix typo in CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169513 [16:09:52] 3MobileFrontend / 3alpha: mw-ui-icon causes strange problem in Firefox - 10https://bugzilla.wikimedia.org/72620#c3 (10Jon) Woooww! Giant hamburger. Not sure what's going on here. Can't reproduce myself.. [16:10:07] 3MobileFrontend / 3alpha: Giant hamburger takes over screen on Firefox - 10https://bugzilla.wikimedia.org/72620 (10Jon) [16:18:53] dbrant: one more thing about the toc_intro layout: try it in landscape mode of a skinny device [16:28:18] Maryana kaldari|2: I’m a duolingo maniac now!!! [16:28:26] niiice [16:28:44] kristenlans: what's yr username? [16:28:54] KristenLans [16:29:22] bearND: ugh :( so, what can we do about it? [16:29:49] kristenlans: tu entends francais? [16:30:07] oh man, i don't even know if that was right [16:30:14] i need to brush up on my francais [16:31:00] Je parle francais, j’ecris francais, et je lis francais! [16:31:31] Maryana: I think you said do you hear french. WHich is technically a thing ;-) [16:31:45] what is "understand" again? [16:31:49] i thought it was entendre [16:31:55] it's been awhile ;) [16:36:08] bearND: put it in a ScrollView? [16:38:58] dbrant: what kind of tablet do you reproduce the bug you filed? [16:39:02] with [16:39:52] bearND: it's Acer A500 [16:40:03] 4.1.2 [16:42:40] dbrant: i can try a few things later, just want to finish up another bug [16:42:49] bearND: ok, sure [16:51:08] 3MobileFrontend / 3alpha: Giant hamburger takes over screen on Firefox - 10https://bugzilla.wikimedia.org/72620#c4 (10Florian) 5UNCO>3RESO/WOR Can't reproduce in Chrome (actual version, mobile and desktop) and not in HTC Stock Browser. Reproduced on: Firefox 25 - 29 (29 only debian) All versions after... [16:56:14] (03PS13) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [17:06:10] 3Wikipedia App / 3Android App: Search icon invisible in dark mode - 10https://bugzilla.wikimedia.org/72630 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1: Switch to dark mode. 2: Restart app. 3: Observe that the search icon is invisible because it dark gray on dark gray bac... [17:06:39] dbrant: got a fix for ^ [17:08:11] (03PS1) 10BearND: Avoid invisible search icon in dark mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169527 (https://bugzilla.wikimedia.org/72630) [17:09:21] (03CR) 10Jhernandez: Beautified all the files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169302 (owner: 10Jhernandez) [17:10:12] kristenlans: I'm kaldari if you want to follow on Duolingo :) [17:16:05] bearND: i can't seem to reproduce... what do you mean by restart the app? [17:16:25] dbrant: restart it from the IDE [17:16:36] brion: refactored the iOS “Credits” page to look like the excellent Android “About” page: https://gerrit.wikimedia.org/r/#/c/169305/ [17:16:40] \o/ [17:19:42] brion: i pulled all the “About” urls/names into a plist file. not sure why i haven’t done this before… :) [17:19:52] oh handy :D [17:20:40] jdlrobson: Looks like PHP has a function to do exactly what you suggested: preg_grep() [17:20:55] 3MobileFrontend / 3alpha: WikiGrok v. B tags shouldn't be centered & nationality missing - 10https://bugzilla.wikimedia.org/72631 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Created attachment 16929 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16929&action=edit wikigrok v. b on bet... [17:20:57] kaldari|2: \o/ [17:20:58] what a great function name [17:21:02] php!! [17:21:04] FTW! :P [17:21:45] FlorianSW: this made me laugh today https://bug-attachment.wikimedia.org/attachment.cgi?id=16926 [17:21:48] such a big hamburger [17:21:58] i suspect it was a caching issue [17:22:53] 3Wikipedia App / 3Android App: Search icon invisible in dark mode - 10https://bugzilla.wikimedia.org/72630#c2 (10Dan Garry) Thank you! :-D I noticed this myself briefly last night, but was unable to reproduce it afterwards so convinced myself I must've been imagining it... [17:22:56] jdlrobson: Yeah, first i haven't seen, that it is the hamburger icon :P must laugh as i read your comment :D [17:23:04] :D [17:23:06] Haha [17:23:09] That's incredible [17:23:11] huggeee hamburger [17:23:13] USE THE MENU [17:23:17] jdlrobson: still can reproduce on firefox versions earlier then 29 (local and beta labs) [17:23:30] bearND: still can't reproduce... but: since those icons are "global" to PageActivity, wouldn't it make more sense to adjust them in prepareOptionsMenu of PageActivity, instead of PageViewFragment? [17:23:44] (03PS2) 10Jdlrobson: Hygiene: Fix typo in CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169513 (owner: 10Florianschmidtwelzow) [17:23:47] dbrant: Are you talking about the search icon in night mode thing? [17:23:51] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix typo in CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169513 (owner: 10Florianschmidtwelzow) [17:23:58] Deskana: yes; i can't reproduce it [17:24:18] Deskana: maybe the hamburger wasn't clicked enough, so he thought "if i'm is much bigger, much more will click me" :D [17:24:31] (03Merged) 10jenkins-bot: Hygiene: Fix typo in CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169513 (owner: 10Florianschmidtwelzow) [17:24:41] (03CR) 10Brion VIBBER: "couple quick notes about doctype and a translation comment" (035 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169305 (owner: 10Mhurd) [17:24:57] dbrant: I actually managed to do it myself last night. [17:25:03] dbrant: I just wasn't able to do it again afterwards... [17:25:23] (03CR) 10Jdlrobson: [C: 032] "The DJ advised just this so this should be fine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [17:25:23] 3MobileFrontend / 3alpha: WikiGrok v. B tags shouldn't be centered & nationality missing - 10https://bugzilla.wikimedia.org/72631#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/g1K3cKhO [17:25:38] brion: cool! amending [17:27:46] (03CR) 10Jdlrobson: [C: 04-1] EditorApi: Check for sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [17:27:49] dbrant: hmm, i can reproduce it quite regularly now. Whenever I start the app using run or debug from the IDE (while in dark mode) I get it right away. Before I got it when switching to another app and coming back. [17:28:47] (03CR) 10Jhernandez: [C: 031] Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [17:29:49] dbrant: first I thought it had to do with doing something while the SearchView was open but later I found that it was happening more often than that. I'm trying to move the adjustments to PageActivity [17:31:13] (03Merged) 10jenkins-bot: Remove role 'button' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [17:34:52] dbrant: I can move it even to PageActivity.onCreateOptionsMenu [17:35:09] bearND: sure, if that works [17:35:17] legoktm: if you can hear me i can't hear you [17:35:48] (03PS2) 10BearND: Avoid invisible search icon in dark mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169527 (https://bugzilla.wikimedia.org/72630) [17:37:47] bearND: so, that fixes it for you, then? [17:37:48] Heading to the office! See you soon. [17:37:56] legoktm: i had my suspicions that was the case :) [17:37:58] dbrant: yes [17:38:03] :P [17:38:37] dbrant, how do you pull the latest copy of java-mwapi so its taken into account while building wikipedia android? [17:39:00] so I get the change to onHeaderCheck [17:39:09] and it stops failing to build WikipediaZeroHandler [17:39:12] (03CR) 10Jdlrobson: [C: 032] Add qunit and file watching support with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169292 (owner: 10Jhernandez) [17:40:33] (03CR) 10Dbrant: [C: 032] Avoid invisible search icon in dark mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169527 (https://bugzilla.wikimedia.org/72630) (owner: 10BearND) [17:41:22] Krenair: first, rm -rf ~/.m2/repository/org/mediawiki/api [17:41:28] Krenair: then: ./gradlew --refresh-dependencies [17:41:49] (03Merged) 10jenkins-bot: Add qunit and file watching support with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169292 (owner: 10Jhernandez) [17:42:12] Krenair: also, in Android Studio, refresh the Gradle tasks (click the "refresh" button in the Gradle window). [17:43:17] (03PS2) 10Mhurd: Change "Credits" to "About". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169305 [17:43:23] brion: ^ done :) [17:43:34] Krenair: we should have bumped the version number of the java-mwapi file :( that would have avoided this annoyance [17:44:08] mhurd: great lemme test real quick [17:45:16] dbrant, ok, thanks [17:45:18] (03CR) 10Jdlrobson: [C: 04-1] "Clicking edit when not logged in on stable seems to have no effect anymore." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [17:45:24] seems to have worked [17:46:36] (03CR) 10Jdlrobson: Fix no-redirecting Cta in Edit-workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [17:49:00] dbrant, why do HistoryEntryPersistanceHelper.getPrimaryKeySelection and HistoryEntryPersistanceHelper.getPrimaryKeySelectionArgs throw "No Primary Keys make sense for History"? [17:49:55] (03CR) 10Brion VIBBER: [C: 032] "Love it!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169305 (owner: 10Mhurd) [17:50:05] brion: woohoo! :) [17:51:11] bearND: hey [17:51:29] mhurd: hola [17:52:25] MaxSem: Your user agent is: BlackBerry8900/4.6.1.199 Profile/MIDP-2.0 Configuration/CLDC-1.1 VendorID/302 [17:52:30] bearND: new strings for translation in the ios app :) we changed the credits page to be an about page like the android about page [17:52:52] mhurd: cool. I'll sync [17:52:59] bearND: thanks! [17:54:41] bearND: dbrant great job on the about page by the way! [17:55:15] (03CR) 10Krinkle: ".jscs.json has been deprecated for a while now. Rename to jscsrc and drop the options.config declaration." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [17:56:07] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c9 (10Jon) 5UNCO>3NEW I've checked on version 4 (8900) and version 6 (9800) and am not seeing the issue. The version 4 doesn't run JavaScript from Wikipedia and the 9800 has touch support. I can rep... [17:56:22] (03PS3) 10Mhurd: Make zero-rating dialog and inspection less intrusive [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169269 (owner: 10Dr0ptp4kt) [17:59:58] (03CR) 10Krinkle: Setup Gruntfile to run jshint and jscs (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [18:03:11] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169269 (owner: 10Dr0ptp4kt) [18:04:51] (03PS6) 10Florianschmidtwelzow: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) [18:05:07] rmoen: jdlrobson: Can you follow-up Gruntfile in MF/ [18:05:26] Should prolly also move some of those deps to devDeps [18:05:27] mhurd: thx [18:05:34] (03CR) 10jenkins-bot: [V: 04-1] EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [18:06:25] (03PS5) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 [18:06:52] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c10 (10Jon) Can't replicate in IE9 though. [18:07:00] (03CR) 10jenkins-bot: [V: 04-1] Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [18:07:38] (03PS7) 10Florianschmidtwelzow: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) [18:09:29] Krinkle: yes. Thanks for comments [18:10:33] Krinkle: I assume that means you saw my mail? I'm really keen to get this setup. [18:10:39] Also is there any reason why core doesn't have a Gruntfile? [18:12:09] bearND, , why do HistoryEntryPersistanceHelper.getPrimaryKeySelection and HistoryEntryPersistanceHelper.getPrimaryKeySelectionArgs throw "No Primary Keys make sense for History"? [18:13:28] (03PS6) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 [18:13:45] I made a patch to allow deletion of specific history entries (rather than delete all), but it relies on me changing those functions to work [18:14:29] Krenair: don't we already support per-entry deletion there? [18:14:32] press and hold... [18:15:32] YuviPanda, no, just saved pages as far as I could tell [18:15:38] YuviPanda: nope, only for saved pages [18:15:40] Maryana, anon editing patch has been deployed by Sam :P [18:15:42] oh, hmm [18:15:43] ok [18:15:51] (hence, my patch) [18:15:55] 3MobileFrontend / 3stable: Header styling issue with JavaScript disabled - 10https://bugzilla.wikimedia.org/72637 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16930 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16930&action=edit Replicated in Firefox with JS disabled I think... [18:16:52] YuviPanda, it currently has to copy some code from saved pages though :( [18:16:59] ah, hmm [18:17:08] :( [18:17:15] jdlrobson: turns out preg_grep is for searching values not keys, so it wasn't ideal to use, so I just put a simple for loop in. You can see both versions at https://gerrit.wikimedia.org/r/#/c/168815/5..6/includes/modules/MobileUserModule.php [18:17:15] I think I'll put it up for review first and we'll see [18:17:24] but I wondered about HistoryEntryPersistanceHelper.getPrimaryKeySelection [18:17:40] jdlrobson: lemme know if either of those looks like a good solution [18:18:07] Krenair: I supposed we never bothered to implement it because we didn't use it (until your patch) [18:18:16] ok [18:18:45] (03PS1) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [18:20:24] 3MobileFrontend / 3stable: Header styling issue with JavaScript disabled - 10https://bugzilla.wikimedia.org/72637#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/guJYIOhs [18:21:14] (03PS6) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) [18:22:14] jdlrobson: core does, it's had one for months [18:22:25] it's in tests/frontend for legacy reasons [18:22:37] and also because we don't want package.json in mediawiki-core root apparently. [18:23:01] (makes sense since it's not an npm package, it's less of an issue is lesser-visible projects I guess) [18:23:20] jdlrobson: core Jenkins builds have had -npm just like extensions. [18:23:42] jdlrobson: I don't know if -npm is enabled for MF (does Grunt get run from Jenkins?) but assuming it's passing, let me know if you need it enabled if not already. [18:23:56] (03PS1) 10Alex Monk: Allow the user to delete individual history entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169547 [18:24:26] whee now my firefox is breaking. that helps. :P [18:26:20] ok fixed, back to library fun [18:26:24] * brion pokes it with a stick [18:29:01] (03PS1) 10Robmoen: Gruntfile cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169548 [18:30:15] Krinkle: ^ [18:30:54] (03CR) 10Krinkle: Gruntfile cleanup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169548 (owner: 10Robmoen) [18:33:48] (03PS1) 10Reedy: Fix type hint [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169549 [18:34:05] (03PS14) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [18:35:53] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c11 (10Jon) Seems related to window.addEventListener on IE8 (guess we need to use attachEvent). Does BlackBerry 9900 support window.addEventListener ? Is it the same problem? I don't know much about the b... [18:36:06] Krinkle: it's currently not running on jenkins no - would be great if it did (non voting to start with) [18:36:50] 11:22 Krinkle: it's in tests/frontend for legacy reasons < that's not very visible :) I'd be keen to re-explore putting that in the root so it's more discoverable to newbies to the code [18:36:52] (03PS15) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [18:37:10] It's determinisitic and won't help you find regressions. I'd rather not add non-voting jobs. Just let me know when it's passing and I"ll add it [18:37:21] The local run is the same as on jenkins. [18:37:39] For incremental application you could disable a few style rules at first to make it passing. [18:39:54] MaxSem: csteipp says he can security review the extension tomorrow. Should I go ahead and merge your code anyway? [18:40:13] I guess:P [18:46:20] (03PS4) 10Dbrant: [WIP] experiments with face detection in lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 [18:49:54] 3MobileFrontend / 3beta: Type error when storing widgetOffset in EventLogging - 10https://bugzilla.wikimedia.org/72639 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None We set the type for the widgetOffset param to number, but it throws an error when we try to store a float: "Validation error against... [18:50:22] 3MobileFrontend / 3beta: Type error when storing widgetOffset in EventLogging - 10https://bugzilla.wikimedia.org/72639#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/x4WulHgm [18:52:37] 3MobileFrontend / 3alpha: WikiGrok v. B tags shouldn't be centered & nationality missing - 10https://bugzilla.wikimedia.org/72631#c2 (10Ryan Kaldari) I guess we need to make the tags smaller so that more than one can fit on a line. [18:52:38] kaldari|2: the file linked to in https://trello.com/c/q0HpIY8t/10-2-each-wikigrok-user-should-have-a-persistent-identifier has been removed from the gettingstarted extension repo. Do you think I should add similar code to the mobile frontend extension? [18:53:28] bmansurov: yes [18:53:34] ok [18:54:17] om nom lunchtimes [18:55:37] (03PS1) 10Jdlrobson: WIP: Get tap event to work without window.addEventListener [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169553 (https://bugzilla.wikimedia.org/72566) [18:57:16] bmansurov: Looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=72631... I vaguely remember a recent patch that changed how we generated the property labels for the tags, but I can't find it now. Do you know which patch that was? [18:58:41] kaldari|2: I think I do, let me look it up [18:58:53] 3Wikipedia App / 3iOS App: iOS app: the strings for the About screen are not translatable - 10https://bugzilla.wikimedia.org/72607#c1 (10Dan Garry) 5NEW>3RESO/WON Monte says that these should be translatable. They're new strings, so they just haven't been translated yet, thus they're defaulting to Englis... [18:59:07] 3Wikipedia App / 3iOS App: iOS app: the strings for the About screen are not translatable - 10https://bugzilla.wikimedia.org/72607 (10Dan Garry) 5RESO/WON>3RESO/WOR [18:59:12] mhurd: I closed that translation bug as WORKSFORME. I said that the strings are translatable, but they're just not actually translated yet. [18:59:22] mhurd: So they're just defaulting to English. [18:59:26] (03CR) 10Kaldari: [C: 032] Backend for picking questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 (owner: 10MaxSem) [18:59:36] Deskana: sounds good. yea confusing report… [18:59:36] kaldari|2: this? I043dd55134811199548fc34cdaac2b13e9e25922 [18:59:36] :] [18:59:50] (03CR) 10MaxSem: [C: 032] Fix type hint [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169549 (owner: 10Reedy) [19:00:05] (03CR) 10MaxSem: [V: 032] Fix type hint [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169549 (owner: 10Reedy) [19:00:13] bmansurov: Yeah, that's probably ut [19:00:15] it [19:01:23] 3MobileFrontend / 3alpha: WikiGrok v. B tags shouldn't be centered & nationality missing - 10https://bugzilla.wikimedia.org/72631#c3 (10Ryan Kaldari) The nationality problem may have been caused by https://gerrit.wikimedia.org/r/#/c/168695/ [19:05:22] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c13 (10Chris H-C) Since BlackBerry 6, BlackBerry devices ran a version of WebKit. addEventListener's just fine. The problem is the touch detector. I don't have the source, but Chrome prettifies it fairly... [19:10:11] (03PS16) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [19:13:41] (03CR) 10Aaron Schulz: [C: 04-1] Use MovePageIsValidMove hook if possible (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 (owner: 10Legoktm) [19:19:39] (03PS2) 10Legoktm: Use MovePageIsValidMove hook if possible [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 [19:20:03] (03CR) 10Legoktm: Use MovePageIsValidMove hook if possible (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 (owner: 10Legoktm) [19:25:10] (03PS1) 10Bmansurov: Add persistent anonymized WikiGrok user token [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169559 [19:26:03] (03CR) 10Aaron Schulz: [C: 032] Use MovePageIsValidMove hook if possible [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 (owner: 10Legoktm) [19:26:11] (03Merged) 10jenkins-bot: Use MovePageIsValidMove hook if possible [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169034 (owner: 10Legoktm) [19:29:37] 3MobileFrontend / 3stable: Accessibility of headers broken due to accessibility enhancements - 10https://bugzilla.wikimedia.org/68371 (10Jon) 5NEW>3RESO/FIX [19:32:13] (03Abandoned) 10Bmansurov: Restore scroll position on Special:Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [19:44:50] (03PS1) 10Yurik: ZeroPortal setRawResult lua mode [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 [19:45:49] dr0ptp4kt, ^ [19:46:40] (03CR) 10MaxSem: [C: 032 V: 032] Backend for picking questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 (owner: 10MaxSem) [19:55:28] (03PS1) 10Robmoen: Fix MF documentation part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) [19:55:37] (03CR) 10jenkins-bot: [V: 04-1] Fix MF documentation part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) (owner: 10Robmoen) [19:58:16] (03PS2) 10Robmoen: Fix MF documentation part 1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) [20:02:23] yurikR: is https://gerrit.wikimedia.org/r/169563 done done and ready for review? mind adding me and any others who should review to the reviewer's list if so? [20:02:30] DarTar: hi, you there? I'd like to get your opinion on this: https://trello.com/c/uM5hM9cR/40-3-wikigrok-error-logging [20:03:03] dr0ptp4kt, should be done, csteip and brion might want to take a look [20:03:41] bmansurov: looking [20:04:04] DarTar: thanks, I'd like to know how we should change the current schema [20:05:04] yurikR: thanks. depending on outcomes from regular partners engineering meeting in 25 minutes, may be able to look at it this afternoon [20:06:08] brion: heya! is there i work-in-progress branch i could peek at for the file system refactor? need some light lunch time reading :) [20:06:34] (03CR) 10Jhobs: [C: 031] "Tiny bit of documentation nitpicking." (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [20:06:53] mhurd: yeah lemme pull it up [20:07:25] mhurd: https://github.com/brion/apps-ios-wikipedia/tree/work-libs/MediaWikiKit <- i shoudl write up a readme too :D [20:07:42] brion: awesome! still down to give me tour tomorrow? [20:07:59] most of the data classes are meant to be semi-immutable, you fetch things in/out of a MWKArticleStore [20:08:06] or for global data on the base MWKDataStore [20:08:08] bmansurov: comments posted [20:08:13] which is initialized with our default document path etc [20:08:16] DarTar: thank you [20:08:30] brion: awesome! [20:08:39] i’m working on the image data stuff now, then i’ll finish up the “list-like” things (history, saved pages, and the image lists within the articles) [20:08:41] bmansurov: if you want to takje a first stab at the schema I can help review it [20:08:45] but i feel like it’s coming together pretty well :D [20:08:56] brion: sounds great! [20:09:05] DarTar: ok I will [20:09:32] (03CR) 10Yurik: ZeroPortal setRawResult lua mode (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [20:09:36] mhurd: the cute part is that most of the objects are using the same i/o schema for the mobileview JSON input and for their .plist storage on-device :D [20:10:22] but it’s sure handy to say [dict writeToFile:blah] [20:11:39] (03PS1) 10Jdlrobson: Restore the place on Nearby for back button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72566) [20:12:37] mhurd: oh and i’m planning to move some of the article state stuff into the history entries like scroll position [20:15:01] yurikR: I think you may have misunderstood my first comment on that patch. I simply meant a line that says "-- global mw_interface" or something similar [20:15:16] ah, ok [20:15:17] yurikR: Maybe it's just me, but I like documenting most globals so future readers aren't confused [20:16:30] yurikR: again, it's just nitpicking though so not really necessary [20:16:32] mhurd: has your mac been adding numbers to its hostname since you upgraded to 10.10? mine is and it’s driving me nuts. apparently some bug with the mdns/bonjour discovery where it thinks the name’s already in use on the network [20:16:40] im up to ‘Hawkeye (5)’ :P [20:17:26] (03PS2) 10BearND: Don't expose fragment-specific action items when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169507 (https://bugzilla.wikimedia.org/72605) (owner: 10Dbrant) [20:17:37] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c15 (10Jon) 5PATC>3NEW Mm.. this leaves me even more confused. I followed your steps completely in the emulator and am unable to replicate it there. According to the code it should fallback to moused... [20:17:45] (03PS2) 10Jdlrobson: WIP: Get tap event to work without window.addEventListener [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169553 (https://bugzilla.wikimedia.org/72645) [20:18:11] (03CR) 10Jhernandez: [C: 031] Add persistent anonymized WikiGrok user token [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169559 (owner: 10Bmansurov) [20:19:49] brion: hmm not sure about the hostname numbers… how do i check? [20:20:00] mhurd: system preferences -> sharing [20:20:16] there’s a box ‘Computer name’ at the top [20:20:25] (03PS3) 10Jdlrobson: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) (owner: 10Robmoen) [20:20:47] brion: “the cute part is that most of the objects are using the same i/o schema for the mobileview JSON input and for their .plist storage on-device” <— awesome!!! [20:21:03] :D [20:21:15] we could switch it to save json on disk, but meh. they’re about the same [20:21:22] either way it’s dictionaries in memory :D [20:21:37] brion: yeah it added “-2” to mine... [20:21:41] bah [20:21:43] brion: true [20:21:45] hope they fix that in the .1 release [20:21:48] i shoudl check if there’s a beta [20:21:54] (03PS1) 10Kaldari: Fix nationalities label in WikiGrok v B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169570 (https://bugzilla.wikimedia.org/72631) [20:22:00] (03PS2) 10Yurik: ZeroPortal setRawResult lua mode [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 [20:22:08] brion: does it screw things up if you edit it out? [20:22:09] jhobs, ^ [20:22:11] nope, no point release in developer land [20:22:17] mhurd: no, it’ll just probably change it back again later ;) [20:22:23] haha right [20:22:31] DarTar: can you please review this: https://meta.wikimedia.org/wiki/Schema:MobileWebWikiGrokError ? [20:22:38] but it can apparently confuse things like time machine backups because the name keeps changing [20:22:53] bmansurov: sure, give me a sec [20:22:53] very strange [20:22:55] (03CR) 10BearND: [C: 032] Don't expose fragment-specific action items when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169507 (https://bugzilla.wikimedia.org/72605) (owner: 10Dbrant) [20:23:12] (03CR) 10Jhobs: [C: 031] ZeroPortal setRawResult lua mode [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [20:23:14] (03Merged) 10jenkins-bot: Don't expose fragment-specific action items when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169507 (https://bugzilla.wikimedia.org/72605) (owner: 10Dbrant) [20:23:28] (03CR) 10Jdlrobson: [C: 04-1] Add missing documentation (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) (owner: 10Robmoen) [20:23:30] (03CR) 10Kaldari: [C: 032] "Quick fix, only affects alpha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169570 (https://bugzilla.wikimedia.org/72631) (owner: 10Kaldari) [20:23:39] ^ rmoen minor issue [20:24:02] bah i hate it when my tests don’t get marked as failed because the build failed and i didn’t notice [20:24:06] (03Merged) 10jenkins-bot: Fix nationalities label in WikiGrok v B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169570 (https://bugzilla.wikimedia.org/72631) (owner: 10Kaldari) [20:24:16] (03CR) 10Jhernandez: [C: 04-1] "This breaks both #/coords/ and #/page when diving into an item, since it uses hashes for remembering the position" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [20:24:26] jdlrobson: ok ty. working on part 2, will come back and address comments [20:26:29] (03CR) 10Jdlrobson: [C: 032] Gruntfile cleanup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169548 (owner: 10Robmoen) [20:26:38] rmoen: i can fix up if you don't mind [20:26:43] i'd like to get it merged :) [20:26:44] i dont mind [20:26:50] ok on it :) [20:26:50] :) [20:27:06] (03Merged) 10jenkins-bot: Gruntfile cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169548 (owner: 10Robmoen) [20:30:48] (03PS1) 10BearND: Fix visibility of dismiss button in ToC tutorial [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169573 (https://bugzilla.wikimedia.org/72595) [20:31:23] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c16 (10Chris H-C) That's really odd. The code is quite explicit: if the touch screen is on (window.ontouchstart is truthy) when it's registering listeners, it'll forego adding a mouseup listener and inste... [20:31:52] dbrant|brb: https://gerrit.wikimedia.org/r/169573 is an alternate solution to your earlier patch [20:31:55] brion: waiting on you for the iOS sync up [20:32:25] ah moment [20:33:31] (03PS4) 10Jdlrobson: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) (owner: 10Robmoen) [20:33:40] (03CR) 10Jdlrobson: [C: 032] Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) (owner: 10Robmoen) [20:37:49] (03Merged) 10jenkins-bot: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169567 (https://bugzilla.wikimedia.org/72341) (owner: 10Robmoen) [20:39:18] (03CR) 10Jdlrobson: [C: 04-1] "Version B disappears when you click okay. This will be very noticeable on a slow connection." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [20:43:04] (03CR) 10Jdlrobson: Show similar experience for both WikiGrok versions A and B. (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [20:44:52] bmansurov: looking now [20:46:04] bmansurov: looks good, a couple of qs [20:46:28] (03CR) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [20:46:44] - record-user-response: under what conditions would that fail? We’re talking of the EventLogging response, not the one on the legacy labsdb table, correct? [20:48:17] also bmansurov: is there any scenario in which WikiGrok can fetch AND there are enough values but for whatever reason the Widget is not displayed? Like a time-out? If so, this should have its own error code [20:48:27] (03CR) 10Dbrant: [C: 032] "wfm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169573 (https://bugzilla.wikimedia.org/72595) (owner: 10BearND) [20:49:03] (03Abandoned) 10Dbrant: Fix dismissability of ToC tutorial on certain screens. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169267 (https://bugzilla.wikimedia.org/72595) (owner: 10Dbrant) [20:49:14] DarTar: i'm not sure, I need to check the js code to see if there are such cases [20:49:21] dbrant|brb: how about another beta release? [20:49:29] bmansurov: last one – I think we can slim down the schema, IMO we don’t need usercount or all the offset data, unless you guys think this is useful for you to debug [20:49:50] bearND: why not indeed! [20:50:01] bmansurov: thanks, what I need at the high level is an indication that the Widget should be there but is not visible for whatever reason [20:50:02] DarTar: nah, I don't think I need it. I'll remove those fields. what else should I remove? [20:50:23] 3Wikipedia App / 3Android App: ToC tutorial screen not dismissable. - 10https://bugzilla.wikimedia.org/72595 (10Dmitry Brant) 5PATC>3RESO/FIX [20:50:24] dbrant|brb: ok, i'll cut one shortly. just wanted to make sure you don't hae another quick patch to fix a bug or something in the queue [20:50:34] bearND: nope [20:50:50] bmansurov: widgetOffset, scrollOffset, userEditCount - keep the rest [20:50:58] ok [20:51:17] bmansurov: also, typo “fetch-suggestions: suggestoins” [20:51:41] and maybe we should use error names that consistently explain what went wrong [20:51:57] e.g. cannot-fetch-suggestions [20:52:01] ok [20:52:05] etc [20:52:21] (I don’t care either way as long as all error names are negative or positive ) ;) [20:52:30] thanks bmansurov [20:52:50] ok [20:52:53] 3Wikipedia App / 3Android App: Android app: Overflow menu items relating to pages should not be usable during search - 10https://bugzilla.wikimedia.org/72605 (10Dmitry Brant) 5PATC>3RESO/FIX [20:53:23] 3Wikipedia App / 3Android App: Search icon invisible in dark mode - 10https://bugzilla.wikimedia.org/72630 (10Dmitry Brant) 5PATC>3RESO/FIX [20:54:10] DarTar: when you say "what I need at the high level is an indication that the Widget should be there but is not visible for whatever reason", do you think the current schema after my edits will be able to give you that info? [20:54:49] bmansurov: checking [20:55:04] (03PS1) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 [20:56:24] bmansurov: oh you haven’t edited yet :) Yes, I think it will, if the union of #1 and #2 (and potentially the timeout issues) covers all reasons why the widget was supposed to be displayed and it wasn’t [20:56:39] DarTar: I have, can you check again? [20:56:46] k [20:57:24] bmansurov: perfect, let me make one little change [20:59:17] bmansurov: refresh [20:59:40] cool [20:59:41] it’s a bit of a hack, but at least I can group all errors that result in no impression vs those that result in no response [20:59:56] (and we can add more later with the same prefix if needed) [21:00:10] sounds good [21:01:13] bmansurov, Maryana: if the plan is to roll out WikiGrok on anons some time soon (as part of a second dry-run test) we should probably add an isLoggedIn boolean, as we won’t store userIds in clear [21:01:39] DarTar: yeah, that makes sense [21:01:41] dbrant|brb: i remembered i wanted to add one more thing to the gradle build config: to bring back "custom" packages/channels. will do the beta afterwards [21:01:52] DarTar: I agree [21:02:07] Maryana, bmansurov: ok if that’s the case we should add it as required to all 3 schemas [21:02:14] given the increased capacity of the team (and how quickly bmansurov & joakino have onboarded themselves) we'll probably try to do a logged out dry run in this sprint :) [21:02:16] bmansurov: can you do it? [21:02:27] Maryana: that’s cool [21:02:36] DarTar: yes I can, I think I should do so once we work on that card, no? [21:02:48] Maryana: what's that? [21:02:59] bmansurov: if we manage to add that field now we won’t have to bump the revId later [21:03:10] joakino: just saying you're doing a great job :) [21:03:11] carry on [21:03:11] DarTar: I see, ok I'll do so now [21:03:18] bmansurov: you’re da man [21:03:25] Maryana: :D [21:03:26] * DarTar waves at joakino [21:03:38] gotta run, bbl [21:04:32] jdlrobson: damn, that code I self-merged still hasn't made it to beta labs :( [21:05:11] guess I'll have to demo locally [21:05:33] Maryana: DarTar talks about 3 schemas and I know of 2 only, where is the 3rd one, do you know? [21:05:51] oh… hmm [21:05:58] there should only be 2 unless i'm missing something? [21:06:03] ok thanks [21:06:07] bmansurov: log, response, errors [21:06:18] errors are in the client-side log, no? [21:06:19] s/log/interaction [21:06:29] Maryana: yes [21:06:34] Maryana: we factored them out in a dedicated log [21:06:50] DarTar: what's the url for the 3rd one? [21:07:11] errors? the one you’ve been hacking a minute ago :D [21:07:34] jdlrobson: when you say change button to a link, do you mean I should replace the button html with a link html? and if so, why is it better than using a hash? [21:07:41] bmansurov: https://meta.wikimedia.org/wiki/Schema:MobileWebWikiGrok https://meta.wikimedia.org/wiki/Schema:MobileWebWikiGrokResponse https://meta.wikimedia.org/wiki/Schema:MobileWebWikiGrokError [21:07:54] DarTar: ok thanks, I was missing the response one [21:08:51] DarTar: I've added the isLoggedIn field to all 3 [21:09:43] thx [21:09:52] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c17 (10Jon) Okay yeh I think I see what's going on. The Torch is touch screen only - if I understand correctly 9900 supports both touch and mousepad and it's obvious the code hasn't thought about this (I... [21:14:19] (03PS1) 10Jdlrobson: Trigger tap events on phones where both touch and mouse are supported [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169581 (https://bugzilla.wikimedia.org/72566) [21:15:45] (03CR) 10Jdlrobson: [C: 04-1] "Breaks touch devices." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169581 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [21:17:38] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c19 (10Jon) The above patch fixes it for Blackberry (I think) but breaks it for iOS. I'm actually going to suggest we kill this code. ios8 [1] has no need for it, neither does Chrome [2] [1] https://gith... [21:18:34] dbrant, bearND, tfinc2: I have Genymotion hooked up to Android Studio now. [21:18:41] dbrant, bearND, tfinc2: It's pretty good. [21:18:52] nice [21:18:54] Deskana: you'll never go back [21:19:04] good! [21:19:06] bmansurov: I'm gonna merge this https://gerrit.wikimedia.org/r/#/c/169559/ looks good to me and I need it [21:19:13] Deskana: i haven't started the android emu in ages since moving to Geny [21:19:30] joakino: sure [21:19:32] props to awjr_away for turning me onto it [21:19:32] bmansurov: do you want someone specifically to take a look at it before that? [21:19:39] joakino: no [21:19:48] oooh lemme try that [21:19:53] joakino: if you think it's good then do it [21:19:56] ios simulator has sooo spoiled me [21:20:21] bmansurov: i'm +2 happy... [21:20:27] ;) [21:21:18] (03CR) 10Jhernandez: [C: 032] Add persistent anonymized WikiGrok user token [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169559 (owner: 10Bmansurov) [21:21:51] (03PS1) 10Jdlrobson: Tap code be gone! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) [21:22:04] (03Merged) 10jenkins-bot: Add persistent anonymized WikiGrok user token [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169559 (owner: 10Bmansurov) [21:22:09] (03CR) 10Jdlrobson: [C: 04-2] "Needs consensus first" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [21:23:24] brion: found a bug w the doctype tag we added… for some reason the toc can’t scroll the web view to bottom most sections… tracking it down... [21:23:29] (03PS2) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 [21:23:36] hmm weird [21:24:08] brion: ya if i remove the doctype line from the index.html it works fine… must have been relying on some weird quirks mode behavior… [21:24:13] haha [21:24:15] (03PS17) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [21:24:16] * brion *sob* [21:24:32] dbrant, bearND: Anyway, how's it going gentlemen? Anything I can help with? [21:25:15] (03PS1) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 [21:25:33] (03PS2) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 [21:26:03] Deskana: Nope. All is good. I'm adding custom channels and packages back to the build, and then cut another beta. [21:26:07] (03PS3) 10Jdlrobson: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 (owner: 10Robmoen) [21:26:25] Deskana: have a second? [21:26:28] Deskana: actually, if you'd like to revisit this: https://gerrit.wikimedia.org/r/163453 there is now a function called "isCancelled" in SaneAsyncTask. [21:26:50] mhurd: Sure. IRC or shall I come over? [21:26:54] * Deskana is on the hammock. [21:30:22] dbrant: Interesting. I'll check that out later. [21:31:10] (03CR) 10Jdlrobson: [C: 04-1] Add missing documentation (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 (owner: 10Robmoen) [21:35:15] (03CR) 10Jdlrobson: [C: 04-1] Add missing documentation (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 (owner: 10Robmoen) [21:36:46] wheeee refactoring test case classes is fun [21:40:52] 3MobileFrontend / 3alpha: WikiGrok v. B tags shouldn't be centered & nationality missing - 10https://bugzilla.wikimedia.org/72631#c6 (10Jon) 5PATC>3NEW I don't know how we can solve the tag problem. To be frank the design is just not that good... it hasn't considered the variable text length nor i18n. We... [21:42:04] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169586 [21:46:10] ^ rmoen in case you didn't see some feedback [21:46:13] (03PS1) 10Southparkfan: Add "address" to "IP" (s/IP/IP address) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169588 [21:46:16] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169586 (owner: 10Hashar) [21:46:48] jdlrobson: i'll look, i've still got more to go [21:47:50] cool :) [21:53:14] oh hey it looks like virtualbox and vmware fusion play a little better together now [21:53:22] bmansurov: do you use the pre-commit hook? [21:53:34] (03PS1) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [21:53:49] joakino: sometimes [21:53:52] (03PS2) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [21:54:10] bmansurov: xd yeah I saw that [21:54:18] bmansurov: jscs is a bitch [21:54:48] joakino: I forgot to run it with my last couple patches [21:55:06] bmansurov: no worries, just a space and a \n [21:55:27] mmmm, nope still pegs a cpu to 100%. d'oh [21:56:40] brion: who. just had a hard crash w the phone - screen turned blue and everything… [21:56:45] *whoa* [21:56:48] yikes! [21:56:59] blue screen huh… sure it’s not a windows phone? [21:57:12] hehe right [21:57:39] brion: the audio scratched so i looked over just in time to see it [21:58:14] not a desired DJ effect in this case... [22:00:00] (03PS1) 10Jhernandez: Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 [22:00:38] (03CR) 10Jhernandez: [C: 04-2] "I'm waiting for some input on the specific details of this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [22:01:41] (03PS1) 10Robmoen: Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 [22:01:48] (03CR) 10jenkins-bot: [V: 04-1] Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 (owner: 10Robmoen) [22:08:18] (03PS1) 10Jdlrobson: Hygiene: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169600 [22:09:46] (03CR) 10Jhernandez: [C: 032] Hygiene: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169600 (owner: 10Jdlrobson) [22:10:19] (03Merged) 10jenkins-bot: Hygiene: Fix jscs errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169600 (owner: 10Jdlrobson) [22:13:13] Deskana: brion i think i fixed it! [22:13:19] woot [22:13:37] brion: needed “px” added :) that’s all [22:13:43] hah [22:13:47] oh quirks mode [22:14:08] (03PS2) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [22:14:17] w/o that the damn padding div i was added at the bottom of the page wasn’t actually being set to the height we needed [22:18:08] 3MobileFrontend / 3alpha: WikiGrok v. B should show more than 1 tag per line - 10https://bugzilla.wikimedia.org/72631#c7 (10Ryan Kaldari) The nationality issue is fixed, so removing that from the bug title. [22:18:38] 3MobileFrontend / 3alpha: WikiGrok v. B should show more than 1 tag per line - 10https://bugzilla.wikimedia.org/72631#c8 (10Ryan Kaldari) CCing Moiz for design input... [22:20:58] (03PS1) 10Jdlrobson: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) [22:21:37] (03CR) 10jenkins-bot: [V: 04-1] Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [22:23:44] (03PS2) 10Jdlrobson: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) [22:23:50] ^ MaxSem I'm pretty sure I need you're help with the page images stuff to make this work [22:25:22] jdlrobson, so... basically, you want to show more than 50 PI from PHP? [22:26:19] dbrant: Hmm, the overflow menu is gone while searching. [22:26:23] (03PS1) 10Mhurd: Fix for scrolling when TOC onscreen. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169610 [22:26:27] brion: ^ [22:26:57] Deskana: shouldn't it be? [22:27:06] (03CR) 10Brion VIBBER: [C: 032] "yay web standards!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169610 (owner: 10Mhurd) [22:27:12] woohoo! [22:27:12] dbrant: How do you clear your recent searches then? That was in there. [22:27:54] Deskana: oh, that's gone too? that's weird [22:28:05] Deskana: does your device have a menu button? [22:28:09] dbrant: I'm checking I'm actually running master. [22:28:09] brion: gonna cut another testflight real fast… [22:28:13] dbrant: No, this is a Nexus 5. [22:28:16] k [22:28:38] dbrant: Yeah, it's gone. [22:31:45] DarTar: got a sec? [22:32:48] (03PS1) 10Jhernandez: Hygiene: Grunt file code style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169613 [22:32:50] (03PS1) 10Jhernandez: Tools: Add lint task for grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169614 [22:32:52] (03PS1) 10Jhernandez: Tools: Add notifications to grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169615 [22:34:10] (03PS5) 10Jdlrobson: Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 [22:34:12] (03PS1) 10Jdlrobson: Introduce WatchList class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 [22:35:44] (03PS4) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 [22:35:58] (03CR) 10Jdlrobson: [C: 032] EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [22:36:34] (03Merged) 10jenkins-bot: EditorApi: Check for sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168823 (https://bugzilla.wikimedia.org/72521) (owner: 10Florianschmidtwelzow) [22:37:24] 3MobileFrontend / 3Feature requests: Setup infinite scroll on Watchlist - 10https://bugzilla.wikimedia.org/72650 (10Jon) 3NEW p:3Unprio s:3normal a:3None When you have more than 50 articles and JavaScript you shouldn't have to click more to see them they should load in the same way they do on Special... [22:37:48] (03PS3) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 [22:39:24] (03CR) 10Brion VIBBER: [C: 031] "I like that the extra interface is targeted at the specific (privileged) page that needs it. Conservative API extensions are good. :D" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [22:40:24] 3MobileFrontend / 3Feature requests: Setup infinite scroll on Watchlist - 10https://bugzilla.wikimedia.org/72650#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ZPd59KdO [22:40:28] (03CR) 10Robmoen: Add missing documentation (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 (owner: 10Robmoen) [22:41:38] bmansurov: I'm trying to get clarification from Dario on that error logging card [22:41:52] kaldari|2: yes I saw your comment [22:41:52] Sorry for the delay [22:42:22] bmansurov: I also added 1 error condition to his list [22:42:39] (03PS4) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 [22:42:51] (03PS3) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [22:42:51] kaldari|2: thanks [22:57:37] jhobs: i forgot to mention today...well, i think i forgot to mention?...on those controls, be sure to validate them with smaller viewports. it looks like it was centering relative to the window...wasn't sure about text wrapping and whatnot, though. ff and chrome both have some nice tools for scaling to device dimensions common among phones used by w0 readers [22:57:44] (03PS5) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 [22:57:55] jhobs: and if i'm stating the obvious, sorry! [22:58:01] (03PS5) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 [22:58:03] dr0ptp4kt: already handled by oo-ui :) [22:58:17] (03PS4) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [22:58:25] jhobs: excellent [22:58:25] dr0ptp4kt: if the screen gets too small it expands to full-screen [22:58:38] jhobs: word [22:59:33] kaldari|2: can you comment on this one? https://trello.com/c/HlIE01me/3-5-show-wikigrok-to-readers-in-alpha-beta [23:00:14] (03CR) 10Jdlrobson: [C: 04-1] Add missing documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 (owner: 10Robmoen) [23:00:23] (03PS6) 10Jdlrobson: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 (owner: 10Robmoen) [23:00:34] (03CR) 10Jdlrobson: [C: 032] Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 (owner: 10Robmoen) [23:00:48] (03PS5) 10Jdlrobson: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [23:01:09] (03Merged) 10jenkins-bot: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169583 (owner: 10Robmoen) [23:01:40] joakino: replied [23:02:56] Maryana: you around? [23:03:01] in a meeting I bet :) [23:03:23] (03PS2) 10Dbrant: Change ActionBar search text every time a "Did you mean" query is run. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169319 (owner: 10Deskana) [23:06:46] (03CR) 10Jdlrobson: [C: 04-1] "nitpicks. please don't hate me." (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [23:08:20] (03CR) 10Jdlrobson: [C: 032] Tools: Add notifications to grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169615 (owner: 10Jhernandez) [23:08:43] (03CR) 10Jdlrobson: [C: 032] Tools: Add lint task for grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169614 (owner: 10Jhernandez) [23:09:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: Grunt file code style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169613 (owner: 10Jhernandez) [23:09:49] kaldari|2: can i get the url of the schema? [23:10:06] (03Merged) 10jenkins-bot: Hygiene: Grunt file code style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169613 (owner: 10Jhernandez) [23:10:08] (03Merged) 10jenkins-bot: Tools: Add lint task for grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169614 (owner: 10Jhernandez) [23:10:10] (03Merged) 10jenkins-bot: Tools: Add notifications to grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169615 (owner: 10Jhernandez) [23:10:46] joakino: schemas added [23:10:52] 3MobileFrontend / 3stable: Edit preview doesn't work for JS and CSS pages (throws JS error) - 10https://bugzilla.wikimedia.org/72521 (10Jon) 5PATC>3RESO/FIX [23:11:43] (03CR) 10Jdlrobson: [C: 04-1] "Needs rebasing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 (owner: 10Robmoen) [23:12:35] (03CR) 10Jdlrobson: [C: 031] "Max should take a look." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [23:15:34] kaldari|2, DarTar I've also added another error type: no-impression-cannot-fetch-claims, but it's related to wikidata and not wikigrok, is that fine? [23:16:09] kaldari|2, DarTar if the above is fine, I need to add another error type called no-impression-cannot-fetch-labels, which is also related to wikidata [23:20:15] kaldari|2: yes but will be free in a sec :) [23:28:53] (03CR) 10Jdlrobson: [C: 04-1] Show similar experience for both WikiGrok versions A and B. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [23:29:00] (03CR) 10Jdlrobson: Show similar experience for both WikiGrok versions A and B. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [23:32:54] 3MobileFrontend / 3alpha: Issues with icons in alpha. Get fixed so we can move it to beta. - 10https://bugzilla.wikimedia.org/72653 (10Jon) 3NEW p:3Unprio s:3normal a:3None * CtaDrawer down icon is not centered * Switcher in VisualEditor/Wikitext editor * Notification icon tiny mw-ui-icon-notificatio... [23:35:23] 3MobileFrontend / 3alpha: Issues with icons in alpha. Get fixed so we can move it to beta. - 10https://bugzilla.wikimedia.org/72653#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Vh51EzgU [23:35:53] 3MobileFrontend / 3Hygiene: [Tracking] MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181 (10Jon) [23:35:54] 3MobileFrontend / 3stable: IE8 background sizes - 10https://bugzilla.wikimedia.org/70961 (10Jon) [23:35:55] 3MobileFrontend / 3Feature requests: Icons missing/broken on old Nokia phones (X3, C3) - 10https://bugzilla.wikimedia.org/50326 (10Jon) [23:35:55] 3MobileFrontend / 3Feature requests: Lots of background images not using data URI embedding - 10https://bugzilla.wikimedia.org/64101 (10Jon) [23:36:09] 3MobileFrontend / 3alpha: Issues with icons in alpha. Get fixed so we can move it to beta. - 10https://bugzilla.wikimedia.org/72653 (10Jon) [23:36:17] (03PS13) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [23:37:21] (03CR) 10Robmoen: "Updated rebased so this doesn't rot too much" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [23:37:46] yurikR: did you verify on your machine that https://gerrit.wikimedia.org/r/#/c/169563 is actually working? [23:38:04] dr0ptp4kt, yep [23:38:30] (03CR) 10Jdlrobson: [C: 04-1] Fix no-redirecting Cta in Edit-workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [23:38:32] (03PS2) 10Robmoen: Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 [23:39:22] dr0ptp4kt, create Module:Portal with local p = {} [23:39:22] [23:39:22] function p.main( frame ) [23:39:22] mw.zeroportal.setRawResult('aaaaaaaaaaa') [23:39:22] return '' end [23:39:32] (03CR) 10Dr0ptp4kt: [C: 032] "See comments for fast follower stuff." (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [23:39:57] (03Merged) 10jenkins-bot: ZeroPortal setRawResult lua mode [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [23:40:23] 3MobileFrontend / 3Hygiene: [Tracking] MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181#c8 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/paVrcmhn [23:40:23] 3MobileFrontend / 3beta: Type error when storing widgetOffset in EventLogging - 10https://bugzilla.wikimedia.org/72639#c2 (10Jon) To be clear the fix should store a float not an integer. [23:40:33] rmoen: your face is on https://trello.com/c/wYLhzlDl/12-5-add-alma-mater-to-wikigrok-version-b does that mean you are working on it? [23:40:55] if so can you move it to in dev [23:41:00] jdlrobson: i haven't started but i just un-rotted the response api so i could start it [23:41:03] Fixing docs first [23:41:25] rmoen: okay i'm never sure if i see your face on a card in 'ready for dev' if you are working on it or not :) [23:41:27] rmoen: Thanks Rob, still pushing to get things unblocked... [23:41:48] jdlrobson: its not in dev yet because i haven't started [23:41:52] rmoen: Chris is going to do the security review with me tomorrow and I think we should be able to get it deployed by Thursday. [23:42:08] kaldari|2: sounds good [23:44:17] (03CR) 10Yurik: ZeroPortal setRawResult lua mode (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [23:44:38] (03PS1) 10Jdlrobson: Convert string to integer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169624 (https://bugzilla.wikimedia.org/72639) [23:45:53] 3MobileFrontend / 3alpha: WikiGrok v. B should show more than 1 tag per line - 10https://bugzilla.wikimedia.org/72631#c9 (10Maryana Pinchuk) i18n shouldn't be an issue right now; we're on enwiki only at this stage :) And we don't have a standard design to solve this, since it's a completely novel workflow. T... [23:47:52] (03PS1) 10Bmansurov: WIP: WikiGrok error logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 [23:50:31] (03PS6) 10Robmoen: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 [23:50:58] (03PS6) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [23:53:28] (03CR) 10Kaldari: [C: 032] Convert string to integer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169624 (https://bugzilla.wikimedia.org/72639) (owner: 10Jdlrobson) [23:54:04] (03Merged) 10jenkins-bot: Convert string to integer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169624 (https://bugzilla.wikimedia.org/72639) (owner: 10Jdlrobson) [23:59:48] (03CR) 10Dr0ptp4kt: "See also https://www.mediawiki.org/wiki/Wikipedia_Zero/Accept-Language_Aware_Redirects" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)