[00:00:06] (03PS3) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [00:00:13] (03CR) 10Anomie: "This was merged too hastily, IMO. It has issues and didn't get review from any of the people who raised issues with Ifecbbb6e." (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [00:00:24] (03CR) 10Jdlrobson: [C: 032] Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 (owner: 10Robmoen) [00:00:59] (03Merged) 10jenkins-bot: Add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169578 (owner: 10Robmoen) [00:01:02] dbrant: dr0ptp4kt: got a custom channel/package functionality almost ready to push to gerrit [00:01:25] bmansurov: can you review https://gerrit.wikimedia.org/r/168711 - if it doesn't break anything +2? [00:01:33] (03CR) 10Jackmcbarn: "I agree with Anomie that this was probably a bad idea." (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169563 (owner: 10Yurik) [00:01:36] jdlrobson: ok [00:01:37] bearND: sweet [00:01:50] rmoen: does https://gerrit.wikimedia.org/r/#/c/169599/ need the dependency? [00:02:04] thanks bmansurov [00:02:19] dr0ptp4kt: would you mind if I changed --custompackage to --app in the build script? [00:02:32] Yeah for the ResponseApi, plus it was one less conflict i would have carrying it [00:02:36] jdlrobson: ^ [00:02:37] (03PS2) 10Jhernandez: Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 [00:02:38] bearND: as long as it's documented it's all good [00:02:45] (03CR) 10Jdlrobson: [C: 032] Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 (owner: 10Robmoen) [00:04:17] dr0ptp4kt: we only have it documented as part of the usage print out right now [00:04:30] (03PS1) 10Jdlrobson: Hygiene: Correct the icon documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169628 [00:04:52] (03PS3) 10Jhernandez: Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 [00:04:56] bmansurov: OK, I think the acceptance criteria for https://trello.com/c/uM5hM9cR/40-3-wikigrok-error-logging are settled now. [00:05:09] after talking with Dario [00:05:25] thx folks [00:05:35] bearND: and in the commented lead up in the script if memory serves. main thing is that it's clear that --app means to have a package other than the default so i don't do something horribly bad when doing custom builds [00:05:37] ! [00:05:38] kaldari|2: it's missing cannot-fetch-labels [00:05:38] :) [00:05:43] (03CR) 10Jhernandez: Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:05:58] (03CR) 10Jhernandez: "Ready for review" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:05:58] ^ rmoen saved you some work with icon docs [00:06:00] bmansurov: Ah, you're right. [00:06:05] it bugged me when i saw it. [00:06:24] dr0ptp4kt: the lead section doc got trimmed quite a bit lately [00:07:00] bearND: oh ok. in any event, --help or help output if run without params / incorrect params does the trick for me [00:07:08] (03PS1) 10BearND: Add custom channel and package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169629 [00:07:13] rmoen: i think we are just waiting on https://gerrit.wikimedia.org/r/#/c/169592/ now yeh? [00:07:43] jdlrobson: yeah i'm writing docs for things i don't understand at the moment. [00:07:49] sweet [00:08:00] good way to learn what everything does [00:08:00] dr0ptp4kt: yes, that doc is updated [00:08:14] dbrant: dr0ptp4kt: patch is pushed [00:08:46] (03CR) 10Jdlrobson: Update and add missing documentation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [00:08:57] bearND: ooh, very nice [00:09:05] (03CR) 10Bmansurov: [C: 032] Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [00:09:15] jdlrobson: currently trying to figure out how loadingOverlay stops animating [00:09:23] LoadingOverlay [00:09:33] yes LoadingOverlay [00:09:39] (03Merged) 10jenkins-bot: Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [00:09:41] rmoen: you have to hide it :) [00:09:48] rmoen: it's just an overlay with a spinner in it [00:09:51] yeah [00:10:00] up to the caller to hide it [00:10:19] yeah i figured, just explaining where i'm at [00:12:46] (03CR) 10BearND: [C: 032] Add "address" to "IP" (s/IP/IP address) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169588 (owner: 10Southparkfan) [00:13:06] (03Merged) 10jenkins-bot: Add "address" to "IP" (s/IP/IP address) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169588 (owner: 10Southparkfan) [00:13:22] bmansurov: thanks for adding that. Feel free to add more if you come across possible error conditions in the code [00:13:48] kaldari|2: np, I didn't know you were going to add it, so I let myself go ahead ;) [00:14:13] (03CR) 10Dbrant: "Responses to your points:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 (owner: 10Dbrant) [00:15:52] (03CR) 10Jhernandez: [C: 032] Hygiene: Correct the icon documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169628 (owner: 10Jdlrobson) [00:16:27] (03Merged) 10jenkins-bot: Hygiene: Correct the icon documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169628 (owner: 10Jdlrobson) [00:17:58] Deskana: question about https://trello.com/c/pywk5prg/2-3-as-a-reader-when-i-tap-search-i-would-like-to-be-shown-my-recent-searches-so-that-i-can-run-those-searches-again. Should we really store a recent search term when search is cancelled? [00:18:08] and related to https://gerrit.wikimedia.org/r/#/c/168979/ [00:18:47] bearND: I think so. It was a valid search, it's just one that you decided not to action. :) [00:18:52] bearND: Any reason it shouldn't be stored? [00:19:47] Deskana: that was a question that came up in a follow up patch by dbrant (https://gerrit.wikimedia.org/r/#/c/168979/) [00:20:02] just trying to close the loop [00:20:17] Deskana: bearND: here's what I'm hesitant about -- you bring up the Search field, then type the letter "a", then back out of Search. The term "a" will then be in your "recent" list. [00:20:39] dbrant: Right. Why would you do that, though? [00:20:58] Sorry to be difficult. :-p [00:21:15] Deskana: bearND: i'm just picturing it getting really cluttered. At least it has been for me, ...but maybe it's because I'm doing a lot of testing. [00:21:27] dbrant: I think so. Mine is really cluttered too. [00:22:23] (03CR) 10Jhernandez: [C: 031] Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [00:22:37] (03PS7) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [00:22:41] (03CR) 10Bmansurov: Show WikiGrok to readers in alpha/beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:22:43] (03CR) 10jenkins-bot: [V: 04-1] Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [00:22:56] jdlrobson: Hey Jon, I have to take my car in tomorrow morning for some work, so I might be late for stand-up and possibly scrum of scrums. If I'm not in before 10:30 could be sub for me at scrum of scrums? [00:23:11] joakino: ignore my comment [00:24:43] (03CR) 10Jhernandez: Show WikiGrok to readers in alpha/beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:24:52] bmansurov: oh ok [00:24:57] wops [00:25:13] bmansurov: anyway there goes the explanation heh [00:25:42] (03PS8) 10Robmoen: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 [00:26:09] dbrant: Deskana: whatever you guys come up with for this is fine with me. [00:26:47] blah jdlrobson, stepping all over my toes today... I forgive you though :) [00:27:36] jenkins is so slow merging [00:27:59] (03CR) 10Bmansurov: "looks great, needs spaces inside parenthesis though" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:29:49] (03PS4) 10Jhernandez: Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 [00:30:15] (03CR) 10Jhernandez: Show WikiGrok to readers in alpha/beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:32:54] dbrant, bearND: I think we should stick to the current criteria. [00:33:09] dbrant, bearND: I suspect it's only getting cluttered because we're searching very atypically since we're testing a lot. [00:34:42] Deskana: ok [00:35:02] dbrant, bearND: Thanks for checking in. :) [00:35:26] bearND: i'll amend that patch. let me know what you think of the other stuff [00:35:29] dbrant: bearND i chatted with gabriel about parsiod stuff and it sound like much of what we need is coming online in the near future. he’s really interested in our use cases and dan’s agreed to set up a meeting where we can demo to him what we’re doing / trying to do, and he can demo to us how parsiod can help. [00:35:54] mhurd: awesome! thanks [00:35:58] dbrant: I think the other stuff sounds good. [00:36:15] mhurd: sweet! [00:37:04] (03PS2) 10BearND: Add custom channel and package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169629 [00:42:37] (03PS1) 10Yurik: Change MIME type of the raw lua [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169632 [00:43:19] (03CR) 10Bmansurov: [C: 032] Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:43:56] (03Merged) 10jenkins-bot: Show WikiGrok to readers in alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169598 (owner: 10Jhernandez) [00:44:16] bmansurov: yipiii my second feature patch! [00:44:20] :D [00:44:33] joakino_: you're doing very well!!! [00:44:56] 3MobileFrontend / 3stable: Can't dismiss search interface by clicking on the rest of the page - 10https://bugzilla.wikimedia.org/72656 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Go to https://en.m.wikipedia.org/wiki/Main_Page (in a desktop browser) 2. Click in the search... [00:45:25] 3MobileFrontend / 3stable: Can't dismiss search interface by clicking on the rest of the page - 10https://bugzilla.wikimedia.org/72656#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/fNGUtfZ0 [00:46:29] (03PS1) 10Jhobs: Update interstitial to use OOjs-UI [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 [00:46:51] yurikR: ^ [00:47:07] jhobs, thx, will look [00:48:52] dbrant, bearND, mhurd: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec has the semantic bits exposed in Parsoid HTML [00:50:08] (03CR) 10Kaldari: [C: 032] Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 (owner: 10Robmoen) [00:51:41] (03PS2) 10Jhobs: Update interstitial to use OOjs-UI [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 [00:55:22] 3MobileFrontend / 3stable: Can't dismiss search interface by clicking on the rest of the page - 10https://bugzilla.wikimedia.org/72656#c2 (10Ryan Kaldari) I was hoping maybe this would be fixed for free by https://gerrit.wikimedia.org/r/#/c/169582/, but no luck. [01:05:08] (03CR) 10Jhernandez: [C: 031] "Looks good, the only thing I noticed is the spinner on version B appears at the bottom right of the box, I don't know if it has to be cent" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [01:09:03] gwicke: i have a feeling i’m going to be using that doc quite a bit :) [01:14:24] jdlrobson: kaldari|2 – i talked moiz down from the checkbox ledge. can one of you estimate this, plz? https://trello.com/c/JltOtA2q/46-wikigrok-v-b-better-tag-styling [01:14:41] jdlrobson: kaldari|2 whoever works on this card, can we sit down please [01:14:53] i dont want to loose the checkbox [01:15:02] so i want to see how much its getting us [01:15:10] if its helping a lot, then fine [01:30:23] (03PS1) 10Jdlrobson: Tools: Use gruntfile to generate pngs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169641 [01:30:25] (03PS1) 10Jdlrobson: WIP: Experiment with populating the icon library from Wikifont [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169642 [01:33:06] (03PS2) 10Jdlrobson: Restore the place on Nearby for back button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72566) [01:36:53] 3MobileFrontend / 3stable: Can't dismiss search interface by clicking on the rest of the page - 10https://bugzilla.wikimedia.org/72656#c3 (10Jon) This behaviour only seems to be present on iOS for some reason. I'm not sure how important this is to be fixed or what the behaviour should be. [01:37:54] (03PS9) 10Jdlrobson: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [01:38:30] (03CR) 10Jdlrobson: [C: 032] Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [01:38:58] (03PS10) 10Jdlrobson: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [01:40:10] 3MobileFrontend / 3Hygiene: Hygiene: Wikigrok lacks documentation - 10https://bugzilla.wikimedia.org/72657 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon `make jsduck` returns the following Warning: /Users/jrobson/git/vagrant/mediawiki/extensions/MobileFrontend/javascripts/modules/wikigrok/wikigrok.js:18:... [01:40:24] 3MobileFrontend / 3Hygiene: Hygiene: Wikigrok lacks documentation - 10https://bugzilla.wikimedia.org/72657#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7eOK5vEA [01:41:53] 3MobileFrontend / 3General/Unknown: Documentation warnings for JavaScript - 10https://bugzilla.wikimedia.org/72341#c4 (10Jon) 5PATC>3RESO/FIX Let's call this done. The template warnings should go away when templates are in core. I've created a bug for wikigrok docs. [01:43:12] (03CR) 10MaxSem: Allowing UserJS and UserCSS within the Minerva skin (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [02:04:15] (03CR) 10Jdlrobson: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [02:04:31] (03CR) 10Jdlrobson: [C: 032] Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [02:05:05] (03Merged) 10jenkins-bot: Update and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169592 (owner: 10Robmoen) [07:13:40] 3Wikipedia App / 3iOS App: iOS app: the strings for the About screen are not translatable - 10https://bugzilla.wikimedia.org/72607#c2 (10Amir E. Aharoni) 5RESO/WOR>3RESO/FIX Actually, I'd call this FIXED :) It was not in translatewiki when I opened the bug, and I couldn't even find them in the source co... [10:03:08] morning all [10:33:05] (03CR) 10Phuedx: Implement WikiGrok response API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [10:45:24] (03CR) 10Phuedx: [C: 04-1] "This logging needs to be split between the client and the server to minimise the number of requests that the client is making, i.e. if the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [12:35:07] (03PS7) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) [12:35:12] (03CR) 10Florianschmidtwelzow: Fix no-redirecting Cta in Edit-workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [14:02:28] (03CR) 10Dbrant: [C: 032] Change ActionBar search text every time a "Did you mean" query is run. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169319 (owner: 10Deskana) [14:18:29] (03CR) 10Dbrant: [C: 04-1] "Almost there... but I can't select multiple history entries (when I try selecting more than one, it goes to the page that I click). There" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169547 (owner: 10Alex Monk) [14:21:42] Clueless question as I'm not following the mobile world at all: If I was asked which languages the official Wikimedia mobile applications are written in, would that be Java (Android) and Objective-C (iOS)? Or do I remember incorrectly? Thanks in advance [14:23:06] andre__: that is correct! [14:23:13] whouhou! thanks :) [14:23:30] * andre__ needs to fill in random programming languages for the Google Code-In application) [14:26:33] (03PS2) 10Alex Monk: Allow the user to delete individual history entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169547 [14:57:00] (03CR) 10Dbrant: [C: 032] "groovy" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169547 (owner: 10Alex Monk) [15:02:20] (03PS4) 10Dbrant: Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 [15:02:54] (03PS3) 10Dbrant: Add custom channel and package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169629 (owner: 10BearND) [15:23:25] dbrant, did we talk about a 'Forward' button before? [15:24:44] Krenair: I believe so. I think the last consensus was that it's not necessary, since that pattern doesn't appear in other Android apps. [15:25:12] I just browsed through some feedback and found that come up a few times [15:25:32] (03CR) 10Dbrant: [C: 04-1] "Just one issue. Also, we can probably delete the make-beta script." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169629 (owner: 10BearND) [15:30:31] Krenair: the annoyance that I agree with is accidentally touching the "back" button, and being thrown off by not being able to go "forward" to the page I was on. But I think it's sufficient to make sure that we're scrolled to the proper position in the previous page, so that you can click the link to go forward to the same page. [15:45:33] (03PS2) 10Dbrant: A few Search refinements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 [15:53:22] (03CR) 10Phuedx: "The code change LGTM. Could you include which devices we support that are negatively affected by this change and, if any, which categories" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [15:55:38] (03CR) 10Jdlrobson: "The revert will basically making clicking feel less responsive on Android native browser, old versions of Chrome and any iPhone pre ios8." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [16:01:04] why do i keep forgetting about the timezones?! [16:02:32] jdlrobson: yt? [16:02:45] (i know you're looking at email, but are you here) [16:03:54] phuedx: yup [16:04:06] phuedx: about to head to office soon though [16:04:10] kk [16:04:23] i remember seeing an email thread about device traffic breakdown [16:04:30] which included ios7/8 numbers [16:05:09] what kind of numbers are we talking for the tap be gone! change? [16:05:28] also, if i'm rehashing a conversation that you've already had with others, then please shut me up [16:05:29] ;) [16:08:07] (03PS1) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [16:08:28] phuedx: i haven't checked numbers - it's more a case of building for the future rather than the now [16:08:56] (03CR) 10jenkins-bot: [V: 04-1] Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [16:09:06] (03PS1) 10Phuedx: Fix PHPDoc warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169731 [16:09:15] we never really identified the number of people who had this problem but considering it makes clicking around 300ms faster for a few apple fan boys but kills wikipedia usage for some users with older devices i think it's a no brainer [16:09:49] (03PS2) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [16:10:06] ^ phuedx have a play with this patch i think you'll like :) e.g. http://localhost:8080/wiki/Barack_Obama?mobileaction=alpha&wikidataid=Q76 [16:10:23] heading into office now so i'll make standup! [16:16:45] (03CR) 10Phuedx: [C: 04-1] Introduce WatchList class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 (owner: 10Jdlrobson) [16:18:54] (03PS4) 10BearND: Add custom channel and package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169629 [16:26:28] (03CR) 10Dbrant: [C: 032] Add custom channel and package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169629 (owner: 10BearND) [16:28:14] dbrant: thanks, and good catch with the missing dot [16:28:43] (03PS5) 10BearND: Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 (owner: 10Dbrant) [16:28:53] (03CR) 10BearND: [C: 032] Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 (owner: 10Dbrant) [16:29:10] bearND: np! the builds are now totally complete [16:29:17] (03Merged) 10jenkins-bot: Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 (owner: 10Dbrant) [16:30:21] dbrant: yeah, i wanted to get this merged so that Adam could use it later for building custom packages without having to change anything [16:30:47] bearND: cool; i'm loving how simple this is now. [16:32:57] (03PS3) 10BearND: A few Search refinements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 (owner: 10Dbrant) [16:36:53] (03CR) 10Phuedx: "See inline about potentially documenting events that are emitted." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 (owner: 10Jdlrobson) [16:46:03] (03CR) 10BearND: [C: 032] "Hmm, on my Nexus 4 it automatically scrolls to the top. But ok, it probably doesn't hurt too much to leave this in there." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 (owner: 10Dbrant) [16:47:18] dbrant: anything else you want to get merged before i cut the beta? [16:47:24] (03Merged) 10jenkins-bot: A few Search refinements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168979 (owner: 10Dbrant) [16:47:32] bearND: nope! good to go [16:47:43] al'ight [16:48:13] just doing a quick TWN sync [16:52:20] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169738 [16:53:48] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169739 [16:58:41] (03CR) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [16:58:49] (03CR) 10BearND: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169739 (owner: 10BearND) [16:59:10] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169739 (owner: 10BearND) [16:59:38] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169742 [17:00:04] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169742 (owner: 10BearND) [17:00:24] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169742 (owner: 10BearND) [17:00:48] phuedx you standin or zooing? [17:01:01] kristenlans: trying to connect [17:01:05] having hangout issues [17:05:55] (03CR) 10Dr0ptp4kt: [C: 032] Change MIME type of the raw lua [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169632 (owner: 10Yurik) [17:06:18] (03Merged) 10jenkins-bot: Change MIME type of the raw lua [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169632 (owner: 10Yurik) [17:14:35] (03CR) 10Bmansurov: "thanks, Phuedx for the comment. Kaldari what do you think?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [17:20:46] there was a spike to investigate a/b testing stuff somewhere [17:20:53] anyone know where it went? [17:21:29] phuedx: https://trello.com/c/qoezEgHd/14-spike-examine-the-data-from-the-a-b-test? [17:21:44] bmansurov: nopers [17:21:49] n/m [17:22:47] ah [17:22:58] it was moved [17:28:55] gonna break for 10 minutes [17:29:48] rmoen: moiz is gonna sync up w/you about the tag styling stuff. he's in a mtg till 11:30, so sometime after that [17:29:52] sound good? [17:30:14] Maryana: Sounds good [17:31:42] kristenlans: server error! [17:32:07] mhurd: WOAH! you didn’t really miss anything ;-) [17:35:08] dbrant: just noticed this bug is in To Do but looks liek you fixed it (yay!) https://trello.com/c/l09hk35v/32-toc-tutorial-screen-not-dismissable [17:41:07] backsies [17:42:48] (03PS3) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [17:42:50] (03PS1) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [17:44:00] dbrant: Deskana|Away: beta is published [17:44:35] phuedx: I’m not going to let you forget about those zoo pictures. What’s cuter than animals? What’s cuter than babies? Answer: babies + animals [17:47:00] kristenlans: yep, that one is done [17:47:19] (03PS2) 10Bmansurov: Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 [17:51:54] phuedx: do you know any way to turn 'File:Foo.jpg' into a url that points to the image itself? [17:52:13] jdlrobson: yowza [17:52:17] no, off the top of my head [17:52:22] jdlrobson: server or client? [17:52:30] phuedx: client :/ [17:52:34] eep [17:52:40] i want to avoid an api request [17:52:45] eep [17:53:20] (03PS18) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [17:54:49] jdlrobson: i was really hoping that mw.Title has NS_FILE support :/ [17:55:16] (03CR) 10Jhernandez: "Whats the bug you referenced in the commit have to do with this? Bug 72566 - Mouse cannot expand/contract headers" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [17:56:06] (03PS3) 10Jdlrobson: Restore the place on Nearby for back button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72486) [17:59:57] brion: just a heads up i may have some small enhancements for the ios app for zero-rating. it will just add foreground and background colors to the fixed w0 element at the bottom of the screen when zero-rating is on. added this to android already, just need to do it for ios, too. cc mhurd [18:00:12] brion: but we'll see if any hot potatoes get tossed at me... [18:00:24] * Deskana attempts to find a potato. [18:00:32] haha [18:03:07] (03CR) 10Jhernandez: [C: 032] Restore the place on Nearby for back button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72486) (owner: 10Jdlrobson) [18:03:55] (03Merged) 10jenkins-bot: Restore the place on Nearby for back button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169569 (https://bugzilla.wikimedia.org/72486) (owner: 10Jdlrobson) [18:04:13] bmansurov: with which browser you test this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=72612 ??? [18:04:21] Deskana: able to spare a minute to talk f2f? [18:04:26] 3MobileFrontend / 3stable: VisualEditor edit summary is not saved - 10https://bugzilla.wikimedia.org/72612#c2 (10Bahodir Mansurov) I'm not able to reproduce. My summary has been saved correctly: https://www.mediawiki.org/w/index.php?title=Project%3ASandbox&diff=1245788&oldid=1245681 also this: https://www.m... [18:04:39] dr0ptp4kt: Sure, let me just finish writing these notes. Two minutes. :) [18:04:49] FlorianSW: chrome on a mac [18:04:53] Deskana: cool, lemme know when ready [18:05:25] dr0ptp4kt: Okay, ready! [18:05:41] 3MobileFrontend / 3stable: VisualEditor edit summary is not saved - 10https://bugzilla.wikimedia.org/72612#c3 (10Florian) Hmm :/ I tested it again: https://m.mediawiki.org/wiki/Special:MobileDiff/1245793 Used Chrome desktop and stable mode. Clicked the lead section edit, write down some test text and click... [18:05:45] bmansurov: hmm, ^ [18:05:53] i use chrome on pc (windows 8) [18:06:24] bmansurov: let me test with nexus 7 chrome :) [18:06:51] FlorianSW: are you emulating the mobile view? [18:07:11] bmansurov: no, clicked "mobile view" in the footer (m.mediawiki.org) [18:08:01] FlorianSW: ok, i did the same thing with the second test [18:08:52] hmm :/ [18:10:06] bmansurov: again no summary with Nexus chrome: https://m.mediawiki.org/wiki/Special:MobileDiff/1245797 [18:10:57] FlorianSW: may it be because you're an admin? [18:11:17] i'm trieng as anon now [18:11:37] bmansurov: nope :( https://m.mediawiki.org/wiki/Special:MobileDiff/1245798 [18:13:25] FlorianSW: really weird: https://m.mediawiki.org/wiki/Special:MobileDiff/1245802 [18:14:32] FlorianSW: I'm going to test it on a pc, thanks for your help [18:14:36] (03CR) 10Robmoen: [C: 04-1] "This throws a js error on my local wiki when going to Albert_Einstein. Possibly because there is no wikidataid in the URL ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [18:14:49] i'm wondering, my summary field is an textarea, but the code refers to an input: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/editor/VisualEditorOverlay.js#L113 [18:14:58] *a textarea [18:15:16] $( '.save-panel input' ).val() in console gives undefined (correct) and $( '.save-panel textarea' ).val() the summary text [18:16:05] ok [18:16:09] bmansurov: i think we should use the same way as EditorOverlay ($( '.summary' ).val()), the textarea has the summary class [18:16:31] ok, i'll look into it [18:17:40] (03PS4) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [18:17:42] (03PS2) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [18:17:44] (03PS1) 10Jdlrobson: Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 [18:17:46] (03PS1) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [18:17:46] ^ rmoen fixed :-) [18:18:03] FlorianSW: how did you post as anonymous? the mobile view asks to login [18:18:27] bmansurov: go to alpha mode (anon editing is in alpha :)) [18:18:34] ok [18:18:39] then click edit and you can click "edit without login" [18:19:24] (03PS2) 10Jdlrobson: Hygiene: Fix PHPDoc warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169731 (owner: 10Phuedx) [18:19:30] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix PHPDoc warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169731 (owner: 10Phuedx) [18:20:06] (03Merged) 10jenkins-bot: Hygiene: Fix PHPDoc warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169731 (owner: 10Phuedx) [18:22:29] (03PS5) 10Dbrant: [WIP] experiments with face detection in lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 [18:24:19] bmansurov: are you really using VE (Visual Editor)? [18:24:23] https://www.mediawiki.org/w/index.php?title=Project:Sandbox&curid=1428&diff=1245807&oldid=1245802 -> missing VE tag [18:24:35] my edit with VE tag: https://www.mediawiki.org/w/index.php?title=Project:Sandbox&curid=1428&diff=1245797&oldid=1245793 [18:25:28] FlorianSW: this one has it: https://www.mediawiki.org/w/index.php?title=Project%3ASandbox&diff=1245788&oldid=1245681 [18:25:49] bmansurov: but the mobile tag is missing :P [18:25:57] FlorianSW: shoot [18:26:04] 3MobileFrontend / 3stable: Table of contents shows on action pages it shouldn't - 10https://bugzilla.wikimedia.org/72692 (10Jon) 3NEW p:3Unprio s:3normal a:3None For example http://localhost:8080/wiki/Protected_page?action=protect It should only show when action === 'view' [18:27:22] dbrant, bearND|food - say, i recall seeing something about image compression stuff being enhanced on the android app. i was wondering, what are the particulars on that? [18:27:34] (03CR) 10Jdlrobson: [C: 032] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [18:28:05] dr0ptp4kt: image compression? not sure what that refers to [18:28:09] (03Merged) 10jenkins-bot: Fix no-redirecting Cta in Edit-workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169216 (https://bugzilla.wikimedia.org/72580) (owner: 10Florianschmidtwelzow) [18:28:53] dbrant: or image size savings or something. does that at all ring a bell? maybe it was a phantom memory from a dream :) [18:29:19] dr0ptp4kt: not quite... maybe before my time? [18:29:49] FlorianSW: is this how activate both at the same time: &mobileaction=toggle_view_mobile&veaction=edit [18:30:03] dbrant: no, i think it was in the release notes on google play. maybe bearND|food will have more info :) [18:30:11] or YuviPanda ^ [18:30:30] 3MobileFrontend / 3stable: Table of contents shows on action pages it shouldn't - 10https://bugzilla.wikimedia.org/72692#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/njzL2C5d [18:30:37] bmansurov: i don't know, if veaction work, i suggest not. Just click edit and (if VE can be used in this browser) you can toggle the usage near to the next button (the wheel) :) [18:30:39] or alternative hypothesis: they'll all say "huh?" dbrant [18:30:52] *suggest -> think [18:30:59] ok [18:31:56] FlorianSW: I was able to reproduce it, thanks [18:33:06] (03CR) 10Phuedx: [C: 04-1] "See my review of PS1." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [18:33:49] bmansurov: np :) i think the best way is to implement the EditorOverlay way :) [18:33:57] ok [18:35:53] (03PS1) 10Florianschmidtwelzow: Don't add a ToC on page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169774 (https://bugzilla.wikimedia.org/72692) [18:37:19] dr0ptp4kt: Did Yuri work on that? [18:37:29] dr0ptp4kt: Or are you the only appsy person in Zero Engineering? [18:37:36] * FlorianSW thinks about to view the film Hitchhiker's Guide To The Galaxy in the next time :D [18:37:37] Partners Engineering [18:37:37] Deskana: work on what, now? [18:37:43] dr0ptp4kt: The compression thingy. [18:37:50] (I don't know whether you're Zero or Partners) [18:38:00] (I'd call you Zero Partners but that kinda makes you sound ineffective) [18:38:09] "I work on the Zero Partners team! We don't have any partners." [18:38:20] bmansurov: we should chat with kaldari to see if i'm being overly cautious about logging in the client etc [18:38:26] Then again, "Zero Engineering" makes it sound like you don't do any engineering [18:38:29] then that change can move on [18:38:50] phuedx: yes, I've left a comment for him and made the patch available for review, let's see what he says [18:39:29] (03CR) 10Florianschmidtwelzow: [C: 04-1] Don't add a ToC on page actions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169774 (https://bugzilla.wikimedia.org/72692) (owner: 10Florianschmidtwelzow) [18:39:58] phuedx: I think there are only a couple of cases where the backend can be used for logging. I don't think we save too much by splitting the code between front end backend [18:40:17] *and [18:40:33] (03PS2) 10Florianschmidtwelzow: Don't add a ToC on page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169774 (https://bugzilla.wikimedia.org/72692) [18:40:34] when no suggestions are returned is the one i thought of [18:41:29] phuedx: claims and labels too [18:41:43] ok, anything that we ask the api for ;) [18:41:47] Deskana: oh. there _is_ a thing in the ZeroBanner extension that rewrites the for jpg/jpeg. yuri added a mode to support image downsampling, and we use that on html pages. but we haven't done anything api or appside that i know of to support this same notion in the apps. i was thinking about working on that for the api/apps when the user is on a zero-rated network, of course taking into consideration some complex things like us [18:41:48] toggling between languages, saved article image quality and whatnot. i think i'm sort of the main guy on the android java / ios objective-c + swift guy on the partners engineering side. [18:42:15] my thing is: i think there's currently work going into figuring out whether or not we can rely on client-side event logging [18:42:28] Deskana: i suppose another thing to think about is whether it could be a user preference for the bandwidth conscious. i seem to recall some discussion about letting the user be in text-only mode or something like that, but don't recall specifics [18:42:33] there's a change open in eventlogging to use the sendBeacon api [18:42:35] (that is, by way of an app pref) [18:42:38] Deskana: ^ [18:42:53] and that sparked a meeting around client-side event logging [18:43:28] bmansurov: i should really write this as a comment on the change [18:43:32] ;) [18:43:44] ok [18:49:11] rmoen: hey rob [18:49:18] moizsyed: howdy [18:49:28] rmoen: i hear you're working on tags stuff [18:49:36] moizsyed: yes [18:49:41] moizsyed: doing that right now [18:49:46] rmoen: you wanna jump on a hangout later today to talk about it [18:50:09] rmoen: i have meetings until 2:30 [18:50:12] moizsyed: sure, i'm almost to a point where we could tweak the spacing [18:50:31] / share what i have [18:50:44] rmoen: nice, i got meetings tho... is 2:30 hangout ok? [18:50:45] moizsyed: ok, we can sync anytime [18:50:49] yea [18:50:50] rmoen: ok thanks [18:50:55] rmoen: i'll throw that on your calendar [18:51:01] moizsyed: sweet [18:51:22] rmoen: alright invite sent [18:51:26] rmoen: i'll tty soon [18:51:38] looking forward to it :) [18:53:23] (03Abandoned) 10Jdlrobson: Trigger tap events on phones where both touch and mouse are supported [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169581 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [18:53:40] (03Abandoned) 10Jdlrobson: WIP: Get tap event to work without window.addEventListener [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169553 (https://bugzilla.wikimedia.org/72645) (owner: 10Jdlrobson) [18:56:01] (03CR) 10Jdlrobson: [C: 032] Don't add a ToC on page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169774 (https://bugzilla.wikimedia.org/72692) (owner: 10Florianschmidtwelzow) [18:56:35] (03Merged) 10jenkins-bot: Don't add a ToC on page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169774 (https://bugzilla.wikimedia.org/72692) (owner: 10Florianschmidtwelzow) [18:56:36] jdlrobson: I have VisualEditor installed locally but I'm still unable to edit using it. Is there anything I should do to get it working? [18:56:51] parsoid bmansurov :) [18:56:52] bmansurov: did you enable the role on vagrant? [18:57:04] FlorianSW: I've installed parsoid too [18:57:06] jdlrobson: yes [18:57:21] bmansurov: are you trying on a tablet [18:57:26] and switching to edit? [18:57:30] jdlrobson: yes [18:57:30] any errors in the console? [18:57:43] bmansurov: is it listed on http://localhost:8080/wiki/Special:Version [18:58:07] jdlrobson: yes it's listed in there, and no console errors [18:58:17] jdlrobson: I just don't see the switch button in the editor overlay [18:58:50] bmansurov: it should be next to the save button [18:59:06] jdlrobson: next to the next button maybe? [18:59:40] yes [18:59:50] jdlrobson: it's not there [18:59:58] mm i'm not sure what's going on there then [19:00:21] bmansurov: you'll have to debug nothing obvious i can think of [19:00:28] ok thanks [19:00:40] window.ve < does that exist? [19:11:50] (03PS1) 10Robmoen: Change wikigrok tags to buttons and adjust spacing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 [19:22:46] (03PS1) 10Bmansurov: Save summary in VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169778 (https://bugzilla.wikimedia.org/72612) [19:25:01] 3MobileFrontend / 3stable: Return of giant hamburger? now repro-able - 10https://bugzilla.wikimedia.org/72695 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Steps to repro what I think might be the "giant hamburger bug" we just closed: 1. Go to any article in stable that is in more than 1 lang... [19:25:33] 3MobileFrontend / 3stable: Return of giant hamburger? now repro-able - 10https://bugzilla.wikimedia.org/72695#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/sJfuS5Vl [19:32:42] 3MobileFrontend / 3stable: Return of giant hamburger? now repro-able - 10https://bugzilla.wikimedia.org/72695#c2 (10Maryana Pinchuk) This is on iPhone 5/iOS 8 [19:45:40] (03PS1) 10Bmansurov: Hygiene: Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169782 (https://bugzilla.wikimedia.org/72657) [19:50:55] (03CR) 10Florianschmidtwelzow: [C: 031] Save summary in VisualEditor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169778 (https://bugzilla.wikimedia.org/72612) (owner: 10Bmansurov) [19:51:50] (03CR) 10Bmansurov: Save summary in VisualEditor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169778 (https://bugzilla.wikimedia.org/72612) (owner: 10Bmansurov) [19:55:29] (03CR) 10Florianschmidtwelzow: Save summary in VisualEditor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169778 (https://bugzilla.wikimedia.org/72612) (owner: 10Bmansurov) [20:00:13] 3MobileFrontend / 3stable: Return of giant hamburger? now repro-able - 10https://bugzilla.wikimedia.org/72695#c3 (10Bahodir Mansurov) I'm not able to reproduce this in the Chrome emulator, somebody may want to test it on a real device? [20:11:44] 3MobileFrontend / 3alpha: Issues with icons in alpha. Get fixed so we can move it to beta. - 10https://bugzilla.wikimedia.org/72653#c2 (10Jon) Also * close icon in image overlay repeats itself [20:11:44] 3MobileFrontend / 3Hygiene: [Tracking] MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181 (10Jon) [20:12:34] jdlrobson: want to break up some of those icon issues or are you doing 'em all in one change? [20:12:39] *swoop [20:17:04] jdlrobson: should 'tap' event be an alias to 'click' in browsers where tap is not defined? this will save us from listening to both 'tap' and 'click'. [20:17:11] (03PS5) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [20:17:13] (03PS3) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [20:17:15] (03PS2) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [20:17:17] (03PS1) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [20:17:18] bmansurov: that might be an easier fix yeh [20:17:25] k [20:17:27] bmansurov: do you want to do an alternative patch that sets that up? [20:17:35] sure [20:17:46] bmansurov: scool :) [20:18:20] (03CR) 10jenkins-bot: [V: 04-1] Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 (owner: 10Jdlrobson) [20:19:42] (03PS2) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [20:19:59] rmoen: ^ will blow your mind [20:20:25] rmoen: Don't forget to add your spike results to https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok/Claim_suggestions [20:27:58] (03CR) 10Phuedx: [C: 032] Save summary in VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169778 (https://bugzilla.wikimedia.org/72612) (owner: 10Bmansurov) [20:28:35] (03Merged) 10jenkins-bot: Save summary in VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169778 (https://bugzilla.wikimedia.org/72612) (owner: 10Bmansurov) [20:31:14] 3MobileFrontend / 3stable: VisualEditor edit summary is not saved - 10https://bugzilla.wikimedia.org/72612 (10Sam Smith) 5PATC>3RESO/FIX [20:33:48] (03PS19) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [20:38:12] jdlrobson: You not in any channel other than #wikimedia-mobile? [20:38:29] jdlrobson: Can you +1 the rl-template commit? [20:40:46] (03CR) 10Phuedx: [C: 032] Hygiene: Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169782 (https://bugzilla.wikimedia.org/72657) (owner: 10Bmansurov) [20:41:24] (03Merged) 10jenkins-bot: Hygiene: Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169782 (https://bugzilla.wikimedia.org/72657) (owner: 10Bmansurov) [20:44:00] dbrant: So, are we good to release our fragment refactor to market tomorrow? [20:44:07] dbrant: Without the full text search stuff? [20:44:55] Deskana: well... does this mean that it'll be another month until the search stuff is released? [20:45:13] Deskana: I would much rather wait just a little bit more, and get the search stuff in there [20:45:14] anyone object to me taking a swing at the a/b test card tomorrow? [20:45:28] bmansurov, joakino_, jdlrobson, kaldari: ^ ? [20:45:38] dbrant: Well, this process was put in place at Erik's request, so I'm not eager to throw it out of the window in the first instance. :) [20:45:50] phuedx: go for it [20:45:53] phuedx: fine with me [20:46:00] i picked it up just now [20:46:06] but it's 8:45 here [20:46:15] and i didn't want to pick it up and then not work on it for 12 hours [20:46:27] :) [20:46:28] we'll find something else to work on ;) [20:46:34] phuedx: infoboxes 2.0! [20:46:36] jdlrobson: I sent you some wallpaper alternatives for the trello board, I think you are the only one who can change it [20:46:40] INFOBOXES!!! [20:47:00] bmansurov: there's the 4 hour investigation card [20:47:04] which sounds /amazing/ [20:47:13] dbrant: That said, I don't intend for this process to be totally prescriptive. If we think search is ready (which it's not right now, imo) then we can look at scheduling something earlier. [20:47:16] jdlrobson: you just reminded me, i should take a look at that patch! [20:47:17] dbrant: How does that sound? :) [20:47:22] ok [20:47:32] phuedx: it's pretty epic now [20:47:44] phuedx: check ut https://gerrit.wikimedia.org/r/169792 [20:47:53] http://localhost:8080/wiki/Albert_Einstein?wikidataid=Q937&mobileaction=alpha is a good example [20:48:06] Deskana: what do we need for search to be considered ready? [20:48:08] bmansurov: i'm only joking, that investigation sorta scares me [20:48:09] Deskana: you mean do a release tomorrow, and follow up with another release soon thereafter? (i.e. less than a month) [20:48:11] :/ [20:48:16] (03PS1) 10Anomie: Add i18n for API module help [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169824 [20:48:24] (03PS1) 10Anomie: Add i18n for API module help [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169828 [20:48:27] MaxSem: I’m in the mobile story review meeting, Ithought you were here [20:48:27] jdlrobson: i'm going to merge it because of the commit message [20:48:37] phuedx: haha [20:48:40] dbrant: That's something we can consider, yeah. [20:48:47] DarTar, nah:) [20:48:50] phuedx: don't be scared, we're all going to ...;) [20:49:09] (03PS1) 10Anomie: Add i18n for API module help [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169848 [20:49:11] (03PS1) 10Anomie: Add i18n for API module help [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169849 [20:49:27] moizsyed: did rmoen chat to you about the wikigrok design tweaks? [20:49:34] jdlrobson: ZOMG!!! [20:49:37] bearND: Firstly, I think we need to make another design pass with Vibha. Quite a few people that I showed it to said it needed a bit of polishing, Vibha included. [20:49:38] SHIP IT!!! [20:49:47] jdlrobson: we have a meeting soon [20:50:09] jdlrobson: http://shipitsquirrel.github.io/ [20:50:27] phuedx: next up editing wikidata :P [20:50:37] can't be too hard?! [20:50:46] bearND: Secondly, I think it just needs to be tested more rigorously. We shouldn't just push things out without getting them tested. [20:50:56] jdlrobson: estimate: large 1, small 2 [20:51:01] ;) [20:51:16] bearND: Whether that's with The Specialists Guild (our QA contractors that we're using on iOS) or with Rummana and Elena is an open question. [20:51:30] (03PS1) 10Mhurd: Cleaned up About page text a bit. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169859 [20:51:33] alright dude [20:51:34] *s [20:51:40] peeps [20:51:42] even [20:51:45] am orf [20:51:54] episode of the west wing and hot milk [20:52:00] see ya [20:52:12] g'night [20:52:30] Deskana: eager to get a hands on a list of search improvements needed. Let's get vbamba's review asap. She can download the beta app that has been published today. [20:52:41] bearND: Agreed! [20:52:43] brion: tiny patch: https://gerrit.wikimedia.org/r/169859 [20:52:53] \o/ [20:53:22] brion: if we can merge this and the incoming translations i’d say good to go for market :) [20:53:23] dbrant, bearND: But, in the mean time, we should stick to our release process. Are we good to go for tomorrow? [20:53:30] mhurd: what’s with the substringFromIndex? [20:53:50] brion: removing the “http://“ from display like on android [20:53:56] Deskana: bearND: alright then; we'll do a release tomorrow! (with a possible off-schedule release in the coming weeks) [20:54:11] ahh [20:54:21] brion: figure prob ok as the url wont be changing [20:54:33] mhurd, brion: And on the iOS side, are we ready to push the AFNetworking refactor to Apple tomorrow? [20:54:47] Deskana: yep it’s looking good [20:54:53] yay! [20:54:54] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169824 (owner: 10Anomie) [20:54:56] (03CR) 10Brion VIBBER: [C: 032] Cleaned up About page text a bit. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169859 (owner: 10Mhurd) [20:55:08] Excellent. Ill send the email out. [20:55:23] dbrant, bearND, dbrant, bearND: Thanks! :-) [20:55:26] ... [20:55:28] Deskana: i have arch meetings tomorrow from 12:30-2, will be available the rest of the day for apps so can push to apple whenever [20:55:30] mhurd, brion: ^ [20:55:33] kaldari: will do [20:55:43] brion: Sweet. [20:55:55] Deskana: cool! [20:55:58] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169828 (owner: 10Anomie) [20:56:00] thanks [20:56:20] Deskana: dbrant: which bits are we going to release tomorrow? We probably would need to add a commit to hide the searchTypesContainer button [20:56:50] bearND: Search should look exactly as it does in production right now. [20:57:04] buttons [20:57:33] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169849 (owner: 10Anomie) [20:57:39] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169848 (owner: 10Anomie) [20:58:28] dbrant: any ideas how to accomplish ^? [20:59:13] bearND: 1 sec, chatting with vibha [20:59:29] If we keep having these issues then maybe we should go back to having a code freeze. [21:03:09] Deskana: bearND: ah ok, so the thing is, our refactoring work necessitated a change in the behavior of the search bar (turned into a button instead of a text field). We can't have the search looking like it does in production now, and have our fragment changes. [21:03:34] dbrant, bearND: Sorry, I was unclear. Let me clarify. [21:03:56] dbrant, bearND: What I mean is, when you type a query then you just get prefixsearch results and no option to switch and no automatic switching. [21:04:10] It's okay that the search bar itself looks different. That's part of the fragment refactoring. [21:04:54] Deskana: gotcha; in that case, we should be good to go. bearND, agree? [21:05:42] joakino_: nice job on finding a different background for our trello board, now bmansurov doesn’t need to bleed from his eyes anyore [21:05:58] Deskana: that basically means we need to add a commit that hides the searchTypesContainer buttons, as i said earlier, and also disable the automatic switching for the production app. [21:06:10] dbrant: ^ Or do we already have that? [21:06:15] kristenlans: :D [21:06:23] nice, thanks to whoever was involved in this ;) [21:06:52] bearND: That sounds right to me. [21:06:53] kristenlans: I liked the depressed robot but the background was to bright [21:09:09] joakino_: we still have “Don’t Panic”, which is critical ;-) [21:10:44] bearND: couldn't we just base off the Beta from the 20th? it looks like it has the fragment updates, but not the search updates. [21:10:48] kristenlans: indeed [21:13:45] (03PS1) 10Jhernandez: Fix bug 72637 - No JS heading CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 [21:14:21] bearND: or indeed, base off today's beta, and cherrypick a patch that enables the full-search killswitch. [21:14:45] (03PS1) 10MaxSem: Purge memcached on links update [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169916 [21:14:57] kaldari, ^^^ [21:15:14] MaxSem: nice [21:16:23] (03PS1) 10Jdlrobson: WIP: Date formatting in infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169917 [21:16:48] dbrant: Do we already had a patch to cherry-pick from? Otherwise we should just create one, and make sure it's merged right after the beta bits (i.e. hold off merging anything else until then). [21:17:12] either way we'll get a new commit on master right after the bump commit [21:17:42] (03PS1) 10MaxSem: Register messages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169918 [21:17:46] bearND: i've got a better idea... one sec... [21:18:00] kaldari, we aso definitely want this ^_^ [21:18:33] dbrant: ^ since we don't need special branches anymore we can just tag the prod release based on that one additional commit. Sounds pretty straighforward to me. [21:19:15] (03PS1) 10MaxSem: Add Sam to credits [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169921 [21:19:23] hehe [21:22:17] (03CR) 10Kaldari: [C: 032] Register messages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169918 (owner: 10MaxSem) [21:23:20] (03PS1) 10Dbrant: Disable full-text search for production (for now) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169924 [21:23:32] bearND: ^ how about that? [21:25:06] (03Merged) 10jenkins-bot: Register messages [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169918 (owner: 10MaxSem) [21:25:28] dbrant: Nice. [21:27:05] greg-g, when can we schedule WikiGrok deployment? [21:27:27] MaxSem: please email, in the middle of a 2 hour string of 1:1s [21:27:33] ah:) [21:29:27] (03PS1) 10Bmansurov: Close search overlay when clicking on the overlay background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169927 (https://bugzilla.wikimedia.org/72656) [21:30:07] (03CR) 10BearND: [C: 032] "wfm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169924 (owner: 10Dbrant) [21:30:24] jdlrobson: tap was already falling back to click, so I didn't change it [21:30:47] (03Merged) 10jenkins-bot: Disable full-text search for production (for now) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/169924 (owner: 10Dbrant) [21:31:43] Deskana: ^ [21:32:45] bearND: Deskana: we should be all set, then [21:33:20] dbrant: agreed [21:34:09] dbrant, bearND: Thanks guys. :) [21:34:43] dbrant: Deskana: need more testing, of course [21:36:44] MaxSem: what was the name of the node.js guy on wikizero? [21:37:06] jhobs? [21:37:26] bearND, dbrant: I'll pull it and take a look. [21:37:30] MaxSem: and on the staff page?https://wikimediafoundation.org/wiki/Staff_and_contractors?showall=1#Wikipedia_Zero [21:37:35] i'm so bad with names [21:37:46] jeff hobson [21:39:53] Deskana: if you want to test it like a production app then also switch to build variant prodDebug or prodRelease in AS [21:40:57] (03CR) 10Bmansurov: "looks great, I think you need to update the _renderSuggestions method documentation too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 (owner: 10Robmoen) [21:41:02] (03CR) 10Kaldari: [C: 04-1] Purge memcached on links update (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169916 (owner: 10MaxSem) [21:41:11] thx MaxSem [21:42:12] (03PS1) 10MaxSem: API profiling [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169930 [21:44:58] (03PS2) 10MaxSem: Purge memcached on links update [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169916 [21:45:23] (03CR) 10MaxSem: [C: 032] "Trivial." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169930 (owner: 10MaxSem) [21:45:41] (03Merged) 10jenkins-bot: API profiling [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169930 (owner: 10MaxSem) [21:47:58] (03CR) 10Bmansurov: Correctly identify humans (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 (owner: 10Jdlrobson) [21:50:25] (03PS1) 10MaxSem: Fix phpcs warnings [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169932 [21:52:43] (03CR) 10Bmansurov: "I think you should remove "Fix bug 72637 - " from the commit message and add this line as the last line (before the Change-id line). Also " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (owner: 10Jhernandez) [21:54:45] 3MobileFrontend / 3beta: In edit I can't scroll to the top to access the toolbar in beta + alpha - 10https://bugzilla.wikimedia.org/72707 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None In the edit screen, the toolbar gets scrolled up and I can't access it. Not in stable, only in beta and alpha. [21:55:29] 3MobileFrontend / 3beta: In edit I can't scroll to the top to access the toolbar in beta + alpha - 10https://bugzilla.wikimedia.org/72707#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/hg05dlxH [21:56:17] TrevorParscal: sent [21:56:25] (03PS2) 10Jhernandez: No JS heading CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) [21:57:04] (03CR) 10Jhernandez: "Done!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) (owner: 10Jhernandez) [21:58:05] TrevorParscal: hmm it shows an attachment… let me try again [21:58:16] 3MobileFrontend / 3General/Unknown: VisualEditor Mobile: There is no Preview bar appearing at the top in iOS Safari for tablet and desktop browser while saving the edited content - 10https://bugzilla.wikimedia.org/72709 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16946 -... [21:58:49] TrevorParscal: check it now [21:59:04] mhurd: looking good - thanks man [21:59:18] TrevorParscal: yay! yw! [22:00:30] 3MobileFrontend / 3General/Unknown: VisualEditor Mobile: There is no Preview bar appearing at the top in iOS Safari for tablet and desktop browser while saving the edited content - 10https://bugzilla.wikimedia.org/72709#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https:/... [22:00:31] 3MobileFrontend / 3General/Unknown: VisualEditor Mobile: There is no Preview bar appearing at the top in iOS Safari for tablet and desktop browser while saving the edited content - 10https://bugzilla.wikimedia.org/72709#c1 (10Rummana Yasmeen) Created attachment 16947 --> https://bugzilla.wikimedia.org/atta... [22:00:40] moizsyed: hangout round 2 ? [22:01:29] (03CR) 10Bmansurov: [C: 04-1] No JS heading CSS (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) (owner: 10Jhernandez) [22:02:02] MaxSem: Just added this to current sprint if you're interested: https://trello.com/c/kNknLksC/52-5-create-api-for-pulling-wikidata-descriptions-via-local-wiki [22:03:21] joakino: sorry for being a pain, but I think the first commit message should be informative something like: "Fix header styling issue with JavaScript disabled" [22:04:25] bmansurov: yeah sure, you are right, i'll fix it [22:05:59] 3MobileFrontend / 3Hygiene: Deprecate use of EventEmitter.prototype.one in MobileFrontend - 10https://bugzilla.wikimedia.org/72711 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon We should be using EventEmitter.prototype.once instead See https://gerrit.wikimedia.org/r/168724 [22:06:25] (03PS3) 10Jhernandez: Fix search input and search button missalignment (js disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) [22:07:06] bmansurov: there we go. i was in the middle of something when i edited that quickly and didn't think about it. [22:07:14] kaldari: can you merge https://gerrit.wikimedia.org/r/169769 prior to tomorrows deployment [22:08:52] ok deployments are wed now scrap that [22:08:54] (03PS2) 10Robmoen: Change WikiGrok tags elements to buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 [22:09:39] moizsyed, i have made final tweaks, want to look really quick ? [22:09:44] sure [22:09:56] (03PS3) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [22:09:58] (03PS6) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [22:09:58] imgur some screenshot [22:09:59] rejoin ? [22:10:00] (03PS4) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [22:10:02] (03PS3) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [22:10:02] oh ok [22:10:07] (03Abandoned) 10Jdlrobson: WIP: Date formatting in infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169917 (owner: 10Jdlrobson) [22:10:18] joakino: have you read my comment to patch 2? [22:10:42] 3MobileFrontend / 3Hygiene: Deprecate use of EventEmitter.prototype.one in MobileFrontend - 10https://bugzilla.wikimedia.org/72711#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/WuNMR6M2 [22:11:14] bmansurov: no, im on it [22:11:55] kaldari: when you get a chance, can you leave your thoughts on phuedx's comment here: https://gerrit.wikimedia.org/r/#/c/169626/ thanks [22:11:58] (03PS7) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [22:12:07] moizsyed: http://i.imgur.com/Xfvsw2k.png [22:12:11] http://i.imgur.com/LlSpzCy.png [22:12:52] rmoen: that looks a lot better [22:13:14] rmoen: the left/right padding on those buttons is a bit too much, right? [22:13:53] moizsyed: the inner padding of the buttons ? [22:13:59] rmoen: yeah [22:14:08] moizsyed: standard mw-ui-button padding. [22:14:11] i think its 1em [22:14:33] rmoen: alright lets stick with it [22:14:37] rmoen: i think this is good [22:14:41] rmoen: SHIP IT [22:14:43] ok [22:14:48] its in gerrit [22:14:51] nice [22:14:55] (03PS3) 10Jdlrobson: Change WikiGrok tags elements to buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 (owner: 10Robmoen) [22:15:03] (03CR) 10Jdlrobson: Change WikiGrok tags elements to buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 (owner: 10Robmoen) [22:15:08] moizsyed: will you leave a comment on the card ? [22:15:11] bmansurov: the width of the magnifying glass is 24px + 0.7em, what do you recommend [22:15:17] (03CR) 10Jdlrobson: [C: 031] "@rmoen feel free to +2 if you are happy with my change." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 (owner: 10Robmoen) [22:15:23] rmoen: sure, i'll bless your card with a comment [22:15:32] moizsyed: ty [22:15:37] maybe change em to px above? [22:15:40] joakino: ^ [22:16:04] rmoen: feel free to +2 [22:16:10] jdlrobson: awe you removed the checkbox ;/ [22:16:11] i made a slight tweak to the php code [22:16:22] joakino: I mean change it here: margin: 0 .2em 0 .5em; [22:16:26] rmoen: it's gone. it's over. I knew it was a waste of time when i built it ;-) [22:16:33] jdlrobson: i was torn, if I should remove it or not [22:16:46] the code is out there somewhere [22:16:48] but YAGNI [22:16:51] yeah [22:17:18] (03CR) 10MSyed: [C: 032 V: 032] "Worked with Rob on this, has my stamp of approval!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169776 (owner: 10Robmoen) [22:17:24] jdlrobson: well jon, i thought it was beautiful. but, YAGNI aye [22:17:49] rmoen: uh oh, i accidentally merged it, haha [22:17:55] i think its ok [22:17:58] ;) [22:18:05] bmansurov: that 0.7em at default size are about 12px [22:18:05] rmoen: yeees [22:18:05] ty [22:18:27] bmansurov: most of the margins are in ems, i'm not sure if there is a reason [22:18:41] moizsyed, and don't V+2 please [22:18:43] joakino: hmm [22:18:57] MaxSem: sorry that was a mistake, wont happen again [22:18:58] (03CR) 10Jdlrobson: [C: 032] Close search overlay when clicking on the overlay background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169927 (https://bugzilla.wikimedia.org/72656) (owner: 10Bmansurov) [22:19:21] joakino: I think in here, it's ok to use pixles [22:19:33] (03Merged) 10jenkins-bot: Close search overlay when clicking on the overlay background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169927 (https://bugzilla.wikimedia.org/72656) (owner: 10Bmansurov) [22:19:48] hey, mobly peeps [22:19:49] bmansurov: the biggest problem there is that the heading has display:inherit in the sub elements so there end up table-cells nested on table-cells, which firefox doesn't like [22:19:56] Ironholds: hello [22:20:10] can you think of any reason why I'd have a mobile app request that claims to be using google's AppEngine but be on iOS? [22:20:17] joakino: i see [22:20:22] moizsyed, MaxSem: I'm not sure what the issue with V+2'in is if Jenkins has already done it [22:20:44] what if it didn't? [22:21:10] bmansurov: in chrome it is aligned properly, because chrome doesn't give a fuck about nested display:table-cells [22:21:11] I understand, not a good habit. Just wondering if there is any harm since it already had [22:22:05] bmansurov: in any case, i'm just going to remove that margin, since that button is only used on the no-js version, and it doesn't actually matter [22:22:34] bmansurov: i'm gonna get coffe [22:22:41] coffee, i'll ping you back [22:22:52] kaldari: so to add alma mater i need to modify api2.php ? [22:24:28] joakino: I don't think you should remove the margin: just change it to px. something like 1em = 16px [22:24:29] rmoen: yes, but that's the easy part.... [22:25:00] kaldari: ok ;) what is the hard part ? [22:25:48] rmoen: The hard part is you need to write a script to generate the alma mater suggestions, similar to the scripts here: https://bitbucket.org/magnusmanske/wikidata-game/src/c5166cffe4f9274c8d2db0f99297e4ba3c925ff2/tools/?at=master [22:26:00] kaldari: aye [22:26:07] cool [22:26:29] kaldari: so i do need lab server access [22:26:34] rmoen: yes [22:26:51] Do you have a Tool Labs account currently? [22:26:56] yeah [22:27:18] wait, no i don't think so [22:27:28] (03PS1) 10Bmansurov: Fix documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169945 [22:27:30] i have a labs.wikimedia account [22:27:43] rmoen: See if you can ssh to tools-login.wmflabs.org [22:27:50] ok [22:29:03] MaxSem: I scheduled a meeting with Lydia at 5pm today. Can you help flesh out this Etherpad for agenda items: http://etherpad.wikimedia.org/p/Wikidata_technical_needs [22:29:25] kaldari: nope [22:30:10] rmoen: See https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Help#Getting_access_to_Tool_Labs [22:30:19] ok [22:31:06] rmoen: you may want to hop on #wikimedia-labs as well. If you have any trouble ping Coren (or let me know if you can't make any progress on access) [22:31:20] ok [22:31:27] thanks [22:31:43] rmoen: Should be fairly easy since you already have a labs account [22:31:50] (I assume) [22:32:03] Oh yeah, you said so :) [22:33:49] bmansurov: ok [22:33:59] rmoen: Once you have access I'll be able to add you as a maintainer to the projects [22:35:25] (03PS3) 10Jdlrobson: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) [22:35:33] bmansurov: i'm going to change it to the px values that firefox computes [22:35:45] sure [22:35:57] 3MobileFrontend / 3stable: Can't dismiss search interface by clicking on the rest of the page - 10https://bugzilla.wikimedia.org/72656 (10Jon) 5PATC>3RESO/FIX [22:36:58] 3MobileFrontend / 3Hygiene: Hygiene: Wikigrok lacks documentation - 10https://bugzilla.wikimedia.org/72657 (10Jon) 5PATC>3RESO/FIX [22:38:33] (03PS4) 10Jhernandez: Fix search input and search button missalignment (js disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) [22:38:51] joakino: a better idea maybe to override those values only when js is disabled [22:39:03] Any SFers have a sense of whether Lovelace, Yongle, or Hopper is better for a big meeting? [22:39:16] (03CR) 10Jhernandez: "I've also changed the margin to px in the last patch, and then added the width and margin to the negative margin." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) (owner: 10Jhernandez) [22:40:05] bmansurov: yeah the negative margin is only applied on no-js [22:42:02] kristenlans: Yongle is the biggest room in the office. [22:42:03] bmansurov: in fact that button has the class no-js-only, so it will only appear on no-js sites, all of this only happens when js is disabled [22:42:18] Deskana: thanks :-) [22:42:19] cool [22:43:25] joakino: I think you need to add padding-right: 36px; too [22:43:43] joakino: otherwise the end of the text is covered by the button [22:43:45] 3MobileFrontend / 3Hygiene: Build jsduck through Gruntfile - 10https://bugzilla.wikimedia.org/72718 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon VisualEditor build documentation via Grunt [1] and publish via Jenkins. One of the benefits of this is you can use a jsduckcatconfig that pulls in documentation... [22:45:22] joakino: also make the width of the window smaller than 280px and you'll see that borders appear around the input. The padding looks off there [22:45:28] 3MobileFrontend / 3Hygiene: Build jsduck through Gruntfile - 10https://bugzilla.wikimedia.org/72718#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/w96Isqis [22:45:36] bmansurov: true to the padding [22:45:52] bmansurov: about making the window small, i don't think this has to do with this bug [22:46:14] MaxSem: I scheduled a meeting with Lydia at 5pm today. Can you help flesh out this Etherpad for agenda items: http://etherpad.wikimedia.org/p/Wikidata_technical_needs [22:46:25] joakino: yes, but it's an easy fix ;) not sure if you should do it here or create a new patch [22:46:34] moizsyed: chambers? [22:46:47] I don’t know where james is [22:46:51] bmansurov: also it only happens with the mobile design view, resizing the browsers normally doesn't get me that, so i'm not sure if it would happen on actual mobile devices [22:46:58] bmansurov: i think that goes on another bug [22:47:06] ok [22:47:24] bmansurov: file one, and we can tackle it independently [22:47:33] i'm gonna add the padding right! [22:50:02] (03PS5) 10Jhernandez: Fix search input and search button missalignment (js disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) [22:50:16] bmansurov: good catch the padding-right! thx [22:50:32] (03PS2) 10Jdlrobson: Tap code be gone! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) [22:51:41] (03CR) 10Bmansurov: [C: 032] Fix search input and search button missalignment (js disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) (owner: 10Jhernandez) [22:51:54] kaldari: where is a good place to look in the tool server for this stuff ? [22:51:58] i'm in [22:52:18] (03Merged) 10jenkins-bot: Fix search input and search button missalignment (js disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169915 (https://bugzilla.wikimedia.org/72637) (owner: 10Jhernandez) [22:53:14] rmoen: one sec, I'll see if I can add you to the projects... [22:53:23] (03CR) 10Jdlrobson: [C: 04-1] "Rebase needed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [22:53:33] rmoen: I think there's usually a delay before people can be added... [22:54:18] (03CR) 10Jdlrobson: [C: 031] "Max?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169828 (owner: 10Anomie) [22:54:36] (03PS4) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [22:54:39] (03PS2) 10Jdlrobson: Hygiene: Fix documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169945 (owner: 10Bmansurov) [22:54:44] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169945 (owner: 10Bmansurov) [22:54:50] rmoen: added you to wikigrok project [22:55:25] (03Merged) 10jenkins-bot: Hygiene: Fix documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169945 (owner: 10Bmansurov) [22:55:45] rmoen: And actually, I don't really need to add you to Magnus's project, as long as you have the table schema (that I just emailed you) [22:56:06] kaldari: ok perfecto [22:56:14] rmoen: So once you're logged in to tool labs, try 'become wikigrok' [22:56:27] (03CR) 10Jdlrobson: [C: 04-1] "* In alpha version buttons are centered but not in beta version" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [22:57:02] kaldari: awesome [22:57:17] that worked? [22:57:18] ty [22:57:19] yes [22:57:41] I think i'm set [22:57:43] ok, lemme see if I can explain what you need to do now... [22:57:47] jdlrobson: do I need to make the alpha buttons aligned to the left too? beta buttons was left aligned recently: https://trello.com/c/JltOtA2q/46-3-wikigrok-v-b-better-tag-styling [22:58:40] rmoen: if you CD into public_html/tools, you'll see a script that Sam wrote to update one of the suggestion tables... [22:59:05] rmoen: You'll want to write a similar script, but better... [22:59:15] oh ok [22:59:33] kaldari: he wrote update_people_no_date.php ? [22:59:49] the only script i'm setting here [22:59:55] (03CR) 10MaxSem: [C: 04-2] "Alpha or not, this must not make API requests on every page view." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [22:59:56] rmoen: Sam's script is only half finished as it only currently identifies articles that need dates of birth and death, but it doesn't actually supply the suggestion values. [23:00:21] rmoen: You'll want to write something more like https://bitbucket.org/magnusmanske/wikidata-game/src/c5166cffe4f9274c8d2db0f99297e4ba3c925ff2/tools/update_occupation.php?at=master [23:01:00] rmoen: That generates actual suggestions and populates the potential_alma_mater table (that I already created) [23:01:16] cool [23:02:22] rmoen: That table is in the s51999__merge_candidates db (as you can see from the email), but you can just steal Sam's code for connecting to the db, just change the table name. [23:04:01] (03PS5) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [23:04:08] rmoen: What's your GitHub username? [23:04:23] rmoen: I'll add you as a collaborator to the repo [23:04:41] 3MobileFrontend / 3stable: Login icon showing on Special:MobileMenu for non-JS users - 10https://bugzilla.wikimedia.org/72723 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16949 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16949&action=edit Eek See screenshot. In JS we don't... [23:04:42] 3MobileFrontend / 3Hygiene: WikigrokApi and Dialog tests - 10https://bugzilla.wikimedia.org/72720#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/T3ORerDl [23:05:11] kaldari: rmoen [23:05:27] 3MobileFrontend / 3stable: Login icon showing on Special:MobileMenu for non-JS users - 10https://bugzilla.wikimedia.org/72723#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3PaCFMdb [23:05:38] rmoen: Done: https://github.com/kaldari/WikiGrokAPI [23:05:53] All the code in that Tool Labs project is pulled from that GitHub repo [23:06:23] right [23:06:39] rmoen: So you can just clone that repo to your local machine and work from there, or work directly on Tools Labs and push from there to GitHub if you prefer. [23:07:00] kaldari: ahh nice so i don't need to work in a fork and do pull reqs [23:07:10] jdlrobson: in here (https://trello.com/c/WuNMR6M2/54-bug-72711-deprecate-use-of-eventemitter-prototype-one-in-mobilefrontend) do you mean change all one's to once's? you've already deprecated it in your patch [23:07:12] rmoen: Not unless you want to :) [23:07:19] kaldari: not really ;) [23:07:30] bmansurov: don't pick up stuff from in analysis without maryana's permission :) [23:07:35] ok this is making much more sense now [23:07:41] that's not how things work :) [23:07:44] rmoen: I'm pretty sure if you're a collaborator you can push directly to the repo, but if you have any trouble, let me know. [23:08:00] :) [23:08:31] kaldari: Sounds good [23:09:57] jdlrobson: sometimes i get excited ;) [23:10:15] 3MobileFrontend / 3stable: Redirect to editor after login doesn't work for lead section - 10https://bugzilla.wikimedia.org/72580 (10Florian) 5PATC>3RESO/FIX [23:10:29] (03CR) 10Kaldari: [C: 032] Purge memcached on links update [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169916 (owner: 10MaxSem) [23:10:46] (03Merged) 10jenkins-bot: Purge memcached on links update [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169916 (owner: 10MaxSem) [23:11:02] (03PS1) 10Dr0ptp4kt: Support colorized zero-rating messaging [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 [23:11:14] 3MobileFrontend / 3Hygiene: WikigrokApi and Dialog tests - 10https://bugzilla.wikimedia.org/72720 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon With so many people coding on these things we are doomed if we don't add some tests to cover what they are supposed to do. Unit tests please! :) [23:12:14] 3MobileFrontend / 3stable: VisualEditor edit summary is not saved - 10https://bugzilla.wikimedia.org/72612#c6 (10Florian) Maybe LD this patch in the next SWAT? The latest wmf branch was created today (without this patch), so Wikipedias will get thid patch in 14 days, which is a long time :/ The edit summary... [23:12:57] bmansurov: i moved some more bugs over into ready for dev :) [23:13:05] grab em if you're bored [23:13:15] Maryana: thanks [23:13:39] i need to check with kaldari, but we'll probably move some more stories into the sprint today/tomorrow [23:13:52] so look out for those soon, too :) [23:15:27] (03PS1) 10MaxSem: Save summary in VisualEditor [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169952 (https://bugzilla.wikimedia.org/72612) [23:15:50] (03PS1) 10MaxSem: Save summary in VisualEditor [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169953 (https://bugzilla.wikimedia.org/72612) [23:16:15] (03CR) 10MaxSem: [C: 032 V: 032] Save summary in VisualEditor [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169952 (https://bugzilla.wikimedia.org/72612) (owner: 10MaxSem) [23:16:19] (03CR) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [23:16:27] (03PS7) 10Kaldari: Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 [23:16:31] (03CR) 10MaxSem: [C: 032] Save summary in VisualEditor [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169953 (https://bugzilla.wikimedia.org/72612) (owner: 10MaxSem) [23:17:04] (03CR) 10MaxSem: [C: 032] Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [23:18:30] (03PS1) 10Kaldari: Adding FIXME comment about module dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169955 [23:19:54] (03Merged) 10jenkins-bot: Save summary in VisualEditor [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169953 (https://bugzilla.wikimedia.org/72612) (owner: 10MaxSem) [23:20:54] (03Merged) 10jenkins-bot: Allowing UserJS and UserCSS within the Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168815 (owner: 10Kaldari) [23:21:25] (03PS1) 10Bmansurov: Remove login icon and a border from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) [23:24:26] kaity: hey, do you mean the browser toolbar here: https://bugzilla.wikimedia.org/show_bug.cgi?id=72707 [23:25:30] bmansurov: the edit toolbar, which includes back button, "Editing article title" and the next button [23:26:06] kaity: does it happen on a smartphone only? [23:26:38] (03PS1) 10Dbrant: prepare for next development iteration 1.3-SNAPSHOT [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169959 [23:27:11] kaity: if yes, what was the device you tested it on? [23:27:35] bmansurov: iphone [23:28:14] kaity: do you know the version? [23:28:19] bmansurov: doesn't happen on desktop [23:28:39] hey mobile webbers - is it possible for me to start playing with wikigrok in production yet? [23:28:53] bmansurov: ios 8 [23:29:10] bmansurov: Also its only on beta and alpha, not on stable [23:29:13] (03PS2) 10Jdlrobson: Introduce WatchList class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 [23:29:14] kaity: thanks for the info [23:29:20] bmansurov: sure [23:29:28] awjr: sure thang [23:29:36] awjr: you just gotta find an article it works on [23:29:42] and jump through all the requirements [23:29:51] will it just show up when i find the right article jdlrobson? [23:29:58] 1) be logged in 2 ) be on a phone 3) visit a person 4) hope [23:30:03] lol [23:30:07] stable? [23:30:24] oh yeh 5) beta or alpha [23:30:42] 3MobileFrontend / 3beta: In edit I can't scroll to the top to access the toolbar in beta + alpha - 10https://bugzilla.wikimedia.org/72707#c2 (10Bahodir Mansurov) Apparently, it happens on iOS8. I was not able to reproduce it in an emulated chrome. [23:30:44] what makes a person the right kind of person [23:31:04] oo i found one [23:31:27] http://en.m.wikipedia.org/wiki/Jesus?mobileaction=alpha is an amusing one [23:33:22] (03CR) 10Jdlrobson: [C: 04-1] "needed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169955 (owner: 10Kaldari) [23:33:54] MaxSem: we are doing api requests on every page already.. lolz [23:33:58] :D [23:34:04] MaxSem: and it's api requests to wikidata.org anyway [23:34:11] still [23:34:16] MaxSem: don't stifle innovation [23:34:18] :P [23:34:29] you will not be able to do them for anons [23:35:05] (03PS1) 10Dbrant: Handle network-related exceptions when doing a POST. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 [23:35:07] (03CR) 10Jdlrobson: [C: 04-1] Remove login icon and a border from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [23:35:42] 3MobileFrontend / 3stable: Return of giant hamburger? now repro-able - 10https://bugzilla.wikimedia.org/72695#c4 (10Jhernandez) I'll try with the iOS simulator (a good excuse to download it) [23:35:43] (03CR) 10Jdlrobson: "See less/specials/mobilemenu.less" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [23:35:56] (03PS3) 10Jdlrobson: Tap code be gone! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) [23:36:04] (03PS3) 10Dbrant: Allow custom headers and remote endpoint to be specified at the same time when constructing Api [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/164873 (owner: 10Alex Monk) [23:36:28] MaxSem: so if I just make it user logged in only you'll un -2 it? [23:36:37] no [23:36:39] why not [23:36:50] please do it right [23:36:56] also srsly someone merge https://gerrit.wikimedia.org/r/169769 - it should be lightning deployed [23:37:11] (and https://gerrit.wikimedia.org/r/169582) [23:37:14] once again, "it's beta" is not a good reason to dump everything into it] [23:37:22] MaxSem: it's not beta. It's alpha [23:37:26] whatever [23:37:45] (03PS4) 10Dbrant: Allow custom headers and remote endpoint to be specified at the same time when constructing Api [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/164873 (owner: 10Alex Monk) [23:38:12] MaxSem: how are we supposed to fix the world if we don't do scary things? [23:38:26] do pretty things [23:38:32] (03PS4) 10Jdlrobson: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) [23:38:47] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None In stable enwiki on iPhone 5/iOS8: 1) go to Settings 2) tap on the Beta checkbox The word Beta jumps under the checkbox and is obscured... [23:39:26] (03PS2) 10Bmansurov: Remove login icon and a border from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) [23:39:42] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727#c1 (10Maryana Pinchuk) Created attachment 16950 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16950&action=edit screenshot [23:39:58] 3MobileFrontend / 3stable: Language super zoom - 10https://bugzilla.wikimedia.org/72695#c5 (10Jon) Yeh this must be ios specific. It doesn't sound like it is the same as the giant hamburger issue [23:40:13] 3MobileFrontend / 3stable: Language super zoom in ios when visiting language overlay - 10https://bugzilla.wikimedia.org/72695 (10Jon) [23:40:28] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/r57DfZ9i [23:40:28] 3MobileFrontend / 3stable: Language super zoom in ios when visiting language overlay - 10https://bugzilla.wikimedia.org/72695#c6 (10Jon) Is it just the language overlay or does search/edit have the same issue? [23:42:49] brion: https://gerrit.wikimedia.org/r/169950 is the patch for colorizing the zero-rating "banner" (UILabel subclass) i mentioned earlier today. when you have a moment, would you please review and, if appropriate, approve? [23:42:50] (03CR) 10BearND: "Are you planning more incompatible changes?" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169959 (owner: 10Dbrant) [23:43:02] dr0ptp4kt: thx looking [23:43:18] brion: thx. [23:44:11] bearND: i'd like to merge Krenair's patch, which I think would break compatibility... [23:45:10] Aren't I just adding a new method? [23:45:47] (and changing a bunch of internal things) [23:46:12] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727#c3 (10Jon) This looks a bit like bug 72189 [23:47:40] Krenair: but when the patch in the app is merged, it'll require the new method... [23:47:50] yes [23:48:05] ok [23:48:26] (03CR) 10Bmansurov: [C: 032] Tools: Use gruntfile to generate pngs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169641 (owner: 10Jdlrobson) [23:48:58] are there any other bios on beta labs besides anne dallas dudley & princess di that show wikigrok? [23:49:26] (03CR) 10Brion VIBBER: "couple quick style notes & a double-check on format" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [23:49:59] jdlrobson: kaldari ^ [23:50:26] dbrant|bbl: good call [23:50:37] (03CR) 10MaxSem: "Eh, minify the pngs?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169641 (owner: 10Jdlrobson) [23:50:55] (03Merged) 10jenkins-bot: Tools: Use gruntfile to generate pngs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169641 (owner: 10Jdlrobson)