[00:05:42] (03CR) 10Jdlrobson: [C: 04-1] Remove login icon and a border from Special:MobileMenu for non-JS users (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [00:06:30] (03PS7) 10Jdlrobson: WIP: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [00:07:09] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [00:07:26] (03CR) 10Jdlrobson: "Note whilst you have the WIP prefix in your commit no one will even look at this code unless you are me wondering why it is still here :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [00:11:20] (03CR) 10Jdlrobson: [C: 04-1] Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [00:16:03] jdlrobson: I can't figure out where the Special:MobileMenu is being rendered. Can you help me find it? [00:16:28] (03PS3) 10Bmansurov: Remove login icon and a border from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) [00:16:44] disable js then click on http://localhost:8080/wiki/Special:MobileMenu [00:16:58] but slow down i'm going to leave the office soon :) [00:17:43] jdlrobson: I did, I'm looking to add label to that page, so I need to find the file where that page is being rendred. maybe tomorrow [00:18:05] (03CR) 10Jdlrobson: "Various issues. The goal of the card as I understood it is ux reuse but the card is not well worded so this may not be the case." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [00:18:21] bmansurov: i'd focus all your attention on this card though if i was you. I suspect some tests will help you. ^ [00:26:12] 3MobileFrontend / 3stable: Language super zoom in ios when visiting language overlay - 10https://bugzilla.wikimedia.org/72695#c7 (10Jhernandez) I've reproduced it using the iOS simulator with iPhone 5 and iOS8.1. It happens both in the language overlay, and in the edit overlay (go to edit, press back button). [00:29:35] (03CR) 10Dr0ptp4kt: "Thanks, will update, research, and if necessary, update some more." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [00:31:17] (03CR) 10Jdlrobson: [C: 04-1] "This fixes the issue when the user is not logged in but when the user is logged in the logout link is still invisible (if you prefer raise" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [00:45:06] (03CR) 10Dr0ptp4kt: "Responding on the typecasting, missed that earlier." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [00:45:29] brion: thanks for the code review. will get to the updates probably tomorrow. [00:47:57] whee [00:51:47] (03PS6) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [00:52:23] (03CR) 10Bmansurov: "Jdlrobson, thanks for the comments. As for #6, I think it should be handled in a separate bug." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [00:53:44] (03CR) 10Bmansurov: "sorry, #5, which is "Infinite spinner in alpha when you visit http://localhost:8080/wiki/Anne%20Dallas%20Dudley?mobileaction=alpha&wikidat" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [00:54:48] (03PS6) 10Dbrant: Face detection in lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 [00:56:27] (03PS4) 10Bmansurov: Remove login icon from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) [00:56:55] bearND, has this crash been dealt with? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7918440 [00:57:57] (03CR) 10Bmansurov: "created another bug for the logout link: https://bugzilla.wikimedia.org/show_bug.cgi?id=72728" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [01:00:30] 3MobileFrontend / 3stable: No logout link in Special:Mobilemenu when JS is disabled - 10https://bugzilla.wikimedia.org/72728#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7XfYssI9 [01:17:11] (03CR) 10Mhurd: "Can we use the existing macro?" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [01:34:30] Krenair: I don't think that crash has been dealt with yet. (cc: dbrant|bbl) [01:35:04] also reported in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7918460 [01:37:53] Krenair: yeah, that looks like the same one [01:37:55] thanks [13:12:13] 3Wikipedia App / 3Android App: NPE crash when creating NearbyResult - 10https://bugzilla.wikimedia.org/72761 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.NullPointerException at org.wikipedia.concurrency.SaneAsyncTask.onCatch(SaneAsyncTask.java:73) at org.wikipedia.nearby.NearbyFragment$6... [13:18:50] (03PS8) 10Florianschmidtwelzow: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 [13:19:31] (03CR) 10jenkins-bot: [V: 04-1] Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [13:20:14] 3Wikipedia App / 3Android App: NPE from android.content.ClipboardManager.setPrimaryClip - 10https://bugzilla.wikimedia.org/72762 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None at android.content.ClipboardManager.setPrimaryClip(ClipboardManager.java:144) at android.content.ClipboardManager.setText(Cli... [13:22:56] 3Wikipedia App / 3Android App: android.content.ActivityNotFoundException: No Activity found to handle Intent (WEB_SEARCH and CHOOSER) - 10https://bugzilla.wikimedia.org/70528#c6 (10Alex Monk) And this one: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7917014 [13:25:48] (03PS3) 10Phuedx: Introduce WatchList class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 (owner: 10Jdlrobson) [13:26:40] (03CR) 10Phuedx: "PS3 is a rebase. It also removes the remaining isWatchList option from watchlist.js." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 (owner: 10Jdlrobson) [13:35:14] (03CR) 10Phuedx: [C: 032] Introduce WatchList class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 (owner: 10Jdlrobson) [13:35:49] (03Merged) 10jenkins-bot: Introduce WatchList class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169616 (owner: 10Jdlrobson) [14:20:24] (03CR) 10Phuedx: "BrowserStack wasn't the greatest to test this with given my connection. It also doesn't have Windows Phone/Blackberry emulators. This shou" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [14:24:58] phuedx: bad internet in Londo, you say? :) [14:25:00] are you on B?T [14:25:02] BT? [14:25:22] yup, but before we go into that, the exchange hasn't been upgraded yet [14:25:24] it is [14:25:26] INFURIATING [14:25:54] phuedx: :) [14:26:06] phuedx: a lot of times in London my 3G was faster than the broadband... [14:26:19] phuedx: and both were much slower than 3G in the pretty beaches of Goa here... it's weird. [14:26:33] i've actually been forcefully disconnected by bt before [14:26:38] i don't know why i stay with 'em [14:27:27] they claimed i hadn't paid a bill [14:27:30] which i had [14:27:38] i phoned them a total of 13 times [14:27:44] and they cut me off [14:27:56] switch! [14:27:56] and sent a note to a credit reporting agency [14:28:11] oh wow [14:28:52] they received my proof a couple of days after along with a copy of a letter of complaint to ofcom [14:28:59] and y'know what [14:29:06] they reconnected me quickly [14:32:12] hey kristenlans [14:32:27] hey phuedx! [14:34:11] * phuedx goes back to whining about his internet connection [14:39:59] phuedx: :( :) [15:05:31] brb restart [15:18:55] bearND: mornin'! [15:19:06] dbrant: hello [15:19:15] bearND: so, are we just releasing from master? [15:19:25] dbrant: yes [15:21:09] dbrant: if there have been some later commits when we release then we just checkout the commit we want to base to build on (I imagine your commit you made yesterday, 1 after the bump commit), and the push step with tag it [15:21:19] will tag it [15:21:40] bearND: yep! although, I wonder if we could nail down that last Nearby crash... [15:22:01] dbrant: yeah, that would be good [15:27:20] (03CR) 10BearND: [C: 04-1] "need more javadoc for throws statement" (034 comments) [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 (owner: 10Dbrant) [15:33:58] bearND: i'll look at that bug (if you're not already) [15:35:01] dbrant: only briefly glanced at it but have not written any code to address it. IIRC it had two possible cases for nulls. [15:35:48] dbrant: it would be better to have more reproducibility, or some idea why it happened. [15:36:40] dbrant: i'm looking at the java-mwapi changes right now [15:36:59] bearND: yes indeed. it seems like the server might be returning a response with no "query" object, but no "error" either. [15:42:06] (03PS1) 10Dbrant: Fix possible crash when fetching Nearby results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170051 (https://bugzilla.wikimedia.org/72761) [15:47:58] (03CR) 10BearND: [C: 04-1] Allow custom headers and remote endpoint to be specified at the same time when constructing Api (031 comment) [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/164873 (owner: 10Alex Monk) [15:51:33] (03CR) 10Dr0ptp4kt: "Monte, thanks for the heads up on the macro!" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [16:01:27] (03CR) 10BearND: [C: 032] "lgtm" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170051 (https://bugzilla.wikimedia.org/72761) (owner: 10Dbrant) [16:02:25] (03Merged) 10jenkins-bot: Fix possible crash when fetching Nearby results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170051 (https://bugzilla.wikimedia.org/72761) (owner: 10Dbrant) [16:06:14] dbrant|food: we seem to be getting more and more of these. Looks like the first one came in this morning. We should probably check with Max later, if he knows anything about this. [16:15:09] dbrant|food: since this is also happening on beta we might want to also push another beta soon [16:20:41] 3Wikipedia App / 3Android App: NPE crash when creating NearbyResult - 10https://bugzilla.wikimedia.org/72761 (10Alex Monk) 5PATC>3RESO/FIX [17:03:17] phuedx: added you to the wikigrok project on tool labs. You should be able to 'become wikigrok' now [17:03:30] then go into public_html/ [17:03:31] become one with the wikigrok? [17:04:26] kaldari: i'm a noob at tool labs, where am i looking for details of the project? [17:07:41] kaldari: MaxSem http://etherpad.wikimedia.org/p/wikidata_query_service_checkin [17:13:00] Maryana: hi, on this (https://trello.com/c/ZyfC4MOe/64-5-improve-reference-display-for-better-readability) when you say "multiple references next to each other" do you mean "in one sentence"? [17:13:36] kaldari: nm, i got it [17:13:45] bmansurov: yes, like the first sentence of this article: https://en.wikipedia.org/wiki/Sandwich [17:13:51] kaldari: i'd forgotten that i set up some of this stuff with YuviPanda [17:14:04] Maryana: thanks [17:14:14] sure :) [17:15:43] kaldari: awesome, working ta [17:17:52] kaldari: have magnus's scripts been run against the db? [17:17:52] manybubbles: https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok/Claim_suggestions [17:19:38] kaity|away: hi, what's the padding around the reference number in https://trello.com/c/ZyfC4MOe/64-5-improve-reference-display-for-better-readability? [17:25:58] phuedx: in meeting... [17:29:53] jdlrobson: WikiResponseAPI (of WikiGrok extension) doesn't response any data, right? [17:30:13] FlorianSW: that's what i was wondering :) you saw infobox patch? [17:30:25] (03CR) 10Jdlrobson: "Max what if we moved the api requests internal?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [17:31:34] which one? [17:31:38] jdlrobson: ^ [17:31:57] FlorianSW: https://gerrit.wikimedia.org/r/#/c/169792/ and friends [17:32:32] jdlrobson: ah, ok, yes, i saw them, but haven't a look on it for now :/ actually i'm working on the FIXME of: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiGrok.git/b28d6bcbb4c1d24d9847a64582977ca8bcef7c73/includes%2Fapi%2FApiResponse.php [17:32:39] https://www.mediawiki.org/wiki/Extension:MobileFrontend#action.3Dwikigrokresponse [17:32:59] and i'm wondering if (and why) the api doesn't respond any data [17:33:28] (03CR) 10Jdlrobson: [C: 04-1] "5 is introduced by your patch so you are introducing a bug in this patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [17:34:31] FlorianSW: what do you think it should respond with? [17:34:36] ^ jdlrobson [17:35:29] phuedx: on success: nothing (or a success: true json), on failure: some info or a warning. [17:35:33] jdlrobson: ^ [17:36:50] (03CR) 10Jdlrobson: [C: 032] Remove login icon from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [17:37:22] (looking) [17:37:34] * jdlrobson confesses he's not even looked at WikiGrok extension till this time [17:37:43] FlorianSW: i considered returning the result of EventLogging::logEvent for each attempted event [17:37:57] but it didn't have a client until now ;) [17:38:03] (03Merged) 10jenkins-bot: Remove login icon from Special:MobileMenu for non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169956 (https://bugzilla.wikimedia.org/72723) (owner: 10Bmansurov) [17:38:05] and, well, smallest possible change [17:38:34] brb -- food!!! [17:38:42] 3MobileFrontend / 3stable: Login icon showing on Special:MobileMenu for non-JS users - 10https://bugzilla.wikimedia.org/72723 (10Jon) 5PATC>3RESO/FIX [17:39:03] manybubbles, https://bitbucket.org/magnusmanske/wikidataquery/src [17:39:13] 3MobileFrontend / 3beta: In edit I can't scroll to the top to access the toolbar in beta + alpha - 10https://bugzilla.wikimedia.org/72707#c3 (10Jon) I'm not sure I understand the bug Kaity can you provide some clearer steps and screenshots? [17:39:15] manybubbles, http://wdq.wmflabs.org/ [17:41:51] phuedx: meeting done. not sure I understand your question [17:46:15] rmoen: Hey Rob, we're going to need those claim suggestion write-ups soon (for movies). We're using them as use case requirements for building a new query engine for wikidata (a project that Nik Everitt is now working on). [17:47:13] rmoen: They don't have to be super detailed, basically just the same as what you wrote up in the card. [17:47:39] bmansurov: kaity's in a design meeting now but she'll be here in a sec to help you work through the references styling story [17:47:56] Maryana: cool [17:53:05] kaldari: sorry I keep forgetting to put them up. [17:53:12] bearND: alright! anything else before we release? [17:53:43] ] [17:54:03] cat :P [17:54:18] dbrant: not from me, but check with Deskana|Away, too. [17:55:19] bearND: great; i'll do a final run-through while we wait for Deskana|Away's signoff [17:55:38] kaldari, re the GG talkpage: [17:55:41] 3MobileFrontend / 3Hygiene: Deprecate use of EventEmitter.prototype.one in MobileFrontend - 10https://bugzilla.wikimedia.org/72711#c2 (10Jon) To be clear https://gerrit.wikimedia.org/r/168724 just tells you that you are using it when you shouldn't be. Once that's merged it will make it easier to deprecate. [17:55:48] thank you for making me huff dorito dust all over my monitor [17:55:55] :) [17:55:59] that was a genuine laugh-out-loud [17:56:36] Ironholds: I would actually love for us to include the entire list in the lead. That would be epic. [17:57:14] and then a [note 1] that links through 30 5e7 more? yep. [17:57:21] *through to. Brain, what are you DOING. [18:05:22] (03CR) 10Florianschmidtwelzow: Creative destruction: Wikidata Infoboxes in alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [18:05:38] (03CR) 10Florianschmidtwelzow: "I like this entire idea! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [18:05:50] yello [18:07:36] kaldari: i think i've just answered my own question while trying to ask you a better question [18:07:42] * phuedx goes about his business [18:07:45] MaxSem: "error:OK"! http://wdq.wmflabs.org/api?q=claim[141]%20AND%20noclaim[31:16521] [18:08:12] nevermind I guess error:OK just means there wasn't an error :P [18:08:12] yup, <3 [18:08:33] there just happen to be no matches for that query [18:09:53] (03CR) 10Florianschmidtwelzow: Creative destruction: Wikidata Infoboxes in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [18:10:15] (03PS1) 10Jdlrobson: Hygiene: Fix jscs errors so I can merge again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170104 [18:10:17] (03PS1) 10Jdlrobson: Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 [18:11:30] MaxSem: i want to interrupt your work (again) and ask you, if you can take a look at: https://gerrit.wikimedia.org/r/#/c/154873/ ? :) [18:12:13] FlorianSW, yup looked at it [18:12:21] was not sure [18:12:47] hmm :/ [18:13:20] sorry for not communicating this [18:14:27] jdlrobson: sorry i didn't spot the docblock thing earlier [18:14:36] phuedx: the docblock? [18:14:43] check yer email [18:15:02] MaxSem: np, do you know someone who might have an idea? [18:15:27] I can look again [18:15:29] phuedx: what's the subject? [18:15:41] jdlrobson: https://gerrit.wikimedia.org/r/#/c/169926/5 [18:15:54] oh those don't go to my email hehe [18:16:48] ah [18:17:04] you mean you have a sane inbox? [18:17:10] phuedx: done :) [18:17:17] phuedx: yeh filters send it all to archive [18:17:23] they are there if i need them i just dont need to know about them [18:18:51] jdlrobson: gonna go give george a bath [18:18:59] phuedx: :-) [18:19:02] i'll kick the tyres once more when i get back [18:19:28] then we'll make you responsible for migrating two things to core ;) [18:21:18] MaxSem: i think i found the problem :/ Is UTSysop not the user to use in tests? [18:21:35] If i replace him with "Florian" (my local existing account) the tests will pass :/ [18:23:53] dbrant: Hey! I was pinged? [18:24:21] Deskana: yep, just wanted to confirm that we're good to go for release. [18:24:39] dbrant: Can you email me the APK so I can quickly take a look at it? [18:26:07] Deskana: done [18:26:12] dbrant: Cheers. :) [18:26:30] dbrant: Just finishing a meeting, I'll take a look in 5 minutes then probably tell you it's good 5 minutes after that. :) [18:26:41] Deskana: np [18:27:08] MaxSem: https://trello.com/b/oDLgJr8w/mobile-web-current-sprint-34-hitchhiker-s-guide-to-the-galaxy [18:27:13] (03PS9) 10Florianschmidtwelzow: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 [18:27:56] (03CR) 10jenkins-bot: [V: 04-1] Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [18:29:26] dbrant: Hah, I got worried for a minute there. [18:29:40] dbrant: I opened it and got the main page of the Burmese Wikipedia. I forgot I'd changed my language to that last night. :P [18:29:45] lol, tests pass locally but not in Jenkins, thanks Jenkins! :/ [18:29:47] Deskana: ha! [18:30:03] dbrant: So, recent searches is still in there. It shouldn't be. [18:30:12] dbrant: That's still really untested code and definitely needs a styling pass. [18:31:01] dbrant: Can we take that out? [18:31:20] Deskana: yep, very easily [18:31:26] dbrant: Wheeee [18:34:48] dbrant: Other than that, good to go I think! [18:35:07] Deskana: ok, i'll patch that momentarily. [18:35:34] (03CR) 10Florianschmidtwelzow: "The tests pass local (the problem was, that UTSysop is only created, if the extension is in group Database: https://www.mediawiki.org/wiki" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [18:36:21] dbrant: How are you feeling workload wise? Too much left in the sprint? Too little? Just right? [18:38:22] Deskana: it's certainly not too little :) it may be fewer points than last sprint, but it means that we'll have more breathing room for refinements and other kinds of icing. [18:40:11] Deskana: maybe even begin the transition to 5.0 support... [18:41:42] dbrant: Indeed. You and I should talk about what that entails. [18:43:40] Deskana: shall I schedule a time? [18:44:00] dbrant: I'm looking for one. My calendar is kind of wonky for the next few days due to a few afternoon appointments that I have. [18:44:27] dbrant: How about 9am tomorrow? [18:44:30] 12pm for you [18:44:44] Deskana: that... works! [18:46:04] (03PS1) 10Dbrant: Hide recent searches in production (for now) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170113 [19:01:05] bearND: https://gerrit.wikimedia.org/r/170113 it's been requested that we don't show Recent searches in production, either :) [19:02:49] dbrant: ok, checking... [19:07:28] (03CR) 10BearND: [C: 04-1] "It doesn't make sense to have the "Clear recent searches" menu to show up." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170113 (owner: 10Dbrant) [19:07:51] bearND: ah, right [19:08:37] dbrant: looks pretty empty when you bring up search the first time, oh well. I hope we get to do a follow up release with all this in soon [19:09:26] bearND: yep. I think, after the styling pass, there won't be any issues. [19:10:15] kaity: hi, you there? [19:10:32] bmansurov: hello [19:10:47] kaity: what should the reference font size and padding be in https://trello.com/c/ZyfC4MOe/64-5-improve-reference-display-for-better-readability? [19:10:57] (03PS2) 10Dbrant: Hide recent searches in production (for now) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170113 [19:11:00] bearND: ^ [19:11:10] ok [19:11:21] kaity: Also, I figured the color is #ccc; and the background color is #555; am I right? [19:11:24] bmansurov: actually lets hold off on that for a little while, we're updating the design mocks today [19:11:32] kaity: ok [19:11:39] bmansurov: we want them to be more in line with the app [19:12:03] kaity: ok, please leave a note on the card when it's ready. thanks [19:12:17] bmansurov: thanks! will do [19:13:48] (03CR) 10BearND: [C: 032] Hide recent searches in production (for now) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170113 (owner: 10Dbrant) [19:14:18] (03Merged) 10jenkins-bot: Hide recent searches in production (for now) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170113 (owner: 10Dbrant) [19:14:20] (03PS1) 10Bmansurov: WIP: Update reference styling. Show adjacent references at once. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170122 [19:14:59] (03CR) 10jenkins-bot: [V: 04-1] WIP: Update reference styling. Show adjacent references at once. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170122 (owner: 10Bmansurov) [19:18:10] MaxSem: Starting this morning we're getting a lot of issues reported in our Nearby functionality. Looks like we get a JSON response back that doesn't have an "error" nor a "query" attribute. We didn't account for this case until recently, so our app crashes in those cases. Did anything funny regarding the API or geosearch get deployed lately? Or is this related to some elaticsearch hosts having issues? [19:18:29] nah [19:18:37] I can haz repro? [19:18:53] bearND: MaxSem: i think i know what's happening [19:19:29] mebbe https://gerrit.wikimedia.org/r/#/c/170093/ ? [19:19:44] you would've noticed this sooner though... [19:21:15] MaxSem: could be [19:21:19] bearND: MaxSem: the way that we've been checking for an "empty" response is by checking for "[]". But now, the geosearch API has started to issue a warning about continuation formatting... so, even in an otherwise empty response, there's a warning, and we don't see the "[]", which trips us up. [19:21:52] Y IZ JAVA NO PHP? [19:23:59] bearND: i think the patch from this morning will handle this case adequately, but we should probably make it more robust later... [19:24:50] dbrant: agreed. [19:31:29] (03CR) 10Bmansurov: "Jdlrobson, does the link you gave (#5) work on your local master branch? I don't think it does." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [19:33:39] dbrant: I can confirm your findings. I can repro by forcing an empty response (e.g. through changing the radius to something really small) [19:34:02] bearND: ok, good! [19:34:44] kaldari: would you be available for a monthly (frequency up in the air) 1:1 to keep coordinated on frontend stuff? (per tfinc's request) [19:39:27] 3Wikipedia App / 3Android App: NPE crash when creating NearbyResult - 10https://bugzilla.wikimedia.org/72761#c3 (10Bernd Sitzmann) FWIW, to repo with our old code, make it so that Nearby doesn't return any results. You can do that in code by changing the radius. If you have access to the code that's probably... [19:52:57] manybubbles: Aha, you're in here too! [19:53:06] dbrant|brb, bearND: I was just chatting to Nik about our full text search feature. [19:53:22] manybubbles: Want to repeat what you just said to me so that dbrant|brb and bearND can implement it? :) [19:53:44] lay it on! [19:53:48] manybubbles: I'm all ears [19:55:11] bearND: it'd be useful if the searches from the app marked themselves in some say [19:55:14] *way* [19:55:20] a url parameter would work just fine [19:55:43] then if we really really need to squash them *right now* we could add a temporary fix around the url parameter [19:57:14] manybubbles: what about user agent? [19:57:40] dbrant: if I can identify the app from it then its fine [19:57:54] dbrant: That may not be good enough, actually. GoogleBot is using our app and it changes the user agent. [19:57:58] If we have a crisis I don't want to accidentally do something funky to everyone on mobile [19:58:33] does useragent specify that it is the app rather than that it is some kind of phone? [19:59:37] manybubbles: It's pretty consistent [19:59:58] manybubbles: yes it does, but Deskana is correct that the Google bot also hits the same URLs as the app [20:00:13] But user agents change. I think an API parameter is probably a good way to go. [20:00:33] can you give me an example of the user agent? [20:00:37] Sure [20:00:39] WikipediaApp/2.0-r-2014-10-14 (Android 4.2.1; Phone) Google Play [20:00:51] that _should_ be fine [20:01:03] WikipediaApp/4.0.4 (iPhone OS 6.1.3; Phone) [20:01:11] any hack we do to put out a fire would be temporary [20:01:44] Deskana: couldn't we also suppress the user agent of the google bot, if necessary? [20:01:58] Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html) [20:02:03] It even appears in EventLogging... [20:02:12] I don't even know how that's possible. [20:03:07] Well, that's a question for Nik. If he thinks the user agent is enough then that's okay. [20:03:27] A parameter given to the API, that's different for iOS and Android, seems more future-proofed to me, but you guys are the engineers at the end of the day. ;-) [20:08:52] dbrant, bearND, manybubbles: So, we don't need to do anything then. Cool. :) [20:09:22] user agent should be fine [20:09:31] manybubbles: Do ping us if we generate too much load, so that we can flip our killswitch. Our killswitch also changes the UX so that it won't look awful. :-) [20:14:57] (03PS2) 10Jdlrobson: Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 [20:18:01] (03PS3) 10Jdlrobson: Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 [20:26:14] (03PS8) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [20:27:32] (03PS5) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [20:28:26] (03PS4) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [20:28:28] (03PS4) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [20:30:55] (03CR) 10Jdlrobson: "I can't see a card for this so I guess this is an experiment? (cool:)) If so please make sure before submitting it you limit it to the alp" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170122 (owner: 10Bmansurov) [20:30:58] 3Wikipedia App / 3Android App: Android app: Full text search result ordering is bad/wrong - 10https://bugzilla.wikimedia.org/72781 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Full text search result ordering is bad. I searched for "gandhi" and it didn't give me him as the first result. But it does... [20:32:00] (03CR) 10Bmansurov: "Here is the card: https://trello.com/c/ZyfC4MOe/64-5-improve-reference-display-for-better-readability" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170122 (owner: 10Bmansurov) [20:36:53] dbrant, bearND: Something I meant to chat about before... [20:37:14] dbrant, bearND: Jon, Howie and I met with Toby and Dario today and we decided we're going to go with having a single install ID for all features and read actions so that our data is cross-comparable. [20:37:37] dbrant, bearND: As opposed to the one ID per feature thing we're going with right now. [20:38:53] Deskana: understood! i've got no problem with that. [20:39:12] Deskana: ok [20:39:30] (03CR) 10Jdlrobson: "On the basis this is being deployed Monday (I think Max said that) can we merge this yet or not?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [20:39:43] (03CR) 10Jdlrobson: [C: 04-1] "will need a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [20:41:43] brion: Are we good to start submitting our most recent TestFlight build to Apple? [20:41:50] brion: Anything you need from me to get the ball rolling? [20:42:00] Deskana: as soon as this meeting is over i’ll start the build :D [20:42:02] (03PS7) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [20:42:09] (should bea round 2pm) [20:42:13] Deskana: just sent you a (final?) release candidate [20:43:40] bearND, for https://gerrit.wikimedia.org/r/#/c/164873/4/src/main/java/org/mediawiki/api/json/Api.java you just want me to add something like this: [20:43:42] private static String DEFAULT_ENDPOINT = "/w/api.php"; [20:43:56] and then use it throughout the file instead of the value? [20:44:13] Krenair: make it private static final, and we've got a deal [20:44:23] final, right, of course. [20:45:27] Release candidate final final final [20:45:43] (03CR) 10Bmansurov: [C: 032] Hygiene: Fix jscs errors so I can merge again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170104 (owner: 10Jdlrobson) [20:46:18] (03Merged) 10jenkins-bot: Hygiene: Fix jscs errors so I can merge again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170104 (owner: 10Jdlrobson) [20:47:43] dbrant|brb: Hmm, well, the web view disappears when you tap search. [20:50:29] Deskana: it's empty now since we don't show the recent searches anymore [20:50:45] Right, but before it overlaid the article. [20:51:03] Deskana: before the refactoring, yes [20:51:09] It's just a bit strange that tapping on search causes the content of the article you're looking at to disappear. [20:52:10] I don't think it's much of a problem. [20:54:09] Deskana: (it will be superseded very soon by the new search stuff, anyway) [20:54:26] Indeed, yes. [20:54:55] Okay, let's go for this then. [20:55:27] * dbrant sets wheels in motion [20:55:29] Given our ramping up with QA, I think we're going to have to move to a stage where we have the release candidate APK built before the release day, so that it can be rigorously tested [20:55:49] ^ +++ [20:56:47] (03CR) 10Jdlrobson: [C: 04-1] "http://localhost:8080/wiki/Anne%20Dallas%20Dudley?mobileaction=alpha&wikidataid=Q3 is still giving me an infinite spinner when I click yes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [20:56:50] The Specialists Guild have proved to be excellent so far on iOS. [20:56:56] (03PS5) 10Alex Monk: Allow custom headers and remote endpoint to be specified at the same time when constructing Api [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/164873 [20:58:51] brion: Excellent. Thanks! [21:03:52] woo meetings [21:03:56] ok lemme fire xcode back up [21:05:25] jdlrobson: do you see the wikigrok dialog on master when you visit http://localhost:8080/wiki/Anne%20Dallas%20Dudley?mobileaction=alpha&wikidataid=Q3 ? [21:07:15] (03PS1) 10Brion VIBBER: Bump ver to 4.0.5 (really should do this before beta releases!) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170159 [21:07:27] * Deskana is currently trying to write a small little patch for the iOS app. [21:07:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerrrge" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170159 (owner: 10Brion VIBBER) [21:07:39] Deskana: yay :D [21:07:52] bmansurov: no i don't [21:08:09] ok [21:08:20] [are [you areEnjoyingThe:[[NSBracket alloc] initWithBrackets]]]? [21:08:44] bmansurov: do you? [21:09:18] jdlrobson: no, which means the Q3 is problematic itself [21:09:48] * brion sacrifices cookies to the code signing gods [21:10:55] kaity: when wikigrok fails to load suggestions, how should I display the error message, if any. Currently I see an infinite spinner: http://imgur.com/Uyr3EsH [21:11:35] “uploading archive”… [21:11:43] * brion pleeeeeease validate [21:11:44] bmansurov: moiz will get back to you [21:11:54] hey bmansurov, i'll come over your desk in a few [21:11:54] ok thanks [21:12:06] moizsyed: I'm not in the office [21:12:10] bmansurov: i meant, i'll fly in nyc [21:12:16] ;) [21:12:22] bmansurov: at the airport now, getting on a plane, see you in a few [21:12:28] oh no [21:12:41] argh app id oddity again. lemme double-check [21:12:44] bmansurov: See the showError function in WikiGrok A (WikiGrokDialog.php) [21:13:01] kaldari: ok thanks [21:13:54] * brion pushes more buttons until it looks right [21:13:55] bmansurov: Although in theory, if WikiGrok fails to load any suggestions, it probably just shouldn't display any interface at all. [21:14:10] ok that looks like the right app id in the signing identity now. let’s try again… [21:14:36] kaldari: do you mean I should pre load suggestions before asking the user to contribute? [21:16:34] bmansurov: Yes, I think that would be a good idea. I believe it was doing that at one point, but may have changed. [21:17:19] am gonna head off for the night folks [21:17:37] phuedx: I never answered your question from earlier [21:17:50] kaldari: i answered 'em myself [21:17:56] phuedx: cool :) [21:18:10] i wasn't reading the script that i was looking at correctly [21:18:23] so i've got all the information i need [21:18:27] i reckon [21:18:37] :) [21:18:39] right [21:18:42] am orf [21:19:16] phuedx: night! [21:21:26] aaaaand bump the build number cause it uploaded the bogus version… [21:21:27] wheee [21:23:52] ok that one looks right [21:23:54] prepping... [21:25:16] ah it’s still processing, that’s why it doesn’t show up [21:25:21] * brion refills coffee [21:27:18] Maryana: http://wdq.wmflabs.org/api_documentation.html [21:27:43] gracias [21:28:27] brion: there are a couple of open TWN imports patches for iOS that haven't been merged yet [21:28:43] ay! [21:28:48] bearND: thanks for reminding me :D [21:28:55] lemme grab those before i push more buttons [21:29:14] (03CR) 10Kaldari: "For now, we should have both A and B do an AJAX call on initial load to find out if there are any claim suggestions. It is true this isn't" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [21:29:29] bmansurov: replied in gerrit: ^ [21:29:35] thanks [21:29:37] brion: it's weird, though. There are two but the 2nd one should haven been the superset of the first. Doesn't seem like that [21:29:48] brion: do you want me to make a fresh one? [21:30:06] brion: we just got a mail from iTunes connect about the app identifier. this is the second time we've seen this happen. whats going on? [21:30:13] bearND: yeah that’d be best [21:30:29] brion: ok, i'll abandon the other ones first [21:30:32] tfinc2: i selected the wrong profile, then saw the error and fixed it [21:30:35] (03Abandoned) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168972 (owner: 10BearND) [21:30:42] (03Abandoned) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169738 (owner: 10BearND) [21:31:25] tfinc2: there should be no further regressions as long as we stick to the corrected app id prefix (with the right profile) [21:31:30] (03PS8) 10Bmansurov: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 [21:32:18] bmansurov: I'll take a look at the new version now [21:32:34] tfinc2: i’ll kill the bad one so it doesn’t get used by accident again [21:33:45] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170169 [21:33:46] brion: ^ [21:33:58] bearND: thx! looking [21:34:17] ah good the new about strings [21:34:20] yeah that’s good to have [21:35:32] tfinc2: ok i killed the bad profile and renamed the bad app id to ‘broken wikipedia do not use’ :D that should clear it up [21:36:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170169 (owner: 10BearND) [21:37:45] (03PS1) 10Brion VIBBER: bump build number after updating localizations [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170172 [21:37:57] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerge" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170172 (owner: 10Brion VIBBER) [21:43:13] ok it’s got to process that for a few more minutes… [21:43:18] * brion gets the refilled coffee [21:45:54] (03PS1) 10Jdlrobson: Enter brave new ResourceLoader world [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 [21:46:05] ^ kaldari joakino what we were talking about at lunch [21:47:31] (03CR) 10Dr0ptp4kt: "Update on hex color in API response." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [21:49:21] brion: ^ thanks for asking about that. i created a trello card to make the server be stricter. finally getting around to writing some code for more than a minute now. [21:49:38] :D [21:50:37] (03PS2) 10Jdlrobson: WIP: Enter brave new ResourceLoader world [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 [21:51:22] Deskana: http://etherpad.wikimedia.org/p/wikipedia-ios-4.0.5-release-notes <- release notes look good? I took the beta header from the last one and added a note about the new testflight system [21:51:36] i can probably start migrating people over while we’re waiting for this version to clear review :D [21:51:42] or we can wait a bit [21:52:43] (03PS2) 10Jdlrobson: Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 [21:52:51] (03PS3) 10Jdlrobson: Enter brave new ResourceLoader world [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 [21:52:54] (03PS4) 10Jdlrobson: Enter brave new ResourceLoader world [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 [21:53:52] (03CR) 10Dr0ptp4kt: "Update on type casting. About to resubmit patch." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [21:54:34] (03PS1) 10BearND: Bump version to 1.2 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/170178 [21:56:47] 3MobileFrontend / 3Hygiene: Publish our JS Documentation - 10https://bugzilla.wikimedia.org/72794 (10Jon) [21:56:47] 3MobileFrontend / 3Hygiene: Publish our JS Documentation - 10https://bugzilla.wikimedia.org/72794 (10Jon) [21:56:48] 3MobileFrontend / 3Hygiene: Publish our JS Documentation - 10https://bugzilla.wikimedia.org/72794 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon We want our documentation published on https://doc.wikimedia.org/ See https://bugzilla.wikimedia.org/show_bug.cgi?id=64374 Blocked on bug 64374 [21:56:49] thanks, kaldari [21:57:06] (03CR) 10BearND: [C: 032] Bump version to 1.2 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/170178 (owner: 10BearND) [21:58:29] (03PS2) 10Dr0ptp4kt: Support colorized zero-rating messaging [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 [21:59:30] (03CR) 10BearND: [V: 032] Bump version to 1.2 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/170178 (owner: 10BearND) [22:00:19] (03CR) 10Kaldari: "Like I said at lunch, I favor changing how we organize our files, but I don't like magic registration. For example, there may be cases whe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson) [22:00:28] 3MobileFrontend / 3Hygiene: Publish our JS Documentation - 10https://bugzilla.wikimedia.org/72794#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/o79gX3x5 [22:00:31] jdlrobson: Added my thoughts ^ [22:01:19] (03PS2) 10BearND: prepare for next development iteration 1.3-SNAPSHOT [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169959 (owner: 10Dbrant) [22:01:49] brion: mind re-reviewing https://gerrit.wikimedia.org/r/169950 ? i changed to xcode 4.4+ nsdictionary lookup notation plus used the macro. i left the preliminary check on the rgb value for length of 7 and prefix of #, and will get the server to be strict about that. it's lax right now [22:02:12] (03CR) 10BearND: [C: 032 V: 032] prepare for next development iteration 1.3-SNAPSHOT [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169959 (owner: 10Dbrant) [22:02:33] dr0ptp4kt: awesome [22:02:53] brion: Tweaked slightly. Good to go! [22:03:07] (03PS6) 10BearND: Allow custom headers and remote endpoint to be specified at the same time when constructing Api [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/164873 (owner: 10Alex Monk) [22:03:29] 3MobileFrontend / 3alpha: WikiGrok B: Cannot click 'Next' when I don't agree with any of the suggestions. - 10https://bugzilla.wikimedia.org/72795 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3None Created attachment 16971 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16971&action=edit ca... [22:04:01] Deskana: thanks! [22:04:56] Deskana: tfinc2: ok iOS app submission is in the queue; when it’s done a little more automated processing (who knows what!) on the build i’ll start testing the new TestFlight system. you may get invite emails. hopefully they will make sense. [22:04:58] (03CR) 10BearND: [C: 032 V: 032] Allow custom headers and remote endpoint to be specified at the same time when constructing Api [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/164873 (owner: 10Alex Monk) [22:05:24] dr0ptp4kt: looks good, i’ll test it in a bit [22:05:26] 3MobileFrontend / 3alpha: WikiGrok B: Cannot click 'Next' when I don't agree with any of the suggestions. - 10https://bugzilla.wikimedia.org/72795#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/aZA8lYXd [22:05:38] brion: thx [22:07:48] (03CR) 10BearND: "once this is merged I can do a mvn deploy and upload the jar file to the team repo" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 (owner: 10Dbrant) [22:10:56] (03CR) 10Jdlrobson: [C: 032] Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [22:11:12] dbrant: able to spare 5 mins to go over builds? [22:11:23] cc bearND [22:11:29] dr0ptp4kt: yep, sure [22:11:36] bearND: want to hop on as well? [22:11:40] ok [22:11:59] 3MobileFrontend / 3alpha: Wikgrok A and B trigger API request on every page load - 10https://bugzilla.wikimedia.org/72796 (10Jon) 3NEW p:3Unprio s:3normal a:3None They really shouldn't. The API request should only be made when the user clicks 'yes' they want to help Wikipedia. I would suggest making... [22:12:01] dr0ptp4kt: wanna go to the batcave? [22:12:11] 3MobileFrontend / 3beta: Wikgrok A and B trigger API request on every page load - 10https://bugzilla.wikimedia.org/72796 (10Jon) [22:12:51] bearND: yeah. be there in a little bit [22:13:08] dr0ptp4kt: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [22:13:42] (03Merged) 10jenkins-bot: Show similar experience for both WikiGrok versions A and B. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169544 (owner: 10Bmansurov) [22:15:26] 3MobileFrontend / 3beta: Wikgrok A and B trigger API request on every page load - 10https://bugzilla.wikimedia.org/72796#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/feS9dFr0 [22:15:40] bmansurov: Looks like jon beat me to it :) [22:17:25] kaldari: tell me about it, he's everywhere [22:18:27] 3MobileFrontend / 3beta: Wikgrok A and B trigger API request on every page load - 10https://bugzilla.wikimedia.org/72796#c2 (10Florian) Maybe we can use a generic questions for us, maybe asking the user, if he likes the mobile view or not (with the problem, that we can not ask, or become more information, wh... [22:23:01] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170187 [22:25:25] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170187 (owner: 10Dbrant) [22:27:12] Maryana: joakino is leaving after tomorrow. I have you down for the following onboarding task: "Product overview". Should I mark that as done or do you want to give Joaquin a more formal tour of the product? [22:35:50] dbrant: bearND sorry about that. mind sending that url again for the hangout? [22:36:13] dbrant: or is there not much left to see? just checkout the bump build corresponding to prod, then run the script with the properties file, right? [22:36:18] dr0ptp4kt: https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [22:37:16] (03PS4) 10Kaldari: Tap code be gone! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [22:38:41] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788 (10Andre Klapper) [22:40:27] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/iel5tCZS [22:50:20] (03CR) 10Jhernandez: "UI components FTW" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson) [22:56:51] dbrant: Did the update go out? :) [22:57:22] Deskana: it did!! just a few minutes ago. :D [22:57:30] dbrant: Woo! [22:57:34] Deskana: (both prod. and beta) [22:57:44] dbrant: I just checked Google Play and didn't see it, I guess I just hadn't hit it yet. [23:00:33] dbrant: Thanks! [23:03:38] kaldari: hehe, maybe i'll just grab him for a coffee at some point tomorrow and make sure :) [23:03:45] thanks for the reminder [23:09:29] (03PS1) 10Kaldari: Fixing some issue from change Id86375a7 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:12:49] (03PS2) 10Kaldari: Fixing some issue from change Id86375a7 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:13:29] 3Wikipedia App / 3iOS App: iOS app jumps unexpectedly during scrolling on page linked with section hash - 10https://bugzilla.wikimedia.org/72797 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Bug reported via TestFlight, confirmed on latest build on my iPhone 4S (iOS 7.1) Steps to reproduce: - Se... [23:14:14] (03PS3) 10Kaldari: Fixing some issue from change Id86375a7 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:15:20] ahhhhhh it’s still “processing” the build [23:15:35] i’ll just check tomorrow if it’s not done soon :D [23:17:53] jdlrobson: There were a bunch of bugs in https://gerrit.wikimedia.org/r/#/c/169544/ . If you have a chance, could you merge https://gerrit.wikimedia.org/r/#/c/170246/ to fix them? I'm testing your tap removal code now. [23:19:45] (03PS1) 10MaxSem: Move campaigns into a subdirectory [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170248 [23:19:47] (03PS1) 10MaxSem: Add SimpleCampaign [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170249 [23:20:38] (03CR) 10Bmansurov: Restore the more button to the watchlist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:24:00] (03CR) 10Jdlrobson: [C: 04-1] Fixing some issue from change Id86375a7 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 (owner: 10Kaldari) [23:25:17] (03CR) 10Jdlrobson: Restore the more button to the watchlist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:25:31] ^ bmansurov see my comment on https://gerrit.wikimedia.org/r/170246 [23:25:39] (03PS4) 10Kaldari: Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:25:39] i was probably a bit too trigger happy with your patch :) [23:32:59] (03CR) 10Bmansurov: [C: 032] Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 (owner: 10Jdlrobson) [23:36:15] (03CR) 10Bmansurov: Fixing some random WikiGrok issues and regressions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 (owner: 10Kaldari) [23:39:09] (03PS5) 10Kaldari: Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:40:29] (03PS6) 10Kaldari: Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:40:37] dr0ptp4kt: one more thing before building releases is to make sure you check if there are any updates for the android SDK [23:41:29] (03PS7) 10Kaldari: Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:44:12] (03CR) 10Bmansurov: [C: 032] Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 (owner: 10Jdlrobson) [23:46:04] (03CR) 10Bmansurov: Fixing some random WikiGrok issues and regressions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 (owner: 10Kaldari) [23:47:49] (03CR) 10Kaldari: Fixing some random WikiGrok issues and regressions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 (owner: 10Kaldari) [23:49:03] (03CR) 10Bmansurov: [C: 04-1] Restore the more button to the watchlist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:49:24] (03PS8) 10Kaldari: Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 [23:49:45] brion: Hey! So I *think* my commit is ready but I have a few questions. [23:49:55] brion: There were apparently a few files changed that I wasn't expecting, and I'm... sceptical. [23:50:01] heh [23:50:06] bmansurov: good catch [23:50:06] Deskana: are they the .css files? [23:50:28] brion: Yeah. Also, Main_iPhone.storyboard [23:50:57] so the CSS files auto-update during build, you can just not commit them [23:51:07] the storyboard sometimes changes if you do stuff like…. scroll…. in the storyboard view [23:51:18] again, if you don’t think you changed it, should be safe to leave it be :D [23:51:20] Which I did, because I did look at it [23:51:24] But I didn't touch anything [23:51:29] Or, at least, I didn't intend to [23:51:34] Okay, so I'll just commit the relevant files then [23:51:35] Thanks :) [23:52:18] :D yeah it can be scary [23:52:24] giant xml whatsits [23:53:40] (03PS1) 10Deskana: Add The Specialists Guild to the "About the Wikipedia app" page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170258 [23:53:45] brion: ^^ [23:53:46] :-D [23:54:59] woohoo! [23:55:03] looks legit Deskana :D [23:55:35] awww yiss [23:55:38] kaldari: are you still working on https://gerrit.wikimedia.org/r/#/c/170246/8? can I +2 it? looks good to me [23:56:05] bmansurov: I'm done with it :) [23:56:20] (03CR) 10Bmansurov: [C: 032] Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 (owner: 10Kaldari) [23:56:59] (03Merged) 10jenkins-bot: Fixing some random WikiGrok issues and regressions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170246 (owner: 10Kaldari) [23:57:14] brion: Awesome! No need to review or merge now, just do it as and when you normally would. [23:57:29] great, i’ll test it shortly :D [23:58:41] Woooo