[00:00:39] Seems like XCode itself is friendlier than Android Studio. [00:00:42] bmansurov: hi! where did you get this from? isIos8 = isIos && /OS 8_/.test( ua ), [00:00:57] Like the GUI I used for editing the plist was pretty nice, rather than writing the XML by hand [00:01:05] What a shame that Objective C is so less friendly to me than Java. :P [00:01:21] bmansurov: isn't that the phone model? like here: https://gist.github.com/anonymous/3cf1db037558e61e4a34 [00:02:04] on application.js:24 [00:02:30] joakino: I just wrote it myself [00:02:55] joakino: what's wrong with it? are you having problems? [00:03:03] bmansurov: are you sure that's how you detect the os version? [00:03:24] Deskana: xcode is a double-edged sword. in places it’s wonderful and in places you just boggle and go “WTFFFFFFF” [00:03:32] bmansurov: yeah i've been with overlay ios bugs for a couple of days now [00:03:44] especially when it comes to code signing and submitting to the store ;) [00:03:45] joakino: do you think that's the phone version, not the OS version? [00:03:54] bmansurov: i'm so tired [00:03:59] brion: Well all that code submission bullshit we're going through is stupid. [00:04:07] joakino: take it easy, man [00:04:12] brion: Though you could argue that's just Apple being stupid rather the software I guess :-p [00:04:23] :D [00:04:45] bmansurov: i have no idea, i but it seemed fishy taking into account the surrounding lines [00:05:50] joakino: I think that's the OS version, because an emulated iphone6 on chrome shows OS 8 [00:06:28] (03CR) 10Kaldari: [C: 032] "Tested in iOS 6 and Android." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [00:07:20] bmansurov: i'm going to check it out, in the ios simulator it gives me "Mozilla/5.0 (iPhone; CPU iPhone OS 10_9_5 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12B411 Safari/600.1.4" for an iphone [00:07:24] (03Merged) 10jenkins-bot: Tap code be gone! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169582 (https://bugzilla.wikimedia.org/72566) (owner: 10Jdlrobson) [00:07:58] joakino: ok [00:09:33] user agents are so fun [00:10:26] kaldari: why don't some +2'ed patches get merged right away? [00:10:35] bmansurov: i'm a bit lost now, so a real iphone 5: Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12A365 Safari/600.1.4 [00:10:52] joakino: and does it have iOS8? [00:10:53] but in the code we have isIPhone5 = isIos && /OS 5_/.test( ua ), [00:11:20] which is just plain wrong, i'm not sure now to what useragent detection is the correct and what is the bad one [00:11:23] bmansurov: yes [00:11:27] bmansurov: They added some "features" to jenkins so that it does a lot more checks on certain code (PHP?), so sometimes it takes a while. Plus there is sometimes a backlog. It can take as long as 20 minutes now :( [00:11:30] joakino: hmm, maybe at the time when iphone 5 came out, the os version was 5 too. but you're right that's wrong [00:11:44] kaldari: i see, thanks [00:11:51] bmansurov: ok thnx! [00:12:08] bmansurov: You can monitor the merge process at https://integration.wikimedia.org/zuul/ [00:12:21] cool [00:15:27] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788#c3 (10Max Semenik) Upon clicking on search results, browser navigates back. Couldn't achieve a consistent repro though. [00:15:48] (03PS1) 10Jdlrobson: WIP: Make OverlayManager -> RouteManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170262 [00:20:05] (03CR) 10Kaldari: [C: 04-1] Add SimpleCampaign (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170249 (owner: 10MaxSem) [00:21:13] (03Abandoned) 10Kaldari: Adding FIXME comment about module dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169955 (owner: 10Kaldari) [00:23:08] (03CR) 10MaxSem: Add SimpleCampaign (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170249 (owner: 10MaxSem) [00:24:13] (03PS2) 10MaxSem: Add SimpleCampaign [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170249 [00:24:23] (03PS1) 10MaxSem: WIP: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [00:25:22] MaxSem: Do you think these cards are OK to move into Ready for Dev or should we wait to see what kind of performance implecations campaigns like those are going to have: https://trello.com/c/605rafdj/61-5-reimplement-occupation-claim-suggestions-as-a-campaign-in-wikigrok-extension-without-front-end-integration https://trello.com/c/o96yGD8o/62-5-reimplement-nationalities-claim-sug [00:28:12] Maryana: you in a meeting? [00:28:35] Deskana: well-said! [00:31:32] (03PS1) 10Jhernandez: Avoid megazoom after tapping input and closing overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170265 (https://bugzilla.wikimedia.org/72695) [00:35:17] dbrant|bbl: are you going to push the apks to releases.wm.o and add an entry for https://www.mediawiki.org/wiki/Mobile/Release_history#Apps? [00:35:45] bearND: ah! thx for the reminder [00:37:39] dbrant|bbl: we probably should create a real https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process page and move what's currently there to a section called Release Criteria [00:38:23] Then we could include all the steps on how to do a release [00:38:35] dbrant|bbl: if you agree I can start on this [00:38:42] cc Deskana [00:38:44] bearND: yeah, for sure! [00:41:29] 3MobileFrontend / 3stable: Code shouldn't be loaded unless necessary - 10https://bugzilla.wikimedia.org/72799 (10Jon) 3NEW p:3Unprio s:3normal a:3None mobile.newusers ResourceLoader module is loaded unconditionally. If you look closely it only does something when you are logged in. Thus we should mo... [00:45:27] 3MobileFrontend / 3stable: Code shouldn't be loaded unless necessary - 10https://bugzilla.wikimedia.org/72799#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/uVypROVA [00:50:38] (03PS1) 10Jdlrobson: Create generic intermediate loader function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170271 [00:50:40] (03PS1) 10Jdlrobson: Only load LanguageOverlay when needed, use M.loadModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170272 [00:51:27] 3MobileFrontend / 3stable: Cannot toggle sections or open the hamburger menu in IE8 - 10https://bugzilla.wikimedia.org/72645 (10Jon) 5PATC>3RESO/FIX [00:51:27] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566 (10Jon) 5PATC>3RESO/FIX [00:52:10] bearND: Excellent plan. [00:52:31] kaldari: https://gerrit.wikimedia.org/r/#/c/169926/3 [00:52:36] and https://gerrit.wikimedia.org/r/#/c/169931/ [00:52:40] please pretty pleaseeee [00:53:06] Deskana: is the hostname we push the apks to sensitive or can I include it on the wiki? [00:53:20] bearND: It's public AFAIK [00:53:29] bearND: So put it on there and we'll take it off if someone complains [00:53:29] jdlrobson: don't have time to test them tonite, but ping me tomorrow [00:53:38] Deskana: ok [00:55:36] bearND: So I quickly moved things around a bit [00:57:06] https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process [00:57:18] That's now a page where you can document the process to follow when releasing a new version [01:19:21] bearND, you mean, the server behind releases.wikimedia.org? [01:19:31] Krenair: yes, sir [01:19:43] bearND, according to the public puppet repo that's caesium [01:20:09] Krenair: ok, that's what i was going to use, but wasn't sure if that was public knowledge [01:20:11] thanks! [01:22:59] https://github.com/wikimedia/operations-puppet/blob/production/manifests/role/releases.pp [01:23:21] https://github.com/wikimedia/operations-puppet/blob/production/manifests/site.pp#L454-L464 [01:23:54] ah, good to know [01:35:28] dbrant|bbl, bearND: Either of you happen to be around? [01:35:33] I realise it's not exactly working hours. :) [01:35:41] Deskana: yes [01:36:29] bearND: Woohoo! So I wrote a patch which changes the install IDs like I said. I also had to update the schemas on Meta so I also updated the REVISION int in each schema. [01:36:42] bearND: If I now test this code, will it just start populating a new table or do I have to do something else first? [01:38:07] bearND: I want to test this before committing it, but I don't want to break something in EventLogging while testing it! [01:39:49] Deskana: yes, since you have updated the REVISION in the Java code it would create the new table automatically once you test your apk. There is nothing else to do. But be careful that you are confident that your schema changes are correct since we don't want to create too many unnecessary tables. [01:40:29] bearND: Cool, I can double-check that. [01:40:30] bearND: Thanks! [01:40:31] Deskana: For instance we don't update the rev# just for comment changes in the schema [01:40:56] bearND: Yeah, this is actually reworking the data in each schema. [01:43:47] bearND: I'll let this sit here for a while and take a look at it tomorrow before committing or testing it. [01:44:15] Deskana: which schemas did you change? [01:44:22] All the ones with installIDs. [01:44:28] so [01:44:30] AppearanceChange [01:44:36] SavedPages [01:44:38] SessionFunnel [01:44:42] ToCInteractionFunnel [01:44:52] Deskana: ah, i see it now [01:45:14] They're all going to use what was the readingActionID [01:45:20] The readingActionID will remain unchanged [01:45:25] You'll see the patch tomorrow :) [01:46:59] Deskana: so, you basically changed the name of the field to be the same for multiple schemas. Is the Java code taking advantage of that? [01:47:13] Yep [01:47:38] There's now just a single getAppInstallID method in WikipediaApp.java [01:47:42] And all the schemas use that instead [01:48:00] Deskana: ok, good. Otherwise it wouldn't have made sense to up the rev #. [01:48:28] So basically all the new data is incompatible with the old data [01:48:45] So it needs to be in a separate table otherwise we'll get our analysis confused [01:51:38] Deskana: Curious to see what dbrant|bbl and brion think of this as well. Gotta go eat now. Laters. [01:51:47] bearND: Cheers! [10:07:18] morning all [13:28:27] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c23 (10Chris H-C) Yay! So.. when will I see this in "Experimental" or "Beta" (or in the normal, every-day view)? Or, more directly, when/where/how will I be able to test it? [14:02:35] (03PS1) 10Dbrant: Fix possible crash when detached from activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 [14:05:04] (03PS1) 10Phuedx: Add query parameter to force WikiGrok version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 [14:17:57] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c24 (10Jon) Hi Chris, can you verify this works on http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page ? Sadly I was not able to find a physical advice or emulator to verify this. Wikimedia definitely n... [14:44:41] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c25 (10Chris H-C) Well, the Random button doesn't work. (the beta slide out menu works better with mouse, though, than the public one.) I eventually found an article page (Wikipedia in culture) whose hea... [14:49:56] (03PS1) 10Dbrant: Fix possible crash involving the main ProgressBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 [15:24:05] bearND: fewer crashes than I thought! There seem to be only two distinct new ones. [15:24:27] bearND: one is patched for sure: https://gerrit.wikimedia.org/r/170321 [15:25:33] bearND: the second i'm not 100% sure about: https://gerrit.wikimedia.org/r/170332 I've sent a test build of the app to one of the OTRS users; we'll see. [15:35:33] (03PS1) 10Dbrant: User paddingTop instead of marginTop to account for ActionBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170336 [15:39:38] (03PS2) 10Dbrant: Use paddingTop instead of marginTop to account for ActionBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170336 [15:51:25] dbrant: great job! [15:52:38] dbrant: what's a ticlet? Is that the official term for OTRS ticket? Ususlly the Change-Id should come last in the commit message (https://gerrit.wikimedia.org/r/#/c/170321/) [15:54:31] bearND: lol damn it! It looks like gerrit automatically alphabetizes the various properties (I definitely typed it before the change id). [15:55:19] bearND: I'll amend the spelling, but I don't think it's an issue if it ends up below the change id... [15:58:09] dbrant: ok, but the links don't work. Shouldn't they point to OTRS? [15:58:37] usually we create a bug in bugzilla and point to that [16:00:16] bearND: yeah... i'll create a bug. I was just on too much of a roll. [16:01:26] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c26 (10Jon) Mmm I could have sworn we had width=device-width I will have to look at the git history and see where and why that went. Not sure why random wouldn't work. I'll take another look at code toda... [16:02:43] dbrant: that's cool. Don't let that stop you from keeping things rolling. [16:23:44] 3Wikipedia App / 3Android App: NPE when updating ProgressBar - 10https://bugzilla.wikimedia.org/72817 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None Looks like, under certain circumstances, the ProgressBar that is inside the ActionBar doesn't get created until after Activity.onCreate, which causes... [16:26:59] 3Wikipedia App / 3Android App: NPE when fragment(s) detached from activity - 10https://bugzilla.wikimedia.org/72818 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7922103 https://ticket.wikimedia.org/otrs/index.pl?Action=Ag... [16:27:42] (03PS2) 10Dbrant: Fix possible crash when detached from activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 (https://bugzilla.wikimedia.org/72818) [16:30:56] (03PS2) 10Dbrant: Fix possible crash involving the main ProgressBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) [16:44:51] dbrant: am i safe to build the apks today? or are there any high priority bugs going out in a bugfix release? it ran well on my nexus 7, but i know that's but one device [16:46:30] dr0ptp4kt: there may be one or two fixes. there were two new crashes reported overnight, and it's not yet clear how widespead they are. can you standby until later in the day? [16:46:49] dbrant: yep, will do [16:46:59] (03CR) 10BearND: [C: 032] "Nice! I also like that you've changed the progress bar in Nearby" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [16:56:15] 3MobileFrontend / 3stable: Enable meta viewport width=device-width - 10https://bugzilla.wikimedia.org/72820 (10Jon) 3NEW p:3Unprio s:3normal a:3None For some unknown reason we have never set width=device-width By not doing so we are missing out on fast clicking in latest Chrome. [16:56:42] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c27 (10Jon) I've raised bug 72820. No idea why it's not set. Never has been apparently :-S [16:59:18] (03CR) 10Jdlrobson: [C: 04-1] Add query parameter to force WikiGrok version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [17:00:28] 3MobileFrontend / 3stable: Enable meta viewport width=device-width - 10https://bugzilla.wikimedia.org/72820#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/M7pNKvHF [17:15:30] dbrant: I am analyzing font-settings data for the android app. Deskana mentioned that android fonts were relative. can you explain to me how that manifests. [17:15:43] (03CR) 10jenkins-bot: [V: 04-1] Fix possible crash when detached from activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 (https://bugzilla.wikimedia.org/72818) (owner: 10Dbrant) [17:19:34] (03CR) 10jenkins-bot: [V: 04-1] Fix possible crash involving the main ProgressBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [17:19:43] bmansurov: phuedx: rmoen interested to hear what you think of https://gerrit.wikimedia.org/r/#/c/170174/ [17:20:29] any commit whose message contains "What say you?" or "woo magic" MUST be merged [17:20:41] jdlrobson: will take a look in a sec [17:22:10] (03CR) 10Bmansurov: "Phuedx, I thought about your comment that we should log the errors in the backend, but it's still not as reliable as logging on the front " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [17:22:12] (03CR) 10Jdlrobson: [C: 031] "Hacky but ios so understandable.Merger should test on a real iphone as I haven't verified this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170265 (https://bugzilla.wikimedia.org/72695) (owner: 10Jhernandez) [17:22:26] phuedx: let me know what you think about my comment here https://gerrit.wikimedia.org/r/#/c/169626/ [17:23:34] (03CR) 10Jdlrobson: [C: 04-2] "The overlay manager assumes you can only have one overlay visible at a time this is different from Views e.g. Nearby where you can see sea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170262 (owner: 10Jdlrobson) [17:25:42] 3MobileFrontend / 3stable: Enable meta viewport width=device-width - 10https://bugzilla.wikimedia.org/72820#c2 (10Chris H-C) > By not doing so we are missing out on fast clicking in latest Chrome. and BlackBerry. [17:27:54] (03PS2) 10Phuedx: Add query parameter to force WikiGrok version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 [17:29:07] (03CR) 10Phuedx: Add query parameter to force WikiGrok version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [17:29:24] bmansurov: thinking about it, thanks for the response [17:29:28] (03PS4) 10Jdlrobson: Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 [17:29:30] (03PS1) 10Jdlrobson: Wikidata API enhancements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170355 [17:34:27] JonKatz: hey, sorry! are you referring to our ability to increase/decrease the font size in the app? [17:35:13] yes--specifically looking at the logs and wondering how to interpret the numbers. [17:35:21] (03PS3) 10BearND: Fix possible crash when detached from activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 (https://bugzilla.wikimedia.org/72818) (owner: 10Dbrant) [17:36:01] (03CR) 10Bmansurov: "I think the old way of doing it was better because you could easily see which files are being used in a module. With this change I'll have" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson) [17:37:24] dbrant: did that add clarity? maybe we could talk over briefly via hangout? [17:37:58] JonKatz: sure, brief hangout is fine [17:38:12] (03CR) 10Kaldari: [C: 032] Move campaigns into a subdirectory [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170248 (owner: 10MaxSem) [17:38:30] (03Merged) 10jenkins-bot: Move campaigns into a subdirectory [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170248 (owner: 10MaxSem) [17:38:33] (03CR) 10Kaldari: [C: 032] Add SimpleCampaign [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170249 (owner: 10MaxSem) [17:38:54] (03Merged) 10jenkins-bot: Add SimpleCampaign [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170249 (owner: 10MaxSem) [17:38:58] (03CR) 10BearND: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 (https://bugzilla.wikimedia.org/72818) (owner: 10Dbrant) [17:40:06] MaxSem: Could you add descriptions for the return values of the methods in WikiGrok? It would make the code a lot easier to trace. [17:40:55] sure [17:41:02] (03CR) 10BearND: [C: 032] Fix possible crash when detached from activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 (https://bugzilla.wikimedia.org/72818) (owner: 10Dbrant) [17:41:05] (03CR) 10Cscott: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [17:41:23] (03Merged) 10jenkins-bot: Fix possible crash when detached from activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170321 (https://bugzilla.wikimedia.org/72818) (owner: 10Dbrant) [17:42:00] (03PS3) 10BearND: Fix possible crash involving the main ProgressBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [17:44:02] (03PS9) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 [17:44:04] (03PS1) 10Jdlrobson: Support other instance types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170360 [17:46:02] (03PS6) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [17:46:04] (03PS5) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [17:46:09] (03PS5) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [17:46:18] (03CR) 10Cscott: [C: 032] Fix possible crash involving the main ProgressBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [17:46:39] (03Merged) 10jenkins-bot: Fix possible crash involving the main ProgressBar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [17:47:26] kaldari: do you know who's working on the a/b testing spike? [17:47:35] it's currently in dev unassigned [17:47:48] phuedx: no idea [17:47:56] anyone? [17:48:07] dbrant: fyi, cscott helped me get your patches merged (in qa channel) [17:48:31] bearND: cool beans, thx [17:48:40] phuedx: I assumed you were going to work on that one, since you had been asking questions about it [17:49:17] kaldari: i kinda think it's done [17:49:50] i could write up a quick note on it explicitly answering the questions and then move it to sign off [17:49:59] just don't want to tread on anyone's toesies [17:54:18] that's right [17:54:21] toesies [17:55:03] phuedx: sounds good to me, unless someone else speaks up [17:55:48] (03PS1) 10Bmansurov: Fix WikiGrok B license link styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170362 [17:57:04] kaldari: please review ^ when you can [17:57:59] bearND: can dr0ptp4kt make his builds from the latest master (with the fixes)? or should we bump again? [17:59:00] (03CR) 10Jdlrobson: [C: 04-1] Add query parameter to force WikiGrok version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:00:08] (03CR) 10Jdlrobson: "Bmansurov but on the plus side when you are editing a file you know exactly which module it is shipped with and thus how to retrieve it in" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson) [18:01:52] (03CR) 10Bmansurov: "Jdlrobson, are there any cases where we may have to use the same file in different modules?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson) [18:02:25] bmansurov: no if you are using the same file in two modules you are doing it wrong [18:02:36] bmansurov: as the code has the possibilities of being loaded twice [18:02:50] jdlrobson: ok [18:02:57] dbrant: dr0ptp4kt can release from latest this time. It'll be tagged so that's cool. [18:03:32] dr0ptp4kt: ^ you're good to go; just build from master! [18:04:34] bearND and dbrant: which commit hash? c039fd6e5ef13c666cb7784fc03428993ef1e8c5 ? [18:05:21] dr0ptp4kt: looks right [18:05:24] dr0ptp4kt: yes, that one [18:05:43] dbrant, so I saw https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7922991#9394563 - do we want a similar thing to go to other reporters of that crash? [18:06:06] bearND and dbrant: thx [18:06:48] Krenair: no, i'm fairly confident about the fix... i just sent it to this user because he submitted four reports (!), and i hoped he might confirm the fix. [18:07:12] ahh [18:07:24] I hadn't noticed the others I had were all from that same person [18:07:24] ok [18:07:29] merging [18:07:31] (03CR) 10Bmansurov: [C: 031] Add query parameter to force WikiGrok version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:08:08] bmansurov: you beat me to it :) [18:08:17] phuedx: you're welcome [18:08:22] (03CR) 10Jhernandez: [C: 04-1] Add query parameter to force WikiGrok version (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:09:32] lots of code reviews ^ [18:09:54] yowza [18:10:00] dbrant, heh, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7820026 still stopped [18:10:18] joakino: default version makes sense [18:10:33] joakino: alternative is to hard stop (throw an error) [18:10:45] but i think i prefer the default version [18:11:13] phuedx: we could also let it flow to the no-parameter flow [18:11:35] phuedx: but that may be confusing, that's why i lean towards having a default version for that [18:12:12] phuedx: do as you want, it is a dev feature, but comment it :D [18:17:52] (03CR) 10Kaldari: [C: 031] Add query parameter to force WikiGrok version (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:18:03] yowza [18:18:27] jdlrobson: This is epic, we have 2 +1s and 2 -1s: https://gerrit.wikimedia.org/r/#/c/170324/ [18:19:10] will it be merged? [18:19:13] won't it? [18:19:15] who decides? [18:20:10] hah [18:20:29] i think we are all too scared of jdlrobson patches so we ended up reviewing that one [18:20:55] tried a restricted user profile on my nexus 10 tablet, confirmed that the ‘no-browser’ case is possible in this situation :D [18:21:41] (03CR) 10Jdlrobson: Add query parameter to force WikiGrok version (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:22:28] (03CR) 10Jhernandez: Add query parameter to force WikiGrok version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:24:43] wooow most heated patch ever [18:24:50] wish people were this keen on my patches :P [18:25:35] jdlrobson: you want some comments? [18:25:39] I'LL GIVE YOU COMMENTS [18:25:41] LOLZ [18:25:45] FRIDDDAYY [18:26:55] (03CR) 10Alex Monk: Fix possible crash involving the main ProgressBar. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170332 (https://bugzilla.wikimedia.org/72817) (owner: 10Dbrant) [18:27:28] 3Wikipedia App / 3Android App: NPE when updating ProgressBar - 10https://bugzilla.wikimedia.org/72817#c1 (10Alex Monk) 5NEW>3RESO/FIX Should be fixed by Gerrit change 170332 it seems [18:27:31] (03PS3) 10Phuedx: Add query parameter to force WikiGrok version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 [18:27:40] * phuedx runs and hides from the code review [18:28:02] (03CR) 10MaxSem: [C: 04-2] "Needs more work and a DBA review." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem) [18:28:46] (03CR) 10Phuedx: Add query parameter to force WikiGrok version (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:29:28] dbrant and bearND, able to hop on the batcave for a few minutes? [18:30:48] dr0ptp4kt: in a meeting for another ~1/2hr [18:31:34] dbrant: k [18:33:06] dr0ptp4kt: nm, just finished! [18:33:28] dbrant: k, i'm in the batcave [18:39:22] (03CR) 10Alex Monk: "Looks like this caused https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7922735" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168313 (https://bugzilla.wikimedia.org/71331) (owner: 10Dbrant) [18:41:55] (03CR) 10Jhernandez: [C: 031] "For me it's a +2, but since we all commented, let's see other opinioons :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:43:10] gotta love vbox going 120%... >:( [18:43:58] kaldari: do you have a sec? [18:44:12] yes [18:44:32] kaldari: so if I enable the 'next' button and the user doesn't select any suggestions, should we record it somehow? [18:44:44] kaldari: https://bugzilla.wikimedia.org/show_bug.cgi?id=72795 [18:46:56] (03CR) 10Phuedx: "> The reason is that the even though the backend may not have errors and for some reason the front end is not able to get response from th" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [18:49:01] bmansurov: As long as it logs the Next click, that's fine for now. Eventually, we'll want it to record all the ones they didn't select as well, but that's not part of this card. So for now the behavior should be the same as far as what gets recorded as the response. [18:49:19] kaldari: ok thanks [18:52:22] (03PS1) 10Bmansurov: WikiGrok B: Advance without selecting a tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170374 (https://bugzilla.wikimedia.org/72795) [18:53:47] (03CR) 10Jdlrobson: [C: 032] Add query parameter to force WikiGrok version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:55:53] jdlrobson: ^ for that we're all going to swarm each of your patches [18:55:57] \o/ [18:57:12] (03Merged) 10jenkins-bot: Add query parameter to force WikiGrok version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170324 (owner: 10Phuedx) [18:57:49] Maryana, when you've got a moment can you respond to the R&D trello pings? [18:57:56] no pressure, I'm just trying to tie things up [18:58:03] sure thing [18:58:19] ta! [18:59:26] kaldari: https://gerrit.wikimedia.org/r/#/c/169926/ ? [19:01:42] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788#c4 (10Bahodir Mansurov) I'm not able to reproduce this. scoppino.giuseppe@gmail.com what OS are you running? [19:04:23] Maryana: sorry, I was looking at the analysis column. The second column used to be 'Ready for Dev' [19:04:33] heh, no worries [19:09:24] (03CR) 10Kaldari: [C: 04-1] Fix WikiGrok B license link styling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170362 (owner: 10Bmansurov) [19:10:27] (03CR) 10Jhernandez: "Some comments about code style and such" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [19:12:17] (03PS2) 10Bmansurov: Fix WikiGrok B license link styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170362 [19:15:06] (03PS3) 10Bmansurov: Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 [19:15:11] (03CR) 10jenkins-bot: [V: 04-1] Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [19:15:42] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788#c5 (10scoppino.giuseppe) Hey, Bahodir, thanks for asking. Upon you asking, I booted into a Windows 7 64-bit installation and found myself unable to reproduce the pro... [19:21:20] (03PS4) 10Bmansurov: Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 [19:25:21] (03PS20) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [19:26:57] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788#c6 (10Bahodir Mansurov) 5UNCO>3RESO/WON Thanks, scoppino.giuseppe@gmail.com! Since Windows 10 is still in development(?) I'm closing this bug for now. Feel free... [19:27:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [19:28:12] 3MobileFrontend / 3General/Unknown: Wikimedia mobile view search not functional in stable Chrome (v38) - 10https://bugzilla.wikimedia.org/72788 (10Alex Monk) 5RESO/WON>3RESO/WOR [19:34:55] dbrant: are there plans to implement this (https://gerrit.wikimedia.org/r/#/c/168208/) in android app? (Searching "nearby" by coords or pagename) [19:35:21] (03CR) 10Kaldari: [C: 032] Fix WikiGrok B license link styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170362 (owner: 10Bmansurov) [19:35:59] 3MobileFrontend / 3alpha: File Chooser dialog opens when clicked anywhere on the page - 10https://bugzilla.wikimedia.org/72827 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Visit http://127.0.0.1:8080/wiki/Special:Uploads 2. Click anywhere on the page (menu, search area... [19:36:23] FlorianSW: definitely plans, but not really a time frame :( [19:36:43] dbrant: hmm :/ ok, but plans are good, thanks :) [19:38:05] jdlrobson: i'm usually alright +2ing, but i've had dealings with rl before [19:38:14] 3MobileFrontend / 3stable: Long username overlaps the logout button - 10https://bugzilla.wikimedia.org/72828 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3None Created attachment 16981 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16981&action=edit long username See the attached screensh... [19:38:18] phuedx: which patch? The Mantle one? [19:38:22] yarrrp [19:38:31] i can assure you it will not create caching problems [19:38:41] so provided Mobile doesn't explode with it you are good to go [19:39:04] (03Merged) 10jenkins-bot: Fix WikiGrok B license link styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170362 (owner: 10Bmansurov) [19:40:28] 3MobileFrontend / 3alpha: File Chooser dialog opens when clicked anywhere on the page - 10https://bugzilla.wikimedia.org/72827#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/jlMUasg1 [19:40:28] 3MobileFrontend / 3stable: Long username overlaps the logout button - 10https://bugzilla.wikimedia.org/72828#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/DIdyAskq [19:41:52] bearND, dbrant: https://lists.wikimedia.org/pipermail/mobile-l/2014-September/008012.html still a problem. With the new stable release there was one start with a fast starttime, but now again the same issue :/ [19:43:27] FlorianSW: do we have a bug in bugzilla for this? [19:45:30] bearND: öhm, no, because it's not reproduceable for several devices, should it be a bug report? I can create one :) [19:45:42] 3MobileFrontend / 3stable: Enable meta viewport width=device-width - 10https://bugzilla.wikimedia.org/72820#c3 (10Jon) Note: it seems setting width=device-width has a side effect of making the search overlay scrollable (Chrome Android/ioS) so sadly this bug is not as trivial as simply adding it to the meta t... [19:46:23] jdlrobson: i see, because the timestamp-related functions are left untouched [19:46:52] FlorianSW: yes, please create one. That would be a good reminder for me to check this out. I have a friend who's got a Moto G. [19:47:00] (03CR) 10Jdlrobson: [C: 04-1] "Code is fine but can we check with a designer first? They asked for that behaviour. Get one of them to comment on the card or the gerrit p" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170374 (https://bugzilla.wikimedia.org/72795) (owner: 10Bmansurov) [19:47:05] bearND: great! :) [19:47:32] phuedx: correct :) [19:49:49] cool [19:49:54] am gonna head off for the night folks [19:50:05] / buy some sweets for the people hammering on our doors [19:50:27] jdlrobson: i'll take a look at the brave new world patch soon ;) [19:50:29] 3Wikipedia App / 3Android App: Moto G: high startup time - 10https://bugzilla.wikimedia.org/72830 (10Florian) 3NEW p:3Unprio s:3normal a:3None There is a user with a Motorola Moto G (Android 4.4.4), who has a very high startup time of the app (~50 seconds), normal page views in the mobile browser wor... [19:50:31] bearND: ^ [19:50:37] night folks! [19:51:39] phuedx: at this point it's just a proof of concept, but i'm keen to work out if the team thinks this would be a useful direction to go in [19:51:52] joakino was commenting how there were so many files to edit just to get js on a page [19:52:47] MaxSem: hi, can you help me find the php code where the items on this page get rendered? http://localhost:8080/wiki/Special:MobileMenu спс [19:53:14] FlorianSW: thanks [19:53:49] bearND: thanks for you :P [19:54:03] bmansurov: SkinMinerva.php i think [19:54:14] DarTar-away: https://trello.com/c/5lqwrBHK/73-1-in-wikigrok-version-b-make-it-possible-to-advance-without-selecting-a-tag [19:54:20] bmansurov it's a function near getFooter() [19:54:23] or so [19:54:36] kaldari: looking [19:54:37] FlorianSW: thanks [19:55:27] kaldari: do you mean that right now it’s mandatory to select at least one tag before submitting? [19:55:34] DarTar: yes [19:55:41] (03CR) 10Jhernandez: [C: 031] Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [19:56:01] yes, there should definitely be a way for people to proceed without selecting anything [19:56:22] or we won’t know whether the user abandoned the task or no tag applied [19:56:28] so +1 [19:57:16] DarTar: Thanks [19:57:24] np, good catch [19:57:42] 3Wikipedia App / 3Android App: NPE when fragment(s) detached from activity - 10https://bugzilla.wikimedia.org/72818#c3 (10Alex Monk) 5PATC>3RESO/FIX Presumably this is fixed now [19:57:57] 3MobileFrontend / 3stable: Long username overlaps the logout button - 10https://bugzilla.wikimedia.org/72828#c2 (10Jon) Mm.. should be using truncated-text class. This seems to be a regression. [20:00:54] Maryana: can you add a video link to the hangout? I can’t change the event [20:04:14] 3Wikipedia App / 3Android App: HttpRequestException crashes - 10https://bugzilla.wikimedia.org/72832 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None From EditPreviewFragment: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7922735 https://ticket.wikimedia.org/otrs/index.pl?A... [20:06:47] Have we seen these kinds of IndexOutOfBoundsException crashes before? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7912603 [20:07:19] I seem to recall we have, but I don't remember the details to link it to an entry in BZ/Gerrit [20:07:45] something fixed within the past 2 weeks? [20:08:14] 3Wikipedia App / 3Android App: HttpRequestException crashes - 10https://bugzilla.wikimedia.org/72832#c1 (10Dmitry Brant) 5NEW>3PATC These will be fixed by: https://gerrit.wikimedia.org/r/169962 [20:09:32] Krenair: continuing to investigate that... it's not clear why it would happen. [20:10:28] FlorianSW: I can't find it. Can you help me find it? [20:10:57] FlorianSW: where is the line that renders the 'Settings' text for example [20:10:59] ? [20:11:40] bmansurov: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/skins/SkinMinerva.php#L283 [20:12:06] FlorianSW: big thanks [20:12:34] (03CR) 10Jhernandez: [C: 031] Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 (owner: 10Jdlrobson) [20:12:45] bmansurov: np :P [20:15:20] (03PS2) 10Dbrant: Handle network-related exceptions when doing a POST. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 [20:23:50] dbrant: are you going to add the bug # and the @throws docs to ^? [20:24:00] bearND: yep! doing now [20:24:07] dbrant: awesome! [20:24:39] dbrant: once that's done, I'll merge and push the jar to the mvn team repo [20:26:34] [20:31:53] (03CR) 10Jhernandez: [C: 032] Support other instance types (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170360 (owner: 10Jdlrobson) [20:32:29] (03PS3) 10Dbrant: Handle network-related exceptions when doing a POST. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 [20:32:55] (03PS4) 10Dbrant: Handle network-related exceptions when doing a POST. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 (https://bugzilla.wikimedia.org/72832) [20:33:38] bearND: ^ [20:34:36] dbrant: :) [20:36:40] (03CR) 10Jhernandez: [C: 032] Wikidata API enhancements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170355 (owner: 10Jdlrobson) [20:36:48] (03CR) 10BearND: [C: 032] Handle network-related exceptions when doing a POST. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 (https://bugzilla.wikimedia.org/72832) (owner: 10Dbrant) [20:37:08] (03CR) 10BearND: [V: 032] Handle network-related exceptions when doing a POST. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/169962 (https://bugzilla.wikimedia.org/72832) (owner: 10Dbrant) [20:43:27] (03PS1) 10BearND: Update MW API to 1.3-SNAPSHOT [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170399 [20:43:50] dbrant: ^ also uploaded the jar to the mvn team repo [20:44:29] (03CR) 10Jhernandez: [C: 04-2] "This patch is awesome, but wtf is untitled.txt? x__x" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170271 (owner: 10Jdlrobson) [20:45:05] (03CR) 10Jhernandez: [C: 04-1] Create generic intermediate loader function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170271 (owner: 10Jdlrobson) [20:46:16] (03PS2) 10Jdlrobson: Create generic intermediate loader function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170271 [20:46:23] (03PS2) 10Jdlrobson: Only load LanguageOverlay when needed, use M.loadModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170272 [20:48:56] (03PS1) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 [20:49:10] (03CR) 10Florianschmidtwelzow: "It's just a crazy idea :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (owner: 10Florianschmidtwelzow) [20:51:14] (03PS2) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 [20:53:02] anyone have a clue on how long it usually takes for one of these update scripts to run on the tool server? [20:53:12] (03CR) 10Jhernandez: [C: 031] Only load LanguageOverlay when needed, use M.loadModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170272 (owner: 10Jdlrobson) [20:54:20] rmoen: ping somebody [20:54:26] (03PS1) 10Dbrant: Ensure that build works with the updated java-mwapi. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170432 [20:54:47] kaldari|2: ^ [21:00:10] (03PS2) 10Dbrant: Update MW API to 1.3-SNAPSHOT [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170399 (owner: 10BearND) [21:01:56] (03CR) 10Dbrant: "feel free to self-merge after the dependent build fix." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170399 (owner: 10BearND) [21:04:54] (03CR) 10Kaldari: [C: 032] Add Sam to credits [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169921 (owner: 10MaxSem) [21:05:14] (03Merged) 10jenkins-bot: Add Sam to credits [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169921 (owner: 10MaxSem) [21:05:33] (03CR) 10Kaldari: [C: 032] Fix phpcs warnings [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169932 (owner: 10MaxSem) [21:05:53] (03Merged) 10jenkins-bot: Fix phpcs warnings [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169932 (owner: 10MaxSem) [21:06:46] rmoen: Sam's took about 10 minutes and it was a simple one. [21:06:47] (03PS6) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [21:06:49] (03PS7) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [21:06:51] (03PS6) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [21:06:53] (03PS1) 10Jdlrobson: Species infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170434 [21:06:55] (03PS1) 10Jdlrobson: Add movie posters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 [21:06:57] (03PS1) 10Jdlrobson: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [21:07:12] kaldari|2: hmm ok. So this might take a while. [21:07:16] (03PS2) 10Jdlrobson: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 [21:07:31] (03PS1) 10Florianschmidtwelzow: Truncate Username in mobile menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170437 (https://bugzilla.wikimedia.org/72828) [21:07:55] rmoen: Also I had to bump the memory limit for Sam's script. [21:09:01] rmoen: 200M wasn't enough :P [21:09:22] but it worked with 400M [21:11:26] kaldari|2: hmmk, no memory limit specified. I think i'm at the point where its querying all the wikipedia's pagelinks [21:11:59] kaldari|2: ^ i basically copied magnus's update_occupations script and plugged in our candidates db [21:12:36] it says its only been runing for 15 minutes but i feel like its been way longer [21:13:39] afk for a bit [21:13:51] (03PS1) 10MaxSem: Fix logic mess, split conditions to AND / OR ones [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 [21:13:56] kaldari|2, ^^^ :P [21:15:41] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727 (10Florian) [21:18:55] (03PS2) 10MaxSem: Fix logic mess, split conditions to AND / OR ones [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 [21:24:26] 3MobileFrontend / 3alpha: File Chooser dialog opens when clicked anywhere on the page - 10https://bugzilla.wikimedia.org/72827#c2 (10Florian) Only reproduceable on actual Chrome (for me) and only desktop. Not with Firefox and not with IE. [21:29:11] Ironholds: ios breakdown lgtm. thanks for the quick turnaround [21:29:21] also, i'm sad that you're not in the office to appreciate my costume [21:29:32] Maryana, what did you come as? [21:29:34] and don't say Death [21:29:40] ha, no [21:29:41] dean venture [21:29:42] or you'll be the second Death I know today [21:29:43] (03CR) 10Kaldari: [C: 04-1] Fix logic mess, split conditions to AND / OR ones [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [21:29:44] NICE [21:30:03] i feel somewhat insulted that i dressed like a 12-year-old boy and nobody thinks it's a costume [21:30:05] next year I want to do Spider Jerusalem, but I don't know how much of that is just looking for an excuse to shave all my hair off and see how it looks. [21:30:08] * Ironholds snorts [21:30:33] only jared has gotten it so far [21:32:32] (03CR) 10Kaldari: Fix logic mess, split conditions to AND / OR ones (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [21:32:39] that's sad, I'd expect K4 to. [21:32:58] Maryana, you know your mistake? [21:32:59] oh, i don't think she's seen me today [21:33:07] well, i need a hank -- he's coming later [21:33:16] neat! [21:33:24] (03CR) 10Kaldari: Fix logic mess, split conditions to AND / OR ones (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [21:33:25] you could also have got Greg to shave his hair off and whine a lot [21:33:30] haha [21:33:44] (the worst bit of moving away; not getting you and greg in for a death/dream/destiny piece. We just need a book, a chain and a robe!) [21:33:55] i think kaldari would make a good dr. venture, actually, but he'd have to dye his goatee red [21:34:00] ooh, point [21:34:08] hmn. And greg could also stand in for destruction. [21:34:10] delirium [21:34:12] always delirium [21:34:19] no, sometimes delirium! [21:34:21] jdlrobson: hey can I pick your brain on Resources.php and js/less compilation before I go?? [21:34:22] and sometimes shockingly lucid [21:34:24] that's how it works [21:36:42] alright, I have 12 months to find a short brunette and a tall blonde *looks determined* [21:36:52] (03CR) 10Kaldari: Fix logic mess, split conditions to AND / OR ones (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [21:36:52] also a shitty suit and a futuristic raygun. So I've got 1 out of 4. [21:39:16] joakino: sure [21:39:31] (03CR) 10MaxSem: Fix logic mess, split conditions to AND / OR ones (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [21:43:22] jdlrobson: can you take a look at the logged data for anonymous editing? (amount) [21:43:27] FlorianSW: sure [21:43:34] across all projects? [21:43:49] jdlrobson: yes, and, if possible, on it wiki [21:43:55] :) [21:45:26] (03PS1) 10Bmansurov: Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) [21:45:42] FlorianSW: is it enabled on italian wiki? [21:46:09] FlorianSW: it doesn't seem to be [21:46:16] not seeing anon link on https://it.m.wikipedia.org/wiki/Locuzione [21:46:50] FlorianSW: only seeing 13 anonymous edits [21:46:54] jdlrobson: it's in alpha?! [21:47:29] jrlsobson: 13 for all project? [21:47:36] (03PS5) 10Jdlrobson: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) [21:54:16] dbrant|bbl, brion: Sorry for my absence. Had a doctor's appointment. I'm all healthy, yay! [21:54:20] dbrant|bbl, brion: How's it swinging? Anything I can help with? [21:55:01] coming along! [21:56:43] 3MobileFrontend / 3Hygiene: JS console warnings - 10https://bugzilla.wikimedia.org/72839 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon ResourceLoaderTemplateModule is deprecated please use ResourceLoaderFileModule and Use of "get" is deprecated. mw.mantle.template.get is deprecated use mw.template.get ins... [21:56:47] (03PS3) 10MaxSem: Fix logic mess, split conditions to AND / OR ones [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 [21:58:36] DarTar: I can't seem to find the analytics/limn-mobile-data repo in gitbit: https://git.wikimedia.org/summary/analytics/limn-mobile-data.git [22:00:29] 3MobileFrontend / 3Hygiene: JS console warnings - 10https://bugzilla.wikimedia.org/72839#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dQEADxpJ [22:00:45] kaldari|2, https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#mobile_issue [22:01:26] joakino: https://www.mediawiki.org/wiki/Requests_for_comment [22:02:06] jdlsobson: 13 for all project? [22:05:24] kaldari|2: http://git.wikimedia.org/summary/?r=analytics/limn-mobile-data.git [22:16:20] (03PS3) 10Jdlrobson: Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 [22:16:22] (03PS1) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [22:17:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [22:17:59] (03CR) 10Jdlrobson: [C: 04-1] "Blocked on upstream patch" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson) [22:18:05] (03CR) 10Jdlrobson: [C: 04-1] "Blocked on upstream patch" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170434 (owner: 10Jdlrobson) [22:18:22] (03CR) 10Jdlrobson: [C: 04-1] "Blocked on upstream patch" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 (owner: 10Jdlrobson) [22:18:30] (03CR) 10Jdlrobson: [C: 04-1] "Blocked on upstream patch" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 (owner: 10Jdlrobson) [22:18:38] (03CR) 10Jdlrobson: [C: 04-1] "Blocked on upstream patch" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 (owner: 10Jdlrobson) [22:26:01] (03CR) 10Jdlrobson: [C: 04-1] Show logout link on Special:MobileMenu when JS is disabled (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) (owner: 10Bmansurov) [22:26:55] (03CR) 10Jhernandez: [C: 032] Create generic intermediate loader function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170271 (owner: 10Jdlrobson) [22:27:30] (03CR) 10Kaldari: [C: 032] Fix logic mess, split conditions to AND / OR ones [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [22:27:32] (03Merged) 10jenkins-bot: Create generic intermediate loader function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170271 (owner: 10Jdlrobson) [22:27:47] (03Merged) 10jenkins-bot: Fix logic mess, split conditions to AND / OR ones [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170438 (owner: 10MaxSem) [22:28:23] (03CR) 10Jhernandez: [C: 032] Only load LanguageOverlay when needed, use M.loadModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170272 (owner: 10Jdlrobson) [22:28:26] 3Wikipedia App / 3Android App: HttpRequestException crashes - 10https://bugzilla.wikimedia.org/72832#c2 (10Alex Monk) 5PATC>3RESO/FIX Was merged. [22:29:00] (03Merged) 10jenkins-bot: Only load LanguageOverlay when needed, use M.loadModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170272 (owner: 10Jdlrobson) [22:29:05] (03CR) 10Jdlrobson: [C: 04-1] "Cool! :)" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (owner: 10Florianschmidtwelzow) [22:29:33] (03CR) 10Jhernandez: [C: 032] Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 (owner: 10Jdlrobson) [22:30:13] (03Merged) 10jenkins-bot: Correctly identify humans [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169769 (owner: 10Jdlrobson) [22:30:15] (03Merged) 10jenkins-bot: Wikidata API enhancements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170355 (owner: 10Jdlrobson) [22:30:20] (03Merged) 10jenkins-bot: Support other instance types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170360 (owner: 10Jdlrobson) [22:33:39] (03CR) 10Jdlrobson: [C: 04-1] Truncate Username in mobile menu (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170437 (https://bugzilla.wikimedia.org/72828) (owner: 10Florianschmidtwelzow) [22:37:11] 3MobileFrontend / 3stable: Enable meta viewport width=device-width - 10https://bugzilla.wikimedia.org/72820#c4 (10Bahodir Mansurov) Jon, isn't search overlay supposed to be scrollable if you have many results? Is it scrollable when there is nothing in the overlay? Can you explain more? [22:37:39] (03CR) 10Kaldari: [C: 032] Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [22:37:44] (03CR) 10jenkins-bot: [V: 04-1] Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [22:38:23] bmansurov: https://gerrit.wikimedia.org/r/#/c/169626/ needs a rebase [22:38:46] (03PS1) 10Bmansurov: WIP: Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) [22:39:22] (03CR) 10jenkins-bot: [V: 04-1] WIP: Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) (owner: 10Bmansurov) [22:40:57] (03PS5) 10Bmansurov: Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 [22:46:17] (03CR) 10Jhernandez: [C: 04-1] "A couple of issues:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [22:50:23] (03PS2) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [22:51:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [22:51:40] (03CR) 10Kaldari: [C: 032] Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [22:52:16] (03Merged) 10jenkins-bot: Log WikiGrok errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169626 (owner: 10Bmansurov) [22:54:22] (03PS2) 10Bmansurov: Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) [22:55:02] (03CR) 10jenkins-bot: [V: 04-1] Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) (owner: 10Bmansurov) [22:55:59] (03PS3) 10Bmansurov: Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) [22:57:32] (03PS1) 10Jdlrobson: Deprecate usage of `one`. Use `once` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170462 (https://bugzilla.wikimedia.org/72711) [22:58:42] (03CR) 10jenkins-bot: [V: 04-1] Deprecate usage of `one`. Use `once` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170462 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [22:59:43] (03PS4) 10Jdlrobson: Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 [23:00:03] (03PS3) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [23:00:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [23:01:21] (03CR) 10Jdlrobson: [C: 04-1] "mm." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [23:01:30] (03PS2) 10Jdlrobson: Deprecate usage of `one`. Use `once` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170462 (https://bugzilla.wikimedia.org/72711)