[09:16:15] yello [13:34:04] (03PS1) 10Dbrant: Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 [13:52:46] (03PS2) 10Dbrant: Migrate all app install IDs to be the same as the old reading action ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170285 (owner: 10Deskana) [14:03:33] (03CR) 10Dbrant: [C: 032] "wfm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170285 (owner: 10Deskana) [14:05:51] (03PS4) 10Dbrant: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [14:06:43] (03CR) 10Dbrant: [C: 04-1] "please see comment from PS2" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [14:09:30] (03PS2) 10Dbrant: Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 [14:14:46] (03PS22) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [14:19:57] (03PS7) 10Dbrant: Face detection in lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 [14:23:58] (03PS1) 10Dbrant: Wikidata description under page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170698 [14:24:18] (03CR) 10jenkins-bot: [V: 04-1] Wikidata description under page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170698 (owner: 10Dbrant) [14:25:25] (03PS2) 10Dbrant: Wikidata description under page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170698 [14:41:42] 3MobileFrontend / 3Feature requests: Need option to switch off "Thanks" - 10https://bugzilla.wikimedia.org/72903 (10pamdavies7) 3UNCO p:3Unprio s:3normal a:3None Given the slow progress on "Bug 61737 - Thank notification on mobile doesn't ask for confirmation: accident-prone" and "Bug 69636 - Thanks:... [14:44:11] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737#c21 (10pamdavies7) I've now filed Bug 72903 - Need option to switch off "Thanks", in view of the slow progress on this or Bug 69636. [14:45:25] 3MobileFrontend / 3Feature requests: Need option to switch off "Thanks" - 10https://bugzilla.wikimedia.org/72903#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3wykvR2X [16:15:23] (03CR) 10Phuedx: [C: 032] Deprecate usage of `one`. Use `once` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170462 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [16:16:12] (03Merged) 10jenkins-bot: Deprecate usage of `one`. Use `once` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170462 (https://bugzilla.wikimedia.org/72711) (owner: 10Jdlrobson) [16:41:55] 3MobileFrontend / 3Hygiene: Deprecate use of EventEmitter.prototype.one in MobileFrontend - 10https://bugzilla.wikimedia.org/72711 (10Jon) 5PATC>3RESO/FIX [16:49:32] (03CR) 10Phuedx: [C: 032] Fix: Really truncate long usernames [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170437 (https://bugzilla.wikimedia.org/72828) (owner: 10Florianschmidtwelzow) [16:50:17] (03Merged) 10jenkins-bot: Fix: Really truncate long usernames [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170437 (https://bugzilla.wikimedia.org/72828) (owner: 10Florianschmidtwelzow) [16:52:14] brion: Do you happen to remember when google usually do software releases? [16:52:23] Trying to work out when the ota for nexus 5 android l might drop [16:52:47] Reedy: they’re not terribly consistent, also they tend to do staged rollouts [16:52:52] yeah [16:52:58] so you might have to wait days even if it drops [16:53:00] I was more meaning when the ota file would end up being leaked [16:53:06] well, "leaked" [16:53:09] hah [16:53:12] so I can flash it manually, but save wiping stuff [16:54:06] but yeah, I'm familiar with the staged rollout and people spamming check for updates, deleting random things, voodoo and checking for updates again ;D [16:54:13] lol [16:54:25] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c4 (10Jon) Can you open the left menu at all? If not this is a duplicate of 72566 the fix for which I'm hoping to get lightning deployed. [16:54:32] apple’s got its problems, but i like that when they release an os update they fucking RELEASE IT [16:54:41] of course then the entire internet slows down cause everyone’s updating to ios 8 at once [16:55:17] lol [16:55:28] or any other 5 bajliion GB OS update [17:10:37] dbrant: just checking TWN right now [17:10:51] bearND: sure [17:13:37] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170725 [17:28:03] (03PS2) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170725 [17:29:43] (03CR) 10BearND: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170725 (owner: 10BearND) [17:30:02] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170725 (owner: 10BearND) [17:34:59] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910 (10Florian) 3NEW p:3Unprio s:3normal a:3Jon It also happens for alpha mode (yay!), i want to have a bug for this for tracking purposes. The login page of MobileFrontend actually is provided b... [17:35:26] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/tOKYUJrd [17:35:27] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910#c2 (10Florian) 5NEW>3ASSI Alpha patch: I8f89bdaf3dc7fde104f199554b18486c30580910 [17:35:41] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910 (10Florian) [17:36:56] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910 (10Florian) [17:37:55] 3MobileFrontend / 3stable: Long username overlaps the logout button - 10https://bugzilla.wikimedia.org/72828 (10Jon) 5PATC>3RESO/FIX [17:38:17] (03CR) 10Jdlrobson: [C: 032] "Maryana says let's go for it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170374 (https://bugzilla.wikimedia.org/72795) (owner: 10Bmansurov) [17:38:54] (03PS4) 10Jdlrobson: Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) (owner: 10Bmansurov) [17:39:19] (03Merged) 10jenkins-bot: WikiGrok B: Advance without selecting a tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170374 (https://bugzilla.wikimedia.org/72795) (owner: 10Bmansurov) [17:40:13] (03PS2) 10Jdlrobson: Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [17:41:17] (03PS1) 10MaxSem: Awwwwww [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170732 [17:41:44] (03CR) 10Jdlrobson: [C: 032] Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [17:42:33] (03CR) 10jenkins-bot: [V: 04-1] Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [17:44:55] (03CR) 10Jdlrobson: [C: 032] Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) (owner: 10Bmansurov) [17:45:50] (03Merged) 10jenkins-bot: Show logout link on Special:MobileMenu when JS is disabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170446 (https://bugzilla.wikimedia.org/72728) (owner: 10Bmansurov) [17:49:42] (03CR) 10Jdlrobson: [C: 04-1] Really Activate $wgUserMediaWikiUIEverywhere everywhere (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [17:51:19] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [17:51:26] (03PS2) 10Jdlrobson: Use Hook to add valid error messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170521 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [17:52:09] (03CR) 10Jdlrobson: [C: 031] "Can be merged once dependency is +2ed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170521 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [17:52:43] (03Abandoned) 10Jdlrobson: WIP: Make OverlayManager -> RouteManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170262 (owner: 10Jdlrobson) [17:53:17] brion: looking at the iOS TWN sync right now. Did you mean to make that change in https://translatewiki.net/wiki/Special:ManageMessageGroups? [17:53:53] (03CR) 10Florianschmidtwelzow: [C: 04-1] Really Activate $wgUserMediaWikiUIEverywhere everywhere (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [17:57:19] i go for dinner [17:57:26] (03CR) 10Jdlrobson: [C: 04-1] Link to Special:Nearby out of the article (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [17:57:27] and have a few small patches to review [17:57:35] i come back after ~30 minutes [17:57:39] jdlrobson has happened [17:57:46] i no longer have a few small patches to review [17:58:03] morning all [17:58:12] yo [18:02:15] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170741 [18:02:28] brion: morning, just sync TWN for iOS as well [18:02:31] synced [18:02:36] \o/ [18:02:37] thx [18:03:57] (03PS2) 10Florianschmidtwelzow: Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) [18:04:37] (03CR) 10jenkins-bot: [V: 04-1] Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [18:14:01] (03CR) 10Florianschmidtwelzow: Link to Special:Nearby out of the article (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [18:15:42] win 6 [18:15:43] bmansurov: he's taking a travel day [18:15:52] ok [18:16:33] jdlrobson: with your templates for resourceloader change [18:16:46] could that enable pre-compiling templates for the front-end? [18:17:35] (03CR) 10Kaldari: [C: 032] Awwwwww [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170732 (owner: 10MaxSem) [18:18:11] (03PS3) 10Florianschmidtwelzow: Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) [18:18:14] (03Merged) 10jenkins-bot: Awwwwww [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170732 (owner: 10MaxSem) [18:23:18] dbrant: "Update MW API to 1.3-SNAPSHOT" is not included in the Friday's builds [18:23:32] bearND: ah, yes... [18:26:12] 3MobileFrontend / 3General/Unknown: Empty cells displayed in (infobox) table - 10https://bugzilla.wikimedia.org/72857#c4 (10Jon) 5NEW>3RESO/INV Please add .content table.sinottico td to your MediaWiki:Mobile.css to remove this. We can't do anything our end, it serves the same HTML as desktop the skin is... [18:30:28] (03CR) 10BearND: [C: 04-1] "minor stuff" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 (owner: 10Dbrant) [18:31:06] dbrant: how critical do you think the MWAPI changes are? [18:33:01] bearND: not nearly as critical as the earlier crashing patches... but I feel really bad when I see a crash report when someone was submitting an edit (and lost it)! [18:33:04] (03CR) 10Brion VIBBER: [C: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170741 (owner: 10BearND) [18:33:22] (03PS1) 10Bmansurov: Align WikiGrok butons (except for tag buttons) left [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 [18:33:38] (03PS3) 10Brion VIBBER: Support colorized zero-rating messaging [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [18:36:04] (03CR) 10Jdlrobson: [C: 04-1] Really Activate $wgUserMediaWikiUIEverywhere everywhere (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [18:36:36] (03CR) 10Brion VIBBER: [C: 032] "looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/169950 (owner: 10Dr0ptp4kt) [18:37:41] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c5 (10Bahodir Mansurov) I can open the left menu, but sections won't expand. [18:38:02] dbrant: ok. Would you like me to do the releases? [18:38:37] (03PS2) 10Brion VIBBER: Add The Specialists Guild to the "About the Wikipedia app" page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170258 (owner: 10Deskana) [18:39:38] bearND: sure! that would be great [18:39:50] dbrant: ok [18:40:00] (03CR) 10Brion VIBBER: [C: 032] Add The Specialists Guild to the "About the Wikipedia app" page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170258 (owner: 10Deskana) [18:41:05] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170757 [18:41:20] (03PS2) 10Brion VIBBER: Migrate all app install IDs to be the same as the old reading action ID. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170286 (owner: 10Deskana) [18:41:36] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170757 (owner: 10BearND) [18:41:58] brion: https://twitter.com/evanmena/status/529292548461060096 [18:41:58] :D [18:42:11] lol [18:42:53] wow [18:43:28] I'm not sure if it's real, or someone mocked it up [18:43:43] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170757 (owner: 10BearND) [18:43:53] (03CR) 10Brion VIBBER: [C: 032] "looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/170286 (owner: 10Deskana) [18:47:09] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [18:48:40] gonna go get george to bed [18:50:13] phuedx: yeh i don't know what's going on with that patch [18:50:19] i'll have it fixed by time you get back though ;-) [18:51:11] jdlrobson: is "Error: Module not found: loggingSchemas/mobileWebWikiGrokError" the console error you were talking about this morning? [18:51:37] and is there a patch which fixes this already, if so I'll gladly merge it right now ;) [18:53:56] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c6 (10Jon) 5UNCO>3NEW Bahodir can you replicate on your local instance? [18:54:41] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c7 (10Bahodir Mansurov) yes, I'm about to push a fix [19:02:56] (03PS14) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [19:03:16] (03CR) 10Robmoen: "^ Rebased ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [19:05:10] jdlrobson: is there a way to run a piece of javascript code before jquery loads? the opera error is related to unhandled jquery exceptions [19:08:40] 3MobileFrontend / 3Feature requests: Need option to switch off "Thanks" - 10https://bugzilla.wikimedia.org/72903#c2 (10Jared Zimmerman (WMF)) I don't think this is justification for turning off the feature. The good far outweighs the few accidental taps I'm sure. [19:11:31] (03PS4) 10Florianschmidtwelzow: Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) [19:12:41] jdlrobson, kaldari: i would like to backport this change, what do you mean? https://gerrit.wikimedia.org/r/#/c/170437/3 [19:15:55] yo [19:16:02] FlorianSW: That would be fine with me [19:16:15] yoyo! whatup? [19:16:38] (03PS3) 10Dbrant: Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 [19:17:37] (03CR) 10jenkins-bot: [V: 04-1] Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 (owner: 10Dbrant) [19:17:57] (03PS4) 10Dbrant: Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 [19:18:51] jdlrobson: i don't understand why those warnings haven't disappeared in the jerkins build :/ [19:19:08] phuedx: mm? [19:19:14] phuedx: there are a load of follows up i need to do [19:19:16] it's messy [19:19:24] YAY [19:19:25] MESS [19:20:08] FlorianSW: hi, do you know how to add a piece of js code to the head of the document? [19:23:04] (03PS4) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [19:23:07] ^ phuedx this should fix it [19:23:21] jdlrobson: IT BETTER! [19:23:26] * phuedx shakes fist [19:23:37] mainly at jerkins [19:23:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [19:23:48] bmansurov: Why you want to do that? In the head i don't know if there is a function (maybe just do it via OutputPage::addHeadItem(), but i never tested it). To add the script to the button you can use OutputPage::addInlineScript [19:24:38] FlorianSW: there is an unhandled jquery error on opera mobile, so I want to listen to window.onerror before jquery runs [19:25:57] phuedx: argg [19:28:55] bmansurov: oh, ok... then try addHeadItem of OutputPage [19:29:08] bmansurov: -> https://doc.wikimedia.org/mediawiki-core/master/php/html/classOutputPage.html#ad37dc926166096712154a6e2e3ca33d8 [19:29:14] FlorianSW: thanks [19:29:26] bmansurov: please report, if it works :P [19:29:33] (03PS5) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [19:29:36] FlorianSW: ok [19:29:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [19:30:07] (03PS5) 10Jdlrobson: Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 [19:30:14] ^ phuedx this can get merged though [19:30:22] (03PS6) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [19:30:24] we'll just see about that [19:30:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [19:31:20] (03PS1) 10Florianschmidtwelzow: Fix: Really truncate long usernames [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170770 (https://bugzilla.wikimedia.org/72828) [19:31:51] (03PS2) 10Florianschmidtwelzow: Fix: Really truncate long usernames [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170770 (https://bugzilla.wikimedia.org/72828) [19:33:12] (03PS3) 10Florianschmidtwelzow: Fix: Really truncate long usernames [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170770 (https://bugzilla.wikimedia.org/72828) [19:34:17] bmansurov: There are several ways to add JS to the head. The easiest is to put it in a RL module with position set to 'top'. [19:34:40] bmansurov: But we usually try to avoid loading JS in the head if possible [19:34:42] kaldari: ok thanks [19:34:58] kaldari: I'm trying to test if my hypothesis is correct ;) [19:35:48] kaldari: are you ok with book a swat for ^ backport? I (maybe) can't be online to the times :/ [19:35:53] (03PS7) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [19:37:15] phuedx: \o/ [19:37:24] jdlrobson: what was it? [19:37:36] a bit of js hadn't been updated [19:37:40] was trying to get a template incorrectly [19:38:59] FlorianSW: sure, just send me the gerrit URLs for the backport(s) [19:39:54] (03PS1) 10Jdlrobson: Hygiene: Stop compile deprecation warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170774 [19:40:05] kaldari: great :) https://gerrit.wikimedia.org/r/#/c/170770/ if you want i can put it into Deployments on wikitech, if you give me your prefered time :) [19:41:17] FlorianSW: Go ahead and put ity in the next SWAT window (00:00 Tuesday) [19:41:32] kaldari: ok :) thanks! [19:42:24] (03PS3) 10Jdlrobson: Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [19:43:15] (03CR) 10Phuedx: [C: 032] Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 (owner: 10Jdlrobson) [19:43:25] 3MobileFrontend / 3stable: Mouse cannot expand/contract headers - 10https://bugzilla.wikimedia.org/72566#c28 (10Chris H-C) I don't know your integration schedule or policy... could you give me an idea when we'll start seeing this patch in Beta or on the public site? [19:43:32] phuedx: will be a series of patch to kill the warnings. Scared to do it in a one big go [19:43:43] jdlrobson: absolutely the right approach [19:43:51] (03Merged) 10jenkins-bot: Hygiene: Use core templates for table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170105 (owner: 10Jdlrobson) [19:44:02] (03PS4) 10Jdlrobson: Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [19:44:07] (03CR) 10Jdlrobson: [C: 032] Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [19:44:11] aha! [19:44:28] that's what it was, i noticed that error this morning but didn't get round to checking it out [19:44:43] kaldari: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=133242&oldid=133231 [19:44:43] :) [19:44:47] (03Merged) 10jenkins-bot: Ensure event logging works with wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170482 (owner: 10Bmansurov) [19:45:23] FlorianSW: thanks [19:45:39] kaldari: thanks to you :P [19:50:26] (03PS8) 10Jdlrobson: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) [19:50:28] (03PS2) 10Jdlrobson: Hygiene: Stop compile deprecation warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170774 [19:50:30] (03PS3) 10Florianschmidtwelzow: Use Hook to add valid error messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170521 (https://bugzilla.wikimedia.org/71769) [19:51:27] jdlrobson: was ps8 a rebase? [19:51:38] errr i forget :-S [19:52:03] looks like it [19:52:11] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c8 (10Bahodir Mansurov) So, on my local environment this error happens only when DragonFly is open. On wikipedia links above it happens even when DrangonFly is closed. Jon, any ideas how to fix it? [19:52:38] FlorianSW: addHeadItem works as you said [19:52:57] bmansurov: great :D thanks for reply :P [19:53:13] np [19:53:34] (03CR) 10Phuedx: [C: 032] Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [19:53:56] jdlrobson: gotta do some chores [19:53:59] :( [19:54:10] (03Merged) 10jenkins-bot: Hygiene: Migrate modules using 'parse' message command to ResourceLoaderParsedMessageModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170448 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [19:54:53] (03PS1) 10Jdlrobson: Hygiene: Use core template method in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170777 [19:56:25] ttyl [19:58:53] all right team, WikiGrok is live on testwiki [19:59:05] phuedx, mind testing your API there? [19:59:38] (03PS1) 10Jdlrobson: Hygiene: AbuseFilter overlay and panel should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170779 [20:02:58] do we have some iOS app developers here? [20:06:19] (03PS2) 10Jdlrobson: Hygiene: AbuseFilter overlay and panel should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170779 [20:06:21] (03PS1) 10Jdlrobson: Hygiene: Move over VE to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170780 [20:08:28] 3Wikipedia App / 3iOS App: Icons are too big for Tablet - 10https://bugzilla.wikimedia.org/72916 (10Florian) 3NEW p:3Unprio s:3normal a:3None This user (https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7929397;) complains the big icons in the app, especially on the iPad. [20:08:40] 3Wikipedia App / 3iOS App: Icons are too big for Tablet - 10https://bugzilla.wikimedia.org/72916#c1 (10Florian) 5NEW>3UNCO I have no iOS device, so i can't test it. -> Unconfirmed [20:08:46] (03PS1) 10Jdlrobson: Hygiene: Page issues use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170782 [20:09:51] MaxSem: my local environment stopped working all of a sudden. I reloaded vagrant, but still can't access the site. What should I do to fix it? [20:10:23] um, hhvm borkage [20:10:33] enable the zend role.... [20:10:56] thanks [20:14:20] jdlrobson: after your latest commit, I'm getting this error: Fatal error: Class 'ResourceLoaderParsedMessageModule' not found in /vagrant/mediawiki/includes/resourceloader/ResourceLoader.php on line 506 [20:18:49] bmansurov: confirmed...ohoh :/ [20:19:10] jdlrobson: ^ ;) [20:19:27] FlorianSW: bmansurov: did you update Mantle? [20:19:32] Extension:Mantle [20:19:40] jdlrobson: damn :P [20:19:49] i don't make such silly mistakes ;-) [20:19:53] jdlrobson: cool [20:20:14] (03PS1) 10Jdlrobson: Hygiene: Nearby should use core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170783 [20:20:22] phuedx: just grabbing lunch but working my way through those errors ^ :) [20:20:37] hopefully by time i'm back you'll be caught up with code review :) [20:20:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Nearby should use core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170783 (owner: 10Jdlrobson) [20:21:23] jdlrobson: "i don't make such silly mistakes" I would be surprised :) [20:26:58] FlorianSW: is js disabled for you after updating? [20:28:40] bmansurov: you mean?7 [20:28:45] *?7 -> ? [20:29:25] when I click on the left menu icon, I'm taken to the Special:MobileMenu page [20:29:42] FlorianSW: ^ and the menu won't open [20:29:51] FlorianSW: with js I mean, it just loads a page [20:30:23] * FlorianSW is testing [20:31:08] bmansurov: nope, it's all working :) alpha/beta/stable mode? Can you click the "Edit" link? [20:31:35] FlorianSW: edit link is hidden [20:32:14] hidden?! on a wikitext content page? [20:32:26] FlorianSW: yes no pencil icon [20:32:34] (03PS1) 10BearND: Change location of apk to releases dir [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170786 [20:33:00] :/ and mw core, mobilefrontend and mantle on latest master? [20:33:10] FlorianSW: yes they are, I'll reload vagrant, maybe that'll help [20:33:30] sounds scary :) [20:34:53] FlorianSW: no luck, i'll ask jon when he comes back from lunch. thanks [20:35:30] have you js errors? [20:36:15] FlorianSW: oh yeah, forgot to check: Unknown dependency: mediawiki.template [20:36:24] FlorianSW: thanks, I'll debug it [20:36:58] bmansurov: mediawiki.template is a core dependency [20:37:34] ok [20:38:12] FlorianSW: silly me, I was pulling the wrong repo [20:38:19] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169828 (owner: 10Anomie) [20:38:21] :D [20:38:26] cool :P [20:38:57] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169828 (owner: 10Anomie) [20:39:39] (03PS1) 10Alex Monk: VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) [20:42:40] (03PS2) 10Jdlrobson: Hygiene: Nearby should use core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170783 [20:50:48] (03PS5) 10BearND: Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 (owner: 10Dbrant) [20:50:55] (03CR) 10BearND: [C: 032] Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 (owner: 10Dbrant) [20:51:34] (03Merged) 10jenkins-bot: Stop using the Bus unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170691 (owner: 10Dbrant) [20:56:22] dbrant: What was the reason why you removed the screenOrientation hack from PageActivity? [20:57:57] dbrant: Now when I rotate the screen it goes back to the main page, and open dialogs get dismissed by that as well. [20:59:10] (03PS1) 10Jdlrobson: Hygiene: mobile.ajax should use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170798 [20:59:12] (03PS1) 10Jdlrobson: Hygiene: Don't use ResourceLoaderTemplateModule when you don't have to [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 [21:00:03] bearND: it greatly simplifies the laying-out of the lead image components. With the hack, I couldn't do the layout without it being jarring to the user... [21:00:13] bearND: But it shouldn't be going to the main page :( [21:02:00] bearND: steps to reproduce? [21:03:42] dbrant: open app, go to another page, e.g. scallops, click on Similar pages link, rotate device [21:04:18] bearND: hmm! doesn't happen for me [21:04:21] 3Wikipedia App / 3Android App: "User exists" not messaged in account creation - 10https://bugzilla.wikimedia.org/72923#c1 (10Jon Katz) Created attachment 17007 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17007&action=edit after clicking exclamation point [21:04:21] 3Wikipedia App / 3Android App: "User exists" not messaged in account creation - 10https://bugzilla.wikimedia.org/72923 (10Jon Katz) 3NEW p:3Unprio s:3minor a:3None Created attachment 17006 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17006&action=edit when error occurs the error for user e... [21:04:26] 3Wikipedia App / 3Android App: "User exists" not messaged in account creation - 10https://bugzilla.wikimedia.org/72923#c2 (10Jon Katz) The error text should show without click being necessary. [21:04:33] dbrant: you can also skip the Similar pages link. [21:04:41] dbrant: I'll send you a video [21:04:49] hey bmansurov [21:04:59] (03CR) 10Kaldari: [C: 032] Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [21:05:01] dbrant: or i can show you on hangout if you want to come to the batcave [21:05:14] kaity: hi [21:05:23] bearND: sure, batcave [21:05:40] (03Merged) 10jenkins-bot: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [21:05:41] dbrant: ok, i'm there [21:16:00] I’d like to get some #wikimedia-mobile folks to come out to https://news.ycombinator.com/item?id=8553490 [21:17:40] bmansurov: want to talk about https://trello.com/c/ZyfC4MOe/64-5-improve-reference-display-for-better-readability in about 30 min? [21:18:16] kaity: ok [21:24:02] (03PS1) 10Jdlrobson: Hygiene: Move tests over to core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170808 [21:34:22] (03PS1) 10Jdlrobson: Hygiene: mobile.special.uploads.scripts should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170810 [21:34:24] (03PS1) 10Jdlrobson: Hygiene: Migrate mobile.contentOverlay to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170811 [21:34:27] (03PS1) 10Jdlrobson: Hygiene: Kill the overlay template related warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170812 [21:34:58] Maryana: hi, can you explain what you mean by "Switcher in VisualEditor/Wikitext editor" in https://trello.com/c/Vh51EzgU/43-bug-72653-issues-with-icons-in-alpha-get-fixed-so-we-can-move-it-to-beta ? thanks [21:36:24] bmansurov: in the tablet mobile view, if you go into the edit screen, there'll be a cog icon in the top right toolbar – this is the "switcher" between regular wikitext editing and the visual editor [21:36:39] Maryana: sure, I see that [21:37:24] bearND: ok, i'm able to reproduce *some* weird behavior involving changing themes. I'll work on an update. [21:37:25] i'm not sure what the issue with it is, though. looks like jon reported the bug? [21:37:36] Maryana: ok thanks, I'll talk to jdlrobson [21:37:48] dbrant: k [21:37:56] jdlrobson: what's the issue with the visual editor icon in https://trello.com/c/Vh51EzgU/43-bug-72653-issues-with-icons-in-alpha-get-fixed-so-we-can-move-it-to-beta ? [21:42:27] dbrant|brb: now i can repo it when i go to nearby, saved pages, history, or random and then rotate [21:42:34] (03CR) 10Jdlrobson: [C: 04-1] "Classes like align-left are not meaningful and not a semantic class name. Please either rename the class to something more meaningful and " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [21:42:55] dbrant|brb: in those cases it goes to the previous page [21:44:54] (03PS5) 10Jdlrobson: Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [21:45:15] (03CR) 10Jdlrobson: [C: 032] Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [21:47:21] (03CR) 10Jdlrobson: [C: 032] VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) (owner: 10Alex Monk) [21:47:46] (03CR) 10Jdlrobson: [C: 032] Use Hook to add valid error messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170521 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [21:50:39] bmansurov: I updated the trello card with the latest designs [21:50:57] bmansurov: let me know what questions you have! sorry for the last minute changes [21:51:07] (03Merged) 10jenkins-bot: Really Activate $wgUserMediaWikiUIEverywhere everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170518 (https://bugzilla.wikimedia.org/72853) (owner: 10Florianschmidtwelzow) [21:51:18] (03CR) 10jenkins-bot: [V: 04-1] VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) (owner: 10Alex Monk) [21:51:20] (03Merged) 10jenkins-bot: Use Hook to add valid error messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170521 (https://bugzilla.wikimedia.org/71769) (owner: 10Florianschmidtwelzow) [21:52:03] urgh [21:52:09] kaity: thanks [21:52:32] (03PS1) 10Bmansurov: WIP Fix alpha icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170831 [21:52:42] Krenair, agh? [21:52:54] MaxSem, jenkins failure on https://gerrit.wikimedia.org/r/170790 [21:53:09] because qunit [21:53:44] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910 (10Jon) [21:53:44] 3MobileFrontend / 3Hygiene: Tracking: Getting rid of own login page - 10https://bugzilla.wikimedia.org/72910 (10Jon) [21:53:44] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758 (10Jon) [21:53:44] 3MobileFrontend / 3Feature requests: Mobile login not compatible with OpenID - 10https://bugzilla.wikimedia.org/52059 (10Jon) [21:55:16] (03PS2) 10Jdlrobson: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [21:55:22] (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [21:57:43] jdlrobson, hey [21:58:41] 3MobileFrontend / 3General/Unknown: action=purge has no discernible button - 10https://bugzilla.wikimedia.org/72853 (10Jon) 5PATC>3RESO/FIX [22:05:34] (03PS2) 10Bmansurov: Left align WikiGrok butons (except for tag buttons) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 [22:05:41] (03CR) 10jenkins-bot: [V: 04-1] Left align WikiGrok butons (except for tag buttons) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [22:09:06] (03PS3) 10Bmansurov: Left align WikiGrok butons (except for tag buttons) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 [22:12:39] (03PS1) 10Robmoen: Add mobile mode getter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170838 [22:12:41] (03PS2) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [22:13:31] (03Abandoned) 10Robmoen: Mobile mode getter and implement in schemas and WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168336 (owner: 10Robmoen) [22:19:23] (03Abandoned) 10Robmoen: Add missing WikiGrok documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169599 (owner: 10Robmoen) [22:21:49] (03PS2) 10Bmansurov: Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) [22:22:27] (03CR) 10jenkins-bot: [V: 04-1] Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) (owner: 10Bmansurov) [22:23:55] (03PS3) 10Bmansurov: Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) [22:24:32] (03CR) 10jenkins-bot: [V: 04-1] Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) (owner: 10Bmansurov) [22:26:00] (03PS4) 10Bmansurov: Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) [22:34:18] (03PS2) 10Jdlrobson: VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) (owner: 10Alex Monk) [22:38:01] (03PS1) 10Amire80: Correct positioning for the issues icon in RTL wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170848 [22:40:19] MaxSem: do you know why I can't import a page at Special:Import? WHen I hit the submit button, the next page won't load [22:41:22] looks like you'll need to re-approve it jdlrobson [22:41:28] (03CR) 10Jdlrobson: [C: 032] "WFM on Chrome and ios" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) (owner: 10Bmansurov) [22:41:54] (03CR) 10Alex Monk: Drag some Wikipedia domain stuff into the Site class (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [22:42:04] (03Merged) 10jenkins-bot: Enable meta viewport width=device-width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170449 (https://bugzilla.wikimedia.org/72820) (owner: 10Bmansurov) [22:42:41] 3MobileFrontend / 3stable: Enable meta viewport width=device-width - 10https://bugzilla.wikimedia.org/72820 (10Jon) 5PATC>3RESO/FIX [22:43:32] (03PS2) 10Jdlrobson: Hygiene: Add mobile mode getter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170838 (owner: 10Robmoen) [22:44:13] (03PS5) 10Alex Monk: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 [22:47:41] (03CR) 10Jdlrobson: [C: 032] Hygiene: Add mobile mode getter (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170838 (owner: 10Robmoen) [22:48:04] hello [22:48:04] (03CR) 10Jdlrobson: VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) (owner: 10Alex Monk) [22:48:08] (03CR) 10Jdlrobson: [C: 032] VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) (owner: 10Alex Monk) [22:48:19] (03Merged) 10jenkins-bot: Hygiene: Add mobile mode getter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170838 (owner: 10Robmoen) [22:48:47] (03Merged) 10jenkins-bot: VE: Don't set @grayDark colour for tool titles in disabled widgets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170790 (https://bugzilla.wikimedia.org/72405) (owner: 10Alex Monk) [22:49:56] (03CR) 10Jdlrobson: [C: 04-1] Left align WikiGrok butons (except for tag buttons) (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [22:51:10] kaity: where can I get the citation icon? [22:52:23] (03PS2) 10Jdlrobson: i18n: Correct positioning for the issues icon in RTL wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170848 (owner: 10Amire80) [22:52:49] bmansurov: oops just attached to trello card [22:53:12] kaity: thanks [22:54:30] (03CR) 10Jdlrobson: [C: 032] i18n: Correct positioning for the issues icon in RTL wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170848 (owner: 10Amire80) [22:55:07] (03Merged) 10jenkins-bot: i18n: Correct positioning for the issues icon in RTL wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170848 (owner: 10Amire80) [22:56:11] 3MobileFrontend / 3General/Unknown: Empty cells displayed in (infobox) table - 10https://bugzilla.wikimedia.org/72857#c5 (10Nemo) I'm not sure all our table-based templates use that class. Should we override the mobile classes in all our templates? [22:57:51] (03PS3) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [22:58:24] (03PS4) 10Dr0ptp4kt: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [23:00:43] bmansurov, on hhvm? [23:01:00] MaxSem: I don't know, where do I check? [23:01:11] Special:Version [23:02:02] MaxSem: there is no hhvm word on that page [23:02:44] hm [23:02:51] check error log [23:03:32] MaxSem: ok, i'll do so [23:40:48] hey kaity, what are the height and width of the cancel button? [23:41:32] bmansurov: 12x12 px [23:41:40] kaity: thanks [23:41:58] (03CR) 10Kaldari: [C: 032] Fix: Really truncate long usernames [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170770 (https://bugzilla.wikimedia.org/72828) (owner: 10Florianschmidtwelzow) [23:42:28] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169849 (owner: 10Anomie) [23:43:05] (03Merged) 10jenkins-bot: Fix: Really truncate long usernames [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170770 (https://bugzilla.wikimedia.org/72828) (owner: 10Florianschmidtwelzow) [23:43:09] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/169849 (owner: 10Anomie) [23:47:31] rmoen: I merged your API JS code, but not SWAT deploying it yet. Since your code was written we changed the workflow a bit so that now it is possible to submit a WikiGrok B response without actually selecting any of the tags (in case none of them are correct). Since Sam's code (which was written before that was the case) assumes that the user is always selecting a tag, it throws an error if an.... [23:47:40] API request is submitted without a claim... [23:48:06] So we need to implement https://trello.com/c/AjVoudN4/93-2-make-wikigrok-v-b-record-null-claims before we deploy your code [23:50:33] kaldari: ok. looking [23:53:00] kaity: what's the margin after the citation line? [23:56:55] 3MobileFrontend / 3General/Unknown: Empty cells displayed in (infobox) table - 10https://bugzilla.wikimedia.org/72857#c6 (10Jon) What other tables have the same issue? If it's all tables you could of course create a generic rule for all tables and simply do .content table td { border: none; }