[00:11:49] kaldari: do you know why ".background-image('images/cite.svg')" won't turn to data-image? [00:12:00] kaldari: it's just rendering as a link [00:13:42] bmansurov: not sure, see what happens if you try to bypass the mixin: background-image: e('/* @embed */') url(@url); [00:14:47] kaldari: nothing, the same result [00:15:04] bmansurov: must not be able to find the file [00:15:26] kaldari: this is the url: http://127.0.0.1:8080/w/extensions/MobileFrontend/less/modules/references/images/cite.svg [00:15:27] You can check in Firebug (or most other CSS debuggers) [00:15:51] kaldari: ohhh i see [00:17:13] kaldari: nm, i thought the relative path was wrong, but the mixin still doesn't work [00:17:39] is the non mix-in version working now? [00:18:47] kaldari: MaxSem so did the wikigrok eventlogging changes go out? [00:19:01] Maryana: mostly yes [00:19:31] kaldari: no, it's still generating a url [00:22:11] jdlrobson: hey you there? [00:24:44] (03PS5) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [00:25:28] bmansurov: one minute, have to talk to analytics about an EV bug.... [00:25:43] ok [00:28:08] bmansurov: yup currently fighting some ios bugs [00:28:31] jdlrobson: ok, i won't bother you, kaldari is going to help me, thanks [00:30:12] (03CR) 10Jdlrobson: [C: 04-1] "I currently can't replicate the issue on current master so I'm not convinced this is needed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170265 (https://bugzilla.wikimedia.org/72695) (owner: 10Jhernandez) [00:30:14] (03PS6) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [00:40:52] (03PS7) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [00:52:40] 3MobileFrontend / 3stable: Language super zoom in ios when visiting language overlay - 10https://bugzilla.wikimedia.org/72695#c9 (10Jon) 5PATC>3UNCO I can't seem to replicate this on beta labs or local master.... I think removing the tap code may have fixed it? [00:59:47] jdlrobson: you still there? kaldari seems busy. So, why won't .background-image mixin embed the image, but it just outputs the link? [01:01:34] bmansurov: I thought the mix-in wasn't the issue, didn't you say it failed with background-image as well? [01:01:48] kaldari: yes, you're right, they both failed [01:01:55] kaldari: is that a php issue? [01:04:35] (03PS1) 10Bmansurov: Improve reference display for better readability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [01:04:57] bmansurov: shouldn't be, does using debug=true make any difference? [01:05:10] (03Abandoned) 10Bmansurov: WIP: Update reference styling. Show adjacent references at once. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170122 (owner: 10Bmansurov) [01:05:21] (03CR) 10jenkins-bot: [V: 04-1] Improve reference display for better readability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [01:05:52] bmansurov: What's the exact line of CSS you're using? [01:06:16] kaldari: debug=true didn't work either [01:06:44] kaldari: it's this file: https://gerrit.wikimedia.org/r/#/c/170873/1/less/modules/references/references.less [01:06:54] kaldari: .background-image('../images/cite.svg'); [01:08:27] kaldari: sorry, it works now [01:08:32] kaldari: wrong path [01:08:39] :) [01:12:31] (03PS2) 10Bmansurov: Improve reference display for better readability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [01:13:08] (03CR) 10jenkins-bot: [V: 04-1] Improve reference display for better readability [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [01:25:34] (03PS8) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [01:27:00] (03PS4) 10Bmansurov: Left align WikiGrok butons (except for tag buttons) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 [01:41:09] (03PS1) 10Robmoen: Add alma_mater (schools) to WikiGrok Dialog b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170877 [02:05:57] (03PS1) 10Jdlrobson: Conditionally load mobile.newuser code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) [02:21:02] i'm outta here for the day :) [02:21:04] see you all tomorrow :) [04:15:20] (03CR) 10Jdlrobson: [C: 04-1] "Please make this beta only. All our features should be put in beta first. The card didn't mention this so it's not your fault... a side ef" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [06:15:04] (03CR) 10Yurik: [C: 04-1] WIP: Make mdot show language list quickly (035 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt) [06:37:18] (03CR) 10Florianschmidtwelzow: "otherwise looks good :-)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) (owner: 10Jdlrobson) [07:08:32] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Kill the overlay template related warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170812 (owner: 10Jdlrobson) [07:59:57] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c9 (10Matus UHLAR - fantomas) (In reply to Jon from comment #4) > Can you open the left menu at all? > If not this is a duplicate of 72566 the fix for which I'm hoping to get > lightning deployed... [08:08:02] (03PS1) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 [08:18:23] (03PS1) 10Florianschmidtwelzow: Watchstar: Add missing "please wait" message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170888 [08:49:47] (03CR) 10BearND: [C: 04-1] "Needs manual rebase." (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [10:26:41] 3MobileFrontend / 3stable: Language super zoom in ios when visiting language overlay - 10https://bugzilla.wikimedia.org/72695#c10 (10Jhernandez) I can't reproduce the issue in the iOS simulator either, so this has stopped being an issue. I'll abandon the patch on gerrit. So weird... Should we mark this one... [10:27:45] (03Abandoned) 10Jhernandez: Avoid megazoom after tapping input and closing overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170265 (https://bugzilla.wikimedia.org/72695) (owner: 10Jhernandez) [10:38:42] hey joakino_ [10:38:50] hi!! [10:38:54] * phuedx just realised that you'd be on today! [10:39:07] haha yea [10:39:17] i'm not alone anymore [10:39:20] how're you doing after yer travel? [10:39:52] still recovering, tonight ive slept 3 hours... [10:40:11] i'll be fine :D [10:40:22] i /hate/ travelling back [10:40:56] * joakino_ nods [10:41:03] i find drinking oodles of coffee helps ;) [10:41:45] i'm on it, second mug already :) [10:42:10] what times are you connected, more or less? [10:44:40] 10 am - 8 pm gmt [10:45:37] i take breaks at 1 pm and 6.30 pm for lunch and getting my son, george, to bed [10:46:12] cool [10:46:38] I have to figure it out, I'll probably do something similar [10:47:34] yeah, those hours work for my family right now [10:47:42] might shift later once number 2 arrives [10:48:31] are you expecting the second? or just planning for it [10:50:20] expecting [10:50:24] < 2 weeks [10:50:27] (hard deadline) [10:55:09] wow congrats!! [10:57:39] thanks :) [11:00:05] (03CR) 10Phuedx: [C: 032] Hygiene: Stop compile deprecation warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170774 (owner: 10Jdlrobson) [11:00:14] ^ this is what i'm going to be doing for most of the day :/ [11:00:19] so joakino_ [11:00:24] have you worked from home before? [11:00:26] are you wfh? [11:00:58] (03Merged) 10jenkins-bot: Hygiene: Stop compile deprecation warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170774 (owner: 10Jdlrobson) [11:02:40] phuedx: yeap i've seen the patches from jdlrobson [11:02:56] phuedx: he is doing good work to get the debug mode to work properly again in mobile frontend [11:03:03] its all for a good cause [11:03:05] it's the best approach, there's just a lot of patches [11:03:15] yeah, lots of commits [11:03:27] phuedx: he moves so fast xd [11:03:52] phuedx: yeah i've worked from home all 2014 as a remote contractor [11:04:05] cool [11:04:11] (same) [11:04:18] never with such a big time difference though [11:04:26] same same [11:04:33] it's not too much of a problem [11:04:33] for me its 9 hours, 8 for you right? [11:04:36] yup [11:04:48] i really like waking up to a whole bunch of code review [11:04:56] despite my little whinge 2 minutes ago [11:04:56] yeah everything is pretty well organized for remotes [11:05:06] the mobile team used to be mainly remote i reckon [11:05:10] *iirc [11:05:30] so they understand [11:05:45] i used to do 2-3 days remote at my previous job [11:05:53] and they didn't understand for a long time :/ [11:07:02] yeah all the team needs to be on board [11:07:12] otherwise it is a recipe for disaster [11:08:46] (03CR) 10Phuedx: [C: 032] Hygiene: Use core template method in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170777 (owner: 10Jdlrobson) [11:09:14] 3MobileFrontend / 3stable: Checkboxes on Settings page move on tap (ios 8) - 10https://bugzilla.wikimedia.org/72946 (10Jhernandez) 3NEW p:3Unprio s:3normal a:3None Created attachment 17011 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17011&action=edit Misaligned checkboxes Reproduced on re... [11:09:25] (03Merged) 10jenkins-bot: Hygiene: Use core template method in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170777 (owner: 10Jdlrobson) [11:10:25] 3MobileFrontend / 3stable: Checkboxes on Settings page move on tap (ios 8) - 10https://bugzilla.wikimedia.org/72946#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/8azTrNYS [11:20:52] (03CR) 10Phuedx: [C: 032] "LGTM. Tested by forcing EditorApi#save to reject with an AbuseFilter warning/error." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170779 (owner: 10Jdlrobson) [11:21:35] (03Merged) 10jenkins-bot: Hygiene: AbuseFilter overlay and panel should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170779 (owner: 10Jdlrobson) [11:25:17] * phuedx waits for vagrant to mount nfs shared folders [11:25:19] ... [11:28:29] phuedx: vagrant has been screwing me today, i've got to git-update it and reload/provision a couple of times ... [11:28:42] phuedx: patience [11:28:51] joakino_: what's that? [11:28:58] i've never heard that word before [11:29:07] haha [11:29:38] it is surprising how random and not deterministic software is most of the time... [11:29:48] at least from our point of view [11:34:23] big systems are hard to reason about [11:34:36] and there are very few simple systems running on yer machine [11:37:40] tch tch, all apple systems are super simple and user friendly [11:37:43] didn't you know? [11:44:51] phuedx: do you have any wikidataID for testing wikigrok that returns multiple questions on version B? [11:45:15] I'm always using the Anne dallas one and it only has one question on version B [11:45:32] joakino_: not off the top of my head [11:45:33] hrrrm [12:09:45] (03CR) 10Phuedx: [C: 04-1] "This breaks the VisualEditor overlay. The mobile.editor.ve module can't be loaded because the template paths are wrong." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170780 (owner: 10Jdlrobson) [12:11:13] (03PS2) 10Phuedx: Hygiene: Move over VE to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170780 (owner: 10Jdlrobson) [12:11:53] (03CR) 10Phuedx: "PS2 fixes the issue above. It's also a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170780 (owner: 10Jdlrobson) [12:14:09] (03CR) 10Phuedx: [C: 032] Hygiene: Move over VE to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170780 (owner: 10Jdlrobson) [12:17:27] (03Merged) 10jenkins-bot: Hygiene: Move over VE to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170780 (owner: 10Jdlrobson) [12:42:40] (03PS1) 10Jhernandez: Record all answers (+ & -) in wikigrok b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 [12:44:01] (03CR) 10Jhernandez: Record all answers (+ & -) in wikigrok b (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [15:33:56] 3MobileFrontend / 3stable: Language super zoom in ios when visiting language overlay - 10https://bugzilla.wikimedia.org/72695#c12 (10Jon) 5UNCO>3RESO/WOR I blame tap events! :) [15:42:15] huzzah [15:42:17] internet! [15:43:33] (03PS2) 10Phuedx: Hygiene: Page issues use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170782 (owner: 10Jdlrobson) [15:44:31] builders over the road clearly broke something [15:44:46] at least, i'm going to blame it on them [15:46:00] (03CR) 10Phuedx: [C: 032] Hygiene: Page issues use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170782 (owner: 10Jdlrobson) [15:46:35] (03Merged) 10jenkins-bot: Hygiene: Page issues use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170782 (owner: 10Jdlrobson) [15:58:12] only for a short while though, so y'know [16:00:31] (03CR) 10Phuedx: Record all answers (+ & -) in wikigrok b (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [16:01:47] (03PS23) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [16:02:08] (03CR) 10Jhernandez: [C: 032] Add alma_mater (schools) to WikiGrok Dialog b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170877 (owner: 10Robmoen) [16:02:14] (03CR) 10Phuedx: Record all answers (+ & -) in wikigrok b (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [16:02:49] (03Merged) 10jenkins-bot: Add alma_mater (schools) to WikiGrok Dialog b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170877 (owner: 10Robmoen) [16:05:15] also, hey kristenlans [16:07:53] (03CR) 10Dbrant: "bearND - excellent comments; should be all better now. I've actually drastically simplified how the Theme Change is handled, but that onl" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [16:08:57] phuedx: I've been looking this morning through the response schema, but I don't know where the JS `correct` field maps to the schema [16:09:44] joakino: kaldari has asked me to improve the documentation around the api, and it's on my list [16:09:49] phuedx: I can see now that response is what i should have looked at, but where would I look for the api code to see what gets translated to what? [16:10:02] joakino: sec [16:10:11] k [16:10:22] * phuedx waits for git.wikimedia.org [16:10:31] is it on the wikigrok extension? [16:10:51] joakino: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiGrok.git/0e097b90319eda572682d1e08b48bc01a0385f8f/includes%2Fapi%2FApiResponse.php [16:11:02] i take responsibility for this not being easy to find [16:11:14] it should be documented elsewhere than the code [16:11:39] Hey phuedx :-) [16:12:07] phuedx: ooh ok, it is not hard to find, I just forgot about the wikigrok extension :S my bad [16:12:46] a simple search shows it: includes/api/ApiResponse.php 54: ‘response' => $claim['correct'], [16:13:56] yup [16:14:18] joakino: want to write a card to change the names so that they map almost 1 to 1? [16:14:44] (honestly i think it'd be easier to do it on the client side, but that's for discussion) [16:15:13] phuedx: if we do it I agree, do not touch the schema more than necessary [16:15:33] shall i write a card or do you want to? [16:15:40] it could be interesting [16:15:50] i think it's a neat little piece of work that'll make things easier to read [16:16:02] phuedx: ok, can you write it? [16:16:06] sure thing [16:16:30] So for this hygiene things, we create the card into 'In analysis'? or 'Ready for dev'? [16:18:52] (03CR) 10Jhernandez: Record all answers (+ & -) in wikigrok b (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [16:19:50] phuedx: ^ [16:20:17] joakino, kristenlans: q2 backlog to be analyzed? [16:20:19] look at me [16:20:21] spelling with a z [16:20:39] x) [16:22:12] joakino: https://trello.com/c/vkmddneA/112-make-the-wikigrokresponse-api-parameters-match-the-mobilewebwikigrokresponse-schema [16:22:26] Joakino phuedx: I think “In Analysis” in the Current Sprint is a good bet. Then we’ll be sure to triage it during standup. [16:23:31] kristenlans: ta [16:24:08] phuedx joakino: And if waiting for the next standup to talk about it feels like too much time, you can always ping maryana (@maryana) in a comment on the card [16:24:28] suresies [16:24:37] it's really a hygiene thing [16:24:42] but i sorta wanted to write a story [16:24:50] (i've had three cups of coffee today) [16:24:54] (i'm a little giddy) [16:25:09] hahah x) [16:25:37] well we talked in standup about having more accountability on hygiene tasks, so creating those cards is probably a good idea [16:25:38] Phuedx: that sounds good. We talked about wanting to make hygiene stuff more visible. I quit coffee a few months ago, thinking of startign again [16:25:51] in the retrospective sorry [16:25:52] What joakino said ^ :-) [16:26:19] kristenlans: what do you do in the mornings? [16:26:27] tea? [16:26:30] exercise? [16:26:52] Phuedx: both :-) [16:27:25] kristenlans: i don't drink coffee for ~3 weeks every year [16:27:44] i drink two cups of coffee a day [16:27:58] but once i start to drink three regularly [16:28:00] then i hard stop [16:28:13] 3 weeks later i start drinking two again [16:28:31] turns out, i'm actually pretty disciplined when it comes to torturing myself [16:29:19] * phuedx is still importing a wikipedia dump into vagrant [16:29:32] *grumble* *grumble* *grumble* [16:29:39] lol [16:31:29] (03PS1) 10Florianschmidtwelzow: Fix OverlayFooterLink template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170941 [16:31:55] (03PS1) 10Jhobs: [WIP] News page tests with Cucumber error [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/170942 [16:32:17] phuedx: I’ve gone through similar coffee cycles. Once it gets to three cups, it’s hard for me to fall asleep at night. Then it’s time to stop and recalibrate [16:32:54] i'm currently brewing these: http://barn.bigcartel.com/product/bokasso-filter-ethiopia [16:33:10] and i've stepped up to three cups [16:33:22] it's time to stop again once i run out [16:33:27] (they are /delicious/) [16:35:42] (03PS3) 10Jdlrobson: Hygiene: Nearby should use core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170783 [16:36:13] 3MobileFrontend / 3stable: References drawer does not disappear upon clicking the page itself - 10https://bugzilla.wikimedia.org/72955 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None On a page with references e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_References_test_page Clicking... [16:39:33] (03CR) 10Jhernandez: Left align WikiGrok butons (except for tag buttons) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [16:40:42] 3MobileFrontend / 3stable: References drawer does not disappear upon clicking the page itself - 10https://bugzilla.wikimedia.org/72955#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/1dcLGsp8 [16:42:52] (03CR) 10Jdlrobson: Left align WikiGrok butons (except for tag buttons) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [16:46:21] (03CR) 10Jdlrobson: Conditionally load mobile.newuser code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) (owner: 10Jdlrobson) [16:47:26] 3MobileFrontend / 3stable: Checkboxes on Settings page move on tap (ios 8) - 10https://bugzilla.wikimedia.org/72946#c2 (10Jon) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 72727 *** [16:47:31] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727#c5 (10Jon) *** Bug 72946 has been marked as a duplicate of this bug. *** [16:47:35] (03CR) 10BearND: [C: 04-1] "Just one more minor issue: on 2.3, the 'g' in the "Main Page" title gets cut off at the bottom." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [16:50:06] anyone have special:nearby working on vagrant? [16:51:25] phuedx: i do [16:51:35] hrrrm [16:52:37] need anything? [16:52:50] joakino: is there a special invocation for getting it set up? [16:53:02] you need to enable the geodata role\ [16:53:27] and then there is a variable to use wikipedia's geo api instead of your local empty one [16:53:30] let me find it [16:53:43] AH HA [16:55:48] joakino: wgMFnearby [16:56:08] $wgMFNearbyEndpoint = 'https://en.m.wikipedia.org/w/api.php'; [16:56:13] phuedx: ^ [16:56:23] oh and that [16:56:53] i got it under settings.d/LocalSettings.php [16:56:53] I just got that one and it works :D [17:00:00] thanks joakino [17:00:09] i'd spotted the former, not the latter! [17:03:38] (03CR) 10Phuedx: [C: 032] Hygiene: Nearby should use core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170783 (owner: 10Jdlrobson) [17:04:15] (03Merged) 10jenkins-bot: Hygiene: Nearby should use core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170783 (owner: 10Jdlrobson) [17:07:18] (03PS2) 10Phuedx: Hygiene: mobile.ajax should use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170798 (owner: 10Jdlrobson) [17:08:57] (03CR) 10Phuedx: [C: 032] Hygiene: mobile.ajax should use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170798 (owner: 10Jdlrobson) [17:09:05] pew pew pew pew pew [17:09:32] (03Merged) 10jenkins-bot: Hygiene: mobile.ajax should use core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170798 (owner: 10Jdlrobson) [17:13:56] i know you're there jdlrobson! [17:14:00] SIGN IN TO IRC [17:15:11] dbrant, bearND: wonder what's going on in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7707510 / https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7892199 [17:23:22] (03PS2) 10Phuedx: Hygiene: Don't use ResourceLoaderTemplateModule when you don't have to [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 (owner: 10Jdlrobson) [17:23:45] i should've reviewed these in reverse order [17:40:06] (03PS1) 10Jhernandez: Hygiene: Fix method chaining code style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 [17:41:12] where is jdlrobson... [17:41:18] DANGIT [17:43:07] (03CR) 10Jhernandez: Left align WikiGrok butons (except for tag buttons) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [17:48:32] (03CR) 10Phuedx: [C: 031] "I've kicked the tyres of the affected features and they LGTM (which I expected, but y'know…)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 (owner: 10Jdlrobson) [17:53:37] (03PS2) 10Phuedx: Hygiene: Move tests over to core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170808 (owner: 10Jdlrobson) [17:53:47] (03CR) 10Florianschmidtwelzow: [C: 031] Conditionally load mobile.newuser code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) (owner: 10Jdlrobson) [17:55:22] (03CR) 10Phuedx: [C: 032] "I didn't know this was how we loaded tests for our modules. Interesting!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170808 (owner: 10Jdlrobson) [17:59:53] (03CR) 10Phuedx: [C: 032] Hygiene: mobile.special.uploads.scripts should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170810 (owner: 10Jdlrobson) [18:01:34] bearND, dbrant: is the app supposed to have a network error when you click a link to https://wg-en.wikipedia.org ? [18:03:05] Krenair: hmm, what should it display? [18:03:26] dbrant, the main page and a link to login? [18:03:52] hey joakino bmansurov phuedx rmoen :) [18:03:59] o hi! [18:04:10] hello jdlrobson, everyone. [18:04:16] hello [18:04:28] hey jdlrobson [18:04:38] i've been in yer patches [18:04:40] reviewing [18:04:40] (03PS3) 10Jdlrobson: Hygiene: Move tests over to core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170808 [18:04:46] (03CR) 10Jdlrobson: [C: 032] Hygiene: Move tests over to core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170808 (owner: 10Jdlrobson) [18:04:59] phuedx: i see thanks a bunch :) [18:05:07] joakino: thanks for kicking off writing those tests [18:05:07] MaxSem: hi, I'm not able to login in my local environment. Can you help me? Here is the error message: Notice: Did not find alias for special page 'CentralLogin'. Perhaps no aliases are defined for it? [Called from SpecialPageFactory::getLocalNameFor in /vagrant/mediawiki/includes/specialpage/SpecialPageFactory.php at line 679] in /vagrant/mediawiki/includes/debug/MWDebug.php on line 302 [18:05:28] (03Merged) 10jenkins-bot: Hygiene: Move tests over to core templating mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170808 (owner: 10Jdlrobson) [18:05:28] bmansurov: sounds like you need CentralNotice extension? [18:05:38] jdlrobson: to be sincere i haven't started, but I'll get to it [18:05:38] (03PS2) 10Jdlrobson: Hygiene: mobile.special.uploads.scripts should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170810 [18:05:39] jdlrobson: middle of the day my internet died so the review ground to a halt :( [18:05:39] ok thanks [18:05:43] (03PS2) 10Jdlrobson: Hygiene: Migrate mobile.contentOverlay to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170811 [18:05:45] http://www.theregister.co.uk/2014/11/04/remoteie_for_osx_ios_android [18:05:49] (03PS2) 10Jdlrobson: Hygiene: Kill the overlay template related warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170812 [18:07:17] (03CR) 10Phuedx: [C: 032] Hygiene: mobile.special.uploads.scripts should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170810 (owner: 10Jdlrobson) [18:07:35] jdlrobson: i've found two bugs during testing yer patches [18:07:46] which i'll report in a sec [18:07:53] (03Merged) 10jenkins-bot: Hygiene: mobile.special.uploads.scripts should use core templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170810 (owner: 10Jdlrobson) [18:07:55] joakino: glad to see you made it back safe :) did you still have clown makeup on at the airport? [18:08:31] Krenair: it looks like that site's API endpoint (api.php) doesn't work. So there's nothing that the app can do with it. [18:08:45] Maryana: just the black eyes :) like a goth [18:08:49] (03CR) 10Jdlrobson: "I forgot about style modules... I was using JS warnings to identify them. Done! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 (owner: 10Jdlrobson) [18:08:51] dbrant, doesn't work? [18:08:55] (03PS3) 10Jdlrobson: Hygiene: Don't use ResourceLoaderTemplateModule when you don't have to [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 [18:09:04] phuedx: eeeeek bugggss oh nos [18:09:08] dbrant, then why does it even try? [18:09:24] joakino: nice [18:09:25] jdlrobson: not with your stuff [18:09:33] just while testing your stuff [18:09:34] :) [18:09:42] (03CR) 10BearND: "Besides the stack trace I sent you, one more observation: whenever I rotate the device the progress bar reappears. What is going on there?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [18:09:53] phuedx: phheewww [18:10:00] (03CR) 10Phuedx: [C: 032] Hygiene: Migrate mobile.contentOverlay to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170811 (owner: 10Jdlrobson) [18:10:08] jdlrobson: your stuff has been fiiiinee! [18:10:21] brb [18:10:24] Krenair: because the app believes that subdomains of "wikipedia.org" are language variants of the site, instead of independent wikis. [18:10:25] apart from the ve module definition ;) [18:10:37] phuedx: orlllyy [18:10:37] (03Merged) 10jenkins-bot: Hygiene: Migrate mobile.contentOverlay to new template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170811 (owner: 10Jdlrobson) [18:10:57] yeah, you'd missed the templates/ in the paths to the templates [18:11:02] dbrant, it used to be a subdomain of en.wikipedia.org [18:11:03] eep did that get merged? [18:11:11] nope [18:11:14] i fixed it and then merged [18:11:19] interestingly though [18:11:27] totally silent failure [18:11:30] but the ssl certificate didn't work for those sub-sub-domains so they got changed, iirc [18:11:34] it took me a while to figure out what was up [18:11:57] (03PS2) 10Jdlrobson: i18n: Add missing "please wait" message to watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170888 (owner: 10Florianschmidtwelzow) [18:12:10] (03CR) 10Jdlrobson: [C: 032] i18n: Add missing "please wait" message to watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170888 (owner: 10Florianschmidtwelzow) [18:12:31] phuedx: oh reeally? i smell and upstream fix [18:12:32] *an [18:13:06] phuedx: shall i pick off where i left off on the template warning deprecations or did you write some patches? [18:13:43] jdlrobson: if you want, as i said, it's gone slowly because of teh interwebz [18:13:47] or lack thereof [18:13:48] ok going for it [18:13:54] i think i'm at the end of the review chain now [18:13:57] wait [18:14:10] jdlrobson: https://gerrit.wikimedia.org/r/170799 [18:14:21] oh [18:14:23] fine [18:14:31] you go ahead and reply to me and i won't notice then! [18:16:17] jdlrobson: is Max there? I can't get my local environment working, enabling centralrole didn't help [18:17:40] (03Merged) 10jenkins-bot: i18n: Add missing "please wait" message to watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170888 (owner: 10Florianschmidtwelzow) [18:19:06] (03CR) 10Phuedx: [C: 032] Hygiene: Kill the overlay template related warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170812 (owner: 10Jdlrobson) [18:19:46] (03Merged) 10jenkins-bot: Hygiene: Kill the overlay template related warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170812 (owner: 10Jdlrobson) [18:20:29] (03PS2) 10MaxSem: WIP: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [18:20:31] (03CR) 10Phuedx: [C: 032] Hygiene: Don't use ResourceLoaderTemplateModule when you don't have to [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 (owner: 10Jdlrobson) [18:20:44] * phuedx stretches [18:20:50] jdlrobson: i think that's all of 'em [18:21:09] (03Merged) 10jenkins-bot: Hygiene: Don't use ResourceLoaderTemplateModule when you don't have to [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170799 (owner: 10Jdlrobson) [18:21:29] jdlrobson: they were all really easy to make sense of [18:21:37] i like that it was per module [18:22:05] that is, small [18:22:06] :) [18:22:47] jdlrobson: are you doing 'em all [18:22:51] or do you want to split 'em? [18:35:24] bearND: the progress bar reappears whenever the sections are reloaded (even when it's from cache, i.e. after screen rotation). It's basically the "progress" of how many sections are populated into the webview. Do you think we shouldn't have it? [18:37:06] dbrant: hmm, maybe. Was mainly curious. [18:37:57] phuedx: yeh i'm currently breaking up mobile.stable.common [18:38:01] whilst i'm there i'm cleaning up the code [18:38:22] jdlrobson: i don't want to tread on yer toes [18:38:28] so i'm going to review other things [18:39:26] phuedx: sounds good [18:40:48] dbrant: if you apply the patch i sent you and fix the 'g' in "Main Page" on 2.3 then i think it's good to go for now. [18:42:15] Deskana, brion, dbrant - Hi! Any chance you could update https://translatewiki.net/wiki/Translating:WikimediaMobile ? [18:42:43] It *was* edited since July 2014, so maybe it's already good, but then Brion's notice at the top should be removed :) [18:42:54] (03CR) 10Phuedx: Record all answers (+ & -) in wikigrok b (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [18:45:43] bearND: completing... [18:45:51] heh [18:46:07] i’ll take a peek [18:46:27] (03CR) 10Jhernandez: Record all answers (+ & -) in wikigrok b (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [18:49:40] phuedx: gerrit is so bad for having conversations and comments ... I miss github [18:51:07] joakino: totally agree with the semantic classes approach [18:51:12] gerrit’s actually kinda nice for evolving a patch in response to feedback, but then you can do similar on github by force-updating your pull request [18:51:21] and github is prettier ;) [18:51:40] yup yup [18:51:45] to the former [18:51:51] brb [18:51:52] brion: agreed, but for commenting on the code, notifications and pull request comments it is much better [18:52:01] oh ya :D [18:52:05] getting george to bed [18:52:14] phuedx: i'm going too [18:52:34] phuedx: I'll have a look tomorrow to see if I can refactor the view a bit, it is too tangled the JS and the view [18:52:53] I should probably wait to finish the task of the tests tough [18:53:45] (03PS2) 10Jhernandez: Record all answers (+ & -) in wikigrok b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 [18:58:11] (03PS24) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [18:58:19] bearND: ^ [19:00:36] (03PS1) 10Robmoen: hygiene: Change source to task_type for consistency with MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170992 [19:04:50] (03PS1) 10Robmoen: hygiene: Change source to task_type for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170994 [19:05:10] (03PS2) 10Robmoen: hygiene: Change source to task_type for consistency with MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170992 [19:06:23] i'm done for today, bb! [19:08:50] dbrant: checking... [19:14:33] dbrant: make sure to let the team know about Thur [19:14:53] tfinc: cool, thanks! [19:15:04] i just approved it in ADP [19:15:26] awesome [19:18:37] dbrant: sorry, just sent you another stack trace [19:20:07] dbrant: gotta be careful about getActivity() being null in those fragments now since the orientation hack got removed [19:20:47] dbrant: there are probably more potential NPEs lurking around [19:21:57] bearND: hmm ok, let me take another pass through the code and get 'em... [19:24:38] bearND: this one kinda doesn't make sense, though, since we unregister from sensor updates in onPause... but i suppose it's an API 10 thing... [19:26:43] dbrant: maybe i got "lucky" that time [19:31:44] aharoni: I'll update that page. :-) [19:31:59] Deskana: thanks [19:32:10] I think the logo is a little... large. [19:33:28] aharoni, bearND: I guess Bernd should be listed as the support contact since he's our importer? [19:33:41] Deskana: good idea [19:33:47] aharoni, bearND: Or should it be me since I'm the product manager? [19:34:01] Deskana: no, listing me is fine [19:34:32] anybody who can answer question from translators and from translatewiki server maintainers is fine. [19:34:52] (03PS5) 10Bmansurov: Left align WikiGrok butons (except for tag buttons) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 [19:35:42] bearND: Do you have an account on twn? I can't seem to find your username. [19:36:05] Deskana: Bsitzmann [19:36:22] Thanks! [19:40:49] bbiab [19:40:56] hey bmansurov [19:41:05] can you check my question here: https://trello.com/c/uM5hM9cR/40-3-wikigrok-error-logging [19:41:09] DarTar: hello, 1 sec [19:41:17] sure [19:44:57] DarTar: i've replied in there [19:48:07] Hey Deskana! Feeling better? [19:52:40] (03PS1) 10Jdlrobson: Hygiene: Componentise mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171015 [19:52:42] (03PS1) 10Jdlrobson: Hygiene: Move PageList to core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171016 [19:52:44] (03PS1) 10Jdlrobson: Hygiene: Rewrite references to use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171017 [19:52:46] (03PS1) 10Jdlrobson: Hygiene: Notifications using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171018 [19:52:48] (03PS1) 10Jdlrobson: Hygiene: Editor overlay using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171019 [19:53:16] (03PS25) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [19:53:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Editor overlay using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171019 (owner: 10Jdlrobson) [19:54:02] bearND: ^ fixed the nearby crash. but nothing else really jumps out at me. we'll have to let our rigorous QA process iron out any other kinks ;) [19:54:49] (03PS1) 10Jdlrobson: Hygiene: ImageOverlay should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 [19:55:12] dbrant: and our alpha builds could help with that (cc: YuviPanda) [19:55:16] (03PS1) 10Bmansurov: Log an error when WikiGrok is unable to load labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171021 [19:55:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ImageOverlay should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 (owner: 10Jdlrobson) [19:55:50] kristenlans: Mostly! Still a bit off. [19:56:31] kristenlans: I slept a lot better last night, which always helps [19:58:25] Deskana: sleep is key. [19:58:28] and water [20:03:46] (03PS2) 10Jdlrobson: Hygiene: ImageOverlay should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 [20:04:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: ImageOverlay should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 (owner: 10Jdlrobson) [20:09:06] kristenlans: Just noticed our message now, I was busy drinking water. True story. [20:11:28] dbrant: dbrant_: sent a stack trace with Patch Set 25 [20:12:19] (03PS1) 10Robmoen: Validate claims in WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 [20:12:38] bearND: I used to be a fan of the droid x... [20:13:09] (03PS2) 10Robmoen: Validate claims in WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 [20:13:40] dbrant: i think it's 2.3 and support-v4 doing the onCreateOptionsMenu call too early, should probably happen on more 2.3 devices [20:14:01] dbrant: just rotate the heck out of the fragments contained within PageActivity [20:14:44] 3MobileFrontend / 3beta: Talk: Text area of add talk topic not indented. - 10https://bugzilla.wikimedia.org/72969 (10Jon) 3NEW p:3Unprio s:3normal a:3None wikitext-editor should also have a panel class. Most noticeable when viewing in tablet mode. [20:15:26] 3MobileFrontend / 3beta: Talk: Text area of add talk topic not indented. - 10https://bugzilla.wikimedia.org/72969#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ww4vVrqm [20:20:14] kaldari|2: so currently the api throws an error if there are no claims submitted to response api. I think you sent me a link to the card yesterday, but the api needs to be patched to allow no claims correct? [20:21:30] rmoen: Not necessarily. Really, we should always be recording something from WikiGrok even if it is just NULL claims from the unselected tags. [20:21:51] rmoen: Dario really wants that data too [20:22:03] i.e. which tags were NOT selected [20:23:01] rmoen: Here's the card: https://trello.com/c/AjVoudN4/93-2-make-wikigrok-v-b-record-null-claims . Let me know if that makes sense. [20:23:03] kaldari|2: let me rephrase, the php class ApiReponse needs to be patched to handle empty claims [20:23:23] rmoen: Yes, that's correct [20:23:46] This is an issue as when you hit 'next' it currently just spins forever. [20:25:30] rmoen: Well, actually, I'm not sure if it needs to be patched or not. Depends on if there's a way to pass a NULL value to the API and it still define the array value when it does the JSON decode. [20:25:52] (03PS2) 10Jdlrobson: Hygiene: Editor overlay using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171019 [20:25:54] (03PS2) 10Jdlrobson: Hygiene: Notifications using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171018 [20:25:56] (03PS3) 10Jdlrobson: Hygiene: ImageOverlay and TalkOverlays should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 [20:25:58] (03PS1) 10Jdlrobson: Hygiene: Wikigrok B should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171026 [20:26:00] (03PS1) 10Jdlrobson: Hygiene: Checkboxes on Special:MobileOptions (alpha) -> mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171027 [20:26:02] (03PS1) 10Jdlrobson: Complete deprecation of mw.mantle.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171028 (https://bugzilla.wikimedia.org/72839) [20:26:02] rmoen: Definitely needs some investigation [20:26:04] (03PS1) 10Jdlrobson: Hygiene: Fix indent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171029 [20:26:16] kaldari|2: checking out joakino's patch [20:27:51] rmoen: So it looks like joakino's patch sets correct to null, would be good to find out what exact API call that ends up generating and if the existing API can deal with it or not. [20:28:02] yeah [20:28:44] kaldari|2: so the api response is [] [20:28:47] no error [20:29:13] cool [20:29:54] that should resolve the deferred and not give us an infinite spinner then [20:31:06] yeah this works [20:31:19] (03CR) 10Robmoen: [C: 032] Record all answers (+ & -) in wikigrok b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [20:34:59] 3MobileFrontend / 3Uploads: Special:Uploads button not centered - 10https://bugzilla.wikimedia.org/72972 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17018 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17018&action=edit It appears left aligned, and is inconsistent with rest of... [20:35:03] (03CR) 10Robmoen: [C: 04-1] "This needs rebased and adjusted to accept null claims" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 (owner: 10Robmoen) [20:35:26] 3MobileFrontend / 3Uploads: Special:Uploads button not centered - 10https://bugzilla.wikimedia.org/72972#c1 (10Jon) It also appears to be trigged when clicking on the hamburger menu. [20:35:46] (03Merged) 10jenkins-bot: Record all answers (+ & -) in wikigrok b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170909 (owner: 10Jhernandez) [20:44:04] (03PS26) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [20:50:08] brb, yummy sandwich time [20:51:43] 3MobileFrontend / 3beta: Type error when storing widgetOffset in EventLogging - 10https://bugzilla.wikimedia.org/72639 (10Ryan Kaldari) 5PATC>3RESO/FIX [21:00:33] (03PS3) 10MaxSem: WIP: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [21:01:19] kaldari|2 & phuedx ^^^ please review so that we could start a DBA review process for it [21:03:17] (03PS4) 10MaxSem: WIP: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [21:03:59] 3MobileFrontend / 3alpha: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Created attachment 17020 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17020&action=edit screenshot See screenshot. [21:05:26] 3MobileFrontend / 3alpha: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nNdHy0Bq [21:08:13] 3MobileFrontend / 3alpha: Notifications icon is too small and badge is unstyled/missing - 10https://bugzilla.wikimedia.org/72979 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None In alpha, the notifications icon is now tiny. Also the red badge is missing. It's actually in the DOM but apparently not g... [21:10:26] 3MobileFrontend / 3alpha: Notifications icon is too small and badge is unstyled/missing - 10https://bugzilla.wikimedia.org/72979#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/GwdfNOMB [21:14:20] (03PS1) 10Jdlrobson: Create array of style modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171038 [21:14:22] (03PS1) 10Jdlrobson: Hygiene: Move tutorial styling into the appropriate module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171039 [21:14:24] (03PS1) 10Jdlrobson: Hygiene: Move watchstar styles to appropriate location [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171040 [21:14:26] (03PS1) 10Jdlrobson: Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 [21:14:28] (03PS1) 10Jdlrobson: Hygiene: Kill a bunch of unused messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171042 [21:21:13] 3MobileFrontend / 3stable: Errors not styled as errors on login form - 10https://bugzilla.wikimedia.org/72980 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17021 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17021&action=edit error [21:25:40] 3MobileFrontend / 3stable: Errors not styled as errors on login form - 10https://bugzilla.wikimedia.org/72980#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/z5UH8k83 [21:28:05] dbrant: http://developer.android.com/tools/help/emulator.html#KeyMapping [21:30:27] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ziP2marX [21:30:28] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983 (10Ryan Kaldari) 3NEW p:3Unprio s:3major a:3None In Firefox, I periodically get the JS error "Error: module not found: toast" when loading a page. It seems to be a race condition with the... [21:31:04] (03PS1) 10Jdlrobson: Make it possible to visually unwatch an article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 [21:31:11] ^ kaldari|2 [21:31:35] (03PS1) 10Florianschmidtwelzow: Style Login error messages in stable, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171047 [21:32:43] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c2 (10Jon) I'm unable to replicate this locally or on beta labs. Can anyone else? [21:32:52] (03PS2) 10Florianschmidtwelzow: Style Login error messages in stable, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171047 (https://bugzilla.wikimedia.org/72980) [21:32:57] 3MobileFrontend / 3stable: Errors not styled as errors on login form - 10https://bugzilla.wikimedia.org/72980 (10Florian) a:3Florian [21:36:28] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None When I try to click on the watchlist star in Firefox, I get the error: "TypeError: this.bindings[event].slice is not a function" It coming... [21:39:11] (03PS3) 10Robmoen: Validate claims in WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 [21:39:56] (03CR) 10Jdlrobson: [C: 04-2] "As I said on https://trello.com/c/nMVDaKkU/31-beta-move-article-action-icons-to-right-of-title-on-phone I think this is a really bad idea." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 (owner: 10Florianschmidtwelzow) [21:40:26] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/XQv9IUsd [21:43:36] (03CR) 10Jdlrobson: [C: 032] Style Login error messages in stable, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171047 (https://bugzilla.wikimedia.org/72980) (owner: 10Florianschmidtwelzow) [21:43:43] 3MobileFrontend / 3stable: Search within pages message not properly localized - 10https://bugzilla.wikimedia.org/72985 (10Ryan Kaldari) 3NEW p:3Unprio s:3major a:3None On en.wiki, go to https://en.m.wikipedia.org/wiki/Main_Page?uselang=fr. Enter a nonsense search term like "sdghyth". The message "Sea... [21:44:13] (03Merged) 10jenkins-bot: Style Login error messages in stable, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171047 (https://bugzilla.wikimedia.org/72980) (owner: 10Florianschmidtwelzow) [21:45:26] 3MobileFrontend / 3stable: Search within pages message not properly localized - 10https://bugzilla.wikimedia.org/72985#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/lqjSdb8G [21:46:19] (03PS6) 10Jdlrobson: Only left align tag buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [21:48:58] 3MobileFrontend / 3stable: Mobile notifications not properly localized - 10https://bugzilla.wikimedia.org/72986 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None This is due to https://gerrit.wikimedia.org/r/#/c/160798/. We need to add 'uselang=user' to the API call. [21:49:00] (03CR) 10Jdlrobson: Only left align tag buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [21:49:05] (03CR) 10Jdlrobson: [C: 032] Only left align tag buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [21:49:11] 3MobileFrontend / 3stable: Mobile notifications not properly localized - 10https://bugzilla.wikimedia.org/72986 (10Ryan Kaldari) s:5normal>3major [21:49:42] (03Merged) 10jenkins-bot: Only left align tag buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170753 (owner: 10Bmansurov) [21:49:49] (03PS2) 10Jdlrobson: Hygiene: Fix method chaining code style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 (owner: 10Jhernandez) [21:50:25] 3MobileFrontend / 3stable: Mobile notifications not properly localized - 10https://bugzilla.wikimedia.org/72986#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ijKIOazJ [21:50:26] (03CR) 10Jdlrobson: [C: 04-2] "Let's see if we get a majority in the core team in favour of this before merging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 (owner: 10Jhernandez) [21:50:51] (03CR) 10Jdlrobson: "Also if we do this we should update jscs... it will just come back." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 (owner: 10Jhernandez) [21:51:10] 3MobileFrontend / 3stable: Errors not styled as errors on login form - 10https://bugzilla.wikimedia.org/72980 (10Jon) 5PATC>3RESO/FIX [21:52:15] bbiab [21:54:17] 3MobileFrontend / 3stable: References drawer does not disappear upon clicking the page itself - 10https://bugzilla.wikimedia.org/72955#c2 (10Jon) Chris would you mind leaving a note on the browser tests page, I spent some time analysing them and was about to raise the same bug. You could have saved me the ha... [21:54:43] 3Wikipedia App / 3iOS App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - 10https://bugzilla.wikimedia.org/72987 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal... [21:54:57] 3Wikipedia App / 3iOS App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - 10https://bugzilla.wikimedia.org/72987 (10Rummana Yasmeen) a:3Monte Hurd [21:55:41] (03CR) 10Jdlrobson: [C: 032] Log an error when WikiGrok is unable to load labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171021 (owner: 10Bmansurov) [21:56:18] (03Merged) 10jenkins-bot: Log an error when WikiGrok is unable to load labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171021 (owner: 10Bmansurov) [21:57:26] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c3 (10Ryan Kaldari) Seems to be thrown by mobile.watchstar. [21:58:04] (03CR) 10Jdlrobson: [C: 04-1] "It does what it says, but it seems dumb to me and I don't get why we need to do this" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 (owner: 10Robmoen) [21:59:30] (03CR) 10MaxSem: [C: 031] Hygiene: Fix method chaining code style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 (owner: 10Jhernandez) [21:59:41] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c4 (10Ryan Kaldari) I also get the error on Beta Labs. [22:00:34] BRB voting!!!!!!!! [22:05:39] (03PS27) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [22:06:58] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c5 (10Ryan Kaldari) I'm using Firefox 33, logged in, in stable. Can't reproduce on mediawiki.org, so must be a recent change. [22:09:10] (03PS1) 10Ori.livneh: Respect existing X-Analytics header, if set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171055 [22:09:41] (03PS3) 10Bmansurov: Improve reference display for better readability (beta only) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [22:11:51] (03CR) 10jenkins-bot: [V: 04-1] Respect existing X-Analytics header, if set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171055 (owner: 10Ori.livneh) [22:13:23] (03PS2) 10Ori.livneh: Respect existing X-Analytics header, if set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171055 [22:15:13] 3MobileFrontend / 3stable: Firefox: Click on watchstar throws JS Error - 10https://bugzilla.wikimedia.org/72989 (10Florian) 3NEW p:3Unprio s:3major a:3None On beta labs and local master branch i get a JS error (TypeError: this.bindings[event].slice is not a function) when i click on the watchstar on... [22:15:27] 3MobileFrontend / 3stable: Firefox: Click on watchstar throws JS Error - 10https://bugzilla.wikimedia.org/72989#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/kXWWdoLz [22:15:27] 3MobileFrontend / 3stable: Firefox: Click on watchstar throws JS Error - 10https://bugzilla.wikimedia.org/72989 (10Florian) 5NEW>3UNCO [22:15:57] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c6 (10Florian) Hmm, can't reproduce on betalabs, too :( (with FF 32 and 33, logged in and in stable (and alpha)). [22:18:35] bearND: just bash it with a hammer. [22:18:52] bearND: (i can't reproduce any of this stuff on my 2.3 device!) [22:20:40] dbrant: just rotate many times [22:22:51] bearND: i've been trying, and nothing [22:28:59] (03PS4) 10Bmansurov: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [22:29:36] (03CR) 10jenkins-bot: [V: 04-1] Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [22:32:24] (03CR) 10Robmoen: "This was in ready for dev. You are entitled to your opinion, but it's not exactly nice to call something someone did dumb." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 (owner: 10Robmoen) [22:32:40] jdlrobso_: ^ [22:32:42] (03PS2) 10Jdlrobson: Hygiene: Change source to task_type for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170994 (owner: 10Robmoen) [22:32:57] rmoen: i wasn't calling you dumb. [22:33:26] i said the code seemed dumb. And I know it was in ready for dev. I wrote an email to complain about this. [22:34:18] EventLogging server throws validation errors when you give it the wrong data [22:34:46] so it seems overkill to check the parameters here. Hence why my frustration in the email that this was put in ready for dev and is a habit we should get out of [22:36:01] jdlrobso_: ok well i appreciate the email as it will hopefully prevent things being done that you think are dumb. Its just frustrating and somewhat hurtful to read a word "dumb" on something you did. Not proud of commit for any particular reason, it just seems it could have been more tasteful [22:36:38] rmoen: apologies for my use of words. I'm just getting a little frustrated as this is the third time this has happened and i flagged it during last retrospective [22:36:51] (03PS3) 10Ori.livneh: Respect existing X-Analytics header, if set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171055 [22:37:30] and i've moaned numerous times to kaldari. Apologies that I caught you in my frustration that wasn't my intention and is no reflection on you or the work you put in. [22:37:51] jdlrobso_: Apology accepted. My main frustration comes from doing work that isn't helpful [22:38:46] rmoen: it's a shared frustration. historically we've always had a chance to challenge the work we take on during story review, and then the iteration goes nice and smoothly as everyone knows exactly what is going on but recently we've been working in some kind of extreme-agile method which I feel is actually creating more work for us on the long run [22:40:25] rmoen: we will have to make sure this comes up during standup. bmansurov also has been a victim of this this iteration [22:41:10] (03CR) 10MaxSem: [C: 032] Respect existing X-Analytics header, if set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171055 (owner: 10Ori.livneh) [22:41:26] rmoen: on the Wikigrok stuff https://gerrit.wikimedia.org/r/#/c/170992/2/tests/phpunit/api/ApiResponseTest.php does this need to be backwards compatible at all? [22:41:46] Is there any situation where old WikiGrok extension will run with latest MobileFrontend code? [22:41:48] (03Merged) 10jenkins-bot: Respect existing X-Analytics header, if set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171055 (owner: 10Ori.livneh) [22:42:30] (03CR) 10Jdlrobson: [C: 031] "Only not +2ing due to compatibility concerns - do we need to ensure the api is backwards compatible?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170992 (owner: 10Robmoen) [22:42:37] jdlrobso_: i don't think so. As long as both patches are merged and both extensions ride the deployment train at the same time [22:42:42] (03CR) 10Jdlrobson: [C: 031] "Only not +2ing due to compatibility concerns - do we need to ensure the api is backwards compatible?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170994 (owner: 10Robmoen) [22:43:05] ^ maybe OuKB can sanity check me since he wrote it :) [22:43:38] (03CR) 10Jdlrobson: [C: 032] Fix OverlayFooterLink template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170941 (owner: 10Florianschmidtwelzow) [22:43:47] i wrote what? [22:44:02] I thought it was phuedx ;) [22:44:15] (03Merged) 10jenkins-bot: Fix OverlayFooterLink template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170941 (owner: 10Florianschmidtwelzow) [22:45:13] jdlrobso_, rmoen: I think there must have been some confusion here. I asked Sam to add some error checking to the WikiGrok API (meaning the server-side API component), did he create a card for that or something? [22:45:30] (03CR) 10Robmoen: "I'm not sure that we need backwards compatibility. Seems early for anything else besides DialogB to be using the Response API." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170994 (owner: 10Robmoen) [22:46:49] jdlrobso_, rmoen: Ah yeah, I see. Looks like he didn't clarify that this was supposed to be on the server-side. [22:48:04] rmoen: Sorry about the confusion :( [22:48:08] kaldari: yeah that wasn't clear. Also it was labeled as "Additional input validation for the WikiGrokResponseAPI" Which is the exact name of the api module. also it was in ready for dev [22:48:27] kaldari: water under the bridge [22:48:37] rmoen: Yeah, I think Sam got carried away there :) [22:49:44] Its ok. I don't think anyone should take blame. I think Jon's email correctly identifies the issue. [22:51:42] (03CR) 10Jdlrobson: [C: 04-1] Improve reference display for better readability (beta and alpha) (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [22:53:03] (03PS2) 10Jdlrobson: Hygiene: Create array of style modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171038 [22:53:09] (03PS2) 10Jdlrobson: Hygiene: Move tutorial styling into the appropriate module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171039 [22:53:13] (03PS2) 10Jdlrobson: Hygiene: Move watchstar styles to appropriate location [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171040 [22:53:17] (03PS2) 10Jdlrobson: Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 [22:53:20] bearND, I have a feeling I might've asked this before recently, but... [22:53:22] (03PS2) 10Jdlrobson: Hygiene: Kill a bunch of unused messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171042 [22:53:31] material design. is that being worked on? [22:56:24] (03CR) 10Kaldari: "Sorry, this was a bad game of telephone. I asked Sam if he could add some basic error handling to the WikiGrokResponse API (on the server " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 (owner: 10Robmoen) [22:58:55] Krenair: cc dbrant: not actively, and not directly yet. We do have a few cards in the feature backlog for 5.0, e.g. migrating from the action bar to the new toolbar: https://trello.com/c/Sy7emj4K/802-android-5-0-migrate-to-the-new-toolbar. [22:58:57] (03CR) 10Kaldari: [C: 032] hygiene: Change source to task_type for consistency with MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170992 (owner: 10Robmoen) [22:59:03] (03CR) 10Kaldari: [C: 032] Hygiene: Change source to task_type for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170994 (owner: 10Robmoen) [22:59:17] (03Merged) 10jenkins-bot: hygiene: Change source to task_type for consistency with MobileFrontend [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170992 (owner: 10Robmoen) [22:59:34] Krenair: I think that would be a good start, not sure I want to call it material design, though. [22:59:40] (03Merged) 10jenkins-bot: Hygiene: Change source to task_type for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170994 (owner: 10Robmoen) [23:00:02] Krenair: I think that would be a good start, not sure I want to call it material design, though. [23:00:59] dbrant, bearND: I'm going to a conference on material design on Friday. [23:01:18] dbrant, bearND: Hopefully this will enlighten me somewhat! [23:01:52] Deskana: please share your findings. Maybe bring vbamba, too? [23:02:13] bearND: Yeah, I forwarded the invite to her and she said she registered. [23:02:55] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c10 (10Jon) 5NEW>3UNCO MM.. I can't seem to replicate this issue. Can you replicate it on http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings or any other page on that site (it is running th... [23:03:02] Deskana: a shame I can't be there :( [23:03:36] Krenair: dbrant is working on introducing lead images with parallax scrolling, which is super cool. It seems to hint at a another layer in the page, so might be considered somewhat like material design. [23:03:59] Deskana: do they allow remote particpation? [23:05:37] (03CR) 10Dr0ptp4kt: "Updated code coming soon." (034 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt) [23:06:59] bearND: I don't think so. [23:12:55] (03PS3) 10Jdlrobson: Hygiene: Kill a bunch of unused messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171042 [23:13:31] OuKB: https://gerrit.wikimedia.org/r/#/c/154873/ florian needs your help there.. [23:13:51] i know [23:14:01] poked at it, couldn't figure out [23:14:41] (03PS1) 10Deskana: Make "userexists" message in account creation slightly more prominent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) [23:14:42] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c7 (10Ryan Kaldari) Just got all the following errors locally with debug=true (logged in, in stable): Module not found: toast Module not found: modules/watchstar/Watchstar Module not found: modul... [23:15:41] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c8 (10Ryan Kaldari) All came from modules.js in Mantle. [23:17:52] (03CR) 10jenkins-bot: [V: 04-1] Make "userexists" message in account creation slightly more prominent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) (owner: 10Deskana) [23:18:49] (03CR) 10Robmoen: [C: 032] Hygiene: Componentise mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171015 (owner: 10Jdlrobson) [23:19:18] (03PS2) 10Robmoen: Hygiene: Componentise mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171015 (owner: 10Jdlrobson) [23:19:51] (03PS2) 10Robmoen: Hygiene: Move PageList to core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171016 (owner: 10Jdlrobson) [23:22:16] (03PS9) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [23:23:04] (03CR) 10Robmoen: [C: 032] Hygiene: Move PageList to core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171016 (owner: 10Jdlrobson) [23:23:11] (03PS2) 10Robmoen: Hygiene: Rewrite references to use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171017 (owner: 10Jdlrobson) [23:23:41] (03Merged) 10jenkins-bot: Hygiene: Componentise mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171015 (owner: 10Jdlrobson) [23:23:46] (03Merged) 10jenkins-bot: Hygiene: Move PageList to core template mechanism [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171016 (owner: 10Jdlrobson) [23:27:40] (03CR) 10Robmoen: [C: 032] Hygiene: Rewrite references to use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171017 (owner: 10Jdlrobson) [23:27:59] (03PS3) 10Robmoen: Hygiene: Notifications using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171018 (owner: 10Jdlrobson) [23:28:39] (03CR) 10Robmoen: [C: 032] Hygiene: Notifications using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171018 (owner: 10Jdlrobson) [23:28:43] (03Merged) 10jenkins-bot: Hygiene: Rewrite references to use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171017 (owner: 10Jdlrobson) [23:29:14] (03Merged) 10jenkins-bot: Hygiene: Notifications using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171018 (owner: 10Jdlrobson) [23:30:10] (03PS3) 10Robmoen: Hygiene: Editor overlay using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171019 (owner: 10Jdlrobson) [23:30:41] (03CR) 10Robmoen: [C: 032] Hygiene: Editor overlay using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171019 (owner: 10Jdlrobson) [23:30:50] (03PS4) 10Robmoen: Hygiene: ImageOverlay and TalkOverlays should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 (owner: 10Jdlrobson) [23:31:54] (03Merged) 10jenkins-bot: Hygiene: Editor overlay using mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171019 (owner: 10Jdlrobson) [23:32:06] 3Wikipedia App / 3iOS App: Wikipedia App: [iOS] App crashes when closing the "Recent" and "Saved pages" section, while option to delete individual item is visible - 10https://bugzilla.wikimedia.org/72991 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 17023 --> https://bugzi... [23:32:16] 3Wikipedia App / 3iOS App: Wikipedia App: [iOS] App crashes when closing the "Recent" and "Saved pages" section, while option to delete individual item is visible - 10https://bugzilla.wikimedia.org/72991 (10Rummana Yasmeen) a:3Monte Hurd [23:33:33] Maryana: BTW, is the mobile domains for Beta Labs being down a known thing? [23:33:45] i just noticed it [23:33:54] not sure if it's known more broadly than that [23:33:58] Maryana: Hmm. [23:34:49] (03CR) 10Robmoen: [C: 032] Hygiene: ImageOverlay and TalkOverlays should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 (owner: 10Jdlrobson) [23:34:58] (03PS2) 10Robmoen: Hygiene: Wikigrok B should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171026 (owner: 10Jdlrobson) [23:35:26] (03Merged) 10jenkins-bot: Hygiene: ImageOverlay and TalkOverlays should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171020 (owner: 10Jdlrobson) [23:36:10] (03CR) 10Robmoen: [C: 032] Hygiene: Wikigrok B should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171026 (owner: 10Jdlrobson) [23:36:19] (03PS2) 10Robmoen: Hygiene: Checkboxes on Special:MobileOptions (alpha) -> mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171027 (owner: 10Jdlrobson) [23:36:46] (03Merged) 10jenkins-bot: Hygiene: Wikigrok B should use mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171026 (owner: 10Jdlrobson) [23:37:11] (03CR) 10Robmoen: [C: 032] Hygiene: Checkboxes on Special:MobileOptions (alpha) -> mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171027 (owner: 10Jdlrobson) [23:37:22] (03PS2) 10Robmoen: Complete deprecation of mw.mantle.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171028 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [23:37:48] (03Merged) 10jenkins-bot: Hygiene: Checkboxes on Special:MobileOptions (alpha) -> mw.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171027 (owner: 10Jdlrobson) [23:38:00] (03PS10) 10Dr0ptp4kt: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [23:38:18] (03CR) 10Robmoen: [C: 032] Complete deprecation of mw.mantle.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171028 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [23:38:25] (03PS2) 10Robmoen: Hygiene: Fix indent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171029 (owner: 10Jdlrobson) [23:38:41] (03CR) 10Robmoen: [C: 032] Hygiene: Fix indent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171029 (owner: 10Jdlrobson) [23:38:55] (03Merged) 10jenkins-bot: Complete deprecation of mw.mantle.template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171028 (https://bugzilla.wikimedia.org/72839) (owner: 10Jdlrobson) [23:39:00] (03CR) 10Kaldari: [C: 032] Hygiene: Kill a bunch of unused messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171042 (owner: 10Jdlrobson) [23:39:08] (03PS3) 10Robmoen: Hygiene: Create array of style modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171038 (owner: 10Jdlrobson) [23:39:19] (03Merged) 10jenkins-bot: Hygiene: Fix indent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171029 (owner: 10Jdlrobson) [23:39:35] (03Merged) 10jenkins-bot: Hygiene: Kill a bunch of unused messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171042 (owner: 10Jdlrobson) [23:42:42] 3MobileFrontend / 3Hygiene: JS console warnings - 10https://bugzilla.wikimedia.org/72839 (10Jon) 5PATC>3RESO/FIX [23:42:43] (03PS1) 10Deskana: Only log theme change events if the theme was actually changed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171152 [23:43:22] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) (owner: 10Deskana) [23:45:05] (03CR) 10Robmoen: [C: 032] Hygiene: Create array of style modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171038 (owner: 10Jdlrobson) [23:45:21] (03PS3) 10Robmoen: Hygiene: Move tutorial styling into the appropriate module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171039 (owner: 10Jdlrobson) [23:45:44] (03Merged) 10jenkins-bot: Hygiene: Create array of style modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171038 (owner: 10Jdlrobson) [23:47:00] (03CR) 10Robmoen: [C: 032] Hygiene: Move tutorial styling into the appropriate module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171039 (owner: 10Jdlrobson) [23:47:10] (03PS3) 10Robmoen: Hygiene: Move watchstar styles to appropriate location [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171040 (owner: 10Jdlrobson) [23:47:19] (03CR) 10Deskana: [C: 04-1] "Amending this..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) (owner: 10Deskana) [23:47:40] (03Merged) 10jenkins-bot: Hygiene: Move tutorial styling into the appropriate module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171039 (owner: 10Jdlrobson) [23:47:51] (03CR) 10Robmoen: [C: 032] Hygiene: Move watchstar styles to appropriate location [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171040 (owner: 10Jdlrobson) [23:48:05] (03PS3) 10Robmoen: Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 (owner: 10Jdlrobson) [23:48:47] (03PS2) 10Deskana: Make error messages in account creation slightly more prominent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) [23:49:02] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 (owner: 10Jdlrobson) [23:49:06] (03PS2) 10Jdlrobson: Conditionally load mobile.newuser code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) [23:50:08] rmoen: kaldari make sure https://gerrit.wikimedia.org/r/171046 makes the branch cut.. will need a lightning deploy if it gets out! [23:50:55] (03CR) 10Kaldari: [C: 032] Make it possible to visually unwatch an article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 (owner: 10Jdlrobson) [23:51:14] (03PS2) 10Robmoen: Make it possible to visually unwatch an article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 (owner: 10Jdlrobson) [23:51:25] (03CR) 10Robmoen: [C: 032] Make it possible to visually unwatch an article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 (owner: 10Jdlrobson) [23:53:07] (03CR) 10Robmoen: [C: 04-1] Hygiene: Remove mobile.stable.styles (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 (owner: 10Jdlrobson) [23:53:38] (03CR) 10Jdlrobson: Link to Special:Nearby out of the article (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [23:54:08] brb