[00:00:06] (03Merged) 10jenkins-bot: Hygiene: Move watchstar styles to appropriate location [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171040 (owner: 10Jdlrobson) [00:02:35] (03PS3) 10Jdlrobson: Make it possible to visually unwatch an article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 [00:02:39] (03CR) 10Jdlrobson: [C: 032] "3rd time lucky" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 (owner: 10Jdlrobson) [00:03:26] 3Wikipedia App / 3iOS App: Wikipedia App: [iOS] App crashes when closing the "Recent" and "Saved pages" section, while option to delete individual item is visible - 10https://bugzilla.wikimedia.org/72991#c1 (10Brion Vibber) Looks like this bug: http://stackoverflow.com/questions/19230446/tableviewcaneditrowa... [00:03:31] (03CR) 10Jdlrobson: "It would be useful though if you are interested to make this alpha only, we can delay any decisions on removing this on data rather than i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 (owner: 10Florianschmidtwelzow) [00:06:43] (03PS1) 10Brion VIBBER: Fix for crash when closing recent/saved during edit mode [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/171157 (https://bugzilla.wikimedia.org/72991) [00:09:39] kaldari, bmansurov: q about Wikigrok instrumentation: are we logging anywhere the total number of possible values extracted from a WikiGrok-ready article? [00:09:57] (03CR) 10Jdlrobson: [C: 04-1] "Dropping to -1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 (owner: 10Jhernandez) [00:10:21] DarTar: I don't think I am, maybe kaldari is doing it in the back end? [00:10:54] (03PS4) 10Jdlrobson: Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 [00:11:20] we don’t know how many possible statements per article can be generated and if we’re capping them to 5 there’s a very high chance that we’ll throw some literally random stuff to our users [00:12:22] bmansurov, kaldari: I’d be curious to know how magnus dealt with that problem (if at all) [00:13:18] DarTar: no we aren't logging that [00:13:49] kaldari: do you have a sense of scale from your own tests? [00:14:48] as in, do you feel that 99% of the times we’ll be presenting a number of values smaller than those that can be extracted [00:15:04] DarTar: Currently, it's anywhere from 0 to about 10 or so. 1 is most common. [00:15:19] kaldari: got it [00:15:37] it might be interesting to capture this in a future iteration [00:15:41] (03PS1) 10Jdlrobson: Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 [00:16:40] kaldari: imagine if the only true property was displayed 1% of the total impressions of the widget [00:18:07] kaldari: I am adding this to the limitations section of the docs on Meta [00:18:58] DarTar: have you played around with this at all? http://tools.wmflabs.org/autolist/ [00:19:02] i've just been getting into it [00:19:19] Maryana: yes, pretty powerful (although it’s been down for several days) [00:19:27] working now [00:19:50] kaldari, to recap (let me know if I am getting anything wrong): [00:20:51] 1. in version B up to 10 values are displayed, if more values are available a randomly selected sample is displayed [00:21:11] 2. there needs to be at least one value for at least one of the 3 properties for the widget to be loaded [00:21:27] (the 3 properties being: occupation, nationality, alma mater) [00:22:56] 3. in version A, the property displayed to the user is randomly selected out of those 3 properties that have at least one potential value [00:23:15] kaldari, Maryana ^ is this accurate? [00:23:55] in version B, up to 6 values are displayed [00:24:01] and we're probably gonna limit it even further [00:24:06] cos that's a lot of screen space [00:24:10] Maryana, DarTar: actually only 4 now (per Moiz) [00:24:15] right [00:24:17] wow [00:24:44] it would be really helpful to know the distribution of potential values [00:24:55] > imagine if the only true property was displayed 1% of the total impressions of the widget [00:25:04] (03PS1) 10Ori.livneh: Respect existing X-Analytics header, if set [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171159 [00:25:05] I guess we’ll have to live with that for now [00:25:12] (03CR) 10Ori.livneh: [C: 032] Respect existing X-Analytics header, if set [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171159 (owner: 10Ori.livneh) [00:25:16] we might add a null value to v. B [00:25:21] "none of the above" [00:25:26] (03PS1) 10Ori.livneh: Respect existing X-Analytics header, if set [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171160 [00:25:26] Yeah, that needs to be done [00:25:29] I need to mock that [00:25:42] (03CR) 10Ori.livneh: [C: 032] Respect existing X-Analytics header, if set [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171160 (owner: 10Ori.livneh) [00:25:55] coz there are times when Prince Di is not a Cleaner, a Disk Jockey or a Part-time Model [00:26:03] indeed. [00:26:04] yes that sounds reasonable [00:26:23] moizsyed: my point is that this might be true 99% of the times [00:26:36] DarTar: yeah [00:26:54] i'm not sure we can know until we test [00:27:12] but this is def one thing to keep in mind for post-hoc analysis [00:27:12] Maryana: yeah, but we won’t know how aggressively we’re sampling [00:27:22] unless we capture that data (and we’re not now) [00:27:52] so best case scenario we’ll see a lot of “null / no / not sure” values posted [00:28:11] worst case scenario we’ll see actual garbage data [00:28:44] but hey – if many people agree that Prince Di is a Disk Jockey, that’s going be true, it’s wikipedia after all :) [00:28:51] ha [00:29:06] I’m captuting this in the docs [00:29:19] well, right. either scenario is good, because it'll tell us how well/poorly we're serving relevant tags [00:29:20] (I captute all the time) [00:29:26] always be capturin [00:29:31] *photoshoping princess di with big headfones* [00:29:53] this is all under the rubric of "which version of wikigrok works better", imho [00:29:55] oh I thought Prince Di was a famous DJ friend of yours [00:30:25] it might be that we can't actually serve enough relevant tags, in which case version a all the way [00:31:06] so are we settling on 4 for version B? [00:31:07] DarTar: The average number of occupation suggestions per item is 2 (for items that have suggestions). All items that have nationality suggestions have only 1 suggestion. No idea how often those overlap or what the distribution is. [00:31:20] DarTar: for now, yes [00:31:27] kaldari: that’s in wikidata, right? not in WP [00:31:37] ? [00:32:01] Don't understand your question [00:32:08] kaldari: I mean, how did you get that average N [00:32:21] SELECT AVG(LENGTH(occupation)) FROM potential_occupation; on the Tool Labs db [00:32:35] which gave 9.7069 [00:32:37] ah! there’s a potential_occupation table [00:32:43] OMG, I want it [00:32:48] haha [00:32:55] each suggestion is usually about 5 chars in the comma separated list [00:32:59] same labs instance as the one I used to have access to? [00:33:13] (03PS5) 10Bmansurov: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [00:33:24] DarTar: No that's Magnus's instance... [00:33:37] DarTar: but I can dump it and put it some where [00:33:44] jdlrobson: hey, can you help me with https://gerrit.wikimedia.org/r/170873? For some reason I'm not able to load the references js files. [00:33:55] kaldari: can I get access to the project and underlying DB? [00:33:58] (03CR) 10jenkins-bot: [V: 04-1] Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [00:34:09] DarTar: You'll have to ask Magnus [00:34:39] DarTar: but I don't see why not [00:34:56] kaldari: doing it (is that the same data source we’re using for the test?) [00:35:51] DarTar: yes [00:35:55] (03PS6) 10Bmansurov: WIP: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [00:36:05] kaldari: alright [00:36:36] DarTar: I'm dumping it now [00:36:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [00:36:59] kaldari: great, can you create a table on s1.staging ? [00:38:56] DarTar: Hmm, not sure how to move it anywhere though. If I try to move it outside Magnus's dir I get a permission error. [00:39:16] brb [00:41:46] kaldari: can you just dump the results of a SELECT * somewhere? [00:41:55] (03PS7) 10Bmansurov: WIP: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [00:42:24] DarTar: There are several hundred thousand entries [00:42:49] * DarTar shrugs :) [00:42:51] (03Merged) 10jenkins-bot: Make it possible to visually unwatch an article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171046 (owner: 10Jdlrobson) [00:43:03] kaldari: let me ask him if I can get access to the DB then [00:47:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [00:48:05] kaldari: https://meta.wikimedia.org/wiki/Research:Mobile_microcontributions/WikiGrok#Limitations [00:49:04] Maryana: alma mater is not on the list of claim suggestions created by Max [00:49:09] DarTar: Looks good [00:49:11] https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok/Claim_suggestions [00:49:23] DarTar: alma mater is still under development [00:49:48] DarTar: oops, seems to be missing from that page [00:49:50] I'll add it [00:49:52] kaldari: right, but I understand from Maryana it’s going to be included in the test [00:49:58] thx [00:50:09] DarTar: Yes, it probably will be [00:53:28] yeah, it's live onwiki now [00:53:57] you can see it on august wilson's article :) [00:54:05] DarTar: https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok/Claim_suggestions#Alma_mater [00:54:24] i guess we should add that as acceptance criteria for all new claim types [00:54:27] add to docs [00:54:32] yeah [00:55:22] kaldari: excellent (but we are overriding the “no existing alma mater claim” condition for the test) [00:55:25] right? [00:56:38] DarTar: Possibly, do we know how many people already have that claim. I imagine it's pretty low [00:57:11] we should apply the override consistently to all 3 questions [00:57:43] kaldari: i.e. if we override the missing claim check for occupation and nationality we should do so for alma mater too [00:58:06] https://meta.wikimedia.org/wiki/Research:Mobile_microcontributions/WikiGrok#Claim_selection [00:59:17] kaldari: that’s the 2nd acceptance condition at https://trello.com/c/MiEz2Dc0/8-5-wikigrok-a-b-test-logged-in-dry-run-in-beta [00:59:55] (03Merged) 10jenkins-bot: Respect existing X-Analytics header, if set [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171159 (owner: 10Ori.livneh) [00:59:57] (03Merged) 10jenkins-bot: Respect existing X-Analytics header, if set [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171160 (owner: 10Ori.livneh) [01:03:56] DarTar: alma matter isn't on en.wiki yet, but should be soon [01:04:22] (03PS8) 10Bmansurov: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [01:04:30] (03PS3) 10Jdlrobson: Conditionally load mobile.newuser code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) [01:04:32] (03PS2) 10Jdlrobson: Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 [01:04:34] (03PS1) 10Jdlrobson: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 [01:04:36] (03PS1) 10Jdlrobson: Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 [01:04:38] (03PS1) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 [01:04:40] (03PS1) 10Jdlrobson: Hygiene: Add another FIXME for the future. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171172 [01:05:29] (03CR) 10jenkins-bot: [V: 04-1] Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 (owner: 10Jdlrobson) [01:06:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add another FIXME for the future. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171172 (owner: 10Jdlrobson) [01:06:03] (03CR) 10jenkins-bot: [V: 04-1] Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [01:06:34] (03CR) 10Jdlrobson: [C: 04-1] "A few issues we'll need to work out." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [01:06:57] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997#c6 (10Bryan Davis) From /var/log/hhvm on deployment-mediawiki01: Fatal error: Call to undefined method WebResponse::getheader() in /srv/mediawiki/php-master/extensions/MobileFrontend/... [01:07:16] (03PS9) 10Bmansurov: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [01:07:52] (03CR) 10Jdlrobson: [C: 04-1] "See comments in PS8" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [01:07:56] (03CR) 10Bmansurov: Improve reference display for better readability (beta and alpha) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [01:09:11] (03PS10) 10Bmansurov: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [01:09:39] (03PS1) 10Kaldari: Hygiene: Make sure description.descriptions is defined so we don't error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171176 [01:10:17] jdlrobson: Can you merge this for me: https://gerrit.wikimedia.org/r/#/c/171176/ (just 1 line) [01:10:27] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997#c7 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2eZMffqy [01:11:58] (03CR) 10Bmansurov: [C: 032] Hygiene: Add another FIXME for the future. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171172 (owner: 10Jdlrobson) [01:12:10] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make sure description.descriptions is defined so we don't error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171176 (owner: 10Kaldari) [01:13:22] (03PS2) 10Jdlrobson: Hygiene: Add another FIXME for the future. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171172 [01:13:33] (03CR) 10Jdlrobson: [C: 032] Hygiene: Add another FIXME for the future. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171172 (owner: 10Jdlrobson) [01:16:54] (03Merged) 10jenkins-bot: Hygiene: Make sure description.descriptions is defined so we don't error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171176 (owner: 10Kaldari) [01:16:56] (03Merged) 10jenkins-bot: Hygiene: Add another FIXME for the future. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171172 (owner: 10Jdlrobson) [01:30:11] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997#c8 (10Daniel Zahn) this might be the fix on the way: (CR) Ori.livneh: [C: 2 V: 2] Revert "Update MobileFrontend for cherry-picks" [core] (wmf/1.25wmf5) - https://gerrit.wikimedia.org... [01:31:40] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997#c9 (10Daniel Zahn) bd808: < legoktm> ori: https://gerrit.wikimedia.org/r/#/c/171055/ is causing beta to fatal < legoktm> that function is only in FauxResponse [01:32:59] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7932815 [01:33:11] java.lang.OutOfMemoryError: char[] of length -4097 exceeds the VM limit [01:33:11] at org.wikipedia.staticdata.MainPageNameData.setupData(MainPageNameData.java:166) [01:33:16] negative length? interesting [01:42:03] (03PS1) 10Kaldari: Change WikiGrok tags elements to buttons [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171186 [01:42:51] (03CR) 10Kaldari: [C: 032] Change WikiGrok tags elements to buttons [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171186 (owner: 10Kaldari) [01:43:30] (03Merged) 10jenkins-bot: Change WikiGrok tags elements to buttons [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171186 (owner: 10Kaldari) [01:54:20] (03PS1) 10Ori.livneh: Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171188 [01:54:27] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/171188 (owner: 10Ori.livneh) [01:54:31] (03PS1) 10Ori.livneh: Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171189 [01:54:37] (03PS2) 10Ori.livneh: Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171189 [01:54:43] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/171189 (owner: 10Ori.livneh) [01:56:11] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c2 (10Jon) I suspect there is an event called watch somewhere which also happens to be property on objects in Firefox Cannot reproduce though :( [01:58:12] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c3 (10Jon) *** Bug 72989 has been marked as a duplicate of this bug. *** [01:58:12] 3MobileFrontend / 3stable: Firefox: Click on watchstar throws JS Error - 10https://bugzilla.wikimedia.org/72989#c2 (10Jon) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 72984 *** [02:00:17] (03PS1) 10Ori.livneh: Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171190 [02:00:29] (03CR) 10Ori.livneh: [C: 032] Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171190 (owner: 10Ori.livneh) [02:01:05] (03Merged) 10jenkins-bot: Revert "Respect existing X-Analytics header, if set" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171190 (owner: 10Ori.livneh) [02:03:25] 3MobileFrontend / 3General/Unknown: Purge is required to edit some page as unregistered user - 10https://bugzilla.wikimedia.org/72855#c4 (10Jon) I'm confused what is the bug here? Isn't this the correct behaviour or are you saying the purge action wasn't doing that? Anonymous editing changes the HTML markup... [02:12:43] (03Abandoned) 10Robmoen: Validate claims in WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171023 (owner: 10Robmoen) [05:35:52] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 (owner: 10Jdlrobson) [05:39:27] (03CR) 10Florianschmidtwelzow: [C: 031] "Yay!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 (owner: 10Jdlrobson) [06:34:12] 3MobileFrontend / 3General/Unknown: Purge is required to edit some page as unregistered user - 10https://bugzilla.wikimedia.org/72855#c5 (10Nemo) (In reply to Jon from comment #4) > Anonymous editing changes the > HTML markup So that's the bug (from my point of view). [08:07:58] 3MobileFrontend / 3General/Unknown: cannot uncollapse on opera mobile 12 - 10https://bugzilla.wikimedia.org/72883#c11 (10Matus UHLAR - fantomas) (In reply to Jon from comment #10) > MM.. I can't seem to replicate this issue. Can you replicate it on > http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings wor... [08:08:00] 3MobileFrontend / 3alpha: Improve display of catgories - 10https://bugzilla.wikimedia.org/73008 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None Actual, the categories are simply a collapsible content/header construct, which isn't (maybe) the best design for it. Jon suggested (in this bug: https://gerri... [08:09:15] (03CR) 10Florianschmidtwelzow: [C: 04-1] Link to Special:Nearby out of the article (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [08:10:25] 3MobileFrontend / 3alpha: Improve display of catgories - 10https://bugzilla.wikimedia.org/73008#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/1XrZNgAl [08:49:57] (03PS4) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) [09:04:32] good mornint [09:04:38] *morning [10:34:53] morning joakino [10:35:02] * phuedx didn't set himself as back again [10:41:28] phuedx: morning! [10:50:48] (03CR) 10Jhernandez: [C: 032] Conditionally load mobile.newuser code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) (owner: 10Jdlrobson) [10:51:30] (03Merged) 10jenkins-bot: Conditionally load mobile.newuser code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) (owner: 10Jdlrobson) [10:52:19] (03CR) 10Phuedx: Conditionally load mobile.newuser code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170878 (https://bugzilla.wikimedia.org/72799) (owner: 10Jdlrobson) [10:57:54] (03CR) 10Jhernandez: "What do you mean with jsbeautify? What do you want to do?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170960 (owner: 10Jhernandez) [10:58:55] 3MobileFrontend / 3alpha: Improve display of categories - 10https://bugzilla.wikimedia.org/73008 (10Andre Klapper) [11:00:00] phuedx: how would you compare two patch sets from the same commit? [11:00:54] joakino: view the diff, select a different patchset as the base [11:01:02] so, if you're viewing in side-by-side mode [11:01:11] then the base is above the file on the left [11:01:19] it says "Base 1 2 ..." [11:01:33] where 1, 2, ..., n are the patchset numbers [11:02:11] phuedx: oh yeah, that submenu [11:02:15] i forgot about that [11:02:23] awesome thx [11:02:40] joakino: be aware if ps2 (for example) was a rebase [11:02:59] then the diff between ps1 and ps3 will include code that was brought in by the rebase [11:03:04] which always throws me off [11:04:24] phuedx: and also the between ps2 and ps3 it shows all the files from ps1 to ps3 but empty... [11:04:30] yes [11:04:43] hmph so annoying [11:04:45] it ain't great, but it's actually useful if you think about it [11:05:00] why? [11:05:02] file is modified by the patch but is unchanged [11:05:18] by the base patch [11:05:25] i'd rather know than not know ;) [11:08:39] oh I see, it is useful in the main view in the list of files, but i meant when you are reviewing file by file differences, if you change the base patch then you cycle through empty files [11:09:02] wellp [11:09:06] gerrit is open source [11:09:09] get on it ;) [11:18:44] argh internet hiccups [11:30:26] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c21 (10Sam Smith) (In reply to Derk-Jan Hartman from comment #17) > also, when on https, the stopMobileRedirect cookie is set with the 'secure' > flag on. That me... [11:30:35] joakino: that's the worst, had it yesterday [11:55:10] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c22 (10Sam Smith) Kelson, This bug has been added to the Mobile Web team's current sprint (see https://trello.com/c/gtF11D1B) and I'm taking a look. I've read t... [11:58:12] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727#c7 (10Prateek Saxena) Created attachment 17033 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17033&action=edit nogap Now there seems to be a negative gap between the checkbox and the label [11:58:17] (03CR) 10Phuedx: Remember user choice (mobile/desktop) (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (https://bugzilla.wikimedia.org/54885) (owner: 10Kelson) [13:04:53] gonna break for lunch [13:23:13] buen provecho [13:53:08] back [14:28:40] i'm out for lunch, so late [15:18:25] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c23 (10Sam Smith) Sorry, wgMFStopRedirectCookieHost. [15:28:31] (03PS28) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [15:39:21] (03PS29) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [15:49:31] (03CR) 10Dbrant: "After some research, here's what the culprit seems to be:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [15:54:11] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c9 (10Sam Smith) I get mobile.watchstar and mobile.editor throwing this about 50% of the time locally. [16:02:16] i'm back [16:05:57] hey joakino [16:06:02] hi! [16:06:07] i have been trying to track a bug down to a commit [16:06:10] and the bug has disappeared [16:06:18] i love software! [16:06:25] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c10 (10Jon) The dependencies are likely to be out of whack. Check all those modules and that they are dependent on the appropriate things. Likely to be my fault hygiening up our messy Resources.p... [16:07:12] hahah [16:07:39] phuedx: same thing happened to me with an ios bug, 2 days fighting, jon rebased a different fix from another place, and the bug was gone [16:08:26] i hate those things [16:13:15] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c11 (10Sam Smith) (In reply to Jon from comment #10) > The dependencies are likely to be out of whack. Check all those modules and > that they are dependent on the appropriate things. Likely to b... [16:25:16] hey kristenlans [16:36:32] MorningEvening, phuedx [16:37:19] hi kristenlans [16:37:37] Hey Joakino! How’s life back in Spain? :-) [16:37:47] kristenlans: do you know if tomorrow's meeting hangout will be recorded? [16:38:16] good, a bit colder than I remembered :D [16:38:47] joakino: I am going to ask Greg G about it today. I think all we woudl have to do is make it a “hangout on air” vs a regular hangout. [16:40:14] kristenlans: it would be cool to watch it next day to get the hang of phabricator [16:42:19] joakino: Totally. If for some reason we can’t get it recorded, I can make some time to give you the rundown. [16:43:24] kristenlans: ok thanks, I'll try to find some time to play with it [16:50:23] (03CR) 10BearND: [C: 04-1] "Let's make it 30 PS. ;)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [16:54:55] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c12 (10Sam Smith) ... and now I can't reproduce the error at HEAD. [17:02:45] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c13 (10Jon) Could be caching related. ./dev-scripts/cachedpage.sh 8327a9ceac372766955ac42042e89ba5bd8e3943 Headings If you can run the output on a localhost it should be possible to see if it's... [17:04:11] 3MobileFrontend / 3stable: References drawer does not disappear upon clicking the page itself - 10https://bugzilla.wikimedia.org/72955 (10Sam Smith) a:3Sam Smith [17:04:19] (03PS1) 10Phuedx: Fix all drawers not hiding after clicking the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171284 (https://bugzilla.wikimedia.org/72955) [17:20:29] (03PS30) 10Dbrant: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [17:20:44] (03CR) 10Jdlrobson: [C: 032] "whoops." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171284 (https://bugzilla.wikimedia.org/72955) (owner: 10Phuedx) [17:21:20] (03Merged) 10jenkins-bot: Fix all drawers not hiding after clicking the page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171284 (https://bugzilla.wikimedia.org/72955) (owner: 10Phuedx) [17:24:26] (03CR) 10Kaldari: [C: 04-1] "The magic registration seems like a bad idea for many reasons. In addition to the points I raised earlier, this would also make setting up" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson) [17:25:47] gah, i forgot that patch ^ [17:34:45] // If you're wondering where the DOM insertion happens, look in wikigrokeval.js. [17:34:52] And the file does not exist xD [17:35:10] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c4 (10Sam Smith) See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/watch [17:35:30] bearND: think we can get it merged before standup? [17:36:03] dbrant: hopefully, i'm going to check it soon [17:40:18] phuedx: it looks like the server-side schema still isn't collecting any data, so the A/B test card is still blocked :-/ but IIRC kaldari mentioned we might need to swat some things today to get it working, so *hopefully* will be unblocked today [17:40:45] ok -- my fault or someone else's fault? [17:40:55] nobody's fault :) [17:40:55] if so i think i'm gonna go find a sword to fall on [17:41:15] 3MobileFrontend / 3stable: References drawer does not disappear upon clicking the page itself - 10https://bugzilla.wikimedia.org/72955 (10Jon) 5PATC>3RESO/FIX [17:41:43] phuedx: no. no violence on my watch. [17:48:15] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c5 (10Jon) I also raised an issue against OOJS (bug 73034) [17:52:10] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c14 (10Ryan Kaldari) Before Beta Labs stopped working, I was able to reproduce this there even on hard refreshes. I'm very worried about this getting to production as it causes random JS failure.... [17:53:10] dbrant: drum roll, please [17:53:17] (03CR) 10BearND: [C: 032] "Excellent! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [17:53:27] sweet baby jesus [17:53:37] (03Merged) 10jenkins-bot: Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [17:53:48] bearND: many thanks [17:55:13] dbrant: any of the other patches you want merged? [17:55:55] bearND: oh, nothing pressing, i think! [17:55:58] dbrant: i think the other two big ones that depend on lead images need manual rebases [17:56:43] bearND: yep, they do [17:57:37] kristenlans: internet just d/c [17:57:50] which happened twice yesterday [17:58:00] if i don't show at standup, blame bt [17:58:17] phuedx: I will sned them a bill for 1 USD [17:59:18] european internet sucks [18:01:06] rmoen joakino you joinin [18:01:20] kristenlans: yeah i was locked out of my gmail account ;/ [18:01:24] sorry [18:02:03] rmoen no worries :-) [18:12:49] phuedx: I'm not refactoring, just testing :), i created a card for refactoring them, in the future [18:12:58] splitting them and such [18:13:06] cool [18:13:27] sorry, i heard "refactoring" and got a little scared :) [18:20:44] hey rmoen, kaldari|2: my pull request to WikiGrokAPI has been awaiting review [18:21:01] i guess it'll have to be rebased since rmoen brought in a few of my changes [18:22:48] phuedx: yeah sorry, I split some stuff out. I would have just changed it up if it were in the repo. Are you a maintainer? If so you can just push it directly into master. [18:23:02] i'm not a maintainer [18:32:44] bmansurov: so what happened to your vagrant? [18:33:02] jdlrobson: it's all good now [18:33:08] you can also send a mail to mobile-tech / raise bugs when you have these issues. It helps get them fixed (I'm scared to update now :-)) [18:33:29] jdlrobson: will do so next time it breaks, which will be pretty soon [18:35:49] (03PS2) 10Dbrant: Change location of apk to releases dir [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170786 (owner: 10BearND) [18:38:12] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c6 (10Bartosz Dziewoński) *** Bug 72989 has been marked as a duplicate of this bug. *** [18:38:12] 3MobileFrontend / 3stable: Firefox: Click on watchstar throws JS Error - 10https://bugzilla.wikimedia.org/72989#c5 (10Bartosz Dziewoński) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 72984 *** [18:39:09] (03CR) 10Dbrant: [C: 032] Change location of apk to releases dir [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/170786 (owner: 10BearND) [18:39:40] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984 (10Bartosz Dziewoński) [18:39:52] (03CR) 10Florianschmidtwelzow: [C: 04-1] Link to Special:Nearby out of the article (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [18:40:06] (03PS2) 10Dbrant: Only log theme change events if the theme was actually changed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171152 (owner: 10Deskana) [18:40:33] (03PS11) 10Bmansurov: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 [18:43:50] kaldari: "Mobile notifications not properly localized" is this in NotificationOverlay? How do I replicate bug for testing? [18:44:18] (03CR) 10Dbrant: [C: 032] Only log theme change events if the theme was actually changed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171152 (owner: 10Deskana) [18:45:50] (03PS3) 10Dbrant: Make error messages in account creation slightly more prominent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) (owner: 10Deskana) [18:46:49] (03PS5) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) [18:46:51] (03PS1) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [18:47:10] kaldari: oh i see, i need to provision echo [18:48:02] phuedx: sounds like you may not need to do anything [18:48:06] (03PS6) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) [18:48:08] \o/ [18:48:17] (03PS2) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [18:48:55] phuedx: it may be useful to rename the event to something other than watch though [18:49:06] jdlrobson: maybe [18:49:26] i think it's appropriate given the context [18:49:26] phuedx: i'm not sure when oojs will get updated on beta labs [18:49:43] an "it's a generic name" wasn't the best first response to a bug report ;) [18:49:47] from now on [18:49:54] i'm going to name all events "hasOwnProperty" [18:50:01] :P [18:50:35] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add CategoryOverlay to show categories of a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [18:51:02] (03CR) 10Dbrant: [C: 032] Make error messages in account creation slightly more prominent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171149 (https://bugzilla.wikimedia.org/72923) (owner: 10Deskana) [18:52:13] (03PS3) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [18:52:15] (03PS7) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) [18:52:51] jdlrobson: one failure https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/311/testReport/ and it's a bug with VE https://bugzilla.wikimedia.org/show_bug.cgi?id=73039 [18:53:31] chrismcmahon: peace is restored to mobile land! :) (sort of) :) [18:53:55] (03PS6) 10Dbrant: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [18:54:00] chrismcmahon: i've updated the description [18:55:06] woo! [18:58:04] hey kaldari, do you have the url of the page in https://bugzilla.wikimedia.org/show_bug.cgi?id=72977 ? [18:58:11] (03PS1) 10Robmoen: Set user language in api request so notifications are localized [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171303 (https://bugzilla.wikimedia.org/72986) [18:59:47] Maryana: I'm trying to join the mobile web story review hangout but it says I'm not allowed [19:00:05] Maryana: is there any chance I could get added back to the calendar invite? I think somehow I got removed [19:00:45] (03CR) 10Florianschmidtwelzow: [C: 031] Set user language in api request so notifications are localized [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171303 (https://bugzilla.wikimedia.org/72986) (owner: 10Robmoen) [19:01:06] pinging rmoen too in case Maryana does not have IRC readily available [19:01:09] MaxSem: can you make sure this card makes sense: https://trello.com/c/tJoUTzJC/122-create-a-way-to-test-wikigrok-campaigns-from-wikigrok-extension [19:01:24] looking [19:01:31] jhobs: one sec - we're adding you [19:01:38] thanks :) [19:01:46] bmansurov: I was seeing that on the Main Page locally I believe. [19:01:47] jhobs: shodl be good to go [19:02:07] kaldari: do you see it now too? I'm not able to reproduce it [19:03:42] joakino: story review! :) [19:03:52] jdlrobson: wat? [19:03:59] meeting :) [19:04:21] jdlrobson: oh i'm not invited [19:04:30] joakino: i'm poking kristenlans now :) [19:05:00] joakino done [19:06:10] @moizsyed, cracking me up with the street fighter comment [19:06:40] rmoen: :) [19:09:11] 3MobileFrontend / 3alpha: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c2 (10Bahodir Mansurov) Ryan, do you have the url of the page in screenshot? [19:09:40] 3MobileFrontend / 3General/Unknown: Calling VisualEditor from MF spins forever - 10https://bugzilla.wikimedia.org/73039 (10Chris McMahon) s:5normal>3major [19:10:27] 3MobileFrontend / 3General/Unknown: Calling VisualEditor from MF spins forever - 10https://bugzilla.wikimedia.org/73039 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None As a logged in user with VE available, edit any page in beta labs e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/Cyrion_and_Cand... [19:10:40] 3MobileFrontend / 3alpha: Improve display of categories - 10https://bugzilla.wikimedia.org/73008#c3 (10Florian) Created attachment 17042 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17042&action=edit possible result (of gerrit change 171301) Just the firt thought :) [19:12:02] kaldari: do we have a job queue? [19:12:11] don't want to interrupt story chats [19:14:59] http://hatjitsu.wmflabs.org/82279 [19:15:45] 3Wikipedia App / 3Android App: "User exists" not messaged in account creation - 10https://bugzilla.wikimedia.org/72923#c5 (10Alex Monk) 5PATC>3RESO/FIX Sounds fixed [19:27:11] kristenlans: my connection is really shaky [19:30:27] http://hatjitsu.wmflabs.org/82279 [19:30:48] phuedx we’re estimating! [19:31:05] kristenlans: i've been d/c for the past 5 minutes [19:31:21] i've just quit hatjitsu [19:31:26] if that's what you meant ;) [19:40:36] hi kaldari. I hear you and I should chat about more items on the missing claims. Ping me whenever you want to chat. [20:03:14] ok i'm leaving [20:04:11] 3MobileFrontend / 3alpha: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c3 (10Jon) http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=alpha in Firefox. [20:04:12] kristenlans: could you make sure I'm invited in the meetings at the new times, please? [20:04:29] 3MobileFrontend / 3alpha: Firefox: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977 (10Jon) [20:04:29] 3MobileFrontend / 3alpha: Firefox: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c4 (10Jon) Doesn't effect Chrome. [20:05:41] i am also off for the night [20:06:09] to write a letter of complaint to the mayor of london, bt, and ofcom about the state of broadband in my area [20:06:19] anyone got £10m on 'em? [20:06:27] g'night folks [20:06:32] sorry i couldn't take part :( [20:06:44] bb [20:08:36] (03PS6) 10Jdlrobson: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) [20:10:03] joakino: sure, not sure why your invote didn’t move along with the meeting :P [20:32:29] (03PS1) 10Dbrant: Fix tests related to PageProperties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171330 [20:32:54] phuedx: I'm moving to somewhere that's 8km from the exchange [20:33:38] I expected the state of the internet to be worse here in SF than in Manchester, but actually it was the other way around. [20:34:09] Then again, it is SF... [20:34:33] (03CR) 10jenkins-bot: [V: 04-1] Fix tests related to PageProperties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171330 (owner: 10Dbrant) [20:36:48] (03PS2) 10Dbrant: Fix tests related to PageProperties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171330 [20:40:24] (03CR) 10BearND: [C: 032] Fix tests related to PageProperties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171330 (owner: 10Dbrant) [20:40:41] (03Merged) 10jenkins-bot: Fix tests related to PageProperties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171330 (owner: 10Dbrant) [20:53:01] (03PS1) 10Bmansurov: Fix notification icon size and count in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171433 (https://bugzilla.wikimedia.org/72979) [21:17:08] (03CR) 10Jdlrobson: [C: 04-1] Fix notification icon size and count in alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171433 (https://bugzilla.wikimedia.org/72979) (owner: 10Bmansurov) [21:17:30] kaldari: you know Echo - https://gerrit.wikimedia.org/r/#/c/171303/1/javascripts/modules/notifications/NotificationsOverlay.js [21:17:38] lazyweb is uselang: 'user' a parameter? [21:18:22] kirstenlans: this seems to need some wiki-design love :) https://www.mediawiki.org/wiki/Mobile_web/Team/Retrospectives/2014-10-27#What.27s_been_working_well.3F (i don't know, if it's ok, if i interrupt you're work there :P) [21:18:39] uselang user is allowed for api usage jdlrobson :) [21:18:45] *for -> in [21:19:20] dbrant, have you dealt with the NearbyFragment.setRefreshingState NPE crash? [21:19:25] I thought I'd seen this one before... [21:19:38] FlorianSW: :) chekcing [21:19:49] Krenair: i believe so... is there a new report? [21:19:59] 3 new [21:20:18] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7933872 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7933754 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7933731 [21:20:25] i had to check it too :P Comes with the api i18n, content and user will be converted to user language (for user) or to content language (content) [21:22:00] Krenair: yep, fixed by https://gerrit.wikimedia.org/r/170321 [21:22:19] jdlrobson: https://github.com/wikimedia/mediawiki/blob/d0cb475f1eed27631a7e9049fd20531ef9208dd5/includes/api/ApiMain.php#L190 (but i think you already found it :P) [21:22:41] 3MobileFrontend / 3beta: In edit I can't scroll to the top to access the toolbar in beta + alpha - 10https://bugzilla.wikimedia.org/72707#c4 (10Jon) 5NEW>3RESO/WOR I can't duplicate this now. Maryana said there was an another issue with the editor. Could a bug for that be filed? [21:25:09] (03CR) 10Jdlrobson: [C: 04-1] "much better :) A few minor issues. I will checkout the code and test shortly." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [21:27:28] dbrant, closed them [21:27:34] dbrant, have you seen https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7934211 ? [21:27:57] menu text strings made completely unreadable, showing as almost complete nonsense [21:28:11] Krenair: i have indeed. and i'm as baffled as anyone [21:30:48] dbrant, I've also seen a few reports of users complaining they can't create accounts but don't know why [21:31:00] (03CR) 10Jdlrobson: [C: 032] "Can't override with uselang but as I understand user language is a preference and the bug doesn't say anything about how it should work wi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171303 (https://bugzilla.wikimedia.org/72986) (owner: 10Robmoen) [21:31:39] (03Merged) 10jenkins-bot: Set user language in api request so notifications are localized [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171303 (https://bugzilla.wikimedia.org/72986) (owner: 10Robmoen) [21:31:59] Krenair: most likely because of the AntiSpoof extension. The app doesn't show a specific-enough error for it. (we have a bug out for that) [21:33:11] (03PS1) 10BearND: WIP: Disambiguation and page issues more like search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171442 [21:33:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: Disambiguation and page issues more like search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171442 (owner: 10BearND) [21:35:14] 3MobileFrontend / 3stable: Beta labs: swiping in the edit screen blanks the screen - 10https://bugzilla.wikimedia.org/73046 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Steps to repro: 1) Using iPhone 5/iOS8: On beta labs in stable, log in and tap on an edit pencil in an article 2) Tap into... [21:35:27] 3MobileFrontend / 3stable: Beta labs: swiping in the edit screen blanks the screen - 10https://bugzilla.wikimedia.org/73046#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4M7reUgC [21:35:57] 3MobileFrontend / 3beta: In edit I can't scroll to the top to access the toolbar in beta + alpha - 10https://bugzilla.wikimedia.org/72707#c5 (10Maryana Pinchuk) https://bugzilla.wikimedia.org/show_bug.cgi?id=73046 [21:36:40] (03CR) 10Jdlrobson: [C: 04-1] Link to Special:Nearby out of the article (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [21:37:11] 3MobileFrontend / 3stable: Mobile notifications not properly localized - 10https://bugzilla.wikimedia.org/72986 (10Jon) 5PATC>3RESO/FIX [21:39:29] (03PS2) 10BearND: WIP: Disambiguation and page issues more like search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171442 [21:39:41] 3MobileFrontend / 3stable: Swiping in the edit screen blanks the screen - 10https://bugzilla.wikimedia.org/73046#c2 (10Maryana Pinchuk) Replicated in production/stable :-/ [21:39:54] dbrant: can you take a look at ^ and tell me why it doesn't show the links. I'm about to give up on native disambig/issues links for this patch [21:39:54] (03CR) 10jenkins-bot: [V: 04-1] WIP: Disambiguation and page issues more like search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171442 (owner: 10BearND) [21:40:13] (03PS8) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) [21:40:31] bearND|food: sure, will look [21:40:51] (03CR) 10jenkins-bot: [V: 04-1] Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [21:41:50] (03PS3) 10BearND: WIP: Disambiguation and page issues more like search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171442 [21:42:35] (03CR) 10Jdlrobson: "Apart from the minor fix this is ready to go." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [21:43:39] (03PS12) 10Jdlrobson: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [21:44:06] (03PS13) 10Jdlrobson: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [21:45:45] dbrant, oh it's createaccount-hook-aborted, sigh [21:45:55] yep [21:46:00] (reading the bug) [21:46:05] dbrant, looking at anomie's comment though, sounds like an easy fix [21:47:43] (03PS1) 10Jdlrobson: Hygiene: Extend ReferencesDrawerBeta defaults [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171446 [21:48:41] 3MobileFrontend / 3stable: Opting into beta/alpha causes text to jump - 10https://bugzilla.wikimedia.org/72727#c8 (10Jon) Prateek which browser are you seeing that in? [21:49:38] dbrant: Hey! So I'm looking at onboarding, and it'd be nice if the "Skip" tap area was the same size as the buttons above it. [21:50:48] Deskana: sure, that's a good idea [21:51:05] dbrant: I'll write a card for it. [21:51:16] (03PS9) 10Florianschmidtwelzow: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) [21:52:13] dbrant: https://trello.com/c/Uso8eHrL/50-onboarding-make-skip-tap-area-the-same-size-as-the-buttons-above-it [21:52:28] jdlrobson: I don't understand why I cannot style using a psuedo class. THe icon is implemented in that class. [21:52:50] (03CR) 10Jdlrobson: [C: 032] Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [21:53:09] bmansurov: it is /now/ but it won't be in future [21:53:28] (03Merged) 10jenkins-bot: Improve reference display for better readability (beta and alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170873 (owner: 10Bmansurov) [21:54:22] bmansurov: the Icon abstraction was invented so we don't have to have hacks in other modules. So either there is a bug in the definition of an icon, or something about that element is breaking it [21:59:59] kaldari, are you around? [22:00:32] (03PS2) 10Bmansurov: Fix notification icon size and count in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171433 (https://bugzilla.wikimedia.org/72979) [22:00:42] leila: yes [22:00:58] so, Dario said that you wanted to chat with me about something? [22:01:30] he said I should ping you (something about missing claims or along that line?) [22:01:55] kaldari, ^ [22:03:40] jdlrobson: w00t, MF chrome build went green just now: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/ [22:03:52] \o/ [22:04:39] pretty sure the Flow build is going to go green later today also, I made a last couple of tweaks just now [22:05:24] (03CR) 10Kaldari: [C: 04-1] WIP: DB store (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem) [22:05:26] 3MobileFrontend / 3alpha: Firefox: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c5 (10Bahodir Mansurov) Jon, what version of Firefox? I have Version 33.0.2 and it looks fine. [22:05:43] leila: sure, do you have time right now? [22:06:09] sure. I should have 25 min. [22:06:11] Hangout? [22:07:19] sure lemme snag a room [22:08:06] k, send you an invite [22:10:14] (03PS1) 10MaxSem: Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 [22:10:53] leila: Did you start a hangout? I have a room now [22:11:04] I did, let me re-add? [22:11:57] 3MobileFrontend / 3alpha: Firefox: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c6 (10Jon) 33.0.2 here too.. in alpha. I can only replicate it on beta labs when logged in. Very strange. [22:12:55] 3MobileFrontend / 3alpha: Firefox: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977#c7 (10Jon) Ahaa.. you also need to have notifications. So this is probably related to bug 72979 [22:28:54] leila: Some existing ideas are at https://www.mediawiki.org/wiki/Extension_talk:MobileFrontend/WikiGrok/Claim_suggestions#Cheap_suggestions [22:29:26] thanks, kaldari. [22:29:59] (03CR) 10Jdlrobson: [C: 04-1] "I took a closer look and it seems the main issue here is the SVG file we are using. Fix on way." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171433 (https://bugzilla.wikimedia.org/72979) (owner: 10Bmansurov) [22:30:04] leila: I'm hoping to find at least 1 cheap claim suggestion that would work for more than 50,000 articles. [22:30:18] making a note of it. :-) [22:30:24] working on the card [22:30:31] leila: so far, the winner is "Also an author?" which hits 33,000 pages. [22:36:11] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997 (10Rummana Yasmeen) 5NEW>3RESO/FIX [22:40:57] (03CR) 10Kaldari: [C: 04-1] Debug mode (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 (owner: 10MaxSem) [22:41:06] (03PS2) 10MaxSem: Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 [22:42:44] bearND: You're linked from the GitHub repo now! :-D [22:43:31] Deskana: :) [22:43:37] (03PS3) 10MaxSem: Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 [22:43:49] kaldari, ^^^ [22:46:48] (03PS1) 10Jdlrobson: Fix the notifications icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171463 (https://bugzilla.wikimedia.org/72979) [22:46:55] (03PS4) 10MaxSem: Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 [22:46:59] (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/171463" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171433 (https://bugzilla.wikimedia.org/72979) (owner: 10Bmansurov) [22:47:52] kaldari: https://github.com/phuedx/WikiGrokAPI/commit/bc833556b18851c0331a6c5e4eeeb639aa2ef2cb take a look at this? [22:48:11] MaxSem: https://gerrit.wikimedia.org/r/#/c/169606/ you can take a look at this now :) [22:49:38] jdlrobson: Will do. Also can you comment at https://bugzilla.wikimedia.org/show_bug.cgi?id=72983 ? [22:51:05] @bmansurov https://gerrit.wikimedia.org/r/#/c/171463/ fixes the hamburger too [22:51:20] jdlrobson: so both bugs are fixed? [22:51:29] bmansurov: with that patch yeh [22:51:36] they are both caused by the same thing [22:52:08] (03PS2) 10Jdlrobson: Fix the notifications icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171463 (https://bugzilla.wikimedia.org/72979) [22:52:13] jdlrobson: I could also do my own git bisect on the issue if you like, but it will be tedious since it only happens to me on occassion. [22:52:47] jdlrobson: ok, i'll review your patch and abandon mien [22:54:13] 3MobileFrontend / 3alpha: Watchstar animation slightly off - 10https://bugzilla.wikimedia.org/73050 (10Jon) 3NEW p:3Unprio s:3normal a:3None In alpha click the watch star. The watch seems to move North west by a 1px when it completes. [22:54:43] 3MobileFrontend / 3General/Unknown: Unwatching does not work in Firefox (Chrome is OK) - 10https://bugzilla.wikimedia.org/73051 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None See the failure at https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-li... [22:54:46] (03Abandoned) 10Bmansurov: Fix notification icon size and count in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171433 (https://bugzilla.wikimedia.org/72979) (owner: 10Bmansurov) [22:55:26] 3MobileFrontend / 3alpha: Watchstar animation slightly off - 10https://bugzilla.wikimedia.org/73050#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/QF7QdQBb [22:55:27] 3MobileFrontend / 3General/Unknown: Unwatching does not work in Firefox (Chrome is OK) - 10https://bugzilla.wikimedia.org/73051#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Gsi1oRdm [22:56:13] 3MobileFrontend / 3alpha: Alpha: Close icon in image overlay - 10https://bugzilla.wikimedia.org/73052 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17049 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17049&action=edit Repeating xs Go to a page with images Click the image to op... [22:57:58] 3MobileFrontend / 3alpha: Alpha: Watchstar icons are smaller in alpha than in beta - 10https://bugzilla.wikimedia.org/73053 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17050 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17050&action=edit The icon should be replaced with a lar... [22:58:34] jdlrobson: branch gets cut tomorrow morning, and I want to get the module loading issue resolved before then. [23:00:29] 3MobileFrontend / 3alpha: Alpha:No cursor icon when you hover over a section - 10https://bugzilla.wikimedia.org/73054 (10Jon) 3NEW p:3Unprio s:3normal a:3None When you hover over a section you should see the pointer icon. Instead you see the cursor icon. [23:00:31] Going for late lunch. bbiab [23:00:43] 3MobileFrontend / 3alpha: Alpha: Watchstar icons are smaller in alpha than in beta - 10https://bugzilla.wikimedia.org/73053#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/17ecaSKI [23:00:43] 3MobileFrontend / 3alpha: Alpha: Close icon in image overlay - 10https://bugzilla.wikimedia.org/73052#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/krAIrDmu [23:00:56] 3MobileFrontend / 3alpha: Alpha:No cursor icon when you hover over a section - 10https://bugzilla.wikimedia.org/73054#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nh0FGbkV [23:03:26] (03CR) 10Bmansurov: [C: 032] Fix the notifications icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171463 (https://bugzilla.wikimedia.org/72979) (owner: 10Jdlrobson) [23:03:28] 3MobileFrontend / 3stable: Tablets: Notifications icon no worky 2nd time - 10https://bugzilla.wikimedia.org/73056 (10Jon) 3NEW p:3Unprio s:3normal a:3None Click the notifications icon in tablet mode Click the whitespace to the left of the notifications panel. The notifications panel closes Click the... [23:04:04] (03Merged) 10jenkins-bot: Fix the notifications icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171463 (https://bugzilla.wikimedia.org/72979) (owner: 10Jdlrobson) [23:05:27] 3MobileFrontend / 3stable: Tablets: Notifications icon no worky 2nd time - 10https://bugzilla.wikimedia.org/73056#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xwffalF5 [23:05:29] 3MobileFrontend / 3alpha: Broken switcher icons in alpha for VE - 10https://bugzilla.wikimedia.org/73057 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17051 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17051&action=edit In beta * Should use cog icon for switcher * Icons shoul... [23:05:41] 3MobileFrontend / 3alpha: Broken switcher icons in alpha for VE - 10https://bugzilla.wikimedia.org/73057#c1 (10Jon) Created attachment 17052 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17052&action=edit Damage in alpha [23:06:58] 3MobileFrontend / 3alpha: Alpha: Spinner doesn't hide bell for notifications - 10https://bugzilla.wikimedia.org/73058 (10Jon) 3NEW p:3Unprio s:3normal a:3None Click the bell icon in alpha An ajax loader icon appears in its centered Expected: the bell should disappear whilst the ajax loader icon is p... [23:07:11] 3MobileFrontend / 3alpha: Issues with icons in alpha. Get fixed so we can move it to beta. - 10https://bugzilla.wikimedia.org/72653#c4 (10Jon) 5NEW>3RESO/INV I split this into various bugs to be more actionable [23:08:13] 3MobileFrontend / 3alpha: Alpha: CTA drawer icon not centered - 10https://bugzilla.wikimedia.org/73059 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17053 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17053&action=edit Not centered [23:08:43] 3MobileFrontend / 3alpha: Firefox: hamburger menu is misplaced in alpha - 10https://bugzilla.wikimedia.org/72977 (10Jon) 5PATC>3RESO/FIX [23:08:43] 3MobileFrontend / 3alpha: Notifications icon is too small and badge is unstyled/missing - 10https://bugzilla.wikimedia.org/72979 (10Jon) 5PATC>3RESO/FIX [23:10:27] 3MobileFrontend / 3alpha: Broken switcher icons in alpha for VE - 10https://bugzilla.wikimedia.org/73057#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4BWA4miA [23:10:27] 3MobileFrontend / 3alpha: Alpha: Spinner doesn't hide bell for notifications - 10https://bugzilla.wikimedia.org/73058#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/R8RH6eUz [23:10:40] 3MobileFrontend / 3alpha: Alpha: CTA drawer icon not centered - 10https://bugzilla.wikimedia.org/73059#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9iAocuXD [23:11:04] (03CR) 10Bmansurov: [C: 032] Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 (owner: 10Jdlrobson) [23:11:42] (03Merged) 10jenkins-bot: Hygiene: Remove mobile.stable.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171041 (owner: 10Jdlrobson) [23:13:41] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c15 (10Ryan Kaldari) Completely wiping my browser cache seems to have fixed the problem, or at least I can't reproduce it anymore. [23:16:03] (03CR) 10Bmansurov: Fix the language sorter mess (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 (owner: 10Jdlrobson) [23:17:24] (03CR) 10Bmansurov: [C: 032] Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 (owner: 10Jdlrobson) [23:17:56] 3MobileFrontend / 3General/Unknown: Unwatching does not work in Firefox (Chrome is OK) - 10https://bugzilla.wikimedia.org/73051#c2 (10Chris McMahon) "Please wait, watch action is taking longer than expected" seems to be stuck in a loop, the message overlay appears and disappears over and over [23:20:09] dbrant|bbl, bearND: Was this one fixed? https://bugzilla.wikimedia.org/show_bug.cgi?id=71299 [23:20:13] 3MobileFrontend / 3General/Unknown: No toast message in Firefox upon Watching a page (Chrome is OK) - 10https://bugzilla.wikimedia.org/73060 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None as a logged-in user on any page, click Watch. user should see a toast message but does not this is the cau... [23:20:19] dbrant|bbl, bearND: I remember we did some stuff around that... [23:20:28] 3MobileFrontend / 3General/Unknown: Unwatching does not work in Firefox (Chrome is OK) - 10https://bugzilla.wikimedia.org/73051 (10Chris McMahon) [23:20:28] 3MobileFrontend / 3General/Unknown: No toast message in Firefox upon Watching a page (Chrome is OK) - 10https://bugzilla.wikimedia.org/73060 (10Chris McMahon) [23:20:40] 3MobileFrontend / 3General/Unknown: No toast message in Firefox upon Watching a page (Chrome is OK) - 10https://bugzilla.wikimedia.org/73060#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Y4mLgKjH [23:22:40] 3Wikipedia App / 3Android App: TOC swiping hot zone is too wide now - 10https://bugzilla.wikimedia.org/71672#c1 (10Dan Garry) 5NEW>3RESO/WOR We've never experienced any issues with this, honestly. [23:23:07] Deskana: I don't recall that we did anything about that, but that we got a new OTRS report for this: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7934214 this morning [23:24:35] Deskana: since this morning's report is with the latest release bits it's not fixed yet [23:24:35] (03CR) 10MaxSem: [C: 032] Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:25:13] (03Merged) 10jenkins-bot: Restore the more button to the watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:25:53] (03PS1) 10Yurik: Re-implemented missing Zero Portal Lua function [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171472 [23:26:25] (03CR) 10Bmansurov: "I think there is a bug in there. I can't see one of my watched pages in the list. Steps to reproduce:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169606 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:26:42] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c7 (10Jon) *** Bug 73051 has been marked as a duplicate of this bug. *** [23:26:42] 3MobileFrontend / 3General/Unknown: Unwatching does not work in Firefox (Chrome is OK) - 10https://bugzilla.wikimedia.org/73051#c3 (10Jon) 5NEW>3RESO/DUP Can't replicate this locally. We just fixed a bug with watchstar. I imagine it was same issue. *** This bug has been marked as a duplicate of bug 7298... [23:32:59] bearND: Cool, I'll leave that in the sprint then. [23:38:27] dr0ptp4kt, ^^^^ [23:42:18] yurikR: is that a code review request? [23:47:26] 3MobileFrontend / 3stable: "Error: module not found: toast" on page load - 10https://bugzilla.wikimedia.org/72983#c16 (10Ryan Kaldari) 5NEW>3RESO/WOR Hmm. [23:47:37] (03CR) 10MaxSem: WIP: DB store (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem) [23:48:11] (03PS5) 10MaxSem: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [23:48:45] dr0ptp4kt, yep )) [23:49:06] dr0ptp4kt, also, pls re-test them