[00:01:31] (03CR) 10Jforrester: [C: 032] Add i18n for API module help [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169824 (owner: 10Anomie) [00:01:44] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/169824 (owner: 10Anomie) [00:02:13] 3MobileFrontend / 3stable: Collapsing and expanding sections does not work in Category: namespace - 10https://bugzilla.wikimedia.org/73063 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3None Visit http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Category:People_by_religion&mobileaction=togg... [00:04:55] DarTar: kaldari [00:05:01] where you at? [00:05:27] 3MobileFrontend / 3stable: Collapsing and expanding sections does not work in Category: namespace - 10https://bugzilla.wikimedia.org/73063#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/RWXZPD3I [00:05:51] Maryana: at my desk now [00:06:20] did you want to check in on a/b test dry run blockers? [00:06:39] you accepted my invite :) [00:07:12] Maryana: yeah, sorry, coming now [00:07:22] np – do you see kaldari? [00:08:09] nope [00:08:23] it would be useful to have him [00:12:22] Maryana, DarTar: where'd you guys go? [00:18:21] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Extend ReferencesDrawerBeta defaults (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171446 (owner: 10Jdlrobson) [00:19:56] Maryana: kaldari http://etherpad.wikimedia.org/p/WikiGrokTest1 [00:20:41] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c8 (10Bartosz Dziewoński) Should be fixed too, now that bug 73034 is fixed? [00:33:22] DarTar: https://trello.com/c/MiEz2Dc0/7-5-wikigrok-a-b-test-logged-in-dry-run-in-beta [00:37:56] 3MobileFrontend / 3stable: Swiping in the edit screen blanks the screen - 10https://bugzilla.wikimedia.org/73046 (10Dereckson) p:5Unprio>3Normal [00:41:11] 3MobileFrontend / 3stable: Clicking on watchlist star gives JS error - 10https://bugzilla.wikimedia.org/72984#c9 (10Jon) 5NEW>3RESO/FIX Yup. Thanks! :) [01:02:26] 3MobileFrontend / 3stable: Swiping in the edit screen blanks the screen - 10https://bugzilla.wikimedia.org/73046#c3 (10Jon) Can be replicated in ios simulator when you swipe down. [01:03:53] kaldari: https://trello.com/c/JltOtA2q/46-3-wikigrok-v-b-better-tag-styling [01:03:56] ? [01:04:27] Maryana: https://gerrit.wikimedia.org/r/#/c/169776/ [01:04:34] yeah [01:05:41] kaldari: http://etherpad.wikimedia.org/p/WikiGrokTest1 [01:06:28] (03CR) 10Kaldari: [C: 031] "Looks good need to test." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 (owner: 10MaxSem) [01:09:37] (03CR) 10Jdlrobson: [C: 032] Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [01:10:21] (03Merged) 10jenkins-bot: Link to Special:Nearby out of the article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170431 (https://bugzilla.wikimedia.org/72864) (owner: 10Florianschmidtwelzow) [01:12:51] (03CR) 10Jdlrobson: [C: 04-1] "Very very cool :)" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [01:14:10] 3MobileFrontend / 3alpha: Link to Special:Nearby out of article - 10https://bugzilla.wikimedia.org/72864 (10Jon) 5PATC>3RESO/FIX [01:22:55] (03PS1) 10Jdlrobson: Code wars: the empire strikes tap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171487 (https://bugzilla.wikimedia.org/73056) [01:23:31] beer anyone? it's been one of those days [01:23:33] just one mind you [01:34:35] jdlrobson: I wish I coudl join you for a beer [01:35:26] or five [03:02:09] (03CR) 10MaxSem: [C: 032] Code wars: the empire strikes tap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171487 (https://bugzilla.wikimedia.org/73056) (owner: 10Jdlrobson) [03:02:49] (03Merged) 10jenkins-bot: Code wars: the empire strikes tap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171487 (https://bugzilla.wikimedia.org/73056) (owner: 10Jdlrobson) [03:43:07] (03PS11) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [05:38:20] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Will do today :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [06:26:06] (03PS1) 10Deskana: Change width of tappable area for "Skip" in OnboardingActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171509 [06:57:43] (03PS1) 10BearND: Disambiguation and page issues dialog comes up from bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [08:22:23] hi [09:25:13] (03PS4) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [09:49:10] hey joakino [09:49:23] morning! [10:14:22] (03CR) 10Phuedx: [C: 04-1] "Firstly, this is great. Secondly, I'd like one of the designers to take a look at it – I'll make sure they're added to the card." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [10:39:00] i'm going to be out for a while [11:01:27] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> At a higher level though, I'm concerned about the API call. Wouldn't it be cheaper to embed this data onto the page as it's being render" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [12:41:26] gonna head out for lunch [13:16:32] phuedx: can i pm you/ [13:16:34] ? [13:51:37] joakino: sure? [14:34:24] i'm out for lunch [15:07:38] mobile queue above 600 open tickets [15:32:16] legoktm, around? [15:32:49] The iOS (Wikipedia) subqueue is above 200 tickets, and since only two tickets there have been resolved since the 2nd of August I'm tempted to have an admin close it down. [15:34:41] gonna make a cup of coffee [15:42:26] 3Wikipedia App / 3Android App: Improve language selection - 10https://bugzilla.wikimedia.org/71136 (10Alex Monk) [15:46:47] Krenair: poke Deskana|Away, etc? email maybe? [15:46:49] * YuviPanda feels a bit sad [15:47:14] YuviPanda, and android has largely been left to me and florian. But at least that's someone... [15:48:00] yeah... [15:51:43] 3Wikipedia App / 3Android App: App says I'm logged in, but edits are saved from IP - 10https://bugzilla.wikimedia.org/73086 (10Jon Harald Søby) 3NEW p:3Unprio s:3normal a:3None I have made two edits with the mobile app (the stable one, not the Beta one), and both edits [1][2] were saved from the IP I... [19:32:46] YuviPanda: who should i asked about tool labs? [19:32:46] is it ok? [19:32:46] seeing timeouts while testing something [19:32:47] just found out i can't ssh [19:32:49] Congrats YuviPanda to joining ops :) [19:32:49] phuedx: #wikimedia-labs [19:32:49] phuedx: me, coren, andrewbogott [19:32:49] phuedx: it's already being taken care of as well:) [19:32:50] it better be! [19:32:50] * phuedx shakes his fist [19:32:50] YuviPanda: you're my guy in ops ;) [19:32:50] lab ops too! ;) [19:32:50] phuedx: :D [19:32:50] yeah [19:32:50] you guys are hitting tools from prod aren't you? [19:32:50] * YuviPanda shakes fist a little :_ [19:32:50] :) [19:32:50] alpha [19:32:50] so yes, but infrequently [19:32:50] :) still [19:32:50] labs has gone down before because of a bug in a gadget that hit tools [19:32:51] YuviPanda: yeah "we're not doing the bad thing a whole bunch" isn't the greatest dodge [19:32:51] :D [19:32:55] Krenair: bah. I haven't had anytime for OTRS :( [19:33:05] i have to go [19:33:05] see you tomorrow! [19:33:07] dr0ptp4kt: are you planning on attending the selenium workshop in january? [19:33:07] jhobs: yeah. i changed from 'maybe' to 'yes' at zjelko's email and your irc reminder here :) [19:33:07] dr0ptp4kt: ok, then I won't attend unless they end up having space. I wanted to make sure at least one of us was planning on going [19:33:07] jhobs: if you'd like to go, i'll opt out. [19:33:08] dr0ptp4kt: no, it's fine. I figure there's a decent chance they'll end up having enough space anyways but I want to give it at least a week or so [19:33:08] jhobs: cool [19:33:09] MaxSem: remember when we discussed embedding the wikidata description in the page output (similar to the wikidata ID)? Are you still up for doing that? If so, I'll create a card in Trello. If not, I'll file a bug against Wikidata. [19:33:09] kaldari, can do [19:33:09] cool [19:33:09] Deskana bearnd brion vbamba msyed: what’s the verdict on change the iteration review meting today? Can we reschedule to 3 PM? [19:33:09] kristenlans: 3pm works for me [19:33:09] kristenlans: 3pm works for me as well [19:33:09] bearND that’s 3 PM PT, to clarify :-) [19:33:09] kristenlans: Yeah, that's fine. [19:33:10] So moved. [19:33:10] just one mind you [19:33:10] jhobs: I'm pretty sure we'll have space for the Se workshop [19:33:10] dr0ptp4kt: ^^ the more the better [19:33:11] kristenlans: yes, I know -- right after the phab meeting [19:33:11] bearnd: thumbs up [19:33:11] chrismcmahon: sweet, i'll rsvp then [19:33:11] lots of meetings today [19:33:11] bearnd: tell me about it [19:33:12] bearND: Only three hours? Pretty light day for me. ;-) [19:33:12] jhobs: we're after a critical mass of people who know how to use our browser test framework well, so yeah, everyone is welcome [19:33:12] chrismcmahon: thanks! [19:33:12] Product management: I meet, so you don't have to!™ [19:33:12] chrismcmahon: turns out I already rsvp'd yes to the invitation previously without realizing it anyways :D [19:33:12] :-) [19:33:12] kaldari: do you want to do backlog reviw/groom sometime today? [19:33:13] dr0ptp4kt: how did you envision the logo being positioned on the language selection screen? Right next to the searchbox? Far left of the page? Top left (above/next to title)? [19:33:14] dr0ptp4kt: because since everything is centered and on such a small screen here, I actually think placing it on its own line and centered might not be a bad idea [19:33:14] dr0ptp4kt: either above the searchbox or at the very bottom [19:33:15] dr0ptp4kt: alternatively, being fixed to the bg in the top left corner of the page might not be bad either [19:33:15] dr0ptp4kt: actually, i'll just mockup some screenshots and send them to you [19:33:16] jhobs: lol, yeah, i kept revising my response. a few mockups sounds good. getting a good balance on branding and functionality (search, shortlist of langs) is hard! [19:33:21] yo [19:33:21] yoyo [19:33:21] yoyoyo [19:33:21] we're all @ metrics right now [19:33:21] i case you're wondering why it's so quiet here [19:33:21] oy [19:33:23] * jdlrobson waves at bmansurov [19:33:23] hello [19:33:23] good catch with the categories bug :) [19:33:23] sigh. beta labs down again. [19:33:23] can't test anything :( [19:33:23] It seems Gerrit bot is not with us either [19:33:23] yeh just hit that issue Maryana :( [19:33:23] bugzilla and bugello, too rmoen :) [19:33:23] rmoen: i wrote a jscs patch :) https://github.com/jscs-dev/node-jscs/pull/754 [19:33:23] jdlrobson: nice :) [19:33:58] (03PS5) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [19:34:04] (03CR) 10jenkins-bot: [V: 04-1] Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [19:34:16] (03PS6) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [19:34:18] (03CR) 10jenkins-bot: [V: 04-1] Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [19:34:45] (03PS7) 10Florianschmidtwelzow: Add CategoryOverlay to show categories of a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) [19:35:56] phuedx: labs is back up [19:36:01] <3 [19:37:50] hey jdlrobson, how can I change an .mw-ui-icon icon size without changing the font-size of the text? [19:38:24] bmansurov: if an icon is the wrong size it's probably an indicator that the SVG is the wrong size [19:38:37] bmansurov: TrevorParscal is building an icon library with violetto that should solve this issue [19:38:44] jdlrobson: thanks [19:39:02] but if you can fix the svg and it's easy to do so please do [19:40:30] bmansurov: is the icon too big or too small? [19:40:38] TrevorParscal: too small [19:41:04] is the text larger than the normal screen text? [19:41:30] TrevorParscal: no, the text is smaller (12px), but I want the icon size to be 24x24px [19:42:57] the icons that will be added to core along with the ResourceLaoderImageModule will be 24x24px, and sized for 12px text [19:43:03] but the icon you are using may be different [19:44:06] May is going through the icons now and conforming them to the 24px grid and proportioning them to the display text we are using currently (0.875em) [19:44:34] we have talked about changing Vector to use 1em, not sure where that's at [19:47:08] TrevorParscal: we also have a bunch of icons that are png rather than svg :/ [19:47:44] manybubbles: no pressure :) [19:47:57] kaldari|2: huh? [19:47:58] what? [19:48:14] manybubbles: were you listing to Erik's presentation about Wikidata? [19:48:41] ah - I always forget that meeting [19:48:57] (03PS3) 10Jdlrobson: Only load notifications and user module where necessary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171158 [19:49:24] manybubbles: He said something like "Better search and querying capabilities are really, really, really, really, needed for proper leverage of Wikidata on our projects." [19:49:27] and now I'm logging in [19:49:35] (03PS2) 10Jdlrobson: Fix the language sorter mess [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 [19:50:04] ah well, there are so many facets to that [19:50:15] true [19:50:38] (03CR) 10Jdlrobson: Fix the language sorter mess (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171169 (owner: 10Jdlrobson) [19:50:46] (03PS2) 10Jdlrobson: Hygiene: Kill unnecessary mobile.beta.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171170 [19:53:28] TrevorParscal: thanks for the info [19:58:35] dr0ptp4kt: just sent you an email with some screenshots [19:59:00] dr0ptp4kt: will move forward with whichever one you choose, but my guess is it'll be the 4th one [20:00:40] (03PS2) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 [20:00:48] hey kaity|away what should be the reference line height in https://trello.com/c/ZyfC4MOe/64-5-improve-reference-display-for-better-readability (see maryana's comment) [20:10:19] bmansurov: you and kaity should chat in person (well, via hangout) about it – i think she wanted to eyeball it [20:10:30] YEY deskana and maryana! Go web and app teams! <3 [20:10:50] * kristenlans is watching the metrics meeting [20:10:58] :) [20:11:02] kaity|away: let me know when you can hangout [20:13:55] (03PS1) 10Phuedx: WIP WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 [20:14:08] Maryana: ^ [20:14:23] i think it's there, but since labs was down for a while i haven't poked it /hard/ [20:15:05] Inappropriate. [20:16:16] * YuviPanda phamplets Deskana [20:19:39] YuviPanda: the tool labs outage stopped me from testing my work [20:19:55] i'll write a card to stop this being the case [20:20:04] (03PS1) 10Robmoen: Fix WikiGrokDialogB answer recording [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171633 [20:20:17] phuedx: :) [20:20:25] ^ claims were not being recorded ;/ [20:27:10] rmoen: testing that change now [20:28:42] cool [20:28:43] rmoen: i'm seeing nosource errors from the api :/ [20:28:54] (the source parameter is missing) [20:29:02] but that's not your change [20:29:17] phuedx: i was seeing 'no_claim' errors from the api due to it not finding the tags [20:29:27] 3MobileFrontend / 3alpha: Alpha: Subheading overlaps Close button (TalkOverlay) - 10https://bugzilla.wikimedia.org/73088 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 17061 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17061&action=edit Alpha How to reproduce: 1. Go to a p... [20:29:27] or making the answers rather [20:29:33] i get that [20:29:59] phuedx: i'm not getting the nosource error ;/ [20:31:09] ok [20:31:14] well now that error's gone away [20:32:25] (03CR) 10Phuedx: [C: 032] "LGTM. Tested both scenarios (selected and unselected tags) locally." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171633 (owner: 10Robmoen) [20:32:42] right [20:32:46] it's 8:30 pm [20:32:49] am off for the night [20:33:09] g'night folks [20:33:26] 3Wikipedia App / 3Android App: App says I'm logged in, but edits are saved from IP - 10https://bugzilla.wikimedia.org/73086#c1 (10Bernd Sitzmann) The translations are edited in translatewiki.net (TWN). Here is a link to one language.[1] You can change the language with the link after "Translate to" in the up... [20:34:24] 3Wikipedia App / 3Android App: Improve language selection - 10https://bugzilla.wikimedia.org/71136 (10Alex Monk) [20:36:09] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997#c10 (10Maryana Pinchuk) 5RESO/FIX>3REOP I can't get to en.m.wikipedia.beta.wmflabs.org either on mobile or in a desktop browser. [20:36:26] phuedx: g'night [20:36:37] :) [20:39:10] 3MobileFrontend / 3General/Unknown: http://en.m.wikipedia.beta.wmflabs.org is down - 10https://bugzilla.wikimedia.org/72997#c11 (10Bryan Davis) 5REOP>3RESO/FIX (In reply to Maryana Pinchuk from comment #10) > I can't get to en.m.wikipedia.beta.wmflabs.org either on mobile or in a > desktop browser. All... [20:39:55] 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100 (10Alex Monk) [20:40:11] 3MobileFrontend / 3alpha: Alpha: Subheading overlaps Close button (TalkOverlay) - 10https://bugzilla.wikimedia.org/73088#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/L3ymgcDh [20:42:11] 3MobileFrontend / 3alpha: Alpha: Subheading overlaps Close button (TalkOverlay) - 10https://bugzilla.wikimedia.org/73088#c1 (10Florian) Created attachment 17062 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17062&action=edit Beta [20:44:09] phuedx: awesome sauce! [20:44:10] 3Wikipedia App / 3Android App: Do not display "Read in other languages" when there're no other languages available - 10https://bugzilla.wikimedia.org/66198#c1 (10Alex Monk) Looks like we don't even load language links (and thus know whether there are any or not) until the user actually presses this... [20:44:23] labs /should/ be back up [20:45:09] it seems to be, yes [20:47:13] (03PS2) 10Bmansurov: WIP: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 [20:50:23] * awjr waves - i think the labs outage may have caused some problems for bugello [20:50:33] i got a bunch of cronjob failure notices [20:52:20] but afaict it looks like bugello is back to normal now [20:52:55] Maryana, ping [20:53:11] what's up MaxSem ? [20:53:21] are we deploying? :) [20:54:18] we've already deployed wikipedia to /dev/nyll yesterday, remeber? [20:55:42] o_O [20:56:39] Maryana, so last bit remaining: do we really need to look up random pages by several campaigns? by one campaign is easy, by any campaign is easy, by several campaigns is not [20:58:48] brion: yo [20:59:01] yo [20:59:11] MaxSem: eventually we want to serve several campaigns, yes [20:59:19] just a reminder that you have an iOS task out [20:59:21] but we can start with just one if it's easier and doesn't paint us into a corner [20:59:31] tfinc: gotcha, i’ll pull it down and check i tout [20:59:40] thanks [20:59:59] Maryana, i.e. "get me a page that belongs to either of these 3 campaigns?" [21:00:39] eventually: i tap on the sidebar and can select from a number of campaigns (author/writer, occupation, etc.) [21:01:14] MaxSem: ^ [21:01:22] aha, so you select just one:) [21:01:24] there, finally got greenhouse password to remember in my password manager [21:01:47] MaxSem: right. so you can play the occupation game and then switch to the author game [21:01:49] brion, just login with google? [21:02:07] but we can start with just one game for now [21:02:11] meh that might work too :D [21:02:19] Maryana, got it. so searching in just one campaign is fine [21:02:26] yes [21:03:02] hey bmansurov [21:03:13] i can take a look at the citations [21:03:35] kaity: ok, let me share my screen, 1min [21:05:15] (03PS1) 10Robmoen: Validate claims in ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171717 [21:05:47] kaldari|2: so are we gonna try to push all this stuff out today? http://etherpad.wikimedia.org/p/WikiGrokTest1 [21:09:16] kaldari|2, Maryana just want to make you both aware that claim recording in DialogB is currently broken as I'm not sure what we are deploying. Patch that fixes it https://gerrit.wikimedia.org/r/#/c/171633/ [21:11:34] rmoen: We had to roll-back all of the WikiGrok deployment yesterday anyway due to the cherrypick clusterfuck. (See thread on Ops list) [21:11:45] i see [21:12:55] cherrrypick clusterfuck is the name of my new punk band [21:13:10] 3 r's for extra rrrriot [21:13:29] Maryana: +1 [21:13:56] (03PS3) 10Bmansurov: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 [21:14:13] brb lunch [21:15:32] (03Merged) 10jenkins-bot: Fix WikiGrokDialogB answer recording [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171633 (owner: 10Robmoen) [21:16:05] i just added these to DNS: [21:16:10] https://gerrit.wikimedia.org/r/#/c/171475/5/templates/wikimedia.org [21:16:42] MobileFrontend is enabled per default on all except wikitech and wikidata [21:17:28] manybubbles, MaxSem: When you say that you create extension submodule updates by pointing to a branch tip, what does that mean exactly? I just follow the instructions at https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Case_1b:_extension_changes. Should I be doing something differently? [21:18:18] I mean the next step: core submodule update [21:19:54] kaldari|2: the big thing is to do $(git checkout origin/wmf/1.20wmf1) rather than $(git checkout somehash) [21:19:56] Isn't pointing to the branch tip what is always done? i.e. "git checkout origin/wmf/1.2X"? [21:20:05] should be [21:20:28] grabbing anything but the branch tip is going to be confusing [21:21:10] OK, this wasn't actually a cause of the recent outage, just a suggestion for best practice (that hopefully everyone is already doing). [21:21:18] Right? [21:21:20] yup [21:21:23] cool [21:21:57] mutante: thanks :) any issues happening? [21:22:07] just wanted to make sure I wasn't missing anything :) [21:22:49] jdlrobson: it should resolve https://bugzilla.wikimedia.org/show_bug.cgi?id=38799 where people said they get redirect to non-existing places [21:22:56] ..in 2012 :p [21:23:33] e.g. "When I open http://uk.wikimedia.org on my mobile phone I get redirected to http://uk.m.wikimedia.org " [21:23:48] this should still happen but now actually work [21:26:11] (03PS1) 10Jdlrobson: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 [21:26:13] (03PS1) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 [21:26:40] (03CR) 10Jdlrobson: [C: 04-1] "explosions" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson) [21:34:38] (03PS6) 10MaxSem: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [21:35:04] kaldari|2, if you're satisfied with ^^ in principle, I'm pinging Sean for review [21:36:27] (03PS2) 10BearND: Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [21:36:29] (03PS1) 10BearND: Slide up/down animations for BottomDialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171725 [21:38:06] MaxSem: yes, the general ideas seem sound to me [21:38:11] ok [21:39:07] (03CR) 10MaxSem: "Sean, we need your yea or nay on this schema:)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem) [21:39:27] 3MobileFrontend / 3stable: Unable to unwatch on Special:EditWatchlist - 10https://bugzilla.wikimedia.org/73098 (10Jon) 3NEW p:3Unprio s:3normal a:3None When go to this page I no longer see watch icons on the watchlist [21:40:25] 3MobileFrontend / 3stable: Unable to unwatch on Special:EditWatchlist - 10https://bugzilla.wikimedia.org/73098#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VvOLUJVy [21:43:09] (03PS2) 10Jdlrobson: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 [21:43:11] (03PS2) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 [21:49:03] (03CR) 10Kaldari: [C: 032] Validate claims in ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171717 (owner: 10Robmoen) [21:49:41] (03Merged) 10jenkins-bot: Validate claims in ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171717 (owner: 10Robmoen) [21:51:36] kaldari|2, see anything here --> https://gerrit.wikimedia.org/r/#/c/171717/1/includes/api/ApiResponse.php ? :P [21:53:56] (03CR) 10jenkins-bot: [V: 04-1] Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [22:01:05] (03CR) 10Jdlrobson: [C: 04-1] Update reference drawer styling (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [22:02:42] (03PS1) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 [22:02:44] (03PS1) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 [22:06:30] kaldari|2: jdlrobson come up to 6 [22:06:37] for the phabricator overview [22:06:41] Maryana: roger [22:06:47] ok [22:06:50] we're in the big room [22:10:37] (03CR) 10Jdlrobson: Test WikiGrokResponseApi.js (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:12:15] (03PS2) 10Jdlrobson: Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:12:17] (03PS1) 10Jdlrobson: Tools: Complain about spaces missing inside parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171738 [22:12:30] (03PS1) 10MaxSem: Fix I7c0796219bd8b842e7207f6f8a5dec380f576287 [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171739 [22:12:34] MaxSem: so i think after adding those new DNS entries, you could make a change to redirect more of them? [22:12:41] (03CR) 10Jdlrobson: [C: 032] Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:12:49] (03PS2) 10Jdlrobson: Fix nonexisting methods in WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171550 (owner: 10Jhernandez) [22:13:02] (03PS3) 10Jdlrobson: Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:13:22] mutante, do they have main pages that look sanely on mobile? do they have community interested in addressing issues with mobile? [22:13:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson) [22:13:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 (owner: 10Jdlrobson) [22:15:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson) [22:15:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [22:16:01] MaxSem: i haven't tried them yet. so that sounds like we do have to ask them one by one, just some of them are small private wikis, like "stewards", "checkuser" and so on [22:16:23] i guess best would be one bug per wiki then [22:16:35] also, I'm not sure if anybody tested MF on private wikis:) [22:16:51] (03CR) 10jenkins-bot: [V: 04-1] Tools: Complain about spaces missing inside parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171738 (owner: 10Jdlrobson) [22:17:02] well, at least now they can ask for it if they want to and it's not blocked anymore [22:17:04] (03CR) 10jenkins-bot: [V: 04-1] Fix nonexisting methods in WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171550 (owner: 10Jhernandez) [22:17:17] (03CR) 10jenkins-bot: [V: 04-1] Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:18:14] (03Abandoned) 10Jdlrobson: Hygiene: Extend ReferencesDrawerBeta defaults [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171446 (owner: 10Jdlrobson) [22:26:41] 3MobileFrontend / 3alpha: When $wgMFAnonymousEditing is enabled pencil icon is preloaded locked - 10https://bugzilla.wikimedia.org/72851#c4 (10Jon) 5NEW>3RESO/WOR Seems to be fixed now. Caching related. [22:28:08] 3MobileFrontend / 3General/Unknown: No toast message in Firefox upon Watching a page (Chrome is OK) - 10https://bugzilla.wikimedia.org/73060#c2 (10Jon) 5NEW>3RESO/WOR Latest Firefox build passing so I don't think this is a problem anymore. Can't replicate. [22:28:58] 3MobileFrontend / 3stable: Tablets: Notifications icon no worky 2nd time - 10https://bugzilla.wikimedia.org/73056#c2 (10Jon) 5NEW>3RESO/FIX Fixed by https://gerrit.wikimedia.org/r/171487 [22:31:40] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:31:48] (03CR) 10Jdlrobson: [C: 031] Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [22:33:09] 3MobileFrontend / 3General/Unknown: Purge is required to edit some page as unregistered user - 10https://bugzilla.wikimedia.org/72855#c6 (10Jon) 5NEW>3RESO/INV Nothing actionable here. Sometimes HTML changes are needed. Usually when we make HTML changes we are careful to add JavaScript to get round cachi... [22:40:13] Krinkle: zuul issues again? https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/6812/console [22:46:41] hey mobile-ites: what is "extracts"? http://i.imgur.com/79KUQ7S.png [22:46:47] jdlrobson: do you know ^ ? [22:48:07] huh, where is that graph from? [22:48:45] graphite [22:48:49] https://graphite.wikimedia.org/render/?title=Top%2010%20API%20Methods%20by%20Max%2090%25%20Time%20%28ms%29%20log%282%29%20-8hours&from=-8hours&width=1024&height=500&until=now&areaMode=none&hideLegend=false&logBase=2&lineWidth=1&lineMode=connected&target=cactiStyle%28aliasByNode%28highestMax%28maximumAbove%28MediaWiki.API.*.tp90,1%29,10%29,2%29%29 [22:49:57] ahh. haven't had a chance to play around with graphite yet [22:54:25] greg-g: extracts are used by the Hovercard feature [22:54:32] they provide a short summary of an article [22:54:41] (like one liner/paragraph) MaxSem wrote it [22:55:15] well, it's short it you tell it to be [22:55:20] greg-g: not sure why spiking though [22:55:37] did app start using it dr0ptp4kt ? [22:55:48] Deskana|Away: [22:55:53] (wrong d sorry dr0ptp4kt :)) [22:56:29] ah, hovercard, didn't realize, nothing has changed with hovercard recently though, right? jdlrobson ? [22:56:49] s/realize/remember/ (don't tell anyone I didn't enable that one ;) ) [22:57:18] jdlrobson: it's all good. incidentally, i had suggested to a third party dev to look at the abstracts api. but i think she's going with search api stuff instead, so probably not it. she's just familiarizing herself with the api. [22:57:36] and she'd be sleeping at this point of the day [23:02:44] yurikR and jhobs: you guys hit any problems trying to save Module: pages? i keep getting connection resets on localhost:8080 [23:03:05] dr0ptp4kt, it resently started for me too [23:03:17] yurikR: nooooooooooooooooo [23:03:18] but i'm off to bed atm [23:03:26] dr0ptp4kt: maybe something with the scribunto role? [23:03:38] dr0ptp4kt: I actually haven't done any modules on localhost yet so idk [23:04:05] jhobs: yeah, dunno. may have to set some breakpoints and see if i can get to the bottom of it. i haven't updated the roles since provisioning [23:04:19] yurikR: 'night. [23:05:05] (03PS11) 10Jhobs: WIP: Make mdot show language list quickly [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt) [23:05:09] dr0ptp4kt: ^ [23:05:16] jhobs: thx, will look [23:05:25] sorry it took so long, had an impromptu meeting [23:18:39] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [23:19:18] (03PS4) 10Bmansurov: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 [23:19:55] (03CR) 10jenkins-bot: [V: 04-1] Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [23:20:36] (03CR) 10Bmansurov: "recheck, will you?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [23:27:40] (03PS1) 10Jdlrobson: Hygiene: Enforce requireSpacesInsideParentheses Change-Id: Ibf1b3fcd8890287372def25b518b06036559e05e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171766 [23:27:45] (03PS2) 10Jdlrobson: Tools: Complain about spaces missing inside parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171738 [23:27:50] (03PS3) 10Jdlrobson: Tools: Complain about spaces missing inside parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171738 [23:28:01] (03PS2) 10Jdlrobson: Hygiene: Enforce requireSpacesInsideParentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171766 [23:28:34] (03PS12) 10Dr0ptp4kt: Make mdot landing page faster and have logo [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 [23:29:00] Krinkle: are you around? more zuul pain.. [23:41:25] kaldari|2, where's that descriptions card? [23:43:59] (03PS1) 10MaxSem: WIP: add wikidata descriptions... somewhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 [23:44:47] (03CR) 10Kaldari: [C: 032] Fix I7c0796219bd8b842e7207f6f8a5dec380f576287 [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171739 (owner: 10MaxSem) [23:45:44] (03PS1) 10Bmansurov: Fix broken switcher icons in alpha for VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171768 (https://bugzilla.wikimedia.org/73057) [23:46:39] (03PS5) 10Jdlrobson: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [23:46:43] (03Merged) 10jenkins-bot: Fix I7c0796219bd8b842e7207f6f8a5dec380f576287 [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171739 (owner: 10MaxSem) [23:47:46] (03PS3) 10Jdlrobson: Fix nonexisting methods in WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171550 (owner: 10Jhernandez) [23:47:54] (03CR) 10Jdlrobson: [C: 032] Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [23:48:42] hmm… is stat1001 down? [23:48:48] i can't seem to connect [23:49:02] (03CR) 10Jdlrobson: Add CategoryOverlay to show categories of a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [23:50:25] (03Merged) 10jenkins-bot: Test WikiGrokResponseApi.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171549 (owner: 10Jhernandez) [23:50:40] (03Merged) 10jenkins-bot: Fix nonexisting methods in WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171550 (owner: 10Jhernandez) [23:51:11] MaxSem: https://trello.com/c/nvjt35Q5/130-embed-wikidata-description-in-page-output [23:51:17] feel free to move it [23:51:50] (03PS2) 10Jdlrobson: WikiGrokDialog UI tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171551 (owner: 10Jhernandez) [23:51:55] (03PS2) 10Jdlrobson: Hygiene: Code format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171552 (owner: 10Jhernandez) [23:55:01] jdlrobson: I looked at pushing the current master to en.wiki, but I think there are just too many changes in MF. I think it would be quite risky and would rather wait and see if any bugs crop up from the Group1 deployment. [23:55:23] (03PS1) 10Bmansurov: Put icon and text on the same line in VE switcher dropdown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 [23:56:27] 3MobileFrontend / 3stable: Unable to unwatch on Special:EditWatchlist - 10https://bugzilla.wikimedia.org/73098#c2 (10Jon) This appears to have leaked out to https://m.mediawiki.org/wiki/Special:EditWatchlist [23:58:40] (03CR) 10Jdlrobson: [C: 04-1] Update reference drawer styling (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [23:59:01] (03CR) 10Jdlrobson: Hygiene: Code format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171552 (owner: 10Jhernandez) [23:59:06] (03CR) 10Jdlrobson: [C: 032] Hygiene: Code format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171552 (owner: 10Jhernandez) [23:59:13] (03CR) 10Jdlrobson: [C: 032] WikiGrokDialog UI tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171551 (owner: 10Jhernandez) [23:59:44] (03Merged) 10jenkins-bot: WikiGrokDialog UI tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171551 (owner: 10Jhernandez)