[00:01:39] (03CR) 10Kaldari: "Some problems..." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [00:07:54] (03CR) 10Jdlrobson: Update reference drawer styling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [00:08:01] (03PS8) 10Jdlrobson: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [00:08:22] jdlrobson: How do you run git commit without the jscs checks again? [00:09:34] (03PS1) 10Jdlrobson: Show intermediate loader when loading image overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171986 [00:09:46] (03CR) 10Jdlrobson: [C: 032] Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [00:09:58] kaldari|2: add "exit()" to the top of dev-scripts/pre-commit [00:10:25] 3MobileFrontend / 3stable: Clicking notifications icon takes me to Special:Notifications rather than JavaScript overlay. - 10https://bugzilla.wikimedia.org/73149#c2 (10Jon) Picked up by browser test here - https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wm... [00:10:39] (03Merged) 10jenkins-bot: Update reference drawer styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171612 (owner: 10Bmansurov) [00:10:41] (03PS1) 10MaxSem: [doesn't work] use wikidata.org in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171987 [00:10:43] (03CR) 10jenkins-bot: [V: 04-1] [doesn't work] use wikidata.org in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171987 (owner: 10MaxSem) [00:11:07] (03PS1) 10Kaldari: Adding alma mater to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171988 [00:15:11] (03PS5) 10MaxSem: Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 [00:16:10] jdlrobson: ?wikidataid=Q764812&wikigrokversion=A [00:17:53] bmansurov: got a helpful hint from jdlrobson: You can do 'git commit -n' to skip the checks [00:18:09] kaldari|2: good to know [00:19:21] (03CR) 10Jdlrobson: [C: 032] Adding alma mater to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171988 (owner: 10Kaldari) [00:20:02] (03Merged) 10jenkins-bot: Adding alma mater to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171988 (owner: 10Kaldari) [00:21:46] (03CR) 10Jdlrobson: [C: 04-1] WikiGrok A/B test dry run (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [00:22:57] (03CR) 10Jdlrobson: [C: 031] "It's passing now.. \o/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [00:23:25] (03PS3) 10Jdlrobson: Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) [00:23:30] (03PS2) 10Jdlrobson: Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) [00:24:43] bmansurov: kaldari|2: even better you should stop everything and fix the code when you hit warnings :) [00:25:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) (owner: 10Jdlrobson) [00:25:50] (03CR) 10jenkins-bot: [V: 04-1] Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) (owner: 10Jdlrobson) [00:25:53] DarTar: quick note/sanity check... In the WikiGrok error logging, it looks like we are currently registering the 'no-impression-not-enough-suggestions' error in the event that a user lands on a _biography_ article, but there are no claim suggestions. Does that make sense or should it be changed to any article without a claim suggestion (not just biographies)? [00:26:31] kaldari|2: the latter, good catch [00:27:04] kaldari|2: wait, coming over [00:30:05] DarTar: You'll probably want to add that to the A/B test notes that you wrote up: no-impression-not-enough-suggestions is triggered when a user lands on a page about a human that has no claim suggestions. [00:30:25] kaldari|2: sure [00:30:45] kaldari|2: you mean the docs, right? not the schema desc [00:30:53] correct [00:30:56] kk [00:31:31] DarTar: I actually like that it's limited to humans as that will make us less likely to overwhelm the eventlogging servers :) [00:31:56] we should totally take down EventLogging for this thing to work [00:32:08] DarTar: also that code is shared between the two WikiGrok vesions, so it is well-controlled. [00:32:16] :) [00:32:17] right [00:32:29] is any other log live yet in beta? [00:32:45] * DarTar looks up the log db [00:33:17] DarTar: The response log is now live for test.wiki, but for some reason the error log isn't working. I filed a bug on it. [00:33:38] how about the interaction log [00:34:18] DarTar: The new version of that table is being used by test.wiki now [00:35:01] DarTar: We're planning on pushing the master branch up to en.wiki on Monday or Tuesday as soon as these last few bugs are shaked out. [00:35:14] kaldari|2: great, thanks [00:37:51] kaldari|2: the interaction log on testwiki is complete though, right – the bugs you;re referring to are only for the error log, correct? [00:37:54] (03PS1) 10Robmoen: Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 [00:38:09] (03CR) 10Bmansurov: [C: 04-1] "Go to any article page and you'll see the drawer fade in and out really quickly." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [00:39:12] DarTar: Yes, we took a look at the new interaction log this morning and it seems to be recording everything properly. You may want to double check though. [00:39:33] wow: kaldari|2 we have events with a widgetOffset of 15.7x viewports [00:39:46] DarTar: wow [00:39:53] kaldari|2: yes, checking it now [00:40:05] what article is that? WWII? [00:40:07] kaldari|2: a few things I noticed already [00:40:18] - event_testing is always NULL: intentional? [00:40:59] - event_taskType: I was expecting this to be “a” or “b” not “version a” or “version b” (but it doesn’t really matter) [00:41:31] DarTar: hmm, event_testing is 100% NULL? [00:42:16] kaldari|2: not 100% [00:42:36] (03PS1) 10Jdlrobson: Tools: Run `make jsduck` on git review [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171995 [00:42:38] (03PS1) 10Jdlrobson: Hygiene: Complete JS documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171996 [00:42:44] kaldari|2: 32 events with event_testing NOT NULL out of 1267 [00:43:03] I was expecting all events to be flagged as testing [00:43:38] DarTar: Ah, the new interaction logging must have hit en.wiki already then [00:43:54] DarTar: Are there entries with wiki = enwiki? [00:43:57] oh you’re right [00:44:00] kaldari|2: yes [00:44:18] where do you want me to capture the QA notes? [00:44:23] etherpad? [00:44:54] DarTar: sure [00:45:04] kaldari|2: also, I thought the bucketing was not live yet [00:45:16] but I definitely see events with version A AND version B in beta [00:46:08] kaldari|2: http://etherpad.wikimedia.org/p/WikiGrokTest1DataQA [00:46:16] DarTar: Yeah, that's already live as we were hoping to start the A/B pretty soon [00:46:29] or at least the dry run [00:47:24] hm, I actually asked Maryana/Sam to have a config setting to delay the activation of the test, captured in the AC [00:47:38] (03PS3) 10BearND: Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [00:48:05] DarTar: Yes, that's definitely in the AC for the actual test (with anons). I'm not sure about the dry run... [00:48:33] (03PS2) 10BearND: Left/right animation inside page info dialog [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171875 [00:48:35] (03PS2) 10BearND: Disambig items have thumbnail, title, and Wikidata description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 [00:48:37] (03PS2) 10BearND: Slide up/down animations for BottomDialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171725 [00:48:38] oh, the first A/B test (Test 1) is with logged in users [00:48:39] (03PS4) 10BearND: Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [00:48:59] (03CR) 10Bmansurov: [C: 031] Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 (owner: 10Robmoen) [00:49:21] DarTar: looks like you're right: https://trello.com/c/MiEz2Dc0/8-5-wikigrok-a-b-test-logged-in-dry-run-in-beta [00:49:36] (03CR) 10jenkins-bot: [V: 04-1] Disambig items have thumbnail, title, and Wikidata description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 (owner: 10BearND) [00:49:37] DarTar: guess there was some confusion about that [00:50:16] kaldari|2: definitely, the risk is that we may exhaust the population of users by bucketing them before we’re ready to collect good data [00:51:05] DarTar: how would you suggest avoiding that? [00:51:27] kaldari|2: the original plan I discussed with Maryana was: [00:51:43] - push the complete instrumentation to production, without bucketing users [00:51:55] (03CR) 10Jdlrobson: [C: 032] Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 (owner: 10Robmoen) [00:51:56] - QA the data collected and fix any anomalies [00:52:21] DarTar: lemme come over and discuss.... [00:52:21] (03PS2) 10Jdlrobson: Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 (https://bugzilla.wikimedia.org/73063) (owner: 10Robmoen) [00:52:35] (03CR) 10Jdlrobson: Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 (https://bugzilla.wikimedia.org/73063) (owner: 10Robmoen) [00:52:39] (03CR) 10Jdlrobson: [C: 032] Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 (https://bugzilla.wikimedia.org/73063) (owner: 10Robmoen) [00:52:56] - when the data looks kosher roll out bucketing and serve a treatement as a function of the bucket after the test activation time (last AC we added to that card) [00:53:34] (03Merged) 10jenkins-bot: Only assume sections are collapsible if they are wrapped in a div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171994 (https://bugzilla.wikimedia.org/73063) (owner: 10Robmoen) [00:56:18] (03PS4) 10Jdlrobson: Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) [00:56:50] (03PS3) 10BearND: Left/right animation inside page info dialog [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171875 [00:56:52] (03PS3) 10BearND: Disambig items have thumbnail, title, and Wikidata description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 [00:56:55] (03PS3) 10BearND: Slide up/down animations for BottomDialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171725 [00:56:57] (03PS5) 10BearND: Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [00:58:54] (03PS3) 10Jdlrobson: Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) [00:59:31] (03CR) 10jenkins-bot: [V: 04-1] Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) (owner: 10Jdlrobson) [01:00:30] (03PS3) 10Jdlrobson: Put icon and text on the same line in VE switcher dropdown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov) [01:05:16] (03PS6) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 [01:05:21] (03PS6) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 [01:05:27] (03PS7) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 [01:08:02] (03PS4) 10Jdlrobson: Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) [01:09:54] 3MobileFrontend / 3stable: Collapsing and expanding sections does not work in Category: namespace - 10https://bugzilla.wikimedia.org/73063 (10Jon) 5PATC>3RESO/FIX [01:11:29] Alright guys, I'm packing up some stuff and getting ready for my trip Sunday. Have a great weekend. See some of you in the office Monday morning. xD [01:25:23] (03PS1) 10Jdlrobson: Ensure notifications overlay code runs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172006 (https://bugzilla.wikimedia.org/73149) [01:26:04] ^ kaldari|2 can you merge asap would hate this to get on to mediawiki.org [01:31:57] (03PS1) 10Jdlrobson: Lolz CamelCase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172008 (https://bugzilla.wikimedia.org/73098) [01:34:54] ^ bmansurov hehe [01:35:21] good [01:36:58] (03PS5) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 [01:44:09] 3MobileFrontend / 3Hygiene: Kill M.isApp method and less/apps directory - 10https://bugzilla.wikimedia.org/73158 (10Jon) [01:49:29] (03PS1) 10Deskana: Capitalise first letter of Wikidata descriptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172010 [01:49:49] (03CR) 10jenkins-bot: [V: 04-1] Capitalise first letter of Wikidata descriptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172010 (owner: 10Deskana) [01:51:56] (03PS8) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 [01:51:58] (03PS6) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 [01:52:00] (03PS7) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 [01:52:02] (03PS5) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 [01:52:24] (03PS9) 10Jdlrobson: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 [01:52:40] (03PS7) 10Jdlrobson: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 [01:53:33] (03PS2) 10Deskana: Capitalise first letter of Wikidata descriptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172010 [01:54:48] (03PS3) 10Jdlrobson: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 [01:55:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [02:20:23] I have a urgent request: for the beta: a azw/prc/ or possibly .mobi re-render link would be unimaginably helpful [02:24:58] with reference to bug https://bugzilla.wikimedia.org/show_bug.cgi?id=58621 , yes SOME kindles do handle pdfs natively but not over 3g with the stock browser [06:30:55] 3MobileFrontend / 3alpha: Improve display of categories - 10https://bugzilla.wikimedia.org/73008 (10Jon) 5PATC>3RESO/FIX [20:12:27] 3MobileFrontend / 3stable: Long gallery captions break viewport - 10https://bugzilla.wikimedia.org/73183 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17082 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17082&action=edit example See http://en.m.wikipedia.org/wiki/The_Roulin_Fa... [20:15:26] 3MobileFrontend / 3stable: Long gallery captions break viewport - 10https://bugzilla.wikimedia.org/73183#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Bp5vblME [21:07:57] 3MobileFrontend / 3Feature requests: Design suggestions for mobile user profile page - 10https://bugzilla.wikimedia.org/73185 (10Axel Boldt) 3NEW p:3Unprio s:3normal a:3None I have two design suggestions for the mobile user profile pages: 1) Provide a more prominent and more obvious link to the user... [21:10:25] 3MobileFrontend / 3Feature requests: Design suggestions for mobile user profile page - 10https://bugzilla.wikimedia.org/73185#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/r6lEwrzy [22:35:40] 3MobileFrontend / 3Feature requests: Design suggestions for mobile user profile page - 10https://bugzilla.wikimedia.org/73185#c2 (10Andre Klapper) s:5normal>3enhanc Thanks. For future reference one issue per ticket only, please.