[02:31:17] (03CR) 10Dbrant: [C: 04-1] "Looks great overall, but one tiny thing:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 (owner: 10BearND) [02:53:49] (03CR) 10Dbrant: [C: 04-1] Change width of tappable area for "Skip" in OnboardingActivity. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171509 (owner: 10Deskana) [03:21:46] (03PS2) 10Deskana: Change width of tappable area for "Skip" in OnboardingActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171509 [03:24:35] (03CR) 10Dbrant: [C: 032] Change width of tappable area for "Skip" in OnboardingActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171509 (owner: 10Deskana) [07:28:33] (03CR) 10Florianschmidtwelzow: "Follow up: I0a409e40e39a63d5d8e79d0b1236422a004d1723" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171301 (https://bugzilla.wikimedia.org/73008) (owner: 10Florianschmidtwelzow) [07:28:51] (03CR) 10Florianschmidtwelzow: "Follow up for: Ie3062a9b560db1aa6b2a889d9cc10f4a1033441e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171984 (owner: 10Bmansurov) [08:48:38] good morning [09:06:40] morning joakino [09:07:01] good morning phuedx [09:07:08] how was the weekend [09:08:49] good thanks [09:08:51] yours? [09:19:25] quiet, but good [09:25:12] (03CR) 10Jhernandez: [C: 031] "Looks good to me, I want somebody else to have a look." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [09:26:52] phuedx: can you review ^ and if you think so +2 it? looks good to me and everything works but i'm not confident enough with all that mumbo jumbo yet [09:27:02] sooner we get those hygiene things through, the better [09:30:39] joakino: will look after i've finished reading through email ;) [09:30:49] phuedx: sure, thanks [09:31:18] just submitted my travel dates for the all hands [09:33:45] what's that? [09:34:57] there's an all hands in january [09:35:11] if you haven't had an email about it, send an email to tomasz [09:35:23] (all staff -> sf) [09:35:29] (i think) [09:36:51] I got an invitation to a QUARTERLY REVIEW MEETING which is the 29-30 January [09:37:22] phuedx: I'll ask tomasz [09:37:33] nosir [09:37:44] yessir [09:42:48] YES!!! i have two emails in one of my inboxes! [09:42:56] pew pew pew [09:44:48] you can do it [09:45:22] joakino: i'm picking up the review for the first two items in the code review column real quick [09:45:31] they address the same issue, but for two different bugs [09:46:03] that is to say: both changes need their commit messages combining :) [09:53:05] (03PS2) 10Phuedx: Ensure notifications overlay code runs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172006 (https://bugzilla.wikimedia.org/73149) (owner: 10Jdlrobson) [09:54:04] (03CR) 10Phuedx: [C: 032] Ensure notifications overlay code runs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172006 (https://bugzilla.wikimedia.org/73149) (owner: 10Jdlrobson) [09:54:42] (03Merged) 10jenkins-bot: Ensure notifications overlay code runs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172006 (https://bugzilla.wikimedia.org/73149) (owner: 10Jdlrobson) [09:55:53] (03CR) 10Phuedx: "I opted to merge Jdlrobson's change (I0cd04a2dc62f7fd353c9e0584fec82fc68321dbf), which fixes the same issue, but also changes the group pr" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172113 (https://bugzilla.wikimedia.org/73198) (owner: 10Florianschmidtwelzow) [10:00:20] (03CR) 10Florianschmidtwelzow: Ensure notifications overlay code runs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172006 (https://bugzilla.wikimedia.org/73149) (owner: 10Jdlrobson) [10:01:12] (03CR) 10Florianschmidtwelzow: "Yeah, i haven't seen this change :) Can you take a look at my comment? If i'm the only who see this so, i will abandon this change, otherw" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172113 (https://bugzilla.wikimedia.org/73198) (owner: 10Florianschmidtwelzow) [10:01:40] 3MobileFrontend / 3stable: Notices and Warnings in mobile view - 10https://bugzilla.wikimedia.org/73198 (10Florian) 5PATC>3RESO/FIX [10:02:12] 3MobileFrontend / 3stable: Clicking notifications icon takes me to Special:Notifications rather than JavaScript overlay. - 10https://bugzilla.wikimedia.org/73149 (10Sam Smith) 5PATC>3RESO/FIX [10:03:23] (03CR) 10Phuedx: "You're right. I think it's good to be consistent within the method/class/extension etc." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172113 (https://bugzilla.wikimedia.org/73198) (owner: 10Florianschmidtwelzow) [10:03:37] MOAR COFFEE REQUIRED [10:07:49] agreed [10:08:18] (03PS2) 10Florianschmidtwelzow: Be consistent in "modules-to-load" declaration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172113 (https://bugzilla.wikimedia.org/73198) [10:13:22] (03CR) 10Jhernandez: [C: 032] Lolz CamelCase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172008 (https://bugzilla.wikimedia.org/73098) (owner: 10Jdlrobson) [10:14:02] (03Merged) 10jenkins-bot: Lolz CamelCase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172008 (https://bugzilla.wikimedia.org/73098) (owner: 10Jdlrobson) [10:22:13] (03CR) 10Phuedx: [C: 032] Be consistent in "modules-to-load" declaration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172113 (https://bugzilla.wikimedia.org/73198) (owner: 10Florianschmidtwelzow) [10:22:56] (03Merged) 10jenkins-bot: Be consistent in "modules-to-load" declaration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172113 (https://bugzilla.wikimedia.org/73198) (owner: 10Florianschmidtwelzow) [10:28:26] joakino: are you going through the code review column? [10:28:51] yes, from the end [10:29:04] i'm with the talk page bugs [10:29:04] there are a few dependent commits [10:29:11] phuedx: ^ [10:29:32] coool [10:29:36] i'll leave 'em alone [10:34:54] (03CR) 10Jhernandez: "awesome comments and splitting up methods" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171958 (owner: 10Jdlrobson) [10:35:22] wow gerrit breaks if you do emoticons in textareas 👍 [10:37:01] you've got a lot of love for gerrit joakino ;) [10:37:26] oh yeah [10:37:44] i have a lot of hopes for the code review system in phab [10:38:00] i hope is not as mediocre as the maniphest thingy [10:39:22] i'm looking forward to markdown [10:39:23] that's about it [10:42:30] i have very few needs [10:46:33] phuedx: yeah, markdown ftw [10:46:59] is there any way of seeing comments you've been answered to in gerrit? [10:47:16] like a notifications stream or something [10:47:46] i have no idea [10:47:49] email? ;) [10:55:08] (03CR) 10Jhernandez: [C: 032] Hygiene: Make add talk discussion a route. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) (owner: 10Jdlrobson) [10:55:49] (03Merged) 10jenkins-bot: Hygiene: Refactor talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171958 (owner: 10Jdlrobson) [10:55:53] (03Merged) 10jenkins-bot: Hygiene: Make add talk discussion a route. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) (owner: 10Jdlrobson) [10:57:01] (03CR) 10Phuedx: "Overall this looks great. See inline for a possible issue with the changes to SkinMinerva#getDefaultModules." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [11:05:00] (03CR) 10Florianschmidtwelzow: Hygiene: Make add talk discussion a route. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171959 (https://bugzilla.wikimedia.org/71076) (owner: 10Jdlrobson) [11:12:02] (03CR) 10Jhernandez: [C: 032] Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) (owner: 10Jdlrobson) [11:12:40] (03Merged) 10jenkins-bot: Enable routing on TalkSectionOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) (owner: 10Jdlrobson) [11:18:13] (03CR) 10Phuedx: WikiGrok A/B test dry run (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [11:20:40] 3MobileFrontend / 3beta: Talk: Back button doesn't destroy open topic - 10https://bugzilla.wikimedia.org/71075 (10Jhernandez) 5PATC>3RESO/FIX [11:22:54] 3MobileFrontend / 3beta: Talk: Clicking back from add topic overlay doesn't destroy it - 10https://bugzilla.wikimedia.org/71076 (10Jhernandez) 5PATC>3RESO/FIX [11:29:07] (03CR) 10Jhernandez: [C: 032] Tools: Run `make jsduck` on git review [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171995 (owner: 10Jdlrobson) [11:29:48] (03Merged) 10jenkins-bot: Tools: Run `make jsduck` on git review [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171995 (owner: 10Jdlrobson) [11:33:28] (03PS2) 10Jhernandez: Hygiene: Complete JS documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171996 (owner: 10Jdlrobson) [11:34:33] (03CR) 10Jhernandez: [C: 032] Hygiene: Complete JS documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171996 (owner: 10Jdlrobson) [11:35:15] (03Merged) 10jenkins-bot: Hygiene: Complete JS documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171996 (owner: 10Jdlrobson) [11:37:29] (03CR) 10Jhernandez: [C: 032] Show intermediate loader when loading image overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171986 (owner: 10Jdlrobson) [11:38:08] (03Merged) 10jenkins-bot: Show intermediate loader when loading image overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171986 (owner: 10Jdlrobson) [11:42:40] (03PS5) 10Phuedx: WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 [11:42:49] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [11:43:32] (03PS6) 10Phuedx: WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 [11:45:18] (03CR) 10Phuedx: WikiGrok A/B test dry run (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [11:47:34] joakino: you've +2'd the change for https://trello.com/c/VvOLUJVy/129-bug-73098-unable-to-unwatch-on-special-editwatchlist, right? [11:47:43] (i've just moved it to code review) [11:47:53] if so, then i'll move it along to sign off [11:48:03] because it seems that it can only be tested in prod [11:48:04] :/ [11:48:27] phuedx: oh yes, I saw it before, didn't see the related card, sorry [11:50:27] phuedx: on that topic, the resource loader does not complain if it doesn't find one of the files? [11:50:50] joakino: obviously not :/ [11:50:58] sec [11:51:36] joakino: yes, it does [11:51:41] but maybe not loudly [11:51:47] aha [11:51:55] however, the module would be in an error state on the front-end [11:52:13] so, mw.loader.moduleRegistry[ '' ].state would be "error" [11:52:31] there'd be exceptions in the error logzzz though [11:52:34] for defs [11:56:05] in the client it doesnt log anything [11:56:13] :S [11:58:55] hrrrm [11:59:08] so you've deliberately borked a module? [12:01:34] joakino: i see this: Failed to load resource: the server responded with a status of 404 (Not Found) http://127.0.0.1:8080/w/extensions/MobileFrontend/javascripts/modules/watchstar/Watchstar.jsaskjhlsdkfhj [12:01:55] file system case sensitivity maybe? [12:01:57] :/ [12:02:26] that must be it [12:03:01] right, i'm taking george out for lunch [12:03:02] bbl [12:03:49] it is so weird, I would guess that osx is as case sensitive as linux... [12:03:59] i don't know... in any case, it is solved [12:04:25] phuedx: bon appetite [14:23:40] back now wireless problems have been resolved [14:54:40] 3MobileFrontend / 3General/Unknown: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73109#c2 (10Sam Smith) Sam Reed: are there any other notices originating from ApiMobileView.php at around the same time? For this to happen ApiMobileView#getData, which returns the required data about a page, must... [15:34:04] hey jdlrobson [15:41:53] (03PS1) 10Phuedx: Die with an error if the title redirects to media [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) [15:42:41] (03CR) 10jenkins-bot: [V: 04-1] Die with an error if the title redirects to media [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [15:51:48] (03PS2) 10Phuedx: Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) [16:07:11] 3MobileFrontend / 3General/Unknown: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73109#c4 (10Sam Reed (reedy)) Just had a look again now, and grepping for "ApiMobileView" literally only finds the stuff on line 98, and nothing more if I grep for "MobileFrontend" [16:08:11] 3MobileFrontend / 3General/Unknown: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73109#c5 (10Sam Reed (reedy)) It's probably worth noting this will happen on zend on production too, just we don't surface these things in the logs... [16:08:18] (03CR) 10Reedy: [C: 031] Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [16:28:20] brb [16:30:56] 3MobileFrontend / 3General/Unknown: Jenkins: QUnit job always -1ing patches in MobileFrontend - 10https://bugzilla.wikimedia.org/72505#c4 (10Greg Grossmeier) p:5Unprio>3Normal (Not a CI problem then. Moving to the proper component) [16:34:11] i'm here [16:35:16] phuedx: i saw your change: https://gerrit.wikimedia.org/r/#/c/172258/ have you test it? I took a look into the code, and if i understand it right (without testing), it should returned null for lastmodifiedby if there is no user (e.g. NS_SPECIAL)? [16:39:38] FlorianSW: there's actually a test that tests that code path (see the first v: -1 from jenkins) [16:40:24] in the case of a title being a redirect to a special page – which is what /i think/ /might/ be happening – #getData returns an empty array [16:40:24] phuedx: ah, ok :) [16:40:40] not array( 'lastmodifiedby' => null ) [16:41:02] in the other code paths lastmodifiedby – as well as all the other parameters – should be set [16:41:32] that's the only thing i could think of :( [16:43:50] that's why i'm wondering, it should be null :/ [16:43:56] inorite [16:45:20] apart from when the title is a redirect to a special page – ApiMobileView.php lines 429 - 441 [16:48:31] FlorianSW: wait one sec, i'll amend the test case to cause an error [16:49:43] phuedx: i have the error, really on a redirect to a specialpage :/ [16:49:53] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove unused template variables in Page and Section (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 (owner: 10Jdlrobson) [16:53:20] (03Merged) 10jenkins-bot: Hygiene: Remove unused template variables in Page and Section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171723 (owner: 10Jdlrobson) [16:54:00] phuedx: *facepalm* now i understand, what you mean with L429-L441, i haven't seen the return array :( [16:55:56] (03CR) 10Florianschmidtwelzow: [C: 031] Fix "Undefined index" notices in ApiMobileView (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [17:00:46] (03CR) 10Dbrant: [C: 04-1] "Code looks solid; however, the styling of the list items should probably be the same as the search results:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 (owner: 10BearND) [17:02:13] (03PS3) 10Phuedx: Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) [17:02:47] (03CR) 10Phuedx: "PS3 adds a supporting test case (based off of the one that failed for PS1)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [17:02:56] (03CR) 10jenkins-bot: [V: 04-1] Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [17:04:19] (03CR) 10Jhernandez: [C: 032] Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson) [17:04:26] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson) [17:04:51] asdf rebase [17:06:27] (03PS4) 10Phuedx: Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) [17:06:44] code style [17:06:51] when you least expect it [17:07:22] phuedx: yeah :D "Should i run phpcs locally?"... "ah, no, it's just a little change" :D [17:19:10] (03PS1) 10Reedy: Don't call $this->config directly, instead call $this->getZeroConfig() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/172278 [17:29:07] (03PS13) 10Dbrant: Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [17:34:55] 3Wikipedia App / 3Android App: NPE when updating ProgressBar - 10https://bugzilla.wikimedia.org/72817#c3 (10Dmitry Brant) 5RESO/FIX>3REOP it would appear not :( we still can't reproduce it... [17:44:40] (03PS8) 10Jhernandez: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson) [17:48:06] (03CR) 10Jhernandez: [C: 032] "That was a tough rebase..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson) [17:48:55] (03Merged) 10jenkins-bot: Hygiene: Add save message by default to Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171731 (owner: 10Jdlrobson) [17:53:27] (03CR) 10Robmoen: [C: 031] "Small doc tweak. Otherwise, LG2M" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [18:02:04] kaldari|2: heya! [18:02:10] kaldari|2: I emailed you about a script of yours on stat1003 [18:16:30] (03CR) 10Jdlrobson: [C: 032] Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [18:17:19] (03CR) 10Chad: [C: 031] Don't call $this->config directly, instead call $this->getZeroConfig() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/172278 (owner: 10Reedy) [18:19:27] (03CR) 10Bmansurov: "jdlrobson, should I abandon this patch? Are you submitting your own patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov) [18:19:45] bmansurov: sure. I took a look at it Friday and it's pretty nasty :) [18:19:50] (the problem not your code) [18:19:59] I'm trying to work out what's going on with it [18:20:05] jdlrobson: ok i'll abandon it [18:20:07] (03Merged) 10jenkins-bot: Fix "Undefined index" notices in ApiMobileView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172258 (https://bugzilla.wikimedia.org/73109) (owner: 10Phuedx) [18:20:26] (03PS4) 10Jdlrobson: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 [18:20:49] (03Abandoned) 10Bmansurov: Put icon and text on the same line in VE switcher dropdown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171771 (owner: 10Bmansurov) [18:21:12] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [18:21:32] (03PS5) 10Jdlrobson: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 [18:21:46] jdlrobson: you've got email :) [18:22:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [18:24:06] DarTar: I need some help with pulling that new mysql password into a shell script [18:24:23] (03CR) 10Robmoen: [C: 032] Redirect to Section, if possible, after edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172111 (owner: 10Florianschmidtwelzow) [18:25:31] (03CR) 10Jdlrobson: [C: 04-1] Redirect to Section, if possible, after edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172111 (owner: 10Florianschmidtwelzow) [18:26:04] kaldari|2: is tomorrow holiday there? [18:26:20] (03CR) 10Jdlrobson: "Just to double check - do we want this behaviour? In a long article if I'm editing the last section, do I want to be redirected to the con" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172111 (owner: 10Florianschmidtwelzow) [18:27:56] (03Merged) 10jenkins-bot: Redirect to Section, if possible, after edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172111 (owner: 10Florianschmidtwelzow) [18:28:21] kristenlans: Deskana|Away: bearND: sorry for connection issues :( [18:28:55] (03PS6) 10Robmoen: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [18:29:12] Deskana|Away: bearND: the one OTRS report about "upgrading" from 4 to 5 seems to be because the database somehow became read-only (?) [18:29:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [18:29:41] kaldari|2: jdlrobson MaxSem we're meeting in R37, fyi [18:29:54] not R31 [18:30:18] MaxSem: we need to merge this https://gerrit.wikimedia.org/r/#/c/171891/ ? [18:30:49] dbrant: bearND just wanted to say again how great those page styling patches turned out! you’ve set the bar high! :) [18:31:38] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/171157 (https://bugzilla.wikimedia.org/72991) (owner: 10Brion VIBBER) [18:31:39] we do, however we need to test it first, sadly:P [18:32:03] brion: ^ that was a strange bug! [18:32:09] jdlrobson, we do, however we need to test it first, sadly:P [18:32:20] mhurd: totally! you’d think that would ‘just work’ [18:32:34] luckily i found a stackoverflow q with the same problem and a simple solution [18:32:42] that could have been a ‘spend hours going wtf’ bug ;) [18:32:46] mhurd: thanks!! exciting times [18:32:48] brion: haha yeah [18:32:54] dbrant: :) [18:34:55] 3Wikipedia App / 3iOS App: Wikipedia App: [iOS] App crashes when closing the "Recent" and "Saved pages" section, while option to delete individual item is visible - 10https://bugzilla.wikimedia.org/72991#c4 (10Monte Hurd) 5PATC>3RESO/FIX Merged Brion's patch. [18:37:32] joakino: i fixed it for you ;-) [18:38:02] jdlrobson: thx :D [18:38:05] (03CR) 10Florianschmidtwelzow: "Oh,i thought this is the "Standard" workflow :) When i edit something i want to read the section i edited (or sections after this one). It" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172111 (owner: 10Florianschmidtwelzow) [18:38:32] jdlrobson: ^ [18:39:01] ^ -> hi, ^ [18:41:15] Etherpad link: https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:55:56] mhurd: So the lead image stuff is already right after the search stuff in the backlog. So that's great. :) [18:56:17] Deskana: sounds great! [19:03:32] mhurd, dbrant, bearND: Boards are split now [19:03:40] Deskana: yay! [19:03:48] (03CR) 10Robmoen: [C: 04-1] "Small issue, also some qunit fails that I haven't investigated yet" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [19:04:21] Deskana: :) [19:07:06] Deskana: I like that the boards now have different background colors :) I don't see the new iOS board in my list [19:08:12] bearND: Yeah, I figured that'd help a bit since we already have the "Green for Android, blue for iOS" [19:08:24] bearND: And, I forgot to add people to the iOS board. Let me fix that. [19:11:24] bearND: Should be fixed now. [19:15:37] Deskana, hey [19:15:48] Krenair: Hey! [19:15:57] you three appear to be online at the moment :) [19:16:37] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketQueue;QueueID=323;View=Preview has 10 tickets which either don't relate to any specific app, or need you to look at them [19:21:46] Krenair: I'll take a look. Thanks for pointing them out. [19:23:17] FlorianSW, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7942108 should have been bounced back into info-en. I put it there deliberately [19:24:36] Krenair: the ticket come back from Courtesy, so i thought it's orrect in our queue, sorry :) [19:24:43] No [19:24:53] It's supposed to be in info-en, which is why I moved it there. [19:25:00] Someone else moved it back, they should not have done so. [19:25:54] ok [19:35:00] hey FlorianSW in meetings right now but will take a look in a bit [19:35:17] jdlrobson: ok, thanks ;) [19:35:18] but yeh i'm not sure what the correct behaviour should be in that situation. We've never really looked to see what people do post edit [19:36:57] 3Wikipedia App / 3Android App: IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. - 10https://bugzilla.wikimedia.org/73236 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descen... [19:43:12] 3Wikipedia App / 3Android App: IllegalStateException: Can not perform this action after onSaveInstanceState - 10https://bugzilla.wikimedia.org/73237 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None Seems to happen during the BackStackRecord.commit call in page.PageActivity.pushFragment E.g.: https://t... [19:47:37] http://hatjitsu.wmflabs.org/73101 [19:49:13] http://hatjitsu.wmflabs.org/73101 [20:03:36] Brion, is there anything someone with practically no PHP experience (that is, me) can do to help you with anything in the "Allow styling in templates" RFC, or would I just get in your and Tims way? [20:04:06] MartyH: i could totally use some good use case examples [20:04:23] cool, I can definitely find some of those [20:04:26] awesome :D [20:04:48] i’m in the midst of a mobile refactor right now, hope to get back to the styling later this week [20:04:55] (also, was the case of templates that return incomplete HTML elements considered yet, i.e. the collapse top/collapse bottom?) [20:04:55] MartyH: feel free to ping me by email as well [20:05:24] brion: also, 'mobile app team exodus!!1' :) [20:05:26] yeah that’s a tricky case. my preference is to recommend retooling such templates to nested templates, which the parsoid/VE folks prefer too :D [20:05:46] * brion parts the red sea [20:06:04] yeah, I think eveybody would prefer that. I thought that was blocked on max parameter length though? Or is that no longer an issue? [20:06:11] [[NSRedSea sharedInstance] partCompletionBlock:^(){[NSEgyptians flood]}] [20:06:26] hmmm good question, i’ll have to research that [20:07:30] jdlrobson: tch tch [20:07:34] jdlrobson: you shouldn't need sudo to read it now [20:07:40] * YuviPanda puts jdlrobson on *very* naughty list [20:07:44] YuviPanda: lol i just pressed enter trigger happy :) [20:07:48] haha [20:07:50] up, enter, rather than up up enter [20:08:07] jdlrobson: :) Ops shall now confiscate your hat license [20:08:08] I'll mail you a few templates that would be use-cases for me. I'm quite excited about the whole thing, and think it has the potential to really help everyone - both from the dev perspective as well as the user perspective [20:08:08] wow i got upgraded monitors at the office, went from 1920x1080 to 1920x1200 [20:08:15] there’s so much more room for debugging [20:08:35] 16:9 is terrible. 16:10 rocks [20:20:54] jdlrobson: yeah, point the research pw questions to me for today, ottomata can pick them up from tomorrow [20:21:00] if you still have questions that is [20:23:49] jdlrobson: you hitting any vagrant issues with mobilefrontend? i'm hitting the error "Fatal error: Class 'ResourceLoaderParsedMessageModule' not found in /vagrant/mediawiki/includes/resourceloader/ResourceLoader.php on line 506" and it has SkinMinerva->prepareQuickTemplate() in the stack trace. i've updated the master branches of vagrant and the submodules and run vagrant provision. [20:23:58] dr0ptp4kt: update Mantle [20:24:09] YuviPanda: i've got password thanks [20:24:15] jdlrobson: yw! [20:25:19] jdlrobson: that did it. thx! [20:31:36] http://etherpad.wikimedia.org/p/I [20:33:26] http://www.leblogdefanaworld.fr/wp-content/uploads/2013/09/i-robot-wallpaper.jpg [21:06:51] (03PS8) 10Dbrant: Hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [21:07:25] (03PS1) 10Bmansurov: Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 [21:08:16] (03CR) 10jenkins-bot: [V: 04-1] Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [21:17:34] howdy, vbamba [21:17:37] new team metric: time from initial commitment to first change [21:17:56] (03PS2) 10Bmansurov: Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 [21:18:17] so i'm wide awake [21:18:31] and everyone else is going to bed :/ [21:21:32] * phuedx is going to play with elixir [21:21:45] bearND: I found out what's making our search results for fulltext bad/wrong. [21:22:04] bearND: .param("generator", "search") [21:22:08] bearND: That changes the ordering. [21:22:44] Deskana: I had to use the generator because i needed the wikibase_item(s) (aka. Wikidata IDs) [21:23:01] bearND: I don't know what to do about that, though. Monte suggested looking at the patch that was written a while ago for opensearch. Apparently there's something extra in the API response that tells you the original ordering. [21:23:08] bearND: Sync up with him about that? [21:23:39] mhurd: ^ [21:27:18] (03PS1) 10Bmansurov: Change "Read in another language" button to neutral button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 [21:30:10] (03PS4) 10BearND: Left/right animation inside page info dialog [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171875 [21:30:11] (03PS4) 10BearND: Disambig items have thumbnail, title, and Wikidata description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 [21:30:13] (03PS4) 10BearND: Slide up/down animations for BottomDialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171725 [21:30:15] (03PS6) 10BearND: Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [21:32:53] bearND: looking for that patch... [21:35:03] bearND: so it was based on this patch: https://gerrit.wikimedia.org/r/#/c/158011/2/javascripts/modules/search/SearchApi.js [21:35:41] bearND: either you or dbrant then updated the android app prefix search to do the same [21:36:21] mhurd: thanks, yeah, dbrant did that for title search, one of us needs to do the same for full text search [21:36:30] bearND: ya [21:36:33] Deskana: ^ [21:37:00] bearND: should be fairly easy [21:37:51] mhurd: yeah. I'll check it out later, once we've got most of the stuff so far merged [21:38:21] bearND: cool! i’ll try to keep it in mind as well as i implement the search changes [21:38:52] dbrant: great. you're back. i got a question about making the whole disambig items clickable in https://gerrit.wikimedia.org/r/#/c/171876/ [21:39:51] dbrant: I'm using disambigList.setOnItemClickListener, similar to what's in FullSearchFragment but the click listener doesn't get called [21:40:55] dbrant: I could set individual click listeners on each item but that seems a bit hacky, and then I would need to pass in more references to the outer dialog and the activity to the ListAdapter [21:41:49] dbrant: see the commented code in DisambigListAdapter. If I uncomment and set a breakpoint there it hits it [21:43:31] (03PS1) 10Bmansurov: Fix MobileWebWikiGrokError event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172412 (https://bugzilla.wikimedia.org/73162) [21:44:12] yurikR: any luck getting saves of Module: pages working? i'm going to try starting fresh with vagrant if not, to rule out any problems [21:44:28] dr0ptp4kt, no, still no luck, no idea what's failing there :( [21:44:39] kinda weird :( [21:44:57] i'm trying to wrap up the stats stuff [21:45:09] yurikR: ho hum. i'm going to fully remove the dir, only enable the scribunto role, and see if i can at least get the canonical example from its mediawiki page working [21:45:21] dr0ptp4kt, just create a new dir ;) [21:45:37] this way you can just delete the new trial [21:45:42] yurikR: right [21:45:50] up to you of course ;) [21:47:30] dbrant: hello [21:47:40] phuedx: did you see this? http://www.theguardian.com/media/mediamonkeyblog/2014/nov/10/sandwich-makers-of-britain-concede-daily-mail-front-page-is-right [21:47:58] ^ cc James_F|Away [21:48:32] (03PS1) 10Bmansurov: Remove old opt-out code. Related to bug 169544 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172415 [21:49:38] jdlrobson: Wow. Wine sandwich. [21:49:45] Deskana: :) [21:49:46] *Wine bottle sandwich [21:55:49] (03PS1) 10Bmansurov: Remove page description from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172416 [21:56:27] (03CR) 10jenkins-bot: [V: 04-1] Remove page description from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172416 (owner: 10Bmansurov) [21:56:30] mhurd: Here's a task for your backlog: writing an email to mobile-l laying out the advantages of switching to SWIFT. :) [21:56:36] mhurd: Whenever you get a chance. [21:56:47] Deskana: will do. i have a short list already [21:57:44] Is it SWIFT or Swift? [21:57:46] Swift. [21:59:25] bearND: sorry! catching up / looking... [21:59:40] dbrant: ah, ok, sent the same via email [22:00:16] (03PS2) 10Florianschmidtwelzow: Remove old opt-out code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172415 (owner: 10Bmansurov) [22:00:31] bmansurov: ^ i was free and changed the commit message :) [22:00:37] bearND: I always have bad luck with decent wifi when I'm away :( [22:00:51] FlorianSW: thanks [22:00:54] mhurd, brion: Reading the documentation for Swift on enwiki. Apparently it features revolution concepts like being able to add two strings directly together using + instead of using a method do it. [22:01:07] Deskana: hahahah [22:01:09] :D [22:01:10] mhurd, brion: I'm not sure I can handle concepts like this. So new and revolutionary. [22:01:17] Deskana: try PHP [22:01:20] it’ll blow your mind [22:01:25] add a string and a number! [22:01:31] and get a number [22:02:23] * Deskana sighs. [22:02:32] i like that nullability is explicit in swift :D [22:02:40] i’ve been bitten by nil things that shouldn’t have been nil a lot [22:02:59] Better than adding together two variables then finding out that you were trying to add a pointer to another pointer. [22:03:07] in java that dies immediately, but obj-c lets you call methods on nil and gives you back nil [22:03:10] heh [22:03:18] brion: so many little things are no longer issues in swift… can’t wait [22:03:22] srsly [22:05:15] Imagine that in real life. You get a container of milk, try milk.drink()... NULL POINTER EXCEPTION [22:05:22] Rather than "Oh, the milk is empty" [22:06:00] Programming languages are silly sometimes [22:06:12] (03PS2) 10Bmansurov: Remove page description from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172416 [22:08:19] (03PS3) 10Bmansurov: Remove page description from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172416 [22:09:36] return ENOMILK [22:09:55] throw new InsufficientMilkException(‘not got milk’); [22:10:16] (03CR) 10Kaldari: [C: 032] Fix MobileWebWikiGrokError event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172412 (https://bugzilla.wikimedia.org/73162) (owner: 10Bmansurov) [22:10:43] always use a try/catch block before you drink the milk, otherwise if you’re out YOU WILL DIE IMMEDIATELY [22:10:44] (03CR) 10Legoktm: [C: 032] Add i18n for API module help [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169848 (owner: 10Anomie) [22:10:53] (03Merged) 10jenkins-bot: Fix MobileWebWikiGrokError event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172412 (https://bugzilla.wikimedia.org/73162) (owner: 10Bmansurov) [22:11:07] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169848 (owner: 10Anomie) [22:12:05] Deskana: so in languages like rust, you'd have an Option which returns wether the milk is empty or not, and would refuse to let you drink until you also specify what you want to do when there is no milk [22:13:49] Does anyone know May's IRC nick? [22:14:21] in javascript, some miscreant could have made sure the drink method on milk now returns beer [22:16:07] bmansurov, not sure May uses IRC...? [22:16:27] Krenair: ok thanks [22:16:34] I could be wrong [22:16:48] violetto [22:16:51] But she's not here. [22:17:16] bmansurov: violetto [22:17:31] ok thanks guys [22:17:34] -NickServ- Last seen : Mar 22 18:38:36 2014 (33 weeks, 2 days, 04:38:50 ago) [22:20:50] Deskana, did you get a chance to look at any of those mobile queue tickets? [22:23:05] @bmansurov May is probably not the best person to mail about canonical icon repository [22:23:12] TrevorParscal: did we work this out yet? [22:23:31] Krenair: I got pulled in to a meeting. :-( [22:23:33] is there a repository we can use for icons whilst the Image module stuff is getting finalised? [22:23:35] Krenair: Let me polish off a few now. [22:23:55] some probably don't need a response. [22:23:58] jdlrobson: well, the patch is coming along, will probably get security review later this week, early next [22:24:08] But I'd prefer that you at least see them [22:24:21] TrevorParscal: but the work May and Monte were doing got finalised ya? Wikifont to svgs? [22:24:30] bearND: that's very strange indeed :/ [22:24:33] I'm trying to get some prep work done so we can easily switch over to the ImageModule [22:25:00] which means i need a copy of the icons we are going to use (or in this case bmansurov needs one in particular - watchstar) [22:25:01] jdlrobson: I haven't seen the results yet, but I will be requesting the icons from May when we are putting the final touches on the patch for MW core [22:25:22] May has the icons and is cleaning them up atm [22:25:57] 3MobileFrontend / 3beta: Talk: Add discussion button look like other Overlay buttons - 10https://bugzilla.wikimedia.org/73243 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 17087 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17087&action=edit actual master Can be reproduced... [22:26:40] 3MobileFrontend / 3beta: Talk: Add discussion button look like other Overlay buttons - 10https://bugzilla.wikimedia.org/73243#c1 (10Florian) Created attachment 17088 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17088&action=edit expected [22:28:12] 3Wikipedia App / 3Android App: NPE crashes from android.webkit.WebViewClassic.updateSelectionInfo - 10https://bugzilla.wikimedia.org/73244 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.NullPointerException at android.webkit.WebViewClassic.updateSelectionInfo(WebViewClassic.java:14972) at a... [22:28:58] (03PS1) 10Bmansurov: Kill M.isApp method and less/app directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172422 (https://bugzilla.wikimedia.org/73158) [22:29:00] MaxSem: Can we push up the current master branches of WikiGrok and MobileFrontend to wmf7? I think there's one cherry-pick already in the branch, so you might have to deal with that. [22:29:31] (03PS7) 10Jdlrobson: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 [22:29:31] when updating to master, you can always just recreate the branch [22:30:25] 3MobileFrontend / 3beta: Talk: Add discussion button look like other Overlay buttons - 10https://bugzilla.wikimedia.org/73243#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/MSED64NS [22:31:42] 3MobileFrontend / 3beta: Talk: Add discussion button look like other Overlay buttons - 10https://bugzilla.wikimedia.org/73243#c3 (10Jon) Ideally this should be replaced with an icon. Maybe @violetto can recommend one that is in the Wikifont (may this is not a high priority so please only reply if you can hel... [22:31:42] 3MobileFrontend / 3alpha: Alpha: Subheading overlaps Close button (TalkOverlay) - 10https://bugzilla.wikimedia.org/73088#c3 (10Florian) 5NEW>3RESO/WOR a:3Florian Seems to be fixed on betalabs: http://en.m.wikipedia.beta.wmflabs.org/wiki/0.6613060008941519 [22:32:18] greg-g: Hey Greg for the new Mobile self-deployments, should we use the SWAT window for that or get a new dedicated window? [22:32:24] 3MobileFrontend / 3alpha: Alpha: Subheading overlaps Close button (TalkOverlay) - 10https://bugzilla.wikimedia.org/73088#c4 (10Florian) Created attachment 17089 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17089&action=edit fixed [22:32:54] 3MobileFrontend / 3beta: Talk: Add discussion button look like other Overlay buttons - 10https://bugzilla.wikimedia.org/73243#c4 (10Jon) In meantime since editor uses 'Next' maybe we should just change the text to 'new topic' or simply 'new'/'add'. [22:34:40] 3Wikipedia App / 3Android App: Crash reports with null values? - 10https://bugzilla.wikimedia.org/68308#c3 (10Alex Monk) Not quite the same thing, but another useless one: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7881816 [22:35:06] jdlrobson: should we wait for new icons before fixing all alpha icon bugs? maybe they should be removed from ready for dev column for now. Maryana what do you think? [22:35:42] kaldari|2: new window, did you all decide to do it for the next 3ish weeks? [22:36:11] pick a time that looks reasonable and is open on the schedule [22:37:26] yurikR: able to finish the reviews on https://gerrit.wikimedia.org/r/#/c/170483/ and https://gerrit.wikimedia.org/r/#/c/169210/ ? [22:37:44] (03CR) 10Jdlrobson: [C: 032] Remove page description from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172416 (owner: 10Bmansurov) [22:38:22] (03Merged) 10jenkins-bot: Remove page description from Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172416 (owner: 10Bmansurov) [22:39:49] (03PS1) 10Robmoen: Add max height and scroll to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172424 [22:40:16] MaxSem: What do you think about Tuesdays at 10am? [22:42:16] (03PS1) 10Bmansurov: Alpha: Hide notifications bell icon when spinner is shown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172425 (https://bugzilla.wikimedia.org/73058) [22:43:42] 3MobileFrontend / 3Hygiene: Rename progress-bar.js and put in uploads directory - 10https://bugzilla.wikimedia.org/73247 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Should be called ProgressBar.js and live in uploads directory Module name should be modules/uploads/ProgressBar [22:44:08] (03CR) 10Jdlrobson: [C: 032] Kill M.isApp method and less/app directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172422 (https://bugzilla.wikimedia.org/73158) (owner: 10Bmansurov) [22:44:12] (03CR) 10Bmansurov: Add max height and scroll to reference drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172424 (owner: 10Robmoen) [22:44:33] MaxSem: ^ [22:44:42] 3MobileFrontend / 3Hygiene: javascripts/desktop folder can be removed - 10https://bugzilla.wikimedia.org/73248 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Just contains a readme. Not useful. [22:44:46] (03Merged) 10jenkins-bot: Kill M.isApp method and less/app directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172422 (https://bugzilla.wikimedia.org/73158) (owner: 10Bmansurov) [22:45:26] 3MobileFrontend / 3Hygiene: Rename progress-bar.js and put in uploads directory - 10https://bugzilla.wikimedia.org/73247#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oheTsM5F [22:45:26] 3MobileFrontend / 3Hygiene: javascripts/desktop folder can be removed - 10https://bugzilla.wikimedia.org/73248#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/GtClM9LS [22:47:59] (03PS1) 10BearND: Make disambig item clicks open linked page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172426 [22:48:07] dbrant: ^ [22:49:16] (03CR) 10Jdlrobson: [C: 04-1] Alpha: Hide notifications bell icon when spinner is shown (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172425 (https://bugzilla.wikimedia.org/73058) (owner: 10Bmansurov) [22:49:59] (03CR) 10Jdlrobson: [C: 04-1] "I have one open question to designers/product." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [22:50:15] (03CR) 10Florianschmidtwelzow: Add max height and scroll to reference drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172424 (owner: 10Robmoen) [22:53:55] 3MobileFrontend / 3Hygiene: Kill M.isApp method and less/apps directory - 10https://bugzilla.wikimedia.org/73158 (10Jon) 5PATC>3RESO/FIX [22:54:12] 3MobileFrontend / 3General/Unknown: WikiGrokDialogB Response spinner needs design love - 10https://bugzilla.wikimedia.org/73249 (10Rob Moen) 3NEW p:3Unprio s:3normal a:3None Created attachment 17090 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17090&action=edit Current spinner location Cur... [22:54:38] brion: been commenting out the build scripts while doing dev… so much faster [22:54:39] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Neutral feels wrong :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [22:55:05] mhurd: i can probably make them not run when not needed… will take a peek later [22:55:11] like not running inkscape if the .svg hasn’t changed [22:55:19] brion: not a bad idea [22:55:25] 3MobileFrontend / 3General/Unknown: WikiGrokDialogB Response spinner needs design love - 10https://bugzilla.wikimedia.org/73249#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/lBmdHSwP [23:01:36] bearND: will look in more detail in a little while. currently on the road for a couple hours [23:02:17] dbrant: k. ty [23:03:02] (03CR) 10Bmansurov: "Florianschmidtwelzow, fyi: https://trello.com/c/brvBDsO4/19-5-change-read-in-another-language-button-to-neutral-button" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [23:04:10] (03CR) 10Jdlrobson: [C: 032] Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [23:04:15] (03CR) 10jenkins-bot: [V: 04-1] Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [23:20:35] (03CR) 10Robmoen: [C: 04-1] "Needs rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [23:23:18] (03PS2) 10Bmansurov: Alpha: Hide notifications bell icon when spinner is shown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172425 (https://bugzilla.wikimedia.org/73058) [23:25:27] (03PS3) 10Bmansurov: Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 [23:26:08] yurikR: dfoy_ starting with a completely fresh vagrant installation and then enabling the 'scribunto' role, it's possible to save Module: pages. then, after enabling the role 'zero', it's also possible to keep saving Module: pages. after copying things from zero.wikimedia.org to localhost:8080, lua starts to assemble some stuff together. yurikR, i'll probably need your help wiring up a few more things, but it's now on a better track for [23:26:50] thx dr0ptp4kt, good to know. I wonder what broke in scribunto [23:27:10] i will review the patches today or tomorrow morning. [23:28:41] yurikR: thx. reminder: tomorrow's a holiday here. [23:28:51] dr0ptp4kt, yep, thx [23:32:59] (03CR) 10Robmoen: [C: 032] Alpha: Hide notifications bell icon when spinner is shown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172425 (https://bugzilla.wikimedia.org/73058) (owner: 10Bmansurov) [23:33:36] (03Merged) 10jenkins-bot: Alpha: Hide notifications bell icon when spinner is shown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172425 (https://bugzilla.wikimedia.org/73058) (owner: 10Bmansurov) [23:36:16] (03PS8) 10Robmoen: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [23:37:43] (03CR) 10Robmoen: [C: 032] Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [23:38:23] (03Merged) 10jenkins-bot: Hygiene: Move settings into standalone module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171781 (owner: 10Jdlrobson) [23:39:27] (03CR) 10Robmoen: [C: 04-1] "Needs rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson) [23:40:50] jdlrobson2: I'd like to work on this card (https://trello.com/c/FydOAtob/27-3-update-click-tracking-limn-graphs). What info do I need? [23:44:03] (03CR) 10Yurik: [C: 032] Don't call $this->config directly, instead call $this->getZeroConfig() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/172278 (owner: 10Reedy) [23:44:24] (03Merged) 10jenkins-bot: Don't call $this->config directly, instead call $this->getZeroConfig() [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/172278 (owner: 10Reedy) [23:45:06] (03CR) 10Robmoen: [C: 031] Change "Read in another language" button to neutral button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [23:49:24] (03PS1) 10Bmansurov: Conform to the MobileWebWikiGrok schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443