[00:01:19] (03PS1) 10Bmansurov: Don't run eventLogging in QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172447 (https://bugzilla.wikimedia.org/73106) [00:07:27] (03CR) 10Robmoen: [C: 04-1] "This does not work in the simulator, tested iphone 5 and ipad ios8." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172424 (owner: 10Robmoen) [00:10:53] (03PS2) 10Robmoen: Add max height and scroll to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172424 [00:16:45] (03PS1) 10Bmansurov: Alpha: Fix watchstar animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172453 (https://bugzilla.wikimedia.org/73050) [00:17:29] (03PS1) 10Deskana: Show confirmation dialogue when users click on links in preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172454 [00:31:09] (03PS1) 10Jdlrobson: Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 [00:31:11] (03PS1) 10Jdlrobson: Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 [00:31:13] (03PS1) 10Jdlrobson: Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 [00:31:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [00:31:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 (owner: 10Jdlrobson) [00:31:26] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 (owner: 10Jdlrobson) [00:32:59] (03CR) 10Robmoen: [C: 04-1] "Needs rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [00:35:20] dr0ptp4kt: hey! time to chat today or tomorrow about the ios candidate you interviewed? [00:35:48] (03PS2) 10Jdlrobson: Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 [00:35:50] (03PS2) 10Jdlrobson: Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 [00:35:53] (03PS2) 10Jdlrobson: Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 [00:36:31] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [00:36:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 (owner: 10Jdlrobson) [00:36:47] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 (owner: 10Jdlrobson) [00:38:56] (03PS3) 10Jdlrobson: Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 [00:41:05] (03PS1) 10Jdlrobson: Hygiene: Kill unnecessary folder/readme [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172461 [00:46:36] (03CR) 10Bmansurov: [C: 032] Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 (owner: 10Jdlrobson) [00:47:12] (03CR) 10Bmansurov: [C: 032] Hygiene: Kill unnecessary folder/readme [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172461 (owner: 10Jdlrobson) [00:47:14] (03Merged) 10jenkins-bot: Hygiene: Correct documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172459 (owner: 10Jdlrobson) [00:47:48] (03Merged) 10jenkins-bot: Hygiene: Kill unnecessary folder/readme [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172461 (owner: 10Jdlrobson) [00:52:33] (03PS1) 10Robmoen: Allow for null answer in response api. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172463 [00:56:51] (03CR) 10Kaldari: [C: 04-1] WIP: add wikidata descriptions... somewhere (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 (owner: 10MaxSem) [00:57:21] jdlrobson2: what time are we planning on leaving the office? [00:57:40] i saw the invite was for 6:30 [00:57:45] leaving then or be there by then ? [00:58:23] tfinc: 10-20 min bus, 5-10min taxi. We need to be there for 6.30 [00:58:28] 24 min walk [01:00:01] jdlrobson2: k, let me know what you guys decide. i'm stepping into an interview. [01:01:57] dbrant: bearND does your in-article search query return the thumb urls? [01:02:25] mhurd: checking... [01:03:39] mhurd: no, we do another request to get those (based on the titles) [01:04:04] mhurd: plus, another one for the wikidata descriptions [01:04:04] bearND: gotcha. i’ll poke around to see if the query can be modified to get ‘em [01:05:16] mhurd: strangely there exists a property called pageimage, but it only is a file name, not the full URL [01:06:03] (03CR) 10Jdlrobson: [C: 04-2] "The animation is off due to the icons being pngs and misaligned with their baseline. The purpose of moving to mw-ui-icon was to make our c" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172453 (https://bugzilla.wikimedia.org/73050) (owner: 10Bmansurov) [01:06:33] bearND: dbrant regarding the order of in-article search results, i’ve just added “list”, “pssearch”, and “pslimit” params from the prefix search query to the in-article query and confirmed it does give you back a second list w the correct order [01:06:42] (03CR) 10Jdlrobson: [C: 032] Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [01:06:48] (03CR) 10jenkins-bot: [V: 04-1] Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [01:07:59] mhurd: list=prefixsearch, right? [01:10:43] rmoen: Maybe something like $this->getResult()->addValue( 'query', $this->getModuleName(), 'success' ); [01:11:57] (03CR) 10Jdlrobson: "This needs a follow up patch.." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172425 (https://bugzilla.wikimedia.org/73058) (owner: 10Bmansurov) [01:15:28] 3MobileFrontend / 3Hygiene: Hygiene: Ajax loader on notifications icon should be a real Icon - 10https://bugzilla.wikimedia.org/73251 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon In notifications.js an Icon is created which has no name. An additionalClass loading is what renders the icon. Introduced in pa... [01:16:31] jdlrobson2: would adding a name be a solution ^? [01:16:52] bmansurov: yup [01:17:04] bmansurov: i can't keep up with you today :) [01:17:13] jdlrobson2: but there is mw-ui-icon class too [01:20:05] (03CR) 10Jdlrobson: "Yeh it seemed a little strange to me. Technically the languages list is not a next step in the process though. In search clicking the sear" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [01:20:25] 3MobileFrontend / 3Hygiene: Hygiene: Ajax loader on notifications icon should be a real Icon - 10https://bugzilla.wikimedia.org/73251#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/edxeE6B4 [01:21:16] (03PS1) 10Robmoen: ApiResponse: return success or die with error if logging fails [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 [01:21:27] hey bmansurov are you still trying to work out limn stuff? [01:21:32] (03CR) 10jenkins-bot: [V: 04-1] ApiResponse: return success or die with error if logging fails [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 (owner: 10Robmoen) [01:21:37] jdlrobson2: yeah if you can help [01:21:53] bmansurov: i've got a few things to do so was wondering if you could hold off till tomorrow morning and i'll help you then [01:21:57] i can't keep up with you :) [01:22:02] not tomorrow wednesday [01:22:04] (day off tomorrow :)) [01:22:10] ok sounds good to me [01:22:15] thanks [01:23:10] 3MobileFrontend / 3Hygiene: javascripts/desktop folder can be removed - 10https://bugzilla.wikimedia.org/73248#c2 (10Jon) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/172461 [01:24:39] 3MobileFrontend / 3General/Unknown: WikiGrokDialogB Response spinner needs design love - 10https://bugzilla.wikimedia.org/73249#c2 (10Jon) Loader should probably appear in content area and the button should probably disable but asking design to clarify. [01:26:11] (03CR) 10Kaldari: [C: 032] Allow for null answer in response api. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172463 (owner: 10Robmoen) [01:26:21] (03CR) 10Jdlrobson: [C: 032] Don't run eventLogging in QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172447 (https://bugzilla.wikimedia.org/73106) (owner: 10Bmansurov) [01:26:27] (03Merged) 10jenkins-bot: Allow for null answer in response api. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172463 (owner: 10Robmoen) [01:27:02] (03Merged) 10jenkins-bot: Don't run eventLogging in QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172447 (https://bugzilla.wikimedia.org/73106) (owner: 10Bmansurov) [01:29:14] bearND: sorry afk. ya it’s prefixsearch: https://gerrit.wikimedia.org/r/#/c/158011/2/javascripts/modules/search/SearchApi.js [01:30:08] (03CR) 10MaxSem: [C: 032] Revert "Revert "Respect existing X-Analytics header, if set"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171891 (owner: 10Ori.livneh) [01:30:49] (03Merged) 10jenkins-bot: Revert "Revert "Respect existing X-Analytics header, if set"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171891 (owner: 10Ori.livneh) [01:32:28] bearND: i was able to get it to return thumb image urls in same query as well [01:32:42] (03PS8) 10Jdlrobson: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 [01:32:56] mhurd: awesome. [01:32:59] (03CR) 10Jdlrobson: Separate the entry point modules (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [01:33:08] bearND: making an etherpad to show u [01:33:36] mhurd: probably prop=pageimages? [01:34:12] 3MobileFrontend / 3Hygiene: Running QUnit is logging events - 10https://bugzilla.wikimedia.org/73106 (10Jon) 5PATC>3RESO/FIX [01:34:13] bearND: yes prop=pageprops|pageimages [01:37:21] bearND: https://etherpad.wikimedia.org/p/in_article_search_query [01:46:09] (03PS1) 10Kaldari: Correcting WikiGrok init function description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172473 [01:46:16] kaity: you are sick? [01:46:28] jdlrobson2: yea [01:46:35] so no karaoke for you either? [01:46:39] jdlrobson2: sorry I can't make it to sushi [01:46:44] i've literally just had 6 people tell me 30 mins before. :-S [01:46:58] jdlrobson2: Sorry about that :( [01:50:22] (03CR) 10Kaldari: [C: 04-1] Conform to the MobileWebWikiGrok schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 (owner: 10Bmansurov) [01:52:02] (03PS2) 10Jdlrobson: Docs: Correcting WikiGrok init function description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172473 (owner: 10Kaldari) [01:52:06] (03CR) 10Kaldari: Conform to the MobileWebWikiGrok schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 (owner: 10Bmansurov) [01:52:08] (03CR) 10Jdlrobson: [C: 032] Docs: Correcting WikiGrok init function description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172473 (owner: 10Kaldari) [01:52:48] (03Merged) 10jenkins-bot: Docs: Correcting WikiGrok init function description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172473 (owner: 10Kaldari) [01:55:06] bearND: hmm my query may not be quite right... [01:58:57] bearND: specifically the "list=prefixsearch" is giving the in-order prefix search titles (rather unsuprisingly haha) [01:59:03] (03CR) 10Kaldari: [C: 032] Remove old opt-out code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172415 (owner: 10Bmansurov) [01:59:09] (03CR) 10Bmansurov: Conform to the MobileWebWikiGrok schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 (owner: 10Bmansurov) [01:59:41] (03Merged) 10jenkins-bot: Remove old opt-out code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172415 (owner: 10Bmansurov) [02:08:06] bearND: max gave me some tips… will update the etherpad if i get it figured out in the next few minutes [02:08:07] mhurd: what was wrong with the query? I didn't quite follow [02:10:37] bearND: the in-article search needs the ordered list from “search” not “prefixsearch” [02:10:37] mhurd: ah [02:10:37] bearND: “list=search” has different parameters though… i changed them but goofed something… fixing now - or trying to :) [02:26:14] bearND: i think i got it! updating the etherpad... [02:30:04] bearND: ok the etherpad should be updated. it seems to work, but we’ll probably want to confirm with max that it’s ok later [02:32:54] mhurd: great work! Make sure you send a link to the etherpad around, so dbrant will get it, too [02:33:04] bearND: will do! [02:33:16] Better search! \o/ [02:33:22] Thanks guys. :) [03:28:41] bearND: i think i've got it [03:28:57] dbrant: got what? [03:29:07] bearND: why the items aren't clickable [03:29:16] dbrant: ah, great! [03:29:24] bearND: you'll kick yourself, though :) [03:29:42] dbrant: ok, getting ready to kick myself [03:29:45] ;) [03:30:06] bearND: DisambigListAdapter.java : 159 [03:30:39] aaaaaaaarrrrggg [03:31:01] lol, good one, oh my [03:31:03] :P [04:26:21] (03PS1) 10BearND: Page info dialog header click feedback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172479 [04:27:28] (03Abandoned) 10BearND: Make disambig item clicks open linked page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172426 (owner: 10BearND) [05:11:13] (03PS2) 10BearND: Page info dialog header click feedback + clickable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172479 [05:11:50] (03PS7) 10BearND: Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 [05:12:11] (03PS5) 10BearND: Slide up/down animations for BottomDialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171725 [05:12:18] (03PS5) 10BearND: Left/right animation inside page info dialog [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171875 [05:12:25] (03PS5) 10BearND: Disambig items have thumbnail, title, and Wikidata description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 [05:12:36] (03PS3) 10BearND: Page info dialog header click feedback + clickable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172479 [05:42:27] (03PS14) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [05:43:35] (03CR) 10Deskana: "Rebased." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [06:03:45] (03PS1) 10BearND: Faster up/down animations for bottom dialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172496 [06:13:40] (03PS1) 10Deskana: Improve documentation for main-menu-account-logout message. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172497 (https://bugzilla.wikimedia.org/71225) [06:26:06] yo [06:29:23] it's 6:30 am so i'm going to watch the new robocop movie [08:45:48] (03CR) 10Florianschmidtwelzow: "Hmm, interesting, thanks for the link bmansurov. I'm not sure, what the best is, but you're right, three progressive buttons maybe aren't " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [09:19:30] phuedx: morning [09:19:48] morning joakino [09:20:00] gonna get ready for work [09:20:20] :D [09:35:57] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255 (10pamdavies7) 3UNCO p:3Unprio s:3normal a:3None A change in the last short time, perhaps couple of weeks, means that when I go into edit mode I cannot scroll down the page - so my editing is restricted to cha... [09:40:26] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mkVQaFJO [09:50:10] * phuedx is ready for work and has finished watching the new robocop movie [09:55:59] phuedx: did you like it? [09:56:08] it was ok [09:56:34] it had a message [09:57:13] best put forward by samuel l jackson's zealot character [09:57:31] i saw it some time ago [09:57:42] phuedx: have you seen interstellar? [09:57:44] i'd have liked it if it spent more time on the relationship between the machine and the man [09:57:51] joakino: do you have children? [09:57:53] yeah [09:57:57] phuedx: nop [09:58:14] not yet [09:58:16] why? [09:58:25] :) [09:58:49] i haven't been to a cinema in about 2.5 years :) [09:59:30] on the other hand i'm getting quite good at brewing and tasting coffee [09:59:35] so, y'know, trade offs [10:00:04] oh yeah haha [10:00:19] nobody to babysit at night? [10:01:27] i don't think we've ever had a babysitter [10:01:46] i guess lisa and i are happy to not go out [10:02:01] cool then [10:02:02] you can definitely go out when you have children, but we prefer to cuddle up with him [10:02:12] awesome :D [10:02:23] this is all by the by [10:02:30] i'd really like to see interstellar ;) [10:02:45] i'll come up on bluray rip soon enough, don't worry haha [10:13:22] (03PS7) 10Phuedx: WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 [10:13:36] (03CR) 10Phuedx: WikiGrok A/B test dry run (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [10:13:49] more code review!!! [10:16:12] i'm with tests [10:16:39] ? [10:49:25] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255#c2 (10Andre Klapper) On which page(s)? On which device(s)? Steps to reproduce welcome. :) [11:08:05] (03CR) 10Phuedx: [C: 04-1] "Please add a test case for this change." (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 (owner: 10Robmoen) [11:35:28] (03PS4) 10Phuedx: Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [11:43:36] (03CR) 10Phuedx: "PS4 is a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [11:55:37] (03CR) 10Phuedx: [C: 032] Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [11:56:16] (03Merged) 10jenkins-bot: Instrument search, hamburger and notification clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172353 (owner: 10Bmansurov) [13:02:32] hey phuedx [13:03:01] what's WMF reqs [13:33:33] (03CR) 10Jhernandez: [C: 032] Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [13:34:11] (03Merged) 10jenkins-bot: Separate the entry point modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171171 (owner: 10Jdlrobson) [14:58:08] sorry joakino_, i didn't say i was out to lunch earlier [14:58:13] wmf reqs? [15:00:20] (03CR) 10Phuedx: [C: 032] Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 (owner: 10MaxSem) [15:00:41] (03Merged) 10jenkins-bot: Debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171453 (owner: 10MaxSem) [15:02:32] i went out and got a burger [15:02:34] nom nom nom [15:23:56] (03PS1) 10Phuedx: Open up the WikiGrok A/B to alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172551 [15:26:57] joakino_: you working on https://trello.com/c/z9ihM4XZ/1-spike-4-hours-what-are-some-cheap-suggestions-we-could-use-in-wikigrok? [15:27:46] phuedx: no [15:27:50] oh [15:27:51] what am I doing there [15:27:55] not sure [15:28:03] lol [15:28:04] also, wmf reqs? [15:28:41] ye talking to tomasz he said that all the info about all hands was in the email of wmfreqs but im not subscribed to that mailing list, I didn't even know that it existed [15:29:38] phuedx: I don't know why I was in that card, at that time I was having lunch :S, i've just left it [16:27:31] (03PS1) 10Florianschmidtwelzow: Move progress-bar.js to modules/uploads/ProgressBar.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172560 (https://bugzilla.wikimedia.org/73247) [16:38:24] 3MobileFrontend / 3stable: Long gallery captions break viewport - 10https://bugzilla.wikimedia.org/73183#c2 (10Florian) Hmm, this seems to be a problem of https://en.wikipedia.org/w/index.php?title=Template:Multiple_image :/ We could force a max-witdh, but i think the best would be to change the "width" inli... [16:48:53] (03CR) 10Phuedx: [C: 032] Move progress-bar.js to modules/uploads/ProgressBar.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172560 (https://bugzilla.wikimedia.org/73247) (owner: 10Florianschmidtwelzow) [16:49:35] (03Merged) 10jenkins-bot: Move progress-bar.js to modules/uploads/ProgressBar.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172560 (https://bugzilla.wikimedia.org/73247) (owner: 10Florianschmidtwelzow) [16:59:41] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255#c3 (10pamdavies7) Device: Samsung Galaxy Fame smartphone Pages: Any, as far as I can see Steps to reproduce: 1:View article, such as "Streatham Street" Screen layout,from top, is: - My phone's top bar with time, bat... [17:01:56] (03PS1) 10Jhernandez: Fix jscs errors on MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172568 [17:01:57] (03PS1) 10Jhernandez: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 [17:02:44] (03CR) 10jenkins-bot: [V: 04-1] Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [17:10:42] (03PS2) 10Jhernandez: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 [17:15:58] (03PS1) 10Jhernandez: Add QUNIT_MODULE filter for grunt qunit command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172573 [17:18:41] (03CR) 10Jhernandez: [C: 032] "I need to merge this ASAP, master has jscs errors" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172568 (owner: 10Jhernandez) [17:19:19] (03Merged) 10jenkins-bot: Fix jscs errors on MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172568 (owner: 10Jhernandez) [17:20:20] joakino_: was that a self +2? [17:20:41] phuedx: yep, baha introduced jscs errors in master, couldnt commit [17:20:50] just changed indentation of 15 lines [17:21:25] phuedx: sorry? :( [17:28:37] i get that it was a problem for you, but i'm here [17:29:33] the change looks fine [17:29:53] in fact, i merged the change that broke yer tooling [17:30:12] phuedx: sorry wont do it again [17:30:25] i read the diff wrong and assumed he was correcting the indentation [17:30:44] hehe its happened a couple of times, thats why jon wants to push the jenkins grunt stuff [17:31:24] cool, wellp [17:31:30] shout out if you need a pair of eyes [17:31:38] ok? [17:31:38] i will! [17:31:41] ok [17:32:02] hey jdlrobson2 [17:32:10] get back on holiday!? [17:32:15] hey. i am :P [17:32:28] he missed us [17:32:47] was the pull too strong? [17:33:14] i did bait the hook a little with the code review email [17:33:30] phuedx: joakino_ i'm in the coffee shop waiting for my laundry to be done [17:33:38] haha [17:33:45] you do your laundry in a coffee shop? [17:33:47] #usaproblems [17:33:52] phuedx: i wissssh [17:33:56] phuedx: there is actually one of those in soma [17:34:00] HAHA [17:34:03] my coffee shop is next door too the laundry [17:34:04] #usasolutions [17:34:22] http://www.brainwash.com/ < phuedx [17:34:24] best name ever too [17:34:34] o [17:34:36] m [17:34:37] g [17:34:43] also http://www.yelp.com/biz/sit-and-spin-san-francisco [17:35:09] i always thought i'd meet the love of my life in a launderette but it is yet to happen. [17:35:28] too many movies [17:35:44] yeh, i mix up my hours, hoping one day she'll be there [17:35:50] and we'll notice we have the same detergent [17:35:58] and we'll talk about how it's because we have sensitive skin [17:35:59] hahah [17:36:08] and then she'll need to borrow one of my quarters [17:36:36] http://en.wikipedia.org/wiki/40_Days_and_40_Nights [17:36:38] and then next thing you know we'll be next door in the coffee shop drinking coffee [17:36:42] but it never happens [17:36:43] it's a vicious cycle. [17:37:04] lolbye [17:37:20] instead, you join an irc channel and start talking to people 8+ hours away [17:37:22] wait [17:37:25] wait... [17:37:26] "On the 40th day, a newly single Nicole learns of the betting pool, makes a large bet and then rapes Matt while he is asleep." [17:37:29] wtf is this movie?!! [17:37:43] haha you haven't seen it? [17:37:44] wtf!? [17:37:49] i don't remember that part [17:37:50] lol thats the end xD [17:38:23] man rape [17:38:30] i haven't seen this movie [17:38:37] it was filmed in sf hey? [17:39:03] i think so [17:39:54] so i thought you 2 were taking the day off too? [17:40:07] nosir [17:40:09] :? [17:40:12] 3MobileFrontend / 3Hygiene: Rename progress-bar.js and put in uploads directory - 10https://bugzilla.wikimedia.org/73247 (10Florian) 5PATC>3RESO/FIX [17:40:16] we've been working [17:40:21] shame. [17:40:25] i said exactly the opposite in the meeting [17:40:27] i think we're done with the backlog [17:40:31] yerrrp [17:40:33] done [17:40:34] joakino_: i thought i had misunderstood you ;-) [17:40:44] maybe everyone did lol [17:40:51] hah [17:40:55] phuedx: yeh baha did most of the work yesterday. [17:40:58] he was like a machine [17:41:12] unstoppable [17:41:33] i think baha has been sent from the future to save wikipedia and stop skynet or something [17:41:37] maybe wikipedia is skynet [17:41:41] no [17:41:42] that's google [17:41:50] ahh so we're the good guys? [17:41:55] absolument [17:42:07] haha [17:42:19] hey [17:42:20] i need to work out my hours next week but i want to be more you-guys time [17:42:26] aww [17:42:29] shucks [17:42:32] * phuedx blushes [17:43:14] having said that [17:43:20] jdlrobson: which time zone will you be in? [17:43:22] gmt/gmt + 1 is party central [17:43:51] flakey wifi :/ [17:44:16] 5:42:20 PM i need to work out my hours next week but i want to be more you-guys time [17:44:16] 5:42:26 PM aww [17:44:16] 5:42:29 PM shucks [17:44:16] 5:42:32 PM — phuedx blushes [17:44:16] 5:43:14 PM having said that [17:44:17] 5:43:20 PM jdlrobson: which time zone will you be in? [17:44:17] 5:43:22 PM gmt/gmt + 1 is party central [17:44:58] joakino_: gmt+8 [17:45:04] and through a uk vpn [17:45:09] (yey china and https) [17:45:16] yowza [17:45:20] will see how that works xd [17:45:28] only for a week mind you [17:45:42] i'm taking the week off for thanksgiving [17:49:04] ok [17:50:00] lisa's phoning the hospital – i may disappear suddenly [17:50:09] ok [17:59:20] Hoping to work your hours, Wed, Thur, Fri next week (12-1500) @joakino_ @phuedx [17:59:27] yowza [17:59:32] you're going to be alive after that? [17:59:35] awesome [17:59:42] joakino_: speaking of markdown: https://stackedit.io [17:59:49] http://www.timeanddate.com/worldclock/meetingtime.html?iso=20141115&p1=470&p2=141 [18:01:06] phuedx: looks very good, is it free? [18:01:20] i'm trying it out right now [18:01:24] just click edit [18:01:30] sorry [18:01:33] "Start writing" [18:01:35] yeah im on it [18:01:35] at the top of the page [18:02:10] i'm too attached to vim to edit text in anything else [18:03:31] vim4lyf [18:04:04] for phpstorm, there's a nice vim plugin [18:04:56] YuviPanda: the best vim clone is emacs, unfortunately [18:05:09] i'm curious what you guys think about neovim? [18:05:42] i'm skeptic, but welcome the effort [18:05:47] i am a recovering user of vim [18:06:03] but sometimes i miss it so much [18:06:28] jdlrobson2: yeah, evil mode is something. [18:06:31] err [18:06:31] ლ(ಠ益ಠ)ლ [18:06:32] joakino_: [18:06:41] haha [18:06:44] I used it for a while, but then went back to vim [18:06:49] phuedx: what do you use now [18:06:55] i did emacs for a few monts [18:06:57] months [18:07:05] * YuviPanda uses pycharm for python stuff, phpstorm for php [18:07:08] all with vim plugins [18:07:15] ;-) [18:07:21] YuviPanda: will you ever move to sf btw? [18:07:23] sec [18:07:28] jdlrobson2: april :) [18:07:38] i use atom [18:07:40] at the moment [18:07:47] YuviPanda: pfft i've never known this take someone so long ;-) [18:07:48] phuedx: I tried it, is still too slow for me [18:07:57] jdlrobson2: :D I could move now, but I have stuff here happening... [18:07:57] phuedx: wasn't it slow and memory hungry? [18:08:01] jdlrobson2: end march / april [18:08:12] joakino_: yeah, I still find it slow [18:08:38] i have a friend using it too from sublime, he says it is pretty good now [18:09:08] i never found speed to be an issue [18:09:12] memory hungry? [18:09:36] aha [18:09:41] i have 8 gigs of ram [18:09:51] not a problem xd [18:09:52] I sent patches to their autosave plugin months ago [18:09:54] no repsonse yet [18:10:02] that's more than my tower at the moment (a dimm died recently) [18:10:46] i just... memory? is that a thing we care about any more? ;) [18:10:58] * phuedx goes back to packing structs [18:11:04] hehe [18:11:09] phuedx: It still is slow for me, tho9 [18:11:17] admin.yaml in puppet repo always froze it [18:11:26] phuedx: YuviPanda codes at the speed of light [18:11:35] i have seen YuviPanda type [18:11:42] but admin.yaml freezes vim too sometime [18:11:42] i'm amazed the processor keeps up [18:11:52] or the chip in the keyboard [18:11:55] or his fingers [18:11:56] * YuviPanda sees his legs grow longer at being pulled heavily [18:12:23] i've opened a 100mb txt and didnt freeze vim, it may be because of the syntax [18:12:27] YuviPanda: you still have to type? [18:12:34] i thought you just thought the code these days [18:12:53] joakino_: yeah, I bet it's the yaml syntax thing freezing it [18:13:06] joakino_: also the admin.yaml file has lots of ssh pubkeys, so that also has an effect, I think [18:13:29] YuviPanda typing: http://www.youtube.com/watch?v=PkyZGZRnQb4 [18:13:37] YuviPanda: try this [18:13:41] " Don't try to highlight lines longer than 800 characters. [18:13:41] set synmaxcol=800 [18:13:45] ooooooh [18:13:47] that's nice [18:13:49] for example [18:14:20] * phuedx runs away from the magical vim incantations [18:14:28] phuedx: come back xd [18:14:36]