[01:58:48] (03CR) 10Dbrant: [C: 032] Disambiguation and page issues dialog on bottom [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171512 (owner: 10BearND) [02:01:30] (03CR) 10Dbrant: [C: 032] Slide up/down animations for BottomDialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171725 (owner: 10BearND) [02:04:41] (03CR) 10Dbrant: [C: 032] Left/right animation inside page info dialog [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171875 (owner: 10BearND) [02:18:28] (03CR) 10Dbrant: [C: 032] Disambig items have thumbnail, title, and Wikidata description [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171876 (owner: 10BearND) [02:20:50] I'm looking to augment a series of field guides to flora and fauna. Each page in the field guides describes some species, and textually describes the range where the specie may be found. For this to be more useful, I would like for the users to be able to select a region of the world and get a list of pages (or better, a page which transcludes the relevant pages) for that region. I was thinking the geodata extension migh [02:20:50] tag each page to cover regions. Some regions are small, some are large, and none are circular. Most pages would need multiple coordinate tags. For ease of content creation, perhaps each page could transclude a template naming a region, and that template could add the tags? Or maybe there is a better way? [02:23:11] Also, does GeoData sound like the right tool for this job? [02:24:05] (03CR) 10Dbrant: [C: 032] Page info dialog header click feedback + clickable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172479 (owner: 10BearND) [02:24:45] (03PS7) 10Dbrant: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [02:53:32] (03CR) 10Dbrant: [C: 04-1] Drag some Wikipedia domain stuff into the Site class (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [02:59:09] (03CR) 10Dbrant: [C: 032] Faster up/down animations for bottom dialogs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172496 (owner: 10BearND) [03:17:24] (03CR) 10Dbrant: [C: 04-1] "A couple notes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172454 (owner: 10Deskana) [03:23:26] (03PS9) 10Dbrant: Face detection in lead image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168773 [03:23:45] (03PS14) 10Dbrant: Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [03:24:21] (03PS3) 10Dbrant: Remove pinch-zoom in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171850 [03:25:16] (03PS14) 10Dbrant: Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [06:37:33] (03CR) 10BearND: [C: 04-1] "The white background seems a bit jarring in dark mode." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [06:39:44] (03CR) 10BearND: [C: 032] Remove pinch-zoom in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171850 (owner: 10Dbrant) [06:41:27] (03Merged) 10jenkins-bot: Remove pinch-zoom in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/171850 (owner: 10Dbrant) [06:43:12] (03CR) 10BearND: [C: 04-1] "In dark mode there is hardly a difference between templates and other text." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 (owner: 10Dbrant) [07:25:58] 3Wikipedia App / 3General/Unknown: Disable translations to wuu and lzh? - 10https://bugzilla.wikimedia.org/73295 (10Nemo) 3NEW p:3Unprio s:3normal a:3None A translator asks if translations to Literary Chinese and wuu can be disabled, since the locales are not available on phones (according to the use... [07:46:39] (03PS8) 10Alex Monk: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 [09:27:53] yo [09:30:23] phuedx: hi! [09:30:28] how did it go? [09:47:21] fine [09:47:28] nothing doing, unfortunately [09:47:30] ^ joakino [09:47:36] sorry, was making breakfast [09:47:42] i don't usually eat breakfast, but when i do [09:47:50] phuedx: pity [09:47:59] yeah :( [09:48:02] bon appetite [09:48:36] eggs and fish [09:48:40] gotta love dem eggs and fish [09:48:53] brb [09:49:21] back [09:52:30] * phuedx is watching the last quarter of the phabricator thingemy [09:55:20] nom nom nom nom nom [09:56:20] joakino: what're you working on? [09:57:25] right now i'm with emails and administrative stuff [09:57:35] phuedx: nothing in particular [09:57:44] okie poke [09:57:49] was just looking at the backlog [10:02:53] phuedx: i ended up yesterday fighting with the ios bug [10:03:05] phuedx: i'm going to try a bit more, but i'm about to give up... [10:03:30] the scrolling thing? [10:03:31] then i'll go code review and find something else to work on [10:03:34] yes [10:10:10] i think all of the code review is either blocked on external reviewers or awaiting work [10:10:20] people should take fewer holidays [10:13:00] i am full of eggs and fish [10:15:20] phuedx: fish for breakfast [10:15:22] haha [10:15:28] awesome [10:15:43] smoked mackerel and scrambled eggs [10:15:51] a little salt and pepper [10:15:52] boom [10:15:57] protein bomb [10:16:07] 👍 [10:16:18] i'm going bouldering at lunch, so the protein may help [10:16:25] although i should probably eat it /afterwards/ [10:17:54] well this good breakfast its going to keep hunger away for a good while, just eat some carbs later for extra energy [10:18:05] very cool [10:18:31] i think i'm going to bike a bit later, it is sunny today [10:18:54] if you ever visit london, i'll take you to the bouldering centre 10 minutes away from my house [10:21:02] phuedx: 👍 awesome plan [11:17:55] 3MobileFrontend / 3Feature requests: Indicators are not shown in mobile view - 10https://bugzilla.wikimedia.org/73299#c1 (10Bartosz Dziewoński) Yeah, MobileFrontend's Minerva skin needs to have support for them added (assuming that it is wanted, I'm not sure if it currently displays FA icons and the like). I... [11:20:25] 3MobileFrontend / 3Feature requests: Indicators are not shown in mobile view - 10https://bugzilla.wikimedia.org/73299#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/gb3kNPJJ [11:40:50] phuedx: phuedx/fiveMinuteAbs lol wtf [11:41:08] if your branch names don't contain jokes [11:41:11] you're doing something wrong [11:42:35] phuedx: damn it [11:42:46] haha [11:43:03] phuedx: i've been reviewing taht [11:43:18] cool design, and very clean code, too big of a commit in my opinion [11:44:01] but with small commits rebasing is a nightmare... so, bleh [11:44:50] phuedx: i'm running vagrant git-update to get the mediawiki cookie thingy [11:45:46] joakino: maybe wikigrokuser.js could've been broken out [11:45:48] phuedx: add a card into the developer backlog to migrate all $.cookie, it is better your way [11:46:13] you should take a look at the review history of mediawiki.cookie ;) [11:46:20] it took a while [11:46:23] but it's better for it [11:46:35] link? [11:48:19] phuedx: it is just that I like reviewing smaller commits, so you see with the commit messages and the small code changes the intentions of the author and it is easier to follow (when there is a big wall of code it is harder to keep focus) [11:48:27] phuedx: maybe i'm just getting old [11:49:01] joakino: smaller things are easier to reason about [11:49:14] that's how i say it [11:49:24] commits, teams, systems, classes, methods [11:49:28] books [11:49:30] paragraphs [11:49:33] premises [11:49:37] pick your poison [11:49:43] yep [11:49:52] maybe i could've broken out wikigrokuser [11:50:00] that patch is large because i like unit tests ;) [11:50:05] sure [11:50:34] what i'm saying is: i agree with you, i'll break it up next time around [11:50:49] *i'll try harder to break it up next time around* i meant [11:51:34] that's why I prefer branches with lots of small commits, review and code with as many small commits as you want, and later merge rebasing into master a big commit with a meaningful message extracted out of all the small commits [11:52:09] phuedx: the problem is that gerrit makes it pretty hard to do that flow, and it bothers you less when you work with big commits [11:52:18] that's why I don't like gerrit xd [11:52:26] sure, it makes it harder to do the last part of that flow [11:53:14] anyway rant over [11:53:30] phuedx: your change is good, I'm not sure also of how I would have split it [11:53:41] 👍 [11:53:51] there's a follow-up change that /should/ be done [11:54:10] which is related to my comment about there being two things responsible for choosing which version of wikigrok to load [11:54:25] that can be broken out later [11:55:15] meaning what, the abtest and the user? [11:57:42] (03CR) 10Jhernandez: WikiGrok A/B test dry run (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [11:58:22] there's something that sits between wikigrok.js and wikigrokuser/abtest [11:58:53] phuedx: do you want me to wait for somebody else? i think it is ready for +2 [11:59:14] i'd like jdlrobson (at least) to get back to me about mw.cookie [11:59:23] phuedx: yes we should leave wikigrok.js as empty of logic as possible, and add tests to what we refactor [11:59:23] just so everyone's on the same page [11:59:26] oki, then +2 [11:59:30] sorry, +1 [11:59:33] :) [11:59:35] cool.io [12:00:30] (03CR) 10Jhernandez: [C: 031] WikiGrok A/B test dry run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171630 (owner: 10Phuedx) [12:15:43] gonna go for a boulder [12:15:58] enjoy!1 [12:24:00] (03CR) 10Jhernandez: [C: 04-1] Open up the WikiGrok A/B to alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172551 (owner: 10Phuedx) [13:32:51] Florianschmidtwelzow you here? [14:03:48] (03PS15) 10Dbrant: Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [14:30:04] (03PS2) 10Phuedx: Open WikiGrok A/B test to all users on alpha/beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172551 [14:34:35] i'm out for lunch [14:49:40] (03PS1) 10Dbrant: [WIP] Final styling tweaks for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 [14:49:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Final styling tweaks for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 (owner: 10Dbrant) [14:56:26] (03PS2) 10Dbrant: [WIP] Final styling tweaks for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 [14:57:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Final styling tweaks for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 (owner: 10Dbrant) [15:05:17] (03PS1) 10Phuedx: Hygiene: Use spinner template instead of Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [15:05:19] (03PS1) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 [15:06:10] 3Wikipedia App / 3General/Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - 10https://bugzilla.wikimedia.org/68579#c7 (10Andre Klapper) 5PATC>3NEW Resetting bug report status from PATCH_TO_REVIEW to NEW as there are no patches left to review. [15:06:51] coffee time! [15:33:43] (03PS15) 10Dbrant: Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [15:37:03] (03PS16) 10Dbrant: Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [16:03:58] dbrant: are you around ? [16:04:11] matanya: yep [16:04:39] hello, i would to to report that with the new alpha, the page mostly times out after a saved edit [16:05:03] i.e i edit a page, get the message the page was saved, and never get back to the article [16:05:40] dbrant: furthermore i would like to thank you for the cover picture for the article, it is very nice. [16:05:53] but on the other hand argue for it's need [16:06:57] it draws more bandwith with very little info added [16:06:57] so i would prefer it to be an option for the user to choose wheather he wants it on or off [16:08:16] dbrant: if you wish me to open a bug report for this, i can [16:08:23] matanya: thanks! True, the "need" of the cover picture may be more aesthetic than practical, but we're simply trying to bring the app into 2014, instead of 2004. [16:09:23] matanya: hmm, i'll surely look into the editing issue! I've reproduced it just now. [16:10:01] dbrant: ok thanks, if you need anything from me, do poke me [16:34:27] 3Wikipedia App / 3MobileApp extension: 12.11.14 alpha times out after saving an edit - 10https://bugzilla.wikimedia.org/73314 (10matanya) 3NEW p:3Unprio s:3normal a:3None how to reproduce: 1. use the alpha from the subject 2. edit a page and save. 3. you get a message your edit was saved, but you... [16:39:12] 3Wikipedia App / 3Android App: allow user to configure if he wants cover images in the app - 10https://bugzilla.wikimedia.org/73315 (10matanya) 3NEW p:3Unprio s:3enhanc a:3None The new alpha recently add a cover image to articles, which is a very nice feature in terms ofveye kandy. However, this lea... [16:39:40] 3Wikipedia App / 3Android App: 12.11.14 alpha times out after saving an edit - 10https://bugzilla.wikimedia.org/73314 (10Dmitry Brant) [16:49:54] (03CR) 10BearND: [C: 032] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [16:50:39] bearND: thx! note that there's also a patch in MobileApp that corresponds to this. [16:50:55] dbrant: ah, thanks for the heads-up [16:51:39] (03Merged) 10jenkins-bot: Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [17:41:41] hey joakino phuedx! [17:41:51] yo [17:42:22] heads up, i'm thinking a good focus for kitty grooming that we should start with is getting our tools in order e.g. the grunt file, jsbeautify, publishing stuff. Any objections to focusing on tasks around that to start with? [17:43:59] publishing stuff like docs? [17:44:04] or publishing stuff like code metrics? [17:44:07] or both? (!!!) [17:44:19] both :) [17:44:23] \o/ [17:44:27] absopositively [17:44:36] phuedx: obviously depending on how 'big' we think things are [17:44:40] and what's achievable [17:44:44] obvs [17:44:56] so i was thinking we could focus discussion around that tomorrow and get some units of work identified and estimated [17:44:59] (03PS3) 10Dbrant: Final styling tweaks/fixes for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 [17:45:06] i love that you say units of work [17:45:10] suresies [17:45:11] :P [17:45:29] So yeh if you think of any more wild crazy ideas around tools that we should add please add 'em to the trello board [17:45:53] (03CR) 10jenkins-bot: [V: 04-1] Final styling tweaks/fixes for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 (owner: 10Dbrant) [17:45:54] do we have code coverage tools for php? [17:46:02] phuedx: i believe there are some in phpunit [17:46:03] i've written a card, but i'm curious what's already there [17:46:05] in core [17:46:09] ok [17:46:10] i don't know where they go though [17:46:14] i'll take a look and flesh the card out [17:46:29] don't want to us to commit to something that's essentially undefined [17:47:11] spike! [17:47:13] spike! [17:47:14] spike! [17:47:37] phuedx: https://integration.wikimedia.org/cover/mediawiki-core/master/php/index.html [17:47:39] this exists [17:47:47] (also lolz) [17:47:56] awesome [17:47:57] and :'( [17:48:28] bmansurov: did you take yesterday off? [17:48:38] or did you work with these crazy cats? [17:49:00] jdlrobson: i chilled yesterday [17:49:15] bmansurov: cool :) [17:49:17] jdlrobson: icon sizes: everything in ems, right? [17:49:47] (this is always where i get things in a muddle) [17:50:02] i think that, as a team, we should commit to less chilling [17:50:04] more work [17:50:04] jdlrobson: phuedx wow those metrics are sad [17:50:14] phuedx: correct. although in the future there will be two icon sizes - indicators (16px) and icons (24px) so we shouldn't have to worry about icon sizes [17:50:21] at least that's where TrevorP|Away is trying to get us [17:50:54] phuedx: let's get to the point we don't have to even think about how icons exist :) [17:50:57] we just add them to things [17:51:10] that'd be nice, wouldn't it? [17:51:43] phuedx: on https://gerrit.wikimedia.org/r/#/c/172743/ should we just replace the spinner with an icon? [17:51:47] after all it is an icon... [17:52:25] jdlrobson: sure after we use the spinner consistently, and manipulate it consistently [17:52:31] ;) [17:52:32] (03PS4) 10Dbrant: Final styling tweaks/fixes for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 [17:52:36] phuedx: that would be nice. :) [17:52:59] joakino: I was also thinking about maybe creating some kind of AsyncView which handles View's which have to make api requests to get data to render. [17:53:01] i'll push a follow-on patch to replace the spinner with an icon [17:53:06] i'm not good at naming stuff though [17:53:36] jdlrobson: meaning one that would automatically show and hide the spinner? [17:54:26] (03CR) 10Jdlrobson: [C: 04-1] "Please also update the category button to be neutral as well. They look strange together in alpha." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [17:54:48] (03PS3) 10Jdlrobson: Proposal: Merge CtaDrawer with EditorOverlay Anonwarning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:00:24] (03PS2) 10Bmansurov: Conform to the MobileWebWikiGrok schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 [18:00:37] (03CR) 10Jdlrobson: [C: 04-1] Proposal: Merge CtaDrawer with EditorOverlay Anonwarning (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:10:56] 3Wikipedia App / 3Android App: Android app: Changing to night mode while searching cancels the search - 10https://bugzilla.wikimedia.org/72604#c1 (10Bernd Sitzmann) 5NEW>3RESO/FIX The menu to change themes is not available anymore from search. So one cannot get into this situation anymore. [18:17:00] (03CR) 10Jdlrobson: Proposal: Merge CtaDrawer with EditorOverlay Anonwarning (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:17:09] (03PS4) 10Jdlrobson: Merge CtaDrawer with EditorOverlay Anonwarning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:17:20] (03PS5) 10Jdlrobson: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:18:02] * phuedx goes back to eating his sammich [18:18:52] om nom [18:20:37] chicken, bacon, lettuce, tomato, mayo, tobasco sauce [18:20:40] i am so happy [18:24:23] (03PS3) 10Jdlrobson: Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 [18:24:32] (03CR) 10Bmansurov: "Isn't category button also updated already?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [18:24:34] (03PS3) 10Jdlrobson: Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 [18:24:37] DarTar: Where do you have the WikGrok A/B test stuff written up? [18:24:53] (03CR) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:25:02] (03CR) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [18:25:06] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [18:25:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 (owner: 10Jdlrobson) [18:26:05] jdlrobson: can you check this again? I think the category button is already updated: https://gerrit.wikimedia.org/r/#/c/172408/ [18:27:17] (03CR) 10Florianschmidtwelzow: "@bamnsurov: i think so, but haven't tested." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172408 (owner: 10Bmansurov) [18:27:40] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255#c5 (10Jhernandez) Can't reproduce with Android 4 and neither Chrome nor Firefox. Please can you tell us which android version has your phone? Also which browser are you using? If you don't know how to get that info... [18:28:56] jdlrobson: let me know when we can chat about limn. thanks [18:29:14] bmansurov: sure [18:32:15] limn chats! [18:32:18] (03CR) 10Jdlrobson: [C: 04-1] Add tests to WikiGrokDialogB (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [18:32:29] bmansurov, jdlrobson: i'd really appreciate any notes you guys make being published somewhere [18:32:41] no swearing, obvs ;) [18:32:42] what is limn [18:32:51] joakino: don't open pandora's box ;-_ [18:32:53] phuedx: ok, i'll take some notes and share [18:33:05] mobile-reportcard.wmflabs.org is the output [18:33:10] ^ joakino [18:33:30] bmansurov: awesome [18:33:33] okay bmansurov let me get you up and running. Do you want to me to grab a room and hangout? [18:33:39] :D [18:33:41] jdlrobson: sure [18:33:56] let me see if i can find one [18:33:58] maryana bmansurov jdlrobson phuedx joakino maxsem rmoen kaldari [18:34:03] Bug triage? [18:34:09] joakino: This page has some useful documentation (although it is specifically about the EE dashboard, not the mobile dashboard): https://wikitech.wikimedia.org/wiki/EE_Dashboard [18:34:10] (03CR) 10BearND: [C: 032] Final styling tweaks/fixes for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 (owner: 10Dbrant) [18:34:14] oh yeh bmansurov let's do bug triage first [18:34:15] yo yo [18:34:18] suggestion: highlight words in yer irc client [18:34:18] https://trello.com/c/MSED64NS/46-bug-73243-talk-add-discussion-button-look-like-other-overlay-buttons [18:34:24] mobilewebteam? [18:34:26] webteam? [18:34:26] thx kaldari|2 jdlrobson [18:34:41] so kristenlans doesn't have to type all of that repeatedly ;) [18:34:48] phuedx: good suggestion :-) [18:35:10] I like webteam [18:35:12] are we starting from the top? [18:35:43] joakino: Here is our reportcard (with limn graphs): http://mobile-reportcard.wmflabs.org/ [18:35:50] Maryana it depends, do we want to get in to those stories or just triage bugs? [18:36:05] (03Merged) 10jenkins-bot: Final styling tweaks/fixes for lead images / wikidata description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172735 (owner: 10Dbrant) [18:36:09] kristenlans: a good description of the last.fm webteam's practices: http://paulrhayes.com/2013-06/last-fm-webteam/ [18:36:12] (details irc comms) [18:36:43] kristenlans: i think "add event_isWP0" was fairly uncontroversial. let's move that into ready for dev [18:36:54] wikigrok error state can go to next sprint [18:37:12] Maryana: before moving it can we at least sanity check those story points [18:37:14] and i don't know what "document our limn stuff" is :) [18:37:19] oh yeah [18:37:23] since no one has looked at that card other than kaldari :) [18:37:27] do it [18:37:59] So all we are basically doing is adding an isZero field [18:38:14] how do we know if we are in zero or not dr0ptp4kt [18:38:30] if you split the card into two: log the data, whisper the limn incantation at the appropriate shrine, you'd two small-ish stories [18:38:38] phuedx: +1 to that [18:38:46] jdlrobson: on the scrum of scrums meeting. let's discuss afterward [18:38:47] * jdlrobson does that [18:39:15] Maryana: can we just add a graph of zero edits? [18:40:15] or do they not need a graph? [18:40:29] * jdlrobson creates https://trello.com/c/dEwKAcki/55-update-existing-limn-graphs-to-show-zero-edits [18:40:55] joakino / phuedx / rmoen any thoughts about https://trello.com/c/d1Xa7bvt/24-5-add-event-iswikipediazero-to-mobile-web-edit-schema ? [18:40:58] bmansurov: ^ [18:41:41] awaiting an answer to 6:38:14 PM how do we know if we are in zero or not dr0ptp4kt [18:41:42] change null to false as MaxSem said? [18:41:46] jdlrobson: What's the status of core templates right now? [18:41:53] still, teeny tiny [18:42:14] jdlrobson: what is the 'new field' [18:42:17] jdlrobson: estimates? [18:42:18] phuedx: i'll talk with you and jdlrobson after i get off this meeting [18:42:31] kaldari|2: ask TrevorP|Away/brion :) mobile web is just waiting on mustache in core [18:42:58] http://hatjitsu.wmflabs.org/17699 < joakino rmoen etc [18:43:01] ta [18:43:06] was about to ask [18:43:23] jdlrobson: Is there a patchset for that yet? [18:43:34] kaldari|2: not that i know of, but we are not doing anything relating to that [18:43:41] we got our stuff merged and using core [18:43:41] cool, thanks [18:43:49] idk if i can properly estimate this but i'm giving it a go [18:43:55] so looks like 1-3 [18:44:06] any strong reasons for the 3? [18:44:33] i said 3 but thats me, knowing about logging, and the schemas etc it is probably a 1 [18:44:43] or 2 [18:44:45] i said 2 just because of the open question to dr0ptp4kt :) [18:44:51] i'm fine with 2 [18:45:02] i voted one, but danger 2 is fine [18:45:03] 👍 [18:45:06] (y) [18:45:18] jdlrobson: ctrl+command+space [18:45:20] okay 2 it is :) [18:45:25] 🙀 [18:45:29] https://trello.com/c/dEwKAcki/55-update-existing-limn-graphs-to-use-new-editing-schema < might as well do this one next [18:45:30] 👻 [18:46:00] 🚀 [18:46:07] i don't think anyone except for jdlrobson and kaldari|2 know about limn graphs [18:46:14] bmansurov: you'll know soon [18:46:16] no idea [18:46:19] but basically this is just updating an sql query [18:46:22] yeah, but i can't estimate now [18:46:26] ok [18:46:42] jdlrobson: kaldari|2 we need at least a good description on the card [18:46:49] like, a technical description xd [18:47:20] limn graphs are so lovely... [18:47:43] done [18:47:48] irc needs out of band sarcasm metadata [18:47:49] i'd suggest a 1. If anyone wants to hatjitsu though we can :) [18:48:06] looks like we are hatjitsuing [18:48:11] waiting on one person [18:48:17] lol [18:48:17] heheh [18:48:19] who was the 5? [18:48:23] danger 5 from me [18:48:30] i did jon*2 = 2 [18:48:40] only one thing better than writing limn graphs is hacking on limn itself. [18:48:43] i did 3 (which is my goto answer when I don't know how to properly estimate) [18:48:47] ;/ [18:48:56] i'm sorta ok with a three [18:48:57] there is a ? too ;) [18:49:08] i'm trying to find the code to convince you it's a 1 [18:49:13] if someone points me in the right direction i can get all up in your sql [18:49:20] jdlrobson: not the time ;) [18:49:29] i gotta go get george to bed in a sec [18:49:34] ok ;-) [18:49:45] can i pull you down to a 2 at least? It really is just a one liner [18:49:49] a very long one liner [18:49:49] 👶💤 [18:49:53] but a one liner sql nevertheless [18:49:53] ^ [18:50:03] ... [18:50:07] ... [18:50:08] jdlrobson: we trust you, let's go with a 1 [18:50:11] zzzzz [18:50:16] danger 2 [18:50:17] go [18:50:18] danger 2 okay [18:50:22] ✌️ [18:50:32] fear-based estiamtion™ [18:50:39] https://trello.com/c/MSED64NS/46-bug-73243-talk-add-discussion-button-look-like-other-overlay-buttons [18:50:52] i'm kinda hoping FlorianSW will want to work on this? :) [18:51:31] basically the add button is huge. But since it's in beta and we're still not sure how talk/flow fit in i'm assuming it's a low priority for Maryana [18:51:36] and a bug so doesn't need estimation [18:51:44] ping him then, and will see [18:51:53] do we need input from design there? [18:51:59] joakino: possibly. ok i'll leave it there and we'll come back to it [18:52:08] i'll let Maryana decide [18:52:11] ok [18:52:13] i gotta go [18:52:16] backlog :) [18:52:17] https://trello.com/c/gb3kNPJJ/54-bug-73299-indicators-are-not-shown-in-mobile-view < lasty a feature request [18:52:20] * jdlrobson waves at phuedx [18:52:21] george is standing at the top of the stairs [18:52:28] "come on daddy!" [18:52:30] "bed time!" [18:52:31] "read!" [18:52:42] (i'm assuming the limn graph docs will come out of bmansurov :) [18:52:55] phuedx: bye! 👋 [18:52:57] sure [18:53:18] bye phued [18:53:23] …x [18:53:55] i'm not sure what the status of indicators are but i'd say not a high priority Maryana [18:54:49] backlogged (maryana in real life said so) [18:54:51] i have no idea of what those are [18:54:57] 👍 [18:55:03] kaldari|2: what did you say about https://trello.com/c/Elmti0S9/53-blocked-set-a-flag-config-var-to-start-the-test ? [18:55:12] we were going to kill it? [18:55:26] jdlrobson: Yeah, I think we can kill that. [18:56:05] omg [18:56:10] lol joakino [18:56:11] what is even happenign on that card [18:56:12] oh jesus [18:56:14] i'm terrified [18:56:18] LOLOLOLOL [18:56:19] the gif went to cover lol [18:56:23] make it go away [18:56:26]