[00:03:06] (03PS2) 10Bmansurov: Alpha: Fix watchstar animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172453 (https://bugzilla.wikimedia.org/73050) [00:03:24] (03PS4) 10Robmoen: ApiResponse: return success status or die on EventLogging fail. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 [00:06:05] mhurd: if you want test more properties you can use Q42 for the id, and get Douglas Adams. Q1 Universe, Q2 Earth [00:15:58] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172920 [00:30:51] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172453 (https://bugzilla.wikimedia.org/73050) (owner: 10Bmansurov) [00:34:42] (03PS1) 10Bmansurov: Fix rubocop warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172922 [00:35:24] can someone please +2 ^, all my patches are failing because of this [00:36:10] (03PS1) 10Kaldari: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 [00:38:03] (03CR) 10Bmansurov: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [00:47:19] hmm… beta labs seems to be out of sync with master [00:47:26] none of the patches you guys merged today are on it [00:47:43] either that or nobody's fixed any bugs :) [00:48:14] kaldari|2: jdlrobson ^^ [00:55:18] (03CR) 10Robmoen: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [00:57:07] (03PS5) 10Robmoen: Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [00:59:51] (03CR) 10Robmoen: [C: 032] Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [01:00:00] (03PS5) 10Robmoen: Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 (owner: 10Jdlrobson) [01:00:29] (03Merged) 10jenkins-bot: Hygiene: Clearly identify when/how things get initialised. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172457 (owner: 10Jdlrobson) [01:00:41] (03CR) 10Robmoen: [C: 032] Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 (owner: 10Jdlrobson) [01:01:20] (03Merged) 10jenkins-bot: Hygiene: Put TableOfContents in own file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172458 (owner: 10Jdlrobson) [01:06:10] (03CR) 10Kaldari: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:07:24] (03CR) 10Kaldari: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:10:30] (03CR) 10Kaldari: [C: 04-1] "Per comments" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:11:26] (03CR) 10Bmansurov: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:12:18] jdlrobson or kaldari|2 can you guys review this? https://gerrit.wikimedia.org/r/#/c/172922/ [01:14:23] omfg gerrit [01:16:22] (03CR) 10Maryana: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:20:06] jdlrobson, http://en.wiki.local.wmftest.net:8080/ [01:31:00] (03PS2) 10Kaldari: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 [01:38:09] (03CR) 10Bmansurov: [C: 032] Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:38:25] (03PS7) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [01:38:27] (03PS1) 10Jdlrobson: Make sure notifications has loaded click tracking code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172931 [01:38:29] (03PS1) 10Jdlrobson: Creative MaxSem friendly destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172932 [01:39:07] (03CR) 10jenkins-bot: [V: 04-1] Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 (owner: 10Jdlrobson) [01:39:22] (03Merged) 10jenkins-bot: Changing WikiGrok v B copy per discussion with Dario, Maryana, and Moiz [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172923 (owner: 10Kaldari) [01:39:40] (03CR) 10jenkins-bot: [V: 04-1] Creative MaxSem friendly destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172932 (owner: 10Jdlrobson) [01:42:59] (03CR) 10Dr0ptp4kt: [C: 032] Re-implemented missing Zero Portal Lua function [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171472 (owner: 10Yurik) [01:43:17] (03Merged) 10jenkins-bot: Re-implemented missing Zero Portal Lua function [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/171472 (owner: 10Yurik) [01:43:20] bearND_: did you want me to merge https://gerrit.wikimedia.org/r/172920 ? [01:44:04] dbrant|brb: no, I've found some issues in some translations. [01:44:30] dbrant|brb: it's paramaters again. I'm updating the TranslationTests to catch those [01:44:36] bearND_: ok, cool [01:45:31] dbrant|brb: the Catalan translations has some weird stuff (notranslate) [01:45:58] bearND_: oh, i see it [01:47:00] (03CR) 10Jdlrobson: [C: 04-1] Fix WikiGrokDialogB button spinner (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172817 (https://bugzilla.wikimedia.org/73249) (owner: 10Bmansurov) [01:47:53] (03PS3) 10Jdlrobson: Update watchstar icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73053) (owner: 10Bmansurov) [01:48:45] (03CR) 10Jdlrobson: Update watchstar icons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73053) (owner: 10Bmansurov) [01:51:27] (03CR) 10Jdlrobson: [C: 04-1] "* Animation only runs when clicking a watched watchstar. Doesn't run when clicking an unwatched star :-(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73053) (owner: 10Bmansurov) [01:51:41] (03PS1) 10Kaldari: Making sure that user is thanked regardless of EventLogging success [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172934 [01:55:13] 3MobileFrontend / 3Hygiene: Hygiene: Standardise names of our event logging schemas - 10https://bugzilla.wikimedia.org/73342 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon We have loggingSchemas/MobileWebClickTracking and loggingSchemas/mobileWebEditing which is the incorrect one? [01:55:25] 3MobileFrontend / 3Hygiene: Hygiene: Standardise names of our event logging schemas - 10https://bugzilla.wikimedia.org/73342#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/8HWy51DB [01:55:28] (03PS1) 10Kaldari: ? -> : [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172936 [01:55:47] (03PS2) 10Jdlrobson: Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 [01:55:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson) [01:56:00] (03CR) 10Kaldari: [C: 032] ? -> : [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172936 (owner: 10Kaldari) [01:56:39] (03Merged) 10jenkins-bot: ? -> : [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172936 (owner: 10Kaldari) [01:57:46] (03PS3) 10Jdlrobson: Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 [01:58:27] 3MobileFrontend / 3beta: If EventLogging fails when recording a WikiGrok response, the user is left with an eternal spinner - 10https://bugzilla.wikimedia.org/73343 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None We should just thank them anyway and record the error. [01:59:18] (03PS2) 10Jdlrobson: Hygiene: Fix rubocop warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172922 (owner: 10Bmansurov) [01:59:25] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix rubocop warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172922 (owner: 10Bmansurov) [01:59:33] (03PS2) 10Kaldari: Making sure that user is thanked regardless of EventLogging success [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172934 (https://bugzilla.wikimedia.org/73343) [02:00:06] (03Merged) 10jenkins-bot: Hygiene: Fix rubocop warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172922 (owner: 10Bmansurov) [02:00:16] (03PS2) 10Jdlrobson: Creative MaxSem friendly destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172932 [02:00:42] (03PS8) 10Jdlrobson: Wikidata infoboxes: Reveal images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169792 [02:06:05] (03PS2) 10Bmansurov: Fix WikiGrokDialogB button spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172817 (https://bugzilla.wikimedia.org/73249) [02:06:12] (03CR) 10jenkins-bot: [V: 04-1] Fix WikiGrokDialogB button spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172817 (https://bugzilla.wikimedia.org/73249) (owner: 10Bmansurov) [02:08:25] (03PS3) 10Bmansurov: Fix WikiGrokDialogB button spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172817 (https://bugzilla.wikimedia.org/73249) [02:09:01] (03CR) 10Kaldari: [C: 032] Add wikidata descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 (owner: 10MaxSem) [02:11:29] (03PS3) 10Bmansurov: Alpha: Fix watchstar animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172453 (https://bugzilla.wikimedia.org/73050) [02:11:56] (03CR) 10Bmansurov: "Animation has been fixed here: https://gerrit.wikimedia.org/r/#/c/172453/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73053) (owner: 10Bmansurov) [02:14:09] (03Merged) 10jenkins-bot: Add wikidata descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171767 (owner: 10MaxSem) [02:21:13] (03CR) 10Springle: [C: 031] ""Yea" to schema." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem) [02:28:57] 3Wikipedia App / 3Android App: Article rotations pull and stretch lead images in very bizarre ways - 10https://bugzilla.wikimedia.org/73345 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load https://en.m.wikipedia.org/wiki/Mario #2 Rotate the device Notice how Mario gets 'stretched' on rotatio... [02:31:37] flyingclimber: doesn't look like the video got attached to the bug [02:31:40] 3Wikipedia App / 3Android App: Article rotations pull and stretch lead images in very bizarre ways - 10https://bugzilla.wikimedia.org/73345#c1 (10Tomasz Finc) Created attachment 17107 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17107&action=edit Mario image getting stretched.mp4 Trying upload again [02:31:54] flyingclimber: nm! [02:31:56] dbrant|brb: yup, file was too big. i just recorded a shorter version of it [02:32:48] dbrant|brb: i do love filing bugs that have to do with 'Mario' :) [02:33:07] tfinc: yep! that's a good one [02:34:00] dbrant|brb: if you don't need rotations adb screenrecord is pretty useful [02:34:25] it sure is! [02:35:42] dbrant|brb: while i'm glad that it's fixed i will forever remember this a far superior http://imgur.com/SO7PcBX [02:35:56] mustache is the definitive trait on that one [02:36:18] lolol [02:37:08] dbrant|brb: is the stretch being done by us or the underlying animation library ? [02:37:27] tfinc: that's the underlying OS transformations... [02:37:48] tfinc: i'll look into it; there may be something that could be done. [02:37:59] tfinc: actually i'm surprised that face-detection worked on mario's face! [02:38:21] dbrant|brb: prioritize it like the others [02:38:22] yup [02:38:31] Deskana and i were just talking about that [02:38:38] but if its also detecting hub caps ... [02:38:48] Haha [02:38:58] If it can detect a face in a wheel, it can detect a face on Mario. :-p [02:39:13] granted i told Deskana that while if failed to find a face ... the mini is nicely centered [02:39:42] lol ...a Tumblr of face-detection fails... [02:41:00] :-D [02:41:39] Reminds me of that thing I saw about fails of Photoshop's content aware fill failing. [03:10:13] 3MobileFrontend / 3stable: List of languages not indented on tablet - 10https://bugzilla.wikimedia.org/73346 (10Jon) 3NEW p:3Unprio s:3normal a:3None This is inconsistent with the search bar [03:10:26] 3MobileFrontend / 3stable: List of languages not indented on tablet - 10https://bugzilla.wikimedia.org/73346#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xG0IzdiR [03:13:41] (03Abandoned) 10Jdlrobson: Creative destruction: Wikidata Infoboxes in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169730 (owner: 10Jdlrobson) [03:13:49] WikiGrok is a bit funny, because it says "This extension is being used on one or more Wikimedia projects. This probably means that the extension is stable" and at the same time "Release status: experimental" [03:14:04] i just happened to see it's on en.wp now, 'grats [03:17:32] i wanna be a beta tester too :) [03:19:58] like this for Android https://www.mediawiki.org/wiki/Design/Research/Guerilla_testing_Wikigrok [03:49:31] (03PS1) 10Mhurd: In-article search with WikiData short descriptions. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 [06:45:28] 3Wikipedia App / 3Android App: Android app: Description in article title is sometimes in the wrong language - 10https://bugzilla.wikimedia.org/73349 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 17110 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17110&action=edit Descrip... [06:51:01] (03CR) 10Florianschmidtwelzow: "I'm wondering, if it would be better (and possible) to find a way to deactivate CentralNotice (without loading any module), instead of hid" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172885 (owner: 10Robmoen) [06:53:16] (03CR) 10Deskana: "This is good to go from a product standpoint, imo." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172010 (owner: 10Deskana) [06:58:39] (03PS13) 10Florianschmidtwelzow: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 [06:58:51] (03CR) 10Florianschmidtwelzow: "Sorry for the delay." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [09:08:35] hi! [09:12:08] hey webot [09:22:45] hi meatbags! 😬 [09:23:27] another bot, joakino? :) [09:23:28] lol it works [09:23:37] wm-bot2: hi? [09:23:41] heh [09:23:46] yeah I was coding last night, first time bot :p [09:23:51] hehe :) [09:23:53] it does nothing now xd [09:24:05] tread carefully tho, there was just a flame war yesterday about us having too many bots [09:24:09] just hi if you mention webot [09:24:10] hi joakino! [09:24:20] YuviPanda: oh I didn't know that [09:24:26] so I started on an IRC relay to unify all bots into one https://github.com/yuvipanda/ircnotifier [09:24:35] will unify grrrit-wm, wikibugs, wikibugs2 and morebots [09:25:02] awesome! [09:25:14] do contribute! :D [09:25:21] it's got a simple http interface with simple auth tokens [09:25:26] and then redis for comm + then irc [09:25:31] python3 asyncio code \o/ [09:25:34] i just wanted it for webteam queries, for example calling out all members without having to remember the names [09:26:06] i'm more of a node.js guy, so i'm not sure i'll be useful, but i'll have a look [09:26:31] YuviPanda: a small irc with steps/resources wouldn't hurt [09:26:44] hehe [09:27:01] grrrit-wm is nodejs, but in general we're moving 'em all to python [09:27:14] joakino: 'a small irc with steps'? [09:27:27] oops *readme [09:28:10] so is it a problem if it is passive? (just answer when invoked) [09:29:28] joakino: someone might bite you at some point, but the people who usually care don't hang out here. [09:29:52] !hi is wat [09:29:52] You are not authorized to perform this, sorry [09:29:55] dammit [09:29:58] lol [09:30:04] joakino: if you're looking for ^ kinda stuff we already do have it [09:30:06] haha 😀 [09:30:11] just need to find someone to authorise me [09:30:14] !help [09:30:19] !bot-brain [09:30:24] sigh [09:30:41] doesn't work very well haha [09:30:42] https://meta.wikimedia.org/wiki/WM-Bot [09:30:56] I trust: petan!.*@wikimedia/Petrb (2admin), .*@mediawiki/Yuvipandan (2admin), .*@wikipedia/preilly (2admin), [09:30:56] @trusted [09:31:04] wait what [09:31:09] who the fuck is YuviPandan [09:31:25] joakino: it's actually fairly good. [09:31:53] typo [09:32:02] ah, no. my old cloak. [09:32:05] had a typo [09:32:16] preilly: hey! ^ wm-bot, can you add my new cloak? [09:32:44] joakino: also, what TZ are you in? [09:32:59] i'm in GMT+1 Spain [09:33:24] ah, nice [09:33:33] I think that's close to my Timezone today [09:33:48] where are you [09:34:13] @seen kaldari [09:34:30] joakino: I'm in India [09:34:36] but usually have a EST timezone [09:34:44] !seen on [09:34:54] joakino: I think we need to turn that feature on [09:35:00] joakino: nobody's really used the irc bot in -mobile much [09:35:04] YuviPanda: ok xd [09:35:17] so it is 4:34 AM there? [09:35:22] no [09:35:23] 3:05 PM [09:35:40] because I'm in India, but I usually work at around 6pm-4am. [09:35:51] today I'm working noon to 8pm instead :) [09:39:42] cool [09:39:47] you work till 4am [09:39:54] wow [09:46:51] that way you sync with the next day in SF [09:47:59] joakino: yeah! :D [09:48:20] joakino: I wake up at noon, work for 2-3 hours, then go out, have fun, back home at 11pm - midnight, then work for 4-5h [09:48:47] must be tiring [09:49:47] is it required for ops to sync up? [09:51:30] joakino: nope [09:51:39] joakino: I was in the mobile team for 2.5 years, and there it definitely helped :) [09:52:17] joakino: no, it's actually quite awesome :) I prefer working in the night, but also enjoy outings in the evenings. This way I'm not too tired when I go out in the evening, and also have a block of time uninterrupted by things like food [09:53:08] yeah it must have its advantages [09:54:19] i'm working morning/afternoon here, so that i sync a couple of hours [09:54:39] YuviPanda: the mobile team has pretty good remote practices so it hasn't been a problem [09:55:59] joakino: indeed, but we did have meetings. [09:56:10] joakino: if I worked normal Indian hours there'll be 0 overlap [09:56:13] joakino: I was also tech lead. [09:56:27] true [09:56:54] their morning meetings are my evening so it is usually fine for me [09:57:11] so did you change teams/ [09:57:12] ? [09:57:18] yeah, I switched about 2 weeks ago [09:58:25] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255 (10Jhernandez) [09:58:42] why? [10:01:33] joakino: oh, I was in the apps team [10:01:53] joakino: I wrote the old app, and it was terrible. Wanted to stay on and fix it :) [10:02:06] aha [10:02:18] joakino: that happened, new team was formed. Everything is awesome, etc [10:02:58] joakino: I've always been more of a systems person, and have been doing ops work on my side anyway [10:03:41] 👍 that's a change [10:04:00] how long have you been with the foundation? [10:07:34] joakino: hmm, 3 years next month [10:07:41] joakino: I was a volunteer dev for a year before that, I think [10:07:49] awesome [10:08:02] did Google Summer of Code with MW in 2011, when I was 19 :D and then kinda stuck around [10:08:15] damn youngsters [10:08:19] hehe :) [10:11:41] indeed.... [10:11:51] * thedj suddenly feels very old. [10:13:19] heh [10:13:24] I'm 23, but look about 35 [10:13:40] thedj: joakino legoktm and matmarex are 18 (19?) if that's better [10:13:49] * thedj is 34 but looks like 39 :) [10:14:11] legoktm is 18 ???? [10:14:20] now i'm just getting depressed :) [10:14:46] :D [10:14:48] he's 19 now, I think [10:14:55] thedj: tell me about it [10:15:15] when I was 19 I was just rewriting minor GNOME components, not getting deployment access... [10:16:20] well i started on VLC media player when i was 21 i guess... and release Samba network sharing for MacOS X 10.0 when i was 20... [10:16:32] hehe :) [10:16:33] * thedj feels slighly better now. [10:17:35] 😭 if I keep talking with you guys I'm just going to leave programming and go farm [10:17:48] btw, anyone know how to run an app on iOS from commandline on Xcode 6, without it closing down after the 'testrun' finished ? [10:18:28] thedj: you need brion [10:23:17] i've been banging my head against the wall on this. they changed instruments in xcode 6 to by default, 'kill the app' after it's done with the testrun. [10:23:45] with the GUI app, there is a switch for that behavior, but it seems that didn't bother documenting it for the commandline app. [10:23:54] F'ers [10:25:03] * thedj will file a bugreport with apple. see if that gets me any support. [10:58:36] phuedx: everything ok? [10:59:37] (03PS3) 10Jhernandez: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 [10:59:55] (03CR) 10Jhernandez: Add tests to WikiGrokDialogB (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [11:44:37] yo [11:44:43] hey joakino, yeah everything's fine [11:45:11] had to go to the hospital [11:48:01] phuedx: no baby yet [11:59:05] no baby yet [12:18:31] (03CR) 10Jhernandez: Conform to the MobileWebWikiGrok schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 (owner: 10Bmansurov) [12:19:16] phuedx: :( [12:27:09] (03CR) 10Jhernandez: [C: 032] Conform to the MobileWebWikiGrok schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 (owner: 10Bmansurov) [12:29:50] (03Merged) 10jenkins-bot: Conform to the MobileWebWikiGrok schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172443 (owner: 10Bmansurov) [12:48:46] (03PS5) 10Phuedx: ApiResponse: return success status or die on EventLogging fail. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 (owner: 10Robmoen) [12:51:19] (03CR) 10Phuedx: "PS5 fixes the coding style violation that I introduced and also changes 'false' to true ;) (see inline)." (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 (owner: 10Robmoen) [12:54:36] i'm out for lunch! [12:55:50] (03CR) 10Nemo bis: "> The idea behind this patch is sound, however it will need to be run by the design team." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159198 (owner: 10NightlyNexus) [12:55:59] (03CR) 10Phuedx: [C: 032] ApiResponse: return success status or die on EventLogging fail. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 (owner: 10Robmoen) [12:56:18] (03Merged) 10jenkins-bot: ApiResponse: return success status or die on EventLogging fail. [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/172467 (owner: 10Robmoen) [13:11:44] (03CR) 10Nemo bis: "> We should not be special-casing entire countries like this." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163830 (owner: 10Zhaofeng Li) [13:20:56] 3MobileFrontend / 3Feature requests: MobileFrontend: Showing the "back" button in the editors is silly in Android because the browser back button is available, as is a hardware one - 10https://bugzilla.wikimedia.org/69637#c3 (10James Forrester) a:3None This is a general MobileFrontend design decision. [13:25:25] 3MobileFrontend / 3Feature requests: MobileFrontend: Showing the "back" button in the editors is silly in Android because the browser back button is available, as is a hardware one - 10https://bugzilla.wikimedia.org/69637#c4 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https... [14:27:36] (03PS1) 10Florianschmidtwelzow: Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) [14:36:40] 3MobileFrontend / 3beta: Talk overlay conflicts with OverlayManager hide delay - 10https://bugzilla.wikimedia.org/64105#c5 (10Florian) 5RESO/FIX>3REOP Reopen, can reproduce after merging routing for TalkOverlay (Ie5dd5b0e66cd192e32dc9288732d16ed49948eec). Tap is removed in MF, so it seems the problem isn... [14:36:48] (03CR) 10Florianschmidtwelzow: "Seems to be related to this bug: 64105" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171981 (https://bugzilla.wikimedia.org/71075) (owner: 10Jdlrobson) [14:37:37] (03CR) 10Florianschmidtwelzow: Style links in Overlay header like buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [14:45:18] im back [14:45:32] hey joakino [14:45:45] phuedx 👋 [14:55:40] (03CR) 10Dbrant: [C: 032] Capitalise first letter of Wikidata descriptions. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172010 (owner: 10Deskana) [15:08:03] currently drinking this: http://barn.bigcartel.com/product/githiga-kenya-filter [15:08:05] it's delish [15:12:50] (03PS1) 10Dbrant: Clear Wikidata cache when switching languages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173006 (https://bugzilla.wikimedia.org/73349) [15:14:52] joakino: do occasionally see Uncaught Error: Module not found: loggingSchemas/MobileWebClickTracking locally? [15:15:00] i've been seeing it all day [15:15:11] (03PS2) 10Phuedx: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [15:15:13] (03PS2) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 [15:16:16] phuedx: I haven't seen that :S [15:16:32] phuedx: i've been navigating now keeping an eye up but nope [15:16:42] maybe it's time to tear down and rebuild [15:17:06] phuedx: and im up to date with master [15:17:19] in one of the pushes there was lots of file renaming [15:17:25] i have to ask about that this afternoon [15:28:49] (03PS1) 10Dbrant: Scroll all the way up when first section in ToC clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173011 (https://bugzilla.wikimedia.org/73327) [15:32:32] (03PS3) 10Phuedx: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [15:33:54] (03PS9) 10Dbrant: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [15:37:27] (03CR) 10Phuedx: [C: 04-1] "This is borked in alpha." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [15:47:04] (03CR) 10Dbrant: [C: 04-1] "almost :)" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [15:53:31] (03PS1) 10Dbrant: Don't show title or lead image block on Main page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 [16:17:32] (03PS1) 10Jhernandez: Tools: Run make jshint with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173024 [16:17:34] (03PS1) 10Jhernandez: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 [16:17:36] (03PS1) 10Jhernandez: WIP: Auto beautify files when adding them to the staging area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173026 [16:42:13] (03PS9) 10Dbrant: Hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [16:45:48] (03PS10) 10Dbrant: Hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [16:46:55] hey kristenlans [16:47:17] hey there phuedx. how are your coffee levels today? [16:47:25] pretty dern good [16:47:26] two cups [16:47:44] kristenlans: currently drinking http://barn.bigcartel.com/product/githiga-kenya-filter [16:48:59] Hmm wonder if they will ship to my country… [16:49:08] yes [16:49:38] oh boo [16:49:40] they don't :( [16:50:31] oh yeah :-( “We only accept orders that are shipped to addresses in Germany or other countries of the European Union. [16:50:32] ” [16:52:00] hi! [16:52:20] hi joakino [16:52:21] kristenlans: it is usually the opposite [16:52:29] I know, right? [16:52:41] Now I knwo how it feels! [16:53:19] kristenlans: 😩 [16:56:11] hey phuedx do you get error messages from grep when commiting? [16:56:16] i get this all the time [16:56:22] https://gist.github.com/anonymous/c66081136e50a378be3e [16:56:48] yowzxa [16:57:05] that's so much grep spam that i misspelled yowza [16:57:28] kristenlans: there's a little part of me that is feeling smug about your lack of barn coffee [16:57:38] phuedx hehehehe [16:57:43] however, i'll bring you a bag in january [16:57:51] Yeeeeeeeehaw!!! [16:59:39] phuedx: it is the grep -P in the dev-scripts/pre-commit [16:59:51] wtf is -P, it is not in man [17:00:12] joakino, perl regex [17:00:23] If you are looking at the "man" on macos, it's differenty [17:00:28] ^ that [17:00:34] halfak: hm looks like a regex [17:00:36] also, hey halfak [17:00:40] o/ phuedx [17:00:48] :) [17:01:09] * halfak found an excuse to poke his head in -mobile and used that as an excuse to autojoin [17:01:17] \o/ [17:01:22] more halfak for everyone! [17:01:26] :D [17:01:49] there is -e pattern, --regexp=pattern and -E, --extended-regexp [17:02:02] if I change -P for --regexp will it work on linux? [17:02:21] GREETINGS HALFAK [17:02:24] phuedx: oops [17:02:34] haha help my fingers are possessed [17:02:37] :) [17:03:20] joakino, on my ubuntu 13.10 install, -P, --perl-regexp [17:03:20] Interpret PATTERN as a Perl regular expression (PCRE, see below). This is highly experimental and grep -P may [17:03:20] warn of unimplemented features. [17:03:56] halfak: and do you have --regexp ? [17:04:19] joakino, yes [17:04:40] --regexp=PATTERN \n Use PATTERN as the pattern. This can be used to specify multiple search patterns, or to [17:04:46] ... [17:04:50] aha [17:05:19] halfak: it is stuff like grep --regexp '\.js$' grep --regexp '\.*php$' grep --regexp 'includes/skins/.*php$' , nothing complicated so it should work [17:05:41] halfak: thx! [17:05:49] :) hth [17:06:36] * halfak *just* ran into the difference between MacOS coreutils and Ubuntu's coreutils a couple days ago. [17:06:56] yeah so annoying [17:07:41] kaldari, Maryana: http://etherpad.wikimedia.org/p/WikidataQueries [17:07:49] danke [17:08:04] gwicke: http://etherpad.wikimedia.org/p/WikidataQueries [17:12:59] Deskana: thanks! [17:18:02] (03PS1) 10Jhernandez: Make make jscs use grunt jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173041 [17:18:04] (03PS1) 10Jhernandez: Fix grep errors on pre-commit (dev-scripts/pre-commit) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173042 [17:28:46] (03PS1) 10Dbrant: Make ThemeChooser dialog inherit from BottomDialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173047 [17:40:26] (03CR) 10Deskana: [C: 04-2] "Not ready yet." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [17:56:35] brion: heya! [17:58:19] hey mhurd [17:58:44] brion: i got the first part of the search stuff done! https://gerrit.wikimedia.org/r/172942 [17:59:21] \o/ [17:59:47] \o. [17:59:51] .o/ [17:59:53] \o/ [17:59:55] haha [18:00:10] ok i gotta interview candidate, bbiab [18:09:27] MaxSem: be careful with your audio. we're hearing everyone when your not muted and someone else is speaking [18:09:42] uh-oh [18:10:59] http://hatjitsu.wmflabs.org/57282 [18:23:13] dr0ptp4kt_: you've played with swift, do you know if it allows hardware access? i don't see it in their spec [18:23:48] tfinc: which sort of hardware access? [18:24:03] dr0ptp4kt_: USB bus [18:24:49] tfinc: from what i gather, stuff like that might be accessible by the normal ios libraries via swift like they would historically be accessible from objective-c. lemme check on some things [18:24:57] thanks [18:25:03] (a lot of peripheral stuff is limited in general in ios) [18:25:22] dr0ptp4kt_: i was actually looking at in OSX [18:25:29] not iOS [18:27:33] tfinc: this may be a starting point: http://stackoverflow.com/questions/25297927/implementing-objective-c-methods-into-swift-program [18:28:02] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=73377 [18:28:35] and pretty much this https://developer.apple.com/library/ios/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html . thanks dr0ptp4kt_ [18:28:55] tfinc: yep. IOKit documentation with that [18:32:47] MaxSem: https://trello.com/b/DWuSeWBE/mobile-web-developers-backlog [18:32:54] jdlrobson: beta labs is down because of a ResourceLoaderTemplateModule issue [18:33:06] see the bug I sent you above [18:34:55] 3MobileFrontend / 3General/Unknown: Bits broken on beta labs: ReferenceError: mw is not defined - 10https://bugzilla.wikimedia.org/73377#c6 (10Greg Grossmeier) p:5Unprio>3Highes (Not a Beta Cluster bug) [18:35:26] 3MobileFrontend / 3General/Unknown: Bits broken on beta labs: ReferenceError: mw is not defined - 10https://bugzilla.wikimedia.org/73377#c7 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9dGlL33Y [18:35:55] 3MobileFrontend / 3General/Unknown: Bits broken on beta labs: ReferenceError: mw is not defined - 10https://bugzilla.wikimedia.org/73377 (10James Forrester) s:5major>3blocke [18:36:25] 3MobileFrontend / 3General/Unknown: Fatal error: Class undefined: ResourceLoaderTemplateModul e in /srv/mediawiki/php-master/i ncludes/resourceloader/Reso urceLoader.php on line 506 - 10https://bugzilla.wikimedia.org/73377 (10Greg Grossmeier) [18:39:17] I've shown a lot of different language speakers our capitalisation patch now. [18:41:31] French, German, Italian, Japanese, Ukranian, Persian, Russian [18:41:34] All looks good. [18:41:39] I'm going to show it to a Hebrew speaker later. [18:49:54] good [18:51:15] Deskana: I'm not sure Hebrew even has "capital" letters. [18:51:45] Me neither! But rather than trying to figure it out, I'm just going to show it to him and see if he looks confused at the question or laughs at me. :) [18:53:04] whee [18:54:12] ah i forgot about th emobile app retrospective :D [18:54:16] i’ll head into the office after that [18:56:34] jdlrobson: Can you look into https://bugzilla.wikimedia.org/show_bug.cgi?id=73377 after the technical kitty grooming is done [18:59:38] Krinkle|detached: hey. i changed ownership of some of the app rituals to you. let me know if it works [19:01:15] (03PS2) 10Mhurd: In-article search with WikiData short descriptions. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 [19:01:25] kaldari: oh dears. Any idea which extension is throwing that? [19:01:41] I thought i'd removed it from Flow and MobileFrontend. Sounds like something else is using it that I wasn't aware of [19:02:08] ah it's Zero [19:02:39] jdlrobson: Yeah, Bryan mentioned it's breaking ZeroBanner [19:03:27] kristenlans, brion: Ping! Retrospective time. :-) [19:03:37] Deskana: were’ on the hangout [19:03:40] were are you? [19:03:46] brion: We are too... [19:03:47] YEah where are you!!! [19:03:50] WHat even... [19:04:00] whee hangout netsplit :) [19:04:07] brion: Vibha, Dmitry, Bernd and the office are in the hangout. [19:04:14] One of the hangouts... [19:04:18] ok we’re gonna try reconnecting [19:04:27] brion: Cool. [19:06:35] hey jdlrobson what happened with all the file renames on JS? (init.js) [19:07:27] joakino: https://gerrit.wikimedia.org/r/#/c/171171/ [19:07:40] So I wanted to make it clearer what the entry points of code were. [19:07:51] sometimes we were using init.js and sometimes the modulename.js [19:07:56] I thought init made it more obvious [19:08:11] you merged it apparently. :) [19:08:44] me? lol [19:09:14] joakino: haha do you think it was a bad idea? [19:09:25] i'm still trying to work out the best way to lay out our modules [19:09:58] One idea I have is to move all the init.js's into a different folder / maybe merge the files [19:10:04] e.g. stable.js beta.js alpha.js [19:10:25] turns out rmoen_ was the ghost of hatjitsu btw ;-) [19:10:38] jdlrobson: why isn't gerrit showing the renames on that patch? i didn't see them :P, it looks good anyway [19:10:39] jdlrobson: calling me out ;) [19:10:44] jdlrobson: I don't think moving all init.js's intoa separate files is a good idea. [19:10:45] rmoen_: i knew it [19:10:57] joakino: eerrrr [19:10:59] good question [19:11:01] joakino, jdlrobson: I blame firefox [19:11:31] rmoen: nope chrome does the same [19:11:33] joakino: are things exploding? [19:11:59] jdlrobson: which things [19:12:23] oh wait [19:12:38] bmansurov, jdlrobson: There would be a bunch of duplicated code. Perhaps we would do everything in stable.js and then inherit with alpha/beta and override to reduce duplication of code ? [19:12:43] joakino: https://gerrit.wikimedia.org/r/#/c/172902/ [19:12:48] that's the patch - it didn't get merged [19:13:02] wait i'm losing my brain [19:13:33] So rmoen merged it https://gerrit.wikimedia.org/r/#/c/172457/ not joakino. Okay now I'm on the same page [19:13:34] i'm lost xD [19:13:42] yeh let's start again [19:13:46] so https://gerrit.wikimedia.org/r/#/c/172457/ renamed them to init.js [19:14:08] oh ok haha, now it makes sense [19:14:14] rmoen: yes [19:14:30] bmansurov: so what don't you like about that change? [19:14:45] joakino: makes sense in that it was a good idea or just that you understand when it happened? :) [19:15:20] The only issue i see with everything being init.js is knowing where you are exactly when you have more than one init.js file open [19:15:26] jdlrobson: are you saying you want to move module specific init code to a separate folder? that would mix things up [19:15:55] bmansurov: i'm saying it was an idea I had - having a stable.js / beta.js / alpha.js (where alpha requires beta, beta requires stable) [19:16:02] could get messy though so i'm not sure [19:16:14] It depends what we decide to do with Resource.php I guess [19:16:23] jdlrobson: i don't have any preferences on /init.js vs [19:16:39] anyway we can talk about that at some point in future in the grooming session [19:16:47] i just wanted to check everything was okay with the status quo [19:16:54] bmansurov: joakino phuedx rmoen_ so I've moved all the cards we just discussed and that seems uncontroversial into a ready for dev column there [19:17:01] kaldari: fyi, i moved the wikidata query service use-cases from the doc to a sandbox page on mw.o. imma gnome on it a little & then get your input at some point [19:17:15] cool [19:17:29] if you have any objections with doing any of those cards do you want to put your face on it and leave a comment? [19:18:27] How do you guys want to continue this? Would you be okay with a follow up meeting Monday after standup just so we can get some more cards specced out (I really want this to be every 2 weeks in future but I feel if we put the effort in now it will be worth it)? [19:18:30] jdlrobson: in the dev backlog [19:18:40] the ready for dev, right? [19:18:59] joakino: correcto [19:19:00] kristenlans: So is Bugello down for the time being? [19:19:14] jdlrobson: i'm fine with meeting to specify [19:19:37] Okay. I'll send a mail out :-) thanks for all the time you put in. It was good to talk about this stuff [19:20:06] 👍! [19:22:33] jdlrobson: i'm all in. Thanks for organizing :) [19:23:21] (03PS1) 10Jdlrobson: Use templates in core to avoid fatals [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173069 (https://bugzilla.wikimedia.org/73377) [19:25:03] ^ dr0ptp4kt_ should fix it [19:25:08] erggg no rooms kristenlans Monday am :( [19:27:48] jdlrobson: thx, parlayed to jeff. having him test, then +1 if he's okay with it prior to yuri/i +2'ing [19:30:35] (03Abandoned) 10Bmansurov: Alpha: Fix watchstar animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172453 (https://bugzilla.wikimedia.org/73050) (owner: 10Bmansurov) [19:30:40] (03PS4) 10Bmansurov: Update watchstar icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73050) [19:36:42] right folks [19:36:45] am off for the night [19:37:02] hey jdlrobson, solved my internet connectivity issues. I'll check out the patch you submitted and make sure everything works [19:37:13] jdlrobson: yeah the room availability thing is getting ridiculous! Shoot Sarah Rodlund an email and she can possibly help shuffle other meetigns around. [19:37:16] jdlrobson: to be clear, the problem was with the ZeroBanner extension, not ZeroPortal, correct? [19:37:18] jhobs: thanks :) [19:37:45] greg-g: Since we didn't get to use our new deployment windon on Tuesday (due to Veteran's Day), would it be possible to do a one-time deployment window for mobile today after the parsoid window (2pm)? [19:37:45] jhobs: it seems that way but if ZeroPortal is using templates in anyway you'll want to get that fixed asap [19:37:53] i'll send round an email about my meeting tomo [19:37:54] but for now [19:38:03] thanks phuedx [19:38:05] night night :D [19:38:07] it's chocolate biscuit time [19:38:12] (03PS5) 10Bmansurov: Update watchstar icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73050) [19:38:24] kaldari: sure [19:38:36] thanks, I'll add it into the schedule [19:40:49] If anyone has some time, I need to get this merged before 2pm so that we can start our A/B test: https://gerrit.wikimedia.org/r/#/c/172934/ [19:42:54] (03CR) 10Bmansurov: [C: 031] Making sure that user is thanked regardless of EventLogging success [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172934 (https://bugzilla.wikimedia.org/73343) (owner: 10Kaldari) [19:43:40] alright i'm out for today [19:43:45] have a nice day [19:43:54] cya [19:43:59] (03CR) 10Florianschmidtwelzow: [C: 031] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172934 (https://bugzilla.wikimedia.org/73343) (owner: 10Kaldari) [19:46:13] 3MobileFrontend / 3beta: When tag buttons are selected they change size - 10https://bugzilla.wikimedia.org/73381 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None In WikiGrok version B when you select a tag and it turns blue, it also changes size. It should stay the same size. This may be due to bord... [19:49:19] kristenlans: I'm not seeing new bugs go into Trello for some reason: https://bugzilla.wikimedia.org/show_bug.cgi?id=73343 https://bugzilla.wikimedia.org/show_bug.cgi?id=73381 [19:49:51] awjr: ^ [19:50:25] 3MobileFrontend / 3beta: When tag buttons are selected they change size - 10https://bugzilla.wikimedia.org/73381#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/l7wBZbHm [19:50:38] (03CR) 10Kaldari: [C: 032] Fix WikiGrokDialogB button spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172817 (https://bugzilla.wikimedia.org/73249) (owner: 10Bmansurov) [19:51:18] (03Merged) 10jenkins-bot: Fix WikiGrokDialogB button spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172817 (https://bugzilla.wikimedia.org/73249) (owner: 10Bmansurov) [19:54:07] jdlrobson: does this change remove Mantle completely? I'm getting an error with the line "M.router.one(...);" [19:54:14] kristenlans, awjr: Hmm, looks like Bugello just kicked in for that last one, but Bug 73343 never got pulled into Trello. Maybe it was just something specific to that bug :P [19:54:24] oh well [19:54:32] jhobs: mmm that sounds like another error [19:54:57] jhobs: Are you declaring mobile.startup as a dependency? [19:56:10] kaldari: jdlrobson bugello is ok now, or do you need me to take a look? [19:56:15] (03PS1) 10Jdlrobson: Click track clicks to references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173079 [19:56:18] jdlrobson: no [19:56:25] awjr: probably not [19:56:47] ok; i hope bugello survives long enough for us to shut it down next week ;) [19:57:01] awjr: I thought it wa broken, but maybe it was just that one bug [19:57:13] what are y'all planning to do about bugs/trello when BZ gets migrated? [19:57:31] kaldari: there are a lot of different possible reasons one bug might get missed by bugello [19:57:34] it's really rare tho [19:59:07] jdlrobson: looks like router.one was simply renamed to router.once somewhere along the way [19:59:12] Hey kaldari, was in app retro [19:59:36] jhobs: ohh yeh [19:59:48] jhobs: so i setup a bunch of javascript deprecation warnings but i guess you guys didn't see that :/ [20:00:07] jdlrobson: where would I see those so this doesn't happen again? [20:00:08] kristenlans: NP [20:00:09] they are supposed to show up in the console but i guess if you are running an older version of Mantle those could be missed [20:00:17] jdlrobson: hmm ok [20:00:18] jhobs: they just appear in the Javascript console [20:00:24] jdlrobson: i'll keep an eye out in the future [20:00:38] yeh i'll make sure I ping you I had no idea you were using this stuff :) [20:05:55] 3MobileFrontend / 3beta: MobileWebWikiGrokError event logging isn't working - 10https://bugzilla.wikimedia.org/73162 (10Ryan Kaldari) 5PATC>3RESO/FIX [20:06:05] (03CR) 10Bmansurov: Add tests to WikiGrokDialogB (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [20:07:45] (03CR) 10Jdlrobson: [C: 032] Making sure that user is thanked regardless of EventLogging success [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172934 (https://bugzilla.wikimedia.org/73343) (owner: 10Kaldari) [20:08:25] (03Merged) 10jenkins-bot: Making sure that user is thanked regardless of EventLogging success [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172934 (https://bugzilla.wikimedia.org/73343) (owner: 10Kaldari) [20:10:55] 3MobileFrontend / 3Feature requests: MobileFrontend: Showing the "back" button in the editors is silly in Android because the browser back button is available, as is a hardware one - 10https://bugzilla.wikimedia.org/69637#c5 (10Jon) 5NEW>3RESO/INV Some mobile browsers have no visible back button. We've n... [20:11:02] (03CR) 10Bmansurov: [C: 04-1] Click track clicks to references (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173079 (owner: 10Jdlrobson) [20:11:27] 3MobileFrontend / 3General/Unknown: Mobile watchstar QUnit tests failing in Firefox - 10https://bugzilla.wikimedia.org/73383 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None When I run the QUnit tests locally, I get 2 failures: MobileFrontend: Watchstar.js: Logged in user watches article MobileFront... [20:12:52] (03CR) 10Jdlrobson: Click track clicks to references (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173079 (owner: 10Jdlrobson) [20:13:28] (03PS2) 10Jhobs: Use templates in core to avoid fatals [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173069 (https://bugzilla.wikimedia.org/73377) (owner: 10Jdlrobson) [20:13:40] yurikR, dr0ptp4kt ^ [20:13:50] (03PS2) 10Jdlrobson: Click track clicks to references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173079 [20:14:54] jhobs: is it ready to be merged? [20:15:06] dr0ptp4kt: yeah [20:15:14] (03CR) 10Dr0ptp4kt: [C: 032] Use templates in core to avoid fatals [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173069 (https://bugzilla.wikimedia.org/73377) (owner: 10Jdlrobson) [20:15:21] jhobs: ^ done cc yurikR jdlrobson [20:15:25] 3MobileFrontend / 3General/Unknown: Mobile watchstar QUnit tests failing in Firefox - 10https://bugzilla.wikimedia.org/73383#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ZrSEzcif [20:15:47] (03Merged) 10jenkins-bot: Use templates in core to avoid fatals [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173069 (https://bugzilla.wikimedia.org/73377) (owner: 10Jdlrobson) [20:17:27] MaxSem: I have a deployment window set up for us at 2pm today. Can we push the masters of MF and WikiGrok to 1.25wmf8 and 1.25wmf7 then? [20:18:23] (03CR) 10Bmansurov: [C: 031] Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [20:20:17] (03CR) 10Bmansurov: [C: 032] Click track clicks to references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173079 (owner: 10Jdlrobson) [20:24:59] (03Merged) 10jenkins-bot: Click track clicks to references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173079 (owner: 10Jdlrobson) [20:30:27] (03CR) 10Bmansurov: [C: 032] Make sure notifications has loaded click tracking code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172931 (owner: 10Jdlrobson) [20:34:05] (03Merged) 10jenkins-bot: Make sure notifications has loaded click tracking code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172931 (owner: 10Jdlrobson) [20:38:02] (03PS2) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172920 [20:40:22] (03PS1) 10Dbrant: Styling tweaks for Search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173087 [20:43:47] (03PS2) 10Dbrant: Styling tweaks for Search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173087 [20:43:56] (03CR) 10Bmansurov: [C: 031] Creative MaxSem friendly destruction: Wikidata Infoboxes in alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172932 (owner: 10Jdlrobson) [20:47:13] (03PS1) 10BearND: Fix translations and add more tests for them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173092 [20:48:04] dbrant: I've made separate commits for the string changes. The 2nd commit depends on the 1st one. Would you CR them together? [20:48:15] bearND: sure! [20:48:27] (03CR) 10Bmansurov: [C: 032] Tools: Run make jshint with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173024 (owner: 10Jhernandez) [20:49:07] (03Merged) 10jenkins-bot: Tools: Run make jshint with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173024 (owner: 10Jhernandez) [20:54:18] (03CR) 10Bmansurov: Hygiene: Separate init code path for events (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson) [20:57:21] (03CR) 10BearND: [C: 032] Make ThemeChooser dialog inherit from BottomDialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173047 (owner: 10Dbrant) [20:57:40] (03Merged) 10jenkins-bot: Make ThemeChooser dialog inherit from BottomDialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173047 (owner: 10Dbrant) [20:57:44] Maryana: where's the design review meeting held in 2 mins? [20:58:18] dr0ptp4kt: it's in r31 [20:58:29] Maryana: thx c u soon [21:08:25] MaxSem: I have a deployment window set up for us at 2pm today. Can we push the masters of MF and WikiGrok to 1.25wmf8 and 1.25wmf7 then? [21:08:47] MaxSem: I'm in meetings until then unfortunately [21:18:30] (03CR) 10BearND: [C: 04-1] "really minor stuff" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173087 (owner: 10Dbrant) [21:21:05] tfinc: https://trello.com/c/dgYqIuId/21-spike-hr-determine-whether-we-re-ready-to-migrate-to-swift [21:21:19] kaldari: you got the url for the hangout? [21:26:55] 3MobileFrontend / 3General/Unknown: WikiGrokDialogB Response spinner needs design love - 10https://bugzilla.wikimedia.org/73249 (10Jon) 5PATC>3RESO/FIX [21:27:30] * Deskana yawns. [21:27:32] I'm so tired. [21:33:06] brion: moiz had some style tweaks to the search patch i submitted - updating… [21:33:52] kaity: https://etherpad.wikimedia.org/p/Lower_end_devices_checkup [21:35:08] ok will peek at it in a bit [21:36:25] (03CR) 10Jdlrobson: [C: 032] "I have a few follow up patches that are on the way related to this but this is fine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73050) (owner: 10Bmansurov) [21:36:36] mhurd: I have a friend who's interested in contributing to the app. He's done lots of C++ but no Objective C before. To get him started, could you recommend me a few easy-ish bugs for me to point him to? [21:36:45] brion: ^ [21:37:14] mhurd: i want to define a spike for Swift that Dan tells me we can include in this sprint as we're ahead of schedule [21:38:33] Deskana: no obj-c experience? [21:38:39] Deskana: not sure i can help [21:38:58] tfinc: sounds good! [21:39:08] mhurd: Sure, no worries. I'll just point him at the entire bug list and see what happens. :) [21:41:10] (03Merged) 10jenkins-bot: Update watchstar icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172883 (https://bugzilla.wikimedia.org/73050) (owner: 10Bmansurov) [21:41:45] jdlrobson, kaldari, phuedx: ohoh: https://bugzilla.wikimedia.org/show_bug.cgi?id=73389 [21:41:50] 3MobileFrontend / 3stable: Uncaught Error: Unknown dependency: ext.centralNotice.bannerController.lib - 10https://bugzilla.wikimedia.org/73389 (10Florian) 3NEW p:3Unprio s:3critic a:3None Visit beta labs or mediawiki.org in mobile view (stable/beta/alpha), you will get the following error in console:... [21:42:09] ^ rmoen [21:43:16] the module shouldn't loaded on mobile (like definition: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/d077d3540d2ab484419155daf1a91c8547cefbb4/CentralNotice.modules.php#L136) [21:45:16] AndyRussG: looks like you broke mobile. High five :) [21:45:30] mhurd: what else will be important on top of this https://trello.com/c/dgYqIuId/21-spike-hr-determine-whether-we-re-ready-to-migrate-to-swift ? [21:45:45] AndyRussG: ping me when you can and we can get it fixed up? [21:45:46] jdlrobson: hhmmmmm thank you.. on it!!! [21:45:54] oh cool you're here :) [21:45:58] Yes... [21:45:59] so yeh all mobiles are turned off on mobile by default [21:46:08] mhurd: i consider this feasibility. and at *most* light implementation [21:46:10] it's to encourage us to think about mobile when we add new js :-) [21:46:28] all.. modules? [21:46:36] yup all ResourceLoader modules [21:46:43] ah OK! [21:46:45] AndyRussG: you try to load a module for mobile with a dependency not declared to be loaded in mobile :) [21:46:51] tfinc: “migrate” makes it sound like we’re converting the codebase to swift, which i don’t think we should at this point. i just want the ability to choose to use swift as we make new things as a start [21:46:52] jdlrobson: this isn't happening on production, right? only mediawiki and beta labs, right? [21:46:54] when you want them on mobile you have to set 'targets'=>array('mobile','desktop' ) it's to encourage you to test it on mobile [21:47:00] AndyRussG: nope only made it to betalabs so far :) [21:47:06] Phew! [21:47:11] mhurd: edit it [21:47:16] tfinc: k [21:47:21] jdlrobson: I did set that target... so I thought :) [21:47:24] the library you are adding looks small so is probably harmless on mobile (if it had been 1000s of lines of code i would be a little concerned :) [21:48:11] AndyRussG: ext.centralNotice.bannerController.lib specifies no target (ResourceLoaderFileModules are desktop only by default) [21:48:32] Ah ooops, right it was the other one that does have the mobile target... OK [21:48:36] and some mobile module probably has it as a dependency [21:48:44] Yes that's it [21:48:55] ext.centralNotice.bannerController.mobiledevice inherits ext.centralNotice.bannerController :) [21:49:03] ext.centralNotice.bannerController.mobiledevice has mobile traget :) [21:49:11] AndyRussG: be sure to flag to your team to be careful with js changes and test them on mobile! Please be our mobile ambassador :-) [21:49:28] * AndyRussG copies backscrole for ejegg and awight [21:49:42] thanks AndyRussG :) [21:50:19] but also be careful about adding js, the more js you add the slower the mobile experience, so always think of what you're putting in and whether it's right to do so (in this case the code is so small it doesn't seem like it will be a problem) [21:51:14] jdlrobson: we are indeed planning to add more. This is just an initial no-op patch for a significant change to how banners are served [21:51:30] In fact the goal was to see if anything broke! [21:51:33] AndyRussG: yeh so please think mobile in all this :-) you may want to only load some of that code on desktop. [21:51:45] e.g. have completely different packages for mobile/desktop [21:52:03] CentralNotice js runs at the top of the page, so the more js you load the more you block people from reading the sum of all human knowledge [21:52:09] :) [21:52:21] Hmmm it's gonna be about 200 or 300.... [21:52:30] lines [21:53:18] it's a new dependency for bannerController, which mobile needs already. And there's not much in bC that would make sense to make device-specific afaik [21:53:19] It may save on banner response time a bit, and remove some load on the cache, if that's any comfort... 8p [21:54:00] mhurd: i'm not certain i understand your changes to the card [21:54:16] mhurd: a spike defines the question we want to answer [21:54:28] (03CR) 10BearND: [C: 04-1] Don't show title or lead image block on Main page(s). (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 (owner: 10Dbrant) [21:54:36] jdlrobson: we've increased the amount of js to help new phone sales: https://gerrit.wikimedia.org/r/#/c/173107/ [21:54:48] tfinc: those are the questions i have [21:55:02] 3MobileFrontend / 3alpha: Make page action icons use svgs in alpha - 10https://bugzilla.wikimedia.org/73391 (10Jon) 3NEW p:3Unprio s:3normal a:3None .mw-ui-icon-edit, .mw-ui-icon-edit-enabled, .mw-ui-icon-addimage, .mw-ui-icon-addimage-enabled, .mw-ui-icon-talk all use... [21:55:23] awight: all i'm saying is be careful on what you add, that JS gets loaded at top so can slow down the rest of the mobile experience - especially on 2G [21:55:23] There are two modules. One is not file based and constructs json in PHP: [21:55:23] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/a3455237f25a4c7fffde70fae85850f37cde884b/includes%2FCNBannerChoiceDataResourceLoaderModule.php [21:55:24] (03PS1) 10Robmoen: Only run SkinMinervaDefaultModules hook once in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173109 [21:55:30] 3MobileFrontend / 3alpha: Make page action icons use svgs in alpha - 10https://bugzilla.wikimedia.org/73391#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/da2UYple [21:55:32] mhurd: "Develop some new features in Swift?" is a high level assertion without much of a question being asked [21:55:44] That's the one that does have the targets set correctly :) [21:56:03] Its purpose is to sneak some extra data about banner allocations into the client without needing another round-trip [21:56:38] The next one, basically very small now but growing, will take that data and make a final decision about which banner to show on the client [21:56:42] That's fine. Just test on mobile is all I ask :-) The environment there is different, if you just merge code for desktop it's akin to putting a man on Mars without an oxygen mask :-) [21:56:58] There are a bunch of libraries we purposely don't load. [21:57:05] tfinc: i already knew the answers to the questions which were in the card. “What will it take to build the Wikipedia App as both Objective-C and Swift with *no* other changes?” - the answer is drop iOS 6 support. “What are existing features that we could rebuild in swift? and What are upcoming features that we could build in swift?” the answer is “all” and “all”. The answer to “Do we need to communicate exclusively Obj [21:57:05] Swift or also/instead Swift->Objective-C” is “huh?” :) [21:57:26] (03PS1) 10Jdlrobson: Hygiene: Make sure icon styles only run on older icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173111 [21:57:28] (03PS1) 10Jdlrobson: Hygiene: Cleanup mw-ui-icon specific code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173112 [21:57:38] jdlrobson: OK... really apreciate your pointing this out.... we do have some browser tests prepared or almost prepared... what do you suggest we do for Mobile testing? [21:57:49] jdlrobson: I'm wondering why we didn't break mobile on wikipedia... [21:58:03] awight: 'cause u didn't deloy there? [21:58:05] awight: it hasn't rode the train yet. We caught it before the branch was cut :) [21:58:10] basically we can convert/add classes in one language or the other on a class-by-class basis [21:58:14] though there are a few limitations [21:58:19] AndyRussG: at minimum, install MobileFrontend on your local instances via vagrant and test in a small browser window [21:58:23] swift classes can extend obj-c classes but not the other way around [21:58:28] jdlrobson: wat. I certainly did deploy to enwiki, at least I tried to. [21:58:28] which is usually fine [21:58:37] both can call each other [21:58:51] if you have upgraded your phone that you had in mexico and it's capable of wifi ;-) you can use ngrok service to share your localhost on web and connect to it via phone [21:58:56] mhurd: does that mean that we have an existing feature list of what can be migrated piece by piece ? [21:59:01] awight: you did?! [21:59:03] tfinc: i updated the questions [21:59:05] yeah [21:59:05] so that Dan can prioritize and schedule [21:59:09] uhoh [21:59:20] awight: yup you broke enwiki [21:59:27] you'll need to revert that change [21:59:42] awight: i [21:59:48] awight: i'm seeing the error all over the place. Not good. [21:59:58] Caches take around 5 minutes to clear [21:59:59] oooh boy [22:00:03] tfinc: i think we could do it piece-meal if we chose to since Obj-C and Swift can co-exist [22:00:13] mhurd: note Deskana recent email which answers some of those [22:00:19] depending on how you added this as well this could lead to some serious caching issues... [22:00:21] (03CR) 10Florianschmidtwelzow: [C: 031] "Problem: If someone wants to change beta modules (e.g. replace talk module with an own module) he can't do it anymore. But the hooks aren'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173109 (owner: 10Robmoen) [22:00:23] * jdlrobson takes a deeper look [22:00:24] mhurd: i want to know which of those bits we're likely to move first. i don't think we have that [22:00:29] its too easy to say all of it [22:00:49] awight: please revert asap though [22:00:55] or merge the fix [22:01:18] tfinc: probably we’d want to move some UI things initially [22:01:30] maybe the WebViewController where a lot of our front-end view logic lives [22:01:34] 3Wikipedia App / 3Android App: Similar pages link shows empty dialog - 10https://bugzilla.wikimedia.org/73393 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None Similar pages link shown on [[en:Test]] but when pressed it's empty. Even the headline text is missing. [22:01:47] or else we could drop in new separate embedded view controllers for things like the header image [22:01:53] without changing the core WebViewController [22:02:00] jdlrobson: mos def, I'm on it. I'm trying a fix, https://gerrit.wikimedia.org/r/173107 [22:02:19] awight: i haven't got central notice installed so this will take a while [22:02:37] tfinc: i updated the trello card again. [22:02:53] awight: to clarify though, all the mobile site including editing is down right now cc. Maryana [22:03:34] yes [22:03:36] aah [22:03:39] wat? [22:04:05] jdlrobson: Is it? Works fine for me. [22:04:11] Deskana: wait till your cache clears.. [22:04:13] jdlrobson: Other than that the edit pencil is incredibly misplaced. [22:04:22] And by incredibly I mean *incredibly*. [22:04:33] Deskana: yeh that's a symptom [22:04:37] (03PS1) 10Robmoen: Disable CentralNotice on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173119 [22:04:56] Maryana: CentralNotice made some changes that added code that isn't being loaded on mobile but is now needed on mobile and apparently lightning deployed them. [22:05:11] (03PS1) 10BearND: Fix issue where some disambig items were not picked up [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173120 (https://bugzilla.wikimedia.org/73393) [22:05:13] (03Abandoned) 10Robmoen: Disable CentralNotice on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172885 (owner: 10Robmoen) [22:05:27] jdlrobson: can u please remind me of the URL params to force the MobileFrontend? [22:05:36] ?useformat=mobile [22:05:39] thanks [22:05:40] ?mobileaction_toggle_view_mobile [22:05:41] or simply add m. in front of url [22:05:46] or so :P [22:05:53] (03PS2) 10Robmoen: Disable CentralNotice on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173119 [22:06:35] grr installing central notice is taking forever [22:07:05] * jdlrobson hugs FlorianSW whilst waiting for discovering this nasty bug [22:07:27] keep calm & fix the bugs :) [22:07:38] jdlrobson :D [22:07:47] fix fix fix :P [22:08:12] if anyone has it installed and can verify quicker that https://gerrit.wikimedia.org/r/#/c/173107/ makes it go away please do :) [22:08:43] jdlrobson: checked and give +1 :) [22:08:48] * already [22:08:59] jdlrobson: we're going with https://gerrit.wikimedia.org/r/173135 [22:09:07] (03CR) 10BearND: [C: 032] Scroll all the way up when first section in ToC clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173011 (https://bugzilla.wikimedia.org/73327) (owner: 10Dbrant) [22:10:31] awight: just to clarify: this patch worked fine locally: https://gerrit.wikimedia.org/r/#/c/173107/5 :? [22:10:50] (03PS2) 10BearND: Clear Wikidata cache when switching languages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173006 (https://bugzilla.wikimedia.org/73349) (owner: 10Dbrant) [22:11:03] (03CR) 10BearND: [C: 032] Clear Wikidata cache when switching languages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173006 (https://bugzilla.wikimedia.org/73349) (owner: 10Dbrant) [22:11:22] (03Merged) 10jenkins-bot: Clear Wikidata cache when switching languages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173006 (https://bugzilla.wikimedia.org/73349) (owner: 10Dbrant) [22:11:51] awight: i can confirm your fix makes the issue go away [22:11:59] if you want to deploy that instead [22:12:02] (03PS2) 10BearND: Scroll all the way up when first section in ToC clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173011 (https://bugzilla.wikimedia.org/73327) (owner: 10Dbrant) [22:14:23] (03CR) 10Bmansurov: Hygiene: Cleanup mw-ui-icon specific code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173112 (owner: 10Jdlrobson) [22:14:38] jdlrobson: rmoen: Maryana: ok the rollback has been deployed. Pls keep me posted! [22:14:56] cool, thanks for the fix awight :) [22:14:58] and: sorry, world! :) [22:15:10] it happens [22:15:19] awight: verified in debug mode. We just have to wait 5 mins and hope that there are not any long term cache problems :) [22:15:23] awight: the world forgives you [22:15:29] pfff yes apologies from me too... [22:15:48] awight: as penance, please review rmoen patch to hide CN in beta :D [22:15:55] *rmoen's [22:16:21] we forgive you, we learn through big catastrophic mistakes :-) [22:16:31] thanks FlorianSW for finding the bug! :) [22:16:35] dbrant, any idea about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7954263 ? [22:16:48] is it just giving some exception to them that is interpreted as a network error? [22:16:49] jdlrobson: np :P [22:17:11] yes thanks.... [22:17:22] jdlrobson, awight: and confirmed on english WP: all working now :) [22:17:29] AndyRussG: ^ [22:17:31] * awight faints [22:17:51] (03CR) 10Jdlrobson: [C: 032] Fix grep errors on pre-commit (dev-scripts/pre-commit) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173042 (owner: 10Jhernandez) [22:17:56] awight: deep breath... [22:18:14] Krenair: no idea... :( maybe a slight chance of some kind of SSL issue, but we would need a lot more information. [22:18:22] (03CR) 10Jdlrobson: [C: 032] Make make jscs use grunt jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173041 (owner: 10Jhernandez) [22:18:27] now i go to bed :) good night all! [22:19:10] (03CR) 10Bmansurov: [C: 032] Hygiene: Make sure icon styles only run on older icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173111 (owner: 10Jdlrobson) [22:19:30] dbrant, should I ask if they can browse to the HTTPS mobile site perhaps? [22:19:55] Krenair: sure, but it's just a guess. [22:22:02] (03CR) 10Jdlrobson: [C: 04-1] "I have no idea why but `make qunit` doesn't work for me with this patch" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [22:23:26] blah irc lag [22:23:33] (03PS2) 10Jdlrobson: Make make jscs use grunt jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173041 (owner: 10Jhernandez) [22:23:39] (03CR) 10Jdlrobson: [C: 032] Make make jscs use grunt jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173041 (owner: 10Jhernandez) [22:24:00] (03Merged) 10jenkins-bot: Hygiene: Make sure icon styles only run on older icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173111 (owner: 10Jdlrobson) [22:24:12] rmoen: https://github.com/jdlrobson/gerrit-be-nice-to-me [22:24:27] :) [22:24:55] (03Merged) 10jenkins-bot: Make make jscs use grunt jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173041 (owner: 10Jhernandez) [22:25:15] (03CR) 10Florianschmidtwelzow: "Shouldn't it be disabled in stable and enabled in beta (to test)?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173119 (owner: 10Robmoen) [22:26:16] Thanks again everyone for the help!!!!!!! [22:27:14] Hey MaxSem! Did the Dr appt go OK? [22:27:26] eh [22:27:30] not sure :P [22:29:12] MaxSem: are you up for doing a deployment? Greg granted us a 1-time window this afternoon. [22:29:39] I'd rather not deploy when dizzy [22:29:50] can break stuff:) [22:29:57] (03CR) 10Dbrant: [C: 04-1] "The tests seem to be failing for the "ne" and "ne_np" locales..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173092 (owner: 10BearND) [22:29:59] MaxSem: No problem. I think I can handle it. [22:30:20] thanks [22:32:16] (03PS1) 10Bmansurov: Indend list of languages on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) [22:32:44] (03PS2) 10Bmansurov: Indent list of languages on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) [22:32:46] (03PS7) 10MaxSem: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 [22:32:48] (03PS11) 10BearND: Hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 (owner: 10Dbrant) [22:33:13] (03CR) 10BearND: [C: 032] Hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 (owner: 10Dbrant) [22:33:25] (03CR) 10MaxSem: DB store [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/170263 (owner: 10MaxSem) [22:33:33] (03Merged) 10jenkins-bot: Hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 (owner: 10Dbrant) [22:33:41] kaldari, ^^ can be merged? [22:34:11] MaxSem: Yes, but not until tomorrow [22:35:52] dbrant: Strangley enough, the tests pass for me. Would you send me the test failure output? [22:37:40] MaxSem: So when you're updating a deployment branch to master, what do you do after you've done git pull in the extension? Obviously we don't want to cherry-pick, and doing git merge --ff-only doesn't work because there is the "Creating new branch" change in the deployment branch already. [22:38:18] MaxSem: do we do a git merge without --ff-only? [22:38:28] kaldari, just create a copy of that branch for backup and recreate it from master [22:38:34] OK [22:39:14] bearND: sent [22:39:54] dbrant: we don't have our own translations for "ne" so it must be picking up something from the Android SDK. [22:43:24] dbrant: hmmm, I guess that's not it, since I see nearby strings in there. I've seen language aliases being tested separately. I guess I'll just need to add ne to the exception list for the number formats. [22:43:43] dbrant: Still weird that I don't see it. What device did you test this on? [22:44:18] dbrant: nm, i see it [22:45:00] dbrant: I think your device has an extra locale or two that mine doesn't. [22:45:07] bearND: the test is passing on my Galaxy S3 (4.3), but not on my 4.4 device... [22:46:07] dbrant: I thought it was the other way around. The file you sent me (with the failure) was with the S3 [22:46:40] bearND: sorry, passing on my Galaxy S4 (4.3), failing on Galaxy S3 (4.4) lol [22:46:58] dbrant: good [22:49:42] (03PS2) 10BearND: Fix translations and add more tests for them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173092 [22:50:56] bearND: can you make it 'startsWith("ne")'? it still fails for "ne_np" [22:58:18] (03PS10) 10Alex Monk: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 [22:58:23] dbrant: sure [22:58:41] Maryana: About to try this crazy deployment. Can you doublecheck that MF and WikiGrok seem to be working OK on Beta Labs? [22:58:54] (03PS3) 10BearND: Fix translations and add more tests for them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173092 [23:00:10] dbrant, yeah, I probably didn't actually test PS8/PS9 on my commit :) [23:04:35] (03CR) 10Dbrant: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172920 (owner: 10BearND) [23:05:02] (03CR) 10Dbrant: [C: 032] Fix translations and add more tests for them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173092 (owner: 10BearND) [23:06:01] (03PS2) 10Robmoen: Fix grep errors on pre-commit (dev-scripts/pre-commit) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173042 (owner: 10Jhernandez) [23:06:22] (03CR) 10Robmoen: [C: 032] Fix grep errors on pre-commit (dev-scripts/pre-commit) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173042 (owner: 10Jhernandez) [23:07:07] (03Merged) 10jenkins-bot: Fix grep errors on pre-commit (dev-scripts/pre-commit) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173042 (owner: 10Jhernandez) [23:08:15] (03CR) 10Dbrant: [C: 032] Fix issue where some disambig items were not picked up [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173120 (https://bugzilla.wikimedia.org/73393) (owner: 10BearND) [23:08:58] (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [23:13:40] jdlrobson, rmoen: Since I'm deploying from master, can you guys hold off on merging anything for the next hour or so? [23:13:54] just so it doesn't get confusing [23:16:50] ok [23:21:31] (03CR) 10Dbrant: Don't show title or lead image block on Main page(s). (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 (owner: 10Dbrant) [23:21:41] (03PS2) 10Dbrant: Don't show title or lead image block on Main page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 [23:26:39] bearND: regarding https://gerrit.wikimedia.org/r/173087 , what did you mean in the commit message? Recent searches are still not visible in production. (should they be?) [23:31:00] dbrant: you've removed the block on line 361 in https://gerrit.wikimedia.org/r/#/c/173087/2/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java [23:31:45] dbrant: but ok, now I see that the comment meant to just remove the if check [23:32:08] bearND: right; that simply removes the button from the ActionBar. Now the button is in the recent "panel", which is still hidden in prod. [23:32:41] Maryana, wanna make me a card to investigate WDQ? [23:33:03] (03PS3) 10Dbrant: Styling tweaks for Search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173087 [23:33:19] dbrant: where is it hiding it for prod? [23:34:33] bearND: line 325 and 293 are preventing it from being shown [23:35:05] mhurd: roughly how many testflight users do we have? [23:35:17] tfinc: checking... [23:35:29] dbrant: ah, good then [23:36:12] tfinc: 598 [23:36:19] 3MobileFrontend / 3alpha: Table of contents icon in alpha is small and not aligned correctly - 10https://bugzilla.wikimedia.org/73115#c3 (10Rob Moen) The carrot icon on the right. It should be centered like the typical toggle icon. [23:36:59] tfinc: ooh new recruits! make that 787 [23:37:19] ok thanks [23:43:53] (03CR) 10BearND: [C: 032] Styling tweaks for Search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173087 (owner: 10Dbrant) [23:44:14] (03Merged) 10jenkins-bot: Styling tweaks for Search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173087 (owner: 10Dbrant) [23:44:18] MaxSem: yes! [23:48:07] (03PS1) 10Kaldari: Removing spinner from Thanks interface in WikiGrok v B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173199 [23:49:20] jdlrobson: Can you merge https://gerrit.wikimedia.org/r/#/c/173199/ . Looks like there was a regression that I didn't notice until I looked at it on test.wiki. [23:49:34] jdlrobson: I can show you the regression if you're interested [23:49:49] (03PS3) 10BearND: Don't show title or lead image block on Main page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 (owner: 10Dbrant) [23:50:02] (03CR) 10BearND: [C: 032] Don't show title or lead image block on Main page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 (owner: 10Dbrant) [23:50:19] (03Merged) 10jenkins-bot: Don't show title or lead image block on Main page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173018 (owner: 10Dbrant) [23:51:41] (03PS3) 10Mhurd: In-article search with WikiData short descriptions. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 [23:53:01] 3Wikipedia App / 3General/Unknown: Disable translations to wuu and lzh? - 10https://bugzilla.wikimedia.org/73295#c1 (10Bernd Sitzmann) I was not aware that those were enabled. I haven't seen any translations in those languages coming in from TWN yet. [23:53:57] (03CR) 10Jdlrobson: [C: 032] Removing spinner from Thanks interface in WikiGrok v B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173199 (owner: 10Kaldari) [23:53:57] jdlrobson: If you're busy I can ask rmoen [23:54:02] nevermind :) [23:54:12] jdlrobson: Thanks!! [23:54:17] :) ^ [23:54:36] (03Merged) 10jenkins-bot: Removing spinner from Thanks interface in WikiGrok v B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173199 (owner: 10Kaldari) [23:57:32] I am struggling to keep the mobile OTRS queue below 600.