[00:00:50] Krenair: Is that in general or especially for today (due to the JS outage)? [00:01:18] general [00:01:25] It's mostly about mobile apps [00:01:30] ah [00:02:02] Krenair: is there not a mechanism to automatically discard tickets older than x days? [00:02:18] If there was, we would not use it. [00:03:10] We can't just ignore tickets because no one has been able to answer yet [00:08:10] dbrant: Coming to this meeting? :-) [00:08:21] jdlrobson: rmoen: [00:08:34] jdlrobson: rmoen: if you have a minute to look at this patch... https://gerrit.wikimedia.org/r/173198 [00:08:35] awight: sup [00:08:37] ok [00:08:43] I'm trying to reintroduce those squirrely modules... [00:09:17] YuviPanda, are you supposed to still be listed under Mobile Apps on the staff list? [00:09:19] also, if you could suggest a testing strategy? I can deploy to beta and browse around with ?useformat=mobile... is that good enuf? [00:10:46] awight: will you give 173110 a push since it was rebased / [00:10:46] ? [00:12:38] Maryana: Latest WikiGrok is up on test.wiki now if you want to test [00:13:03] https://test.m.wikipedia.org/wiki/MegaMan?wikidataid=Q9685 [00:13:36] awesome [00:13:41] rmoen: definitely! [00:14:56] Maryana: Especially good to check would be to see if the eventlogging is logging everything correctly [00:15:11] on it :) [00:16:28] hmm, how do i get out of the bucket? [00:16:31] kaldari: ^ [00:16:44] Maryana: Delete the cookie [00:16:50] kk [00:17:07] Maryana: You may have to delete several times to get in the other bucket since it's random. [00:17:35] Maryana: You can also use 'wikigrokversion=A' or 'wikigrokversion=B' in the query string to force a version [00:17:42] ok, sweet [00:17:47] i've only seen version a so far [00:18:02] but i've only tried 2 times :) [00:18:28] Maryana: You may need to try infinite times ;P [00:26:38] hmm.. still only version a [00:26:42] have you seen version b, kaldari ? [00:26:54] (03PS1) 10Jdlrobson: Remove code powering talk count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173213 [00:26:56] (03PS1) 10Jdlrobson: Hygiene: Remove dead code paths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 [00:26:58] (03PS1) 10Jdlrobson: Turn page action icons in alpha into SVGS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173215 [00:26:59] yes :) [00:27:13] Maryana: But only by forcing it [00:27:21] :-/ [00:28:02] Maryana: Are you removing all your cookies, or just one? [00:29:08] i'm deleting safari cookies [00:29:17] still no v. b [00:29:22] not impossible, but unlikely.. [00:29:27] hmmm [00:29:33] have you tested it on a phone? [00:30:21] Maryana: I just got version B without forcing it, but not on a phone [00:31:03] 3Wikipedia App / 3Android App: NPE from page.ToCHandler.scrollToSection - 10https://bugzilla.wikimedia.org/73402 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.NullPointerException at org.wikipedia.page.ToCHandler.scrollToSection(ToCHandler.java:90) at org.wikipedia.page.ToCHandler.access$3... [00:32:06] kaldari: hmm, and now after clearing cookies again, i get nothing [00:32:32] 3Wikipedia App / 3Android App: NPE from android.webkit.WebViewClassic.setBaseLayer? - 10https://bugzilla.wikimedia.org/73403 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.NullPointerException at android.webkit.WebViewClassic.setBaseLayer(WebViewClassic.java:4953) at android.webkit.WebViewC... [00:33:24] (03CR) 10Jdlrobson: [C: 04-1] Indent list of languages on tablet (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) (owner: 10Bmansurov) [00:33:26] and there's this in the error log: no-impression-not-enough-suggestions [00:33:44] oh wait, that's not me [00:33:47] that's from a logged in user [00:34:01] Maryana: Are you using wikidataid=? [00:34:06] yeah [00:34:09] hmm [00:34:17] 3Wikipedia App / 3Android App: "IndexOutOfBoundsException: Invalid index 2, size is 2" from page.PageViewFragmentInternal.displayNonLeadSection - 10https://bugzilla.wikimedia.org/73404 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.IndexOutOfBoundsException: Invalid index 2, size is 2 at ja... [00:34:31] checking [00:35:01] (03CR) 10Jdlrobson: [C: 032] Disable CentralNotice on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173119 (owner: 10Robmoen) [00:35:17] Maryana: lol [00:35:43] Maryana: Sorry, that's because my mini A/B test window expired! [00:35:53] ? [00:36:52] (03Merged) 10jenkins-bot: Disable CentralNotice on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173119 (owner: 10Robmoen) [00:36:59] Maryana: I wasn't expecting the deployment to take this long, so I only set a 1 hour A/B test for testing :) [00:37:11] lemme try that again.... [00:37:15] (03CR) 10Jdlrobson: [C: 04-1] "This makes it impossible to load Flow on a page which has a Flow page. That said this is hacky we should find a better way to do it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173109 (owner: 10Robmoen) [00:37:49] oh, hehe [00:38:21] (03CR) 10Jdlrobson: Hygiene: Cleanup mw-ui-icon specific code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173112 (owner: 10Jdlrobson) [00:38:56] (03CR) 10Jdlrobson: [C: 032] Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [00:39:38] (03Merged) 10jenkins-bot: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [00:41:08] (03CR) 10Jdlrobson: [C: 04-1] Style links in Overlay header like buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [00:42:35] (03PS2) 10Jdlrobson: Hygiene: Consistent file naming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172902 (https://bugzilla.wikimedia.org/73342) [00:42:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Consistent file naming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172902 (https://bugzilla.wikimedia.org/73342) (owner: 10Jdlrobson) [00:42:55] Maryana: OK, you now have another hour for testing. My have to clear your cache though [00:44:04] * Maryana tests [00:44:13] (03CR) 10Bmansurov: Indent list of languages on tablet (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) (owner: 10Bmansurov) [00:44:19] jdlrobson: ^ [00:45:44] kaldari: omggg, still only version a [00:45:47] @_@ [00:46:09] what kind of crazy cookie are we setting? [00:46:31] (03CR) 10Jdlrobson: Indent list of languages on tablet (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) (owner: 10Bmansurov) [00:47:50] 3Wikipedia App / 3Android App: Reports about issues with Chinese variants - 10https://bugzilla.wikimedia.org/73405 (10Alex Monk) 3UNCO p:3Unprio s:3normal a:3None Related tickets: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7779837 https://ticket.wikimedia.org/otrs/ind... [00:47:51] (03PS6) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 [00:48:32] Maryana: I just got V B on a phone without forcing :) [00:49:51] (03Abandoned) 10Jdlrobson: Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [00:51:38] kaldari: howww? [00:51:43] what wizardry did you use?? [00:52:08] Maryana: Don't sweat it, you're just stuck in a statistical anomaly [00:52:30] (03PS3) 10Bmansurov: Indent list of languages on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) [00:55:36] kaldari: finally! [00:56:33] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [00:57:10] ok, so let's go ahead & run this test for real now :) [01:01:06] kaldari: Maryana did i hear `celebratory beer`? [01:01:59] jdlrobson: inception! [01:02:08] :D [01:02:11] when are we going? [01:02:14] rmoen: you in? [01:02:21] get you another $7 beer [01:08:12] we have to wait for kaldari to deploy the a/b test to enwiki [01:09:32] k k k [01:09:34] k [01:11:27] woah [01:11:35] you gotta be careful with the number of ks there... [01:14:50] (03PS3) 10Jdlrobson: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx) [01:15:32] (03PS3) 10Dbrant: Make content horizontally scrollable on a per-div basis. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 [01:16:48] (03CR) 10Jdlrobson: [C: 031] "I wonder if there is a way we don't even need to be aware that spinner is a class..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx) [01:22:28] (03PS1) 10Dbrant: Fix Main Page title hiding in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 [01:23:30] Maryana: it's on en.wiki now [01:23:48] Maryana: You have about 15 minutes to test it [01:23:52] wheee [01:31:08] (03PS7) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 [01:31:10] (03PS1) 10Jdlrobson: WIP: Don't add things to the DOM in postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173227 [01:31:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Don't add things to the DOM in postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173227 (owner: 10Jdlrobson) [01:55:52] (03PS4) 10Mhurd: In-article search with WikiData short descriptions. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 [02:01:57] (03PS5) 10Legoktm: In-article search with Wikidata short descriptions. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 (owner: 10Mhurd) [02:03:27] legoktm: doh! :) [02:03:31] :) [03:02:05] tfinc: email sent [03:34:35] (03PS1) 10Mhurd: Update search box styling to look same on iOS 6, 7 and 8. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173231 [03:37:49] brion: hey quick question - do yo u have a field in you file system proj for the wikidata short description? it would be awesome to be able to save off the short descriptions we’re getting when we search to the fs so the saved pages and history could show ‘em :) [03:38:08] no but i could totally add that :D [03:38:18] brion: yay! [03:39:40] brion: ^ small patch above for ya. it styles the search box on iOS 6 correctly - it had been all weird [04:30:30] 3Wikipedia App / 3Android App: Reports about issues with Chinese variants - 10https://bugzilla.wikimedia.org/73405#c1 (10Bernd Sitzmann) Bug 32906 is related but predates the new app. Most of the linked OTRS reports are before we enabled language variants for Chinese in the Android app in August: https://ge... [04:38:11] (03PS1) 10Mhurd: Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 [04:39:13] (03PS2) 10Mhurd: Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 [04:51:57] (03CR) 10BearND: "It was working fine on my 2.3 device before that, too. What did I miss?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 (owner: 10Dbrant) [05:04:46] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173234 [05:16:53] (03PS1) 10BearND: More TranslationTest improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173235 [05:52:22] (03PS1) 10BearND: Use menu_clear_all_recent_searches string in translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173236 [05:54:15] (03CR) 10BearND: [C: 032] "Just string changes. Want to expedite this so I can send this to TWN." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173236 (owner: 10BearND) [05:54:35] (03Merged) 10jenkins-bot: Use menu_clear_all_recent_searches string in translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173236 (owner: 10BearND) [05:54:56] (03Abandoned) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173234 (owner: 10BearND) [06:02:02] (03PS1) 10BearND: Removed unused menu file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173237 [06:08:38] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173239 [06:11:36] (03CR) 10BearND: "Any good pages to try this on?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [06:15:06] (03PS2) 10BearND: Removed unused menu file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173237 [06:15:24] (03CR) 10BearND: [C: 032] "Sorry, the build was broken" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173237 (owner: 10BearND) [06:15:42] (03Merged) 10jenkins-bot: Removed unused menu file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173237 (owner: 10BearND) [06:21:31] (03PS2) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173239 [06:22:36] (03CR) 10BearND: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173239 (owner: 10BearND) [06:22:54] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173239 (owner: 10BearND) [06:23:07] (03PS2) 10BearND: More TranslationTest improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173235 [06:42:12] (03PS2) 10Florianschmidtwelzow: Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) [07:14:55] so any chance of adding .mobi format to the render engine and sticking the option in the beta ?? [07:16:38] (03PS6) 10Mhurd: In-article search with WikiData short descriptions. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 [07:18:05] (03PS3) 10Mhurd: Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 [08:24:26] tfinc: What is an all ritual? [08:24:39] tfinc: What is an "app ritual" ownership? [09:51:30] morning all [10:04:38] hi [10:06:36] * phuedx is brewing a cup of coffee [10:10:24] currently brewing these: http://www.workshopcoffee.com/collections/coffee/products/gikirima [10:10:41] ☕️ [10:11:25] phuedx: is it worth it? i don't know much about coffee, here we take them short and very intense [10:13:37] joakino: for me, yes [10:13:51] i drink coffee for the taste [10:14:04] aha [10:14:07] the caffeine is an incredibly useful, but still secondary, thing [10:14:23] phuedx: i though english had a thing for tea [10:14:29] yeah [10:15:48] i grew up drinking tea [10:15:56] but now it tastes like hot bath water [10:16:00] hahaha [10:16:22] i started drinking coffee 4 years ago [10:16:47] when i listened to a software development podcast that had an episode about roasting/brewing coffee [10:16:50] i haven't looked back [10:17:10] it took me three years to train my palette though… [10:17:14] awesome [10:17:50] i own 5 different brewers, buy beans every two weeks from all around europe, brew daily [10:17:55] take notes [10:18:04] it's a ritual [10:18:13] yeah, and a great hobbie [10:18:39] i'll be bringing some beans and my grinder/brewer-for-travelling when i come over in january [10:19:01] i could bring my stove top as well, if you want to feel at home ;) [10:19:11] * joakino salivates [10:19:27] careful with the tsa xd [10:21:23] done it before, they didn't seem to care [10:21:52] 👍 then [10:21:53] although i couldn't find any definite rules on roasted coffee beans [10:22:00] so i assumed that it was ok [10:22:14] if they are "industrially" packaged it should be fine [10:22:25] and they are processed, so it shouldn't matter [10:22:32] ^ that [10:22:43] but try finding the thing online that says it clearly [10:22:46] with bullet points [10:22:48] and numbers [10:23:36] yeah [10:24:11] when I went i had a bag with peanuts, nuts and almonds, and the agent told me it was fine because it was processed food [10:24:29] worst case scenario, tsa agent walks home with a good pack of coffee [10:43:42] ya [10:43:48] there are a couple of great roasters in sf [11:03:34] in particular: http://www.sightglasscoffee.com/ [12:44:26] (03PS4) 10Phuedx: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [12:44:28] (03PS4) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 [12:44:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [12:44:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx) [12:47:57] (03PS5) 10Phuedx: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [12:47:59] (03PS5) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 [12:52:05] (03CR) 10Phuedx: "This is no longer borked in alpha, but both the icon- and mw-ui-icon-spinner look a little small." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [12:54:06] george is up so i'm going to break for lunch [12:54:31] 3Wikipedia App / 3Android App: Reports about issues with Chinese variants - 10https://bugzilla.wikimedia.org/73405#c2 (10Alex Monk) 5UNCO>3RESO/INV OK, thanks. I've resolved all the tickets. [12:55:07] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/E_07gw [12:55:07] 13WikipediaMobile/06master 14da5c960 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [13:45:04] back [14:14:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Right, flow uses it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173109 (owner: 10Robmoen) [14:18:24] (03CR) 10Dbrant: "Interesting; on my 2.3 device, the Main page loads fine, but then if I start scrolling it, the lead image (placeholder) appears, and fills" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 (owner: 10Dbrant) [15:02:26] (03PS4) 10Dbrant: Prevent pages from being horizontally scrollable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 [15:05:27] (03PS5) 10Dbrant: Prevent pages from being horizontally scrollable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 [15:08:35] i'm back http://1.bp.blogspot.com/-Uo8h2jHcg94/Ur0kuhd4-vI/AAAAAAAAAd4/J55LGKEu2kw/s1600/ImBack1.png [15:13:01] (03CR) 10Dbrant: "A few pages for testing:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [15:15:16] 3MobileFrontend / 3General/Unknown: Unregistered editing shouldn't require 3 clicks - 10https://bugzilla.wikimedia.org/72852#c9 (10Aaron Halfaker) The data is not out here. We have lots of evidence that making the "continue editing" default or at least more prominent is desired. > login/signup should be... [15:35:00] 3MobileFrontend / 3General/Unknown: Mobile watchstar QUnit tests failing in Firefox - 10https://bugzilla.wikimedia.org/73383#c2 (10Jhernandez) I've tried to reproduce it, no luck with head on everything. What I get is this (probably unrelated) Unsafe JavaScript attempt to access frame with URL about:blank... [15:37:18] (03Abandoned) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [15:37:33] (03PS1) 10Florianschmidtwelzow: Hygiene: Remove mw-ui-block from links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 [15:41:09] (03CR) 10Florianschmidtwelzow: "I still prefer the neutral buttons :/ Jon, what we should do now? Ask a designer?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [15:45:18] 3Wikipedia App / 3Android App: Math formulas not visible when MathML is enabled. - 10https://bugzilla.wikimedia.org/73419 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None When a user is logged in, and the user's preferences include displaying math formulas in MathML (settable in desktop website), th... [16:05:14] (03CR) 10Jhernandez: Tools: Run make qunit (and qunitdebug) with grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [16:06:22] (03CR) 10Jhernandez: "I'm going to ping the rest of us to see if somebody else has this problem." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [16:08:56] (03PS1) 10Dbrant: Display fallback math images when MathML is enabled. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173285 (https://bugzilla.wikimedia.org/73419) [16:26:43] (03PS1) 10Dbrant: Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 [16:27:10] (03CR) 10jenkins-bot: [V: 04-1] Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 (owner: 10Dbrant) [16:28:55] (03PS2) 10Dbrant: Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 [16:44:45] (03CR) 10Dbrant: [C: 032] Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [16:47:36] (03CR) 10Dbrant: [C: 032] More TranslationTest improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173235 (owner: 10BearND) [16:50:55] (03PS1) 10Dbrant: Oops, don't fetch the lead image twice! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173302 [16:52:17] (03PS4) 10Jhernandez: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 [16:52:23] (03CR) 10jenkins-bot: [V: 04-1] Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [16:52:43] (03CR) 10Jhernandez: Add tests to WikiGrokDialogB (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [16:55:47] (03CR) 10Dbrant: "NB: the lead image is (correctly) fetched on line 411." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173302 (owner: 10Dbrant) [16:56:30] (03CR) 10Phuedx: "Same. make qunit/qunitdebug don't WFM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [16:57:03] gotta go [16:57:08] bb phuedx [16:57:19] o/ [16:58:57] (03CR) 10Phuedx: "Jdlrobson: this patch feels quite large, despite making 3 (I think) changes. Do you think it could be made smaller? If so, how?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [17:06:55] (03PS1) 10Phuedx: Tidy up WikiGrok\Api\ApiResponse unit tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173311 [17:08:02] (03PS2) 10BearND: Fix Main Page title hiding in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 (owner: 10Dbrant) [17:08:18] (03PS3) 10BearND: Fix Main Page title hiding in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 (owner: 10Dbrant) [17:11:58] (03CR) 10BearND: [C: 032] Fix Main Page title hiding in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 (owner: 10Dbrant) [17:12:17] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c24 (10Kelson [Emmanuel Engelhart]) @Sam Thank you for trying to push this bug/patch. I have explained in https://bugzilla.wikimedia.org/show_bug.cgi?id=54885#c... [17:12:17] (03Merged) 10jenkins-bot: Fix Main Page title hiding in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173226 (owner: 10Dbrant) [17:14:27] (03PS2) 10BearND: Oops, don't fetch the lead image twice! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173302 (owner: 10Dbrant) [17:14:35] (03CR) 10BearND: [C: 032] Oops, don't fetch the lead image twice! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173302 (owner: 10Dbrant) [17:14:48] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422 (10Quim Gil) 3NEW p:3Unprio s:3normal a:3None The mobile watchlist now shows up / down arrows in the left column, next to the number of characters changed. I li... [17:14:54] (03Merged) 10jenkins-bot: Oops, don't fetch the lead image twice! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173302 (owner: 10Dbrant) [17:15:31] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/HgwV3cVF [17:21:35] dbrant: what's the reason to exclude 2.3 in https://gerrit.wikimedia.org/r/#/c/165870/5/www/js/transforms.js? [17:24:30] (03PS6) 10BearND: Prevent pages from being horizontally scrollable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [17:24:39] (03CR) 10BearND: [C: 032] Prevent pages from being horizontally scrollable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [17:24:52] bearND: in 2.3, the cropped content doesn't actually become scrollable anymore; it just gets chopped off. (you observed it in your comment in PS2) [17:24:59] (03Merged) 10jenkins-bot: Prevent pages from being horizontally scrollable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [17:31:55] (03CR) 10BearND: [C: 04-1] Display fallback math images when MathML is enabled. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173285 (https://bugzilla.wikimedia.org/73419) (owner: 10Dbrant) [17:33:13] bearND: ^ I think there's a better solution for that, anyway... [17:33:38] dbrant: couldn't really repro the issue [17:34:32] bearND: you need to go to your account settings on Desktop, and enable MathML (Preferences -> Appearance) [17:34:54] dbrant: I did that, and relogged in on the the app and reloaded the page [17:35:33] dbrant: i'm using the latest master [17:35:50] bearND: curious. are you sure the page wasn't reloaded from cache? [17:36:16] dbrant: could be. ok, I'm trying a new one [17:38:24] dbrant: ok, I se it now. Doesn't happen with every formula. I notice it because it had a reference hanging off by itself. ;) [17:44:06] Hey phuedx, can you do me a favor? paste the hangout link fo rthe mobile web standup? I’m temp locked out of WMF google stuff. so I’m going to see if I can connect with my personal gmail account. [17:45:15] you're locked out of your google apps account? [17:46:04] Krenair: I managed to lock myself out, yes ;-) [17:46:13] ah [17:46:24] Workign with IT on it now. [17:48:32] sorry kristenlans -- am in a meeting [17:48:35] sec [17:54:45] Hey bmansurov! Would you mind sneding me the mobile web hangout link? [17:54:56] sure [17:55:01] thx [17:55:14] kristenlans: https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.abvfhue9msa07tgt4d9v4s0u1g?authuser=0 [17:55:15] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c2 (10Jon) Quim can you elaborate on what you are seeing? I don't see up/down arrows. Although I do see them on the diff page... e.g. https://en.m.wikipedia.org/wiki/Sp... [17:55:47] 3MobileFrontend / 3Feature requests: Specify alternative home page for mobiles - 10https://bugzilla.wikimedia.org/73425 (10Ian Tresman) 3NEW p:3Unprio s:3enhanc a:3None My desktop MW 1.23.5 shows a particular home page (specified with MediaWiki:Mainpage. I couldn't see the option, but it would be use... [17:57:08] thx bmansurov :-) [17:57:22] np [17:59:39] (03PS1) 10Robmoen: Scrolling on reference drawers in every mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173316 [18:00:04] (03PS1) 10Dbrant: Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 [18:00:28] Ah crap: “You’re not allowed to join this video call” [18:00:31] bearND: ^ much simpler [18:00:32] 3MobileFrontend / 3Feature requests: Specify alternative home page for mobiles - 10https://bugzilla.wikimedia.org/73425#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BtSphgTI [18:01:19] (03Abandoned) 10Dbrant: Display fallback math images when MathML is enabled. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173285 (https://bugzilla.wikimedia.org/73419) (owner: 10Dbrant) [18:01:52] bmansurov would you mind telling the gang I can not log in to hangout for standup? :-( [18:02:01] Having some googly issues [18:02:02] kristenlans: I already did [18:02:04] we started [18:02:05] thx :-) [18:02:30] 3Wikipedia App / 3Android App: Math formulas not visible when MathML is enabled. - 10https://bugzilla.wikimedia.org/73419#c3 (10Dmitry Brant) Simpler patch that fixes it: https://gerrit.wikimedia.org/r/173317 [18:05:42] * brion wants his android 5.0 OTA updates [18:11:08] Hey brion, I am currently unable to log in to my WMF google accoutns and will not be able to participate in standup. Woudl you mind lettign the team know? [18:11:15] d’oh [18:11:19] yeah [18:11:27] i’m at home office today [18:11:43] but will let them know over hangout :D [18:11:48] or we could create a new hangout maybe [18:12:02] heh [18:12:05] “Don't get locked out of your Google Account” [18:12:12] what timing [18:12:38] yeah it’s prety much a blocker for ALL THE THINGS [18:12:40] :) [18:12:52] i probably don’t have permissions to change the room settings but lemme check [18:13:16] kristenlans: hey i can invite someone, lemme try inviting your personal acct [18:13:26] ah cool, kristenlans@gmail.com [18:13:58] ok that might or might not be working [18:14:13] hehe ok I’ll keep an eye out, thx brion [18:14:21] good luck [18:17:51] hey jdlrobson [18:18:12] https://gerrit.wikimedia.org/r/#/c/173215 looks great [18:18:17] apart from the .DS_store ;) [18:23:22] (03PS8) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 [18:23:29] (03PS7) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 [18:23:37] (03PS2) 10Jdlrobson: Species infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170434 [18:23:43] (03PS3) 10Jdlrobson: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 [18:24:00] phuedx: :D [18:24:05] lolz [18:24:13] phuedx: let me remove that now [18:24:24] phuedx: should probably add DSStore to ignore list [18:24:33] yarrrp [18:24:59] (03PS2) 10Jdlrobson: Turn page action icons in alpha into SVGS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173215 [18:25:15] jdlrobson: where's the wikidata infobox on people patch? [18:26:44] Maryana et al, sorry I couldn’t make standup. Any major blockers/thing sblowing up? :-) [18:26:45] (03PS1) 10Jdlrobson: Hygiene: Add DS_Store to git ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173327 [18:27:14] kristenlans: nope, we're good :) a/b test is running! [18:27:25] woohoo! [18:28:00] Maryana: https://gerrit.wikimedia.org/r/#/c/172932/2 [18:28:05] although the follow up patch adds images [18:28:09] i need someone to review that code [18:28:43] Maryana: what's the event rate? [18:29:07] phuedx: so you wanted me to look at the loader stuff? [18:29:21] * Maryana cheks [18:29:24] *checks [18:29:31] yeah, the sizing with both icon- and mw-ui-icon classes is off [18:29:45] and i think the change is quite large [18:29:52] phuedx: interesting. I like the factory idea [18:30:14] yeah? it gave the thing i typed out loads of times a name [18:30:25] naming things is hard/useful :) [18:31:03] phuedx: shouldn't $btn.next( '.spinner' ).remove(); be replaced with icon.remove() ? [18:31:14] darn [18:31:15] yes [18:31:46] also we don't need to put mw in the global context ( function ( M, $, mw ) { [18:31:52] it's a global already in mobile mode :) [18:32:04] also seems unused? [18:32:06] phuedx: 50 uniques have seen it so far... [18:33:01] 7 successful answers [18:34:53] (03CR) 10Maryana: [C: 032] "It's alpha. Let's do it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172932 (owner: 10Jdlrobson) [18:35:19] aww yeah [18:35:37] nothing like the smell of +2 in the morning [18:36:54] Awwww there’s wikigrok on teh featured article! [18:37:34] really?? awesome! [18:37:53] Well, kind of… [18:38:12] phuedx: apart from those things i like it [18:38:19] if you can fix it up we can get it merged :) [18:38:20] yes, there it is [18:38:33] niiice. that's going to get some pageviews :) [18:38:53] DarTar: ^ [18:38:58] jdlrobson: icon.remove, mw global? [18:39:15] hey Maryana [18:39:28] ha ha cool [18:39:28] jdlrobson: is there an established way to make the icons a /little/ bit larger? [18:39:34] :D [18:39:42] (03CR) 10Jdlrobson: [C: 04-1] "I think the use of div's here is a case of div-it-us and should be avoided." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 (owner: 10Florianschmidtwelzow) [18:39:43] now, did you guys see my early QA results? [18:39:51] no, where are they? [18:39:55] trello [18:40:04] which board? research & data? [18:40:06] Maryana: https://trello.com/c/ZmvY9dev/32-spike-1h-help-dario-qa-data-collection-bucketing [18:40:17] ah [18:40:24] phuedx: in the new brave world there are going to be only 2 icon sizes [18:40:35] 24px (icon) 16px (indicator) [18:40:35] the main concern at the moment is that we’re not capturing responses at all [18:40:42] to avoid having to use background-size which is not widely supported [18:40:52] (well on some key browsers it doesn't work anyhow) [18:40:59] per bmansurov [18:41:07] jdlrobson: okie poke -- it's just that the patch reduces the size of the spinner [18:41:28] DarTar: hmm, weird.. i see the responses from my testing from yesterday [18:41:50] (03CR) 10Jdlrobson: [C: 04-1] "Exception thrown by mobile.notifications Error: Module not found: icons Error: Module not found: icons" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [18:42:23] but you're right, nothing after that [18:43:16] (03CR) 10Phuedx: [C: 032] Turn page action icons in alpha into SVGS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173215 (owner: 10Jdlrobson) [18:43:16] jdlrobson: What's pratik's gerit account? [18:43:33] brb [18:44:14] jdlrobson: Nevermind, I found it: psaxena [18:44:50] gonna get george to bed [18:44:51] kaldari: are there wikigrok deployments going out today? [18:45:03] tfinc: No, everything went out yesterday [18:45:04] (03CR) 10Jdlrobson: Hygiene: Use Icon to render the spinner (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [18:45:15] tfinc: But the A/B test is starting today [18:45:51] (03CR) 10Jdlrobson: [C: 032] Scrolling on reference drawers in every mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173316 (owner: 10Robmoen) [18:46:04] kaldari: is it? [18:46:12] see above, we’re not collecting responses [18:46:26] dbrant: How many Wikidata descriptions are retrieved per typical API request? [18:46:28] we also have some issues with the instrumentation that I called out in my QA notes [18:46:32] (03Merged) 10jenkins-bot: Scrolling on reference drawers in every mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173316 (owner: 10Robmoen) [18:46:33] kaldari: toby was worried that we were doing deployments today so i wanted to check in and make sure that wasn't the case [18:46:41] DarTar: investigating [18:46:42] at least 2 are potentially major issues [18:46:44] just got rejected by george [18:46:46] cool [18:46:50] tfinc: no, no deployments today [18:46:50] he wants granny to read [18:47:24] (03CR) 10Jdlrobson: [C: 032] Indent list of languages on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) (owner: 10Bmansurov) [18:47:27] jdlrobson: ta [18:47:44] phuedx: awwww :-( [18:48:04] (03Merged) 10jenkins-bot: Indent list of languages on tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173181 (https://bugzilla.wikimedia.org/73346) (owner: 10Bmansurov) [18:48:13] Deskana: we fetch search results 12 at a time. So, at most 12. [18:48:58] DarTar: looks like this is the A/B test rather then any new deployment. just wanted to clarify the difference between those two as it came up during the mgmt meeting [18:49:30] Maryana, DarTar: It looks like it's collecting responses to me [18:49:53] tfinc: correct, apparently there’s no deployment planned, just the activation of the AB test, we’re investigating that data that is collected [18:50:03] there are 5 responses just from the last few minutes [18:50:19] kaldari: coming over [18:54:32] Maryana: yt? can you come over to kaldari’s desk? [18:55:31] (03CR) 10Brion VIBBER: [C: 032] Improve documentation for main-menu-account-logout message. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172497 (https://bugzilla.wikimedia.org/71225) (owner: 10Deskana) [19:04:00] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c3 (10Quim Gil) Created attachment 17128 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17128&action=edit Mobile watchlist with arrow icons Sure, here you have... [19:05:43] jdlrobson: currently battling against Unknown module "ext.scribunto" [19:05:50] will get to your review shortly :/ [19:07:02] 3Wikipedia App / 3iOS App: in the iOS app, the main-menu-account-logout message should display the username differently - 10https://bugzilla.wikimedia.org/71225#c3 (10Dan Garry) 5PATC>3RESO/FIX Fixed! [19:07:03] (03CR) 10Brion VIBBER: [C: 04-1] "HTML snuck into the catalan, needs cleanup" (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172908 (owner: 10BearND) [19:07:17] bearND: Coming to our story prioritisation meeting? :-) [19:07:27] Deskana: coming [19:11:46] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c4 (10May) I can agree that there is a lot of negative connotations in down arrow on top of red colored text for bytes removed. I think at some point, we also used minu... [19:11:49] (03CR) 10BearND: [C: 04-1] "Some minor things inline." (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 (owner: 10Dbrant) [19:14:19] Warning: failed to mkdir "/srv/images/thumb/9/99/Question_book-new.svg" mode 0777 [Called from wfMkdirParents in /vagrant/mediawiki/includes/GlobalFunctions.php at line 2492] in /vagrant/mediawiki/includes/debug/MWDebug.php on line 302 < MaxSem I'm getting this everywhere :( [19:14:46] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c5 (10Quim Gil) Color blind users don't have any problem here either: +259 -8 +25 +25 [19:16:58] (03CR) 10BearND: "Same happened on Android in Catalan. Can you modify the strings to remove the HTML? In some cases I just put in the English text and marke" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172908 (owner: 10BearND) [19:17:10] (03CR) 10Robmoen: "I have the same issue." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [19:17:32] jdlrobson, fix permissions? [19:18:00] the_nobodies: it shouldn't be hitting my local machine though - these images are on commons [19:18:24] you're still downloading them [19:18:31] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c6 (10May) (In reply to Quim Gil from comment #5) > Color blind users don't have any problem here either: > > +259 > -8 > +25 > +25 The good/bad issue that you mentio... [19:18:50] it seems to have write permission - the images folder [19:20:38] mm interestingly the user/group is vagrant vagrant [19:20:46] need to chown that [19:21:30] 3MobileFrontend / 3General/Unknown: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c7 (10Quim Gil) +259 or -8 is just a description, I don't see the good/bad connotation there. Using green-red in numbers to denote characters added-removed is a (geeky)... [19:22:41] jdlrobson: what did you do to get the error mentioned in the review? i don't see it :/ [19:23:11] (03PS1) 10Kaldari: Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 [19:23:16] 3MobileFrontend / 3alpha: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c8 (10Jon) Mmm weird.. I have no idea why these are showing up in alpha but they do not show up in beta or stable. [19:23:32] (03CR) 10jenkins-bot: [V: 04-1] Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 (owner: 10Kaldari) [19:24:00] 3MobileFrontend / 3alpha: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c9 (10Jon) (May I don't think it is a high priority but I'll let Moiz decide about that) [19:24:20] phuedx: i just loaded a page [19:24:28] i think mobile.notifications just needs its resources updated [19:24:42] it needs to specify mobile.startup [19:24:56] that said overlays covers that [19:25:02] so something really weird is going on with dependencies [19:25:07] ^ that [19:25:16] could you hard refresh just to make sure? [19:25:20] i'm really not seeing it :/ [19:26:37] (03CR) 10Brion VIBBER: [C: 032] "Nice! Much cleaner look on 6." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173231 (owner: 10Mhurd) [19:27:18] phuedx: sure i'll work it out [19:28:16] 3MobileFrontend / 3alpha: Arrow icons in mobile watchlist are unnecessary and distracting - 10https://bugzilla.wikimedia.org/73422#c10 (10Quim Gil) (In reply to Jon from comment #8) > Mmm weird.. I have no idea why these are showing up in alpha but they do not > show up in beta or stable. Looks like a good... [19:29:48] 3MobileFrontend / 3General/Unknown: When editing, seeing old version of page - 10https://bugzilla.wikimedia.org/73429 (10Rob Moen) 3NEW p:3Unprio s:3normal a:3None Goto a page on your android 2.3.6 device. Make an edit and save the page. Return to the article, notice edit was made. Try to make anothe... [19:29:53] (03PS2) 10Kaldari: Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 [19:31:00] 3MobileFrontend / 3General/Unknown: When editing, seeing old version of page - 10https://bugzilla.wikimedia.org/73429#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/C3JlKk77 [19:37:25] (03PS1) 10Dbrant: Fix possible crash(es) on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173337 [19:39:59] (03PS1) 10Jdlrobson: Hygiene: Remove M.getLeadSection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 [19:40:01] (03PS1) 10Jdlrobson: Hygiene: Remove unused method don't expose methods we are not using. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173339 [19:40:03] (03PS1) 10Jdlrobson: Hygiene: Move getOrigin method from mw.mobileFrontend to Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173340 [19:41:26] phuedx: i can't replicate issue any more it seems [19:41:30] :/! [19:41:33] i'm wondering if it was page specific so browsing around [19:42:15] phuedx: so yeh just my other issues to fix [19:47:32] 3MobileFrontend / 3stable: List of languages not indented on tablet - 10https://bugzilla.wikimedia.org/73346 (10Jon) 5PATC>3RESO/FIX [19:48:47] DarTar: I have a fix in for the schema update: https://gerrit.wikimedia.org/r/#/c/173333/ . Also, I've replied to your notes on the Etherpad: http://etherpad.wikimedia.org/p/WikiGrokTest1DataQA [19:49:11] jdlrobson: i want to add your wikidata infobox thing as a use-case here: https://www.mediawiki.org/wiki/User:Maryana_(WMF)/Sandbox – but i'm not sure if what's already there covers it or not [19:49:17] when you have a sec, can you take a look? [19:49:40] on that subject kaldari it would look so less lame if you can merge https://gerrit.wikimedia.org/r/169792 [19:49:49] kaldari: is that the only difference between the 2 schemas? [19:50:07] i still don't get why we need that in the response log if we have it in the client-side log & can join across user token [19:50:22] Maryana: that sounds about right [19:50:55] cool [19:51:27] (03PS1) 10Robmoen: Resolve JSCS problems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173343 [19:51:38] Maryana: yes, that's the only difference, and it's not 100% required. I've investigated the other items on Dario's list and it looks like they were all things that should have been fixed yesterday by our deployment. I'm going to write up an email suggesting that we just let the A/B test keep running. [19:52:04] ok :) [19:52:40] jdlrobson: can you check out -> https://gerrit.wikimedia.org/r/#/c/173343/ Resolves jscs warnings [19:52:55] kaldari: or we can just talk about it at 1 [19:52:56] either way [19:53:16] Maryana: Sure, that would probably be easier. Can we all meet then? [19:53:26] yeah, i sent out an invite [19:53:39] which you didn't see because you don't do email :) [19:53:42] Ah, I see now, just accepted [19:53:47] cool [19:54:05] kaldari: i'm going to move this… somewhere - https://www.mediawiki.org/wiki/User:Maryana_(WMF)/Sandbox [19:54:11] any opinions on the name of the page? [19:54:33] Wikidata Complex Query Service? [19:54:35] Skynet? [19:55:41] (03PS1) 10Robmoen: Focus editor textarea [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173344 (https://bugzilla.wikimedia.org/73255) [19:56:55] jdlrobson: lol your infobox looks awesome on the beta labs home page: http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page?mobilemode=alpha [19:57:08] "ancient variety of the Nubian language" [19:57:25] hehehe why has the main page got an infobox? [19:59:59] kaldari: awesome, will check the notes in a moment [20:02:48] (03PS3) 10Dbrant: Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 [20:03:10] (03CR) 10jenkins-bot: [V: 04-1] Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 (owner: 10Dbrant) [20:09:12] (03PS6) 10Phuedx: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [20:09:14] (03PS6) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 [20:09:54] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [20:09:58] (03CR) 10Phuedx: Hygiene: Use Icon to render the spinner (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [20:10:02] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx) [20:14:26] (03PS4) 10Dbrant: Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 [20:16:46] (03PS7) 10Phuedx: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) [20:16:48] (03PS7) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 [20:17:18] (03CR) 10Dbrant: "Comments addressed!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 (owner: 10Dbrant) [20:17:31] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [20:18:37] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [20:19:26] wow, i like the in-articles search way better for most random searches i’ve put in :D [20:19:35] though it’s not always useful during the typeahead portion [20:19:37] (03PS1) 10Mhurd: Prefix and full-text delayed searching. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173351 [20:19:43] more likely to give a useful top result tho [20:20:56] (03CR) 10Phuedx: "Really not sure what was going on with mwext-MobileFrontend-qunit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [20:21:39] brion: ya! [20:22:23] brion: that patch above gives the ios app the same rolling search timeouts the android guys are using [20:22:34] ah nice [20:23:18] right, i'm off for the night [20:23:29] gonna take some time to write some stories for a/b testing foo later [20:23:31] but for now [20:23:33] AWAY [20:30:57] (03CR) 10Brion VIBBER: [C: 04-1] "Only thing I'm worried about is that forced capitalization of the description; should use the search language's locale instead of the defa" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 (owner: 10Mhurd) [20:31:11] mhurd: looking good, just needs a slight locale tweak [20:31:29] a few languages like turkish do different capitalization rules than english so it’s safest to make sure using the proper NSLocale instance :) [20:32:30] when all else fails, blame the turks ;) [20:32:42] (why DID constantinople get the works?) [20:38:03] brion: do we have a reliable mapping of search lang locale to apple type locales? [20:38:52] they should match pretty consistently, but lemme take a quick peek if we already have some mappings [20:39:27] mhurd: [MWLanguageInfo codeForCode:] should do it [20:39:34] currently that just maps ‘test’ and ‘simple’ to ‘en’ :D [20:40:17] heh i pulled up ‘nearby’ view with my language set to german [20:40:22] some of the descriptions get pretty long :D [20:41:23] brion: if it’s ok i’ll make the locale change to the nearby patch: https://gerrit.wikimedia.org/r/#/c/173233/ as it has the capitalization stuff pulled out into category method off nsstring [20:41:33] mhurd: perfect [20:41:43] (03CR) 10BearND: [C: 04-1] "I +2d the mobile app ext. patch too soon." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 (owner: 10Dbrant) [20:42:02] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c25 (10Sam Smith) No problem Kelson. MobileContext#getStopMobileRedirectCookieDomain returns wgMFStopRedirectCookieHost when it's defined. So why not set wgMFSto... [20:42:26] in english my neighborhood is boring, i mostly get muni stops ;) [20:42:30] every damn bus stop has an article [20:42:35] haha [20:43:46] (03CR) 10Brion VIBBER: [C: 032] "Per IRC discussion Monte will fix up the capitalization locale in subsequent commit as the code's been shuffled around. Let's go! :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/172942 (owner: 10Mhurd) [20:47:27] bmansurov: did you work out the limn stuff? [20:48:03] jdlrobson: yes I was able to get it up and running. I need help getting labs data to my local environment though. [20:48:05] (03PS2) 10Jdlrobson: Hygiene: Resolve JSCS problems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173343 (owner: 10Robmoen) [20:48:14] (03CR) 10Jdlrobson: [C: 032] "Thanks Rob!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173343 (owner: 10Robmoen) [20:48:40] brion: hmm it looks like NSLocal’s initWithLocaleIdentifier is expecting things lile “en_US” etc… [20:49:00] (03Merged) 10jenkins-bot: Hygiene: Resolve JSCS problems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173343 (owner: 10Robmoen) [20:49:04] it should take plain ‘en’ as well, is it not? bah [20:49:52] (03CR) 10Jdlrobson: [C: 031] "Still need to test but looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [20:50:17] brion: checking [NSLocale availableLocaleIdentifiers]… [20:50:53] hmm ‘ Note that many of the language codes do not have any supporting locale data in OS X. ‘ helpful [20:51:52] mhurd: try [NSLocale canonicalLocaleIdentifierFromString:@“en”] see if that returns something usable [20:51:59] worst case we give up and add a todo :P [20:52:12] or special-case turkish ;) [20:53:11] brion: http://etherpad.wikimedia.org/p/iOS_available_locale_ids [20:53:31] brion: list of [NSLocale availableLocaleIdentifiers] ids [20:53:58] bmansurov: Could you take a look at https://gerrit.wikimedia.org/r/#/c/173333/ . It's related to the Schema update that you did a while back. [20:54:06] brion: has “en”, it’s all the others that i’m not so sure about... [20:54:10] mhurd: ok how about we feed in the language code, and if that doesn’t give us a locale back we fall back to system default locale? [20:54:16] turkish is tr, looks like it’s in there :) [20:54:19] brion: sounds good! [20:57:10] oh turkish, why’d you have to switch from arabic to latin alphabet and then *add crazy capitalization rules* [20:57:45] there’s always gotta be one language that ruins it for everyone ;) [21:00:51] (03CR) 10Bmansurov: [C: 031] Updating Response API for new schema (adding isLoggedIn) (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 (owner: 10Kaldari) [21:01:35] brion: same in Android: http://developer.android.com/reference/java/util/Locale.html#default_locale. See the last couple of sentences in this section. [21:02:04] heh [21:02:43] bearND: I'll update the patch for Dark mode; it'll be done outside of CSS, so the +2 in MobileApp wasn't too soon. [21:02:52] dbrant: good [21:07:25] brion: almost done... [21:08:20] jdlrobson: I've gained access to bastions and have setup limn and limn-mobile-data locally. It would be great if we can chat about next steps. thanks [21:08:44] awesome sure. Give me 30 mins to finish up here and then ping me with a hangout url? [21:08:55] jdlrobson: sounds good [21:15:21] (03PS4) 10Mhurd: Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 [21:15:23] (03CR) 10jenkins-bot: [V: 04-1] Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 (owner: 10Mhurd) [21:15:41] (03PS5) 10Mhurd: Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 [21:15:57] DarTar, Maryana: 1415988000 [21:18:27] brion: i updated https://gerrit.wikimedia.org/r/#/c/173233 to use the current search locale for capitalizing… [21:18:40] *got disconnected* [21:20:21] (03PS2) 10Mhurd: Prefix and full-text delayed searching. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173351 [21:30:35] Hi YuviPanda: When you installed the Android SDK on the build machine, how did you get around the following problem? "SWT folder '/usr/lib/jvm/java-7-openjdk-amd64/jre/lib/ext:/usr/java/packages/lib/ext' does not exist." [21:30:51] Deskana: http://developer.android.com/training/displaying-bitmaps/display-bitmap.html [21:31:09] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Remove dead code paths (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 (owner: 10Jdlrobson) [21:31:36] bmansurov: what is different about that code? [21:31:44] span [21:32:17] jdlrobson: in one it's inside , in the other outside [21:32:26] ohhhh gawd that's not clear at all [21:32:29] let me refactor that [21:32:46] (03PS1) 10Jdlrobson: Don't load infobox on main page / non-main namespace articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173427 [21:32:48] (03PS1) 10Jdlrobson: Infobox styling tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173428 [21:34:07] Maryana, DarTar: Ping! Apps search meeting. :-) [21:34:10] (03CR) 10Bmansurov: [C: 032] Hygiene: Add DS_Store to git ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173327 (owner: 10Jdlrobson) [21:34:31] (03PS2) 10Jdlrobson: Hygiene: Remove dead code paths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 [21:34:41] Deskana: coming [21:36:27] Deskana, Maryana: checking one more thing with kaldari, joining in 5 [21:37:08] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [21:37:24] YuviPanda: dbrant: The update-android-sdk.bash script had an extra entry that doesn't exist on the system anymore. I removed that entry and the update went through. So, the Alpha build server has the latest ADK now [21:37:40] (03CR) 10Bmansurov: [C: 032] Hygiene: Move getOrigin method from mw.mobileFrontend to Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173340 (owner: 10Jdlrobson) [21:37:54] whee, cool :) [21:37:54] (03Merged) 10jenkins-bot: Hygiene: Use Icon to render the spinner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172743 (https://bugzilla.wikimedia.org/73251) (owner: 10Phuedx) [21:38:42] (03CR) 10BearND: [C: 032] "Everybody, update your Android SDK, see the changes in the REAMDE!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 (owner: 10Dbrant) [21:38:56] dr0ptp4kt: Deskana: Krenair: heads-up to update your Android SDK as well ^ [21:39:13] bearND: \o/ oh my! [21:39:48] get yer androids [21:40:09] (03Merged) 10jenkins-bot: Migration to Toolbar, and 5.0 support <3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173290 (owner: 10Dbrant) [21:41:13] (03CR) 10Bmansurov: [C: 032] Hygiene: Remove unused method don't expose methods we are not using. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173339 (owner: 10Jdlrobson) [21:42:12] dbrant: \o/ [21:42:37] dbrant: it took a bit to get the Alpha build server updated to the latest SDK [21:42:53] bearND: i see; [21:44:00] (03CR) 10Bmansurov: Hygiene: Remove M.getLeadSection (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 (owner: 10Jdlrobson) [21:45:26] (03PS2) 10BearND: Fix possible crash(es) on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173337 (owner: 10Dbrant) [21:47:17] jdlrobson: hangout? not sure how to create a link. why don't I just call you? [21:47:47] 3MobileFrontend / 3stable: Reference list constrained to a short height and scrolling within - 10https://bugzilla.wikimedia.org/73436 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None On both ios and desktop on stable the reference section of the article is constrained to a very short height and... [21:47:56] bmansurov: sorry got side tracked - we found a wikigrok bug :-S [21:48:03] kaldari|2: https://bugzilla.wikimedia.org/show_bug.cgi?id=73437 [21:48:04] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437 (10Jon) 3NEW p:3Unprio s:3normal a:3None Trust In Me when I say that if you go to Katy Perry in beta on a mobile device you'll see wikigrok. Click next to start and you'll see a never ending spinner. I think this mi... [21:48:09] jdlrobson: ok [21:48:45] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c1 (10Jon) Created attachment 17132 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17132&action=edit Never ends! [21:49:51] bmansurov: okay let me find some space [21:50:31] 3MobileFrontend / 3stable: Reference list constrained to a short height and scrolling within - 10https://bugzilla.wikimedia.org/73436#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2F864p1R [21:50:31] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7WCM2chZ [21:50:33] (03PS2) 10Dbrant: Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 [21:50:52] (03CR) 10jenkins-bot: [V: 04-1] Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 (owner: 10Dbrant) [21:51:33] bmansurov: i just noticed i have a hang out with tomasz at 2pm [21:51:38] so this will have to be a quick one [21:51:43] ok [21:51:58] dbrant, bearND that was quicker than I expected :) [21:52:54] :) [21:54:09] tfinc: any chance we can start 10 mins late? Need to help bmansurov with limn [21:55:13] bearND, thanks for alerting me [21:55:40] Krenair: yw [21:56:32] python generate.py -c scripts/config.yaml mobile -g ui-daily [21:56:45] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c3 (10Ryan Kaldari) I got it to show up once, but haven't been able to reproduce since then. Not sure what's going on here. In theory, WikiGrok should never show up for pages with no potential claims. [21:58:02] (03PS3) 10Dbrant: Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 [21:58:15] scripts/my.cnf.research [21:58:38] bmansurov: look at "## Testing using local data" [22:00:31] ./scripts/ssh & [22:07:23] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c4 (10Ryan Kaldari) It looks like this may be coming from some en.wiki local CSS. [22:08:09] (03PS4) 10Dbrant: Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 [22:12:05] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c5 (10Ryan Kaldari) Nevermind, that was coming from my local User:Kaldari/minerva.css. Jon, do you have anything set there? [22:12:19] dbrant YuviPanda: any idea how to push my changes on the build server to origin? [22:12:57] bearND: I highly reccomend not doing that, but you can use key forwarding, add an ssh based origin with your username, and then pushing it if you have to [22:13:09] “Curse of Katy Perry”, lulz [22:13:35] (03CR) 10Kaldari: Updating Response API for new schema (adding isLoggedIn) (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 (owner: 10Kaldari) [22:13:43] wut [22:14:20] hello, YuviPanda, you there? [22:14:29] bmansurov: 'sup [22:14:30] YuviPanda: I was using key forwarding (ssh -A). I was missing the "personal" remote. Will try with that, unless you recommend something else [22:14:46] bearND: yeah, you need a personal remote that's ssh based :) [22:14:54] YuviPanda: I'm trying to setup limn-mobile-data locally, and I need [analytics db password], where should I get it from? [22:15:53] bmansurov: do you have access to the stat1003 machine? [22:16:03] YuviPanda: I think so [22:16:16] bmansurov: ?! how so? that RT ticket hasn't gone through yet, no? [22:16:30] YuviPanda: hmm, I can ssh to bastions [22:16:36] YuviPanda: is that different? [22:16:45] bmansurov: yup, very :) can you ssh to stat1003? [22:16:57] YuviPanda: no then [22:17:20] bmansurov: yup, so that means you can't actually setup limn-mobile-data locally anyway, since access to the actual data sources requires stat1003 ssh access [22:17:21] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c6 (10Ryan Kaldari) Maryana reproduced on an iPhone while logged out and logged in. [22:17:47] YuviPanda: do you have the link to the RT ticket? [22:17:52] best bug ever, other than the ghost of william mckinley [22:18:45] Maryana: it's a conspiracy [22:19:31] bmansurov: it's https://rt.wikimedia.org/Ticket/Display.html?id=8852 but you can't view it. [22:19:34] (also see: RT is stupid) [22:19:51] actually, I can't view it either. you might be? [22:21:38] YuviPanda: any info about how I can ssh to stat1003? I could only find https://wikitech.wikimedia.org/wiki/Stat1003 which doesn't say much [22:22:36] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c7 (10Ryan Kaldari) I had Maryana clear the cache on her phone and the bug went away. I'll touch the CSS and JS files this afternoon just in case. [22:22:39] bmansurov: you can't atm, your access request hasn't gone through. Need to wait until Monday at least. min 3 working days from filing of ticket to access being provided [22:22:51] mhurd: You're apparently not registered for the developer summit! [22:23:50] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c8 (10Ryan Kaldari) If anyone can reproduce in a real browser, please try to get some debugging info. [22:26:20] (03PS2) 10Jdlrobson: Hygiene: Remove unused method don't expose methods we are not using. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173339 [22:26:28] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173339 (owner: 10Jdlrobson) [22:27:04] YuviPanda: why does this take so long :) [22:27:20] (just curious) [22:27:44] jdlrobson: so this was put in place only a few months ago. I don't exactly know what triggered it, but it's to give other opsen time to object to particular access requests [22:27:57] while in the general case I think that's a good idea, I think it should be relaxed for stat requests. [22:30:16] (03Merged) 10jenkins-bot: Hygiene: Remove unused method don't expose methods we are not using. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173339 (owner: 10Jdlrobson) [22:31:06] YuviPanda: thanks, I can't see it either. However I received an email from Ariel that access was given to me. [22:31:19] YuviPanda: he wanted me to upload a new ssh key though [22:32:18] bmansurov: I gained new powers, and I can see that RT ticket now. Access has not been granted yet, I think. Ariel just said you have access to the bastion hosts :) [22:32:32] YuviPanda: ok thank you [22:32:58] bmansurov: yw! [22:35:21] (03PS2) 10Jdlrobson: Hygiene: Add DS_Store to git ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173327 [22:35:25] (03CR) 10Jdlrobson: [C: 032] Hygiene: Add DS_Store to git ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173327 (owner: 10Jdlrobson) [22:36:14] (03Merged) 10jenkins-bot: Hygiene: Add DS_Store to git ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173327 (owner: 10Jdlrobson) [22:40:31] jdlrobson: [22:40:50] $wgMFWikiGrokAbTestStartDate = 1415830242; [22:40:50] $wgMFWikiGrokAbTestEndDate = 1615830242; [22:42:39] (03CR) 10Bmansurov: [C: 031] Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [22:42:54] (03CR) 10Jdlrobson: [C: 04-1] "needs rebasing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [22:49:12] (03CR) 10Bmansurov: Focus editor textarea (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173344 (https://bugzilla.wikimedia.org/73255) (owner: 10Robmoen) [22:51:29] (03CR) 10Bmansurov: [C: 032] Infobox styling tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173428 (owner: 10Jdlrobson) [22:52:52] (03CR) 10Jdlrobson: [C: 04-1] "Shouldn't this use icon now?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx) [22:54:05] (03CR) 10Bmansurov: [C: 032] Don't load infobox on main page / non-main namespace articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173427 (owner: 10Jdlrobson) [22:54:08] (03PS1) 10Kaldari: Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173445 (https://bugzilla.wikimedia.org/73437) [22:54:49] (03Merged) 10jenkins-bot: Don't load infobox on main page / non-main namespace articles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173427 (owner: 10Jdlrobson) [22:54:51] (03Merged) 10jenkins-bot: Infobox styling tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173428 (owner: 10Jdlrobson) [22:55:31] jdlrobson: https://gerrit.wikimedia.org/r/#/c/173445/ [22:55:48] (03CR) 10Bmansurov: [C: 032] Hygiene: Cleanup mw-ui-icon specific code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173112 (owner: 10Jdlrobson) [22:56:31] (03Merged) 10jenkins-bot: Hygiene: Cleanup mw-ui-icon specific code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173112 (owner: 10Jdlrobson) [22:56:54] (03PS2) 10Kaldari: Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173445 (https://bugzilla.wikimedia.org/73437) [23:00:13] (03PS3) 10Jdlrobson: Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173445 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari) [23:00:36] (03CR) 10Bmansurov: [C: 04-1] "update the commit message?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 (owner: 10Jdlrobson) [23:04:29] (03CR) 10Robmoen: [C: 032] Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 (owner: 10Kaldari) [23:04:49] (03Merged) 10jenkins-bot: Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173333 (owner: 10Kaldari) [23:05:08] 3MobileFrontend / 3alpha: unlike other buttons, "add discussion" button on the talk page overlay is underlined upon hovering over - 10https://bugzilla.wikimedia.org/73442 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3None Created attachment 17134 --> https://bugzilla.wikimedia.org/attachment.cgi... [23:05:36] 3MobileFrontend / 3alpha: unlike other buttons, "add discussion" button on the talk page overlay is underlined upon hovering over - 10https://bugzilla.wikimedia.org/73442#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/aFJd6L2Y [23:06:58] (03PS8) 10Robmoen: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [23:07:20] (03CR) 10Bmansurov: [C: 032] Remove code powering talk count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173213 (owner: 10Jdlrobson) [23:07:59] (03Merged) 10jenkins-bot: Remove code powering talk count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173213 (owner: 10Jdlrobson) [23:09:39] (03CR) 10Bmansurov: [C: 031] Make sure we don't show WikiGrok in version B unless there are suggestions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173445 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari) [23:11:22] (03PS5) 10Jdlrobson: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [23:11:24] (03PS1) 10Jdlrobson: QUnit Test for bug 73437 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173450 [23:12:07] (03CR) 10jenkins-bot: [V: 04-1] Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [23:12:14] (03CR) 10jenkins-bot: [V: 04-1] QUnit Test for bug 73437 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173450 (owner: 10Jdlrobson) [23:12:16] greg-g: It looks like there are some bugs in the A/B test, so I'd like to postpone it until Monday after the SWAT window: https://gerrit.wikimedia.org/r/#/c/173447/2/wmf-config/mobile.php [23:12:29] greg-g: Is that OK to deploy? [23:13:03] greg-g: I will be in the office for the next two hours at least :) [23:15:16] (03CR) 10Jdlrobson: [C: 032] Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173445 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari) [23:16:58] (03Merged) 10jenkins-bot: Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173445 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari) [23:21:35] (03CR) 10BearND: [C: 032] Fix possible crash(es) on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173337 (owner: 10Dbrant) [23:22:35] 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437#c12 (10Ryan Kaldari) 5PATC>3RESO/FIX Should be fixed now. [23:23:16] (03Merged) 10jenkins-bot: Fix possible crash(es) on screen rotation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173337 (owner: 10Dbrant) [23:25:52] 3Wikipedia App / 3Android App: Nearby compass background is dark when switching from dark to light mode - 10https://bugzilla.wikimedia.org/73445 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None Steps: 1) Switch to dark mode 2) Go to Nearby 3) Go back and switch to light mode 4) Go to Nearby again.... [23:30:22] (03PS2) 10Jdlrobson: QUnit Test for bug 73437 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173450 [23:30:24] (03PS6) 10Jdlrobson: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [23:31:03] kaldari: please please please https://gerrit.wikimedia.org/r/169792 [23:31:06] ^ or you rmoen [23:31:07] (03CR) 10jenkins-bot: [V: 04-1] QUnit Test for bug 73437 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173450 (owner: 10Jdlrobson) [23:31:13] (03CR) 10jenkins-bot: [V: 04-1] Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [23:31:27] jdlrobson: sure, one sec... [23:32:25] (03CR) 10Jdlrobson: [C: 04-1] "Joaquin I tried to rebase this and removed any changes to the WikiGrokDialogB code so we can merge this safely without messing with the di" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez) [23:34:34] (03PS5) 10BearND: Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 (owner: 10Dbrant) [23:34:43] (03CR) 10BearND: [C: 032] Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 (owner: 10Dbrant) [23:35:09] (03Merged) 10jenkins-bot: Correctly display MathML fallback images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173317 (owner: 10Dbrant) [23:35:22] 3MobileFrontend / 3beta: Talk: Add discussion button doesn't look like other Overlay buttons - 10https://bugzilla.wikimedia.org/73243#c6 (10Jon) *** Bug 73442 has been marked as a duplicate of this bug. *** [23:35:22] 3MobileFrontend / 3alpha: unlike other buttons, "add discussion" button on the talk page overlay is underlined upon hovering over - 10https://bugzilla.wikimedia.org/73442#c2 (10Jon) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 73243 *** [23:44:35] bearND: you know a thing or two about eventlogging, right? got a little time to hop on the batcave? i'm trying to figure out why the large increase in the number of distinct ip addresses in the logged mccmnc-ip table in eventlogging. it seems to be related to the end of the month release, but i can't really figure out why otherwise... [23:50:49] (03PS2) 10Jdlrobson: Hygiene: Move getOrigin method from mw.mobileFrontend to Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173340 [23:51:03] (03CR) 10Jdlrobson: [C: 032] "cherry picked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173340 (owner: 10Jdlrobson) [23:51:41] kaldari: any idea why my infobox renders with "Error creating thumbnail: Invalid thumbnail parameters" [23:51:48] is it possible i'm missing some kind of template / extension? [23:52:00] dr0ptp4kt: in a minute or so [23:52:36] (03PS3) 10Jdlrobson: Hygiene: Remove dead code paths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 [23:52:45] ^ bmansurov in future feel free to edit commit messages and merge [23:52:50] we all do it :) [23:52:53] jdlrobson: Probably so [23:52:59] ok [23:53:07] (03CR) 10Brion VIBBER: [C: 032] Added Wikidata descriptions to Nearby items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/173233 (owner: 10Mhurd) [23:53:26] (03Merged) 10jenkins-bot: Hygiene: Move getOrigin method from mw.mobileFrontend to Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173340 (owner: 10Jdlrobson) [23:53:34] (03CR) 10Bmansurov: [C: 032] Hygiene: Remove dead code paths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 (owner: 10Jdlrobson) [23:54:11] (03Merged) 10jenkins-bot: Hygiene: Remove dead code paths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173214 (owner: 10Jdlrobson) [23:54:51] bearND: i'm in the batcave [23:55:50] brion: did that nearby amend for the locale look ok? [23:56:00] dr0ptp4kt: coming... [23:57:25] brion: oh i see you +2’ed it, but didn’t merge... [23:57:34] (03PS3) 10Jdlrobson: Turn page action icons in alpha into SVGS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173215 [23:58:13] (03CR) 10jenkins-bot: [V: 04-1] Turn page action icons in alpha into SVGS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173215 (owner: 10Jdlrobson) [23:59:00] (03PS4) 10Jdlrobson: Turn page action icons in alpha into SVGS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173215 [23:59:37] should be merged now :D [23:59:46] yeah looked fine