[00:00:14] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173893 (owner: 10Kaldari)
[00:00:30] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173894 (owner: 10Kaldari)
[00:00:37] <wikibugs>	 3MobileFrontend / 3stable: Image tag for enwiki project logo should specify dimensions and use a stable URL - 10https://bugzilla.wikimedia.org/58886#c7 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/wNb5TP4s
[00:00:44] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173881 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari)
[00:00:53] <wikibugs>	 3MobileFrontend / 3alpha: Alpha back button tap area of overlays is smaller - 10https://bugzilla.wikimedia.org/73535 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 17153   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17153&action=edit Note the blue outline  Focus the back button...
[00:00:57] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173889 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari)
[00:02:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173893 (owner: 10Kaldari)
[00:02:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updating Response API for new schema (adding isLoggedIn) [extensions/WikiGrok] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173894 (owner: 10Kaldari)
[00:04:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/173881 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari)
[00:04:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make sure we don't show WikiGrok in version B unless there are suggestions [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173889 (https://bugzilla.wikimedia.org/73437) (owner: 10Kaldari)
[00:05:37] <wikibugs>	 3MobileFrontend / 3alpha: Alpha back button tap area of overlays is smaller - 10https://bugzilla.wikimedia.org/73535#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2CUeCDdS
[00:17:50] <awight>	 jdlrobson: Maryana: We deployed the CentralNotice changes to 1.25wmf8, so they are live on mediawiki.org now.  Please try to break on mobile (we are, too), and let us know by... well before tomorrow at 11:00 PST if there are issues.
[00:17:54] <awight>	 AndyRussG: ^^
[00:18:04] <jdlrobson>	 awight: okay i'll check
[00:18:07] <grrrit-wm>	 (03PS1) 10BearND: Bring empty screen in nearby back [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174026 
[00:18:14] <jdlrobson>	 awight: what should i be looking for?
[00:18:52] <jdlrobson>	 awight: i don't see any obvious issues on mediawiki.org
[00:19:17] <AndyRussG>	 jdlrobson: javascript crashing, unexplained performance hit maybe, or banners not displaying
[00:19:21] <AndyRussG>	 The last one seems fine
[00:19:25] <AndyRussG>	 all seem fine actually
[00:19:35] <AndyRussG>	 https://www.mediawiki.org/wiki/MediaWiki?debug=true&country=FR&useformat=mobile
[00:19:57] <AndyRussG>	 (need the country param in there to make CentralNotice think you're French)
[00:20:22] <wikibugs>	 3MobileFrontend / 3beta: Curse of Katy Perry - 10https://bugzilla.wikimedia.org/73437 (10Ryan Kaldari) 5PATC>3RESO/FIX
[00:21:48] <AndyRussG>	 mobile banner also displayed nicely on an android device here on mediawiki
[00:39:04] <kaldari|2>	 bmansurov: Sorry I missed your ping earlier. Do you still need the password?
[00:39:26] <bmansurov>	 kaldari|2: np, yes I do, but I think there is an open ticket in RT for that.
[00:41:18] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Don't indent all page-lists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow)
[00:45:10] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Although I disagree with the colour let's deal with that separately" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) (owner: 10Florianschmidtwelzow)
[00:51:53] <grrrit-wm>	 (03PS1) 10Bmansurov: WIP: Use Istanbul for code coverage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174037 
[00:52:17] <jdlrobson>	 bmansurov: did you sort out your limn issues?
[00:52:34] <bmansurov>	 jdlrobson: not yet, couldn't get access to the file.
[00:53:00] <bmansurov>	 jdlrobson: supposedly there is an RT ticket for that, but I never received an email about it
[00:53:22] <jdlrobson>	 bmansurov: :/-
[00:53:30] <jdlrobson>	 ergg how annoying
[00:54:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Get talk page name from title object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173541 (https://bugzilla.wikimedia.org/73476) (owner: 10Florianschmidtwelzow)
[00:55:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Get talk page name from title object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173541 (https://bugzilla.wikimedia.org/73476) (owner: 10Florianschmidtwelzow)
[00:56:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: CategoryOverlay: use more human readable title name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173474 (owner: 10Florianschmidtwelzow)
[00:56:36] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] CategoryOverlay: use more human readable title name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173474 (owner: 10Florianschmidtwelzow)
[00:56:59] <vbamba>	 mhurd:  Hiya!
[00:57:06] <vbamba>	 you still here?
[00:57:08] <mhurd>	 vbamba: ya!
[00:57:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: CategoryOverlay: use more human readable title name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173474 (owner: 10Florianschmidtwelzow)
[00:57:49] <vbamba>	 Would you have a few minutes to chat with me? Want to run through some of our upcoming work. I estimate 10-15 minutes.
[00:59:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] For ios8 detection check for version 8 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173471 (owner: 10Robmoen)
[00:59:37] <bmansurov>	 jdlrobson: got it working. thanks to kaldari|2
[01:00:50] <wikibugs>	 3MobileFrontend / 3beta: TalkOverlay build false talk links - 10https://bugzilla.wikimedia.org/73476 (10Jon) 5PATC>3RESO/FIX
[01:02:00] <mhurd>	 vbamba: ya!
[01:03:54] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Separate init code path for events (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[01:03:57] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 
[01:07:35] <wikibugs>	 3MobileFrontend / 3alpha: Broken switcher icons in alpha for VE - 10https://bugzilla.wikimedia.org/73057#c10 (10Jon) 5NEW>3RESO/FIX Original issue looks fixed. The icon for the cog is smaller but that's a separate bug we should address separately.
[01:09:07] <wikibugs>	 3MobileFrontend / 3alpha: Make page action icons use svgs in alpha - 10https://bugzilla.wikimedia.org/73391#c2 (10Jon) 5NEW>3RESO/FIX Taken care of in https://gerrit.wikimedia.org/r/173215
[01:11:20] <wikibugs>	 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c11 (10Jon) 5ASSI>3NEW Using the desktop login form has various issues still and is not going to be ready any time soon.  Is there any way we can make the stable/beta site version of our existing login form...
[01:12:35] <wikibugs>	 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c26 (10Jon) 5NEW>3UNCO Marking as unconfirmed until we hear back from Kelson.
[01:13:46] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Prepare automation of Cucumber runs [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174042 
[01:15:51] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Remove M.getLeadSection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 
[01:15:56] <grrrit-wm>	 (03PS10) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 
[01:16:13] <grrrit-wm>	 (03PS9) 10Jdlrobson: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 
[01:16:19] <grrrit-wm>	 (03PS8) 10Jdlrobson: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 
[01:16:25] <grrrit-wm>	 (03PS3) 10Jdlrobson: Species infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170434 
[01:16:30] <grrrit-wm>	 (03PS4) 10Jdlrobson: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 
[01:20:25] <grrrit-wm>	 (03PS3) 10Jdlrobson: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 
[01:21:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[01:21:59] <Deskana>	 mhurd: Can we get a TestFlight build send out soon so I can do signoff? :-)
[01:23:07] <wikibugs>	 3Wikipedia App / 3Android App: Math formulas not visible when MathML is enabled. - 10https://bugzilla.wikimedia.org/73419 (10Bernd Sitzmann) 5PATC>3RESO/FIX
[01:23:59] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "uohohohh trouble in the search overlay..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow)
[01:24:20] <wikibugs>	 3Wikipedia App / 3Android App: Similar pages link shows empty dialog - 10https://bugzilla.wikimedia.org/73393 (10Bernd Sitzmann) 5PATC>3RESO/FIX
[01:56:42] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Prepare automation of Cucumber runs [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174042 (owner: 10Dr0ptp4kt)
[01:57:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prepare automation of Cucumber runs [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174042 (owner: 10Dr0ptp4kt)
[02:03:45] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Update Cucumber README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174053 
[02:04:16] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Update Cucumber README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174053 (owner: 10Dr0ptp4kt)
[02:06:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Cucumber README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174053 (owner: 10Dr0ptp4kt)
[02:07:23] <Deskana>	 kristenlans: All signed off! \o/
[02:07:39] <Deskana>	 kristenlans: Well, there's one or two bits that I left. But it's almost all done.
[02:08:18] <kristenlans>	 Deskana: nice 😎
[02:08:41] <Deskana>	 kristenlans: Anyway, what are you still doing around? Go relax already, it's 9pm there!
[02:08:46] <Deskana>	 :-)
[02:08:57] <kristenlans>	 haha hey yeah WT…
[02:09:08] <kristenlans>	 Until tomorrow!
[02:14:07] <wikibugs>	 3Wikipedia App / 3Android App: Android app: resolve the latest alpha build's anger issues - 10https://bugzilla.wikimedia.org/73543 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 17156   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17156&action=edit The app is having a few a...
[02:32:07] <grrrit-wm>	 (03PS1) 10Dbrant: Tame the anger of the onboarding buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174058 (https://bugzilla.wikimedia.org/73543) 
[02:33:35] <wikibugs>	 3Wikipedia App / 3Android App: Android app: resolve the latest alpha build's anger issues - 10https://bugzilla.wikimedia.org/73543#c2 (10Dmitry Brant) Y U NO LIEK TEH APP?
[02:38:51] <grrrit-wm>	 (03PS14) 10Yurik: Make mdot landing page faster and have logo [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt)
[04:58:20] <grrrit-wm>	 (03PS1) 10Mhurd: Work in progress. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 
[04:59:26] <grrrit-wm>	 (03PS2) 10Mhurd: Recent search terms interface. Change-Id: Ib9c41ca37ba0ac69173ceb4b489f397c3928e8b0 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 
[05:12:29] <grrrit-wm>	 (03PS3) 10Mhurd: Recent search terms interface. Change-Id: Ib9c41ca37ba0ac69173ceb4b489f397c3928e8b0 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 
[05:31:57] <grrrit-wm>	 (03PS3) 10Deskana: Show confirmation dialogue when users click on links in preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172454 
[06:24:05] <grrrit-wm>	 (03PS1) 10Mhurd: Made search keyboard use 'Go' button. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174066 
[06:29:36] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Remove bytes{added|remoed} image from MobileSpecialPageFeed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) 
[06:29:39] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Remove bytes{added|remoed} image from MobileSpecialPageFeed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) (owner: 10Florianschmidtwelzow)
[06:29:42] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Remove bytes{added|remoed} image from MobileSpecialPageFeed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) 
[06:36:52] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Don't indent all page-lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) 
[06:37:05] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Don't indent all page-lists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow)
[06:37:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't indent all page-lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow)
[06:41:47] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "Ah...uh :/ For search overlay we had the min-height, i was wondering." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow)
[06:45:54] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) 
[07:22:18] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 
[07:22:54] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Backlog: Show Watchstar only for logged in users (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 (owner: 10Florianschmidtwelzow)
[07:22:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Backlog: Show Watchstar only for logged in users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 (owner: 10Florianschmidtwelzow)
[07:31:11] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 
[07:32:20] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users (Alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 
[08:30:21] <wikibugs>	 3MobileFrontend / 3stable: Long gallery captions break viewport - 10https://bugzilla.wikimedia.org/73183#c8 (10Derk-Jan Hartman) I've improved it a bit further with flex box sexiness. https://en.wikipedia.org/wiki/Module:Multiple_image/sandbox  Visible as sandbox2 on: https://en.wikipedia.org/wiki/Template:M...
[08:50:35] <wikibugs>	 3Wikipedia App / 3Android App: Improve language selection - 10https://bugzilla.wikimedia.org/71136 (10Nemo)
[11:25:58] <grrrit-wm>	 (03PS8) 10Jhernandez: Add tests to WikiGrokDialogB [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 
[11:27:01] <grrrit-wm>	 (03CR) 10Jhernandez: Add tests to WikiGrokDialogB (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez)
[11:27:28] <grrrit-wm>	 (03CR) 10Jhernandez: Add tests to WikiGrokDialogB (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172569 (owner: 10Jhernandez)
[11:56:50] <wikibugs>	 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100#c5 (10Hay Kranen) One additional feature request (not quite sure if this should be a new bug): it would also be very convenient to see the current language selected in the search inter...
[12:00:22] <wikibugs>	 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100#c6 (10Amir E. Aharoni) (In reply to Hay Kranen from comment #5) > One additional feature request (not quite sure if this should be a new bug): > it would also be very convenient to see...
[12:19:13] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Don't indent all page-lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) 
[12:21:52] <wikibugs>	 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100#c7 (10Nemo) (In reply to Amir E. Aharoni from comment #6) > may have some > surprising technical implications on the search engines  ElasticSearch already supports crosswiki searches:...
[12:26:20] <wikibugs>	 3MobileFrontend / 3alpha: Alpha back button tap area of overlays is smaller - 10https://bugzilla.wikimedia.org/73535#c2 (10Florian) Created attachment 17160   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17160&action=edit not in chrome
[12:26:50] <wikibugs>	 3MobileFrontend / 3alpha: Alpha back button tap area of overlays is smaller - 10https://bugzilla.wikimedia.org/73535#c3 (10Florian) Hmm, not in Chrome on Windows :/ Maybe a Mac specific problem? (actual master branch)
[14:25:28] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Fix possible NPE in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174005 (owner: 10BearND)
[14:27:38] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Bring empty screen in nearby back [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174026 (owner: 10BearND)
[15:02:58] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] Use new continuation API for full text search (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174010 (owner: 10BearND)
[15:20:36] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "a few more tiny things :)" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172454 (owner: 10Deskana)
[15:30:13] <grrrit-wm>	 (03PS2) 10Dbrant: Tame the anger of the onboarding buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174058 (https://bugzilla.wikimedia.org/73543) 
[15:30:15] <grrrit-wm>	 (03PS1) 10Dbrant: [WIP] Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 
[16:38:34] <jdlrobson>	 hey joakino
[16:39:13] <jdlrobson>	 joakino: i'm looking at jsbeautify :)
[16:41:03] <joakino>	 hey jdlrobson!
[16:41:10] <joakino>	 awesome!
[16:41:22] <joakino>	 you woke up early today
[16:41:45] <jdlrobson>	 joakino: i'm at airport :)
[16:41:59] <jdlrobson>	 i'm gonna be on a plane this afternoon not sure if it will have wifi
[16:42:19] <jdlrobson>	 joakino: i think if we can find a way to stop jsbeautify from turning foo[1] into foo[ 1 ] i think we can easily incorporate it
[16:42:26] <jdlrobson>	 i'm currently trying to work out if that's possible
[16:44:08] <joakino>	 jdlrobson: there are definitely some differences... it's just about evaluating tradeoffs
[16:44:11] <joakino>	 IMO
[16:44:48] <jdlrobson>	 joakino: my main worry is deviating too much from mediawiki's coding conventions. We've done that and it didn't work.
[16:44:57] <jdlrobson>	 I personally think the other conventions it introduces make complete sense
[16:45:03] <jdlrobson>	 i don't get the need to indent array keys though
[16:45:12] <jdlrobson>	 i would be very surprised if that wasn't configurable
[16:45:39] <joakino>	 jdlrobson: what do you mean?
[16:45:58] <jdlrobson>	 foo[1] becomes foo[ 1 ] when you do jsbeautify
[16:46:40] <jdlrobson>	 every mediawiki developer currently does foo[1] so i'd either want to change that convention so everyone done foo[ 1 ] or just turn that off in jsbeautify
[16:46:49] <jdlrobson>	 anyway i'm optimistic that we will be using jsbeautify very soon
[16:47:22] <joakino>	 jdlrobson: yeah I don't think that's configurable, I think it treats both arrays [ 1, 2, 3 ] and array accessors shit[ 'ass' ] the same way :(
[16:47:34] <jdlrobson>	 mm
[16:47:35] <joakino>	 we may try a pull request
[16:47:45] <jdlrobson>	 we use dot notation for accessors anyway
[16:48:15] <joakino>	 jdlrobson: yeah but for arrays... 
[16:48:21] <joakino>	 btw are you in china?
[16:49:36] <joakino>	 jdlrobson: what I don't like is that when talking about the conventions, some times the attitude is of "oh no this beautifier thing does this little thing different than the conventions" and then when there is a task to change the code to adhere to the conventions it is "oh this is kind of useless, we shall ignore it"
[16:49:52] <jdlrobson>	 joakino: don't worry that won't happen
[16:49:55] <jdlrobson>	 we'll use it :)
[16:49:57] <joakino>	 i'd rather either enforce it or not
[16:50:04] <jdlrobson>	 i'm not in china yet no. I'm in SFO
[16:50:15] <joakino>	 you woke up early then 
[16:52:29] <jdlrobson>	 yeh i figured i'd get some work in whilst i have internet
[16:52:50] <jdlrobson>	 joakino: you'll be seeing more of me your time :) When I land I'm pretty much starting work for tomorrow :)
[16:54:13] <joakino>	 jdlrobson: good :D i'm alone now that sam is gone for a bit
[16:56:00] <jdlrobson>	 joakino: haha https://github.com/beautify-web/js-beautify/issues/424
[16:56:07] <jdlrobson>	 we are not the only mediawiki devs thinkng about this
[16:56:53] <jdlrobson>	 joakino: looks like i'll be writing jsbeautify code on the plane ;-)
[16:58:00] <joakino>	 who's this nemodreamer 💞
[16:58:04] <joakino>	 lol
[16:58:21] <joakino>	 jdlrobson: well they are open to pulls to that's a good sign
[16:58:30] <jdlrobson>	 :)
[17:00:16] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Tame the anger of the onboarding buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174058 (https://bugzilla.wikimedia.org/73543) (owner: 10Dbrant)
[17:00:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tame the anger of the onboarding buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174058 (https://bugzilla.wikimedia.org/73543) (owner: 10Dbrant)
[17:00:26] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Show confirmation dialogue when users click on links in preview. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/172454 (owner: 10Deskana)
[17:00:36] <grrrit-wm>	 (03PS2) 10BearND: Use new continuation API for full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174010 
[17:03:51] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Don't indent all page-lists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow)
[17:03:52] <jdlrobson>	 joakino: i've worked out how to do that in jsbeautify
[17:04:04] <jdlrobson>	 i just have to work out how tests etc work here
[17:04:26] <joakino>	 jdlrobson: for the python or the js version?
[17:04:34] <jdlrobson>	 joakino: js version
[17:05:15] <joakino>	 jdlrobson: you're good 💪
[17:06:07] <jdlrobson>	 joakino: i've only half done it though
[17:06:14] <jdlrobson>	 it's still adding the space after :)
[17:06:48] <joakino>	 jdlrobson: the coverage reports are going to be complicated, for it to work it needs to generate instrumented "processed" javascript files and run the tests with those, so it doesn't seem to be a grunt only issue/solution
[17:08:38] <jdlrobson>	 how does VisualEditor do it joakino ?
[17:08:58] <James_F>	 jdlrobson: We use karma.
[17:11:12] <joakino>	 James_F: jdlrobson i'll have a look, thx
[17:11:15] <joakino>	 didn't see that
[17:11:30] <jdlrobson>	 awesome
[17:20:45] <joakino>	 jdlrobson: Special:JavascriptTest is from mw not from mobilefrontend right
[17:20:52] <jdlrobson>	 ?
[17:20:57] <jdlrobson>	 yeh it's in core
[17:21:02] <jdlrobson>	 mediawiki/includes/specials
[17:21:44] <joakino>	 aha
[17:22:00] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Indentation fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174148 
[17:22:02] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Refactor complicate variables into functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174149 
[17:26:31] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Use new continuation API for full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174010 (owner: 10BearND)
[17:28:28] <jdlrobson>	 ok brb joakino just heading through security
[17:28:38] <joakino>	 oki bb!!
[17:28:40] <grrrit-wm>	 (03PS3) 10Dbrant: Swipe to refresh! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173926 
[17:29:27] <grrrit-wm>	 (03PS2) 10Dbrant: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 
[17:29:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[17:30:00] <dbrant>	 :..(
[17:30:54] <grrrit-wm>	 (03PS3) 10Dbrant: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 
[17:55:14] <jdlrobson>	 joakino: so on subject of `make qunit`
[17:55:17] <jdlrobson>	 i'm running node 1.4.9
[17:55:25] <jdlrobson>	 sorry npm version
[17:55:29] <jdlrobson>	 and node v0.10.28
[17:55:36] <joakino>	 hm i'm on 2.1.4
[17:55:50] <joakino>	 node is 0.10.32
[17:55:58] <jdlrobson>	 joakino: i'm trying npm update
[17:56:16] <joakino>	 lets see
[17:56:19] <jdlrobson>	 didn't help :/
[17:56:22] <joakino>	 k
[17:56:32] <joakino>	 that's so weird
[17:57:56] <jdlrobson>	 digging deeper
[17:58:35] <joakino>	 what about the phantom version 
[17:58:40] <joakino>	 jdlrobson: i got 1.9.8
[17:59:00] <jdlrobson>	 1.9.7
[17:59:24] <joakino>	 shouldn't matter
[18:01:30] <joakino>	 jdlrobson: this are my deps `npm ls --depth 0' https://gist.github.com/anonymous/5b6cd4e66e42e015decc
[18:05:28] <grrrit-wm>	 (03PS1) 10MaxSem: Scrolling on reference drawers in every mode [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174162 
[18:05:48] <grrrit-wm>	 (03PS1) 10MaxSem: Scrolling on reference drawers in every mode [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174163 
[18:06:16] <MaxSem>	 kaldari, I'm going to deploy ^^^ - any objections?
[18:06:55] <kaldari>	 MaxSem: Go for it
[18:07:14] <bmansurov>	 hey guys, is anyone else not able to sign in to gerrit?
[18:08:41] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Scrolling on reference drawers in every mode [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174163 (owner: 10MaxSem)
[18:09:15] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Scrolling on reference drawers in every mode [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174162 (owner: 10MaxSem)
[18:09:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Scrolling on reference drawers in every mode [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174163 (owner: 10MaxSem)
[18:09:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Scrolling on reference drawers in every mode [extensions/MobileFrontend] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/174162 (owner: 10MaxSem)
[18:10:20] <joakino>	 bmansurov: i'm in there
[18:10:35] <bmansurov>	 joakino: can you try logging out and then in?
[18:10:46] <yurikR>	 dr0ptp4kt, around?
[18:10:54] <dr0ptp4kt>	 yurikR: yes
[18:10:58] <bmansurov>	 I'm getting invalid username or password even though I didn't change it
[18:11:07] <yurikR>	 dr0ptp4kt, did you see my changes to your ptach? any comments?
[18:11:21] <joakino>	 bmansurov: yep no problem, works fine
[18:11:39] <bmansurov>	 joakino: ok thanks for checking
[18:12:10] <dr0ptp4kt>	 yurikR: i saw it. am going through email. will respond after caught up on email and have had a chance to review it.
[18:12:16] <yurikR>	 thx
[18:13:19] <bmansurov>	 kaldari, jdlrobson, MaxSem is there a way I can reset my gerrit password?
[18:13:34] <MaxSem>	 ask in #wikimedia-labs
[18:14:18] <bmansurov>	 thanks
[18:20:45] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Indentation fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174148 (owner: 10Jdlrobson)
[18:21:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Indentation fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174148 (owner: 10Jdlrobson)
[18:21:44] <grrrit-wm>	 (03PS4) 10Mhurd: Recent search terms interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 
[18:25:30] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: Refactor complicate variables into functions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174149 (owner: 10Jdlrobson)
[18:30:39] <nuria__>	 jdlrobson: holaaa
[18:31:05] <nuria__>	 would you happen to know how can i trigger event logging events to be sent in beta labs for the mobile website?
[18:31:20] <nuria__>	 jdlrobson: for example in http://en.m.wikipedia.beta.wmflabs.org/
[18:31:36] <nuria__>	 jdlrobson: what workflow do i need to follow to have events be sent?
[18:32:22] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Don't load talk overlay code on talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173532 (https://bugzilla.wikimedia.org/72799) (owner: 10Florianschmidtwelzow)
[18:33:01] <bmansurov>	 nuria__: are you talking about click events?
[18:33:12] <bmansurov>	 nuria__: or wikigrok?
[18:33:30] <nuria__>	 bmansurov: any event that goes to Event logging really, so sure ...
[18:35:17] <bmansurov>	 nuria__: for click events I think you can just start clicking on hamburger icon, or search bar, or notification icon
[18:35:21] <jdlrobson>	 hey nuria__ hey bmansurov
[18:35:25] <jdlrobson>	 sorry was talking to kristenlans
[18:36:12] <jdlrobson>	 nuria__: so yeh what bmansurov said
[18:36:16] <jdlrobson>	 clicking the icon will send an event to http://bits.beta.wmflabs.org/
[18:36:20] <nuria__>	 k, understood
[18:37:02] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Refactor complicate variables into functions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174149 (owner: 10Jdlrobson)
[18:37:44] <jdlrobson>	 joakino: i'm still stumped about the qunit stuff
[18:37:57] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Extra-long search terms get cropped, should be ellipsized." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 (owner: 10Mhurd)
[18:38:00] <joakino>	 grr
[18:38:01] <jdlrobson>	 bmansurov: i'm not sure about resetting gerrit password.
[18:38:10] <bmansurov>	 jdlrobson: got it figured out
[18:38:17] <jdlrobson>	 bmansurov: cool
[18:38:46] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Refactor complicate variables into functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174149 
[18:38:54] <joakino>	 jdlrobson: what did you try? any pointers?
[18:39:02] <jdlrobson>	 joakino: nope i got nothing so far
[18:39:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load talk overlay code on talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173532 (https://bugzilla.wikimedia.org/72799) (owner: 10Florianschmidtwelzow)
[18:39:28] <joakino>	 maybe update phantom?
[18:41:42] <grrrit-wm>	 (03PS4) 10Bmansurov: Remove bytes{added|removed} image from MobileSpecialPageFeed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) (owner: 10Florianschmidtwelzow)
[18:41:51] <bmansurov>	 FlorianSW: updated the commit message 
[18:41:55] <bmansurov>	 FlorianSW: ^
[18:42:15] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Remove bytes{added|removed} image from MobileSpecialPageFeed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) (owner: 10Florianschmidtwelzow)
[18:42:45] <FlorianSW>	 thx bmansurov :)
[18:43:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove bytes{added|removed} image from MobileSpecialPageFeed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173535 (https://bugzilla.wikimedia.org/73422) (owner: 10Florianschmidtwelzow)
[18:45:44] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Refactor complicate variables into functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174149 (owner: 10Jdlrobson)
[18:46:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Refactor complicate variables into functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174149 (owner: 10Jdlrobson)
[18:47:52] <wikibugs>	 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255#c9 (10Jon) Pam a fix should be on this site: http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings - are you able to verify the above fix is working there? If so we can get it pushed to English Wikipedia.
[18:48:21] <wikibugs>	 3MobileFrontend / 3stable: Code shouldn't be loaded unless necessary - 10https://bugzilla.wikimedia.org/72799 (10Jon) 5PATC>3RESO/FIX
[18:49:52] <grrrit-wm>	 (03CR) 10Jdlrobson: "Talk module and all other modules loaded conditionally should also be updated to have 'group' => 'other' as well so that the urls for them" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173532 (https://bugzilla.wikimedia.org/72799) (owner: 10Florianschmidtwelzow)
[18:53:25] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Good changes." (036 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt)
[18:53:42] <dr0ptp4kt>	 yurikR1: ^ . what's the next step?
[19:00:04] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] "There are some errors on the browser console." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson)
[19:00:20] <jdlrobson>	 bmansurov: what are the errors?
[19:01:51] <jdlrobson>	 joakino: even with latest phantomjs it's still failing
[19:02:04] <bmansurov>	 jdlrobson: ignore the first error: http://imgur.com/kUW6ucv
[19:02:28] <jdlrobson>	 ok i'll take a look. that looks weird
[19:02:30] <jdlrobson>	 thanks
[19:05:54] <grrrit-wm>	 (03CR) 10Jdlrobson: "Even latest phantomjs doesn't fix it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez)
[19:06:18] <joakino>	 jdlrobson: 😭
[19:07:12] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] Hygiene: Separate init code path for events (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[19:08:07] <jdlrobson>	 joakino: we will work it out
[19:08:56] <jdlrobson>	 joakino: found https://bugzilla.wikimedia.org/show_bug.cgi?id=63579
[19:09:00] <jdlrobson>	 not sure if it will shed any light
[19:09:56] <jdlrobson>	 joakino: let's try and get all the grunt stuff done tomorrow
[19:09:59] <jdlrobson>	 (jenkins grunt stuff)
[19:10:05] <joakino>	 ok
[19:10:15] <jdlrobson>	 hopefully we can find antoine or krinkle. If not tomorrow the day after
[19:10:29] <joakino>	 👍
[19:12:20] <wikibugs>	 3Wikipedia App / 3Android App: add the option to have favorite languages in the app - 10https://bugzilla.wikimedia.org/34100#c8 (10Bernd Sitzmann) The default search in the apps is using prefixsearch ("Titles"). If the user then goes to full text search ("Within articles") we use ElasticSearch.  So, for the...
[19:21:29] <jdlrobson>	 ok joakino anything you need from me before i go dark for a bit?
[19:21:47] <jdlrobson>	 i'm going to write some patches for jsbeautify and jscs to get all the coding stuff cleaned up and if time do some more infobox related stuff
[19:21:52] <joakino>	 jdlrobson: no, don't worry, have a good flight
[19:22:05] <jdlrobson>	 bmansurov: you got enough work for the day?
[19:25:10] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Some minor nags apart from that looks good" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow)
[19:25:19] <jdlrobson>	 okay  hope you do bmansurov :)
[19:25:24] <bmansurov>	 jdlrobson: not sure
[19:26:58] <dr0ptp4kt>	 yurikR: sorry, i have another call. will get back to you later if you're online
[19:27:15] <yurikR>	 dr0ptp4kt, np
[19:34:20] <kristenlans>	 maryana are you meeting with ario now?
[19:34:23] <kristenlans>	 Dario
[19:47:03] <Maryana>	 kristenlans: yes
[19:47:19] <Maryana>	 sorry, our last meeting went over time, so we got a late start
[19:47:41] <Maryana>	 we're just doing a quick checkin
[19:48:02] <kristenlans>	 I have to jump in to a meeting at 12 PM, so I might just catch up with you guys later on email?
[19:48:37] <kristenlans>	 ^maryana
[19:48:46] <Maryana>	 sure thing
[19:52:58] <joakino>	 i'm out for today
[19:53:02] <joakino>	 have a nice day people
[19:53:10] <kristenlans>	 bye joakino
[19:53:18] <joakino>	 😸 bb
[19:55:05] <grrrit-wm>	 (03PS1) 10Bmansurov: Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) 
[19:55:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov)
[19:56:09] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "In Nearby the refresh action in the toolbar doesn't seem to do anything anymore. Either take it out or fix it." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173926 (owner: 10Dbrant)
[19:58:04] <grrrit-wm>	 (03PS2) 10Bmansurov: Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) 
[19:59:36] <Krenair>	 dbrant, any ideas for https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7954263 ?
[20:01:22] <dbrant>	 Krenair: none!
[20:04:31] <Krenair>	 dbrant, maybe we're catching some exceptions that should be displayed to the user?
[20:04:32] <Krenair>	 Also is our f-droid.org entry official?
[20:07:05] <dbrant>	 Krenair: if someone added the app to f-droid, it wasn't me...
[20:07:17] <dbrant>	 maybe Deskana or bearND|food ^^
[20:07:28] <Krenair>	 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7959980 is asking us to update it
[20:07:33] <Krenair>	 but I don't think it's "ours"
[20:08:28] <Deskana>	 I thought us adding the app to f-droid was blocked on stuff.
[20:08:33] <bearND>	 dbrant: Krenair: wasn't me
[20:08:44] <bearND>	 maybe yuvi?
[20:12:30] <Deskana>	 dbrant, bearND, Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=65460
[20:21:52] <Krenair>	 Deskana, bearND: https://f-droid.org/wiki/index.php?title=org.wikipedia&diff=prev&oldid=55064
[20:22:07] <wikibugs>	 3Wikipedia App / 3Android App: Regression: Decreased search target area in Alpha - 10https://bugzilla.wikimedia.org/73576 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None Previously we we able to tap anywhere between the 'W' and the magnifying glass. Now if you tap the W nothing happens and you have...
[20:23:05] <grrrit-wm>	 (03PS5) 10Mhurd: Recent search terms interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 
[20:23:08] <mhurd>	 brion: ^
[20:23:13] <brion>	 whee
[20:23:53] <wikibugs>	 3Wikipedia App / 3Android App: Android app dismisses and re-opens tool bar after TOC navigation - 10https://bugzilla.wikimedia.org/73577 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Load any article #2 Swipe to TOC and select a section  Notice how the tool bar will get dismissed while we scrol...
[20:25:25] <grrrit-wm>	 (03PS2) 10Mhurd: Made search keyboard use 'Go' button. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174066 
[20:37:51] <wikibugs>	 3Wikipedia App / 3Automated Builds: Get Wikipedia app on f-droid - 10https://bugzilla.wikimedia.org/65460#c1 (10Bernd Sitzmann) We could theoretically upload the java-mwapi jar to jcentral. Needs some investigation. I don't think they allow snapshot versions. I think it best to depend on a release version an...
[20:43:29] <Krenair>	 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7941294 - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7926075
[20:43:31] <Krenair>	 weird
[20:43:51] <wikibugs>	 3Wikipedia App / 3Automated Builds: Get Wikipedia app on f-droid - 10https://bugzilla.wikimedia.org/65460#c2 (10Dmitry Brant) Do we have an idea of the theoretical user base that we would gain by putting the app on f-droid?  I don't see download numbers or statistics on the app page: https://f-droid.org/repo...
[20:44:37] <wikibugs>	 3Wikipedia App / 3Android App: Android app search within articles is not retained when going back into search - 10https://bugzilla.wikimedia.org/73579 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None #1 Search for anything #2 Tap 'Within Articles' #3 Tap search again  Instead of going back to 'Within...
[20:46:06] <wikibugs>	 3Wikipedia App / 3Android App: Android app dismisses and re-opens tool bar after TOC navigation - 10https://bugzilla.wikimedia.org/73577#c1 (10Bernd Sitzmann) It seems to do it only after you select a section that's lower than the one currently on.
[20:46:21] <MaxSem>	 bearND, so what was the question about the API?
[20:48:21] <bearND>	 MaxSem: (1) whether it's a good idea to use the new continuation syntax and (2) do I need to care about the batchcomplete field? Currently we check if there is a continue object in the response, and if not we're done
[20:48:46] <MaxSem>	 1) yup
[20:49:37] <MaxSem>	 2) they're mutually exclusive, so an end of dataset is indicated by a batchcontinue and a lack of continue
[20:50:36] <wikibugs>	 3Wikipedia App / 3Automated Builds: Get Wikipedia app on f-droid - 10https://bugzilla.wikimedia.org/65460#c3 (10Alex Monk) https://f-droid.org/wiki/index.php?title=org.wikipedia&diff=prev&oldid=54638 makes it seem like this is all done automatically on f-droid's end...
[20:51:25] <bearND>	 MaxSem: how do you explain the existence of both in https://en.m.wikipedia.org/w/api.php?action=query&format=json&prop=pageprops%7Cpageimages&ppprop=wikibase_item&generator=search&gsrsearch=fo&gsrnamespace=0&gsrwhat=text&gsrinfo=&gsrprop=redirecttitle&gsrlimit=12&list=search&srsearch=fo&srnamespace=0&srwhat=text&srinfo=suggestion&srprop=&srlimit=12&piprop=thumbnail&pithumbsize=96&pilimit=12&continue=?
[20:54:27] <dr0ptp4kt>	 yurikR: thanks for the email on that stuff. my android toolchain was set to use 3.3. i was hoping to much that pip3 install would take care of everything! so before running the script i'm exporting PYTHONPATH to use the 2.7 libs. i guess i should get virtualenv stuff setup to make life easier
[20:54:42] <dr0ptp4kt>	 s/to much/too much/
[20:55:26] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] "ok ellipsis fix will come in another patch. insert is fixed here yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174065 (owner: 10Mhurd)
[20:55:49] <yurikR>	 dr0ptp4kt, in theory, it should be fairly easy to fix it to work on p3
[20:56:05] <yurikR>	 updating my phone to lolipop... 
[20:56:13] <yurikR>	 hope its still alive after reboot
[20:56:54] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Made search keyboard use 'Go' button. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174066 (owner: 10Mhurd)
[20:56:55] <dr0ptp4kt>	 yurikR: yeah :) sweet, lemme know how it goes. i'm waiting for the formal ota on the nexus 7, but may want to do the upgrade anyway
[20:57:33] <Deskana>	 dr0ptp4kt: I got the OTA on my Nexus 7 today.
[20:57:58] <dr0ptp4kt>	 Deskana: nice!
[20:58:26] <Deskana>	 dr0ptp4kt: I'm actually a little bit disappointed that they didn't change a bit more. The apps screen looks identical as it did before. Black. :-(
[20:59:04] <brion>	 the apps screen is SO not material design yeah. i’m kinda surprised they didn’t totally redo that
[20:59:15] <MaxSem>	 bearND, aha - got it. the batchcomplete is from prop modules you're using with the generator
[20:59:32] <brion>	 (is it same on nexus 6 i wonder? they have slightly different homescreen on nexus 4 and 5 for instance, 5 has the google now page and 4 doesn’t… still…)
[21:11:19] <bearND>	 MaxSem: Does prefixsearch have a continue?
[21:11:48] <bearND>	 MaxSem: in https://en.m.wikipedia.org/w/api.php?action=query&format=json&generator=prefixsearch&gpssearch=fo&gpsnamespace=0&gpslimit=12&prop=pageimages&piprop=thumbnail&pithumbsize=96&pilimit=12&list=prefixsearch&pssearch=fo&pslimit=12&continue= I only see the batchcomplete but no continue object.
[21:12:03] <MaxSem>	 yup
[21:12:16] <MaxSem>	 because the batch is complete
[21:13:48] <bearND>	 MaxSem: how can that be? I search for titles that start with "fo" in enwiki (limit 12). There are surely more pages than that
[21:14:25] <bearND>	 MaxSem: switching to a lower limit also doesn't give me the continue object
[21:14:33] <bearND>	 https://en.m.wikipedia.org/w/api.php?action=query&format=json&generator=prefixsearch&gpssearch=fo&gpsnamespace=0&gpslimit=4&prop=pageimages&piprop=thumbnail&pithumbsize=96&pilimit=4&list=prefixsearch&pssearch=fo&pslimit=4&continue=
[21:16:09] <MaxSem>	 bearND, prefixsearch has no batching
[21:16:28] <MaxSem>	 Monte bumped into the same problem yesterday:P
[21:16:30] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Style links in Overlay header like buttons (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow)
[21:17:40] <bearND>	 MaxSem: then why does it give me the warning if I don't provide the continue parameter?
[21:17:51] <MaxSem>	 ask anomie:P
[21:18:15] <MaxSem>	 he's been pushing for it too much
[21:18:33] <MaxSem>	 so just add continue= everywhere to STFU this warning
[21:18:56] <bearND>	 MaxSem: so, if I understand this correctly, this warning comes whether batching is available or not
[21:19:02] <MaxSem>	 yup
[21:20:23] <bearND>	 MaxSem: ok, thanks!
[21:54:43] <grrrit-wm>	 (03PS1) 10BearND: Allow caller to specify maxResults in FullSearchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174293 
[22:40:32] <grrrit-wm>	 (03PS15) 10Dr0ptp4kt: Make mdot landing page faster [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 
[22:43:23] <dr0ptp4kt>	 yurikR: https://gerrit.wikimedia.org/r/#/c/170483 updated. i removed the if() case for the logo
[22:43:35] <yurikR>	 dr0ptp4kt, thx
[22:58:26] <grrrit-wm>	 (03PS1) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) 
[22:59:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov)
[23:00:27] <grrrit-wm>	 (03PS2) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) 
[23:09:36] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "This will cause the logo to be rendered at full size without retina support. What we probably want to do is set the height to something li" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov)
[23:27:28] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] QUnit Test for bug 73437 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173450 (owner: 10Jdlrobson)
[23:27:32] <grrrit-wm>	 (03PS3) 10Kaldari: Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov)
[23:28:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: QUnit Test for bug 73437 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173450 (owner: 10Jdlrobson)
[23:29:15] <bmansurov>	 kaldari: where did you get the image from? I sent an email to designers asking for a new image with the height of 30px.
[23:29:44] <kaldari>	 bmansurov: I made it based on https://commons.wikimedia.org/wiki/File:Wikipedia_wordmark_1.5x.png
[23:30:00] <bmansurov>	 kaldari: ok thanks
[23:30:29] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "See previous comments" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov)
[23:30:52] <kaldari>	 bmansurov: The new logo is 15px x 210px
[23:31:03] <kaldari>	 bmansurov: And I already ran a PNG crusher on it
[23:31:19] <bmansurov>	 kaldari: so this is good for retina screens?
[23:31:50] <kaldari>	 bmansurov: Yeah, assuming you set the width and height dimensions to half that
[23:32:08] <kaldari>	 bmansurov: probablty best to hard-code the height and scale the width
[23:32:52] <bmansurov>	 kaldari: height of 7.5px? 
[23:33:22] <kaldari>	 bmansurov: Oops, I lied. I mean the new logo is 30x210px :)
[23:33:26] <kaldari>	 so 15px height
[23:33:30] <bmansurov>	 cool
[23:37:11] <Deskana>	 kaldari: Ping! Coming to the meeting in Chambers? :-)
[23:39:16] <grrrit-wm>	 (03PS4) 10Bmansurov: Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) 
[23:57:08] <wikibugs>	 3MobileFrontend / 3stable: MobileFrontend no longer invokes wikitext editor properly or changes editor, different behavior in Chrome and Firefox - 10https://bugzilla.wikimedia.org/73585 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None Created attachment 17164   --> https://bugzilla.wikimedia.org/att...