[00:00:39] 3MobileFrontend / 3stable: MobileFrontend no longer invokes wikitext editor properly or changes editor, different behavior in Chrome and Firefox - 10https://bugzilla.wikimedia.org/73585#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/LKgERdDV [00:02:10] can someone poke kaldari|2? Maryana, kaity, Deskana|Away [00:08:25] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Remove M.getLeadSection (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 (owner: 10Jdlrobson) [00:20:37] (03PS5) 10Kaldari: Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov) [00:22:05] (03CR) 10Kaldari: [C: 032] Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov) [00:22:46] (03Merged) 10jenkins-bot: Add footer logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174218 (https://bugzilla.wikimedia.org/58886) (owner: 10Bmansurov) [00:23:20] 3MobileFrontend / 3stable: Image tag for enwiki project logo should specify dimensions and use a stable URL - 10https://bugzilla.wikimedia.org/58886 (10Ryan Kaldari) 5PATC>3RESO/FIX [00:32:22] 3MobileFrontend / 3alpha: Alpha: Nearby footer button is broken - 10https://bugzilla.wikimedia.org/73586 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None See Nearby button at bottom of https://en.m.wikipedia.org/wiki/Atacama_Large_Millimeter_Array?mobileaction=alpha [00:35:35] 3MobileFrontend / 3alpha: Alpha: Nearby footer button is broken - 10https://bugzilla.wikimedia.org/73586#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/bBF0MLzd [00:40:04] (03PS1) 10Krinkle: Don't use 'new' with jQuery.Deferred [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174331 [00:46:33] mhurd: this mobile meeting is still running, will get the recent spec to you soon [00:46:48] vbamba: cool! [01:03:06] 3Wikipedia App / 3iOS App: App should use native iOS icons for UI - 10https://bugzilla.wikimedia.org/73524#c4 (10Ryan Kaldari) More info from Apple: https://developer.apple.com/library/ios/documentation/userexperience/conceptual/mobilehig/Iconography.html https://developer.apple.com/library/ios/documentation... [01:30:42] DarTar: when do you want to sit down and look at new WikiGrok data? [01:31:19] DarTar: now that EventLogging has stabilized a bit :P [01:32:12] DarTar: There are about 4 hours of holes in the current data though, FYI [01:32:40] kaldari|2: my plan was to work on the data on Thursday, is there anything urgent that we need to do by tomorrow? [01:32:56] huh, 4 hours of holes also on analytics-store? [01:33:12] DarTar: yeah, Christian just sent out an email about it [01:33:31] ok let me check [01:34:09] DarTar: Can you run some of your sanity check queries against the data since yesterday? Just want to see if there are any obvious problems. [01:34:34] kaldari|2: I can but I’m in the middle of something with Aaron atm, I can do this tonight [01:34:46] DarTar: No problem. It can wait until tomorrow [01:35:23] kaldari|2: actually, I can take a quick break and run the queries [01:35:30] let’s see, [01:35:54] kaldari|2: do you have a new cutoff time you want me to use [01:36:13] if not I’ll use 2014-11-14 01:16:15 [01:36:20] (same as before) [01:36:27] DarTar: 18 Nov 2014 01:00:00 UTC [01:36:35] cool [01:36:53] DarTar: Looks like there's still very few responses :( [01:36:55] wait, that’s half an hour ago [01:36:58] right? [01:37:16] DarTar: No that 1 day and 1 hour ago [01:37:21] that=that's [01:37:24] ha right [01:37:43] so was that a new deployment? [01:38:17] Yes, we did a new deployment yesterday afternoon during the SWAT window [01:38:27] got it [01:38:34] (03PS1) 10Dr0ptp4kt: Expand on Cucumber automation in its README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174344 [01:38:59] DarTar: I also added the time to the A/B docs on meta [01:39:08] thx [01:39:16] (03CR) 10Dr0ptp4kt: [C: 032] Expand on Cucumber automation in its README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174344 (owner: 10Dr0ptp4kt) [01:39:20] I’m updating http://etherpad.wikimedia.org/p/WikiGrokTest1DataQA [01:39:39] (03Merged) 10jenkins-bot: Expand on Cucumber automation in its README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/174344 (owner: 10Dr0ptp4kt) [01:40:13] DarTar: I still need to artificially produce all the errors. I'll make a card to do that. [01:40:34] kaldari|2: cool [01:41:32] MaxSem: I tested the config change while I was in the 'vision' meeting. It seems to working well. [01:49:50] DarTar: Unfortunately, I have to run, but if you notice anything awry, send me an email. [01:50:01] kaldari|2: I’m updating the etherpad [01:50:08] I’l ping you when it’s done [01:50:14] thanks [01:50:16] np [02:08:58] mhurd: around [02:08:59] ? [02:09:02] can we chat quickly? [02:09:06] vbamba: ya! [02:09:10] can you come over? [02:12:48] vbamba: ya [02:16:04] (03PS4) 10Dbrant: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 [02:25:02] (03PS4) 10Dbrant: Swipe to refresh! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173926 [02:54:53] (03PS1) 10Dbrant: Remember correct search panel when exiting/reentering search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174355 (https://bugzilla.wikimedia.org/73579) [03:40:09] (03PS1) 10Mhurd: Tweaks to Recent Searches interface designs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174363 [03:46:58] (03PS2) 10Mhurd: Tweaks to Recent Searches interface designs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174363 [03:47:20] (03PS3) 10Mhurd: Tweaks to Recent Searches. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174363 [03:47:49] (03PS2) 10BearND: Allow caller to specify maxResults in FullSearchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174293 [03:47:51] (03PS1) 10BearND: Add SuggestionsTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174365 [03:48:15] (03CR) 10jenkins-bot: [V: 04-1] Add SuggestionsTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174365 (owner: 10BearND) [05:52:50] 3Wikipedia App / 3Android App: Android app: Description in article title is sometimes in the wrong language - 10https://bugzilla.wikimedia.org/73349 (10Dan Garry) 5PATC>3RESO/FIX [05:53:09] 3Wikipedia App / 3Android App: Android app: Wikidata description is displayed in incorrect language if you click "read in other languages" - 10https://bugzilla.wikimedia.org/73598 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None If you go to an article via "read in other languages", the Wikidata descri... [06:16:25] 3Wikipedia App / 3Android App: Android app: Wikidata description is displayed in incorrect language if you click "read in other languages" - 10https://bugzilla.wikimedia.org/73598#c1 (10Dan Garry) This is because the Wikidata descriptions are loaded based on the language that the app is currently set to, whi... [06:24:33] (03PS2) 10BearND: Add SuggestionsTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174365 [07:00:51] (03PS1) 10Deskana: Ensure Wikidata description is always shown in correct language in lead image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174375 (https://bugzilla.wikimedia.org/73598) [07:03:29] (03PS2) 10Deskana: Ensure Wikidata description is always shown in correct language in lead image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174375 (https://bugzilla.wikimedia.org/73598) [08:03:38] (03PS1) 10Mhurd: Made lang picker define delegate for selection notification. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174377 [09:05:44] good morning [09:19:50] 3MobileFrontend / 3stable: MobileFrontend no longer invokes wikitext editor properly or changes editor, different behavior in Chrome and Firefox - 10https://bugzilla.wikimedia.org/73585#c2 (10Florian) For the second (FF only): [10:11:21.144] "[Exception... "Failure" nsresult: "0x80004005 (NS_ERROR_FAILURE)"... [09:20:05] (03PS1) 10Florianschmidtwelzow: Don't try to set cursor on hidden elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174384 (https://bugzilla.wikimedia.org/73585) [09:37:50] 3MobileFrontend / 3alpha: Alpha: Nearby footer button is broken - 10https://bugzilla.wikimedia.org/73586#c2 (10Florian) Hmm, i'm wondering what happens there :/ On my local installation (latest master branch and wmf7 (actual on wikipedias)) it looks fine :( The code looks ok, too (can't find anything, that r... [09:58:31] (03CR) 10Jdlrobson: [C: 04-1] "time out hacks are evil. I'd rather we reverted theast change tbh. Will take a look in a few hours. How serious is this? Has it hit produc" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174384 (https://bugzilla.wikimedia.org/73585) (owner: 10Florianschmidtwelzow) [10:06:21] 3MobileFrontend / 3beta: Can't scroll in edit mode - 10https://bugzilla.wikimedia.org/73255#c10 (10pamdavies7) Thanks for working on this. That page as it was didn't test the problem as none of the sections were long, so I edited section YOO YO to test ... and the problem seems to be more or less solved. Wh... [10:18:14] (03CR) 10Florianschmidtwelzow: "> Has it hit production yet?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174384 (https://bugzilla.wikimedia.org/73585) (owner: 10Florianschmidtwelzow) [10:26:23] (03CR) 10Jdlrobson: "@max why are redirects appearing in first place I thought we were excluding them from results with an api parameter?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov) [10:47:23] 3Wikipedia App / 3Android App: JSONException: Value joakino: yeeeehhaah [11:42:25] jdlrobson: go to sleep crazy man [11:42:29] never! [11:42:34] the show must go on [11:45:05] joakino: at least have to show you all the cool stuff on gerrit i've done ;-) [11:46:55] jdlrobson: yeah bring on the patches [11:47:01] be afraid.. [11:47:52] haha [11:57:56] (03PS1) 10Jdlrobson: Hygiene: Use correct indentation level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174396 [11:57:58] joakino: boom [11:57:58] (03PS1) 10Jdlrobson: Hygiene: Add new lines before function keyword [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174397 [11:58:00] (03PS1) 10Jdlrobson: Move: Hygiene: Require new lines before function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 [11:58:02] (03PS1) 10Jdlrobson: Hygiene: Require line feed at end of file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 [11:58:04] (03PS1) 10Jdlrobson: jscs: Add require-line-break-after-variable-assignment config option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 [11:58:06] (03PS1) 10Jdlrobson: Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 [11:58:08] (03PS1) 10Jdlrobson: Hygiene: Move variable declaration on to single line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 [11:58:10] (03PS1) 10Jdlrobson: Hygiene: Simple whitespace and js documentation fix to nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174403 [11:58:12] (03PS1) 10Jdlrobson: jscs: Use disallowSpacesInMemberExpression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174404 [11:58:14] (03PS1) 10Jdlrobson: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 [11:58:16] (03PS1) 10Jdlrobson: Update jsbeautifyrc to respect new rule I wrote [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174406 [11:58:23] (03PS2) 10Jdlrobson: Hygiene: Require new lines before function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 [11:58:31] jdlrobson: lolol [11:58:38] (03CR) 10Jdlrobson: [C: 04-1] "Dependent on an upstream change i'm working on" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 (owner: 10Jdlrobson) [11:58:44] joakino: that's just the mobilefrontend ones.. [11:58:54] (03PS2) 10Jdlrobson: Hygiene: Require line feed at end of file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 [11:59:02] (03PS2) 10Jdlrobson: jscs: Add require-line-break-after-variable-assignment config option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 [12:00:23] (03CR) 10Jdlrobson: [C: 04-1] "Dependent on an upstream change i'm working on" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 (owner: 10Jdlrobson) [12:00:41] (03PS2) 10Jdlrobson: Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 [12:01:03] (03PS2) 10Jdlrobson: Hygiene: Move variable declaration on to single line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 [12:01:10] (03PS2) 10Jdlrobson: Hygiene: Simple whitespace and js documentation fix to nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174403 [12:01:17] (03PS2) 10Jdlrobson: jscs: Use disallowSpacesInMemberExpression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174404 [12:01:36] (03CR) 10Jdlrobson: [C: 04-1] "Dependent on upstream change" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174404 (owner: 10Jdlrobson) [12:02:37] (03PS2) 10Jdlrobson: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 [12:02:47] (03PS2) 10Jdlrobson: Update jsbeautifyrc to respect new rule I wrote [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174406 [12:02:57] (03CR) 10Jdlrobson: [C: 04-1] "Upstream change needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174406 (owner: 10Jdlrobson) [12:03:14] (03CR) 10Jdlrobson: [C: 04-1] "jscs will complain like crazy" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [12:03:25] joakino: be back later :) [12:34:42] (03PS2) 10Jhernandez: Use Istanbul for code coverage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174037 (owner: 10Bmansurov) [15:49:04] (03PS1) 10Florianschmidtwelzow: Hygiene: Extend load talk module only if needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 [15:56:37] (03PS1) 10Florianschmidtwelzow: Hygiene: Add group other to conditionally loaded modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174424 [17:43:12] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Extend load talk module only if needed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 (owner: 10Florianschmidtwelzow) [17:44:22] 3MobileFrontend / 3Hygiene: [Tracking] Migrate css rules in hacks.less into templates. - 10https://bugzilla.wikimedia.org/64578 (10Andre Klapper) [17:44:35] 3MobileFrontend / 3Hygiene: [Tracking] MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181 (10Andre Klapper) [17:44:41] 3MobileFrontend / 3Feature requests: [Tracking] Deprecate redlink removal (enable redlinks in stable) - 10https://bugzilla.wikimedia.org/69849 (10Andre Klapper) [17:44:42] 3MobileFrontend / 3Feature requests: Tracking: Watchlist features available on desktop that aren't on mobile yet - 10https://bugzilla.wikimedia.org/56817 (10Andre Klapper) [17:44:57] 3MobileFrontend / 3Hygiene: [Tracking] Repurpose MobileFrontend as Minerva skin - 10https://bugzilla.wikimedia.org/69366 (10Andre Klapper) [17:44:59] 3MobileFrontend / 3Hygiene: [Tracking] Move Nearby code to Geodata extension - 10https://bugzilla.wikimedia.org/64316 (10Andre Klapper) [17:45:06] 3MobileFrontend / 3Hygiene: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - 10https://bugzilla.wikimedia.org/62638 (10Andre Klapper) [17:45:08] 3MobileFrontend / 3Hygiene: [Tracking] Consolidate code for MediaViewer across desktop and mobile - 10https://bugzilla.wikimedia.org/63504 (10Andre Klapper) [17:45:36] 3MobileFrontend / 3Hygiene: [Tracking] Consolidate code for MediaViewer across desktop and mobile - 10https://bugzilla.wikimedia.org/63504#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/KdBttENl [17:45:37] 3MobileFrontend / 3Hygiene: [Tracking] Move Nearby code to Geodata extension - 10https://bugzilla.wikimedia.org/64316#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/OLxnuzXR [17:45:50] 3MobileFrontend / 3Hygiene: [Tracking] MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181#c9 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7wa4i24Z [17:46:02] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Add group other to conditionally loaded modules (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174424 (owner: 10Florianschmidtwelzow) [17:47:37] hey how are you doing jdlrobson [17:47:42] did you get some sleep [17:47:48] haahah [17:49:08] i think i just felt an earthquake [17:49:33] either that or i'm going crazy from lack of sleep :) [17:51:28] maybe i'm not going crazy https://twitter.com/smallstudent/status/535128165958434816 :) what a funny day this is [17:52:27] it was an earthquake [17:52:48] my chinese is a bit rusty lol [17:54:52] i checked with my airbnb host and it was apparently [17:57:27] standup [17:57:36] joakino: i'm in have i got the wrong url :-S [17:57:49] idk im going in [17:57:51] wait [17:58:02] dbrant, a bunch of people have reported that they get error code -24 trying to download the app [18:00:26] Krenair: sounds like the error comes from the Play Store... I'm seeing conflicting information on the web regarding the reasons for it to occur... [18:02:02] (03Abandoned) 10Florianschmidtwelzow: Hygiene: Add group other to conditionally loaded modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174424 (owner: 10Florianschmidtwelzow) [18:02:22] jdlrobson: hi :) ^ i think i misunderstood group, thx for clarify :) [18:08:43] (03PS2) 10Florianschmidtwelzow: Hygiene: Extend load talk module only if needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 [18:09:43] jdlrobson: if you have one or 2 minutes time, i think we should do something about: https://gerrit.wikimedia.org/r/#/c/174384/ before wmf9 get's branched to save a backport. What do you mean? [18:16:07] FlorianSW: sure we just spoke about that in our daily standup [18:16:21] jdlrobson: ah, great :) [18:16:36] why was everybody ohnooeing [18:16:44] FlorianSW: let me check the revert works [18:17:14] jdlrobson: i've got in the stats OS major and minor, but only browser major, is the android browser versioning tied to the OS major/minor? If so I can get 2.3 percentages [18:17:35] joakino: it is [18:17:46] oh cool, i'll update that then [18:17:59] joakino: see https://en.m.wikipedia.org/wiki/Android_version_history [18:19:46] FlorianSW: can't seem to replicate it locally which is strange [18:20:33] jdlrobson: you try with Firefox? I have only tried the old 25 version, let me try with the newest one [18:20:44] FlorianSW: yeh i can replicate it on beta labs but not locally.. [18:20:51] :O [18:21:33] yeah FF update :( [18:22:07] FlorianSW: seems fixed on beta labs now too.. [18:23:19] FlorianSW: seems specific to that page.. [18:23:48] jdlrobson: can reproduce locally [18:24:01] it has to be a new page, maybe you're testing on an existing one? [18:24:01] ohh now i can replicate locally [18:24:08] i think it only applies to new pages.. ? [18:24:36] FlorianSW: i think it's less urgent then [18:24:41] since we don't surface new pages for editing [18:24:50] 3MobileFrontend / 3stable: Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c4 (10Jon) This seems to be specific for new pages in Firefox. [18:26:13] jdlrobson: hmm, ok :) [18:26:23] FlorianSW: why is the textarea not there? [18:27:27] jdlrobson: the problem seems to be, that the content is hidden (to show the loading spinner) and FF seems to not render the show() function on $content before we try to set the selection range [18:27:45] jdlrobson: and FF will throw an exception then (if you try to set a selection on a hidden element) [18:28:02] FlorianSW: in this case it should just not set selection range :) [18:28:09] there is nothing to select anyway :) [18:28:55] jdlrobson: a simple idea :P i don't know, why i haven't had it :D Let me try and change the patchset. [18:29:22] the setting selection range should not be necessary in this situation [18:30:41] jdlrobson: see the comment below yours https://trello.com/c/C3JlKk77 [18:31:06] there doesn't seem to be more OS fields, https://wikitech.wikimedia.org/wiki/Analytics/Cluster/Hive/QueryUsingUDF [18:31:14] kaldari: nuria__: don't suppose you know how to re-deploy limn? [18:31:38] heh joakino i guess this is why sleep is a good thing [18:32:24] hey jdlrobson [18:32:30] i can do that :) [18:33:37] Ah I know why no one is in the story review meeting… [18:33:45] …it doesn’t start for another half hour! [18:34:54] kristenlans: Haha, you ran off for a meeting that isn't happening? :-D [18:35:10] haha [18:35:10] Deskana: true story [18:36:14] milimetric is back!! [18:36:15] \o/ [18:36:26] milimetric: that would be sweet. let me know when done [18:36:32] kristenlans: dohhhhh [18:36:46] jdlrobson: so you just want to push the graph definitions to the limn server right? [18:36:47] nothing else? [18:38:20] jdlrobson: if that was it - it's done [18:38:27] milimetric: verifying [18:38:52] milimetric: http://mobile-reportcard.wmflabs.org/graphs/ui-daily hasn't got updated for some reason :-/ but maybe that's because the update script hasn't run? [18:39:08] it also looks a bit broken.. [18:39:19] very broken [18:39:53] 3Wikipedia App / 3Android App: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None This is a tracking bug for any bugs in the API that are blocking, or causing undue difficulties to, the Mobile Apps Team from... [18:40:04] jdlrobson: it looks like it has updates as of 11/19 (today) [18:40:11] brion: any time for quick review? i know you’ve got other stuffs today so no worry if not :) [18:40:12] but it does look crazy [18:40:16] 2014-03-18,,,,,,,,,,,,,,,,,, [18:40:16] 2014-03-19,,,,,,,,,,,,,,,,,, [18:40:16] \ [18:40:24] seems to be some bogus lines.. not sure if that's why? [18:40:33] mhurd: yeah just a sec [18:40:35] 3Wikipedia App / 3Android App: Android app: resolve the latest alpha build's anger issues - 10https://bugzilla.wikimedia.org/73543 (10Bernd Sitzmann) 5PATC>3RESO/FIX [18:40:48] brion: you’re awesome [18:41:00] awww :) [18:41:10] (03PS2) 10Florianschmidtwelzow: Don't try to set cursor on hidden elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174384 (https://bugzilla.wikimedia.org/73585) [18:41:20] bronte <3 [18:41:22] 3Wikipedia App / 3Android App: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dan Garry) [18:41:29] jdlrobson: ^ i just wondering, why FF has problems with empty text areas :/ [18:42:39] dbrant, bearND, mhurd, brion: I made a tracking bug for our API issues: https://bugzilla.wikimedia.org/show_bug.cgi?id=73616 [18:42:57] MaxSem: ^ [18:42:59] dbrant: please message out about the days your planning on taking off for the holidays [18:43:02] dbrant, bearND, mhurd, brion: This will help us escalate any issues we're running in to with the API, such as it not doing something we need, or doing something we don't need [18:43:03] FlorianSW: would be great to investigate that and work that out :) [18:43:23] jdlrobson: not sure what you see, I just see a huge spike in one of the lines on that graph. The rest of it looks fine, some data missing for a few days [18:43:24] awesome [18:43:25] tfinc: definitely [18:44:03] milimetric: that spike makes no sense and wasn't there before [18:44:35] dbrant, bearND: any ad hoc idea about: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7966007 ??? [18:44:58] dbrant: When you file a bug for the generator/full text search thing you mentioned, make sure you add it to the "depends on" in that tracking bug. :) [18:45:07] Deskana: will do! [18:45:39] jdlrobson: yeah, I just got back but I hear event logging's been having lots of problems [18:45:42] MaxSem: patch is needed you to look at was https://gerrit.wikimedia.org/r/#/c/174308/ [18:45:58] nothing looks broken in the limn graphs or processes themselves, this is a data issue [18:47:04] (03CR) 10Brion VIBBER: [C: 032] Made lang picker define delegate for selection notification. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174377 (owner: 10Mhurd) [18:47:26] (03CR) 10Brion VIBBER: "whoops wrong window. will review this one shortly" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174377 (owner: 10Mhurd) [18:47:36] (03CR) 10Brion VIBBER: [C: 032] Tweaks to Recent Searches. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174363 (owner: 10Mhurd) [18:50:35] dbrant: But yeah, try not to get too dragged in to the weeds with the full text search stuff. We'll have all of next sprint to figure out these issues and refine it. :-) [18:50:54] (03CR) 10Brion VIBBER: [C: 032] Made lang picker define delegate for selection notification. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174377 (owner: 10Mhurd) [18:51:23] brion: yay! thanks! [18:51:26] :D [18:51:50] Deskana: yep; I think it would be a fair workaround to simply not have continuation. (and maybe fetch more than 12 results all at once) [18:51:53] milimetric: doh :( [18:52:13] milimetric: can you send a mail to mobile-tech/mobile-l explaining the issue ? [18:52:52] FlorianSW: the search input field has been changed to a button. Maybe he doesn't find the button? Probably good to ask what versions of the app and what device he's using? [18:53:48] bearND: there is a connected ticket, too, which explains it a little bit more (and where i already asks the question :)) [18:54:21] (03CR) 10MaxSem: Show redirect targets in search results. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov) [18:55:08] MaxSem: can't we just ask the api for things that are not redirects? [18:55:21] hmmmmmmmm [18:55:21] seems very wasteful frontend code [18:55:37] i mean.. it used to return things that were not redirects [18:56:30] FlorianSW: ah, thanks. Those links are easy to miss. Yes, the other instance is clearer, and I think I've noticed that myself sometime ago. Would you file a bug? It seems that the SearchView doesn't show what the user types in some instances. Haven't figured out how to repro. [18:57:56] bearND: ok, i will ask some meta data (android version, device) and ask, if they want to try the beta release to give most possible information :) thanks for your quick response [18:58:37] (03CR) 10Jdlrobson: "oh nos..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174037 (owner: 10Bmansurov) [18:59:55] dbrant, bearND: The latest alpha crashes if you search for "Barack" and choose full text search. [19:00:02] dbrant, bearND: Even with no scrolling. [19:00:30] :( [19:00:40] Deskana: well then it doesn't have to do with continuation, either :( [19:02:14] dbrant: http://pastebin.com/kq5ThAsb [19:02:35] (03CR) 10Jdlrobson: [C: 04-1] "I really don't think the api should be returning redirects in the first place. Sync up with Max to see if we can do this by just changing " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov) [19:03:11] jdlrobson: why not? it's documented in the api. MaxSem what do you think? [19:03:44] bmansurov: I can add you as a collaborator on the WikiGrok API repo in github if you give me your github username [19:03:51] if a redirect matches, we should just return its target [19:04:01] hmm, or not? [19:04:01] kaldari: 6ahodir [19:04:24] MaxSem: that's what is happening now [19:04:42] bmansurov: added you [19:05:01] kaldari: thanks [19:06:05] http://hatjitsu.wmflabs.org/37418 [19:09:25] kaldari: Can I directly push to the github repo? Or should I fork it and make a pull request? [19:09:48] (03PS1) 10BearND: Fix NPE in full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174467 [19:10:04] Deskana: dbrant: I've got a workaround for it. ^ But I do notice some duplicate entries in the results. May have happened before, too. [19:17:35] 3MobileFrontend / 3stable: Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c5 (10Rummana Yasmeen) Nope, this is not a browser/page specific issue,was happening for me in all pages even in iOS safari.Once you switch to edit source mode the "Edit" butto... [19:25:22] 3Wikipedia App / 3Android App: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dan Garry) [19:42:20] chrismcmalunch marxarelli: on https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Setup_instructions i'm planning to remove the stuff about enabling the 'browsertests' role as it doesn't seem to be present anymore. like i've mentioned previously. lemme know if an issue. [19:43:06] dr0ptp4kt: please do. thanks! [20:06:27] kristenlans: do we have phabrichello yet? the migration is in 2 days :S [20:06:41] joakino: :-( [20:07:46] eep [20:07:55] so i think i might go to bed nw [20:07:57] it's been a while [20:08:09] jdlrobson: go sleep damn it [20:08:14] Goodnight jdlrobson ;-) [20:08:26] anything you need before i go? joakino i arranged a meeting for tomorrow around the grunt stuff so i'm hoping we can get that wrapped up [20:08:28] (03PS1) 10Mhurd: Search shows new results without blanking results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174490 [20:08:46] jdlrobson: antoine said that we should ping timo [20:08:50] thats the only think [20:08:52] thing [20:09:02] joakino: already added him hoping he can join [20:09:07] joakino: i think the qunit / istanbul issues im having are related to timeouts [20:09:07] jdlrobson: oki [20:09:16] i increased timeout drastically and it seemed to get further [20:09:19] most strange [20:09:24] jdlrobson: lets hope he appears xd [20:09:28] thats so weird... [20:09:32] brion: one more tiny patch for search stuffs... [20:09:41] ok will check after my meeting [20:10:01] good night, then, i'm leaving too [20:10:31] g’night joakino [20:10:34] and cat [20:10:39] brion: thanks! gotta run do some errands... [20:10:49] ok :) [20:10:50] night joakino! [20:12:35] (03PS2) 10Jdlrobson: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 [20:12:47] jdlrobson: you wanted to find me about something? [20:12:59] (yesterday) [20:13:09] +jdlrobson: [2014-11-18 19:07:29 +00:00] hopefully we can find antoine or krinkle. If not tomorrow the day after [20:13:15] (03CR) 10Jdlrobson: "I'm not seeing errors in console. If you are still seeing them please give me more steps to replicate e.g. page, stable/beta/alpha and wha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson) [20:13:19] Krinkle: yehhh [20:13:33] Krinkle: so i'm hoping to meet up with you joaquin and antoine to talk about the grunt/jenkins stuff [20:13:38] and understand it and get MobileFrontend using it [20:13:41] we have a Gruntfile now [20:13:52] the main goal is to get jscs running on commits [20:13:57] and in future jsdoc publishing on build [20:14:24] meeting setup for 3pm your time i think tomorrow - let me know if that doesn't work for you [20:15:45] Deskana|Away: running some errands - back in about 1hr [20:16:35] Krinkle: i gotta rush now but hope you can make it :) [20:16:54] Krinkle: also i've been submitting some patches to jscs that you may be interested in [20:17:05] jdlrobson: upstream? [20:17:14] Krinkle: yup had one merged already [20:17:37] Krinkle: https://github.com/jscs-dev/node-jscs/commit/75655d5cbcda76a39be2c3107936190cb2cab5d4 [20:17:51] jdlrobson: To set it up in mobilefrontend should be pretty straight forward. I'm not too flexible with scheduled meetings at the moment. I'd rather try over irc first. Considering this should be widely adopted and well-documented, it shouldn't require a full on meeting to explain it. [20:17:52] and just submitted https://github.com/jscs-dev/node-jscs/pull/780 [20:17:52] jdlrobson: I don't understand what the problem is here: https://gerrit.wikimedia.org/r/#/c/174308/ Can you expalin more? [20:18:06] Krinkle: prob not but i figured a meeting just to chat would be great [20:18:12] we can always finish early and i'm always happy to do so :) [20:18:41] we can do in irc if you prefer, i just want to make sure i get your attention to look at the stuff :) [20:19:21] bmansurov: so Kaldari/maxsem should feel free to overrule me but essentially i'm asking why can't we just do redirects: 'no' in the api request [20:19:29] why do we need to parse the result to filter them out [20:19:55] jdlrobson: we don't have to parse them, but according to a comment, we want to preserve the order [20:19:57] we have lots of API related fixme's to this effect and it's a trend i'd rather reverse - we should be making the api more friendly to ours and others needs rather than adding tape on top of it [20:20:33] jdlrobson: i looked at the results, the returned pages object is already sorted, so I can just skip all the filtering and show the pages results [20:20:37] bmansurov: data.query.redirects doesn't need to be in the result as far as i'm concerned [20:20:44] we don't care about them [20:21:04] it used to work so something has changed in the api [20:21:11] jdlrobson: ok [20:21:20] i'm sure with MaxSem's help you'll find a much simpler solution [20:21:29] anyway just leave a note on the card and i'll take a look tomorrow [20:21:33] i really need some sleep :) [20:21:58] (03CR) 10Bmansurov: [C: 032] Don't use 'new' with jQuery.Deferred [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174331 (owner: 10Krinkle) [20:22:31] jdlrobson: good night [20:22:42] o/ [20:23:27] dr0ptp4kt: I am refactoring browser tests in a handful of repos, I expect to refactor the documentation Real Soon Now [20:27:45] (03Merged) 10jenkins-bot: Don't use 'new' with jQuery.Deferred [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174331 (owner: 10Krinkle) [20:38:27] (03PS3) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) [20:41:55] (03PS4) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) [20:45:37] (03CR) 10Bmansurov: Show redirect targets in search results. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov) [20:46:33] MaxSem: What do you think about this patch? https://gerrit.wikimedia.org/r/#/c/174308/ Do you think we should change the API and make it better by resolving redirects? [20:54:03] bmansurov, ??? [20:54:18] you're already resolving redirects with &redirects, right? [20:54:23] MaxSem: yes [20:54:33] MaxSem: Jon says it should be done in the API level [20:54:57] MaxSem: He says we don't have to filter pages and resolve them on our end. [20:55:10] ergh [20:55:21] I have RFC review, talk to you in an hour [20:56:49] MaxSem: cool [21:08:12] Maryana: Any suggestions on what I should work on next? [21:12:24] kaldari: we still having our meeting or do you need to postpone? [21:12:36] (03CR) 10Bmansurov: [C: 032] Hygiene: Use correct indentation level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174396 (owner: 10Jdlrobson) [21:13:15] (03Merged) 10jenkins-bot: Hygiene: Use correct indentation level [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174396 (owner: 10Jdlrobson) [21:14:33] (03CR) 10Bmansurov: [C: 032] Hygiene: Add new lines before function keyword [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174397 (owner: 10Jdlrobson) [21:15:17] bmansurov: if you want you can take a crack at this to understand how to add new campaigns to wikigrok: https://trello.com/c/pdB7cFUe/3-2-new-albums-campaign-live-or-studio-album [21:15:22] jhobs: sorry, had a phone call [21:15:34] Maryana: thanks [21:15:37] kaldari: think it'd be okay for baha to start working on that? [21:15:44] kaldari: all good. I have to be done by 4:30 though, so do you want to just rush it or postpone? [21:15:57] 1:30pst * [21:16:03] chrismcmahon: okay if i do some cleanup meanwhile? [21:16:06] Maryana: sure [21:16:11] cool :) [21:16:18] jhobs: let's rush it then :) [21:16:25] alright [21:16:40] chrismcmahon: i know you told me previously Go For It. i guess you can always refactor my refactor :) [21:17:34] (03CR) 10Bmansurov: [C: 032] Hygiene: Require line feed at end of file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 (owner: 10Jdlrobson) [21:18:13] dr0ptp4kt: sure, we'd appreciate it [21:18:29] chrismcmahon: cool, alright, i'll try to not mess it up too much [21:18:35] dr0ptp4kt: I did a big re-write maybe a year ago, but it's definitely time to revisit again [21:19:55] (03Merged) 10jenkins-bot: Hygiene: Add new lines before function keyword [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174397 (owner: 10Jdlrobson) [21:22:50] 3MobileFrontend / 3stable: Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c6 (10Florian) Jon is talking about the Firefox only problem :) The VE problem is right, it doesn't work on all pages :( [21:23:23] (03CR) 10Bmansurov: [C: 032] Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 (owner: 10Jdlrobson) [21:24:34] (03CR) 10Bmansurov: [C: 032] Hygiene: Move variable declaration on to single line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 (owner: 10Jdlrobson) [21:25:12] (03CR) 10Bmansurov: [C: 032] Hygiene: Simple whitespace and js documentation fix to nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174403 (owner: 10Jdlrobson) [21:35:24] 3MobileFrontend / 3stable: Saving Icon isn't visible when save an edit - 10https://bugzilla.wikimedia.org/73622 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 17175 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17175&action=edit stable missing loading circle Steps to reprod... [21:35:35] 3MobileFrontend / 3stable: Saving Icon isn't visible when save an edit - 10https://bugzilla.wikimedia.org/73622#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/uPNVb0XD [21:37:09] (03CR) 10BearND: [C: 032] Remember correct search panel when exiting/reentering search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174355 (https://bugzilla.wikimedia.org/73579) (owner: 10Dbrant) [21:39:43] (03Merged) 10jenkins-bot: Remember correct search panel when exiting/reentering search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174355 (https://bugzilla.wikimedia.org/73579) (owner: 10Dbrant) [21:40:37] Krinkle|detached: if you can use headphone it'll solve this problem of audio loop [21:41:20] 3MobileFrontend / 3stable: Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c7 (10Rummana Yasmeen) Ah got it, so this patch is going to fix for all pages in all browsers? [21:42:52] 3Wikipedia App / 3Android App: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dmitry Brant) [21:43:03] (03PS5) 10BearND: Swipe to refresh! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173926 (owner: 10Dbrant) [21:47:48] (03CR) 10BearND: [C: 032] Swipe to refresh! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173926 (owner: 10Dbrant) [21:48:11] (03Merged) 10jenkins-bot: Swipe to refresh! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/173926 (owner: 10Dbrant) [21:48:19] (03CR) 10Florianschmidtwelzow: "Maybe, just an idea, because personaly i don't like the anchor links in CtaDrawer, too: What do you think about to use mw-ui-button there," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [21:49:56] (03CR) 10Dbrant: [C: 032] "Works for now; but we should keep a close eye on the solution from the API point of view:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174467 (owner: 10BearND) [21:50:50] (03PS3) 10Dbrant: Allow caller to specify maxResults in FullSearchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174293 (owner: 10BearND) [21:53:19] (03CR) 10Dbrant: [C: 032] Allow caller to specify maxResults in FullSearchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174293 (owner: 10BearND) [21:53:39] (03Merged) 10jenkins-bot: Allow caller to specify maxResults in FullSearchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174293 (owner: 10BearND) [21:55:21] 3MobileFrontend / 3stable: Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c8 (10Florian) Unhappily no, this patch adresses the Firefox problem. For now, I haven't had the time to look into it, why VE doesn't work :/ [21:57:36] (03PS3) 10BearND: Add SuggestionsTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174365 [21:59:09] dbrant: thanks for merging. Would you also merge https://gerrit.wikimedia.org/r/#/c/174365/? It shouldn't affect anything, just adds some new classes that are not used yet, but will be needed for the UI part [21:59:30] bearND: sure, looking [22:00:08] dbrant: note the change in WikidataCache.java also [22:11:13] kaldari: how do I install https://gerrit.wikimedia.org/r/#/admin/projects/operations/mediawiki-config ? Is there a documentation? [22:11:52] MaxSem: Do you know where the images in /images/mobile/ come from that are on the cluster? Are they in a repo or just stored locally on tin? [22:12:21] example? [22:12:35] MaxSem: The W logo on https://en.m.wikipedia.org/wiki/Special:UserLogin [22:12:58] in mediawiki-config [22:13:53] bmansurov: mediawiki-config is designed for the cluster, so you wouldn't really want to install it locally, AFAIK. I can explain what the different files are for though. [22:14:21] MaxSem: Ah, thanks! [22:14:43] kaldari: I'm trying to work on https://trello.com/c/pdB7cFUe/3-2-new-albums-campaign-live-or-studio-album . Do I need the WikiGrok extension instead then? [22:15:07] bmansurov: There are 2 different ways you could do it... [22:18:03] kaldari: i'm with you [22:19:11] bmansurov: You could add the config vars to WikiGrok.php directly or to your LocalSettings.php file. RIght now, however, there isn't really a way to test production-style WikiGrok campaigns since you they require being able to access the Wikidata database directly (which can only be done from the cluster). You would actually need to set-up your own local installation of Wikidata.... [22:20:20] kaldari: do you have Wikidata installed locally? [22:20:34] bearND: testOneIDTwice() is failing for me... [22:20:49] dbrant: checking... [22:20:51] ...and populate it with data. Since these types of campaigns are easy enough to turn on or off, I would suggest just adding the code to mobile.php and then we can test it after a SWAT deployment (which is needed anyway for any config changes) [22:21:23] kaldari: so I'll have to clone the mediawiki-config anyway, but won't be able to use it locally [22:21:27] bmansurov: No, but I think Max got it set up locally. It's a pain. [22:21:36] bmansurov: correct [22:21:40] kaldari: ok thank you [22:22:18] bmansurov: Normally, you can test most config changes locally by adding them to your LocalSettings.php first, but this is a complicated case. [22:22:33] i see [22:23:05] bmansurov: Maybe MaxSem would have some advice for testing campaigns, but I haven't come up with any solution yet. [22:23:51] kaldari: cool, I'm meeting him later today, so I'll ask about this stuff too ;) [22:26:55] dbrant: what is your primary site on the device you're testing with? [22:27:07] dbrant: i seem to recall having issues when using test [22:27:45] because wikidata doesn't have a "test" language [22:28:39] dbrant: ideally, we would pass in the language to the tasks instead of getting primary language and primary site inside of the tasks [22:29:31] dbrant: the test works for me now. I did have a few issues yesterday but besides the primary site issue I thought I fixed them all. [22:30:06] dbrant: what's the stack trace in logcat? [22:32:54] bearND: dbrant did you see the email i sent to mobile-l about search results changing since yesterday? [22:33:44] mhurd: Deskana|Away is locked away in a room with Voiz brainstorming. [22:34:02] kristenlans: viboiz? [22:34:16] Moibha [22:34:34] kristenlans: hehe that works too [22:36:54] mhurd: interesting... [22:53:30] bearND: how does one change the primary site for the tests? [22:53:58] dbrant: there is no special setting for the tests. Just open the app and change it there [22:54:18] same shared preference [22:56:30] bearND: my app is set to 'en', but when I run the tests, it gets set to 'test' automatically. I thought that was the expected behavior. [22:56:45] dbrant: bearND i think the search query crash you guys were seeing is a results of the recent update - before it i believe there was always a 1-1 between the ordered and the unordered results lists. now, if i search for “fish” the 2 lists look the same, but searching for “fishr” returns lists of differrent sizes. this is with prefix search btw. [22:57:03] *the cirrus search update* [22:57:24] Maryana: which board has the cards for the login/create account and search things on opera mini? [22:57:42] Maryana: i see some stuff with trello search, but didn't want to link to the wrong card [22:57:48] mhurd: but the crashes we saw earlier today (until I patched it) were in full text search [22:58:07] bearND: try “fishr” in prefix search and see it crashes [22:58:47] mhurd: not on the latest Android [23:00:14] mhurd: I'm getting the same two results as on desktop [23:00:25] dr0ptp4kt: Those cards are in “In Analysis” column in the Mobile Web Next Sprint [23:00:40] kaldari: I'm having a hard time picking the proprty for albums. Is there a property similar to 'subclass of' but in the opposite direction, i.e. 'superclass of'? [23:00:54] dr0ptp4kt: just added you to the board :-) [23:00:59] kristenlans: thx. cc Maryana [23:01:03] bmansurov: The property is actually 'instance of' [23:01:05] dr0ptp4kt: i added you to the cards :) [23:01:14] kaldari: cool [23:01:16] Maryana: thx, too. cc kristenlans [23:01:49] bmansurov: P31 I think [23:01:56] thanks [23:03:22] bearND: right, but if you look at the raw results that query returns it actually has many more than 2 results, but only 2 in the ordered list [23:13:27] (03PS1) 10Bmansurov: Round logo width [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [23:19:27] MaxSem: do you have time to talk about the search api? [23:23:47] (03PS4) 10BearND: Add SuggestionsTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174365 [23:23:59] dbrant: ^ see if that's better [23:28:02] (03CR) 10Dbrant: [C: 032] Add SuggestionsTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174365 (owner: 10BearND) [23:28:34] \o/ [23:31:11] mhurd: when I go to https://en.m.wikipedia.org/w/api.php?action=query&format=json&generator=prefixsearch&gpssearch=fishr&gpsnamespace=0&gpslimit=12&prop=pageimages&piprop=thumbnail&pithumbsize=96&pilimit=12&list=prefixsearch&pssearch=fishr&pslimit=12 I see only 2 in each list [23:33:25] (03CR) 10Kaldari: [C: 04-1] Round logo width (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [23:37:57] (03CR) 10Bmansurov: Round logo width (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [23:38:33] bearND: haha i messed up - i had both “fish” and “fishr” in the query i tried. [23:39:14] mhurd: ah, that explains ;) I just copied and pasted the URL from the debugger [23:39:25] dbrant bearND: i pointed chad to the bug dmitry opened (https://bugzilla.wikimedia.org/show_bug.cgi?id=73623) [23:39:36] mhurd: will add a patch to get rid of the stupid warning [23:49:24] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=73623 [23:54:23] (03PS2) 10Bmansurov: Add new config variable: $wgMFCustomLogoPaths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [23:55:05] kristenlans: vbamba: ahh, I don't think I can make the design review mtg! I made plans at 7:30, and need to leave soon... and the meeting notification just popped up :( [23:55:18] vbamba: is there anything super pressing that needs to be discussed?