[00:02:49] bmansurov: It looks like getimagesize only works on full URLs, while we're using protocol relative URLs for those paths currently. I'm in the process of changing that so that it will work (hopefully) [00:03:11] kaldari: i've submitted another patch ;( [00:03:49] bmansurov: Well, if my solution doesn't work, I'll try yours instead :) [00:04:00] ok [00:04:58] bmansurov: In the process, I'm also moving that image out of MobileFrontend and into mediawiki-config, since we shouldn't really have any WMF-specific stuff in MF (in theory) [00:05:45] dbrant: no worries, I'm there [00:05:46] bmansurov: Of course we don't always follow that rule, as I'm sure you can tell :P [00:06:26] kaldari: ;) [00:10:38] (03CR) 10MaxSem: "Why not reuse the existing variable: $wgMFCustomLogos['copyright-url'] = ... ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [00:11:39] (03CR) 10Bmansurov: "Good idea, haven't thought of it that way. I'll do so if Kaldari's method doesn't work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [00:12:15] bmansurov: Looks like it's working now: https://test.m.wikipedia.org/w/index.php?title=Main_Page [00:13:08] kaldari: cool, i'll abandon that patch [00:13:50] (03Abandoned) 10Bmansurov: Add new config variable: $wgMFCustomLogoPaths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [00:20:07] 3MobileFrontend / 3stable: Image tag for enwiki project logo should specify dimensions and use a stable URL - 10https://bugzilla.wikimedia.org/58886#c12 (10Ryan Kaldari) 5PATC>3RESO/FIX Fixed on test.wiki. Should go out to en.wiki soon. [00:26:13] brion: any review cycles to spare? :) https://gerrit.wikimedia.org/r/#/c/174490/ [00:27:39] Anyone know what POC stands for: https://gerrit.wikimedia.org/r/#/c/166089/ [00:28:38] Proof of Concept? [00:36:01] kaldari: looks like so #4: http://www.urbandictionary.com/define.php?term=poc [00:37:19] bmansurov, getimagesize() on a URL, really? [00:37:25] on every pageview? [00:41:18] (03PS1) 10MaxSem: Revert "Add footer logo dimensions" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174611 [00:41:27] (03CR) 10MaxSem: [C: 032] Revert "Add footer logo dimensions" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174611 (owner: 10MaxSem) [00:42:21] MaxSem: you're right, kaldari, I'll reopen my patch. [00:44:38] (03PS1) 10MaxSem: Revert "Add footer logo dimensions" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174612 [00:44:45] (03CR) 10MaxSem: [C: 032] Revert "Add footer logo dimensions" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174612 (owner: 10MaxSem) [00:45:03] (03Merged) 10jenkins-bot: Revert "Add footer logo dimensions" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174611 (owner: 10MaxSem) [00:45:30] (03Merged) 10jenkins-bot: Revert "Add footer logo dimensions" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174612 (owner: 10MaxSem) [00:49:55] kaldari: hmm, i can't get wikigrok to show up on beta labs [00:50:15] Maryana: I'll look... [00:51:26] (03Restored) 10Bmansurov: Add new config variable: $wgMFCustomLogoPaths [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [00:51:32] (03PS3) 10Bmansurov: Use local logo file for measuring its dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [00:51:40] (03CR) 10jenkins-bot: [V: 04-1] Use local logo file for measuring its dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [00:53:56] Maryana: It's throwing a JS error [00:54:16] :( [00:57:38] 3MobileFrontend / 3stable: Search field inaccessible on Opera Mini - 10https://bugzilla.wikimedia.org/73632 (10dr0ptp4kt) 3NEW p:3Unprio s:3normal a:3None Created attachment 17179 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17179&action=edit Shows the hamburger and magnifying glass squishe... [00:58:20] 3MobileFrontend / 3stable: Search field inaccessible on Opera Mini - 10https://bugzilla.wikimedia.org/73632#c1 (10dr0ptp4kt) To replicate, install Opera Mini on iOS or Android, and enable Opera Mini mode, and visit Wikipedia pages. Adding a cachebuster parameter to the URL doesn't seem to help. [01:00:40] 3MobileFrontend / 3stable: Search field inaccessible on Opera Mini - 10https://bugzilla.wikimedia.org/73632#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Ds8MSOrO [01:02:40] bearND: thanks for covering! anything of note? [01:04:27] dbrant: we basically went through https://trello.com/b/nAhhqDXg/mobile-app-sprint-45, talked about some UI refinements we need to get things ready for production [01:05:06] dbrant: the two link I added in https://trello.com/c/T6K92imD/14-fix-icons-in-android-action-bar are from vbamba. [01:06:41] dbrant: Deskana is going to check the first two cards if they are still valid with a production 5.0 OTA device. He's noticed it with a preview 5.0 ROM [01:07:53] bearND: cool, thanks! [01:21:16] Maryana: I found the culprit! https://gerrit.wikimedia.org/r/#/c/172932/ :) [01:21:33] haha [01:21:39] soo it was me? [01:21:57] see, that's why you don't let your PMs merge things [01:22:05] why would it be affecting beta, though? [01:23:00] Maryana: I think the dependencies are a bit screwed up so it's trying to load a module in beta that isn't supposed to load in beta [01:23:22] kaldari: well, glad i caught my own bug [01:23:27] feel free to revert that patch [01:23:30] :) [01:34:13] (03PS1) 10Kaldari: Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174616 (https://bugzilla.wikimedia.org/73633) [01:35:12] Maryana: Would you like to do the honors: https://gerrit.wikimedia.org/r/#/c/174616/ [01:45:05] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None If you try to load WikiGrok on Beta Labs, it doesn't load and a Javascript error is thrown: Attempt to run module outside declared environment mode beta [01:46:19] MaxSem: Looks like nobody's around anymore. Could you merge https://gerrit.wikimedia.org/r/#/c/174616/ ? [01:46:34] (03CR) 10MaxSem: [C: 032] Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174616 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [01:47:11] (03Merged) 10jenkins-bot: Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174616 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [01:51:30] (03PS1) 10Kaldari: Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174620 (https://bugzilla.wikimedia.org/73633) [01:54:41] (03PS2) 10Kaldari: Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174620 (https://bugzilla.wikimedia.org/73633) [01:54:49] mhurd, https://bugzilla.wikimedia.org/show_bug.cgi?id=73623 [01:55:52] (03PS3) 10Kaldari: Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174620 (https://bugzilla.wikimedia.org/73633) [02:00:53] kaldari: d'oh, you beat me to it [02:01:10] Maryana: Should be working on beta labs now [02:04:48] kaldari: i'm trying to test, but i can't get beta + wikidata id query string to stick [02:04:55] also, red links are showing up in beta. wut. [02:05:47] still no wikigrok.. [02:06:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=73323 [02:07:27] (03CR) 10Bmansurov: [C: 04-1] "I don't think the patch resolves the issue. It doesn't do what the commit message says. Maybe I'm missing something." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174384 (https://bugzilla.wikimedia.org/73585) (owner: 10Florianschmidtwelzow) [02:07:58] (03PS3) 10Deskana: Ensure Wikidata description is always shown in correct language in lead image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174375 (https://bugzilla.wikimedia.org/73598) [02:23:24] 3MobileFrontend / 3beta: Mobile: Redlinks showing up in beta - 10https://bugzilla.wikimedia.org/73637 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None I'm seeing redlinks in Beta locally and on Beta Labs. [02:25:22] 3MobileFrontend / 3beta: Mobile: Redlinks showing up in beta - 10https://bugzilla.wikimedia.org/73637#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/d4oiN9dA [02:42:52] 3MobileFrontend / 3stable: [Regression wmf9]Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c9 (10Rummana Yasmeen) okay,just to keep note, this bug is now in test2 as well after today's deployment since it was regression from wmf9.I will test the fix... [02:58:34] (03PS1) 10Mhurd: Limit recent search items to 100. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174623 [05:13:37] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633#c4 (10Jon) can you elaborate. infobox should only be loading in alpha. of it's leaking to beta something is seriously wrong. PS. please please please can we not self merge. I keep telling you this. It's not... [05:27:37] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633#c5 (10Ryan Kaldari) Jon: I didn't self merge. Max merged it. Also I'm not sure what you mean about misunderstanding the problem. I haven't claimed to understand the problem at all. I just disabled it for the... [05:38:31] kaldari: i got bubble tea! [05:41:53] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633#c6 (10Ryan Kaldari) I think I found the problem: mobile.wikigrok.dialog has mobile.alpha listed as a dependency, thus it's going to try to run anything in mobile.alpha when wikigrok loads in beta. I'll fix it... [05:42:49] (03Abandoned) 10Kaldari: Disabling mobile infobox experiment for now - throwing JS error [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174620 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [05:44:30] kaldari: that makes more sense [05:44:34] that was what i was worried about [05:44:45] yeh nothing should have mobile.alpha, mobile.beta, mobile.stable as dependency [05:45:42] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633#c8 (10Jon) That sounds right :) I'm here to +2 the patch... [05:56:31] (03PS1) 10Kaldari: Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) [06:00:49] (03CR) 10Jdlrobson: [C: 04-1] "In theory we should never need to use mobile.beta or mobile.alpha as a dependency and be more specific about what the module needs." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [06:02:25] (03PS1) 10BearND: Use continue parameter to avoid API warnings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174632 [06:04:37] (03PS3) 10Jdlrobson: Hygiene: Require new lines before function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 [06:04:43] (03PS3) 10Jdlrobson: Hygiene: Require line feed at end of file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 [06:04:53] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633#c10 (10Ryan Kaldari) Patch submitted and waiting for +2 :) If you're wondering why I turned infoboxes off without troubleshooting it further, it's because Maryana told me it was broken right as I was about t... [06:06:22] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633#c11 (10Jon) Needs work. Am on irc if you need to chat on can fix up myself. [06:06:49] (03PS1) 10Jdlrobson: WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 [06:07:26] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [06:07:59] (03PS4) 10Jdlrobson: Hygiene: Require line feed at end of file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 [06:08:17] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 (owner: 10Jdlrobson) [06:08:26] (03PS3) 10Jdlrobson: jscs: Add require-line-break-after-variable-assignment config option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 [06:09:00] (03Merged) 10jenkins-bot: Hygiene: Require line feed at end of file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174399 (owner: 10Jdlrobson) [06:10:12] (03PS3) 10Jdlrobson: Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 [06:10:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 (owner: 10Jdlrobson) [06:11:52] (03PS4) 10Jdlrobson: Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 [06:12:04] (03PS3) 10Jdlrobson: Hygiene: Move variable declaration on to single line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 [06:12:12] (03PS4) 10Jdlrobson: Hygiene: Move variable declaration on to single line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 [06:12:21] (03CR) 10Jdlrobson: [C: 032] "cherry pick merge" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 (owner: 10Jdlrobson) [06:12:31] (03PS3) 10Jdlrobson: Hygiene: Simple whitespace and js documentation fix to nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174403 [06:12:37] (03PS3) 10Jdlrobson: jscs: Use disallowSpacesInMemberExpression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174404 [06:12:56] (03CR) 10BearND: [C: 04-1] "needs a manual rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant) [06:13:08] (03Merged) 10jenkins-bot: Hygiene: Move variable declaration on to single line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174402 (owner: 10Jdlrobson) [06:13:31] (03CR) 10Kaldari: "Jdlrobson: Well, I could either do..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [06:14:24] (03PS4) 10Jdlrobson: Don't indent all page-lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow) [06:14:29] (03CR) 10Jdlrobson: Don't indent all page-lists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow) [06:14:35] (03CR) 10Jdlrobson: [C: 032] Don't indent all page-lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow) [06:15:14] (03Merged) 10jenkins-bot: Don't indent all page-lists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173530 (https://bugzilla.wikimedia.org/73448) (owner: 10Florianschmidtwelzow) [06:17:50] (03CR) 10Jdlrobson: [C: 031] "Need to verify this doesn't break link to Flow pages.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 (owner: 10Florianschmidtwelzow) [06:18:28] (03PS1) 10Jdlrobson: Revert "Focus editor textarea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174635 [06:21:38] 3MobileFrontend / 3stable: Page images busted on tablet - 10https://bugzilla.wikimedia.org/73448 (10Jon) 5PATC>3RESO/FIX [06:22:58] (03Abandoned) 10Jdlrobson: WIP: Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 (owner: 10Jdlrobson) [06:24:15] (03PS5) 10Jdlrobson: Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 [06:27:05] (03CR) 10Jdlrobson: "mobile.startup is better as really all this needs is the Panel.js code" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [06:28:05] (03CR) 10Florianschmidtwelzow: [C: 031] Revert "Focus editor textarea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174635 (owner: 10Jdlrobson) [06:34:36] (03PS1) 10BearND: Avoid NPE when going from search to another page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174636 [06:42:13] (03PS3) 10Jdlrobson: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 [06:42:15] (03PS1) 10Jdlrobson: Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 [06:54:21] (03PS2) 10Jdlrobson: Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 [06:54:23] (03PS4) 10Jdlrobson: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 [07:02:34] (03PS1) 10Florianschmidtwelzow: Hygiene: Use topic-title-list for CategoryOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174638 [07:07:28] (03PS2) 10Kaldari: Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) [07:09:16] (03PS3) 10Kaldari: Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) [09:27:10] (03CR) 10Jdlrobson: [C: 032] Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [09:27:38] (03CR) 10Jdlrobson: [C: 032] Hygiene: Simple whitespace and js documentation fix to nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174403 (owner: 10Jdlrobson) [09:27:52] (03Merged) 10jenkins-bot: Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174631 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [09:28:16] (03Merged) 10jenkins-bot: Hygiene: Simple whitespace and js documentation fix to nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174403 (owner: 10Jdlrobson) [09:42:09] good morning [10:29:52] 3MobileFrontend / 3beta: Mobile: Redlinks showing up in beta - 10https://bugzilla.wikimedia.org/73637#c2 (10Jon) 5NEW>3RESO/INV yup that's the incomplete feature we never finished and this is not a bug. It's in the beta column in Q2 backlog. We might want to rethink that and move back to alpha? [10:30:38] 3MobileFrontend / 3stable: [Regression wmf9]Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c10 (10Jon) If there are two problems here there should be 2 bugs.. [10:49:48] jdlrobson: hey are you on? [11:03:07] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633 (10Jon) 5PATC>3RESO/FIX [11:12:10] joakino: hey [11:12:11] (03PS2) 10Jdlrobson: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:12:13] yeh i'm around [11:12:24] joakino: so the issue i'm having with qunit is timeout related [11:12:28] ^ that fixes it for me [11:12:33] but i have no idea why it is so slow [11:13:02] joakino: maybe related to https://github.com/gruntjs/grunt-contrib-qunit/issues/65 ? [11:14:30] (03CR) 10Jdlrobson: [C: 031] "It's just incredibly slow" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:16:07] jdlrobson: hi! [11:16:10] lets see [11:16:16] joakino: or maybe it is https://github.com/gruntjs/grunt-contrib-qunit/issues/44 [11:19:53] (03CR) 10Jdlrobson: Hygiene: Remove M.getLeadSection (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 (owner: 10Jdlrobson) [11:20:01] (03PS4) 10Jdlrobson: Hygiene: Remove M.getLeadSection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 [11:30:05] jdlrobson: EventLogging's MobileWebClickTracking volume about doubled around 2014-11-14 01:00. Is that expected? [11:30:39] jdlrobson: what do you get with : npm ls grunt-contrib [11:30:55] 3MobileFrontend / 3stable: Editor switcher broken - 10https://bugzilla.wikimedia.org/73646 (10Jon) 3NEW p:3Unprio s:3normal a:3None Open up the wikitext editor and attempt to switch to VE. It no longer works. Clicking has no effect and you remain on the wikitext editor. On Chrome and Firefox. [11:30:55] jdlrobson: what do you get with : npm ls grunt-contrib-qunit [11:31:07] 3MobileFrontend / 3stable: [Regression wmf9]Cannot create a new page in Firefox. Edit button doesn't respond - 10https://bugzilla.wikimedia.org/73585#c11 (10Jon) I captured the other issue in bug 73646 [11:32:08] MobileFrontend-dependencies@0.0.1 /Users/jrobson/git/vagrant/mediawiki/extensions/MobileFrontend [11:32:08] └── (empty) [11:32:14] so nothing exciting joakino [11:32:36] └── grunt-contrib-qunit@0.5.2 btw [11:33:25] hm thats the same as me [11:34:54] jdlrobson: what about npm ls grunt-lib-phantomjs [11:35:23] 3MobileFrontend / 3stable: Editor switcher broken - 10https://bugzilla.wikimedia.org/73646#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/AbulO05q [11:35:45] grunt-lib-phantomjs@0.6.0 [11:35:55] same shit here... damn it [11:36:01] bizarrely.. [11:36:05] grunt-mocha@0.4.11 extraneous [11:36:08] grunt-lib-phantomjs@0.4.0 [11:36:24] what? so 0.4 or 0.6? [11:36:38] 0.6 for grunt-contrib-qunit@0.5.2 [11:36:52] joakino: maybe it's just because you and baha have new machines [11:36:58] everyone else has slow old ones [11:37:02] this is why you guys dont have issues [11:37:14] jdlrobson: that would be very weird [11:37:25] because make qunit works fine, but not the grunt one [11:37:30] so it is not because of the machine [11:37:50] npm semver ranges and that mumbo jumbo can get pretty quirky... [11:39:05] jdlrobson: also we should all use at least the same npm major version [11:41:31] mmm [11:41:41] what npm version are you using? [11:41:53] 2.1.4 [11:42:02] yeh let me try upgrading that [11:42:27] then remove the node_modules folder and npm install fresh [11:45:28] 2.1.8 is latest [11:45:56] give it a go [11:46:21] (03PS1) 10Florianschmidtwelzow: Hygiene: Use icons.spinner to create loading icon in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174674 (https://bugzilla.wikimedia.org/73622) [11:50:37] (03PS2) 10Florianschmidtwelzow: Hygiene: Use icons.spinner to create loading icon in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174674 (https://bugzilla.wikimedia.org/73622) [11:51:49] (03CR) 10Florianschmidtwelzow: [C: 04-1] "For some reason, the loading button get's inline style "display: none;". Have to figure out, what happens there :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174674 (https://bugzilla.wikimedia.org/73622) (owner: 10Florianschmidtwelzow) [11:54:46] still takes forever must be a local vagrant issue joakino :-/ [11:55:10] jdlrobson: pff [11:55:23] jdlrobson: it is frustrating because i can't reproduce so i can't help [11:55:31] yeh i know :/ [11:57:13] joakino: i'm fine merging it in slow mode though [11:57:18] will just help us work out what's going wrong [11:57:28] joakino: so hopefully rmoen is back today and can confirm it works for him [11:57:32] or kaldari [11:57:58] jdlrobson: also, the coverage test changes the qunit package to the older-forked-with-istanbul one, so it may change anything [11:58:09] * the coverage patch [11:58:23] mmm [12:08:04] (03PS2) 10Jdlrobson: WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 [12:08:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [12:48:51] i'm out for lunch [12:48:55] see you later [13:33:38] 3MobileFrontend / 3stable: Editor switcher broken - 10https://bugzilla.wikimedia.org/73646#c2 (10Jon) I'm investigating this. I know what's happening but not why. [13:56:57] jdlrobson: are we having the meeting? [13:57:12] joakino: i hope so Krinkle was saying we could just do it over irc though [13:57:25] aha [13:57:52] I'm doing paperwork for my London relocation at the moment. Can't do a meeting at this exact moment [13:58:22] Krinkle: okay. when will you be free? [13:58:48] 3 hours more? [13:58:57] Like I said, it's tricky to get a full session of video where I can't do other stuff. I'm being called at odd hours, scanning things. Waiting for peopel to come back with references. [13:59:46] And really it doesn't need a session. I'd like to principally refuse to for this purpose and try e-mail or irc first. What have you tried so far? [14:00:28] Krinkle: weve had countless emails. We want to understand how all this stuff works so that we rely less on you and antoine for anything jenkins related [14:00:45] async comms doesn't seem to be working [14:01:10] and it's frustrating as i'm sure it's all really simple [14:03:40] Unless I missed it I've only seen that you want certain tasks (e.g. jscs) and Antoine and me saying to use Grunt [14:06:24] joakino: i'm talking to antoine on the hangout if you want to join. [14:06:28] Krinkle: we are using grunt [14:06:31] we just dont know the rest [14:06:53] Krinkle: we have implemented a grunt task with stuff like jscs, but there is a gruntfile somewhere that is executed on jenkins, we would like it to be our gruntfile, and not the other one [14:06:57] jdlrobson: oki [14:09:20] joakino: jdlrobson: I'm not sure I follow. In what job is there a gruntfile on the server that's not yours? [14:09:28] all -npm jobs do is run npm install and npm test [14:09:45] Which only looks in your local repo. It uses your grunt version and gruntfile [14:10:10] as specified in your package.json in scripts.test: grunt test [14:14:12] joakino: jdlrobson: Right, so you're already using Grunt. That means the introduction Antoine was hoping for won't be happening. I'll get him up to speed some other time, you're already past that. [14:25:28] jdlrobson: joakino: :) ? [14:25:42] Krinkle: we are grokking zuul [14:35:04] jdlrobson: EventLogging's MobileWebClickTracking volume about doubled around 2014-11-14 01:00. Is that expected? [14:35:26] no there is a mail about it from dan andrescu :/ [14:35:32] cc milimetric [14:36:01] There is? [14:36:04] * qchris checks mails again. [14:38:45] Ouch. Internal lists :-( [14:41:20] (03CR) 10Dbrant: [C: 032] Use continue parameter to avoid API warnings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174632 (owner: 10BearND) [14:46:57] jdlrobson: there :) [14:49:06] (03CR) 10Dbrant: [C: 032] Ensure Wikidata description is always shown in correct language in lead image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174375 (https://bugzilla.wikimedia.org/73598) (owner: 10Deskana) [14:49:36] so joakino want to divide and conquer? [14:49:45] one of us do package.json other one copy the Flow one? [14:49:51] jdlrobson: sure [14:50:10] joakino: pick one :) [14:50:38] jdlrobson: i'll set up the package.json? [14:50:48] joakino: ok i'll take care of zuul [14:51:20] jdlrobson: can you login to gerrit? [14:51:27] joakino: haven't tried.. [14:51:34] i wanted to comment on a patch of yours but i can't login... [14:53:40] jdlrobson: for this https://gerrit.wikimedia.org/r/#/c/173858/ i'm getting `Error: Module not found: modules/uploads/PhotoUploaderButton` from mainmenutweaks.js [14:54:07] jdlrobson: i'll try to post that to gerrit if I get to log in [14:57:02] joakino: mm i'll take a look. I think baha had same issue [14:57:04] jdlrobson: jesus i got it, i changed wikitech password and they are linked... [14:57:09] fuckssake [14:57:17] joakino: ok so i posted the zuul change [14:58:57] (03CR) 10Jhernandez: [C: 04-1] "With debug=true i'm getting `Error: Module not found: modules/uploads/PhotoUploaderButton` from mainmenutweaks.js" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson) [15:00:39] (03PS3) 10Jdlrobson: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 [15:01:39] 3MobileFrontend / 3alpha: Alpha: Spinner doesn't hide bell for notifications - 10https://bugzilla.wikimedia.org/73058#c4 (10Andre Klapper) All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close th... [15:03:02] (03PS1) 10Jhernandez: Set up npm tasks linked to grunt (for Jenkins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174697 [15:03:24] jdlrobson: there is our patch ^ [15:03:28] (03PS4) 10Jdlrobson: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 [15:03:36] (03CR) 10jenkins-bot: [V: 04-1] Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson) [15:03:37] run `npm test` to try it [15:03:57] joakino: perhaps not call it jenkins [15:03:58] jdlrobson: and in the future we change the jenkins task of the grunt file to execute stuff on jenkins [15:04:04] jenkins-test [15:04:11] we can then have a jenkins-gate-and-submit [15:04:18] oki [15:04:29] but npm runs always npm test? [15:04:40] joakino: it runs different commands no? [15:04:49] the default npm task only runs npm test [15:05:02] "prepublish": "grunt build", "test": "grunt test", [15:05:06] is what VE use [15:05:51] joakino: not a big deal do you want me to merge as is? [15:05:53] jdlrobson: yea, but i set up npm test to execute `grunt jenkins` so that we can add or remove specific tasks that we want / don't want to run on jenkins [15:06:21] jdlrobson: it is fine, if we want we can rename that later, the important thing is that npm test exists [15:06:43] jdlrobson: link to your patch? [15:07:27] (03CR) 10Jdlrobson: [C: 032] Set up npm tasks linked to grunt (for Jenkins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174697 (owner: 10Jhernandez) [15:07:50] joakino: https://gerrit.wikimedia.org/r/#/c/174696/ [15:08:18] (03Merged) 10jenkins-bot: Set up npm tasks linked to grunt (for Jenkins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174697 (owner: 10Jhernandez) [15:09:20] jdlrobson: wow wtf is going on with jenkins https://gerrit.wikimedia.org/r/#/c/173858/ [15:09:25] did we already break it? xd [15:12:13] uhhoohh [15:12:35] (03CR) 10Jhernandez: [C: 04-1] "http://localhost:8080/wiki/Special:Uploads?debug=true" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson) [15:12:43] (03PS5) 10Jdlrobson: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 [15:13:28] (03CR) 10Krinkle: "Please don't do this. This pattern has never been used anywhere else and I recommend against inventing this pattern for MobileFrontend." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174697 (owner: 10Jhernandez) [15:17:26] (03CR) 10Jhernandez: "Ok, ill change it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174697 (owner: 10Jhernandez) [15:23:25] (03PS5) 10Jdlrobson: Hygiene: Remove M.getLeadSection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 [15:24:41] (03PS1) 10Jhernandez: Remove jenkins specific tasks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174702 [15:24:56] jdlrobson Krinkle ^ [15:28:53] (03CR) 10Dbrant: [C: 032] "Good for now, but I'm starting to feel uncomfortable putting these checks in all kinds of places, without understanding the root cause of " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174636 (owner: 10BearND) [15:28:59] (03CR) 10Jdlrobson: [C: 032] "Krinkle" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174702 (owner: 10Jhernandez) [15:29:36] (03Merged) 10jenkins-bot: Remove jenkins specific tasks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174702 (owner: 10Jhernandez) [15:30:34] jdlrobson: joakino: so I am now looking at the CI config for MobileFrontend https://gerrit.wikimedia.org/r/#/c/174696/ [15:31:48] (03PS5) 10Dbrant: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 [15:32:03] hashar: is that what we need? [15:32:18] yeah that is it :] [15:32:29] so to deploy the job in Jenkins one can: [15:32:31] $ jenkins-jobs --conf jenkins_jobs.ini update config/jjb/ mwext-MobileFrontend-npm [15:32:33] doing so [15:32:43] hashar: joakino: should probably no longer use unittests-template since jslint shouldn't be run anymore. [15:32:52] at the bottom of https://gerrit.wikimedia.org/r/#/c/174696/1 , there are some Jenkins jobs results which shows the impact on the Jenkins and Zuul config [15:33:12] except for check pipeline [15:33:25] https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/1676/console shows the XML generated for mwext-MobileFrontend-npm [15:35:30] hashar: 👍 [15:35:59] joakino: jdlrobson it is running out of the master branch at https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/1/consoleFull [15:37:19] hashar: i'm seeing a crash screen [15:37:29] Error: 503, Service Unavailable [15:37:32] (03PS3) 10Jdlrobson: Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 [15:37:43] joakino: that's because live refresh doesn't work properly due to a bug in Jenkins upstream [15:37:48] just refresh once its finishes [15:37:50] its still running [15:38:08] 3Wikipedia App / 3Android App: Android app: Wikidata description is displayed in incorrect language if you click "read in other languages" - 10https://bugzilla.wikimedia.org/73598 (10Dan Garry) 5PATC>3RESO/FIX [15:38:39] Krinkle hashar tests failed, localhost wasn't up? [15:39:52] not sure why it runs on labs slaves [15:40:25] (03CR) 10Krinkle: "The way the qunit task is set up here requires a full MediaWiki install. Since this is not (and should not be) done as part of the 'npm in" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174697 (owner: 10Jhernandez) [15:40:33] joakino: ^ [15:40:44] mediawiki core also runs that way [15:40:49] That's a good example to folow [15:41:13] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use topic-title-list for CategoryOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174638 (owner: 10Florianschmidtwelzow) [15:41:27] hashar: it being on a labs slave is not the reason it failed. [15:41:40] I didn't merge my change to migrate to labs slaves yet, though that should be fine. [15:41:55] (03Merged) 10jenkins-bot: Hygiene: Use topic-title-list for CategoryOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174638 (owner: 10Florianschmidtwelzow) [15:42:41] (03PS11) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 [15:42:53] Krinkle: so you want me to make grunt test not run tests? would you mind if i make npm test do grunt check, or something similar, i dont want our developers to run grunt test and not have the tests run locally [15:43:12] (03PS3) 10Jdlrobson: Hygiene: Extend load talk module only if needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 (owner: 10Florianschmidtwelzow) [15:43:31] I guess qunit should not be run by default when invoking npm test [15:43:41] since on Jenkins that is a different kind of job [15:43:53] (the -qunit and -qunit-mobile ones, which takes care of setting up mediawiki) [15:44:13] Krinkle: do we have any doc regarding Karma? [15:44:25] hashar: i'll change it to not run qunit, but i don't want to call it grunt test since it is not running tests, i'd rather rename that task to grunt check [15:44:49] or grunt unittests [15:44:58] or whatever name you want :] [15:45:00] joakino: 'check' has a different meaning (safe test without executing files from the git repo, e.g. for untrusted users submitting patches, since Grunt is local, it is not safe and should not be referred to with 'check' to avoid confusino) [15:45:42] hashar: No, and I don't want there to be. Grunt is a standalone project. We're not using it in any fancy way other than our labs environment. Karma has excellent documentation of its own. [15:45:57] Krinkle: any suggestions? or the only solution is make grunt test not run tests [15:46:18] (03CR) 10Jdlrobson: [C: 032] Hygiene: Extend load talk module only if needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 (owner: 10Florianschmidtwelzow) [15:46:23] However you can't use it for mediawiki installs, only static js projects (e.g. jquery, oojs, visualeditor) - I already have a bug open to migrate mwext-qunit job to Karma and are actively working on that. Requires multiple weeks of dev, rather complex. [15:46:32] hashar: ^ [15:47:32] joakino: There are plenty of tests it can execute. But by convention, you shouldn't include tasks inside a default wrapper ('default', or 'test') that don't work out of the box. [15:48:02] (03Merged) 10jenkins-bot: Hygiene: Extend load talk module only if needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174423 (owner: 10Florianschmidtwelzow) [15:48:04] Krinkle: well extensions developers would more than welcome a single page on wiki explaining how to add grunt checks and a basic karma test. [15:48:45] (03CR) 10Jdlrobson: "As long as we keep the existing style in stable I'm not too bothered how this is styled in anonymous editing mode. The important thing is " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [15:49:05] hashar: There are 100s of examples out there. We don't introduce extension devs how to write a jquery plugin or how to call jquery methods either. [15:49:08] Or how to set up nodejs/npm. [15:49:25] we should [15:49:38] If there are known issues i'm happy to resolve, but I get the impression people aren't trying first. And assuming everythign ahs to be mediawiki specific. [15:49:42] that would be a good way to scale the grunt work to the other developers [15:49:56] hashar: +1 [15:49:58] I guess most devs don't know where to start from [15:50:06] hashar: another +1 [15:50:17] this is why people are not using Grunt. [15:50:24] so a page teasing them on how to easily add a bunch of grunt plugins would make them curious and cause them to add moaaare tests to their repo [15:51:06] hashar: Making a documentation page will not help. I've experienced this before. The situation is some people (mobile in this case) not knowing to use Grunt at first (a few weeks ago). Now that they know it, there can be a page about it. But it owuldn've helped as they'd have to know about the page in the first place. The next person won't see that page until they have enoguh information to have alr [15:51:06] eady found the documetnation online. [15:51:07] elsewhere [15:51:24] well announce it ? [15:51:29] hashar: I'll document an example, but I refuse to explain how to set it up. That ought to be self-explanatory. [15:51:43] ROFL [15:51:51] (03PS1) 10Jhernandez: Do not run mediawiki dependen tasks on grun test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174705 [15:51:56] It's bound to get overly specific, and incomplete and it'll end up as yet another page on emdaiwiki with 100 sections for every single edge case that people couldn' figure out [15:52:42] and everyone adding to it thinks they're sharing their info for the next person but nobody's actually using it. [15:52:53] True story. seen it dozens of times over the past 2 years, not happening again. [15:53:10] yeah I know that feeling [15:53:19] I suffer from the doc on wiki myself that grows out of control [15:53:28] I love writing documention, you know that :). I'll see how this goes and document it myself. [15:53:31] I have been considering having the doc hosted in a git repo next to the config :D [15:54:02] (03PS2) 10Jdlrobson: Do not run mediawiki dependent tasks on grunt test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174705 (owner: 10Jhernandez) [15:54:09] (03PS3) 10Jdlrobson: Tools: Do not run mediawiki dependen tasks on grun test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174705 (owner: 10Jhernandez) [15:54:11] jdlrobson: btw, it seems some of the rules in jscs for mobile are redundant as they're already part of the wikimedia preset. [15:54:16] (03CR) 10Brion VIBBER: [C: 032] Search shows new results without blanking results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174490 (owner: 10Mhurd) [15:54:21] (03PS4) 10Jdlrobson: Tools: Do not run mediawiki dependent tasks on grunt test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174705 (owner: 10Jhernandez) [15:54:27] validateIndent, onevar etc. [15:54:29] (03CR) 10Jdlrobson: [C: 032] Tools: Do not run mediawiki dependent tasks on grunt test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174705 (owner: 10Jhernandez) [15:54:37] Krinkle: it could be something very simple, you don't need to enter in the details. Just list what could be added in packages.json , whatever simple file to execute a karma test, and list the couple command npm install && npm test [15:54:57] Krinkle: I think that will be sufficient. Then you can announce the page to devs to start copy pasting to their repos. [15:55:14] (03Merged) 10jenkins-bot: Tools: Do not run mediawiki dependent tasks on grunt test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174705 (owner: 10Jhernandez) [15:55:22] Krinkle: something like https://doc.wikimedia.org/mw-tools-scap/ :d [15:55:30] hashar: ok it should succeed now ^ no qunit [15:55:55] (03CR) 10Brion VIBBER: [C: 032] Limit recent search items to 100. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174623 (owner: 10Mhurd) [15:55:57] joakino: so on build #1 https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/1/ [15:56:08] joakino: there is already all the job parameters to run the job out of the tip of the master branch [15:56:25] ok [15:56:27] joakino: so you can log in Jenkins using your labs account, and you will see on the left of https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/1/ a link saying: [Rebuild] [15:56:44] clicking on it will rerun the job using the same parameter (i.e. repo is on gerrit, branch& commit are 'master') [15:56:51] and see what happens [15:57:23] running it now [15:57:34] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/2/console [15:58:03] * hashar awards joakino a "Testing badge 101" [15:58:41] hashar: 👍 works fine now [15:59:51] hashar: so next steps? [16:00:43] success! [16:00:55] so now that we now the job is running [16:00:57] we can +2 it [16:01:44] Krinkle: mind lifting your -1 on MobileFrontend integration/config change ? https://gerrit.wikimedia.org/r/#/c/174696/ [16:01:49] the test is passing now [16:01:57] hashar: that's not what my -1 was for [16:02:10] ahh [16:17:49] https://gerrit.wikimedia.org/r/#/c/174696/2 <- Is this it Krinkle? [16:19:43] joakino: Probably not, I think you've now disabled jobs you want to keep [16:20:08] joakino: Look at the definition of extension-unittests and essentially substitute it in place, and remove jslint from the test and gate pipelines [16:20:19] you'll want to keep the (php)lint jobs [16:20:24] (03Abandoned) 10Florianschmidtwelzow: Seperate list style from page-list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [16:20:52] i'm going to try [16:23:37] joakino: Krinkle: I replied on the change https://gerrit.wikimedia.org/r/#/c/174696/2/zuul/layout.yaml [16:23:47] I think we should use PS1 even if that means duplicating jshint run [16:23:51] joakino: Normally hashar or me would do that part, so don't worty. But cool that you're doing it! [16:23:53] and use another change to refactor [16:24:08] hashar: Why? we never do that. It's not much work. [16:24:15] It's the right thing to do atomically. [16:24:19] I would prefer we do not expand templates [16:24:22] but split them instead [16:24:28] I would prefer we not use templates. [16:24:46] -npm and -composer :) [16:24:48] that is convenient to change the 500+ extensions we have [16:24:48] nothing else [16:24:50] (one day) [16:24:53] but yeah eventually -npm -composer [16:25:00] i agree [16:25:14] right now tempaltes are for status quo and not where we're headed. [16:25:15] I did some -composer work yesterday taking the cdb repo as a play area [16:25:17] Maybe we need new templates [16:25:32] but for now let's keep it accurate. Especially because jslint has a different version of jshint [16:25:39] so it'll be messy and not just redundant [16:25:53] well I would let their change (PS1) land in [16:26:08] so mobile can forget about it [16:26:11] well, I've expressed my concern. [16:26:15] and I am willing to clean up the mess / create a new template [16:26:30] I think it is too much work for new comers to the zuul templates :] [16:26:46] use a template if there is nothing special. Mobile is now joining the league of modern repos, so it shoudln't use the tempalte anymore [16:26:50] it's only like 3 lines of code [16:27:13] ahhhh [16:27:29] yeah maybe it is fine just copy pasting the phplint / unittest :D [16:27:36] don't run two versins of jshint on the same repo. We've never done that, we shouldn't start doing that now. [16:39:58] (03PS9) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) [16:44:03] (03PS5) 10Jdlrobson: Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 [16:58:36] (03PS1) 10Florianschmidtwelzow: Again: Context modules can't be arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174716 [16:59:02] jdlrobson, phuedx: ^^ [16:59:14] (03CR) 10jenkins-bot: [V: 04-1] Again: Context modules can't be arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174716 (owner: 10Florianschmidtwelzow) [16:59:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] Again: Context modules can't be arrays (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174716 (owner: 10Florianschmidtwelzow) [17:01:32] (03PS2) 10Florianschmidtwelzow: Again: Context modules can't be arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174716 [18:07:50] (03PS4) 10Bmansurov: Use local logo file for measuring its dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [18:14:13] (03CR) 10Bmansurov: [C: 032] Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 (owner: 10Jdlrobson) [18:14:50] (03Merged) 10jenkins-bot: Hygiene: Satisfy require-line-break-after-variable-assignment jscs condition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174401 (owner: 10Jdlrobson) [18:26:23] (03PS1) 10Kaldari: Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174749 (https://bugzilla.wikimedia.org/73633) [18:28:53] 3MobileFrontend / 3beta: WikiGrok broken in beta - JS error - 10https://bugzilla.wikimedia.org/73633 (10Ryan Kaldari) 5PATC>3RESO/FIX [18:40:40] MaxSem: hello, can you CR https://gerrit.wikimedia.org/r/#/c/174308/ when you get a chance? thanks [18:42:02] bmansurov, so it just replaces pages returned with redirect targets? [18:42:20] MaxSem: yes [18:42:30] that doesn't sound right [18:42:55] MaxSem: you mean, it shouldn't? [18:43:48] MaxSem, I agree with you, it should only remove the redirect from results if the target is also there. [18:46:12] in prefix search, you're returning a list of pages with titles matching a query. because a redirect taget might be something not matching the search term, it's gonna be helluva misleading [18:47:22] MaxSem: that makes sense, i'll update my patch [18:47:45] also, I'm not sure why this bug was raised against mobile when desktop has the same problem [18:48:19] I think this should be an enhancement request for CirrusSearch [18:48:53] MaxSem: I agree, that was Jon's point too [18:50:02] (03CR) 10MaxSem: [C: 04-1] "[10:42] bmansurov, so it just replaces pages returned with redirect targets?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov) [18:51:07] 3MobileFrontend / 3beta: Search results should show redirect targets rather than redirects - 10https://bugzilla.wikimedia.org/73532#c3 (10Bahodir Mansurov) It looks like this is the default behavior for Desktop too. This bug should be fixed at the API level (CirrusSearch). [18:51:35] (03Abandoned) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov) [18:53:56] MaxSem: Is there anything special we need to do to deploy the WikiGrok DB store to production? i.e. get Sean to manually run the SQL file? It's been over a year since I've created a new table on prod so I have no idea how that's being done now. [18:54:16] eh, it's already live:P [18:54:22] ah, good :) [18:54:40] once you have Sean's permissions, you can create the tables yourself [18:55:05] s/permissions/consent/ [18:56:31] MaxSem: So you just ran the SQL on the master DBs for the wikis where WikiGrok is installed (or for all of them)? [18:56:44] yep [18:57:11] mwscript sql.php --wiki=... file.sql to be precise [19:03:41] (03CR) 10Bmansurov: [C: 032] Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 (owner: 10Jdlrobson) [19:03:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 (owner: 10Jdlrobson) [19:06:55] (03PS4) 10Bmansurov: Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 (owner: 10Jdlrobson) [19:07:20] (03CR) 10Bmansurov: [C: 032] Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 (owner: 10Jdlrobson) [19:08:01] (03Merged) 10jenkins-bot: Hygiene: Apply requirePaddingNewLinesInObjects rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174637 (owner: 10Jdlrobson) [19:11:10] (03CR) 10Bmansurov: "I don't see any changes related to reactivating mobile.infobox" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174749 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [19:12:01] (03CR) 10Bmansurov: [C: 032] jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [19:12:13] (03CR) 10jenkins-bot: [V: 04-1] jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [19:14:11] MaxSem: What's the bug for adding continuation to prefixsearch? [19:15:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=73522 [19:15:11] Cheers! [19:15:31] (03CR) 10Bmansurov: [C: 032] Update jsbeautifyrc to respect new rule I wrote [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174406 (owner: 10Jdlrobson) [19:17:33] Maryana: What do you think about adding a spike about supporting WikiGrok on tablet? [19:17:42] sure :) [19:17:49] cool, I'll write it up [19:17:51] tha'd be more of a design spike, but yeah, we can do it [19:18:35] (03CR) 10Bmansurov: [C: 032] Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 (owner: 10Jdlrobson) [19:19:22] (03CR) 10Bmansurov: [C: 032] Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 (owner: 10Jdlrobson) [19:20:02] (03Merged) 10jenkins-bot: Alpha: Add wikidatainfoboxes to cities [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169757 (owner: 10Jdlrobson) [19:20:05] (03PS1) 10Dbrant: Add event logging for suggested pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174772 [19:20:07] (03Merged) 10jenkins-bot: Wikidata Infoboxes on countries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169770 (owner: 10Jdlrobson) [19:21:04] (03PS5) 10Bmansurov: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [19:24:44] (03CR) 10Bmansurov: [C: 032] Revert "Focus editor textarea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174635 (owner: 10Jdlrobson) [19:25:24] (03Merged) 10jenkins-bot: Revert "Focus editor textarea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174635 (owner: 10Jdlrobson) [19:27:22] Maryana: Done. Feel free to add anything I forgot: https://trello.com/c/VYQxLlqP/12-spike-investigate-supporting-wikigrok-on-tablet [19:27:46] beautimus [19:28:14] kaldari|2: also, don't know if you've tested yet, but it seems to be working fine now on beta labs [19:28:17] and i don't see redlinks [19:28:30] so the mysterious case of the disappearing wikigrok appears to be resolved [19:29:50] (03CR) 10Bmansurov: [C: 04-1] Infobox: movies (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson) [19:29:52] 3Wikipedia App / 3Android App: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dan Garry) [19:30:19] (03CR) 10Jdlrobson: [C: 032] Again: Context modules can't be arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174716 (owner: 10Florianschmidtwelzow) [19:31:13] (03Merged) 10jenkins-bot: Again: Context modules can't be arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174716 (owner: 10Florianschmidtwelzow) [19:31:14] hey MaxSem you around? [19:31:52] 3Wikipedia App / 3General/Unknown: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dan Garry) [19:34:03] (03CR) 10Bmansurov: [C: 032] Species infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170434 (owner: 10Jdlrobson) [19:34:43] (03Merged) 10jenkins-bot: Species infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170434 (owner: 10Jdlrobson) [19:35:25] jdlrobson, yep [19:35:54] hey MaxSem so I need to wrap up https://trello.com/c/0kKBcmoD/2-improve-login-and-account-creation-experience-for-lower-end-device-users [19:36:10] kaldari|2: can you CR this please? https://gerrit.wikimedia.org/r/#/c/174405/ [19:36:34] so essentially what needs to happen as a short term measure is we show the different version in alpha and for opera mini devices [19:36:36] yes [19:36:48] thanks [19:37:10] opera isn't the only non-js device around [19:37:17] MaxSem: i know hence the short term measure bit [19:37:25] right now it's the main one we care about [19:37:31] as the traffic is the most significant [19:37:50] instead of ua sniffing, why not apply a generic solution? [19:38:06] MaxSem: because the generic solution is to rewrite the login page everywhere [19:38:21] (03CR) 10Kaldari: [C: 04-1] "This needs an explanation in the commit summary as to what this actually changes. Otherwise, I'm not even sure how to test it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [19:38:23] and in true agile we should do the least most possible work with the most gain [19:38:25] mmm, add labels but hide them for js devices? [19:38:39] MaxSem: not that easy. Will need a complete rewrite of styles for our existing page [19:38:46] o rly? [19:38:56] not worth the effort we want to stop special casing login page not adapt the existing one [19:39:21] also having some real data showing that account creations go up make a stronger case to just getting this done [19:40:04] also, wtf do we want opera users to create accounts for if all our contributory features require js? [19:41:34] (03CR) 10Bmansurov: [C: 032] "Jdlrobson, you need to reinstall grunt-qunit-istanbul." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174037 (owner: 10Bmansurov) [19:41:50] bmansurov: i have it doesnt work for me [19:41:56] it's a timeout issue [19:42:00] like the qunit issue [19:42:08] jdlrobson: I just checked it and it works [19:42:15] (03Merged) 10jenkins-bot: Use Istanbul for code coverage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174037 (owner: 10Bmansurov) [19:42:17] (03CR) 10Jdlrobson: "This operation takes too long for me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174037 (owner: 10Bmansurov) [19:42:29] bmansurov: i have same issue with it as the other patch that joakin posted [19:42:36] they only work for you and him [19:42:53] for kaldari, rmoen and myself the tests were taking too long [19:42:57] jdlrobson: how did you reinstall grunt-qunit-istanbul [19:43:01] sigh [19:43:05] now i can't run qunit [19:43:23] jdlrobson: you can do grunt qunit:all which will skip coverage [19:43:33] bmansurov: this is the thing it doesn't work for me [19:43:36] with that patch [19:44:52] brion: check this out: git log --pretty=format:'%Cblue%h %Cgreen%<(11)%cd%Cred%<(12)%cr %Creset%s' --date=short -10 [19:45:07] (03CR) 10Jdlrobson: "Can you retest on latest patchset?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson) [19:45:27] anyway MaxSem so you do have any issues with this as short term measure? [19:45:53] only other browser we care about is IE9/8 http://caniuse.com/#feat=input-placeholder [19:46:18] (03CR) 10Robmoen: "This actually fixed the bug for me in IOS8 -> iPhone 5 simulator. I will recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 (https://bugzilla.wikimedia.org/73046) (owner: 10Robmoen) [19:46:26] and I guess Android 2 but we could expand support [19:48:50] mhurd: https://gist.github.com/brion/d1a5b08dbb07861eeb90 [19:48:59] (03Abandoned) 10Robmoen: Only run SkinMinervaDefaultModules hook once in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173109 (owner: 10Robmoen) [19:49:56] jdlrobson: talking to max about login/account creation on opera [19:50:23] we don't provide anything after a user logs in for those people – why don't we just hide those options for now until we can think of a better experience for them? [19:50:54] Maryana: that would mean hiding login and account creation for all non-js devices [19:51:08] yes [19:51:10] the experience is only bad if the browser doesn't have placeholder support which is only opera mini and android 2 [19:51:22] but what features do we have for no js users? [19:51:24] just watchlist [19:51:29] your call [19:51:38] i just don't think it's worth it [19:51:38] watchlist is the only one yeh [19:51:46] if we had editing for those people, i'd feel differently [19:52:01] k let's do that then. You'll be able to see how many less accounts get created [19:52:13] (in Eventlogging) [19:52:22] well, i doubt it'll change anything – it's essentially impossible for those folks to create accounts right now [19:55:22] Maryana: you want me to add card? [19:55:25] update rather [19:56:38] (03CR) 10Jdlrobson: [C: 04-2] "This isn't recognised so should not be merged" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174406 (owner: 10Jdlrobson) [19:57:47] (03PS6) 10Jdlrobson: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 [19:57:57] (03PS7) 10Jdlrobson: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 [19:58:20] jdlrobson: can you run qunit after merging this patch: https://gerrit.wikimedia.org/r/#/c/174716/ [19:58:58] FlorianSW i can't run qunit beause of https://gerrit.wikimedia.org/r/174037 which bmansurov merged [19:59:33] * FlorianSW is testing with this patch [20:01:16] jdlrobson, FlorianSW how can I help you guys run qunit again? Since it's working on my end, maybe it can be easily fixed with some tweaks on your end too. [20:01:53] bmansurov, jdlrobson: i run qunit now (downloading nodejs modules new, because i cloned the repo new) [20:02:01] so actually i can run `make qunit` just not `grunt qunit:all` [20:02:07] jdlrobson bmansurov: make tests runs without problem :/ [20:02:22] so it's not as big a deal bmansurov just means i can't run the code coverage/qunit tools in grunt [20:02:23] FlorianSW: with grunt? [20:03:12] bmansurov: testing... [20:03:29] 3MobileFrontend / 3Hygiene: Issues using qunit with grunt - 10https://bugzilla.wikimedia.org/73670 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon master x ~/git/vagrant/mediawiki/extensions/MobileFrontend $ grunt qunit:all Running "qunit:all" (qunit) task Testing http://127.0.0.1:8080/w/index.php/Special:... [20:03:32] ^ created this bug [20:03:37] jdlrobson: can you remove the node_modules/grunt-qunit-istanbul folder and the do npm install, that fixed the problem for me] [20:03:37] >> 473 assertions passed (2367ms) Done, without errors. [20:03:43] bmansurov, jdlrobson: ^ [20:03:59] FlorianSW: so reinstalling node modules fixed the problem? [20:04:11] bmansurov: i never had problems (i never tested before) [20:04:18] FlorianSW: ok [20:04:25] so, a clean, new install of istanbul ;) [20:05:13] 3MobileFrontend / 3Hygiene: Issues using qunit with grunt - 10https://bugzilla.wikimedia.org/73670#c1 (10Bahodir Mansurov) I would remove the node_modules folder and reinstall all packages. [20:05:22] 3MobileFrontend / 3Hygiene: Issues using qunit with grunt - 10https://bugzilla.wikimedia.org/73670#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/EKGd7gE9 [20:07:24] bmansurov: the url for testing is fixed in Gruntfile.js. What if a developer using another url? If there is no way to specify the url locally i suggest to add Gruntfile.js to .gitignore. if it need changes, you can force to commit it, but it doesn't interrupt most commits :) [20:09:44] FlorianSW: can we just change the Gruntfile.js locally and not exclude it from git? [20:10:21] milimetric: can you take a lookat https://gerrit.wikimedia.org/r/#/c/174615/ ? [20:10:32] bmansurov: You can, but if i made changes at many files i want to use git add --all and don't want to run git checkout -- :P [20:10:44] ;) [20:11:04] bmansurov: and this will cause, that i commit my environment url -> not good :) [20:11:37] bmansurov: so, i think, the better way is, that we make Gruntfile.js updates more complicated instead of doing it for all other commits (at least for me, i think :P) [20:12:16] (03CR) 10Jdlrobson: [C: 032] jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [20:13:03] (03Merged) 10jenkins-bot: jscs: Enforce requirePaddingNewLinesInObjects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174405 (owner: 10Jdlrobson) [20:15:23] 3MobileFrontend / 3Hygiene: Issues using qunit with grunt - 10https://bugzilla.wikimedia.org/73670#c3 (10Jon) I did all this. It still does the above. [20:16:04] (03CR) 10Kaldari: [C: 032] Hygiene: Remove M.getLeadSection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 (owner: 10Jdlrobson) [20:16:43] (03Merged) 10jenkins-bot: Hygiene: Remove M.getLeadSection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173338 (owner: 10Jdlrobson) [20:17:58] jdlrobson: The extension-unittests template provides various jobs (check: jslint/lint, test: jslint/lint/phpunit, gate: gate, jslint/lint/phpunit). Those are substituted, and then jslint removed and npm added. [20:18:17] jdlrobson: https://gerrit.wikimedia.org/r/#/c/174696/9/zuul/layout.yaml [20:18:53] You still want (php)lint and (phpunit)textextensions [20:19:33] Krinkle: i [20:19:37] i am so confused [20:19:47] You were making it more complicated then it was [20:19:55] Krinkle: i just copied you :P [20:20:01] I copied the template contents down to the MobileFrontend section, removed jslint and added npm [20:20:13] Nope. [20:20:52] Krinkle: k makes sense [20:20:58] any issues with merging this as is? [20:21:52] Maryana: hi, any suggestions on what card I should work on next? [20:21:57] mmm apparently jenkins doesn't like [20:22:12] bmansurov: https://trello.com/c/LRWPL9Fl/92-3-add-jscs-jsdoc-extension would be useful [20:22:19] i'd like to get this tools stuff wrapped up [20:22:28] even if you don't like this work it needs to get done :) [20:23:02] jdlrobson: i don't mind working on it, I thought you and joakin were some secret plan to work on all tools cards ;)) [20:23:14] had* [20:23:32] no we just want it all done and for everyone to understand how it works :) [20:23:36] jdlrobson / bmansurov: your changes appear to have worked, I checked the columns line up now: http://mobile-reportcard.wmflabs.org/graphs/ui-daily [20:23:43] milimetric: bmansurov \o. [20:23:48] cool [20:24:01] we're still unsure about the data - more info on that when we have it [20:24:04] i still don't get that spike though! :) [20:24:19] table of contents link is clicked surprisingly often [20:24:30] and languages despite being at the bottom Maryana [20:25:00] jdlrobson: maybe TOC click was triggered? [20:25:10] milimetric: wait.. Home is always NaN in that graph? [20:25:41] jdlrobson: it's not none towards the end of november [20:25:44] jdlrobson: hashar added a unit test (?) that says every project must have php-composer-validate. I have no idea why that is but I'll add it. Evnethough it makes no sense. [20:25:44] no, it starts showing up toward the end [20:25:56] mm that's real strange [20:26:03] i'm not sure why that is [20:26:31] Krinkle: jdlrobson yeah all mediawiki repos are required to have the php-composer-validate job, though it is only triggered when a the /composer.json file is changed [20:27:21] milimetric: lots of weirdness in that graph. I don't trust the data [20:27:21] related bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=73444 "Add php-composer-validate jobs for all extensions and skins with a composer.json file" [20:27:36] hashar: But why assert that via a unit test? Seems rather disproportionate. It being in the template for projects without any handling is fine, but when I override the template, no need to be forced to include irrelevant jobs [20:27:39] history link has always been more popular than profile link but this graph shows opposite.. [20:28:03] jdlrobson: when sean gets back to us about the db and indices / replication problems there, I will look further [20:28:06] seems rather meta meta [20:28:09] until then my hands are kinda tied [20:28:13] thanks milimetric i appreciate it [20:28:31] ok i need to sleep. anything anyone needs before i go? [20:28:38] Krinkle: the job is relevant. Whenever the repo switch to composer, we want to validate the composer file. Meanwhile, the job is just not triggered at all [20:29:26] Maryana: Lunch time! Want to grab it together? [20:29:53] Maryana: Since we have our meeting in 1 minute. :-) [20:31:00] (03CR) 10Jdlrobson: [C: 04-1] Use local logo file for measuring its dimensions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [20:31:27] laters [20:31:44] (03CR) 10Bmansurov: Use local logo file for measuring its dimensions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [20:35:24] 3MobileFrontend / 3beta: Search results should show redirect targets rather than redirects - 10https://bugzilla.wikimedia.org/73532#c5 (10Bahodir Mansurov) https://bugzilla.wikimedia.org/show_bug.cgi?id=73673 [20:41:26] 3Wikipedia App / 3General/Unknown: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Nik Everett) [20:42:42] (03CR) 10Kaldari: [C: 04-1] Use local logo file for measuring its dimensions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [20:58:46] (03PS5) 10Bmansurov: Use local logo file for measuring copyright logo dimensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [21:00:40] (03Abandoned) 10Florianschmidtwelzow: Don't try to set cursor on hidden elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174384 (https://bugzilla.wikimedia.org/73585) (owner: 10Florianschmidtwelzow) [21:26:15] (03CR) 10Hashar: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson) [21:26:43] for what it is worth, npm is now being run by Jenkins on the MobileFrontend repo [21:31:33] * hashar commented on trello [21:33:20] (03CR) 10Hashar: "Was to test the new 'npm' Jenkins job which runs ... npm test !" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson) [21:34:43] (03PS1) 10Mhurd: Enabled "fastest" optimization setting. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174816 [21:35:27] brion: ^ [21:36:04] (03CR) 10Brion VIBBER: [C: 032] Enabled "fastest" optimization setting. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174816 (owner: 10Mhurd) [21:37:42] (03PS1) 10Kaldari: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174818 [21:42:29] (03Abandoned) 10Kaldari: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174818 (owner: 10Kaldari) [21:44:30] (03PS1) 10Bmansurov: Add jscs jsdoc extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174819 [21:45:46] (03PS1) 10Kaldari: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 [21:48:53] (03PS1) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 [21:49:01] (03PS1) 10Kaldari: Changing MAX_OPEN_PATCHES from 5 to 7 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174822 [21:49:06] dbrant: ^ [21:49:40] bearND: nice! will check out [21:49:43] dbrant: still needs layout fixes, but maybe you have an idea [21:50:09] dbrant: no sure what FrameLayout magic is happening at the end of the page [21:53:31] dbrant: probably don't need as much padding on bottom of main page [21:56:23] dbrant: We should have one name for this feature in the code. Do you want to call it ReadMore or SuggestedPages? [21:57:06] bearND: yeah... Reaed More, I guess. [21:57:10] *read [21:58:20] dbrant: agreed. I'd be happy to make another refactoring patch to bring the names in line once we've got the functionality ironed out [21:58:40] bearND: yep, sounds good [22:00:27] bearND: you know, eventually we should make a single reusable component that represents a "list of page titles". You instantiate it as a View, then feed it a list of PageTitles, and reuse it in Search, Disambiguation, Read More, etc... [22:01:08] dbrant: yes [22:07:52] bmansurov: I have some thoughts on the footer patch... [22:08:11] kaldari|2: what are they? [22:10:29] bmansurov: since it's kind of silly to recalculate the dimensions of the logo for every page view (considering it will very rarely change), what do you think about just having $wgMFCustomLogos['copyright-width'] and wgMFCustomLogos['copyright-height'] which are set if present, and otherwise the logo is just loaded as is. [22:11:02] kaldari|2: that sounds good to me [22:11:05] (03PS1) 10Mhurd: Update AFNetworking to 2.5 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174826 [22:12:30] brion: ^ seems to work... [22:15:56] (03PS1) 10Jforrester: Provide VisualEditor regardless of device size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174828 [22:17:53] (03CR) 10Brion VIBBER: [C: 032] Update AFNetworking to 2.5 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174826 (owner: 10Mhurd) [22:20:31] (03PS6) 10Bmansurov: Add config options for correctly displaying the copyright logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [22:26:01] dbrant, bearND: We should probably add some Javadoc to WikidataCache, given that there are now four overloaded methods called get. [22:26:18] dbrant, bearND: I caused the mess, so I'll try to fix it. ^_^ [22:26:27] :) [22:28:24] 3Wikipedia App / 3General/Unknown: Tracking: API issues blocking Wikipedia app development - 10https://bugzilla.wikimedia.org/73616 (10Dan Garry) [22:28:40] What. [22:28:51] There's one person who's saved 2,992 pages in the last 20 days. [22:30:05] Deskana, that's a lot of tapping [22:30:38] or was that mhurd? [22:38:52] (03CR) 10Dbrant: "layout suggestions." (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 (owner: 10BearND) [22:39:23] dbrant, bearND: When are we cutting a beta with lead image stuff? [22:41:06] Deskana: I would kind of prefer to tie up the loose ends in styling, e.g. the actionbar icons, infobox edit pencil, etc... [22:41:34] Right. So given that this needs to sit in beta for a bit before it goes live, we're okay with this not going live in production for around a month? [22:43:19] Deskana: that's probably sensible. It will also give us time for some thorough testing of the new sdk that we're using. [22:43:27] dbrant: Okie doke. [22:43:28] bearND: ^ [22:45:58] Maryana, wrt wikidata infoboxes: https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A4%D0%BE%D1%80%D1%83%D0%BC/%D0%92%D0%BD%D0%B8%D0%BC%D0%B0%D0%BD%D0%B8%D1%8E_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%BE%D0%B2#.D0.97.D0.BD.D0.B0.D0.BA.D0.B8_.D0.B2.D0.BE.D0.BF.D1.80.D0.BE.D1.81.D0.B0_.D0.B2_.D0.BA.D0.B0.D1.80.D1.82.D0.BE.D1.87.D0.BA.D0.B0.D1.85_.D1.84.D0.B8.D0.BB.D1.8C.D0.BC.D0.BE.D0.B2 :P [22:46:06] blaargh [22:46:24] dbrant: Deskana: i was thinking maybe we could just fix the action bar icons, then cut a beta [22:46:31] dbrant|bbl: ^ [22:46:42] epic lulz. coming to a wiki near you [22:47:03] dbrant|bbl: Deskana: we could probably get there tomorrow or Monday [22:48:45] Whoa whoa, slow down a sec. [22:48:52] That is work that's in our next sprint. [22:49:03] Let's not go pulling stuff in to our current sprint to try to get stuff out of the door [22:49:19] We can commit to pushing a beta on Friday 5th December, at the end of next sprint, and if it happens sooner then great [22:50:32] I think you're right; let's do the polishing we planned, then push to beta [22:50:43] agreed [23:00:21] (03PS5) 10Jdlrobson: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 [23:01:04] (03PS4) 10Jdlrobson: jscs: Add require-line-break-after-variable-assignment config option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 [23:02:17] (03CR) 10jenkins-bot: [V: 04-1] jscs: Add require-line-break-after-variable-assignment config option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 (owner: 10Jdlrobson) [23:02:42] MaxSem: https://gerrit.wikimedia.org/r/#/c/174749/ [23:03:08] (03CR) 10MaxSem: [C: 032] Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174749 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [23:04:55] (03CR) 10jenkins-bot: [V: 04-1] Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174749 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [23:05:51] Deskana: you around? [23:06:00] mhurd: Username atm [23:06:03] Erm, wtf [23:06:05] MEETING atm [23:06:08] hehe [23:06:09] Not quite sure what happened there [23:06:12] Deskana: not worry [23:08:45] (03CR) 10MaxSem: [V: 032] Fixing dependency for mobile.wikigrok.dialog [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174749 (https://bugzilla.wikimedia.org/73633) (owner: 10Kaldari) [23:12:32] vbamba: you around? [23:18:17] (03PS1) 10Kaldari: Only set userEditCount if the user is logged in [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174847 [23:18:39] MaxSem: https://gerrit.wikimedia.org/r/#/c/174847/ [23:19:40] bearND: hey! would you have time for a quick hangout? [23:19:50] mhurd: sure [23:20:11] mhurd: batcave? [23:20:14] (03CR) 10MaxSem: [C: 032] Only set userEditCount if the user is logged in [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174847 (owner: 10Kaldari) [23:20:31] (03Merged) 10jenkins-bot: Only set userEditCount if the user is logged in [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174847 (owner: 10Kaldari) [23:25:15] DarTar: I found the problem and fixed it. Will prepare a deployment to push it out. [23:32:02] (03PS1) 10Kaldari: Only set userEditCount if the user is logged in [extensions/WikiGrok] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174849 [23:33:24] kaldari|2: fabulous [23:33:30] (03PS1) 10Kaldari: Only set userEditCount if the user is logged in [extensions/WikiGrok] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174850 [23:34:38] (03PS1) 10Bmansurov: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) [23:34:46] (03CR) 10MaxSem: [C: 032] Only set userEditCount if the user is logged in [extensions/WikiGrok] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174849 (owner: 10Kaldari) [23:35:02] (03CR) 10MaxSem: [C: 032] Only set userEditCount if the user is logged in [extensions/WikiGrok] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174850 (owner: 10Kaldari) [23:35:09] (03Merged) 10jenkins-bot: Only set userEditCount if the user is logged in [extensions/WikiGrok] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174849 (owner: 10Kaldari) [23:35:23] (03Merged) 10jenkins-bot: Only set userEditCount if the user is logged in [extensions/WikiGrok] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174850 (owner: 10Kaldari) [23:37:09] (03PS7) 10Bmansurov: Add config options for correctly displaying the copyright logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [23:40:19] (03CR) 10Kaldari: [C: 04-1] "See comments on patchset 6" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [23:40:33] (03CR) 10Kaldari: Add config options for correctly displaying the copyright logo (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [23:41:29] bmansurov: new patch looks good. Just a couple minor issues with the comment part. [23:42:01] thanks kaldari|2 for your comments, i don't know why i'm making so many mistakes today [23:42:46] bmansurov: No worries :) [23:43:23] kaldari|2: when you say 'extra space here', do you want me to add one blank line after the example? [23:43:35] bmansurov: No, there's a space before the tab for some reason [23:43:41] ok [23:44:13] bmansurov: It's functionally invisible, but I noticed it anyway :) [23:44:21] hawk eyes! [23:45:41] (03PS8) 10Bmansurov: Add config options for correctly displaying the copyright logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 [23:48:48] (03CR) 10Kaldari: [C: 032] Add config options for correctly displaying the copyright logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov) [23:54:15] (03PS1) 10Mhurd: Clear search results if none were returned by the query. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174857 [23:54:18] brion: ^ [23:55:25] (03CR) 10Brion VIBBER: [C: 032] Clear search results if none were returned by the query. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174857 (owner: 10Mhurd) [23:56:46] DarTar: Anon WikiGrok should be fixed now. Can you confirm? [23:57:59] (03Merged) 10jenkins-bot: Add config options for correctly displaying the copyright logo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174588 (owner: 10Bmansurov)