[00:01:58] <DarTar>	  kaldari|2 will test in a second
[00:05:35] <grrrit-wm>	 (03PS1) 10Robmoen: Upstream icons to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 
[00:06:38] <grrrit-wm>	 (03PS2) 10Robmoen: Upstream icons to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 
[00:07:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Upstream icons to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 (owner: 10Robmoen)
[00:10:41] <grrrit-wm>	 (03PS2) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[00:15:42] <grrrit-wm>	 (03CR) 10Robmoen: [C: 04-1] "This is totally broken. ;/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 (owner: 10Robmoen)
[00:29:54] <grrrit-wm>	 (03CR) 10Robmoen: "Ok this is fixed now with latest Icon change in mantle extension" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 (owner: 10Robmoen)
[00:33:23] <grrrit-wm>	 (03Restored) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov)
[00:34:00] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Changing MAX_OPEN_PATCHES from 5 to 7 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174822 (owner: 10Kaldari)
[00:35:46] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "-2ing since we need to discuss this first (But this is all good prep work so it's not really work wasted - we can resurrect it later)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 (owner: 10Robmoen)
[00:36:09] <grrrit-wm>	 (03PS5) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) 
[00:36:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov)
[00:37:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Changing MAX_OPEN_PATCHES from 5 to 7 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174822 (owner: 10Kaldari)
[00:37:43] <grrrit-wm>	 (03PS6) 10Bmansurov: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) 
[00:38:57] <kaldari>	 MaxSem: Started discussion on Wikidata: https://www.wikidata.org/wiki/Wikidata:Project_chat#Setting_more_specific_claims_-_add_or_replace.3F
[00:39:39] <MaxSem>	 thanks:)
[00:42:42] <Maryana>	 kaldari: so it looks like there are a few action items from DarTar – how should we track them? bug? trello card?
[00:43:22] <kaldari>	 Maryana: We'll need to do both (since we don't have Bugello) :(
[00:43:44] <kaldari>	 Maryana: Anon responses are fixed on prod at least
[00:43:47] <Maryana>	 and no phabugello?
[00:43:53] <Maryana>	 oh, sweet
[00:43:54] <kaldari>	 not yet :(
[00:44:55] <kaldari>	 Maryana: The 2 bugs that are left are minor: Version B doesn't log success screen; ResposeAPI logs 'version A' while EventAPI logs 'mobile A'
[00:45:03] <Maryana>	 yep
[00:45:10] <Maryana>	 we can just put those in next sprint
[00:45:15] <kaldari>	 sure
[00:45:41] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "make phpunit doesn't actually work for me anymore inside vagrant. Any ideas what I'm doing wrong?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[00:45:52] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[00:45:56] <Maryana>	 kaldari actually, not logging the success screen should probably be fixed sooner than later
[00:46:01] <Maryana>	 if possible
[00:46:10] <kaldari>	 Maryana: sure, hopefully an easy fix
[00:46:16] <Maryana>	 though i guess no matter what, it still won't get deployed till next week
[00:46:26] <Maryana>	 just gonna put that in the current sprint
[00:47:39] <Maryana>	 there ya go kaldari – https://trello.com/c/36Cgvx1Q/110-bug-wikigrok-b-not-logging-confirmation-screen
[00:47:49] <Maryana>	 the other thing can go in next sprint
[00:48:38] <kaldari>	 jdlrobson: Does make phpunit fail both with and without our config for you?
[00:52:34] <Maryana>	 kaldari: are you satisfied with your QAing at this point? should i go ahead & sign off on that spike?
[00:52:53] <Maryana>	 it looks like y'all have managed to shake out the big issues
[00:56:28] <jdlrobson>	 rmoen: did you get my message on trello?
[00:56:36] <jdlrobson>	 kaldari: yeh it does
[00:56:38] <jdlrobson>	 both cases
[00:56:39] <rmoen>	 jdlrobson: i haven't read it yet
[00:56:54] <jdlrobson>	 rmoen: basically don't work on that we didn't get round to discussing that yet in the dev meeting
[00:56:54] <grrrit-wm>	 (03PS1) 10Kaldari: Log widget-impression-success event in WikiGrok version B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174883 
[00:57:11] <rmoen>	 jdlrobson: ok what should i work on then ? 
[00:57:14] <jdlrobson>	 i guess i messed up by not letting you know whilst sick :/
[00:57:22] <jdlrobson>	 rmoen: i moved a bunch of cards over that are ready
[00:57:34] <rmoen>	 just now ? 
[00:57:47] <jdlrobson>	 rmoen: yup
[00:57:58] <jdlrobson>	 Maryana: do we want this btw https://trello.com/c/zZdOT9Jf/113-make-phabello ?
[00:58:05] <Maryana>	 yaaas
[00:58:27] <jdlrobson>	 i don't know how we want to estimate this
[00:58:33] <Maryana>	 tofu!
[00:58:34] <Maryana>	 :)
[00:58:43] <rmoen>	 jdlrobson: ok so there will be stuff to do tomorrow then :)  Either way, I was looking for something fun do to and it looked liked it had been fleshed out in  the meetings so I grabbed it
[00:58:50] <jdlrobson>	 we burned through developer backlog  quicker then i expected :/
[00:59:08] <jdlrobson>	 rmoen: it's all useful background work so don't feel bad :)
[00:59:11] <rmoen>	 I'm pretty much done with the Overlay as well
[00:59:13] <jdlrobson>	 i'm sure that patch is gonna come in handy
[00:59:21] <rmoen>	 I dont feel bad i feel good about it
[00:59:54] <jdlrobson>	 ok but yeh Echo currently doesn't depend on Mantle and only reason we'd move stuff to Mantle is if we wanted to share it with another extension
[01:00:29] <jdlrobson>	 on plus side the tools stuff got fixed quicker than i expected :)
[01:00:47] <rmoen>	 jdlrobson: Yeah, i understand.  One of items on the card though is "Make echo depend on mantle"
[01:01:28] <rmoen>	 That was the route I was taking.  Seemed like a good way to get my hands dirty with three extensions :)
[01:02:08] <rmoen>	 Happy to work on other things, just loooked like the queue was completely empty this morning.  Maybe I should check with you first before picking things out of the developer backlog.  I think I will do that next time
[01:03:25] <jdlrobson>	 i messed up
[01:03:38] <jdlrobson>	 when i finished yesterday i misjudged what we had left
[01:03:42] <jdlrobson>	 :/
[01:03:53] <jdlrobson>	 but as i said on plus side we have a bunch of good stuff done
[01:04:30] <Maryana>	 rmoen: there were a couple patches you worked on that need revisiting, too
[01:04:42] <Maryana>	 there's still something mysterious/haunted about editing/scrolling
[01:04:49] <jdlrobson>	 Maryana: we are enabling VE on mobile now?
[01:04:57] <Maryana>	 not my choice
[01:05:17] <Maryana>	 james wrote a patch for it at the behest of erik
[01:05:20] <jdlrobson>	 Maryana: does it look okay? It looked really bad last time i checked - did they optimise it?
[01:05:42] <Maryana>	 james said they've tested it and it looks okay
[01:06:01] <Maryana>	 i haven't looked at it yet because it's not yet live on beta labs
[01:06:19] <jdlrobson>	 errrggg
[01:06:36] <Maryana>	 if it looks really bad, i'm going to complain. i'm mostly worried about the switcher icon
[01:06:43] <Maryana>	 i don't know where it's going to fit in the toolbar on a tiny screen
[01:06:48] <jdlrobson>	 yeh it doesn't
[01:06:56] <jdlrobson>	 i'll get you a screenshot
[01:07:00] <Maryana>	 and it'll be so much more prominent on a small screen
[01:07:04] <Maryana>	 are you seeing it live now?
[01:07:58] <rmoen>	 Maryana: True, I've investigated those bugs and still haven't been able to reproduce with the patches.  I did some trello grooming on those cards, just need to update the patches.  I will test again though as I suspect I am missing something.
[01:08:15] <rmoen>	 Also, I wanted to secure some work to do as like I said the queue was nearly empty
[01:08:51] <Maryana>	 rmoen: ready for dev? i'm seeing lots of stuff in there :)
[01:08:59] <rmoen>	 Maryana: yes as of 5pm
[01:09:04] <Maryana>	 oh, haha
[01:09:37] <Maryana>	 wanna make phabello? :)
[01:09:47] <AaronM>	 Not sure if I messed up the config/install or what but does anyone know why my mobile version of the site looks like the printable page instead of having the nice formatting like en.m.wikinews.org? See here http://bwwiki.fgthou.se/index.php?title=Grid_Controller&useformat=mobile
[01:10:12] <AaronM>	 Also it's installed correction at least from the version page standpoint. http://bwwiki.fgthou.se/index.php?title=Special:Version
[01:10:16] <AaronM>	 correctly*
[01:11:03] <AaronM>	 No errors/warnings in my nginx logs either
[01:13:25] <jdlrobson>	 Maryana: http://imgur.com/CDnP8xD,ir22wZ9
[01:13:36] <Maryana>	 yikes
[01:13:37] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "VE currently doesn't load for me (Exception thrown by ext.visualEditor.mwlink ) ypeError: Expecting a function in instanceof check, but go" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174828 (owner: 10Jforrester)
[01:13:49] <Maryana>	 jdlrobson: what does it look like on the wikitext edit screen?
[01:13:57] <jdlrobson>	 Maryana: screenshot is in that link
[01:14:03] <jdlrobson>	 it hides the title of the page being edited
[01:14:11] <jdlrobson>	 it definitely needs design love
[01:14:13] <Maryana>	 o i c
[01:17:01] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Add event logging for suggested pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174772 (owner: 10Dbrant)
[01:17:20] <grrrit-wm>	 (03PS1) 10Mhurd: Added psnamespace parameter to prefix query. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174888 
[01:17:39] <jdlrobson>	 rmoen: also welcome back :)
[01:18:00] <AaronM>	 Vanilla MobileFrontent does look like this http://upload.wikimedia.org/wikipedia/commons/thumb/b/b0/Mobile_site_redesign.jpg/220px-Mobile_site_redesign.jpg correct? Or is there a theme I need to use ?
[01:18:52] <grrrit-wm>	 (03CR) 10Maryana: [C: 04-1] ""Given it's disabled except for users who opt-in, this will be" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174828 (owner: 10Jforrester)
[01:18:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add event logging for suggested pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174772 (owner: 10Dbrant)
[01:21:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add jscs jsdoc extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174819 (owner: 10Bmansurov)
[01:22:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add jscs jsdoc extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174819 (owner: 10Bmansurov)
[01:24:35] <jdlrobson>	 AaronM: that's a super old screenshot :)
[01:24:40] <jdlrobson>	 but roughly looks like that
[01:25:54] <AaronM>	 Hrm, not sure what I've done wrong then for my wiki to look nothing like that on mobile.
[01:26:06] <MaxSem>	 it roughly looks like https://en.m.wikipedia.org/wiki/Main_Page
[01:26:22] <jdlrobson>	 AaronM: mmm are you still seeing the desktop skin?
[01:26:37] <jdlrobson>	 MaxSem: i need to grab breakfast can you help AaronM out?
[01:26:38] <AaronM>	 Nah, http://bwwiki.fgthou.se/index.php?title=Grid_Controller&useformat=mobile It looks like the print preview version
[01:26:46] <MaxSem>	 breakfast:P
[01:27:02] <MaxSem>	 bon appetit  jdlrobson! :P
[01:27:13] <AaronM>	 ^ enjoy 
[01:27:36] <grrrit-wm>	 (03PS6) 10BearND: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[01:27:55] <grrrit-wm>	 (03PS3) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[01:27:57] <grrrit-wm>	 (03CR) 10Jforrester: "Feel free to fix the MF regressions, then. :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174828 (owner: 10Jforrester)
[01:28:44] <MaxSem>	 AaronM, note how it screams bloody murder in http://bwwiki.fgthou.se/load.php?debug=false&lang=en&modules=mediawiki.ui.button%7Cmobile.pagelist.styles%7Cskins.minerva.chrome.styles%7Cskins.minerva.content.styles%7Cskins.minerva.drawers.styles%7Cskins.minerva.tablet.styles&only=styles&skin=minerva&target=mobile&*
[01:29:16] <AaronM>	 hrm, nothings showing up in the nginx logs
[01:29:27] <MaxSem>	 you need php logs: https://www.mediawiki.org/wiki/Manual:How_to_debug
[01:30:16] <MaxSem>	 does your MobileFrontend version matches MediaWiki?
[01:30:30] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] "It's weird we missed this earlier." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174883 (owner: 10Kaldari)
[01:30:47] <kaldari>	 Maryana: Can you comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=73637
[01:32:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Log widget-impression-success event in WikiGrok version B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174883 (owner: 10Kaldari)
[01:32:01] <AaronM>	 My version is cloned from the latest git
[01:32:14] <AaronM>	 So newer than the mediawikis
[01:32:16] <AaronM>	 I presume
[01:32:31] <grrrit-wm>	 (03PS1) 10MaxSem: Random page API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174889 
[01:32:52] <MaxSem>	 yep, we don't support that
[01:33:08] <AaronM>	 M'kay lemme try a stable version then
[01:33:38] <MaxSem>	 just use the REL1_23 branch
[01:34:41] <AaronM>	 http://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdist_name=MobileFrontend&extdist_version=REL1_23&extdist_submit=Continue This correct?
[01:34:54] <MaxSem>	 looks like
[01:35:16] <Maryana>	 kaldari: sure
[01:35:24] <grrrit-wm>	 (03PS2) 10MaxSem: Random page API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174889 
[01:36:04] <Maryana>	 oh no, i can't!
[01:36:06] <Maryana>	 i have to phabricate!
[01:36:18] <Maryana>	 kaldari: do you happen to know where that now lives in phabricator?
[01:36:18] <AaronM>	 Ah, guess there is something wonky with the latest git version. Thanks MaxSem that fixed it :)
[01:37:28] <MaxSem>	 nothing wonky with it, you just can't use it with nothing but master MW
[01:37:35] <AaronM>	 ahh
[01:37:38] <MaxSem>	 which reminds me..
[01:38:45] <grrrit-wm>	 (03PS1) 10MaxSem: Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174891 
[01:38:52] <MaxSem>	 ^_^
[01:38:53] <AaronM>	 hah
[01:39:45] <kaldari>	 Maryana: hmm: "Phabricator is not accessible during the migration period."
[01:39:54] <kaldari>	 which apparently lasts until Monday
[01:39:56] <MaxSem>	 lulz
[01:40:05] <MaxSem>	 they locked us outtta everything
[01:40:32] <Maryana>	 oh nooo
[01:40:44] <Maryana>	 how do i bug???
[01:40:53] <grrrit-wm>	 (03PS1) 10MaxSem: Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/174893 
[01:40:56] <MaxSem>	 well you don't
[01:41:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/174893 (owner: 10MaxSem)
[01:54:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Can you also update make command and remove the ruby code?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov)
[02:32:44] <mhurd>	 Deskana: https://github.com/montehurd/gitshorts
[02:33:02] <Deskana>	 Haha
[02:33:15] <Deskana>	 If you're from the South...
[02:33:18] <Deskana>	 "I'm so warm, pa!"
[02:33:23] <Deskana>	 "GIT SHORTS"
[02:33:33] <Deskana>	 That was funnier in my head.
[02:37:32] <Krenair>	 Yeah.
[04:00:36] <grrrit-wm>	 (03PS4) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[04:55:09] <grrrit-wm>	 (03PS6) 10Jdlrobson: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 
[05:01:24] <grrrit-wm>	 (03PS1) 10Deskana: Add Javadoc comments to WikidataCache. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174906 
[05:04:18] <grrrit-wm>	 (03PS2) 10Deskana: Add Javadoc comments to WikidataCache. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174906 
[05:09:31] <jdlrobson>	 prtksxna: you around?
[05:09:36] <prtksxna>	 jdlrobson: o
[05:09:40] <prtksxna>	 jdlrobson: o/
[05:09:42] <jdlrobson>	 yey! :)
[05:10:56] <grrrit-wm>	 (03PS5) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[05:11:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 (owner: 10BearND)
[05:11:28] <jdlrobson>	 prtksxna: was my email any help?
[05:11:48] <prtksxna>	 jdlrobson: Yup, was!
[05:11:55] <jdlrobson>	 cool
[05:12:08] <prtksxna>	 jdlrobson: I am still bringing elements up to spec though
[05:12:30] <prtksxna>	 jdlrobson: Can you please respond to my question on https://gerrit.wikimedia.org/r/#/c/171452/
[05:12:37] <grrrit-wm>	 (03PS1) 10Jdlrobson: Documentation for special page initialisation functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174907 
[05:12:40] <jdlrobson>	 sure taking a look
[05:13:43] <prtksxna>	 Thanks
[05:14:14] <prtksxna>	 jdlrobson: I'll have a patch for <select> by today
[05:14:23] <jdlrobson>	 \o.
[05:15:09] <jdlrobson>	 prtksxna: updated patch
[05:16:19] <prtksxna>	 jdlrobson: Cool
[05:17:45] <prtksxna>	 jdlrobson: If you find time next week take a look at the patched I have to mw.ui. Don't +2 anything though…
[05:17:56] <jdlrobson>	 ok can you mail me with the details?
[05:18:00] <jdlrobson>	 it will get lost in gerrit otherwise
[05:18:05] <prtksxna>	 A lot of teams are involved and I don't want bad blood again :-p
[05:18:14] <prtksxna>	 jdlrobson: Sure, I'll reply to our thread
[05:18:34] <grrrit-wm>	 (03PS6) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[05:18:36] <jdlrobson>	 we're all converging slowly
[05:19:24] <prtksxna>	 jdlrobson: True. Still not going +2 is better :)
[05:19:55] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174891 (owner: 10MaxSem)
[05:20:14] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "jenkins is sad" [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/174893 (owner: 10MaxSem)
[05:22:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174891 (owner: 10MaxSem)
[05:28:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow)
[05:34:56] <grrrit-wm>	 (03PS6) 10Jdlrobson: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 
[05:37:06] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Needs rebasing and probably a rewrite now we have the code coverage stuff" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez)
[05:37:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov)
[05:39:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Show redirect targets in search results. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174308 (https://bugzilla.wikimedia.org/73532) (owner: 10Bmansurov)
[05:42:11] <grrrit-wm>	 (03PS3) 10Jdlrobson: WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 
[05:43:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson)
[05:50:38] <grrrit-wm>	 (03PS4) 10Jdlrobson: WIP: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (https://bugzilla.wikimedia.org/73115) 
[06:56:57] <grrrit-wm>	 (03PS1) 10Mhurd: Changed fetcher "userData" to "fetchedData". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174915 
[07:03:04] <grrrit-wm>	 (03PS1) 10Deskana: Improve log messages for EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174916 
[07:09:41] <grrrit-wm>	 (03PS10) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) 
[07:10:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow)
[09:02:54] <grrrit-wm>	 (03PS1) 10Mhurd: Auto switch from prefix to in-article search if no prefix results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174927 
[10:00:59] <jdlrobson>	 hey joakino
[10:01:07] <joakino>	 sup jdlrobson
[10:01:13] <jdlrobson>	 joakino: had a freaking amazing day
[10:01:18] <jdlrobson>	 found the best remote working shot ever
[10:01:22] <jdlrobson>	 *spot
[10:01:39] <jdlrobson>	 although i need a nap before i finish up my working day around standup :)
[10:02:00] <joakino>	 yeah haha
[10:02:02] <joakino>	 what spot is it
[10:02:53] <jdlrobson>	 http://instagram.com/p/vqF9Dis2EQ/?modal=true < joakino
[10:02:55] <jdlrobson>	 not bad hey?
[10:03:13] <jdlrobson>	 spent a good 3 hrs in this spot
[10:03:17] <grrrit-wm>	 (03PS5) 10Jdlrobson: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (https://bugzilla.wikimedia.org/73115) 
[10:03:35] <joakino>	 woooow
[10:03:39] <joakino>	 so awesome
[10:03:50] <jdlrobson>	 i've had so much amazing food too
[10:05:13] <jdlrobson>	 joakino: did you see grunts up and running :)
[10:05:27] <joakino>	 yeah! 😀 great
[10:06:32] <grrrit-wm>	 (03PS11) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) 
[10:07:05] <joakino>	 jdlrobson: what is 					config: ".jscs-jsdocrc"  for? why do we have 2 of them and gruntfile uses the other one?
[10:08:20] <jdlrobson>	 joakino: it's the work that baha did for jsdocs
[10:08:27] <jdlrobson>	 we need to make it pass before we can switch over to it
[10:08:50] <grrrit-wm>	 (03PS3) 10Jhernandez: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 
[10:09:03] <jdlrobson>	 joakino: https://gerrit.wikimedia.org/r/#/c/174819/
[10:09:16] <jdlrobson>	 joakino: so i can't work out why grunt qunit is so slow for me
[10:09:27] <jdlrobson>	 but a timeout should suffice for time being
[10:09:41] <jdlrobson>	 if you're cool with that and we can get rob moen or kaldari to double check it works for them i say we merge
[10:10:05] <joakino>	 jdlrobson: yeah of course
[10:10:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "@kaldari @rmoen can you check if this works for you and +2 if it does. It's slow but it works for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez)
[10:10:43] <jdlrobson>	 our velocity is ridiculous this iteration
[10:10:44] <joakino>	 jdlrobson: maybe we shouldn't merge it if it doesn't work properly until we know why
[10:10:47] <jdlrobson>	 i can't keep up
[10:10:50] <joakino>	 ridicously fast?
[10:10:56] <jdlrobson>	 joakino: yeh lol
[10:10:58] <joakino>	 hah
[10:11:02] <jdlrobson>	 i thought we had enough stories to last us till end of next
[10:11:18] <joakino>	 yeah we need more focus areas, or products, or something
[10:11:20] <jdlrobson>	 i'm getting slightly worried that even with a dev backlog we won't keep up haha :)
[10:11:46] <jdlrobson>	 https://gerrit.wikimedia.org/r/173858 should work for you now btw
[10:18:23] <sjoerddebruin>	 Wow, nice mail on the mailing list.
[10:24:29] <joakino>	 sjoerddebruin: shocking content 💪
[10:24:49] <sjoerddebruin>	 Yes, "Sent from Samsung Mobile" is very scary to me.
[10:25:16] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] "Exception when trying to "Contribute an image", after selecting the image, or also when loading http://localhost:8080/wiki/Special:Uploads" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson)
[10:37:11] <matanya>	 bearND: the lastest alpha just crashed on me, sent the report
[13:38:38] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Add Javadoc comments to WikidataCache. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174906 (owner: 10Deskana)
[14:00:28] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "4+ log messages per event is a bit much." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174916 (owner: 10Deskana)
[14:14:50] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "Otherwise works for me :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez)
[15:05:15] <grrrit-wm>	 (03CR) 10Jhernandez: Tools: Run make qunit (and qunitdebug) with grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez)
[15:27:14] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Tools: Run make qunit (and qunitdebug) with grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez)
[15:37:50] <joakino>	 grrr vagrant clusterfuck
[15:45:46] <dbrant>	 bearND: I think I know the root cause of the issues with the bottom handler. Working on an update for the first patch.
[15:46:01] <dbrant>	 bearND: Hopefully it won't be too annoying to rebase yours onto.
[15:50:46] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Make mdot landing page faster [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt)
[15:51:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make mdot landing page faster [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/170483 (owner: 10Dr0ptp4kt)
[15:51:44] <grrrit-wm>	 (03PS7) 10Jdlrobson: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 
[15:55:01] <bearND>	 dbrant: you can also do it as a new patch
[15:55:56] <dbrant>	 bearND: you mean, on top of yours?
[15:56:06] <bearND>	 dbrant: yes
[15:58:18] <dbrant>	 bearND: sure, sounds fair!
[16:09:33] <grrrit-wm>	 (03PS1) 10Jdlrobson: Nearby link should be local url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174960 
[16:15:30] <grrrit-wm>	 (03PS1) 10Jdlrobson: Fix tappable area of upload button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174963 
[16:15:43] <grrrit-wm>	 (03PS2) 10Jdlrobson: Nearby link should be local url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174960 
[16:16:01] <grrrit-wm>	 (03PS2) 10Jdlrobson: Fix tappable area of upload button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174963 
[16:29:54] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Nearby link should be local url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174960 (owner: 10Jdlrobson)
[16:32:32] <joakino>	 jdlrobson: unlimited labels on trello! http://blog.trello.com/introducing-unlimited-labels/
[16:43:23] <jdlrobson>	 joakino: yeh i just saw the husky :D
[16:43:27] <jdlrobson>	 developer backlog just got easier :)
[16:45:03] <joakino>	 oh yeah
[16:45:33] <jdlrobson>	 joakino: so i'm guessing we can publish docs now
[16:45:41] <jdlrobson>	 whilst our minds are in jenkins/zuul land
[16:45:56] <joakino>	 how would that work?
[16:47:12] <jdlrobson>	 joakino: it would be the build step
[16:47:22] <jdlrobson>	 we'd need to reverse engineer ve again :)
[16:47:37] <jdlrobson>	 https://doc.wikimedia.org/VisualEditor/master/
[16:49:05] <jdlrobson>	 hey kristenlans!
[16:50:13] <kristenlans>	 yo!
[16:50:47] <kristenlans>	 how goes your fantastic journey so far jdlrobson 
[16:52:55] <grrrit-wm>	 (03PS1) 10BearND: Avoid IndexOutOfBoundsException in when loading page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174976 
[16:53:05] <dbrant>	 Thanks, Часопис, for my free wikipedia :P
[16:53:21] <jdlrobson>	 joakino: have you used esformatter ?
[16:54:23] <bearND>	 dbrant: ?
[16:54:32] <joakino>	 jdlrobson: i played with it when evaluating jsbeautify. much more flexible thatn jsbeautify but on useless stuff
[16:54:45] <dbrant>	 bearND: my WP Zero provider seems to have changed...
[16:54:48] <joakino>	 jdlrobson: i think
[16:54:54] <joakino>	 i may be wrong
[16:54:57] <jdlrobson>	 joakino: Krinkle says that the VE team tried jsbeautify  and it didn't work well for them
[16:55:10] <jdlrobson>	 he reckons esformatter would be a better interim until jscs has this capability
[16:55:22] <bearND>	 dbrant: ah, i see. I had it turned off for me a couple of weeks ago
[16:55:27] <jdlrobson>	 Krinkle: i assume you won't mind if i forward your message to mailing ist?
[16:55:36] <Krinkle>	 Go ahead
[16:58:02] <joakino>	 jdlrobson: it may be worth trying to get a configuration file for esformatter, but it is extra specific, i think more that our style guide
[16:58:20] <jdlrobson>	 joakino: i'll have an explore before i finish today
[16:58:55] <jdlrobson>	 Krinkle: do you have any idea why we don't define a convention for arrays? e.g. [1,2,3] or [ 1, 2, 3 ] foo[1] or foo[ 1 ]
[17:02:59] <grrrit-wm>	 (03PS2) 10BearND: Avoid IndexOutOfBoundsException in when loading page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174976 (https://bugzilla.wikimedia.org/73404) 
[17:03:36] <Krinkle>	 jdlrobson: for arrays we already do
[17:03:37] <Krinkle>	 spaces
[17:03:51] <jdlrobson>	 but not for accessors? Any reason why?
[17:03:57] <Krinkle>	 It's a separate rule, it's not added yet.
[17:04:44] <Krinkle>	 Add it upstream
[17:05:00] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Refactor special uploads code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 
[17:05:09] <Krinkle>	 Or rather, I've already started doing that
[17:05:12] <Krinkle>	 They keep adding new rules
[17:05:26] <jdlrobson>	 Krinkle: but any idea what the motivation of the rule is?
[17:05:27] <Krinkle>	 I'll have to go through them all and see which ones match our coding style
[17:05:37] <Krinkle>	 jdlrobson: You mean why spaces inside brackets?
[17:05:40] <jdlrobson>	 Krinkle: i began a patch to cover it but i'm keen to understand why
[17:05:51] <jdlrobson>	 it would be easier to just have a consistent style across all square brackets
[17:05:54] <jdlrobson>	 Krinkle: yup
[17:06:01] <jdlrobson>	 why not spaces in accessors
[17:06:14] <Krinkle>	 jdlrobson: Well, first of all, consistency. Even if you don't buy the rational reason, it doens't really matter, and should just all be the same, and we settled on spaces.
[17:06:16] <jdlrobson>	 e.g. why [ 1, 2, 3 ] but not foo[1]
[17:06:26] <jdlrobson>	 *but foo[1]
[17:06:30] <jdlrobson>	 why not foo [ 1 ]
[17:06:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor special uploads code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson)
[17:07:02] <Krinkle>	 jdlrobson: As for why they would be differnet, they're not. But, it shouldn't matter. They're different things. Just because they are both brackets is not a good reason for using the same spacing. They differnet concept and may justify different readability contexts
[17:07:16] <Krinkle>	 jdlrobson: Nobody says we won't have spaces in accessor
[17:07:22] <Krinkle>	 jdlrobson: the convention doesnt' specify it right now
[17:07:33] <Krinkle>	 I'd say lets specify to use spaces.
[17:07:40] <jdlrobson>	 Krinkle: sounds good to me
[17:07:56] <Krinkle>	 Though I think it makes sense to stay spaceless for integer indexes if that's possbile
[17:08:21] <jdlrobson>	 i am happy to write a rule for that as well > https://github.com/jdlrobson/node-jscs/tree/upstream/disallow-spaces-in-member-expression3 was a start for the opposite
[17:08:42] <jdlrobson>	 https://github.com/jdlrobson/node-jscs/commit/22984912c22397d6fe1685bd5a462e2fdc764bed rather
[17:08:53] <Krinkle>	 We don't need a rule to write it a certain way. Write how you like, the rules will follow. It's just a test. Not the code itself :)
[17:10:51] <Krinkle>	 jdlrobson: I left out in the e-mail that I think it'd be in everybody's best interest to use a jscs plugin in your editor. fixing it up afterwards is suboptimal
[17:10:59] <Krinkle>	 and not very discoverable or user friendly.
[17:11:17] <Krinkle>	 It'll help you write code that way to begin with by guiding you where a certain style is preferred.
[17:11:25] <Krinkle>	 Like a spell checker :)
[17:11:51] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Refactor special uploads code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 
[17:12:28] <jdlrobson>	 Krinkle: yeh that works for me but not for everyone i guess. There are some weird things/bugs in jsbeautify that i do not like but i like the idea of never having to bikeshed over conventions again
[17:12:37] <jdlrobson>	 if jscs doesn't complain it's not a convention imo
[17:13:45] <jdlrobson>	 joakino: are you able to run the phpunit tests btw?
[17:19:35] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow)
[17:21:49] <joakino>	 jdlrobson:  No tests executed!
[17:28:25] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Nearby link should be local url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174960 (owner: 10Jdlrobson)
[17:29:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Nearby link should be local url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174960 (owner: 10Jdlrobson)
[17:32:15] <grrrit-wm>	 (03CR) 10Jhernandez: "I'm getting this when trying to run the tests inside vagrant" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[17:42:39] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] "Visiting http://localhost:8080/wiki/Special:Nearby?debug=true" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson)
[17:50:45] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Everything seems to work now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson)
[17:54:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop lead photo uploader button code loading when disabled. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173858 (owner: 10Jdlrobson)
[17:54:34] <grrrit-wm>	 (03PS2) 10Bmansurov: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) 
[17:54:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov)
[17:55:39] <grrrit-wm>	 (03PS3) 10Bmansurov: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) 
[18:18:20] <jdlrobson>	 oh btw i'm apparently giving a talk about wikipedia tomorrow night Maryana Kaldari
[18:18:33] <jdlrobson>	 anything specifically you would like to get volunteers for?
[18:18:42] <jdlrobson>	 any calls to action from taiwan peoples?
[18:19:55] <Maryana>	 cool! i'd mostly be curious how they use wp
[18:20:07] <Maryana>	 i.e. are they 100% mobile? do they use the app?
[18:20:10] <Maryana>	 that kinda thing
[18:20:22] <bmansurov>	 joakino: you there?
[18:21:14] <joakino>	 bmansurov: tell me
[18:22:00] <bmansurov>	 joakino: about my emails, I sent you the username and password
[18:22:07] <bmansurov>	 you need to add those to the scripts/my.cnf.research file
[18:22:25] <bmansurov>	 joakino: detailed in the README.md file of the limn-mobile-data repo
[18:22:45] <joakino>	 oki, i've left the last part until i have the access
[18:22:46] <joakino>	 oki! thx bmansurov
[18:22:59] <bmansurov>	 joakino: cool
[18:23:09] <joakino>	 ✌️
[18:24:25] <jdlrobson>	 Maryana: sure apprently i can turn it into whatever i want :)
[18:27:42] <jdlrobson>	 chrismcmahon: okay sounds good
[18:28:36] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[18:28:45] <jdlrobson>	 ^ kaldari joakino try that
[18:28:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Hygiene: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[18:29:20] <jdlrobson>	 also bmansurov, rmoen can you let me know if you don't think you guys have enough work?
[18:29:24] <jdlrobson>	 i want to head off soon
[18:29:36] <bmansurov>	 jdlrobson: 1 sec
[18:29:50] <joakino>	 jdlrobson: 5 min. i wil
[18:29:52] <rmoen>	 jdlrobson: ok
[18:29:53] <joakino>	 * will
[18:30:18] <bmansurov>	 jdlrobson: i think i have enough work to do. 
[18:30:27] <jdlrobson>	 phew ;-)
[18:30:41] <jdlrobson>	 rmoen: i was wondering - do you want to pick up my infobox editing patch?
[18:30:44] <bmansurov>	 😈
[18:31:03] <jdlrobson>	 rmoen: it's going to need to use search suggestions and I was hoping to use OOUI for those
[18:31:06] <jdlrobson>	 but got a little blocked
[18:31:58] <rmoen>	 jdlrobson: hmm i can take a look, you're talking about using ooui for the suggestion results ?
[18:32:16] <rmoen>	 like the link inspector ? 
[18:32:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Warning: Warning: Warning type no_doc is deprecated, use nodoc(class,public) instead" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov)
[18:32:54] <grrrit-wm>	 (03CR) 10Jdlrobson: Run jsduck through grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov)
[18:33:17] <jdlrobson>	 rmoen: exactly
[18:33:32] <jdlrobson>	 rmoen: if you look at wikidata what actually gets saved is the property so you need to show search results that are human readable
[18:34:34] <rmoen>	 jdlrobson: i'll start looking at that patch in just a minute and let you know if I have a any questions 
[18:34:38] <grrrit-wm>	 (03CR) 10Bmansurov: Run jsduck through grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov)
[18:34:44] <bmansurov>	 jdlrobson: ^
[18:34:52] <jdlrobson>	 rmoen: cool - only if you are interested but i have a feeling you will eb :)
[18:34:59] <rmoen>	 :)
[18:35:20] <jdlrobson>	 bmansurov: run `make clean` then run `make jsduck`
[18:35:23] <jdlrobson>	 you don't get errors?
[18:35:29] <bmansurov>	 1 sec
[18:36:12] <bmansurov>	 jdlrobson: i see
[18:37:00] <rmoen>	 jdlrobson: Infobox: movies ? 
[18:37:12] <jdlrobson>	 rmoen: it's the patch after that
[18:37:13] <rmoen>	 patch
[18:37:18] <jdlrobson>	 infobox movies shoud be ready to go
[18:37:30] <rmoen>	 ok
[18:37:38] <grrrit-wm>	 (03PS4) 10Robmoen: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[18:37:41] <grrrit-wm>	 (03PS12) 10Jdlrobson: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 
[18:37:44] <rmoen>	 rebased
[18:38:13] <rmoen>	 jdlrobson: Looking at both patches
[18:38:21] <jdlrobson>	 rmoen: there is obviously the bugs as well that need fixing but if you wanted something meaty and lower priority that would be a fun one to work on
[18:38:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[18:40:50] <grrrit-wm>	 (03PS7) 10Robmoen: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson)
[18:42:23] <grrrit-wm>	 (03PS2) 10Mhurd: Auto switch from prefix to in-article search if no prefix results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174927 
[18:44:24] <mhurd>	 brion: thoughts on this: https://gerrit.wikimedia.org/r/#/c/174915/ ?
[18:44:41] <mhurd>	 brion: *renamed a var*
[18:45:06] <grrrit-wm>	 (03PS5) 10Robmoen: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[18:45:57] <brion>	 mhurd: makes sense
[18:46:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[18:46:41] <mhurd>	 brion: cool :) i stacked the auto-switch patch on top of it
[18:46:54] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Changed fetcher "userData" to "fetchedData". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174915 (owner: 10Mhurd)
[18:46:59] <mhurd>	 woohoo!
[18:47:49] <mhurd>	 brion: brad pointed out this: https://gerrit.wikimedia.org/r/#/c/174888/
[18:48:02] <jdlrobson>	 rmoen: so it looks a bit broken but basically idea was to put an edit icon in the infobox
[18:48:10] <jdlrobson>	 and then when you click it it opens up the InfoboxEditorOverlay
[18:48:18] <brion>	 mhurd: ah probably good idea
[18:48:19] <rmoen>	 Right
[18:48:19] <jdlrobson>	 which is a series of lines which you can type values into
[18:48:35] <jdlrobson>	 rmoen: i was hoping it would save directly to wikidata but we could use wikigrok response api to be consistent
[18:48:36] <grrrit-wm>	 (03PS1) 10Dbrant: [WIP] Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 
[18:48:53] <mhurd>	 brion: ya he said it defaulted to zero, but good to just specify it
[18:49:00] <jdlrobson>	 okay me heading off soon. Anyone need anything before i do?
[18:49:26] <rmoen>	 jdlrobson: we could save the save via ApiResponse but then the infobox won't be edited on reload
[18:49:54] <rmoen>	 It seems the user would expect the edit to be made in this case
[18:51:41] <joakino>	 go to sleep
[18:51:51] <jdlrobson>	 yeh rmoen it's a proof of concept in alpha though. Personally i would prefer saving to wikidata directly :)
[18:52:58] <jdlrobson>	 okay i'm off see you all monday
[18:53:04] <jdlrobson>	 i'll let you know how the talk goes :)
[18:53:16] <rmoen>	 jdlrobson: see you
[18:53:16] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] "Looks good, pinging kaldari to verify" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[18:53:20] <kristenlans>	 Have fun jdlrobson!
[18:53:29] <joakino>	 grr where is kaldari xd
[18:53:40] <jdlrobson>	 Maryana: can you ping kaldari get him on irc?
[18:53:58] <Maryana>	 if by ping you mean shout across the room: done
[18:54:00] * jdlrobson waves goodbye and takes a melatonin
[18:54:07] <joakino>	 please 🐣
[18:54:10] <joakino>	 bb jdlrobson
[18:54:27] <joakino>	 kaldari can you verify (CR) Jhernandez: [C: 1] "Looks good, pinging kaldari to verify" [extensions/MobileFrontend] - https://gerrit.wikimedia.org/r/174820 (owner: Kaldari)
[18:54:57] <jdlrobson>	 i'm committed now ;-)
[18:56:10] <kaldari>	 ok
[18:57:23] <kaldari>	 joakino: Can you turn off Scribunto and try it?
[18:57:23] <mhurd>	 Deskana: re ios-ready-for-signoff - do you want me to cut another testflight build?
[18:57:45] <joakino>	 kaldari if you tell me what is that and how to turn it off, sure
[18:58:37] <kaldari>	 It's a MW extension.
[18:59:09] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Auto switch from prefix to in-article search if no prefix results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174927 (owner: 10Mhurd)
[18:59:32] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Added psnamespace parameter to prefix query. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174888 (owner: 10Mhurd)
[18:59:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Added psnamespace parameter to prefix query. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/174888 (owner: 10Mhurd)
[18:59:43] <joakino>	 kaldari: i don't have it enabled
[18:59:49] <joakino>	 kaldari: should I?
[18:59:54] <Deskana>	 mhurd: We can just put it on my devices later so that we don't exhaust everyone else updating. ;-)
[19:00:55] <kaldari>	 joakino: Not sure how it's throwing an error from Scribunto then :P
[19:01:30] <joakino>	 kaldari: yeah lol, it works with the 3rd patch tough
[19:02:00] <joakino>	 that's what I wanted you to verify, ps3, i don't know why ps2 was giving me that :S
[19:02:05] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Hygiene: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[19:02:52] <mhurd>	 Deskana|Away: sure!
[19:02:53] <joakino>	 kaldari: anyway MaxSem ^ just +2d it 🙈
[19:03:32] <mhurd>	 brion: thanks! :)
[19:03:38] <brion>	 :D
[19:03:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Removing our custom phpunit config file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174820 (owner: 10Kaldari)
[19:07:48] <mhurd>	 brion: btw i made this last night with that pretty git log script: https://github.com/montehurd/gitshorts (ended up naming the file “lll” - 3 lower case L’s so i could invoke it super-quick, then i did something similar w branch and status commands and also added a command which shows all of ‘em named “aaa”)
[19:08:31] <brion>	 heh
[19:08:39] <mhurd>	 so now my 90% of the git commands i used to type are reduced to “aaa enter” :)
[19:08:43] <brion>	 nice
[19:09:38] <mhurd>	 brion: the screenshot in the repo readme shows the output of the all “aaa” command
[19:10:53] <grrrit-wm>	 (03PS4) 10Bmansurov: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) 
[19:11:35] <grrrit-wm>	 (03CR) 10Bmansurov: Run jsduck through grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov)
[19:12:38] <grrrit-wm>	 (03CR) 10BearND: "Looks pretty good already, and has promise." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 (owner: 10Dbrant)
[19:14:58] <joakino>	 hey mhurd any troubles upgrading to yosemite?
[19:15:12] <joakino>	 i'm still holding on mavericks out of fear
[19:15:45] <mhurd>	 joakino: no it went pretty smoothly. i know tomasz had some issues
[19:16:15] <joakino>	 mhurd ok, may try it soon
[19:16:35] <joakino>	 mhurd: any improvements you couldn't live without now?
[19:17:29] <mhurd>	 joakino: yes! you can now hook up a phone and directly record what’s happening on the phone screen to record video or share it live in a hangout
[19:17:47] <joakino>	 oh cool
[19:17:54] <brion>	 that’s like the best thing evar
[19:18:23] <joakino>	 if only I used iphone 😸
[19:18:34] <brion>	 no soup for you!
[19:18:38] <joakino>	 haha
[19:19:06] <grrrit-wm>	 (03PS12) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) 
[19:19:27] <joakino>	 alright i'm out
[19:19:34] <joakino>	 have a nice day san franciscans
[19:19:44] <mhurd>	 joakino: thanks! see ya!
[19:26:31] <brion>	 bbiab
[20:53:13] * FlorianSW runs again tried to post a comment to Bugzilla :(
[20:53:31] <kaldari|2>	 MaxSem: If you have some time, you should look over https://gerrit.wikimedia.org/r/#/c/173543/ . He's already addressed my suggestions, so would love to merge it soon.
[20:55:39] <MaxSem>	 looing
[20:55:42] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Fix tappable area of upload button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174963 (owner: 10Jdlrobson)
[20:56:16] <grrrit-wm>	 (03PS1) 10Kaldari: Switching from php5 to php and removing unneeded variable in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175032 
[20:59:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix tappable area of upload button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174963 (owner: 10Jdlrobson)
[21:00:21] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Switching from php5 to php and removing unneeded variable in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175032 (owner: 10Kaldari)
[21:00:29] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] Bump required MW version (031 comment) [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/174893 (owner: 10MaxSem)
[21:00:56] <grrrit-wm>	 (03CR) 10MaxSem: "Actually, in vagrant php5 is always Zend, as opposed to php which is hhvm." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175032 (owner: 10Kaldari)
[21:02:57] <grrrit-wm>	 (03PS1) 10MaxSem: Oh shi... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175039 
[21:03:09] <MaxSem>	 kaldari|2, ^_^ :P
[21:03:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Switching from php5 to php and removing unneeded variable in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175032 (owner: 10Kaldari)
[21:05:43] <grrrit-wm>	 (03PS1) 10MaxSem: Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175042 
[21:05:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175042 (owner: 10MaxSem)
[21:06:02] <MaxSem>	 fuck you jerkins
[21:06:20] <Krenair>	 FlorianSW, I think we should be moving stuff like https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7972578 to spam
[21:06:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Oh shi... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175039 (owner: 10MaxSem)
[21:07:12] <FlorianSW>	 Krenair: is there a spam list? I see only propably spam? :)
[21:07:30] <MaxSem>	 anyone knows why the hell is the npm test failing?
[21:07:57] <Krenair>	 FlorianSW, there's a 'Spam' button :)
[21:08:37] <FlorianSW>	 Krenair: ah, yeah, no i see the button :P Thanks! Have clicked on it :P
[21:10:00] <grrrit-wm>	 (03Abandoned) 10MaxSem: Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175042 (owner: 10MaxSem)
[21:11:46] <FlorianSW>	 hashar: <MaxSem> anyone knows why the hell is the npm test failing?
[21:14:44] <hashar>	 FlorianSW: bad code ? :D
[21:15:37] <FlorianSW>	 hashar: ??? :P
[21:16:15] <hashar>	 FlorianSW: I mean, Jenkins is just executing  "npm tes"
[21:16:17] <hashar>	 gg
[21:16:19] <hashar>	 grrr
[21:16:21] <hashar>	 "npm test"
[21:16:34] <hashar>	 so in most case a failure is related to the code contained in the proposed code
[21:17:19] <hashar>	 https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/60/console :(
[21:17:26] <FlorianSW>	 hashar: but on this change: https://gerrit.wikimedia.org/r/#/c/175032/ main test passes, but gate fails?
[21:17:31] <hashar>	 it logs to a file which we do not capture bah
[21:21:45] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Documentation for special page initialisation functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174907 (owner: 10Jdlrobson)
[21:23:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Documentation for special page initialisation functions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174907 (owner: 10Jdlrobson)
[21:27:59] <hashar>	 FlorianSW: sorry went busy.  I think it is a transient issue. You can remove the Code-Review +2 vote and revote +2
[21:28:18] <FlorianSW>	 MaxSem: ^
[21:28:58] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] "The code looks good, but I'm unable to upload an image. A toast shows up with an error." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson)
[21:31:49] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson)
[21:33:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Infobox: movies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170435 (owner: 10Jdlrobson)
[21:34:28] <hashar>	 FlorianSW: https://gerrit.wikimedia.org/r/175112 would make Jenkins capture the npm-debug.log file  but that change is not going to work for now :D
[21:34:53] <FlorianSW>	 hashar: great :)
[21:35:22] <Krenair>	 FlorianSW, umm... I think you moved it somewhere else
[21:35:36] <FlorianSW>	 Krenair: i clicked "Spam"
[21:35:51] <bearND>	 dbrant: how's it going?
[21:36:02] <Krenair>	 oh well
[21:36:15] <dbrant>	 bearND: issues with 2.3 (of course)...
[21:36:29] <bearND>	 dbrant: with the native component?
[21:36:35] <dbrant>	 bearND: yep
[21:37:08] <FlorianSW>	 Krenair: ??
[21:37:10] <hashar>	 FlorianSW: also for what it is worth, I am supposed to be off of IRC.  The best course of action would be to fill a task in phabricator whenever it is open :-]
[21:37:30] <FlorianSW>	 hashar: ok :)
[21:37:38] <Krenair>	 FlorianSW, it doesn't matter much
[21:37:47] <grrrit-wm>	 (03PS1) 10BearND: Remove W logo icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175115 
[21:38:23] <AndyRussG>	 Hi mobile!
[21:38:26] * AndyRussG waves
[21:38:43] <grrrit-wm>	 (03PS2) 10Deskana: Improve log messages for EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174916 
[21:39:20] <AndyRussG>	 Elliot just deployed another CentralNotice change to Mediawiki and test2.wikipedia.org, in case anyone would like to test it out on mobile :)
[21:39:39] <AndyRussG>	 Everything looks good and we plan to push it out everywhere in a little while if there are no issuz
[21:39:51] <Deskana>	 dbrant: I cut down the logging in that patch while still keeping most of my changes in: https://gerrit.wikimedia.org/r/174916
[21:39:59] <Deskana>	 dbrant: It's actually logging fewer events now.
[21:40:23] <dbrant>	 Deskana: nice!
[21:40:59] <dbrant>	 bearND: also, we may have a problem with the SVG files from the Material set.  I tried importing the "search" icon into our collection, and the rsvg converter seems to render it really weirdly!
[21:41:00] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] "It's not aligned correctly on Chrome/Mac. Looks good on Firefox/Mac. See trello card for the screenshot." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (https://bugzilla.wikimedia.org/73115) (owner: 10Jdlrobson)
[21:42:15] <bearND>	 dbrant: i might take a look at that later. What's the issue you're seeing on 2.3?
[21:44:10] <dbrant>	 bearND: on my device, the WebView seems to stop rendering the sections halfway through (even though all the sections were definitely passed to it over the brodge)...  I'm actually no longer convinced that it's related to this patch, either :(
[21:44:41] * Deskana takes a deep breath
[21:44:44] <Deskana>	 WEB VIIIIIIIIIIIIIIIEW
[21:44:58] <Deskana>	 KHAAA.... I mean WEB VIIIIIIIIIIEW
[21:45:03] * Deskana sighs
[21:45:03] <bearND>	 dbrant: is the native component over the content?
[21:45:25] <bearND>	 i meancovering up the content in the webview?
[21:46:12] <dbrant>	 bearND: yep
[21:46:53] <dbrant>	 Deskana: it's more like: 2.3!!!!!!!!!!!!!!!!!!!!!!
[21:46:59] <Deskana>	 Haha, that too :-p
[21:48:31] <brion>	 they should make a 2.3 back-compatibility library that just implements android 5 on top of android 2.3
[21:48:42] <brion>	 the whole thing as a virtualized os
[21:48:50] <dbrant>	 you would think!
[21:48:56] <brion>	 oh and also it blows up your phone so you have to get a new one that’s not so damn old
[21:49:43] <Deskana>	 mhurd, brion: https://trello.com/c/waCWtWvv/37-as-a-product-manager-i-d-like-to-be-selectively-disable-the-display-of-wikidata-descriptions-in-different-sections-of-the-app-so
[21:49:46] <FlorianSW>	 AndyRussG: Looks fine on test2wiki
[21:49:56] <grrrit-wm>	 (03PS1) 10MaxSem: Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175121 
[21:49:56] <AndyRussG>	 FlorianSW: thank you! :)
[21:49:57] <mhurd>	 Deskana: cool
[21:50:00] <Deskana>	 mhurd, brion: I made a separate card for this since it's not encompassed in the full text search killswitch card.
[21:50:06] <Deskana>	 mhurd, brion: Want to do a gut-check estimate?
[21:50:07] <brion>	 Deskana: do you want separate switches for each?
[21:50:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175121 (owner: 10MaxSem)
[21:50:15] <brion>	 Deskana: or a single killswitch that applies to them all?
[21:50:23] <Deskana>	 brion: Monte wants separate ones, I'm okay with that
[21:50:23] <mhurd>	 Deskana: ya, in a few min if that’s ok...
[21:50:27] <brion>	 ok
[21:50:28] <Deskana>	 mhurd: No rush
[21:50:32] <AndyRussG>	 FlorianSW: Have also been trying it out, just tried editing in mobile view on my browser, and also browsing on a real android device...
[21:50:37] <brion>	 i’d say 2ish then. not hard, just needs to update in a couple places
[21:50:46] <dbrant>	 bearND: I really don't know how we could prevent the native component from flashing in certain cases.  I show the native component when the WebView sends a "page complete" message, but it doesn't mean that the WebView has finished rendering everything yet (or even started)!
[21:50:47] <brion>	 add the swithes to MobileApp ext and use them in the places
[21:51:03] <Deskana>	 brion: Cheers!
[21:51:07] <grrrit-wm>	 (03PS1) 10MaxSem: Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 
[21:51:27] <grrrit-wm>	 (03Abandoned) 10MaxSem: Bump required MW version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175121 (owner: 10MaxSem)
[21:51:28] <brion>	 as far as i know it shouldn’t be much harder to add 4 switches than 1 :D
[21:51:38] <grrrit-wm>	 (03Abandoned) 10MaxSem: Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/174893 (owner: 10MaxSem)
[21:51:41] <FlorianSW>	 AndyRussG: On test2wiki you can use qunit, too, to run our mobile JS tests. https://test2.m.wikipedia.org/wiki/Special:JavaScriptTest/qunit
[21:51:53] <AndyRussG>	 FlorianSW: Ah fantastic :)
[21:51:56] <grrrit-wm>	 (03PS2) 10MaxSem: Oh shi... [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175039 
[21:52:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem)
[21:53:02] <bearND>	 dbrant: yeah. Seems to me it's safer to stuff the attributions back and the read more into the WebView
[21:53:12] <AndyRussG>	 FlorianSW: should I be upset if I see some failures?
[21:53:29] <MaxSem>	 hashar, https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-testextension/2552/console looks like jenkins rebases it on top of master instead of REL1_24
[21:53:34] <dbrant>	 bearND: :( perhaps.
[21:53:46] <FlorianSW>	 AndyRussG: jap ;) All tests should pass
[21:54:17] <AndyRussG>	 FlorianSW: try out the URL? do you get any falures?
[21:54:38] <dbrant>	 bearND: or possibly rethink how we present the Read More items...
[21:54:49] <FlorianSW>	 AndyRussG: no errors
[21:55:21] <bearND>	 dbrant: ?
[21:55:49] <FlorianSW>	 AndyRussG: do you have some errors?
[21:56:12] <AndyRussG>	 FlorianSW: OK... so I get no errors on Chromium, but 3 failures on FF (Iceweasel)
[21:58:13] <dbrant>	 bearND: i'll put some thoughts in an email. And I'll try to bang on this just a bit more...
[21:58:29] <bearND>	 dbrant: ok
[21:59:20] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Revert "Focus editor textarea" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175126 
[21:59:24] <AndyRussG>	 FlorianSW: http://gw.gd/JAym
[21:59:25] <FlorianSW>	 AndyRussG: this is fixed in I672d04c16f9348f7e08c4f64b339b307276d2a5a
[21:59:43] <hashar>	 MaxSem: it does :  INFO:zuul.Cloner:Prepared mediawiki/core repo with branch REL1_24
[21:59:59] <MaxSem>	 eek
[22:00:09] <MaxSem>	 still, this error shouldn't happen
[22:01:02] <hashar>	 well
[22:01:12] <hashar>	 what does mediawiki/core @ REL1_24 has for $wgVersion ?
[22:01:20] <hashar>	 and how does it work with:  f ( version_compare( $wgVersion, '1.24c', '<' )   ??
[22:01:33] <AndyRussG>	 FlorianSW: So I shouldn't worry that it's due to the code we just deployed? Anyway, those are unit tests, not integration tests...
[22:02:33] <hashar>	 php > var_dump( version_compare( '1.24.0-rc.0', '1.24c', '<' ) );
[22:02:33] <hashar>	 bool(false)
[22:02:33] <hashar>	 MaxSem: ^^^
[22:02:46] <AndyRussG>	 I don't see our CentralNotice qunit tests, I guess we have to register them specially for the mobile view?
[22:02:50] <hashar>	 MaxSem: 1.24 comes with semantic versioning, so the test is slightly different
[22:03:51] <FlorianSW>	 AndyRussG: right, but it checks, if mobile dependencies makes sense for most modules :)
[22:04:15] <AndyRussG>	 Hmmm
[22:05:05] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] Bump required MW version (031 comment) [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem)
[22:05:17] <AndyRussG>	 FlorianSW: Did you see the pastebin? If I understood correctly, you'd say this is not a problem with the code we just deployed? We were hoping to push it out everywhere...
[22:05:29] <AndyRussG>	 But we could wait...
[22:06:02] <ejegg>	 AndyRussG: that really doesn't look related to our stuff at all
[22:06:33] <FlorianSW>	 AndyRussG: Yes, that's a problem of MobileFrontends code (just in FF), which get's fixed with https://gerrit.wikimedia.org/r/175126 (unhappily, we haven't backported it for now to wmf9 :)).
[22:06:43] <FlorianSW>	 ejegg: ^
[22:06:55] <ejegg>	 ah, cool.  Thanks FlorianSW 
[22:08:31] <AndyRussG>	 K thanks!
[22:08:42] <FlorianSW>	 np :)
[22:09:49] <grrrit-wm>	 (03PS1) 10MaxSem: Disable test that works only with MW 1.25 [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175131 
[22:10:52] <Maryana>	 wow, checking wikigrok responses for accuracy makes me so happy
[22:11:04] <Maryana>	 and teaches me a lot about where famous people went to school :)
[22:11:33] <MaxSem>	 what, vandals are playing nice trying to convince you to procedd with pushing their replies? :P
[22:11:58] <Maryana>	 if that's what we're doing, we have won the internet
[22:12:02] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "Derp." [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175131 (owner: 10MaxSem)
[22:12:03] <Maryana>	 the vandals work for US NOW!
[22:12:16] <MaxSem>	 you mean FOR NOW?
[22:12:24] <Maryana>	 seriously, though, every single answer is correct
[22:12:26] <Maryana>	 and some of these are hard
[22:12:35] <Maryana>	 yay humans!
[22:12:42] <kristenlans>	 \O/ groknards!
[22:13:08] <Maryana>	 we're gonna get lots of eyeballs on the actor bios for the new claims, i can already tell
[22:13:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable test that works only with MW 1.25 [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175131 (owner: 10MaxSem)
[22:15:05] <grrrit-wm>	 (03PS2) 10MaxSem: Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 
[22:18:05] <brion>	 now we need to train machines to check the quality of human answers
[22:18:18] <brion>	 and humans to check the machines’ training
[22:18:25] <brion>	 and machines to train those humans how to check
[22:18:37] <brion>	 and somewhere at the end of it all, HITLER IS GAYYYYYYYYYYY
[22:20:59] <mhurd>	 Deskana: you about?
[22:21:10] <Maryana>	 brion: lulz
[22:22:00] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Switching from php5 to php and removing unneeded variable in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175032 (owner: 10Kaldari)
[22:27:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Switching from php5 to php and removing unneeded variable in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175032 (owner: 10Kaldari)
[22:34:10] <AndyRussG>	 FlorianSW: new CN stuff now deployed everywhere, looks good so far!
[22:36:33] <FlorianSW>	 AndyRussG: looks good :)
[22:38:55] <Deskana>	 mhurd: I'm upstairs. Coming down now!
[22:49:59] <AndyRussG>	 FlorianSW: fantastic, thanks a ton :)
[22:56:34] <chrismcmahon>	 clicking watchlist stars in MF has changed subtly for Chrome, but I can't *quite* find a bug. 
[23:01:59] <kaldari|2>	 Maryana: Also, don't forget to add a card about the disappearing editor in iOS 8
[23:02:13] <Maryana>	 on it
[23:06:52] <chrismcmahon>	 kaldari|2: MaxSem in the absence of bugzilla, as of today if you click the watch star a couple times in Chrome, it'll hang forever http://imgur.com/GZk4EuR.  Firefox seems OK.
[23:07:32] <kaldari|2>	 chrismcmahon: thanks
[23:08:07] <chrismcmahon>	 kaldari|2: click fast enough it might show an error: https://saucelabs.com/jobs/6510863853a54ed3ab0d250ffb0bfe55
[23:24:14] <Maryana>	 ah, mobile site is haunted again!
[23:26:03] <Maryana>	 kaldari|2: MaxSem i'm seeing the search icon and other icon weirdness again… what's the deal? is adam trolling us again? :)
[23:26:28] <kaldari|2>	 Maryana: That usually indicates that something is breaking JS
[23:26:52] <kaldari|2>	 Maryana: Where are you seeing?
[23:27:04] <Maryana>	 oh wait, i think it might've been an emulation issue
[23:27:09] <Maryana>	 nm
[23:27:23] <Maryana>	 it was serving me something in between high-end and low-end :)
[23:29:09] <Maryana>	 hmm, so this hasn't made it out to enwiki yet, right? https://trello.com/c/36Cgvx1Q/110-bug-wikigrok-b-not-logging-confirmation-screen
[23:36:34] <kaldari|2>	 Maryana: Correct
[23:37:08] <kaldari|2>	 Maryana: I fixed the iOS scrolling issue. Can you see if it fixes the disappearing screen issue as well (I suspect it doesn't): http://27192177.ngrok.com/index.php?title=MegaMan#/editor/2
[23:38:01] <Maryana>	 will give it a try
[23:38:41] <Maryana>	 kaldari|2: nope :(
[23:44:47] <grrrit-wm>	 (03PS1) 10Kaldari: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175150 (https://bugzilla.wikimedia.org/73255) 
[23:47:12] <kaldari|2>	 Maryana: Where are you and Dan? I need an iOS 8 device
[23:49:15] <Maryana>	 we're meeting w/comms
[23:49:22] <Maryana>	 upgrade!!!
[23:49:24] <Maryana>	 >:)
[23:50:05] <kaldari|2>	 not until they get over their 'flat' fad :)
[23:53:02] <kaldari|2>	 updating one of our test devices....
[23:54:47] <grrrit-wm>	 (03PS4) 10Dr0ptp4kt: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210