[00:12:47] (03PS2) 10Kaldari: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175150 (https://bugzilla.wikimedia.org/73255) [00:12:53] brion, it's KeybladeSpyMaster, I was here back in June for help developing an app for the Kingdom Hearts Wiki. [00:14:59] Using the Wikipedia source code for their Windows 8 app, I've been able to build a mostly working app, but I've run into a problem: I can't get any of the pictures to load on the page. They only appear when I click them to open in the floating white box. [00:20:11] kaldari|2: off the top of your head, do you remember how many album articles the albums campaign would show up on? [00:20:21] Maryana: 160,000 [00:20:25] w00t! [00:35:23] Or does anyone know why this happens? The only thing I've changed is the references from Wikipedia to the KHWiki [00:36:31] KeybladeSpyMaste, does your wiki has all the API dependencies? [00:37:08] I believe so, though I'm not sure. [00:38:30] The pictures do load, but only when I click on the broken link. In the Javascript console in Visual Studio, it seems to be searching for the images locally or something. [00:40:41] hmm, sniff what's going on with HTTP requests? I suspect it might be trying to use a wrong thumbnail path [00:45:16] http://1drv.ms/1y0ixNS Those are screenshots of the app and the Javascript Console errors. [00:45:58] It seems to look for the images locally when the page loads (which is why it says RESOURCE NOT FOUND), but then goes to the actual web address when I open the image itself. [00:46:08] KeybladeSpyMaste: hey [00:46:17] Hi [00:46:24] are the urls correct? it might have made some attempt to normalize them and is doing it wrong for yours [00:46:40] check if there’s something weird like a double https:// or somethin [00:47:21] istr something about having to rewrite the image urls in javascript yeah [00:48:59] try something like this in the after-load handling: [00:49:00] KeybladeSpyMaste: $( ‘img’ ).each(function(img) { /* check img.src and fi it’s a relative path adjust it */ }); [00:49:44] there might be code in there that looks for things beginning with // since our image paths on wikipedia point to a specific server in a relative way [00:49:52] which might need adjusting for your different url scheme [00:52:57] I'll see if I can find that. Is it the "(/^\//)"? [00:56:21] dr0ptp4kt: https://github.com/montehurd/apps-ios-wikipedia/tree/searchSnippet [00:56:48] dr0ptp4kt: “SearchResultAttributedString” [01:02:29] Is it this?: $div.find('img').each(function () {// fixup for protocol-relative images [01:02:29] var $img = $(this), [01:02:29] src = $img.attr('src'); [01:02:29] if (src.substr(0, 2) == '//') { [01:02:29] $img.attr('src', 'http://www.khwiki.com/' + src); [01:02:30] } [01:02:30] }); [01:03:25] I'm sorry, but I'm still no good with Javascript. [02:10:35] mhurd: I was right [02:10:37] This is an email I'm drafting: [02:10:40] "and also planning and design review meetings for Apps. nhjysnai" [05:43:34] Hey guys, it's me again. I've been able to figure out how to make the images appear, but they don't appear on infoboxes. Do you guys know where in the Wikipedia Win 8 app the code should appear to change image sources? [05:59:05] Never mind, found it. Thanks guys! [17:14:19] (03PS1) 10Deskana: Use apply method instead of commit method for SharedPreferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175220 [17:45:52] (03CR) 10Dbrant: [C: 032] Improve log messages for EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174916 (owner: 10Deskana) [17:50:45] (03CR) 10Dbrant: [C: 032] "good find!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175220 (owner: 10Deskana) [17:51:34] (03CR) 10Dbrant: [C: 032] Avoid IndexOutOfBoundsException in when loading page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174976 (https://bugzilla.wikimedia.org/73404) (owner: 10BearND) [17:53:59] (03CR) 10Dbrant: [C: 032] Remove W logo icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175115 (owner: 10BearND) [17:57:38] (03PS1) 10Dbrant: [WIP] Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) [17:58:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) (owner: 10Dbrant) [18:06:52] (03PS2) 10Dbrant: [WIP] Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) [18:08:41] (03PS1) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225