[00:26:19] (03PS3) 10Jdlrobson: Correct error message when checking version number [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175039 (owner: 10MaxSem) [00:26:30] (03CR) 10Jdlrobson: [C: 032] Correct error message when checking version number [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175039 (owner: 10MaxSem) [00:27:47] (03Merged) 10jenkins-bot: Correct error message when checking version number [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175039 (owner: 10MaxSem) [00:29:29] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't seem to include Mantle JavaScript files. I now get a bunch of errors. This is important to fix as `make jsduck` is run in the pre-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov) [00:43:01] (03PS4) 10Jdlrobson: Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [00:43:22] (03CR) 10Jdlrobson: Style links in Overlay header like buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [00:43:30] (03CR) 10Jdlrobson: [C: 031] Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [05:31:05] (03CR) 10Florianschmidtwelzow: Style links in Overlay header like buttons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [05:31:15] (03CR) 10Florianschmidtwelzow: [C: 031] Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [06:50:48] (03PS5) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users (Alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 [06:52:18] (03CR) 10jenkins-bot: [V: 04-1] Backlog: Show Watchstar only for logged in users (Alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 (owner: 10Florianschmidtwelzow) [07:03:57] (03CR) 10Jdlrobson: [C: 032] Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [07:05:19] (03Merged) 10jenkins-bot: Style links in Overlay header like buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172992 (https://bugzilla.wikimedia.org/73243) (owner: 10Florianschmidtwelzow) [07:09:17] (03CR) 10Jdlrobson: [C: 032] Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175150 (https://bugzilla.wikimedia.org/73255) (owner: 10Kaldari) [07:09:44] 3MobileFrontend-General-or-Unknown: Can't scroll to top in editing window - https://phabricator.wikimedia.org/T71092#777519 (10Jdlrobson) 5Resolved>3Open [07:10:07] 3MobileFrontend-General-or-Unknown: Can't scroll to top in editing window - https://phabricator.wikimedia.org/T71092#727228 (10Jdlrobson) Fix introduced over issues. Reverted fix thus bug therefore reopened. [07:10:28] (03Merged) 10jenkins-bot: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175150 (https://bugzilla.wikimedia.org/73255) (owner: 10Kaldari) [07:12:47] 3MobileFrontend-stable: [Regression wmf9]Cannot create a new page in Firefox. Edit button doesn't respond - https://phabricator.wikimedia.org/T75585#777527 (10Jdlrobson) 5Open>3Resolved [07:13:14] 3MobileFrontend-stable: [Regression wmf9]Cannot create a new page in Firefox. Edit button doesn't respond - https://phabricator.wikimedia.org/T75585#762409 (10Jdlrobson) I can edit new pages on Firefox so I think this has been fixed. Please reopen if you can still duplicate it. [08:30:46] 3MobileFrontend-beta: Talk: Add discussion button doesn't look like other Overlay buttons - https://phabricator.wikimedia.org/T75243#777590 (10Florian) 5Open>3Resolved [09:40:32] hey joakino :D [09:40:44] hi jdlrobson-m! [09:40:51] are you on holidays yet? [09:42:02] no [09:42:04] last day [09:42:08] it's also the fun one [09:42:15] 4.30am finish :D [09:42:25] also add Chinese internet restrictions [09:42:27] gonna be a hoot [09:43:03] joakino: trying to finish off the iteration [09:43:06] can you take a look at https://gerrit.wikimedia.org/r/#/c/174982/ ? [09:43:34] sure [09:47:52] 3Mobile-Web, MobileFrontend-alpha: [Alpha] Some infoboxes do not load - https://phabricator.wikimedia.org/T75701#777716 (10Florian) [09:58:28] 3Mobile-Web, MobileFrontend-alpha: [Alpha] Some infoboxes do not load - https://phabricator.wikimedia.org/T75701#777728 (10Florian) a:3Florian [09:59:34] (03PS1) 10Florianschmidtwelzow: Infobox: Check if entities isn't undefined [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175405 [10:00:35] 3Mobile-Web, MobileFrontend-alpha: [Alpha] Some infoboxes do not load - https://phabricator.wikimedia.org/T75701#777732 (10Florian) https://gerrit.wikimedia.org/r/#/c/175405/1 [10:10:48] joakino: node check script keeps trying to download phantomjs for me [10:10:50] very annlying [10:10:53] *annoying [10:11:08] what is that? jdlrobson-m [10:11:33] it's in the makefile [10:11:36] it checks you have node installed [10:11:46] something juliusz wrote [10:11:57] but it seems to be running `node install.js` for me :) [10:12:01] grumble grumble [10:14:25] nodecheck.sh is only an npm install :S [10:16:08] (03CR) 10Jhernandez: [C: 032] "It works fine and looks good." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson) [10:16:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor special uploads code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson) [10:16:20] hey jdlrobson-m for bugs we now go to bugzilla? [10:16:43] sorry, phabricator [10:17:41] crashed, back again [10:17:46] joakino_: correctomondo [10:17:58] joakino_: i'm still trying to work it out [10:18:02] but it's cool a bug can belong to multiple teams :) [10:18:17] mmm a bunch of ports are blocked at airport which is annoying [10:19:18] jdlrobson-m: where are you now? [10:20:03] joakino_: taipei airport [10:20:45] how did you like taiwan [10:20:58] joakino_: it's cool. I'm coming back in a week for a couple of nights [10:21:06] it's HOOOTTT today. Almost 30 degrees c [10:21:10] china gonna be cooler sadly [10:21:29] you'll be good :) [10:21:40] awesome [10:22:48] jdlrobson-m: i'm going out for 15 min [10:26:43] joakino: np [10:26:47] metapping out too soon [11:23:09] (03PS3) 10Jhernandez: Hygiene: Refactor special uploads code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson) [11:24:33] (03CR) 10Jhernandez: [C: 032] "Rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson) [11:26:10] (03Merged) 10jenkins-bot: Hygiene: Refactor special uploads code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174982 (owner: 10Jdlrobson) [11:51:06] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App, Wikimedia-Continuous-integration: Jenkins should run tests for the Wikipedia app before merge - https://phabricator.wikimedia.org/T62720#778000 (10hashar) p:5Normal>3Volunteer? [12:24:51] (03CR) 10Jhernandez: [C: 032] Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [12:26:27] (03Merged) 10jenkins-bot: Hygiene: Goodbye mobile.stable.common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [12:36:37] 3MobileFrontend-General-or-Unknown: Unregistered editing shouldn't require 3 clicks - https://phabricator.wikimedia.org/T74852#778109 (10Florian) > Here, I think that personal opinion needs to bow to empirical observation. I'm totally with you, that's why i wrote, that it is my personal opinion :) If the mobile... [13:53:58] (03PS1) 10Dbrant: Fix checkstyle and compilation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175429 [13:58:19] (03PS3) 10Dbrant: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) [13:59:57] (03PS1) 10Dbrant: Start loving tablets more. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175431 [14:35:09] (03PS2) 10Dbrant: Start loving tablets more. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175431 [15:31:17] (03CR) 10Hashar: "How did that managed to be fixed?" [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [15:40:47] (03PS1) 10Jdlrobson: Optimise non-js experience for Opera Mini [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175443 [15:42:13] milimetric: are you around? [15:42:26] i am, but in a meeting [15:57:01] StevenW: so quora is also banned in china it seems. Pretty much every website I use apart from bbc news :) [16:00:18] 3Wikipedia-App-Android-App: Disable language selection for languages that are not supported by the OS - https://phabricator.wikimedia.org/T75751 (10Dbrant) 3NEW p:3Normal [16:07:40] 3Mobile-Web, MobileFrontend-alpha: [Alpha] Some infoboxes do not load - https://phabricator.wikimedia.org/T75701#780518 (10Jdlrobson) Maryana/Florian the wikidata id seems to be incorrect on "Q8148" for Barack Obama. I guess query string parameter doesn't trump existing ones. I'm not sure if that's a bug itself.... [16:07:51] (03CR) 10Jdlrobson: [C: 032] Infobox: Check if entities isn't undefined [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175405 (owner: 10Florianschmidtwelzow) [16:12:32] (03Merged) 10jenkins-bot: Infobox: Check if entities isn't undefined [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175405 (owner: 10Florianschmidtwelzow) [16:19:56] 3Wikipedia-App-Android-App: 404 when trying to download new alpha - https://phabricator.wikimedia.org/T74151#780841 (10Matanya) This has been fixed in the mean time, you close it, if you are satisfied from the solution. [16:26:01] 3Mobile-Web, MobileFrontend-alpha: [Alpha] Some infoboxes do not load - https://phabricator.wikimedia.org/T75701#780968 (10Jdlrobson) [16:33:03] kristenlans: you arouund? [16:33:15] Hey jdlrobson I’m around [16:38:18] \o/ [16:39:02] Success. [16:42:33] James_F you're spammmminngg my inbox :P [16:43:05] jdlrobson: How many were you copied on? [16:43:20] i can't count them heheh :) [16:43:53] From: Phabricator && Word: VisualEditor => Action: Archive. [16:43:54] ;-0 [16:48:23] 3Wikipedia-App-Android-App: 404 when trying to download new alpha - https://phabricator.wikimedia.org/T74151#781241 (10bearND) 5Open>3Resolved Yes, this has been fixed. I've added redirect to the new server, and updated a link to the build server. [16:49:11] 3Wikipedia-App-Android-App: Disable language selection for languages that are not supported by the OS - https://phabricator.wikimedia.org/T75751#781253 (10bearND) [17:33:07] (03PS1) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 [17:45:26] 3Mobile-Web, MobileFrontend-alpha: [Alpha] Some infoboxes do not load - https://phabricator.wikimedia.org/T75701#781397 (10Florian) >>! In T75701#780518, @Jdlrobson wrote: > Maryana/Florian the wikidata id seems to be incorrect on "Q8148" for Barack Obama. I guess query string parameter doesn't trump existing on... [17:45:40] jdlrobson: ^ Hi :) [17:45:46] hey FlorianSW :) [17:46:18] jdlrobson: how are you? It's great to have you online "within my timezone" :P [17:46:33] Maryana: how do i use a watchlist token? [17:46:42] i was hoping you'd know :) [17:46:57] Maryana: :-S was hoping just for the raw in the email [17:47:01] e.g. https://en.wikipedia.org/wiki/Special:EditWatchlist/raw [17:47:17] https://en.wikipedia.org/wiki/Wikipedia:Syndication#Watchlist_feed_with_token [17:47:22] FlorianSW: i'm gmt+8 at moment but today is my last day working on that timezone i'm afraid [17:47:58] jdlrobson: it looks like if you go to this URL and add in my username + token, you'll see my watchlist [17:48:00] http://en.wikipedia.org/w/api.php?action=feedwatchlist&wlowner=USERNAME&wltoken=TOKEN [17:48:18] jdlrobson: hm :( :) Maryana: that's how watchlist tokens work :) [17:48:23] (my username is Accedie) [17:48:26] (if i understood and remmeber correctly the api docu) [17:50:58] jdlrobson: hey so I did some work on the infobox parameter ooui menu, But having an issue getting Infoboxes working locally for final tweaks. any tips on getting them setup locally ? [17:51:15] rmoen: are you in alpha and passing wikidataid ? [17:51:19] that's all you should need to do [17:51:30] jdlrobson: yes [17:51:52] i've also installed scribunto and exported/imported the en.wiki Infobox templates [17:52:07] hi jdlrobson rmoen [17:52:14] joakino: hi [17:52:14] hey joakino rmoen [17:52:20] rmoen: that's not necessary :) [17:52:26] rmoen: no need for scribunto or any templates [17:52:39] it's purpose is to kill templates :) [17:52:46] rmoen: that's all you should need.. if it's not loading then somethings broke [17:52:48] jdlrobson: that's what I figured but lets just say i've tried things [17:52:56] jdlrobson: ok [17:53:03] thanks [17:53:29] (03PS2) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 [17:53:32] endofspriint [17:56:01] jdlrobson: did you see this backport: https://gerrit.wikimedia.org/r/#/c/175126/ ??? [17:56:38] (03PS6) 10Jdlrobson: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (https://bugzilla.wikimedia.org/73115) [17:56:47] FlorianSW: yes. I'm not 100% sure it's fixed the problem though [17:57:13] jdlrobson: you mean? [17:59:53] Maryana: that doesn't help. The raw list would make my life a lot easier [17:59:57] i have to parse this [18:01:11] (03CR) 10BearND: [C: 032] Fix checkstyle and compilation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175429 (owner: 10Dbrant) [18:01:31] (03Merged) 10jenkins-bot: Fix checkstyle and compilation. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175429 (owner: 10Dbrant) [18:10:16] jdlrobson, I'm getting some exceptions with latest MobileFrontend and Mantle [18:12:45] 'Class 'ResourceLoaderTemplateModule' not found' [18:15:41] jdlrobson: [18:15:42] k [18:15:52] edsanders: sounds like you have an old version of Zero or Flow installed [18:15:59] ResourceLoaderTemplateModule doesn't exist anywhere any more [18:16:17] jdlrobson, nope [18:16:37] Maryana: mm? [18:16:43] raw watchlist sent [18:16:54] I see ResourceLoaderTemplateModule in MobileFrontend still, despite being up to date [18:17:09] Maryana: thanks :) [18:17:12] line 219 of MobileFrontend.php [18:17:21] and 232 MobileFrontend.hooks.php [18:17:25] edsanders: that's impossible\ [18:17:31] (03PS1) 10Cmcmahon: QA: remove unused steps and page files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175468 [18:17:34] edsanders: double check you are on latest master [18:17:45] * edsanders checks [18:18:16] ah - git is blocked on a local change. stupid. thanks [18:18:20] Maryana: thanks ok testing [18:18:25] edsanders: np glad i unblocked you :) [18:18:49] hmm, anybody know what the beta labs project is called in phabricator? [18:19:08] or if there's a page somewhere w/a glossary of projects? :) [18:19:49] (03PS1) 10Mhurd: Search snippets with in-article search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/175469 [18:20:01] Maryana: just add greg-g to it ;-) [18:20:50] brion: https://gerrit.wikimedia.org/r/#/c/175469/ [18:21:18] brion: saturday got crazy :) [18:21:23] :D [18:21:29] Maryana: #Beta-Cluster [18:21:37] danke! [18:21:37] (03CR) 10MaxSem: "Because the problem wasn't in comparison;)" [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [18:22:04] it was "Wikimedia-Labs-Deployment-prep-(beta)" which is dumb and I'm soooo thankful to be away from BZ now :) [18:23:06] first phab task created! [18:23:15] now we need to point grrit bot to phab instead of bz [18:23:31] Maryana: kaldari i can see the editing issue [18:23:38] Maryana: do we have a bug number? [18:23:46] https://phabricator.wikimedia.org/T75770?workflow=create [18:23:49] jdlrobson: ^ [18:24:18] Maryana, https://phabricator.wikimedia.org/T169 [18:24:38] excellent :) [18:28:25] (03CR) 10Kaldari: "Looks like this broke editing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171732 (owner: 10Jdlrobson) [18:28:56] (03PS1) 10Cmcmahon: QA: alphabetize common_article_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175477 [18:29:03] (03PS1) 10Jdlrobson: Fix race condition preventing edit button from being clickable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175478 [18:29:05] kaldari: [18:29:08] ^ [18:29:14] kaldari: already on it [18:31:31] kaldari: MaxSem - we're in R37 [18:33:14] (03CR) 10Cmcmahon: [C: 032] "no change to function or text, just alphabetized" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175477 (owner: 10Cmcmahon) [18:34:13] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:34:33] (03Merged) 10jenkins-bot: QA: alphabetize common_article_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175477 (owner: 10Cmcmahon) [18:38:49] jdlrobson: hey do you still want to talk about design for wikidata infoboxes? [18:39:18] yeh but might be worth talking to rmoen about it as i'm off on vacation tomorrow until next wed :) [18:40:01] (03CR) 10BearND: [C: 032] Start loving tablets more. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175431 (owner: 10Dbrant) [18:40:13] jdlrobson: ok cool! [18:40:43] dbrant: is https://gerrit.wikimedia.org/r/#/c/175459/ ready for CR? It's not in the CR column. [18:40:54] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:41:31] (03Merged) 10jenkins-bot: Start loving tablets more. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175431 (owner: 10Dbrant) [18:41:53] bearND: actually, not yet. I had a couple more questions for Dan about it. [18:42:50] https://docs.google.com/a/wikimedia.org/document/d/1NqzIX9hXJbaY-ke6uWThKFBEj7CUweSQrw6cCR_fGcY/edit [18:44:00] dbrant: ok [18:50:58] Deskana: I have an account on Trello now, Can you see if you can find me and add access for the workboard? [18:52:00] ryasmeen: Sure! [18:52:04] ryasmeen: What's your username? I'll also need to add you to the Wikimedia Foundation organisation. [18:54:37] Deskana: I used my google account to signup : ryasmeen@wikimedia.org [18:54:54] * Deskana looks. [18:55:17] I think I added you to the organisation. [18:55:34] Now to add you to the boards. [18:55:49] Deskana: yup got that notification [18:55:54] \o/ [18:56:27] Ah I see it now: sprint 45,iOS Wild Turkey ! :D [18:56:55] kristenlans: Can you do 3pm SF time for our chat? [18:57:27] jdlrobson: I forget, how do you find out about broken browser tests? There's some email that goes out, right? I can never find it though :( [18:57:37] haha. no email [18:57:46] Deskana yes! [18:57:50] kaldari|2: https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/ [18:58:07] jdlrobson: ah, thanks [18:58:09] kristenlans: Excellent, I'll set something up. [18:59:12] Deskana ty [19:08:45] (03PS1) 10BearND: Material Design icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175490 [19:23:46] mhurd: I made a card for your work on the freezing bug [19:23:47] mhurd: https://trello.com/c/lU59KgQu/38-fix-freezing-bug [19:23:56] mhurd: Just so that we keep that in mind if it slows down velocity or whatever [19:23:59] (03PS1) 10Cmcmahon: QA: remove redundant step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175491 [19:25:28] (03CR) 10Cmcmahon: [C: 032] QA: remove unused steps and page files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175468 (owner: 10Cmcmahon) [19:25:44] (03CR) 10Cmcmahon: [C: 032] QA: remove redundant step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175491 (owner: 10Cmcmahon) [19:27:05] (03Merged) 10jenkins-bot: QA: remove unused steps and page files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175468 (owner: 10Cmcmahon) [19:27:07] (03Merged) 10jenkins-bot: QA: remove redundant step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175491 (owner: 10Cmcmahon) [19:28:13] joakino: thanks for the device/browser list :) [19:29:01] Deskana: ooh thanks! [19:29:11] Also, can we get a gut-check estimate on this? [19:29:11] https://trello.com/c/waCWtWvv/37-as-a-product-manager-i-d-like-to-be-selectively-disable-the-display-of-wikidata-descriptions-in-different-sections-of-the-app-so [19:29:29] Deskana: sure i’d say 3ish? [19:31:08] brion: That sound okay to you? [19:31:14] I think you said 2ish originally. [19:31:45] -ish :) [19:32:10] bmansurov and joakino don’t forget to coe to the new hangout ;-) [19:34:07] https://etherpad.wikimedia.org/p/J [19:35:19] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175494 [19:37:17] http://hatjitsu.wmflabs.org/46806 [19:41:16] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/175495 [19:44:28] (03CR) 10BearND: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175494 (owner: 10BearND) [19:44:50] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175494 (owner: 10BearND) [19:46:42] dbrant: Okay, responded to your search email. :) [19:46:57] Deskana: thx! [19:49:34] dbrant: In a word, my response was "Yes". [19:49:41] Good catches! :) [20:02:20] (03CR) 10Brion VIBBER: [C: 032] "I do recommend changing the highlight color away from blue as it looks like links. :) Otherwise looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/175469 (owner: 10Mhurd) [20:16:29] 3MobileFrontend-Feature-requests: replace ≡ (hamburger menu) with W symbol for site drawer. - https://phabricator.wikimedia.org/T65978#781832 (10Nemo_bis) >>! In T65978#682067, @Jaredzimmerman-WMF wrote: > I just want to balance (swap a single asset on a subset of sites) with (make a configurable system where si... [20:19:40] 3MobileFrontend-Feature-requests: replace ≡ (hamburger menu) with W symbol for site drawer. - https://phabricator.wikimedia.org/T65978#781835 (10Jdlrobson) [20:28:18] https://etherpad.wikimedia.org/p/J [20:32:06] heading off to vacation guys. see you next wed! <3 [20:33:05] im going off too [20:33:08] bb guys [20:34:00] bbiab [20:34:04] bye jdlrobson joakino [21:02:00] (03CR) 10Hashar: "Bah sorry, I am not sure what I was looking at :D" [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [21:08:58] (03CR) 10Brion VIBBER: [C: 032] "one wrong message in vi fixed on twn" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/175495 (owner: 10BearND) [21:10:43] (03PS1) 10Brion VIBBER: quick fix to string (fixed already on twn) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/175542 [21:12:03] (03CR) 10Brion VIBBER: [C: 032] "selfmerge quickfix" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/175542 (owner: 10Brion VIBBER) [21:18:35] (03PS2) 10Kaldari: Fix race condition preventing edit button from being clickable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175478 (owner: 10Jdlrobson) [21:19:02] (03CR) 10Kaldari: [C: 032] "Tested" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175478 (owner: 10Jdlrobson) [21:20:28] (03PS1) 10Cmcmahon: QA: alphabetize common_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175544 [21:20:47] (03Merged) 10jenkins-bot: Fix race condition preventing edit button from being clickable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175478 (owner: 10Jdlrobson) [21:20:49] (03CR) 10Cmcmahon: [C: 032] QA: alphabetize common_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175544 (owner: 10Cmcmahon) [21:22:45] (03Merged) 10jenkins-bot: QA: alphabetize common_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175544 (owner: 10Cmcmahon) [21:25:16] (03PS1) 10BearND: Updated support libraries to 21.0.2 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175546 [21:25:42] (03CR) 10Kaldari: [C: 031] Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [21:27:07] (03CR) 10Florianschmidtwelzow: [C: 031] Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [21:36:50] Hah [21:36:52] I just walked past two conference rooms upstairs [21:36:54] In one there's a candidate in the office being interviewed by a remote engineer [21:36:58] In the other there's a candidate remote being interviewed by an engineer in the office [21:37:02] (03PS6) 10Robmoen: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [21:37:05] I wonder do they both know they're interviewing for the same job right next to each other? [21:38:19] (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [21:39:00] (03PS1) 10Cmcmahon: QA: refactor create_account_failure test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175548 [21:39:58] (03CR) 10Cmcmahon: [V: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175548 (owner: 10Cmcmahon) [21:47:16] (03PS5) 10Bmansurov: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) [21:51:07] (03CR) 10Dbrant: [C: 032] Material Design icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175490 (owner: 10BearND) [21:51:54] (03CR) 10Dbrant: [C: 032] Updated support libraries to 21.0.2 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175546 (owner: 10BearND) [21:52:05] (03PS1) 10Kaldari: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175552 (https://bugzilla.wikimedia.org/73255) [21:53:21] (03PS4) 10Dbrant: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) [21:53:36] (03PS2) 10MaxSem: [doesn't work] use wikidata.org in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171987 [21:53:40] (03CR) 10jenkins-bot: [V: 04-1] [doesn't work] use wikidata.org in debug mode [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/171987 (owner: 10MaxSem) [21:54:36] (03PS1) 10Kaldari: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175554 (https://bugzilla.wikimedia.org/73255) [21:58:34] (03PS6) 10Bmansurov: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) [22:02:39] (03CR) 10Kaldari: [C: 032] Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [22:03:35] (03Merged) 10jenkins-bot: Bump required MW version [extensions/MobileFrontend] (REL1_24) - 10https://gerrit.wikimedia.org/r/175122 (owner: 10MaxSem) [22:16:05] Maryana: we just enabled client-side banner choice in CentralNotice, just a heads-up in case you hear of oddness on mobile, such as banners appearing too often or not often enuf... [22:16:34] thanks for the heads up, awight [22:16:47] i doubt we'll hear about banners not appearing often enough ;) [22:18:14] lol seriously. dear wmf, please make banners 2 full pages and sticky forever [22:19:19] heh. actually, everybody i know IRL has been talking about the email campaign [22:19:25] not the banners [22:19:30] it's an interesting demographic shift [22:19:55] (IRL as opposed to WMF, which is clearly not real life) [22:20:43] ahh yeah. I did get a "Dear NULL" letter last week [22:22:06] (03CR) 10BearND: [C: 04-1] "Looks very nice. Just a minor nit: I think when the search bar is active it should have some padding on the right." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) (owner: 10Dbrant) [22:27:46] 3Wikipedia-App-Android-App: Android app: "Page issues" animation needs refinement - https://phabricator.wikimedia.org/T75505#782664 (10bearND) @Deskana is this still an issue? [22:36:48] (03CR) 10MaxSem: [C: 032] Tidy up WikiGrok\Api\ApiResponse unit tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173311 (owner: 10Phuedx) [22:36:50] (03CR) 10jenkins-bot: [V: 04-1] Tidy up WikiGrok\Api\ApiResponse unit tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173311 (owner: 10Phuedx) [22:44:14] (03CR) 10Bmansurov: [C: 04-1] "this change is already in master" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175126 (owner: 10Florianschmidtwelzow) [22:49:03] (03PS2) 10MaxSem: Tidy up WikiGrok\Api\ApiResponse unit tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173311 (owner: 10Phuedx) [22:49:52] kaldari|2, I made a rebase ^^^ because it conflicts with your https://gerrit.wikimedia.org/r/#/c/173333/ - can you verify that nothing got broken, please? [22:50:38] (03PS1) 10Dbrant: Tweak the space between the page title and description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175578 [22:50:38] ok [22:52:13] (03CR) 10jenkins-bot: [V: 04-1] Tweak the space between the page title and description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175578 (owner: 10Dbrant) [22:54:31] MaxSem: It looks OK, I'll test as soon as I'm finished review in the API stuff... [22:57:25] (03PS1) 10BearND: Updated squareup libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175588 [22:58:37] (03PS2) 10Dbrant: Tweak the space between the page title and description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175578 [22:59:51] bearND: ^ mind merging? (for vibha) [23:00:21] dbrant: looking... [23:03:15] (03CR) 10BearND: [C: 032] Tweak the space between the page title and description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175578 (owner: 10Dbrant) [23:03:37] (03Merged) 10jenkins-bot: Tweak the space between the page title and description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175578 (owner: 10Dbrant) [23:03:44] bearND: thx [23:03:56] MaxSem: Having a weird error with your API [23:04:46] dbrant: i'm going to make the new icons a bit lighter. Seem to be too black. [23:06:29] bearND: I was going to mention that. Prior to this, I added some opacity to the actual SVG. But maybe we can do setAlpha() in code, or in xml? up to you [23:08:00] (03PS1) 10MaxSem: @group WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175593 [23:11:52] (03PS3) 10MaxSem: Random page API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174889 [23:13:51] (03CR) 10Dbrant: [C: 032] Updated squareup libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175588 (owner: 10BearND) [23:20:06] 3Wikipedia-App-General-or-Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - https://phabricator.wikimedia.org/T70579#782841 (10Deskana) [23:22:11] (03PS5) 10Dbrant: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) [23:25:22] MaxSem: after updating core, I'm getting 500 (hphp_invoke). Do you know how I can fix it? [23:36:31] bmansurov, always update and reprovision vagrant [23:38:47] brion mhurd: Just cleaned up/prioritized Sprint 45 (Wild Turkey) with Deskana. Take a peek and see what you think when you have a mo: https://trello.com/b/intC6nWK/mobile-app-sprint-45-ios-wild-turkey [23:39:51] MaxSem: cool, it's working now. thanks [23:40:05] kristenlans: seems legit :) [23:44:39] MaxSem: when I try to edit a section, I get the following error from the backend. Can you help me fix it? https://gist.github.com/anonymous/e2a0fa2cf1c187ec4014 [23:45:27] someone accidentally your wikidata setup? [23:46:11] (03CR) 10Kaldari: [C: 032] Random page API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174889 (owner: 10MaxSem) [23:46:43] tfinc: emily said i’ll chat with corey after eric- she’ll book room [23:47:37] MaxSem: sorry what? [23:50:06] (03Merged) 10jenkins-bot: Random page API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/174889 (owner: 10MaxSem) [23:50:27] if you don't ned wikidata right now, you can disable it [23:50:44] otherwise, I'm afraid it's past midnight for its developers [23:58:50] MaxSem: wikidata role is not enabled [23:59:51] then how WD gets called?