[00:00:18] <grrrit-wm>	 (03PS1) 10BearND: Make toolbar icons lighter [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175608 
[00:00:46] <bmansurov>	 MaxSem: I'm not sure, maybe it's pulled by some other extension
[00:02:10] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Revert "Focus editor textarea" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175126 (owner: 10Florianschmidtwelzow)
[00:02:28] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175552 (https://bugzilla.wikimedia.org/73255) (owner: 10Kaldari)
[00:02:54] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175554 (https://bugzilla.wikimedia.org/73255) (owner: 10Kaldari)
[00:03:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Focus editor textarea" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175126 (owner: 10Florianschmidtwelzow)
[00:03:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175552 (https://bugzilla.wikimedia.org/73255) (owner: 10Kaldari)
[00:06:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reverting change I10c2cbfdfa5c6d74b98d7c45e1c060911a7f20b4 [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175554 (https://bugzilla.wikimedia.org/73255) (owner: 10Kaldari)
[00:09:13] <grrrit-wm>	 (03PS7) 10Robmoen: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[00:10:27] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] @group WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175593 (owner: 10MaxSem)
[00:10:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[00:10:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: @group WikiGrok [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175593 (owner: 10MaxSem)
[00:12:52] <kristenlans>	 Jerkins, meet phabricator
[00:12:52] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Tidy up WikiGrok\Api\ApiResponse unit tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173311 (owner: 10Phuedx)
[00:13:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tidy up WikiGrok\Api\ApiResponse unit tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/173311 (owner: 10Phuedx)
[00:21:21] * kristenlans soul feels pain as she updates our new sprint name
[00:21:46] <kristenlans>	 https://trello.com/b/KLV4nZEA/mobile-web-next-sprint-36-j
[00:23:57] <Maryana>	 kristenlans: moizsyed has helpfully suggested some trello backgrounds: https://www.google.com/search?site=&tbm=isch&source=hp&biw=1440&bih=771&q=justin+bieber+with+phone&oq=justin+bieber+with+phone&gs_l=img.3...1068.5565.0.5622.26.6.1.19.19.0.114.324.5j1.6.0....0...1ac.1.58.img..11.15.345.WBytWO6oWfU#tbm=isch&q=justin+bieber+with+phone&imgdii=_
[00:26:35] <grrrit-wm>	 (03PS5) 10Yurik: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[00:26:54] <kristenlans>	 Maryana: that is the stuff of nightmares
[00:29:43] <MaxSem>	 Maryana, https://trello.com/c/3dHzyrEB/22-3-new-campaigns-ui has a description from another dard:P
[00:29:48] <MaxSem>	 c/dard/card/
[00:30:00] <Maryana>	 MaxSem: sorry, will fix
[00:40:19] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Use icons.spinner to create loading icon in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174674 (https://bugzilla.wikimedia.org/73622) (owner: 10Florianschmidtwelzow)
[00:41:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Use icons.spinner to create loading icon in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174674 (https://bugzilla.wikimedia.org/73622) (owner: 10Florianschmidtwelzow)
[00:52:57] <grrrit-wm>	 (03PS1) 10Bmansurov: Consistently name taskType in WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175620 
[01:12:04] <grrrit-wm>	 (03PS1) 10BearND: Remove obsolete strings from translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175628 
[01:13:53] <bmansurov>	 Maryana: If multiple people use the same computer, will they have separate settings? https://trello.com/c/5YBQjB5d/7-2-make-sure-users-don-t-see-wikigrok-twice-on-same-article-after-they-have-answered-once
[01:14:17] <bmansurov>	 Maryana: I mean should I track users and pages? or just pages?
[01:14:22] <Maryana>	 well, 99% of people will be seeing this on a phone :)
[01:14:31] <bmansurov>	 so just pages?
[01:16:09] <grrrit-wm>	 (03PS6) 10Yurik: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[01:16:23] <yurikR>	 dr0ptp4kt, let me know ^
[01:16:52] <Maryana>	 bmansurov so what we want, ideally, from the user's perspective: i'm browsing wikipedia and notice wikigrok on the brad pitt article. i answer some questions about brad pitt and get a confirmation message. if i refresh the page, i don't want to see "help wikipedia" again
[01:17:02] <Maryana>	 or if i come back to that page again later on the same phone
[01:17:42] <Maryana>	 i don't care about the implementation details so long as that's what happens :) though it would be good if we could keep this generalizable so we can reuse it for logged out users in the future (so don't go off user id)
[01:19:53] <bmansurov>	 Maryana: So let's say you answered brad pitt question, and now I use your phone and login to wikipedia, to read about brad pitt, should I see wikigrok too? 
[01:20:32] <Maryana>	 no. let's just assume that user = device for now
[01:20:36] <bmansurov>	 ok
[01:21:57] <bmansurov>	 Maryana: well, that contradicts the first criterion of the card. Can you take a look at it?
[01:23:02] <Maryana>	 bmansurov: oh, i see what you mean.
[01:23:28] <Maryana>	 i just deleted it
[01:24:11] <bmansurov>	 cool
[01:28:51] <dr0ptp4kt>	 yurikR: i think i'll need to look at this with a fresh head tomorrow morning :)
[01:29:06] <yurikR>	 np
[01:29:10] <dr0ptp4kt>	 yurikR: looking like some good fixes, though
[01:29:21] <yurikR>	 naturally! :D
[01:29:46] <yurikR>	 let me know ) i'm not sure why you were using pop (at the end), vs reset
[01:57:50] <grrrit-wm>	 (03PS1) 10Bmansurov: WIP: Don't show WikiGrok twice on the same article after a user has answered once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 
[01:58:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Don't show WikiGrok twice on the same article after a user has answered once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov)
[02:03:37] <grrrit-wm>	 (03PS7) 10Yurik: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[02:03:50] <yurikR>	 dr0ptp4kt, ^
[02:04:03] <dr0ptp4kt>	 yurikR: heading out. will take a look tomorrow...thanks again!
[02:04:11] <yurikR>	 np
[02:09:57] <grrrit-wm>	 (03PS1) 10Kaldari: New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 
[02:13:53] <kaldari|2>	 Maryana: The editing bug on Beta Labs should be fixed now, so you should be able to sign off on some of those bug fixes. Lemme know if you have any issues.
[02:14:03] <Maryana>	 kk
[02:45:19] <grrrit-wm>	 (03PS3) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 
[02:48:03] <grrrit-wm>	 (03PS4) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 
[05:36:44] <wikibugs>	 3MobileFrontend-stable: Saving Icon isn't visible when save an edit - https://phabricator.wikimedia.org/T75622#783437 (10Florian) 5Open>3Resolved a:3Florian
[05:41:48] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Bmansurov: that's right. This is a backport. The branch wmf9 is the upcoming branch, which will be online on all wikipedias for 7 days sta" [extensions/MobileFrontend] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/175126 (owner: 10Florianschmidtwelzow)
[06:08:04] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "In addition to the missing right padding in SearchView, I also noticed that when the keyboard gets dismissed the SearchView expands, and t" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) (owner: 10Dbrant)
[06:49:23] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "Not getting any events. Sent you crash reports via email." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 (owner: 10Dbrant)
[07:14:21] <grrrit-wm>	 (03PS1) 10BearND: Set search tab text color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175666 
[07:49:46] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari)
[08:55:58] <wikibugs>	 3MobileFrontend-General-or-Unknown: cannot uncollapse on opera mobile 12 - https://phabricator.wikimedia.org/T74883#783680 (10fanto666) seems that all of pages mentioned above work here now
[11:05:12] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Pretty refactor :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[11:05:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[11:18:22] <grrrit-wm>	 (03PS6) 10Jhernandez: Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[11:20:33] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Rebased a minor non-interesting conflict" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[11:21:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Separate init code path for events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172903 (owner: 10Jdlrobson)
[14:42:04] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Remove obsolete strings from translations [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175628 (owner: 10BearND)
[14:45:00] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Make toolbar icons lighter [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175608 (owner: 10BearND)
[14:47:22] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Set search tab text color. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175666 (owner: 10BearND)
[14:49:58] <grrrit-wm>	 (03PS1) 10Anomie: Testing, ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175702 
[14:50:12] <grrrit-wm>	 (03Abandoned) 10Anomie: Testing, ignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175702 (owner: 10Anomie)
[15:03:45] <grrrit-wm>	 (03PS5) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 
[15:07:25] <grrrit-wm>	 (03CR) 10Dbrant: "Crash fixed. If you don't see events on stat1003, it means you're not one of the Chosen. To test the events, you can force "chosen" to tr" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 (owner: 10Dbrant)
[15:42:14] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] QA: refactor create_account_failure test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175548 (owner: 10Cmcmahon)
[15:43:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: refactor create_account_failure test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175548 (owner: 10Cmcmahon)
[16:04:02] <grrrit-wm>	 (03PS6) 10Dbrant: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) 
[16:04:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) (owner: 10Dbrant)
[16:04:46] <grrrit-wm>	 (03PS7) 10Dbrant: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) 
[16:10:24] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: alphabetize editor_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175715 
[16:10:57] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] QA: alphabetize editor_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175715 (owner: 10Cmcmahon)
[16:11:34] <grrrit-wm>	 (03PS8) 10Dbrant: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) 
[16:13:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: alphabetize editor_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175715 (owner: 10Cmcmahon)
[17:16:21] <grrrit-wm>	 (03PS1) 10Dbrant: Improve collapsed infobox formatting. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 
[17:21:05] <grrrit-wm>	 (03PS1) 10Dbrant: Honor HTML formatting in page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175751 
[17:45:17] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) (owner: 10Dbrant)
[17:45:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update the search button to be a text+image selector. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175224 (https://bugzilla.wikimedia.org/73576) (owner: 10Dbrant)
[17:52:01] <bearND>	 dbrant: just checking out full text search in EL. For initial full text result I get 12 but when I scroll down I get less than 12 multiple times. That's strange
[17:52:45] <dbrant>	 bearND: I think that's because the dual lists aren't matching up. (the issue we saw earlier)
[17:53:25] <bearND>	 dbrant: makes sense
[18:08:27] <grrrit-wm>	 (03PS6) 10BearND: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 (owner: 10Dbrant)
[18:08:34] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 (owner: 10Dbrant)
[18:09:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175459 (owner: 10Dbrant)
[18:13:16] <grrrit-wm>	 (03PS2) 10BearND: Honor HTML formatting in page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175751 (owner: 10Dbrant)
[18:13:22] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Honor HTML formatting in page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175751 (owner: 10Dbrant)
[18:13:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Honor HTML formatting in page title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175751 (owner: 10Dbrant)
[18:19:38] <grrrit-wm>	 (03PS2) 10BearND: Improve collapsed infobox formatting. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 (owner: 10Dbrant)
[18:25:02] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "I think it's removing a bit too much. On [[Jellyfish]] it skips "Scientific classification"." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 (owner: 10Dbrant)
[18:26:14] <grrrit-wm>	 (03PS1) 10Dbrant: Improve infobox/edit-pencil alignment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 
[18:26:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve infobox/edit-pencil alignment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 (owner: 10Dbrant)
[18:31:06] <grrrit-wm>	 (03PS2) 10Dbrant: Improve infobox/edit-pencil alignment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 
[18:32:36] <dr0ptp4kt>	 MaxSem: got a minute?
[18:38:35] <grrrit-wm>	 (03PS3) 10Dbrant: Improve collapsed infobox formatting. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 
[18:55:17] <grrrit-wm>	 (03PS2) 10Bmansurov: Don't show WikiGrok twice on the same article after a user has answered once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 
[19:01:18] <grrrit-wm>	 (03CR) 10Bmansurov: "According to Jon (with whom I agree), text changes should not be made in views, they should already be present in templates." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari)
[19:08:07] <grrrit-wm>	 (03PS1) 10Dbrant: Tweak page title spacing for Lollipop+ [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175781 
[19:12:39] <bmansurov>	 kaity: hey, is moiz around?
[19:26:23] <grrrit-wm>	 (03PS8) 10Robmoen: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[19:26:25] <grrrit-wm>	 (03PS1) 10Robmoen: WIP: menu widget for infobox params [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175788 
[19:27:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[19:28:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: menu widget for infobox params [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175788 (owner: 10Robmoen)
[19:32:58] <wikibugs>	 3Wikipedia-App-Android-App: Formula looks grabled on small screen devices and black theme - https://phabricator.wikimedia.org/T74250#785394 (10Dbrant) 5Open>3Resolved a:3Dbrant Fixed (or at least improved) by https://gerrit.wikimedia.org/r/173317
[20:00:59] <kaldari|2>	 greg-g: When is the last date before Christmas in which we can deploy config changes?
[20:03:04] <Deskana>	 dbrant: Hey!
[20:03:06] <Deskana>	 dbrant: Got a sec?
[20:03:11] <Deskana>	 dbrant: I'll just PM you, I'm about to go for lunch. :)
[20:05:53] <greg-g>	 kaldari|2: Dec 18th
[20:07:47] <grrrit-wm>	 (03PS8) 10Dr0ptp4kt: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 
[20:11:38] <dbrant>	 vbamba: bearND: either of you having issues with hangouts?
[20:15:44] <grrrit-wm>	 (03CR) 10Yurik: [C: 04-1] Redirect zero-rated users more nicely (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[20:17:05] <bearND>	 dbrant: no issues with hangout. wanna try again?
[20:18:22] <dbrant>	 bearND: it seems like all of google is down from my end. I can access everything else.
[20:24:06] <grrrit-wm>	 (03CR) 10BBlack: [C: 031] Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[20:24:47] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: sort steps properly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175800 
[20:30:08] <dbrant>	 bearND: vbamba: I still can't access anything related to google.
[20:30:44] <kaldari|2>	 greg-g: Do you have any time today to discuss our WIkiGrok plans for around the holidays, we're trying to figure out our best-case and worst-case plans for pusshing new tests out. Specifically, our options will depend on whether or not we can end tests automatically after the 18th or if that's a hard line for any feature changes whatsoever (even ending a test).
[20:31:22] <grrrit-wm>	 (03PS2) 10Cmcmahon: QA: sort steps properly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175800 
[20:31:23] <kaldari|2>	 greg-g: since I know we wanted to avoid automatic changes in the future
[20:31:42] <greg-g>	 you can end tests after the 18th, sure, just do it with a normal config change (and schedule it so it's known)
[20:31:43] <kaldari|2>	 greg-g: but we need to figure out what our options are
[20:31:51] <greg-g>	 if that works
[20:32:02] <kaldari|2>	 greg-g: OK, that makes sense
[20:32:23] <mhurd>	 Deskana: you around?
[20:33:03] <mhurd>	 dbrant: hey!
[20:33:13] <dbrant>	 yep!
[20:33:24] <mhurd>	 dbrant: time for a quick hangout?
[20:33:31] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance, hygiene" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175800 (owner: 10Cmcmahon)
[20:34:47] <dbrant>	 mhurd: I'm not able to access any google services for some reason... I can try it...
[20:35:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: sort steps properly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175800 (owner: 10Cmcmahon)
[20:38:01] <mhurd>	 brion: sry i was late - time for a quick hangout?
[20:38:37] <brion>	 moment
[20:47:24] <bmansurov>	 Maryana: hi, can you please help me get the 'W' svg icon on this card https://trello.com/c/JyehD2c6/11-3-wikigrok-error-state from designers? I wasn't able to get hold of them. Thanks.
[20:56:11] <grrrit-wm>	 (03PS9) 10Dr0ptp4kt: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 
[20:57:10] <dr0ptp4kt>	 yurikR: ^ removed todo from php file, added note to commit message
[20:57:57] <yurikR>	 dr0ptp4kt, oki, will merge it, and schedule the mobilelanding for depl today
[20:58:10] <dr0ptp4kt>	 yurikR: word. thanks!
[20:58:27] <grrrit-wm>	 (03PS1) 10Bmansurov: Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 
[20:59:22] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[21:01:29] <Maryana>	 bmansurov: you can use whatever we're using for the login form
[21:01:35] <bearND>	 dbrant: had to update the Android SDK to get the alpha build working again
[21:01:48] <bmansurov>	 Maryana: ok
[21:01:49] <dbrant>	 bearND: ah, right!
[21:03:06] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: WIP: update the VE edit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175854 
[21:03:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Redirect zero-rated users more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169210 (owner: 10Dr0ptp4kt)
[21:08:53] <jhobs>	 yurikR: hey, finally got wifi working. You wanted me to ping you?
[21:09:28] <yurikR>	 jhobs, hi, just wanted to checkin to see when you can start putting your stuff onto the portal
[21:09:46] <yurikR>	 we should move away from the old way of passing params
[21:10:46] <jhobs>	 yurikR: will do today. Meant to do it last week but got caught up with stuff
[21:16:51] <kaity>	 does anyone know whats happening with beta labs?
[21:19:36] <grrrit-wm>	 (03PS1) 10Dbrant: Update the Search funnel to have a session ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175857 
[21:23:20] <grrrit-wm>	 (03PS2) 10Bmansurov: Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 
[21:50:58] <bmansurov>	 kaldari|2: what do I need to install locally to get  mw.config.get( 'wgWikiGrokCampaigns' ) working?
[21:52:29] <kaldari|2>	 bmansurov: I just inserted test fake test data into my local db....
[21:53:34] <kaldari|2>	 bmansurov: Here's an example: INSERT INTO `my_wiki`.`wikigrok_questions` (`wgq_page` ,`wgq_campaign` ,`wgq_version` ,`wgq_random`,`wgq_data`) VALUES ('317', 'author', '1', '0.255882', 'a:2:{s:8:"property";s:4:"P106";s:9:"questions";a:1:{s:7:"Q482980";s:6:"author";}}');
[21:53:34] <kaldari|2>	  
[21:54:01] <bmansurov>	 kaldari|2: thanks
[21:54:03] <kaldari|2>	 You would need to replace 317 with a page ID for an actual page on your wiki
[21:54:10] <bmansurov>	 ok
[21:54:31] <brion>	 nil strikes again!
[21:54:49] <brion>	 just spent a half hour tracking down a bug cause something got called on a pointer before it was initialized
[21:54:59] <brion>	 objective-c Y U NO THROW NIL POINTER EXCEPTION
[21:58:42] <kaldari|2>	 bmansurov: actually, that probably won't work for mw.config.get( 'wgWikiGrokCampaigns' ), as I think that's still pulling from page_props... You'll still need to insert some data, but different data....
[21:59:26] <bmansurov>	 kaldari|2: ok, should I use the 'wiki' database? or any other? I'm in vagrant
[22:00:55] <kaldari|2>	 bmansurov: actually, I might be wrong... one sec, I need to check the latest code...
[22:04:03] <kaldari|2>	 bmansurov: Hmm, it looks like my first suggestion should work, but for some reason it isn't working for me locally.
[22:04:41] <bmansurov>	 kaldari|2: ok thanks, let me know if you get it working. I'll try to understand the code and see if I need to do anything else.
[22:09:22] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Update the Search funnel to have a session ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175857 (owner: 10Dbrant)
[22:10:11] <kaldari|2>	 bmansurov: Ah, it's because the page has to have a wikibase_item property....
[22:11:04] <bmansurov>	 kaldari|2: in the page table?
[22:11:14] <kaldari|2>	 page_props table
[22:11:28] <kaldari|2>	 bmansurov: I'm looking up what that should look like now
[22:11:39] <bmansurov>	 cool
[22:12:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update the Search funnel to have a session ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175857 (owner: 10Dbrant)
[22:14:17] <grrrit-wm>	 (03PS4) 10BearND: Improve collapsed infobox formatting. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 (owner: 10Dbrant)
[22:14:27] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Improve collapsed infobox formatting. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 (owner: 10Dbrant)
[22:14:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve collapsed infobox formatting. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175749 (owner: 10Dbrant)
[22:17:55] <kaldari|2>	 bmansurov: Try this...
[22:17:59] <kaldari|2>	 INSERT INTO `my_wiki`.`page_props` (`pp_page`,`pp_propname`,`pp_value`,`pp_sortkey`) VALUES ('258', 'wikibase_item', 'Q14540', NULL);
[22:18:18] <kaldari|2>	 but change 258 to the actual ID of the page on your local wiki where you'll be testing
[22:18:38] <kaldari|2>	 and make sure it matches the page ID in wikigrok_questions
[22:20:02] <kaldari|2>	 bmansurov: hmm, still isn't working for me...
[22:20:08] <bmansurov>	 kaldari|2: same here
[22:24:09] <bmansurov>	 kaldari|2: have you setup WikiGrokSlowCampaigns and WikiGrokFastCampaigns variables?
[22:24:15] <Deskana>	 dbrant: Can't see any of the data from my testing of that patch in the EventLogging DB. :(
[22:24:28] <Deskana>	 There's no table for our latest schema revision.
[22:24:43] <dbrant>	 Deskana: then you're not one of the Chosen.
[22:24:52] <Deskana>	 I set chosen to true.
[22:24:54] <kaldari|2>	 bmansurov: Yeah, I set up WikiGrokSlowCampaigns locally
[22:25:12] <kaldari|2>	 I think it's having trouble retrieving the page property for some reason...
[22:25:14] <Deskana>	 dbrant: And due to my new eventlogging log changes, I knew it sent. ;-)
[22:25:21] <Deskana>	 11-25 21:58:08.493    1434-1434/org.wikipedia.alpha D/Analytics﹕ SearchFunnel: Sending event, event_action = start
[22:25:26] <bmansurov>	 kaldari|2: ok
[22:25:58] <dbrant>	 Deskana: checking...
[22:28:15] <dbrant>	 Deskana: I can definitely see events coming into stat1003
[22:28:35] <Deskana>	 Interesting. Where did you look?
[22:29:09] <dbrant>	 Deskana: zsub vanadium.eqiad.wmnet:8600 | grep MobileWikiAppSearch
[22:29:11] <Deskana>	 It's possible I'm looking at some DB replica that has lag, I guess.
[22:29:37] <Deskana>	 If you're confident that they're going in, then I trust you more than I trust myself!
[22:31:04] <grrrit-wm>	 (03CR) 10BearND: Improve infobox/edit-pencil alignment. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 (owner: 10Dbrant)
[22:31:17] <dbrant>	 Deskana: well, I see them coming into stat1003 over the network. Whether they're actually being stored in the DB is a separate matter...
[22:34:27] <grrrit-wm>	 (03PS1) 10Robmoen: WIP: Banner image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 
[22:35:47] <rmoen>	 brb
[22:36:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Banner image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen)
[22:42:19] <kaldari|2>	 bmansurov: looks like it's because the parserOutput is cached on page save, so it will never have artificially inserted page properties (only page properties that are valid at save). So I guess you'll have to actually install a local installation of Wikidata to test it :(
[22:42:50] <bmansurov>	 kaldari|2: ok thanks for helping. 
[22:43:15] <kaldari|2>	 bmansurov: I'm goign to keep poking and see if I can come up with anything else
[22:43:50] <bmansurov>	 👍
[22:49:15] <grrrit-wm>	 (03PS1) 10Jhobs: Fix banner dismiss button [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/175881 
[22:49:27] <jhobs>	 dr0ptp4kt: ^
[22:49:40] <jhobs>	 will send an email too since yuri is offline
[23:03:50] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031] "Works on my rig. Yuri, please verify on your side and +2, if appropriate." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/175881 (owner: 10Jhobs)
[23:03:57] <dr0ptp4kt>	 ^ jhobs 
[23:04:04] <jhobs>	 thanks
[23:08:29] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing WikiGrokDebug code [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175888 
[23:11:10] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fixing WikiGrokDebug code [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175888 (owner: 10Kaldari)
[23:11:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing WikiGrokDebug code [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175888 (owner: 10Kaldari)
[23:11:54] <kaldari|2>	 bmansurov: I found a way to fake it without installing Wikidata. You'll need to update to the latest WikiGrok master, set $wgWikiGrokDebug = true; , and add ?wikidataid=<something> to the URL (in addition to making sure there is data in wikigrok_questions for that page).
[23:15:01] <bmansurov>	 kaldari|2: Argument 1 passed to WikiGrok\ConfirmationCampaign::isApplicableToPage() must be an instance of array, null given
[23:15:16] <bmansurov>	 kaldari|2: i'm provisioning so that may fix it
[23:17:06] <kaldari|2>	 bmansurov: Let me know if that doesn't fix it. I have it completely working locally now
[23:17:18] <bmansurov>	 kaldari|2: yeah, it didn't fix it
[23:17:58] <kaldari|2>	 bmansurov: Do you have any campaigns configured locally?
[23:18:13] <bmansurov>	 kaldari|2: I don't think so
[23:19:20] <bmansurov>	 kaldari|2: how do I check?
[23:19:36] <kaldari|2>	 bmansurov: Here's what I have in my LocalSettings: http://pastebin.com/QdtdbHfx
[23:20:05] <bmansurov>	 kaldari|2: oh I have those in the WikiGrok.php file
[23:20:30] <kristenlans>	 dbrant Deskana: have you decided what to do about https://trello.com/c/2qNcSuzc/20-5-make-a-native-component-underneath-the-webview-to-put-the-front-end-ui-for-suggestions-in
[23:20:40] <kaldari|2>	 bmansurov: That should work too (although it will be easier to maintain them in your LocalSettings)
[23:21:19] <kaldari|2>	 bmansurov: Also for testing purposes I would make sure you don't have any fast campaigns configured for now
[23:21:59] <bmansurov>	 kaldari|2: after adding your settings to my LocalSettings, I still see the same error. Is it maybe connected to the wikibase extension?
[23:22:22] <kaldari|2>	 bmansurov: Yeah, try turning off all Wikidata extensions temporarily
[23:25:28] <brion>	 ah, another bonehead error found. saved ids as “sectionId” then got surprised when they didn’t come back reading them as “id”
[23:25:39] <brion>	 is is why i write unit tests :D
[23:25:42] <brion>	 *this
[23:25:48] <bmansurov>	 kaldari|2: you're the man, it worked
[23:26:00] <mhurd>	 brion: :)
[23:26:34] <brion>	 hah now it’s reading the sections from disk but in wrong order. ok i can fix that i think
[23:26:50] <brion>	 10 does not come between 1 and 2, mr fancy computerpants
[23:26:57] <mhurd>	 bahaha
[23:28:20] <the_nobodies>	 brion, sort()? :P
[23:29:01] <brion>	 reading subdirectories out of filesystem they seem to come back lexically sorted per some dreadful string default yeah
[23:29:23] <brion>	 and i want them numerically ordered :D
[23:29:27] <brion>	 gotta do it myself i guess
[23:30:12] <mhurd>	 brion: “ORDER IN THE SORT!”
[23:30:15] <brion>	 haha
[23:37:22] <brion>	 ok let’s see if this loads sections properly now
[23:37:42] <brion>	 if it doesn’t i’m taking a break for coffee and video games anyway :)
[23:37:51] <brion>	 then back to the grind. it’s getting so close to working!
[23:39:00] <the_nobodies>	 YAY VIDEO GAMES!
[23:39:14] <kaldari|2>	 MaxSem: where did you clone your MediaWiki vagrant to? i.e. what path?
[23:39:19] <mhurd>	 brion: exciting :)
[23:39:28] <the_nobodies>	 wherever I felt like
[23:39:30] <brion>	 ok it’s close! it’s appending the section objects instead of the html but ….. hey that’s something
[23:39:34] <brion>	 ok one more quick fix
[23:40:07] <brion>	 *cough* NSString *filePath = [path stringByAppendingPathComponent:@"Section.plist"];
[23:40:14] <brion>	 ok that one’s just my fault, copy-paste error :D
[23:40:19] <kaldari|2>	 the_nobodies: Ah good, I'm cloning it to /dev/null ;)
[23:40:21] <mhurd>	 hehe
[23:41:20] <the_nobodies>	 brion, please don't post Objective-C into public channels - what if minors see it?
[23:41:27] <brion>	 lol
[23:41:41] <brion>	 better they learn it from us than on the streets
[23:41:49] <brion>	 or… are we the streets?
[23:42:10] <brion>	 ok now it’s dying in the url cache
[23:48:47] <brion>	 wooooo ok i got it to load an article
[23:48:56] <brion>	 it then crashes on the ToC but that’s an improvement :D
[23:49:13] <brion>	 lemme sync up, take a break, and continue in a bit
[23:56:30] <grrrit-wm>	 (03PS1) 10MaxSem: Look for random pages in both directions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/175894 
[23:57:48] <jhobs>	 dr0ptp4kt: vagrant's not loading devwiki after a recent git pull. Already tried vagrant destroy, reload, and disabling/re-enabling all roles, and a computer restart. Any suggestions before I wipe the directory and re-clone?