[00:00:08] jhobs: nah, i would probably just start over. btw, did you see that marxarelli and bd808 did a video on stuff? http://www.youtube.com/watch?v=I66xR-fq2O8 oh, hey, if you're going to use phpstorm with xdebug, make sure to enable the role 'zend'. i'm going to add that to our puppet config in the repo [00:06:12] dbrant: Okay, so, that search eventlogging schema is good to go live. Whatever problem with events not showing up was not on our end. [00:06:56] dbrant: Let's chat about it at the standup tomorrow. :) [00:07:08] Deskana: awesome! [00:07:18] dr0ptp4kt: if that's the tech talk from earlier today, i wanted to watch it but got sidetracked at home unfortunately. Thanks for the link! [00:09:29] jhobs: yeah, that's it. pretty nice. [01:59:53] kaldari|2: what's the correct prop for the 'album' claim? [02:00:04] kaldari|2: for 'author' it's occupation [02:00:19] bmansurov: instance of [02:00:26] ok [02:07:57] kaldari|2: do you also have entries in the wikigrok_questions table for actors and albums? [02:08:21] no, but I can make some for you... [02:08:28] kaldari|2: that would be awesome [02:08:38] bmansurov: lemme finish up one little thing first... [02:08:43] sure [02:17:04] (03PS1) 10BearND: ToC tweaks: always on ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175931 [02:22:41] (03PS2) 10Kaldari: New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 [02:23:23] bmansurov: OK, I'm going to generate them now... [02:23:29] cool [02:24:11] (03CR) 10jenkins-bot: [V: 04-1] New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [02:26:54] bmansurov: Here's one for an album.... [02:26:57] INSERT INTO `my_wiki`.`wikigrok_questions` ( `wgq_page` , `wgq_campaign` , `wgq_version` , `wgq_random`, `wgq_data` ) VALUES ( '456', 'album', '1', '0.73429', 'a:2:{s:8:"property";s:3:"P31";s:9:"questions";a:2:{s:7:"Q208569";s:12:"studio album";s:7:"Q209939";s:10:"live album";}}' ); [02:27:26] bmansurov: You'll want to change 456 to whatever local page ID to want to pretend is an album. [02:27:47] ok [02:29:29] bmansurov: Here's one for actor: [02:29:31] INSERT INTO `my_wiki`.`wikigrok_questions` ( `wgq_page` , `wgq_campaign` , `wgq_version` , `wgq_random`, `wgq_data` ) VALUES ( '999', 'actor', '1', '0.73429', 'a:2:{s:8:"property";s:4:"P106";s:9:"questions";a:2:{s:9:"Q10798782";s:16:"television actor";s:9:"Q10800557";s:10:"film actor";}}' ); [02:29:38] thanks, man [02:29:41] bmansurov: and change 999 to your actual page id [02:29:48] ok [02:29:53] bmansurov: OK, gotta run. You need anything else? [02:30:01] no, i'm good [02:30:04] cool [02:30:05] see you [02:31:40] (03PS1) 10Bmansurov: WIP: WikiGrok: show suggestions that are already on the page. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [02:33:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: WikiGrok: show suggestions that are already on the page. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [03:56:40] (03PS2) 10Robmoen: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 [03:58:14] (03CR) 10jenkins-bot: [V: 04-1] Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [03:58:54] (03PS3) 10Robmoen: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 [04:00:11] (03CR) 10jenkins-bot: [V: 04-1] Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [04:26:49] 3MobileFrontend-Feature-requests: MobileFrontend extension needs access to a notifications system for 'status' changes - https://phabricator.wikimedia.org/T34292#787260 (10Mattflaschen) [05:30:18] (03CR) 10Florianschmidtwelzow: Add header wikidata image in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [09:09:55] (03PS4) 10Robmoen: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 [09:11:17] (03CR) 10jenkins-bot: [V: 04-1] Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [09:15:48] hi! [10:03:54] 3Wikipedia-App-General-or-Unknown: Tracking: API issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#787654 (10Tobi_WMDE_SW) [15:34:14] o/ phuedx_ [16:04:54] (03CR) 10Dbrant: [C: 032] ToC tweaks: always on ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175931 (owner: 10BearND) [16:21:36] (03PS1) 10Dbrant: Fix certain links to sections within the current page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176001 (https://bugzilla.wikimedia.org/71745) [16:29:37] (03PS7) 10Jhernandez: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (https://bugzilla.wikimedia.org/73115) (owner: 10Jdlrobson) [16:43:02] (03PS5) 10Jhernandez: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [16:43:24] (03CR) 10Jhernandez: "Fixed linting" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [16:49:37] (03CR) 10Dbrant: "see reply" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 (owner: 10Dbrant) [17:01:51] (03PS3) 10BearND: Improve infobox/edit-pencil alignment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 (owner: 10Dbrant) [17:01:58] (03CR) 10BearND: [C: 032] Improve infobox/edit-pencil alignment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 (owner: 10Dbrant) [17:03:39] (03Merged) 10jenkins-bot: Improve infobox/edit-pencil alignment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175772 (owner: 10Dbrant) [17:49:55] (03CR) 10Cmcmahon: [C: 032] "merging after review" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175854 (owner: 10Cmcmahon) [17:51:18] (03Merged) 10jenkins-bot: QA: WIP: update the VE edit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175854 (owner: 10Cmcmahon) [17:53:37] (03CR) 10Jhernandez: [C: 031] "Looks good, except for the comment I've given you in the code, but still mergeable." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [18:18:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] "copy comments from PS3" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [18:30:58] (03PS1) 10Cmcmahon: QA: untangle editor test steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176017 [18:40:46] (03PS2) 10Cmcmahon: QA: untangle editor test steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176017 [18:43:28] (03PS3) 10Cmcmahon: QA: untangle editor test steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176017 [18:44:01] Deskana: your team broke my app! :) [18:44:11] matanya: Oh no! What did we do? [18:44:23] i'll openseveral bugs shortly [18:44:29] * dbrant perks ears up [18:44:30] mainly blank pages [18:44:32] (03PS4) 10Cmcmahon: QA: untangle editor test steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176017 [18:44:52] recent alpah [18:44:58] (03CR) 10Yurik: [C: 032] Fix banner dismiss button [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/175881 (owner: 10Jhobs) [18:45:21] it was perfect, the one before latest. [18:45:22] (03Merged) 10jenkins-bot: Fix banner dismiss button [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/175881 (owner: 10Jhobs) [18:46:19] * matanya rambels @ phab [18:50:54] (03PS1) 10Yurik: Fix JsonEncode/Decode, error detection [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/176023 [18:51:57] (03CR) 10Cmcmahon: [C: 032] "maintenance, refactoring" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176017 (owner: 10Cmcmahon) [18:54:36] Deskana: how tge hell do i drag and drop on a phone? [18:54:57] Deskana: just cut a testflight build [18:57:45] (03Merged) 10jenkins-bot: QA: untangle editor test steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176017 (owner: 10Cmcmahon) [19:03:09] matanya: Magic! [19:03:44] bash: magic!: command not found [19:05:53] (03PS2) 10Yurik: Fix "PHP Notice: Undefined offset: 1" bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173744 [19:07:42] (03CR) 10Dr0ptp4kt: [C: 032] Fix "PHP Notice: Undefined offset: 1" bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173744 (owner: 10Yurik) [19:08:11] (03Merged) 10jenkins-bot: Fix "PHP Notice: Undefined offset: 1" bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/173744 (owner: 10Yurik) [19:08:12] mhurd: Thanks! [19:08:28] matanya: Now's a good time to file bugs! We set some side in this sprint especially for bug fixing. :) [19:08:58] * dbrant twiddles thumbs eagerly [19:09:24] 3Wikipedia-App-Android-App: empty boxes on 26.11.2014 alpha - https://phabricator.wikimedia.org/T76060 (10Matanya) 3NEW p:3Triage [19:09:39] here, i went to the computer for this ^ [19:09:45] kristenlans: Would you like me to use my Expert Summarising Techniques™ to summarise that meeting? [19:10:21] Deskana, if you’re up for it, that would be great :-) I jotted down the takeaways in teh etherpad [19:10:31] kristenlans: Cool. I'll do that in a few. [19:10:49] Deskana: thanks. You do truly have EST™ [19:16:50] MaxSem: I'm trying to create a page locally, but I get the following error: "wikibase-no-direct-editing". How can I bypass it? [19:16:51] 3Wikipedia-App-Android-App: RTL broke on 26.11 alpha - https://phabricator.wikimedia.org/T76066#788992 (10Matanya) [19:16:54] Kristen|Away [19:17:04] Deskana: this too [19:17:36] bmansurov, there are special pages for that, see Special:SpecialPages [19:17:41] matanya: rule #1 on he.wiki: put every bit of conent in a ! [19:17:57] (03CR) 10Dr0ptp4kt: [C: 032] "@yurik confirmed working on his rig." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/176023 (owner: 10Yurik) [19:17:57] bb [19:18:20] (03Merged) 10jenkins-bot: Fix JsonEncode/Decode, error detection [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/176023 (owner: 10Yurik) [19:18:36] dbrant: rule #2 don't break what worked yesterday :P [19:19:33] MaxSem: special pages for creating a new page? [19:19:41] on wikidata [19:20:35] dbrant: I think the first is related to your fix for the infoboxes. [19:20:39] dbrant: The second, I'm unsure about. [19:20:47] MaxSem: I want to create a normal page, which is not related to wikidata. [19:20:47] I will channel my inner KPhab and create cards for these. [19:20:54] btw, mostly main page [19:20:55] where? [19:21:03] other pages looks mostly sane [19:21:06] MaxSem: /wiki/3 for example [19:21:09] Deskana: matanya: yes indeed; will look into [19:21:16] what wiki? [19:21:20] MaxSem: I can add text, but saving fails [19:21:30] what wiki? [19:21:41] MaxSem: my local wiki localhost:8080 [19:21:48] eh? [19:21:58] MaxSem: http://127.0.0.1:8080/wiki/3?debug=true#/editor/0 [19:22:11] 3Wikipedia-App-Android-App: empty boxes on 26.11.2014 alpha - https://phabricator.wikimedia.org/T76060#789018 (10Deskana) p:5Triage>3Normal Tracked here: https://trello.com/c/xehDOsce/40-empty-boxes-on-26-11-2014-alpha [19:22:20] matanya: Thanks for the reports. :) [19:22:39] sure, always at your service [19:22:59] I'm heading off [19:23:07] see you tomorrow :D fn [19:23:08] gn [19:23:14] and serioulsy how can i drag and drop on my phone? phab sucks on this front [19:23:28] bmansurov: Have you installed Wikibase in the main namespace? [19:23:37] bmansurov: Can you try editing Help:Test ? [19:23:40] matanya: are any other pages affected other than the main page? (you said "mostly") [19:23:48] 3Wikipedia-App-Android-App: RTL broke on 26.11 alpha - https://phabricator.wikimedia.org/T76066#789025 (10Deskana) [19:24:06] i have seen one with a template [19:24:20] but not sure which one, as history vanished [19:24:21] FlorianSW: I'm not sure about the namespace, but I was able to edit Help:Test [19:25:04] Deskana: wasn't the idea to get rid of trello ? [19:25:05] bmansurov: Yeah, then it seems you installed Wikibase (you're using vagrant, right?) and setup the main namspace to be an alias for Item: [19:25:20] matanya: In the long run, yeah. But Phabricator is missing a few things for us. [19:25:23] so you can not edit "normal" pages anymore with the "Edit" button ;) [19:25:30] matanya: We really like the live updating that Trello does. [19:25:32] bmansurov, MaxSem: ^ [19:25:40] i understand [19:25:41] FlorianSW: yes vagrant [19:25:51] FlorianSW: how do I reverse it? [19:26:23] bmansurov: I don't know, how vagrant works, but you must have a config file (or maybe in LocalSettings.php) with the settings for Wikibase [19:26:31] how did you even enable wikibase repo for the main wiki? [19:26:39] There you can change the namespace to be "Iteam" [19:26:55] MaxSem: I have $wgWikiGrokDebug = true; in LocalSettings.php [19:27:06] unrelated [19:27:54] MaxSem: hmm, I must have installed and removed it, but some things have remained in the db. I'll just recreate my environment [19:28:02] MaxSem, FlorianSW: thanks guys [19:28:18] bmansurov: wait :D [19:28:24] ok [19:28:37] that's not how it works [19:28:44] bmansurov: Check, if you still have installed Wikibase. if not, this can't be the problem ;) [19:28:52] MaxSem: +1 : [19:29:26] FlorianSW: there is no wikibase folder in the extensions folder, and the wikibase role is also not present [19:29:46] bmansurov: What does Special:Version say? [19:30:42] FlorianSW: a lot of wikibase related stuff in there: client, repository, etc [19:31:17] bmansurov: Then check your LocalSettings.php (or vagrant related) if you still have require_once Wikibase or related thing in it [19:31:53] Wikibase is installed with WikidataBuildResources in vagrant [19:33:45] FlorianSW: I can't find anything related to it in settings. But as MaxSem said, it seems to be installed in WikidataBuildResources, which I think is needed for WikiGrok [19:34:15] bmansurov: WikiGrok works against live wikidate, so no need to install Wikibase locally [19:34:29] * wikidata [19:34:46] FlorianSW: so removing WikidataBuildResources is safe? [19:34:55] bmansurov: jap ;) [19:35:18] FlorianSW: adios wikidatabuildresources then [19:35:43] bmansurov: and now you can edit the main namespace :) [19:36:31] FlorianSW: jap, worked. thanks [19:37:01] bmansurov: np :) you need Wikibase only locally, if you want to start developing with it :P [19:37:14] FlorianSW: i see [20:06:44] (03PS1) 10Dbrant: Don't move any tables/infoboxes on Main Page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176042 [20:15:18] MaxSem: do you know if something has changed within mobile frontend recently that hasn't hit beta labs that might affect mw.frontend.settings? [20:15:42] mw.mobileFrontend.settings* [20:18:20] 3Wikipedia-App-Android-App: empty boxes on 26.11.2014 alpha - https://phabricator.wikimedia.org/T76060#789158 (10Dbrant) a:3Dbrant patch: https://gerrit.wikimedia.org/r/176042 The patch disables the recently-added table transformations for the Main Page of any wiki. Disabling it only for Main pages seems suff... [20:19:35] 3Wikipedia-App-Android-App: RTL broke on 26.11 alpha - https://phabricator.wikimedia.org/T76066#789162 (10Dbrant) a:3Dbrant Will be fixed by the patch for T76060 https://gerrit.wikimedia.org/r/176042 [20:25:18] yurikR: jhobs i'm getting lunch. [20:25:49] dr0ptp4kt, we are vchating [20:36:27] does someone in MFE know of mw.mobileFrontend.settings changing to some other name? [20:36:52] (03PS6) 10Robmoen: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 [20:37:49] (03CR) 10Robmoen: Add header wikidata image in alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [20:37:56] (03CR) 10Robmoen: Add header wikidata image in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [20:41:53] (03PS1) 10Dbrant: Correctly style page title in ToC. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176056 [20:42:13] jhobs, merged changes get deployed to beta in minutes [20:42:52] MaxSem: it's actually not a beta problem. Did the method for getting user settings change from mw.mobileFrontend.settings. change recently? [20:43:52] I don't even know what mw.mobileFrontend.settings is:P [20:44:02] welp [20:44:40] It's located in mfe/javascripts/settings.js, I just don't know how to access it anymore [20:44:53] because it used to be just mw.mobileFrontend.settings, but that's undefined now [20:47:00] bmansurov: back to your wikibase problem. You tried to edit a page with MF, right? Did you get the error message as a toast with just a message key?! [20:47:27] FlorianSW: yes, just a general error message. I had to check the console to get the detailed info. [20:47:42] bmansurov: ah, ok :) thx [20:47:46] np [20:52:23] (03PS1) 10Dbrant: Keep toolbar shown when scrolling to a section programmatically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176060 [20:53:06] bmansurov, wanna have a hangout? [20:53:33] MaxSem: for what? My issue is resolved [20:53:47] ah, cool [20:53:52] thanks [20:55:54] (03PS1) 10Jhobs: Use settings module instead of variable [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/176061 [20:56:01] yurikR: ^f [20:56:05] ^ * [20:56:11] yurikR: should fix it [20:56:42] (03PS7) 10Robmoen: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 [20:57:05] jhobs, excellente ) [20:57:13] we should tell MFE not to do that again :D [20:58:04] yurikR: haha I'm sure it won't be the last time. There were probably deprecation warnings that I wasn't noticing. I'll try to keep a better lookout for those in the future and change our code proactively [20:58:21] (03PS1) 10Cmcmahon: QA: refactor issues test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176063 [20:59:06] (03CR) 10Cmcmahon: [C: 032] "refactor" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176063 (owner: 10Cmcmahon) [20:59:25] yurikR: once you've merged it i'll have to rebase the ooui-interstitial again [21:01:02] yurikR: I have to run out and do an errand, ping me on gchat if there are any issues and I'll respond from my phone [21:03:51] (03CR) 10Yurik: [C: 032] Use settings module instead of variable [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/176061 (owner: 10Jhobs) [21:14:51] (03PS3) 10Kaldari: New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 [21:15:56] (03PS4) 10Kaldari: New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 [21:17:11] Deskana: so, even though it would be just a cherry-pick on top of the production tag, I would prefer to have both my and Bernd's eyes on it when we push it out... [21:17:31] dbrant: Yeah, I think that's fine. Especially since the holiday is coming up. We can do it on Monday. [21:17:38] Deskana: yep! [21:19:47] olololo https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Search_in_Mobile_Version_of_Wikipedia_No_Longer_Works [21:21:44] (03Merged) 10jenkins-bot: QA: refactor issues test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176063 (owner: 10Cmcmahon) [21:21:47] (03Merged) 10jenkins-bot: Use settings module instead of variable [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/176061 (owner: 10Jhobs) [21:26:41] MaxSem, ok, so i guess we can't deploy much :( [21:27:05] the logging system is broken (it doesn't show any new events) [21:27:13] dr0ptp4kt, sorry [21:27:17] meant that for you [21:28:23] yurikR: cool. i'll make sure dfoy notifies the operator that the close button stuff had to be deferred until next week due to a logging component being on the fritz [21:28:58] (03CR) 10jenkins-bot: [V: 04-1] Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [21:29:42] dr0ptp4kt, yes, today deployment would not be safe [21:29:50] brb [21:30:53] (03CR) 10jenkins-bot: [V: 04-1] New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [21:41:48] (03CR) 10Florianschmidtwelzow: "This little inline comment and look at the npm output :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [21:42:48] (03PS13) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) [21:45:29] (03PS6) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users (Alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 [21:45:36] (03PS7) 10Florianschmidtwelzow: Backlog: Show Watchstar only for logged in users (Alpha) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170887 [21:46:08] (03Abandoned) 10Florianschmidtwelzow: WIP: Addition to "Make advanced wikitext that is not content gray" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157307 (owner: 10Florianschmidtwelzow) [22:01:15] dbrant|brb: Regarding this: https://trello.com/c/ECIYFJQU/39-search-suddenly-displays-no-results-if-you-view-paginated-results [22:01:43] dbrant|brb: Is there some hack we can do such that when there are no matched results between the two, then it just doesn't do anything, instead of overriding the view with the "no results" text? [22:04:16] dr0ptp4kt: is the video call still going on? [22:04:27] and/or is there one for the W0 Deployments meeting? [22:04:39] jhobs: no. we're going to scrap today's deployment and get it in monday. cc yurikR greg-g [22:04:59] dr0ptp4kt: ok, so the 2pm meeting has been cancelled/already resolved? [22:05:27] (03PS2) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions for author, actor, and album questions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [22:05:34] jhobs: yep. that's just a placeholder. no need to join a call or anything, in general [22:05:43] dr0ptp4kt: ah ok, gotcha [22:05:57] sorry for dropping out of the call like that, it's snowing out here so traffic was a bit hectic [22:07:21] Deskana: yep, i'll patch it [22:07:33] dbrant: Cheers [22:07:45] (03PS1) 10Cmcmahon: QA: untangle steps in language test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176151 [22:09:03] hey mobile team! [22:10:03] (03PS2) 10Cmcmahon: QA: untangle steps in language test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176151 [22:10:20] do you happen to know what is the entry point for the Mobile Web team? I will have an enquiry next week and not sure where to ask [22:10:38] list / person / phab project / trello, whatever works for me [22:16:08] (03PS3) 10Cmcmahon: QA: untangle steps in language test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176151 [22:16:10] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions for author, actor, and album questions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [22:18:47] (03PS4) 10Cmcmahon: QA: untangle steps in language test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176151 [22:29:16] hashar: I’d say whatever works for you. If it requires any actual engineering work, IMO Phab is best at this point. If it’s just a question, mobile-l. [22:29:42] (03CR) 10Cmcmahon: [C: 032] "refactoring" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176151 (owner: 10Cmcmahon) [22:29:43] kristenlans: I guess I will subscribe to the mobile list :-]  Thanks! [22:38:20] (03PS1) 10Dbrant: Ignore empty full-text results when using a continue offset. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176156 [22:46:42] (03Merged) 10jenkins-bot: QA: untangle steps in language test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176151 (owner: 10Cmcmahon) [22:53:16] 3Wikipedia-App-General-or-Unknown: Tracking: API issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#789629 (10Deskana) [23:05:30] is there any difference at all in MobileFrontend with regard to language selection between logged-in and anon users? [23:07:17] awjr: old-timey MF PM question maybe :-) [23:08:37] o_O [23:08:55] yeesh i have no idea [23:09:30] chrismcmahon: kaldari may know, otherwise maryana/jon robson are probably your best best [23:11:45] awjr: thanks. I am refactoring the MF browser tests, and I don't see any utility for https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/language_logged_in.feature given https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/language.feature [23:11:56] kaldari: hey, can you review some of my patches? thanks [23:13:29] 3MobileFrontend-stable: Opting into beta/alpha causes text to jump - https://phabricator.wikimedia.org/T74727#789704 (10matmarex) [23:15:47] bmansurov: In an all-day meeting :( [23:15:55] ok [23:17:22] (03PS1) 10Cmcmahon: QA: remove language_logged_in.feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176170