[02:33:17] (03CR) 10Kaldari: [C: 04-1] WikiGrok: use local WikiGrok campaign suggestions for author, actor, and album questions. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [02:39:59] (03CR) 10Kaldari: "Per the acceptance criteria, we want to completely stop using Tool Labs, so go ahead and remove all the Tool Labs related code (including " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [07:24:39] 3MobileFrontend-General-or-Unknown: C/C++ wiki link page does not have a link while it does in desktop view - https://phabricator.wikimedia.org/T76274#795867 (10breadncup) [08:28:40] 3MobileFrontend-Feature-requests: [Tracking] Deprecate redlink removal (enable redlinks in stable) - https://phabricator.wikimedia.org/T71849#795920 (10Florian) [08:28:41] 3MobileFrontend-General-or-Unknown: C/C++ wiki link page does not have a link while it does in desktop view - https://phabricator.wikimedia.org/T76274#795919 (10Florian) [08:31:08] 3MobileFrontend-General-or-Unknown: C/C++ wiki link page does not have a link while it does in desktop view - https://phabricator.wikimedia.org/T76274#795924 (10Florian) Red links (links to pages, that doesn't exist) aren't supported in mobile view (except beta and alpha mode). We are working on to remove the re... [08:33:27] 3Wikipedia-App-iOS-App: Icons are too big for Tablet - https://phabricator.wikimedia.org/T74916#795932 (10Florian) The user sent us an example image: {F17682} [09:09:13] hullo [09:13:17] hey joakino [09:13:18] buenos dias [09:13:24] buenos dias! [09:13:36] hey phuedx!! how is everything [09:13:47] everything is okay thanks [09:13:56] i didn't really want to come back to work this morning [09:14:06] hos harry doing [09:14:08] but it's monday, so [09:14:13] he's really good [09:14:18] cute as a button [09:14:24] (you know that saying?) [09:14:42] yeah haha [09:14:48] awesome [09:15:02] is lisa recovering fine? [09:15:57] she's great! [09:16:01] so much better than expected [09:16:08] we have been /very/ lucky [09:16:12] in the strict sense [09:16:38] nothing went according to our plan, but we've ended up better than we would've done had everything gone according to plan [09:17:09] and now for 300 emails [09:19:22] phuedx: haha good luck [09:19:40] phuedx: remember to ignore the one about the christmas ads, at least for now [09:20:05] it is like 150 emails of long and elaborate responses, more like evening reading material than work stuff [09:23:23] hah [09:47:54] one email account done [09:52:23] (03CR) 10Jhernandez: [C: 032] Run jsduck through grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov) [09:56:32] hey phuedx how do you think we should coordinate code reviews to not step into each others? comments on the card? [09:56:45] card or patch [09:57:01] i used to write a note on jira tickets that i had in hand [09:57:11] in fact, i have a textexpander shortcut for it… [09:57:14] ;jr [09:57:24] -> "Reviewin’" [09:57:38] i guess trello cards [09:58:22] we just need to check if there is card for that patch (which we do to see if we have to move it forward or back) [09:58:25] or both [09:58:34] is trello a materialised view of phabricator? [09:58:37] (03Merged) 10jenkins-bot: Run jsduck through grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174851 (https://bugzilla.wikimedia.org/72718) (owner: 10Bmansurov) [09:58:58] phuedx: still not clear ,for now we are using phab as a bug backlog i think [10:01:18] phuedx: if we all do the commenting thing is going to get super spammy with the emails [10:01:28] gr [10:01:36] good point [10:01:40] 1 email left [10:01:43] boom! [10:01:55] and the epic about ads [10:01:56] obvs [10:02:15] 32 points in the code review column [10:02:22] * phuedx tuts [10:07:18] 3MobileFrontend-Hygiene: Build jsduck through Gruntfile - https://phabricator.wikimedia.org/T74718#796021 (10Florian) [10:18:08] (03PS5) 10Florianschmidtwelzow: Show talk button only, if page can have a talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 [10:19:26] (03CR) 10jenkins-bot: [V: 04-1] Show talk button only, if page can have a talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 (owner: 10Florianschmidtwelzow) [10:35:53] (03CR) 10Jhernandez: [C: 04-1] Don't show WikiGrok twice on the same article after a user has answered once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [10:57:40] (03CR) 10Jhernandez: [C: 032] Consistently name taskType in WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175620 (owner: 10Bmansurov) [10:59:14] (03Merged) 10jenkins-bot: Consistently name taskType in WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175620 (owner: 10Bmansurov) [11:02:44] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 (owner: 10Florianschmidtwelzow) [11:08:50] (03PS8) 10Jhernandez: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [11:37:58] (03CR) 10Phuedx: [C: 032] Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:38:17] phuedx: wow finally haha [11:38:20] phuedx: does it work for you? [11:38:24] no [11:38:29] i just +2 things [11:38:31] ;) [11:38:45] 😭 lol [11:39:16] (03CR) 10jenkins-bot: [V: 04-1] Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:39:17] will see if the other team members have issues [11:40:01] grr needs rebase [11:40:10] the coverage patch got merged before [11:42:39] vagrant is really missbehaving today... [11:42:51] 200% cpu, hanging up, not starting... [11:43:40] joakino: does that change close https://trello.com/b/KLV4nZEA/mobile-web-current-sprint-36-justin-bieber-never-say-never? [11:43:52] https://trello.com/c/qUXXVOqS/43-tools-make-should-use-grunt-when-possible [11:43:54] even [11:44:53] phuedx: yea [11:45:04] you want me to rebase? [11:45:08] or are you on it? [11:45:52] i'm with rob's patch now, i'll have a look later if you don't pick it up [11:45:59] phuedx: as you want [11:46:11] i want the code review column to be clear [11:46:15] i'll rebase it [11:46:41] 👍 me too, it was kind of like that on wednesday, i'm not sure why rob & baha didn't clear it [11:49:21] (03CR) 10Jhernandez: [C: 032] "Awesome sauce, testing url: http://localhost:8080/wiki/Albert_Einstein?wikidataid=Q937&mobileaction=alpha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [11:49:44] (03PS4) 10Phuedx: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:50:08] (03CR) 10Jhernandez: "Florian i've fixed that space and a linting error from jshint (which is why npm was failing)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [11:51:20] (03Merged) 10jenkins-bot: Add header wikidata image in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175874 (owner: 10Robmoen) [11:53:56] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:54:34] (03CR) 10jenkins-bot: [V: 04-1] Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:55:23] joakino: not seen that ^ before [11:55:26] phuedx: wtf, recheck that again, the log is fine ... [11:55:38] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [11:55:51] phuedx: yeah we added npm task to jenkins, so now it runs our npm test which in turn runs grunt test [11:56:09] so now linting happens on the server with jenkins too [11:57:36] joakino: still -2 [11:57:50] i need to go out – got a father's group to go to with george for lunch [11:57:53] will bbiab [12:29:25] phuedx: half an hour internet hiccup... fuck ono [12:30:05] joakino: phuedx: yeah we added npm task to jenkins, so now it runs our npm test which in turn runs grunt test [12:30:05] joakino: so now linting happens on the server with jenkins too [12:30:06] joakino: phuedx: it seems npm install has returned a non zero code but no errors on the log, that is very weird, lets see if rechecking does it [12:38:16] back again [12:51:12] (03CR) 10Jhernandez: [C: 04-1] Tools: Run make qunit (and qunitdebug) with grunt (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [12:56:59] (03PS5) 10Jhernandez: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 [12:58:15] (03CR) 10jenkins-bot: [V: 04-1] Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [12:58:57] (03CR) 10Jhernandez: "Changed the rebase a bit (there was something missing)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [13:01:00] halfak: i have a jenkins npm task failing on npm install here https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/167/console , really weirdly, it is failing from PS3 from https://gerrit.wikimedia.org/r/#/c/173025/ but those patchsets do not change package.json... [13:01:14] halfak: do you know where can I have a look at "12:58:14 npm ERR! /mnt/jenkins-workspace/workspace/mwext-MobileFrontend-npm/npm-debug.log" [13:01:30] or any idea of why this may be happening? there is no errors in the console [13:19:13] (03CR) 10Florianschmidtwelzow: "same on other PS, too: Ic2e1504d7c274d234863f590139840f5300294fb" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [13:23:36] halfak: Krinkle|detached jenkins npm task is failing on npm install in several patches https://gerrit.wikimedia.org/r/173025 and https://gerrit.wikimedia.org/r/#/c/173025/ , for example, it makes no sense. Here is the output https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/167/console , any ideas? [13:23:42] do you know where can I have a look at "12:58:14 npm ERR! /mnt/jenkins-workspace/workspace/mwext-MobileFrontend-npm/npm-debug.log" [13:23:51] maybe i can find some clues there [13:40:21] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App, Mobile-Apps: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#796247 (10Dbrant) [14:28:15] joakino: i think we've got to look at npm-debug.log [14:28:19] also, hey [14:36:25] joakino: it looks like the phantomjs install is borking [14:36:30] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/166/consoleText [16:13:46] phuedx: i've pinged timo and antoine before but no answer [16:13:56] i don't know what to do with that [16:14:16] joakino: btw halfak isn't antoine, hashar is ;) [16:14:32] oops [16:14:45] o/ [16:14:46] phuedx: messed up [16:14:49] also, huh? [16:14:54] hey halfak [16:14:55] nm [16:15:01] kk :) [16:15:10] joakino: join #wikimedia-qa and ping hashar [16:15:14] (he ain't here, obvs) [16:15:45] phuedx: he has been here at times [16:15:52] ill do that [16:16:19] phuedx: yep not there [16:16:45] phuedx: it is really weird that it gives an error after npm http 304 https://registry.npmjs.org/proto-list [16:16:54] i know :/ [16:17:05] are they all async requests? [16:17:06] phuedx: did you see it happened too to florian in another issue [16:17:14] no i didn't [16:17:15] hrrrm [16:17:28] jenkins npm task is failing on npm install in several patches https://gerrit.wikimedia.org/r/173025 and https://gerrit.wikimedia.org/r/#/c/173025/ , for example, it makes no sense. Here is the output https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/167/console , any ideas? [16:33:30] (03PS1) 10Cmcmahon: QA: update diff test for Rspec 3.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176680 [16:34:41] joakino: was that meant for the other channel? [16:34:46] (03CR) 10jenkins-bot: [V: 04-1] QA: update diff test for Rspec 3.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176680 (owner: 10Cmcmahon) [16:41:14] phuedx: no it was to give show you the other patch that has the same problem [16:41:56] i'm going to post there [16:46:13] phuedx: you are looking at (3) WikiGrok error state, right? [16:46:17] yup [16:50:25] 👍 [16:51:01] 3Wikidata, VisualEditor-TechnicalDebt, Project-Management, MobileFrontend-Hygiene: Create technical-debt project - https://phabricator.wikimedia.org/T75892#798554 (10JanZerebecki) [17:08:07] 3MobileFrontend-General-or-Unknown, Continuous-Integration: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354 (10Jhernandez) 3NEW p:3Triage [17:11:07] (03PS1) 10Florianschmidtwelzow: Log Nearby and Category button in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 [17:12:13] (03PS2) 10Florianschmidtwelzow: Log Nearby and Category button in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 [17:13:08] phuedx: FlorianSW is the npm task failing in every patch? [17:13:13] or just a few [17:13:43] joakino: idk, had just the one, let's wait for this one https://gerrit.wikimedia.org/r/176684 [17:14:11] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176248 (owner: 10Florianschmidtwelzow) [17:14:19] and for ^ this one [17:14:55] (03CR) 10BearND: [C: 032] Keep toolbar shown when scrolling to a section programmatically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176060 (owner: 10Dbrant) [17:16:14] joakino: it's working for this one https://gerrit.wikimedia.org/r/#/c/176248/ [17:16:29] FlorianSW: yeah i've seen that [17:16:32] wtf [17:16:45] but it seems this one will fail: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/170/console [17:17:36] (03Merged) 10jenkins-bot: Keep toolbar shown when scrolling to a section programmatically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176060 (owner: 10Dbrant) [17:17:37] i've opened this ticket to continuous integration, https://phabricator.wikimedia.org/T76354 , maybe they will help [17:17:41] FlorianSW: ^ [17:17:58] i hope :) [17:18:40] joakino: you added the same change twice :D [17:19:03] (03PS2) 10BearND: Correctly style page title in ToC. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176056 (owner: 10Dbrant) [17:19:10] (03CR) 10BearND: [C: 032] Correctly style page title in ToC. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176056 (owner: 10Dbrant) [17:19:11] FlorianSW: lol i did [17:19:38] (03Merged) 10jenkins-bot: Correctly style page title in ToC. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176056 (owner: 10Dbrant) [17:21:23] 3MobileFrontend-General-or-Unknown, Continuous-Integration: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#798612 (10Jhernandez) [17:22:05] FlorianSW: this seems to be stuck https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/170/console [17:22:09] :S [17:22:32] joakino: yeah, i see :/ i just sitting here and hope, that jenkins do something :D [17:23:51] FlorianSW: shouldn't be that long... 11 minutes already [17:24:23] (03PS2) 10BearND: Don't move any tables/infoboxes on Main Page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176042 (owner: 10Dbrant) [17:24:31] (03CR) 10BearND: [C: 032] Don't move any tables/infoboxes on Main Page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176042 (owner: 10Dbrant) [17:24:39] joakino: yeah, but we can't do anything here, i think (or can you stop jobs in jenkins?) I have no permission to that [17:24:51] (03Merged) 10jenkins-bot: Don't move any tables/infoboxes on Main Page(s). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176042 (owner: 10Dbrant) [17:27:12] (03CR) 10jenkins-bot: [V: 04-1] Log Nearby and Category button in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 (owner: 10Florianschmidtwelzow) [17:27:44] FlorianSW: i've stopped it and retriggered it [17:27:57] FlorianSW: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/172/console [17:27:58] joakino: ah, ok :) You was it :P [17:29:50] joakino: grrr, but it's still failing, idk why :( [17:31:41] FlorianSW: there is errors with a couple of node modules [17:32:08] yeah, in consoleFull, but why only in this changes? [17:33:41] FlorianSW: idk, in this one https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/167/console there are no errors... [17:34:15] FlorianSW: oh yeah in the full log [17:34:50] joakino: this one is clear: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/171/consoleFull [17:36:06] (03PS2) 10BearND: Fix certain links to sections within the current page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176001 (https://bugzilla.wikimedia.org/71745) (owner: 10Dbrant) [17:36:45] FlorianSW: they are failing when executed on integration-slave1006 [17:37:47] (03CR) 10BearND: [C: 032] Fix certain links to sections within the current page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176001 (https://bugzilla.wikimedia.org/71745) (owner: 10Dbrant) [17:38:28] joakino: hmm, then mybae a local problem :/ [17:38:38] 3MobileFrontend-General-or-Unknown, Continuous-Integration: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#798644 (10Jhernandez) It seems like npm tasks executed on integration-slave1006 fail for various reasons.... [17:39:07] FlorianSW: so annoying [17:39:38] (03Merged) 10jenkins-bot: Fix certain links to sections within the current page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176001 (https://bugzilla.wikimedia.org/71745) (owner: 10Dbrant) [17:39:46] joakino and no one online who can check this :( [17:41:13] yep [17:41:19] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [17:41:30] joakino: this change was executed on slave10006, too: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/121/consoleFull [17:41:36] let's see what happens [17:42:03] FlorianSW: wtf it worked [17:42:10] so it is not related to 1006 [17:42:25] joakino: last check: Nov 25 ;) [17:42:39] (03CR) 10jenkins-bot: [V: 04-1] Don't show WikiGrok twice on the same article after a user has answered once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [17:42:41] it's a while ago, let's wait for the actual recheck [17:42:42] oh yeah it is old [17:42:54] FlorianSW: 💩 [17:42:59] still failing [17:43:38] so it is definitely 1006 [17:45:20] 3MobileFrontend-General-or-Unknown, Continuous-Integration: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#798650 (10Florian) p:5Triage>3High It seems, that tests, triggered by integration-slave1006 fails. See... [17:45:59] it seems so :/ [17:47:17] Krinkle: ^ [17:47:49] 3Wikipedia-App-Android-App: No search results found when scrolling down in full text search results - https://phabricator.wikimedia.org/T76358#798655 (10bearND) [17:48:41] (03PS2) 10BearND: Ignore empty full-text results when using a continue offset. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176156 (owner: 10Dbrant) [17:49:14] (03PS3) 10BearND: Ignore empty full-text results when using a continue offset. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176156 (owner: 10Dbrant) [17:49:56] https://docs.google.com/file/d/0B2AI0-W7JoysakVVUUczSkYxUkUxVU1wWFFqRkk2MTY2RzZJ/edit [17:49:57] (03CR) 10Bmansurov: Don't show WikiGrok twice on the same article after a user has answered once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [17:50:01] I ran into this today [17:51:16] I figured someone in this channel would know more about it [17:52:24] Kreanir: do you mean WikiGrok itself, or the "Null" values? [17:52:28] (03CR) 10Jhernandez: [C: 032] Don't show WikiGrok twice on the same article after a user has answered once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [17:52:29] joakino: npm-debug will show nothing. Just look at the console output. [17:53:03] Krinkle: it is all npm tasks on slave1006 that are failing [17:53:07] the rest of the nodes work fine [17:53:35] (03CR) 10Bmansurov: Don't show WikiGrok twice on the same article after a user has answered once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [17:53:41] (03CR) 10BearND: [C: 032] Ignore empty full-text results when using a continue offset. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176156 (owner: 10Dbrant) [17:53:46] (03Merged) 10jenkins-bot: Don't show WikiGrok twice on the same article after a user has answered once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175639 (owner: 10Bmansurov) [17:53:55] Krenair: that is so weird. do you know how to file bugs? it would be great to have that screenshot along with the url and browser information [17:53:58] joakino: OK. I don't have time to debug this right now. I've wiped any caches on that node and should be fine. The first next build will be slower [17:54:07] (03Merged) 10jenkins-bot: Ignore empty full-text results when using a continue offset. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176156 (owner: 10Dbrant) [17:54:08] Krinkle: oki thanks [17:54:38] joakino: i will recheck one, ok? [17:54:42] FlorianSW: do you mind [17:54:42] joakino, ... yes, I do know how to file bugs thank you [17:54:43] awesome [17:54:55] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 (owner: 10Florianschmidtwelzow) [17:55:02] Krenair: thank you Krenair [17:55:15] Krenair: i don't think we are aware of anything like that [17:57:29] FlorianSW: it run OK but on 1008 [17:57:49] (03PS6) 10Krinkle: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [17:58:27] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 (owner: 10Florianschmidtwelzow) [17:58:28] joakino, ah you're the new Mobile Web engineer. Welcome to wikimedia :) [17:59:15] joakino: yeah, the goal is to be able to merge :P [17:59:52] joakino: 1006: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/177/consoleFull [18:00:02] (03PS1) 10Cmcmahon: QA: refactor references test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176694 [18:00:28] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176695 [18:01:46] FlorianSW: you are right... [18:02:19] (03PS1) 10BearND: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/176697 [18:03:58] Krenair: thanks :D, you are? [18:08:07] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176694 (owner: 10Cmcmahon) [18:08:08] joakino: Still failing I see? [18:08:15] joakino: Have you tried to reproduce it locally? [18:08:18] unhappily yes [18:08:29] Be sure to 'rm -rf node_modules' first. [18:08:58] I suspect one of your indirect dependencies has a version-range dependency on a page that made a new release that breaks something [18:09:36] (03Merged) 10jenkins-bot: QA: refactor references test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176694 (owner: 10Cmcmahon) [18:10:04] Krinkle: i've tried removing it, did nothing [18:10:05] Krinkle: going to try cleaning the cache too now [18:10:24] 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#798699 (10Tfinc) [18:11:19] 3MobileFrontend-stable: "Read in another language" gives desktop site's links - https://phabricator.wikimedia.org/T67047#798704 (10Tfinc) [18:14:05] 3MobileFrontend-alpha: Cancel button out of place - https://phabricator.wikimedia.org/T76257#798706 (10bmansurov) @Florian can you explain this more? The description doesn't seem to match the title. [18:14:34] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176695 (owner: 10BearND) [18:14:54] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176695 (owner: 10BearND) [18:15:54] joakino, I'm a volunteer working on various wikimedia technical things, including wikipedia android app feedback/crash reports for mobile [18:16:13] and some other non-mobile stuff as a WMF contractor [18:16:43] Krenair: awesome :D, nice to meet you [18:17:00] 3MobileFrontend-alpha: Cancel button out of place - https://phabricator.wikimedia.org/T76257#798708 (10Florian) @bmansurov: Oh, yeah :) See it seperatly, the problem is described with the title and: Example on every mediawiki.org page with e.g. a talk overlay (in alpha). {F17771} And this: I seems that i can'... [18:17:10] Maryana: Krenair found this today https://docs.google.com/file/d/0B2AI0-W7JoysakVVUUczSkYxUkUxVU1wWFFqRkk2MTY2RzZJ/edit [18:17:22] may be of interest since we are super focused on wikigroking [18:17:32] eek [18:17:55] thanks joakino - do you know if he filed a bug for that? [18:18:25] Maryana: i've asked him to, but i guess not yet, since we haven't seen it in the triage [18:18:30] I haven't yet [18:18:38] joakino: have you wiped node_modules or what is the status of jenkins?! :) [18:18:56] 3MobileFrontend-alpha: Cancel button out of place - https://phabricator.wikimedia.org/T76257#798713 (10bmansurov) @Florian Thanks for the info. Uploads may have been disabled on mobile. I'm not sure though. [18:19:18] FlorianSW: i'm on it, trying to reproduce it locally cleaning npm cache and node_modules, and Krinkle is going to have a look soon [18:19:19] joakino, project Mobile-Web right? or is it WikiGrok? [18:19:27] mobile-web [18:19:29] ok [18:19:35] Krenair: sorry mobile frontend general [18:20:05] thanks, Krenair! good catch [18:20:09] kristenlans: right? new bugs go to mobile frontend general? /cc Krenair [18:20:31] 3MobileFrontend-alpha: Cancel button out of place - https://phabricator.wikimedia.org/T76257#798717 (10Florian) @bmansurov: I find it out a day ago or so: -> https://www.mediawiki.org/wiki/Phabricator/Help#Uploading_file_attachments It's just more complicated at in bugzilla, because there is no link in the norm... [18:20:33] Krenair: we are still figuring out phabricator conventions [18:21:00] joakino krenair mobile web or mobile frontend general will work [18:21:12] 👍 [18:23:08] bmansurov: on which channel can i find yuvipanda? he was usually here but i haven't seen him for days [18:23:18] joakino: here [18:23:20] 3MobileFrontend-General-or-Unknown: 'Null' profession suggestion showing up in Wikigrok - https://phabricator.wikimedia.org/T76359 (10Krenair) 3NEW p:3Triage [18:23:26] done [18:23:35] joakino: I'm not sure why he's not showing up [18:24:03] joakino: I think you can join #wikimedia-labs and ping someone there [18:24:24] gonna give george a bath and get him to bed [18:24:36] thanks Krenair. Maryana, https://phabricator.wikimedia.org/T76359 [18:24:47] phuedx: bb! [18:24:49] bmansurov: i'm almost finished with the review of the error stuff [18:24:55] will make sure it's done before i go to bed [18:24:56] joakino: for yuvipanda see #wikimedia-operations he's online there :) [18:24:58] away! [18:25:02] phuedx: thanks [18:25:12] * [YuviPanda] #mediawiki-core #wikimedia-devtools #wikimedia-office #wikimedia-dev #phabricator #wikimedia-tech #wikimedia-operations +#wikimedia-staff #wikimedia-qa #mediawiki #wikimedia-labs [18:25:19] you can use /whois to see this [18:25:43] Maryana: So the jist of the "push wikigrok data to wikidata" spike is there are two options. One is pretty easy and straightforward, but doesn't work for anons. The other is complicated but would work for everyone. Thoughts? [18:25:58] thx Krenair FlorianSW [18:26:08] kaldari: hmm, looks like we'll have to go the complicated route [18:27:03] That's what I suspected [18:28:35] 3Continuous-Integration, MobileFrontend-General-or-Unknown: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#798742 (10Jhernandez) [18:28:50] oi kaldari, working on the AB data, I’m assuming that events logged past 20141121001221 are kosher (per data QA etherpad), is that a safe assumption? [18:29:43] 3Mobile-Apps, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#798745 (10bearND) [18:29:44] DarTar: Lemme look at etherpad again. What's the URL? [18:30:01] http://etherpad.wikimedia.org/p/WikiGrokTest1DataQA [18:30:21] kaldari: specifically line 48 [18:30:53] 3MobileFrontend-General-or-Unknown: 'Null' profession suggestion showing up in Wikigrok - https://phabricator.wikimedia.org/T76359#798746 (10Florian) Hmm, unhappily can't reproduce :( {F17773} [18:31:08] kaldari maryana maxsem bmansurov what was happening when I turned in to a robot during standup? [18:31:18] (03PS1) 10BearND: Remove extra quotes in string resource [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176699 [18:31:23] if this is fixed, I understand there is still one major issue that hasn’t been resolved or we can’t explain (L22) [18:31:28] kaldari: ^ [18:31:34] kristenlans: you kept saying 'already' [18:32:39] hahaha creepy [18:32:41] kristenlans: people were flocking from the office joining the techno party [18:32:47] at least I did [18:34:26] DarTar: lololol I think I have experienced that happening on a hangout before, adn it does sound like a techno party [18:35:47] phuedx: it seems like it can be verified now, https://gerrit.wikimedia.org/r/#/c/173025/6 merge if you want [18:36:03] joakino: what's your username on phabricator? [18:36:53] kristenlans: you mean technically? I'm not sure ;) [18:37:18] bmansurov: https://phabricator.wikimedia.org/p/Jhernandez/ [18:38:13] 3Wikipedia-App-Android-App: No search results found when scrolling down in full text search results - https://phabricator.wikimedia.org/T76358#798761 (10bearND) 5Open>3Resolved https://gerrit.wikimedia.org/r/#/c/176156/ [18:38:49] bmansurov: just curious what you guys were experiencing. You guys were LOLing pretty hard :D [18:39:00] 3Wikipedia-App-Android-App: page internal links don't work - https://phabricator.wikimedia.org/T73745#798764 (10bearND) 5Open>3Resolved a:3bearND https://gerrit.wikimedia.org/r/#/c/176001/ [18:39:23] kristenlans: it was LOL-worthy ;) [18:39:43] FlorianSW: joakino: I'm on it now. Seems like it might be an upstream bug. [18:39:48] joakino, we didn’t get to talk about this during triage, but I will make a card on the trello board: https://phabricator.wikimedia.org/T76354 [18:39:55] We're putting npm to the test quite strongly in this environment [18:40:38] 3Wikipedia-App-Android-App: empty boxes on 26.11.2014 alpha - https://phabricator.wikimedia.org/T76060#798788 (10bearND) [18:40:40] Krinkle: something to do with corrupted caches maybe? [18:41:01] 3Wikipedia-App-Android-App: RTL broke on 26.11 alpha - https://phabricator.wikimedia.org/T76066#798791 (10bearND) 5Open>3Resolved patch is merged [18:41:38] joakino: could be. I've just cleared another layer of caching. [18:41:44] joakino: Let me know if it still happens [18:42:13] kaldari: regarding pulling campaigns from the page: so we won't use wikidata at all? should I remove that too? it's related to tools labs suggestions. [18:42:16] Krinkle: oki [18:42:19] Krinkle: thanks [18:42:43] 3Continuous-Integration, MobileFrontend-General-or-Unknown: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#798794 (10Krinkle) [18:43:25] kristenlans: yep thank you [18:43:32] kristenlans: assing me to it [18:43:34] (03CR) 10Brion VIBBER: [C: 032] Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/176697 (owner: 10BearND) [18:44:00] kaldari: ignore my previous question [18:44:30] DarTar: The data issue was merged around the time you mention, although I'm not sure exactly when it was deployed. I think we deployed it the same day if I remember. [18:45:03] kaldari: I got that timestamp from the first successful event with the issue fixed [18:45:12] in production [18:45:24] 3Wikipedia-App-Android-App: Mechanical menu button opens side menu instead of options menu - https://phabricator.wikimedia.org/T76239#798821 (10Dbrant) 5Open>3Resolved a:3Dbrant We no longer override the behavior of the Menu button in the app. So, pressing the button will have the Android-default effect, w... [18:45:50] DarTar: That should be pretty safe then. There could be a few people with cached bad JS, but should be uncommon. [18:45:52] mhurd: https://trello.com/b/ylCAc6Rd/mobile-web-q2-backlog-2014-2015 [18:46:05] kaldari: so it was definitely fixed by then, I am more worried on the issue on L22 on which I haven’t heard back from you guys [18:46:24] 3Continuous-Integration, MobileFrontend-General-or-Unknown: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#798828 (10KLans_WMF) [18:46:53] kaldari: or was that fixed too? I can check using the same cutoff [18:47:05] Maryana: ooh i don’t have “add” permission or something… [18:47:12] DarTar: That was fixed too, around the same time I think [18:47:19] mhurd: hmm, lemme fix that [18:47:23] kaldari: ok, let me verify [18:47:36] DarTar: https://gerrit.wikimedia.org/r/#/c/174883/ [18:47:57] Maryana: yay! [18:47:58] mhurd: k, i added you to the board, so you should be able to add cards now :) [18:52:08] kaldari: it doesn’t look like the patch fixed it, can I come over for a quick check? [18:52:54] 3MobileFrontend-Hygiene: Issues using qunit with grunt - https://phabricator.wikimedia.org/T75670#798849 (10KLans_WMF) [18:53:02] i'm calling it for today, have a nice day people 🙈 [18:53:21] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 (owner: 10Florianschmidtwelzow) [18:53:36] DarTar: sure [18:56:09] 3MobileFrontend-alpha: Cancel button out of place - https://phabricator.wikimedia.org/T76257#798876 (10KLans_WMF) This bug is being tracked here: https://trello.com/c/PfScphlz/60-bug-t76257-cancel-button-out-of-place [18:56:18] 3MobileFrontend-alpha: Cancel button out of place - https://phabricator.wikimedia.org/T76257#798878 (10KLans_WMF) p:5Triage>3Normal [18:56:21] (03PS1) 10Cmcmahon: QA: remove pageactions_logged_in.feature and unique steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176707 [19:04:28] 3MobileFrontend-stable: Search field inaccessible on Opera Mini - https://phabricator.wikimedia.org/T75632#798896 (10KLans_WMF) p:5Triage>3Normal [19:15:19] 3MobileFrontend-beta: Beta mobile talk pages have a(n inactive) "speech-balloon" button - https://phabricator.wikimedia.org/T76190#798909 (10KLans_WMF) [19:15:31] 3MobileFrontend-beta: Beta mobile talk pages have a(n inactive) "speech-balloon" button - https://phabricator.wikimedia.org/T76190#798912 (10KLans_WMF) p:5Triage>3Normal [19:16:09] kaldari: mail to you and Maryana, or should I include anyone else? [19:16:19] DarTar: that works [19:16:25] kk [19:16:30] kaldari: i can wrangle all these up into a trello card for you if you want :) [19:16:35] so you can keep track of it all [19:18:45] brion: spare some c.r. cycles? :) [19:19:03] moment, paying bills \o/ [19:19:15] i’m so thankful i can do all this crap online cause THE FUTURE IS NOW though [19:19:17] Maryana: https://trello.com/c/KWG30on9/164-borders-turn-away-from-the-dark-side-use-the-force [19:19:23] haha [19:19:28] :D [19:19:31] but having to pay bills on my birthday every year sucks. FIRST OF THE MONTH BLUES [19:21:52] ok rent paid. that’s the important one :) [19:21:57] lemme pull out the codeeeee [19:24:19] brion: it’s a little weird the way i send the “window.onload” event, but i wanted to remember exactly which one was being responded to [19:29:57] mhurd: why use window.onload instead of DOMContentLoaded? i ask because the comment says it’s probably better to use DOMContentLoaded :D [19:30:01] DarTar, Maryana: It looks like the success-impression fix just hasn't reached en.wiki yet. I confirmed it's fixed on test.wiki, which means it should reach en.wiki on Wednesday, at which point the A/B will be over anyway :( [19:30:12] general problemw with window.onload is that it waits for things like images to load which may be very slow [19:30:14] d'oh [19:30:19] kaldari: ha [19:30:40] brion: ah i should update those comments… [19:31:06] kaldari: ok, I’ll stop here then [19:31:12] brion: some things are ok to do with DOMContentLoaded, but others need to wait for onload [19:31:31] such as? [19:31:34] DarTar: Yeah, I guess we'll just have to look at everything up to that for now [19:32:13] kaldari: we can still look at everything that happened up to a submit [19:32:52] DarTar: Let me know when you have any debugging info for the 'no-response-cannot-record-user-input' errors. I'm looking into that now. [19:32:54] since we have no reason to think that other parts of the funnel are broken. [19:33:29] kaldari: ok, I’ll do that first then [19:34:41] (03CR) 10Brion VIBBER: [C: 04-1] "Why using window.onload here? This could be veerrrrry slow on pages with images if the raw HTML is included directly in the loaded string." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/176491 (owner: 10Mhurd) [19:35:10] brion: will check... [19:36:01] 3MobileFrontend-stable: Search field inaccessible on Opera Mini - https://phabricator.wikimedia.org/T75632#798959 (10Tfinc) [19:43:37] yo [19:43:59] yo phuedx [19:44:30] two boys are asleep [19:47:23] (03CR) 10Phuedx: [C: 032] Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [19:47:29] let's see [19:47:35] * phuedx crosses fingers [19:49:30] bmansurov: The pre-reivew hook is totally broken for me: "make: grunt: No such file or directory" Any idea how to fix that (other than disabling it)? [19:49:31] 3Wikipedia-App-Android-App: Mechanical menu button opens side menu instead of options menu - https://phabricator.wikimedia.org/T76239#799014 (10KLans_WMF) [19:49:57] (03Merged) 10jenkins-bot: Tools: Run make qunit (and qunitdebug) with grunt [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173025 (owner: 10Jhernandez) [19:50:11] 3Mobile-Apps, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#799026 (10KLans_WMF) [19:50:38] 3Mobile-Apps, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#785483 (10KLans_WMF) Dan, discussed this at standup today, would like to get your two cents on priority. [19:51:28] kaldari: it may be related to jsdoc, try running 'grunt docs' first [19:51:50] kaldari: here is a card 4 u: https://trello.com/c/Pdq9dB3A/64-bug-wikigrok-issues [19:51:57] i guess we've already figured out the first one [19:58:43] bmansurov: Well, now I get completely different errors... [19:58:53] Custom script execution failed. [19:58:54] The following command failed with exit code 1 [19:58:54] ".git/hooks/pre-review" [19:59:17] Please fix the jsduck warnings before submitting this for code review: [19:59:29] and then a bunch of stuff totally unrelated to my changes [19:59:59] 3Wikipedia-App-iOS-App: App does not load any other section or article once you enter a text in the Language filter box which does not have any match - https://phabricator.wikimedia.org/T76380 (10Ryasmeen) 3NEW p:3Triage [20:00:22] kaldari: there are cards related to jsduck errors, I think those need to be fixed. for now I think you should disable pre-review maybe? [20:04:30] brion: amending… [20:07:25] whee [20:07:56] dbrant, bearND|food: Morning, gentlemen. [20:08:13] dbrant, bearND|food: Are we ready to do our cherrypicking? :) [20:08:34] Deskana: doing now!!!11 [20:09:00] Great! [20:17:57] (03PS2) 10Mhurd: Load article and edit preview html directly w/o javascript bridge. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/176491 [20:18:35] brion: ^ much better :) [20:18:39] \o/ [20:19:36] testing... [20:19:54] brion: btw i’ve proposed upstreaming those experimental css bits to mobile web: https://trello.com/c/KWG30on9/164-borders-turn-away-from-the-dark-side-use-the-force (maryanna, dan and moiz are onboard thus far) [20:20:59] nice [20:21:26] brion: the loading indicator goes away sooner now w/ DOMContentLoaded :) [20:21:36] yay [20:21:38] kaldari: did you get past your issue? [20:21:52] lemme pull out the link conditioner and see how it feels on fake edge :D [20:22:12] brion: oh god that’s never a good experience ;) [20:22:49] (03PS1) 10Deskana: Fix omission in the repository's copyright notice. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176730 [20:25:48] (03CR) 10Deskana: [C: 032] "zomg self merge" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176730 (owner: 10Deskana) [20:28:46] (03CR) 10Phuedx: [C: 04-1] "This didn't work for me until I tweaked the suggestion fetching code in WikiGrokDialog and WikiGrokDialogB to always show the dialog, e.g." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [20:29:46] Deskana: i like the tactic: innocuous opening line of a commit message [20:29:56] followed by "oh yeah, and change everything" [20:29:58] :D [20:30:24] Delete ALL the things! [20:30:28] We're starting from scratch. [20:30:35] haha [20:30:45] public class WikipediaApp { [20:30:58] public static void main(String [] args) { [20:30:59] return; [20:31:00] } [20:31:01] } [20:31:03] Done. [20:31:08] yup :) [20:31:14] ok good it waits a few seconds to load text but then shows stuff before images finish \o/ [20:31:22] on the new patch :D [20:31:27] brion: woohoo! [20:31:45] so far so good. i’ll test editing and then merge it if no troubles [20:31:50] then update my patches :D [20:33:42] brion: i feel bad about pulling the rug out from under you when you’re trying to do your refactor :( [20:34:07] brion: the freezing bug made me do it ;) [20:34:18] nah it’s not a huge change, there’ll be some merge conflicts but i can work it out :D [20:34:40] brion: cool :) it does simplify a couple things, so there’s that... [20:35:31] Deskana: you're missing a WikipediaAppBuilderFactoryImpl [20:35:40] sorry, couldn't resist [20:35:47] ;) [20:36:35] anywho, gotta go [20:37:23] my wife says it's my turn to change the nappy [20:37:26] * phuedx sighs [20:37:31] g'night folks [20:37:43] (03PS1) 10Kaldari: Hygiene: Just some comment fixes and additions to WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176733 [20:39:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Just some comment fixes and additions to WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176733 (owner: 10Kaldari) [20:40:25] (03PS2) 10Kaldari: Hygiene: Just some comment fixes and additions to WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176733 [20:40:31] (03PS1) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176735 [20:40:35] (03PS1) 10Dbrant: Update the Search funnel to have a session ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176736 [20:40:36] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176737 [20:40:37] (03CR) 10jenkins-bot: [V: 04-1] Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176735 (owner: 10Dbrant) [20:40:39] (03CR) 10jenkins-bot: [V: 04-1] Update the Search funnel to have a session ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176736 (owner: 10Dbrant) [20:40:41] (03CR) 10jenkins-bot: [V: 04-1] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176737 (owner: 10Dbrant) [20:41:20] wtf, that's not what I meant to do :D [20:41:35] dr0ptp4kt, is everything working as expected? [20:41:38] dbrant: what did you do? [20:41:59] (03PS3) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [20:42:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Just some comment fixes and additions to WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176733 (owner: 10Kaldari) [20:42:08] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [20:43:01] (03CR) 10Kaldari: [C: 032 V: 032] "Jenkins seems to be broken :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176733 (owner: 10Kaldari) [20:44:36] bearND: I checked out the remote branch that I created, then cherry-picked the changes onto it, then did "git review" without specifying the branch name :( [20:44:58] yurikR: it seems to be working on the m.wikipedia.org/ redirect [20:45:07] dbrant: ah, i see. you probably want to abandon those [20:45:14] right! [20:45:24] yurikR: you having any luck with the 'x' close box? [20:45:32] (03Abandoned) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176735 (owner: 10Dbrant) [20:45:40] dr0ptp4kt, seems to work ok in privacy mode [20:46:00] (03Abandoned) 10Dbrant: Update the Search funnel to have a session ID. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176736 (owner: 10Dbrant) [20:46:16] (03Abandoned) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176737 (owner: 10Dbrant) [20:46:18] (03PS4) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [20:46:29] dr0ptp4kt, at some point we might have to revisit it - it flashes [20:47:28] yurikR: yeah, can't be having that. let us remember to ask jeff at the standup tomorrow if he can repro and resolve on that. maybe it would make the wednesday deploy then. [20:47:36] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [20:47:53] dr0ptp4kt, oki [20:48:41] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [20:51:00] (03PS1) 10Dbrant: Implement Search event logging. [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176739 [20:51:03] (03PS1) 10Dbrant: Update the Search funnel to have a session ID. [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176740 [20:51:06] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176741 [20:51:48] dbrant: looks better [20:52:09] (03CR) 10Brion VIBBER: [C: 032] "Ok with using DOMLoaded it's still usable throttled to EDGE speeds (loads all the text in one blob and then loads up images bit by bit). Y" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/176491 (owner: 10Mhurd) [20:52:34] brion: woohoo! [20:52:51] brion: oh, hey, happy birthday!!!! [20:52:57] thx :D [20:53:00] :) [20:53:28] brion: next falafel’s on me :) [20:53:37] :DD [20:55:12] bearND: yep! so, do those need to be +2'd?... or does it not matter? [20:55:57] dbrant: yes, they should be +2'd, i think [20:56:39] dbrant: going to try the first one [20:56:51] (03CR) 10BearND: [C: 032] Implement Search event logging. [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176739 (owner: 10Dbrant) [20:57:11] (03Merged) 10jenkins-bot: Implement Search event logging. [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176739 (owner: 10Dbrant) [20:58:16] dbrant: looks good, i'll do the others as well [20:58:27] (03CR) 10BearND: [C: 032] Update the Search funnel to have a session ID. [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176740 (owner: 10Dbrant) [20:58:47] (03Merged) 10jenkins-bot: Update the Search funnel to have a session ID. [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176740 (owner: 10Dbrant) [20:58:58] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176741 (owner: 10Dbrant) [20:59:23] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] (r/2.0-r-2014-12-01) - 10https://gerrit.wikimedia.org/r/176741 (owner: 10Dbrant) [20:59:36] bearND: \o/ thx! we're good to go, then [20:59:42] just some final testing... [21:02:17] dbrant: after the meeting [21:11:53] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176707 (owner: 10Cmcmahon) [21:12:17] wheee, /me deletes some redundant code [21:14:57] (03Merged) 10jenkins-bot: QA: remove pageactions_logged_in.feature and unique steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176707 (owner: 10Cmcmahon) [21:20:11] (03CR) 10Cmcmahon: [C: 032] QA: update diff test for Rspec 3.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176680 (owner: 10Cmcmahon) [21:20:18] (03CR) 10jenkins-bot: [V: 04-1] QA: update diff test for Rspec 3.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176680 (owner: 10Cmcmahon) [21:29:44] (03PS1) 10Cmcmahon: QA: update diff test for rspec [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176794 [21:29:59] (03Abandoned) 10Cmcmahon: QA: update diff test for Rspec 3.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176680 (owner: 10Cmcmahon) [21:33:09] (03CR) 10Cmcmahon: [C: 032] "refactor" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176794 (owner: 10Cmcmahon) [21:34:22] (03Merged) 10jenkins-bot: QA: update diff test for rspec [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176794 (owner: 10Cmcmahon) [21:42:14] (03PS3) 10Bmansurov: Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 [21:56:53] (03PS1) 10Cmcmahon: QA: update for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176802 [21:58:03] (03CR) 10Cmcmahon: [C: 032] "straightforward refactor" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176802 (owner: 10Cmcmahon) [21:59:10] dbrant: did you take a pass on the JD ? [21:59:17] dbrant: not seeing any edits from you [22:01:11] (03Merged) 10jenkins-bot: QA: update for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176802 (owner: 10Cmcmahon) [22:29:05] (03PS1) 10Cmcmahon: QA: remove unused step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176813 [22:30:08] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176813 (owner: 10Cmcmahon) [22:31:23] (03Merged) 10jenkins-bot: QA: remove unused step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176813 (owner: 10Cmcmahon) [22:38:25] Deskana, so... what to do about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7988406 ? :) [22:41:20] general question for you MobileFolk. Do you think we will ever again allow file uploads via the mobile web interface? [22:45:14] (03PS1) 10Cmcmahon: QA: update pointless test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176820 [22:47:21] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176820 (owner: 10Cmcmahon) [22:48:57] (03Merged) 10jenkins-bot: QA: update pointless test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176820 (owner: 10Cmcmahon) [22:49:53] Deskana: my finger is on the trigger of the production update (with the 'what's new' text that you provided earlier). [22:52:01] (03PS1) 10Bmansurov: Hygiene: Fix overlay icon position in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176821 [22:52:54] (03PS2) 10Bmansurov: Hygiene: Fix overlay icon position in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176821 [22:53:57] * Deskana looks [22:54:23] dbrant: FIRE! [22:54:47] IT'S AWAY! [22:54:55] * Deskana waits for the bugs to come in. [23:15:39] (03PS1) 10Kaldari: Make sure tags aren't created with null labels in WikiGrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176826 [23:17:18] (03PS2) 10Kaldari: Make sure tags aren't created with null labels in WikiGrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176826 [23:18:47] (03PS1) 10Bmansurov: Make the upload button cursor a pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 [23:19:16] (03PS2) 10Bmansurov: Make the upload button cursor a pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 [23:20:28] (03PS3) 10Bmansurov: Make the upload button cursor a pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 [23:26:38] (03CR) 10Bmansurov: [C: 04-1] "You should add both 'nearby-button' and 'category-button' to https://meta.wikimedia.org/wiki/Schema_talk:MobileWebClickTracking" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 (owner: 10Florianschmidtwelzow) [23:28:58] (03PS1) 10Cmcmahon: QA: update watchstar test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176829 [23:30:57] (03CR) 10Bmansurov: [C: 032] Make sure tags aren't created with null labels in WikiGrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176826 (owner: 10Kaldari) [23:31:55] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176829 (owner: 10Cmcmahon) [23:32:44] (03Merged) 10jenkins-bot: Make sure tags aren't created with null labels in WikiGrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176826 (owner: 10Kaldari) [23:33:47] (03Merged) 10jenkins-bot: QA: update watchstar test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176829 (owner: 10Cmcmahon) [23:38:34] (03CR) 10Bmansurov: [C: 032] Show talk button only, if page can have a talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 (owner: 10Florianschmidtwelzow) [23:39:08] bearND: thank you very much for fixing the app and the new release [23:39:21] i'll report new issues tomorrow :) [23:39:42] (03Merged) 10jenkins-bot: Show talk button only, if page can have a talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176326 (owner: 10Florianschmidtwelzow) [23:42:22] (03CR) 10Bmansurov: [C: 032] Show license text in EditorOverlay only, if there is a license [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176248 (owner: 10Florianschmidtwelzow) [23:43:32] (03Merged) 10jenkins-bot: Show license text in EditorOverlay only, if there is a license [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176248 (owner: 10Florianschmidtwelzow) [23:43:53] (03CR) 10Bmansurov: [C: 032] Hygiene: Fix phpdoc errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176245 (owner: 10Florianschmidtwelzow) [23:45:05] (03Merged) 10jenkins-bot: Hygiene: Fix phpdoc errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176245 (owner: 10Florianschmidtwelzow) [23:51:46] (03CR) 10Bmansurov: [C: 032] New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [23:52:00] (03CR) 10jenkins-bot: [V: 04-1] New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [23:52:31] Maryana: the ios testflight build i cut earlier today has the experimental border styling stuff i showed you earlier if you want to play around with it. hopefully we can take it out of the app if mobile web integrates it upstream :) [23:52:53] ooh, yes, i'll check it out!