[00:02:20] (03PS1) 10Cmcmahon: QA: finish common_article_steps.rb refactor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176838 [00:05:49] (03CR) 10Cmcmahon: [C: 032] "refactor" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176838 (owner: 10Cmcmahon) [00:14:09] (03Merged) 10jenkins-bot: QA: finish common_article_steps.rb refactor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176838 (owner: 10Cmcmahon) [00:21:20] dbrant|bbl: hey have a few minutes to do quick hangout? [00:28:06] mhurd: yep! back now [00:28:17] yay! just a sec... [00:37:14] (03PS1) 10Kaldari: Fix grunt.initConfig so it uses MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176848 [00:44:31] (03PS7) 10Kaldari: New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 [00:44:55] (03CR) 10Kaldari: "Just rebased." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [00:45:48] bmansurov: I just rebased and tested https://gerrit.wikimedia.org/r/#/c/175644/ . Wanna +2 again? [00:45:58] kaldari|2: ok [00:46:12] (03CR) 10Bmansurov: [C: 032] New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [00:47:23] (03Merged) 10jenkins-bot: New WikiGrok campaigns UI (version B) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175644 (owner: 10Kaldari) [00:51:14] Maryana: http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?wikidataid=Q937&mobileaction=alpha with small screen [00:53:20] (03CR) 10MaxSem: [C: 032] Fix grunt.initConfig so it uses MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176848 (owner: 10Kaldari) [00:55:08] (03Merged) 10jenkins-bot: Fix grunt.initConfig so it uses MEDIAWIKI_URL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176848 (owner: 10Kaldari) [01:04:50] kaldari|2: do you know why I'm getting this error: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/7563/console ? [01:20:55] (03PS1) 10Dr0ptp4kt: Remove quote from Wikipedia Zero landing page [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/176860 [01:21:24] (03PS2) 10Dr0ptp4kt: Remove quote from Wikipedia Zero landing page [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/176860 [01:30:33] bmansurov: hmm, not sure. I'll take a look tomorrow. I need to finished reviewing that anyway. Was stuck in design review all afternoon :( [01:30:51] ok thanks [01:31:22] and I have to leave early to look at an apartment [03:42:06] (03PS1) 10Krinkle: Icon: Remove confusing '0' argument to '.children()' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176872 [03:42:34] (03PS2) 10Krinkle: Icon: Remove confusing '0' argument to '.children()' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176872 [03:43:25] (03CR) 10Krinkle: Hygiene: More icon abstraction (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [03:57:36] (03PS1) 10Krinkle: redlinks: Move contents instead of serialising/reparsing html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176873 [03:58:13] (03CR) 10Krinkle: "Done in I9d850fba0ecb7498d684c4416f873f31556ab229." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 (owner: 10Jdlrobson) [04:01:32] (03PS2) 10Krinkle: redlinks: Move contents instead of serialising/reparsing html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176873 [04:24:08] 3MobileFrontend-Hygiene, MobileFrontend-General-or-Unknown: Module 'mobile.editor.ve' has incompatible target 'desktop' - https://phabricator.wikimedia.org/T76435 (10Krinkle) 3NEW p:3Triage [04:26:04] 3MobileFrontend-Hygiene, MobileFrontend-General-or-Unknown: Missing autoload entries for DeviceDetection classes - https://phabricator.wikimedia.org/T76436 (10Krinkle) 3NEW p:3Triage [04:27:14] 3MobileFrontend-Hygiene: Issues using qunit with grunt - https://phabricator.wikimedia.org/T75670#800354 (10Krinkle) [05:33:29] (03CR) 10Florianschmidtwelzow: "I haven't tested it, but this fix only SearchOverlay?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176821 (owner: 10Bmansurov) [05:36:25] (03CR) 10Florianschmidtwelzow: "Before this get merged? :S" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 (owner: 10Florianschmidtwelzow) [05:40:43] (03CR) 10Florianschmidtwelzow: [C: 04-1] Make the upload button cursor a pointer (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 (owner: 10Bmansurov) [06:47:26] (03PS1) 10BearND: Fix ToC icon color in dark mode on 5.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176893 [06:47:28] (03PS1) 10BearND: Move adjustDrawableToTheme call to onCreateOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176894 [06:50:06] (03CR) 10jenkins-bot: [V: 04-1] Move adjustDrawableToTheme call to onCreateOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176894 (owner: 10BearND) [06:51:39] (03PS2) 10BearND: Move adjustDrawableToTheme call to onCreateOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176894 [07:04:10] (03PS1) 10Florianschmidtwelzow: Add missing Autoloadclasses entries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176895 [07:06:53] 3MobileFrontend-Hygiene, MobileFrontend-General-or-Unknown: Module 'mobile.editor.ve' has incompatible target 'desktop' - https://phabricator.wikimedia.org/T76435#800463 (10Florian) [07:09:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Yes, just SearchOverlay, you can see the problem on each overlay, so the fix should be in Overlay.less." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176821 (owner: 10Bmansurov) [09:22:08] good morning! [09:22:12] hi phuedx [09:48:50] 3MobileFrontend-beta: Beta mobile talk pages have a(n inactive) "speech-balloon" button - https://phabricator.wikimedia.org/T76190#800824 (10Florian) 5Open>3Resolved [09:56:53] 3MobileFrontend-General-or-Unknown: 'Null' profession suggestion showing up in Wikigrok - https://phabricator.wikimedia.org/T76359#800831 (10Florian) [09:57:23] hey joakino [09:57:57] hi! [10:01:46] 3MobileFrontend-alpha: Alpha: Spinner doesn't hide bell for notifications - https://phabricator.wikimedia.org/T75058#800853 (10Florian) 5Open>3Resolved a:3Florian See also: https://gerrit.wikimedia.org/r/172743/ [10:02:51] 3MobileFrontend-alpha: Alpha back button tap area of overlays is smaller - https://phabricator.wikimedia.org/T75535#800856 (10Florian) Can anyone test, too? :) [10:06:34] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#800859 (10Florian) I'm not sure where to show the indicators :) If we know this, this could be a gci2014 (is Mobile team participating gci?) [10:14:39] 3MobileFrontend-alpha: WikiGrok B: Cannot click 'Next' when I don't agree with any of the suggestions. - https://phabricator.wikimedia.org/T74795#800901 (10Florian) [10:17:02] 3MobileFrontend-alpha: Watchstar animation slightly off - https://phabricator.wikimedia.org/T75050#800905 (10Florian) 5Open>3Resolved a:3Florian [10:17:55] 3MobileFrontend-alpha: Alpha: Watchstar icons are smaller in alpha than in beta - https://phabricator.wikimedia.org/T75053#800907 (10Florian) 5Open>3Resolved a:3Florian [10:52:42] (03CR) 10Phuedx: [C: 04-1] "Nice! There's one error condition that isn't covered though: what happens when WikiDataApi#getClaims rejects?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [11:03:34] 3MobileFrontend-beta: If EventLogging fails when recording a WikiGrok response, the user is left with an eternal spinner - https://phabricator.wikimedia.org/T75343#801029 (10Florian) 5Open>3Resolved a:3Florian [11:05:28] 3MobileFrontend-Hygiene: Hygiene: Ajax loader on notifications icon should be a real Icon - https://phabricator.wikimedia.org/T75251#801034 (10Florian) 5Open>3Resolved This should be fixed with https://gerrit.wikimedia.org/r/172743/ [11:06:40] joakino: yt? [11:07:46] phuedx: whats that? [11:07:55] "you there?" [11:07:56] ;) [11:08:05] to which the answer is "yes", obvs :D [11:08:20] do you know of any articles in prod that have wgWikiGrokCampaigns? [11:09:10] phuedx: no idea, i was asking myself the same thing a few minutes ago [11:09:30] phuedx: those are the things that should be in the card description... 😫 [11:10:43] (03CR) 10Jhernandez: [C: 04-1] "I agree with florian, why can't we do it generic? If there are reasons, please tell us, it seems weird." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 (owner: 10Bmansurov) [11:11:09] hah! [11:11:15] joakino: i just looked at the same thing [11:11:22] florian needs to update trello ;) [11:11:33] 11 points in the -1 column [11:12:25] yeah [11:12:36] there is jon's stuff around [11:15:47] (03PS8) 10Phuedx: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [11:17:44] joakino: you on phabricator? [11:17:50] (03PS1) 10Florianschmidtwelzow: Indent editor in TalkSectionAddOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176916 [11:17:59] phuedx: yes [11:18:07] as joakino? [11:18:21] phuedx: nope, gerrit username, jhernandez [11:18:25] 3MobileFrontend-alpha: Table of contents icon in alpha is small and not aligned correctly - https://phabricator.wikimedia.org/T75115#801057 (10phuedx) [11:18:42] phuedx: btw do you know if I can change my wikimedia username to joakino somehow? [11:18:52] hernandez is not even my first surname [11:19:01] :/ [11:19:16] were you here when they did the sul migration? [11:19:23] phuedx: the ldap one, or where can I ask [11:19:37] phuedx: nope, don't know what that is [11:20:43] the ldap one? [11:20:45] i'm not sure [11:20:50] maybe office it? [11:22:36] phuedx: i'll ask around later thx [11:22:47] phuedx: whats up with phab [11:29:46] joakino: ? [11:30:14] phuedx: since yo asked for my phab user, do you need me to do something? [11:30:21] oh no [11:30:31] i was gonna mention you on a card, but it doesn't matter [11:30:46] oki! [11:35:45] (03PS1) 10Florianschmidtwelzow: Hygiene: Update MobileWebClickTracking to cover alpha links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176917 [11:36:34] (03CR) 10Jhernandez: [C: 032] "Screenshots in trello card" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175443 (owner: 10Jdlrobson) [11:39:16] (03Merged) 10jenkins-bot: Optimise non-js experience for Opera Mini [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175443 (owner: 10Jdlrobson) [11:41:37] (03PS2) 10Florianschmidtwelzow: Hygiene: Update MobileWebClickTracking to cover alpha links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176917 [11:42:51] phuedx: if you can have a look at this when you can, no rush https://trello.com/c/9bDtykVW [11:43:03] i think because the card has two faces everybody is ignoring it xd [11:43:28] joakino: i'm looking at that right now [11:43:42] 😸 awesmoe [11:44:14] hands cold, i can't type 😭 [12:31:14] breaking for lunch [12:34:06] phuedx: me too [12:59:05] back [13:06:40] there's nothing quite like fish finger sandwiches [13:06:43] with hot sauce [13:06:48] there's gotta be hot sauce [13:06:49] obvs [13:39:39] joakino: i've read that patch a couple of times now [13:39:46] it's a little complicated [13:39:51] i hate this icon migration [13:40:19] phuedx: it is a bit messy since we have to test stable/beta icons and alpha mw-icon icons [13:40:42] we should retro about the icon migration once it's done [13:47:14] yep [13:49:07] (03CR) 10Phuedx: [C: 04-1] "This breaks the collapsed TOC – it's super-collapsed! – in alpha/beta. There's also a missing margin-right on the TOC indicator icon eleme" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [14:28:34] (03CR) 10Dbrant: [C: 032] Remove extra quotes in string resource [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176699 (owner: 10BearND) [14:29:01] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#801426 (10Florian) [14:29:56] (03CR) 10Dbrant: [C: 032] Fix ToC icon color in dark mode on 5.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176893 (owner: 10BearND) [14:32:37] 3MobileFrontend-Feature-requests: Lots of background images not using data URI embedding - https://phabricator.wikimedia.org/T66101#801431 (10Florian) [14:59:15] (03CR) 10Dbrant: [C: 032] Move adjustDrawableToTheme call to onCreateOptionsMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176894 (owner: 10BearND) [15:27:43] 3Wikipedia-App-Android-App: android.view.WindowManager$BadTokenException: Unable to add window -- token is not valid; is your activity running? - https://phabricator.wikimedia.org/T73299#801484 (10Dbrant) More recent ticket: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7995646 TODO... [15:29:08] gonna go make a cup of coffee [15:50:10] 3MobileFrontend-alpha: Pencil icon is preloaded locked - https://phabricator.wikimedia.org/T74851#801548 (10Florian) [15:50:36] 3MobileFrontend-alpha: Pencil icon is preloaded locked - https://phabricator.wikimedia.org/T74851#768366 (10Florian) [15:54:28] (03CR) 10Phuedx: [C: 04-1] "See inline for thoughts on the WikiGrokCampaign API and how it's used." (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [15:55:25] code review is done, je reckon [15:57:07] let's write some code! [16:10:42] (03PS1) 10Dbrant: [WIP] Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 [16:11:45] (03PS2) 10Dbrant: Tweak page title spacing for Lollipop+ [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175781 [16:12:35] (03PS1) 10Cmcmahon: QA: alphabetize common_article_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176938 [16:13:00] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176938 (owner: 10Cmcmahon) [16:15:06] (03Merged) 10jenkins-bot: QA: alphabetize common_article_steps.rb [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176938 (owner: 10Cmcmahon) [16:16:15] back [16:17:15] yo [16:24:25] joakino: i've only just noticed that qunit:cov always appends the debug=true query string parameter [16:24:29] is that correct? [16:24:35] yes [16:24:50] phuedx: it is impossible to get coverage with the minified files [16:25:20] of course [16:25:20] that is why qunit:all gives the option to set if you want debug or not, but qunit:cov doesn't [16:25:21] mibad [16:26:36] phuedx: the pull request with my change got merged in qunit-istambul so if he cuts a release we can move the dependency from my fork to the real deal with the proper version numbers on package.json [16:30:25] joakino: which pr? [16:30:30] * phuedx wasn't aware of a pr [16:31:01] phuedx: https://github.com/asciidisco/grunt-qunit-istanbul/pull/34 [16:33:25] ah [16:33:55] (03CR) 10Jhernandez: Make toggle icon standalone (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [16:34:42] phuedx: so is ^^ broken? can you provide screenshots or how to reproduce? i've tested it in chrome and firefox in stable and alpha and it seems to work fine [16:35:02] joakino: i'll double check and screenshot it [16:36:22] phuedx: thx! post what you find out in the trello card, i posted some screenshots there [16:36:41] (03CR) 10Phuedx: Make toggle icon standalone (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [16:36:57] phuedx: i'm mostly trying to get the css right, i don't know about the nested div thing on the tohtml, that's jon's stuff (he comes back tomorrow i think) [16:43:18] (03CR) 10Phuedx: "OK. In alpha it's super-collapsed. Seems fine in beta. See card for deetz." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [16:47:33] (03CR) 10Phuedx: "Yeah… so I cleared my cache – even though I have caching disabled – and after a few hard refreshes the super-collapsing stopped." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson) [16:47:46] joakino: ^ [16:47:59] ever feel like you have to fight the browser sometimes? [16:48:27] phuedx: yeah lots of times haha [16:48:45] so from a "does it work" pov, it's fine [16:49:11] but i find the patch quite confusing and need to read through another dozen times [16:49:15] phuedx: i had the same issues with that same patch, idk why, and having to test changing stable-beta-alpha made it pretty hard too [16:50:02] phuedx: any file in particular? [16:51:20] nope, just the change as a whole [16:53:45] (03PS1) 10Phuedx: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 [16:53:48] *just* [16:56:17] phuedx: yeah its a weird change +1 [17:04:48] (03CR) 10Jhernandez: [C: 04-1] "Besides the comment it looks good but i see that in SkinMinerva there are references to those variables, so we should probably remove thos" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 (owner: 10Phuedx) [17:06:06] (03PS1) 10Cmcmahon: QA: remove a FIXME by moving the step to the proper file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176947 [17:06:40] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176947 (owner: 10Cmcmahon) [17:08:38] (03Merged) 10jenkins-bot: QA: remove a FIXME by moving the step to the proper file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176947 (owner: 10Cmcmahon) [17:09:54] (03PS2) 10Phuedx: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 [17:11:03] (03CR) 10Phuedx: Enable WikiGrok A/B test using wgMFEnableWikiGrok (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 (owner: 10Phuedx) [17:12:17] (03CR) 10Phuedx: [C: 04-2] "We should figure out when this should be merged on the card." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 (owner: 10Phuedx) [17:33:54] (03PS1) 10Florianschmidtwelzow: Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 [17:35:08] (03CR) 10jenkins-bot: [V: 04-1] Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [17:39:03] (03PS2) 10Florianschmidtwelzow: Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 [17:40:32] (03CR) 10jenkins-bot: [V: 04-1] Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [17:41:57] (03PS3) 10Florianschmidtwelzow: Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 [17:44:11] (03CR) 10jenkins-bot: [V: 04-1] Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [17:44:36] (03PS4) 10Florianschmidtwelzow: Beta: Add a setting to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 [17:45:07] (03PS3) 10Bmansurov: Hygiene: Fix overlay icon position in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176821 [17:47:06] 3MobileFrontend-Feature-requests: Add font size adjustment feature to the mobile front end - https://phabricator.wikimedia.org/T50946#802024 (10Florian) [17:52:11] (03CR) 10Bmansurov: Make the upload button cursor a pointer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 (owner: 10Bmansurov) [17:52:40] (03PS4) 10Bmansurov: Make the upload button cursor a pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 [18:00:29] team, do we have anything to deploy? [18:02:50] MaxSem: no backports i know about :) [18:12:14] bmansurov: why is it the ::-webkit-file-upload-button in here? https://gerrit.wikimedia.org/r/#/c/176827/4/less/pageactions.less [18:12:34] joakino: you can't style hidden inputs in webkit otherwise [18:12:41] input:file [18:14:43] aha [18:17:21] joakino: actually, I should revert my last commit, the way you guys suggested, doesn't work firefox because the input:file is hidden [18:18:34] bmansurov: :S i see it visible [18:18:53] #ca-upload.enabled input { display: block; } [18:18:55] joakino: you see an image right? or do you see the input? [18:19:03] joakino: yeah but opacity: 0 [18:19:24] but still on top of the background, cursor pointer should work [18:20:22] bmansurov: if i change it from the devtools in firefox #ca-upload.enabled input with cursor pointer it works, like in your patch [18:21:06] joakino: ok cool [18:21:16] i'll just leave my last patch alone then [18:21:55] what i'm trying to find out is if we really need the webkit prefix for that, it seems to me that the input selector should work [18:25:18] bmansurov: inspecting in chrome i see this thingy http://i.imgur.com/EKM3GGb.png in between the picture icon and the next one, and when i try to focus it focuses the actual input.cloacke [18:26:31] joakino: which is bad? [18:26:51] bmansurov: i just dont understand wtf is going on..., anyway [18:26:58] bmansurov: the webkit prefix is necessary for that style to apply [18:27:05] yes [18:27:24] oh [18:27:47] i thought it'd be a opacity: 0 in .cloaked-element to visibility: hidden and cursor: pointer [18:28:01] however, i'd likely soon find out that i was wrong :) [18:29:32] (03PS5) 10Jhernandez: Make the upload button cursor a pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 (owner: 10Bmansurov) [18:30:08] gonna get george to bed [18:30:09] bmansurov: ^ i've added a comment and joined the cursor:pointer stuff, what do you think [18:30:19] phuedx: bb! [18:30:39] joakino: looks good, thanks [18:30:47] 👍 [18:38:49] (03CR) 10Jhernandez: [C: 032] "Added comment about webkit specific selector. Consulted baha for the review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 (owner: 10Bmansurov) [18:39:59] (03Merged) 10jenkins-bot: Make the upload button cursor a pointer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176827 (owner: 10Bmansurov) [18:44:57] well that was easy [18:52:47] dbrant: is https://gerrit.wikimedia.org/r/#/c/175781/ ready to go? [18:52:58] i'm off for the night [18:52:58] bearND: yep! [18:53:05] as in, i'm actually going to finish on time! [18:53:09] (george was super-tired) [18:53:12] g'night folks [18:53:27] phuedx: night [18:53:57] o/ [19:02:10] (03CR) 10BearND: [C: 032] Tweak page title spacing for Lollipop+ [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175781 (owner: 10Dbrant) [19:02:44] (03CR) 10Yurik: [C: 032] Remove quote from Wikipedia Zero landing page [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/176860 (owner: 10Dr0ptp4kt) [19:03:33] bb phuedx, i'm heading out too [19:03:41] have a nice day [19:04:38] (03Merged) 10jenkins-bot: Tweak page title spacing for Lollipop+ [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175781 (owner: 10Dbrant) [19:09:30] DarTar, Maryana: The first A/B test is officially over so feel free to analyze the data now :) [19:09:37] hehe [19:09:49] let's run the real one in stable now! [19:09:51] :D [19:09:58] soon! [19:11:24] kaldari: yup, the data analysis for test 1 is on my plate, for everything related to the test in stable (specifically, instrumentation changes or QA) I defer to leila, as I won’t be around Thursday-Friday [19:16:42] phuedx: I have some thoughts on https://gerrit.wikimedia.org/r/#/c/176945/ , but I want to push it out today if possible. If you're about to turn in, I'd be happy to work on it myself. Mainly I want to reorganize some of the init code in init.js so that it isn't checking wgMFEnableWikiGrok redundantly, and also so that it allows forcing WikiGrok to load for testing even if EnableWikiGrok is false. [19:17:12] phuedx: how much longer are you around today? [19:17:41] kaldari: phuedx has left I think [19:17:54] bmansurov: ah thanks :) [19:21:39] not raining atm, dashing to the office [19:25:46] (03PS3) 10Kaldari: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 (owner: 10Phuedx) [19:28:34] 3MobileFrontend-Feature-requests: Add font size adjustment feature to the mobile front end - https://phabricator.wikimedia.org/T50946#802198 (10Jaredzimmerman-WMF) [19:29:35] kaldari: do you want to check in w/me & dario real quick about a/b test plan? [19:29:41] we're meeting in r32 [19:30:29] Maryana: can't right now. Only 30 minutes left in this deploy window and trying to need to at least push out the A/B test start/end changes. [19:30:41] kk, will find you later [19:30:43] coming [19:38:50] Deskana: healthy amount of search events trickling into stat1003 :) [19:39:12] (03CR) 10Kaldari: [C: 032] Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 (owner: 10Phuedx) [19:41:15] awjr: got the invite [19:42:00] tfinc :D [19:42:15] i'm glad i emailed you separately rather than just showing up to a meeting with myself :p [19:46:31] (03Merged) 10jenkins-bot: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176945 (owner: 10Phuedx) [19:56:45] dbrant: Excellent. :) [19:58:18] (03PS1) 10Kaldari: Cherry-pick of: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177007 [20:07:16] 3Wikipedia-App-General-or-Unknown: Tracking: API issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#802262 (10Chad) [20:12:30] <^d> mhurd: prefix search continuation landed in master for core & cirrus today. should start making its way out with $whateverNextBranch is. [20:13:44] (03PS5) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [20:13:51] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [20:18:50] ^d: woohoo! that’s awesome!!! [20:23:27] (03PS6) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [20:25:21] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [20:32:24] (03CR) 10Kaldari: [C: 032] Cherry-pick of: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177007 (owner: 10Kaldari) [20:33:33] (03Merged) 10jenkins-bot: Cherry-pick of: Enable WikiGrok A/B test using wgMFEnableWikiGrok [extensions/MobileFrontend] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177007 (owner: 10Kaldari) [20:57:47] (03PS4) 10Bmansurov: Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 [20:59:27] (03CR) 10Bmansurov: "I think it doesn't matter, it's not a schema, just an information page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 (owner: 10Florianschmidtwelzow) [21:03:38] kaldari|2: I'm trying to figure out something in the browser tests and I'm stumped. Why does this page have a redlink http://en.m.wikipedia.beta.wmflabs.org/wiki/0.9942907553443305alklkh but this one does not? http://en.m.wikipedia.beta.wmflabs.org/wiki/NewPage1417553647 [21:03:57] (03CR) 10Bmansurov: [C: 032] Icon: Remove confusing '0' argument to '.children()' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176872 (owner: 10Krinkle) [21:03:58] kaldari|2: they look exactly the same in the non-mobile wikitext editor [21:08:26] (03PS1) 10Cmcmahon: QA: update one assertion for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177071 [21:09:29] (03Merged) 10jenkins-bot: Icon: Remove confusing '0' argument to '.children()' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176872 (owner: 10Krinkle) [21:11:48] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177071 (owner: 10Cmcmahon) [21:14:45] (03Merged) 10jenkins-bot: QA: update one assertion for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177071 (owner: 10Cmcmahon) [21:24:47] (03PS3) 10Jhobs: Update interstitial to use OOjs-UI [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 [21:25:54] yurikR1, dr0ptp4kt: interstital has just been rebased again after a few more MFE changes, ready for review ^ [21:26:05] jhobs, thx [21:28:33] (03PS1) 10Cmcmahon: QA: remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177079 [21:29:00] (03CR) 10Cmcmahon: [C: 032] "maintenance, remove unused code" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177079 (owner: 10Cmcmahon) [21:31:12] mhurd: She said... tomorrow! [21:31:13] (03Merged) 10jenkins-bot: QA: remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177079 (owner: 10Cmcmahon) [21:32:39] mhurd: And, in fact, it's already live on Wikivoyage so we could do testing in the API sandbox there. [21:33:01] Deskana: woohoo!!!!! [21:33:09] Deskana: tell her i said thanks!!! [21:33:45] Deskana: ooh any idea about the query we could use on sandbox? [21:35:02] prop=pageterms [21:41:43] dbrant: bearND1 ^ did you see we can use prop=pageterms tomorrow? [21:42:52] mhurd: what is that in reference to, again? [21:43:12] Wikidata descriptions from client wikis. :) [21:43:29] Deskana: mhurd: ah! well then, \o/ [21:43:30] It's live on some wikis (e.g. Wikivoyage) right now, and will be live on the Wikipedias tomorrow. [21:43:57] Mhurd: where do you see that? I was wondering when this gets deployed [21:44:29] bearND1: dan messaged one of wikidata folks and they said tomorrow :) [21:45:06] On enwiki? [21:45:17] Deskana: ^ i think so? [21:45:29] It's not live on the English Wikipedia yet. [21:45:32] It will be tomorrow. :) [21:45:57] I'm also looking forward to full-text search results with ordered "index" [21:46:06] But if you look on, for example, Wikivoyage, you can see it in the API sandbox: https://en.wikivoyage.org/wiki/Special:ApiSandbox [21:46:31] dbrant: ooh yes… i wonder what the eta on that is… [21:46:47] Deskana Mhurd: wow, that sounds awesome. I assume there will be some cards for this popping up soon, he he. [21:46:53] Yes! [21:46:56] There will! [21:47:31] Deskana: bearND1 can’t wait to delete the separate wikidata request code! [21:47:35] :) [21:52:08] BUUUUUURN [21:52:36] Let's just wait until it's live on enwiki then we can take a look in a bit more detail. [21:56:53] awjr: you didn't add a room to the invite [21:57:25] not adding a room and not adding me will almost guarantee i don't show up for your meetings [21:57:59] awjr: do think about SF staff when scheduling these things [21:58:05] how often do we get to say that :) [21:58:12] :p [21:58:28] tfinc: i actually did think of it but there werent any available [22:00:55] awjr: i see R35 available in the calendar [22:01:07] just snagged it [22:01:09] good! someone must've cancelled a mtg in there [22:03:41] (03PS1) 10Mhurd: Set flags to hide wikidata descriptions and full text search option. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177087 [22:06:42] Maryana: can you give me an example where you see "flash of unstyled content"? thanks https://trello.com/c/0kKBcmoD/2-2-hide-login-sign-up-in-hamburger-menu-for-non-js-users [22:06:50] Deskana: i’m thinking about pushing out another testflight build with the flags set to hide full text search and wikidata w notes explaining that both of these are coming soon, but undergoing refinement. i’ll text brion about readying a market build too. sound ok? [22:08:10] bmansurov: it happens sometimes on bad connections that menu items will load and then hide [22:08:21] Maryana: ok thanks [22:08:30] Maryana I think this should be moved back to ready for dev, right?: https://trello.com/c/WZO0tun5/23-8-alpha-page-styling-experiment-image-at-top [22:08:42] kristenlans: yes :) [22:09:18] So moved [22:09:41] There are seriously NO conference rooms available EVER. erph [22:16:01] (03PS1) 10Bmansurov: Hide some links from nonjs users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 [22:22:16] mhurd: Yes, thanks. :) [22:22:30] Deskana: cool! i messaged brion [22:33:23] kaldari|2: which article on beta labs can i test the new wikigrok campaigns on? :) [22:36:16] Maryana: None. The new campaigns can only be tested locally and on en.wiki due to how they are generated, but if you pick an article on Beta Labs, I can manually edit the database there to insert some claim suggestions in the format that the new campaigns would use. [22:36:51] is that gonna be a lot of work? [22:36:58] Maryana: No [22:37:12] ok :) umm, how about princess di? [22:37:18] actually, she's not an actor [22:37:20] hmm [22:37:25] do we have a tina fey article? [22:37:28] on beta labs [22:37:59] Maryana: No idear. Any actor, album, or writer will work. [22:42:34] kaldari|2: how about this lady? [[dido sotiriou]] [22:43:03] sure [23:00:25] (03CR) 10Kaldari: [C: 04-1] WikiGrok: use local WikiGrok campaign suggestions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [23:02:26] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [23:08:35] MaxSem: I'm no longer getting any results when running mw.config.get( 'wgWikiGrokCampaigns' ) on test articles on en.wiki for some reason [23:11:04] (03PS2) 10Mhurd: Set flags to hide wikidata descriptions and full text search option. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177087 [23:15:17] (03PS3) 10Mhurd: Set flags to hide wikidata descriptions and full text search option. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177087 [23:18:06] (03PS7) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [23:18:55] (03CR) 10Dr0ptp4kt: "It seems to be throwing a JavaScript error and not saving the settings for some reason: "TypeError: M.settings is undefined". See inline c" (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 (owner: 10Jhobs) [23:19:16] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [23:19:21] kaldari|2: I am talking to kevin about pruning the WG logs, 90-day pruning should apply to both Schema:MobileWebWikiGrok and Schema:MobileWebWikiGrokError, right? [23:19:41] DarTar: yes [23:20:04] kaldari|2: cool, filing a request (it’s something that ops takes care of) [23:43:51] (03PS2) 10Bmansurov: Hide some links from nonjs users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 [23:51:57] 3Wikipedia-App-Android-App: Android app: "Similar pages" animation needs refinement - https://phabricator.wikimedia.org/T75504#802756 (10Deskana) Actually I think this was a bug in the developer image of Lollipop that I was running; now that I'm running their production image, everything looks fine. [23:52:16] 3Wikipedia-App-Android-App: Android app: "Page issues" animation needs refinement - https://phabricator.wikimedia.org/T75505#802757 (10Deskana) Actually I think this was a bug in the developer image of Lollipop that I was running; now that I'm running their production image, everything looks fine. [23:54:33] 3MobileFrontend-General-or-Unknown: cannot edit a page through MobileFrontend despite being logged-in and having appropriate permissions - https://phabricator.wikimedia.org/T74877#802768 (10bmansurov)