[00:04:55] 3Wikipedia-App-Android-App: Android app: "Similar pages" animation needs refinement - https://phabricator.wikimedia.org/T75504#802786 (10Deskana) [00:05:03] 3Wikipedia-App-Android-App: Android app: "Page issues" animation needs refinement - https://phabricator.wikimedia.org/T75505#802790 (10Deskana) 5Open>3Resolved a:3Deskana WORKSFORME :-) [00:09:15] (03CR) 10Bmansurov: [C: 032] Indent editor in TalkSectionAddOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176916 (owner: 10Florianschmidtwelzow) [00:11:29] (03PS1) 10Yurik: Lua func fixes [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/177133 [00:12:31] (03Merged) 10jenkins-bot: Indent editor in TalkSectionAddOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176916 (owner: 10Florianschmidtwelzow) [00:13:32] mobile (650) [00:17:44] (03PS1) 10Robmoen: Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 [00:19:10] (03CR) 10jenkins-bot: [V: 04-1] Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [00:22:05] MaxSem, around? could you +2 https://gerrit.wikimedia.org/r/#/c/177133/1/includes/LuaLibrary.php adam is not around, and i would like to get it in [00:23:25] (03CR) 10Brion VIBBER: [C: 032] Set flags to hide wikidata descriptions and full text search option. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177087 (owner: 10Mhurd) [00:23:57] brion: yay! [00:25:16] (03PS1) 10Brion VIBBER: bump version to 4.0.6 / 4.0.6.0 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177137 [00:25:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] "wooooo" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177137 (owner: 10Brion VIBBER) [00:25:58] ok lemme see if i can build this properly :D [00:26:43] brion: build all the things! [00:26:47] mhurd: my firefox phone decided to crash and *not* automatically reboot for like the first time ever, so i didn’t get text messages until i removed and replaced the battery :P [00:26:52] yay for beta devices :D [00:26:58] brion: ah no worry! [00:27:32] brion: i’m finally starting on the lead image styling :) [00:27:40] squee! [00:28:09] brion: i didn’t realize how many fixes we’d made since the last market release until i put those release notes together for you [00:28:19] fair amount of improvements yea! [00:28:44] there we go, launched on the 3gs. slow phone is slow [00:29:08] ok tweak the code signing and archive… [00:29:13] yay! [00:33:43] ok le’t see if it takes it [00:34:03] wheee itunes connect [00:34:09] it’s like a roller coaster ride [00:34:15] you sit there while it ratches up the upload [00:34:26] and then either you go on a wild ride or it stops at the top and you all have to go home [00:34:48] ok looks like it took it :D [00:37:41] ok it’s still ‘processing’ the build but i pasted in the new release notes. will poke it again in a few minutes [00:41:30] brion: awesome! [00:41:38] (03CR) 10MaxSem: [C: 031] Lua func fixes [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/177133 (owner: 10Yurik) [00:41:38] i swear the only people left using WebObjects are Apple’s internal sites [00:41:41] and they’re SO FRAGILE [00:41:49] ‘ Your request could not be processed. For additional help, send an email to itunesconnect@apple.com. ‘ [00:41:54] (03CR) 10Yurik: [C: 032] Lua func fixes [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/177133 (owner: 10Yurik) [00:42:20] Maryana: You around? [00:42:25] (03Merged) 10jenkins-bot: Lua func fixes [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/177133 (owner: 10Yurik) [00:42:45] argh it ate our large app icon. wtf? i have to reupload it [00:43:04] haha wat! [00:43:26] kaldari|2: yes, but in a mtg [00:43:28] one sec [00:43:47] bmansurov: Almost ready to merge your new campaign stuff, but I have to confirm 2 of the acceptance criteria with Maryana that I'm not sure about... Sorry for the delays... [00:45:59] kaldari|2: np, thanks for reviewing it [00:46:29] Maryana: In https://trello.com/c/A9l1yHa0/4-5-alpha-beta-start-pulling-suggestions-from-mw-config-get-wgwikigrokcampaigns it says we want to have 'Other' tags for albums and actors. I don't remember discussing that originally. Thoughts? [00:47:23] friggin fraggin apple [00:49:54] kaldari|2: sorry, gimme 5min [00:50:00] ok [00:50:23] wtf the wmf design dropbox is either broken or my connection to it is broken. sighhhhh [00:51:00] bmansurov: While we're waiting, I also noticed that the indentation is a bit off in WikiGrokCampaigns.js, if you want to fix that [00:51:08] ok [00:52:23] (03PS8) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [00:52:51] (03CR) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [00:53:30] (03PS9) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [00:54:10] mhurd: do you have any of the extra design artwork handy? i need the one that looks like a flat ‘W’ tile with a shadow at the bottom, but no round corners applied [00:54:52] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [00:55:18] brion: oh yeah you can use the icon.svg in the AppIcon.appiconset folder i believe [00:55:28] ok lemme try that [00:56:35] p[erfect yeah [00:56:42] yay! [00:56:56] let’s see if inkscape behaves [00:57:31] for some reason inkscape on mac os x HATES multiple monitor setups [00:57:49] brion: some x11 funkitude? [00:58:15] yeah [00:58:56] brion: more than once i’ve just used the first google search results for “svg to png” for one-off conversions [00:58:58] i talked with some inkscape dev on irc about the possibility of a port using ‘native’ mac version of gtk+ but it’s apparently kinda flaky, and doing it right means using the new version which is still in migration [00:59:01] haha [00:59:12] sometimes i upload to a wiki and download the png from there ;) [00:59:23] that works too! [00:59:29] hehe [01:00:24] ahhhhhhhh now it says ‘images can’t contain alpha or transparencies' [01:00:28] seriously apple? [01:00:33] you can’t flatten a PNG image? [01:00:45] ok let’s convert it [01:01:58] …now the file is gone [01:02:02] arrrrrrrrrgh [01:02:25] bmansurov: You're gonna hate me, but I talked with Maryana and we're changing the acceptance criteria :P Last week we dicussed the UI with Moiz and decided to have a 'None of These' button, which basically makes the 'Other' tag not needed.... [01:02:30] i give up . computers suck today [01:02:39] bmansurov: But no one updated the acceptance criteria on that card :( [01:02:52] kaldari|2: ok, just give me a sec, i'll update the code [01:02:57] sorry bmansurov - feel free to direct your hatred to me, not kaldari [01:03:00] brion: u need a 512x512? [01:03:05] brion: Is this about the app submission? [01:03:11] Maryana: i hate you both equally lol [01:03:15] hehe [01:03:16] brion: The app is submitted to Apple, right? :) [01:03:18] Deskana: yes i need to update the icon :) [01:03:19] mhurd i found it [01:03:29] bmansurov: So we should just get rid of the 'Other' stuff in WikiGrokCampaigns.js and the tests. [01:03:37] yes [01:03:51] Deskana: last button i have to push is updating the damn icon [01:04:04] Hah [01:04:34] KHAAAAN... I mean, AAAAAAPPLE! [01:04:40] haha [01:04:46] aaaaaaand it’s “Waiting For Review" [01:04:46] \o/ [01:04:52] Cheers brion. :) [01:05:00] brion: woohoo! [01:05:00] apparently our icon had an alpha channel so the latest version no longer accepted it :D [01:05:05] even though it was perfectly opaque [01:05:08] ? weird! [01:05:20] the goalposts, they move :) [01:06:23] (03PS10) 10Bmansurov: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 [01:06:27] kaldari|2: ^ [01:06:56] testing... [01:07:53] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [01:10:38] brion: talk to me a bit about how the refactor is going [01:11:48] tfinc: mostly working, needs fixes for image caching (something not quite right there yet) and merge with latest updates [01:11:57] then hack in some nice data migration [01:12:40] what can mhurd help with so that we can have this wrapped up? my worry increases as this work continues without a clear end [01:13:19] mhurd can help with the data migration, we can check in on that tomorrow or thursday [01:13:28] excellent. lets do that [01:13:29] tfinc: brion sounds good! [01:13:33] great [01:13:38] let me know if i need to schedule anything [01:13:47] i'm all for this coming off of our plate brion and being done :D [01:13:57] :) [01:14:04] brion: you in the office tomorrow ? [01:14:54] arch stuff in the early afternoon but i can be around for the rest of the day yeah [01:14:58] brion: oh i added some comments near the top of URLCache.m about debugging and how the webview’s memory caching can make to look like it’s not working when it actually is and how to work around it [01:15:11] mhurd: thanks! [01:16:05] brion: yeah, let's powow about this in person tomorrow morning post standup [01:16:28] ok [01:17:30] i'll put a placeholder on the calendar [01:19:19] rmoen: you there? [01:19:58] rmoen: nevermind, will catch up with you on the trello card. gotta disconnect for a bit [01:27:45] (03PS1) 10BearND: Prevent NPE in ToCHandler.scrollToSection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177148 [01:30:20] (03PS11) 10Kaldari: WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [01:30:37] (03CR) 10Kaldari: [C: 032] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [01:30:50] bmansurov: Added some extra comments and +2ed [01:31:01] yay [01:31:01] \o/ [01:31:03] we'll see what Jenkins does with it [01:31:19] where can i test? :) [01:31:30] Maryana: It's not merged yet :) [01:31:37] i know. but when it is [01:31:45] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [01:31:51] boo jenkins [01:32:18] Maryana: You'll be able to test at http://en.m.wikipedia.beta.wmflabs.org/wiki/Wolf_City?wikidataid=Q4020646 [01:32:54] cool [01:33:01] haha, krautrock [01:33:03] nice :) [01:34:28] ok got a basic merge w/ latest updates, will tweak and fix after dinner :D [01:37:16] (03CR) 10Kaldari: [V: 032] WikiGrok: use local WikiGrok campaign suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175934 (owner: 10Bmansurov) [01:38:55] (03PS1) 10Kaldari: Making sure we can always test load WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177149 [01:39:44] bmansurov, Maryana: Since Jenkins is acting up, I force merged it :P [01:40:08] superuser [01:40:12] bmansurov: Can you do a quick review of this little patch for testing purposes: https://gerrit.wikimedia.org/r/#/c/177149/ [01:40:17] ok [01:40:37] bmansurov, Maryana: then we should be good to go for testing it on Beta Labs [01:41:16] (03CR) 10Bmansurov: [C: 032] Making sure we can always test load WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177149 (owner: 10Kaldari) [01:42:02] bmansurov: thanks. Let's see if Jenkins behaves [01:42:20] * Maryana slaps jenkins [01:42:26] (03CR) 10jenkins-bot: [V: 04-1] Making sure we can always test load WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177149 (owner: 10Kaldari) [01:42:30] damn [01:42:57] jenkins does not respond well to violence, apparently [01:43:01] * Maryana hugs jenkins [01:43:25] (03CR) 10Kaldari: [C: 032] Making sure we can always test load WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177149 (owner: 10Kaldari) [01:43:32] (03CR) 10Kaldari: [V: 032] Making sure we can always test load WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177149 (owner: 10Kaldari) [01:45:05] Maryana: Just make sure you never edit the Wolf City page or it will lose it's suggestions :P [01:45:15] nooo :( [01:45:23] we need to figure that bug out [01:46:54] Maryana: Yes, but it's a hard problem since the new campaign system requires being able to directly access the Wikidata database from the server, which you can't do from Beta Labs. We'll have to set up BetaData and populate it with all the claims from Wikidata [01:48:21] lol [01:48:33] betadata [01:58:16] Maryana: can you guys test? i don't see it in the link kaldari|2 gave [01:58:28] not seeing it, either. is it merged? [01:58:35] bmansurov: For some reason it's failing to load the dialog module [01:59:08] kaldari|2: that's what jenkins was complaining about maybe? [01:59:09] bmansurov: http://en.m.wikipedia.beta.wmflabs.org/wiki/Wolf_City?wikidataid=Q4020646&wikigrokversion=A triggers no-impression-cannot-load-interface [01:59:47] bmansurov: It works fine locally. Not sure what's going on. [02:00:22] that's really weird [02:05:46] Maryana: The experimental infobox stuff seems to be broken as well on Beta Labs, but works fine locally [02:05:59] huh. it was working ok a minute ago [02:06:00] kaldari|2: "Module mobile.wikigrok.api has failed dependencies" [02:06:00] Maryana: It's not throwing any errors though [02:06:31] bmansurov: where'd you find that? [02:06:45] i loaded the module in the console and caught the error [02:06:59] kaldari|2: mw.loader.using('mobile.wikigrok.dialog').fail(function(a, b, c) {console.log(a, b, c) }); [02:07:17] bmansurov: nice idea :) [02:09:21] bmansurov: ah, I see the problem, bad capitalization [02:09:30] where? [02:09:37] bmansurov: strange that it worked locally though! [02:09:45] javascripts/modules/wikigrok/wikiGrokCampaigns.js [02:10:28] kaldari|2: what line? [02:10:37] bmansurov: 943 in Resources.php [02:10:40] ok [02:10:51] err 944 actually :) [02:11:14] kaldari|2: it's supposed to be small case [02:11:16] lower case [02:11:25] because you can't create new objects with it [02:11:30] we should change the file name instead [02:11:34] bmansurov: sure [02:11:39] i'll do so [02:13:49] kaldari|2: why doesn't git recognize filename change, do you know? [02:13:57] can you do it on your end? [02:14:10] i'll try [02:14:14] thanks [02:19:07] bmansurov: got it... [02:19:38] ok, can't wait to see it live [02:20:19] (03PS1) 10Kaldari: Fixing case of wikiGrokCampaigns.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177155 [02:20:46] bmansurov: wanna +2? [02:21:06] (03CR) 10Bmansurov: [C: 032] Fixing case of wikiGrokCampaigns.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177155 (owner: 10Kaldari) [02:21:26] (03CR) 10Kaldari: [V: 032] Fixing case of wikiGrokCampaigns.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177155 (owner: 10Kaldari) [02:22:15] bmansurov: since OS X is case-insensitive, you have to do.... [02:22:18] git mv WikiGrokCampaigns.js wikiGrokCampaigns2.js [02:22:26] git mv wikiGrokCampaigns2.js wikiGrokCampaigns.js [02:22:35] kaldari|2: thanks for the tip [02:23:27] bmansurov: Yay, it's working now! [02:23:30] http://core.local/index.php/MegaMan?wikidataid=Q9685&wikigrokversion=B [02:24:11] bmansurov: You have to be small-screen too [02:24:26] oki [02:25:03] kaldari: waht's core.local? [02:25:19] bmansurov: oops, wrong server :P [02:25:57] try http://en.m.wikipedia.beta.wmflabs.org/wiki/Wolf_City?wikidataid=Q4020646&wikigrokversion=A [02:26:29] I don't see it :( [02:26:49] Maryana: did you clear cache? [02:27:00] No. Lemme do that now.. [02:27:05] and small-screen [02:27:20] cool! [02:27:28] worksforme :) [02:27:33] bmansurov: nice teamwork! [02:27:41] kaldari|2: hi5 [02:28:25] alright guys, talk tomorrow ;) have a good one [02:28:29] 3MobileFrontend-Hygiene, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#805547 (10Jdforrester-WMF) [02:28:50] bmansurov: Cya! [02:29:06] Maryana: Did it ever load for you? [02:29:22] Super slow connection in the BART station :) [02:29:56] Maryana: how are you on IRC? [02:30:18] Colloquy for mobile app! [02:30:22] It's magic [02:30:56] Hmm, still don't see it [02:31:25] Cleared cache, in beta, have the query string [02:31:56] Am I supposed to be logged in? [02:33:31] Ah ha. I see it now. I guess it's only showing up for logged in users for the a/b test? [02:38:58] yay! [02:39:14] for now yes [02:39:28] ok, going to CCL [02:39:29] (03PS1) 10BearND: Check if EditSectionActivity is finished [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177161 [05:24:40] (03CR) 10Florianschmidtwelzow: [C: 04-1] Improve search interaction experience for low end devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [05:25:23] 3MobileFrontend-beta: Talk: Text area of add talk topic not indented. - https://phabricator.wikimedia.org/T74969#805772 (10Florian) 5Open>3Resolved a:3Florian [08:05:24] (03CR) 10Florianschmidtwelzow: "> it's not a schema, just an information page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176684 (owner: 10Florianschmidtwelzow) [08:19:14] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Fix overlay icon position in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176821 (owner: 10Bmansurov) [08:59:00] good morning [10:02:05] morning [10:09:41] phuedx: good morning! [10:15:30] node drama https://github.com/iojs https://github.com/iojs/io.js/issues/3 https://news.ycombinator.com/item?id=8669557 [10:15:46] 😩 [10:24:43] feels like a bump in the road to stable to me [10:26:13] "Isn’t life supposed to be all copacetic and cooperative in the open-source world of Node.js?" [10:26:16] no it's brutal [10:26:33] i've regularly heard open-source described as brutal [10:27:43] * phuedx reads the rest of the article [10:27:45] phuedx: it is [10:28:13] phuedx: the problem is going to be that trust in the technology is going to suffer a lot, whatever happens to the fork/main repo [10:28:28] will see... [10:28:54] ideally we'd trust version numbers, right? [10:28:57] also different versioning, which will ensue confusion everywhere [10:29:01] \o/ [10:29:06] excellent, that's the way to do it! [10:29:11] FRAGMENT ALL THE THINGS [10:29:26] i think joyent'll come out swinging and it'll settle down [10:29:59] hard to tell, will see [10:30:27] companies don't act reasonably or logically, they are complicated entities [10:32:02] i agree with that generalisation to an extent [10:32:12] however, you can temper your behaviour with a mission statement [10:32:30] and having a public list of clear goals [10:32:50] there's are some entities that achieve this… [10:33:28] phuedx: this article talks about this kind of things https://medium.com/@mikeal/on-corporate-ownership-of-open-source-786ebd15847e [10:33:41] open source is hard when there is fame and money on it [10:41:04] i try my hardest not to be famous and have money [10:41:07] it's working pretty dern well [10:44:38] phuedx: :D [10:44:42] easy stuff [10:49:29] hey phuedx i'm trying to import @import "minerva.mixins"; from a less file but the mixin i'm using is not printing any css, do you know where I can look at log files for possible less errors ? [10:51:16] joakino_: this ain't pretty but: [10:51:20] ssh into yer vm [10:51:33] cd /vagrant/mediawiki/tests/phpunit/ [10:51:38] php phpunit.php suites/LessTestSuite.php [10:51:52] phuedx: ok thx, going to try that [10:54:35] wut : could not allocate 216006655 bytes for translation cache [10:54:40] phuedx: ^ any idea? [10:55:02] :/ [10:55:05] no [10:55:09] try again? [10:55:20] https://gist.github.com/anonymous/c697197f858dc0e05cb3 nah same thing [10:55:30] grhrhrhmgmbmn [11:01:42] up the memory allocated to yer vm [11:03:28] phuedx: not worth it, found solution to my problem in the less [11:05:07] 3MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown, Design: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#806423 (10matmarex) [11:21:32] (03CR) 10Phuedx: [C: 032] Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [11:21:39] (03CR) 10jenkins-bot: [V: 04-1] Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [11:27:31] (03CR) 10Phuedx: [C: 04-1] "Now that I2bf8c94703f7e5d49c3a60cf8885f7a1194e7726 has been merged, a lot of this patch is redundant." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [11:57:58] 3MobileFrontend-Feature-requests, Design: Add font size adjustment feature to the mobile front end - https://phabricator.wikimedia.org/T50946#806654 (10Florian) [12:04:23] (03PS1) 10Jhernandez: WIP: Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 [12:06:38] 3MobileFrontend-Feature-requests, Design: Add font size adjustment feature to the mobile front end - https://phabricator.wikimedia.org/T50946#806721 (10Theopolisme) Might also be worth comparing to how the mobile app does it. Appears as an overlay after "Font and theme" is selected from the menu in the upper rig... [13:22:31] joakino: is trello being funny for you? [13:22:39] card history won't load for me [13:22:49] phuedx: it works for me [13:22:55] no probs here [13:23:13] phuedx: vagrant is messing with me today, going 250% cpu every once in a while [13:23:21] yeah, i get that [13:24:01] fairly infrequently [14:30:08] back from lunch [14:43:15] im out for lunch [14:43:18] so late [14:43:19] dang [14:48:52] 3MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown, Design: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#807243 (10Florian) [14:49:35] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature to the mobile front end - https://phabricator.wikimedia.org/T50946#807245 (10Florian) [14:50:01] (03CR) 10Dbrant: [C: 032] Prevent NPE in ToCHandler.scrollToSection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177148 (owner: 10BearND) [14:54:01] 3Wikipedia-App-Android-App: NPE from page.ToCHandler.scrollToSection - https://phabricator.wikimedia.org/T75402#807258 (10Dbrant) 5Open>3Resolved a:3Dbrant [15:04:05] (03CR) 10Dbrant: [C: 032] Check if EditSectionActivity is finished [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177161 (owner: 10BearND) [15:05:28] 3Wikipedia-App-Android-App: android.view.WindowManager$BadTokenException: Unable to add window -- token is not valid; is your activity running? - https://phabricator.wikimedia.org/T73299#807266 (10Dbrant) 5Open>3Resolved a:3Dbrant [16:27:43] (03PS1) 10Dbrant: Allow enabling/disabling images in pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177238 [16:38:29] (03PS1) 10Cmcmahon: QA: refactor mainmenu_steps.rb file for Rspec etc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177243 [17:06:44] (03PS1) 10Cmcmahon: end [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177248 [17:07:51] (03Abandoned) 10Cmcmahon: end [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177248 (owner: 10Cmcmahon) [17:11:54] (03PS2) 10Cmcmahon: QA: refactor mainmenu_steps.rb file for Rspec etc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177243 [17:12:08] 3MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown, Design: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#807437 (10Awjrichards) [17:16:24] 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#807448 (10bearND) 5Open>3stalled The current code doesn't go through the bus for this anymore, so there is no onNewWikiPageNavigationEvent() anymore. We should p... [17:19:29] phuedx: joakino_ \o :D [17:19:49] hey jdlrobson! how are you [17:20:36] joakino_: not bad considering i'm redoing wednesday morning :D [17:20:40] it's like groundhog day! [17:20:43] hey jdlrobson [17:20:50] phuedx: welcome back dad! [17:20:57] \o [17:21:05] :) [17:22:31] how was china jdlrobson? [17:23:10] joakino_: crazy [17:23:21] no chance of achieving much had i not had my fluent chinese friend [17:23:42] (03PS3) 10Cmcmahon: QA: refactor mainmenu_steps.rb file for Rspec etc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177243 [17:23:54] jdlrobson: i can imagine [17:23:59] :/ [17:24:20] jdlrobson: how long were you out for? [17:24:30] phuedx: a week in china, week in taiwan [17:24:38] awesome [17:24:43] i remember holidays… [17:24:44] (03PS1) 10Dbrant: Fix possible crash when clicking link after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177253 [17:24:47] phuedx: lol [17:25:00] also my phone died but i discovered wireless charging [17:25:05] which has made me very happy [17:25:09] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177243 (owner: 10Cmcmahon) [17:25:48] (03PS1) 10Dbrant: Fix possible crash when switching language after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177254 [17:25:53] ok gonna blitz through my email [17:25:56] anything important ? [17:26:12] (03CR) 10jenkins-bot: [V: 04-1] Fix possible crash when switching language after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177254 (owner: 10Dbrant) [17:26:35] jdlrobson: not that i'm aware of [17:26:48] don't take my word for anything though [17:26:53] i'm propped up by caffeine [17:27:31] phuedx: me too! plus i [17:27:36] plus i've only had 4 hrs sleep [17:27:37] muahahah [17:27:55] i've had more sleep than you! [17:27:56] WOO!!! [17:28:53] (03Merged) 10jenkins-bot: QA: refactor mainmenu_steps.rb file for Rspec etc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177243 (owner: 10Cmcmahon) [17:28:57] lol [17:28:59] (03PS2) 10Dbrant: Fix possible crash when switching language after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177254 [17:29:59] welcome back jdlrobson :P [17:30:05] thanks FlorianSW :D [17:30:10] phuedx: you win!! [17:30:17] phuedx: but i have green tea cookies from taiwan to share in the office [17:31:45] (03PS1) 10Dbrant: Fix behavior of long-press in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177255 [17:32:32] jdlrobson: you've mailed some to the remote workers, right? [17:32:43] otherwise that just ain't fair [17:32:47] phuedx: ;-) [17:34:35] joakino_: it's cool they merged the jscs patch :) [17:35:12] yeah there is a lot of interest in all that [17:35:12] joakino_: what's easiest way to package our own version of jscs. I must admit I've never done any npm packaging [17:36:14] jdlrobson: the thing is from npm you can link to git repos instead of npm packages, checkout in package.json the line of grunt-qunit-istanbul [17:36:52] jdlrobson: you can link to a git repo / branch / tag (branch and tag using the #smoething after the url) [17:37:04] then npm install brings the code from the repo instead of the npm registry [17:37:38] jdlrobson: for example for grunt-qunit-istanbul i created a branch called #prefix-url and put there my fix [17:38:09] jdlrobson: the ideal would be to have a tag and link from the package.json to that tag, so that if we want to update jscs then we change the tag on package.json [17:38:17] sweet. i'll cut a card in dev backlog to move to > 1.8.1 [17:38:31] 👍 [17:38:44] i'm keen to make use of the new rules though [17:39:40] jdlrobson: can't we include them in locally doing this? https://github.com/jscs-dev/node-jscs#additionalrules [17:39:57] joakino_: i guess so... [17:40:02] then when we update the package.json we remove the additional rules and the grunt config [17:40:02] i haven't explored that much [17:40:06] (03PS2) 10Florianschmidtwelzow: Hygiene: Add missing Autoloadclasses entries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176895 [17:40:15] joakino_: i'm not sure what's least messy.. [17:40:26] joakino_: can you link to a commit in github? [17:40:36] MaxSem: if you have two minutes, can you take a look at https://gerrit.wikimedia.org/r/#/c/176895/ ? :) [17:40:38] jdlrobson: not sure, maybe [17:41:05] (03CR) 10MaxSem: [C: 032] Hygiene: Add missing Autoloadclasses entries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176895 (owner: 10Florianschmidtwelzow) [17:41:26] jdlrobson: looks like it https://www.npmjs.org/doc/files/package.json.html#git-urls-as-dependencies [17:41:28] yes [17:41:31] MaxSem: that was fast, thanks :D [17:42:26] (03Merged) 10jenkins-bot: Hygiene: Add missing Autoloadclasses entries [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176895 (owner: 10Florianschmidtwelzow) [17:42:47] joakino_: yeyy [17:43:15] 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#807526 (10Dbrant) [17:43:54] milimetric: we can talk today about graphs if you want to :) [17:44:25] 3Wikipedia-App-Android-App: Text Looks garbled when using Bengali - https://phabricator.wikimedia.org/T68125#807539 (10Awjrichards) [17:44:29] 3MobileFrontend-General-or-Unknown: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - https://phabricator.wikimedia.org/T69819#807542 (10Awjrichards) [17:45:32] 3MobileFrontend-Hygiene, MobileFrontend-General-or-Unknown: Missing autoload entries for DeviceDetection classes - https://phabricator.wikimedia.org/T76436#807591 (10Florian) 5Open>3Resolved a:3Florian [17:46:14] jdlrobson: we've got a few tasks in phabricator, hang on [17:46:31] https://phabricator.wikimedia.org/T76407 [17:46:35] https://phabricator.wikimedia.org/T76408 [17:46:51] rtnpro, who is a new volunteer has taken the first one [17:47:12] but he might need help with it, not sure [17:47:15] milimetric: can we grab a meeting today to sync up about this? [17:47:21] the second one is the script you mentioned [17:47:24] sure - are you going to SoS [17:49:49] milimetric: nope kaldari will [17:50:00] milimetric: i'll check your calendar and schedule something [17:50:03] 30mins should do it! [17:50:09] ok, cool, let's do that [17:50:15] but after SoS - in a meeting now [17:51:56] milimetric: done [17:52:05] joakino_: phuedx sorry about all the table of contents icon mess [17:57:32] jdlrobson: it's ok -- i just can't wait for the icon stuff to be sorted [17:57:49] phuedx: taking forever :-( [17:57:58] https://trello.com/c/ClXduc3N/102-migrate-rl-modules-to-a-resources-folder-structure < phuedx any idea why this isn't rendering as html? [17:58:38] (03PS1) 10Cmcmahon: QA: refactor nearby test for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177261 [17:59:30] jdlrobson: fixed [17:59:37] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177261 (owner: 10Cmcmahon) [17:59:40] markdown requires 4 spaces to render a code block [18:01:33] phuedx: are we doing standup? [18:01:35] (03Merged) 10jenkins-bot: QA: refactor nearby test for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177261 (owner: 10Cmcmahon) [18:01:38] Keep getting netwrok error on standup hangout [18:01:38] yeah [18:02:12] gonna restart [18:11:27] (03PS1) 10Cmcmahon: QA: refactor notifications test for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177263 [18:11:59] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177263 (owner: 10Cmcmahon) [18:13:34] (03Merged) 10jenkins-bot: QA: refactor notifications test for RSpec3 syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177263 (owner: 10Cmcmahon) [18:18:07] phuedx: 4? sooo greedy! [18:18:19] inorite [18:18:54] phuedx: not rendering as html though.. [18:21:04] what do you want from me!? [18:21:32] joakino_: I was going to add https://gerrit.wikimedia.org/r/#/c/177149/ to your bug, but I can't find it now. [18:22:10] (03CR) 10BearND: [C: 032] Fix possible crash when clicking link after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177253 (owner: 10Dbrant) [18:22:11] kaldari: are you autoverifying it? xD [18:22:36] (03Merged) 10jenkins-bot: Fix possible crash when clicking link after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177253 (owner: 10Dbrant) [18:22:45] joakino_: We had problems with Jenkins :P [18:22:51] haha [18:23:34] joakino_: Jenkins was rejecting everything, but me and baha figured it out how to fix it.... [18:23:39] kaldari: do you want me to find the phab bug? [18:24:03] joakino_: Well, if it's already resolved I guess it doesn't matter [18:24:51] (03PS1) 10Cmcmahon: QA: refactor pageactions_steps for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177265 [18:24:55] kaldari: 👍 [18:25:41] joakino_: The problem was that a file was listed in a module with different case than the actual file. MacOS didn't case, and would happily run everything regardless, so we couldn't reproduce the problem locally, but on whatever machine Jenkins is on, it's case sensitive apparently. [18:25:50] case=care [18:25:56] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177265 (owner: 10Cmcmahon) [18:27:09] kaldari: ooooh [18:27:20] kaldari: damn jenkins [18:27:42] joakino_: Found the bug and resolved it with the patch [18:28:37] (03Merged) 10jenkins-bot: QA: refactor pageactions_steps for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177265 (owner: 10Cmcmahon) [18:30:05] kaldari: i think that same thing happened with watchlist not long ago [18:30:29] are we triaging? [18:31:25] phuedx yep, just wrapped app standup. [18:31:31] oh yeah [18:31:34] forgot about that [18:31:35] mibad [18:31:59] And now I wish I had the IRC team callout shortcut :P [18:32:19] (03CR) 10BearND: [C: 04-1] "minor" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177254 (owner: 10Dbrant) [18:32:36] So, Maryana jdlrobson phuedx joakino_ bmansurov MaxSem kaldari rmoen [18:32:42] We were talkign about https://phabricator.wikimedia.org/T1384 [18:32:47] Generalize NoScript detection in Wikipedia Zero to be used for all users [18:33:39] this bug is horribly formulated [18:33:45] this should be core functionality, right? [18:33:48] or in some other extension [18:33:54] as it is, it should be closed as WFM [18:34:30] (03PS3) 10Dbrant: Fix possible crash when switching language after activity closed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177254 [18:34:36] (03CR) 10Jdlrobson: [C: 032] "Thanks Timo!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176873 (owner: 10Krinkle) [18:34:39] I guess what it means is that we should display stuf in