[00:00:23] kaldari|2: see also https://trello.com/c/ClXduc3N/102-migrate-rl-modules-to-a-resources-folder-structure [00:04:35] kaldari|2: jdlrobson do you know the max width we have set for tablet where after that point content is centered in the browser window? [00:04:55] 768px kaity [00:05:02] thanks! [00:10:35] (03CR) 10Jdlrobson: Hide some links from nonjs users (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 (owner: 10Bmansurov) [00:11:22] (03PS1) 10Brion VIBBER: fix for order of back/forward [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177436 [00:15:43] (03PS1) 10Cmcmahon: QA: finish watchlist update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177440 [00:16:56] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177440 (owner: 10Cmcmahon) [00:19:27] 3Wikipedia-App-General-or-Unknown: Tracking: API issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#808916 (10Deskana) [00:21:21] (03Merged) 10jenkins-bot: QA: finish watchlist update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177440 (owner: 10Cmcmahon) [00:22:00] brion: found another little issue - MWKImage’s fileNameNoSizePrefix property seems to still have the size prefix. ie “440px-Buson_Park.jpg” vs “Buson_Park.jpg” [00:24:20] mhurd: hmm, woops [00:24:38] i musta forgot to do that bit :D [00:24:53] lol return self.fileName; // @FIXME IMPLEMENT [00:26:05] brion: hehe just saw that :) [00:27:48] 3MobileFrontend-Hygiene: Issues using qunit with grunt - https://phabricator.wikimedia.org/T75670#808935 (10Jdlrobson) [00:30:38] (03PS1) 10Brion VIBBER: implement fileNameNoSizePrefix [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177444 [00:35:10] 3MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown, Design: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#808955 (10Jaredzimmerman-WMF) Consistency is a work in progress. This is a piece of that progress. [00:35:39] 3MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown, Design: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#808956 (10matmarex) [00:49:35] (03PS1) 10MaxSem: WIP: response table [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:49:47] (03CR) 10jenkins-bot: [V: 04-1] WIP: response table [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:50:43] (03PS2) 10MaxSem: WIP: response table [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [00:50:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: response table [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [00:51:41] kekeke, SQLite or death! [00:52:43] (03PS3) 10MaxSem: WIP: response table [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [01:00:09] wooo, response table lives! [01:04:48] (03PS3) 10Robmoen: Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 [01:07:32] (03CR) 10Jhobs: "I like solution (a), I'll just go with that and we can change it in the future if it's still a problem." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 (owner: 10Jhobs) [01:13:29] (03PS3) 10Bmansurov: Hide some links from nonjs users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 [01:15:31] (03CR) 10Bmansurov: Show WikiGrok error (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [01:15:51] (03PS6) 10Bmansurov: Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 [01:19:07] (03PS6) 10Jhobs: Update interstitial to use OOjs-UI [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 [01:26:39] 3MobileFrontend-General-or-Unknown: "Template: refimprove section" not displaying in mobile beta - https://phabricator.wikimedia.org/T76678#809007 (10Aklapper) [01:33:04] brion: ya looks like “createImageRecordsForHtmlOnContext” was called in both “applyResultsForLeadSection” and once per section in “applyResultsForNonLeadSections”. in ArticleFetcher.m [01:33:14] heh woops [01:35:44] brion: no worries - if you want you could do the image placeholder creation stuff at the point within the data layer where you save the html. that way it would just happen implicitly [01:36:19] :) [01:38:05] brion: i’ve had more coffee than sleep though so not sure i should be trying to thinkify things just now ;) [01:38:10] haha [01:38:47] i’m just skinning out out the image list code before my pizza arrives :D [01:43:00] brion: https://www.youtube.com/watch?v=wusGIl3v044 [01:43:27] that’s… disturbing :D [01:43:43] hehe [01:44:12] (03PS4) 10MaxSem: WIP: response table [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [01:50:22] brion: oh i forgot i was going to recommend uncommenting all of the “debuggingPlaceHolderImageData” lines in URLCache.m when for quick debugging of image routing. browse to a page, it should then route the placeholder image "logo-onboarding-subtitle.png" to the data store for every image if it’s working. if you then competely quit the app and restart it every image on the page should be "logo-onboarding-subtitle.png" if URLCache im [01:50:37] nice [01:50:56] brion: very quick way to see “yup, is good” [01:51:47] (03CR) 10Kaldari: [C: 032] Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [01:52:01] oh yeah, finally ^ [01:53:00] (03Merged) 10jenkins-bot: Show WikiGrok error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175851 (owner: 10Bmansurov) [01:57:03] :) [01:57:33] 3MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown, Design: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#809030 (10Jdlrobson) [02:49:19] yurikR: hey I don't know if I'm just missing something but the only changes I'm able to make to the Lua module right now is using p.jsonDecode on one of the parameters, p.getAllowedAccountIds, and p.getUsername. Is this all that's been implemented so far and I'm just overthinking things? I thought the new parameter access functions were in already? [02:49:48] jhobs, they should all work [02:50:02] i mean - they are already in production, working - the main page uses graphs [02:50:12] well yeah i knew the graph stuff [02:50:14] and those graphs use the new param system [02:50:19] hmm [02:50:40] look at the URL requests - you will see the new ones [02:56:07] yurikR: oh are all paramters using getRawParameter? [02:56:12] yurikR: i thought that was only for the graphs [02:56:25] ?? [02:56:30] how do you mean? [02:58:03] yurikR: if I'm trying to get the state and route, I should be using getRawParameter? [02:58:28] and just name some parameters like zpstate or zproute [02:58:33] jhobs, to get any "zp*" parameters, use getRawParameter() [02:58:48] you have an optional "default" value as a second param [02:59:00] it only accepts strings and null [02:59:18] yurikR: ok THAT explains all my confusion then. I thought getRawParameter was only for graphs so I was looking around forever for another function haha [02:59:29] remember that in lua, if s then ... is false only if s is null [02:59:37] right [02:59:46] an empty string is NOT false ( [03:30:14] (03CR) 10BearND: [C: 04-1] "Getting exceptions ("network errors") when entering search terms that have no results in both title and full text search. Sent you stack t" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177397 (owner: 10Dbrant) [03:34:24] (03PS7) 10Dbrant: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 [03:38:48] (03PS7) 10Dbrant: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 (owner: 10BearND) [03:48:15] (03PS2) 10Dbrant: [WIP] Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 [03:49:40] yurikR: I think I've got it sorted out, but we need a way to test beta lua modules [03:49:57] yurikR: for example, Module:Portal-1, which I'm currently creating [03:52:06] would Special:ZeroPortal?module=xxx work? Will only work for admins [03:52:10] jhobs, ^ [03:52:22] sounds good to me [03:52:48] but it will require a php code change, right? [03:53:07] yurikR: ^ [03:53:16] yep [03:53:49] we could also create a debug function of sorts [03:53:58] cool, i'd be hesitant to overwrite the production module until we have that in place. I'll go ahead and create the beta one and ping you to code review it once it's ready tho [03:54:13] oki [03:54:50] jhobs, btw, it seems that when you create two functions with identical names in two different modules, they collide [03:55:05] unless they are part of the "p" or some other local var [03:55:26] hence i suspect we should have a local "_" as a private var [03:55:27] only if both modules are loaded by the same page though, right? [03:55:31] correct [03:55:38] aight, good to know [03:55:55] but i think it should be a good practice to have all local funcs as part of the "_" var [03:56:01] yeah, makes sense [03:56:04] take a look at the graphs2 module [03:56:08] I'll start that practice with the beta template then [03:56:10] yeah, I have [03:56:18] and i meant continue* [03:56:21] not start [03:56:34] btw, i haven't tested that that's the behaviour, but i did run into the conflicting funcs [04:06:30] ugh regexes just have to be harder in objective-c for no good reason [04:36:56] yurikR: Module:Portal-1 has been created if you want to review it at some point, although I assume we might as well wait on the php change [04:37:35] jhobs, php change might take a bit, but i am thinking of how to test things via p.dbg() style method [04:38:04] yurikR: i tested as much as I could with p.dbg(), but I can't test the getRawParameter parts with that [04:38:09] or getAllowedIds [04:39:38] that's what i'm working on ) [04:42:46] ok [04:49:45] 3MobileFrontend-Hygiene: Issues using qunit with grunt - https://phabricator.wikimedia.org/T75670#809145 (10Liuxinyu970226) [05:03:50] (03PS1) 10Brion VIBBER: Image caching -- sorta working? :D [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177493 [06:40:33] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature to the mobile front end - https://phabricator.wikimedia.org/T50946#809207 (10Florian) [07:13:50] 3MobileFrontend-General-or-Unknown: "Template: refimprove section" not displaying in mobile beta - https://phabricator.wikimedia.org/T76678#809250 (10Florian) [07:14:02] 3MobileFrontend-General-or-Unknown: "Template: refimprove section" not displaying in mobile beta - https://phabricator.wikimedia.org/T76678#808890 (10Florian) That's correct. This kind of infoboxes are hidden in mobile (because they aren't optimised for it). Actually, we parse the information and display it with... [07:15:15] 3MobileFrontend-stable: "Template: refimprove section" not displaying in mobile beta - https://phabricator.wikimedia.org/T76678#809252 (10Florian) [09:32:45] good morning! [10:02:24] morning joakino [10:03:53] sup phuedx [10:06:46] i'm switching from rdio to spotify [10:06:56] i've agonised over this for the last few months [10:13:26] phuedx: i just use grooveshark, for the last years, but i recon spotify was pretty good [10:13:56] rdio has a gorgeous design and a solid ux [10:14:11] however, their catalogue and various streaming issues i've had recently have put me off [10:16:37] the mobile as a remote thing was a really, really nice touch [10:16:45] but yeah, spotify's catalogue is immense [10:17:01] even for small-ish post-rock/post-metal bands [10:21:17] phuedx: yep, it is very good [11:34:57] i'm leaving for a little while, gonna cut peppers [11:58:55] back [12:16:58] what're you making joakino? [12:17:29] i'm sorting through email and looking at office stuff now [12:17:32] phuedx: ^ [12:17:45] no with the peppers ;) [12:20:29] oh xD [12:21:24] phuedx: tuna with paprika on the pan, 1 egg omelette and thin sliced peppers on top [12:21:34] will get to the rest of it on a bit [12:21:36] yowza [12:21:39] sounds delish! [12:21:52] phuedx: healthy today [12:22:08] so you like cooking? [12:22:26] meh [12:22:32] at the moment i take no pleasure in it [12:22:40] but generally speaking, yes i do [12:22:47] i'm also having an omelette today [12:23:03] cool [12:23:10] i enjoy it, i find it relaxing [12:24:02] at the moment lisa and i cook to hard deadlines of children demanding dinner ;) [12:33:31] phuedx: haha, hard to do pleasure cooking :) [14:11:06] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#818804 (10Florian) [14:11:14] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#532681 (10Florian) [14:12:14] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#818809 (10Qgil) [14:40:22] (03CR) 10Dbrant: [C: 032] Avoid rehashing when building HashMaps in staticdata [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177311 (owner: 10BearND) [14:59:43] (03PS4) 10Dbrant: Use new "index" property to sort search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177397 [15:02:51] (03PS2) 10Dbrant: Whoops: explicitly set placeholder image for thumbnails. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177405 [15:53:59] (03PS1) 10Brion VIBBER: fix ToC missing top-level entry [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177553 [16:07:45] (03PS1) 10Brion VIBBER: magic happy language name [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177555 [16:14:09] (03PS1) 10Dbrant: Add ignored CSS class for table transforms. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177556 [16:41:56] (03CR) 10BearND: [C: 032] Whoops: explicitly set placeholder image for thumbnails. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177405 (owner: 10Dbrant) [17:02:00] (03CR) 10BearND: [C: 032] Add ignored CSS class for table transforms. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177556 (owner: 10Dbrant) [17:02:20] (03Merged) 10jenkins-bot: Add ignored CSS class for table transforms. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177556 (owner: 10Dbrant) [17:02:39] (03PS5) 10BearND: Use new "index" property to sort search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177397 (owner: 10Dbrant) [17:08:51] (03CR) 10BearND: [C: 032] Use new "index" property to sort search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177397 (owner: 10Dbrant) [17:09:12] (03Merged) 10jenkins-bot: Use new "index" property to sort search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177397 (owner: 10Dbrant) [17:10:28] (03PS3) 10BearND: Whoops: explicitly set placeholder image for thumbnails. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177405 (owner: 10Dbrant) [17:43:17] ping [17:48:06] (03PS1) 10Cmcmahon: QA update talk test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177575 [17:48:45] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177575 (owner: 10Cmcmahon) [17:50:32] (03Merged) 10jenkins-bot: QA update talk test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177575 (owner: 10Cmcmahon) [17:54:40] pong [17:54:44] kristenlans_: ^ [17:56:37] phuedx: do you still have issues with https://gerrit.wikimedia.org/r/#/c/174633/7 ? [17:56:58] jdlrobson: nope [17:57:11] i haven't re-reviewed it since the caching problem though [17:57:17] can i get a +2? Can I get a +2? what. what. [17:57:17] sorry :( [17:57:30] engine engine number 9 on the new york transit line. [17:58:18] just for that you can! [17:59:34] (03CR) 10Phuedx: [C: 031] "This LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177428 (owner: 10Kaldari) [18:00:27] phuedx thanks for that, trying new irc client [18:02:52] (03PS1) 10Cmcmahon: QA: update toc test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177580 [18:03:37] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177580 (owner: 10Cmcmahon) [18:04:02] dr0ptp4kt, meeting? [18:05:45] (03Merged) 10jenkins-bot: QA: update toc test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177580 (owner: 10Cmcmahon) [18:18:45] https://en.wikipedia.org/wiki/Special:EditWatchlist?useskin=minerva [18:19:27] kristenlans_: which irc client are you trying? [18:22:45] jdlrobso_: editing https://en.wikipedia.org/wiki/Testing?action=edit&useskin=minerva [18:24:09] phuedx: "Lingo" [18:27:15] (03PS1) 10Cmcmahon: QA: update toggling tests for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177581 [18:32:25] brion: great fixes! caching does indeed seem to be working :) [18:32:41] \o/ [18:32:48] i like the turn everything blue’ test mode [18:32:55] brion: hehe yes :) [18:33:45] brion: oh 2 quick small things - seems to always load the “main” page after quitting restarting instead of last viewed article [18:33:54] http://hatjitsu.wmflabs.org/60107 [18:34:05] ah yeah i think it’s not saving the updated article probably [18:34:27] brion: and can saveImageList record the section too so the article object can be interrogated to, say, give me the 3rd image in section 5? [18:35:00] brion: coffee times… [18:35:01] mhurd: yeah i was thinking about that, either i can store one list per section, or enhance the list to store section data too [18:35:04] got a pref? [18:35:08] mmmm coffeeeee [18:36:19] brion: hmmm thinking... [18:37:08] and then either a single record or a single-item list for the PageImages thumbnail [18:39:27] (03CR) 10Cmcmahon: [C: 032] "maintenance (this test was passing by accident)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177581 (owner: 10Cmcmahon) [18:39:58] brion: yea for the thumbnail the ideal outcome would be not only access to the thumbnail, but also easy way of getting higher resolution version of the same image if it’s in the store… i’m doing that now matching in core data via the fileNameWithoutPrefix [18:40:10] yep [18:40:16] 3Wikipedia-App-Android-App: SQLiteException: Can't upgrade/downgrade database - https://phabricator.wikimedia.org/T75161#819225 (10Krenair) [18:40:33] easy enough to scan through the lists for that [18:40:52] (03Merged) 10jenkins-bot: QA: update toggling tests for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177581 (owner: 10Cmcmahon) [18:47:12] brion: regarding “either i can store one list per section, or enhance the list to store section data too”, i think maybe the latter because then you wont have to walk all the section folders to get the 4th image in section whatever. i think? [18:48:32] well if we want it from a given section we just load that one list [18:48:37] only diff is when we need the full list [18:48:42] and i’m not sure we really need that often either? [18:48:55] brion: ah good point [18:50:44] brion: as long the article can return the highest res version it has of image x from section y, i’ll be filled with joy :) [18:52:06] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819257 (10Jaredzimmerman-WMF) [18:53:31] :) [18:53:44] mhurd: hmm, if we have to scan through that list then… might be easiest to stick them all in one object then [18:53:49] i’ll go with that and see how it looks [18:57:44] brion: cool! easy way to test would be that “toggleImageSheet" method commented out in the didReceiveMemoryWarning method of web view controller. it lays out images in order by section with section titles. quickest test for the highest res stuff is saved pages - the low res thumbnails look bad scaled up, but if we can ask for highest res version of given image/thumb it looks sharp [18:58:17] yep [18:58:18] nice [18:59:04] gonna grab some eats and watch the metrics, bbiab [19:01:04] oh yeah, the metrics... [19:01:39] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819289 (10Florian) @Jaredzimmerman-WMF: then i haven't misunderstood you, unhappily :( That's why i have added it to Special:MobileOptions. Maybe, as a first step, we could add this feature to Sp... [19:04:21] rmoen: 3 years huh?! [19:05:01] MaxSem too! [19:13:54] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update MobileWebClickTracking to cover alpha links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176917 (owner: 10Florianschmidtwelzow) [19:14:36] (03CR) 10Bmansurov: [C: 031] Improve search interaction experience for low end devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [19:16:00] (03Merged) 10jenkins-bot: Hygiene: Update MobileWebClickTracking to cover alpha links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176917 (owner: 10Florianschmidtwelzow) [19:21:54] (03PS16) 10Bmansurov: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [19:28:59] (03PS4) 10Robmoen: Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 [19:29:44] (03CR) 10Robmoen: Improve search interaction experience for low end devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [19:37:36] (03CR) 10Bmansurov: [C: 04-1] "Looks good, a few notes:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [19:40:22] (03CR) 10Bmansurov: "It maybe a good idea to add the core dependency to gerrit (https://wiki.openstack.org/wiki/Gerrit_Workflow#Add_dependency) so that I can +" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [19:44:36] (03PS4) 10Bmansurov: POC: Add mobile preview button to EditPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [19:46:18] (03CR) 10jenkins-bot: [V: 04-1] POC: Add mobile preview button to EditPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [19:52:09] jdlrobso_: what's the url parameter for using minerva in desktop? [19:58:51] bmansurov: useskin=minerva [19:58:59] thanks [20:00:56] (03CR) 10Florianschmidtwelzow: "@Bmansurov: Probably i'm wrong, but you can't add dependencies to different git repositories." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [20:01:02] bmansurov: ^ [20:01:45] FlorianSW_: hmm, I thought I saw jon do that before [20:02:51] bmansurov: like i said, i never read about it and can't imagine, how to do that and how this should work :) [20:03:31] FlorianSW_: I see [20:04:31] bmansurov: :) core dependencies should be notices in commit message, unhappily we can't +2 them before all dependencies get merged. [20:04:39] *notices -> noticed [20:05:09] FlorianSW: great to know that [20:06:21] (03CR) 10Jdlrobson: [C: 031] "I also noticed the issue Baha did." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [20:10:43] (03CR) 10Florianschmidtwelzow: [C: 04-1] "give me 2 minutes (take the time, if you want ;)) :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [20:11:44] (03PS1) 10Cmcmahon: QA: update ui_links test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177606 [20:12:18] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177606 (owner: 10Cmcmahon) [20:16:03] (03PS17) 10Florianschmidtwelzow: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) [20:16:43] (03PS3) 10Dbrant: Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 [20:16:45] (03Merged) 10jenkins-bot: QA: update ui_links test for RSpec3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177606 (owner: 10Cmcmahon) [20:20:04] (03CR) 10jenkins-bot: [V: 04-1] Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 (owner: 10Dbrant) [20:21:49] (03PS4) 10Dbrant: Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 [20:31:01] (03PS1) 10Brion VIBBER: Split image records into sections and save thumbnail [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177613 [20:31:04] (03PS1) 10Cmcmahon: QA: update upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177614 [20:32:01] mhurd: https://gerrit.wikimedia.org/r/#/c/177613/1 :) [20:32:23] brion: oooh :) [20:33:24] (03CR) 10Cmcmahon: "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177614 (owner: 10Cmcmahon) [20:35:17] (03CR) 10Cmcmahon: [C: 032] QA: update upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177614 (owner: 10Cmcmahon) [20:35:25] rmoen: you there? [20:35:34] jdlrobson: aye [20:35:36] so i looked at your core patch. [20:35:45] i don't think it's a formFooter or a formHeader [20:35:49] yeah [20:35:50] i don't really know what it is [20:35:57] but it seems more like a set of tabs [20:36:01] I think we both agree that the name is incorrect. [20:36:13] closest pattern i can find to it is Special:Preferences [20:36:16] but styled completely differently of course [20:37:33] (03CR) 10Jdlrobson: [C: 032] Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [20:38:21] rmoen:i'm looking through the mediawiki ui trello board [20:38:23] https://trello.com/c/F3SdIvRg/45-tabs-panes-panels [20:38:26] (03CR) 10Bmansurov: [C: 031] "works for login, but not signup. i think that's how it currently works anyway." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [20:38:40] also https://trello.com/c/RVkdiGI2/19-button-group [20:39:05] (03Merged) 10jenkins-bot: QA: update upload tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177614 (owner: 10Cmcmahon) [20:39:28] (03Merged) 10jenkins-bot: Merge CtaDrawer with EditorOverlay Anonwarning for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [20:39:37] ok sandwich time. bbiab [20:40:10] jdlrobson: are you thinking we should use this tab bar? [20:48:50] rmoen: i'm not sure but i think let's drop the form-header/footer name and use something which uses the word tab [20:48:58] shame phuedx is not around [20:49:07] would be keen to hear his thoughts [20:49:12] Being mindful of the existing hook SpecialSearchProfileForm hook, We should rename this method searchProfileTabs ? [20:49:14] (03PS1) 10Cmcmahon: QA: more RSpec [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177615 [20:50:27] jdlrobson: In another patch we can turn them into mw-ui-buttongroups? [20:50:30] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177615 (owner: 10Cmcmahon) [20:52:17] (03Merged) 10jenkins-bot: QA: more RSpec [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177615 (owner: 10Cmcmahon) [20:55:24] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#819550 (10Jdlrobson) [20:55:26] 3MobileFrontend-General-or-Unknown: Unregistered editing shouldn't require 3 clicks - https://phabricator.wikimedia.org/T74852#819548 (10Jdlrobson) [20:59:40] (03CR) 10Florianschmidtwelzow: "Baha: Are you sure? I have tested it and it worked for login and signup :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [21:01:16] rmoen: sounds good to me - searchProfileTabs :D [21:07:29] brion: time for quick hangout? [21:07:35] moment [21:09:42] brion: oh man this lead image styling stuff is starting to look so cool! [21:10:06] :D [21:10:15] ok i think i got my googles open [21:10:22] hehe k [21:11:34] 3MobileFrontend-alpha: Main menu links are not being logged in alpha - https://phabricator.wikimedia.org/T75159#819588 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [21:15:27] (03PS1) 10Cmcmahon: QA: cleanup, adding "should" to Then steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177637 [21:21:42] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819630 (10Jaredzimmerman-WMF) [21:22:30] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819635 (10Jaredzimmerman-WMF) [21:24:11] (03CR) 10Bmansurov: "My bad, it's working for singup too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [21:25:40] (03CR) 10Florianschmidtwelzow: "Great, thanks for testing :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172582 (https://bugzilla.wikimedia.org/72852) (owner: 10Florianschmidtwelzow) [21:25:49] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819640 (10Florian) @jaredzimmerman-WMF: Yes, i will put it into alpha (first thought was beta, but i think Jon is right, alpha is much better for this experimental feature). Ok, 3 initially and t... [21:26:20] (03PS1) 10Brion VIBBER: Thumbnail fallback: if none recorded, use first image in section 0 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177658 [21:26:22] (03PS1) 10Brion VIBBER: Forgot to implement thumbnailUIImage property; fixes Saved Pages thumbnails [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177659 [21:26:29] woo that was easier than expected :D [21:26:31] lemme add those props [21:28:31] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819656 (10Jaredzimmerman-WMF) Also we should Absolutely do some minimal instrumentation on this, to see how users are interacting with it, and what size they are using. If you're not familiar w... [21:29:34] (03PS5) 10Robmoen: Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 [21:30:03] brion: nice!!! [21:30:38] (03PS1) 10Brion VIBBER: Add 'entitydescription' prop on MWKArticle [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177661 [21:35:39] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819670 (10Florian) > Also we should Absolutely do some minimal instrumentation on this, to see how users are interacting with it, and what size they are using. @Jdlrobson: Can we reuse MobileWebC... [21:40:42] brb eating [21:43:11] ok gotta get cat food so cats don’t revolt and take over the apartment [21:43:16] bbiab [21:43:55] (03CR) 10Dr0ptp4kt: [C: 031] Update interstitial to use OOjs-UI [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/169633 (owner: 10Jhobs) [21:57:38] (03PS1) 10Jdlrobson: Add support for donation button in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177668 [21:57:45] banner code is causing jsduck warnings for me :( [22:02:13] brion: quick question - how do you get the image list from MWKImageList? maybe convenience property which returns array of MKWImage objects? [22:04:49] brion: i suppose it’s a wider question - should all MWK*list objects just have such a “list” convenience property? or is does this run counter to some design/containment principle? [22:05:26] guessing it would be a readonly prop [22:06:12] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#819821 (10Jaredzimmerman-WMF) yeah, I think 3 different size A letter forms would be best, if they could match the size, and font of the body text that would be even more ideal. [22:12:28] brion: *context was playing around w/ that toggleImageSheet method - was trying to print section titles with their respective images in order beneath them* [22:13:18] (03CR) 10Bmansurov: [C: 04-1] Add support for donation button in beta (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177668 (owner: 10Jdlrobson) [22:13:52] brion: ok back to lead image styling… *resisting temptation to play with the new data store :) * [22:13:53] mhurd: well if you ask for all the MWKImage objects it’ll have to load them individually from disk [22:13:53] but it’s fairly straightforward to do [22:13:53] MWKArticleStore sections property basically does the same thing :) [22:13:53] if you just want the URLs then it can give them to you from memory [22:13:54] but that’d be convenient for the sections thingy yeah [22:14:03] yeah [22:14:08] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177637 (owner: 10Cmcmahon) [22:14:13] i can totally make an imagesForSectionId: method :D [22:14:22] that’d go on articleStore i think [22:15:21] brion: perfect! yea if i can easily list section titles and thier images beneath them i think we’re good to go [22:15:32] (03Merged) 10jenkins-bot: QA: cleanup, adding "should" to Then steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177637 (owner: 10Cmcmahon) [22:15:42] yeah just iteration through articleStore.sections and then ask for the images…. yeah i can make that happen [22:15:44] gimme a few :D [22:15:54] how’s this for convenience methods? [22:15:55] -(NSArray *)imageURLsForSectionId:(int)sectionId; [22:15:56] -(NSArray *)imagesForSectionId:(int)sectionId; [22:15:56] -(NSArray *)UIImagesForSectionId:(int)sectionId; [22:16:11] brion: sounds good! [22:16:39] brion: should be easy to loop throught the sections and do whatever with its images that way [22:16:46] ya [22:23:18] brion: i see “-(NSString *)largestImageVariant:(NSString *)image;” on MWKImageList - can we have a “-(MKWImage *)largestImageVariant;” on MWKImage too? [22:24:01] mhurd: in this object model i think we’d want that convenience method on the MWKArticleStore [22:24:19] but could totally make one yeah [22:25:42] brion: cool - i’m seeing how much laziness i can get away with to see if there’s a higher res of any given “MKWImage” :) [22:27:04] hehe [22:30:53] (03PS1) 10Brion VIBBER: Convenience methods for retrieving all a section's images [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177676 [22:31:50] brion: oooooh! [22:33:21] brion: it’s, like, christmas [22:34:10] (03PS1) 10Brion VIBBER: largestImageWithURL convenience method on MWKArticleStore [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177677 [22:34:42] brion: haha you’re submitting faster than i can download and compile [22:35:01] mhurd: and i think that one should help you a little :) [22:35:01] hmm grrrit-wm poke poke [22:35:01] https://gerrit.wikimedia.org/r/#/c/177677/ anyway :) [22:35:19] iiiiii’m dreaming of UIChristmas [22:35:56] hehe [22:36:03] NSLog(@“%d shopping days left”, [[NSDate new] timeIntervalUntil:[UIChristmas sharedHoliday].date] / 86400); [22:36:13] oh god :) [22:36:32] i can do a Java one too! [22:36:53] AbstractHolidayFactory factory = new ChristmasFactory(); [22:37:00] oh no it just gets worse from there [22:37:24] brion: factory factories are my favorite factories [22:38:11] abstract singleton factory observer data object views [22:38:34] now let’s make that a protocol [22:39:00] brion: refactoring factory factories are my favorite factory refactorings [22:39:41] lollll [22:41:13] brion: somethings a bit off w/toggleImageSheet - it only shows the first image sometimes, but none from later sections… [22:41:43] bahhhhh [22:43:43] ah i think i messed up converting the loop [22:43:45] gimme a sec [22:44:50] (03PS1) 10Jdlrobson: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 [22:45:04] (03PS1) 10Brion VIBBER: Fix regression in toggleImageSheet magic [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177680 [22:45:18] brion: yay! [22:45:24] (03CR) 10Brion VIBBER: "put stuff at wrong end of the loop woops" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177680 (owner: 10Brion VIBBER) [22:45:31] whee [22:45:40] (03PS2) 10Jdlrobson: Hygiene: Fix issues preventing pre-review script from running [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 [22:45:45] ^ bmansurov can you take a look? i can't send code to git without it? [22:45:56] that’s what i get for testing on pages with one section only :P :) [22:46:23] brion: hehe [22:46:31] (03CR) 10Bmansurov: [C: 032] Hygiene: Fix issues preventing pre-review script from running [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 (owner: 10Jdlrobson) [22:47:02] thanks bmansurov! :D [22:47:10] np [22:47:16] (03PS4) 10Jdlrobson: Hide some links from nonjs users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 (owner: 10Bmansurov) [22:49:24] brion: so cool!!!! [22:49:29] bmansurov: i'm reviewing your patch [22:49:42] on second thoughts i don't think we should hide the logout button for non-js [22:49:51] what if you navigate to Special:Userlogin manually? [22:49:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix issues preventing pre-review script from running [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 (owner: 10Jdlrobson) [22:50:11] jdlrobson: you'll have to navigate back to the page you came from :P [22:50:22] mmm i guess [22:50:40] jdlrobson: and why would you navigate to that page when the menu opens on the page you're at [22:50:41] i'm scepticle this is the right thing to do but i'm gonna merge it anyway. [22:51:01] some people might be logged in already [22:51:08] before the change [22:51:27] they can't login if they don't have javascript [22:51:38] if they logged in somehow then the can enable js to see the logout link [22:51:55] jdlrobson: oh isee [22:52:05] bmansurov: you can get to login through search [22:52:34] i think we should show logout button to non-js users. Just not show login [22:52:47] jdlrobson: what does Maryana think? [22:52:47] brion: MWKSection+ImageRecords.m has a couple unused var compiler warnings. are these things ok to worry about later? [22:52:56] i don't know it's an edge case so probably not anything we need to worry about [22:53:09] ok [22:54:27] (03CR) 10Jdlrobson: [C: 032] "As discussed on IRC I find it a bit weird that if you manage to navigate to Special:Userlogin manually you can't logout but let's iterate " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 (owner: 10Bmansurov) [22:55:48] (03Merged) 10jenkins-bot: Hide some links from nonjs users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177089 (owner: 10Bmansurov) [22:57:05] (03PS1) 10Kaldari: Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177683 [22:57:59] brion: getting a nil added to dictionary crash on edit pencil taps... [23:00:13] MaxSem: https://gerrit.wikimedia.org/r/#/c/177683/ per request :) [23:05:06] brion: looks like something with MWKSection index or fromtitle... [23:06:01] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 (owner: 10Jdlrobson) [23:13:47] mhurd: yeah the MWKSection+ImageRecords might actually be redundant as well :) unuised vars should be safe too [23:13:50] lemme check that edit thing [23:14:45] ok that might be because there’s no index on the lede section [23:14:46] lemme test more [23:15:42] hmmmmmms [23:16:18] jdlrobson: should work with mw.config.get( 'wgWikiGrokCampaigns' ); [23:17:32] (03PS2) 10MaxSem: Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177683 (owner: 10Kaldari) [23:18:06] mhurd: found it! wasn’t saving the field correctly [23:18:12] brion: yay! [23:19:17] (03CR) 10MaxSem: "Tweaked the message: don't tell people about experiments ( :P \m/ ), be nice and say "HALP". Feel free to build upon this or revert :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177683 (owner: 10Kaldari) [23:19:36] (03CR) 10Jdlrobson: [C: 032] Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177683 (owner: 10Kaldari) [23:20:15] (03CR) 10Jdlrobson: [C: 032] Hygiene: Refactor WikiGrok code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177418 (owner: 10Bmansurov) [23:20:38] (03CR) 10Jdlrobson: [C: 04-1] "Kaldari says not to touch this code until A/B test is over..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [23:21:00] (03Merged) 10jenkins-bot: Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177683 (owner: 10Kaldari) [23:21:10] (03PS1) 10Brion VIBBER: fix edit [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177689 [23:21:38] (03Merged) 10jenkins-bot: Hygiene: Refactor WikiGrok code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177418 (owner: 10Bmansurov) [23:21:54] brion: awesome! [23:22:18] brion: Ok one more. (sorry! :) So there was a "CoreDataHousekeeping" object which removed unsaved and "unhistoried" article core data. Could you make a version of this object for the new data store which does the same and also prunes oldest article history items (beyond 100 or so)? So it's prune if not saved, or not saved and not in history, or if not saved and past 100 in the history index. Should be pretty slick/simple given the way yo [23:22:19] The beyond 100 trimming is probably pretty needed now that our store data isn't compressed. [23:23:25] mhurd: yeah i’ll poke at that [23:29:07] brion: i think i really convoluted the prune criteria there… take 2: prune if (((history index > 100) || (history index == not found)) && not saved) [23:29:14] brion: does that sound better? [23:29:38] sounds perfect :) [23:30:16] oh good. i re-read what i originally wrote and was like, wtf? [23:36:24] (03PS3) 10Jdlrobson: Hygiene: Fix issues preventing pre-review script from running [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 [23:36:39] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix issues preventing pre-review script from running [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 (owner: 10Jdlrobson) [23:38:12] (03Merged) 10jenkins-bot: Hygiene: Fix issues preventing pre-review script from running [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177679 (owner: 10Jdlrobson) [23:38:31] (03CR) 10Jdlrobson: [C: 04-1] Improve search interaction experience for low end devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen) [23:45:46] (03CR) 10Jdlrobson: [C: 04-1] Promoting WikiGrok to stable and disabling for anons (with flag) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177428 (owner: 10Kaldari) [23:54:06] (03CR) 10MaxSem: [C: 031] Promoting WikiGrok to stable and disabling for anons (with flag) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177428 (owner: 10Kaldari) [23:54:11] jdlrobson, ^^^^ [23:54:17] replied to you