[00:56:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Okay. We should revisit this code at some point though. It seems broken to load these variables on every skin :-/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177428 (owner: 10Kaldari)
[00:58:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Promoting WikiGrok to stable and disabling for anons (with flag) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177428 (owner: 10Kaldari)
[01:25:22] <mhurd>	 vbamba: you around?
[01:50:44] <grrrit-wm>	 (03PS1) 10Jdlrobson: Infoboxes: Use correct urls in infoboxes. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177731 
[01:59:54] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Update jsbeautifyrc to respect new rule I wrote [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174406 (owner: 10Jdlrobson)
[02:12:25] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Make use of disallowOperatorBeforeLineBreak in jscsr [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171617 (owner: 10Jdlrobson)
[02:12:59] <grrrit-wm>	 (03CR) 10Jdlrobson: "bump?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx)
[03:23:13] <grrrit-wm>	 (03PS1) 10BearND: Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 
[03:25:45] <grrrit-wm>	 (03PS2) 10BearND: Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 
[05:09:30] <grrrit-wm>	 (03PS1) 10BearND: More error report content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177744 
[05:10:02] <mhurd>	 bearND: late night too?
[05:10:38] <bearND>	 mhurd: yeah, just trying out a few things
[05:11:15] <mhurd>	 bearND: saw the wikidata patch - can’t wait to update that one too!
[05:11:22] <mhurd>	 the queries
[05:12:03] <bearND>	 mhurd: yeah, the full text search gets the descriptions instantly now :)
[05:12:15] <mhurd>	 bearND: so cool!
[05:13:22] <bearND>	 mhurd: unfortunately, I still need a separate request for the description inside the lead image. I've asked MaxSem via Phabricator if he could hook us up with pageterms in mobileview. Then we wouldn't have to make a separate request for that as well.
[05:14:36] <bearND>	 mhurd: I also simplfied the disambig display code a bit. we first had to get the wikidata IDs, then talk to wikidata to get the descriptions. Now we get the descriptions directly from the wiki
[05:14:44] <mhurd>	 bearND: 5 minutes for quick hangout?
[05:14:52] <bearND>	 mhurd: sure
[05:17:31] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#820600 (10Thnidu) Now the talk page buttons are missing from articles! The only way to get to a talk page in mobile beta now is to edit the URL by hand. (They were there and working before.)
[05:22:44] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#820605 (10Florian)
[05:30:49] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#820617 (10Thnidu) https://en.m.wikipedia.org/wiki/Nathaniel_Goldfinger#/random  https://en.m.wikipedia.org/wiki/KABQ_(AM)#/random  https://en.m.wikipedia.org/wiki/William_Volker#/random  Yes, I found t...
[05:32:22] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#820618 (10Thnidu)
[05:37:21] <bearND>	 mhurd: https://gerrit.wikimedia.org/r/#/c/177397/
[06:16:03] <grrrit-wm>	 (03PS3) 10BearND: Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 
[06:16:27] <bearND>	 mhurd: ^ always adds the description of the clicked on item in full text search to the cache so we don't even try to get it again when the page is opened. 
[06:16:38] <bearND>	 mhurd: Thanks for the hint ;)
[06:16:58] <mhurd>	 bearND: ooh nice!! yw!
[06:17:27] <bearND>	 mhurd: now we just need to get descriptions for title search and do the same then we basically never ask for a description when opening a new page from search
[06:17:45] <mhurd>	 bearND: oh edge case where you may want to get it the old way is if you tap a link rather than a search result
[06:18:01] <bearND>	 mhurd: oh, yeah, that's right
[06:18:12] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#820645 (10Florian)
[06:18:20] <bearND>	 good point, probably happens more often actually
[06:18:35] <mhurd>	 bearND: but at least that’s only going to be for links
[07:26:40] <grrrit-wm>	 (03PS1) 10BearND: Title search gets descriptions, too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177752 
[08:17:46] <joakino_>	 good morning!
[09:09:11] <joakino_>	 phuedx: hey have you managed to get the wgWikiGrokCampaigns working?
[09:09:32] <joakino_>	 i've followed https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing but it is not working :(
[09:27:17] <joakino_>	 phuedx: got it working, 👍
[09:45:26] <wikibugs>	 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#820944 (10TheDJ)
[10:02:47] <phuedx>	 joakino_: i'm just working through that
[10:02:49] <phuedx>	 also, morning
[10:02:56] <joakino_>	 phuedx: morning :)
[10:08:28] <phuedx>	 joakino_: wfm first time
[10:08:30] <phuedx>	 boy am i tired
[10:09:28] <joakino_>	 👍 cool
[10:09:34] <joakino_>	 phuedx: giving you trouble the boys?
[10:10:05] <phuedx>	 yeah
[10:10:12] <phuedx>	 harry didn't want to sleep for most of the night
[10:10:18] <phuedx>	 and i'm on night duty
[10:17:13] <joakino_>	 phuedx: stay strong!
[10:17:25] <joakino_>	 phuedx: good thing you can vary your work hours
[10:21:01] <wikibugs>	 3MobileFrontend-General-or-Unknown: Unregistered editing shouldn't require 3 clicks - https://phabricator.wikimedia.org/T74852#820963 (10Nemo_bis) Should arrive on Wikipedias on December 17, correct?
[10:39:10] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#820985 (10Thnidu) (Facepalm) I wasn't. I don't know how that happened. I am very sorry for wasting your time. :-$
[10:57:14] <wikibugs>	 3MobileFrontend-General-or-Unknown: Unregistered editing shouldn't require 3 clicks - https://phabricator.wikimedia.org/T74852#821005 (10Florian) @Nemo_bis: Correct :) It's already online on beta labs, if you want to test it.
[10:57:45] <wikibugs>	 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#821009 (10Florian) No problem, the main goal is, hat it works, so thanks when you report problems :)
[10:59:39] <wikibugs>	 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#821010 (10Florian)
[11:07:53] <phuedx>	 bleh rebasing
[11:16:46] <grrrit-wm>	 (03PS1) 10Phuedx: Make getWikiGrokVersion promise-based [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177773 
[11:16:48] <grrrit-wm>	 (03PS1) 10Phuedx: Retire WikiGrokAbTest in favour of PlanOut [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177774 
[11:16:50] <grrrit-wm>	 (03PS1) 10Phuedx: Add and register the WikiGrokExperiment experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177775 
[11:18:05] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-2] "DO NOT MERGE. THIS IS AN EXPERIMENT." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177773 (owner: 10Phuedx)
[11:18:14] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-2] "DO NOT MERGE. THIS IS AN EXPERIMENT." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177774 (owner: 10Phuedx)
[11:18:21] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-2] "DO NOT MERGE. THIS IS AN EXPERIMENT." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177775 (owner: 10Phuedx)
[11:18:33] <phuedx>	 ^ i'm a professional
[11:20:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Retire WikiGrokAbTest in favour of PlanOut [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177774 (owner: 10Phuedx)
[11:22:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add and register the WikiGrokExperiment experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177775 (owner: 10Phuedx)
[11:23:21] <grrrit-wm>	 (03PS8) 10Phuedx: Update jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 (owner: 10Jdlrobson)
[11:26:10] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Update jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 (owner: 10Jdlrobson)
[11:26:50] <phuedx>	 so now i don't have an excuse to look at the icon stuff again
[11:26:52] <phuedx>	 ^ joakino_ 
[11:28:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174400 (owner: 10Jdlrobson)
[11:28:55] <joakino_>	 phuedx: why is that?
[11:29:08] <phuedx>	 everything else is reviewed
[11:33:42] <joakino_>	 phuedx: haha
[11:34:00] <joakino_>	 phuedx: im with the freaking header image, async programming is hard
[11:35:11] <grrrit-wm>	 (03PS2) 10Phuedx: Add and register the WikiGrokExperiment experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177775 
[11:35:13] <grrrit-wm>	 (03PS2) 10Phuedx: Retire WikiGrokAbTest in favour of PlanOut [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177774 
[11:36:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add and register the WikiGrokExperiment experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177775 (owner: 10Phuedx)
[11:37:04] <phuedx>	 ^ not seeing that locally, boo
[11:37:12] <phuedx>	 oh well, it's an experiment
[11:37:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Retire WikiGrokAbTest in favour of PlanOut [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177774 (owner: 10Phuedx)
[12:42:50] <grrrit-wm>	 (03CR) 10Phuedx: "Working in stable, beta, and alpha modes." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson)
[12:43:00] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson)
[12:44:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make toggle icon standalone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174633 (owner: 10Jdlrobson)
[12:44:30] <grrrit-wm>	 (03PS2) 10Jhernandez: Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 
[12:44:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez)
[12:44:58] <joakino_>	 jesuschrist...
[12:46:49] <grrrit-wm>	 (03PS3) 10Jhernandez: Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 
[12:47:54] <phuedx>	 joakino_: gonna go out shopping
[12:48:00] <phuedx>	 am cooking a big stew for dinner tonight
[12:48:03] <phuedx>	 bbiab
[12:49:08] <joakino_>	 phuedx: hmm awesome
[12:49:30] <joakino_>	 gotta recommend me some place to go for that when i go to uk
[13:05:07] <joakino_>	 out for lunch
[13:52:42] <phuedx>	 back
[13:52:48] <phuedx>	 hey kristenlans_ 
[13:52:55] <phuedx>	 are you actually here or is it yer irc client?
[13:53:35] <kristenlans_>	 hehe I am here. Heading to yoga class in a few though :-)
[14:15:33] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] More error report content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177744 (owner: 10BearND)
[14:20:34] <PeperPots_>	 got a small request
[14:21:05] <PeperPots_>	 I am requesting that the mobile portal have a link to convert articles to .mobi format for the kindle
[14:49:13] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] Wikidata descriptions retrieved via new PageTerms API (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 (owner: 10BearND)
[15:17:45] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] Title search gets descriptions, too (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177752 (owner: 10BearND)
[15:18:09] <grrrit-wm>	 (03PS1) 10Dbrant: Support the latest Gradle plugin in updated Android Studio. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177803 
[15:23:48] <grrrit-wm>	 (03PS2) 10Dbrant: Support the latest Gradle plugin in updated Android Studio. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177803 
[15:26:13] <joakino_>	 PeperPots_: I don't think that is a focus of the mobile web, why don't you try using some service that converts websites to ebooks? for example http://dotepub.com/converter/?lang=en
[15:35:32] <grrrit-wm>	 (03PS3) 10Dbrant: Support the latest Gradle plugin in updated Android Studio. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177803 
[15:56:42] <grrrit-wm>	 (03PS4) 10BearND: Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 
[16:05:22] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update .rubocop_todo file for latest rubocop version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177819 
[16:08:53] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: update .rubocop_todo file for latest rubocop version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177819 (owner: 10Cmcmahon)
[16:10:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: update .rubocop_todo file for latest rubocop version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177819 (owner: 10Cmcmahon)
[16:13:26] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: updating rubocop offenses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177821 
[16:14:15] <grrrit-wm>	 (03PS2) 10Cmcmahon: QA: updating rubocop offenses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177821 
[16:15:47] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: updating rubocop offenses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177821 (owner: 10Cmcmahon)
[16:18:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: updating rubocop offenses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177821 (owner: 10Cmcmahon)
[16:19:23] <grrrit-wm>	 (03PS2) 10BearND: Title search gets descriptions, too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177752 
[16:19:25] <grrrit-wm>	 (03PS5) 10BearND: Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 
[16:20:50] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: update for spaces inside parens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177822 
[16:22:06] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: rubocop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177823 
[16:24:11] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: space around operators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177824 
[16:25:00] <kristenlans_>	 phuedx now I am here 4 realZ (FYI)
[16:25:08] <phuedx>	 o/ kristenlans_
[16:25:23] <phuedx>	 i am just checking on the status of my stew
[16:25:34] <phuedx>	 (and possibly making dumplings if the timing is right)
[16:25:42] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: space after colon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177825 
[16:27:52] <kristenlans_>	 phuedx sounds tasty :D
[16:28:10] <joakino_>	 phuedx: have you set up limn and limn-mobile-data locally?
[16:28:17] <phuedx>	 joakino_: no
[16:28:18] <phuedx>	 kristenlans_: hopefully!
[16:28:29] <phuedx>	 have some old friends coming round to meet harry
[16:28:49] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: favor unless over if-not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177827 
[16:29:10] <joakino_>	 k
[16:29:51] <milimetric>	 joakino_: need help with it or just asking?
[16:30:08] <joakino_>	 milimetric: i'm stuck at the last steps, generating data
[16:30:13] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: unnecessary parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177828 
[16:31:17] <joakino_>	 milimetric: i've run scripts/ssh on one terminal and `python generate.py -c scripts/config.yaml mobile -g ui-daily` on another, and it has been generating data for a loooooooot of time
[16:31:46] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: missing space after comment # character [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177829 
[16:33:06] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: indentation width fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177830 
[16:34:35] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: use modern hash syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177831 
[16:36:42] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: fix unneeded empty line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177832 
[16:38:28] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: fix unnecessary braces for hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177834 
[16:41:52] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: remove unused argument for do block [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177835 
[16:43:02] <milimetric>	 joakino_: i see.  maybe just use the already generated data: http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/
[16:43:16] <milimetric>	 i guess, why are you trying to generated data?
[16:43:23] <milimetric>	 just to render the graphs locally or to test new sql?
[16:43:26] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: rubocop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177823 (owner: 10Cmcmahon)
[16:43:33] <joakino_>	 milimetric: oh handy, thx
[16:43:44] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: prefer single quotes to double quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177836 
[16:43:54] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: space around operators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177824 (owner: 10Cmcmahon)
[16:44:37] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: space after colon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177825 (owner: 10Cmcmahon)
[16:45:04] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: favor unless over if-not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177827 (owner: 10Cmcmahon)
[16:45:32] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: unnecessary parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177828 (owner: 10Cmcmahon)
[16:46:29] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: missing space after comment # character [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177829 (owner: 10Cmcmahon)
[16:47:10] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: indentation width fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177830 (owner: 10Cmcmahon)
[16:47:56] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: use modern hash syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177831 (owner: 10Cmcmahon)
[16:48:24] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: fix unneeded empty line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177832 (owner: 10Cmcmahon)
[16:49:07] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: remove unused argument for do block [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177835 (owner: 10Cmcmahon)
[16:49:43] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: update for spaces inside parens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177822 (owner: 10Cmcmahon)
[16:50:21] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: fix unnecessary braces for hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177834 (owner: 10Cmcmahon)
[16:51:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: update for spaces inside parens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177822 (owner: 10Cmcmahon)
[16:51:50] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] QA: prefer single quotes to double quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177836 (owner: 10Cmcmahon)
[16:54:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: rubocop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177823 (owner: 10Cmcmahon)
[16:56:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: space around operators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177824 (owner: 10Cmcmahon)
[16:56:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: space after colon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177825 (owner: 10Cmcmahon)
[16:56:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: favor unless over if-not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177827 (owner: 10Cmcmahon)
[16:56:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: unnecessary parentheses [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177828 (owner: 10Cmcmahon)
[16:56:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: missing space after comment # character [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177829 (owner: 10Cmcmahon)
[16:56:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: indentation width fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177830 (owner: 10Cmcmahon)
[16:56:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: use modern hash syntax [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177831 (owner: 10Cmcmahon)
[16:56:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: fix unneeded empty line [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177832 (owner: 10Cmcmahon)
[16:56:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: fix unnecessary braces for hash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177834 (owner: 10Cmcmahon)
[16:57:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: remove unused argument for do block [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177835 (owner: 10Cmcmahon)
[16:58:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: prefer single quotes to double quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177836 (owner: 10Cmcmahon)
[16:59:55] <Krenair>	 mobile queue is on 16 open tickets (2 pages)
[17:00:17] <Krenair>	 that's all stuff that's not related to a specific ios/android app
[17:02:46] <wikibugs>	 3MobileFrontend-Feature-requests: Provide a button to convert articles to .mobi format for the Kindle - https://phabricator.wikimedia.org/T76869 (10phuedx) 3NEW p:3Triage
[17:03:20] <phuedx>	 PeperPots_: i've converted your feature request to a phabricator task ^
[17:03:32] <phuedx>	 it'll be triaged by the mobile web team in today's stand up meeting
[17:03:39] <phuedx>	 which will happen in about an hour
[17:05:22] <wikibugs>	 3MobileFrontend-Feature-requests: Add pageterms to mobileview API - https://phabricator.wikimedia.org/T76870 (10phuedx) 3NEW p:3Triage
[17:23:04] <grrrit-wm>	 (03PS6) 10Florianschmidtwelzow: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 
[17:23:59] * jdlrobson2 waves
[17:24:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow)
[17:26:51] <grrrit-wm>	 (03PS7) 10Florianschmidtwelzow: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 
[17:27:45] * FlorianSW waves back
[17:28:19] <FlorianSW>	 jdlrobson: hi :) Can you (adhoc) say, for what this rule was added? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/less/ui.less#L314
[17:29:08] <dbrant>	 bearND: mind checking this out: https://gerrit.wikimedia.org/r/177803  so that we can upgrade Android Studio
[17:29:59] <bearND>	 dbrant: sure
[17:30:11] <wikibugs>	 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#821606 (10Florian)
[17:30:41] <bearND>	 dbrant: what version of AS have you  installed?
[17:31:07] <dbrant>	 bearND: it upgraded itself to 1.0 rc4
[17:31:52] <bearND>	 dbrant: hmmm, weird, i did check for update once and it offered 1.0 rc4, then I repeated and it offered 0.9.9
[17:32:30] <dbrant>	 bearND: ah yes, it upgraded to 0.9.9, as an intermediate step to upgrading to 1.0rc4
[17:32:51] <bearND>	 dbrant: i see
[17:33:11] <jdlrobson2>	 FlorianSW: looking
[17:33:38] <FlorianSW>	 jdlrobson2: thanks :)
[17:33:41] <jdlrobson2>	 FlorianSW: i suspect it is either cta drawer or watchlist
[17:34:21] <FlorianSW>	 jdlrobson2: on drawer it will break mw-ui-button-groups, there is a space between the buttons :/
[17:35:58] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Alpha: Add possibility to change font size of the content (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow)
[17:42:02] <phuedx>	 hey jdlrobson
[17:42:06] * phuedx waves back
[18:10:04] <grrrit-wm>	 (03PS4) 10BearND: Support the latest Gradle plugin in updated Android Studio. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177803 (owner: 10Dbrant)
[18:10:11] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Support the latest Gradle plugin in updated Android Studio. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177803 (owner: 10Dbrant)
[18:10:53] <bearND>	 dbrant: sorry. it took a long time downloading all the stuff
[18:11:03] <dbrant>	 bearND: np, thanks!
[18:11:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support the latest Gradle plugin in updated Android Studio. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177803 (owner: 10Dbrant)
[18:15:01] <bearND>	 dbrant: i've updated my two description patches btw
[18:15:13] <dbrant>	 bearND: yep, will look
[18:15:56] <grrrit-wm>	 (03PS6) 10Dbrant: Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 (owner: 10BearND)
[18:25:49] <wikibugs>	 3Wikipedia-App-General-or-Unknown: Disable translations to wuu and lzh? - https://phabricator.wikimedia.org/T75295#821739 (10bearND) 5Open>3Resolved a:3bearND I guess not.
[18:29:00] <wikibugs>	 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#821750 (10Jaredzimmerman-WMF)
[18:33:27] <grrrit-wm>	 (03PS8) 10BearND: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[18:33:37] <grrrit-wm>	 (03PS8) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[18:33:44] <grrrit-wm>	 (03PS5) 10BearND: Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 (owner: 10Dbrant)
[18:35:26] <Deskana>	 kristenlans_: "Thank you, guys."
[18:35:28] <Deskana>	 kristenlans_: "Thank you, guys."
[18:35:30] <Deskana>	 kristenlans_: "Thank you, guys."
[18:35:32] <Deskana>	 kristenlans_: "Thank you, guys."
[18:35:35] <Deskana>	 (the skipping bug happened again)
[18:35:37] <Deskana>	 :)
[18:35:37] <Maryana>	 hey joakino - you around for a bit longer today?
[18:36:03] <joakino_>	 Maryana: do you need something?
[18:36:29] <Maryana>	 monte from the apps team wanted to check with you about lead image styling css
[18:36:45] <Maryana>	 hang on, he's still getting online :)
[18:37:05] <joakino_>	 joakino: oki
[18:37:41] <Maryana>	 mhurd: joakino_ talk amongst yourselves ;)
[18:37:50] <joakino_>	 mhurd: hi! 👋
[18:38:44] <jdlrobson>	 joakino_: hey, if there are issues with the image styling
[18:38:50] <jdlrobson>	 i assume it's okay for me to fix them up?
[18:39:11] <joakino_>	 jdlrobson: sure!
[18:39:17] <jdlrobson>	 sweet :)
[18:39:17] <joakino_>	 jdlrobson: anything wrong?
[18:39:31] <joakino_>	 jdlrobson: i'm supposed to talk with mhurd now about that
[18:39:43] <jdlrobson>	 joakino_: no idea. just looking now :)
[18:39:58] <joakino_>	 ah ok :p
[18:40:01] <jdlrobson>	 The use of md5fn is going to be problematic if we ever want to push this to beta though
[18:40:10] <grrrit-wm>	 (03CR) 10Bmansurov: Improve [Alpha page styling experiment] Image at top (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez)
[18:40:11] <jdlrobson>	 that library is only temporary for infobox code
[18:40:18] <joakino_>	 jdlrobson: background-size: cover is going to be problematic with older devices..., but it is beta now
[18:40:24] <jdlrobson>	 true
[18:40:31] <joakino_>	 sorry alpha
[18:40:40] <mhurd>	 joakino: hey! so apps uses parts the mobile web css (mediawiki/extensions/MobileApp). we are already doing lead image styling and are using native components to do so for a variety of reasons. just wanted to make sure that we don’t suddenly see doubled-up lead image styling :)
[18:40:52] <joakino_>	 jdlrobson: yeah it is all a bit delicate
[18:41:03] <mhurd>	 jdlrobson: ^
[18:41:43] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Wikidata descriptions retrieved via new PageTerms API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177740 (owner: 10BearND)
[18:42:02] <joakino_>	 jdlrobson: mhurd i think jdlrobson or kaldari will answer that better than me
[18:42:15] <grrrit-wm>	 (03PS3) 10Dbrant: Title search gets descriptions, too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177752 (owner: 10BearND)
[18:42:17] <joakino_>	 mhurd: if you don't execute JS nothing should happen
[18:42:24] <joakino_>	 mhurd: and it is only in alpha
[18:42:34] <joakino_>	 mhurd: so i guess it is fine?
[18:43:28] <mhurd>	 joakino_: oh cool - we do only our own js, so that shouldn’t affect us :)
[18:44:26] <joakino_>	 mhurd: about the css, there is a bit of styling for this selector .wikidata-banner-image
[18:45:00] <joakino_>	 mhurd: if you guys are using that css selector too, then cheers for us all haha
[18:45:14] <mhurd>	 joakino_: is that a new selector?
[18:45:15] <jdlrobson>	 joakino_: any reason why phantomjs keeps downloading every time i run npm install?
[18:45:22] <jdlrobson>	 PhantomJS detected, but wrong version 1.9.7 @ /opt/local/bin/phantomjs.
[18:45:51] <joakino_>	 jdlrobson: brew upgrade phantomjs ?
[18:46:08] <jdlrobson>	 joakino_: nope. something odd going on
[18:46:18] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Use .background-size for cover [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177855 
[18:47:09] <joakino_>	 jdlrobson: WAT is that ^
[18:47:12] <joakino_>	 black magic
[18:47:34] <joakino_>	 mhurd: yeah the new selector related to the header image
[18:47:52] <joakino_>	 mhurd: do you load mobilefrontend css?
[18:48:42] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Title search gets descriptions, too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177752 (owner: 10BearND)
[18:49:38] <mhurd>	 joakino_: is the header image html new? here’s what we load iirc: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileApp/767c7a36201aac3e42ceb09c152d8563fa35ca77/MobileApp.php
[18:49:52] <grrrit-wm>	 (03PS9) 10BearND: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[18:50:09] <jdlrobson>	 joakino_: lolz
[18:50:18] <jdlrobson>	 joakino_: feel free to merge it into your patch lol
[18:50:44] <joakino_>	 jdlrobson: i'm going to leave and have a big drink
[18:50:55] <jdlrobson>	 joakino_: sounds good.
[18:50:58] <jdlrobson>	 joakino_: enjoy monday
[18:50:59] <joakino_>	 i'll finish it up on monday limbo time
[18:51:04] <jdlrobson>	 just don't have your own immaculate conception
[18:51:19] <joakino_>	 jdlrobson: xD lets hope not
[18:51:34] <joakino_>	 mhurd:  hahah // FIXME: This is crazy. Don't do this. Use $wgResourceLoaderLESSImportPaths. 
[18:52:05] <joakino_>	 mhurd: you guys are fine, not loading that CSS or JS so no problem, the html is exactly the same
[18:52:47] <mhurd>	 joakino_: hehe that reminds me, lego has a patch that fixes the FIXME :) https://gerrit.wikimedia.org/r/#/c/152838/
[18:53:09] <mhurd>	 Deskana: ^ can we chat about this patch later?
[18:53:38] <Deskana>	 mhurd: Sure.
[18:53:45] <mhurd>	 joakino_: great! thanks for the info :)
[18:55:37] <Deskana>	 mhurd: Maybe we should just grab James (since he +1'd it) and chat about it now?
[18:55:48] <mhurd>	 Deskana: sure!
[18:57:06] <joakino_>	 bb people, have a nice weekend
[18:59:27] <legoktm>	 :o
[18:59:31] <legoktm>	 I wrote that a long time ago
[19:00:07] <legoktm>	 I don't think that actually fixed the fixme though?
[19:00:47] <jdlrobson>	 joakino: heh i wrote that comment
[19:03:21] <grrrit-wm>	 (03PS1) 10Jdlrobson: Stop npm install downloading phantomjs every time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177860 
[19:06:06] <Deskana>	 dbrant: Do you think you could rebase/review this? https://gerrit.wikimedia.org/r/#/c/152838/
[19:06:59] <dbrant>	 Deskana: sure, i'll check it out
[19:07:08] <mhurd>	 brion: code review time!
[19:07:16] <brion>	 \o/
[19:07:50] <mhurd>	 brion: how do recommend we go about this. should it be squashed down?
[19:08:03] <brion>	 mhurd: ?
[19:08:18] <mhurd>	 brion: quick hangout?
[19:08:22] <brion>	 sure
[19:10:24] <brion>	 whee
[19:10:29] <mhurd>	 :)
[19:13:41] <jdlrobson>	 kristenlans_: what's the url you use in standup for bug triaging?
[19:14:26] <grrrit-wm>	 (03PS10) 10BearND: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[19:17:22] <wikibugs>	 3MobileFrontend-Uploads, Mobile-Web: upload image button cursor is not a pointer - https://phabricator.wikimedia.org/T75804#821869 (10Jdlrobson)
[19:17:33] <wikibugs>	 3MobileFrontend-Uploads, Mobile-Web: upload image button cursor is not a pointer - https://phabricator.wikimedia.org/T75804#821871 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[19:17:54] <Deskana>	 dbrant: The r key is broken on this phone. The funny thing? It's the keyboard provided by the OS.
[19:17:56] <Deskana>	 dbrant: 2.3, man.
[19:18:12] <kristenlans_>	 jdlrobson: https://phabricator.wikimedia.org/maniphest/query/U1SHkqqzjg84/
[19:18:30] <jdlrobson>	 kristenlans_: i'm setting up a board i think it will be better for triage
[19:18:31] <jdlrobson>	 thoughts?
[19:18:48] <dbrant>	 Deskana: lol what phone is that?
[19:18:59] <kristenlans_>	 jdlrobson: but each time I update the "Created After" field to the date of the last bug we traiged
[19:19:26] <jdlrobson>	 https://phabricator.wikimedia.org/project/board/67/ < kristenlans_
[19:19:48] <Deskana>	 dbrant: It's a Nexus S I think
[19:23:38] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "Still needs logging; Jon: Can we reuse MobileWebClickTracking for it (three (maybe four, if we want to log the tap on the link, too) new e" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow)
[19:25:18] <wikibugs>	 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#821909 (10Florian) @Jaredzimmerman-WMF: Added your suggestions to the change and will add it in a new patchset, after i know, which logging schema we should use :)
[19:26:06] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#821910 (10Jdlrobson) #Mobile-Web
[19:26:11] <kristenlans_>	 jdlrobson: I think that could make things easier.
[19:26:17] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Talk overlay conflicts with OverlayManager hide delay - https://phabricator.wikimedia.org/T66105#821912 (10Jdlrobson)
[19:26:29] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Wikgrok A and B trigger API request on every page load - https://phabricator.wikimedia.org/T74796#821914 (10Jdlrobson) #Mobile-Web
[19:26:33] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Can't scroll in edit mode - https://phabricator.wikimedia.org/T75255#821916 (10Jdlrobson)
[19:27:21] <wikibugs>	 3MobileFrontend-stable, Mobile-Web, Design: List of languages looks strange when mixes RTL and LTR languages - https://phabricator.wikimedia.org/T66617#821918 (10Jdlrobson) #Mobile-Web
[19:27:34] <wikibugs>	 3MobileFrontend-General-or-Unknown: Search broken on mobile web on Android 2.3 - https://phabricator.wikimedia.org/T76882#821921 (10Deskana)
[19:27:39] <kristenlans_>	 We'll need to add in all the projects (mobile-frontend alpha, etc.), as they don't all automatically appear under the Mobile Web team project.
[19:27:42] <mhurd>	 brion: one more quick hangout?
[19:27:50] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: Alpha back button tap area of overlays is smaller - https://phabricator.wikimedia.org/T75535#821928 (10Jdlrobson) #Mobile-Web
[19:27:54] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: Table of contents icon in alpha is small and not aligned correctly - https://phabricator.wikimedia.org/T75115#821930 (10Jdlrobson)
[19:28:00] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: Pencil icon is preloaded locked - https://phabricator.wikimedia.org/T74851#821933 (10Jdlrobson) #Mobile-Web
[19:28:04] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: File Chooser dialog opens when clicked anywhere on the page - https://phabricator.wikimedia.org/T74827#821935 (10Jdlrobson) #Mobile-Web
[19:28:08] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: WikiGrok v. B should show more than 1 tag per line - https://phabricator.wikimedia.org/T74631#821937 (10Jdlrobson) #Mobile-Web
[19:28:14] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: "Template: refimprove section" not displaying in mobile beta - https://phabricator.wikimedia.org/T76678#821939 (10Jdlrobson) #Mobile-Web
[19:28:18] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Search field inaccessible on Opera Mini - https://phabricator.wikimedia.org/T75632#821941 (10Jdlrobson) #Mobile-Web
[19:28:23] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Swiping in the edit screen blanks the screen - https://phabricator.wikimedia.org/T75046#821943 (10Jdlrobson) #Mobile-Web
[19:28:26] <kristenlans_>	 jdlrobson: also, I DID lobby Maryana to possibly include Phabello in our next sprint, so we maybe talking about that on Monday :D cc: bmansurov, who I think was interested in Phabello.
[19:28:31] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Nearby doesn't remember back behaviour - https://phabricator.wikimedia.org/T74486#821945 (10Jdlrobson) #Mobile-Web
[19:28:45] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Nearby doesn't remember back behaviour - https://phabricator.wikimedia.org/T74486#821947 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[19:28:50] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: "Desktop" link doesn't work on User pages on mobile - https://phabricator.wikimedia.org/T74323#821949 (10Jdlrobson) #Mobile-Web
[19:29:14] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: only top 50 articles on my watchlist show page images - https://phabricator.wikimedia.org/T73961#821951 (10Jdlrobson) Still seems to be an issue with this. The hook is not working correctly. #Mobile-Web
[19:29:14] <bmansurov>	 kristenlans_: yes, it would be great if we can get it working asap
[19:29:26] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Talk: "Return to "Foo" page." appears on talk page needs design love - https://phabricator.wikimedia.org/T73919#821960 (10Jdlrobson)
[19:29:30] <Maryana>	 phabello!
[19:29:30] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Login form duplicate messages - https://phabricator.wikimedia.org/T73771#821962 (10Jdlrobson) #Mobile-Web
[19:29:43] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: IE8 background sizes - https://phabricator.wikimedia.org/T72961#821970 (10Jdlrobson) #Mobile-Web
[19:29:43] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: WikiGrok v. B should show more than 1 tag per line - https://phabricator.wikimedia.org/T74631#821974 (10kaldari) 5Open>3Resolved a:3kaldari
[19:29:55] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Going back to previous page doesn't remember expanded sections - https://phabricator.wikimedia.org/T71351#821976 (10Jdlrobson) #Mobile-Web
[19:29:57] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: No placeholders on account creation or login forms in Opera Mini - https://phabricator.wikimedia.org/T70758#821978 (10Jdlrobson) #Mobile-Web
[19:30:07] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Hide details Overlay in MediaViewer after tap on screen - https://phabricator.wikimedia.org/T70504#821980 (10Jdlrobson) #Mobile-Web
[19:30:37] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Text does not appear in the place of icons when images are disabled - https://phabricator.wikimedia.org/T69726#821989 (10Jdlrobson)
[19:30:58] <kristenlans_>	 bmansurov: I talked to awjr (original creator of Bugello) about it a bit last week, and he didn't think it would be *too* hard to do.
[19:31:04] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - https://phabricator.wikimedia.org/T56885#821993 (10Jdlrobson) #Mobile-Web
[19:31:23] <bmansurov>	 kristenlans_: 👍
[19:31:39] <dbrant>	 Deskana: mhurd: https://gerrit.wikimedia.org/r/152838
[19:31:41] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: Table of contents icon in alpha is small and not aligned correctly - https://phabricator.wikimedia.org/T75115#821996 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[19:31:50] <brion>	 mhurd: moment, bacon cooking :)
[19:31:58] <Deskana>	 dbrant: So the next thing is, how do we test that this works?
[19:32:14] <dbrant>	 Deskana: use it locally in vagrant
[19:32:43] <Deskana>	 dbrant: James_F suggested merging, which will cause it to go live to the beta cluster within 5 minutes, but not live to production until next Wednesday.
[19:32:50] <Deskana>	 dbrant: Then point the app at the beta cluster instead, to see what happens.
[19:33:41] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: No placeholders on account creation or login forms in Opera Mini - https://phabricator.wikimedia.org/T70758#822021 (10Jdlrobson)
[19:33:44] <brion>	 mhurd: ok
[19:34:01] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: "Read in another language" gives desktop site's links - https://phabricator.wikimedia.org/T67047#822022 (10Jdlrobson)
[19:34:04] <Deskana>	 dbrant: I'll leave that to you, anyway. :)
[19:34:06] <Deskana>	 dbrant: Thanks!
[19:34:15] <grrrit-wm>	 (03PS11) 10BearND: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[19:34:47] <mhurd>	 brion: hmm can’t remember the question i had… :)
[19:34:53] <brion>	 hehe
[19:35:07] <mhurd>	 brion: coffeeeeeee!!!!
[19:35:10] <awjr>	 bmansurov: i am happy to answer any q's - also jdlrobson and spagewmf have some experience with the code base
[19:35:15] <dbrant>	 Deskana: yeah that could work, too (point the app at beta cluster), but I've already verified it with vagrant, which uses the same url.
[19:35:32] <bmansurov>	 awjr: thanks, i'll ping you once I start working on it ;)
[19:35:38] <Deskana>	 dbrant: Well, if you're sure, then go for it. :)
[19:37:00] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Hide details Overlay in MediaViewer after tap on screen - https://phabricator.wikimedia.org/T70504#822035 (10Jdlrobson)
[19:37:10] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Hide details Overlay in MediaViewer after tap on screen - https://phabricator.wikimedia.org/T70504#822037 (10Jdlrobson)
[19:37:43] <dbrant>	 kristenlans_: <3
[19:38:09] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Talk overlay conflicts with OverlayManager hide delay - https://phabricator.wikimedia.org/T66105#822042 (10Jdlrobson)
[19:38:39] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#750326 (10Jdlrobson)
[19:38:43] <wikibugs>	 3MobileFrontend-Uploads, MobileFrontend-alpha, Mobile-Web: File Chooser dialog opens when clicked anywhere on the page - https://phabricator.wikimedia.org/T74827#822049 (10Jdlrobson)
[19:38:46] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: Pencil icon is preloaded locked - https://phabricator.wikimedia.org/T74851#822054 (10Jdlrobson)
[19:38:54] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Special:Userprofile does not currently work on desktop. - https://phabricator.wikimedia.org/T74323#822056 (10Jdlrobson)
[19:38:57] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Special:Userprofile does not currently work on desktop. - https://phabricator.wikimedia.org/T74323#765147 (10Jdlrobson) It's by design. If someone wants to enable it and put some time into making sure it renders nicely on the Vector skin be my guest but it's not clear what it...
[19:39:00] <mhurd>	 brion: oh could you a quick patch to change any “#include” to “#import”. i think there’s only one or 2
[19:39:00] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Special:Userprofile does not currently work on desktop. - https://phabricator.wikimedia.org/T74323#822067 (10Jdlrobson)
[19:39:04] <brion>	 ah woops
[19:40:04] <grrrit-wm>	 (03PS1) 10Brion VIBBER: kill the last #include with #import [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177866 
[19:40:15] <mhurd>	 brion: hehe thanks
[19:40:18] <brion>	 :D
[19:45:52] <mhurd>	 brion: thoughts on moving all the legacy core data objects to a “CoreDataLegacy” sub-project? maybe as part of import patch?
[19:46:20] <brion>	 mhurd: hmmmmm, should be doable yeah
[19:46:27] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Text does not appear in the place of icons when images are disabled - https://phabricator.wikimedia.org/T69726#822192 (10Jdlrobson) In alpha they have title attributes now but no text labels. Personally I think showing the labels themselves is more trouble than it is worth, so...
[19:46:40] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Text does not appear in the place of icons when images are disabled - https://phabricator.wikimedia.org/T69726#822201 (10Jdlrobson)
[19:48:09] <mhurd>	 brion: yeah may be nice to sandbox the cruft for now with an explicitly crufty sub-project name so new folks are less tempted to use old core data stuffs… 
[19:49:52] <grrrit-wm>	 (03CR) 10Kaldari: "MaxSem: Do you need any more feedback on this?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem)
[19:52:18] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: "Template: refimprove section" not displaying in mobile beta - https://phabricator.wikimedia.org/T76678#822288 (10Jdlrobson) 5Open>3declined a:3Jdlrobson We only show cleanup templates at the top of the page on mobile (and we collapse them into 'This page has issues' sec...
[19:54:52] <Deskana>	 kristenlans_: Iteration review has just disappeared from my calendar this afternoon. :/
[19:55:04] <kristenlans_>	 uhoh
[19:55:04] <kristenlans_>	 hmm me too!
[19:55:09] <wikibugs>	 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#822322 (10Quiddity)
[19:55:14] <mhurd>	 brion: can you check one more thing - in the big patch it looks like “CoreDataHousekeeping” is still being instanced in the historyviewcontroller. did any of the latter patches remove this?
[19:56:21] <kristenlans_>	 Deskana shoudl be back :-)
[19:56:52] <Deskana>	 kristenlans_: Thanks. :)
[19:56:52] <kristenlans_>	 Deskana you'll see I also changed the time permanently going forward so we can avoid that metrics clash we keep having
[19:56:58] <Deskana>	 kristenlans_: Cool. Thanks!
[19:58:32] <brion>	 mhurd: i think it’s still there, but its contents are all commented out
[19:58:47] <mhurd>	 brion: ah cool thx
[19:58:47] <brion>	 mhurd: needs to be replaced with a new housekeeping class that does the equivalent on the new data store
[19:59:39] <mhurd>	 brion: sounds good
[19:59:51] <mhurd>	 brion: almost through the big patch...
[20:00:21] <brion>	 whee
[20:02:03] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Talk overlay conflicts with OverlayManager hide delay - https://phabricator.wikimedia.org/T66105#822380 (10Florian) Unhappily yes. You can reproduce it by going to a page with talkOverlay, open the overlay, click "add discussion" and hit return (or click back in your browser) wi...
[20:04:26] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 
[20:04:56] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 
[20:05:31] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "Needs clarification what is meant with "animations" to wait for." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow)
[20:11:50] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Let's do this!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177281 (owner: 10Brion VIBBER)
[20:12:29] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177289 (owner: 10Brion VIBBER)
[20:13:27] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177296 (owner: 10Brion VIBBER)
[20:13:54] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177297 (owner: 10Brion VIBBER)
[20:14:30] <brion>	 woooo
[20:15:25] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177374 (owner: 10Brion VIBBER)
[20:15:51] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177380 (owner: 10Brion VIBBER)
[20:16:08] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177391 (owner: 10Brion VIBBER)
[20:16:15] * brion dances for joy
[20:16:23] <mhurd>	 brion: :)
[20:16:42] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177404 (owner: 10Brion VIBBER)
[20:17:07] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177407 (owner: 10Brion VIBBER)
[20:18:12] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177415 (owner: 10Brion VIBBER)
[20:18:38] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177426 (owner: 10Brion VIBBER)
[20:18:54] <brion>	 i find myself thinking of the guy on one of those storage wars shows that bids on the auctions with “YYYYYUUUUUUP”
[20:19:02] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177436 (owner: 10Brion VIBBER)
[20:19:09] <mhurd>	 hehe
[20:19:16] <Deskana>	 CODE REVIEW +YUP
[20:19:54] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177444 (owner: 10Brion VIBBER)
[20:22:37] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177493 (owner: 10Brion VIBBER)
[20:23:07] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177553 (owner: 10Brion VIBBER)
[20:23:41] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177555 (owner: 10Brion VIBBER)
[20:25:13] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177613 (owner: 10Brion VIBBER)
[20:25:34] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177658 (owner: 10Brion VIBBER)
[20:25:59] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177659 (owner: 10Brion VIBBER)
[20:26:25] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177661 (owner: 10Brion VIBBER)
[20:26:56] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177676 (owner: 10Brion VIBBER)
[20:26:59] <Deskana>	 The yup continues.
[20:27:05] <mhurd>	 yup
[20:27:34] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177677 (owner: 10Brion VIBBER)
[20:27:53] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177680 (owner: 10Brion VIBBER)
[20:28:16] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177689 (owner: 10Brion VIBBER)
[20:28:30] <brion>	 will this never ennddddddd
[20:28:52] <grrrit-wm>	 (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177866 (owner: 10Brion VIBBER)
[20:29:09] <kaldari>	 mhurd: What have you done?
[20:29:11] <mhurd>	 brion: that’s it :)
[20:29:14] <brion>	 \o/ wooooooooo
[20:29:54] <mhurd>	 brion: ok foods :)
[20:29:58] <brion>	 thanks mhurd :D
[20:30:13] <mhurd>	 brion: great stuff! :)
[20:40:01] <grrrit-wm>	 (03CR) 10MaxSem: "After more iterations on it:)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem)
[20:42:33] <grrrit-wm>	 (03PS4) 10Jdlrobson: Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez)
[20:43:42] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Hygiene: Use .background-size for cover [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177855 (owner: 10Jdlrobson)
[20:43:47] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez)
[20:44:50] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#822535 (10Jdlrobson)
[20:47:15] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Swiping in the edit screen blanks the screen - https://phabricator.wikimedia.org/T75046#822549 (10Jdlrobson)
[20:51:46] <grrrit-wm>	 (03PS12) 10BearND: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[20:56:47] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[20:57:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add native component to the bottom of WebView content. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174130 (owner: 10Dbrant)
[20:57:45] <Deskana>	 aww yiss
[21:19:06] <MaxSem>	 kaldari, remind me plz where are there still WG questions left? :P
[21:21:08] <kaldari>	 MaxSem: On en.wiki, it looks like the old campaigns are still functioning, but you have to append 'wikigrokversion=X' to load them. On Beta Labs, only the Wolf City aricle has WikiGrok questions.
[21:22:28] <kaldari>	 Maryana: Wanna look at my proposed announcement for the Wikidata community and see what should be tweaked?
[21:22:55] <grrrit-wm>	 (03PS9) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[21:23:19] <grrrit-wm>	 (03PS10) 10BearND: Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 
[21:24:23] <grrrit-wm>	 (03PS6) 10BearND: Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 (owner: 10Dbrant)
[21:25:02] <bearND>	 dbrant|brb: https://gerrit.wikimedia.org/r/#/c/174821/ is now ready for your review
[21:25:21] <dbrant|brb>	 bearND: yay!
[21:26:20] <Deskana>	 aww yiss
[21:26:24] <bearND>	 dbrant|brb: rebasing this was a major pain
[21:26:50] <dbrant>	 oh right! wikidata stuff
[21:27:03] <bearND>	 yup
[21:27:35] <bearND>	 dbrant: once we got this merged I'll try to refactor some some
[21:27:46] <bearND>	 some more
[21:29:32] <grrrit-wm>	 (03PS1) 10Bmansurov: Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 
[21:29:44] <bmansurov>	 jdlrobson: please review if you have time ^
[21:29:46] <wikibugs>	 3MobileFrontend-General-or-Unknown: cannot edit a page through MobileFrontend despite being logged-in and having appropriate permissions - https://phabricator.wikimedia.org/T74877#822628 (10Jdlrobson) Amir can you paste ``` mw.mobileFrontend.getCurrentPage().isEditable( mw.user).done( function(r) { console.log(r...
[21:30:30] <kristenlans_>	 Deskana et al, the only rooms that are available for iteration review today are mushroom kingdom and chambers, which are both pretty small :-( Do you have a preference :-/
[21:33:21] <jdlrobson>	 bmansurov: have created a new card in trello which will list bugs that you can work on :)
[21:33:31] <Deskana>	 kristenlans_: Chambers is large!
[21:33:31] <jdlrobson>	 will look at your patch in a bit :)
[21:33:36] <bmansurov>	 jdlrobson: thanks
[21:34:05] <jdlrobson>	 bmansurov: also if you want to fix robs patch since he's out - https://gerrit.wikimedia.org/r/#/c/177136/
[21:34:09] <jdlrobson>	 would be good to wrap that up!
[21:35:12] <kristenlans_>	 Deskana: oh, than we're good! :-)
[21:35:15] <wikibugs>	 3MobileFrontend-alpha, Mobile-Web: Alpha back button tap area of overlays is smaller - https://phabricator.wikimedia.org/T75535#822630 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Can't replicate any more.
[21:35:49] <bmansurov>	 jdlrobson: ok i will
[21:36:51] <grrrit-wm>	 (03PS1) 10Jdlrobson: Pre-commit hook: Check jsdoc coverage of any touched files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177883 
[21:36:54] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Complete jsdoc for application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177884 
[21:37:40] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Display native Read more section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174821 (owner: 10BearND)
[21:38:52] <Deskana>	 kristenlans_: Ah, no, we don't have Chambers. We have Hopper and Mushroom Kingdom.
[21:38:55] <grrrit-wm>	 (03PS1) 10Jdlrobson: Tweak toggle behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177885 
[21:40:16] <grrrit-wm>	 (03PS6) 10Bmansurov: Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen)
[21:42:07] <kristenlans_>	 Deskana ah hopper
[21:42:12] <kristenlans_>	 right
[21:51:07] <mhurd>	 brion: quick question - how do you recommend getting the first image in the article? (could be in section other than the 1st)
[21:52:56] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#822673 (10Jdlrobson) WIP patch at https://gerrit.wikimedia.org/r/166079 someone should feel to pick it up.
[21:53:20] <wikibugs>	 3MobileFrontend-beta, MobileFrontend-Feature-requests: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#822674 (10Jdlrobson)
[21:53:38] <kaldari>	 jdlrobson: Did Maryana leave?
[21:53:55] <jdlrobson>	 kaldari: i guessss her laptop is still here though so guess she'll be bacl
[21:54:13] <mhurd>	 brion: i’ve got session.articleStore.imageList - but not sure how to get the first MWKImage from the list.
[21:55:18] <brion>	 mhurd: ah well you can scan through the sections until you find something
[21:55:24] <brion>	 could make a convenience method 
[21:56:36] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: Hygiene: Split up mobile.startup module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/171722 (owner: 10Jdlrobson)
[21:56:36] <brion>	 mhurd: i can easily give you: -(NSArray *)allImages;
[21:56:51] <brion>	 which you can take the first URL and grab it as an image at largest available size
[21:57:59] <mhurd>	 brion: quick hangout?
[21:58:44] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Warning: /Users/jrobson/git/vagrant/mediawiki/extensions/MobileFrontend/javascripts/Page.js:16: Unknown type Integer" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[21:59:19] <brion>	 mhurd: i’ve got a meeting w/ tomasz, will ping ya after that
[22:01:19] <mhurd>	 brion: cool. was thinking maybe the array returned by -(NSArray *)allImages could be array of arrays - one for each section
[22:01:31] <brion>	 yessssss i could do that
[22:02:06] <brion>	 well there might be holes where sections are missing. mhurd dictionary ok or prefer the arrays?
[22:03:39] <mhurd>	 brion: array and just put empty arrays as placeholder for sections w/o images. that way we can loop through and easily see, oh, there are 3 images in section 1, 0 in section 2, 8 in section 5 etc just by doing “count” on that section’s sub array
[22:04:18] <mhurd>	 brion: then i don’t think we’d need this method anymore: -(NSArray *)imageURLsForSectionId:(int)sectionId;
[22:04:35] <mhurd>	 brion: or this one: -(NSString *)imageURLAtIndex:(NSUInteger)index sectionId:(int)sectionId;
[22:05:06] <mhurd>	 brion: wouldn’t have to remove them though - they’re pretty convenient :)
[22:07:41] <grrrit-wm>	 (03CR) 10Jdlrobson: Document defaults in Views (0322 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[22:08:59] <grrrit-wm>	 (03CR) 10Jdlrobson: Document defaults in Views (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[22:10:18] <Deskana>	 dbrant: Maybe we should push a beta today?
[22:10:27] <Deskana>	 dbrant: If we do, do it with lead images disabled, plz. :)
[22:11:52] <dbrant>	 Deskana: that would require some finagling of the code... how about first thing next week?
[22:12:22] <Deskana>	 dbrant: Sure, no rush. Was just thinking we've not done one for a while.
[22:12:47] <bearND|brb>	 Deskana: when can we do a beta with lead images included?
[22:13:21] <Deskana>	 Hmm, not sure about that.
[22:13:37] <Deskana>	 We should chat about that at the end of the iteration review, if we get a chance.
[22:13:54] <bearND>	 that would be great
[22:16:22] <bmansurov>	 jdlrobson: why are defaults being extended if parent defaults are inhereted here? https://gerrit.wikimedia.org/r/#/c/177880/1/javascripts/modules/editor/EditorOverlay.js
[22:17:01] <kristenlans_>	 Deskana: forgot to ask in standup: do you have everythign you need to sign off on Andriod wild turkey by COB? https://trello.com/b/nAhhqDXg/mobile-app-sprint-45-android-11-24-14-wild-turkey
[22:17:24] <Deskana>	 Well, if that stuff's merged, then I can pull an alpha build!
[22:17:40] <kristenlans_>	 yeeeehaw!
[22:18:52] <bearND>	 Deskana: kristenlans_: one more minor patch to be merged. Should be done soon.
[22:19:09] <Deskana>	 I'll update Android Studio in the mean time then.
[22:19:20] <bearND>	 I hope before the next alpha build is to be built in 10 min,
[22:19:45] <kaldari>	 Maryana: https://www.wikidata.org/wiki/Wikidata:Project_chat#Experimental_Wikidata_feature_coming_soon_to_English_Wikipedia_Mobile_site
[22:28:18] <kristenlans_>	 kaldari: I like what you wrote :-) But IANAM
[22:29:24] <brion>	 mhurd: ok sounds good (empty arrays as placeholders)
[22:29:47] <kaldari>	 That's OK K-bot. Your analysis is still valuable :)
[22:29:50] <brion>	 the MWKImageList doesn’t know for sure how many sections there are so it might not go to the end of the article if later sections have no items
[22:29:50] <brion>	 but that should work
[22:31:55] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 (owner: 10Dbrant)
[22:33:35] <grrrit-wm>	 (03CR) 10Bmansurov: Document defaults in Views (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[22:33:47] <grrrit-wm>	 (03PS2) 10Bmansurov: Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 
[22:34:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Iron out issues in Read More component. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/174995 (owner: 10Dbrant)
[22:35:18] <Maryana>	 kaldari oh no, i'll be missing hedwig! :(
[22:35:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[22:37:29] <kaldari>	 Maryana: So that means you got your visa?
[22:37:35] <Maryana>	 i did :)
[22:37:41] <kaldari>	 Maryana: Yay!
[22:37:41] <Maryana>	 just in the nick of time
[22:38:40] <brion>	 visa? for everything else, there’s mastercard.
[22:38:44] <Maryana>	 hehe
[22:38:56] <mhurd>	 brion: this is so cool :) image how much of a pain doing the same sort of changes we just discussed would have been w core data...
[22:39:07] <brion>	 :D srsly
[22:39:12] <brion>	 i’m liking the new flexibility
[22:39:25] <mhurd>	 brion: from day one it’s already better
[22:39:33] <brion>	 :DD
[22:43:02] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Stub 'imagesBySection' method on MWKImageList [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177933 
[22:45:40] <grrrit-wm>	 (03CR) 10Bmansurov: Document defaults in Views (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[22:45:43] <grrrit-wm>	 (03PS3) 10Bmansurov: Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 
[22:50:21] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Hide details Overlay in MediaViewer after tap on screen - https://phabricator.wikimedia.org/T70504#822745 (10Florian)
[22:52:18] <grrrit-wm>	 (03PS1) 10BearND: No Read more section on main page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177936 
[22:52:31] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Hide Details box when user taps the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177937 
[22:52:41] <bearND>	 dbrant|brb: ^^
[22:53:19] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Stop npm install downloading phantomjs every time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177860 (owner: 10Jdlrobson)
[22:54:36] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Complete jsdoc for application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177884 (owner: 10Jdlrobson)
[22:55:25] <grrrit-wm>	 (03PS1) 10MaxSem: Restrict response API to 2 submissions per minute [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177938 
[22:55:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Restrict response API to 2 submissions per minute [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177938 (owner: 10MaxSem)
[22:56:00] <MaxSem>	 fuck you jerkins
[22:56:38] <mhurd>	 brion: small bug for ya: looks like redirects are looping :) - search for “medieval” and tap first result
[22:56:46] <brion>	 woops
[22:57:05] <FlorianSW>	 oO MaxSem, keep calm it's friday :)
[22:57:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop npm install downloading phantomjs every time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177860 (owner: 10Jdlrobson)
[22:57:21] <brion>	 there’s always something :D
[22:57:40] <mhurd>	 brion: ok for me to keep tossing these your way as i find ‘em while i do lead image stuffs?
[22:57:42] <grrrit-wm>	 (03PS1) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 
[22:57:47] <brion>	 mhurd: oh yeah
[22:57:53] <brion>	 i’ll stick em in trello for nwo
[22:58:08] <mhurd>	 brion: cool!
[22:58:20] <mhurd>	 brion: heading upstairs...
[22:59:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson)
[23:00:01] <grrrit-wm>	 (03CR) 10Bmansurov: Pre-commit hook: Check jsdoc coverage of any touched files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177883 (owner: 10Jdlrobson)
[23:00:41] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Improve search interaction experience for low end devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen)
[23:05:45] <grrrit-wm>	 (03PS7) 10Bmansurov: Improve search interaction experience for low end devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177136 (owner: 10Robmoen)
[23:24:18] <grrrit-wm>	 (03PS2) 10MaxSem: Restrict response API to 2 submissions per minute [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177938 
[23:24:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Restrict response API to 2 submissions per minute [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177938 (owner: 10MaxSem)
[23:41:07] <kristenlans_>	 http://hatjitsu.wmflabs.org/48374
[23:43:15] <Deskana>	 https://en.wikipedia.org/w/api.php?action=mobileview&page=Jellyfish&prop=text%7Csections%7Cpageprops%7Cimage%7Cthumb
[23:46:16] <grrrit-wm>	 (03PS1) 10Kaldari: Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177942 
[23:51:57] <mhurd>	 Deskana: https://github.com/AFNetworking/AFNetworking/blob/master/LICENSE
[23:52:08] <Deskana>	 mhurd: https://raw.githubusercontent.com/AFNetworking/AFNetworking/master/LICENSE
[23:52:11] <Deskana>	 Plaintext!
[23:55:10] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Please don't leave incomplete documentation. I'd rather you just didn't document the defaults in a class if you are not sure." (0315 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov)
[23:57:10] <tfinc>	 dr0ptp4kt: lets tighten up the JD to just three bullet points. pick out he best ones and/or combine 
[23:57:21] <dr0ptp4kt>	 tfinc: on it
[23:57:30] <wikibugs>	 3MobileFrontend-Uploads, MobileFrontend-alpha, Mobile-Web: File Chooser dialog opens when clicked anywhere on the page - https://phabricator.wikimedia.org/T74827#822907 (10Jdlrobson)