[00:32:45] 3Continuous-Integration, MobileFrontend-General-or-Unknown: mwext-MobileFrontend-npm is failing to complete on several commits (not verifying commits, can't merge) - https://phabricator.wikimedia.org/T76354#824121 (10Krinkle) 5Open>3Resolved Let me know if this breaks again. [00:51:26] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#824142 (10Krinkle) [04:46:12] (03CR) 10Deskana: "Some questions." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177962 (owner: 10Deskana) [05:35:10] 3MediaWiki-Interface, Parsoid, MobileFrontend-General-or-Unknown, MediaWiki-Core-Team: Switch MobileFrontend over to using Parsoid for its read HTML - https://phabricator.wikimedia.org/T76970#824227 (10Florian) [06:16:40] 3Wikipedia-App-Android-App: top bar flickers when scrolling up past end of page (android) - https://phabricator.wikimedia.org/T76985#824229 (10jeremyb-phone) [07:14:02] (03CR) 10Florianschmidtwelzow: Alpha: Add possibility to change font size of the content (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [07:14:28] (03PS8) 10Florianschmidtwelzow: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 [07:30:57] (03PS1) 10Deskana: [WIP] Floating action button for saving pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178147 [09:15:08] morning all [09:42:04] 3MobileFrontend-Hygiene, VisualEditor-TechnicalDebt, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#824439 (10Qgil) [11:42:33] (03CR) 10Phuedx: [C: 04-1] "-1 for the this/self mixup. There's also a question about the use of a single promise." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [11:44:46] taking george to father's group [13:19:06] (03PS2) 10Dbrant: Enable lead images only in the Alpha build. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178127 [13:20:29] (03PS1) 10Dbrant: Fix sending of SuggestedPagesFunnel "shown" event [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178190 [13:34:51] (03PS1) 10Dbrant: Fix bottom padding of Read More component after refreshing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178192 [13:40:18] joakino: heya! Can you tell me what endpoint WikiGrok uses for WikidataQuery? also how much use WikiGrok is getting? [13:40:28] WDQ has been unstable of late, trying to figure out if WikiGrok is the culprit :) [14:40:06] hey YuviPanda [14:40:17] joakino's out for the day i think [14:44:01] YuviPanda: i don't think we're using wdq directly atm [14:45:17] wait… [14:46:49] YuviPanda: afaik wikigrok only ever used wdq indirectly [14:47:06] we populate tables on tool labs with possible claims [14:47:14] which involves hitting wdq hard once or twice [14:47:31] wikigrok is set to use wikibase (?) moving forward [15:04:01] phuedx: oh, I see. [15:04:05] phuedx: good to know then :) [15:04:32] YuviPanda: https://github.com/kaldari/WikiGrokAPI [15:04:55] that's the source for the api that we hit on toollabs [15:08:01] phuedx: cool! [15:08:19] which we shouldn't be hitting after christmas iirc [15:09:51] phuedx: \o/ cool [16:01:29] (03CR) 10BearND: [C: 032] Fix sending of SuggestedPagesFunnel "shown" event [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178190 (owner: 10Dbrant) [16:03:02] (03Merged) 10jenkins-bot: Fix sending of SuggestedPagesFunnel "shown" event [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178190 (owner: 10Dbrant) [16:06:23] (03CR) 10BearND: [C: 032] Fix bottom padding of Read More component after refreshing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178192 (owner: 10Dbrant) [16:06:43] 3MobileFrontend-Hygiene, VisualEditor-TechnicalDebt, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#825557 (10Jdforrester-WMF) >>! In T75892#824439, @Qgil wrote: >>>! In T75892#790593, @Jdforrester-WMF wrote: >> Rather than create a new project, just re-lab... [16:06:45] (03Merged) 10jenkins-bot: Fix bottom padding of Read More component after refreshing page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178192 (owner: 10Dbrant) [16:09:16] (03PS3) 10BearND: Enable lead images only in the Alpha build. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178127 (owner: 10Dbrant) [16:19:02] (03CR) 10Phuedx: [C: 032] "Nice! Thanks for improving the docs too!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177885 (owner: 10Jdlrobson) [16:20:58] (03Merged) 10jenkins-bot: Tweak toggle behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177885 (owner: 10Jdlrobson) [16:22:12] (03CR) 10BearND: [C: 032] Enable lead images only in the Alpha build. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178127 (owner: 10Dbrant) [16:22:31] (03Merged) 10jenkins-bot: Enable lead images only in the Alpha build. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178127 (owner: 10Dbrant) [16:26:01] (03PS1) 10Dbrant: Fix scrolling in the "read more" list. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178206 [16:30:43] (03PS2) 10Dbrant: Fix scrolling in the "read more" list. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178206 [16:32:36] (03CR) 10Phuedx: [C: 04-1] "See inline for glancing review. Time to kick the tyres." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [16:32:46] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [17:06:20] (03PS1) 10BearND: Bump version to 1.3.0 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/178213 [17:06:22] (03PS1) 10BearND: Getting ready for next development cycle [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/178214 [17:09:12] (03PS1) 10BearND: Use stable version of mwapi dependency [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178215 [17:19:05] bearND, hey, around? [17:20:06] Krenair: hello [17:20:29] (03CR) 10Phuedx: "Actually, The V-2 from jenkins-bot is due to the use of 5.4 syntax (see inline). Otherwise, this LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [17:20:51] bearND, someone has pointed out that Nearby returns nothing from the Turkish Wikipedia [17:20:56] even if it does from the English Wikipedia [17:21:57] Krenair: hmm, you mean the device lang is set to Turkish or the site it set to Turkish? [17:22:07] turkish site [17:23:00] Krenair: ok, checking... [17:25:47] (03CR) 10Dbrant: [C: 032] Use stable version of mwapi dependency [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178215 (owner: 10BearND) [17:27:26] bearND, https://en.wikipedia.org/w/api.php?action=query&prop=coordinates&generator=geosearch&ggsradius=10000&ggspage=Horsham_Museum vs. https://tr.wikipedia.org/w/api.php?action=query&prop=coordinates&generator=geosearch&ggsradius=10000&ggspage=Horsham%20M%C3%BCzesi [17:27:44] so it can't get coordinates for pages on trwiki? [17:27:59] or at least not that page, nor any pages near me [17:30:38] hmm, seems trwiki's Template:Coord just doesn't use {{#coordinates: ... }} [17:31:06] MaxSem should know about this: https://en.wikipedia.org/w/index.php?title=Template:Coord&diff=526665541&oldid=368854805 [17:31:53] ??? [17:34:16] (03PS1) 10Dbrant: Fix "read more" margins when in landscape mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178216 [17:34:22] MaxSem, {{Coord}} on enwiki stores coordinates for searching via API, but not on trwiki? [17:35:46] Krenair: MaxSem: Here's an example query from our app (with a location in Istanbul, so that should have results within 10 km): https://tr.m.wikipedia.org/w/api.php?action=query&format=json&prop=coordinates%7Cpageimages&colimit=50&pithumbsize=144&pilimit=50&generator=geosearch&ggscoord=41.013817%7C28.964964&ggsradius=10000&ggslimit=50&continue= [17:36:15] just gets a batchcomplete [17:36:52] so no results returned [17:37:16] Krenair: MaxSem: yeah, the api doesn't return any results [17:40:45] Krenair, you just need to press +2 at https://gerrit.wikimedia.org/r/165869 hehehe [17:42:15] hah [17:44:33] dbrant: There are a couple of more patches in https://gerrit.wikimedia.org/r/#/q/owner:bsitzmann%2540wikimedia.org+status:open+project:apps/android/java-mwapi,n,z [17:50:04] (03CR) 10Dbrant: [C: 032] Bump version to 1.3.0 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/178213 (owner: 10BearND) [17:50:21] (03CR) 10Dbrant: [V: 032] Bump version to 1.3.0 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/178213 (owner: 10BearND) [17:50:56] (03CR) 10Dbrant: [C: 032 V: 032] Getting ready for next development cycle [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/178214 (owner: 10BearND) [17:53:42] dbrant: ty [17:54:30] (03PS3) 10BearND: Fix scrolling in the "read more" list. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178206 (owner: 10Dbrant) [17:54:36] (03CR) 10BearND: [C: 032] Fix scrolling in the "read more" list. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178206 (owner: 10Dbrant) [17:54:50] (03PS2) 10BearND: Fix "read more" margins when in landscape mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178216 (owner: 10Dbrant) [17:55:02] (03Merged) 10jenkins-bot: Fix scrolling in the "read more" list. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178206 (owner: 10Dbrant) [18:06:23] (03CR) 10Phuedx: [C: 032] "LGTM. Took me a little while to remember that wgDBname is "wiki" locally, which stopped sitelinks actually being generated." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177731 (owner: 10Jdlrobson) [18:07:54] (03Merged) 10jenkins-bot: Infoboxes: Use correct urls in infoboxes. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177731 (owner: 10Jdlrobson) [18:14:48] (03CR) 10BearND: [C: 032] Fix "read more" margins when in landscape mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178216 (owner: 10Dbrant) [18:15:09] (03Merged) 10jenkins-bot: Fix "read more" margins when in landscape mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178216 (owner: 10Dbrant) [18:15:48] (03PS2) 10Jdlrobson: Hygiene: Complete jsdoc for application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177884 [18:15:53] (03CR) 10Jdlrobson: [C: 032] Hygiene: Complete jsdoc for application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177884 (owner: 10Jdlrobson) [18:17:36] (03CR) 10Jdlrobson: [C: 04-1] Hide Details box when user taps the image (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177937 (owner: 10Florianschmidtwelzow) [18:17:46] brion are you avail for standing? [18:19:29] (03PS2) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 [18:22:26] (03Merged) 10jenkins-bot: Hygiene: Complete jsdoc for application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177884 (owner: 10Jdlrobson) [18:34:11] (03PS1) 10BearND: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178234 [18:36:00] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178235 [18:38:55] kaldari: whereeee areee you [18:39:24] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178235 (owner: 10BearND) [18:39:44] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178235 (owner: 10BearND) [18:40:13] kaldari we miss you in retrospective! [18:40:15] wrong room [18:40:21] DOH! [18:43:44] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [18:49:44] 3Wikipedia-App-Android-App: "Read more" section is eating scroll events - https://phabricator.wikimedia.org/T76934#830539 (10bearND) 5Open>3Resolved a:3bearND [19:11:12] yo dawg [19:11:18] i put a collapsed table in your collapsed table [19:11:32] so you can have hidden tables inside your hidden tables [19:11:55] Deskana: you scared bearnd away [19:12:07] mhurd: He probably knew I'd ask him to fix it. ;) [19:12:21] I'll make a Phabricator task for it, it's not really urgent. [19:12:27] I think it's a Barack Obama edge-case. [19:12:40] Deskana: THANKS OBAMA! [19:15:18] 3Wikipedia-App-Android-App: Barack Obama article has the infobox collapsed inside another collapsed table (yo dawg) - https://phabricator.wikimedia.org/T77802 (10Deskana) 3NEW p:3Triage [19:15:22] :D [19:17:11] Deskana: so we don't want nested infoboxes? [19:17:32] Having the infobox be collapsed behind a button which is collapsed behind another button is a bit strange [19:17:48] That's a bug, isn't it? Those two templates are not inside each other on desktop. [19:18:29] The wikitext looks like this [19:18:46] {{Infobox officeholder | ... }} {{Barack Obama sidebar}} [19:19:09] I'm not sure how the infobox has ended up inside the sidebar [19:19:38] well that's queer. [19:25:44] * YuviPanda waves [19:26:41] (03CR) 10Jdlrobson: [C: 04-1] Document defaults in Views (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov) [19:31:34] Hey YuviPanda! [19:31:41] hey Deskana [19:31:54] just popped about to see some old nicks, etc :) [19:32:58] hello YuviPanda [19:33:03] jdlrobson: it is true that trello is miles away from phab, it is just too awesome, but phab is miles away from bugzilla, so I think there is no loss if we use phab as (new)bugzilla but we would need to push hard for phabello [19:33:24] hey Platonides [19:33:26] long time no see [19:33:30] I think I didn't congratulate you for you team change :) [19:33:40] Platonides: :D thanks! [19:33:45] I'm not on irc as often as I was [19:36:49] phuedx we are in a new hangout fyi [19:37:29] Platonides: :) [19:37:29] Platonides: but good to see you back :) [19:37:50] phuedx: btw, your stat100* access is stalled :) [19:39:29] (03CR) 10Bmansurov: Document defaults in Views (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov) [19:39:39] (03PS6) 10Bmansurov: Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 [19:40:56] http://hatjitsu.wmflabs.org/82345 [19:47:54] @Deskana: this (http://i.imgur.com/dxqfJKd.png) is the material design, right? Is there an alpha build for a limited test (e.g. for me only :P)? :D [19:50:54] FlorianSW: http://android-builds.wmflabs.org/ [19:51:22] ehh, always i forget this site, sry :/ :D [19:51:25] YuviPanda: ? [19:52:06] phuedx: did you get email from RT with number #8853 [19:52:09] YuviPanda: is it because i'm awesome? [19:52:38] YuviPanda: no [20:04:58] https://etherpad.wikimedia.org/p/K [20:11:07] JOakino thanks fro popping in for meetins. [20:11:33] Feliz Concepcion? [20:11:37] kristenlans: 👍 :) [20:12:03] joakino_: what's the time with you? [20:12:11] phuedx: wat? [20:12:24] ... [20:12:26] i'm awake [20:12:29] timezone? [20:12:41] phuedx: 9:12pm now [20:12:49] as usual [20:12:49] kk [20:13:26] anyhow [20:13:29] g'night y'all [20:14:06] jdlrobso_: https://gerrit.wikimedia.org/r/#/c/177939/ [20:14:16] that's so close to getting merged [20:14:19] i'm leaving too! bb 👋 [20:15:41] MaxSem, so what am I telling this user asking about Turkish Wikipedia nearby search? [20:20:29] dbrant: wanna do a hangout to chat about that infobox transform stuff? [20:20:58] mhurd: sure! [20:33:43] dbrant: https://raw.githubusercontent.com/montehurd/apps-ios-wikipedia/leadImageStyling/www/js/transforms.js [20:38:33] (03CR) 10Jdlrobson: [C: 032] Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov) [20:42:03] 3MobileFrontend-Hygiene, VisualEditor-TechnicalDebt, Project-Management, Wikidata: Create technical-debt project - https://phabricator.wikimedia.org/T75892#831488 (10Qgil) > Editable By VisualEditor (Project) You do it. :) [20:43:14] (03PS2) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 [20:43:40] (03Merged) 10jenkins-bot: Document defaults in Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177880 (owner: 10Bmansurov) [20:51:52] dbrant: silly question but how are you getting the url of the image for the lead image? [20:52:04] dbrant: i should know this... [20:53:50] mhurd: ah, that's what I was confused about during the meeting: [20:54:48] dbrant: oh that’s right - max had a query parameter we could use, but only for search? lemme check... [20:55:20] mhurd: apparently, when you do prop=pageimages, you can select "thumbnail" as well as "name", and it will return a "pageimage" property that is the file name. [20:55:46] mhurd: then you prepend "File:" onto it, and that becomes the file page. [21:04:09] (03PS1) 10BearND: Avoid NPE calling updateProgressBar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178270 [21:06:36] dbrant: hmm i just added “image” to the mobileview query (for section retrieval) and it gives me the image file name... [21:06:54] dbrant: *added “image” to “props” [21:07:15] *to “prop” rather [21:07:54] mhurd: yeah that works too. I was just confused because the file name doesn't begin with "File:" [21:08:37] mhurd: but it sounds like prepending "File:" onto it will work for all wikis. [21:08:55] dbrant: ah. so even having the file name we still don’t have the url to the resolution we want right? [21:09:48] dbrant: and we then use http://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=url&iiurlwidth=55&titles=File%3AWiki.png to get the url for the resolution desired? [21:09:58] mhurd: right, we'll need to make another request to get "imageinfo" for the File page [21:10:04] dbrant: gah [21:19:21] (03CR) 10BearND: Fix issue where first "Read more" suggestion was sometimes the current article (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177962 (owner: 10Deskana) [21:24:21] dbrant|brb: i talked to max and created a card for enhancing the mobileview api to not only return name of article image but url of that image at higher res: https://trello.com/c/49dretMe/174-enhance-mobileview-api-to-not-only-return-name-of-article-image-but-url-to-that-image-at-a-given-resolution [21:26:27] dbrant|brb: max also said we should only request certain image widths for lead images. see the “widthBuckets” array here: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMultimediaViewer.git/f9e7bae91a8032fa13fc68114a0d57d190ea77f9/resources%2Fmmv%2Fmmv.ThumbnailWidthCalculator.js [21:26:37] dbrant|brb: for cache reasons of course [21:30:10] 3MobileFrontend-stable, Mobile-Web, MobileFrontend-beta: "center" does not center non-thumb image (stable) / "thumb|left" results in centered thumb (beta) - https://phabricator.wikimedia.org/T76945#831705 (10Jdlrobson) [21:36:38] 3Wikipedia-App-Android-App: Text selection and menu drawer activation can happen at the same time - https://phabricator.wikimedia.org/T77924 (10Ragesoss) 3NEW p:3Triage [21:42:07] 3MobileFrontend-General-or-Unknown: Issues using qunit with grunt - https://phabricator.wikimedia.org/T75670#831731 (10Jdforrester-WMF) [21:42:10] 3MobileFrontend-General-or-Unknown: Missing autoload entries for DeviceDetection classes - https://phabricator.wikimedia.org/T76436#831732 (10Jdforrester-WMF) [21:42:11] 3MobileFrontend-General-or-Unknown: [Tracking] Getting rid of own login page - https://phabricator.wikimedia.org/T74910#831736 (10Jdforrester-WMF) [21:42:12] 3MobileFrontend-General-or-Unknown: Hygiene: Ajax loader on notifications icon should be a real Icon - https://phabricator.wikimedia.org/T75251#831733 (10Jdforrester-WMF) [21:42:13] 3MobileFrontend-General-or-Unknown: Build jsduck through Gruntfile - https://phabricator.wikimedia.org/T74718#831735 (10Jdforrester-WMF) [21:42:15] 3MobileFrontend-General-or-Unknown: Module 'mobile.editor.ve' has incompatible target 'desktop' - https://phabricator.wikimedia.org/T76435#831734 (10Jdforrester-WMF) [21:42:16] 3MobileFrontend-General-or-Unknown: [Tracking] Move Nearby code to Geodata extension - https://phabricator.wikimedia.org/T66316#831738 (10Jdforrester-WMF) [21:42:18] 3MobileFrontend-General-or-Unknown: [Tracking] MobileFrontend should use mw-ui-icon - https://phabricator.wikimedia.org/T73181#831737 (10Jdforrester-WMF) [21:42:19] 3MobileFrontend-General-or-Unknown: [Tracking] Consolidate code for MediaViewer across desktop and mobile - https://phabricator.wikimedia.org/T65504#831739 (10Jdforrester-WMF) [21:42:20] 3MobileFrontend-General-or-Unknown: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - https://phabricator.wikimedia.org/T64638#831740 (10Jdforrester-WMF) [21:42:22] 3MobileFrontend-General-or-Unknown: Running QUnit is logging events - https://phabricator.wikimedia.org/T75106#831747 (10Jdforrester-WMF) [21:42:23] 3MobileFrontend-General-or-Unknown: Rename progress-bar.js and put in uploads directory - https://phabricator.wikimedia.org/T75247#831746 (10Jdforrester-WMF) [21:42:24] 3MobileFrontend-General-or-Unknown: Get Grunt setup in MobileFrontend - https://phabricator.wikimedia.org/T74443#831744 (10Jdforrester-WMF) [21:42:26] 3MobileFrontend-General-or-Unknown: Hygiene: Standardise names of our event logging schemas - https://phabricator.wikimedia.org/T75342#831745 (10Jdforrester-WMF) [21:42:27] 3MobileFrontend-General-or-Unknown: Kill M.isApp method and less/apps directory - https://phabricator.wikimedia.org/T75158#831749 (10Jdforrester-WMF) [21:42:30] 3MobileFrontend-General-or-Unknown: JS console warnings - https://phabricator.wikimedia.org/T74839#831750 (10Jdforrester-WMF) [21:42:30] 3MobileFrontend-General-or-Unknown: javascripts/desktop folder can be removed - https://phabricator.wikimedia.org/T75248#831748 (10Jdforrester-WMF) [21:42:31] 3MobileFrontend-General-or-Unknown: Tables on mobile are a big fat mess - https://phabricator.wikimedia.org/T66577#831752 (10Jdforrester-WMF) [21:42:32] 3MobileFrontend-General-or-Unknown: Deprecate use of EventEmitter.prototype.one in MobileFrontend - https://phabricator.wikimedia.org/T74711#831751 (10Jdforrester-WMF) [21:42:33] 3MobileFrontend-General-or-Unknown: Publish our JS Documentation - https://phabricator.wikimedia.org/T74794#831753 (10Jdforrester-WMF) [21:42:34] 3MobileFrontend-General-or-Unknown: WikigrokApi and Dialog tests - https://phabricator.wikimedia.org/T74720#831754 (10Jdforrester-WMF) [21:42:34] 3MobileFrontend-General-or-Unknown: Hygiene: Wikigrok lacks documentation - https://phabricator.wikimedia.org/T74657#831755 (10Jdforrester-WMF) [21:42:37] 3MobileFrontend-General-or-Unknown: QUnit failures in browser for toggling tests - https://phabricator.wikimedia.org/T74506#831756 (10Jdforrester-WMF) [21:42:38] 3MobileFrontend-General-or-Unknown: Make commands in MobileFrontend need documentation - https://phabricator.wikimedia.org/T73892#831759 (10Jdforrester-WMF) [21:42:38] 3MobileFrontend-General-or-Unknown: QA: Update Scenario: Check more button exists browser test - https://phabricator.wikimedia.org/T74321#831758 (10Jdforrester-WMF) [21:42:39] 3MobileFrontend-General-or-Unknown: QA: Scenario: Successful edit reloads language button test fails - https://phabricator.wikimedia.org/T74368#831757 (10Jdforrester-WMF) [21:42:41] 3MobileFrontend-General-or-Unknown: Make mobileFrontend an object created with "new" - https://phabricator.wikimedia.org/T46264#831761 (10Jdforrester-WMF) [21:42:43] 3MobileFrontend-General-or-Unknown: Standardise on our grey colours - https://phabricator.wikimedia.org/T67381#831760 (10Jdforrester-WMF) [21:42:44] 3MobileFrontend-General-or-Unknown: Hygiene: localTemplateBasePath should be the same as localBasePath - https://phabricator.wikimedia.org/T74161#831762 (10Jdforrester-WMF) [21:42:45] 3MobileFrontend-General-or-Unknown: JSHint: Clean up .jshintignore - https://phabricator.wikimedia.org/T73714#831763 (10Jdforrester-WMF) [21:42:46] 3MobileFrontend-General-or-Unknown: Standardize page-loaded event across stable/beta/alpha - https://phabricator.wikimedia.org/T47299#831764 (10Jdforrester-WMF) [21:42:47] 3MobileFrontend-General-or-Unknown: QUnit tests hit API - https://phabricator.wikimedia.org/T66635#831765 (10Jdforrester-WMF) [21:42:47] 3MobileFrontend-General-or-Unknown: Documentation: JS Documentation out of date since OOJS move - https://phabricator.wikimedia.org/T73250#831766 (10Jdforrester-WMF) [21:42:49] 3MobileFrontend-General-or-Unknown: Hygiene: common.less and main.less are dumping grounds and need tidying up - https://phabricator.wikimedia.org/T67622#831767 (10Jdforrester-WMF) [21:42:50] 3MobileFrontend-General-or-Unknown: Minimize number of thumb sizes used in MobileFrontend extension - https://phabricator.wikimedia.org/T60285#831769 (10Jdforrester-WMF) [21:42:51] 3MobileFrontend-General-or-Unknown: Hygiene: Rearrange templates folder so that is is consistent with javascripts and less - https://phabricator.wikimedia.org/T73523#831768 (10Jdforrester-WMF) [21:42:53] 3MobileFrontend-General-or-Unknown: Code Hygiene: Standardise between forEach and $.each usage - https://phabricator.wikimedia.org/T65454#831773 (10Jdforrester-WMF) [21:42:54] 3MobileFrontend-General-or-Unknown: Setup EventLogging schemas the new cool way. - https://phabricator.wikimedia.org/T68055#831772 (10Jdforrester-WMF) [21:42:54] 3MobileFrontend-General-or-Unknown: Inconsistency: Editor uses back icon for closing overlay, talk uses X - https://phabricator.wikimedia.org/T73203#831770 (10Jdforrester-WMF) [21:42:56] 3MobileFrontend-General-or-Unknown: Get down to 15 shades of gray - https://phabricator.wikimedia.org/T73627#831771 (10Jdforrester-WMF) [21:42:59] 3MobileFrontend-General-or-Unknown: Hygiene: Change editor URL to use leading / - https://phabricator.wikimedia.org/T72904#831774 (10Jdforrester-WMF) [21:42:59] 3MobileFrontend-General-or-Unknown: Use real (logic-less) templates to generate HTML - https://phabricator.wikimedia.org/T46130#831776 (10Jdforrester-WMF) [21:43:00] 3MobileFrontend-General-or-Unknown: Remove commons folder - https://phabricator.wikimedia.org/T73524#831775 (10Jdforrester-WMF) [21:43:01] 3MobileFrontend-General-or-Unknown: Views used to like Models - https://phabricator.wikimedia.org/T66933#831778 (10Jdforrester-WMF) [21:43:03] 3MobileFrontend-General-or-Unknown: Copyvio tests do not work on Chrome - https://phabricator.wikimedia.org/T66397#831780 (10Jdforrester-WMF) [21:43:03] 3MobileFrontend-General-or-Unknown: Manage z-index with LESS variables - https://phabricator.wikimedia.org/T66707#831779 (10Jdforrester-WMF) [21:43:04] 3MobileFrontend-General-or-Unknown: VisualEditor uses different class names to mobile - leads to duplicate CSS - https://phabricator.wikimedia.org/T66973#831777 (10Jdforrester-WMF) [21:43:05] 3MobileFrontend-General-or-Unknown: API: Sensible mobileview defaults - https://phabricator.wikimedia.org/T62485#831783 (10Jdforrester-WMF) [21:43:06] 3MobileFrontend-General-or-Unknown: Avoid CSS rule duplication by using more descriptive classes - https://phabricator.wikimedia.org/T66217#831782 (10Jdforrester-WMF) [21:43:08] 3MobileFrontend-General-or-Unknown: Make MobileFrontend dependent on Mantle extension - https://phabricator.wikimedia.org/T68224#831784 (10Jdforrester-WMF) [21:43:09] 3MobileFrontend-General-or-Unknown: MobileOptions checkbox toggles should be refactored and put in mediawiki.ui - https://phabricator.wikimedia.org/T66313#831781 (10Jdforrester-WMF) [21:43:10] 3MobileFrontend-General-or-Unknown: make phpdoc shows errors in our PHP documentation - https://phabricator.wikimedia.org/T68086#831786 (10Jdforrester-WMF) [21:43:13] 3MobileFrontend-General-or-Unknown: Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php - https://phabricator.wikimedia.org/T66004#831787 (10Jdforrester-WMF) [21:43:15] 3MobileFrontend-General-or-Unknown: jsduck is not installed by bundle - https://phabricator.wikimedia.org/T68579#831785 (10Jdforrester-WMF) [21:43:16] 3MobileFrontend-General-or-Unknown: Nearby is not a PageList - https://phabricator.wikimedia.org/T66212#831790 (10Jdforrester-WMF) [21:43:16] 3MobileFrontend-General-or-Unknown: Get PHP documentation generating - https://phabricator.wikimedia.org/T66398#831791 (10Jdforrester-WMF) [21:43:18] 3MobileFrontend-General-or-Unknown: make message changes character encoding - https://phabricator.wikimedia.org/T65019#831788 (10Jdforrester-WMF) [21:43:19] 3MobileFrontend-General-or-Unknown: $wgMFNearby shouldn't exist - https://phabricator.wikimedia.org/T66029#831789 (10Jdforrester-WMF) [21:43:20] 3MobileFrontend-General-or-Unknown: Consolidate mw.Api with mw.mobileFrontend.require( 'api' ) - https://phabricator.wikimedia.org/T59629#831795 (10Jdforrester-WMF) [21:43:20] 3MobileFrontend-General-or-Unknown: consolidate css rules for edit switcher css - https://phabricator.wikimedia.org/T66968#831793 (10Jdforrester-WMF) [21:43:22] 3MobileFrontend-General-or-Unknown: Consolidate mediawiki.notify module and Toast - https://phabricator.wikimedia.org/T66565#831792 (10Jdforrester-WMF) [21:43:23] 3MobileFrontend-General-or-Unknown: Rewrite ImageOverlay to use OverlayNew - https://phabricator.wikimedia.org/T66269#831794 (10Jdforrester-WMF) [21:43:24] 3MobileFrontend-General-or-Unknown: Missing step definitions - https://phabricator.wikimedia.org/T65090#831796 (10Jdforrester-WMF) [21:43:42] kristenlans: Please don't close the sprint 45 boards yet. :) [21:45:11] Deskana: 10-4 [21:49:08] food times [21:49:11] brb [21:53:39] jdlrobson: hey, according to the new watchlist click tracking schema you created, we are not tracking the 'more' button. Should I remove it from the code or add it to the schema? [21:56:17] jdlrobson: also, in the diff schema there is no tracking for 'diff-prev-or-next', but there is a new value for 'thank', supposedly a button which I cannot find in the UI. [21:59:34] jdlrobson: can I make that test with a link from WP to your site? [22:00:53] jdlrobson: I take that back, it looks like SSL is not enabled on your site [22:14:11] (03PS1) 10Bmansurov: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 [22:14:56] bmansurov: please track it :) [22:15:14] bmansurov: would be good to get an idea if people are using ir or not. Also please add diff-prev-or-next [22:15:26] The thank button should be in bottom right when logged in when viewing a diff that is not your own [22:15:27] jdlrobson: ok, where is the thank button? [22:15:33] ok [22:15:34] thanks [22:15:36] (03CR) 10jenkins-bot: [V: 04-1] EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [22:16:00] unless we broke it again.. [22:16:47] uhoohhh bmansurov you found a bug :) [22:17:15] jdlrobson: I found another, more serious bug [22:17:41] bmansurov: https://phabricator.wikimedia.org/T77929 [22:17:45] bmansurov: you did what? [22:17:57] jdlrobson: I think the futureLog function is wrong, it overrides previous values ;) [22:18:05] correct [22:18:14] futureLog should only be used once on a page. [22:18:29] it basically says save this after the next page load [22:18:30] jdlrobson: what if you're tracking two different values? [22:18:48] that wasn't its original purpose [22:18:53] it was just to avoid delaying link clicks [22:18:55] (03PS3) 10Deskana: Fix issue where first "Read more" suggestion was sometimes the current article [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177962 [22:18:56] jdlrobson: i see, ok, so it's used for when leaving the page [22:19:04] you can only click on one link [22:19:14] i think thanks being broken is more serious than an eventlogging issue though ;-) [22:19:15] in that case i take my words back [22:20:03] bearND: Thanks for the feedback on that patch! I changed my == to use .equals instead, and actually the way it's done has no issues with EventLogging misfiring events. [22:20:26] jdlrobson: so the 'more' button is supposed to be on the 'watchlist-a-z' or 'feed' page? [22:20:43] bmansurov: only a-z at moment [22:20:49] ok [22:26:47] (03CR) 10Deskana: "After a rebase to incorporate I9498a366cc4eb7f5e1cb69c2361265d411e77447, there are no issues with EventLogging; events can only fire after" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177962 (owner: 10Deskana) [22:27:33] Deskana: No, I didn't think it would cause misfiring events. It's just that the pageTitle value would change from one event to another, e.g. from "Avant-garde" to "Avant garde" [22:27:35] bearND: read more is a great feature [22:27:45] :) [22:28:02] one question about it though ... (i can;t just give compliments) :P [22:28:33] bearND: That's what I meant! The events only fire after the view has been populated, so the title is actually always correct. :) [22:28:50] Deskana: ah, ok [22:28:58] in about 20% of articles i tested it on one of the three links was pointing to the article i was on, is that a bug or a feature ? [22:29:13] matanya: That is the bug I just fixed in this patch: https://gerrit.wikimedia.org/r/#/c/177962/ [22:29:22] gmta [22:29:27] matanya: yeah, what Deskana just said [22:29:57] one more thing is that attribution is now cut under the read more section [22:29:59] matanya: In cases where you arrived on a page via a redirect, it would almost always display the current page as a read more link, because the read more section was using the title of the redirect rather than the actual article :) [22:30:04] is that fixed as well ? [22:30:17] matanya: What, you mean the attribution is missing? [22:30:23] oh, mhurd re: question you/Vibha had about lead image card, I found the Android card. It doesn't look like it was broken up any more than the iOS card: https://trello.com/c/dHFLUvSx/1-3-as-a-reader-i-d-like-to-view-a-consistent-lead-image-across-all-the-articles-i-read-so-that-they-re-easier-to-process [22:30:30] Deskana: hidden under read more [22:30:50] kristenlans: cool thanks for checking! :) [22:30:55] matanya: I'm not sure what you mean by "hidden". [22:31:04] rmoen: joakino is the image at top working on beta labs? [22:31:06] i'll try to post a pic [22:31:16] matanya: Thank you. :) [22:31:17] (03PS1) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [22:31:34] matanya: You use 2.3, right? [22:31:48] I've not tested this on 2.3 [22:31:51] Deskana: android ? [22:31:52] Let me boot up my 2.3 emulator [22:31:55] Yes [22:31:58] no, 4.4.4 [22:32:12] Oh [22:32:12] Then yes, picture please. :) [22:33:17] Erm, wow, big problem on 2.3 [22:33:32] 12-08 22:33:03.960 2400-2400/org.wikipedia.alpha E/dalvikvm﹕ Could not find class 'android.support.v7.widget.SearchView$5', referenced from method android.support.v7.widget.SearchView.addOnLayoutChangeListenerToDropDownAnchorSDK11 [22:33:55] http://imgur.com/FHHjOEI [22:34:14] Deskana: ^ [22:34:41] see how the cc-by part is cut ? [22:36:11] kaity: not sure if its up yet. card status is in -1 https://trello.com/c/WZO0tun5/33-8-alpha-page-styling-experiment-image-at-top [22:37:50] (03CR) 10Jdlrobson: Improve [Alpha page styling experiment] Image at top (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [22:40:09] (03CR) 10Jdlrobson: [C: 04-1] Scrollable reference drawers (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [22:40:29] (03CR) 10BearND: [C: 032] Fix issue where first "Read more" suggestion was sometimes the current article [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177962 (owner: 10Deskana) [22:41:31] rmoen: did you get anywhere with infobox editing? I want to have another stab at that this afternoon [22:42:40] (03Merged) 10jenkins-bot: Fix issue where first "Read more" suggestion was sometimes the current article [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/177962 (owner: 10Deskana) [22:42:57] jdlrobson: I think I got stuck w/ it. have a WIP up but there is oo.ui error [22:43:09] ergg. i need that oo ui component [22:43:48] jdlrobson: there was some issue with createElement, can't remember at the moment [22:44:04] cool i'll take a look [22:44:13] (03PS1) 10BearND: Remove Android Maven Plugin from credits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178349 [22:44:49] matanya: Oh, I hadn't noticed that. [22:45:14] Deskana: matanya: fixed in today's patches [22:45:18] matanya: Strange. It looks fine on my device. [22:45:18] matanya: What device are you using? [22:45:18] Deskana: can you reproduce ? if so, i'll report on pahb [22:45:24] nexus 5 [22:45:41] Deskana: see dbrant above [22:45:43] I'm using a Nexus 5 too, but I'm using the latest alpha, so I guess that's why it's fine for me, given what dbrant said! [22:45:59] dbrant: Did you see what I said above about 2.3? [22:46:10] dbrant: If I put the app on my 2.3 Genymotion device, it crashes on startup [22:46:28] lastest means head? or latest alpha from labs ? [22:46:36] Deskana: it's known that the app does not work on any 2.3 emulator :( [22:46:47] or real device [22:46:54] dbrant: That's weird. I worked for me before. [22:47:17] Deskana: lol it shouldn't have. there's a known issue with the emulator when trying to use a JS bridge with the WebView [22:47:28] Because that's helpful feedback. [22:47:28] matanya: it should work on a real 2.3 device [22:47:33] "You're wrong, it worked before" [22:47:37] * Deskana slaps himself for being unhelpful [22:47:54] (03CR) 10Jdlrobson: [C: 04-1] "So coool! Almost there before I think this is alpha ready!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [22:48:30] Deskana: just to verify, what is your version ? [22:48:48] matanya: 2.0-alpha-2014-12-08 [22:48:58] I downloaded it this morning. [22:49:06] ok, so wasn't released yet [22:49:17] (03CR) 10Jdlrobson: "also you should probably load this at the top of the page... I'm seeing a flash of unstyled content" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [22:50:11] Deskana: matanya: the version string for alpha is not granular enough. We probably should add some more info, like a git sha-1 to it for alpha [22:50:11] Deskana: aharoni joke: hey! i'm on the contributors list, i wonder what i contributed [22:50:54] bearND: as i'm on -12-07 i know i don't have latest, but yeah, good point [22:51:02] (03PS9) 10Jdlrobson: WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [22:51:45] now i am [22:52:45] (03PS2) 10Bmansurov: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 [22:52:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [22:53:24] (03PS1) 10Robmoen: Small style tweaks to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 [22:53:51] bearND: is it by design that holding the device horizontal doesn't load cover image ? [22:55:12] matanya: kind of. It depends on the device. We basically check how much space is there before we show the lead image. [22:55:23] i see [22:55:56] matanya: on a very wide device you could still see the lead image in landscape, while on a narrow device you most likely would not [22:58:08] Deskana: Is Vibha around? I was wondering if there was any design for https://trello.com/c/9jwNkr9h/2-5-legal-requirement-when-i-tap-on-a-link-to-a-library-in-about-the-full-text-of-the-licence-of-that-library-needs-to-be-displaye ? [22:58:45] Deskana: or is it just adding extra links after every library? [22:58:55] like the checklist says [23:03:22] (03PS2) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 [23:03:36] (03CR) 10Robmoen: Scrollable reference drawers (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [23:03:57] (03PS2) 10Robmoen: Small style tweaks to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 [23:06:53] 3MobileFrontend-General-or-Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - https://phabricator.wikimedia.org/T63737#832080 (10PamD) [23:09:20] (03CR) 10Robmoen: "Jon, I agree that views shouldn't be handling things outside of themselves. However, this is how Drawers are currently setup. Until we " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [23:09:34] holy phabricator spam batman... [23:14:43] bearND: pm? [23:20:45] MaxSem: Can you give this card a preliminary estimate? https://trello.com/c/vwkGDQu4/42-make-wikigrok-extension-embed-property-labels-in-pages [23:26:49] kristenlans: yes [23:32:21] bearND: Just add extra links after the library. [23:32:35] Deskana: ok, ty [23:34:23] dr0ptp4kt: Are you about? [23:34:28] kaity: don't forget https://trello.com/c/ZCDlJJBX/2-3-after-completing-5-25-and-50-in-wikigrok-roulette-i-get-a-thank-you-message-with-badges ! [23:35:54] 3Wikipedia-App-Android-App: The current article can be suggested in the "Read more" panel if you arrive via a redirect - https://phabricator.wikimedia.org/T76936#832242 (10Deskana) 5Open>3Resolved a:3Deskana [23:44:29] kristenlans: haven't looked at this but this sounds interesting - https://www.cloudpipes.com/integrations/phabricator/trello [23:44:36] claims to integrate different apps [23:45:06] kristenlans: also do you use chrome? [23:45:41] jdlrobso_: iiiinteresting [23:45:45] I use chrome sometimes [23:45:54] anyway at very least that shows it's possible to do something with trello/phab :) [23:47:30] jdlrobso_: I'll poke around at it a bit :-) thanks! [23:51:40] (03CR) 10MaxSem: [C: 032] Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177942 (owner: 10Kaldari) [23:53:52] (03Merged) 10jenkins-bot: Rewriting WikiGrok more info copy and changing None button to neutral [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/177942 (owner: 10Kaldari) [23:57:21] 3MobileFrontend-General-or-Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - https://phabricator.wikimedia.org/T63737#832416 (10Quiddity) >>! In T63737#832080, @PamD wrote: > The new bug I raised was 72903 and is T74903 in Phabricator, but has been dismissed with "I don't think... [23:57:33] 3MobileFrontend-General-or-Unknown, MediaWiki-extensions-Thanks: Thank notification on mobile doesn't ask for confirmation: accident-prone - https://phabricator.wikimedia.org/T63737#832420 (10Quiddity)