[00:19:36] mhurd: https://www.mediawiki.org/wiki/Mobile_web/Team/Onboarding [00:20:07] mhurd: http://etherpad.wikimedia.org/p/FrontEndDevOnboarding [00:20:20] jdlrobso_: you mention 'unions' in https://trello.com/c/4icRYufi/26-5-eventlogging-update-all-click-tracking-graphs Can you explain more? Won't old data be coming from the old schema? [00:26:01] Deskana: which jdk are you using? want to make sure i'm running the same jdk. it seems now that jdk 7 is required with the v21 support libraries? [00:26:23] dr0ptp4kt: Yeah, I updated. [00:26:24] * Deskana looks [00:27:06] dan-garry:android-wikipedia dgarry$ java -version [00:27:06] java version "1.7.0_71" [00:27:06] Java(TM) SE Runtime Environment (build 1.7.0_71-b14) [00:27:08] Java HotSpot(TM) 64-Bit Server VM (build 24.71-b01, mixed mode) [00:27:51] The instructions in the README in the repo are pretty out of date. [00:31:03] Deskana: thx, getting it from oracle.com [00:33:39] 3Design, MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#832559 (10Jaredzimmerman-WMF) I'm just going to put this here for inspiration http://codepen.io/joshbader/pen/ByoXRP [00:43:56] bmansurov: not sure i follow [00:44:18] bmansurov: but any time you change the schema and want to keep historic data you have to combine the two tables into one big table [00:44:22] using union [00:44:56] jdlrobso_: so when I change the schema, the old table gets split? [00:51:07] bmansurov: yup every revision change! [00:51:10] it's a different schema [00:51:14] you could completely rewrite it [00:51:59] jdlrobso_: why do we need version number then? in a file like this https://gerrit.wikimedia.org/r/#/c/178381/1/mobile/diff-activity.sql [00:52:41] bmansurov: you want to unify the tables MobileWebClickTracking_5929948 and MobileWebDiffClickTracking_10720373 into one single table [00:52:52] i'm not sure what you are asking [00:53:24] jdlrobso_: what's the significance of the version number here: MobileWebDiffClickTracking_10720373 [00:53:40] jdlrobso_: why is it even needed if the latest one is the default one [00:55:31] added svgs to https://trello.com/c/ZCDlJJBX/2-3-after-completing-5-25-and-50-in-wikigrok-roulette-i-get-a-thank-you-message-with-badges jdlrobso_ [00:57:24] the version number? you mean 10720373 ? [00:57:27] that's revision [00:57:45] maryana wanted them all in one table. [00:58:47] kaity: thanks! :) [01:02:36] (03PS1) 10Robmoen: Beta border sanity [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 [01:11:55] (03CR) 10Bmansurov: [C: 04-1] "Also, pages that are not created yet, but are watched by the user show up on the Special:EditWatchlist page but are ignored when construct" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [01:12:44] jdlrobson: yeah I meant to say revision [01:15:56] Deskana: when i saw the standard ToC icon i almost cried a tear of joy. [01:57:19] Deskana|Away: funny thing happens when the device's date & time settings are earlier than the certificate issue date for all wikipedia servers [01:58:57] Deskana|Away: that reminds me, we may want to think about embedding the cert and doing cert pinning. i don't know if the guys have looked at that, but it's kind of a nice way to deal with funny people doing funny things like building devices with wildcard certs [01:59:11] Deskana|Away: but not a top priority, of course. if one is in that situation, all bets are off anyway [02:21:56] Krinkle: In zero we're having an instance of what appears to be a span tag bubbling a click event up through an anchor tag to the body where we're listening to anchor tags via $('document.body').on('click', 'a', handler). Because of this, the event target is the span tag and not the anchor tag and we need it to be the anchor tag for certain element properties. The solution that [02:21:57] popped into my head is to write in a check for target tags that aren't anchor tags and check parentNode recursively in that case, but before implementing that I wanted to get your opinion on if there's a better route that you might have in mind. In case you want it, relevant javascript code: [02:21:57] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroBanner.git/46eb1fb20db221bac1c765725dcdaeec290c3a84/modules%2Finterstitial.js (line 75), relevant page: http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page?debug=true (needs X-CS header set to TESTON, try clicking Wikivoyage link vs. one of the language links, you'll notice the difference). [02:26:19] dr0ptp4kt: So, fixed on that device at least? [02:34:30] (03PS10) 10Jdlrobson: WIP: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 [02:36:02] (03CR) 10jenkins-bot: [V: 04-1] WIP: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson) [02:46:32] 3Wikipedia-App-Android-App: SuggestedPagesFunnel is sending events when it shouldn't - https://phabricator.wikimedia.org/T76933#832692 (10Deskana) [02:46:50] Krinkle: emailing with my information from above as well in case you're afk [02:49:13] jhobs: jQuery provides e.target as well as 'this'. [02:49:23] jhobs: 'this' is always the element you targetted in the event handler. [02:49:36] e.target should be avoided. Mostly used in legacy code that predates jQuery. [02:49:59] It has a few uses (like if you explicitly want the span in your case), but otherwise you'll want to default in code you write to 'this' [02:50:00] I figured 'this' would equate to document.body in this case, but it's actually the selector? [02:50:19] the filtered selector* [02:50:29] jhobs: 'this' would refer to a jQuery object wrapped around document.body (never document.body itself) in the context of a jQuery class method. [02:51:10] (03PS1) 10Dbrant: Image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178416 [02:51:13] jhobs: e.g. jQuery.fn.myPlugin = function () { this; /* this one */ }; $(document.body).on( .. ).myPlugin(); then it would be document.body (the jQuery object thereof) [02:51:36] jhobs: but an event handler is always triggered on an individual element, not on the collection as a whole. [02:51:41] ah therein must have lied my confusion [02:51:53] thanks! [02:52:19] yw :) [03:26:22] (03PS1) 10Jhobs: Fix for bug T76982 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178420 [03:30:56] (03CR) 10Yurik: [C: 032] Fix for bug T76982 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178420 (owner: 10Jhobs) [03:31:15] (03Merged) 10jenkins-bot: Fix for bug T76982 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178420 (owner: 10Jhobs) [06:18:40] (03PS1) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 [06:28:25] (03CR) 10Kaldari: Redoing how mobile handles tables (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari) [06:35:31] (03PS2) 10Florianschmidtwelzow: Hide Details box when user taps the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177937 [06:36:09] (03CR) 10Florianschmidtwelzow: Hide Details box when user taps the image (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177937 (owner: 10Florianschmidtwelzow) [07:40:10] 3Design, MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#832940 (10matmarex) [08:17:19] 3MobileFrontend-Feature-requests: Need option to switch off "Thanks" - https://phabricator.wikimedia.org/T74903#832967 (10PamD) [08:22:48] Somebody hed [08:22:51] here*? [09:06:50] morning phuedx [09:44:25] (03CR) 10Jhernandez: Improve [Alpha page styling experiment] Image at top (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [09:46:22] (03CR) 10Jhernandez: Improve [Alpha page styling experiment] Image at top (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [09:47:46] (03CR) 10Jhernandez: Improve [Alpha page styling experiment] Image at top (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [09:59:42] (03CR) 10Florianschmidtwelzow: "> defaults to medium font size not small" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [10:12:33] (03PS9) 10Florianschmidtwelzow: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 [10:14:22] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [10:49:13] morning joakino_ [10:49:24] my router has been playing up all morning [10:49:27] hi! :3 [10:49:34] know the feeling :p [11:18:01] (03PS1) 10Florianschmidtwelzow: Make sure, that toast is loaded for Thanks notifications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178471 [11:21:58] 3Design, MediaWiki-skins-Vector, MobileFrontend-General-or-Unknown: Watchlist icon does not match on desktop and mobile skin - https://phabricator.wikimedia.org/T56307#833188 (10Florian) [11:46:16] (03CR) 10Phuedx: [C: 04-1] "The change is good, but I'm a little concerned about ignoring programmer error." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [13:38:22] brb [13:51:34] (03CR) 10Dbrant: [C: 032] Avoid NPE calling updateProgressBar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178270 (owner: 10BearND) [13:52:28] (03CR) 10Dbrant: [C: 032] Remove Android Maven Plugin from credits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178349 (owner: 10BearND) [13:54:15] (03PS2) 10Dbrant: Image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178416 [14:52:11] https://www.google.co.uk/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=0CCIQqQIwAA&url=http%3A%2F%2Fandroid-developers.blogspot.com%2F2014%2F12%2Fandroid-studio-10.html&ei=kgyHVMTjGIW6Ub7lgrAD&usg=AFQjCNGHz3s7_0aY8Eq7ULr-i97bsB2J9Q&sig2=b47KiXQ5lAZ9NSfO9xEcMg&bvm=bv.81449611,d.d24 [14:52:17] ffs [14:52:18] http://android-developers.blogspot.co.uk/2014/12/android-studio-10.html [14:53:44] 3Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003 (10jeremyb-phone) 3NEW p:3Triage [14:59:18] 3Wikipedia-App-Android-App: main page last modified time confusing - https://phabricator.wikimedia.org/T78005 (10jeremyb-phone) 3NEW p:3Triage [15:57:09] (03PS1) 10Dbrant: [WIP] Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 [16:12:13] (03PS5) 10Jhernandez: Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 [16:19:19] (03PS2) 10Dbrant: [WIP] Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 [16:28:52] phuedx: ping? [16:28:56] YuviPanda: pong [16:28:59] phuedx: did you get the email from RT robh just sent? [16:29:37] YuviPanda: no, what's the email addy yer using? [16:30:13] phuedx: ssmith@wikimedia.org [16:30:18] ah [16:30:27] you'll be wanting samsmith ;) [16:30:32] goddamnit [16:32:22] phuedx: who is ssmith? [16:33:10] YuviPanda: sherah smith [16:33:18] she'll be enjoying getting all of these emails [16:33:28] phuedx yuvipanda: LOL [16:33:33] phuedx: gah, isn’t she in fr-tech? [16:33:40] heh, name collission! [16:34:11] indeed [16:34:22] she uses sherah@wikimedia.org [16:34:32] y'all should be able to get me at phuedx@wikimedia.org [16:34:49] phuedx: I’ve forwarded email to you that needs some action, can you take a look and respond on the RT email? [16:34:54] phuedx: I assume you’ve gotten email now [16:36:55] YuviPanda: i'll upload a new key pair momentarily [16:37:14] phuedx: thank you! you should be able to reply to the RT ticket to respond now [16:58:33] grr i want custom address too [17:00:53] joakino_: you should have one [17:01:30] phuedx: i have jhernandez, which is boring, i'd rather have joakin or joakino [17:02:50] phuedx: ive gone to the ldap page, but can only change password, not the name (assuming that's where I would do it) [17:03:15] joakino: I think you can ask techsupport@wikimedia.org to do it [17:04:39] kristenlans: oh cool, I'll email them [17:06:29] joakino_: yeah, you’ve to email ‘em to get an alias, and then set yourself up on gmail to be able to send from that :) [17:06:29] * YuviPanda is glad he’s not ypandian [17:07:03] YuviPanda: does it change gerrit/phab/wikitech user name too? [17:07:17] joakino_: nope. [17:07:30] joakino_: but nothing stopping you from registering a wikitech / phab / gerrit username that’s joakino : [17:07:31] :) [17:07:52] joakino: my gerrit/wikitech account predates my @wikimedia.org account by quite a while, they aren’t actually linked together [17:13:37] (03CR) 10Jhernandez: [C: 032] Restore styling to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177951 (owner: 10Jdlrobson) [17:15:01] (03Merged) 10jenkins-bot: Restore styling to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177951 (owner: 10Jdlrobson) [17:29:17] (03PS3) 10Dbrant: [WIP] Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 [17:30:10] (03CR) 10Jhernandez: [C: 04-1] "See http://i.imgur.com/S1Glers.png (firefox) and http://i.imgur.com/OAfLuv7.png (firefox & chrome)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [17:31:23] dbrant: how about a new beta release? [17:32:24] bearND: absolutely. you want to take care of it? [17:32:45] dbrant: yes [17:40:37] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178544 [17:46:00] dbrant, bearND: With lead images turned off? :-) [17:46:10] Deskana: correct! [17:46:16] \o/ [17:49:33] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178544 (owner: 10BearND) [17:49:44] (03CR) 10Jhernandez: [C: 032] Pre-commit hook: Check jsdoc coverage of any touched files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177883 (owner: 10Jdlrobson) [17:49:58] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178544 (owner: 10BearND) [17:51:56] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178548 [17:52:22] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178548 (owner: 10BearND) [17:52:45] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178548 (owner: 10BearND) [17:58:02] (03CR) 10Bmansurov: "Thanks for the feedback, Phuedx. Would exposing 4 new functions mean that I will have to expose 4 new functions for each of hijackLink and" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [18:01:12] (03CR) 10Bmansurov: EventLogging: break up MobileWebClickTracking (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [18:03:36] kaldari, our window:P [18:03:55] I don't even have a deployment key at home [18:04:46] MaxSem: That's OK, I don't think we actually need to do a deployment today. All the new WikiGrok stuff will go out on the train to en.wiki tomorrow. So I'm fine with waiting. [18:05:39] MaxSem: I was originally thinking we could deploy it a day early for testing, but we can just use the hours between the core deployment and the SWAT window (for the config change) to do that tomorrow. [18:06:11] MaxSem: See the schedule I sent out yesterday [18:06:20] (03CR) 10Florianschmidtwelzow: Alpha experiment: Replace search bar with branding and icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [18:06:39] yep, just reminding after a bot ping:) [18:06:54] MaxSem: I'm trying to exercise more patience :) [18:07:04] thanks for the reminder though [18:09:11] 3MobileFrontend-Feature-requests: Need option to switch off "Thanks" - https://phabricator.wikimedia.org/T74903#833999 (10Jdlrobson) [18:16:51] brion: heya! [18:17:10] hey hey [18:18:26] brion: hangout in a bit? chat about some data stuffs :) [18:19:26] brion: advance warning - i’ve had too much coffee and not enough sleeps... [18:20:11] haha [18:20:19] sure! just coffeeing up myself [18:23:28] brion: ping me when caffeine level’s in the green :) [18:23:48] i’m trying to remember how to put a sick day into adp payroll portal. man this thing has an awful ui [18:24:17] brion: my ex-college people work on it, so has to be :) [18:24:23] lol [18:24:31] YuviPanda: whoa really? [18:25:01] it reminds me of web interfaces from 2000 [18:25:24] YuviPanda: hey when are heading this way? [18:25:28] *are you* [18:25:43] mhurd: heh, yeah really they are :) if it’s any consolation, *they* hate it too :) [18:25:55] mhurd: Jan for all staff, moving in March [18:26:46] so i can make a ‘new time request’ but that only allows inputting future dates [18:27:00] dbrant: Deskana: fyi, just updated SDK Tools from 23.0.5 to 24 and AS to 1.0.0 [18:27:04] i can’t say ‘i was sick yesterday just record it in the damn system’. this is why i never use it bah [18:27:09] YuviPanda: march! awesome! [18:27:24] bearND: ah cool, thx [18:27:31] YuviPanda: looking foward to finally meeting you in person in January [18:27:40] bearND: me too! :) [18:27:49] YuviPanda: me3! [18:28:11] dbrant: +1! [18:28:38] dbrant: wow, we've added 19 new languages since the last beta [18:29:03] bearND: whoa! [18:29:15] bearND: i wonder if all the fonts are supported, tho [18:29:45] (03CR) 10Phuedx: EventLogging: break up MobileWebClickTracking (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [18:29:47] kaldari: yeah i see reset.less https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileApp/4e625ee06ec9302ccf0be8cb1908825cf4310d19/MobileApp.php [18:30:15] dbrant: it's weird some seem to show up duplicated. we had "ta" before, now it also added "ta-IN" [18:30:38] mhurd: Here's what I changed in the resets: https://gerrit.wikimedia.org/r/#/c/178438/1/less/reset.less [18:31:02] mhurd: resetting to vertical-align: baseline; especially causes lots of problems [18:31:40] kaldari: interesting - i’m gonna play with that in the app… [18:32:11] dbrant: only 6 languages are really new, the rest is adding a regional version of the same translations. Maybe something new in Google Play Publisher [18:32:23] bearND: hmm, curious [18:32:43] ok lemme find my glasses so i can read all this stuff :D then ready to work [18:32:57] (03CR) 10Phuedx: "> Would exposing 4 new functions mean that I will have to expose 4 new functions for each of hijackLink and logPastEvent functions too?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [18:33:06] dbrant: we don't have duplicated resource folders for those [18:35:09] mhurd: and actually, I think the font: inherit; reset needs to be removed too, as it prevents table headers from being made bold by the browser [18:37:41] (03CR) 10Jdlrobson: [C: 04-1] Beta border sanity (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 (owner: 10Robmoen) [18:38:15] mhurd: anytime :D [18:38:16] (03PS2) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 [18:38:19] phuedx: hey, so about the hijackLink function. What would be an alternative for not creating 4 of those? [18:38:23] brion: ah just a sec… [18:39:22] (03CR) 10Jdlrobson: "I think the importants don't make sense either." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 (owner: 10Robmoen) [18:39:42] (03CR) 10Jdlrobson: "At very least !important use should be commented to make clear what they are overriding" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 (owner: 10Robmoen) [18:40:15] bmansurov: so one that i just thought of: just use an enum object to control the api for other developers [18:40:33] which isn't creating new functions, but it's making it easier for developers to not make errors [18:40:45] alternatively, split out each schema into a new logging module [18:40:52] all modules have the same interface [18:40:53] phuedx: and check if passed 'schema' is in that enum? [18:41:09] phuedx: i think that's what i'll do [18:41:20] yeah, which is what you're almost doing anyhow [18:41:31] my thing is, i wan't it to be obvious when i've messed up [18:41:34] ok [18:41:45] the jQuery analogy made me think hard about what i was saying [18:42:11] i see [18:42:50] but good apis make it really easy to do the right thing [18:43:06] I agree [18:43:08] but i think the enum'll make that easy while not creating a whole load of new functions [18:43:40] dbrant: Deskana|Away: beta is published [18:43:52] bearND: \o/ awesome [18:44:11] ok [18:45:28] (03CR) 10Jdlrobson: "Do we want to try this in beta first in case there are unwanted side effects?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari) [18:46:39] whee [18:48:18] (03CR) 10Jdlrobson: [C: 04-1] "Talked to kaldari will do this in beta first" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari) [18:48:55] brion: again, the flexibility of not using coredata here is so awesome :) [18:49:02] hehe [18:49:03] (03CR) 10Legoktm: "Does mobile.special.mobilediff.scripts depend upon mobile.toast? Or does the Thanks code depend upon mobile.toast?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178471 (owner: 10Florianschmidtwelzow) [18:50:18] (03CR) 10Florianschmidtwelzow: "The thanks code, but this module is for the thanks code only (loggingSchema is used by thanks code, too)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178471 (owner: 10Florianschmidtwelzow) [18:50:57] brion: oh check this out: https://gerrit.wikimedia.org/r/#/c/177957/ [18:51:12] (03CR) 10Jdlrobson: [C: 04-1] "As Legoktm says, issues is in thanks extension." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178471 (owner: 10Florianschmidtwelzow) [18:51:16] woops [18:51:16] :D [18:51:35] brion: oh, and the other patch i tagged you on is probably not what we want to do [18:51:48] (03CR) 10Brion VIBBER: [C: 032] Fix for imagesBySection method. Was sorting on values instead of keys. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177957 (owner: 10Mhurd) [18:52:20] yay [18:52:40] i’ll check the other one [18:54:48] (03PS4) 10Dbrant: [WIP] Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 [18:54:53] (03PS1) 10Brion VIBBER: Regression fix: save current article in prefs again [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178554 [18:55:22] bearND, dbrant: Thank you, gentlemen! [18:56:02] 3MobileFrontend-stable: MobileFrontend and $wgUseFileCache - https://phabricator.wikimedia.org/T78021 (10StasR) 3NEW p:3Triage [18:56:29] (03CR) 10Jdlrobson: [C: 032] Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [18:57:57] (03Merged) 10jenkins-bot: Improve [Alpha page styling experiment] Image at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177201 (owner: 10Jhernandez) [18:58:12] brion: is https://gerrit.wikimedia.org/r/#/c/178554/1 good to go? [18:58:24] yeps [18:58:29] (03PS2) 10Mhurd: Regression fix: save current article in prefs again [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178554 (owner: 10Brion VIBBER) [18:58:47] (03CR) 10Mhurd: [C: 032 V: 032] "Yes!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178554 (owner: 10Brion VIBBER) [18:58:53] \o/ [18:59:08] brion: my merge is strong today [18:59:15] :D [18:59:23] oh man i still havent watched the new star wars trailer [18:59:31] brion: WHAT! [18:59:42] brion: stop what you are doing [18:59:46] haha [19:01:22] (03CR) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [19:02:27] mhurd: ok that looks cool. i might forgive george lucas for the last 3 [19:02:28] MAYBE [19:02:55] brion: never forgive! never forget! [19:03:01] ;) [19:03:15] why is E.T. running away from those nice government men with walkie-talkies?? [19:03:21] lol [19:03:39] brion: i binge watched that damn thing like 20 times the day it came out [19:04:05] i still feel burned from when i thought darth maul was gonna be an awesome bad guy [19:04:15] and he’s there for like a 15 minute fight and dies [19:04:32] you might say he…. fell to pieces [19:04:39] hahahah [19:04:50] * tfinc looks about [19:04:52] On the topic of using a web view for image descriptions... [19:04:53] I felt a great disturbance in the Native Code, as if millions of TextViews suddenly cried out in terror and were suddenly silenced. I fear something terrible has happened. [19:05:19] attributed strings 4evahhhhh [19:05:22] web views nevahhhhh [19:05:36] brion: ya. the plinket reviews of 1, 2 & 3 are the only good things that came out of 1, 2 & 3. if you haven’t seen them, best deconstuctions of all time [19:05:51] heh i’ll have to pull those up sometime [19:06:19] brion: http://redlettermedia.com/plinkett/ [19:06:44] ah yeah i’ve got null fromtitles, that’s not always filled out is it [19:06:58] brion: note the reviews are almost as long as the movies :) [19:07:47] brion: hmm that sounds possible [19:08:18] (03CR) 10Florianschmidtwelzow: "Sorry, i haven't seen, that mobilediff.js uses loggingSchema, so i thought, that all mobile dependencies for thanks are managed in MobileF" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178471 (owner: 10Florianschmidtwelzow) [19:08:32] (03Abandoned) 10Florianschmidtwelzow: Make sure, that toast is loaded for Thanks notifications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178471 (owner: 10Florianschmidtwelzow) [19:09:17] (03PS3) 10Bmansurov: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 [19:10:41] (03CR) 10jenkins-bot: [V: 04-1] EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [19:11:02] (03PS4) 10Bmansurov: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 [19:12:29] (03PS1) 10Brion VIBBER: Regression fix: don't explode on edit sections with no fromtitle (it's optional field) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178559 [19:12:52] hmmmm why won’t it let me rebase that [19:13:22] jdlrobson: i've found out where the /potential/ error is, but i feel way out of my depth here [19:13:27] with the translation stuff [19:13:29] (03CR) 10Jdlrobson: "Is there a bug associated with this? It's hard to work out what I'm testing against." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [19:13:36] phuedx: \o/ [19:13:41] phuedx: what did you find? [19:13:51] (03PS2) 10Brion VIBBER: Regression fix: don't explode on edit sections with no fromtitle (it's optional field) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178559 [19:14:04] ah my gerrit login died [19:14:09] sighhhh [19:14:11] CoreParserFunctions::intFunction calls wfMessage( $key )->inLanguage( $parser->getOptions()->getUserLangObj() )->plain(); [19:14:19] rather than carrying forward the parser's configured language [19:14:23] so: [19:14:33] wfMessage( $key )->inLanguage( $parser->getOptions()->getTargetLanguage() )->plain(); [19:15:21] ^ with that change the url you put in the gerrit change works fine [19:15:30] brion: merge it? [19:15:34] merge it! [19:15:36] 3Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#834158 (10Deskana) [19:15:50] (03CR) 10Mhurd: [C: 032 V: 032] "Merge it!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178559 (owner: 10Brion VIBBER) [19:16:01] (03CR) 10Jdlrobson: Small style tweaks to reference drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen) [19:21:18] 3Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#834182 (10Krenair) What was the request made to the API exactly? [19:24:55] 3MobileFrontend-Feature-requests: Need option to switch off "Thanks" - https://phabricator.wikimedia.org/T74903#834186 (10Jaredzimmerman-WMF) 5Open>3declined a:3Jaredzimmerman-WMF See {T71636} for undo feature, declining this for now. While accidentally sending thanks for actions that you didn't mean to co... [19:25:24] jdlrobson: am gonna read through the parser testing stuff -- there's not really a test case that covers this [19:25:52] jdlrobson: also, i can't help feeling that this should've turned up before [19:26:31] (03PS1) 10Brion VIBBER: Fix 'Today' link [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178568 [19:26:35] i think we were aware of it but it only effects uselang [19:26:45] it's not a problem if site language is french for example [19:27:57] 3MobileFrontend-Feature-requests: Need option to switch off "Thanks" - https://phabricator.wikimedia.org/T74903#834203 (10Jdlrobson) .mw-mf-action-button { display: none; } should do it but haven't tested. [19:28:55] 3Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#834211 (10Deskana) It looks like this: https://en.wikipedia.org/w/api.php?action=mobileview&format=json&page=File:FEMA_-_25380_-_Photograph_by_Barry_Bahler_taken_on_07-2... [19:29:36] jdlrobson: yeah, that looks like that should be the case [19:29:52] (03CR) 10Jdlrobson: [C: 032] Hide Details box when user taps the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177937 (owner: 10Florianschmidtwelzow) [19:29:54] i suspect bug in Language code [19:30:03] mhurd: having trouble reprodicing ‘Seeing crash "'MWArticleStoreException', reason: 'invalid input, not a mobileview api data'" regularly after browsing from link to link for a couple minutes.’ [19:30:11] 3MobileFrontend-stable, Mobile-Web: Hide details Overlay in MediaViewer after tap on screen - https://phabricator.wikimedia.org/T70504#834212 (10Jdlrobson) 5Open>3Resolved [19:30:38] it could be something missing from ParserOptions or somewhere in the Language code [19:30:41] :/ [19:31:14] ok [19:31:18] gonna go clear my head [19:31:19] bbiab [19:33:05] (03Merged) 10jenkins-bot: Hide Details box when user taps the image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177937 (owner: 10Florianschmidtwelzow) [19:34:18] brion: i hit it maybe 3 or 4 times randomly… maybe force it & just handle somehow w/o crash? [19:35:02] we can probably rig it up to not crash at laeast :D [19:35:14] catch the exception and show an err message instead [19:35:20] brion: sounds good [19:35:40] (03CR) 10Jdlrobson: [C: 031] "Looks fine need to test it before +2ing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [19:35:58] brion: would it be too tricky to this for all exceptions? [19:36:17] *to do this* [19:36:29] mhurd: well, all exceptions that fall within a certain place :D [19:36:54] hehe yeah, the ones we throw at least ) [19:37:20] *typing skills are low today* [19:37:59] on ‘tropical depression link…. “TypeError: null is not an object (evaluating 'document.getElementById( href.substring( 1 ) ).scrollIntoView’)” [19:38:12] did we lose the section ids when we moved to the new loading maybe? [19:38:49] ah i bet i messed something up in the data model [19:38:50] (03CR) 10Mhurd: [C: 032 V: 032] "Yes!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178568 (owner: 10Brion VIBBER) [19:38:54]

Physical structure

[19:40:16] i see it, i forgot to actually import the anchor property? [19:41:06] brion: ah, seems so [19:41:40] jdlrobson: In https://trello.com/c/4icRYufi/26-5-eventlogging-update-all-click-tracking-graphs do we want new graphs to show old data? [19:42:07] bmansurov: question for maryana but i think ideally yes [19:42:31] jdlrobson: If not I don't see a need for unions [19:43:40] (03PS1) 10Brion VIBBER: Fix regression with section links [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178576 [19:52:18] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178576 (owner: 10Brion VIBBER) [19:52:25] (03PS1) 10Brion VIBBER: Be less explody when failing to load an image [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178580 [19:52:31] (03PS1) 10Brion VIBBER: Hopefully be less explody on article load failures [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178581 [19:53:02] brion: i should abandon this right? https://gerrit.wikimedia.org/r/#/c/177956/ [19:53:17] mhurd: yeah i have a better fix for that now [19:53:19] which i think you merged :D [19:53:26] brion: ya i thought so :) [19:53:31] flyingclimber: Do we have a list of mobile team travel for the all staff? [19:53:37] (03Abandoned) 10Mhurd: Fixes edit pencil crash? Not sure about this one... [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177956 (owner: 10Mhurd) [19:53:39] dbrant, bearND: When are you guys coming and leaving in January for the all staff? [19:53:42] brion: done [19:53:54] ok lemme grab a quick bite then i’ll see if i can figure out those dupes in the history list. it’s supposed to prune them out but … obviously something is failing :D [19:54:23] Deskana: arriving on the 20th (morning), leaving 31st. [19:55:13] Deskana: arriving on 1/20 in the afternoon, leaving on 1/30 after work [19:55:25] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178580 (owner: 10Brion VIBBER) [19:55:34] Great, thanks. :) [20:03:37] (03CR) 10Mhurd: [C: 032 V: 032] "Seems legit." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178581 (owner: 10Brion VIBBER) [20:04:08] brion: foooooood! [20:04:19] nom nom nom [20:04:34] :) [20:07:05] Deskana: no one just for mobile but if you need it just let Rachel know and she create it for us [20:07:16] (03PS1) 10Dr0ptp4kt: Ensure zerodot redirects stay on zerodot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 [20:08:35] yurikR: would you please review and +2 ^ ? also, if you can please deploy tomorrow i would appreciate it. [20:15:31] bearND: shall we abandon this one? https://gerrit.wikimedia.org/r/167612 [20:16:31] dbrant: sure [20:16:47] dbrant: i'll abandon it [20:17:23] (03Abandoned) 10BearND: WIP: Update for Android 5.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167612 (owner: 10BearND) [20:18:33] 3Wikipedia-App-Android-App: main page last modified time confusing - https://phabricator.wikimedia.org/T78005#834447 (10Krenair) 5Open>3Invalid a:3Krenair This is consistent with MediaWiki core, which also displays the last modified date of the page itself (not accounting for updates to files, transclusion... [20:19:13] (03PS2) 10Jdlrobson: Add support for donation button in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177668 [20:19:55] (03CR) 10Jdlrobson: Add support for donation button in beta (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177668 (owner: 10Jdlrobson) [20:20:46] Hi MaxSem [20:21:02] yo [20:21:06] (03PS3) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 [20:21:14] MaxSem, what am I going to say to this user asking about Turkish Nearby? [20:21:41] tell them to update their coordinate templates [20:21:48] Shall I try to edit the #coordinates thing into the trwiki template? [20:21:53] hm [20:22:26] Yeah, I doubt this user will be able to deal with editing wikitext templates themselves :) [20:29:27] Krenair, or they could wait for Wikidata integration. it will be only for primary coordinates though [20:31:44] jdlrobson: kaldari: does one of you want to jump into the content folding discussion on wikitech-l ? [20:33:21] tfinc: i'm watching it. I'm hoping for a few more replies before jumping in. [20:33:28] thanks jdlrobson [20:33:34] i assume you mean the content tree email? [20:34:56] (03CR) 10Robmoen: Beta border sanity (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 (owner: 10Robmoen) [20:36:22] (03PS2) 10Robmoen: Bind events only once in _fixIosHeader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 [20:36:26] (03PS3) 10Robmoen: Bind events only once in _fixIosHeader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 [20:36:54] (03CR) 10Robmoen: "This should definitely be merged as this is a huge memory leak to bind these events every time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 (owner: 10Robmoen) [20:37:12] (03PS1) 10Brion VIBBER: Test fix for shortened image paths [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178596 [20:37:14] (03PS1) 10Brion VIBBER: Quick fix for tests: can no longer store anon user objects standalone [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178597 [20:37:17] (03PS1) 10Brion VIBBER: Quick fix for tests: need section id on importImageURL [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178598 [20:37:19] (03PS1) 10Brion VIBBER: Fix for multiple history entries bug [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178599 [20:38:52] also OMGYES http://wiki.polyfra.me/ [20:42:13] puurrrrrty [20:43:11] ^ mhurd [20:44:11] (03PS2) 10Robmoen: For ios8 detection check for version 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173471 [20:45:52] MaxSem, basically copied in the enwiki code for this: https://tr.wikipedia.org/w/index.php?title=%C5%9Eablon:Coord&diff=14904108&oldid=13403635 [20:46:01] it's pending review [20:46:38] what review? [20:46:44] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178596 (owner: 10Brion VIBBER) [20:47:08] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178597 (owner: 10Brion VIBBER) [20:47:13] bmansurov: why doesn't `make jsduck` work for me any more? [20:47:22] You need to have Ruby and JSDuck installed and in your PATH for this task to work. See https://github.com/dpashkevich/grunt-jsduck for details. [20:47:25] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178598 (owner: 10Brion VIBBER) [20:47:29] whee [20:47:42] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178599 (owner: 10Brion VIBBER) [20:48:11] :) [20:48:24] MaxSem: I have an action=mobileview question for you. [20:48:35] sure [20:48:38] MaxSem, the edit I made to the page requires review [20:48:56] jdlrobson: that's weird, it works for me. maybe your ruby version doesn't match? [20:49:09] MaxSem: This query is running action=mobileview on the English Wikipedia, but on a file page for a file that exists on Commons: https://en.wikipedia.org/w/api.php?action=mobileview&format=json&page=File:FEMA_-_25380_-_Photograph_by_Barry_Bahler_taken_on_07-27-2006_in_District_of_Columbia.jpg&prop=text|sections&onlyrequestedsections=1§ions=0§ionprop=toclevel|line|anchor&noheadings=true [20:49:12] Krenair, ah, you mean I should yell at you if something's wrong? :P [20:49:31] MaxSem: This is in the output: description page there [20:49:36] MaxSem: That seems wrong to me. :) [20:49:49] MaxSem: Is this a problem with the MobileFrontend API, or is it somewhere else? [20:49:49] Well you should, but I mean it's waiting for someone with the right flags to tell FlaggedRevs it's okay. [20:50:07] jdlrobson: whoa that’s pretty nifty :) [20:50:34] Deskana, looks like a bug:P [20:50:44] bmansurov: worked it out [20:50:44] in MF, likely [20:50:47] bmansurov: patch on way [20:50:57] or just due to some change in the core [20:51:03] MaxSem: I'll file a Phab task against MobileFrontend for now, then. [20:51:05] MaxSem: Cheers. [20:51:31] Wait... [20:51:31] 3MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#834612 (10Deskana) [20:51:33] There [20:51:44] I just added MobileFrontend to the projects for the existing task [20:51:46] GO GO PHAB [20:52:06] 3MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#833576 (10Deskana) I chatted with Max and he says this is probably a bug in MobileFrontend. [20:54:55] (03PS3) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 [20:54:57] (03PS1) 10Jdlrobson: Hygiene: Update pngs via `grunt build-icon` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178607 [20:54:59] (03PS1) 10Jdlrobson: Hygiene: Update `make jsduck` dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178608 [20:55:01] (03PS1) 10Jdlrobson: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178609 [20:58:31] Krenair, looks cursorily right but I don't have a wikitext parser in my head:) [20:58:40] :) [20:59:43] (03CR) 10Jdlrobson: [C: 04-1] "jscs complaints!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:01:25] (03PS10) 10Jdlrobson: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:02:36] (03CR) 10Jdlrobson: [C: 032] "Let's iterate on this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:02:37] dbrant: hey! [21:02:50] (03CR) 10jenkins-bot: [V: 04-1] Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:02:51] mhurd: sup! [21:03:07] (03CR) 10Jdlrobson: Alpha: Add possibility to change font size of the content (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:03:16] dbrant: could i bother you to send me a screenshot of what the “Perception” article looks like on android w lead image styling? [21:03:41] dbrant: fine tuning gradients and whatnot [21:03:50] mhurd: sure, 1 sec [21:03:55] dbrant: thanks! [21:04:01] (03PS11) 10Jdlrobson: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:04:38] (03CR) 10Jdlrobson: [C: 032] "Please refactor SkinMinerva in a follow up and look at the behaviour of font changing when you open hamburger menu" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:05:34] (03PS1) 10Brion VIBBER: 'section99/Section.plist' -> '99/Section.plist' [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178644 [21:05:58] MaxSem: Having trouble getting the rate limit to trigger on WikiGrok response. I set $wgGroupPermissions['*']['noratelimit'] = false; in localsettings. Anything else I need to do? [21:06:33] the docs for pingLimiter() say it requires memcached [21:06:47] brion: what’s the regex doing? [21:07:09] mhurd: confirming the directory name is just a digit, and not some random stray directory that came in [21:08:49] (03Merged) 10jenkins-bot: Alpha: Add possibility to change font size of the content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:09:21] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178644 (owner: 10Brion VIBBER) [21:10:03] 3MobileFrontend-stable, Mobile-Web: Swiping in the edit screen blanks the screen - https://phabricator.wikimedia.org/T75046#834658 (10Jdlrobson) [21:10:16] dbrant: thanks for the png! :) [21:10:25] mhurd: np! [21:11:23] 3MobileFrontend-stable, Mobile-Web: Icons in IE8 due to lack of support for background sizes - https://phabricator.wikimedia.org/T72961#834665 (10Jdlrobson) [21:13:54] 3MobileFrontend-stable, Mobile-Web: Icons in IE8 due to lack of support for background sizes - https://phabricator.wikimedia.org/T72961#834684 (10Jdlrobson) Update: In alpha: main menu icons and watchstar, section toggle arrow all appear zoomed in. Hamburger icon is clipped vertically. Patches welcomed to fix a... [21:14:16] dbrant: is the lead image 40% of total height? (https://trello.com/c/Fmcftrli/96-lead-image) [21:16:08] dbrant: i saw 40% number from this image that card https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/53c812eba1f0e3b0ae039264/3571x3996/bbaee498516e7ce573cdc1f927fb9d04/LeadIllustrations_Android.png [21:16:39] 3MobileFrontend-Feature-requests: [Tracking] Deprecate redlink removal (enable redlinks in stable) - https://phabricator.wikimedia.org/T71849#834699 (10Jdlrobson) [21:17:10] MaxSem: set up memcached, but still not triggering the limit. hmmm [21:17:14] mhurd: it's slightly larger than 40%... iirc, we made it a bit larger because some of the faces were getting squeezed a little too much. [21:17:23] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#834711 (10Jdlrobson) [21:17:38] dbrant: cool. i’ll just use same percentage then [21:17:50] dbrant: looks to be ~ 47% [21:18:13] 3MobileFrontend-Feature-requests: Special:History should work on desktop - https://phabricator.wikimedia.org/T66939#834721 (10Jdlrobson) [21:18:17] kaldari, well it definitely works: https://integration.wikimedia.org/ci/job/mwext-WikiGrok-testextension/95/console XD [21:20:36] 3MobileFrontend-Feature-requests: top of article messy on phones and inconsistent with tablet - https://phabricator.wikimedia.org/T73450#834747 (10Jdlrobson) [21:20:43] 3MobileFrontend-Feature-requests: The mobile site does not display collapsible elements - https://phabricator.wikimedia.org/T71773#834750 (10Jdlrobson) [21:20:51] 3MobileFrontend-Feature-requests: Link to 'create a new article' if no related Article is found in search - https://phabricator.wikimedia.org/T70289#834753 (10Jdlrobson) [21:21:00] 3MobileFrontend-Feature-requests: Add Donation link to main navigation - https://phabricator.wikimedia.org/T69626#834755 (10Jdlrobson) [21:22:37] 3MobileFrontend-Feature-requests: "Desktop" in page footer of Special:Uploads returns Page unavailable - https://phabricator.wikimedia.org/T66986#834772 (10Jdlrobson) [21:22:47] 3MobileFrontend-Feature-requests: Examine discoverability and usability of search on low-JS devices - https://phabricator.wikimedia.org/T66926#834776 (10Jdlrobson) [21:22:50] 3MobileFrontend-Feature-requests: Examine discoverability and usability of search on low-JS devices - https://phabricator.wikimedia.org/T66926#701560 (10Jdlrobson) [21:23:07] 3MobileFrontend-Feature-requests: Allow configuration of the mobilefrontend menu - https://phabricator.wikimedia.org/T65459#834783 (10Jdlrobson) [21:23:32] 3MobileFrontend-Uploads: Uploads AbuseFilter styling regression - https://phabricator.wikimedia.org/T65332#834784 (10Jdlrobson) [21:24:03] Deskana: the full-text search api no longer seems to be giving "did you mean" suggestions... is this a known issue? [21:24:23] 3MobileFrontend-Feature-requests: Links to talk pages in mobile view - https://phabricator.wikimedia.org/T54165#834792 (10Jdlrobson) [21:24:28] 3MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#834793 (10Jaredzimmerman-WMF) @Jdlrobson why is this non-actionable, can you please comment as to what is needed to unblock this? [21:24:42] 3MobileFrontend-Feature-requests: Mobile login not compatible with OpenID - https://phabricator.wikimedia.org/T54059#834798 (10Jdlrobson) [21:25:07] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#834805 (10Jaredzimmerman-WMF) [21:25:55] 3MobileFrontend-General-or-Unknown: C/C++ wiki link page does not have a link while it does in desktop view - https://phabricator.wikimedia.org/T76274#834810 (10breadncup) Got it. Thanks, [21:29:02] 3MobileFrontend-Feature-requests: normal diff links don't redirect to MobileDiff - https://phabricator.wikimedia.org/T63489#834839 (10Jdlrobson) [21:29:05] 3MobileFrontend-Feature-requests: normal diff links don't redirect to MobileDiff - https://phabricator.wikimedia.org/T63489#834840 (10Jdlrobson) [21:31:16] dbrant: No... [21:32:31] manybubbles: Do you know anything about this? [21:32:49] manybubbles: "Did you mean" seems to not be being returned by the search API anymore. [21:33:03] Deskana: no idea [21:33:18] is it returned by the search on page? [21:33:33] dbrant, manybubbles: I'll let you two chat. :) [21:33:58] dbrant: can you send me an example? [21:34:09] standby... [21:34:28] dbrant: this certainly provides a suggestion: https://en.wikipedia.org/w/index.php?search=ozzyi+osboune&title=Special%3ASearch&go=Go [21:35:24] (03PS1) 10Florianschmidtwelzow: Use a better way to add Main menu sitelinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 [21:35:36] mhurd: poke poke ios update mtg? [21:35:57] brion: oh crap just a sec [21:36:19] i got distracted [21:36:31] manybubbles: https://en.wikipedia.org/w/api.php?action=query&prop=pageprops&generator=search&gsrsearch=ozzyi%20osboune&gsrnamespace=0&gsrwhat=text&gsrlimit=12 [21:36:32] :) [21:36:34] (03CR) 10Florianschmidtwelzow: "> Please refactor SkinMinerva in a follow up" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [21:38:05] 3MobileFrontend-Feature-requests: normal diff links don't redirect to MobileDiff - https://phabricator.wikimedia.org/T63489#834893 (10Ragesoss) I think we took this discussion to IRC back in September, but the current situation is that it's still an issue. The main place where I get these non-redirected links o... [21:40:32] dbrant: I think it has to do with switching to the generator [21:40:46] I'll file an issue [21:41:01] 3MobileFrontend-Feature-requests: Allow end users to view images compressed to decrease page load times - https://phabricator.wikimedia.org/T68819#834909 (10Jaredzimmerman-WMF) [21:41:28] manybubbles: thx! we definitely need to use the generator... [21:43:21] 3MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#834918 (10Jaredzimmerman-WMF) @Jdlrobson what are the open questions? [21:44:10] 3MobileFrontend-Feature-requests: images are too small on tablets and large phones - https://phabricator.wikimedia.org/T65134#834920 (10Jaredzimmerman-WMF) [21:44:20] 3MobileFrontend-Feature-requests: normal diff links don't redirect to MobileDiff - https://phabricator.wikimedia.org/T63489#834921 (10Jdlrobson) @ragesoss can you paste a sample URL that is not redirecting? Thanks :D [21:45:32] 3MobileFrontend-Feature-requests: Allow end users to view images compressed to decrease page load times - https://phabricator.wikimedia.org/T68819#834933 (10Jdlrobson) From patch "Note that doing this in PHP would require varying cache by the new cookie and thus an ops review. Blocking until that happened. An al... [21:45:45] 3MobileFrontend-Feature-requests: images are too small on tablets and large phones - https://phabricator.wikimedia.org/T65134#675384 (10Jaredzimmerman-WMF) [21:46:03] 3MobileFrontend-Feature-requests: normal diff links don't redirect to MobileDiff - https://phabricator.wikimedia.org/T63489#834937 (10Ragesoss) From a watchlist email I got yesterday: http://en.wikipedia.org/w/index.php?title=Wikipedia:Education_program/Assignment_Design_Wizard&diff=next&oldid=636824769 [21:47:22] 3MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#834942 (10Jdlrobson) No design input. No idea how this should work. Do we use Special:MobileOptions or something like that Is it worth doing when we have BetaFeatures Needs lots of di... [21:47:33] brion: hi, now that i spot u, i was wondering if we could talk about TMH some time soon. during a Frontednd meeting or whatever. [21:47:55] thedj: sure, ping me before to remind me :D [21:48:08] k, will do [21:48:27] i started jshint/jscs'ing upstream in the mean time :) [21:53:08] (03PS1) 10Florianschmidtwelzow: Remove unneeded vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178659 [21:54:45] 3MobileFrontend-Feature-requests: Allow end users to view images compressed to decrease page load times - https://phabricator.wikimedia.org/T68819#834985 (10Jaredzimmerman-WMF) [21:55:42] 3MobileFrontend-Feature-requests: normal diff links don't redirect to MobileDiff - https://phabricator.wikimedia.org/T63489#834990 (10Jdlrobson) Thanks a bunch Sage! :) [21:56:04] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project names of VE and WTE -... [21:57:04] 3MobileFrontend-Feature-requests: Allow end users to view images compressed to decrease page load times - https://phabricator.wikimedia.org/T68819#835005 (10Jdlrobson) So am I give me time... I'm triaging and working out the best columns as we speak :P [21:57:16] dbrant: the new image gallery looks great but why is it an activity and not a fragment? [21:59:34] 3MobileFrontend-Feature-requests: Allow end users to view images compressed to decrease page load times - https://phabricator.wikimedia.org/T68819#835013 (10Jaredzimmerman-WMF) {F20295} [22:00:17] bearND: my rationale was as follows -- (1) a separate activity would allow more efficient screen rotation while in gallery mode. (2) it would allow us to have a totally different Toolbar. (3) not much else. [22:00:44] dbrant: ok [22:01:06] bearND: are there compelling arguments for a fragment? [22:01:30] dbrant: no, just wondering [22:01:57] 3MobileFrontend-Feature-requests: Allow end users to view images compressed to decrease page load times - https://phabricator.wikimedia.org/T68819#835022 (10Jaredzimmerman-WMF) Sorry those fireworks are blocked by {T78072} [22:08:56] 3MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#835058 (10Jaredzimmerman-WMF) [22:10:21] 3MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#835061 (10Jaredzimmerman-WMF) [22:13:26] mhurd: ok i think i’m going to end up basically merging MWKArticle with MWKArticleStore into a ‘smarter object’, and divide up MWKImageList to live in individual sections [22:13:43] that’ll take a little reworking so probably be done with it late today or tomorrow morning [22:13:53] but that should fix up some of your requests :D [22:14:50] in the meantime… it’s “update all your ios devices to 8.1.2” time! [22:15:32] (03PS3) 10BearND: Image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178416 (owner: 10Dbrant) [22:15:39] (03CR) 10BearND: [C: 032] Image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178416 (owner: 10Dbrant) [22:15:54] android 5.0.1 also? it’s point release dayyyyy [22:16:04] bearND: ^_^ thx [22:16:22] dbrant: good job! Looks great! [22:16:23] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835090 (10Jdforrester-WMF) [22:17:28] MaxSem: So I'm trying to use vagrant to test WikiGrok, but when I use the WikiGrok role, it turns my wiki into a Wikidata repo. I tried setting $wmgUseWikibaseRepo = false; in a config file in settings.d, but it doesn't seem to have any effect. [22:18:02] kaldari, the rep[o issue has been fixed in vagrant [22:18:28] (03Merged) 10jenkins-bot: Image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178416 (owner: 10Dbrant) [22:18:49] MaxSem: So I should just disable the WikiGrok role, update vagrant, and re-enable it? [22:18:53] (03PS1) 10BearND: Update README [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178669 [22:19:30] kaldari, just git pull and provision [22:24:01] MaxSem: no luck. it still wants to act as a wikidata repo. Maybe I'll wait until you're back in the office to troubleshoot. [22:24:15] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo in WTE on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835133 (10Jaredzimmerman-WMF) @Jdforrester-WMF this behaviour should be supported by both editors on mobile devices whic... [22:24:22] (03PS1) 10BearND: Avoid NPE in when calling isSearching [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178671 [22:24:25] MaxSem: Also I guess I can just manually uninstall the Wikidata stuff in the meantime [22:24:29] 3MediaWiki-Page-editing, VisualEditor-EditingTools, MobileFrontend-Feature-requests: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835135 (10Jaredzimmerman-WMF) [22:24:49] sure, let's investigate tomorrow. we don't need this for tomorrow's train [22:25:15] 3MediaWiki-Page-editing, VisualEditor-MediaWiki-Mobile, MobileFrontend-Feature-requests: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#835138 (10Jdforrester-WMF) [22:26:39] (03PS1) 10Florianschmidtwelzow: Hide Drawer, when main menu will be open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178675 [22:26:58] (03CR) 10Florianschmidtwelzow: "-> I96044437178291d477dad52ba185cdca0238a720" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/176961 (owner: 10Florianschmidtwelzow) [22:27:32] good night all! :) [22:30:02] MaxSem: it looks like the puppet-generated configs want it to be a repo regardless of whether it is the wikidata instance or not: http://pastebin.com/5AP0MWu5 [22:30:46] that's in Wikidata-Init.php [22:31:17] that's an older version, I fixed it with https://gerrit.wikimedia.org/r/#/c/177370/1/puppet/modules/role/templates/wikidata-init.php.erb [22:33:52] (03PS1) 10Jdlrobson: Hygiene: Refactor EditorOverlay's templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178679 [22:33:54] (03PS1) 10Jdlrobson: Fix the preview header when switching from VE to wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178680 [22:35:18] (03CR) 10Jdlrobson: [C: 032] Remove unneeded vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178659 (owner: 10Florianschmidtwelzow) [22:35:25] (03PS2) 10Jdlrobson: Hygiene: Remove unneeded vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178659 (owner: 10Florianschmidtwelzow) [22:37:50] (03PS1) 10Robmoen: Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 [22:38:19] (03CR) 10jenkins-bot: [V: 04-1] Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 (owner: 10Robmoen) [22:40:11] (03CR) 10Robmoen: [C: 04-1] Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 (owner: 10Robmoen) [22:40:14] (03PS1) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 [22:41:20] MaxSem: hmm, I did 'vagrant git-update', then 'vagrant halt', then 'vagrant up', but the file is still the same. Is there a way to force puppet to regenerate those files? [22:42:24] (03PS2) 10Robmoen: Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 [22:43:20] (03PS1) 10Robmoen: WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 [22:44:12] you need to pull the vagrant repo itself [22:44:45] (03CR) 10jenkins-bot: [V: 04-1] WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 (owner: 10Robmoen) [22:47:58] MaxSem: OK, I think it's fixed now. Thanks! [22:48:04] :) [22:48:16] (03CR) 10Bmansurov: [C: 032] Add support for donation button in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177668 (owner: 10Jdlrobson) [22:48:23] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:48:40] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:49:37] brion: awesome!!! :) [22:49:41] (03Merged) 10jenkins-bot: Add support for donation button in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177668 (owner: 10Jdlrobson) [22:49:46] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:51:37] 3MediaWiki-extensions-Flow, MobileFrontend-General-or-Unknown, Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Collaboration-Team, MediaWiki-extensions-LiquidThreads, VisualEditor-MediaWiki-Mobile, Wikipedia-App-iOS-App, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project n... [22:53:08] (03PS2) 10Robmoen: Beta border sanity [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 [22:54:27] kaldari: pm? [22:54:59] prime meridian? [22:55:10] hell yeah [22:55:26] what do I win? [22:55:50] you win a wikigrok 10,000,000 badge [22:56:43] PRODUCT MANAGER [22:56:45] You called? [22:56:58] (03CR) 10Bmansurov: [C: 031] Alpha experiment: Replace search bar with branding and icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [22:57:03] Deskana LULZ [22:58:14] ^_^ [23:00:41] (03CR) 10Robmoen: [C: 04-1] WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 (owner: 10Robmoen) [23:01:33] (03PS2) 10Robmoen: WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 [23:02:30] bearND: Is PrefKeys.getKnowTocDrawer() where you store whether someone has seen the ToC onboarding or not? [23:03:20] Deskana: that's set to true when someone either pressed the "Got it" button or opens the ToC drawer by swipe [23:03:33] iirc [23:03:39] Right, cool. [23:03:43] Trying to fix a little bug I found. [23:03:44] dbrant: hey what font are you using for the lead image title? [23:12:48] bearND dbrant Deskana: latest beta lookign good :D [23:13:36] mhurd: What's that tool you use to simulate packet loss, EDGE networks, and so on? [23:13:48] Deskana: link conditioner [23:15:46] Cool, got it. [23:15:55] Trying to reproduce a bug on Android that only happens on slow connection [23:17:55] Bahaha [23:18:06] I think my interaction with the emulator is done via network [23:18:15] Because just turning that on makes the UI of the emulator unusable [23:18:41] Oh well. [23:23:09] Deskana: I used to just try when I’m on a bus... [23:23:25] YuviPanda: My Android phone has no SIM card. ;) [23:23:44] Deskana: well, if it did from what I hear in the US you don’t even have to get on a bus... [23:23:49] Deskana: are you one of those iPhone users? tch tch :P [23:25:00] YuviPanda: I prefer this Nexus 5 to my iPhone 4, but my SIM card is somehow locked into my specific phone. I can change it but I need to go in to the shop and I'm lazy. [23:25:33] Deskana: There is another app. It's called the Link/Leg conditioner: you could probably walk up and down the stairs. ;) [23:26:10] (03CR) 10Bmansurov: "The code looks good, but something is still wrong with showing missing pages. Steps to reproduce:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [23:27:14] (03CR) 10Jdlrobson: [C: 031] Hygiene: Remove unneeded vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178659 (owner: 10Florianschmidtwelzow) [23:27:20] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unneeded vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178659 (owner: 10Florianschmidtwelzow) [23:29:17] (03Merged) 10jenkins-bot: Hygiene: Remove unneeded vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178659 (owner: 10Florianschmidtwelzow) [23:29:44] mhurd: hey, sorry! it's just the default Android serif font. ("Droid Serif" i think) [23:30:03] dbrant: no worry! thanks! [23:33:12] 3Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#835353 (10Jdlrobson) [23:33:48] jdlrobson: Any reason in particular you just did that? ^ [23:33:58] jdlrobson: Max said it was a bug in MobileFrontend. [23:34:10] Deskana: ah then youneed the MobileWeb tag [23:34:14] Ah balls. [23:34:17] I don't know what "MobileFrontend-General-or-Unknown" must I want to destroy that [23:34:23] also mention what Max said [23:34:29] 3Wikipedia-App-Android-App, Mobile-Web: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#835355 (10Deskana) [23:34:29] it looks like an app bug from glancing at it [23:34:48] jdlrobson: It's not, the API is outputting garbage which the app then displays [23:35:13] jdlrobson: Thanks :) [23:42:00] 3MobileFrontend-General-or-Unknown: Can't scroll to top in editing window - https://phabricator.wikimedia.org/T71092#835402 (10Jdlrobson) [23:42:29] 3MobileFrontend-Uploads: Use GPS location to deliver locally relevant messages about copyright (for people uploading pictures) - https://phabricator.wikimedia.org/T70770#835405 (10Jdlrobson) [23:43:35] oh no! the CIALIS in speCIALIStsguild.org is triggering wiki spam filters :P [23:43:46] 3MobileFrontend-Feature-requests: Show what features are included in Beta and Experimental on mobile. - https://phabricator.wikimedia.org/T67079#835415 (10Jdlrobson) [23:45:54] 3MobileFrontend-Uploads, Mobile-Web: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - https://phabricator.wikimedia.org/T64638#835449 (10Jdlrobson) [23:46:15] kristenlans: lolol!! [23:46:24] 3MobileFrontend-Uploads: Error toast rather than AbuseFilterPanel when photo upload itself triggers AbuseFilter - https://phabricator.wikimedia.org/T63975#835454 (10Jdlrobson) [23:46:40] 3MediaWiki-extensions-Thanks, MobileFrontend-Feature-requests: Thank notification on mobile doesn't ask for confirmation: accident-prone - https://phabricator.wikimedia.org/T63737#835456 (10Jdlrobson) [23:53:21] ok downloading updates to things, be back in a bit to keep poking at article/store mix