[00:08:00] <wikibugs>	 3MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#835501 (10Jaredzimmerman-WMF)
[00:15:04] <wikibugs>	 3MobileFrontend-Uploads: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - https://phabricator.wikimedia.org/T64638#682787 (10Jdlrobson)
[00:17:16] <wikibugs>	 3MediaWiki-API, Wikipedia-App-Android-App, Mobile-Web: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#835549 (10Jdlrobson)
[00:29:34] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Avoid NPE in when calling isSearching [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178671 (owner: 10BearND)
[00:33:52] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] "very nice" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178669 (owner: 10BearND)
[00:35:18] <wikibugs>	 3MobileFrontend-Feature-requests: Show what features are included in Beta and Experimental on mobile. - https://phabricator.wikimedia.org/T67079#835589 (10Jdlrobson) We found when a submit button was below the fold people were less likely to use it. We can save automatically but it may be confusing that the user...
[00:37:00] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: Update pngs via `grunt build-icon` (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178607 (owner: 10Jdlrobson)
[00:37:42] <wikibugs>	 3MobileFrontend-Feature-requests: Show what features are included in Beta and Experimental on mobile. - https://phabricator.wikimedia.org/T67079#835602 (10Jdlrobson) See T78096
[00:39:32] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Update pngs via `grunt build-icon` (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178607 (owner: 10Jdlrobson)
[00:41:38] <grrrit-wm>	 (03PS1) 10Jdlrobson: Don't load RL module for VE in supported mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178731 
[00:49:15] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Alpha: move lastmodified to bottom of article (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[00:52:21] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hide Drawer, when main menu will be open (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178675 (owner: 10Florianschmidtwelzow)
[00:56:49] <grrrit-wm>	 (03CR) 10Bmansurov: Hygiene: Update pngs via `grunt build-icon` (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178607 (owner: 10Jdlrobson)
[01:01:56] <grrrit-wm>	 (03PS5) 10Dbrant: Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 
[01:02:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 (owner: 10Dbrant)
[01:02:16] <grrrit-wm>	 (03PS6) 10Dbrant: Display image description/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 
[01:19:34] <grrrit-wm>	 (03PS3) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 
[01:38:09] <grrrit-wm>	 (03PS7) 10Dbrant: Display image description/license/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 
[02:09:03] <grrrit-wm>	 (03PS2) 10Yurik: Ensure zerodot redirects stay on zerodot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[02:09:06] <yurikR>	 dr0ptp4kt, if you are ok with ^, i'll +2
[02:09:18] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Needs to be beta only" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari)
[02:11:36] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Enable mobile modifications on Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178755 
[02:11:38] <grrrit-wm>	 (03PS1) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 
[02:12:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Enable mobile modifications on Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178755 (owner: 10Jdlrobson)
[02:13:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson)
[02:15:34] <wikibugs>	 3Wikipedia-App-Android-App, MediaWiki-extensions-WikiEditor, Wikipedia-App-iOS-App, VisualEditor-MediaWiki-Mobile, MediaWiki-extensions-CodeEditor, MediaWiki-Page-editing: Rationalize the project names of VE and wikitext editor - https://phabricator.wikimedia.org/T78063#835778 (10Mattflaschen)
[02:15:58] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Quick question." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[02:16:05] <dr0ptp4kt>	 yurikR: i gotta run, but see ^
[02:16:14] <grrrit-wm>	 (03PS2) 10Bmansurov: WIP: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 
[02:16:17] <dr0ptp4kt>	 yurikR: let's circle tomorrow before the deployment window
[02:17:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[02:20:04] <wikibugs>	 3MobileFrontend-Feature-requests: Allow feedback for mobile beta features like Desktop - https://phabricator.wikimedia.org/T67078#835784 (10Mattflaschen)
[02:20:46] <grrrit-wm>	 (03CR) 10Yurik: Ensure zerodot redirects stay on zerodot if OK (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[02:22:16] <grrrit-wm>	 (03PS1) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[02:22:36] <grrrit-wm>	 (03PS2) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[02:24:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 (owner: 10Jdlrobson)
[02:25:46] <wikibugs>	 3MobileFrontend-Uploads: "Desktop" in page footer of Special:Uploads returns Page unavailable - https://phabricator.wikimedia.org/T66986#835795 (10Jdlrobson)
[02:26:01] <grrrit-wm>	 (03PS3) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[02:27:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 (owner: 10Jdlrobson)
[03:13:44] <grrrit-wm>	 (03PS2) 10Krinkle: Don't load mobile.editor.ve module in desktop target [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178731 (owner: 10Jdlrobson)
[03:13:51] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Don't load mobile.editor.ve module in desktop target [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178731 (owner: 10Jdlrobson)
[03:15:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load mobile.editor.ve module in desktop target [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178731 (owner: 10Jdlrobson)
[04:05:36] <grrrit-wm>	 (03PS1) 10Deskana: Add hidePageContent convenience method to PageViewFragmentInternal [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178761 
[04:17:49] <grrrit-wm>	 (03PS1) 10BearND: Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 
[04:18:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[04:31:00] <grrrit-wm>	 (03PS2) 10BearND: Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 
[04:31:03] <grrrit-wm>	 (03PS1) 10BearND: Fix checkstyle warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178764 
[04:37:20] <wikibugs>	 3Wikipedia-App-Android-App: NPE in PageViewFragment.onCreateOptionsMenu - https://phabricator.wikimedia.org/T78115 (10bearND) 3NEW p:3High
[04:39:50] <wikibugs>	 3Wikipedia-App-Android-App: NPE in PageViewFragment.onCreateOptionsMenu - https://phabricator.wikimedia.org/T78115#835898 (10bearND)
[04:50:13] <wikibugs>	 3Wikipedia-App-Android-App: App crash on 4.1 LG device when pressing menu button - https://phabricator.wikimedia.org/T78117 (10bearND) 3NEW p:3High
[05:04:22] <wikibugs>	 3Wikipedia-App-Android-App: Add a 'Night Mode' to the Wikipedia Mobile app - https://phabricator.wikimedia.org/T37251#835933 (10Quiddity)
[05:34:16] <grrrit-wm>	 (03PS1) 10BearND: Avoid crash when menu button is pressed on 4.1 LG devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178769 
[05:43:32] <grrrit-wm>	 (03PS1) 10Deskana: Refactor code for storing preference for EventLogging opt-out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178771 
[05:43:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor code for storing preference for EventLogging opt-out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178771 (owner: 10Deskana)
[05:46:32] <grrrit-wm>	 (03PS2) 10Deskana: Refactor code for storing preference for EventLogging opt-out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178771 
[08:17:09] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[08:18:11] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[08:19:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[08:58:55] <grrrit-wm>	 (03PS1) 10Yurik: Allow portal= parameter for Special:ZeroPortal [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/178795 
[09:28:05] <joakino_>	 morning
[09:28:48] <wikibugs>	 3MediaWiki-API, Wikipedia-App-Android-App, Mobile-Web: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#836112 (10Schnark)
[09:30:22] <wikibugs>	 3MediaWiki-API, Wikipedia-App-Android-App, Mobile-Web: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#833576 (10Schnark) Since this task has already more information than the older one, I merged T40756 into this rather then the other way round.
[10:02:01] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Don't stop click propagation when clicked on hamburger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178675 
[10:04:45] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[10:07:12] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Don't stop click propagation when clicked on hamburger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178675 
[10:08:14] <phuedx>	 yo
[10:09:45] <phuedx>	 ^ joakino
[10:19:37] <joakino__>	 hi phuedx
[10:19:43] <phuedx>	 hey hey
[11:13:26] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Alpha experiment: Replace search bar with branding and icon (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson)
[11:19:38] <grrrit-wm>	 (03CR) 10Jhernandez: Alpha experiment: Replace search bar with branding and icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson)
[11:39:19] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "I'm not sure how but this seems to break the "Edit summary" step of the VE editor flow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178680 (owner: 10Jdlrobson)
[11:54:45] <grrrit-wm>	 (03CR) 10Phuedx: [C: 031] Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 (owner: 10Robmoen)
[11:54:53] <grrrit-wm>	 (03CR) 10Phuedx: [C: 031] WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 (owner: 10Robmoen)
[12:11:51] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] "I've been trying this out and I'm getting different behaviour the first and second time I focus a text area (presumably because the focus " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 (owner: 10Robmoen)
[12:54:00] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] WIP: Alpha: move lastmodified to bottom of article (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[13:04:34] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Another question." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[13:11:26] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Adding PHP CLI example for clarity." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[13:41:32] <grrrit-wm>	 (03PS3) 10Yurik: Ensure zerodot redirects stay on zerodot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[13:43:52] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Don't bypass blocked user check in editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 
[13:44:18] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 
[13:46:10] <joakino_>	 out for lunch
[14:35:07] <joakino_>	 back
[14:51:03] <grrrit-wm>	 (03PS2) 10Yurik: Allow portal= parameter for Special:ZeroPortal [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/178795 
[15:18:50] <grrrit-wm>	 (03PS1) 10Dbrant: Wikidata descriptions in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178855 
[15:27:12] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Fix checkstyle warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178764 (owner: 10BearND)
[15:29:34] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Avoid crash when menu button is pressed on 4.1 LG devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178769 (owner: 10BearND)
[15:39:14] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Refactor code for storing preference for EventLogging opt-out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178771 (owner: 10Deskana)
[15:41:59] <grrrit-wm>	 (03PS1) 10Phuedx: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 
[15:46:07] <grrrit-wm>	 (03CR) 10Phuedx: "Restyling of the secondary actions will be done in a follow-on change when the "Read in another language" icon asset has been uploaded." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[15:46:09] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Add hidePageContent convenience method to PageViewFragmentInternal [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178761 (owner: 10Deskana)
[15:47:38] <grrrit-wm>	 (03PS3) 10Dbrant: Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[15:52:44] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031] Ensure zerodot redirects stay on zerodot if OK (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[16:08:03] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Been trying it out, no problems that I could notice." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[16:08:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[16:09:24] <grrrit-wm>	 (03CR) 10Jhernandez: "Needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[16:15:59] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 (owner: 10Robmoen)
[16:18:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: WikiGrok: Pass campaign_name to ApiResponse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178688 (owner: 10Robmoen)
[16:18:55] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Awesome patch, thanks" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173471 (owner: 10Robmoen)
[16:21:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: For ios8 detection check for version 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173471 (owner: 10Robmoen)
[16:23:58] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 (owner: 10Robmoen)
[16:26:29] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "Looks pretty good! Just a couple quick notes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[16:26:52] <joakino_>	 phuedx: why? because we are not supposed to break anything?
[16:27:28] <phuedx>	 joakino_: not break
[16:27:31] <phuedx>	 /change/
[16:27:33] <phuedx>	 ;)
[16:28:32] <bearND>	 dbrant: would you send me a screenshot of how the license text looks on your device?
[16:29:48] <joakino_>	 phuedx: oh i understand
[16:30:04] <joakino_>	 what's the procedure on merged patches? new patch that reverts?
[16:30:12] <joakino_>	 phuedx: just curious ^
[16:31:16] <dbrant>	 bearND: http://imgur.com/lVFoGS4
[16:32:19] <bearND>	 dbrant: thanks. you mean the wrapping of the text?
[16:32:45] <phuedx>	 joakino_: new patch that reverts i think
[16:32:50] <dbrant>	 bearND: right
[16:33:02] <joakino_>	 ok
[16:35:30] <Maryana>	 greetings, europeople!
[16:39:23] <grrrit-wm>	 (03CR) 10Phuedx: "I've just tried the rebase and in testing the necessary modifications to the font size changer I've found that the click tracking doesn't " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[16:39:32] <phuedx>	 hullo Maryana 
[17:09:25] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "My general thoughts on this so far:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178147 (owner: 10Deskana)
[17:15:34] <phuedx>	 jerith: diffusion spam?
[17:17:42] <phuedx>	 mibad
[17:17:48] <phuedx>	 joakino: diffusion spam!
[17:22:00] <dbrant>	 diffusion!!!111
[17:23:00] <mhurd>	 dbrant: hehe wat
[17:23:16] <grrrit-wm>	 (03CR) 10Deskana: "It looked odd on my device too, so I ran the following perl one-liner from the assets folder and it stripped all the single newlines but l" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[17:23:41] <dbrant>	 mhurd: it's flooding my inbox (~40 of them)
[17:23:55] <grrrit-wm>	 (03CR) 10Deskana: "And yes, that script does actually work. It looks like total nonsense... but that's Perl for you." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[17:24:15] <mhurd>	 dbrant: huh. where’s it from?
[17:24:45] <joakino_>	 phuedx: wyat happened?
[17:24:51] <dbrant>	 mhurd: Chad was saying that Diffusion might spam us today, and to ignore it :)
[17:25:12] <phuedx>	 i think someone's importing all the gerrit commits into diffusion
[17:25:15] <phuedx>	 spam ahoy!
[17:25:15] <mhurd>	 dbrant: gotcha
[17:25:27] <joakino_>	 lol
[17:25:43] <joakino_>	 let's hope gmail doesn't start sending them directly to spam
[17:25:47] <grrrit-wm>	 (03CR) 10Deskana: "And, erm, I meant that I ran it from licenses folder, not the assets folder, obviously. :-)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[17:35:20] <grrrit-wm>	 (03PS4) 10BearND: Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 
[17:38:30] <bearND>	 dbrant: ^ I replaced single \n with <br/>
[17:38:59] <bearND>	 dbrant: didn't understand why I would only replace double \n
[17:41:34] <grrrit-wm>	 (03PS5) 10BearND: Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 
[17:41:36] <bearND>	 dbrant: oh well, I just tried it and it does look better ^
[17:41:41] <dbrant>	 bearND: That doesn't fix the word-wrapping issue.  The reason we want to use fromHtml() is so that the line breaks are treated as whitespace, so that the paragraphs appear continuous in the TextView.  However, a *double* line break indicates a new paragraph;  that's why we want to convert only double line breaks to a double-<br>
[17:42:20] <bearND>	 dbrant: yes, see my latest patch set
[17:42:44] <dbrant>	 bearND: oh! excellent
[17:45:48] <MaxSem>	 grr grr
[17:46:07] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Legal requirement: add links to license text for libraries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178763 (owner: 10BearND)
[17:46:13] <MaxSem>	 need to produce a stool sample, can't poop
[17:47:54] <grrrit-wm>	 (03PS2) 10Dbrant: Wikidata descriptions in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178855 
[17:51:27] <mhurd>	 dbrant: ^ nice! :)
[17:52:06] <dbrant>	 mhurd: just one more parameter in the api request!
[17:52:16] <mhurd>	 :)
[17:53:08] <mhurd>	 dbrant: i’m re-adding all the wikidata descrips to the ios app presently…
[17:53:16] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "Needs a manual rebase. Probably conflict in credits.xml." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 (owner: 10Dbrant)
[17:59:48] <grrrit-wm>	 (03PS8) 10Dbrant: Display image description/license/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 
[18:00:31] <rmoen>	 kristenlans: sorry last minute notice.  I have to miss the standup, will email update.
[18:00:48] <rmoen>	 internet is wonky at the moment
[18:02:30] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] Wikidata descriptions in Nearby. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178855 (owner: 10Dbrant)
[18:03:28] <kristenlans>	 Thanks rmoen
[18:07:09] <grrrit-wm>	 (03PS3) 10Dbrant: Wikidata descriptions in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178855 
[18:08:24] <chrismcmahon>	 hi Mobile folk, I have a question: in the new Phab world, who monitors incoming bug reports marked "Needs Triage"? I filed two this morning and I'm not sure of the process now.
[18:12:56] <bearND>	 chrismcmahon: that's where our phabulous KPhab (kristenlans) comes in. There's also this query: https://phabricator.wikimedia.org/maniphest/query/7TBTH5XTB4Bs/#R
[18:15:27] <chrismcmahon>	 bearND: kristenlans that's weird, the issues I reported are not in that query https://phabricator.wikimedia.org/T78158 https://phabricator.wikimedia.org/T78155
[18:16:05] <phuedx>	 go to sleep or backlog grooming?
[18:16:10] <phuedx>	 go to sleep or backlog grooming
[18:16:12] <phuedx>	 hrrrm
[18:16:15] <phuedx>	 brb
[18:16:30] <joakino_>	 chrismcmahon: ping kristenlans maybe for answers
[18:16:34] <joakino_>	 i'm out too for today
[18:16:49] <joakino_>	 cartrip
[18:16:57] <joakino_>	 bb people, have a nice day
[18:16:58] <chrismcmahon>	 bearND: kristenlans I see the problem. that query does not contain the "Mobile-Web" tag
[18:17:13] <bearND>	 she's running our standup right now. done in 15 min
[18:29:17] <grrrit-wm>	 (03PS5) 10Bmansurov: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 
[18:31:30] <grrrit-wm>	 (03PS6) 10Bmansurov: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 
[18:32:32] <grrrit-wm>	 (03CR) 10Bmansurov: "Phuedx, I've updated the schema and included fontchanger fields: https://meta.wikimedia.org/wiki/Schema:MobileWebUIClickTracking" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[18:37:59] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Kaldari asked to hold off merging this until he's finished his experiments (see email thread)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 (owner: 10Robmoen)
[18:38:52] <grrrit-wm>	 (03CR) 10Jdlrobson: Beta border sanity (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178386 (owner: 10Robmoen)
[18:39:51] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Wikidata descriptions in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178855 (owner: 10Dbrant)
[18:40:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Wikidata descriptions in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178855 (owner: 10Dbrant)
[18:40:53] <jdlrobson>	 bmansurov: don't really understadn what you are saying on https://gerrit.wikimedia.org/r/#/c/177939/
[18:43:03] <jdlrobson>	 oh wait i see what you are saying
[18:46:22] <bmansurov>	 hi5 for seeing what i'm saying
[18:48:36] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson)
[18:49:10] <grrrit-wm>	 (03CR) 10Bmansurov: WIP: Alpha: move lastmodified to bottom of article (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[18:50:55] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "Thanks. The image viewer looks great." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 (owner: 10Dbrant)
[18:53:18] <bmansurov>	 jdlrobson: what is "RL module" in https://gerrit.wikimedia.org/r/#/c/178686/1/less/content/links.less
[18:53:39] <jdlrobson>	 bmansurov: ResourceLoader module
[18:53:43] <jdlrobson>	 Resources.php
[18:53:47] <bmansurov>	 ;)
[18:54:59] <grrrit-wm>	 (03PS9) 10Dbrant: Display image description/license/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 
[18:59:01] <jdlrobson>	 errgg php
[18:59:17] <jdlrobson>	 if I have an array with 0 in it why does array_search always return 0 no matter the search term ?!?
[19:00:53] <bearND>	 dbrant: the comma needs to be moved, too
[19:01:11] <grrrit-wm>	 (03PS4) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[19:02:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 (owner: 10Jdlrobson)
[19:04:21] <grrrit-wm>	 (03PS4) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 
[19:05:18] <grrrit-wm>	 (03PS5) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 
[19:06:38] <dbrant>	 bearND: gah
[19:07:44] <grrrit-wm>	 (03PS10) 10Dbrant: Display image description/license/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 
[19:08:11] <phuedx>	 jdlrobson: are you using strict array search?
[19:08:18] <jdlrobson>	 phuedx: yeh
[19:08:24] <phuedx>	 array_search( $needle, $haystack, true );
[19:08:27] <phuedx>	 ?
[19:08:28] <jdlrobson>	 bmansurov watched a page called '0' and apparently it breaks the search
[19:08:31] <jdlrobson>	 i worked that out
[19:08:32] <jdlrobson>	 but php is dumb
[19:08:39] <jdlrobson>	 incorporated in fix :)
[19:08:43] <bmansurov>	 cool
[19:09:40] <grrrit-wm>	 (03PS11) 10BearND: Display image description/license/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 (owner: 10Dbrant)
[19:13:19] <grrrit-wm>	 (03CR) 10BearND: [C: 032] "Very cool!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 (owner: 10Dbrant)
[19:13:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Display image description/license/metadata in gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178532 (owner: 10Dbrant)
[19:14:23] <dbrant>	 bearND: thanks!  things are lookin' up!
[19:14:46] <grrrit-wm>	 (03PS3) 10Bmansurov: WIP: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 
[19:17:26] <grrrit-wm>	 (03PS4) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 
[19:18:30] <jdlrobson>	 phuedx: so you getting any sleep these days?
[19:18:34] <phuedx>	 me?
[19:18:40] <phuedx>	 what's sleep?
[19:18:56] <phuedx>	 yeah
[19:19:04] <phuedx>	 harry's sleeping for ~4 hour stretches
[19:19:17] <phuedx>	 so i get a chunk of four and then a chunk of three ish
[19:20:45] <grrrit-wm>	 (03PS5) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[19:20:47] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Make uploads page agnostic about current skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178886 
[19:20:50] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Hygiene: Enable mobile modifications on Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178755 (owner: 10Jdlrobson)
[19:21:00] <grrrit-wm>	 (03PS2) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 
[19:22:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 (owner: 10Jdlrobson)
[19:22:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "havent' tested. one question." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[19:22:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make uploads page agnostic about current skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178886 (owner: 10Jdlrobson)
[19:23:14] <bmansurov>	 anyone knows why I cannot view my commits in phabricator? I get 'access denied' message. This link for example: https://phabricator.wikimedia.org/rEMFR7f3aeedd8d3c1fc01f07f79905c23be285467237
[19:25:03] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Ensure zerodot redirects stay on zerodot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[19:25:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure zerodot redirects stay on zerodot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/178589 (owner: 10Dr0ptp4kt)
[19:25:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson)
[19:26:32] <grrrit-wm>	 (03PS6) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[19:26:34] <grrrit-wm>	 (03PS1) 10Jdlrobson: Apply mobile modifications inside minerva desktop skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178888 
[19:28:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Apply mobile modifications inside minerva desktop skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178888 (owner: 10Jdlrobson)
[19:30:03] <grrrit-wm>	 (03PS3) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 
[19:37:27] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838675 (10Jaredzimmerman-WMF) 3NEW
[19:37:47] <grrrit-wm>	 (03PS1) 10Mhurd: Re-added Wikidata descriptions to search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178890 
[19:37:50] <leila>	 kaldari, where I can follow up on the status of test 2?
[19:38:00] <wikibugs>	 3MobileFrontend-Feature-requests: Show what features are included in Beta and Experimental on mobile. - https://phabricator.wikimedia.org/T67079#838684 (10Jaredzimmerman-WMF)
[19:38:11] <kaldari>	 leila: good question....
[19:38:19] <mhurd>	 brion: ^ wikidata!
[19:38:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "This change seems dangerous so we must be sure to do it carefully.." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[19:38:42] <mhurd>	 brion: so snappy now that we don’t have to do separate request :)
[19:39:02] <kaldari>	 leila: http://etherpad.wikimedia.org/p/WikiGrokTest2DataQA
[19:41:01] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "Now that the client-side part of this is merged..." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 (owner: 10Robmoen)
[19:41:17] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-Feature-requests, MobileFrontend-beta: Hide Beta features that are not supported by the current skin. - https://phabricator.wikimedia.org/T78187#838692 (10Jaredzimmerman-WMF) 3NEW
[19:41:46] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838699 (10Jdforrester-WMF) What? We've agreed that we're not intending to ever mix up Beta Feat...
[19:42:28] <leila>	 thanks, kaldari. can you ping me when it's live?
[19:42:30] <kaldari>	 leila: Looks like train deployment isn't quite finished yet
[19:42:35] <kaldari>	 leila: will do
[19:42:42] <leila>	 thanks!
[19:43:56] <wikibugs>	 3Wikipedia-App-Android-App: NPE in PageViewFragment.onCreateOptionsMenu - https://phabricator.wikimedia.org/T78115#838704 (10Krenair) (See also https://gerrit.wikimedia.org/r/174005 )
[19:44:39] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838706 (10Jaredzimmerman-WMF) @Jdforrester-WMF if Mobile-web teams needs to use the Beta Featur...
[19:45:58] <wikibugs>	 3MobileFrontend-Feature-requests: Show what features are included in Beta and Experimental on mobile. - https://phabricator.wikimedia.org/T67079#838708 (10Jaredzimmerman-WMF)
[19:46:00] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-Feature-requests, MobileFrontend-beta: Hide Beta features that are not supported by the current skin. - https://phabricator.wikimedia.org/T78187#838709 (10Legoktm) How is this different from T78096?
[19:46:22] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838713 (10Jdforrester-WMF) >>! In T78186#838706, @Jaredzimmerman-WMF wrote: > @Jdforrester-WMF...
[19:46:38] <Krenair>	 Deskana, wondering who I should send a user with font size issues on ipad/iphone to...
[19:46:44] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-Feature-requests, MobileFrontend-beta: Hide Beta features that are not supported by the current skin. - https://phabricator.wikimedia.org/T78187#838714 (10Jaredzimmerman-WMF)
[19:46:47] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Also talk icon in beta looks wonky" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[19:46:57] <Krenair>	 I think it's a mobile web problem?
[19:47:00] <Krenair>	 probably
[19:47:25] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Make uploads page agnostic about current skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178886 
[19:47:40] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838720 (10Jaredzimmerman-WMF) @Jdlrobson — https://phabricator.wikimedia.org/T67079#835589
[19:47:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow for campaign_name parameter to be passed to ApiResponse [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/178681 (owner: 10Robmoen)
[19:48:14] <phuedx>	 ta jdlrobson
[19:48:23] <phuedx>	 will fix that up tomo
[19:48:32] <grrrit-wm>	 (03CR) 10Phuedx: "Sorry Bmansurov, I meant that click tracking doesn't actually work for it on master, i.e. I see no click tracking events for any of the el" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[19:51:24] <Deskana>	 Krenair: You can get them to email with, with a screenshot if possible. :)
[19:51:25] <grrrit-wm>	 (03CR) 10Phuedx: Restyle/reposition page actions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[19:52:04] <Krenair>	 Deskana, it is an email. no screenshot though. They don't know exactly where it should go, and honestly I don't know the best place either
[19:52:26] <Deskana>	 Oh, well, I'm not sure what you mean by "go" then, if they're already in touch with us?
[19:52:28] <phuedx>	 ok
[19:52:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Much nicer! but one quick tweak please! :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 (owner: 10Florianschmidtwelzow)
[19:52:32] <phuedx>	 g'night folks
[19:52:38] <Krenair>	 Deskana, it's info-en
[19:52:54] <Deskana>	 Can you link the ticket to me?
[19:53:04] <Krenair>	 Deskana, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7986400
[19:53:42] <grrrit-wm>	 (03CR) 10Jdlrobson: Use a better way to add Main menu sitelinks (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 (owner: 10Florianschmidtwelzow)
[19:53:45] <Deskana>	 We need to figure out whether they're using the app or web.
[19:53:45] <grrrit-wm>	 (03PS1) 10Mhurd: Re-added Wikidata descriptions to Nearby results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178900 
[19:54:03] <Krenair>	 I'll ask them that, and for a screenshot then?
[19:54:15] <Deskana>	 Krenair: Yes, please. :)
[19:54:20] <Krenair>	 ok
[19:55:14] <Deskana>	 dbrant: Stupid question... how do I trigger the image viewer?
[19:55:31] <dbrant>	 Deskana: click on an image?
[19:55:40] <Deskana>	 Yeah, it loaded the file page.
[19:55:42] <wikibugs>	 3Wikipedia-App-Android-App: NPE in PageViewFragment.onCreateOptionsMenu - https://phabricator.wikimedia.org/T78115#838764 (10bearND) Good catch. Looks like a pattern to me. Looking for more occurrences in the code...
[19:55:49] * Deskana scratches his head
[19:55:56] <grrrit-wm>	 (03PS1) 10BearND: More areas to avoid NPE when calling isSearching [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178901 
[19:55:56] <dbrant>	 Deskana: got the latest build?
[19:56:08] <Deskana>	 Yeah,  just pulled from master and made an alphaDebug
[19:56:14] <Deskana>	 2.0-alpha-2014-12-10
[19:57:00] <dbrant>	 Deskana: hmm, where's the image in question?
[19:57:20] <Krenair>	 bearND, onCreateOptionsMenu crash - long-term beta user says they can't launch the app due to it. Will you guys update the beta again soon or shall I tell them to use stable until the next beta update?
[19:57:38] <grrrit-wm>	 (03PS2) 10Mhurd: Re-added Wikidata descriptions to search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178890 
[19:58:18] <Deskana>	 dbrant: Main page
[19:58:32] <Deskana>	 But it also doesn't work in the lead image, or images in articles
[19:58:35] <Deskana>	 Wait
[19:58:39] <Deskana>	 Erm
[19:58:42] <Deskana>	 Hm
[19:59:04] <Deskana>	 Okay, so I take that back, I guess
[19:59:19] <Deskana>	 I swear it wasn't working before
[19:59:26] <Deskana>	 But that image on the main page still doesn't load the image viewer
[19:59:35] <Deskana>	 It's the first image in the "in the news" section
[19:59:51] <bearND>	 Krenair: my inclination is to publish another beta once we get all the crashes taken care of in a day or two (cc: dbrant Deskana). Not sure if we can get the lead image stuff in there as well.
[19:59:59] <mhurd>	 brb
[20:00:16] <Deskana>	 Anyway, it looks good!
[20:00:19] <Deskana>	 I need to dash right now
[20:00:22] <Deskana>	 Chat to you guys later :)
[20:00:23] <Krenair>	 cool, thanks bearND 
[20:01:34] <bearND>	 Krenair: is that info you told me in OTRS?
[20:01:48] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838777 (10Jdforrester-WMF) >>! In T78186#838720, @Jaredzimmerman-WMF wrote: > @Jdlrobson — http...
[20:02:07] <Krenair>	 bearND, the one about onCreateOptionsMenu causing the app not to open?
[20:02:16] <bearND>	 Krenair: yes
[20:02:18] <Krenair>	 yes
[20:03:11] <Krenair>	 I just took care of it - it's https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8013544
[20:04:01] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838781 (10Jdlrobson) To be clear I've not suggested anything about __actually__ doing this. I j...
[20:04:15] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838784 (10Jaredzimmerman-WMF) p:5Normal>3Low I don't know that we need to focus on it right...
[20:04:59] <mhurd>	 Deskana: the wikidata stories went super fast :)
[20:05:20] <mhurd>	 Deskana: using the ”index” key for ordering now too
[20:05:49] <yurikR>	 dr0ptp4kt, could you +2 https://gerrit.wikimedia.org/r/#/c/178795/
[20:05:50] <yurikR>	 thx )
[20:06:05] <yurikR>	 its been tested, seems to work in many different conditions
[20:06:32] <Maryana>	 kaldari: DarTar any updates on a/b test? :)
[20:09:40] <dbrant>	 Deskana: the image of Zhou Yongkang (on the main page) doesn't have an 'image' CSS class. That's why I'm not picking it up as a viewable image. Note that the Desktop site also fails to view that image in MediaViewer.
[20:11:34] <mhurd>	 foods
[20:11:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "apart from this i think we are ready to go" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[20:13:48] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "See comment... :-/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen)
[20:14:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "a few minor comments but mostly i'd like a task to know what i'm testing for.. what is broken and this fixes?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen)
[20:19:06] <grrrit-wm>	 (03PS4) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 
[20:20:11] <dbrant>	 Deskana: there's a dictussion about that in the Talk page for that template: https://en.wikipedia.org/wiki/Template_talk:In_the_news/image
[20:20:26] <dr0ptp4kt>	 yurikR, in case you are operating under a different handle, i'll get to reviewing that patch prior to the deployment.
[20:25:27] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Use a better way to add Main menu sitelinks (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 (owner: 10Florianschmidtwelzow)
[20:27:10] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Refactor EditorOverlay's templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178679 
[20:27:24] <grrrit-wm>	 (03PS2) 10Jdlrobson: Fix the preview header when switching from VE to wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178680 
[20:27:32] <grrrit-wm>	 (03PS3) 10Jdlrobson: Fix the preview header when switching from VE to wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178680 
[20:31:02] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Use a better way to add Main menu sitelinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 
[20:36:36] <Krenair>	 Deskana, actually I just peaked into the iOS app queue and it looks like there's been a few requests for a way to change font size in that
[20:37:01] <jdlrobson>	 kaldari:  where you at?
[20:37:37] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "Is it intended to not show the last editor (last edited by) in alpha anymore?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[20:37:51] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Use a better way to add Main menu sitelinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 (owner: 10Florianschmidtwelzow)
[20:38:17] <Krenair>	 (I count 9 of those requests since the start of September)
[20:38:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Use a better way to add Main menu sitelinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 (owner: 10Florianschmidtwelzow)
[20:38:39] <grrrit-wm>	 (03CR) 10Bmansurov: "It is, Florianschmidtwelzow, but after the body. Please see https://trello.com/c/Om3Xr4ss/10-1-alpha-page-styling-experiment-move-lastmodi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[20:39:33] <jdlrobson>	 joakino: did you sort out your email woes?
[20:41:12] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Sorry, i think you misunderstood me :) The bar is visible, with the time of the last edit, but there is not "by Florian" (e.g.) anymore. A" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[20:42:56] <grrrit-wm>	 (03CR) 10Bmansurov: "Florianschmidtwelzow, you're right. For some reason the wording is also different. I'm looking into it. Thanks for catching it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[20:47:47] <grrrit-wm>	 (03CR) 10Jdlrobson: "As Florian also points out the JavaScript isn't kicking in" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[20:49:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Use a better way to add Main menu sitelinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178648 (owner: 10Florianschmidtwelzow)
[20:51:37] <wikibugs>	 3MobileFrontend-alpha, MediaWiki-extensions-BetaFeatures, MobileFrontend-Feature-requests, MobileFrontend-beta: Allow BetaFeatures page to be shown outside Special:Preferences effectively SpecialBetaFeatures - https://phabricator.wikimedia.org/T78186#838966 (10Jdlrobson)
[21:06:18] <kristenlans>	 Yo kaldari are we meeting?
[21:06:24] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: no_javascript view no longer has watchlist available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178923 
[21:07:18] <kaldari>	 kristenlans: sorry, lunch ran long...
[21:08:13] <chrismcmahon>	 jdlrobso_: feature or bug? after updating the no-javascript test I also see that the link to "Log in" no longer exists in the no-javascript view https://gerrit.wikimedia.org/r/#/c/178923/
[21:08:35] <jdlrobso_>	 chrismcmahon: feature for no-js
[21:08:42] <jdlrobso_>	 dr0ptp4kt's request
[21:08:54] <chrismcmahon>	 jdlrobso_: thanks, will remove that step also then
[21:08:55] <bmansurov>	 FlorianSW: what's the syntax for getting a skin property in a template?
[21:09:32] <bmansurov>	 jdlrobso_: ^?
[21:09:41] <FlorianSW>	 you mean for a template? BaseTemplate::get() and BaseTemplate::set()
[21:09:50] <dr0ptp4kt>	 chrismcmahon: jdlrobso_, Maryana and Carolynne agreed to hide those features for the time being
[21:10:22] <bmansurov>	 FlorianSW: Say, I'm trying to get a public property of Minerva skin in Minerva template.
[21:10:41] <FlorianSW>	 then the above :)
[21:10:46] <kristenlans>	 https://phabricator.wikimedia.org/project/board/67/
[21:10:54] <bmansurov>	 FlorianSW: thanks
[21:11:04] <FlorianSW>	 in SkinMinerva you can set a value with BaseTemplate::set() and use it in MinervaTemplate with $data[]
[21:11:58] <Deskana>	 Krenair: Yeah, it is indeed a very requested feature. Did you know that the same was true on Android, but only 1% of our userbase used it? :-)
[21:12:11] <Deskana>	 Krenair: This is why we can't prioritise it right now. We're so strapped for resources.
[21:12:17] <bmansurov>	 FlorianSW: I see, is there no other way? If I have a public property in SkinMinerva, won't I be able to access it in MinervaTemplate?
[21:13:03] <FlorianSW>	 bmansurov: with property you mean a class variable? Is it static?
[21:13:14] <grrrit-wm>	 (03PS2) 10Cmcmahon: QA: no_javascript view no longer has watchlist or Log inavailable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178923 
[21:13:16] <bmansurov>	 FlorianSW: yes, it's not static
[21:13:38] <Deskana>	 dbrant, bearND: I've been chatting to Katherine and Juliet in Comms and they want to do a rollout of lead images on both platforms. We may need to delay rolling it out.
[21:13:45] <Deskana>	 dbrant, bearND: I want Howie's advice on this.
[21:14:03] <FlorianSW>	 then you can use it via SkinTemplate->variablename (in MinervaTemplate you can use $this->getSkin() to get the corresponding SkinMinerva)
[21:14:14] <grrrit-wm>	 (03PS3) 10Cmcmahon: QA: no_javascript view no longer has watchlist or Log inavailable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178923 
[21:14:23] <bmansurov>	 FlorianSW: thanks
[21:14:29] <kaldari>	 jdlrobso_: Are the bugs in the 'Submit a patch' column in Phabricator already converted into Trello cards?
[21:15:08] <Deskana>	 dbrant, bearND: Either way, lead images not withstanding, I would love to do a production release next week.
[21:15:24] <chrismcmahon>	 jdlrobso_: if you review https://gerrit.wikimedia.org/r/#/c/178923/ , I checked and "I should see the watch star" is not used in any other test
[21:21:33] <dbrant>	 Deskana: :/
[21:21:45] <dbrant>	 Deskana: what about the image gallery view?
[21:21:55] <Deskana>	 dbrant: There's no reason that couldn't go out.
[21:22:30] <Deskana>	 dbrant: Basically, what I think we need is to define an acceptable amount of time to wait. Howie's input on that would be appreciated.
[21:22:35] <Deskana>	 That way, we don't be stuck waiting indefinitely.
[21:22:47] <Deskana>	 Perhaps we should jump in to a hangout for this.
[21:22:56] <Deskana>	 Batcave?
[21:23:08] <dbrant>	 sure!
[21:23:23] <Deskana>	 Let me grab a room.
[21:23:28] <Deskana>	 bearND: You may want to join us. :)
[21:23:43] <bearND>	 Deskana: ok
[21:27:48] <Krenair>	 Deskana, I'm not suggesting  you should prioritise it, I just learned that the iOS app does not support it. Which was relevant to our earlier conversation.
[21:28:55] <wikibugs>	 3Wikipedia-App-Android-App, Mobile-Web, MediaWiki-API: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#839111 (10KLans_WMF) This bug is being tracked here: https://trello.com/c/4mLJ86do/48-bug-t78003-description-page-there-commons-images-links-to...
[21:29:29] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Use user rights to check, if the user can edit page (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[21:43:42] <wikibugs>	 3Wikipedia-App-Android-App: NoClassDefFoundError: android.support.v7.internal.view.menu.MenuBuilder - https://phabricator.wikimedia.org/T78197#839148 (10bearND) 3NEW
[21:48:27] <dbrant>	 bearND: there's an update to the support library...
[21:48:37] <grrrit-wm>	 (03PS5) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 
[21:48:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov)
[21:49:01] <wikibugs>	 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#839160 (10kaldari) Could someone please explain what an 'indicator' is?
[21:49:53] <bearND>	 dbrant: great. Thanks. I'll update and test it. Will also see if the issue from yesterday is fixed
[21:50:06] <grrrit-wm>	 (03PS6) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 
[21:53:26] <bearND>	 dbrant: there are also new tools and build tools revisions
[21:53:54] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Allow portal= parameter for Special:ZeroPortal [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/178795 (owner: 10Yurik)
[21:54:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow portal= parameter for Special:ZeroPortal [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/178795 (owner: 10Yurik)
[21:54:36] <dbrant>	 bearND: yep, i see it.  Do you know of a URL for the actual release notes for the support library? i can't find them anywhere..
[21:55:16] <bearND>	 dbrant: the only thing I can find is for the major versions but nothing for the point releases
[21:55:32] <dbrant>	 :/
[21:55:40] <bearND>	 dbrant: http://developer.android.com/tools/support-library/index.html
[21:55:53] <dbrant>	 yeah, that's all i could find, too
[22:00:08] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[22:02:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[22:04:47] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[22:06:31] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[22:17:28] <wikibugs>	 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#839213 (10Florian) https://www.mediawiki.org/wiki/Help:Page_status_indicators  Do you know the "featured articles" badge/indicator in the top right? It is now added in mediawiki-core, instead of u...
[22:26:31] <grrrit-wm>	 (03PS6) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[22:27:07] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, MobileFrontend-Feature-requests, MediaWiki-Page-editing: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#839241 (10kaldari) @Jaredzimmerman-WMF Works for me. Tested in Mobile Safari on iPhone.
[22:27:13] <grrrit-wm>	 (03PS7) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[22:29:33] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] "It's still not working. I took some screenshots that may help:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson)
[22:29:35] <grrrit-wm>	 (03PS1) 10Jdlrobson: Regression: Restore this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178982 
[22:29:37] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Document issues JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178983 
[22:30:15] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Update `make jsduck` dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178608 
[22:30:24] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178609 
[22:30:34] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/178609/ < someone please help me use git review again!
[22:31:11] <jdlrobson>	 bmansurov: can you replicate that issue without my patch
[22:31:29] <FlorianSW>	 jdlrobson: what you mean? (with git review?)
[22:31:36] <FlorianSW>	 ... what you want to do :)
[22:31:38] <bmansurov>	 jdlrobson: I see
[22:31:41] <jdlrobson>	 FlorianSW: i have done `make installhooks`
[22:31:49] <jdlrobson>	 it checks documentation before i can publish
[22:31:59] <jdlrobson>	 and there are documentation warnings which prevent me doing that
[22:32:19] <FlorianSW>	 ah, ok :)
[22:34:42] <jdlrobson>	 bmansurov: and you are sure it's not caching as i'm testing now and unable to replicate
[22:34:49] <jdlrobson>	 sure you were not testing the older patch?
[22:35:01] <bmansurov>	 jdlrobson: i'll double check
[22:35:08] <jdlrobson>	 bmansurov: thanks
[22:36:26] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Because there will be no new wmf branch before Jan 06, i suggest (if this change get merged), to backport it to at least wmf12 and wmf11 :" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[22:37:26] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, MobileFrontend-Feature-requests, MediaWiki-Page-editing: iOS: Shake to undo on mobile does not undo or redo typing - https://phabricator.wikimedia.org/T67600#839264 (10Jaredzimmerman-WMF) 5Open>3Resolved a:3Jaredzimmerman-WMF Just testing on iphone, and ipad, in VE and WTE,...
[22:37:57] <bmansurov>	 jdlrobson: I've pulled your latest changes and cleared the browser cache, unfortunately I still see the same thing as I described in the patch
[22:38:16] <grrrit-wm>	 (03PS1) 10BearND: Update support libraries to 21.0.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178986 
[22:40:12] <bear_nd>	 dbrant|bbl: https://developer.android.com/tools/revisions/build-tools.html should show the point releases, too, but it doesn't seem updated yet. Also on the alpha build machine (Linux) I haven't been able to install the new version of build-tools yet. This is why I'm currently only updating the support libs
[22:40:49] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178923 (owner: 10Cmcmahon)
[22:42:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: no_javascript view no longer has watchlist or Log inavailable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178923 (owner: 10Cmcmahon)
[22:43:02] <FlorianSW>	 good night all :)
[22:46:50] <jdlrobson>	 bmansurov: and you tried on master too?
[22:46:55] <jdlrobson>	 bmansurov: i think there is something weird with your setup
[22:47:04] <jdlrobson>	 i was able to replicate it but i can't any more with the latest patch
[22:47:22] <jdlrobson>	 chrismcmahon: please let me merge your patches..
[22:47:28] <jdlrobson>	 i've told you about +2ing :P
[22:47:38] <bmansurov>	 jdlrobson: in master 0 doesn't even show up
[22:47:50] <jdlrobson>	 bmansurov: well then it's a feature.. it should show up :P
[22:48:08] <jdlrobson>	 but seriously.. i don't know what's going on but i'm keen to move this patch along
[22:48:24] <jdlrobson>	 can you take a look at your raw watchlist and email me it to localhost:8080/wiki/Special:EditWatchlist/raw
[22:48:41] <bmansurov>	 jdlrobson: ok
[22:50:39] <bmansurov>	 jdlrobson: I'm fine with your patch if it works for someone else too. I can't test it so I'll stop bugging you.
[22:53:20] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178991 
[22:54:30] <grrrit-wm>	 (03PS2) 10Kaldari: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178991 
[22:55:08] <kaldari>	 jdlrobson, bmansurov: Need an emergency review on the following patch before 4pm so I can SWAT: https://gerrit.wikimedia.org/r/#/c/178991/
[22:55:19] <bmansurov>	 kaldari: ok
[22:55:31] <kaldari>	 thanks!
[22:57:45] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178991 (owner: 10Kaldari)
[22:58:36] <kaldari>	 leila: You can test on en.wiki now. For example: https://en.m.wikipedia.org/wiki/Wolf_City?wikigrokversion=B or https://en.m.wikipedia.org/wiki/Wolf_City?wikigrokversion=A
[22:58:52] <kaldari>	 leila: You'll need to delete a cookie after each test though....
[22:59:01] <leila>	 got it. thanks!
[22:59:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178991 (owner: 10Kaldari)
[22:59:35] <kaldari>	 leila: the cookie is enwiki-wikiGrokUserToken
[23:00:23] <kaldari>	 leila: You should be able to test on pretty much any page that is an album, actor, and most that are writers
[23:00:35] <leila>	 yup, kaldari!
[23:00:57] <leila>	 I'll work on it for some time and will update.
[23:01:05] <kaldari>	 leila: Do you know how to run Javascript commands from your browser console?
[23:01:15] <leila>	 walking to your cube. ;-)
[23:05:08] <kaldari>	 leila: You can run mw.config.get( 'wgWikiGrokCampaigns' ); from browser console to see the embedded questions (if you ever need to see all the questions)
[23:05:52] <kaldari>	 mw.config.get( 'wgWikiGrokCampaigns' ); 
[23:08:10] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178998 
[23:12:34] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Don't stop click propagation when clicked on hamburger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178675 (owner: 10Florianschmidtwelzow)
[23:14:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't stop click propagation when clicked on hamburger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178675 (owner: 10Florianschmidtwelzow)
[23:14:07] <bmansurov>	 kaldari: do you need another +2?
[23:14:36] <kaldari>	 bmansurov: no
[23:14:44] <bmansurov>	 ok
[23:17:46] <yurikR>	 dr0ptp4kt, could you take a look, seems like interstitial is showing up wrong
[23:17:51] <yurikR>	 on en.wiki
[23:20:06] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Make uploads page agnostic about current skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178886 (owner: 10Jdlrobson)
[23:21:21] <dr0ptp4kt>	 yurikR: i'm looking
[23:21:24] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179001 
[23:21:29] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178609 (owner: 10Jdlrobson)
[23:22:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Make uploads page agnostic about current skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178886 (owner: 10Jdlrobson)
[23:22:20] <dr0ptp4kt>	 yurikR: by 'interstitial' are you referring to the ooui thing?
[23:23:03] <yurikR>	 dr0ptp4kt, yep
[23:23:50] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: Document issues JavaScript (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178983 (owner: 10Jdlrobson)
[23:24:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178609 (owner: 10Jdlrobson)
[23:26:14] <dr0ptp4kt>	 yurikR: btw, are you seeing any uptick in fatals?
[23:26:45] <yurikR>	 dr0ptp4kt, no, but fatals are unusually silent, hope they still run
[23:30:59] <bmansurov>	 kaldari, jdlrobson: to get page issues working locally, do I need this extension? https://www.mediawiki.org/wiki/Extension:IssueTracker 
[23:31:27] <jdlrobson>	 bmansurov: no
[23:31:30] <jdlrobson>	 bmansurov: just run the browser test
[23:32:02] <bmansurov>	 jdlrobson: ok
[23:32:46] <dr0ptp4kt>	 yurikR: yeah, something's not right there with the interstitial. it's like it's using the old javascript pointed at the old titles. i wonder if we just need to wait for the RL stuff on bits to referesh?
[23:33:23] <yurikR>	 dr0ptp4kt, could be, but how long does it take?
[23:33:24] <dr0ptp4kt>	 yurikR: for example, looking for the string "Do not ask me again" turns up nothing inside ZeroBanner tip of master. and that's because it's a different message now
[23:33:31] <dr0ptp4kt>	 yurikR: i thought it was 5 mins?
[23:33:40] <yurikR>	 it has been > 5 min
[23:33:49] <dr0ptp4kt>	 yurikR: yeah, kaldari agrees 5 mins
[23:34:05] <dr0ptp4kt>	 yurikR: i tried making the page itself be a cachebuster
[23:34:24] <dr0ptp4kt>	 yurikR: no luck with that, though. at least not yet
[23:35:31] <yurikR>	 dr0ptp4kt, i wonder if i need to scap
[23:35:49] <dr0ptp4kt>	 yurikR: for the messages, hmm?
[23:36:03] <dr0ptp4kt>	 yurikR: and i guess whatever else didn't sync.
[23:36:23] <yurikR>	 i think so
[23:36:24] <wikibugs>	 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#839407 (10Krenair) New one (2.0-beta-2014-12-09): https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8013990
[23:37:32] <dr0ptp4kt>	 yurikR: don't know that they are something to worry about with scap, but beware any existing security patches on the servers. don't break those things. just wanted to say that, rather than not
[23:37:49] <yurikR>	 thx dr0ptp4kt :)
[23:38:24] <grrrit-wm>	 (03PS1) 10Jdlrobson: Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 
[23:39:11] <grrrit-wm>	 (03PS1) 10BearND: Hygiene: Removed unused class PopupMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179006 
[23:39:44] <dr0ptp4kt>	 yurikR: i'll be back in 3 mins. lemme know if/when i should recheck on the js
[23:40:00] <dr0ptp4kt>	 yurikR: er, interstitial
[23:45:32] <jdlrobson>	 bmansurov: ok so i can replicate with your watchlist but i think this is a super edge case which only effects people with a page '0' in their watchlist. I'm kind of curious why this is happening so i'll raise a bug, but can you test without that page in your watchlist?
[23:45:58] <bmansurov>	 jdlrobson: ok
[23:46:50] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Regression: Restore this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178982 (owner: 10Jdlrobson)
[23:47:28] <kaldari>	 MaxSem: wmgMFEnableWikiGrok to true for enwiki in InitializeSetting
[23:48:17] <grrrit-wm>	 (03PS3) 10Mhurd: Re-added Wikidata descriptions to search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178890 
[23:48:29] <grrrit-wm>	 (03PS2) 10Mhurd: Re-added Wikidata descriptions to Nearby results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178900 
[23:48:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: Restore this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178982 (owner: 10Jdlrobson)
[23:49:57] <bmansurov>	 jdlrobson: now i cannot unwatch 0 because the page doesn't exist ;) i'll add some content but I think it maybe another bug
[23:50:37] <grrrit-wm>	 (03PS1) 10Kaldari: Promoting WikiGrok to stable and disabling for anons (with flag) [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179009 
[23:51:14] <bmansurov>	 jdlrobson: how can I remove a page?
[23:53:05] <kaldari>	 bmansurov: what do you mean by remove?
[23:53:25] <leila>	 kaldari, here is the list of items that have writer but not author: http://wdq.wmflabs.org/api?q=claim[31%3A5]%20AND%20claim[106%3A36180]%20AND%20noclaim[106%3A482980]
[23:53:29] <yurikR>	 dr0ptp4kt, seems like scap has fixed it
[23:53:33] <yurikR>	 its not fully done
[23:53:41] <dr0ptp4kt>	 yurikR: phew
[23:53:45] <bmansurov>	 kaldari: I have created a page with the title '0', but I want to remove that page, so the next time I visit that page it should say 'page doesn't exist'
[23:54:20] <yurikR>	 dr0ptp4kt, and just to make it even more fun: the warning shows "<zero-interstitial-title>" in the title :)
[23:54:51] <kaldari>	 bmansurov: If you are an administrator on your wiki and you switch to desktop view, you can go up to the more menu and select delete.
[23:55:03] <bmansurov>	 kaldari: thanks
[23:55:17] <wikibugs>	 3Wikipedia-App-Android-App: IllegalStateException: Can not perform this action after onSaveInstanceState - https://phabricator.wikimedia.org/T75237#839469 (10bearND) 5stalled>3Open
[23:56:15] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179001 (owner: 10Kaldari)
[23:56:29] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178998 (owner: 10Kaldari)
[23:57:07] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Promoting WikiGrok to stable and disabling for anons (with flag) [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179009 (owner: 10Kaldari)
[23:57:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179001 (owner: 10Kaldari)
[23:59:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing query string override for loading WikiGrok on en.wiki [extensions/MobileFrontend] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178998 (owner: 10Kaldari)