[00:02:45] yurikR: hmm, seems to be behaving the same way as before, with not the correct verbiage, and that dialog title like you say. [00:04:53] bmansurov: just remove it from the raw wtchlist.. [00:05:06] ok [00:05:25] bmansurov: so it seems 0 is not on your watchlust [00:05:28] yet it renders [00:05:30] this is really odd [00:05:44] (03CR) 10MaxSem: [V: 032] Promoting WikiGrok to stable and disabling for anons (with flag) [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179009 (owner: 10Kaldari) [00:12:03] jdlrobson, nice Freudian typo, watchlust :P [00:13:24] the_nobodies: ") [00:18:40] bmansurov: got it [00:18:45] php really is ugly. [00:18:54] boo ugly php [00:19:03] (03PS6) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 [00:21:47] (03PS2) 10Jdlrobson: Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 [00:23:31] 3MediaWiki-ResourceLoader, MobileFrontend-alpha: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#839579 (10Jdlrobson) 3NEW [00:23:47] ^ bmansurov that should work for oyu [00:24:50] kaldari, when I say "No, thanks" in version A, if I refresh the page (and not delete cookies), it will show the question to me again. Is this intended? [00:25:08] jdlrobson: so the '0' is gone, but no matter how many times i click 'more', even after clearing the cache [00:29:08] (03Abandoned) 10Jdlrobson: Hygiene: Update pngs via `grunt build-icon` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178607 (owner: 10Jdlrobson) [00:29:34] (03Abandoned) 10Jdlrobson: WIP: Experiment with populating the icon library from Wikifont [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169642 (owner: 10Jdlrobson) [00:30:51] (03CR) 10Jdlrobson: [C: 032] EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [00:37:24] kaldari, can you submit responses for Album? I'm testing Actors to make sure we [00:37:32] we're capturing the data correctly [00:37:47] sure... [00:37:50] thanks! [00:41:45] (03Merged) 10jenkins-bot: EventLogging: break up MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov) [00:41:50] leila: should be some album answers in there now [00:43:01] kaldari, the responses are 0 or 1, mostly 1. I'm not sure if they're captured correctly. digging deeper. [00:43:34] leila: on the version A questions I answered 1 for studio album and 0 for live album [00:48:16] (03PS1) 10Jdlrobson: Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179031 [00:48:18] (03PS1) 10Jdlrobson: Documentation for SearchApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 [00:56:53] Deskana: hey can u check if search still works on android - max said there was a api change… seems ok on ios... [00:57:11] (03CR) 10Bmansurov: [C: 032] Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179031 (owner: 10Jdlrobson) [00:57:48] mhurd: works for me [00:58:33] (03Merged) 10jenkins-bot: Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179031 (owner: 10Jdlrobson) [00:59:06] (03PS1) 10Jdlrobson: Regression: Fix search in language overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 [00:59:14] bear_nd: cool thanks! max said it was limited to search and “id” became “pageid” apparently [01:00:31] (03CR) 10Bmansurov: [C: 04-1] Documentation for SearchApi (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 (owner: 10Jdlrobson) [01:03:56] (03CR) 10Bmansurov: [C: 04-1] Regression: Fix search in language overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:04:46] ergg how did the documentation get in the LD fix [01:04:47] fs [01:06:20] 3Wikipedia-App-Android-App: NoClassDefFoundError: android.support.v7.internal.view.menu.MenuBuilder - https://phabricator.wikimedia.org/T78197#839799 (10Dbrant) Some resources that may help: https://code.google.com/p/android/issues/detail?id=78377 http://stackoverflow.com/questions/24809580/noclassdeffounderror-... [01:06:52] (03PS2) 10Jdlrobson: Regression: Fix search in language overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 [01:09:48] bear_nd: i noticed GalleryItemFetchTask.java is requesting a 2048 thumbnail. max says we should choose a width from the “widthBuckets” array here: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMultimediaViewer.git/f9e7bae91a8032fa13fc68114a0d57d190ea77f9/resources%2Fmmv%2Fmmv.ThumbnailWidthCalculator.js [01:10:35] bear_nd: should be one of these widths for caching reasons: 320, 640, 800, 1024, 1280, 1920, 2560, 2880 [01:14:02] bear_nd: for what it’s worth, i also noticed that sometimes the image url it gives you points to an image that can be *almost* the width you request, but not the exact width. For instance, I used this to get the thumb url to a 640px wide image https://en.wikipedia.org/w/api.php?action=query&prop=imageinfo&format=jsonfm&iiprop=url%7Cdimensions%7Cmime%7Cextmetadata&iiurlwidth=320&titles=File%3AHomer%20British%20Museum.jpg but the url poi [01:14:02] is actually 635px wide https://upload.wikimedia.org/wikipedia/commons/1/1c/Homer_British_Museum.jpg [01:16:53] (03PS1) 10Jdlrobson: Documentation and QUnit coverage for LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179038 [01:17:26] mhurd: can you send email to dbrant about the buckets? He implemented the image viewer on Android. He's probably not on IRC right now [01:17:35] mhurd: leaving in 10 [01:17:51] bear_nd: sure! [01:18:00] (03PS2) 10Jdlrobson: Documentation for SearchApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 [01:18:48] (03CR) 10jenkins-bot: [V: 04-1] Documentation and QUnit coverage for LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179038 (owner: 10Jdlrobson) [01:19:34] (03CR) 10Jdlrobson: Hygiene: Document issues JavaScript (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178983 (owner: 10Jdlrobson) [01:19:44] (03PS2) 10Jdlrobson: Hygiene: Document issues JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178983 [01:20:10] (03CR) 10Jdlrobson: "Test will pass when https://gerrit.wikimedia.org/r/179033 gets merged" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179038 (owner: 10Jdlrobson) [01:20:27] (03CR) 10Jdlrobson: "Reviewer see https://gerrit.wikimedia.org/r/#/c/179038/ after you +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:22:39] (03CR) 10Bmansurov: [C: 04-1] Regression: Fix search in language overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:23:34] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#839919 (10Jdlrobson) I'm still seeing ugly templates in mobile view on English Wikipedia - $( '.top-icon' ).length > 0 Am I misunderstanding how they work? [01:24:47] bearND: email sent :) gonna run - have a good night! [01:29:20] (03PS3) 10Jdlrobson: Regression: Fix search in language overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 [01:29:22] (03CR) 10Jdlrobson: Regression: Fix search in language overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:31:50] (03CR) 10Bmansurov: [C: 032] Hygiene: Document issues JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178983 (owner: 10Jdlrobson) [01:31:57] (03CR) 10Dbrant: [C: 032] "This is ok, but these patches are still not "satisfying" in the sense that we don't know the root cause of why createOptionsMenu is being " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178901 (owner: 10BearND) [01:32:36] (03CR) 10Dbrant: [C: 032] Update support libraries to 21.0.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178986 (owner: 10BearND) [01:33:00] (03CR) 10Dbrant: [C: 032] Hygiene: Removed unused class PopupMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179006 (owner: 10BearND) [01:33:16] (03Merged) 10jenkins-bot: Hygiene: Document issues JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178983 (owner: 10Jdlrobson) [01:34:24] (03CR) 10Bmansurov: Regression: Fix search in language overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:35:26] (03CR) 10Bmansurov: Regression: Fix search in language overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:35:58] bmansurov: i dont understand why you are blocking this fix on an existing problem.. [01:36:05] The spans are in languages [01:36:08] i don't think variants filter [01:36:11] not sure if they ever did [01:36:27] {{langname}}{{#title}} | {{title}}{{/title}} [01:36:36] jdlrobson: It's just the patch doesn't fix the issue, maybe I misunderstood it [01:36:45] try a page without variants [01:36:53] also see the qunit test i posted that is currently failing [01:37:19] jdlrobson: what's a page without variants? [01:37:36] language variant [01:37:49] ok [01:38:08] (03PS1) 10Dbrant: Hygiene: delete unused dialog xml files. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179041 [01:39:14] bmansurov: https://gerrit.wikimedia.org/r/#/c/179038/ explains the problem [01:39:23] a LanguageOverlay can have languages or variants [01:39:41] i don't know why variants don't get searched as there was no tests to show whether they should or not [01:39:59] jdlrobson: ok I thought variants were also part of the list, my bad [01:40:13] bmansurov: would be good to capture that in a task [01:40:28] bmansurov: if you can merge it i can merge your last modified bar [01:40:41] i was waiting for those patches to get merged since they might need a LD and didn't want the branch to change too much [01:41:02] (03CR) 10Bmansurov: [C: 032] Regression: Fix search in language overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:42:27] (03Merged) 10jenkins-bot: Regression: Fix search in language overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179033 (owner: 10Jdlrobson) [01:49:12] (03PS4) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 [01:49:33] (03CR) 10Kaldari: [C: 04-1] "Requires further dicussion" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari) [01:51:49] (03CR) 10Bmansurov: [C: 032] Documentation and QUnit coverage for LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179038 (owner: 10Jdlrobson) [01:53:48] (03Merged) 10jenkins-bot: Documentation and QUnit coverage for LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179038 (owner: 10Jdlrobson) [01:53:53] (03PS7) 10Jdlrobson: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [01:54:17] ^ bmansurov i made some tweaks avoid using $data where possible [01:54:25] jdlrobson: thanks [01:54:26] it's really a horrible thing that should be destroyed [01:54:48] (03CR) 10Jdlrobson: [C: 031] "I made a few tweaks to Baha's patch so someone will need to sanity check me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [01:59:40] (03CR) 10Bmansurov: Documentation for SearchApi (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 (owner: 10Jdlrobson) [02:03:18] (03PS1) 10Dbrant: Adjust image size to fetch for gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179047 [05:33:59] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#840510 (10Florian) The templates must be changed by the community to remove the ugly css solutions and replace it with the new indicator tag :) [05:41:59] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#840513 (10Jdlrobson) Is there a tracking bug for that? Seems like a blocker from our perspective... [06:44:52] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#840565 (10Florian) > Is there a tracking bug for that? Not that i know any. There is already a discussion for the Top_icon template on enwiki: https://en.wikipedia.org/wiki/Template_talk:Top_icon#... [06:58:51] 3Wikipedia-App-Android-App: too hard to click links near left edge of screen - https://phabricator.wikimedia.org/T78240#840583 (10jeremyb-phone) 3NEW [07:10:55] 3Wikipedia-App-Android-App: find in page nearly unusable in landscape orientation - https://phabricator.wikimedia.org/T78244#840625 (10jeremyb-phone) 3NEW [07:50:40] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Just two little things :)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [10:48:21] morning joakino_ [11:01:21] hi phuedx [11:03:06] phuedx: 45 emails... jesus [11:03:12] lol [11:03:14] phuedx: i've got to figure some filters out [11:03:19] i was about to say [11:25:42] joakino_: phuedx phabricator? :) [11:25:48] you can go to settings there and turn it off there [11:26:10] but that'd fix the problem [11:26:15] i want to moan a bit more [11:26:33] hehe :D [11:27:14] phuedx: fwiw, chad turned on a config setting to *not* send notifications for past commits, which phab then proceeded to ignore [11:27:22] lol [11:30:47] YuviPanda: i didn't get almost anything from diffusion, i'm pretty new [11:31:21] YuviPanda: phuedx for me it is mostly the mailing lists [11:31:31] YuviPanda: which ones? [11:31:39] i've actually unsubscribed from quite a few recently [11:31:51] because i found myself just archiving everything [11:31:52] phuedx: I just turned off everything in ‘auditor' [11:32:24] phuedx: mobile-tech and all are specially noisy right now [11:32:33] ok [11:32:36] well that's relevant ;) [11:32:43] i know haha [11:32:58] i also subscribe to elixir-lang and rust-lang, which adds to noise [11:34:06] phuedx: yeah on my personal i'm on clojure, clojurescript and a few more, but i've set it up to send me at most a daily mail with all combined [11:34:25] can we do that with wmf lists? [11:34:50] joakino_: yup [11:34:52] you can [11:35:11] YuviPanda: have a link? [11:35:14] all hail mailman, almost ok as long as you don’t try to read archives or actually be an administrator... [11:35:45] joakino_: go to https://lists.wikimedia.org/mailman/listinfo, find your list, ‘change settings’ with your password [11:35:55] and if you don’t know your password you can ask it to send it to you as well [11:36:14] phuedx: dang, I just realized I’m not on any non-wmf lists :| [11:36:22] * YuviPanda has been here too long [11:36:34] * YuviPanda goes off to subscribe to some noisy lists to fix that [11:36:43] haha [11:36:52] thanks YuviPanda [11:37:03] haha [11:37:15] elixir-lang is ~14 emails a week [11:37:18] which is perfect [11:37:24] hmm, that’s not bad [11:37:34] * YuviPanda used to be on the GNOME lists, and unsubscribed a while ago [11:37:35] i haven't actually written any elixir in a while [11:37:43] so sometimes i feel like a fraud [11:38:01] xD [11:38:06] phuedx: ’s ok, I’m on wikitech and haven’t written any MW in a while... [11:38:49] lol [11:39:05] don't you just twiddle your thumbs all day YuviPanda [11:39:05] ? [11:39:10] spin around on yer chair [11:39:29] phuedx: and if you think *that* is spammy, I’m on root@ (gets about… 2000 emails a day?), and also the shinken notify list, which when there’s a puppet storm about… 600 emails. [11:39:48] phuedx: no, I spend all that time clicking the emails to root@ and hitting ‘delete' [11:40:24] haha [11:40:35] YuviPanda: filters are you friends? [11:40:49] joakino_: shush, then I’ll have to actually work! [11:41:10] "today i spent most of the day creating email filters" [11:41:28] * joakino_ says phuedx at standup tomorrow [11:41:34] * joakino_ nods [11:41:39] i'm the master of email filters [11:41:42] (i'm not) [11:41:51] my personal account is pretty neat [11:41:56] personal accounts* [11:42:03] but my wmf is a nightmarish hellhole [11:42:25] i've set them up and cleaned inbox, so i feel good, but then i have to go through labels and actually have a look, so ... idk [11:42:32] heh [11:42:45] all the WMF email (except root@, shinken, and ops@) go to my ‘personal’ inbox [11:47:00] YuviPanda: why? [11:47:20] joakino_: I was a volunteer and so had subscribed to ‘em for almost a year before I joined the WMF... [11:47:23] and too lazy to change. [11:47:30] cool [11:47:34] that’s also why my gerrit login is @gmail as well [11:50:16] joakino_: possible gmail extension: show the date you last looked at the label [11:50:22] if it's more than a year just hide the damn thing [11:51:04] phuedx: that would be cool [11:51:37] phuedx: what i really want is to create and modify filters in android, the only way right now is to install google inbox [11:52:02] phuedx: i don't understand if google inbox let's you create and modify filters, why the gmail app doesnt [11:52:12] lazy google [11:54:34] no [11:54:37] not lazy google [11:54:41] very deliberate google [11:54:46] never, /ever/ lazy [11:54:47] EVER [11:55:42] also, the inbox site scrolljacks [11:55:45] screw 'em [12:02:05] (03CR) 10Phuedx: [C: 032] Fix the preview header when switching from VE to wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178680 (owner: 10Jdlrobson) [12:04:10] (03Merged) 10jenkins-bot: Fix the preview header when switching from VE to wikitext [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178680 (owner: 10Jdlrobson) [12:04:26] phuedx: i've just used the mobile app, pretty cool, but not that useful for experienced gmailers [12:04:52] phuedx: I guess the LD email is still not sorted out [12:05:00] from your answer? [12:15:09] i have no idea, no one had responded to it [12:15:42] joakino_: rather than ask me here, where people might not be able to see, why not ask on the list? ;) [12:18:07] phuedx: will do! [12:18:39] phuedx: is there any criteria we usually consider when thinking about LDs? [12:43:04] joakino_: that i'm not sure about [12:43:14] i'd say major regressions should be [12:43:27] otherwise, 1 week ain't a long time [13:09:17] phuedx: joakino_ LDs are dead, long live SWAT? [13:22:52] YuviPanda: LONG LIVE THE SWAT [13:23:09] SO SAY WE ALL [15:11:05] (03PS2) 10Phuedx: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 [15:12:40] (03CR) 10jenkins-bot: [V: 04-1] Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [15:14:15] (03PS1) 10Dbrant: Fix possible crash when fetching random page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 [15:16:18] (03PS3) 10Phuedx: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 [15:55:37] (03CR) 10Florianschmidtwelzow: "See also: Iaa4cc13edda213b3b17a8fd9912a23fc0658a6e9" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [16:11:16] (03PS2) 10Dbrant: Fix possible crash(es) related to fragment manager state loss. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 [16:40:13] (03CR) 10Jhernandez: [C: 031] "+1ing to let other members see this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178608 (owner: 10Jdlrobson) [17:13:39] super storm! [17:15:53] (03CR) 10Jdlrobson: Don't bypass blocked user check in editor (anonymous editing) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [17:16:17] (03PS3) 10Jdlrobson: Documentation for SearchApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 [17:17:20] (03PS4) 10Jdlrobson: Documentation for SearchApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 [17:18:59] jdlrobson: what's going on over there [17:19:04] also hi! [17:19:13] joakino: it started raining at 10pm and hasn't stopped [17:19:17] most rain i've ever seen here [17:19:22] and my power has gone [17:19:34] it might be the fuse book but i don't want to go outside and brave the rain [17:19:48] and being around fuse boxes during a big storm seems a bad idea [17:19:56] indeed [17:20:04] are you working from home? [17:20:05] i'm hoping the handyman comes (he was supposed to arrive at 9pm) to do some work on my ceiling [17:20:22] then i can just play dumb and defer to him and he can fix it ;-) [17:20:25] still with the hole in the ceiling? haha [17:20:28] but i somehow don't think he will turn up [17:20:38] despite me telling him are you sure you dont want to do it friday [17:20:40] cos of storms etc [17:20:43] people are weird [17:20:52] hugggeee holes in my ceiling [17:20:57] ceiling cat is up there i am sure [17:21:05] lol it's being 2 months already [17:21:20] * been [17:21:41] joakino: exactly! [17:21:43] it's ridiculous [17:21:48] i had to ring them twice to get to this point [17:22:03] i expected to come back from china and it would all be fixed but nooooo they're hopeless [17:23:30] annoying [17:24:02] btw, jdlrobson what's up with those extends L154 https://gerrit.wikimedia.org/r/#/c/178679/2/javascripts/modules/editor/VisualEditorOverlay.js [17:24:17] why are you overriding the view options with the defaults? [17:24:34] joakino: so yeh this code is all very strange [17:24:42] so when Juliusz wrote the extend method [17:25:20] he added some support for extending defaults, so a child would inherit parent defaults and anything it added [17:25:49] but it's a bit odd and i wonder if we should remove it - as if you have A->B->C inheritance, C does not always inherit A's defaults [17:25:56] i think it happens if you don't override initialize [17:26:25] anyway essentially i don't want to override them but extend them [17:26:31] i thought making this explict would be better no? [17:26:48] ohh wait you are talking about wOptions = $ ? [17:26:56] ye! [17:27:06] yeh this was messy i wasn't sure how to do it [17:27:22] but basically in VisualEditor.initialize is sets previewingMsg and editingMessage [17:27:28] let me restart it to see if it comes back [17:27:32] whoops, wrong channel. sorry [17:28:04] YuviPanda: thats some itcrowd shit right there xD [17:28:04] actually i don't think i need this any more lol [17:28:16] jdlrobson: i'm confused xD [17:28:20] such a big patch [17:28:28] joakino: originally editor overlay was only setting a value if it wasn't defined [17:28:40] and visual editor was defining it [17:28:41] so it was a bit odd [17:29:05] joakino: heh, that’s what I do all day :) along with archiving email, of course ;) [17:29:40] jdlrobson: so do i wait for another patchset? [17:30:01] jdlrobson: well will continue to review but not comment on that [17:30:05] joakino: yeh one second [17:30:12] joakino: will check if those lines are needed any more [17:30:24] jdlrobson: 👍🙈 [17:30:30] joakino: but yeh the templates code was confusing the hell out of me [17:30:33] that .previewingMsg patch was hella odd [17:30:42] phuedx: which bit about it ? :) [17:31:09] the bit where it broke something else for, afaict, no reason at all [17:31:18] phuedx: there was a reason :) [17:31:31] don't tell me, i don't want to know [17:31:35] basically EditorOverlay creates a VisualEditorOverlay with its own options [17:31:46] if i know then i might be called on to fix it [17:31:48] and VisualEditorOverlay was only setting preview message if it wasn't defined for some reason [17:31:52] LALALALALALALALLALALALLALALLALALALA [17:31:55] lolz [17:31:59] so funny [17:32:06] phuedx: did you see ResourceLoaderImage module landed? [17:32:20] no sir!? [17:32:56] joakino: mmm so that options voodo is needed apparently. [17:32:57] sigh [17:33:05] phuedx: yeh check my patch out in MobileFrontend that uses it [17:33:09] well kick starts using it [17:33:25] jdlrobson: but it wasn't done before? why is it needed now? [17:33:42] jdlrobson: link or add me to the reviewers or it didn't happen [17:33:51] joakino: oh yeh i remember now [17:33:56] lol [17:33:58] the toolbar value needs to be set in initialize [17:34:10] EditorOverlay defines hasToolbar: false [17:34:23] so if you create a VisualEditorOverlay using the options of EditorOverlay this gets set there. [17:34:28] Let me move it to VisualEditorOverlay :) [17:35:14] (03CR) 10Florianschmidtwelzow: [C: 031] Don't bypass blocked user check in editor (anonymous editing) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [17:36:08] (03PS3) 10Jdlrobson: Hygiene: Refactor EditorOverlay's templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178679 [17:36:10] jdlrobson: cant we just do $.extend({}, options, { hasToolbar: true }) so we don't override other potential options to default behavior? [17:36:11] ^ joakino that oughta do it [17:36:20] joakino: yeh i made it more explicit [17:36:28] lets see [17:37:52] joakino: ahrrghh still issues [17:37:53] one sec [17:38:10] jdlrobson: ye the options object is passed by reference everywhere [17:40:15] joakino: argg this is messy [17:42:21] jdlrobson: it looks good, just the options thing is confusing [17:42:48] we are passing around an object by reference to several views which modify it, so it is bound to have problems [17:42:53] mutability is shit [17:43:16] joakino: fix on way [17:43:28] but yeh only a short term fix [17:43:35] jdlrobson: haha 😁 [17:43:36] we need to find a better way of doing this [17:45:00] jdlrobson: exactly what, switching the views? [17:45:08] (03PS4) 10Jdlrobson: Hygiene: Refactor EditorOverlay's templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178679 [17:45:10] joakino: how we use options [17:45:18] ^ joakino anyway this fixes in short term [17:45:25] hopefully more explicit [17:45:52] phuedx: https://gerrit.wikimedia.org/r/#/c/179005/ [17:46:02] jdlrobson: 👍 [17:46:35] 3MobileFrontend-alpha, Mobile-Web: Blocked, not logged in user can access the editor (but not save) - https://phabricator.wikimedia.org/T78315#842162 (10Florian) 3NEW a:3Florian [17:46:55] (03PS3) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [17:47:30] mm only 210 code style errors found for documentation! [17:47:34] getting there slowly ;-) [17:49:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Doesn't work, there is a minor change needed :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [17:52:20] (03PS4) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [17:53:46] (03CR) 10jenkins-bot: [V: 04-1] Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [17:54:49] (03CR) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [17:55:11] (03PS5) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [17:56:34] (03CR) 10Florianschmidtwelzow: [C: 04-1] "damn..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [17:57:54] (03PS1) 10Jdlrobson: Hygiene: Document EditorOverlay and EditorOverlayBase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179160 [17:59:11] (03PS6) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [18:04:06] gonna give george a bath and get him to bed [18:09:19] (03CR) 10Bmansurov: Alpha: move lastmodified to bottom of article (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [18:10:00] FlorianSW: hi, I've left comments on your comments ^ ;) [18:10:16] (03PS1) 10Jdlrobson: Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 [18:10:24] ok i'm gonna brave this storm. brb wish me luck ;-) [18:11:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [18:12:34] (03CR) 10Bmansurov: [C: 032] Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [18:14:10] (03CR) 10Florianschmidtwelzow: Alpha: move lastmodified to bottom of article (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [18:14:27] bmansurov: commented on your comments on my comments :D ^ [18:14:35] thanks [18:20:08] FlorianSW: so a better place is $wgMinervaStyleModules at the top of the file? [18:20:51] bmansurov: e.g. :) [18:21:35] FlorianSW: after the 'skins.minerva.icons.styles' module for example [18:22:01] bmansurov: yes, and a much better name, maybe skins.minerva.alpha.styles or something else [18:22:10] FlorianSW: ok [18:23:52] 3Wikipedia-App-Android-App: App unexpectedly closes on Samsung Galaxy Ace II X (S7560M) - https://phabricator.wikimedia.org/T76279#842278 (10bearND) Might be related to T78197 [18:25:15] (03PS8) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 [18:27:15] (03CR) 10Bmansurov: [C: 032] Documentation for SearchApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 (owner: 10Jdlrobson) [18:27:25] (03CR) 10jenkins-bot: [V: 04-1] Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [18:28:56] (03Merged) 10jenkins-bot: Documentation for SearchApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179032 (owner: 10Jdlrobson) [18:31:48] (03PS9) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 [18:51:29] (03CR) 10Bmansurov: [C: 04-1] Minerva friendly version of Special:Preferences (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [18:54:18] (03CR) 10BearND: [C: 032] Hygiene: delete unused dialog xml files. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179041 (owner: 10Dbrant) [18:56:21] (03Merged) 10jenkins-bot: Hygiene: delete unused dialog xml files. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179041 (owner: 10Dbrant) [18:57:24] (03CR) 10BearND: [C: 04-1] "It's an improvement but couldn't we request smaller sizes for smaller devices?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179047 (owner: 10Dbrant) [18:59:32] kaldari: yt? [19:00:02] Leila and I are reviewing the test2 data QA, any chance you could hop on a hangout? [19:00:17] (03CR) 10Dbrant: "...but since we're allowing pinch-to-zoom, don't we want to load the best possible resolution, so that the user would be able to zoom in o" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179047 (owner: 10Dbrant) [19:01:38] Deskana can you guys hear me? [19:01:41] or see me? [19:02:22] I keep getting netwrok error :-( [19:02:47] kristenlans: Nope, you keep dropping in and out. [19:03:32] phuedx: are you taking a look at the seach bug? [19:03:49] Deskana: are you guys in the office and is kaldari around? [19:04:02] DarTar: I'm in the office, but in a meeting. [19:04:07] https://etherpad.wikimedia.org/p/MobileAppRetrospective [19:04:14] DarTar: I can check when I'm out at 12. [19:05:52] how can i tell if i have my block has an outage or my building is screwed? [19:05:59] the cafe on the next block is fine so i'm confused [19:08:30] (03CR) 10Jhernandez: [C: 032] "nice" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178679 (owner: 10Jdlrobson) [19:09:43] i'm out for today! [19:09:50] joakino: see you dude! :D [19:09:53] bb people! [19:09:55] (03Merged) 10jenkins-bot: Hygiene: Refactor EditorOverlay's templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178679 (owner: 10Jdlrobson) [19:09:59] jdlrobson: take care [19:10:09] joakino: can't work out my fuse boxes :-S [19:10:25] jdlrobson: ask your neighbour [19:10:32] no one's in bmansurov [19:10:39] the light in the hall is gone so i think it's the house [19:10:43] but have no idea how to switch it back on [19:10:50] my fuse box looked fine [19:11:00] no super in the building? [19:11:11] that's what i;m trying to work out [19:11:17] good luck [19:11:19] we have these old fuse boxes that i don't understand [19:11:52] I think it's best if you didn't touch them ;) [19:13:05] (03CR) 10BearND: "I'd like to point out that this should be done as a last resort." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 (owner: 10Dbrant) [19:14:05] (03CR) 10BearND: [C: 032] "ok" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179047 (owner: 10Dbrant) [19:14:26] kaldari, are you around? [19:14:46] (03Merged) 10jenkins-bot: Adjust image size to fetch for gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179047 (owner: 10Dbrant) [19:15:43] (03PS1) 10BearND: Enable basic ProGuard minification [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179174 [19:16:04] leila, DarTar: heading down to three now. Will let me know you are loooking for him if he is around [19:16:04] (03CR) 10Dbrant: "The language change follows the same mechanism, and can lead to the same kind of condition. Actually, I think this report proves it:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 (owner: 10Dbrant) [19:16:16] *will let him know... [19:16:20] thanks rfarrand. appreciate it. :-) [19:18:37] (03CR) 10Bmansurov: [C: 032] Hygiene: Document EditorOverlay and EditorOverlayBase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179160 (owner: 10Jdlrobson) [19:19:43] MaxSem: hi :) Short question: "position = top" is it irrelevant for module styles (loaded with OutputPage::addModuleStyles())? Because it is loaded via a link element [19:20:27] leila: no here [19:20:30] not** [19:20:33] can't type today! [19:20:40] rfarrand, thanks for checking. [19:20:54] (03Merged) 10jenkins-bot: Hygiene: Document EditorOverlay and EditorOverlayBase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179160 (owner: 10Jdlrobson) [19:21:17] FlorianSW: correct [19:21:25] thedj: thanks :) [19:21:53] basically, addModuleStyles makes sure that with the stylesheet is put in the head of the page, instead of being JS loaded [19:22:39] 3MobileFrontend-Feature-requests: Mobile website should display super-categories on categories on Wikimedia Commons - https://phabricator.wikimedia.org/T78175#842423 (10Jdlrobson) [19:22:43] thedj yeah, that i know :) but i was unsure, if the position key does anything then :) thanks for clarify [19:22:56] as far as i know, it does nothing in that situation. [19:22:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] "one little thing :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [19:23:21] FlorianSW, yes, basically: addModuleStyles overrides position [19:23:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [19:23:32] thedj, MaxSem: great, thanks for quick reply :) [19:23:39] 3MobileFrontend-Feature-requests, Collaboration-Team, MediaWiki-extensions-Thanks: Thank notification on mobile should support click to undo - https://phabricator.wikimedia.org/T63737#842435 (10Jdlrobson) [19:23:42] (03PS1) 10Kaldari: Fix EventLogging of responses when correct is null [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179176 [19:24:02] (03PS10) 10Bmansurov: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 [19:24:38] 3MobileFrontend-Feature-requests: [Contributions] Allow people to submit coordinates for articles that don't have them - https://phabricator.wikimedia.org/T44786#842438 (10Jdlrobson) Coordinates should probably be submitted to wikidata. Not sure if we want to explore this at all in mobile. [19:25:16] MaxSem: https://gerrit.wikimedia.org/r/#/c/179176/ [19:25:33] (03CR) 10Florianschmidtwelzow: [C: 031] Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [19:26:09] (03CR) 10MaxSem: [C: 032] Fix EventLogging of responses when correct is null [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179176 (owner: 10Kaldari) [19:26:29] (03Merged) 10jenkins-bot: Fix EventLogging of responses when correct is null [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179176 (owner: 10Kaldari) [19:27:09] 3MobileFrontend-Feature-requests: create a book should be possible from mobile - https://phabricator.wikimedia.org/T62249#842448 (10Jdlrobson) Not sure what actions there are here. We could potentially add a link to the bottom of the page in alpha as a starting point to explore interest but before that can happe... [19:28:13] jdlrobson: sorry for the late response [19:28:21] i was trying to figure out a way around it and coulnd't [19:28:27] *couldn't [19:28:33] if you want to kill the bug, go for it :) [19:29:07] (03CR) 10Bmansurov: "The More link keeps loading the first page only. Can someone else confirm? Apparently it's working for Jon. @phuedx, @joakino?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [19:30:31] phuedx: i'm occupied with another card [19:30:41] phuedx: i'm keen to kill this watchlist bug though - would appreciate a look [19:30:56] also on 12% battery so need to seriously think about getting into office or finding a way to fix the power here [19:31:17] brb [19:33:37] 3Wikipedia-App-MobileApp-extension: Last modified articles in the xatxh list in the mobile version - https://phabricator.wikimedia.org/T78320#842467 (10Hunsu) 3NEW [19:34:42] (03CR) 10Bmansurov: [C: 032] "Thanks, @jhernandez for mentioning it. I think it's safe to change the MW_INSTALL_PATH to '../..' in the makefile in another patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178608 (owner: 10Jdlrobson) [19:35:01] kaldari, DarTar, frozen while deleting cache [19:35:03] brb [19:35:47] 3Wikipedia-App-MobileApp-extension: Last modified articles in the xatxh list in the mobile version - https://phabricator.wikimedia.org/T78320#842479 (10Hunsu) [19:36:09] (03Merged) 10jenkins-bot: Hygiene: Update `make jsduck` dependencies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178608 (owner: 10Jdlrobson) [19:36:22] (03PS2) 10Bmansurov: Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [19:36:26] I can type here kaldari. basically for page_id 5879584 we sometimes log events in MobileWebWikiGrok_10352247 and sometimes don't. This is from Chrome/Linux [19:36:34] 3Wikipedia-App-MobileApp-extension: Wrong informations in the watch list of the mobile version - https://phabricator.wikimedia.org/T78320#842480 (10Hunsu) [19:37:47] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [19:39:43] (03PS3) 10Bmansurov: Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [19:40:25] (03CR) 10Bmansurov: [C: 032] "jdlrobson, fixed a typo. looks great." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [19:42:01] (03Merged) 10jenkins-bot: Hygiene: Some upload documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179161 (owner: 10Jdlrobson) [20:27:23] braving the storm for provisions [20:27:26] :) [20:27:39] leila: my Firefox crashed :( [20:27:53] np. we'll wait for you [20:28:32] leila: can you reinvite me? [20:28:41] yes, kaldari [20:29:02] I just did, are you back? [20:38:39] dbrant, bearND|food: This is a bit concerning: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8015934 [20:39:29] (anonymous editing while app thinks you're logged in. logging out and back in again 'solved' it for this user) [20:41:58] (03PS4) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [20:42:02] (03CR) 10Jdlrobson: Minerva friendly version of Special:Preferences (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [20:43:27] (03CR) 10jenkins-bot: [V: 04-1] Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [20:45:18] (03PS5) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [20:45:29] (03PS7) 10Jdlrobson: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [20:46:38] Krenair: we have a trello card for that... still needs investigating. [20:46:53] I thought I'd seen this mentioned before somewhere [20:46:54] (03CR) 10jenkins-bot: [V: 04-1] Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [20:46:59] (03CR) 10Bmansurov: Minerva friendly version of Special:Preferences (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [20:48:53] bmansurov: yeh you are right. i just didn't understand what you meant. No idea why Jenkins is complaining though.. maybe that's why [20:49:19] jdlrobson: probably [20:56:28] jhobs: yurikR: the Portal-1, GraphData2, Debug stuff looks okay. one thing i was wondering: can p.live(frame) live somewhere else outside of Debug so to not give the impression it's a debugging aid only? [20:56:43] jhobs: yurikR: i gotta go on a call soon, just so you know [20:56:51] AM I here? [20:57:19] dr0ptp4kt, i was thinking about it, but really its a shim for calling built-in functions [20:57:44] kristenlans: you are here. [20:57:51] dr0ptp4kt, and i wouldn't want to split it up between multiple modules [20:57:59] because they must have identical functions [20:58:15] kristenlans, yes, you appear to be:P [20:58:25] kristenlans, no, you are not [20:58:27] Thanks MaxSem :D [20:58:44] i looked everywhere [20:58:45] yurikR: :P [20:58:48] you are somewhere else [20:59:07] yurikR: ok. thought for less split brain you might say that. maybe add a comment above it to clarify that it's there so that there's One Place that one is to look for the exported functions. [20:59:24] dr0ptp4kt, its a wiki :) [20:59:31] edit it :D [20:59:41] yurikR: i've heard of them. [21:00:13] (03PS6) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [21:01:13] (03PS7) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [21:01:20] jdlrobson: do you know what "Must be under a feature flag" means here: https://trello.com/c/AhWMM2zo/1-8-wikigrok-in-sidebar-mvp [21:01:38] bmansurov: feature flag is a global variable defined in MobileFrontend.php that defaults to false [21:01:42] that has to be enabled in LocalSettings.php [21:01:48] jdlrobson: thank you [21:02:15] (03PS8) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [21:04:21] kaldari_lunch: we're design reviewing when you have a mo [21:04:24] (03CR) 10jenkins-bot: [V: 04-1] Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [21:05:23] jdlrobson, bmansurov Hola! [21:05:31] nuria__: heeeyy :D [21:05:35] nuria__: hola [21:05:56] I wanted to let you guys know that we fixed (with some guest start contributions) teh beta labs testing environment for event logging [21:06:21] so we can test throughly instrumentation and validation of events before sending code to production [21:06:29] just an FYI [21:06:40] cool! [21:08:44] bmansurov, jdlrobson: if you add new EL instrumentation or a/b testing that you care to test before moving it to prod using beta labs let us know if you need any help [21:09:06] nuria__: OK I will, thank you. [21:09:29] (03CR) 10Kaldari: [C: 032] Restrict response API to 2 submissions per minute [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177938 (owner: 10MaxSem) [21:09:54] (03Merged) 10jenkins-bot: Restrict response API to 2 submissions per minute [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177938 (owner: 10MaxSem) [21:12:25] 3MobileFrontend-stable, Mobile-Web: List of languages looks strange when mixes RTL and LTR languages - https://phabricator.wikimedia.org/T66617#842741 (10Jdlrobson) 5Open>3stalled Blocked on T78334 [21:24:29] (03CR) 10Jdlrobson: [C: 04-1] "Margin top of the footer needs to be removed. Otherwise there is a huge gap thus doesn't meet acceptance criteria "Remove line separator f" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [21:25:24] jdlrobson: ^ it's already removed in alpha [21:25:40] bmansurov: mm? [21:25:50] bmansurov: there's a huge gap though for me. Let me just check its not cache [21:25:58] jdlrobson: ok [21:26:44] 3MobileFrontend-stable, Mobile-Web: List of languages looks strange when mixes RTL and LTR languages - https://phabricator.wikimedia.org/T66617#842798 (10Amire80) Another imaginable possibility is to resolve it through https://phabricator.wikimedia.org/T78337 . It also makes more sense because it's about languag... [21:27:33] (03PS1) 10Jdlrobson: Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 [21:30:05] (03PS3) 10BearND: Fix possible crash(es) related to fragment manager state loss. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 (owner: 10Dbrant) [21:30:13] (03CR) 10BearND: [C: 032] Fix possible crash(es) related to fragment manager state loss. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 (owner: 10Dbrant) [21:30:13] 3MobileFrontend-stable, Mobile-Web: List of languages looks strange when mixes RTL and LTR languages - https://phabricator.wikimedia.org/T66617#842800 (10Amire80) [21:31:08] (03CR) 10Jdlrobson: [C: 032] "Seems to be cache related." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [21:32:22] (03Merged) 10jenkins-bot: Fix possible crash(es) related to fragment manager state loss. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179139 (owner: 10Dbrant) [21:32:51] (03Merged) 10jenkins-bot: Alpha: move lastmodified to bottom of article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178686 (owner: 10Bmansurov) [21:33:43] (03CR) 10Florianschmidtwelzow: [C: 031] Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [21:35:42] (03PS9) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [21:35:44] (03PS1) 10Jdlrobson: Hygiene: Fix phpcs complaints in hooks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179211 [21:36:37] kaldari_lunch, so... we should swat that logging fix and try enabling WG again? [21:40:26] mhurd, dbrant: Fouad is on his way back right now. [21:40:41] Deskana: nice [21:40:45] mhurd, dbrant: I think I'll leave you gentlemen to it for now and check back in in an hour or so. [21:40:52] Deskana: sounds good [21:41:03] mhurd, dbrant: But yeah, let me know if you need anything [21:41:18] Deskana: will do, you’ll let him in? [21:41:34] mhurd: Yeah, or Gayle will. [21:41:41] cool [21:41:43] mhurd: The front desk will contact me if they need me. :) [21:42:49] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Fix phpcs complaints in hooks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179211 (owner: 10Jdlrobson) [21:45:09] hola [21:45:20] In the Android app, what is "Could not draw the image"? [21:46:07] Deskana: ^ [21:46:13] (03PS4) 10Jdlrobson: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [21:46:15] Hey Amir. [21:46:21] dbrant: ^ [21:46:35] aharoni: lol we'll work on making that more specific. Most likely it means that there isn't enough memory to render the image in full resolution. [21:46:49] OK [21:46:58] "draw" makes me think of the user drawing something. [21:47:04] aharoni: can you point to the image in question? [21:47:13] It's a user interface string. [21:47:23] gallery error draw failed [21:47:44] dbrant: I think aharoni is translating the string. Maybe we need to add more qqq [21:48:12] yes, and even in English it's not entirely clear. [21:48:18] aharoni: bearND: oh!! you didn't actually see it in the app. I'm confused! :D [21:48:29] https://translatewiki.net/w/i.php?title=Special:Translations&message=Wikimedia%3AWikipedia-android-strings-gallery+error+draw+failed%2Fhe [21:48:48] It's already translated to Malagasy! [21:48:58] Malagasy, of all languages. Malagasy! [21:49:41] aharoni: How does the image viewer look in rtl? [21:49:49] I'n on translatewiki.net since 2009, and it never stops surprising me. [21:50:05] Deskana: haven't tried it, actually. [21:50:13] * Deskana sets his phone to Hebrew. [21:50:16] Is it released in beta? [21:50:27] no, just alpha [21:50:33] MMM [21:50:40] can I get it anywhere? [21:50:52] whoah [21:50:55] https://android-builds.wmflabs.org/ [21:51:09] The design in beta changed considerably. I haven't opened it in a while. [21:51:32] Ah, sorry, I figured you were running the alpha. My bad. [21:51:51] Interesting that even the OS does not seem to be entirely translated to Hebrew. [21:52:00] "Wi-Fi", "Bluetooth" and "Apps" show up in English [21:52:22] Wi-Fi and Bluetooth is understandable, "Apps" is very disappointing. [21:52:52] Wi-Fi and Bluetooth are names of technologies, and even they could be transliterated, but for apps there is a word. [21:53:06] And "Nearby" still doesn't work with the Hebrew Wikipedia :( [21:54:27] (03CR) 10Jdlrobson: [C: 04-1] "minor problem." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [21:54:46] aharoni: Why is that? Are articles not geotagged? [21:54:54] They should be. [21:54:56] aharoni: What I'm trying to figure out is, is that on our end, or the site's end? [21:55:10] i'm pretty sure it's a (known) backend issue [21:55:51] same on trwiki [21:56:02] (03CR) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [21:56:47] Deskana: I'd expect to see https://en.wikipedia.org/wiki/Shaare_Zedek_Medical_Center , for example, in Nearby, [21:56:59] the Hebrew articles appears to be geotagged. [21:57:29] (03PS8) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 [21:57:43] I see it when Wikipedia is English, but not Hebrew. [22:00:40] 3Wikipedia-App-Android-App: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#842886 (10Amire80) [22:01:41] Deskana: is it supposed to be possible to install the alpha along with the beta? [22:02:00] aharoni: Yeah, you can have all three on your phone at once; alpha, beta, production [22:02:23] They're actually separate apps, as far as your OS is concerned. [22:02:31] good [22:03:11] good night all! [22:03:27] 3MobileFrontend-alpha: Mysterious JS exception - https://phabricator.wikimedia.org/T78340#842901 (10Ciencia_Al_Poder) Not reproducible for me. I get this error instead: Error: Module not found: loggingSchemas/MobileWebClickTracking modules.js:17 [22:06:32] kaldari_lunch, DarTar, the issue with Linux/Firefox and EL is Adblock Plus 2.6.6. When enabled, we don't record EL events, when disabled, we do! [22:06:50] leila: wow [22:06:51] DarTar, should I send an email about this to analytics@ [22:07:00] yes please (public list) [22:07:03] yes [22:07:17] oh leila [22:07:18] hi [22:07:31] hi aharoni. lemme send the email and come back here. [22:08:12] leila, Deskana - would it be possible to have a table that compares how many people click on interlanguage links in MobileFrontend, Android, iOS and desktop? [22:08:54] aharoni: In theory, yes. If we could agree on a schema that works for all four platforms, then each implement that schema. [22:09:19] should I create a phab task for that or something? [22:09:28] aharoni: That'd be the first time a single schema had ever been implemented cross-platform (excluding stuff that's implemented on both iOS and Android apps) [22:09:33] I'm very very curious about how well does each implementation of interlanguage links works. [22:09:53] We'd also need to be very careful that it was implemented on all platforms in a way that makes the data comparable [22:10:12] (I don't care much about the implementation. It doesn't have to be a single schema as far as I'm concerned. I just want to see all the data side by side.) [22:11:12] If it's in a single table then it has to be a single schema [22:11:17] That's why I suggested that [22:11:28] It also helps make sure that the data is cross-comparable if you do it that way [22:12:26] 3MobileFrontend-alpha: Mysterious JS exception - https://phabricator.wikimedia.org/T78340#842931 (10Florian) http://bits.beta.wmflabs.org/static-master/extensions/MobileFrontend/javascripts/modules/wikigrok/WikiGrokDialog.js:78:35 mw.config.get( 'wgWikiGrokCampaigns' ) is null :/ [22:14:07] aharoni: Sure, file a Phab task. Might be a good thing to mention to Howie next time you chat to him. [22:14:25] Deskana: thanks. [22:14:33] (03PS1) 10BearND: Enable Lint [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179227 [22:18:37] Deskana, when we talked with Jon K the other time, did we conclude that we want to have one schema per device? [22:23:58] Deskana: nicey, I managed to send to a screenshot to Phabricator by email straight from my device :) [22:24:02] https://phabricator.wikimedia.org/T78347 [22:24:16] editing the task with better description... [22:30:53] Deskana: I played around with the alpha and IT'S AWESOME. [22:31:11] The top image, the minimized infobox, the image viewer. [22:31:19] aharoni: Yay! :D [22:31:30] Some bugs here and there, but the general design is lovely. [22:31:55] "alpha" [22:31:57] A friend complained to me a few days that the infobox is too big, and BAM - you are already solving it. [22:32:09] a few days ^ago^ [22:33:03] Deskana: Commons has templates that allow adding image descriptions in several languages. Do you use them? [22:33:04] fouadm: https://github.com/montehurd/apps-ios-wikipedia.git [22:33:18] aharoni: We use whatever the API gives us. [22:33:39] aharoni: AFAIK it does handle different languages if you query a different API. [22:33:59] aharoni, hi [22:34:04] e.g. if I look at the exact same image with my wiki set to French Wikipedia, the API returns the French description [22:34:49] aharoni, so another user reported what basically seems to be https://phabricator.wikimedia.org/T35704 a few days ago - I looked into it a bit [22:34:55] 3Wikipedia-App-Android-App: suboptimal scrollbar in image description on Android - https://phabricator.wikimedia.org/T78347#842991 (10Amire80) [22:35:52] aharoni, thought I'd look at your example, https://en.wikipedia.org/wiki/Ora,_Israel - seems the equivalent page on hewiki is called "אורה" [22:36:00] Correct. [22:36:02] https://en.wikipedia.org/w/api.php?action=query&generator=geosearch&ggspage=Ora,_Israel&ggsradius=1000 returns useful results, https://he.wikipedia.org/w/api.php?action=query&generator=geosearch&ggspage=%D7%90%D7%95%D7%A8%D7%94&ggsradius=1000 does not [22:36:03] I used to live there :) [22:36:47] so the problem is either with GeoData or hewiki's coordinate templates, not the app [22:37:34] Krenair: Can you check whether the coordinates in the he.wikipedia article are correct? [22:38:06] they're identical to the enwiki ones [22:45:09] aharoni, I don't see where #coordinates is being called in https://he.wikipedia.org/wiki/%D7%99%D7%97%D7%99%D7%93%D7%94:Coordinates [22:45:50] Drat. [22:46:25] mmm [22:46:33] MaxSem: but where is it in English? [22:46:47] it's in the template itself [22:46:55] which is not the case for he: [22:48:30] hey Maryana [22:48:51] greetings :) [22:52:12] aharoni, trwiki ran into the same issue :) [22:52:41] I tried adding #coordinates to the templates there, don't think I quite got it working though [22:53:02] hellooo Maryana. :-) [22:53:37] MaxSem, Krenair: I'm not really familiar with how that keyword works. Is there a page that describes it? [22:53:52] lolwut, docs? [22:54:02] https://www.mediawiki.org/wiki/Extension:GeoData [22:54:16] (03PS1) 10Kaldari: Fix EventLogging of responses when correct is null [extensions/WikiGrok] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179297 [22:54:32] (03PS1) 10Kaldari: Fix EventLogging of responses when correct is null [extensions/WikiGrok] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179300 [22:54:40] * aharoni has very hard time understanding why on Earth does every wiki has different templates and modules for this and why isn't this code common. [22:57:20] aharoni: Standardisation is hard. :) [22:57:38] (As evidenced by the fact that I would spell standardisation differently from a lot of people in this room, I guess!) [22:58:28] ZZZZZ [22:59:03] no u [23:01:05] mhurd: Heard any more voices? :P [23:01:15] Deskana: haha no [23:01:29] kaldari_lunch bmansurov did you see https://phabricator.wikimedia.org/T78340 ? [23:01:39] also kaldari_lunch stop having such a long lunch ;-) [23:01:55] (03PS1) 10Kaldari: Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179334 [23:02:13] (03PS1) 10Kaldari: Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179335 [23:04:31] (03PS1) 10Jdlrobson: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 [23:05:20] jdlrobso_: I just saw it, maybe related to kaldari_lunch's patch from yesterday? [23:07:23] (03CR) 10Jdlrobson: [C: 04-1] Restyle/reposition page actions (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [23:07:29] mhurd: I'll come and check in on you guys at 3:30. [23:08:17] (03CR) 10jenkins-bot: [V: 04-1] Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [23:14:29] 3MediaWiki-extensions-GeoData, Wikipedia-App-Android-App: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#843062 (10Krenair) I can't quote Amir's post giving w:en:Ora,_Israel as an example due to https://secure.phabricator.com/T6736 But anyway, it l... [23:14:37] jdlrobso_: how can I easily construct a page URL from its NS and title? [23:14:47] grep for getLocalUrl [23:14:52] thanks [23:15:43] (03PS2) 10Jdlrobson: Hygiene: Fix phpcs complaints in hooks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179211 [23:17:51] brion: heya! time for quick hangout sync-up? [23:18:16] jdlrobso_: in the front end? [23:18:41] bmansurov: oh for frontend getUrl i think or something like that [23:18:49] oki [23:18:49] it's in mw.util [23:18:54] cool [23:20:18] (03CR) 10Jdlrobson: [C: 04-1] "needs a rebase :-(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [23:33:19] 3Wikipedia-App-Android-App: overlapping lines under the globe logo in the Android login screen - https://phabricator.wikimedia.org/T78350#843080 (10Amire80) [23:34:40] 3Wikipedia-App-Android-App: suboptimal scrollbar in image description on Android - https://phabricator.wikimedia.org/T78347#843086 (10Amire80) [23:37:42] kaldari_lunch, yt? [23:38:30] mhurd: yo [23:38:36] heya! [23:38:54] i’m refactoring interfaces whee :D [23:39:06] you’re gonna like the new ones [23:39:28] brion: yay! [23:39:52] [article.thumbnailImage asUIImage], [article.sections[0].images[0] asUIImage] <- etc [23:40:34] mostly just a matter of letting the combined article+articlestore pass through instead of title into some of the data objects, and then they have the smarts to pull up more data [23:41:53] brion: oh i think those need to be MWKImages right? [23:42:18] mhurd: article.thumbnailImage or sections[2].images[3] iwll be an MWKImage :D [23:42:28] then you call its asUIImage to get a handy UIImage [23:42:33] and stick that in a view [23:42:33] perfect [23:42:51] :) [23:50:17] (03CR) 10MaxSem: [C: 032] Fix EventLogging of responses when correct is null [extensions/WikiGrok] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179300 (owner: 10Kaldari) [23:50:37] (03CR) 10MaxSem: [C: 032] Fix EventLogging of responses when correct is null [extensions/WikiGrok] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179297 (owner: 10Kaldari) [23:50:39] (03Merged) 10jenkins-bot: Fix EventLogging of responses when correct is null [extensions/WikiGrok] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179300 (owner: 10Kaldari) [23:50:59] (03CR) 10MaxSem: [C: 032] Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179334 (owner: 10Kaldari) [23:51:02] (03Merged) 10jenkins-bot: Fix EventLogging of responses when correct is null [extensions/WikiGrok] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179297 (owner: 10Kaldari) [23:51:16] (03CR) 10MaxSem: [C: 032] Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179335 (owner: 10Kaldari) [23:51:24] brion: oh while you’re doing article.thumbnailImage the “Needed for lead image” part of the checklist has an “article.image” item which will behave almost identically (but as a bucket for the article lead image) [23:51:39] *nod* [23:51:52] lemme stub that in [23:52:14] brion: cool [23:56:00] (03CR) 10jenkins-bot: [V: 04-1] Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179334 (owner: 10Kaldari)