[00:00:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use correct API parameter to avoid search JS exceptions [extensions/MobileFrontend] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/179335 (owner: 10Kaldari)
[00:04:40] <leila>	 kaldari, yt?
[00:05:32] <wikibugs>	 3Mobile-Apps, Analytics, Wikipedia-App-Android-App, Wikipedia-App-iOS-App, MediaWiki-extensions-UniversalLanguageSelector, Language-Engineering, Mobile-Web: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#843122 (10Amire80) 3NEW
[00:07:41] <grrrit-wm>	 (03PS5) 10Jdlrobson: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[00:07:43] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 
[00:07:51] <grrrit-wm>	 (03CR) 10Jdlrobson: Restyle/reposition page actions (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[00:07:57] <grrrit-wm>	 (03CR) 10MaxSem: [V: 032] "Fuck you jerkins" [extensions/MobileFrontend] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/179334 (owner: 10Kaldari)
[00:09:49] <grrrit-wm>	 (03PS6) 10Jdlrobson: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[00:10:06] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "made some tweaks.. what think others?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[00:11:17] <mhurd>	 fouadm: http://stackoverflow.com/a/7972976/135557
[00:12:13] <grrrit-wm>	 (03PS2) 10Jdlrobson: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 
[00:12:25] <leila>	 kaldari, let's start the final phase of testing if the fixes are there?
[00:16:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "@maxsem / @kaldari LGTM can you also test/check?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[00:18:49] <grrrit-wm>	 (03PS8) 10Jdlrobson: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[00:20:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson)
[00:21:53] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Don't bypass blocked user check in editor (anonymous editing) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[00:22:27] <kaldari>	 leila: time to test
[00:22:35] <leila>	 Hangout
[00:23:27] <MaxSem>	 kaldari, leila, how does it look so far?
[00:23:49] <leila>	 MaxSem, we are just about to test nulls
[00:23:55] <leila>	 hopefully we'll make it
[00:26:52] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/179357 
[00:27:57] <kaldari>	 MaxSem: so far, so good
[00:28:57] <dr0ptp4kt>	 yurikR: would you please review https://gerrit.wikimedia.org/r/#/c/179357/ ? zero.wikipedia.org/ redirects for mdot-only operators were sending users to lang.zero.wikipedia.org because of the way getZeroConfig() was being invoked in the landing redirect call.
[00:29:17] <dr0ptp4kt>	 yurikR: which was harmless, yet annoying. please examine closely.
[00:29:53] <yurikR>	 dr0ptp4kt, does it have to be deployed today?
[00:30:07] <dr0ptp4kt>	 yurikR: probably not, but if you can do it, swell
[00:30:19] <yurikR>	 dr0ptp4kt, only major ones today
[00:30:27] <yurikR>	 significant problems, etc
[00:30:37] <dr0ptp4kt>	 yurikR: i don't think it's so major that it should be deployed in that case.
[00:30:54] <yurikR>	 dr0ptp4kt, oops, sorry, thought it was fri in SF, my bad
[00:31:36] <dr0ptp4kt>	 yurikR: k, well if you can get it in, great. if not, then not. mind arranging a swat monday if you can't do it tonight?
[00:31:37] <MaxSem>	 kaldari, so we can deploy the config change?
[00:31:58] <yurikR>	 ok
[00:33:32] <kaldari>	 MaxSem: Leila's testing a couple more things...
[00:37:29] <MaxSem>	 yurikR, also: Warning: API call had warnings trying to get remote JsonConfig: warnings={"query":{"*":"Formatting of continuation data will be changing soon. To continue using the current formatting, use the 'rawcontinue' parameter. To begin using the new format, pass a
[00:40:30] <leila>	 MaxSem, I've passed on my blessings to it. ;-)
[00:50:51] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Small wording updates to Cucumber README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179363 
[00:51:18] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Small wording updates to Cucumber README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179363 (owner: 10Dr0ptp4kt)
[00:51:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Small wording updates to Cucumber README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179363 (owner: 10Dr0ptp4kt)
[00:54:10] <grrrit-wm>	 (03PS1) 10Bmansurov: Fix schema and wikigrog bugs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 
[00:54:56] <bmansurov>	 jdlrobso_: ^ should fix https://phabricator.wikimedia.org/T78340
[01:10:40] <grrrit-wm>	 (03PS1) 10Yurik: Fixed 'continue' API warning [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/179365 
[01:11:08] <yurikR1>	 MaxSem, could you +2 https://gerrit.wikimedia.org/r/179365
[01:11:53] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Fixed 'continue' API warning [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/179365 (owner: 10Yurik)
[01:11:57] <yurikR1>	 thx
[01:15:07] <yurikR1>	 MaxSem, any way to get a stacktrace for the  "Unable to get config content" msg?
[01:15:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed 'continue' API warning [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/179365 (owner: 10Yurik)
[01:20:45] <grrrit-wm>	 (03PS1) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 
[01:27:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov)
[02:10:58] <grrrit-wm>	 (03PS1) 10Bmansurov: WIP: Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 
[02:12:22] <grrrit-wm>	 (03PS2) 10Bmansurov: Make sure campaign exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 
[02:13:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[03:13:00] <grrrit-wm>	 (03PS1) 10Yurik: Fixed getAllowedAccountIds() to list all configs for admins [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179394 
[03:14:47] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Fixed getAllowedAccountIds() to list all configs for admins [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179394 (owner: 10Yurik)
[03:15:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed getAllowedAccountIds() to list all configs for admins [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179394 (owner: 10Yurik)
[03:17:58] <grrrit-wm>	 (03CR) 10Jhobs: "Context: hotfix for discovered bug where all partner graphs could not be shown for admins." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179394 (owner: 10Yurik)
[03:33:45] <grrrit-wm>	 (03CR) 10Mattflaschen: "This introduced T78360 ." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[03:38:33] <grrrit-wm>	 (03PS1) 10MaxSem: Fix undefined index warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179398 
[04:20:39] <grrrit-wm>	 (03PS1) 10Yurik: Allow impersonate= parameter for admin users [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179401 
[05:46:41] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Fix undefined index warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179398 (owner: 10MaxSem)
[06:09:08] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: WIP: Fix Schema errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[06:24:09] <lzia>	 hey kaldari.
[06:59:01] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: EventLogging: break up MobileWebClickTracking (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178287 (owner: 10Bmansurov)
[07:01:39] <grrrit-wm>	 (03PS5) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 
[07:02:28] <grrrit-wm>	 (03PS6) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 
[07:05:44] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] WIP: Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov)
[07:10:55] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] "This will make WikiGrok more stable against empty campaigns, but the question is: Why is there no campaign on beta labs?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov)
[07:19:27] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[07:40:09] <grrrit-wm>	 (03PS9) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 
[07:41:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[07:46:06] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson)
[07:50:41] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Refactor secondary actions generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson)
[08:09:32] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Restyle/reposition page actions (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[08:11:32] <grrrit-wm>	 (03PS10) 10Florianschmidtwelzow: Don't bypass blocked user check in editor (anonymous editing) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 
[09:13:45] <wikibugs>	 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#843940 (10Florian)
[09:16:05] <wikibugs>	 3MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#843941 (10Florian)
[09:16:53] <wikibugs>	 3MobileFrontend-Feature-requests: Add font size adjustment feature - https://phabricator.wikimedia.org/T50946#532681 (10Florian) Removed patch-for-review. The change was merged and the function will be available in alpha mode :)
[09:23:06] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Add missing loggingSchmeas dependency to fontchanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179419 
[09:25:42] <joakino>	 hi!
[10:02:32] <phuedx>	 hullo
[10:03:14] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 04-1] "This doesn't make much sense as it is. If the dialog only works if a campaign is found, then we should just bailout if there is no campaig" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov)
[10:07:29] <phuedx>	 the page action change has been quite contentious
[10:07:36] * phuedx sighs
[10:08:54] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Fix undefined index warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179398 (owner: 10MaxSem)
[10:10:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix undefined index warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179398 (owner: 10MaxSem)
[10:18:18] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Fix phpcs complaints in hooks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179211 (owner: 10Jdlrobson)
[10:19:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Fix phpcs complaints in hooks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179211 (owner: 10Jdlrobson)
[10:20:04] <joakino>	 phuedx: uh, didnt see that, what is the page action change?
[10:20:14] <phuedx>	 page action restyling
[10:20:27] <phuedx>	 joakino: https://gerrit.wikimedia.org/r/178859
[10:21:02] <joakino>	 phuedx: only codewise or also about design
[10:21:07] <phuedx>	 code wise
[10:21:14] <phuedx>	 the template classes aren't /great/
[10:22:12] * joakino agrees
[10:26:15] <joakino>	 phuedx: lots of things going on :/
[10:33:22] <phuedx>	 in the templates?
[10:33:25] <phuedx>	 or in the change?
[10:50:44] <joakino>	 in the change, with all the comments
[10:51:41] <phuedx>	 yeah, getting the templates to play nice was the hard part
[10:51:44] <phuedx>	 the styling was easy
[10:54:06] <phuedx>	 lol
[10:54:18] <phuedx>	 i've just received 50 pages of credit card bills in the post :/
[10:54:55] <phuedx>	 i asked my bank to resend all of my bills for the previous financial year and they've send me /all/ of them
[11:05:10] <joakino>	 phuedx: lol
[11:05:42] <joakino>	 phuedx: i'm going to do some paperwork, mail/bank, etc
[11:05:49] <phuedx>	 bleh
[11:05:51] <phuedx>	 paperwork
[11:05:57] <phuedx>	 (i feel your pain)
[11:05:59] <joakino>	 i'll be back after lunch
[11:06:18] <joakino>	 phuedx: yeah, i'm tired already, I want to get paid already
[11:06:26] <phuedx>	 lol
[11:06:26] <joakino>	 (yes i'm that slow)
[11:06:49] <joakino>	 it doesn't help how convoluted it is in spain to properly set up
[11:06:57] <joakino>	 anyway..
[11:07:05] <joakino>	 see you later! 👋
[11:32:02] <grrrit-wm>	 (03PS7) 10Phuedx: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 
[11:34:55] <grrrit-wm>	 (03CR) 10Phuedx: Restyle/reposition page actions (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[11:41:52] <grrrit-wm>	 (03CR) 10Phuedx: Hygiene: Refactor secondary actions generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson)
[12:48:49] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Restyle/reposition page actions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx)
[14:45:02] <phuedx>	 i feel awful :/
[14:51:39] <grrrit-wm>	 (03PS2) 10Phuedx: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson)
[14:51:41] <grrrit-wm>	 (03PS8) 10Phuedx: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 
[14:56:59] <grrrit-wm>	 (03CR) 10Phuedx: Hygiene: Refactor secondary actions generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson)
[14:58:11] <grrrit-wm>	 (03PS3) 10Phuedx: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson)
[15:45:12] <grrrit-wm>	 (03CR) 10Bmansurov: WIP: Fix Schema errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[15:53:00] <grrrit-wm>	 (03CR) 10Bmansurov: "Florainschmidtwelzow, that's a good question, but that happened yesterday. In any case we should take care of this in our code too ;)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov)
[16:01:16] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "Just one thing:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179174 (owner: 10BearND)
[16:10:20] <wikibugs>	 3Wikipedia-App-Android-App: SQLiteException: Can't upgrade/downgrade database - https://phabricator.wikimedia.org/T75161#844382 (10Krenair) >>! In T75161#808265, @Deskana wrote: > Downgrade: This happens when someone tries to install an older APK on top of a newer one. This is not a supported operation. Unfortun...
[16:18:04] <joakino>	 back 
[16:23:26] <Krenair>	 dbrant, Deskana: This looks like one for you guys: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8017043
[16:23:52] <dbrant>	 Krenair: Deskana: i was just drafring a response ;)
[16:23:57] <dbrant>	 *drafting
[16:24:40] <Krenair>	 ok
[16:35:49] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "See inline. The more I think about it, the more relying on the browser to do text transformation might be the only clean approach." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson)
[16:48:54] <grrrit-wm>	 (03CR) 10Phuedx: [C: 031] "This works for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson)
[17:05:47] <grrrit-wm>	 (03CR) 10Jhernandez: "That works for me, it changes pages but it loads the last item from the previous page in the next page (i've changed the limit to 3)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson)
[17:06:37] <joakino>	 phuedx: bmansurov ^ what's going on with this patch xd
[17:07:01] <bmansurov>	 joakino: it's been misbehaving ;)
[17:07:22] <phuedx>	 who doesn't love pagination?
[17:07:38] <joakino>	 haha
[17:07:53] <joakino>	 this one is taking a lot longer than it should
[17:08:17] <joakino>	 i remember testing a while ago
[17:08:56] <bmansurov>	 joakino: it should be approved if it's working for you guys, i suspect something is wrong with my vagrant, i've had other random problems with it
[17:11:29] <joakino>	 bmansurov: it is not working as I would expect it to, but I don't know if that's the intended behaviour
[17:11:59] <joakino>	 bmansurov: i feel you, last time I updated everything broke, so I'm updating as little as I can
[17:12:08] <joakino>	 like somebody was saying in the email
[17:12:20] <bmansurov>	 yeah
[17:15:46] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Simplify banner check [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179490 
[17:22:54] <joakino>	 phuedx: about the watchlist patch, does it work for you the same as for me? is that the intended behavior?
[17:23:40] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Simplify banner check [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179490 
[17:23:43] <phuedx>	 joakino: wait, i'll double check
[17:24:03] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Simplify banner check [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179490 (owner: 10Dr0ptp4kt)
[17:28:07] <phuedx>	 joakino: ah, you're right
[17:28:19] <phuedx>	 i think that might be the intended behaviour
[17:28:29] <phuedx>	 but it's a little confusing
[17:28:41] <joakino>	 a bit weird indeed
[17:28:51] <joakino>	 let's wait for jdlrobson
[17:29:53] <grrrit-wm>	 (03PS1) 10BearND: Code inspections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179492 
[17:29:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Simplify banner check [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179490 (owner: 10Dr0ptp4kt)
[17:39:05] <phuedx>	 chrome crashed
[17:39:09] <phuedx>	 lost my schema edit
[17:39:11] <phuedx>	 so annoyed
[17:44:50] <wikibugs>	 3Wikipedia-App-Android-App: NullPointerException at org.wikipedia.beta.createaccount.CreateAccountActivity - https://phabricator.wikimedia.org/T69019#844490 (10Krenair) And https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8018352
[17:50:04] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Enable Lint [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179227 (owner: 10BearND)
[18:08:58] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Code inspections (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179492 (owner: 10BearND)
[18:10:54] <joakino>	 kristenlans: hangouts crash, sorry
[18:13:16] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] WIP: Fix Schema errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[18:15:18] <phuedx>	 yo
[18:15:30] * phuedx waits for Jdlrobson
[18:17:47] <jdlrobson>	 hey joakino
[18:17:55] <joakino>	 jdlrobson: sup
[18:18:03] <jdlrobson>	 joakino: i was just asking how long before your weekend begins and did you have time to talk about the search icon issues
[18:18:14] <joakino>	 i'll be here for a bit
[18:18:22] <joakino>	 jdlrobson: so now? xD
[18:18:30] <jdlrobson>	 joakino: ok cool
[18:18:42] <jdlrobson>	 so i'm just rebasing the latest patch but did you try the latest patch? I couldn't see the issues you talked about
[18:18:52] <joakino>	 i'm going to try again
[18:19:10] <joakino>	 jdlrobson: tell me when youve submitted it
[18:19:24] <grrrit-wm>	 (03PS5) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 
[18:19:25] <jdlrobson>	 ^ joakino done
[18:19:55] <joakino>	 👍 i'll tell you something
[18:21:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson)
[18:24:27] <jdlrobson>	 joakino: oops issue with js
[18:24:54] <leila>	 hey kaldari. how persistent is userToken for logged in users?
[18:24:57] <jdlrobson>	 done
[18:24:58] <joakino>	 jdlrobson: yeah something is broken
[18:24:59] <grrrit-wm>	 (03PS6) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 
[18:25:06] <joakino>	 👍
[18:25:08] <kaldari>	 MaxSem: can you take a look at https://phabricator.wikimedia.org/T72312 ? We're stuck in a stalemate on this Echo diff bug.
[18:25:09] <jdlrobson>	 ^ joakino sorry bout that was being dumb
[18:25:14] <leila>	 can I assume that every editor will have a unique userToken throughout the one week experiment?
[18:25:21] <wikibugs>	 3Mobile-Apps, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#844538 (10KLans_WMF) p:5Triage>3Normal
[18:25:31] <kaldari>	 leila: 90 day cookie I believe
[18:26:44] <leila>	 I see. and if their browser deletes cookies after being closed, the editor will get a new userToken on the next arrival?
[18:26:54] <joakino>	 jdlrobson: is it possible that I need to update mediawiki? maybe that's why i'm seeing missaligned icons
[18:27:15] <joakino>	 jdlrobson: i'm so afraid to vagrant git-update
[18:27:16] <wikibugs>	 3Wikipedia-App-iOS-App: App does not load any other section or article once you enter a text in the Language filter box which does not have any match - https://phabricator.wikimedia.org/T76380#844540 (10KLans_WMF) p:5Triage>3Normal
[18:27:21] <bmansurov>	 kaldari: do you have 2 mins to help me with event logging?
[18:27:53] <kaldari>	 sure
[18:28:08] <kaldari>	 leila: yes
[18:28:14] <leila>	 thanks, kaldari.
[18:28:43] <bmansurov>	 kaldari: Event logging code is sending the following data, but I get ERR_CONNECTION_REFUSED: {"event":{"name":"nearby","destination":"/wiki/Special:Nearby","mobileMode":"alpha","username":"Baha","userEditCount":33},"clientValidated":true,"revision":10703095,"schema":"MobileWebMainMenuClickTracking","webHost":"127.0.0.1","wiki":"wiki"};:
[18:28:58] <bmansurov>	 kaldari: I've checked the schema name and version, they are both correct
[18:29:20] <kaldari>	 leila: the part that remember which pages you've answered WikiGrok for is more perisistant though. It actually stores that in LocalStorage and only falls back to cookies if LocalStorage isn't available.
[18:29:43] <leila>	 makes sense, kaldari.
[18:30:13] <leila>	 trying to figure out a way to count unique users, and see how many new users try it in each hour.
[18:31:05] <kaldari>	 bmansurov: connection refused sounds like a bigger problem. Where do you see that error?
[18:31:18] <bmansurov>	 kaldari: in browser console
[18:31:18] <jdlrobson>	 joakino: just go into mediawiki and do git pull origin master
[18:31:25] <wikibugs>	 3Wikipedia-App-iOS-App: Font size issues - https://phabricator.wikimedia.org/T78409#844546 (10Krenair) 3NEW
[18:31:26] <jdlrobson>	 you don't need to update vagrant
[18:31:35] <leila>	 per hour, we have around 7-10 unique users using WG, and these cookie approximations can dilute that number.
[18:31:40] <jdlrobson>	 joakino: but yeh it's very possible
[18:31:48] <jdlrobson>	 mediawiki should be kept up to date as much as possible :)
[18:31:54] <leila>	 will dig more, will update you later in the day kaldari
[18:32:02] <bmansurov>	 kaldari: this is the URL: http://localhost:8100/event.gif?%7B%22event%22%3A%7B%22name%22%3A%22nearby%22%2C%22destination%22%3A%22%2Fwiki%2FSpecial%3ANearby%22%2C%22mobileMode%22%3A%22alpha%22%2C%22username%22%3A%22Baha%22%2C%22userEditCount%22%3A33%7D%2C%22clientValidated%22%3Atrue%2C%22revision%22%3A10703095%2C%22schema%22%3A%22MobileWebMainMenuClickTracking%22%2C%22webHost%22%3A%22127.0.0.1%22%2C%22wiki%22%3A%2
[18:32:02] <bmansurov>	 2wiki%22%7D;
[18:32:55] <wikibugs>	 3Wikipedia-App-iOS-App: App does not load any other section or article once you enter a text in the Language filter box which does not have any match - https://phabricator.wikimedia.org/T76380#844557 (10KLans_WMF) Tracking this bug here: https://trello.com/c/2oKCryv3/15-app-does-not-load-any-other-section-or-art...
[18:33:58] <grrrit-wm>	 (03PS2) 10BearND: Enable basic ProGuard minification [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179174 
[18:34:19] <kaldari>	 bmansurov: the semicolon at the end shouldn't be encoded (although I have no idea if that's the problem)
[18:34:42] <kaldari>	 probably not
[18:34:54] <bmansurov>	 kaldari: do you know what service is listening to the 8100 port?
[18:35:19] <kaldari>	 No, I'm not sure
[18:35:26] <bmansurov>	 kaldari: ok thanks
[18:35:48] <wikibugs>	 3Mobile-Apps, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: "Your app’s back button doesn’t send users back to search results" - https://phabricator.wikimedia.org/T75918#844560 (10KLans_WMF) Tracking this bug here: https://trello.com/c/DGd3Hygd/23-bug-t75918-your-app-s-back-button-doesn-t-send-users-back-to-...
[18:36:43] <wikibugs>	 3Wikipedia-App-iOS-App: Font size issues - https://phabricator.wikimedia.org/T78409#844562 (10Sjoerddebruin) There is a global font size setting in iOS 8+. It would be great if the app listens to that instead.
[18:37:58] <kaldari>	 bmansurov: You can try sending that to the production EventLogging and make sure it is accepted.. https://bits.wikimedia.org/event.gif?...
[18:38:21] <wikibugs>	 3Wikipedia-App-iOS-App: add a link to translatewiki.net to the About screen in the iOS app - https://phabricator.wikimedia.org/T72946#844564 (10Sjoerddebruin) 5Open>3Resolved a:3Sjoerddebruin Added in one of the latest releases.
[18:38:49] <kaldari>	 bmansurov: and then check the log tables to see if it gets recorded. It sounds like it's probably an issue without you local EventLogging service though
[18:39:53] <dbrant>	 bearND_: lol  "...the annoying feature..."
[18:39:56] <bmansurov>	 kaldari: It looks like it worked, but can you give me some info on how to check log tables? 
[18:40:11] <kaldari>	 bmansurov: sure, one sec...
[18:40:11] <bearND_>	 dbrant: oops, did i leave that in?
[18:40:36] <dbrant>	 bearND_: we should probably decrease it just a bit :)
[18:41:09] <wikibugs>	 3Wikipedia-App-Android-App: Opening ToC for the first time on a very slow connection causes loading indicator to show on top of ToC onboarding - https://phabricator.wikimedia.org/T76932#844574 (10KLans_WMF) p:5Triage>3Normal
[18:44:21] <joakino>	 jdlrobson: jebus krist i've broken it
[18:44:26] <joakino>	 css is not loading now
[18:44:31] <jdlrobson>	 joakino: uhhhohhhh
[18:44:34] <jdlrobson>	 joakino: no css at all?
[18:44:36] <jdlrobson>	 what did you do?
[18:44:38] <joakino>	 😩💩
[18:44:41] <YuviPanda>	 h
[18:44:52] <joakino>	 jdlrobson: vagrant git-update...
[18:44:56] <joakino>	 dangit
[18:45:38] <jdlrobson>	 joakino: noooo
[18:45:42] <jdlrobson>	 don't do that
[18:45:47] <jdlrobson>	 you should have just gone into mediawiki folder
[18:45:51] <jdlrobson>	 and done git pull origin master'
[18:45:53] <joakino>	 i've learnt my lesson, there wont be a 3rd time xd
[18:45:54] <jdlrobson>	 much safer!
[18:45:55] <jdlrobson>	 :P
[18:46:04] <jdlrobson>	 MaxSem: $wgMFCollapseSectionsByDefault = false on wikidata.org
[18:46:13] <jdlrobson>	 section collapsing makes no sense there
[18:46:21] <MaxSem>	 ugh
[18:46:24] <MaxSem>	 okayyyy
[18:46:32] <kaldari>	 bmansurov: Sorry, was discussing stuff with Max IRL
[18:46:38] <bmansurov>	 np
[18:47:14] <kaldari>	 bmansurov: You'll want to go to bast1001 and then ssh to stat1003...
[18:47:43] <kaldari>	 bmansurov: then....
[18:47:43] <kaldari>	 mysql --defaults-file=/etc/mysql/conf.d/research-client.cnf -h analytics-store.eqiad.wmnet
[18:47:58] <kaldari>	 then 'use log;'
[18:48:19] <bmansurov>	 kaldari: thanks
[18:48:25] <joakino>	 jdlrobson: no styles at all, i'm giving up
[18:48:43] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Enable basic ProGuard minification [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179174 (owner: 10BearND)
[18:48:53] <kaldari>	 bmansurov: then you can 'show tables;' to find the right eventlogging table with the data
[18:49:00] <bmansurov>	 cool
[18:49:04] <Deskana>	 Error:Failed to find: com.android.support:appcompat-v7:21.0.3
[18:49:04] <Deskana>	 <a href="openFile">Open File</a><br><a href="open.dependency.in.project.structure">Open in Project Structure dialog</a>
[18:49:09] <Deskana>	 dbrant, bearND_: ^
[18:49:28] <dbrant>	 Deskana: update your sdk
[18:49:36] <joakino>	 jdlrobson: i'll continue on monday, ping somebody else to check that patch, or i'll review it on monday
[18:49:42] <Deskana>	 dbrant: Roger.
[18:49:46] <jdlrobson>	 joakino: okay. yeh save it for monday
[18:49:49] <jdlrobson>	 enjoy your weekend :)
[18:49:56] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Fix typo in curl README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179511 
[18:50:03] <joakino>	 jdlrobson & all have a nice weekend
[18:50:05] <jdlrobson>	 joakino: hopefully someone else can ytake a look :)
[18:50:14] <joakino>	 hopefully :p
[18:50:25] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Fix typo in curl README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179511 (owner: 10Dr0ptp4kt)
[18:50:30] <jdlrobson>	 bmansurov: can i help you with the eventlogging stuff?
[18:50:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix typo in curl README [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179511 (owner: 10Dr0ptp4kt)
[18:51:01] <jdlrobson>	 kaldari: would be great if you can review https://gerrit.wikimedia.org/r/178793
[18:51:13] <jdlrobson>	 A patch from FlorianSW that i'm keen to get merged
[18:51:14] <bmansurov>	 jdlrobson: yes, it's not working for me locally, I get connection refused error in the console when I ping this url: http://localhost:8100/event.gif?%7B%22event%22%3A%7B%22name%22%3A%22nearby%22%2C%22destination%22%3A%22%2Fwiki%2FSpecial%3ANearby%22%2C%22mobileMode%22%3A%22alpha%22%2C%22username%22%3A%22Baha%22%2C%22userEditCount%22%3A33%7D%2C%22clientValidated%22%3Atrue%2C%22revision%22%3A10703095%2C%22schema%22
[18:51:15] <bmansurov>	 %3A%22MobileWebMainMenuClickTracking%22%2C%22webHost%22%3A%22127.0.0.1%22%2C%22wiki%22%3A%22wiki%22%7D;
[18:51:16] <kaldari>	 jdlrobson: I'm already looking at it
[18:51:22] <jdlrobson>	 could be some protected page issues. Awesome kaldari :)
[18:51:25] <jdlrobson>	 bmansurov: that's fine
[18:51:35] <bmansurov>	 jdlrobson: so is it working?
[18:51:52] <jdlrobson>	 well have you got http://localhost:8100/event.gif up on your server?
[18:52:10] <Deskana>	 dbrant, bearND_: Is ProGuard something we need to add to our libraries list in "About"?
[18:52:31] <jdlrobson>	 bmansurov:  you can cheat and point it to http://bits.beta.wmflabs.org/event.gif
[18:52:42] <bmansurov>	 jdlrobson: where is the code for that?
[18:52:43] <jdlrobson>	 and then check if the events get registered on labs
[18:52:49] <jdlrobson>	 ^ bmansurov this will be much easier :)
[18:52:57] <dbrant>	 Deskana: pretty sure it's part of the sdk, so no need.
[18:53:16] <bmansurov>	 jdlrobson: ok
[18:53:58] <jdlrobson>	 $wgEventLoggingSchemaApiUri ='http://bits.beta.wmflabs.org/event.gif'; < bmansurov
[18:54:16] <bmansurov>	 thanks
[18:54:17] <grrrit-wm>	 (03PS1) 10Dbrant: Decrease the edge width of Drawer drag areas. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179515 
[18:54:22] <YuviPanda>	 bmansurov: if you’re using Vagrant, I don’t think localhost:8100 actually works
[18:54:25] <YuviPanda>	 like, at all.
[18:54:31] <YuviPanda>	 I know that is set to the default, but...
[18:54:44] <bmansurov>	 YuviPanda: thanks for clarifying
[18:55:06] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add missing loggingSchmeas dependency to fontchanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179419 (owner: 10Florianschmidtwelzow)
[18:55:10] <YuviPanda>	 we could theoretically set up the devserver locally listening there, but it’s not going to be anywhere close to same as prod...
[18:55:17] <YuviPanda>	 so nobody has taken the time to do that, I think
[18:56:31] <bmansurov>	 no problem, i'll use the labs
[18:56:37] <bearND_>	 Deskana: no, ProGuard is not a library. It's a tool, which gets bundled as part of the Android SDK.
[18:56:50] <Deskana>	 Yeah, I googled it and found something else called ProGuard I guess. :)
[18:57:05] <Deskana>	 Excellent!
[18:57:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add missing loggingSchmeas dependency to fontchanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179419 (owner: 10Florianschmidtwelzow)
[18:57:33] <Deskana>	 Now I've updated my SDK I forgot why I even wanted to open Android Studio in the first place.
[18:57:35] * Deskana sighs.
[18:57:44] <bearND_>	 Deskana: it's probably the same (http://proguard.sourceforge.net/)
[18:58:19] <YuviPanda>	 proguard can also somewhat obfuscate your sourcode, so evil people can not reverse-engineer the apk and discover our secret source code!!1
[18:58:59] <Deskana>	 Yes. Let's obfuscate our open source project!!!
[18:59:15] <Deskana>	 OPEN SOURCE? MORE LIKE CLOSED SOURCE, AM I RIGHT? MUAHAHAHAHAHA
[18:59:21] <bearND_>	 YuviPanda: i've tried to tone down that as much as possible. The main reason I enabled it was for https://phabricator.wikimedia.org/T78197
[18:59:58] <YuviPanda>	 bearND_: ah, interesting that could possibly fix that
[19:00:06] <jdlrobson>	 YuviPanda: when you getting over to SF
[19:00:13] <YuviPanda>	 jdlrobson: end march
[19:00:24] <jdlrobson>	 YuviPanda: soooo long
[19:00:30] <jdlrobson>	 i might be dead by then
[19:00:32] <YuviPanda>	 jdlrobson: inorite
[19:00:39] <YuviPanda>	 jdlrobson: oh, from the hole in your ceiling?
[19:00:43] <bearND_>	 because some companies like to copy internal packages of the support libraries, and then when those support libraries get updated things break
[19:01:01] <YuviPanda>	 heh, true. I bet it’s samsung
[19:01:14] <YuviPanda>	 well, I remember it being samsung, things like this started when I was still on the team
[19:03:08] <jdlrobson>	 YuviPanda: yeh soo many holes still :(
[19:03:19] <YuviPanda>	 heh, is water leaking through?
[19:03:24] <jdlrobson>	 FlorianSW bmansurov https://phabricator.wikimedia.org/T78360 still broken :(
[19:03:34] <jdlrobson>	 YuviPanda: not quite
[19:03:39] <jhobs>	 dr0ptp4kt: pinging you about cucumber per your request
[19:03:40] <YuviPanda>	 heh, not so bad then
[19:03:45] <jdlrobson>	 although my bathroom got a little flooded but that was down to a slightly ajar window
[19:03:54] <YuviPanda>	 heh
[19:04:36] <bmansurov>	 jdlrobson, FlorianSW I'll submit a follow up patch
[19:05:09] <FlorianSW>	 bmansurov: ok, thanks, i missed this :( sorry
[19:05:14] <bmansurov>	 np
[19:05:40] <jdlrobson>	 anyway at least thanks isn't broken :)
[19:05:48] <jdlrobson>	 bmansurov: also another issue with diff prev or next buttons
[19:05:52] <jdlrobson>	 bmansurov: i created a checklist on card
[19:05:57] <bmansurov>	 jdlrobson: ok
[19:07:24] <jdlrobson>	 FlorianSW: is the nearby button working?
[19:07:29] <jdlrobson>	 FlorianSW: i can't find it anywhere on beta labs
[19:07:48] <FlorianSW>	 jdlrobson: locally yes, are there coordinates in beta labs?
[19:08:02] <FlorianSW>	 or do you mean nearby?
[19:08:05] <FlorianSW>	 *loggingschema?
[19:08:22] <jdlrobson>	 http://en.m.wikipedia.beta.wmflabs.org/wiki/GeoData FlorianSW
[19:08:35] <jdlrobson>	 FlorianSW: shouldn't that work? ^
[19:09:59] <FlorianSW>	 jdlrobson: hmm, i think it should :/
[19:11:22] <FlorianSW>	 jdlrobson: this is working: http://en.m.wikipedia.beta.wmflabs.org/wiki/New_York?mobileaction=alpha
[19:14:56] <wikibugs>	 3MobileFrontend-stable: [GlobalTitleFail] RequestContext::getTitle called by MobileContext::isBlacklistedPageInternal/ContextSource::getTitle/RequestContext::getTitle with no title set. - https://phabricator.wikimedia.org/T78414#844676 (10Legoktm) 3NEW
[19:32:43] <Krinkle>	 jdlrobson: Regarding a Mainpage.css, what about loading Common.css on mobile?
[19:32:56] <Krinkle>	 I can think of a 100 more things that look broken on mobile because of that missing. Sometimes
[19:33:19] <Krinkle>	 My personal petpeeve is tables having borders everywhere. Makes information templates on Wikipedia and commons look weird.
[19:33:30] <Krinkle>	 feature vs. optimisation. I'm not sure we should confuse the two.
[19:34:52] <jdlrobson>	 Krinkle: that's a separate conversation
[19:35:03] <MaxSem>	 we're working on table styles right now, btw
[19:35:11] <jdlrobson>	 but I don't think it makes sense to load CSS everywhere just for the main page
[19:35:23] <jdlrobson>	 css in Common.css should be reusable
[19:35:36] <jdlrobson>	 Krinkle: Common.css is my petpeeve
[19:35:47] <Krinkle>	 jdlrobson: Not really. If mobile would just load what wikis wrote and developed, it would work. Implementing it as a separate module for efficiency reasons is not a good reason to keep unloading common.css
[19:35:49] <jdlrobson>	 it's a dumping ground and looks like a bomb hit it
[19:36:09] <Krinkle>	 jdlrobson: yes, that's called local customisations. It'll get better with time. Denying it is not a long term solutino.
[19:36:20] <jdlrobson>	 Krinkle: if wikipedia didn't mix styling with content this wouldn't be an issue
[19:36:27] <jdlrobson>	 we should be moving away from that
[19:36:45] <Krinkle>	 jdlrobson: I thinik you're greatly overestimating the horror that would come from loading common.css
[19:36:52] <jdlrobson>	 Krinkle: i think you are
[19:37:05] <Krinkle>	 Anything that breaks, file it, work with the community to get those handful of issues fixed. It's never gonna get better this way.
[19:37:19] <jdlrobson>	 if you are really interested go away and do some research and come back to me when you have
[19:37:20] <Krinkle>	 Especially on the major wikis, they're very well maintained and open to feedback nowadays.
[19:37:33] <Krinkle>	 I have.
[19:37:59] <Krinkle>	 I've read, edited, cleaned up and work with local admins to refactor over 100 wikis' common.css .js'es
[19:38:26] <Krinkle>	 It's been my project for the past 3 years. First thing I did.
[19:39:43] <Krinkle>	 jdlrobson: maybe enable it in beta mode or something. Find out what the real problems are. The main problem left after that, which I assume is why you're afraid of it, is that it is "big". Loads of broken unused code making it slower to download.
[19:40:30] <bmansurov>	 jdlrobson: do you know why event logging is unable to validate a perfectly valid schema? Validation error against schema MobileWebUIClickTracking: Unknown schema: MobileWebUIClickTracking
[19:40:32] <Krinkle>	 But that could be said about many things. Takes review to make better. Feedback. I'm just curious what your plan for it is, and if loading common.css is in any future possible in your mind. I don't mind either way.  Just curious what your plans for it are i the long term.
[19:41:43] <Krinkle>	 Because if common.css/js is never happening on mobile, I'll need to adjust my strategy and to fix the bugs resulting from its absence by other means.
[19:43:06] <kaldari>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/178438/
[19:43:39] <jdlrobson>	 Krinkle: personally I didn't ever even want Mobile.css enabled, only reason it is is MaxSem enabled it whilst I was on a vacation. The problem with Common.css is a lot of it isn't relevant on mobile, it gets hidden anyway. Tables usually have styling problems due to inline styles not common.css and issues in our codebase (as Max says this iteration we are giving them some love)
[19:43:40] <jdlrobson>	 To be honest I think the only way to fix our css debt is to start creating more reusable concepts in core itself and move away from allowing inline-styles in templates.
[19:43:42] <jdlrobson>	 I'd be interested if you envision ways for editors to create and use OOUI widgets and set them up in a more controlled way.
[19:43:43] <grrrit-wm>	 (03PS7) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 
[19:44:52] <jdlrobson>	 Personally I think templates shouldn't be needed in MediaWiki. We should be using namespaces e.g. Graph / Table and referencing them as we do images
[19:45:11] <jdlrobson>	 The wikitext on a standard article should be simpler
[19:45:23] <jdlrobson>	 and shouldn't mix HTML markup and template variables with content
[19:45:32] <MaxSem>	 where you were 11 years ago? :P
[19:45:54] <jdlrobson>	 Imagine if the first thing you saw when you clicked edit was [[Infobox:San Francisco]] San Francisco is a ...
[19:46:03] <jdlrobson>	 so much more friendly for a newbie.
[19:46:35] <kaldari>	 jdlrobson: You can already do that, but it makes the infoboxes harder to edit.
[19:47:05] <kaldari>	 jdlrobson: i.e. {{Infobox San Francisco}} San Francisco....
[19:47:26] <kaldari>	 There are some articles that do things like that, but it's rare
[19:47:27] <grrrit-wm>	 (03PS2) 10Bmansurov: Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 
[19:47:46] <jdlrobson>	 kaldari: {{Infobox San Francisco}}  is better and certainly an improvement :-)
[19:47:55] <grrrit-wm>	 (03PS3) 10Bmansurov: Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 
[19:47:58] <jdlrobson>	 key thing is not showing parameters
[19:48:08] <jdlrobson>	 wikitext should be more like plain text and less like code
[19:48:47] <kaldari>	 jdlrobson: You should start a discussion on Village Pump: Proposals if you want people to switch to that
[19:49:11] <grrrit-wm>	 (03CR) 10Krinkle: Redoing how mobile handles tables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari)
[19:49:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[19:50:53] <Krinkle>	 jdlrobson: That is mostly handled by wikidata and better template abstraction ("{{Infobox}}" could be a magic template that takes the current page's wikidata item, finds the type of infobox, and fills in the parameters)
[19:51:12] <grrrit-wm>	 (03PS4) 10Bmansurov: Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 
[19:52:31] <grrrit-wm>	 (03CR) 10Bmansurov: Fix Schema errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[19:52:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[19:53:38] <Krinkle>	 jdlrobson: I don't think you'll find much resistance. If it works, it'll happen. I'm right there with you.
[19:53:45] <grrrit-wm>	 (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[19:53:45] <Krinkle>	 jdlrobson: Another obvious one is making templates not a local wiki concept.
[19:53:54] <Krinkle>	 jdlrobson: infoboxes * I mean
[19:54:18] <Krinkle>	 So that they could look/behave different on mobile, e.g. when registered from an extension.
[19:54:31] <jdlrobson>	 Krinkle: that would be lovely
[19:54:33] <Krinkle>	 Though you don't need it to be native to do that. media queries work fine in Common.css.
[19:54:36] <jdlrobson>	 Krinkle: so yeh i guess my point is by enabling Common.css you send out a message saying we are going to continue supporting this and i think by not enabling it it sends out a message that we don't see this as part of the future.
[19:54:43] <Krinkle>	 And I already experimented with that on Commons.
[19:54:47] <jdlrobson>	 i think mobile web as a unique opportunity to rethink things that we know suck
[19:55:36] <jdlrobson>	 for instance with targets we don't allow jquery ui on mobile - purposely to push people down the oojs route
[19:55:44] <kaldari>	 jdlrobson: The main obstacle to what you're talking about is not making it more difficult to edit the Infoboxes. If we had a nice client-side infobox editor (steal it from VE?) I'm sure people would love to move infoboxes out of article content.
[19:55:49] <Krinkle>	 jdlrobson: Maybe. I'm not convinced. And right now it is in my opinion just broken. That's the end-user perspective hat. It's not the user's job to care about the implementation.
[19:56:14] <jdlrobson>	 i guess from my perspective on mobile it's not broken and if you find specific examples of things that are we find ways to fix them
[19:56:21] <Krinkle>	 jdlrobson: There should be no reason to use an extreme measure like 'target' to forbid jquery-ui. If that was part of the rationale. 'target' would not have been landed in RL.
[19:56:24] <grrrit-wm>	 (03PS1) 10Dbrant: Refine search logic a bit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179529 
[19:56:31] <jdlrobson>	 i see people all the time commenting on Twitter they prefer the mobile experience on desktop so i don't think we are doing anything majorly wrong
[19:56:35] <Krinkle>	 And 'target' is, last I checked, still a temporary measure that will go away.
[19:56:38] <MaxSem>	 kaldari, you mean people except for enwikipedians? :P
[19:57:07] <Krinkle>	 jdlrobson: when oojs-ui is ready, jquery-ui is going away. deprecation, migration, guidance, removal. it doesn't take 'target' to do that.
[19:57:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refine search logic a bit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179529 (owner: 10Dbrant)
[19:57:36] <MaxSem>	 well, target will go away when we will be profoundly mobile-first
[19:57:40] <jdlrobson>	 Krinkle: but it helps... if we enabled jquery ui and people built a bunch of stuff for mobile that used it we're creating more code debt for ourselves
[19:57:45] <MaxSem>	 i.e. not very soon:)
[19:57:45] <jdlrobson>	 MaxSem: +2
[19:58:01] <Krinkle>	 I think you'll like the more rigorous approach going forward regarding unmaintained wiki customisations that don't keep up with development. It's gonna raise the bar slightly, but wikis deserve that.
[19:58:21] <Krinkle>	 jdlrobson: I respectfully disagree with that statement.
[19:58:24] <grrrit-wm>	 (03PS2) 10Dbrant: Refine search logic a bit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179529 
[19:58:49] <jdlrobson>	 bmansurov: sorry missed your message
[19:58:50] <grrrit-wm>	 (03PS3) 10Bmansurov: Make sure campaign exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 
[19:58:51] <jdlrobson>	 what's the EL problem
[20:01:13] * jdlrobson lunch
[20:41:56] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Apply percent decoding to titles extracted from URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177961 (owner: 10Sesh)
[20:46:23] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Apply percent decoding to titles extracted from URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/177961 (owner: 10Sesh)
[20:47:18] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178234 (owner: 10BearND)
[20:47:37] <grrrit-wm>	 (03PS4) 10Brion VIBBER: Re-added Wikidata descriptions to search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178890 (owner: 10Mhurd)
[20:48:23] <grrrit-wm>	 (03PS4) 10Bmansurov: Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 
[20:49:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov)
[20:50:06] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Re-added Wikidata descriptions to search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178890 (owner: 10Mhurd)
[20:50:46] <grrrit-wm>	 (03PS3) 10Brion VIBBER: Re-added Wikidata descriptions to Nearby results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178900 (owner: 10Mhurd)
[20:52:02] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Re-added Wikidata descriptions to Nearby results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/178900 (owner: 10Mhurd)
[20:53:35] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[20:55:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix Schema errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179385 (owner: 10Bmansurov)
[20:57:00] <grrrit-wm>	 (03PS5) 10Bmansurov: Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 
[20:59:42] <grrrit-wm>	 (03PS3) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 
[21:00:13] <grrrit-wm>	 (03CR) 10Bmansurov: "Please review this, I think it's OK if we merge it now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov)
[21:02:18] <grrrit-wm>	 (03PS4) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 
[21:05:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov)
[21:05:48] <grrrit-wm>	 (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov)
[21:06:28] <kristenlans>	 kaldari are you taking any holiday time off?
[21:06:44] <kaldari>	 don't think so
[21:06:58] <kaldari>	 I'm taking Christmas off
[21:07:06] <kristenlans>	 m'kay. WHat about you MaxSem? ANy extra hoiday time off?
[21:07:18] <MaxSem>	 nah
[21:07:27] <kristenlans>	 kaldari: yeah you shoudl definitely take the WMF holidays :-)
[21:07:59] <bmansurov>	 jdlrobson: regarding https://gerrit.wikimedia.org/r/#/c/178381/ can you help me test graphs locally? any instructions how to do it?
[21:08:12] <jdlrobson>	 bmansurov: i haven't looked in a while
[21:08:16] <jdlrobson>	 and it's highly likely it got broken in the refactor
[21:08:23] <bmansurov>	 jdlrobson: you left a comment there
[21:08:27] <jdlrobson>	 so you'll have to check
[21:08:31] <jdlrobson>	 but you can at least test the sql queries do what you expect them to
[21:08:42] <bmansurov>	 jdlrobson: directly in mysql?
[21:10:23] <grrrit-wm>	 (03PS5) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 
[21:13:43] <jdlrobson>	 bmansurov: yes
[21:13:55] <jdlrobson>	 kaldari: where can i discuss template changes on wikidata.org ?
[21:14:55] <bmansurov>	 jdlrobson: what's the mysql host for betalabs data? deployment-eventlogging02.eqiad.wmflabs.org isn't working
[21:18:44] <jdlrobson>	 bmansurov: what do you mean it is not working?
[21:18:47] <jdlrobson>	 bmansurov: what error are you getting
[21:18:50] <jdlrobson>	 do you have permission to access?
[21:19:17] <bmansurov>	 jdlrobson: I think so, I'm in stat1003 and running this command: mysql --defaults-file=/etc/mysql/conf.d/research-client.cnf -h deployment-eventlogging02.eqiad.wmflabs.org
[21:19:28] <bmansurov>	 jdlrobson: result: ERROR 2005 (HY000): Unknown MySQL server host 'deployment-eventlogging02.eqiad.wmflabs.org' (0) 
[21:19:52] <jdlrobson>	 https://m.wikidata.org/wiki/Q2 < kaldari
[21:20:02] <bmansurov>	 jdlrobson: but I can access analytics-store.eqiad.wmnet without a problem
[21:28:04] <grrrit-wm>	 (03PS2) 10Dbrant: Decrease the edge width of Drawer drag areas. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179515 
[21:29:43] <jdlrobson>	 bmansurov: ket me pm you
[21:29:52] <jdlrobson>	 bmansurov hey
[21:34:08] <MaxSem>	 jdlrobson, http://wikidata.wiki.local.wmftest.net:8080/
[21:41:26] <MaxSem>	 jdlrobso_, https://www.wikidata.org/wiki/User:Jdlrobson/minerva.css is still LESS:P
[21:45:39] <leila>	 kaldari, is uuid cookie based, too?
[21:56:21] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "This solves the problem, but is a fragile solution. We need to solve this the same way it is solved in core: mapping the legacy Restrictio" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[21:57:09] <kaldari>	 leila: uuid?
[21:59:49] <leila>	 yeah, I see id, uuid in the tables.
[22:00:52] <leila>	 kaldari, if you don't know it, don't worry about it for now. it's not in the schema definition. I'll see what it is and will let you know.
[22:10:15] <tfinc>	 mhurd: 6th floor cake alert 
[22:10:34] <grrrit-wm>	 (03CR) 10Jdlrobson: "@kaldari says he will try make the fix in core." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[22:11:11] <grrrit-wm>	 (03PS2) 10Jdlrobson: Add missing loggingSchmeas dependency to fontchanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179419 (owner: 10Florianschmidtwelzow)
[22:11:17] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Add missing loggingSchmeas dependency to fontchanger [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179419 (owner: 10Florianschmidtwelzow)
[22:11:26] <mhurd>	 tfinc: ooooh!
[22:11:36] <tfinc>	 mhurd: it's going fast...and its made out of kitkats 
[22:11:45] <tfinc>	 you should come see it at least
[22:12:28] <mhurd>	 tfinc: k
[22:12:33] <grrrit-wm>	 (03PS1) 10Deskana: Change "Credit" to "Author" in the image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179558 
[22:16:46] <sjoerddebruin>	 MaxSem: You say "edit links do not work on Wikidata mobile", but they were working at my side.
[22:17:03] <sjoerddebruin>	 Ehm, sorry. Wrong user. :P
[22:17:18] <sjoerddebruin>	 You've sended the e-mail, sorry. :P
[22:18:36] <sjoerddebruin>	 Anyway, is that Jon here?
[22:21:39] <hashar>	 late friday notice, MobileFrontend and Mantle are passing CI using hhvm :-)
[22:27:50] <MaxSem>	 jdlrobso_, ^^^
[22:27:56] <wikibugs>	 3MobileFrontend-Feature-requests: MobileFrontend extension should stop special-casing main page - https://phabricator.wikimedia.org/T32405#845082 (10Krinkle) @Tfinc: Having a separate version of the main page for mobile isn't desirable. Somehow it made sense to me at the time, but I agree. I'd like wikis to stic...
[22:27:56] <bmansurov>	 jdlrobso_: you don't happen to know what "project" it's under in labs, do you?
[22:28:38] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "View source - it's still in the HTML. I'm not sure this can be done for anonymous users... how does desktop do it?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[22:31:20] <grrrit-wm>	 (03PS7) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 
[22:31:27] <grrrit-wm>	 (03PS7) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 
[22:31:34] <grrrit-wm>	 (03PS2) 10Jdlrobson: Apply mobile modifications inside minerva desktop skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178888 
[22:31:39] <grrrit-wm>	 (03PS6) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 
[22:31:47] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: jscs: Use disallowSpacesInMemberExpression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174404 (owner: 10Jdlrobson)
[22:34:43] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "I disagree that we should feed desktop users with mobile versions of special pages depending on skin. This just mixes several problems int" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178888 (owner: 10Jdlrobson)
[22:39:14] <wikibugs>	 3MobileFrontend-Feature-requests: MobileFrontend extension should stop special-casing main page - https://phabricator.wikimedia.org/T32405#845089 (10Jdlrobson) @Krinkle note that the mf- id prefixes are no longer needed. If you don't have them your page will render as normal. See also T75425 - I'd suggest conver...
[22:40:12] <wikibugs>	 3MobileFrontend-Feature-requests: MobileFrontend extension should stop special-casing main page - https://phabricator.wikimedia.org/T32405#845091 (10Jdlrobson) and this is the function I'm desperate to kill: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/479a6d938930886042b536a4d0fa21...
[22:42:30] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Ehh, i trust the hook description and haven't really checked it :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow)
[22:42:39] <FlorianSW>	 jdlrobso_: ^
[22:43:15] <jdlrobso_>	 FlorianSW: it does what it says it does
[22:43:22] <jdlrobso_>	 but an anon user is the same as another anon user
[22:43:27] <jdlrobso_>	 so that's not varying :)
[22:44:12] <FlorianSW>	 wait, quickUserCan checks for blocks, too, or not?
[22:45:39] <jdlrobso_>	 FlorianSW: i'm not sure
[22:45:42] <FlorianSW>	 jdlrobso_:^ if i followed correctly, it should check for blocked users, too (which can vary from anon user to anon user)
[22:45:45] <jdlrobso_>	 FlorianSW: i still can't find nearby button anywhere
[22:46:11] <FlorianSW>	 jdlrobso_: in beta labs here: http://en.m.wikipedia.beta.wmflabs.org/wiki/New_York?mobileaction=alpha
[22:46:36] <FlorianSW>	 and in prod: http://de.m.wikipedia.org/wiki/Berlin?mobileaction=alpha
[22:46:46] <mhurd>	 lea-image face detection for intelligent crop is working :)
[22:46:52] <mhurd>	 *lead-image*
[22:46:56] <jdlrobso_>	 FlorianSW: ahh awesome :)
[22:47:05] <FlorianSW>	 Yeah :D
[22:47:05] <mhurd>	 brion: ^
[22:47:14] <brion>	 \o/
[22:47:17] <brion>	 awesome sauce
[22:47:30] <mhurd>	 brion: is pretty slick
[22:47:41] <jdlrobso_>	 wooa! all the new event logging is working
[22:47:56] <FlorianSW>	 MaxSem: Do you know, how desktop handles blocks of anonymous users and caches?
[22:48:09] <FlorianSW>	 jdlrobso_: Yeah, cool :)
[22:48:20] <jdlrobso_>	 FlorianSW: you been following https://phabricator.wikimedia.org/T77925 ?
[22:48:32] <FlorianSW>	 jdlrobso_: Can you run a query to see the usage of not-logged-in editing?
[22:48:55] <jdlrobso_>	 FlorianSW: oh yeh tht's been on my to do list all week
[22:49:06] <jdlrobso_>	 FlorianSW: i'll do that now
[22:49:29] <FlorianSW>	 jdlrobso_: I have subscribed and have read some comments, but not all atm.
[22:49:59] <MaxSem>	 FlorianSW, anons see they're blocked when they try to edit. I'm still not sure how do they see messages - probably, they gett a cache-busting cookie when they edit?
[22:50:15] <jdlrobso_>	 FlorianSW: i'll write up an email
[22:50:32] <FlorianSW>	 jdlrobso_: Great, thanks :)
[22:51:05] <FlorianSW>	 MaxSem: Hmm, betalabs is cached like prod, right? Can we test it there? Maybe kaldari know anything?
[22:51:26] <kaldari>	 FlorianSW: You sure are up late :)
[22:52:58] <kaldari>	 FlorianSW: I assume the articles are cached, but not the editing interface for articles.
[22:53:15] <kaldari>	 FlorianSW: but that's just a guess
[22:54:47] <FlorianSW>	 kaldari: maybe, yeah, thanks :)
[22:56:46] <kaldari>	 FlorianSW: I'm working on redoing the permission stuff in the API BTW
[22:57:24] <kaldari>	 FlorianSW: I might also try to fix how it works in core although I imagine people will yell at me :)
[22:57:28] <FlorianSW>	 kaldari: i'm waiting for the change to see, how you solved this :)
[22:58:25] <kaldari>	 FlorianSW: The permission checking is a total pile of hacks. It's such a mess :(
[22:58:34] <kaldari>	 In core I mean
[22:58:59] <FlorianSW>	 kaldari: unhappily not only this, i just think about the userlogin process :(
[23:08:04] <FlorianSW>	 jdlrobso_: What do you think about to get the blockinfo from the api, instead of use a config variable in skin? (maybe in initialize of EditorOverlay?)
[23:10:09] <grrrit-wm>	 (03PS1) 10BearND: Save ProGuard mapping files [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179569 
[23:12:56] <grrrit-wm>	 (03PS1) 10BearND: Add releases folder to gitignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179570 
[23:18:05] <jdlrobso_>	 FlorianSW: problem with that is it creates a nasty experience of clicking edit and then being told you can't edit
[23:18:08] <jdlrobso_>	 how does desktop deal with it?
[23:18:37] <jdlrobso_>	 our job is not to make more code debt but to make things work how they should have from the start :-)
[23:19:49] <FlorianSW>	 jdlrobso_: yes that's a problem. I will take a look into it next time, now i go to sleep :)
[23:22:11] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Decrease the edge width of Drawer drag areas. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179515 (owner: 10Dbrant)
[23:22:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Decrease the edge width of Drawer drag areas. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179515 (owner: 10Dbrant)
[23:23:49] <wikibugs>	 3Wikipedia-App-Android-App: too hard to click links near left edge of screen - https://phabricator.wikimedia.org/T78240#845150 (10bearND) 5Open>3Resolved a:3bearND Change https://gerrit.wikimedia.org/r/#/c/179515/ got merged, which reduces the edge width of the Drawer drag areas.
[23:29:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 (owner: 10Jdlrobson)
[23:30:25] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Fix up documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179572 
[23:32:26] <mhurd>	 brion: i keep typing “git fetch ferrit”
[23:32:52] <brion>	 lol
[23:33:05] <mhurd>	 i swear this happens once a day
[23:33:48] <Deskana>	 git checkout faster
[23:33:59] <jdlrobso_>	 FlorianSW: sent email about anon editing
[23:34:08] <Deskana>	 for some reason I tend to type "git checkoust master"
[23:34:14] <mhurd>	 Deskana: haha i’ve never done that one
[23:34:25] <Deskana>	 Checkoust reminds me of jousting.
[23:34:26] <Deskana>	 git joust
[23:35:20] <grrrit-wm>	 (03PS3) 10BearND: Refine search logic a bit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179529 (owner: 10Dbrant)
[23:35:28] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Refine search logic a bit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179529 (owner: 10Dbrant)
[23:35:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Apply mobile modifications inside minerva desktop skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178888 (owner: 10Jdlrobson)
[23:35:41] <dr0ptp4kt>	 mhurd: dbrant|bbl bear_nd: heads up about https://gerrit.wikimedia.org/r/#/c/179571/. i'm asking yuri and bblack to review it. in practice it doesn't much make a difference in the apps at the moment, but wanted to make you aware of it anyway.
[23:35:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov)
[23:36:02] <dr0ptp4kt>	 cc Deskana ^^^
[23:36:30] <grrrit-wm>	 (03PS1) 10Jdlrobson: Don't generate qunit test coverage on every commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179573 
[23:36:37] <grrrit-wm>	 (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov)
[23:37:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refine search logic a bit. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179529 (owner: 10Dbrant)
[23:47:38] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Fix up documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179572 
[23:55:41] <dr0ptp4kt>	 battery dying. talk to y'all later