[00:19:55] (03PS1) 10Jdlrobson: Hygiene: Document VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179577 [00:19:57] (03PS1) 10Jdlrobson: Hygiene: Documentation fixups - inherited methods and ignored methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179578 [00:27:22] (03CR) 10Bmansurov: [C: 032] Hygiene: Documentation fixups - inherited methods and ignored methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179578 (owner: 10Jdlrobson) [00:29:18] (03CR) 10Bmansurov: [C: 032] Hygiene: Document VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179577 (owner: 10Jdlrobson) [00:32:26] (03CR) 10Bmansurov: [C: 032] Hygiene: Fix up documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179572 (owner: 10Jdlrobson) [00:34:51] (03Merged) 10jenkins-bot: Hygiene: Fix up documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179572 (owner: 10Jdlrobson) [00:35:26] (03PS2) 10Jdlrobson: Don't generate qunit test coverage on every commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179573 [00:35:56] (03Merged) 10jenkins-bot: Hygiene: Document VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179577 (owner: 10Jdlrobson) [00:35:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Documentation fixups - inherited methods and ignored methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179578 (owner: 10Jdlrobson) [00:39:24] (03CR) 10Bmansurov: [C: 032] Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [00:40:55] (03CR) 10jenkins-bot: [V: 04-1] Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [00:43:18] (03PS2) 10Jdlrobson: Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 [00:43:26] (03CR) 10Bmansurov: [C: 032] Don't generate qunit test coverage on every commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179573 (owner: 10Jdlrobson) [00:43:28] (03CR) 10Jdlrobson: [C: 032] "try again jenkins!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [00:45:15] (03Merged) 10jenkins-bot: Don't generate qunit test coverage on every commit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179573 (owner: 10Jdlrobson) [00:46:02] (03PS1) 10Jdlrobson: Hygiene: Documentation for nearby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179580 [00:46:54] (03CR) 10jenkins-bot: [V: 04-1] Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [00:49:50] (03PS1) 10Jdlrobson: Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 [00:50:57] (03CR) 10Bmansurov: [C: 032] Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 (owner: 10Jdlrobson) [00:52:51] looks like jenkins is broken [00:52:56] probably have to leave it till monday :) [00:53:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 (owner: 10Jdlrobson) [00:55:26] (03CR) 10Bmansurov: [C: 032] Hygiene: Documentation for nearby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179580 (owner: 10Jdlrobson) [00:55:52] jenkins has gone to ferry friday [00:58:09] (03Merged) 10jenkins-bot: Hygiene: Documentation fixups - inherited methods and ignored methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179578 (owner: 10Jdlrobson) [01:00:32] (03PS9) 10Kaldari: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [01:02:21] (03CR) 10jenkins-bot: [V: 04-1] Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [01:03:32] (03PS10) 10Kaldari: Use user rights to check, if the user can edit page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [02:45:57] (03PS2) 10Yurik: Remove legacy Lua invocation, Allow impersonate= [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179401 [02:46:16] dr0ptp4kt, if you have a chance, pls +2 ^ [02:46:29] jeff would be very happy ) [02:47:23] (03PS3) 10Yurik: Remove legacy Lua invocation, Allow impersonate= [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179401 [02:50:31] (03CR) 10Dr0ptp4kt: [C: 032] Remove legacy Lua invocation, Allow impersonate= [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179401 (owner: 10Yurik) [02:50:42] thx [02:50:46] yurikR: yw [02:50:51] (03Merged) 10jenkins-bot: Remove legacy Lua invocation, Allow impersonate= [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/179401 (owner: 10Yurik) [06:06:05] 3MobileFrontend-stable, Mobile-Web, MobileFrontend-beta: "center" does not center non-thumb image on tablets - https://phabricator.wikimedia.org/T76945#845555 (10Edokter) I thought it was defined in core and filtered in mobile, but perhaps, it is just not defined in mobile (Minerva). [15:51:37] 3MediaWiki-extensions-GeoData, Wikipedia-App-Android-App: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#365099 (10Amire80) OK, so the {{#coordinates}} magic word was added today by the ever-excellent @eranroz, but I still don't see anything in the... [15:59:15] 3MediaWiki-extensions-GeoData, Wikipedia-App-Android-App: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#846043 (10eranroz) @Amire80 - I just fixed it now. there was typo in {{coord}} template in hewiki [17:39:50] 3MediaWiki-extensions-GeoData, Wikipedia-App-Android-App: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#846228 (10Krenair) Looks like the hewiki query returns no results now (instead of erroring) - but it works for other cities: https://he.wikipedi... [18:09:09] 3Wikipedia-App-Android-App: android.content.ActivityNotFoundException: No Activity found to handle Intent (WEB_SEARCH and CHOOSER) - https://phabricator.wikimedia.org/T72528#846245 (10Krenair) And https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8019356 [18:09:26] 3Wikipedia-App-Android-App: android.content.ActivityNotFoundException: No Activity found to handle Intent (WEB_SEARCH, CHOOSER and LOCATION_SOURCE_SETTINGS) - https://phabricator.wikimedia.org/T72528#846246 (10Krenair) [20:00:03] (03CR) 10Florianschmidtwelzow: "After i talked to Bartosz (MatmaRex) and tested it on mw.org, desktop doesn't have such a feature. As a not logged-in, blocked user you st" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [20:17:27] (03PS11) 10Florianschmidtwelzow: Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [20:22:52] 3MobileFrontend-beta, Mobile-Web: PHP error (undefined index) in MinervaTemplate.php - https://phabricator.wikimedia.org/T78480#846334 (10Florian) 3NEW a:3Florian [20:26:53] 3MobileFrontend-beta, Mobile-Web: PHP Notice (undefined index) in MinervaTemplate.php - https://phabricator.wikimedia.org/T78480#846344 (10Florian) [20:27:36] (03PS1) 10Florianschmidtwelzow: Add css class to donate button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 [20:42:24] 3MobileFrontend-stable: Watchstar making unnecessary API requested - https://phabricator.wikimedia.org/T78478#846349 (10Krenair) [20:42:30] FlorianSW, ^ [20:42:33] I think that is mobilefrontend [20:42:44] looks like it only occurs on the mobile site anyway... [20:50:16] Kreanir: i'll take a look [20:55:38] Kreanir: yes, it seems to be mobilefrontend :) [21:01:52] FlorianSW, you're still spelling my nickname wrong... [21:02:02] does your client not have autocomplete or something? [21:02:46] Krenair: it has, but i usually forget to use it, sorry :( [21:04:14] Tab <3 [21:05:28] (03PS1) 10Florianschmidtwelzow: Fix unneded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [21:07:01] FlorianSW, so you're adding a new function, but where is it called? [21:07:34] (03CR) 10jenkins-bot: [V: 04-1] Fix unneded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [21:07:57] Krenair: in Watchstar: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/watchstar/Watchstar.js#L53 [21:08:25] it should be a fallback, because options.isWatched is defined in init.js for watchstar: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/watchstar/init.js#L17 and taken from Page [21:08:51] but Page.isWatched isn't a method atm, so we do an api call, which is really unneeded [21:10:38] your patch adds a new getter for options.isWatched. the code you linked also checks options.isWatched. [21:10:47] I don't see how your patch helps? [21:12:21] (03PS2) 10Florianschmidtwelzow: Fix unneded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [21:13:41] FlorianSW, the second link you sent me shows it checking page.isWatched, which would be undefined, but your patch creates it as a function? [21:14:11] Krenair: correct :) Page comes from here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/watchstar/init.js#L23 [21:14:17] M.getCurrentPage comes from here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/application.js#L357 [21:14:29] isWatched is set here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/application.js#L384 [21:14:34] Krenair: ^ [21:18:46] FlorianSW, you need to turn page.isWatched in javascripts/modules/watchstar/init.js into a function call [21:19:31] at the moment you just reference the function [21:19:32] >> !!(function(){}) [21:19:32] Krenair: (boolean) true [21:20:03] so it always starts off thinking you're watching the current page [21:21:02] Krenair: oops, right [21:21:43] (03PS3) 10Florianschmidtwelzow: Fix unneded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [21:24:04] hmm, something doesn't work there.... *grr** [21:26:40] FlorianSW, yeah, take a look at loadCurrentPage in application.js [21:26:44] isWatched: $( '#ca-watch' ).hasClass( watchIcon.getGlyphClassName() ), [21:26:51] now, if the page is watched, class 'watched' is present [21:27:18] Krenair: it's because we use mw-ui-icon in alpha [21:27:29] but watchIcon.getGlyphClassName() returns icon-watched [21:27:38] getGlyphClassName will be mw-ui-icon-watched (but only watched in dom) [21:29:09] replacing that getGlyphClassName call with just 'watched' fixes it for me [21:29:29] I don't know enough about MobileFrontend to know if that's the 'correct' fix though [21:30:07] (03PS4) 10Florianschmidtwelzow: Fix unneded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634