[04:41:46] (03PS3) 10Legoktm: Convert API help for wikigrokresponse to use i18n [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179768 (owner: 10Sn1per) [04:45:06] (03CR) 10Legoktm: [C: 032] Convert API help for wikigrokresponse to use i18n [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179768 (owner: 10Sn1per) [04:45:35] (03Merged) 10jenkins-bot: Convert API help for wikigrokresponse to use i18n [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179768 (owner: 10Sn1per) [06:25:36] 3Wikipedia-App-Android-App: Left sidebar swipe out area seems to be bigger then the right one - https://phabricator.wikimedia.org/T78516#847283 (10Florian) 3NEW [06:32:38] (03PS2) 10Florianschmidtwelzow: Provide a possibility to suppress preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [06:33:13] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [06:34:05] (03PS4) 10Florianschmidtwelzow: Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 [06:49:31] (03CR) 10Florianschmidtwelzow: [C: 031] "+1 to kaldari's changes :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [06:59:04] (03PS12) 10Florianschmidtwelzow: Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [08:57:37] hi! [10:10:13] (03PS5) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [10:10:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [10:13:10] (03PS6) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [10:13:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [10:26:14] morning all [10:29:32] hey joakino_ [10:41:33] how was the weekend phuedx [10:41:40] not bad [10:41:42] tiring [10:41:48] went climbing yesterday [10:41:57] and now my upper body is /tired/ [10:41:59] how was yours? [10:42:22] cool! which level do you climb? [10:43:06] phuedx: i had a birthday barbecue in a friends house, they brought a bouncy castle :D [10:44:14] joakino_: 6A+ to 6B+ – the latter is a good day [10:44:22] on sunday we made homemade christmas pastries witht the family [10:44:24] cool weekend [10:44:36] phuedx: wow that's good 👍 [10:45:12] i've been around 6a+ for a while now though [10:45:19] because i'm not doing as much [10:45:35] i go twice a week at a push [10:46:22] phuedx: mountain? [10:47:21] indoor bouldering gym [10:47:45] aha [10:48:53] not many mountains in london ;) [10:49:15] one day, when we move outta london, i'll make sure that there's some outdoor bouldering problems nearby [10:49:53] not even by car? too far? [10:51:38] meh [10:51:40] driving [10:51:44] phuedx: my province is great for climbing, I have a few friends that are into it and there is thousands of paths to climb around here http://www.climb-europe.com/RockClimbingSpain/Costa-Blanca.html [10:52:00] no need to show off ;) [10:52:06] hehe [10:52:24] i've tried it out, it is very fun [10:55:58] i'm going to the atm, bbiab [12:11:16] (03CR) 10Jhernandez: [C: 032] "The icon problems i was seeing were because an outdated mediawiki core." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [12:13:43] (03CR) 10jenkins-bot: [V: 04-1] Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [12:15:26] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [12:22:24] (03CR) 10Jhernandez: [C: 032] Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov) [12:23:59] (03CR) 10jenkins-bot: [V: 04-1] Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov) [12:26:04] (03CR) 10Jhernandez: [C: 032] Hygiene: Documentation for nearby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179580 (owner: 10Jdlrobson) [12:27:16] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov) [12:28:39] (03Merged) 10jenkins-bot: Hygiene: Documentation for nearby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179580 (owner: 10Jdlrobson) [12:28:41] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 (owner: 10Jdlrobson) [12:37:03] (03CR) 10Jhernandez: [C: 031] "Kaldari & jdlrobson, so can we merge this now?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [12:38:47] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [12:38:57] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [12:51:49] (03CR) 10Florianschmidtwelzow: Hygiene: Documentation for nearby code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179580 (owner: 10Jdlrobson) [12:54:09] (03CR) 10Florianschmidtwelzow: Hygiene: Refactor wikiGrokCampaigns code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [14:30:20] (03CR) 10Dbrant: [C: 032] Change "Credit" to "Author" in the image viewer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179558 (owner: 10Deskana) [14:37:19] back from lunch [14:37:23] although i may need coffee soon [14:38:39] (03CR) 10Dbrant: [C: 032] Save ProGuard mapping files [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179569 (owner: 10BearND) [14:39:49] (03CR) 10Dbrant: [C: 032] Add releases folder to gitignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179570 (owner: 10BearND) [14:40:50] (03Merged) 10jenkins-bot: Add releases folder to gitignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179570 (owner: 10BearND) [14:52:38] (03CR) 10Dbrant: [C: 04-1] "See comment. Also, ideally we should hide the ToC entry for "read more" when there are no results... but that could get tricky, and it's o" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179792 (owner: 10Deskana) [15:04:17] (03PS1) 10Dbrant: Minor tweaks in collapsed infobox design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 [15:05:10] (03PS2) 10Dbrant: Minor tweaks in collapsed infobox design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 [15:15:26] gonna brew [15:28:16] hey jdlrobson [15:28:19] are you actually here?! [15:29:06] (03PS1) 10Dbrant: First round of design tweaks to the Gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179929 [15:53:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [16:10:34] (03PS1) 10Jdlrobson: Infoboxes: Expose images and wikidata urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179939 [16:10:42] phuedx: hey yeh [16:10:47] just in my morning routine [16:24:41] (03PS1) 10Dbrant: Minor tweaks of the Toolbar design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 [16:30:37] 3Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#848188 (10Amire80) Yeah, it works now. I wonder whether this should stay open though... the problem is real even if the communities can fix it. [16:34:25] (03PS1) 10Phuedx: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 [16:40:28] 3Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#848207 (10Amire80) 5Open>3declined a:3Amire80 And wondering a bit more, why does the app use the template that must be maintained in 289 l... [17:12:29] 3Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#848260 (10Krenair) The app does not care where the coordinates come from, it just queries the API. The API is provided by a MediaWiki extension. [17:13:02] 3Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#848262 (10Krenair) Also, you might want to see https://gerrit.wikimedia.org/r/165869/ for the Wikidata idea. [17:23:21] (03CR) 10BearND: [C: 04-1] "Hmm, I like the drop shadow you've added to the infoboxes in light theme. But it would be better if the content area had one, too." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 (owner: 10Dbrant) [17:24:00] 3Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: the nearby function doesn't work in some locales in the Android app - https://phabricator.wikimedia.org/T35704#848293 (10Nemo_bis) Weird, did he.wiki miss my [[https://fi.wikipedia.org/w/index.php?title=Keskustelu_mallineesta:Coord&diff=13315451&oldid=100... [17:25:59] 3Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: The nearby function doesn't work because of incomplete GeoData in some subdomains - https://phabricator.wikimedia.org/T35704#848298 (10Nemo_bis) 5declined>3Open a:5Amire80>3MaxSem [17:27:44] (03CR) 10Jhernandez: [C: 031] Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [17:29:19] (03PS2) 10Deskana: Don't display "Read more" section if there are no read more suggestions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179792 [17:30:55] dbrant: Now that we've got two classes handling content (LeadImagesHandler and BottomContentHandler) I was thinking about making an interface that they both implement that defines their behaviour a bit more formally [17:30:58] dbrant: e.g. right now they both have a hide() and beginLayout() [17:31:28] That way if we, say, ask a new engineer to add another as an onboarding task, they have a better idea about it [17:31:30] Thoughts? [17:31:44] 3Wikidata, Wikipedia-App-Android-App, MediaWiki-extensions-GeoData: GeoData should pull coordinates from Wikidata - https://phabricator.wikimedia.org/T35704#848322 (10Krenair) [17:31:48] (they should probably also have show(), and maybe hideContent() and showContent()) [17:33:37] Deskana: maybe... But do we foresee adding another one? (where would it go?) [17:34:07] (03CR) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [17:34:42] dbrant: I have no idea at this stage. :) [17:35:10] (03PS7) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 [17:35:56] (03CR) 10BearND: [C: 032] First round of design tweaks to the Gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179929 (owner: 10Dbrant) [17:36:01] Maybe I'll do it later and you can -2 at will without offending me ;-) [17:36:11] Deskana: both the top and bottom components are quite hacky (that's all they *can* be at this point). Formalizing them any further would just be formalizing a hack. [17:36:18] (03Merged) 10jenkins-bot: First round of design tweaks to the Gallery view. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179929 (owner: 10Dbrant) [17:36:22] joakino_: hey, can you re +2 this one: https://gerrit.wikimedia.org/r/#/c/179364/ thanks [17:36:45] Deskana: but feel free! I'm all for better code. [17:36:51] bmansurov: damn jenkins [17:37:02] i'll try again [17:37:12] ;) [17:37:22] thanks [17:38:50] (03CR) 10Jhernandez: "JENKINS TO ME!! ✞⚛✇" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov) [17:39:15] wit [17:39:58] *wut [17:42:08] Deskana: trying to summon jenkins, doesn't seem to be working [17:43:08] joakino_: Does changing to CR 0 then back to +2 work? [17:43:23] Maybe Jenkins is stupid. [17:44:19] Deskana: oh didnt think of that incantation, i'm gonna try that [17:44:37] joakino_: we may need to wait a little, jenkins may be busy [17:45:24] bmansurov: also that [17:48:13] (03CR) 10Jhernandez: [C: 031] Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [17:48:15] joakino_, hmm.. is recheck supposed to make it merge? [17:48:37] maybe it has to be +2'd again? [17:48:37] Krenair: i would have thought so, it was already +2ed [17:49:07] Krenair: that's my next step, change to 0 and then +2, since re+2ing doesn't seem to do anything [17:49:24] I don't think it goes back through old comments :) [17:49:26] or check for old +2s, even [17:50:12] Krenair: the thing is I don't remember having to re+2 when after a recheck it verifies properly, idk :\ [17:50:35] everyday a new adventure [17:50:44] (03CR) 10BearND: [C: 04-1] "On My 5.0 Nexus 4, I get the search hint text move down once I click on the search area (and don't have any recent search terms to display" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 (owner: 10Dbrant) [17:59:03] (03PS2) 10Jdlrobson: Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 [17:59:03] (03CR) 10Jdlrobson: [C: 032] Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 (owner: 10Jdlrobson) [17:59:08] (03CR) 10Jdlrobson: [C: 032] Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov) [17:59:50] (03PS3) 10Jdlrobson: Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 [17:59:59] (03CR) 10Jdlrobson: Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [18:00:02] (03CR) 10Jdlrobson: [C: 032] Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [18:01:33] (03CR) 10Jdlrobson: [C: 04-1] Fix unneded Watched api call (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [18:02:44] (03PS1) 10BearND: Hide system and navigation bars in GalleryActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179963 [18:02:46] (03PS1) 10BearND: Stop making gallery view info labels bold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179964 [18:03:17] (03CR) 10jenkins-bot: [V: 04-1] Hide system and navigation bars in GalleryActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179963 (owner: 10BearND) [18:03:17] (03CR) 10jenkins-bot: [V: 04-1] Stop making gallery view info labels bold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179964 (owner: 10BearND) [18:05:10] (03Merged) 10jenkins-bot: Hygiene: inheritdoc for AbuseFilterPanel methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179583 (owner: 10Jdlrobson) [18:06:22] (03PS2) 10BearND: Hide system and navigation bars in GalleryActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179963 [18:06:23] (03PS2) 10BearND: Stop making gallery view info labels bold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179964 [18:07:53] (03Merged) 10jenkins-bot: Make sure a campaign exists before rendering WikiGrokDialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179364 (owner: 10Bmansurov) [18:07:59] (03Merged) 10jenkins-bot: Do not show donate button when enabled on special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179204 (owner: 10Jdlrobson) [18:10:13] RIP mobile web standup hangout [18:10:18] Our love was short lived [18:11:20] I can't seem to rejoin [18:12:53] It's alive! [18:13:57] (03PS1) 10BearND: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/179966 [18:18:20] jdlrobson: kaldari sorry guys I had to answer that [18:18:31] have I missed anything important? [18:19:38] rmoen: So there's a longish email thread about table restyling you'll want to read through. We ended up with 2 action items: Redo base table styling in beta (https://gerrit.wikimedia.org/r/#/c/178438/) and apply Monte's styles only to infoboxes and wikitable tables... [18:19:38] (03PS7) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:20:08] rmoen: and #2 investigate how Wikiwand handles table styling (https://trello.com/c/9rlwYr0Z/49-spike-how-does-wikiwand-s-infobox-styling-differ-from-ours) [18:20:19] joakino: nothing too important [18:20:52] rmoen: If you want to take over the first one, that would be fine with me. [18:21:14] http://hatjitsu.wmflabs.org/64556 [18:22:08] 3MobileFrontend-alpha: Mysterious JS exception - https://phabricator.wikimedia.org/T78340#848405 (10Florian) 5Open>3Resolved a:3Florian [18:25:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [18:28:09] 3Wikipedia-App-Android-App: NoClassDefFoundError: android.support.v7.internal.view.menu.MenuBuilder - https://phabricator.wikimedia.org/T78197#848440 (10bearND) 5Open>3Resolved a:3bearND [18:32:15] dbrant, bearND: I'm really sorry about this whole kerfuffle with the beta release. :-( [18:33:02] dbrant, bearND: At least it's moving forwards; I have a meeting with Erik and Comms this afternoon at 2pm. When that's done, we should be able to move forwards. [18:33:09] (03PS8) 10MaxSem: WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 [18:33:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: recording and applying user responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem) [18:34:11] Deskana: the stand-up chromebox looped your “see you guys soon” 4 times :) [18:34:17] mhurd: Haha [18:34:31] Deskana: it was pretty great [18:34:52] Deskana: probably should change the priority of the PhabTasks we triaged today to be not "needs triage" anymore when you create the cards [18:35:11] bearND: Yeah, I couldn't do that as we were going because I forgot my password to Phabricator. I've got them all open here and I'm going to fix it up, then head to the office. [18:35:21] Deskana: good [18:36:05] Eugh, Phabricator won't let me log in. [18:36:35] Deskana: first wikidata descrip via ios app: http://www.wikidata.org/wiki/Q2045923 [18:37:39] Deskana: bearND: so wait, are we in fact doing a production release this week? [18:37:57] dbrant, bearND: Our previous beta release can go to stable [18:38:16] And lead images and image viewer can go to beta (after I finish this thing with comms) [18:38:38] Deskana: nooo, too many crashes on beta already [18:39:07] 3Wikipedia-App-Android-App: find in page nearly unusable in landscape orientation - https://phabricator.wikimedia.org/T78244#848491 (10Deskana) 5Open>3stalled This is a native control that it'll be a bit tricky for us to override, so we can't prioritise it right now [18:39:20] Deskana: we need to have at least the crash fixes in a new beta, and hide what you don't want [18:39:33] Deskana: ^ agreed with bearND. [18:39:52] * Deskana slams his gavel [18:39:56] Deskana: dbrant: If I multiply the beta crashes of the last week we got by 100 = horror [18:40:03] There shall be no production release! [18:40:09] hehe [18:40:22] So we can proceed with pushing lead images to beta and leave it at that [18:42:58] 3Wikipedia-App-Android-App: overlapping lines under the globe logo in the Android login screen - https://phabricator.wikimedia.org/T78350#848498 (10Deskana) Tracked here: https://trello.com/c/EITZ0HD4/26-increase-space-between-wikipedia-and-the-free-encyclopedia-in-onboarding-by-a-few-dps-to-avoid-an-issue-with-... [18:43:05] 3Wikipedia-App-Android-App: overlapping lines under the globe logo in the Android login screen - https://phabricator.wikimedia.org/T78350#848499 (10Deskana) p:5Triage>3Normal [18:47:30] mhurd: That's sweet! [18:47:57] mhurd: You'll have to show me it when I get to the office. [18:48:18] mhurd, hey [18:48:22] Deskana: heading in later today? [18:48:26] Krenair: hey [18:48:33] 3Wikipedia-App-Android-App: suboptimal scrollbar in image description on Android - https://phabricator.wikimedia.org/T78347#848529 (10Deskana) Dmitry thinks he can put something in place quickly to fix some of this; it might not put the scroll bar in the right place for now, but it should at least make it not ov... [18:48:36] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179971 [18:48:39] mhurd, I took a look into the issue you brought up with coordinate precision... [18:48:48] Krenair: woohoo! thanks! [18:48:57] Krenair: easy fix? [18:49:05] 3Wikipedia-App-Android-App: suboptimal scrollbar in image description on Android - https://phabricator.wikimedia.org/T78347#848530 (10Deskana) p:5Triage>3Normal Tracked here: https://trello.com/c/Yi1eGl68/27-suboptimal-scrollbar-in-image-description-on-android [18:50:01] mhurd, well I was testing on mysql, but wmf production uses a different backend (elastic) [18:50:33] 3Wikipedia-App-Android-App: NPE crash from leadimages.LeadImagesHandler.beginLayout - https://phabricator.wikimedia.org/T78501#848535 (10Deskana) p:5Triage>3Normal Dmitry will take a look at this. [18:50:39] it looked to me like the data was getting to $db->insert fine, but then losing some digits [18:51:00] 3Wikipedia-App-Android-App: NPE crash from leadimages.LeadImagesHandler.beginLayout - https://phabricator.wikimedia.org/T78501#848539 (10Deskana) Tracked here: https://trello.com/c/nVgczDJZ/28-npe-crash-from-leadimages-leadimageshandler-beginlayout [18:51:07] mhurd, so... probably not? [18:51:24] 3Wikipedia-App-Android-App: Left sidebar swipe out area seems to be bigger then the right one - https://phabricator.wikimedia.org/T78516#848548 (10Deskana) 5Open>3Resolved a:3Deskana We think we've fixed this in a patch that was merged after we did the release that this user is using. [18:52:20] Krenair: hehe need more digits! :) [18:55:24] Deskana: about https://phabricator.wikimedia.org/T78516 Is this patch in the beta release or do you have a plan when it will be released? :) [18:56:02] Ask dbrant|food and bearND, they're the ones tha ttold me that. :) [18:56:30] mhurd, https://gist.github.com/Krenair/296b1b438b48257545a4 [18:57:09] FlorianSW: Deskana: the patch was merged after the last beta release [18:57:55] bearND: ah, ok, then i think it will be available with one of the next releases :) Thanks! [18:58:16] (03PS1) 10BearND: Fix test compilation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179973 [18:58:33] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179971 (owner: 10BearND) [18:58:55] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179971 (owner: 10BearND) [19:02:29] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix unneded Watched api call (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [19:03:33] joakino: what happened? [19:03:43] we finished early!! [19:04:18] phuedx: the card you left was the last one i think, with a 13 [19:04:22] stupid internet connection [19:04:57] phuedx: happens in the best homes [19:05:30] Krenair: hmm does that mean the update statement is where the precison loss is happening? [19:05:55] yeah, probably [19:06:06] obviously the same effect would happen with insert [19:06:29] but as I said, WMF production is using elastic instead of mysql. I don't know what that changes [19:06:32] right, i'm off for the night [19:06:42] mainly to phone my isp [19:06:45] * phuedx grumbles [19:06:47] (03CR) 10Jdlrobson: [C: 04-1] Add css class to donate button (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [19:06:54] Krenair: any options / next steps come to mind? [19:07:02] no ideas [19:07:10] (03PS7) 10Jdlrobson: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 [19:07:18] (03CR) 10Jdlrobson: [C: 032] Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [19:07:40] Krenair: no worries - thanks for looking in to it :) [19:09:37] phuedx: can you explain to me how jquery.client works? [19:09:46] oh shoot saw you are gone for night [19:10:55] (03PS5) 10Florianschmidtwelzow: Fix unneded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [19:11:22] (03CR) 10Bmansurov: Give a better error message for blocked users trying to edit (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [19:11:31] (03Merged) 10jenkins-bot: Alpha experiment: Replace search bar with branding and icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177952 (owner: 10Jdlrobson) [19:11:48] (03PS6) 10Jdlrobson: Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [19:12:58] (03PS2) 10Florianschmidtwelzow: Add css class to donate button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 [19:13:31] (03CR) 10Jdlrobson: [C: 031] "Can someone check out and verify it works and +2 ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [19:14:36] (03CR) 10jenkins-bot: [V: 04-1] Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [19:15:15] (03CR) 10Florianschmidtwelzow: Give a better error message for blocked users trying to edit (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [19:16:45] (03PS13) 10Florianschmidtwelzow: Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [19:17:50] (03PS2) 10Jdlrobson: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [19:19:19] (03CR) 10Bmansurov: [C: 04-1] "The files in the screenshot should be updated too: http://imgur.com/9SneohH" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [19:22:35] (03CR) 10Jdlrobson: [C: 04-1] "In theory this should work but I'm not seeing it work on the Droid Razr Android 2.3" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [19:26:57] jdlrobson: i noticed https://phabricator.wikimedia.org/T78559 and wonder how mw.template works for non-js? [19:27:11] is there some documentation i can look at or is it not implemented yet? [19:28:33] (03CR) 10Bmansurov: [C: 032] Infoboxes: Expose images and wikidata urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179939 (owner: 10Jdlrobson) [19:29:07] (03CR) 10Kaldari: [C: 04-1] Hygiene: Refactor wikiGrokCampaigns code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [19:30:33] (03CR) 10Kaldari: Hygiene: Refactor wikiGrokCampaigns code (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [19:30:59] (03PS3) 10Florianschmidtwelzow: Provide a possibility to suppress preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [19:31:52] rmoen: Did you get my IRC messages about the table border stuff? [19:32:52] (03PS7) 10Florianschmidtwelzow: Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [19:35:06] (03PS8) 10Bmansurov: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 [19:45:28] 3MobileFrontend-Feature-requests: Indicators are not shown in mobile view - https://phabricator.wikimedia.org/T75299#848663 (10Jdlrobson) I would say no value comes out of doing this work our end unless they become widely adopted (as this will mean we can kill some of the css rules in hacks.less relating to gett... [19:51:07] kaldari: sorry, yes I did. [19:51:43] (03CR) 10Bmansurov: [C: 04-1] "The words suppress is misspelled." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [19:53:53] (03PS1) 10Mhurd: Made Nearby use UICollectionView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/179978 [19:54:06] (03PS1) 10Mhurd: Moved angle/distance calc into Nearby controller. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/179979 [19:55:30] (03CR) 10Bmansurov: [C: 031] Add css class to donate button (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [19:55:46] rmoen: are you interested in working on it further? I'm happy to take over that card if you're interested in working on other things. [19:55:55] brion: ^ these shouldn’t clash too much with your refinements… [19:56:47] spiff [19:57:12] whoa the rain finally started coming down like in the last 30 seconds [19:58:08] brion: i learned so much about uicollectionviews :) much fanciness is going to be possible [19:58:26] (03CR) 10Florianschmidtwelzow: Add css class to donate button (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [19:58:45] :D awesome [19:59:53] kaldari: happy to pass the torch on that. I've been keeping up on the thread but would like to do other things [20:00:14] rmoen: Sounds good to me [20:00:22] I'll take you off the card then [20:00:45] (03PS4) 10Florianschmidtwelzow: Provide a possibility to suppress preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [20:02:28] (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to suppress preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [20:02:30] (03CR) 10Jdlrobson: [C: 04-1] "Please can we get a designers opinion on this. I'd rather keep with the status quo then make a noticeable design change." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 (owner: 10Florianschmidtwelzow) [20:04:04] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169586 (owner: 10Hashar) [20:04:10] (03CR) 10Hashar: "check experimental" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169586 (owner: 10Hashar) [20:06:51] (03CR) 10Florianschmidtwelzow: "sure! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 (owner: 10Florianschmidtwelzow) [20:06:52] Deskana|Away: joining us? [20:07:46] Deskana|Away: would be really good to hear about your work with Fouad [20:10:39] (03CR) 10Jdlrobson: [C: 032] "Doesn't seem to break animations on notification drawer which introduced it so looks fine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [20:10:53] 3Mobile-Web, MobileFrontend-beta: Talk overlay conflicts with OverlayManager hide delay - https://phabricator.wikimedia.org/T66105#848762 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [20:11:16] 3Mobile-Web, MobileFrontend-stable: Remove display:block from CtaDrawer - https://phabricator.wikimedia.org/T78586#848765 (10Florian) 3NEW a:3Florian [20:11:20] (03PS2) 10Jdlrobson: Infoboxes: Expose images and wikidata urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179939 [20:11:26] (03CR) 10Jdlrobson: [C: 032] Infoboxes: Expose images and wikidata urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179939 (owner: 10Jdlrobson) [20:11:29] (03PS5) 10Florianschmidtwelzow: Hygiene: Remove anchor links from ctaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 [20:13:45] (03CR) 10jenkins-bot: [V: 04-1] Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [20:13:53] 3Mobile-Web, MobileFrontend-stable: Remove display:block from CtaDrawer - https://phabricator.wikimedia.org/T78586#848776 (10Florian) Result of change https://gerrit.wikimedia.org/r/#/c/173283/ {F21312} -> {F21314} What say #design ? :) [20:15:34] * FlorianSW loves Jenkins! :D [20:15:52] (03CR) 10Kaldari: [C: 032] Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [20:17:06] jdlrobson: do you know something about https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/8100/console ? [20:17:10] (03Merged) 10jenkins-bot: Infoboxes: Expose images and wikidata urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179939 (owner: 10Jdlrobson) [20:17:58] FlorianSW: it sounds like an issue that Krinkle or hashar might know the answer to. java.io.IOException: request to write '2315' bytes exceeds size in header of '2262' bytes for entry 'log/mw-debug-www.log' [20:18:06] sounds like an issue with the server running jenkins [20:18:07] (03PS5) 10Florianschmidtwelzow: Provide a possibility to suppress preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [20:18:13] maybe create phabricator bg? [20:18:46] (03Merged) 10jenkins-bot: Hygiene: Refactor wikiGrokCampaigns code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177413 (owner: 10Bmansurov) [20:18:48] jdlrobson: i have seen this error on other changes, to , in the last time :/ [20:19:06] maybe really a phab bug [20:24:40] jdlrobson: https://phabricator.wikimedia.org/T78590 [20:45:29] (03PS1) 10Kaldari: Make sure campaign data isn't set to false [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/179985 [20:47:07] (03CR) 10Dbrant: [C: 04-1] "If I touch the image while in full-screen mode, the controls come back, and the touch event is consumed. (it becomes impossible to pan or" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179963 (owner: 10BearND) [20:49:52] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/169586 (owner: 10Hashar) [21:09:51] heading out for today [21:09:55] have a nice day [21:13:57] (03PS3) 10BearND: Stop making gallery view info labels bold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179964 [21:14:52] (03CR) 10BearND: "removed Gerrit dependency to previous patch since that one may take a bit longer to get right." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179964 (owner: 10BearND) [21:21:13] lunchtimes [21:25:52] cheers FlorianSW! [21:32:44] jdlrobson: Did I miss anything at the showcase? [21:41:31] cheers jdlrobson :) [21:46:20] Deskana, are you around? [21:46:36] Ellery and I wanted to chat about Apps with you. :-) [21:48:08] (03CR) 10Jdlrobson: [C: 032] Add css class to donate button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [21:48:18] (03PS5) 10Jdlrobson: Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [21:49:22] (03PS3) 10Florianschmidtwelzow: Fix php notice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 [21:50:23] jdlrobson: sry for interrupt the merge process ^ but the commi message title was misleading [21:54:10] (03CR) 10Jdlrobson: [C: 04-1] "Go to a page that is watched." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [21:57:52] (03CR) 10Bmansurov: [C: 031] "It's working fine for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [21:59:18] leila: Hey! I'm about to go in to a meeting. [22:02:22] (03CR) 10Bmansurov: [C: 031] "Just a couple of typos. Other than that it looks good." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [22:08:44] (03CR) 10Jdlrobson: [C: 04-1] "Consider splitting this into 2 patches - 1 moving anonymous editing to a generic config variable and 2nd introducing this config option." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [22:09:08] MaxSem: https://gerrit.wikimedia.org/r/#/c/179766/ [22:09:31] jdlrobson: https://gerrit.wikimedia.org/r/178381 when you get a chance. [22:10:04] (03CR) 10Jdlrobson: [C: 031] "haven't tested" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [22:10:26] bmansurov: you got 2 ;-) i'm looking at phuedx patch now [22:11:12] but bmansurov i get a whole list of zeroes [22:11:16] seems to be something wrong with union [22:11:22] k [22:11:23] if you run the 2nd part i get results. the 1st none [22:11:49] switched to feed is coming out as 0 to me [22:13:36] jdlrobson, ohohoh [22:13:49] (03CR) 10MaxSem: [C: 032] useFileCache hook must be prefixed with the correct class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179766 (owner: 10Nic Jansma) [22:16:04] (03Merged) 10jenkins-bot: useFileCache hook must be prefixed with the correct class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179766 (owner: 10Nic Jansma) [22:23:34] (03PS1) 10Jdlrobson: Hygiene: Correct dependencies for category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180024 [22:29:29] (03CR) 10Jdlrobson: Fix php notice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [22:29:33] (03CR) 10Jdlrobson: [C: 032] Fix php notice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [22:30:05] (03CR) 10Jdlrobson: [C: 032] Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [22:34:32] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Correct dependencies for category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180024 (owner: 10Jdlrobson) [22:35:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Correct dependencies for category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180024 (owner: 10Jdlrobson) [22:38:15] (03Merged) 10jenkins-bot: Fix php notice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179632 (owner: 10Florianschmidtwelzow) [22:39:33] (03PS8) 10Kaldari: Redoing how mobile handles tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 [22:41:17] dbrant|food, bearND: Here's the story; we'll push lead images and image viewer to beta on Wednesday. [22:41:20] (03PS3) 10Jdlrobson: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 [22:41:22] dbrant|food, bearND: It's official. [22:41:27] (03PS9) 10Jdlrobson: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [22:41:37] (03PS4) 10Jdlrobson: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 [22:42:04] \o/ [22:42:39] Deskana: and when do we have the next production release? [22:45:05] (03CR) 10Jdlrobson: Put description below title (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [22:45:24] (03PS5) 10Jdlrobson: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 [22:48:30] (03PS1) 10Jdlrobson: Hide hat notes on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180028 [22:53:44] YuviPanda: Didn't you get me access to Hive ages ago? [22:53:49] YuviPanda: Can you tell me how to access it? [22:54:04] Deskana: step 1 is to join #wikimedia-research and #wikimedia-analytics, but you’re already there :) [22:54:07] Deskana: let me find step2 [22:54:24] (03PS6) 10Jdlrobson: Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [22:54:32] (03CR) 10Jdlrobson: [C: 031] Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [22:54:39] (03CR) 10Jdlrobson: [C: 032] Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [22:55:34] Deskana: https://wikitech.wikimedia.org/wiki/Analytics/Cluster/Hive [22:55:45] Deskana: and all the subpages thereof, like https://wikitech.wikimedia.org/wiki/Analytics/Cluster/Hive/Queries [22:55:47] Deskana: it’s on stat1002 [22:55:48] (03CR) 10Jdlrobson: [C: 031] "@MaxSem does this look sane to you?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [22:56:02] YuviPanda: I'm trying to figure out how to ssh in. [22:56:45] Deskana: hmm, how do you to stat1003? [22:56:54] YuviPanda: I use SequelPro :P [22:57:01] MaxSem: You're probably the only other person who knows enough about permissions to review this: https://gerrit.wikimedia.org/r/#/c/178793/ (The changeset was originally by Florian, but I rewrote it, so can't merge). It has tests, so mostly just needs a sanity check on the permissions logic. [22:57:05] (03Merged) 10jenkins-bot: Remove waiting when close Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177870 (owner: 10Florianschmidtwelzow) [22:57:14] Deskana: ah, heh :) [22:57:24] sanity? from me? :P [22:57:29] NEVAR [22:57:35] Deskana: ssh-add, then ssh -A bast1001.wikimedia.org, and then ssh stat1002? [22:57:42] Deskana: *or* you could setup proxycommand, much more secure [22:57:48] 3MobileFrontend-beta, Mobile-Web: PHP Notice (undefined index) in MinervaTemplate.php - https://phabricator.wikimedia.org/T78480#849447 (10Jdlrobson) 5Open>3Resolved [22:57:59] 3Mobile-Web, MobileFrontend-stable: Watchstar making unnecessary API requested - https://phabricator.wikimedia.org/T78478#849458 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson [22:58:35] Deskana: also remember hive is a bit more… involved than SQL :) you can bring down the hive cluster with one well placed query :) [22:59:41] (03PS1) 10Yurik: Enables zero-config editing functionality [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180029 [22:59:52] YuviPanda: Huh, I guess I don't. Okay. :P [23:00:10] Deskana: guess you don’t what? [23:00:16] i checked, you *do* have stat1002 access :) [23:00:28] YuviPanda: It's not working now, and I don't have the time to figure out why. We'll figure it out later. :) [23:00:32] For now, I have work to do! [23:00:36] Deskana: heh, ok! [23:00:51] 3Wikidata, MobileFrontend-Feature-requests: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#849469 (10Jdlrobson) [23:04:11] dr0ptp4kt, jhobs could you take a look at the edit patch pls [23:04:22] dr0ptp4kt, looking at your patches [23:12:03] 3Mobile-Web, MobileFrontend-beta: Can't scroll in edit mode - https://phabricator.wikimedia.org/T75255#849495 (10Jdlrobson) Is this fixed or still presenting itself as a problem? [23:12:34] (03CR) 10Kaldari: [C: 04-1] "Lots of minor issues, but I guess it's a good start." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [23:15:04] bearND: joining now [23:16:17] jdlrobson: hey, howie is looking for you [23:16:22] tfinc: i'm already there, but I don't see you yet [23:16:33] (03PS10) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [23:16:50] tfinc: where is he? [23:17:12] i didn't get a calendar invite from other jon [23:18:00] (03PS11) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [23:18:28] jdlrobson: their in avicenna [23:18:50] tfinc: what room is avicenna? 6th flor [23:18:51] ? [23:19:03] jdlrobson: r61 [23:19:14] kaldari, we haz stuff to swat? [23:19:23] thx! [23:19:37] MaxSem: Don't think so. It's a miracle! [23:19:51] well, not really: https://gerrit.wikimedia.org/r/179513 :P [23:20:51] MaxSem: although we may want to SWAT https://gerrit.wikimedia.org/r/#/c/178793/ after it's merged [23:21:09] ah yeah, was reviewing it [23:21:25] MaxSem: although apparently it's been broken for a while, so it's not really an emergency [23:22:39] MaxSem: comparing our new code against Title:checkPageRestrictions() will probably shed some light on it [23:23:05] why the hell reproduce PHP in JS then? [23:25:56] (03CR) 10Kaldari: [C: 04-1] Make sure page images get shown on next page of watchlist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [23:34:55] (03PS12) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [23:38:14] bearND: That'll be in January, right? [23:38:38] bearND: Dmitry will be off for the entire holiday period, so I don't think doing a release while he's out is feasible. [23:38:51] bearND: Or, were you looking for me to be a bit more specific? [23:38:54] :) [23:41:40] (03CR) 10Yurik: [C: 032] Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/179357 (owner: 10Dr0ptp4kt) [23:46:50] (03Merged) 10jenkins-bot: Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/179357 (owner: 10Dr0ptp4kt) [23:49:42] (03PS8) 10Jdlrobson: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 [23:52:52] Deskana: I agree with January. The question is really can we do it early or mid January? End of the month there always seems to be something else going on. Holidays, big meetings, etc. [23:53:12] Deskana: I think having two windows per month would be better. [23:53:33] Comms wants us to do it on the 15th. Given that the first week of working January begins on the 5th, that seems sensible to me. [23:53:36] Deskana: or if that's not possible something more mid-month [23:57:22] (03CR) 10Jdlrobson: [C: 04-1] Redoing how mobile handles tables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari) [23:58:52] (03PS2) 10Jdlrobson: Hygiene: Correct dependencies for category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180024 [23:59:30] (03Abandoned) 10Jdlrobson: Hygiene: Correct dependencies for category overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180024 (owner: 10Jdlrobson)