[00:00:06] kaldari: https://gerrit.wikimedia.org/r/#/c/179347/3 is blocking stuff [00:05:36] 3Wikidata, MobileFrontend-Feature-requests: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#849606 (10LtPowers) >>! In T77925#848657, @Jdlrobson wrote: > @Matroc It seems that the Wikidata property is misleading then, I had imagined all projects would be sharing the same value. It might... [00:16:42] $wgMFNamespacesWithoutCollapsibleSections = array( NS_MAIN ) [00:16:46] ^ MaxSem [00:17:30] jdlrobson, https://gerrit.wikimedia.org/r/179513 [00:19:40] yurikR, also - why is the nominated change to master? [00:20:09] MaxSem, how do you mean? [00:20:30] please backport to release branches [00:21:56] MaxSem, feel free to simply sync with master [00:22:07] nah, we don't do that [00:22:10] i don't think anything else has changes [00:22:12] changed [00:22:14] sigh [00:23:22] also, you tricked e to merge a master change without reviewing:P [00:23:42] MaxSem: My wiki doesn't have a block table. Are you sure that's where it's recorded? [00:24:14] (03PS1) 10Yurik: Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180088 [00:24:38] (03PS1) 10Yurik: Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/180089 [00:24:46] MaxSem, ^? [00:25:01] (03CR) 10Yurik: [C: 032] Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/180089 (owner: 10Yurik) [00:25:20] (03CR) 10Yurik: [C: 032] Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180088 (owner: 10Yurik) [00:25:50] MaxSem, when? [00:26:10] when what? [00:27:38] MaxSem, when did i trick you?? [00:28:04] by putting a master change on deployments page [00:28:34] so while it was merged, it wasn't really reviewed because I didn't notice it's master [00:29:01] MaxSem, i just cherrypicked it to 11 & 12 [00:29:04] ^^ [00:31:00] (03CR) 10Dr0ptp4kt: [C: 031] "We'll need to actually verify this on appropriate WIP Portal once deployed. Per Yuri, this is working." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180029 (owner: 10Yurik) [00:31:11] ^ yurikR [00:32:09] (03CR) 10Dr0ptp4kt: [C: 032] "To be verified against WIP portal." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180029 (owner: 10Yurik) [00:35:46] (03Merged) 10jenkins-bot: Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] (wmf/1.25wmf11) - 10https://gerrit.wikimedia.org/r/180089 (owner: 10Yurik) [00:35:47] (03Merged) 10jenkins-bot: Redirect zerodot wikipedia webroot to mdot if OK [extensions/ZeroBanner] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/180088 (owner: 10Yurik) [00:35:50] (03Merged) 10jenkins-bot: Enables zero-config editing functionality [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180029 (owner: 10Yurik) [00:44:18] (03CR) 10Kaldari: [C: 04-1] Give a better error message for blocked users trying to edit (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [00:46:55] (03PS1) 10Jdlrobson: Hygiene: Document methods in uploads folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180095 [00:50:45] (03CR) 10Kaldari: [C: 04-1] "Doesn't seem to be saving changes now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [00:54:11] (03CR) 10Jdlrobson: [C: 04-1] Use user rights to check, if the user can edit page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [00:58:11] 3Wikidata, MobileFrontend-Feature-requests: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#849751 (10Nicolas_Raoul) @Jdlrobson: The goal of Wikidata banners is to share banners between all Wikivoyage projects. This is the huge benefit that prompted us to use Wikidata for banners. Except... [01:08:53] (03PS2) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [01:10:50] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [01:13:59] (03PS3) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [01:15:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [01:15:40] (03PS1) 10Robmoen: Add WikiGrok response badges in Alpha for version b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 [01:17:04] (03CR) 10Robmoen: [C: 04-1] "Need to optimize svgs" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [01:18:10] (03CR) 10Dbrant: [C: 032] Fix test compilation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179973 (owner: 10BearND) [01:18:41] (03CR) 10Dbrant: [C: 032] Stop making gallery view info labels bold [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179964 (owner: 10BearND) [01:20:19] (03CR) 10Bmansurov: [C: 032] Hygiene: Document methods in uploads folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180095 (owner: 10Jdlrobson) [01:21:03] (03PS1) 10Dbrant: Enable lead images in Beta. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180105 [01:21:41] (03PS4) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [01:22:10] (03PS5) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [01:27:19] (03PS2) 10Robmoen: Add WikiGrok response badges in Alpha for version b [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 [01:27:27] (03Merged) 10jenkins-bot: Hygiene: Document methods in uploads folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180095 (owner: 10Jdlrobson) [01:29:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [01:35:11] kaldari: any chance of a +2 on https://gerrit.wikimedia.org/r/#/c/179347/ ? [01:42:49] (03CR) 10Kaldari: [C: 04-1] Hygiene: Refactor secondary actions generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [01:53:39] (03CR) 10Kaldari: Redoing how mobile handles tables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178438 (owner: 10Kaldari) [01:54:50] (03CR) 10Kaldari: [C: 04-1] Hide hat notes on mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180028 (owner: 10Jdlrobson) [01:57:52] (03CR) 10Kaldari: [C: 032] Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [01:58:51] (03PS13) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [02:00:37] (03Merged) 10jenkins-bot: Make sure page images get shown on next page of watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177939 (owner: 10Jdlrobson) [02:02:04] (03PS14) 10Jdlrobson: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 [02:04:27] (03CR) 10Kaldari: [C: 032] Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [02:06:05] (03Merged) 10jenkins-bot: Minerva friendly version of Special:Preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178756 (owner: 10Jdlrobson) [02:10:25] (03PS4) 10Jdlrobson: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 [02:11:14] (03PS2) 10Jdlrobson: Hide hat notes on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180028 [02:12:07] (03PS3) 10Jdlrobson: Hide hat notes on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180028 [02:14:34] (03CR) 10Jdlrobson: [C: 04-1] "jenkins issues" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [02:15:51] (03CR) 10Jdlrobson: "WikiGrok Roulette != WikiGrok version B." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [02:18:54] (03CR) 10Jdlrobson: WIP: Alpha: WikiGrok in sidebar (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [02:23:31] https://gerrit.wikimedia.org/r/179347 [02:23:34] ^ MaxSem [02:23:59] (03CR) 10Jdlrobson: [C: 04-1] "(see above comment)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [02:31:50] (03PS5) 10Jdlrobson: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 [06:50:36] (03PS1) 10Florianschmidtwelzow: Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 [06:50:54] (03PS6) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [06:52:13] (03CR) 10Florianschmidtwelzow: "> Also not sure about the surpressPreview variable name." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [06:53:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [06:54:27] (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [06:59:25] (03PS2) 10Florianschmidtwelzow: Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 [07:00:58] (03PS7) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [07:01:22] (03PS14) 10Florianschmidtwelzow: Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 [07:03:02] (03CR) 10jenkins-bot: [V: 04-1] Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [07:14:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Refactor secondary actions generation (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [07:29:55] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> Uncaught TypeError: Cannot read property 'indexOf' of undefined" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [07:40:01] (03PS8) 10Florianschmidtwelzow: Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [09:22:15] morning! [09:34:22] morning joakino [09:34:42] hi phuedx [09:36:09] hey phuedx do you use trello usually? [09:36:21] for wmf stuff or for other things? [09:36:25] ive gotten "the gift of trello gold" [09:36:41] for other stuff [09:36:52] do you want a month of gold? [09:37:20] i'll take it [09:37:24] if you're offering [09:37:33] i bounce between wunderlist and trello [09:37:40] but trello is better for projects imo [09:38:30] phuedx: yeah, i think a list view would go a long way for single person projects [09:38:36] phuedx: wikimedia email? [09:38:51] no my trello email is trello@samsmith.io [09:39:01] 👍 [09:40:09] phuedx: done [09:46:02] ta [09:46:38] now i'm wondering if the custom backgrounds will stay after gold expires [09:50:38] only one way to find out! [10:12:02] joakino: have you got gold? [10:12:08] i.e. do you want a month of gold? [10:12:38] phuedx: i got a month when inviting a couple of friends [10:12:48] coo [10:12:54] phuedx: if they stack up it would be cool [10:12:57] hah [10:13:33] i'm not in need, though, if you have people that would want to try it send it out [10:13:50] phuedx: i'll eventually support trello by paying, soon [10:18:52] i'm fairly certain it's the best thing out there [11:40:35] (03CR) 10Jhernandez: [C: 04-1] "Seems that the right positioned page actions create extra horizontal scroll (header image does not influence that):" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [11:41:21] joakino: given that it's a small change to the styling, i'm fine with you pushing a new ps ;) [11:41:34] phuedx: 👍 [11:45:36] (03PS10) 10Jhernandez: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [11:45:43] (03PS6) 10Phuedx: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [11:46:03] ta [11:46:05] (03CR) 10Jhernandez: [C: 031] "+2able" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [11:46:27] joakino: generally speaking, really minor changes that have been written down in the code review, i'm fine with [11:46:28] ;) [11:47:01] (03CR) 10Phuedx: Hygiene: Refactor secondary actions generation (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [11:47:23] phuedx: i didn't know if the overflow hidden was the desired way [11:47:30] i'm fine with that [11:47:47] phuedx: there it is, ive +1d, but i'd +2 it if i hadn't sent patch [11:47:54] sure [11:48:05] it's blocked on the dependant patch anyway [11:48:10] which i've just pushed [11:48:27] aha [11:49:13] phuedx: i'm gonna have a look, do you want jon to review it back? [11:49:20] which one? [11:49:24] the hygeine? [11:49:43] i don't mind [11:49:49] i think florian should take a look [11:49:52] but he's not here? [11:49:59] is it this one? https://gerrit.wikimedia.org/r/#/c/179347/6/ [11:53:12] phuedx: yeap i'm going to wait for some phper to have a look, it looks fine to me but i'm not that experienced [11:53:25] yeah it's that one [11:53:26] ok [11:53:34] joakino: is this yer first php? [11:53:58] phuedx: yes [11:54:08] oh [11:54:11] i didn't know that [11:54:50] phuedx: i've had enough with javascript weirdnesses, so I've always tried to stay away from it [11:55:52] phuedx: the language is not hard, so not a problem [11:57:00] joakino: i suppose with mobilefrontend you can kinda avoid the php side anyway [11:58:37] phuedx: it is less predominant, still necessary tough [11:59:08] yarrrp [12:20:55] ffs [12:21:00] local testing isn't working through browserstack [12:21:05] for some unknown reason [12:34:10] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Refactor secondary actions generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [12:51:23] (03PS3) 10Phuedx: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 [12:53:26] (03PS7) 10Phuedx: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [12:53:42] (03CR) 10Phuedx: Hygiene: Refactor secondary actions generation (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [12:54:04] going for lunch [12:54:27] (03CR) 10jenkins-bot: [V: 04-1] Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [12:56:37] (03CR) 10Phuedx: "> Also note we have a bunch of browser detection related code in application.js maybe we should use jquery.client there too if we are usin" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [13:00:13] ok [13:00:15] (03PS4) 10Phuedx: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 [13:00:17] now i'm going for lunch [13:08:39] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [13:20:17] (03CR) 10Florianschmidtwelzow: "two little open questions :)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [13:51:29] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#850436 (10Sjoerddebruin) [14:17:26] whoops [14:17:27] back [14:18:42] (03CR) 10Dbrant: [C: 032] Don't display "Read more" section if there are no read more suggestions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179792 (owner: 10Deskana) [14:39:26] (03CR) 10Phuedx: Restyle/reposition page actions (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [14:39:36] (03PS11) 10Phuedx: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 [14:39:57] (03PS1) 10Dr0ptp4kt: Update README with correct shell script sh line [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180183 [14:40:39] (03CR) 10Dr0ptp4kt: [C: 032] Update README with correct shell script sh line [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180183 (owner: 10Dr0ptp4kt) [14:41:21] (03CR) 10Florianschmidtwelzow: [C: 031] ":)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [14:41:31] (03Merged) 10jenkins-bot: Update README with correct shell script sh line [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/180183 (owner: 10Dr0ptp4kt) [15:00:58] (03CR) 10Phuedx: [C: 032] Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [15:08:14] (03PS3) 10Dbrant: Minor tweaks in collapsed infobox design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 [15:11:29] (03PS4) 10Dbrant: Minor tweaks in collapsed infobox design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 [15:31:45] (03CR) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [16:17:03] dbrant: you there? [16:17:15] dr0ptp4kt: yep [16:18:20] dbrant: thx. i had heard you had a (search?) widget or something like that for android you were looking at. do you happen to have that branch handy? i was hoping to lean on it for a widget for carolynne. she hasn't made it a strict requirement for end of december, but i figure if i can find open time, i could at least try [16:18:58] dbrant: that reminds me...well, you able to hop on video and talk? [16:19:16] dr0ptp4kt: sure! [16:19:24] to the batcave, dbrant, i go [16:22:51] dr0ptp4kt: https://gerrit.wikimedia.org/r/175225 [16:43:27] (03PS2) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [16:44:31] dr0ptp4kt: ^ lol easier than I thought! [16:44:44] dbrant: you're l337 [16:50:01] 1337 H4X0R [16:50:15] That's our Dmitry! [16:51:51] dbrant: http://developer.android.com/guide/topics/search/adding-custom-suggestions.html . grep -ir includeInGlobalSearch . 2>/dev/null suggests maybe this has been looked at a bit (searchable.xml) [16:52:47] dbrant: original blog announcement was at http://googlemobile.blogspot.com/2009/10/quick-search-box-for-android-search.html . had noticed it when someone referenced "quick search bar" (quick search box) [16:53:46] dr0ptp4kt: hmm, curious... [16:58:29] (03PS1) 10Phuedx: Restyle/reposition page issues in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 [17:00:20] (03CR) 10jenkins-bot: [V: 04-1] Restyle/reposition page issues in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [17:02:56] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [17:04:17] (03PS3) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [17:04:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 (owner: 10Dbrant) [17:06:04] (03PS4) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [17:32:08] (03CR) 10Jhernandez: [C: 032] Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [17:38:55] (03CR) 10Jdlrobson: [C: 04-1] "(disclaimer untested)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [17:39:24] (03PS12) 10Jdlrobson: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [17:39:32] (03CR) 10Jdlrobson: [C: 032] Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [17:40:01] oh some one needs to merge https://gerrit.wikimedia.org/r/#/c/179347/7 before we can merge that [17:40:23] ^ joakino phuedx [17:40:45] i worked on it [17:40:52] as did you [17:40:55] bmansurov ? [17:41:15] yes? [17:41:29] ok [17:41:35] i've looked at it but i don't feel confident enough on +2ing it [17:42:23] (03CR) 10Jdlrobson: [C: 04-1] Fix unneeded Watched api call (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [17:42:27] ^ FlorianSW [17:42:33] phuedx: hah! :P [17:42:40] phuedx: i won't tell anyone if you don't ;-) [17:42:54] jdlrobson: hi :) [17:42:58] * FlorianSW checks this [17:43:40] FlorianSW: so I think what you actually want is #content a there [17:43:47] and secondly watch star should probably be a button now [17:44:28] jdlrobson: yeah, i think so, to [17:48:34] OuKB: take a look at vhttps://gerrit.wikimedia.org/r/#/c/179347/7 ? [17:48:59] (03CR) 10Bmansurov: [C: 032] Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [17:49:06] never mind :) [17:49:22] * jdlrobson looking at https://gerrit.wikimedia.org/r/179033 [17:50:28] hey jdlrobson phuedx what is {{#invoke:Message box|ambox}} and how do i get it https://en.wikipedia.org/w/index.php?title=Template:Ambox&action=edit [17:50:35] (03PS2) 10Dbrant: Minor tweaks of the Toolbar design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 [17:50:40] i'm trying to get up to speed with templates and all [17:51:08] phuedx: does that work? [17:51:17] joakino: welcome to the horrible world of wiki templates [17:51:20] oh i see https://www.mediawiki.org/wiki/Help:Templates#Extensions [17:51:32] joakino: do you want the red pill or the blue pill? [17:51:34] jdlrobson: i can see it... need to read more [17:51:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [17:51:45] (03CR) 10jenkins-bot: [V: 04-1] Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [17:51:48] what do those do [17:52:01] joakino: you'll need to enable scribunto [17:52:06] (extension( [17:52:11] jdlrobson: does what work? [17:52:12] it basically invokes lua [17:52:18] also, yay! rebases required [17:52:18] https://gerrit.wikimedia.org/r/#/c/179033/ < phuedx [17:52:20] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [17:52:24] ahh wrong one [17:52:37] jdlrobson: looks like the rabbit hole goes really deep [17:52:47] https://gerrit.wikimedia.org/r/#/c/179948/ < phuedx [17:52:54] joakino: deeper than you could ever know ;-) [17:53:09] phuedx: i can't search at all with that patch [17:53:19] hrrm [17:53:25] phuedx: the search button is not visible [17:53:31] which makes sense as it still thinks you have js enabled [17:54:22] phuedx: you probably want to make sure the search button is visible if there is a class on body [17:54:25] that gets added in that module [17:55:12] (03CR) 10Dbrant: "This might be as simple as making the activity full-screen by default, by adding the following before setContentView():" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179963 (owner: 10BearND) [17:55:16] (03CR) 10Jdlrobson: [C: 04-1] Hide search on Android 2.3 or less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [17:55:49] (03CR) 10Jdlrobson: [C: 032] Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [17:57:02] 3MobileFrontend-stable, Mobile-Web: only top 50 articles on my watchlist show page images - https://phabricator.wikimedia.org/T73961#851078 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Fixed in https://gerrit.wikimedia.org/r/#/c/177939/ [17:57:10] jdlrobson: i don't quite follow that comment [17:57:42] phuedx: so... we want to make it possible to search in android 2.3 [17:58:12] the fallback search button is only shown when javascript doesn't exist [17:58:22] something like .client-js button { display: none; } [17:58:28] bleh [17:58:35] so in your patch what happens is the button doesn't show and neither does the input [17:59:01] so what i'm suggesting is you add a class to the DOM before you exit that module e.g. android-search-bug or something more semantic [17:59:05] and then reveal the icon [18:01:35] (03Merged) 10jenkins-bot: Hygiene: Refactor secondary actions generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179347 (owner: 10Jdlrobson) [18:01:39] (03Merged) 10jenkins-bot: Restyle/reposition page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178859 (owner: 10Phuedx) [18:01:46] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Move anonymousEditing config to EditorOptions (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [18:03:19] (03CR) 10Jdlrobson: [C: 04-1] Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [18:04:14] (03PS15) 10Jdlrobson: Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [18:04:40] (03PS6) 10Jdlrobson: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 [18:04:47] (03CR) 10Jdlrobson: [C: 032] Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [18:04:55] (03PS2) 10Jdlrobson: Restyle/reposition page issues in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [18:04:59] MaxSem: hey, is it safe to directly use QueryRandom class in the wikigrok extension to get a random page on page load? i.e. without an api call, just in php [18:05:00] (03CR) 10Florianschmidtwelzow: Fix unneeded Watched api call (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [18:05:45] MaxSem: or is it better to create a js config variable on page load just like wikigrokcampaings? [18:06:28] (03PS9) 10Florianschmidtwelzow: Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 [18:06:31] MaxSem: is http://en.wikidata.beta.wmflabs.org/ used? [18:06:33] there's QuestionStore::getRandomPage(), however what do you need it for? doesn't seem there's a need to precompute it for every page view [18:06:35] jdlrobson: nice to get some of those patches down [18:06:42] phuedx: yeeeyyyy! :D \o/ [18:06:59] gonna get george to bed [18:07:01] (he's very tired) [18:07:09] FlorianSW: huh? https://gerrit.wikimedia.org/r/#/c/179634/9/javascripts/modules/watchstar/Watchstar.js [18:07:10] jdlrobson, no idea [18:07:14] why a span? [18:07:17] MaxSem: I need it for wikigrok roulette in sidebar [18:07:34] bmansurov, do an api query when clicked [18:07:58] MaxSem: is it safe to assume that the API always returns a page? [18:08:02] (03CR) 10jenkins-bot: [V: 04-1] Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [18:08:18] no [18:08:32] MaxSem: that's the problem, I want to make sure that there is a page before displaying the menu item [18:08:33] (03CR) 10Jdlrobson: "Bad Jenkins! Bad!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [18:08:38] for example, there can be a campaign, but its data not filled yet [18:08:40] (03CR) 10Jdlrobson: [C: 032] Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [18:09:23] if you want just a random page with campaigns, just a config variable should be enough [18:09:35] *any* campaigns [18:09:47] MaxSem: yes, any is fine [18:09:55] jdlrobson: mw-ui-icon-element seems to doesn't work with button :/ [18:10:07] it doesn't? It should.. [18:10:12] * jdlrobson has a quick look [18:10:14] jdlrobson: so you have text "behind" the watchstar [18:10:27] (03Merged) 10jenkins-bot: Put description below title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179336 (owner: 10Jdlrobson) [18:10:43] MaxSem: can you add that to the wikigrok code? [18:10:49] FlorianSW: we should fix that :) [18:10:53] what? [18:10:55] jdlrobson: i thought it should only for text elements? [18:11:05] MaxSem: config variable? or is it something I can do? [18:11:14] it shoudl be in mf [18:11:22] already? [18:11:25] ohh [18:12:28] MaxSem: so this is what I need right? QuestionStore::getRandomPage() [18:12:31] FlorianSW: anyway.. i'll merge as is we can reinvestigate that later [18:13:14] kaldari quick patch for you so we can wrap up the ui restyling before next depoy > https://gerrit.wikimedia.org/r/180028 [18:13:41] phuedx: you taking a look at https://gerrit.wikimedia.org/r/#/c/180209/ ? [18:13:51] bmansurov, config var, if true show a menu item that makes an api request on tap. cater for the rare but theoretically possible case of no page being returned [18:14:23] also, page variables get cached which will create lots of fun for anons, etc [18:16:12] MaxSem: so I'm mainly interested in that rare but theoretically possible case of no page being returned. I don't want to show the menu item if that's the case. So what I'm asking is can I run the api call from php? I mean not the api call itself but some function in php. [18:16:58] do not do that [18:17:10] this random page will be needed in 0.001% of pvs [18:17:32] bmansurov: why do you need a page ready before? [18:17:39] why can't you just request it on click? [18:17:52] jdlrobson: to show the menu item [18:18:00] jdlrobson: why show the menu item if the page doesn't exist? [18:18:11] bmansurov: why would a page not exist? [18:18:35] jdlrobson: according to MaxSem it's possible. there is a reason above somewhere [18:18:52] that's a bug with the api i would say and something frontend code shouldn't optimise for [18:18:54] there's always a possibility of failure [18:19:08] MaxSem: it should show an error if it can't find a page [18:19:11] HTTP request fail, after all [18:19:12] just as we do with wikigrok [18:19:26] but we should minimise the likelihood of failures [18:19:32] yup [18:19:33] (03CR) 10Kaldari: [C: 032] Hide hat notes on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180028 (owner: 10Jdlrobson) [18:19:47] (03CR) 10Jdlrobson: [C: 032] Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [18:19:52] jdlrobson: so show the menu item but alert the user if there is no page? [18:20:09] FlorianSW: are you going to go to the hackathon in Lyon? [18:20:13] would be cool to meet you [18:20:27] https://www.mediawiki.org/wiki/Lyon_Hackathon_2015 < FlorianSW if you haven't seen it [18:20:38] we could build some cool things together :) [18:21:04] (03Merged) 10jenkins-bot: Hide hat notes on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180028 (owner: 10Jdlrobson) [18:21:19] (03PS2) 10Dbrant: Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 [18:22:12] kaity|away: hey, can I get an icon for wikigrok menu item? https://trello.com/c/AhWMM2zo/1-8-wikigrok-in-sidebar-mvp thanks [18:22:20] (03Merged) 10jenkins-bot: Fix unneeded Watched api call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179634 (owner: 10Florianschmidtwelzow) [18:23:45] jdlrobson: i have already read this, but haven't thought about it :) [18:24:08] We think we have the solution. [18:24:11] jdlrobson: you all are coming? [18:24:38] jdlrobson: https://gerrit.wikimedia.org/r/#/c/180122/2/includes/skins/SkinMinervaAlpha.php what should be the intended behavior? actual the "false" will be overwritten [18:24:39] FlorianSW: we don't know yet but i would like to go [18:24:46] and i'm sure something from mobile will! [18:25:10] FlorianSW: I guess the correct behaviour would be for PHP to ensure it is always an object [18:25:17] so false gets converted somewhere to array() [18:25:31] (03CR) 10Kaldari: [C: 032] Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [18:25:53] maybe this is over-optimisation though i don't know. I just don't think setting a config variable should blow stuff up :-S [18:26:48] We want to ask someone to take a peek at a design and let us know if that is the mobile mediawiki needs. [18:27:05] (03Merged) 10jenkins-bot: Give a better error message for blocked users trying to edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178834 (owner: 10Florianschmidtwelzow) [18:27:29] Jehovahsays: i think i'm missing some of your conversation? The first message I have from you is "We think we have the solution." [18:27:30] jdlrobson: it doesn't blow up (at least in this step in SkinMinervaAlpha) [18:28:08] FlorianSW: mmmm. okay [18:28:24] We didn't use mobilefrontend to do this either [18:28:25] maybe it's not so bad then. My JS comments still stand though. [18:30:09] jdlrobson: if i see it right, there will be no exception, the configs are used always in an if statement, so an undefined will be the default: false [18:30:28] jdlrobson we are developing a mobile view of mediawiki we just need others to peek at it and tell us if that is the design they are looking for to implement into mediawiki [18:30:35] jdlrobson: but it doesn't look like a good code style, maybe [18:31:02] mediawiki has not publish an example of the design they need us develope. [18:32:30] Here, please take a peek at this design with a mobile device - https://www.jehovahsays.net/mobile/ [18:32:33] (03CR) 10Florianschmidtwelzow: Hygiene: Move anonymousEditing config to EditorOptions (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow) [18:33:16] it only took one php file in a mediawiki extensions folder [18:33:54] 3MobileFrontend-Feature-requests: [Tracking] Obstacles to enable anonymous editing for MobileFrontend users - https://phabricator.wikimedia.org/T55069#851280 (10Florian) [18:33:55] 3Mobile-Web, MobileFrontend-alpha: Blocked, not logged in user can access the editor (but not save) - https://phabricator.wikimedia.org/T78315#851279 (10Florian) 5Open>3Resolved [18:34:01] not bad [18:34:29] thank you. is that the design they need? [18:34:39] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851285 (10Krenair) @Ninovolador, was this in the iOS app or Android app? Please don't forget to add projects when creating tasks. [18:34:43] no [18:34:45] or do they need something better? [18:36:07] if they need something better someone send us a snap shot of a picture of the design and we will build it [18:38:30] just one or two pictures of what they need it to look and feel like and we are on it. [18:41:39] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851297 (10Ninovolador) Sorry about my grammar, i don't speak english very well. I meant "this should be done (...)" [18:43:52] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851299 (10Ninovolador) [18:44:23] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#850417 (10Ninovolador) [18:46:47] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851351 (10Mhurd) The apps don't yet allow you to upload photos to nearby places, so I'm not sure how loading even more nearby item... [18:47:35] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851353 (10Krenair) @Ninovolador? [18:47:53] i found a picture at http://www.mediawiki.org/wiki/Manual:Mobiles,_tablets_and_responsive_design [18:48:09] is this what they really want? [18:49:04] (03CR) 10Florianschmidtwelzow: Use user rights to check, if the user can edit page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [18:49:16] MaxSem, Jdlrobson, kaldari: ^ thoughts? :) [18:50:27] (03PS1) 10Dbrant: Improve scrollbar in Gallery description text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180224 [19:00:24] FlorianSW: will take a look a little later [19:00:56] anyone know when rmoen will be around? [19:00:56] jdlrobson: ok :) [19:03:21] manybubbles: rmoen joined [19:03:40] Yes, I have joined. [19:04:15] dbrant|brb: sent an invite to parsiod chat [19:05:21] (03PS1) 10Kaldari: Hygiene: Adding documentation and prettifying some code in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180231 [19:06:04] rmoen: sorry - yeah - hey - did you get a chance to look at https://phabricator.wikimedia.org/T78553 ? [19:06:11] (03CR) 10Robmoen: "Yeah I got it. This was uploaded 5 minutes prior to the Roulette patch and I was going off what the card said about Roulette being versio" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [19:06:42] FlorianSW: In the case of anonymous editors, we could probably just assume their rights and not vary the page cache (since all anonymous users on a given wiki should have the same editing rights). [19:06:55] manybubbles: uhh no, i haven't yet [19:07:36] rmoen: sorry to just dump this on you, but I _think_ your change to special:search broke the advanced search [19:07:37] manybubbles: perhaps related to my change to special:serach? [19:08:09] manybubbles: no worries, I will dive into this [19:08:15] kaldari: btw, we cached anon rights too and ended up with the problem of ipblocks. [19:08:17] thanks! [19:08:18] (we as in apps team) [19:08:29] rmoen: I didn't want to just revert it so I figured I'd find you when you got online [19:08:43] kaldari: you mean we should put the rights into a js config var? [19:09:00] might be totally unrelated, though :) [19:09:05] YuviPanda: We can stop blocked IPs after they enter the editing workflow [19:09:28] kaldari: blocked users still have edit right [19:09:32] yeah, that’s what we ended up doing as well, I think [19:09:33] FlorianSW: possibly. I haven't completely thought through this. [19:09:33] YuviPanda: ^^ [19:10:57] YuviPanda: Do you have any idea why we aren't already including user rights in a JS var? Apart from the fact that it's stupid that we need access to them since protection should be based on groups rather than rights. [19:11:09] jdlrobson: yes [19:11:15] was just getting george to bed [19:11:26] kaldari: JS var emitted in the page HTML? because cache, I think [19:11:46] YuviPanda: groups are in js vars [19:11:58] YuviPanda: We already emit user groups. What's the difference? [19:12:20] logged in pages aren’t cached, and anon rights change based on their IP address. [19:12:43] YuviPanda: are you sure, that anon rights changed? [19:13:11] FlorianSW: yeah, maxsem enlightned me a lot on this when we were working on the API changes for mobile app. [19:13:19] FlorianSW: well, userCanEdit changes at least. [19:13:23] YuviPanda: I was thinking only emit user rights for logged in users [19:13:32] that should work [19:14:00] YuviPanda: hmm, iirc anon blocked user can still edit his own user talk page [19:14:12] YuviPanda: I don't their actual rights change, but I could be wrong [19:14:28] kaldari: well, userCan definitely changes, not sure about rights. [19:14:33] (03PS1) 10Jdlrobson: Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 [19:14:35] so it may not matter [19:14:35] (03PS1) 10Jdlrobson: Clean qunit coverage reports in `make clean` method in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180233 [19:15:32] YuviPanda: userCan probably checks for blocked status, but that's handled outside of rights [19:15:52] right, but if this is for the edit pencil you need userCan, no? [19:16:14] (03CR) 10jenkins-bot: [V: 04-1] Clean qunit coverage reports in `make clean` method in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180233 (owner: 10Jdlrobson) [19:16:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 (owner: 10Jdlrobson) [19:16:48] YuviPanda: we don't check blocks actually, only the protection of a site [19:16:56] kaldari: ^ [19:17:15] manybubbles: That change should be reverted for now. This is more broken than just that js error. [19:17:25] hmm, right. so for the apps we rolled everything into userCan, since that checked for pretty much everything (except ipblocks) [19:17:34] YuviPanda: I'm thinking... set the state of the edit pencil based on their rights (which we could embed in a JS var so we don't make an API call), then once they click the edit pencil, check if they are blocked or not. It's not ideal, but it's the best I can come up with given our rediculous protection system. [19:17:43] I will comment on the bug. [19:17:57] Yuvipanda, kaldari: checked it: anon blocked users have the same rights as not blocked ones, so put rights into page should be possible [19:18:19] (03PS2) 10Jdlrobson: Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 [19:18:25] (03PS2) 10Jdlrobson: Clean qunit coverage reports in `make clean` method in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180233 [19:18:36] kaldari: so what we have for the app is, we exteded action=mobileview to do a userCan check and return that, so that covers all logged in users. Anon users who *were* ipblocked got a warning as they tried to save. This also handled protection against anons, etc wonderfully. [19:19:41] YuviPanda: That seems like a decent solution [19:19:41] kaldari: you can put the output of userCan, re-using 127.0.0.1 for anons (so it is counted as a non-ipblocked anon) and that emit that as a jsvar [19:19:48] YuviPanda: "as they tried to save." when they click save, or enter the editor? [19:19:49] (03PS3) 10Jdlrobson: Clean qunit coverage reports in `make clean` method in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180233 [19:19:49] that would catch all anons that aren’t ipblocked [19:19:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 (owner: 10Jdlrobson) [19:20:04] FlorianSW: the original code as they click save. [19:21:04] kaldari: FlorianSW we also instrumented the entire thing, btw, if you want stats on ipblocked save attempts [19:21:06] kaldari, YuviPanda: hmm, isn't this what we have already? Just that we try to save and return an error toast, if the save api call fails? [19:21:23] no idea about the state of MobileFrontend :) [19:21:37] :) [19:23:05] manybubbles: no wait, I have a fix [19:23:25] what's going on with mfe on beta labs? [19:23:46] it looks… funky [19:24:13] Maryana: ?Looks normal? [19:24:40] Maryana: or do you mean experimental mode? [19:24:42] yes [19:24:51] what's going on? :) [19:25:14] if i followed the patches: an ui redesign :) [19:25:35] wasn't there a card in trello? [19:25:57] oh yeah, i just meant the logo in the search bar, the "font size" menu item.. [19:26:10] that stuff wasn't part of any card i know about – just curious [19:27:13] hmm :/ [19:29:16] FlorianSW: Yes, that's similar to what we're already doing in MF. We just need to fix the protection detection for logged in users [19:30:02] kaldari: i'm still not really happy with putting the complete list of rights into the source code :/ [19:30:55] FlorianSW: Yeah, that might be a lot of extra content. Just returning a true/false from a canUser(edit) in a JS var might be better, like Yuvi was suggesting [19:31:39] YuviPanda: I really just want to change our protection system back to how it was in the old day when it was sensible. Do you have any idea why it was changed to be rights-based instead of group based? [19:31:46] kaldari: yeah, let me amend my change :) (later) [19:32:10] kaldari: not sure. [19:32:28] kaldari: might be hard to roll back, has things like templateeditors and random other protection levels [19:32:28] now [19:33:33] YuviPanda: and superprotect :P [19:34:08] *hust* [19:34:19] (03PS3) 10Jdlrobson: Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 [19:35:32] YuviPanda: templateeditor is also a group [19:38:14] kaldari: let’s just 503 on superprotect edits [19:38:14] :) [19:38:19] kaldari: hmm, true. [19:40:09] (03PS3) 10Phuedx: Restyle/reposition page issues in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 [19:40:14] YuviPanda: The only right not associated with a group is superprotect. I wonder if the system was changed just for that. It would at least explain why the switch was only done halfway (all wikis are still using 'sysop' as a restriction level, which has to be rewritten to editprotected everywhere the ritghts are checked) [19:40:45] (03CR) 10Phuedx: Restyle/reposition page issues in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [19:40:52] jdlrobson: ^ [19:40:57] gotta go! [19:41:02] YuviPanda: and of course the protection interface is still group-based [19:41:06] i'll be monitoring patchezzz [19:41:18] what a mess [19:41:18] kaldari: do you know when it was changed? [19:41:22] no idea [19:41:25] we definitely did the app stuff before superprotect [19:41:28] Deskana: need… coffee… [19:41:36] kaldari: it is a mess, yeah :) [19:41:55] kaldari: also, different levels of protection on top of each other :) [19:42:11] kaldari: not sure if that’s exposed in the UI, but Max told me it’s theoretically possible [19:42:23] like, 3 days of full protection followed on top of 9 days of semi [19:42:27] mhurd: https://office.wikimedia.org/w/index.php?title=Bash&diff=125178&oldid=124885 [19:42:36] YuviPanda: Yes, it's now possible to have protection base on a random stack of rights [19:42:52] which is silly and we will never build a UI for [19:42:57] yup [19:43:07] but it means the API will expose a goddamn Array there instead of a string [19:43:11] grumblegrumble [19:43:45] YuviPanda: Yep, and you have to iterate over the array even though right now it will never have more than 1 item (and probably forever) [19:43:52] ArrayList list = new GoddamnArray(); [19:44:45] kaldari: yeah, I think I swapped between having an actual array, and stopping giving a fuck and just taking the first item... [19:44:45] YuviPanda: a whole layer of complexity with no use case other than superprotect :( [19:45:06] hmm, I’m not sure if this was built just for superprotect, though [19:46:20] temp.java:7: error: cannot find symbol [19:46:21] ArrayList list = new GoddamnArray(); [19:46:21] ^ [19:46:23] symbol: class GoddamnArray [19:46:24] :( [19:53:39] Deskana: heh :D should be trivial to fix :) [20:08:21] (03PS6) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [20:09:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [20:16:22] FlorianSW: I'm thinking it may be a better long term solution to just expose user rights on the client-side than implementing one-off solutions for every action that needs a rights check. [20:18:36] kaldari: and then give meaningful error messages, if an action fails due to missing permissions? [20:19:53] kaldari: what i see atm: we still have a variable with the value if the current user can edit the page :? [20:19:59] wgIsPageEditable [20:20:09] Yeah. Plus that will let us surface permission errors earlier in a lot of workflows (rather than waiting until the action is submitted) [20:20:18] (03CR) 10BearND: [C: 032] Minor tweaks in collapsed infobox design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 (owner: 10Dbrant) [20:20:48] (03Merged) 10jenkins-bot: Minor tweaks in collapsed infobox design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179920 (owner: 10Dbrant) [20:20:58] bearND: thx! related: https://gerrit.wikimedia.org/r/179919 [20:21:39] hmm, would be possible, and that without an api call on every page view, if we do it with the first action, which needs an permission. [20:21:47] FlorianSW: I think we should get rid of that and just have a property of the Page object instead [20:23:39] FlorianSW: I think I'll propose that core switches mw.user.getRights() to mw.config.get( 'wgUserRights' ) [20:23:56] and see what people say [20:24:11] kaldari: let me be clear (your messages are misleading me, i think :P): Do you mean to remove all permission check related code (e.g. Page.isEditable()) from MF and just give an error message when the user saves a page where he has no permission to edit it? Or check permissions only on the client side, e.g. with mw.user.can('edit'); or something else? [20:24:56] FlorianSW: I mean having all our interfaces proactively check the user rights before showing UI elements [20:25:32] dbrant: got it. thanks [20:25:34] or at least disabling them immediately on page load [20:26:08] kaldari: yeah, with the proposal of to put rights into js var i think i understand it :) [20:26:17] so we output one html page and do all other in JS [20:27:24] (03PS2) 10BearND: Improve scrollbar in Gallery description text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180224 (owner: 10Dbrant) [20:27:39] (03CR) 10BearND: [C: 032] Improve scrollbar in Gallery description text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180224 (owner: 10Dbrant) [20:27:52] i think this would be the best solution to solve this, permissions in mediawiki are a big fat... :( Where you want to propose it? wikitech-l or phabricatorß [20:27:57] kaldari: ^ [20:28:01] (03Merged) 10jenkins-bot: Improve scrollbar in Gallery description text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180224 (owner: 10Dbrant) [20:29:58] FlorianSW: MaxSem brings up the point that if we keep all the checks on the server side, it will reduce page load, as we only need to expose the permissions that are relavent to a particular page (rather than all rights). Hmmm. [20:31:29] Which I guess brings us back to the wgIsPageEditable solution [20:31:41] kaldari: that's the other point, yes. [20:31:49] hmm [20:31:55] plus that means we don't have to fight for a change to core :P [20:32:31] OK, I need to get some lunch. [20:32:41] let me do this (should be just a small change) and we can think about and discuss this :D "don't have to fight for a change to core" Yeah :D [20:32:49] bon apetit :P [20:34:16] (03CR) 10BearND: "This looks great! I would like to see the x of the SearchView to also visually appear inside the SearchView area, and not outside. Otherwi" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 (owner: 10Dbrant) [20:40:58] dr0ptp4kt: Are you available at 2pm tomorrow for a meeting? [20:41:06] 3MobileFrontend-Feature-requests, Wikipedia-App-iOS-App, Wikipedia-App-Android-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851611 (10Ninovolador) The old fashioned way I want to check if i could upload a photo to Commons. All places near me (~2 km) alr... [20:41:26] dr0ptp4kt: We're going to have to do some header mumbo jumbo in the app and you come to mind as the most header mumbo jumboy engineer that's touched the apps. :-) [20:43:03] Deskana: we have our deployment window at that time. lemme check: yurikR, will you need me during the deployment window tomorrow? [20:43:19] when was the last android app beta update? and when will the next one be? [20:44:06] Krenair: Dec 9, and tomorrow, respectively! [20:44:17] ok, thanks [20:44:18] On the... yes, thanks Dmitry. :) [20:44:37] (is there a timetable for this somewhere?) [20:44:52] Krenair: No, beta is done whenever we feel we have something worthy of beta. [20:44:59] ok [20:45:16] Krenair: We're trying to stick to a schedule for production releases, but we're failing at that pretty hard honestly. [20:47:34] Deskana: feel free to add me to the meeting. these are HTTP headers that you speak of, right? [20:47:48] 3MobileFrontend-Feature-requests, Wikipedia-App-Android-App, Wikipedia-App-iOS-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851619 (10Ninovolador) That would be nice [20:49:20] dr0ptp4kt: Yes! [20:49:45] Deskana: cool [20:49:51] dr0ptp4kt: Thank you. :) [20:50:03] and the nightlies seem to be working without glitches as well [20:50:04] Deskana: you're welcome [20:50:05] so yay on that [20:51:07] (03PS7) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [20:53:36] (03PS8) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [20:54:25] MaxSem: https://phabricator.wikimedia.org/T78703 [20:55:35] 3MobileFrontend-Feature-requests, Wikipedia-App-Android-App, Wikipedia-App-iOS-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#851645 (10Mhurd) Per Max, I created a task in MediaWiki-extensions-GeoData: https://phabricator.wikimedia.org/T78703 [20:56:27] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [20:58:16] Deskana: i cc’ed you on https://phabricator.wikimedia.org/T78703 [20:58:30] kaldari, can I see the list of all page_ids in which WikiGrok is displayed? [20:58:51] Deskana: god that was so much easier than bugzilla :) [20:59:02] mhurd: :D [21:00:17] mhurd, have you told MaxSem what I found? [21:00:24] re: nearby coordinate precision [21:00:31] uh? [21:00:43] (03PS11) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 [21:00:51] Krenair: aww, I thought it was your and mhurd’s secret :) [21:00:52] leila: one sec... [21:01:26] (I just noticed that MaxSem was going to investigate, so...) [21:01:39] (03CR) 10Bmansurov: [C: 032] Hygiene: Adding documentation and prettifying some code in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180231 (owner: 10Kaldari) [21:01:50] Krenair, and what did you discover? [21:02:19] MaxSem, I found that, at least on my local install with mysql, geodata would maintain the full coordinates [21:02:23] kaldari, I've been told you know about the mobile editor. Can I steal some of ya time to diagnose something? [21:02:25] leila: select wgq_page from wikigrok_questions; on enwiki db [21:02:40] Ironholds: sure [21:02:44] kaldari, thanks! [21:02:45] but mysql would drop some precision... [21:02:48] ta! [21:02:58] (03CR) 10jenkins-bot: [V: 04-1] Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [21:03:03] uh [21:03:07] (03Merged) 10jenkins-bot: Hygiene: Adding documentation and prettifying some code in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180231 (owner: 10Kaldari) [21:03:53] (03CR) 10Bmansurov: [C: 032] Clean qunit coverage reports in `make clean` method in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180233 (owner: 10Jdlrobson) [21:04:08] Krenair: oops sorry i misunderstood what you’d found [21:04:20] (03PS12) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 [21:04:35] YuviPanda: hey get to california [21:04:42] mhurd: sooooon [21:04:44] oh.. what did you think I found? [21:07:14] thanks Krenair ! [21:07:36] Krenair: did realize (or remember) your local install seemed to preserve precision. i was seriously sleep deprived the other day :) [21:07:50] I didn't check what happens on the backend production uses.. [21:07:58] (03Merged) 10jenkins-bot: Clean qunit coverage reports in `make clean` method in Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180233 (owner: 10Jdlrobson) [21:08:04] ah :) [21:15:18] (03CR) 10Bmansurov: [C: 031] Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 (owner: 10Jdlrobson) [21:18:47] (03PS1) 10Dbrant: [WIP] Share images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180302 [21:22:09] rmoen: do you want to schedule https://gerrit.wikimedia.org/r/#/c/180237/ for SWAT and make the submodule update for it? [21:22:26] (03PS3) 10Dbrant: Minor tweaks of the Toolbar design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 [21:22:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Share images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180302 (owner: 10Dbrant) [21:24:00] (03PS6) 10Jdlrobson: POC: Add mobile preview button to EditPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [21:24:35] (03CR) 10Jdlrobson: [C: 04-1] "If this is a proof of concept should we abandon it (I assume you posted it on mailing list) or are you hoping for another outcome?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [21:27:02] (03PS4) 10Dbrant: Minor tweaks of the Toolbar design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 [21:29:19] (03PS5) 10Dbrant: Minor tweaks of the Toolbar design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 [21:30:42] bearND: ^ done! [21:32:35] (03CR) 10BearND: "One comment inline + would be nice to be able to get the references in [[Barack]], as well. Not just the notes. But ok, that could come in" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 (owner: 10Dbrant) [21:32:57] (03CR) 10Florianschmidtwelzow: "There was no response on the mailing list, so i would like to read, what mobile team thinks about itml. Is this a way we should follow?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [21:34:44] (03CR) 10Jdlrobson: [C: 04-1] "Due to .mw-ui-icon * { display: block; } the overlay content looks weird. I'm going to amend this myself. Feel free to +2 if you are happy" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [21:35:12] main.css [21:37:34] (03CR) 10Jdlrobson: [C: 032] "Wait.. this is already an issue. I'll file a bug and send a patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [21:37:43] 3Mobile-Web, MobileFrontend-alpha: Issues in overlay render strangely - https://phabricator.wikimedia.org/T78708#851735 (10Jdlrobson) 3NEW [21:39:14] (03Merged) 10jenkins-bot: Restyle/reposition page issues in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180209 (owner: 10Phuedx) [21:40:55] rmoen: poke on the SWAT question - will you support SWATing that fix and make the submodule update and all that good stuff? [21:41:25] manybubbles: for sure. I was just now responding. [21:41:52] bmansurov: what icon do you need? [21:42:02] cool. I'm just trying to get all my ducks in a row before I sign off in an hour and a half. I know it can take some time [21:42:09] jdlrobson: an icon for the new wikigrok menu item [21:42:49] 3Mobile-Web, MobileFrontend-alpha: Pencil icon is preloaded locked - https://phabricator.wikimedia.org/T74851#851747 (10bmansurov) a:3bmansurov [21:42:52] bmansurov: is there any icon you can use as an interim solution? [21:43:25] jdlrobson: i didn't find anything that correctly describes it. also the icons we have are already used somewhere else [21:43:29] (03CR) 10BearND: [C: 032] ":)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 (owner: 10Dbrant) [21:43:33] bmansurov: maybe something from https://github.com/munmay/WikiFont ? [21:43:50] jdlrobson: ok [21:43:51] thanks [21:43:52] let me check with moiz [21:44:07] (03Merged) 10jenkins-bot: Minor tweaks of the Toolbar design. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/179947 (owner: 10Dbrant) [21:44:25] bmansurov: i just asked him he's going to find one [21:44:42] jdlrobson: thanks dude [21:44:54] (03PS1) 10Jdlrobson: Remove unnecessary rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 [21:45:17] (03PS2) 10BearND: Enable lead images in Beta. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180105 (owner: 10Dbrant) [21:45:24] (03CR) 10BearND: [C: 032] Enable lead images in Beta. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180105 (owner: 10Dbrant) [21:45:26] (03PS9) 10Jdlrobson: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [21:45:56] bmansurov: fyi i'm happy to merge it if the code is okay without an icon btw and use that as a motivation to get an icon ;-) [21:45:59] (03Merged) 10jenkins-bot: Enable lead images in Beta. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180105 (owner: 10Dbrant) [21:46:43] jdlrobson: sure, i think the code is ok, but i wrote it, so i'm biased ;) [21:46:50] bmansurov: hey [21:46:51] bmansurov: i'm looking at it now [21:47:08] moizsyed: howdy [21:47:09] bmansurov: i have an icon for you for wikidata game left nav [21:47:22] bmansurov: sending you an svg in 1 mins [21:47:24] moizsyed: please email, thanks [21:47:34] or upload to the card [21:47:42] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [21:51:53] (03CR) 10BearND: [C: 04-1] Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 (owner: 10Dbrant) [21:52:22] dbrant: forgot to mark it earlier. Marking it makes it easier to find [21:52:31] bearND: np [21:54:19] (03CR) 10Jdlrobson: [C: 04-1] WIP: Alpha: WikiGrok in sidebar (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [21:56:11] bmansurov: just sent you an email [21:59:47] moizsyed: thanks [22:00:48] (03PS1) 10Bmansurov: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180315 [22:12:47] (03PS1) 10BearND: Fix NPE in LeadImagesHandler.beginLayout [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180321 [22:14:58] (03PS5) 10Jdlrobson: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [22:15:00] moizsyed_: hey, the icon you sent me is blank. can you confirm? [22:16:54] (03CR) 10jenkins-bot: [V: 04-1] Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [22:17:21] (03CR) 10Jdlrobson: [C: 04-1] "minor tweaks needed..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow) [22:19:54] 3Wikipedia-App-iOS-App: Integrate Testflight SDK to make iOS betas easier to install - https://phabricator.wikimedia.org/T78714#851819 (10Jaredzimmerman-WMF) 3NEW [22:20:52] dbrant: time for a hangout in a bit? [22:20:52] (03PS5) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [22:21:05] mhurd: sure [22:21:41] (03PS2) 10Dbrant: [WIP] Share images. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180302 [22:21:51] dbrant: 10 min? [22:21:57] mhurd: yep [22:25:25] brion: hey dude! how goes the bits and/or bytes? [22:25:45] so many bits [22:25:52] brion: collect them all [22:25:57] hehe [22:26:12] (03CR) 10Brion VIBBER: [C: 032] Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/179966 (owner: 10BearND) [22:27:49] mhurd: are those two nearby commits ready to review? [22:27:55] jdlrobson: could you create a phab ticket describing your needs / use cases re sections & add me in the cc? [22:27:57] lemme get some coffee started brb [22:28:02] brion: should be :) [22:28:35] brion: oooh coffee… me too [22:29:54] ok i’ll test those in a sec [22:30:14] brion: uicollectionview ftw! [22:33:59] jdlrobson: hey can you please tell moiz to resend the icon? he's not replying :( [22:34:16] bmansurov: he seems occupied right now. you got my review comments right? [22:34:25] i'd suggest just fixing those up and we'll ship it without an icon [22:34:29] it's only alpha after all [22:34:30] jdlrobson: yep, they are already fixed [22:34:33] icon should be easy to fix up [22:34:37] bmansurov: ok ill take a look a bit later [22:34:38] jdlrobson: i'll push [22:34:48] (03PS10) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [22:36:22] (03CR) 10jenkins-bot: [V: 04-1] Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [22:38:06] there's an issue with your qunit baha [22:38:10] it's not jenkins [22:38:24] * jdlrobson needs to restart computer [22:38:40] (03PS11) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [22:38:57] (03PS6) 10Jdlrobson: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [22:38:59] (03PS1) 10Jdlrobson: Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 [22:39:31] jdlrobson: any idea why this may happen: TypeError: 'undefined' is not an object (evaluating 'mw.config.get('wgArticlePath').replace') ? [22:40:04] it doesn't exist... :) [22:40:19] (03CR) 10jenkins-bot: [V: 04-1] Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [22:41:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 (owner: 10Jdlrobson) [22:41:06] (03CR) 10jenkins-bot: [V: 04-1] Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [22:42:22] mhurd, /w/api.php?action=mobileview&format=json&page=Barack%20Obama&prop=image%7Cthumb&thumbsize=666 [22:43:43] (03CR) 10Brion VIBBER: [C: 032] Made Nearby use UICollectionView. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/179978 (owner: 10Mhurd) [22:44:01] (03CR) 10Brion VIBBER: [C: 032] Moved angle/distance calc into Nearby controller. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/179979 (owner: 10Mhurd) [22:44:17] brion: yay! [22:44:46] brion: now we can do fanciness with flowcontrollayout thingies [22:45:09] sweet :D [22:48:29] mhurd: are we still hanging-out? [22:48:45] dbrant: sorry got distracted. 2 min [22:50:20] (03CR) 10Dbrant: [C: 032] "Lgtm, but I'll follow up with a more comprehensive patch to fix similar issues elsewhere." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180321 (owner: 10BearND) [22:51:11] dbrant: sent invite [22:52:08] (03PS12) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [22:53:55] (03CR) 10jenkins-bot: [V: 04-1] Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [22:54:25] (03CR) 10Jdlrobson: [C: 031] "Solution makes sense but haven't tested yet" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180315 (owner: 10Bmansurov) [22:55:58] (03PS2) 10Jdlrobson: Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 [22:56:00] (03PS7) 10Jdlrobson: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [22:58:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 (owner: 10Jdlrobson) [22:59:03] (03CR) 10jenkins-bot: [V: 04-1] Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [22:59:20] ok i gotta grab a late lunch, then i’ll check in and sync up some code [23:06:51] hey bmansurov [23:09:29] moizsyed: yes i got it, it's white ;) [23:15:21] (03PS1) 10Jdlrobson: Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 [23:15:38] (03PS13) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [23:16:19] (03PS4) 10Jdlrobson: Hygiene: Introduce Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180232 [23:16:26] (03PS8) 10Jdlrobson: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [23:16:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [23:17:26] (03PS14) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [23:18:40] (03CR) 10jenkins-bot: [V: 04-1] Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [23:19:30] (03CR) 10MaxSem: Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:20:45] (03PS2) 10Jdlrobson: Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 [23:20:50] (03CR) 10Bmansurov: Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:21:47] Deskana, I believe you owe https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketNumber=2014060510018481 a reply. [23:23:19] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [23:23:31] (03PS15) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [23:25:51] (03CR) 10jenkins-bot: [V: 04-1] Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:26:21] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [23:27:08] dbrant: email sent [23:27:19] mhurd: thx! [23:27:54] (03PS3) 10Jdlrobson: Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 [23:27:56] (03PS9) 10Jdlrobson: Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [23:29:17] (03PS1) 10MaxSem: Flag to disable main page transformations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180349 [23:29:31] (03CR) 10jenkins-bot: [V: 04-1] Hide search on Android 2.3 or less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [23:29:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move lockViewport to Browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180329 (owner: 10Jdlrobson) [23:29:53] (03PS1) 10BearND: More space between wordmark and slogan [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180350 [23:31:06] (03CR) 10Bmansurov: Remove unnecessary rule (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 (owner: 10Jdlrobson) [23:31:53] Krenair: I'll give a quick, fairly generic reply. [23:32:50] Fine. I'd just like to make sure it gets some sort of acknowledgement, they obviously put a lot of work into writing it. [23:33:01] (03CR) 10jenkins-bot: [V: 04-1] Flag to disable main page transformations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180349 (owner: 10MaxSem) [23:33:03] And hopefully the contents will be taken into account by the team :) [23:33:35] FYJ! [23:35:29] Krenair: Yeah, I read that email a while back and in fact we've done quite a few of the things he suggested. [23:35:57] great [23:36:06] (03PS2) 10MaxSem: Flag to disable main page transformations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180349 [23:38:48] mhurd: can you add me to that board or make it public [23:38:49] ? [23:39:02] tfinc: ya [23:39:20] tfinc: done [23:40:09] Ohhh hammock time. [23:40:17] I love you, hammock time. [23:40:37] brion: what's our status on https://trello.com/c/Sy8c6f2f/11-data-layer-refactor-little-issues-to-fix Refinements & Lead Image ? [23:41:43] tfinc: partway through the tweaking of APIs, hope to land that tonight [23:42:22] brion: and the bits for lead image story? [23:42:30] that feature is now blocked on this work [23:42:44] should be in the same batch [23:42:59] mhurd: catch up with you in the morning on that? i should have some patches ready to review by then [23:43:21] brion: sounds good! [23:44:00] brion: glad the nearby uicollectionview stuff passed muster - gonna be fun to transition more tableviews later :) [23:44:23] yeah nothing seemed explody :D and it gives us flexibility for later :D [23:45:11] brion: i’ve been a bit intimidated by the collection views - figured converting one of the most complex table views would be a good trial by fire [23:45:19] yep [23:45:28] brion: oh, i’ll show you some really fun face detection stuff tomorrow too! [23:45:33] mhurd: anything else i need to make sure i finish this week for you to work on? i’m trying to get caught up this week [23:45:51] will drag myself into the office and everything :) [23:46:29] agh phone got stuck in a reboot loop again :D [23:46:32] (03PS3) 10Jdlrobson: Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 [23:46:34] (03PS1) 10Jdlrobson: Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 [23:46:43] brion: i don’t think so - i may need a bucket to store another url or string in or something… but nothing huge comes to mind [23:46:59] ok that should be easy to add [23:47:07] we’ll get to it when we reach it [23:47:15] brion: yes@ [23:47:23] *!* [23:47:31] @YES :) [23:47:42] @“YES” [23:47:58] BOOL isYes = YES; [23:48:08] does NSString have a boolValue method? :D [23:48:16] ? haha probably [23:48:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move class name generation to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180344 (owner: 10Jdlrobson) [23:48:37] (03CR) 10jenkins-bot: [V: 04-1] Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 (owner: 10Jdlrobson) [23:49:45] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179948 (owner: 10Phuedx) [23:50:45] (03CR) 10Jdlrobson: [C: 032] Flag to disable main page transformations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180349 (owner: 10MaxSem) [23:53:59] (03Merged) 10jenkins-bot: Flag to disable main page transformations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180349 (owner: 10MaxSem)