[00:00:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Reinstate Baha's +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson)
[00:00:22] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Followup Ia6bf604c, I431a9025: Update way VE target is constructed [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180701 (owner: 10Jforrester)
[00:01:22] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: Make mobile watchlist use core code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149326 (https://bugzilla.wikimedia.org/68365) (owner: 10Jdlrobson)
[00:01:51] <grrrit-wm>	 (03PS2) 10Bmansurov: Hygiene: Update editor, mediaviewer, talk, tutorials, and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180912 
[00:01:57] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: Use Desktop Echo overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153615 (owner: 10Jdlrobson)
[00:02:04] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Beautified all the files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/169302 (owner: 10Jhernandez)
[00:02:12] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Enter brave new ResourceLoader world [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170174 (owner: 10Jdlrobson)
[00:02:17] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: Auto beautify files when adding them to the staging area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173026 (owner: 10Jhernandez)
[00:02:25] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Hygiene: Consistent file naming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172902 (https://bugzilla.wikimedia.org/73342) (owner: 10Jdlrobson)
[00:02:32] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: Don't add things to the DOM in postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173227 (owner: 10Jdlrobson)
[00:02:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Add documentation for PhotoApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180897 (owner: 10Jdlrobson)
[00:02:51] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: Add add discussion button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166079 (https://bugzilla.wikimedia.org/70614) (owner: 10Jdlrobson)
[00:04:03] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Update editor, mediaviewer, talk, tutorials, and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180912 (owner: 10Bmansurov)
[00:04:22] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Document PhotoUploaderButton.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180901 
[00:04:27] <jdlrobson>	 ^ bmansurov just waiting on tht now
[00:04:44] <bmansurov>	 jdlrobson: yep and then we can merge this https://gerrit.wikimedia.org/r/#/c/180888/
[00:05:15] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "untested but looks about right" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 (owner: 10MaxSem)
[00:05:42] <grrrit-wm>	 (03PS9) 10Jdlrobson: Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 
[00:06:30] <Krenair>	 dbrant, did you see https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8030681 ?
[00:07:00] <dbrant>	 Krenair: yes?
[00:07:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup Ia6bf604c, I431a9025: Update way VE target is constructed [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180701 (owner: 10Jforrester)
[00:07:24] <Krenair>	 it reminds me of the onCreateOptionsMenu NPE crash
[00:07:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Update editor, mediaviewer, talk, tutorials, and watchstar documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180912 (owner: 10Bmansurov)
[00:07:35] <Krenair>	 this is different though
[00:08:08] <dbrant>	 Krenair: it should also be taken care of by the same patch that fixed the createOptionsMenu variant.
[00:08:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 (owner: 10Jdlrobson)
[00:08:22] <Krenair>	 ok
[00:08:36] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Document PhotoUploaderButton.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180901 (owner: 10Jdlrobson)
[00:08:48] <Krenair>	 thanks
[00:10:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Document PhotoUploaderButton.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180901 (owner: 10Jdlrobson)
[00:11:28] <bmansurov>	 ^^^DONE^^^
[00:11:51] <grrrit-wm>	 (03PS2) 10Bmansurov: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 
[00:12:22] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Expose Wikidata descriptions via mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 (owner: 10MaxSem)
[00:13:06] <dbrant>	 ^^^ \o/
[00:13:16] <dbrant>	 mhurd: ^
[00:13:39] <mhurd>	 dbrant: whaaaat! that’s awesome!
[00:14:10] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Combine two seperate .jscsrc files into one. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:14:35] <mhurd>	 ship it!
[00:14:36] <mhurd>	 :)
[00:15:04] <grrrit-wm>	 (03CR) 10Mhurd: "THIS IS AWESOME!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 (owner: 10MaxSem)
[00:15:06] <grrrit-wm>	 (03CR) 10Bmansurov: Combine two seperate .jscsrc files into one. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:16:07] <grrrit-wm>	 (03CR) 10BearND: "Thank you! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 (owner: 10MaxSem)
[00:17:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expose Wikidata descriptions via mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180895 (owner: 10MaxSem)
[00:17:28] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Combine two seperate .jscsrc files into one. (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:18:21] <grrrit-wm>	 (03CR) 10Bmansurov: Combine two seperate .jscsrc files into one. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:18:32] <grrrit-wm>	 (03PS3) 10Esanders: Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 
[00:19:05] <grrrit-wm>	 (03PS3) 10Bmansurov: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 
[00:19:17] <bmansurov>	 jdlrobson: jscs is not complaining now. weird
[00:20:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[00:20:31] <grrrit-wm>	 (03CR) 10Esanders: "Thanks, I've gone through the less files looking for set width and height and found another 4 cases where padding existed. I've also added" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[00:20:45] <grrrit-wm>	 (03PS4) 10Bmansurov: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 
[00:20:49] <jdlrobson>	 bmansurov: you seem to have missed bycomments
[00:21:09] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "See my earlier comments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:22:23] <grrrit-wm>	 (03PS5) 10Bmansurov: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 
[00:22:59] <grrrit-wm>	 (03CR) 10Esanders: "Sorry, that will need to be .content * ..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[00:24:37] <grrrit-wm>	 (03PS4) 10Esanders: Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 
[00:25:08] <grrrit-wm>	 (03CR) 10Krinkle: "You can simply remove /*global module */" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:26:46] <grrrit-wm>	 (03PS6) 10Bmansurov: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 
[00:27:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Combine two seperate .jscsrc files into one. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:28:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[00:29:49] <grrrit-wm>	 (03CR) 10Bmansurov: Combine two seperate .jscsrc files into one. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[00:31:00] <grrrit-wm>	 (03PS2) 10Jdlrobson: Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 
[00:31:05] <grrrit-wm>	 (03PS3) 10Jdlrobson: Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 
[00:46:01] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Serve description even if the wiki data item has no instance of claims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 (owner: 10Jdlrobson)
[00:52:15] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Revert "Load correct page actions images" [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180696 (owner: 10Kaldari)
[00:52:39] <yurikR>	 MaxSem, do you know much about validating edit tokens
[00:53:13] <MaxSem>	 pfft yeah!
[00:53:42] <MaxSem>	 but my experience is that it just works for users and doesn't for anons:P
[00:54:21] <grrrit-wm>	 (03PS1) 10Jdlrobson: Correct RL targets for site module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 
[00:55:30] <grrrit-wm>	 (03CR) 10Jdlrobson: Fix structure suite (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180748 (owner: 10Phuedx)
[00:55:33] <yurikR>	 MaxSem, could you point me to how to a) generate token, and b) later validate that token
[00:56:12] <MaxSem>	 one sec, deploying
[00:57:10] <yurikR>	 MaxSem, when you are back:  i generated it with   $user->getEditToken( 'zeroportal' ),  and later compared the value against it, but it keeps generating a new one
[00:58:57] <MaxSem>	 there's validateToken() or something
[00:59:09] <jdlrobson>	 MaxSem: we still need a reply for you on https://phabricator.wikimedia.org/T72318 of a way forward..
[01:01:05] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] Infobox description editing (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 (owner: 10Jdlrobson)
[01:01:12] <yurikR>	 MaxSem, ah, thx, matchEditToken().
[01:04:59] <grrrit-wm>	 (03PS26) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 
[01:11:01] <grrrit-wm>	 (03PS1) 10Yurik: Proper edit token validation [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181012 
[01:11:15] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Proper edit token validation [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181012 (owner: 10Yurik)
[01:11:27] <wikibugs>	 3MobileFrontend-Feature-requests: Next and previous buttons in Media viewer - https://phabricator.wikimedia.org/T84959#934616 (10Jdlrobson) 3NEW
[01:11:40] <wikibugs>	 3MobileFrontend-Feature-requests: Next and previous buttons in mobile image viewer - https://phabricator.wikimedia.org/T84959#934616 (10Jdlrobson)
[01:11:56] <grrrit-wm>	 (03CR) 10MaxSem: [V: 032] "Fuck you jerkins." [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180696 (owner: 10Kaldari)
[01:12:17] <yurikR>	 MaxSem, could you ping me when done deploying? I might want to piggyback afterwards
[01:12:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Serve description even if the wiki data item has no instance of claims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180683 (owner: 10Jdlrobson)
[01:12:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Load correct page actions images" [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180696 (owner: 10Kaldari)
[01:14:48] <grrrit-wm>	 (03PS7) 10Jdlrobson: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[01:15:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "We said we wouldn't fix code hygiene issues unless jscs complained." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[01:16:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[01:18:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Proper edit token validation [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181012 (owner: 10Yurik)
[01:18:53] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/#/c/180122/2
[01:18:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Combine two seperate .jscsrc files into one. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180888 (owner: 10Bmansurov)
[01:19:50] <grrrit-wm>	 (03PS10) 10Jdlrobson: Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 
[01:42:09] <AndyRussG>	 Boo!
[01:42:14] * AndyRussG waves
[01:42:46] <AndyRussG>	 Hi, we found an issue with CentralNotice on mobile--getting some extra round-trips to the server that we didn't realize, due to redirection based on device
[01:43:32] <AndyRussG>	 Just thought I'd check in here to see if there is a preferred solution... (Sorry to ask so late in the day...)
[01:50:01] <grrrit-wm>	 (03CR) 10MaxSem: [C: 031] Hygiene: Move anonymousEditing config to EditorOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180122 (owner: 10Florianschmidtwelzow)
[02:07:50] <kaldari|2>	 awjr: You still around?
[02:17:04] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] Include the campaign property's Wikidata label (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx)
[02:21:57] <grrrit-wm>	 (03PS1) 10Jdlrobson: WIP: Untested Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 
[02:23:50] <Deskana>	 jdlrobso_: I don't know whether this is useful to you but we have some architecture around EventLogging in the apps if you're looking to draw inspiration.
[02:24:09] <jdlrobso_>	 Deskana: right now i'm just refactoring the mess we made
[02:24:13] <jdlrobso_>	 it's been bugging me for a while
[02:24:27] <grrrit-wm>	 (03PS1) 10Yurik: Simplified config changing to '+' and '-' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181021 
[02:24:29] <Deskana>	 We have one class called Funnel that everything else extends
[02:24:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Untested Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson)
[02:25:49] <grrrit-wm>	 (03PS2) 10Yurik: Simplified config changing to '+' and '-' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181021 
[02:25:56] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] Simplified config changing to '+' and '-' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181021 (owner: 10Yurik)
[02:26:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Simplified config changing to '+' and '-' [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/181021 (owner: 10Yurik)
[07:16:16] * Deskana eyeballs mhurd
[07:16:55] <mhurd>	 Deskana: hehe had a nice nap then got bored :)
[07:21:58] <Deskana>	 mhurd: Don't forget to relax!
[07:23:12] <Deskana>	 mhurd: Just after you left, I turned to Tomasz and said "Hey, I sent your engineer home. Er, my engineer. Erm, our engineer."
[07:23:20] <Deskana>	 mhurd: He said "You'll have to be more specific."
[07:23:26] <mhurd>	 Deskana: lol
[07:23:37] <Deskana>	 mhurd: So I replied "I sent Lead iOS Engineer 1 home"
[07:23:49] <Deskana>	 I don't think that's what he wanted from me :P
[07:24:13] <mhurd>	 Deskana: we’re indexed!
[07:26:53] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[07:28:53] <joakino>	 morning
[07:31:05] <grrrit-wm>	 (03PS20) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[07:46:53] <Deskana>	 Hey joakino
[07:46:59] <joakino>	 morning Deskana
[08:02:33] <grrrit-wm>	 (03CR) 10Krinkle: Let PHP check, if the user can edit a page or not (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[08:39:12] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[08:39:42] <grrrit-wm>	 (03PS21) 10Florianschmidtwelzow: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 
[09:07:33] <grrrit-wm>	 (03CR) 10Jhernandez: "I think as proven by the comments that this is mainly a philosophical CSS decision, and it affects not only current code but future work, " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[09:11:19] <grrrit-wm>	 (03CR) 10Jhernandez: WIP: TableOfContents uses events map (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[09:50:43] <phuedx>	 morning
[09:55:50] <grrrit-wm>	 (03CR) 10Jhernandez: WIP: Refactor Watchstar view to use EventsView (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[09:59:57] <grrrit-wm>	 (03CR) 10Phuedx: "Should Ifce458e31ad794750f7ba2719e1ef6a61836b44a be reverted then?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[10:02:34] <grrrit-wm>	 (03PS3) 10Phuedx: Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 
[10:03:21] <grrrit-wm>	 (03CR) 10Phuedx: Include the campaign property's Wikidata label (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx)
[10:10:24] <grrrit-wm>	 (03CR) 10Esanders: "I think enough of the major contributors are present here for this to proceed, if you feel anyone is missing please add them as a reviewer" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[10:13:40] <prtksxna>	 o/
[10:20:24] <grrrit-wm>	 (03CR) 10Jhernandez: "I've been looking at the EventEmitter connect function and tried to map it to the code in delegateEvents, but it doesn't work (or I don't " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez)
[10:21:07] <grrrit-wm>	 (03PS2) 10Jhernandez: WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 
[10:21:09] <grrrit-wm>	 (03PS2) 10Jhernandez: WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 
[10:21:11] <grrrit-wm>	 (03PS2) 10Jhernandez: WIP: Implement a view that features an event map for declarative event definitions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 
[10:21:13] <grrrit-wm>	 (03PS2) 10Jhernandez: WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 
[10:21:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[10:21:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez)
[10:21:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[10:22:24] <grrrit-wm>	 (03PS3) 10Jhernandez: WIP: Implement a view that features an event map for declarative event definitions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 
[10:28:11] <phuedx>	 hey prtksxna
[10:28:15] <phuedx>	 how're you?
[10:51:12] <phuedx>	 joakino: does make jscsdoc work for you on master?
[10:52:23] <joakino>	 phuedx: i can't check right now, i'm drowning in three-way merge conflicts because the documentation patches
[10:52:27] <joakino>	 i'll tell you in a bit
[10:52:37] <phuedx>	 lol
[10:52:45] <phuedx>	 i mean "oh noes"
[10:52:46] <phuedx>	 obvs ;)
[10:55:09] <joakino>	 PAEWRUFJASELJID
[10:55:20] <joakino>	 remote: (W) No changes between prior commit 3e37cbd and new commit 1968f9e 
[10:55:28] <joakino>	 what about you fuck off and send it anyway
[10:55:32] <joakino>	 jesus
[10:59:12] <grrrit-wm>	 (03PS3) 10Jhernandez: WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 
[10:59:13] <grrrit-wm>	 (03PS3) 10Jhernandez: WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 
[10:59:16] <grrrit-wm>	 (03PS4) 10Jhernandez: WIP: Implement a view that features an event map for declarative event definitions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 
[10:59:18] <grrrit-wm>	 (03PS3) 10Jhernandez: WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 
[11:02:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement a view that features an event map for declarative event definitions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez)
[11:12:19] <grrrit-wm>	 (03CR) 10Jhernandez: "True, inherit may be a problem too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[11:49:53] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "Minor points inline. I'll kick the tyres now." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov)
[12:15:43] <grrrit-wm>	 (03CR) 10Jhernandez: Move file upload support detection to browser.js (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[12:16:14] <grrrit-wm>	 (03PS2) 10Jhernandez: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 
[12:16:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[12:19:11] <grrrit-wm>	 (03CR) 10Jhernandez: Move file upload support detection to browser.js (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[12:35:13] <grrrit-wm>	 (03PS3) 10Jhernandez: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 
[12:35:31] <grrrit-wm>	 (03CR) 10Jhernandez: "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[12:37:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[13:47:55] <grrrit-wm>	 (03PS1) 10Jhernandez: Remove jscsdoc objective [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181060 
[13:48:34] <joakino>	 phuedx: ^ jscsdoc has been merged with jscs so now the jscs task checks for docs too
[13:50:13] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Remove jscsdoc objective [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181060 (owner: 10Jhernandez)
[13:50:21] <phuedx>	 thanks for clearing that up joakino 
[13:50:48] <joakino>	 phuedx:  i'm still seeing a bunch of errors on pre-review, i'm going to check pending patches for the documentation
[13:51:15] <phuedx>	 joakino: see jon's latest comment: https://trello.com/c/X8qu3ZYx/54-5-fix-up-remaining-documentation-warnings-for-make-jscsdoc
[13:51:49] <joakino>	 phuedx: aah alright, i may pick that up
[13:52:33] <joakino>	 phuedx: i've been working since early today, I'll leave for lunch soon and come back for a bit more, but I have to leave at 5 gmt+1 (car trip!)
[13:52:46] <joakino>	 i'll send an email later and write the standup stuff down
[13:52:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove jscsdoc objective [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181060 (owner: 10Jhernandez)
[13:52:53] <phuedx>	 joakino: sure
[13:52:57] <phuedx>	 are you off next week?
[13:53:07] <joakino>	 phuedx: no, just the standard vacations
[13:53:13] <joakino>	 and you?
[13:56:17] <phuedx>	 i'm taking three days to make it a week
[13:56:40] <phuedx>	 no one had any objections so…
[13:56:41] * phuedx runs
[13:58:46] <phuedx>	 but christmas with george and harry will be pretty dern special
[14:09:40] <wikibugs>	 3Wikipedia-App-Android-App: (Android 2.3) Lead image remains "clickable" even after sliding away. - https://phabricator.wikimedia.org/T84998#936275 (10Dbrant) 3NEW a:3Dbrant
[14:17:30] <grrrit-wm>	 (03PS1) 10Jhernandez: Fix MobileWebClickTracking documentation errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 
[14:17:32] <grrrit-wm>	 (03PS1) 10Jhernandez: Fix MW_INSTALL_PATH to default to local installation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 
[14:18:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix MW_INSTALL_PATH to default to local installation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[14:19:22] <joakino>	 phuedx: yeah super family :D
[14:19:36] <joakino>	 Jenkins is so picky today
[14:23:35] <grrrit-wm>	 (03PS1) 10Dbrant: Fix lead image click area in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181065 
[14:41:14] <grrrit-wm>	 (03PS1) 10Dbrant: Fix possible NPE(s) when accessing parent fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181068 
[15:18:00] <grrrit-wm>	 (03PS1) 10Lokal Profil: Add missing word to parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181072 
[15:21:31] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181072 (owner: 10Lokal Profil)
[15:23:04] <grrrit-wm>	 (03CR) 10Phuedx: Fix MobileWebClickTracking documentation errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 (owner: 10Jhernandez)
[15:23:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing word to parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181072 (owner: 10Lokal Profil)
[15:23:20] <grrrit-wm>	 (03CR) 10Phuedx: "No -1 because I'm not sure we actually use @singleton." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 (owner: 10Jhernandez)
[15:23:32] <phuedx>	 COFFEE TIME
[15:26:50] <joakino>	 phuedx: what's up with the singleton?
[15:26:57] <joakino>	 i've seen it in other parts of the codebase
[15:27:23] <joakino>	 for example in javascripts/application.js
[15:27:43] <phuedx>	 joakino: https://github.com/senchalabs/jsduck/wiki/@singleton
[15:28:52] <joakino>	 phuedx: so we are actually using it in other files like application.js
[15:28:57] <joakino>	 do you want me to add it?
[15:29:12] <joakino>	 i already had, just missing the git review :p
[15:29:34] <phuedx>	 joakino: yeah, go for it
[15:29:59] <grrrit-wm>	 (03PS2) 10Jhernandez: Fix MobileWebClickTracking documentation errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 
[15:30:01] <grrrit-wm>	 (03PS2) 10Jhernandez: Fix MW_INSTALL_PATH to default to local installation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 
[15:31:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix MW_INSTALL_PATH to default to local installation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[15:32:40] <joakino>	 jenkins is failing in all patches (the mwext-MobileFrontend-qunit task) :/
[15:40:01] <grrrit-wm>	 (03CR) 10Jhernandez: Fix MobileWebClickTracking documentation errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 (owner: 10Jhernandez)
[15:42:31] <grrrit-wm>	 (03CR) 10Phuedx: Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov)
[16:11:10] <grrrit-wm>	 (03PS1) 10Dbrant: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 
[16:14:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant)
[16:17:23] <grrrit-wm>	 (03PS1) 10Dbrant: Fix checkstyle. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181084 
[16:18:21] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix checkstyle. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181084 (owner: 10Dbrant)
[16:18:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix checkstyle. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181084 (owner: 10Dbrant)
[16:19:19] <grrrit-wm>	 (03PS2) 10Dbrant: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 
[16:40:30] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Fix MW_INSTALL_PATH to default to local installation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[16:40:44] <grrrit-wm>	 (03PS2) 10BearND: Fix lead image click area in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181065 (owner: 10Dbrant)
[16:40:52] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix lead image click area in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181065 (owner: 10Dbrant)
[16:41:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix lead image click area in 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181065 (owner: 10Dbrant)
[16:46:29] <grrrit-wm>	 (03PS2) 10BearND: Fix possible NPE(s) when accessing parent fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181068 (owner: 10Dbrant)
[16:46:36] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix possible NPE(s) when accessing parent fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181068 (owner: 10Dbrant)
[16:46:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix possible NPE(s) when accessing parent fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181068 (owner: 10Dbrant)
[16:51:30] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Fix MobileWebClickTracking documentation errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 (owner: 10Jhernandez)
[16:51:57] <grrrit-wm>	 (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[16:52:09] <phuedx>	 jenkins really hates you joakino
[16:52:10] <phuedx>	 hey jdlrobson 
[16:52:49] <jdlrobson>	 woooo! hey phuedx
[16:55:55] <bearND>	 dbrant: any reservations about https://gerrit.wikimedia.org/r/#/c/180868/2?
[16:56:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix MobileWebClickTracking documentation errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181062 (owner: 10Jhernandez)
[16:56:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix MW_INSTALL_PATH to default to local installation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[16:56:55] <dbrant>	 bearND: none! looks good
[16:57:10] <grrrit-wm>	 (03PS3) 10BearND: Add X-WMF-UUID to Wikipedia for Android requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt)
[16:58:04] <grrrit-wm>	 (03CR) 10Jdlrobson: "Let's be careful here. Ideally this should be the value used by Jenkins since that is the end goal (https://trello.com/c/o79gX3x5)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[16:58:45] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Add X-WMF-UUID to Wikipedia for Android requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt)
[16:59:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add X-WMF-UUID to Wikipedia for Android requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180868 (owner: 10Dr0ptp4kt)
[16:59:15] <grrrit-wm>	 (03PS3) 10BearND: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant)
[16:59:27] <jdlrobson>	 phuedx: https://phabricator.wikimedia.org/T78590 is the problem
[16:59:31] <jdlrobson>	 that's why jenkins is all screwy
[16:59:55] <jdlrobson>	 unless something new is happening
[17:00:41] <phuedx>	 i doubt it
[17:02:06] <grrrit-wm>	 (03CR) 10Phuedx: "I'd go one further: bail immediately – with a clear error message (!) – if it ain't set." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181063 (owner: 10Jhernandez)
[17:03:46] <phuedx>	 so this is pretty dern amazing news: http://blog.travis-ci.com/2014-12-19-introducing-travis-ci-enterprise/
[17:19:44] <grrrit-wm>	 (03CR) 10Jdlrobson: "I'm pretty swamped with code review and other things and I promise I will look into this later when I have time and revisit the decision." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[17:22:12] <jdlrobson>	 phuedx: can you merge https://gerrit.wikimedia.org/r/#/c/180312/?
[17:23:26] * phuedx takes a look
[17:26:06] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 (owner: 10Jdlrobson)
[17:26:12] <jdlrobson>	 thanks a bunch :)
[17:26:22] <jdlrobson>	 hey phuedx as for https://gerrit.wikimedia.org/r/#/c/181010/
[17:27:21] <jdlrobson>	 i'll remove desktop target from user module in same patch
[17:27:25] <jdlrobson>	 no need for revert
[17:31:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 (owner: 10Jdlrobson)
[17:31:16] <grrrit-wm>	 (03PS2) 10Jdlrobson: Correct RL targets for site module and user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 
[17:31:53] <grrrit-wm>	 (03PS4) 10Jdlrobson: Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 
[17:31:58] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 (owner: 10Jdlrobson)
[17:33:04] <phuedx>	 jdlrobson: cool.io
[17:33:12] <phuedx>	 i should stop typing that actually
[17:34:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Correct RL targets for site module and user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[17:35:05] <phuedx>	 jdlrobson: bleh
[17:35:13] <jdlrobson>	 we need to fix that issue
[17:35:17] <jdlrobson>	 with jenkins
[17:35:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary rule to fix issues overlay rendering [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180312 (owner: 10Jdlrobson)
[17:37:05] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "Doesn't break the structure test suite and the comments make sense. Woo!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[17:38:26] * phuedx waits for jerkins to V: -1
[17:38:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Correct RL targets for site module and user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[17:39:06] <wikibugs>	 3Mobile-Web, MobileFrontend-alpha: Issues in overlay render strangely - https://phabricator.wikimedia.org/T78708#936558 (10phuedx) 5Open>3Resolved a:3phuedx
[17:39:53] <phuedx>	 jdlrobson: that's actually a genuine build failure ;)
[17:41:06] <jdlrobson>	 bahh
[17:52:39] <grrrit-wm>	 (03CR) 10BearND: "We should ask designers for a different icon since this is a repetition of the regular share action. Some suggestions from the material de" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant)
[17:53:39] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: jscs should check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181098 
[17:53:41] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 
[17:53:43] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181100 
[17:53:45] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: check types are valid in jsdocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 
[17:55:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: jscs should check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181098 (owner: 10Jdlrobson)
[17:56:15] <grrrit-wm>	 (03PS3) 10Jdlrobson: Correct RL targets for site module and user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 
[17:56:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: jscs should check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181098 
[17:57:37] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: jscs should check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181098 
[17:58:00] <grrrit-wm>	 (03PS11) 10Jdlrobson: Move M.isIos to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180351 
[17:58:11] <grrrit-wm>	 (03PS4) 10Jdlrobson: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[18:04:02] <grrrit-wm>	 (03CR) 10Esanders: "I'm not saying border-box isn't a sensible model, but you can't apply styles to things you don't own. Per my last response to Joaquin, pro" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (owner: 10Esanders)
[18:04:04] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Correct RL targets for site module and user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[18:05:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct RL targets for site module and user module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[18:14:35] <bearND>	 dbrant: any idea on how to get the selected text for "share a text snippet"?
[18:15:34] <dbrant>	 bearND: nope! I haven't looked into that yet
[18:17:36] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[18:17:42] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[18:17:52] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Move file upload support detection to browser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[18:18:56] <jdlrobson>	 rmoen: so i'm having this issue https://phabricator.wikimedia.org/T78733
[18:19:46] <rmoen>	 jdlrobson: same ;/
[18:20:12] <rmoen>	 jdlrobson: I've been doing vagrant reload and it sometimes helps
[18:20:20] <rmoen>	 rather it seems to help
[18:20:25] <rmoen>	 for a bit
[18:20:27] <jdlrobson>	 rmoen: is it minification too?
[18:20:51] <grrrit-wm>	 (03PS21) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 
[18:21:59] <jdlrobson>	 rmoen: i assume https://trello.com/c/o0l0dKAd/13-3-alpha-beta-make-reference-dialog-scrollable is the card?
[18:22:02] <jdlrobson>	 it was archived for some reason
[18:22:41] <rmoen>	 jdlrobson: yes that was the card
[18:23:26] <grrrit-wm>	 (03PS22) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 
[18:25:44] <rmoen>	 jdlrobson: somehow my vagrant is running quickly again
[18:25:53] <rmoen>	 jdlrobson: so i'm not sure if we are having the same issue
[18:26:05] <rmoen>	 Seems that monitoring it sped it up...
[18:27:56] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: check return types (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181100 (owner: 10Jdlrobson)
[18:29:12] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Remove redundant returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181099 (owner: 10Jdlrobson)
[18:31:50] <dr0ptp4kt>	 dfoy_ tfinc Deskana|Away i'm going to have some lunch with some friends. available by cell until i return...
[18:31:58] <dbrant>	 bearND: that's very curious... I wouldn't want to resort to using JS to get the selected text.. :(
[18:31:58] <tfinc>	 dr0ptp4kt: ok
[18:32:04] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: jscs should check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181098 (owner: 10Jdlrobson)
[18:32:39] <dbrant>	 bearND: it looks like the webview has a getSelection() method, but it's package-private
[18:33:08] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: check types are valid in jsdocs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 (owner: 10Jdlrobson)
[18:34:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: jscs should check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181098 (owner: 10Jdlrobson)
[18:37:33] <Deskana>	 dr0ptp4kt: Cheers Adam!
[18:51:00] <mhurd>	 brion: wikidata description in mobileview patch: https://gerrit.wikimedia.org/r/#/c/180895/ (should be live early next month, could add params for it, commented out maybe w/ fake descrip being put in the article description bucket for now?)
[18:51:34] <brion>	 tx
[18:51:46] <brion>	 yeah i’ll add those in a bit
[18:56:26] <Krenair>	 dbrant, any ideas about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7938876 ?
[18:56:51] <Krenair>	 I'm not quite sure what the issue is
[18:59:41] <dbrant>	 Krenair: not sure at all...  I would have responded the same as you did.
[19:05:12] <bmansurov>	 kaldari: could you please review https://gerrit.wikimedia.org/r/#/c/180884/ ? thanks
[19:06:41] <phuedx>	 finally!
[19:06:54] <phuedx>	 back on the line
[19:07:18] <bmansurov>	 phuedx: wikigrok in sidebar has been waiting for you ;)
[19:07:56] <jdlrobson>	 MaxSem: http://localhost:8080/w/load.php?debug=false&lang=en&modules=skins.minerva.chrome.styles&only=styles&skin=minerva&target=mobile&forceprofile=1
[19:08:12] <jdlrobson>	 phuedx: are you having any slowdown issues in vagrant with that url ^
[19:08:42] <jdlrobson>	 in incognito mode it is taking 5.3s
[19:10:17] <phuedx>	 timing in prod?
[19:10:37] <jdlrobson>	 626ms
[19:10:49] <jdlrobson>	 http://en.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=skins.minerva.chrome.styles&only=styles&skin=minerva&target=mobile
[19:11:13] <jdlrobson>	 http://en.m.wikipedia.org/w/load.php?debug=false&lang=en&modules=mediawiki.ui.button%7Cmobile.pagelist.styles%7Cskins.minerva.alpha.styles%7Cskins.minerva.chrome.styles%7Cskins.minerva.content.styles%7Cskins.minerva.content.styles.beta%7Cskins.minerva.drawers.styles%7Cskins.minerva.icons.styles%7Cskins.minerva.tablet.styles%7Cskins.minerva.tablet.styles.beta&only=styles&skin=minerva&target=mobile&forceprofile=1 is 1.22s
[19:11:24] <jdlrobson>	 which is the stylesheet we load in beta
[19:11:49] <jdlrobson>	 locally that same url is ridiculously slow for me
[19:12:03] <jdlrobson>	 25.77s
[19:12:23] <jdlrobson>	 i think something is b0rked with caching on vagrant
[19:12:44] <jdlrobson>	 phuedx ^
[19:12:57] <jdlrobson>	 how long does that url take for you to load?
[19:13:01] <jdlrobson>	 same question to bmansurov
[19:13:04] <jdlrobson>	 and rmoen
[19:14:22] <phuedx>	 sec, hammering my vm
[19:15:06] <phuedx>	 good ol' ab
[19:17:07] <bmansurov>	 jdlrobson: the last url: 1.06s
[19:17:28] <bmansurov>	 the one before that 57ms
[19:17:55] <bmansurov>	 and the local one is 2.20s
[19:19:01] <phuedx>	 first local url is taking 1.7s
[19:19:35] <rmoen>	 jdlrobson: takes me like a second to load that url
[19:19:45] <jdlrobson>	 mmm
[19:19:48] <jdlrobson>	 why me so long
[19:19:54] <jdlrobson>	 what roles do you have enabled?
[19:20:31] <phuedx>	 jdlrobson: takes ~6s to load the last url
[19:20:53] <bmansurov>	 jdlrobson: cite, echo, geodata, mantle, mobilefrontend, parsoid, scribunto, wikigrok
[19:21:09] <phuedx>	 echo, ve, mf, betafeatures, scrubuntu, wikigrok, parsoid, geodata, mantle
[19:21:30] <phuedx>	 recently disabled cirrussearch because i was breaking all the things after an update
[19:26:44] <jdlrobson>	 phuedx: 6s is slow still
[19:26:51] <phuedx>	 absolument
[19:27:14] <jdlrobson>	 http://localhost:8080/w/load.php?debug=false&lang=en&modules=mediawiki.ui.button%7Cmobile.pagelist.styles%7Cskins.minerva.alpha.styles%7Cskins.minerva.chrome.styles%7Cskins.minerva.content.styles%7Cskins.minerva.content.styles.beta%7Cskins.minerva.drawers.styles%7Cskins.minerva.icons.styles%7Cskins.minerva.tablet.styles%7Cskins.minerva.tablet.styles.beta&only=styles&skin=minerva&target=mobile&forceprofile=1 < slow slow 
[19:27:14] <jdlrobson>	 slow
[19:27:30] <bmansurov>	 I noticed that vagrant tends to work faster after restart of the host machine.
[19:30:27] <rmoen>	 jdlrobson: that one runs just fine for me
[19:30:49] <rmoen>	 vagrant is being nice to me today
[19:39:17] <phuedx>	 what has jdlrobson done to incur the wrath of the vagrant gods?
[20:02:05] <brion>	 mhurd: current diff on my work branch https://github.com/brion/apps-ios-wikipedia/compare/workstuff?expand=1
[20:03:45] <wikibugs>	 3Wikipedia-App-Android-App: (Android 2.3) Lead image remains "clickable" even after sliding away. - https://phabricator.wikimedia.org/T84998#936831 (10Dbrant) 5Open>3Resolved https://gerrit.wikimedia.org/r/181065
[20:13:05] <rmoen>	 picking up pencil bug
[20:17:08] <rmoen>	 arrg, vagrant now crawling along
[20:29:08] <grrrit-wm>	 (03PS1) 10Robmoen: WIP: Fix for header covering edit pencil in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181123 
[20:29:48] <rmoen>	 Bout to leave for doctors appt.  If someone is inclined they can finish the padding issues with ^  
[20:30:06] <rmoen>	 Alpha pencil thingy
[20:30:15] <rmoen>	 be back in a few
[20:44:35] <grrrit-wm>	 (03CR) 10Hashar: "Thank you very much Jon for the follow up!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181010 (owner: 10Jdlrobson)
[20:46:10] <jdlrobson>	 this makes me sad
[20:46:16] <jdlrobson>	 seems to be related to LESS compiler
[20:51:06] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: WIP: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[20:54:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[20:56:55] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: WIP: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[21:13:45] <dbrant>	 bearND: I can think of one possible way to get the text selection, but it's extremely hacky:
[21:14:37] <bearND>	 dbrant: using reflection?
[21:14:54] <dbrant>	 bearND: nope:
[21:15:02] <dbrant>	 bearND: while the WebView is in the context mode, we could programmatically fire the "Copy" menu button, which copies the selected text to the clipboard, then simply peek at the contents of the clipboard.
[21:15:29] <bearND>	 dbrant: cool. that could work
[21:16:17] <dbrant>	 bearND: I actually don't think reflection would work for all APIs, because it looks like API 19+ doesn't even have getSelection anymore (not even privately).
[21:28:35] <mhurd>	 brion: dbrant sorry i monopolized so much of the apps chat time!
[21:28:43] <brion>	 no worries it was good stuff :D
[21:29:05] <dbrant>	 mhurd: np! my concerns were very similar
[21:29:23] <mhurd>	 brion: dbrant *relieved*
[21:30:11] <Deskana>	 For me, it's good to hear that they're well aware that this is slowing down routine development.
[21:30:20] <Deskana>	 And that they're okay with that.
[21:30:27] <Deskana>	 My challenge now is to become okay with it myself. ;)
[21:35:09] <brion>	 argh now it’s saving the global images.plist but not per-section
[21:35:12] * brion bangs on some more things until it works
[21:38:06] <brion>	 http://en.wiktionary.org/wiki/percussive_maintenance
[21:38:21] <mhurd>	 Deskana: hmmm unsure how ok with that i am… you can only strain/disrupt things so much before cadence falters… *pictures researcher kicking that ‘big dog’ robot so hard it falls down*
[21:38:57] <Deskana>	 mhurd: Yes indeed. I am unsure too. But it helps to an extent to be able to tell people that Lila and Damon are the ones that want us to do it.
[21:41:20] <brion>	 i think we need some dedicated r&d team time, but it’s tough to build that kind of thing out when we have so much else to do too :)
[21:42:52] <Deskana>	 Yep.
[21:43:19] <Deskana>	 I'd go further, we also need a dedicated R&D team *as well* as a mobile apps team
[21:44:58] <mhurd>	 Deskana: +1
[21:46:17] <brion>	 oh yeah
[21:46:34] <mhurd>	 Deskana: r&d is often separate for good reason - it’s so fundamentally different in purpose
[21:46:55] <Deskana>	 Yep, and as much as I agree with Damon and Lila, I think that we can't just drop the Wikipedia app.
[21:47:12] <Deskana>	 Facebook does R&D. But do they stop working on the Facebook app?
[21:47:25] <Deskana>	 Google does R&D. Do they stop working on search?
[21:47:42] <mhurd>	 Deskana: exactly, i think that’s a detail they’ll be receptive to
[21:48:24] <dbrant>	 Deskana: mhurd: it's so much more imperative for us to get the app right.  first and foremost.
[21:49:22] <dbrant>	 And aren't we indirectly doing r&d within the app by creating all these new features?
[21:49:54] <mhurd>	 dbrant: ya that was the point i tried to make
[21:50:50] <mhurd>	 dbrant: that was one of my main concerns going in as well
[21:51:06] <Deskana>	 Indeed. Lila wants us to take it further.
[21:51:18] <Deskana>	 Which is fine. It's great!
[21:51:36] <Deskana>	 But... let's be realistic.
[21:51:38] <Deskana>	 Two engineers per platform!
[21:51:56] <mhurd>	 Deskana: yes it’s awesome. but as you say, 2 engineers…
[21:51:58] <bearND>	 dbrant: Deskana: no idea what you are discussing. Was there a meeting i missed?
[21:54:51] <dbrant>	 bearND: want to jump in batcave?
[21:55:00] <bearND>	 sure
[21:55:30] <brion>	 :) batcave
[22:01:24] <Krenair>	 Deskana, how's the more-otrs-volunteers thing going?
[22:02:04] <Deskana>	 I've been drafting the email, but I keep getting distracted by other stuff. I'll try and finish that email by the end of the day.
[22:02:05] <tfinc>	 Deskana: how is the overall beta feedback looking for lead images ?
[22:02:19] <Deskana>	 tfinc: Very good! Lots of 5 star ratings.
[22:03:04] <tfinc>	 Deskana: any direct feedback about it past what Andy sent us?
[22:03:19] <Deskana>	 tfinc: Nothing explicit.
[22:03:27] <Deskana>	 tfinc: There are gems like this though: "Compared to original versions of Beta, latest versions are definitely miles ahead in improvement and optimizations."
[22:04:01] <Deskana>	 "Better and better."
[22:04:11] <tfinc>	 great, Deskana: did the specialist guild test on 2.3 ?
[22:04:46] <Deskana>	 tfinc: We've not actually got them to test it yet. I think now is a good time.
[22:05:07] <tfinc>	 Deskana: yes, do a round with them if we're seeing so many 2.3 issues 
[22:05:09] <mhurd>	 Deskana: those *are* gems! great work guys!
[22:05:17] <tfinc>	 their are likely more then what Andy reported 
[22:05:31] <Deskana>	 tfinc: Agreed.
[22:05:32] <tfinc>	 and we need that list 
[22:06:23] <Krenair>	 The android app gets more email feedback than can be dealt with.
[22:06:55] <Krenair>	 currently sitting at 325 open tickets
[22:07:16] <Deskana>	 Krenair: I'll get that email sent to the OTRS admins by the end of the day. 
[22:07:23] <Krenair>	 going all the way back to june
[22:07:24] <Deskana>	 Krenair: Thank you for your work on it so far.
[22:07:26] <Krenair>	 ok
[22:07:49] <Krenair>	 Let me assure you at least one OTRS admin is very well aware of the issue :)
[22:11:37] <dbrant>	 Deskana: bearND:  what do you think of doing a beta release next week (while i'm gone)?  I think the lead-image issue on 2.3 is fairly serious, and should be patched asap.  It may be contributing to Andy's frustration, as well.
[22:12:18] <bearND>	 dbrant: Deskana: I'll be gone next week, too. We should do one today
[22:12:29] <Deskana>	 GO!
[22:12:37] <mhurd>	 Deskana: to your earlier point about “our job being getting the app right first and formost” - i agree. to elaborate, our primary job involves innovating to the point we can be innovative *and* have something production-ready and actually usable/maintainable that we can develop and push to production within a predictable time period. but pure blue sky R&D of the “we should do more” type Lila wants should not be constrained by *an
[22:12:38] <mhurd>	 resposibilities. they’re fundamentally different things.
[22:14:10] <bearND>	 dbrant: how about I do a quick TWN sync, and then you build a beta?
[22:14:34] <dbrant>	 bearND: agreed!
[22:15:56] <brion>	 arggggggh ok that explains why section wasn’t working. it wasn’t lazy-loading, it was always-loading
[22:15:58] * brion stabba
[22:16:54] <grrrit-wm>	 (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181176 
[22:18:07] <brion>	 whafu error: warning: couldn't get cmd pointer (substituting NULL): no variable named '_cmd' found in this frame
[22:22:25] <Deskana>	 Krenair: Alright, I got an email to them out of the door. Apologies for my delay, and thanks once again for working so hard on this. :)
[22:22:29] <grrrit-wm>	 (03PS1) 10MaxSem: Ensure file page mobile views have the proper title in context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181178 
[22:25:42] <grrrit-wm>	 (03PS2) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181176 
[22:26:31] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181176 (owner: 10BearND)
[22:27:20] <bearND>	 dbrant: it's ready
[22:27:38] <dbrant>	 bearND: thanks! building...
[22:27:57] <bearND>	 dbrant: bumo first?
[22:28:01] <bearND>	 bump
[22:28:16] <dbrant>	 ah of course
[22:29:05] <bearND>	 dbrant: oh, the patch still needs zuul to merge it
[22:29:59] <dbrant>	 waiting...
[22:32:47] <mhurd>	 dbrant: have a sec for hangout?
[22:32:54] <dr0ptp4kt>	 Deskana: mhurd, you guys able to chat in 30-45 minutes? i'm in a car at the moment, but wanted to circle with you before i wrap up.
[22:33:17] <Deskana>	 dr0ptp4kt: Maybe... I'm in a Q3 priorities meeting.
[22:33:26] <Deskana>	 dr0ptp4kt: It might be done by then!
[22:33:46] <mhurd>	 dr0ptp4kt: if dan’s available sure
[22:33:47] <dr0ptp4kt>	 Deskana: cool. cc mhurd ^
[22:33:48] <DarTar>	 jdlrobson: remember the meta referer tag thing? Legal and the execs cleared it, who should I ask to write a patch?
[22:33:55] <dr0ptp4kt>	 mhurd: cool
[22:34:14] <jdlrobson>	 DarTar: if you drop me a mail i can add this to my to do list
[22:34:15] <Krenair>	 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8028864 - hmm.. IPA stuff shows to me...
[22:34:17] <jdlrobson>	 no deployments till jan though
[22:34:25] <dbrant>	 mhurd: yep, but just for a few minutes
[22:34:34] <Krenair>	 at least partially
[22:37:33] <DarTar>	 jdlrobson: splendid, and not urgent at all (I just need to know when it hits prod so I can talk to our external partners and see if it affected them, we’re talking to BBC)
[22:37:43] <DarTar>	 jdlrobson: I’ll drop you a line
[22:39:30] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Support dynamic HTTPS not free message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/181194 
[22:43:08] <mhurd>	 dbrant: <!DOCTYPE html>
[22:43:19] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "I have an idea for improving this slightly..." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx)
[22:47:57] <dbrant>	 bearND: i've got to step out for awhile, but i'll take care of the build later. (when zuul wakes up)
[22:49:12] <dbrant>	 bearND: or if you want to push it out, that would be awesome, too
[22:49:14] <bearND>	 dbrant: ok. I've asked for help on the qa channel. Hope they get zuul back up again
[22:49:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181176 (owner: 10BearND)
[22:50:09] <grrrit-wm>	 (03PS27) 10Jdlrobson: Infobox description editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/170436 
[22:50:11] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Use Wikibase for infobox labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181196 
[22:50:13] <grrrit-wm>	 (03PS1) 10Jdlrobson: Remove images from infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181197 
[22:50:15] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Make instance of property id configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181198 
[22:50:17] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 
[22:50:20] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Kill dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181200 
[22:50:22] <grrrit-wm>	 (03PS1) 10Jdlrobson: WIP: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 
[22:50:34] <grrrit-wm>	 (03CR) 10MaxSem: Include the campaign property's Wikidata label (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx)
[22:50:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181176 (owner: 10BearND)
[22:52:36] <grrrit-wm>	 (03PS1) 10Brion VIBBER: (Work in progress) Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 
[22:53:06] <brion>	 mhurd: ok that’s the squashed commit with latest updates
[22:53:21] <grrrit-wm>	 (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181203 
[22:53:22] <brion>	 i still have a regression causing thumbnails not to load in lists which i want to fix
[22:53:25] <mhurd>	 brion: woohoo! checking…
[22:53:35] <brion>	 mhurd: but wanted to make sure you have a chance to look it over in gerrit while i’m doing the final fixes
[22:54:03] <mhurd>	 brion: k. i’ll switch over to poking it now…
[22:54:14] <brion>	 note this creates separate Images.plist / MWKImageList objects for the whole article and for each section, so you can grab by the whole article or per-section
[22:54:33] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181203 (owner: 10BearND)
[22:55:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181203 (owner: 10BearND)
[22:56:54] <brion>	 brb coffee
[22:57:04] <bearND>	 dbrant|bbl: ok, doing the rest of the release
[23:02:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 (owner: 10Jdlrobson)
[23:05:56] <grrrit-wm>	 (03CR) 10Mhurd: "Added quick comment to article fetcher query params..." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER)
[23:06:35] <brion>	 mhurd: ah good catch, i got halfway through that one :D
[23:06:57] <mhurd>	 brion: thumbs! :)
[23:09:13] <brion>	 who’s got a thumb and can load articles? ArticleFetcher!
[23:10:51] <grrrit-wm>	 (03CR) 10Mhurd: "Loop "copy" comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER)
[23:13:22] <grrrit-wm>	 (03CR) 10Brion VIBBER: "iteration without copy should be safe here; no CoreData magic changing our data behind from under us. Note it's actually iterating on an M" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER)
[23:14:17] <grrrit-wm>	 (03CR) 10Mhurd: "Yay!" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER)
[23:14:22] <brion>	 :D
[23:14:58] <brion>	 the NSFastIteration protocol is kinda weird but not too tricky once you find reference materials for it :D
[23:15:27] <brion>	 and it makes me happy to do for loops without having to cast an extra array in there somewhere
[23:15:37] <grrrit-wm>	 (03PS1) 10Kaldari: Making WikiGrok pull property ID and name from new campaign data [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181208 
[23:16:31] <mhurd>	 brion: i read that article you posted to my facebook page - such a cool find!
[23:17:00] <brion>	 i was pretty sure the subscripts were some kind of syntactic sugar, just needed the docs :D and adding iteration makes the illusion complete
[23:17:31] <brion>	 i sure hope that works with swift…. i should double-check :D
[23:17:38] <brion>	 well it should, NSArray and stuff use it
[23:17:58] <brion>	 and those are all over the cocoa apis
[23:19:03] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[23:20:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Let PHP check, if the user can edit a page or not [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178793 (owner: 10Florianschmidtwelzow)
[23:21:12] <grrrit-wm>	 (03PS2) 10Jdlrobson: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 
[23:23:34] <grrrit-wm>	 (03PS2) 10Kaldari: Making WikiGrok pull property ID and name from new campaign data [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181208 
[23:24:54] <kaldari>	 MaxSem: What changed about ProfileSection?
[23:25:14] <MaxSem>	 kaldari, it's getting replaced by xhprof
[23:25:30] <kaldari>	 oh, nice
[23:26:13] <grrrit-wm>	 (03CR) 10Bmansurov: "Why should this piece of code be loaded everywhere? I don't think this is a good move." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez)
[23:26:55] <wikibugs>	 3Wikipedia-App-Android-App: Barack Obama article has the infobox collapsed inside another collapsed table (yo dawg) - https://phabricator.wikimedia.org/T77802#937292 (10KLans_WMF) p:5Triage>3Normal
[23:27:16] <wikibugs>	 3Wikipedia-App-Android-App: Barack Obama article has the infobox collapsed inside another collapsed table (yo dawg) - https://phabricator.wikimedia.org/T77802#830818 (10KLans_WMF) This bug is tracked here: https://trello.com/c/vV00vwat/36-bug-t77802-barack-obama-article-has-the-infobox-collapsed-inside-another-c...
[23:28:59] <wikibugs>	 3MediaWiki-API, Mobile-Web, Wikipedia-App-Android-App: "description page there" (commons images) links to [[commons:file:API]] - https://phabricator.wikimedia.org/T78003#937295 (10KLans_WMF) p:5Triage>3Normal
[23:29:40] <grrrit-wm>	 (03PS2) 10Brion VIBBER: (Work in progress) Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 
[23:30:08] <grrrit-wm>	 (03CR) 10Brion VIBBER: "PS2 adds the thumb size selector on the page request." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER)
[23:33:41] <mhurd>	 brion: saw your comment: “Note it's actually iterating on an MWKSectionList rather than an NSArray here.” <—that’s awesome :)
[23:34:20] <brion>	 :D
[23:35:11] <mhurd>	 indexed subscripting… it’s the little things ;)
[23:37:04] <mhurd>	 brion: is there something i can help poke for any of the remaining regressions? i may not be able to fix, but could maybe help diagnose?
[23:38:15] <brion>	 mhurd: i’m probably just doing something dumb with the thumbnail fetching, like forgetting to run it through the function that finds the largest cached size
[23:38:23] <grrrit-wm>	 (03PS1) 10MaxSem: Remove old b/c code not needed since late summer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181212 
[23:38:24] <brion>	 mhurd: but if you notice any other problems running the patch through its paces do let me know!
[23:38:33] <brion>	 lemme take another peek in there
[23:39:26] <mhurd>	 brion: k i’ll start kicking tires hard :)
[23:39:31] <brion>	 awesome :D
[23:39:49] <brion>	 i’m sure there’s a few stray exceptions that are easy to uncover
[23:42:20] <brion>	 awwww yeah
[23:42:22] <brion>	 got thumbs to work
[23:44:05] <grrrit-wm>	 (03PS3) 10Brion VIBBER: Merging MWKArticle and MWKArticleStore into one object [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 
[23:44:33] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Thumbs now working pulling from article imagelist." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181202 (owner: 10Brion VIBBER)
[23:44:46] <mhurd>	 brion: awesome!
[23:48:03] <grrrit-wm>	 (03PS4) 10Kaldari: Include the campaign property's Wikidata label [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx)
[23:48:15] <grrrit-wm>	 (03PS1) 10MaxSem: Hygiene: phpdoc comments, unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181213 
[23:49:56] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] "Seems like this would require a campaign version update, otherwise users will keep on receiving old versions without labels for eternity." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/180811 (owner: 10Phuedx)
[23:50:47] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: VisualEditorOverlay: Update for Idc299e23 in OOUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181215 
[23:52:16] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: VisualEditorOverlay: Update for Idc299e23 in OOUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181215 
[23:55:09] <kristenlans>	 I just found a note to myself that says "jerky st" 0_o
[23:59:07] <brion>	 that sounds much less pleasant than sesame street