[00:04:10] Why isn't your accuracy 100%? [00:04:20] That's sounding like a blocker for release, to me. [00:04:21] * Deskana tuts. [00:06:23] 3Compact-Personal-Bar-(Beta), MobileFrontend-Feature-requests: Allow all or part of a mobile formatted screen to be called from desktop site - https://phabricator.wikimedia.org/T67367#940960 (10Jaredzimmerman-WMF) [00:07:20] 3Compact-Personal-Bar-(Beta), MobileFrontend-Feature-requests: Allow all or part of a mobile formatted screen to be called from desktop site - https://phabricator.wikimedia.org/T67367#691660 (10Jaredzimmerman-WMF) @MaxSem can you update the title of this to reflect how this could be done correctly (called via th... [00:13:26] (03PS1) 10Mhurd: Refactor way thumbs get associted with articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181527 [00:18:06] (03PS2) 10Mhurd: Refactor way thumbs get associted with articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181527 [00:20:22] (03CR) 10Brion VIBBER: [C: 032] "woo!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181527 (owner: 10Mhurd) [00:22:33] (03PS3) 10Brion VIBBER: Move old CoreData stuff to separate project library [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181525 [00:49:48] (03PS4) 10Mhurd: Move old CoreData stuff to separate project library [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181525 (owner: 10Brion VIBBER) [00:54:21] (03CR) 10Mhurd: [C: 032 V: 032] "We made ArticleFetcher use the first article image as the thumb if no thumb was found in the tmp dir." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181525 (owner: 10Brion VIBBER) [01:15:48] (03PS1) 10Jdlrobson: Fix footer on special pages where there is no last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181530 [01:15:50] (03PS1) 10Jdlrobson: Tweaks to login form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 [01:18:15] jdlrobson: No one has volunteered to cover for me at the scrum of scrums meeting :( Any chance I could talk you into it? [01:18:26] will you be around on Weds? [01:30:44] (03PS23) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [01:35:52] tfinc: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Onboarding [01:39:24] mhurd, Wikimedia Bugzilla? :D [01:42:29] Krenair: oh yeah! we have to update that... [01:45:58] jdlrobson: Help me Johnny-Wan, you're my only hope! [01:47:50] mhurd, do the mobile apps really follow the MediaWiki coding conventions..? [01:48:46] (03PS1) 10Deskana: Hygeine: use String instead of StringBuilder where appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 [01:48:49] Krenair: no, i copied the mobile web onboarding page and haven’t edited it down to app specific stuff completely yet. will take another pass at it tomorrow :) [01:49:02] ahh :) [01:49:14] Krenair: i need to flesh out apps parts a bit more too [01:49:19] the bit.ly/WMFStaff link seems broken too [01:49:39] Krenair: ah! cool. i’ll make a note to test all links tomorrow as well [01:57:56] (03PS1) 10Hoo man: Don't (implicitly) parse the "editsectionhint" message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181534 [02:00:42] (03CR) 10MaxSem: [C: 032] Don't (implicitly) parse the "editsectionhint" message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181534 (owner: 10Hoo man) [02:01:29] (03PS2) 10Jdlrobson: Tweaks to login and sign up form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 [02:01:31] (03PS1) 10Jdlrobson: Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181536 [02:02:04] (03Merged) 10jenkins-bot: Don't (implicitly) parse the "editsectionhint" message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181534 (owner: 10Hoo man) [02:05:20] tfinc: I need to run some moving errands on Wednesday morning, so I would like to request a half-day off. Jon says he can cover for me at scrum of scrums (assuming they actually still have the meeting). If that sounds good I'll submit via ADP. [02:05:55] (03PS24) 10Bmansurov: WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [02:07:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [02:20:32] (03PS2) 10Deskana: Don't transmit zero-result search events in TitleSearchFragment funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181429 [09:25:28] 3Wikipedia-App-Android-App: IllegalArgumentException: View not attached to window manager causing crashes - https://phabricator.wikimedia.org/T69947#941372 (10Krenair) More recent one: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8037943 [09:45:03] (03CR) 10Florianschmidtwelzow: Tweaks to login and sign up form in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 (owner: 10Jdlrobson) [10:12:06] hi! [10:25:04] (03CR) 10Nikerabbit: Don't (implicitly) parse the "editsectionhint" message (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181534 (owner: 10Hoo man) [11:09:23] (03PS1) 10Jhernandez: Require MW_INSTALL_PATH in both makefile and gruntfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181553 [11:09:25] (03PS1) 10Jhernandez: Fix jsduck warnings on WikiDataApi (inheritdoc) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181554 [11:10:41] (03CR) 10jenkins-bot: [V: 04-1] Fix jsduck warnings on WikiDataApi (inheritdoc) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181554 (owner: 10Jhernandez) [11:12:52] (03CR) 10jenkins-bot: [V: 04-1] Require MW_INSTALL_PATH in both makefile and gruntfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181553 (owner: 10Jhernandez) [11:20:56] (03PS2) 10Jhernandez: Fix jsduck warnings on WikiDataApi (inheritdoc) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181554 [11:20:58] (03PS2) 10Jhernandez: Require MW_INSTALL_PATH in both makefile and gruntfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181553 [11:58:33] yo [11:58:37] joakino_: o/ [11:58:43] hi phuedx!! [11:58:49] merry christmas :D [11:58:58] same to you! [11:59:05] just popping in [11:59:11] first chance i've had to sit down [11:59:22] (i.e. not wrapping presents) [11:59:43] :D [11:59:52] phuedx: you are on holidays, right [11:59:59] yeah [12:01:33] cool, enjoy [12:02:52] shoot [12:02:56] i forgot to update the holiday calendar [12:03:15] joakino_: i'm catching up on reading [12:03:28] (i'm not the greatest reader) [12:03:31] phuedx: what are you readin [12:04:41] the webfinger, salmon, and activity streams specs [12:04:55] and i'm working through introduction to elixir [12:05:02] no idea about any of that xd [12:05:07] elixir seems cool [12:05:23] it's fun [12:05:32] trying to avoid writing a web app in it though ;0 [12:05:50] phuedx: what are you using it for? [12:06:48] writing a toy game server [12:07:39] for a toy mmorpg i used to play a long time ago [12:13:15] awesome [12:13:22] phuedx: the actor model looks super interesting [12:13:29] and pattern matching is awesome [12:13:57] i like the pipe operator at the moment [12:14:21] Path.join( __DIR__, "/path/to/file.extension" ) |> File.read! [12:14:27] what does that do? [12:15:11] make_an_http_request() |> decode_response() |> extract_resource() [12:15:17] it's really, really clean [12:17:17] it passes the value on the left hand side of it as the argument to the function on the right hand side of it [12:17:41] so the second example is equivalent to extract_resource(decode_response(make_an_http_request())) [12:26:01] (03CR) 10Jhernandez: "I've created a task for us to discuss and get to something more concrete." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180824 (owner: 10Jhernandez) [12:39:15] lunch time! [12:42:28] (03CR) 10Jhernandez: Memoize results of the browser.js methods. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [13:21:22] (03CR) 10Jhernandez: Memoize results of the browser.js methods. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [13:22:38] (03PS3) 10Jhernandez: Memoize results of the browser.js methods. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 [15:29:54] (03CR) 10Hoo man: "This is why I shouldn't be allowed near computers at 3am" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181534 (owner: 10Hoo man) [18:04:33] (03CR) 10Bmansurov: "jdlrobson, `When I click the main menu button the menu is not immediately visible and there is a flash.` happens in master too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [18:05:09] (03PS25) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [18:06:41] (03PS26) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [18:07:08] sure is quiet today [18:07:24] making some noise ;))) [18:19:44] It was surprisingly busy in the office yesterday. [18:20:04] ppl haz no life [18:20:41] This surprises you? ;-) [18:20:51] * Deskana is heading in in 10 minutes [18:20:55] mmm, no [18:21:22] * MaxSem is too sleepy due to overnight painkillers [18:24:10] (03PS1) 10Brion VIBBER: Additional redirect fixes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181603 [18:27:45] (03PS1) 10Brion VIBBER: more logspam removal [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181605 [18:36:10] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181603 (owner: 10Brion VIBBER) [18:36:44] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181605 (owner: 10Brion VIBBER) [18:39:42] Maryana: What do we want to call WikiGrok roulette in the sidebar? Right now it is actually called "WikiGrok roulette". [18:51:26] (03PS1) 10Brion VIBBER: work around kerbooooooooooom in page loading if HTML sections used [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181608 [18:51:44] (03CR) 10Brion VIBBER: "Affects 'Apple IIe' page" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181608 (owner: 10Brion VIBBER) [18:53:53] (03CR) 10Kaldari: [C: 04-1] "The drawer currently has double padding. 1em for the drawer and 1em for the pane in the drawer. This makes the content too cramped on a ph" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [18:55:11] (03CR) 10Kaldari: "Also Maryana says we should change the title in the menubar to just 'WikiGrok' instead of 'WikiGrok roulette'." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [18:56:38] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181608 (owner: 10Brion VIBBER) [19:04:16] bmansurov: Just 2 minor things for WikiGrok Roulette and then I think it's ready to merge [19:04:32] kaldari: ok [19:08:01] (03PS1) 10Brion VIBBER: Image data save cleanup [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181611 [19:11:34] wow, what an album title… https://en.wikipedia.org/wiki/The_Boy_Bands_Have_Won [19:13:39] that’s really long. [19:14:00] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181611 (owner: 10Brion VIBBER) [19:17:23] (03PS27) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [19:17:28] kaldari: ^ [19:18:29] Deskana|Away: mhurd: looks like as a side effect of refactoring i accidentally made it so switching languages via the language switcher at bottom of article changes the search languages too [19:18:33] i’m not sure if this is a bug or a feature [19:18:37] i actually kinda like it :) [19:19:49] brion: hmm... interesting… [19:28:52] (03CR) 10Kaldari: [C: 04-1] Alpha: WikiGrok in sidebar (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [19:29:03] bmansurov: found one more little bug. Sorry :) [19:29:11] kaldari: you want to join the dario checkin in few min? [19:29:27] wikigrok dataz u can haz [19:29:29] Maryana: possibly. Will it run past 12? [19:29:36] i dunno [19:29:40] kaldari: thanks [19:29:45] you got somewhere important to be? :) [19:29:46] should have looked closer [19:30:11] Maryana: In a pizza [19:31:28] (03PS28) 10Bmansurov: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 [19:32:24] (03CR) 10Kaldari: [C: 032] Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [19:34:10] (03Merged) 10jenkins-bot: Alpha: WikiGrok in sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179367 (owner: 10Bmansurov) [19:37:23] 👍 [19:44:18] brion: i may be doing something silly… can’t seem to get the article.image to save... [20:05:30] brion: may have a bug - if i do a clean install, then browse to “food”, article, then restart, it goes back to mainpage [20:06:37] hmm [20:07:53] works for me [20:08:18] brion: i may be doing something screwy... [20:09:23] brion: after browsing to “food” i was hitting “stop” in xcode…not sure if that’s why? [20:09:57] brion: ah when i restart i see both food and main page in history, but mainpage is on top [20:10:00] possible? should still save the state tho [20:10:05] weird [20:15:06] brion: quick question about article.displaytitle when u have a sec [20:15:20] ya> [20:21:19] mhurd, brion, tfinc: "Your meal will arrive in approximately 24 minutes (2.9 miles away)" [20:21:35] \o/ [20:21:39] nommmmmmm [20:21:40] Deskana: didn’t realize it was that far [20:24:32] delivery is always close by the time they arrive [20:25:41] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#942286 (10Deskana) 3NEW [20:25:52] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#942286 (10Deskana) p:5Triage>3Normal [20:26:03] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#942286 (10Deskana) Tracked here: https://trello.com/c/lQW5S7Dm/858-do-not-send-x-wmf-uuid-header-in-any-requests-if-the-user-has-op... [20:28:38] (03PS2) 10MaxSem: Hygiene: phpdoc comments, unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181213 [20:30:20] brion: i think i may have found the history issue... [20:30:28] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#942299 (10Nuria) I would like to add that rather than EL it should be "data collection". It is likely that in the future we might w... [20:45:36] (03PS1) 10Mhurd: Fix for remembering last viewed article. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181671 [20:48:03] brion: ^ [20:48:23] \o/ [20:48:37] (03PS1) 10Deskana: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181673 [20:48:44] (03CR) 10Brion VIBBER: [C: 032] "yup :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181671 (owner: 10Mhurd) [20:53:29] (03PS1) 10Brion VIBBER: Update DataHousekeeping for post-CoreData world [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181675 [21:05:43] (03PS5) 10Jdlrobson: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 [21:05:45] (03PS4) 10Jdlrobson: Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 [21:05:48] (03PS4) 10Jdlrobson: Hygiene: Make instance of property id configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181198 [21:05:50] (03PS1) 10Jdlrobson: Hygiene: Organise our long list of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 [21:06:13] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Organise our long list of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 (owner: 10Jdlrobson) [21:17:26] (03PS5) 10Jdlrobson: Hygiene: Make instance of property id configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181198 [21:17:33] (03PS5) 10Jdlrobson: Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 [21:17:40] (03PS6) 10Jdlrobson: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 [21:29:02] kaldari: what's the query string i need to append to test wikigrok in sidebar again? [21:30:16] Maryana: Eh, have to turn on a config var on Beta Labs, I forgot... [21:30:23] kk [21:30:33] (03PS3) 10Jdlrobson: Fix jsduck warnings on WikiDataApi (inheritdoc) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181554 (owner: 10Jhernandez) [21:30:35] (03PS3) 10Jdlrobson: Require MW_INSTALL_PATH in both makefile and gruntfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181553 (owner: 10Jhernandez) [21:31:14] Maryana: Looks like there are no deployments this week except for Fundraising, so I guess it [21:31:16] it [21:31:23] it'll have to wait :( [21:31:29] aww :( [21:31:36] ok, no worries [21:31:37] But you can test on my computer some more if you need to [21:31:48] (03CR) 10Jdlrobson: [C: 032] Require MW_INSTALL_PATH in both makefile and gruntfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181553 (owner: 10Jhernandez) [21:31:57] (03CR) 10Jdlrobson: [C: 032] Fix jsduck warnings on WikiDataApi (inheritdoc) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181554 (owner: 10Jhernandez) [21:32:35] Maryana: I could probably just set the config var manually on the server for today and change it back. I doubt anyone would care since it's just beta labs. [21:32:54] (03CR) 10Jdlrobson: [C: 032] Hygiene: phpdoc comments, unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181213 (owner: 10MaxSem) [21:33:07] kaldari: yeah, i wanna test it on a real phone to see it fully in action.. [21:33:10] (03Merged) 10jenkins-bot: Require MW_INSTALL_PATH in both makefile and gruntfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181553 (owner: 10Jhernandez) [21:33:18] so if you wanna take a gamble, i'd support it :D [21:33:37] (03Merged) 10jenkins-bot: Fix jsduck warnings on WikiDataApi (inheritdoc) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181554 (owner: 10Jhernandez) [21:36:33] (03Merged) 10jenkins-bot: Hygiene: phpdoc comments, unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181213 (owner: 10MaxSem) [21:38:03] (03CR) 10Jdlrobson: [C: 032] Memoize results of the browser.js methods. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [21:39:11] (03CR) 10Jdlrobson: [C: 031] "@kaldari ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [21:39:23] (03Merged) 10jenkins-bot: Memoize results of the browser.js methods. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181394 (owner: 10Jhernandez) [21:42:19] (03CR) 10Jdlrobson: "I'm not sure what the box shadows are... are you saying the drop down menu overlaps the toolbar in the desktop version too? Maybe a scree" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders) [21:42:30] (03CR) 10Jdlrobson: "(also needs rebase)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders) [21:46:55] Maryana: It should be on there in a few minutes [21:47:04] w00t [21:48:27] (03CR) 10Jdlrobson: Don't add VisualEditor related modules if VE isn't installed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow) [21:50:03] (03CR) 10Jdlrobson: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [21:50:11] (03CR) 10Bmansurov: [C: 032] Hygiene: check types are valid in jsdocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 (owner: 10Jdlrobson) [21:51:12] (03CR) 10Bmansurov: [C: 032] Hygiene: check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181100 (owner: 10Jdlrobson) [21:52:49] (03Merged) 10jenkins-bot: Hygiene: check return types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181100 (owner: 10Jdlrobson) [21:52:52] (03Merged) 10jenkins-bot: Hygiene: check types are valid in jsdocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181101 (owner: 10Jdlrobson) [21:54:43] (03PS2) 10Jdlrobson: Hygiene: Organise our long list of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 [21:55:05] (03PS1) 10Florianschmidtwelzow: Use Config object vor global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [21:55:07] (03PS1) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 [21:55:22] (03PS2) 10Florianschmidtwelzow: Hygiene: Use Config object vor global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [21:56:08] (03PS2) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 [21:58:02] * legoktm hugs FlorianSW [21:58:20] legoktm :D [21:58:42] it's (hopefully) just the beginning :) [21:58:49] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object vor global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow) [21:59:44] Maryana: actually, this will take a whlie since I don't remember how to access the databases on beta labs. lemme finish up the template stuff I was working on first if that'sOK [21:59:50] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [21:59:54] kaldari: sure, np [22:00:40] $ sql foowiki [22:00:41] :P [22:02:00] legoktm: what server? [22:02:05] (03PS2) 10Florianschmidtwelzow: Don't add VisualEditor related modules if VE isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 [22:03:03] (03PS1) 10Brion VIBBER: Re-separate the search language from the currently viewed article's language [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181686 [22:04:27] (03CR) 10Jdlrobson: [C: 04-1] "Fair enough. I think it's okay to go ahead with this if it simplifies our code base and makes things more readable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez) [22:05:14] (03PS1) 10Deskana: Hygeine: reduce number of fields that are used unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181687 [22:06:25] legoktm: is there just one db server? deployment-db2? [22:08:46] legoktm: also 'sql' doesn't seem to work from any of the beta labs instances :( [22:10:50] brion: those 2 patches good to go? [22:11:13] should be :D pls test [22:12:04] (03PS2) 10Jdlrobson: Fix footer on special pages where there is no last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181530 [22:13:08] (03PS3) 10Jdlrobson: Fix footer on special pages where there is no last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181530 [22:16:48] brion: https://github.com/montehurd/gitshorts/ [22:16:53] brion: updating... [22:18:53] brion: you'd appreciate this: http://sauceio.com/index.php/2014/12/we-automated-12-android-phones-to-sing-appy-holidays-to-you-video/ [22:22:18] (03PS2) 10Deskana: Hygeine: reduce number of fields that are used unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181687 [22:23:27] (03PS2) 10Mhurd: Update DataHousekeeping for post-CoreData world [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181675 (owner: 10Brion VIBBER) [22:24:32] chrismcmahon: nice :D [22:25:10] (03PS3) 10Florianschmidtwelzow: Hygiene: Use Config object vor global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [22:27:20] kaldari: $sql enwiki works for me on deployment-bastion [22:27:27] kaldari: there are 2 db servers I think [22:27:44] (03PS3) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 [22:29:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [22:29:07] legoktm: reminder: can you review my 2 changes (core and confirmedit (if possible))? https://gerrit.wikimedia.org/r/#/c/170309/ || https://gerrit.wikimedia.org/r/#/c/136323/ [22:30:35] (03PS4) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 [22:30:38] brion: that housekeeping patch seems to work quite nicely :) [22:30:44] woot [22:32:12] (03CR) 10Mhurd: [C: 032 V: 032] "Seems to work great!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181675 (owner: 10Brion VIBBER) [22:33:01] (03PS2) 10Mhurd: Re-separate the search language from the currently viewed article's language [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181686 (owner: 10Brion VIBBER) [22:34:26] legoktm: thanks [22:35:42] Maryana: it's working now on Beta Labs [22:35:51] nice. will test. [22:35:54] bmansurov: kaldari i'm still seeing the issue with the hamburger since we merged wikidata roulette [22:36:06] jdlrobson: ? [22:36:10] jdlrobson: it was happening in master too [22:36:14] before the merge [22:36:25] When you click it the menu is empty for about half a second [22:36:57] bmansurov: do you know what introduced it? [22:37:12] bmansurov: Noticed a bug. If there are no WikiGrok pages and the API doesn't return anything useful, the sidebar menu stays open and it show the error drawer in the tiny space left over. [22:37:24] jdlrobson: I think it happend in the last day or two, but haven't tracked it down. [22:37:58] kaldari: i'll submit a follow up patch [22:38:09] jdlrobson: what is the hamburger issue? [22:38:21] kaldari created a bug - https://phabricator.wikimedia.org/T85253 - if someone can look at it that would be great [22:39:24] brion: i think i found what that weird history update code was doing... [22:40:05] herp derp, position fixed doesn't work [22:40:13] on wikigrok c :-/ [22:43:08] (03PS1) 10Deskana: Hygeine: change some if statements to switch statements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181692 [22:45:27] jdlrobson, bmansurov: looks like the bug is specific to Chrome. Doesn't happen in Firefox. [22:45:38] the hamburger bug I mean [22:48:53] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181686 (owner: 10Brion VIBBER) [22:54:45] brion: wtf? this lang bug is weird! [22:54:50] srsly [22:55:52] (03PS1) 10Bmansurov: Close main menu before showing wikigrok roulette error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 [22:56:48] kaldari: ^ fixes the menu menu issue [22:58:53] 3MobileFrontend-stable, Mobile-Web: Search field inaccessible on Opera Mini - https://phabricator.wikimedia.org/T75632#942545 (10Jdlrobson) Adam this seems to work fine for me on Opera Mini on my Android Nexus 5 device. Is this fixed? [23:03:35] (03CR) 10Jdlrobson: [C: 031] Don't add VisualEditor related modules if VE isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow) [23:07:15] (03CR) 10Florianschmidtwelzow: Close main menu before showing wikigrok roulette error (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov) [23:07:43] (03PS2) 10Jdlrobson: Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181536 [23:08:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181536 (owner: 10Jdlrobson) [23:08:44] (03CR) 10Bmansurov: Close main menu before showing wikigrok roulette error (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov) [23:09:06] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181536 (owner: 10Jdlrobson) [23:09:25] bmansurov: do you want to push your changes to stable? https://phabricator.wikimedia.org/T71351 [23:09:31] Maryana seemed to be keen to have that happen [23:10:13] 3MobileFrontend-stable, Mobile-Web: Going back to previous page doesn't remember expanded sections - https://phabricator.wikimedia.org/T71351#942567 (10Jdlrobson) See T78015 - Maryana has said we should push this to stable. [23:10:27] jdlrobson: ok [23:10:59] 3MobileFrontend-stable, Mobile-Web: Going back to previous page doesn't remember expanded sections - https://phabricator.wikimedia.org/T71351#942570 (10Jdlrobson) [23:15:15] yes please :) [23:15:18] it's a big improvement [23:15:39] kaldari: bubble tea? [23:16:02] (03CR) 10Kaldari: Close main menu before showing wikigrok roulette error (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov) [23:16:42] Maryana: one sec... [23:16:49] kk [23:17:45] (03PS1) 10Brion VIBBER: Fix for language list search breaking navigation sometimes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181697 [23:17:55] (03PS2) 10Brion VIBBER: Fix for language list search breaking navigation sometimes [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181697 [23:18:25] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/181697 (owner: 10Brion VIBBER) [23:19:06] (03CR) 10Bmansurov: Close main menu before showing wikigrok roulette error (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov) [23:19:50] 3Wikipedia-App-iOS-App: App does not load any other section or article once you enter a text in the Language filter box which does not have any match - https://phabricator.wikimedia.org/T76380#942589 (10brion) 5Open>3Resolved Resolved in development version on master (merged). Will go out with January's app... [23:23:31] (03PS1) 10Jdlrobson: Hygiene: Make _hasChanged public [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181698 [23:23:34] (03PS1) 10Jdlrobson: Hygiene: Rename misleading onSave name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181699 [23:23:35] (03PS1) 10Jdlrobson: Hygiene: Rename _save to onSaveBegin and _prepareForSave to onStageChanges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181700 [23:23:38] (03PS1) 10Jdlrobson: Hygiene: Remove unnecessary overlay code / address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181701 [23:23:40] (03PS1) 10Jdlrobson: Hygiene: Kill closeOnBack property and OverlayManager FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181702 [23:25:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove unnecessary overlay code / address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181701 (owner: 10Jdlrobson) [23:25:27] (03CR) 10Jdlrobson: [C: 04-1] Close main menu before showing wikigrok roulette error (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov) [23:25:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Kill closeOnBack property and OverlayManager FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181702 (owner: 10Jdlrobson) [23:27:05] (03PS2) 10Jdlrobson: Hygiene: Rename _save to onSaveBegin and _prepareForSave to onStageChanges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181700 [23:27:20] (03PS2) 10Jdlrobson: Hygiene: Remove unnecessary overlay code / address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181701 [23:27:26] (03PS2) 10Jdlrobson: Hygiene: Kill closeOnBack property and OverlayManager FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181702 [23:29:51] (03PS1) 10Bmansurov: Promote auto toggle to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181703 [23:31:03] (03PS2) 10Bmansurov: Close main menu before showing wikigrok roulette error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 [23:54:25] jdlrobson, kaldari the hamburger bug seems to be introduced in this patch https://gerrit.wikimedia.org/r/#/c/180344/ [23:56:38] bmansurov: Can you add that to the ticket? [23:56:46] sure [23:57:22] kaldari: is there a ticket for that already? [23:57:41] phabricator or trello? [23:57:50] bmansurov: https://phabricator.wikimedia.org/T85253 [23:59:39] (03PS3) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 [23:59:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson)