[00:00:23] <jdlrobson>	 bmansurov: any idea what in that patch introduced it? that's bizarre
[00:06:06] <bmansurov>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/180344/11/javascripts/application.js
[00:06:24] <bmansurov>	 line 142
[00:07:29] <jdlrobson>	 bmansurov: but that still gets added no?
[00:07:47] <bmansurov>	 jdlrobson: maybe, but I couldn't find where
[00:08:06] <jdlrobson>	 mmm so are all animations busted?
[00:08:13] <jdlrobson>	 $viewport.addClass( 'animations' ); 
[00:08:18] <jdlrobson>	 it's on line 79 now
[00:08:28] <jdlrobson>	 possibly a css rule got missed
[00:08:30] <jdlrobson>	 it's on the viewport now
[00:08:48] <bmansurov>	 yes, it should be html 
[00:11:19] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 
[00:11:23] <jdlrobson>	 bmansurov: no it should't be on html tag
[00:11:33] <jdlrobson>	 we're trying to make classes local to the things they effect
[00:11:46] <jdlrobson>	 we need to abstract the mainmenu code so that it is a View like everything else
[00:12:04] <jdlrobson>	 bmansurov: but yeh i see what's doing it 
[00:12:10] <jdlrobson>	 i broke it so i can fix it if you are not doing so
[00:12:19] <bmansurov>	 jdlrobson: i see
[00:12:30] <bmansurov>	 I think you can fix it faster than I can 
[00:12:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson)
[00:12:54] <jdlrobson>	 k let me take a look
[00:20:48] <jdlrobson>	 not sure what i hate most toggle code or main menu code
[00:23:19] <bmansurov>	 jdlrobson: i know, you hate them both equally, you don't discriminate ;)
[00:27:38] <bmansurov>	 jdlrobson: also, drawers are not fixed to the bottom of the page anymore. I suppose it maybe related to browser.js refactoring
[00:27:56] <jdlrobson>	 bmansurov: did you raise a bug? that sounds serious
[00:28:11] <jdlrobson>	 it's probably a similar problem to this - assuming the class is on the body
[00:28:11] <bmansurov>	 not yet
[00:31:39] <grrrit-wm>	 (03PS1) 10Jdlrobson: Restore main menu animations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181707 
[00:32:09] <jdlrobson>	 bmansurov: if you can raise a bug with how to replicate that would be great
[00:32:28] <bmansurov>	 jdlrobson: https://phabricator.wikimedia.org/T85258
[00:32:53] <jdlrobson>	 bmansurov: when i scroll the drawer disappears..
[00:33:21] <bmansurov>	 sorry, you need to set closeOnScroll to false, i'll update the card
[00:34:04] <jdlrobson>	 bmansurov: does anything use closeOnScroll ?
[00:34:15] <bmansurov>	 jdlrobson: by default everything uses it
[00:34:16] <jdlrobson>	 ah fontchanger
[00:34:30] <jdlrobson>	 bmansurov: sure but it seems to exist because of fontchanger
[00:34:39] <bmansurov>	 and wikigrok c
[00:34:40] <jdlrobson>	 so this only effects font changer
[00:43:29] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Make _hasChanged public [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181698 (owner: 10Jdlrobson)
[00:44:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Make _hasChanged public [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181698 (owner: 10Jdlrobson)
[00:45:53] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Rename misleading onSave name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181699 (owner: 10Jdlrobson)
[00:47:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Rename misleading onSave name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181699 (owner: 10Jdlrobson)
[00:49:59] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Rename _save to onSaveBegin and _prepareForSave to onStageChanges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181700 (owner: 10Jdlrobson)
[00:51:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Rename _save to onSaveBegin and _prepareForSave to onStageChanges [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181700 (owner: 10Jdlrobson)
[00:51:39] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Remove unnecessary overlay code / address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181701 (owner: 10Jdlrobson)
[00:52:48] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] "Nice!" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[00:52:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary overlay code / address FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181701 (owner: 10Jdlrobson)
[00:55:32] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Kill closeOnBack property and OverlayManager FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181702 (owner: 10Jdlrobson)
[00:56:12] <kaldari>	 legoktm: Any idea what's going wrong with the qunit test here: https://gerrit.wikimedia.org/r/#/c/181708/ . Looks like the autoloading is not working within Jenkins, but I'm not sure why.
[00:57:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Kill closeOnBack property and OverlayManager FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181702 (owner: 10Jdlrobson)
[00:57:43] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] Hygiene: Use Config object for global variables in MinervaTemplate (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[00:58:18] <legoktm>	 kaldari: looking...
[00:58:21] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032 V: 032] Restore main menu animations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181707 (owner: 10Jdlrobson)
[01:01:12] <legoktm>	 kaldari: do you have a composer/autoload_files.php locally?
[01:01:27] <kaldari>	 legoktm: yes
[01:01:29] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Make instance of property id configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181198 (owner: 10Jdlrobson)
[01:01:48] <legoktm>	 kaldari: you need to commit that file :)
[01:02:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Restore main menu animations [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181707 (owner: 10Jdlrobson)
[01:02:45] <kaldari>	 legoktm: weird. I did a git commit -a. Wonder why it didn't catch that one.
[01:02:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Make instance of property id configurable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181198 (owner: 10Jdlrobson)
[01:03:08] <kaldari>	 legoktm: oh, I guess it's totally new :P
[01:03:16] <legoktm>	 kaldari: yeah so git add .; git commit should do it
[01:03:40] <kaldari>	 legoktm: yep, should have run a git status first  :)
[01:04:10] <legoktm>	 also, I think this exposes an issue that lightncandy is using the file autoload thing instead of a classmap.
[01:05:00] <kaldari>	 legoktm: yeah, do you think that will cause any problems?
[01:05:24] <grrrit-wm>	 (03PS3) 10Deskana: Hygiene: reduce number of fields that are used unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181687 
[01:05:33] <grrrit-wm>	 (03PS2) 10Deskana: Hygiene: change some if statements to switch statements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181692 
[01:06:12] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 04-1] Hygiene: Generalise instance of field for infobox generation to allow configuration (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 (owner: 10Jdlrobson)
[01:06:13] <legoktm>	 kaldari: I do :/ but working on a PR right now
[01:06:44] <kaldari>	 legoktm: NP, I'll make a note of it in the commit summary
[01:08:16] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Fix footer on special pages where there is no last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181530 (owner: 10Jdlrobson)
[01:09:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix footer on special pages where there is no last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181530 (owner: 10Jdlrobson)
[01:17:30] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[01:21:44] <legoktm>	 kaldari: https://github.com/zordius/lightncandy/pull/122
[01:33:53] <kaldari>	 legoktm: wow, that was fast, he already merged the pull request :)
[01:34:24] <legoktm>	 woaaah
[01:35:33] <legoktm>	 we'll need to ask him to tag another release so we can actually use it though
[01:36:07] <kaldari>	 yeah
[01:53:28] <grrrit-wm>	 (03PS1) 10Bmansurov: Remove unused variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181712 
[01:56:19] <grrrit-wm>	 (03PS7) 10Jdlrobson: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 
[01:56:21] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 
[01:56:23] <grrrit-wm>	 (03PS2) 10Jdlrobson: wIP: Infobox item editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 
[01:56:40] <grrrit-wm>	 (03PS3) 10Jdlrobson: wIP: Infobox item editing using ooui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 
[01:56:47] <grrrit-wm>	 (03PS4) 10Jdlrobson: wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 
[01:57:31] <grrrit-wm>	 (03CR) 10Jdlrobson: "Bartosz this is making me feel like a dummy. I'm reverse engineering in the absence of guidance/docs and would really like to have an idea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson)
[01:58:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson)
[02:29:31] <grrrit-wm>	 (03PS1) 10Kaldari: Hygiene: Prevent JS error - anchors don't necessarily have an HREF [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181715 
[02:33:06] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Close main menu before showing wikigrok roulette error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov)
[02:34:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Close main menu before showing wikigrok roulette error [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181694 (owner: 10Bmansurov)
[10:43:10] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 
[10:47:00] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[10:54:33] <grrrit-wm>	 (03PS6) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 
[11:00:04] <grrrit-wm>	 (03CR) 10Esanders: "Looks the same in desktop: https://phab.wmfusercontent.org/file/data/e27bc3ucgxipyl42v725/PHID-FILE-gdju6i5yl22yrqgfftiv/zxmbzni7pdya7loj/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders)
[11:00:59] <grrrit-wm>	 (03CR) 10Esanders: "Link doesn't work, just go to bug T85025" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders)
[11:16:41] <grrrit-wm>	 (03PS4) 10Esanders: Redo VE toolbar styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 
[11:16:47] <grrrit-wm>	 (03CR) 10Esanders: Redo VE toolbar styling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders)
[11:18:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Redo VE toolbar styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders)
[12:31:34] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[12:32:08] <grrrit-wm>	 (03PS8) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[12:32:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[12:40:27] <grrrit-wm>	 (03PS9) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[12:40:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[12:43:02] <grrrit-wm>	 (03PS10) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[12:48:23] <grrrit-wm>	 (03PS11) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[12:50:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[12:51:43] <grrrit-wm>	 (03CR) 10Jhernandez: "I've added the code to View and added tests in Mantle." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez)
[13:02:33] <grrrit-wm>	 (03PS4) 10Jhernandez: WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 
[13:02:35] <grrrit-wm>	 (03PS4) 10Jhernandez: WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 
[13:02:37] <grrrit-wm>	 (03PS4) 10Jhernandez: WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 
[13:02:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez)
[13:03:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[13:04:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[13:05:24] <grrrit-wm>	 (03PS5) 10Jhernandez: WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 
[13:05:26] <grrrit-wm>	 (03PS5) 10Jhernandez: WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 
[13:05:28] <grrrit-wm>	 (03PS5) 10Jhernandez: WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 
[13:06:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: PhotoUploaderButton uses EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez)
[13:07:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[13:08:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor Watchstar view to use EventsView [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[13:13:43] <grrrit-wm>	 (03PS6) 10Jhernandez: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 
[13:13:45] <grrrit-wm>	 (03PS6) 10Jhernandez: PhotoUploaderButton uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 
[13:13:47] <grrrit-wm>	 (03PS6) 10Jhernandez: Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 
[13:15:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[13:16:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PhotoUploaderButton uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez)
[13:16:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[13:16:56] <grrrit-wm>	 (03CR) 10Jhernandez: "Tests fail because the Mantle patch is not merged. Once it is, we shall recheck this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[13:17:07] <grrrit-wm>	 (03CR) 10Jhernandez: "Tests fail because the Mantle patch is not merged. Once it is, we shall recheck this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[13:17:19] <grrrit-wm>	 (03CR) 10Jhernandez: "Tests fail because the Mantle patch is not merged. Once it is, we shall recheck this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez)
[13:22:21] <grrrit-wm>	 (03PS1) 10Jhernandez: Remove console.log and fixed a couple of jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181735 
[14:21:03] <grrrit-wm>	 (03PS5) 10Esanders: Redo VE toolbar styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 
[14:23:22] <wikibugs>	 3Wikipedia-App-Android-App: [wish list] add support for random in category - https://phabricator.wikimedia.org/T85274#942991 (10Muhammedabuali.e) 3NEW
[17:15:32] <grrrit-wm>	 (03PS2) 10Jhernandez: Hygiene: Prevent JS error - anchors don't necessarily have an HREF [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181715 (owner: 10Kaldari)
[17:24:05] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Prevent JS error - anchors don't necessarily have an HREF [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181715 (owner: 10Kaldari)
[17:25:46] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Remove unused variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181712 (owner: 10Bmansurov)
[17:27:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Prevent JS error - anchors don't necessarily have an HREF [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181715 (owner: 10Kaldari)
[17:27:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181712 (owner: 10Bmansurov)
[17:37:43] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] "Looks good to me, would want somebody else to have a look." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 (owner: 10Jdlrobson)
[17:49:47] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] "Looks good, address florian's comments" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 (owner: 10Jdlrobson)
[17:57:39] <grrrit-wm>	 (03PS2) 10Deskana: Hygiene: use String instead of StringBuilder where appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 
[18:02:29] <bmansurov>	 standup anyone?
[18:05:58] <jdlrobson>	 bmansurov: looks like on email no one will be around
[18:06:18] <bmansurov>	 k
[18:06:23] <Maryana>	 just you two :)
[18:06:32] <jdlrobson>	 anything blocking you mr bmansurov ?
[18:06:54] <bmansurov>	 no, I'll keep working on anomaly detection
[18:07:53] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Remove console.log and fixed a couple of jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181735 (owner: 10Jhernandez)
[18:08:22] <joakino>	 hi bmansurov jdlrobson Maryana!
[18:08:33] <joakino>	 merry christmas :D
[18:09:03] <bmansurov>	 hi joakino, you too!
[18:09:45] <Maryana>	 merry christmas joakino :)
[18:10:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove console.log and fixed a couple of jsduck errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181735 (owner: 10Jhernandez)
[18:11:00] <jdlrobson>	 have fun joakino :)
[18:13:41] <Deskana>	 Ho ho ho
[18:16:35] <Deskana>	 mhurd: Standup time!
[18:17:06] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 (owner: 10Jdlrobson)
[18:21:29] <grrrit-wm>	 (03PS7) 10Jdlrobson: Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 
[18:22:12] <grrrit-wm>	 (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181536 (owner: 10Jdlrobson)
[18:22:21] <grrrit-wm>	 (03PS3) 10Jdlrobson: Tweaks to login and sign up form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 
[18:22:40] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 (owner: 10Jdlrobson)
[18:23:06] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Tweaks to login and sign up form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 (owner: 10Jdlrobson)
[18:23:12] <grrrit-wm>	 (03CR) 10Jdlrobson: Tweaks to login and sign up form in alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 (owner: 10Jdlrobson)
[18:23:23] <grrrit-wm>	 (03PS8) 10Jhernandez: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 (owner: 10Jdlrobson)
[18:24:25] <brion>	 woo
[18:25:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Generalise instance of field for infobox generation to allow configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181199 (owner: 10Jdlrobson)
[18:25:23] <grrrit-wm>	 (03PS4) 10Jdlrobson: Tweaks to login and sign up form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 
[18:26:00] <joakino>	 i'm heading out
[18:26:06] <joakino>	 enjoy these days
[18:26:15] <joakino>	 bb :)
[18:44:26] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "fine with me then" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders)
[18:46:28] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[18:47:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Redo VE toolbar styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181362 (owner: 10Esanders)
[18:48:27] <grrrit-wm>	 (03PS9) 10Jdlrobson: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 
[18:48:49] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "No one commented on 24hrs so in interest of keeping things moving..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow)
[18:49:22] <grrrit-wm>	 (03PS12) 10Jdlrobson: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[18:49:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "qunit tests..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[18:50:32] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Needs a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen)
[18:50:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[18:52:33] <grrrit-wm>	 (03PS7) 10Jdlrobson: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[18:53:56] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Use Config object for global variables in MinervaTemplate (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[18:54:14] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Organise our long list of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 
[18:54:36] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "@MaxSem can you take a look?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[18:54:59] <grrrit-wm>	 (03PS13) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[18:55:34] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "merge attempt 2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 (owner: 10Jdlrobson)
[18:56:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't add VisualEditor related modules if VE isn't installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181403 (owner: 10Florianschmidtwelzow)
[18:56:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make infobox experiment configurable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181201 (owner: 10Jdlrobson)
[18:57:02] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: WIP: menu widget for infobox params [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/175788 (owner: 10Robmoen)
[18:58:26] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[18:58:50] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 
[19:01:12] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 
[19:02:05] <grrrit-wm>	 (03PS7) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 
[19:08:25] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Organise our long list of globals (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 (owner: 10Jdlrobson)
[19:27:46] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[19:29:23] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 
[19:33:04] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Promote auto toggle to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181703 (owner: 10Bmansurov)
[19:36:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Promote auto toggle to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181703 (owner: 10Bmansurov)
[19:37:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Refactor Watchstar view to use events map with View (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez)
[19:38:27] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] TableOfContents uses events map (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez)
[19:38:57] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] PhotoUploaderButton uses events map (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez)
[19:40:27] <mhurd>	 brion: Deskana heading to airport - will be back online in an hr or so :)
[19:40:46] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Going back to previous page doesn't remember expanded sections - https://phabricator.wikimedia.org/T71351#943376 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[19:41:32] <brion>	 mhurd: ok give mae a ping when ready to review :D
[19:41:42] <brion>	 if i’m not on irc drop me a text
[19:41:42] <mhurd>	 brion: will do! :)
[19:41:47] <mhurd>	 k
[19:41:57] <brion>	 and enjoy your climbing!
[19:42:03] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Login form duplicate messages - https://phabricator.wikimedia.org/T73771#943378 (10Jdlrobson) Would be good to fix stable in the mean time for this problem.
[19:42:09] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Login form duplicate messages in stable - https://phabricator.wikimedia.org/T73771#943379 (10Jdlrobson)
[19:42:26] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Login form duplicate messages in stable when directly visit Special:EditWatchlist whilst anon - https://phabricator.wikimedia.org/T73771#762677 (10Jdlrobson)
[19:45:13] <wikibugs>	 3MobileFrontend-stable, Mobile-Web: Talk: "Return to "Foo" page." appears on talk page needs design love - https://phabricator.wikimedia.org/T73919#943384 (10Jdlrobson) Maybe just put it at bottom of page for the time being. I think this would be the easiest thing to do.
[19:48:17] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Can't scroll in edit mode - https://phabricator.wikimedia.org/T75255#943388 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson I guess this is fixed then? Please reopen if this is not true.
[19:52:47] <FlorianSW>	 jdlrobson: hi :) https://gerrit.wikimedia.org/r/#/c/179863/13/tests/qunit/modules/editor/test_EditorOverlay.js stub a variable?
[19:55:10] <wikibugs>	 3MobileFrontend-beta, Mobile-Web: Wikgrok A and B trigger API request on every page load - https://phabricator.wikimedia.org/T74796#943392 (10Jdlrobson) @Kaldari was it the status of this? Since we are using campaigns now is this bug event relevant any more?
[19:56:38] <jdlrobson>	 FlorianSW: i assume that's possible? When you set EditorOverlayBase.protype.config you are overriding it for all EditorOverlayBase
[19:57:34] <FlorianSW>	 jdlrobson: i think that doesn't work, because stub is for methods (i haven't tested it) :/ Yeah, if it doesn't work, it would be possible to save the value of config and restore it after the assertion?
[20:00:12] <jdlrobson>	 FlorianSW: not 100% sure. I'm heading for lunch now but there must be a way of doing this
[20:00:24] <FlorianSW>	 jdlrobson:  "Cannot stub non-existent own property config" -> https://gitorious.org/sinon/sinon/source/d76b83bc3d8949a3a1ea724077396713bdf62983:lib/sinon/collection.js#L96-98
[20:01:53] <grrrit-wm>	 (03PS14) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[21:38:57] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[21:39:19] <grrrit-wm>	 (03PS3) 10Jdlrobson: Small style tweaks to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen)
[21:39:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Small style tweaks to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen)
[21:39:41] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen)
[22:47:07] <grrrit-wm>	 (03PS5) 10Jdlrobson: wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 
[22:47:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson)
[23:25:33] <grrrit-wm>	 (03PS5) 10Bmansurov: Add WikiGrok response badges for wg-sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen)
[23:47:54] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Remove dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181536 (owner: 10Jdlrobson)