[01:53:05] 3Wikipedia-App-Android-App: NPE crashes from onBeforeExecute while searching - https://phabricator.wikimedia.org/T85429#946521 (10Krenair) 3NEW [09:04:50] morning [09:33:22] morning [09:37:59] mroning :P [09:40:24] yo [09:40:29] caught up on email already [09:40:38] TO THE REVIEW CAVE [09:47:41] phuedx: you working today? [09:47:46] yup [09:48:21] phuedx: 👍 i'm not alonee [09:48:25] morning FlorianSW [09:48:56] i'm reviewing the badges change [09:49:21] then i'm going to write up an email about the planout stuff i've been working on [09:49:29] joakino: working? between christmas and new year? :o my condolences [09:49:43] FlorianSW: i know, right? [09:50:09] are thursday and friday holidays? [09:50:18] phuedx: i'm looking at it too to try and understand what happened with wikigrokdialogc (missed that patch) [09:50:25] i may end up working them anyway [09:50:51] joakino: hmm? [09:50:52] phuedx: yep 1 and 2 holidays [09:51:03] oh [09:51:13] w/e [09:51:21] i've had a good week [09:51:25] phuedx: and I think those are superfixed [09:51:33] :/ [09:52:31] FlorianSW: where are you? [09:52:48] joakino: you mean, where i'm coming from? Germany :) [09:53:19] FlorianSW: yeah, i was going to ask where are you from but that may have nothing to do with where you live now [09:53:32] cool, very close [09:53:53] yeah, right :D But both Germany :) you and pheudx are both in great britain, right? [09:54:25] FlorianSW: i'm in spain! [09:54:55] joakino: oha :) [09:55:12] FlorianSW: hola? [09:55:30] joakino: oha = ok + aha :P [09:56:04] FlorianSW: lol [09:56:07] haha [09:56:28] (03CR) 10Phuedx: [C: 04-1] "To be clear, this is only for version C of WikiGrok?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [09:56:52] haha [09:57:00] i've never heard "oha" before [09:57:44] phuedx: i need to enable $wgMFEnableWikiGrokInSidebar to see that version c right [09:57:44] lol, ok :D [09:58:12] joakino: yarrrp [09:58:21] brb [10:03:02] back [10:03:07] with monkey nuts [10:05:46] phuedx: i think that badges patch is open for anyone to improve it [10:05:59] yeah i think so too [10:06:04] but it's worth a review cycle [10:06:09] just to get thoughts down [10:07:17] phuedx: what do you think about A -> B -> C [10:07:36] phuedx: it smells a lot to me, i'd rather have composition and no inheritance overall [10:08:22] and smaller subviews to be included on those dialogs, instead of hidden implicit inherited behavior [10:10:34] yup, i think that small, distinct modules that do the coordinating vs. a class that they all inherit from is the way to go [10:10:58] i favour composition over inheritance generally [10:11:26] and when it comes to frontend stuff, i favour small modules communicating with events [10:12:43] phuedx: i really wish more time was spent on thinking and clarifying frontend architecture, nobody usually pays attention and it is a pretty wild environment... [10:13:46] joakino: well afaik wikigrok is still a prototype [10:13:56] that may eventually get pushed to production without second thought [10:18:21] "refactoring is not something that you do at the end of a project" [10:19:43] phuedx: yeah but there is already some fear to touching it because it can break [10:20:19] i think kaldari mentioned that when the test was over we would be able to touch it [10:20:58] i still don't really understand our deployment cycle enough to figure that out [10:20:59] :/ [10:21:49] btw phuedx have you seen my patches on implementing an events map on the views a la backbone? https://gerrit.wikimedia.org/r/181734 <- view patch, examples: https://gerrit.wikimedia.org/r/180835 https://gerrit.wikimedia.org/r/180836 https://gerrit.wikimedia.org/r/180837 [10:22:06] it would be cool to know your opinion [10:23:04] joakino: i hadn't, i shall take a look [10:24:57] (03CR) 10Jhernandez: [C: 032] Tweaks to login and sign up form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 (owner: 10Jdlrobson) [10:27:36] (03Merged) 10jenkins-bot: Tweaks to login and sign up form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181531 (owner: 10Jdlrobson) [10:31:41] (03CR) 10Jhernandez: Refactor Watchstar view to use events map with View (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [10:35:17] (03PS7) 10Jhernandez: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 [10:36:01] (03PS7) 10Jhernandez: PhotoUploaderButton uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 [10:38:24] (03PS7) 10Jhernandez: Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 [10:41:15] (03PS8) 10Jhernandez: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 [10:41:24] (03CR) 10jenkins-bot: [V: 04-1] Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [10:41:26] (03CR) 10Jhernandez: TableOfContents uses events map (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [10:42:53] (03PS8) 10Jhernandez: PhotoUploaderButton uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 [10:47:18] (03CR) 10Jhernandez: [C: 031] "I agree with you, but the patch itself is +2able" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [10:57:39] (03CR) 10Phuedx: "You're right. I'll remove my -1 and make sure we all have chats about how to tidy up WikiGrok." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [10:57:46] ^ joakino [10:58:54] phuedx: 👍, i've posted a comment and screenshots on the card, i think the 2 seconds timeout is too low (or strict), maybe the designers will chime in [10:59:42] i'd rather have a button that said [ Moar questions \o/ ] or something like that [11:02:13] (03CR) 10Phuedx: [C: 032] Hygiene: Move "Return to $1 page" to footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181802 (owner: 10Florianschmidtwelzow) [11:05:08] (03Merged) 10jenkins-bot: Hygiene: Move "Return to $1 page" to footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181802 (owner: 10Florianschmidtwelzow) [11:05:59] 3MobileFrontend-stable, Mobile-Web: Talk: "Return to "Foo" page." appears on talk page needs design love - https://phabricator.wikimedia.org/T73919#946876 (10phuedx) [11:08:40] (03CR) 10Phuedx: [C: 032] Hygiene: Fix add of no-position-fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181874 (owner: 10Florianschmidtwelzow) [11:10:03] 3MobileFrontend-stable, Mobile-Web: Talk: "Return to "Foo" page." appears on talk page needs design love - https://phabricator.wikimedia.org/T73919#946881 (10Florian) [11:10:03] (03Merged) 10jenkins-bot: Hygiene: Fix add of no-position-fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181874 (owner: 10Florianschmidtwelzow) [11:10:51] 3MobileFrontend-stable, Mobile-Web: Talk: "Return to "Foo" page." appears on talk page needs design love - https://phabricator.wikimedia.org/T73919#749873 (10Florian) Removed patch-for-review, for now we only moved the link to the button, but the main problem still exists :) [11:38:55] (03CR) 10Phuedx: [C: 032] "Nice work!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 (owner: 10Jdlrobson) [11:40:22] (03Merged) 10jenkins-bot: Hygiene: Organise our long list of globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181677 (owner: 10Jdlrobson) [14:31:50] well that was plain weird [14:32:16] web-based ircclient /would not/ detect that i had reconnected and the browser tab wouldn't refresh :/ [14:50:12] Hello. Arab wikipedians community got a grand to create a mobile app to upload images directly into commons. https://www.mediawiki.org/wiki/API:Properties has nothing to offer. Any ideas [14:50:51] Danny_B: Any ideas [14:53:40] Eh, wasn't that disabled because the commons community thought it was resulting in bad uploads ? [14:54:02] oh no, the commons app was pulled because no one was maintaining it. [14:55:08] Tarawneh: https://github.com/wikimedia/apps-android-commons fork and have fun :) [14:56:00] but please do consult with the community, there has been a lot of controversy about uploads over mobile. [14:56:02] thedj: Thanks a million , Will check the pages. What we need is a customized app. Hope I find what I need in the link. Thanks again [14:57:26] thedj: found it, https://www.mediawiki.org/wiki/API:Upload [14:58:04] (03CR) 10Phuedx: Load correct page actions images (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [15:01:19] 3Mobile-Web, MobileFrontend-alpha: Pencil icon is preloaded locked - https://phabricator.wikimedia.org/T74851#947121 (10phuedx) @kaldari I think [180884](https://gerrit.wikimedia.org/r/180884) is waiting on your review. [16:13:00] hey guys..need some help with Xcode setup to run the scripts. I get compile error with npm ERR! Error: EACCES, mkdir '/Users/xxxxx/.npm/through/2.3.6' [16:13:15] I understand the nom script requires sudo access. [16:13:53] I already tried to change the chmod for npm & grunt files. am I not trying the right thing here ? [16:13:59] any advice ? [16:18:23] futur, what are you setting up? [16:18:45] this repo -> https://github.com/wikimedia/apps-ios-wikipedia [16:19:08] trying to contribute with iOS development of new app which in progress [16:19:11] ah, ios [16:19:18] don't know anything about that, sorry [16:19:37] No probs Krenair [16:42:45] (03Abandoned) 10Phuedx: Hygiene: Use the spinner class everywhere [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/172744 (owner: 10Phuedx) [16:45:31] (03CR) 10Phuedx: "It's interesting to me that the tests are passing…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [16:46:09] 3MobileFrontend-stable, Mobile-Web: Talk: "Return to "Foo" page." appears on talk page needs design love - https://phabricator.wikimedia.org/T73919#947226 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson this is good enough. It's still not clear what we do about talk on mobile (e..g how flow fits into that). I'... [16:46:49] @krenair - fixed it.. just nom install inside www folder solved it all [16:52:12] Tarawneh: MobileFrontend itself (the browser mobile version of Wikipedia) has an upload feature, too, but it was disabled because of too many junk uploads :/ [16:53:12] (03CR) 10Phuedx: "This change could be made far less scary/easier to test if you were to break it up into a series of changes: one to introduce the new clas" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [16:55:03] FlorianSW: Thanks :) [16:58:42] (03CR) 10Jhernandez: "phuedx makes no sense, the view is probably not properly tested?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [16:59:09] "phuedx makes no sense." [16:59:16] "the view is probably not tested." [16:59:19] that's how i read that [16:59:20] ;) [16:59:43] oops xD, missed the comma [17:00:48] (03CR) 10Phuedx: "I rarely make sense." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [17:01:16] (03CR) 10Jhernandez: "Now properly constructed, hah" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [17:02:17] lol [17:02:39] brb -- dinner with my parents [17:02:49] phuedx: enjoy! [17:41:54] 3MobileFrontend-stable, Mobile-Web: Search field inaccessible on Opera Mini - https://phabricator.wikimedia.org/T75632#947327 (10dr0ptp4kt) 5Open>3Resolved a:3dr0ptp4kt @Jdlrobson, yep. [17:52:28] eh, do we even have a standup today? [17:54:22] (03CR) 10Phuedx: Hygiene: prep work for collections work (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [17:54:42] MaxSem: maybe? [17:55:12] phuedx, you don't sound confident :P [17:55:18] i'm never confident [17:55:25] i was planning on showing up [17:55:28] (03CR) 10BearND: [C: 04-1] "I'm holding off on merging this for two reasons:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181440 (owner: 10Deskana) [17:55:47] ^ clickbait review message [17:56:06] "You won't believe what he has to say about your change." [17:56:24] "Someone pushed a change. You won't believe what happened next." [17:56:38] (03PS3) 10BearND: Don't transmit zero-result search events in TitleSearchFragment funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181429 (owner: 10Deskana) [17:59:04] (03CR) 10BearND: [C: 032] Don't transmit zero-result search events in TitleSearchFragment funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181429 (owner: 10Deskana) [17:59:28] (03Merged) 10jenkins-bot: Don't transmit zero-result search events in TitleSearchFragment funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181429 (owner: 10Deskana) [17:59:32] (03PS1) 10Kaldari: WIP: Error reporting [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [18:01:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Error reporting [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [18:01:49] joakino: standup? [18:01:58] link? [18:02:09] i don't have it in the calendar phuedx [18:02:12] (03PS2) 10BearND: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181673 (owner: 10Deskana) [18:02:14] lol [18:04:44] (03CR) 10BearND: [C: 032] Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181673 (owner: 10Deskana) [18:05:07] (03Merged) 10jenkins-bot: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181673 (owner: 10Deskana) [18:05:53] (03PS4) 10BearND: Hygiene: reduce number of fields that are used unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181687 (owner: 10Deskana) [18:06:05] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#947354 (10Deskana) Resolved on Android. Still need to happen on iOS. [18:12:03] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#947355 (10Deskana) >>! In T85243#942299, @Nuria wrote: > I would like to add that rather than EL it should be "data collection". It... [18:30:11] 3Wikimedia-Site-requests, MobileFrontend-alpha, Mobile-Web: Permanently enable unregistered users editing on it.m.wikipedia.org - https://phabricator.wikimedia.org/T85317#947387 (10Jdlrobson) @Nemo_bis this is great. Thanks so much for doing the trial and it's exciting to see the result has been positive. It wou... [18:30:40] (03CR) 10BearND: [C: 032] Hygiene: reduce number of fields that are used unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181687 (owner: 10Deskana) [18:31:04] (03Merged) 10jenkins-bot: Hygiene: reduce number of fields that are used unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181687 (owner: 10Deskana) [18:34:41] (03PS3) 10BearND: Hygiene: change some if statements to switch statements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181692 (owner: 10Deskana) [18:34:48] (03CR) 10BearND: [C: 032] Hygiene: change some if statements to switch statements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181692 (owner: 10Deskana) [18:36:50] (03Merged) 10jenkins-bot: Hygiene: change some if statements to switch statements. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181692 (owner: 10Deskana) [18:47:43] (03CR) 10BearND: [C: 04-1] Hygiene: use String instead of StringBuilder where appropriate. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 (owner: 10Deskana) [18:52:50] (03PS3) 10Deskana: Hygeine: use String instead of StringBuilder where appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 [18:53:41] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182086 [18:56:59] (03PS1) 10BearND: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182087 [19:02:26] dr0ptp4kt: hey! have you looked at quarry.wmflabs.org? [19:03:00] YuviPanda: no, but that's sweet [19:03:21] dr0ptp4kt: :D that’s where I ended up at after chasing that around for a while [19:03:29] YuviPanda: :) [19:05:30] (03PS1) 10Deskana: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 [19:06:20] dr0ptp4kt: also, this: https://tools.wmflabs.org/notebooks/yuvipanda/Untitled0 [19:06:51] never fully took off, that. [19:07:05] (03PS2) 10Deskana: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 [19:07:27] YuviPanda: how does one enter a command there? [19:07:36] dr0ptp4kt: one does not :) it’s just a viewer. [19:07:45] YuviPanda: i see [19:07:55] dr0ptp4kt: I had a securieish way to run your kernel on toollabs, but it was only still ‘secureish’ :) [19:08:31] dr0ptp4kt: https://tools.wmflabs.org/notebooks/yuvipanda/Untitled0 [19:08:46] dr0ptp4kt: err, [19:08:46] https://github.com/yuvipanda/labsbooks/blob/master/start.py [19:08:58] dr0ptp4kt: ^ would start a kernel on the grid, and connect you to it via an ssh tunnel [19:09:37] YuviPanda: ah, i get it. cool [19:13:10] dr0ptp4kt: Does this look right? https://gerrit.wikimedia.org/r/#/c/182090/ [19:13:15] brion: ^ [19:13:51] Deskana: checking [19:14:03] lookin [19:15:15] Deskana: i’m not 100% sure whether that gets set once at manager initialization time or whether it’s called multiple times lemme check [19:15:24] if the former it might not pick up changes during a run [19:19:06] phuedx: hey. so what do you want to do about the icons stuff? it's a hack (the fact that :before works) but since it's alpha and closer to the end goal do you think it's worth it...? [19:19:59] jdlrobson: the resource loader thingemy? [19:20:02] i think the only way we are ever going to get all this icon stuff to work is if we start using oojs ui for icons (which also means using oojs ui everywhere unless we find a way to dissect the library to help with that transition) [19:20:07] (was just getting george to bed) [19:20:19] phuedx: sure something to think about for you over bedtime stories. no rush:) [19:20:39] he's asleep now [19:20:41] shoot [19:21:53] (03CR) 10Brion VIBBER: [C: 04-1] "This code only gets run on startup, so I think it won't take into account changes in the setting during runtime. Need to be able to send a" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (owner: 10Deskana) [19:23:30] jdlrobson: agreed [19:23:36] this shouldn't be difficult! :/ [19:32:33] (03CR) 10Jdlrobson: "If anyone from VE team can help me by telling me why my widget doesn't work I'd be most appreciative :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [19:38:18] phuedx: so yeh it's up to you if you want to merge or not [19:38:29] i like that it wraps the images in a nice way and takes care of the svg [19:38:35] yep [19:38:39] by consuming it we also have a stake in its development [19:38:45] at the expense of the :before malarky [19:38:49] yeh [19:39:19] we should use it as motivation to finding a way to kill that either by finding a way to use a lightweight version of OOJS UI or making the module more generic [19:41:48] +1 [19:42:08] i'll re-test it laterz (it's ~quarter to 8 atm) [19:42:34] but i'll be up at 2 am to feed harry [19:42:39] ;) [19:42:46] optimum code reviewing time [19:42:51] tfinc: http://www.yelp.com/biz/city-cell-repair-san-francisco?osq=cell+phone+repair [19:43:33] http://www.yelp.com/biz/citicomm-wireless-san-francisco-6 < tfinc [19:44:33] (03PS9) 10Jdlrobson: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [19:44:57] (03PS10) 10Jdlrobson: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [19:45:53] phuedx: no problem :D sounds good [19:52:57] (03CR) 10Jdlrobson: [C: 032] TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [19:55:38] (03PS9) 10Jdlrobson: PhotoUploaderButton uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [19:56:22] (03CR) 10Jdlrobson: PhotoUploaderButton uses events map (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [19:56:32] (03CR) 10Jdlrobson: [C: 04-1] "See comments on PS8" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [19:56:53] (03Merged) 10jenkins-bot: TableOfContents uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180836 (owner: 10Jhernandez) [19:58:11] (03CR) 10Jdlrobson: PhotoUploaderButton uses events map (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [20:02:31] making good progress on the data converter, will grab some lunch run some errands and get back to it after [20:02:54] Bahaha [20:02:54] http://i.imgur.com/ICSDDhQ.png [20:02:57] What a captcha. [20:03:10] hahahaha best evah [20:03:19] brion: Great stuff! Let me know if you need anything. [20:04:10] Deskana: at some point i’ll want some sample data files i can use to test with. i’ll write up some directions on how to extract them if i can make it fairly easy :D otherwise i’ll write some code to do it for us [20:04:48] or at least make a mode for the onverter that if it fucks up, it offers to upload the files to us for examination [20:04:51] :D [20:05:00] ok foodstufffffffs [20:15:55] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182086 (owner: 10BearND) [20:18:43] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182086 (owner: 10BearND) [20:24:21] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Do not send X-WMF-UUID header in any requests if the user has opted out of EventLogging - https://phabricator.wikimedia.org/T85243#947633 (10Nuria) Thanks for doing these changes. Can we please make sure that in the QA test plan for the next release of the app... [20:33:57] (03PS1) 10BearND: Fix string parameter format error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182098 [20:35:03] (03CR) 10BearND: [C: 032] "translation fix" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182098 (owner: 10BearND) [20:35:29] (03Merged) 10jenkins-bot: Fix string parameter format error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182098 (owner: 10BearND) [20:35:57] (03PS4) 10BearND: Hygeine: use String instead of StringBuilder where appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 (owner: 10Deskana) [20:36:04] (03CR) 10BearND: [C: 032] Hygeine: use String instead of StringBuilder where appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 (owner: 10Deskana) [20:36:27] (03Merged) 10jenkins-bot: Hygeine: use String instead of StringBuilder where appropriate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181533 (owner: 10Deskana) [20:46:25] 3Wikipedia-App-Android-App: NPE when updating ProgressBar - https://phabricator.wikimedia.org/T74817#947659 (10bearND) 2.0-r-2014-12-01 does not have the patch you mention. 2.0-r-2014-12-01 is basically the same as the previous release, 2.0-r-2014-11-03, plus one additional change in event logging. So, I don't e... [20:58:17] (03CR) 10Dbrant: [C: 04-1] "BearND's comment is correct: We're using a constant file name so that it would be overwritten every time an image is shared, and will ther" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181440 (owner: 10Deskana) [21:10:54] (03CR) 10Dr0ptp4kt: "What @brion said. Note, one place you may probably will want to fire a message to update the custom headers is in SessionSingleton::setSen" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (owner: 10Deskana) [21:17:37] (03PS1) 10BearND: Remove unused string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182100 [21:24:20] (03CR) 10Deskana: [C: 032] Remove unused string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182100 (owner: 10BearND) [21:27:46] bear_nd: It seems there's rather a lot of unused strings in there, actually. Should we remove them all? [21:55:13] phuedx: no problem :D sounds good [21:57:01] 3Wikipedia-App-Android-App: Context needed for some Wikipedia android app messages - https://phabricator.wikimedia.org/T69981#947817 (10bearND) 5Open>3Resolved a:3bearND #1: removed unused string #2: screenshots already provided in thread #3: let's avoid plurals for now [21:57:12] 3MobileFrontend-beta, Editing, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#947820 (10Cmcmahon) 3NEW [21:57:47] kaldari: is wolf city the only article on beta labs that's wired up to wikigrok c? [21:58:01] Yes, I'll add some more.... [21:58:10] ty :) [22:08:33] bear_nd, do you know when the next stable and beta updates will be? and where history and saved pages are saved? [22:09:05] 3MobileFrontend-beta, Editing, VisualEditor: Back arrow appears before other VE controls but does nothing - https://phabricator.wikimedia.org/T85481#947855 (10Cmcmahon) 3NEW [22:09:34] kaldari: do you know if Mediawiki:Common.css does not apply to Special:UserLogin for some reason? [22:10:05] jhobs: I believe it is excluded from that page specifically [22:10:35] 3MobileFrontend-beta, Editing, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#947861 (10Cmcmahon) [22:10:40] jhobs: as is Common.js [22:10:51] kaldari: Can I still make a subpage Special:UserLogin/common.css and it will apply, or is there some other way for me to apply styling to UserLogin? [22:11:55] jhobs: not sure. jdlrobson: are you fimilar with the change that excluded common.js and common.css from Special:UserLogin? [22:12:12] Krenair: Not sure when the next beta release will be, but I don't see the need for one during this week since dbrant is not around. We'll do at least one more beta release before the next stable release. I believe next stable release should be around Jan 15 IIRC. [22:12:19] jdlrobson: and do you know if there's any workaround? [22:13:26] jhobs: common.js was excluded do to security concerns, but if you ask me there's isn't as much of an argument for exclding common.css. [22:14:05] kaldari: I assume worst case I can still apply styles by adding less files as dependencies to the ZeroPortal extension? [22:14:11] yes [22:14:22] ok good, I was hoping to keep this on-wiki if possible though [22:14:41] so if jdlrobson does happen to know of a workaround, definitely please let me know [22:14:50] jhobs: The change was made relatively recently I believe. You may want to ask about it on #wikimedia-dev and argue for re-enabling common.css. [22:15:32] Krenair: history info is stored in the Sqlite db inside the apps data folder. Saved pages has another table in the same DB, but also saved the page contents and the images in a subfolder of the app's data folder. So, both are using internal storage. [22:15:44] kaldari: well I guess I could see reasons for wanting to exclude the login page from certain common.css files, so I'd be hesitant to re-enable it by default in core [22:16:11] kaldari: but an option to include/exclude any pages via a PHP var or something would be nice [22:16:24] kaldari: or better yet, a special page [22:16:45] kaldari: I'll bring that up with wikimedia-dev [22:16:46] bear_nd, great, thank you [22:19:03] jhobs: according to the peanut gallery, you'll probably just have to use less files for it, as the change is unlikely to be revisitied. [22:19:10] 3Wikipedia-App-Android-App: UnsupportedOperationException in MenuWrapperFactory.wrapSupportMenu - https://phabricator.wikimedia.org/T78738#947876 (10bearND) Yes, that's from the same user and same 3.1 Samsung device. We probably should ask him to refrain from long pressing any text inside the pages until we get... [22:19:22] kaldari: that's what I figured. Thanks for the poll [22:22:39] bear_nd, previous searches are stored in that db as well? [22:23:30] Krenair: yes, we really only use one DB, just using different tables in there for various things [22:24:35] 3MobileFrontend-beta, Editing, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#947889 (10Etonkovidova) The following error is displayed: Uncaught TypeError: boolean is not a functionload.... [22:24:43] Krenair: you can clear the DB in settings > Apps> Wikipedia > "Clear data". this will remove the DB, also any locally stored files, and any shared properties (=user settings, etc.) [22:25:42] this was just to answer someone's questions, they didn't ask about clearing it [22:27:09] bear_nd, and no one is working on the wiktionary app, right? [22:28:44] Krenair: you're correct. AFAIK, nobody is working on it. [22:29:06] maybe Deskana knows more about this [22:29:36] bear_nd is correct :) [22:32:58] hmm [22:34:04] app using too much data - what can we do here apart from the option to disable images (which was already implemented)? [22:34:55] Not an awful lot, unfortunately. [22:35:16] Monte once said that the HTML returned by the API for [[Barack Obama]] is around 1 MB [22:35:18] Which is insane [22:35:24] Then add images on to that... [22:36:10] Parsoid may be able to help with that as it might allow us to request only exactly what we need [22:36:18] But that's not going to happen quickly [22:37:16] (03CR) 10Jdlrobson: [C: 032] "keeping things moving. can fix issues in follow up" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [22:37:16] Deskana: it's around 1mb uncompressed, so not quite as bad over the network with gzip [22:37:43] Yeah, we've since started compressing things which helps. [22:37:57] see https://phabricator.wikimedia.org/T78676 [22:38:11] 172k from the mobile site [22:39:00] (03PS1) 10Bmansurov: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 [22:39:03] So, in short, there's nothing we can do quickly. [22:39:03] (03Merged) 10jenkins-bot: PhotoUploaderButton uses events map [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180837 (owner: 10Jhernandez) [22:39:24] Deskana, I guess that's the answer to https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8011730 then? :) [22:39:44] (03PS2) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [22:40:20] (03PS3) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [22:41:15] Deskana: in apps you could possibly use more aggressive compression like lzma; for Obama that reduces it from 172k to 134k [22:41:44] (03PS4) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [22:47:29] jhobs, kaldari: have you found a way to re-enable Commons.css on Special:UserLogin and Special:Preferences? If not, it should be enough to set $wgAllowSiteCSSOnRestrictedPages to true in your LocalSettings.php and MediaWiki:Commons.css is applied on special pages (not Common.js) [22:47:32] see https://www.mediawiki.org/wiki/Manual:$wgAllowSiteCSSOnRestrictedPages [22:48:07] Krenair: Yes. I'll write the reply. [22:48:16] okay [22:48:52] FlorianSW: Oh, nice find [22:49:11] it was added because of massive protests of third parties :P [22:49:15] iirc [22:49:33] where are you intending to use this? [22:50:23] thanks FlorianSW! [22:51:05] np jhobs :) [22:51:22] jhobs, kaldari: where are you planning to use that? [22:51:23] (03PS5) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [22:51:41] Krenair: Wikipedia Zero Portal [22:51:51] in production? [22:51:55] yes [22:52:08] jhobs: then i would suggest to use a RL module for it [22:52:22] because it would be difficult to activate this config won wmf wikis [22:52:25] oh that's a strange fishbowl wiki isn't it? [22:52:35] yeah basically [22:52:43] FlorianSW, eh, fishbowl wikis may be able to get this configuration [22:52:56] foundationwiki has raw HTML for goodness sake... [22:52:57] FlorianSW: I should be able to only activate it for ZeroPortal extension though, right? [22:53:05] yeah we use raw HTML as well on-wiki [22:53:22] fishbowl wiki? :confused: :( [22:53:42] FlorianSW, logged in editing only, restricted registration [22:53:44] take a look at zero.wikimedia.org and that might explain [22:53:44] jhobs: You can make configurations dependent on extensions, yes [22:53:52] basically anyone can view, only authorised editing [22:54:04] And even most of our pages require login to view [22:54:10] ah, or office wiki [22:54:23] no, then not like office wiki [22:54:29] but i understand :) [22:54:33] thx! [22:54:53] Although looking at this zero.wikimedia.org wiki, it seems to be private with just Special:ZeroPortal exposed? hmm [22:55:04] yes Krenair [22:55:30] and ZeroPortal uses Lua modules as a router/state machine to determine which page to show the user [22:55:44] I believe we'll be doing a talk on it at the developer summit if I'm not mistaken [22:55:48] umm [22:55:56] jhobs: is this wiki managed by operations-mediawiki-config repository? [22:55:58] (03PS8) 10Jdlrobson: Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [22:56:08] (03PS9) 10Jdlrobson: Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [22:56:10] FlorianSW, yes [22:56:13] why? [22:56:25] MaxSem: oh, cool :) [22:56:32] those decisions were made before I was hired Krenair [22:56:39] ah :) [22:56:45] I believe for the rapid development/deployment cycle though [22:57:19] kaldari: can you take a look at https://gerrit.wikimedia.org/r/180102 ? [22:57:33] (03CR) 10Jdlrobson: [C: 031] "haven't tested yet" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [22:57:52] (03PS1) 10Jdlrobson: Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 [22:58:32] (03CR) 10Jdlrobson: [C: 04-1] Change navigation easing function (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov) [22:59:33] MaxSem: https://gerrit.wikimedia.org/r/#/c/181683/ ? [23:00:58] jdlrobson: sure [23:01:39] bear_nd, so https://phabricator.wikimedia.org/T78738 - issue with specific 3.1 samsung device, we need a support library update to fix it? [23:01:58] and in the mean time, tell them that we understand the issue and that it's caused by long pressing? [23:03:28] Deskana: do you know when the patch of https://phabricator.wikimedia.org/T76279 will be released, so the user can test it? [23:04:02] (03CR) 10MaxSem: [C: 04-1] "Lacks localisation." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [23:04:19] beta sometime before the 15th, I think bear_nd suggested for the next update? [23:04:42] back button behaviour seems badly broken on mobile on latest master - is that just me? kaldari FlorianSW [23:04:54] FlorianSW: It should be in beta right now, and should hopefully be in production on around 15th Jan. [23:05:10] * FlorianSW test the back button behavior [23:06:03] thx Deskana :) [23:06:48] Krenair: re: https://phabricator.wikimedia.org/T78738. Yes, the support library issue is tracked here: https://code.google.com/p/android/issues/detail?id=80434. Links is also in the task. We're currently using version 21.0.2. According to the page there I don't see any progress in fixing this (even though 21.0.3 is out) [23:07:15] seems broken on VE overlay and notification overlay [23:07:23] jdlrobson: what you mean exactly? Seems to be working on chrome mobile and desktop (both alpha and logged in) :/ [23:07:35] i'm in chrome and clicking browser back and clicking the X icons [23:07:36] oh yeah :o [23:07:38] and sometimes they don't work [23:07:45] on notification overlay [23:07:47] have no minimum test case yet though [23:07:54] not on editor (source, not VE) [23:08:04] (03PS4) 10Jdlrobson: Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 [23:08:09] (03CR) 10Jdlrobson: [C: 032] Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [23:09:22] jdlrobson: I just reported https://phabricator.wikimedia.org/T85481 and also https://phabricator.wikimedia.org/T85480, might be related [23:09:36] (03Merged) 10jenkins-bot: Refactor Watchstar view to use events map with View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [23:09:42] (03CR) 10Jdlrobson: [C: 04-1] "kaldari is slacking so if you fix this i'll merge as is" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [23:10:13] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed :-/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [23:11:16] jdlrobson: it think it can be a change after my remove of of the wait before detach() the overlay when use hide() because i tested this behavior (i though that the notificationoverlay was the "animation to wait for") [23:11:42] kaldari, 8c7a69a55a4efa2cb105abc39227d8992dc14f50 [23:12:45] (03CR) 10Bmansurov: Load correct page actions images (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [23:12:50] (03PS3) 10Bmansurov: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 [23:12:57] (03PS6) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [23:12:58] (03CR) 10jenkins-bot: [V: 04-1] Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [23:13:50] jdlrobson: notificationsoverlay works perfectly with f4e6161, so it seems to be https://gerrit.wikimedia.org/r/#/c/181702/ [23:14:09] I68485a0b70028d322b92b25864465346f9cdc5c7 [23:15:55] (03CR) 10Jdlrobson: [C: 04-1] "Exciting :)" (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [23:16:07] FlorianSW: yeyy i broke it hah :) [23:16:19] yeah: no release-week :D [23:16:22] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [23:16:44] i open a bug and file a patch, ok? (if i find a proper way :P) [23:18:38] (03PS1) 10Jhobs: Enable $wgAllowSiteCSSOnRestrictedPages [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182112 [23:23:01] (03PS4) 10Bmansurov: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 [23:24:38] (03CR) 10jenkins-bot: [V: 04-1] Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [23:26:34] (03PS5) 10Bmansurov: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 [23:28:23] 3Editing, MobileFrontend-beta, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#948005 (10Jdlrobson) a:3Jdlrobson [23:30:29] (03PS1) 10Jdlrobson: Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 [23:31:08] (03PS7) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [23:31:30] (03PS2) 10Bmansurov: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 [23:32:30] (03PS3) 10Jdlrobson: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov) [23:34:34] (03CR) 10Jdlrobson: "Can't test properly because of https://phabricator.wikimedia.org/T85292 :-/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov) [23:47:11] (03PS1) 10Jdlrobson: Login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182116 [23:52:42] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#948112 (10Jdlrobson) 3NEW [23:54:28] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#948112 (10Jdlrobson) [23:59:03] (03PS8) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082