[00:03:52] Maryana: There should be two articles now with WikiGrok on beta labs [00:04:17] gracias, kaldari [00:04:25] are they also krautrock? [00:04:47] kaldari: when i click on Wikigrok in sidebar /wikigrokversion c) on article Wolf City the page just reloads (with parameter wikigrokversion=c) but does nothing? :/ [00:05:11] haha, and the answer is: yes [00:05:30] FlorianSW: try it again [00:05:56] kaldari: ooh, it looks like the live/studio tags switch positions, which is kind of confusing [00:07:32] kaldari: hmm, same, sometimes i get redirected to the article Ricochet, sometimes the article just reloads :/ [00:07:39] Maryana: I only import articles that I actually wrote so as not to incur anger from the copyright patrol [00:07:56] Maryana: Thus the limited subject matter :) [00:08:11] i'm still only getting 2 [00:08:14] what's the 3rd? [00:08:14] FlorianSW: It's progress! [00:08:33] (03CR) 10Bmansurov: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [00:09:03] FlorianSW: sorry, I have to manually add more to the table... [00:09:28] kaldari: hmm, ok :) [00:13:59] * AndyRussG waves [00:14:08] Hi all! Anyone have any ideas why this is not working? https://git.wikimedia.org/blob/operations%2Fmediawiki-config/0655421ed9ea9ce198f3ca619fd845fa421c2023/wmf-config%2Fmobile.php#L66 [00:14:11] Also, I've been asked to check that not redirecting ugly urls ('/w/index.php?title=X') is considered a stable and normally-used feature of the mobile redirect system [00:15:35] Here's the change where it's being talked about: https://gerrit.wikimedia.org/r/#/c/182074/ [00:16:13] And here's a related confg change (that wouldn't be needed if mobile.php worked): https://gerrit.wikimedia.org/r/#/c/182078/ [00:16:32] (03PS1) 10Florianschmidtwelzow: Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 [00:16:38] MaxSem: kaldari: jdlrobson: ^ :) [00:16:48] 3MediaWiki-Categories, MobileFrontend-Feature-requests: (2) Restyle category pagination links as buttons - https://phabricator.wikimedia.org/T85495#948168 (10Jdlrobson) 3NEW [00:17:57] (03CR) 10jenkins-bot: [V: 04-1] Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 (owner: 10Florianschmidtwelzow) [00:18:39] 3MediaWiki-Categories, MobileFrontend-Feature-requests: (3) 3 column responsive layout for categories - https://phabricator.wikimedia.org/T85496#948174 (10Jdlrobson) 3NEW [00:18:49] looking [00:19:04] thx! [00:19:30] (03PS1) 10Jdlrobson: Hygiene: Remove unused active property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182119 [00:19:32] (03PS1) 10Jdlrobson: Hygiene: Remove unnecessary uses of getTokenWithEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182120 [00:20:51] (03PS2) 10Florianschmidtwelzow: Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 [00:21:11] AndyRussG, in what context are you using these urls? load.php? [00:22:59] (03CR) 10jenkins-bot: [V: 04-1] Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 (owner: 10Florianschmidtwelzow) [00:24:45] MaxSem: Hmm good quesiton. Yes, I guess so. The calls are made in the background from JS and the URLs are fetched via mw.config.get, and are set from PHP in the ResourceLoaderGetConfigVars... So, yes. [00:25:47] there's no way to do mobile detection in RL so you'll have to stick to that solution:P [00:26:02] The code there seems specifically meant to deal with this issue... I can imagine that it might ahve once worked that it broke one day and no one noticed [00:26:24] because resources are always served from the same domain, bits.wikimedia.org [00:26:38] (03PS3) 10Florianschmidtwelzow: Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 [00:28:15] MaxSem: Yeah no problems with the ugly URL route, just thought it best to find out more about this config code, too [00:28:39] (03PS1) 10Florianschmidtwelzow: Hygiene: Use group as a parameter to phpunit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182122 [00:29:17] no, it's only going to work only for stuff executed only from a mobile domain [00:30:55] FlorianSW: i'm still exploring the notification overlay. Basically the hide event gets turned off before it can run and i can't work out why [00:31:19] jdlrobson: yes, i know :) -> https://gerrit.wikimedia.org/r/#/c/182118/ [00:31:31] but i'm happy if you find a better solution :P [00:32:00] see OverlayManager.js [00:32:09] FlorianSW: yeh i saw. It's the only one that uses this event right? [00:32:18] MaxSem: Hmm, if that's the case then maybe the code that changes the CentralNotice config variables should be removed? I'm pretty sure those vars are only used for the URLs for the background JS calls [00:32:28] jdlrobson: i haven't found any other, yes [00:32:39] all others simply use the "built-in" function of Overlay.js [00:32:42] If you don't know of any other reason for that code there, I'll submit a patch to remove it (the CentralNotice-related bit) [00:32:43] well it still works for page views [00:32:45] which is working fine there [00:32:49] (03PS1) 10Jdlrobson: Run 'this page has issues' on category pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 [00:33:36] (03PS16) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [00:33:49] $wgCentralBannerDispatcher and $wgCentralBannerRecorder point to pages that are not "viewed" by users per se [00:34:41] mhm, i'm fine with any change that doesn't break anything:P [00:35:12] K I'll submit a patch... [00:35:36] yeah actually $wgCentralBannerDispatcher is deprecated in favor of $wgCentralSelectedBannerDispatcher [00:35:46] But $wgCentralBannerRecorder is still used [00:36:18] I guess if you think of any other reason for the config code there, you could let me know pls? [00:36:53] sure:) [00:37:24] Maryana, FlorianSW: There are 3 wikigrok articles on beta labs now! [00:37:35] w00t [00:39:54] kaldari: you wrote the emma goldman article? [00:39:57] kaldari: sry for the noob question, but maybe i really really misunderstand the functionality of wikigrokc or i'm to silly to get it working :( I still get redirected to the same article all the time i click on Wikigrok in sidebar. [00:40:20] FlorianSW: hm, that's a bug. i'm getting 3 different articles [00:40:36] try clearing cache/cookies? [00:40:37] Maryana: well, I co-wrote it with some other people :P I couldn't find any others that were actually WikiGrok eligible. [00:40:55] i'm getting always Emma Goldman and cleared my browser cache. [00:40:59] that's awesome. gold star :) [00:41:05] or uh, red star, i guess? [00:41:36] MaxSem: any thoughts on the other point (whether non-redirecting ugly URLs is a stable feature)? It's just a question that came up in CR [00:41:38] heh [00:41:49] FlorianSW: how odd. what browser/device? [00:41:51] been like that always [00:42:17] Maryana: chrome, desktop, trying htc one now (chrome mobile) [00:42:18] K sounds good enuf [00:42:32] FlorianSW: it randomly shows me 1 of 3 [00:43:19] FlorianSW: Maybe you're stuck in a statistical anomaly :) [00:43:33] kaldari: oh no, not again :D [00:43:45] (03PS1) 10Jdlrobson: Remove unused test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182126 [00:43:46] no, same on htc one and chrome mobile, always Emma Goldman [00:44:14] maybe because of my long username :P [00:44:23] kaldari, Maryana ^^ [00:44:31] haha [00:44:55] wikigrok is actually now just a test of latent anarchist sympathy [00:45:08] are you now or have you ever been an anarchist, FlorianSW?? [00:45:11] ;) [00:45:36] hmm, that's very strange [00:45:41] öhm :P [00:46:08] hmm, i logged out and logged in on chrome mobile and now it seems to work... [00:48:04] hmm, on chrome desktop, too :) [00:48:39] kaldari, MaxSem, jdlrobson: can you take a quick look on https://gerrit.wikimedia.org/r/#/c/182122/ ??? :) [00:49:15] (03CR) 10MaxSem: [C: 032] Hygiene: Use group as a parameter to phpunit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182122 (owner: 10Florianschmidtwelzow) [00:50:16] (03PS1) 10Bmansurov: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 [00:50:26] thanks MaxSem :) [00:50:34] (03Merged) 10jenkins-bot: Hygiene: Use group as a parameter to phpunit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182122 (owner: 10Florianschmidtwelzow) [00:50:42] beat me to it :) [00:51:00] :P thanks to you too :) [00:51:39] the category overlay seems to be used very activley for an alpha feature, what do you mean jdlrobson? http://mobile-reportcard.wmflabs.org/#other-graphs-tab [00:51:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 (owner: 10Jdlrobson) [00:52:00] FlorianSW: mm? [00:52:08] what is the question? [00:53:27] FlorianSW: also without knowing how big our audience on alpha is it is hard to judge from the page-ui-daily graph whether it is being used actively. [00:54:02] ah, ok, that's an answer to my not asked question :) [00:54:56] (03CR) 10Kaldari: [C: 032] Remove unused test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182126 (owner: 10Jdlrobson) [00:59:50] (03Merged) 10jenkins-bot: Remove unused test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182126 (owner: 10Jdlrobson) [01:05:28] (03PS1) 10Jdlrobson: Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 [01:05:35] FlorianSW: ^ :D [01:05:39] worked it out [01:05:54] ^ kaldari [01:06:21] (03CR) 10Jdlrobson: [C: 04-1] "See https://gerrit.wikimedia.org/r/182128" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 (owner: 10Florianschmidtwelzow) [01:06:56] (03CR) 10jenkins-bot: [V: 04-1] Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [01:09:01] jdlrobson: yay, testing it :) [01:10:29] (03PS4) 10Florianschmidtwelzow: Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 [01:10:31] (03Abandoned) 10Florianschmidtwelzow: Fix: Close notifications Overlay correctly when click on cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182118 (owner: 10Florianschmidtwelzow) [01:10:56] (03CR) 10Jdlrobson: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [01:11:25] jdlrobson: can you jump on https://phabricator.wikimedia.org/T85151 to continue our lunch time conversation ? [01:12:48] (03CR) 10Florianschmidtwelzow: Fix notification overlay back behaviour (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [01:13:15] (03CR) 10Jdlrobson: [C: 04-1] "I showed this to Maryana and she wasn't quite sure about the notifications animation - when closing the notification drawer a bit of the m" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov) [01:14:07] (03CR) 10Bmansurov: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [01:14:33] (03PS2) 10Bmansurov: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 [01:23:30] MaxSem: Hi sorry 2 bother again, just to check once more: in RL context, $mobileContext->shouldDisplayMobileView() will not work? I just came across its use directly in the ResourceLoaderGetConfigVars hook of CentralNotice https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/e2233ec9bc2550f864334ee941b18b8bce7fbbdc/CentralNotice.hooks.php#L337 [01:24:11] (If it doesn't work at all I'll also remove it, or at least doesn't work in the WMF setup, I'll add a comment) [01:28:42] AndyRussG, correct - I don't see how it should work - but requires verification :) [01:29:42] K... I'll just add a FIXME in the code... It's not a huge issue, I just wouldn't want someone to come across that and assume it _was_ working [01:31:18] @Maryana can you add Dan to our current sprint board in trello? thanks [01:31:29] Maryana: ^ [01:32:40] dan garry? [01:35:17] AndyRussG, also getMobileUrl() should fail on some wikis [01:36:55] fail, as in break and cause an error? (in CentralNotice I don't see it used outside the RL hook context) [01:37:07] i.e., this apparently dead code [01:38:23] as in return a bogus url [01:40:22] Hum OK might as well just remove it then [01:41:54] (03CR) 10Jdlrobson: [C: 04-1] "listening to @phuedx" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [01:41:57] "// FIXME The following code does nothing, but could break stuff unpredictably if fiddled with".... [01:44:49] bmansurov: just added dan andrescu to the current sprint board. hope that was the dan you were referring to :) [01:45:02] Maryana: yes and thanks [01:48:34] (03PS8) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 [01:49:06] (03CR) 10Jdlrobson: Hygiene: Introduce Schema class (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [01:49:47] (03CR) 10Kaldari: [C: 032] Add WikiGrok response badges for wg-sidebar (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [01:49:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [01:51:07] (03Merged) 10jenkins-bot: Add WikiGrok response badges for wg-sidebar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180102 (owner: 10Robmoen) [01:51:10] jdlrobson, MaxSem: https://trello.com/c/ZCDlJJBX/2-3-after-completing-5-25-and-50-in-wikigrok-roulette-i-get-a-thank-you-message-with-badges [01:59:38] (03PS2) 10Jdlrobson: Hygiene: Remove unnecessary uses of getTokenWithEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182120 [02:00:03] (03PS2) 10Jdlrobson: Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 [02:00:22] (03PS2) 10Jdlrobson: Login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182116 [02:00:29] (03PS3) 10Jdlrobson: Login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182116 [02:02:33] (03PS1) 10Jdlrobson: Hygiene: Move tagButton code into a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 [02:03:02] MaxSem: https://gerrit.wikimedia.org/r/#/c/182132/ [02:08:52] (03PS1) 10Jdlrobson: WIP: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [02:11:29] (03CR) 10Florianschmidtwelzow: Error reporting interface for alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [02:11:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 (owner: 10Jdlrobson) [02:15:51] (03CR) 10Kaldari: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [02:18:23] (03CR) 10Kaldari: Error reporting interface for alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [02:21:42] (03CR) 10Kaldari: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [02:32:14] (03CR) 10Bmansurov: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [02:45:30] (03CR) 10Phuedx: [C: 032] Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 (owner: 10Jdlrobson) [02:45:45] midnight review! [02:46:04] harry is in a post-bottle daze [02:46:52] (03Merged) 10jenkins-bot: Use ResourceLoaderImage module in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179005 (owner: 10Jdlrobson) [04:40:34] 3Wikipedia-App-Android-App: StringIndexOutOfBoundsException in LicenseActivity - https://phabricator.wikimedia.org/T85510#948484 (10bearND) 3NEW [05:50:52] (03PS1) 10BearND: Don't export activities (except PageActivity) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182146 [06:01:06] (03PS5) 10BearND: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant) [06:01:22] (03PS3) 10BearND: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [06:16:30] (03PS9) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 [06:16:32] (03PS1) 10Jdlrobson: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 [06:16:53] (03PS10) 10Jdlrobson: Hygiene: Use Schema class for all event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 [06:34:19] (03PS2) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 [06:36:11] (03CR) 10jenkins-bot: [V: 04-1] Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 (owner: 10BearND) [06:42:42] (03PS1) 10BearND: Checkstyle: switch without default clause [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182150 [06:46:46] (03CR) 10jenkins-bot: [V: 04-1] Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [07:01:01] (03CR) 10Deskana: [C: 032] Checkstyle: switch without default clause [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182150 (owner: 10BearND) [07:01:24] (03Merged) 10jenkins-bot: Checkstyle: switch without default clause [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182150 (owner: 10BearND) [09:35:18] morning [10:20:37] yo [10:20:47] sup phuedx [10:21:02] i forgot to open up my irc client ;) [10:21:05] i'm having a good day [10:21:17] haha [10:21:33] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#948721 (10fbstj) It could also be used on Special:RecentChanges and most other page lists. Probably only as a user preference. [10:21:43] i'm reviewing jdlrobson's huge logging patch [10:22:12] cool [10:22:17] i was going to pick that up this morning [10:22:25] but if you're on it, then i won't ;) [10:22:29] do so, it's pretty big [10:22:43] for the looks of it i'm going to -1 and leave a few comments [10:22:48] i'm half way through [10:22:59] phuedx: were you ging to review or code it? [10:23:14] review [10:24:25] 👍 just do if you want, the more eyes we get on it, the better [10:41:16] (03CR) 10Jhernandez: [C: 04-1] "Very cool patch, scary in deed :p" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [10:49:21] (03CR) 10Jhernandez: [C: 04-1] "Looks good, just a couple of little comments" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [10:49:32] (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [11:00:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/181194 (owner: 10Dr0ptp4kt) [11:08:18] (03CR) 10Jhernandez: [C: 032] Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:09:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:20:55] (03CR) 10Phuedx: [C: 032] "Tested locally by throttling my connection in Chrome's DevTools with and without debug enabled. Nice work!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [11:22:22] (03Merged) 10jenkins-bot: Load correct page actions images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180884 (owner: 10Bmansurov) [11:23:09] (03CR) 10Phuedx: "Kicking the tyres…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [11:42:08] (03PS2) 10Jhernandez: Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:42:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:42:26] (03CR) 10Jhernandez: "Rebased and fixed error" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:44:38] (03PS3) 10Jhernandez: Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:46:42] (03CR) 10Jhernandez: [C: 032] "Rebased and fixed conflicts" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:48:15] (03Merged) 10jenkins-bot: Hygiene: Enforce documentation of function parameters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182111 (owner: 10Jdlrobson) [11:51:23] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove unused active property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182119 (owner: 10Jdlrobson) [12:05:59] (03CR) 10Jhernandez: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [12:06:56] (03PS3) 10Jhernandez: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [12:11:53] (03CR) 10Jhernandez: [C: 031] "I've converted a property check to `prop in obj` and changed explicit boolean conversion to use the `Boolean` constructor instead of havin" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [12:21:52] joakino: i have a bug in mobile view. are you the person to poke? [12:22:30] or is it phuedx ? [12:22:41] both [12:22:46] even better [12:22:52] i wanted to upload it to pahb [12:22:54] *phab [12:23:09] but it limits the file size, so i can't upload the screencast [12:23:24] where should i put it for your ease of access? on commons ? [12:23:37] commons, maybe [12:23:57] and raise a bug against phab too! [12:29:01] phuedx: https://phabricator.wikimedia.org/T85525 [12:29:22] managed to reduce the size, hope qulity is high enough to understand the flow [12:34:16] matanya: i'll create a trello card to track the bug through our process [12:34:24] thank you [12:34:35] we've dealt with a permissions error recently, i wonder if they're related [12:34:43] i'll try and find that one too [12:34:52] if something isn't clear there, please poke me [12:35:39] it seems clear: you're trying to delete a file, which you have permission to do, and you get stuck in a login loop [12:35:58] yeah [12:37:29] cool [12:38:03] phuedx: we will see it tomorrow in standup and prioritize, but we can probably talk about it today in irc this afternoon [12:38:11] matanya: ^ [12:38:15] thanks matanya [12:38:25] :) [12:38:44] another permissions bug that we've had recently: https://trello.com/c/CfvFwqA9/36-bug-72877-cannot-edit-a-page-through-mobilefronted-despite-being-logged-in-and-having-appropriate-permissions [12:39:05] maps to: https://phabricator.wikimedia.org/T74877 [12:45:08] phuedx: i faced that one too, amire reported it on my behalf [12:45:16] indeed [12:45:36] right -- i've got to head off to have some lunch [12:45:41] i'm starving! [12:45:42] bbiab [12:45:47] see you! [12:46:00] matanya: i've yet to create the tracking card, but it's the first thing i'll do when i get back [12:50:18] (03CR) 10Phuedx: [C: 04-1] "This doesn't work because of how jQuery figures out data attribute names (see http://stackoverflow.com/a/22753630)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [12:50:23] ok [12:50:26] now i'm gone! [13:11:33] out for lunch [13:58:48] matanya: i've created the tracking card: https://trello.com/c/b5Clx0cP/60-t85525-failing-to-delete-image-on-commons-using-mobile-view [13:59:05] this might change as we've got a thing that imports phabricator tasks into trello [13:59:06] maybe [14:34:30] (03PS2) 10Phuedx: Hygiene: Move tagButton code into a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [14:36:00] (03CR) 10Phuedx: "PS2 fixes the problem in the simplest possible way (lowercasing the key passed to $.data)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [14:36:29] joakino: ^ could you review that when you get back [14:36:33] i've tested it and it works just fine [14:36:45] but i've modified a large-ish bit of the patch (3 whole lines (!!!)) [14:37:45] phuedx: i'll have a look :D [14:37:50] ta :) [14:41:01] 3MobileFrontend-alpha, Wikimedia-Site-requests, Mobile-Web: Permanently enable unregistered users editing on it.m.wikipedia.org - https://phabricator.wikimedia.org/T85317#948901 (10hoo) 5Open>3Resolved a:3hoo Deployed the patch now. For the rational please refer to the gerrit change set. [14:43:30] brb [14:47:31] (03PS3) 10Jhernandez: Hygiene: Move tagButton code into a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [14:52:55] (03CR) 10Jhernandez: [C: 032] "I've changed the data-attributes to lowercase for consistency" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [14:54:34] phuedx: ^ i've also changed the hogan attributes for consistency, what a mess of api, as usual... [14:54:48] it's a +2 for me, feel free to merge [15:03:46] (03PS1) 10Jhernandez: Standarize jsdoc param types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182178 [15:09:25] wtf, jsduck gives me a warning here Warning: /javascripts/modules/editor/VisualEditorOverlay.js:229: Unknown type jqXHR , but not in another file javascripts/api.js|78 col 17| * @returns {jqXHR} [15:09:29] i don't understand... [15:16:21] @ignore really ignores everyting... [15:16:50] (03PS1) 10Jhernandez: Fix jsdoc errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182183 [16:02:26] 3MediaWiki-Page-protection, Mobile-Web, Wikipedia-App-Android-App: autoconfirmed users unable to edit semiprotected page via mobile - https://phabricator.wikimedia.org/T85528#948930 (10jeremyb-phone) 3NEW [16:30:57] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#948953 (10Jdlrobson) for the time being this would only able to mobile mode. we have a beta and alpha product that this can be added to this can i... [16:42:59] joakino: yeah, @ignore is a blunt instrument [16:43:10] sorry -- was offline for a bit [16:43:34] phuedx: don't worry :D [16:43:41] (03CR) 10Phuedx: [C: 032] Hygiene: Move tagButton code into a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [16:44:34] joakino: i've switched back to vim [16:44:55] \o/ welcome back! [16:44:56] haha [16:45:01] (03Merged) 10jenkins-bot: Hygiene: Move tagButton code into a template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182133 (owner: 10Jdlrobson) [16:56:28] lol, now i notice, that outlook doesn't synchronize with the imap server of my e-mail provider :o and i was wondering, why i get no E-Mails :D [16:59:32] 3MediaWiki-Page-protection, Wikipedia-App-Android-App: autoconfirmed users unable to edit semiprotected page via mobile - https://phabricator.wikimedia.org/T85528#948995 (10Jdlrobson) [17:06:47] FlorianSW: we've all been really, really quiet! [17:07:37] phuedx: yeah, i see, 78 unread e-mails is very good :) [17:22:03] bear_nd, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=8046324 - app claims no internet connection while there is one, I guess it runs into network exceptions? [17:24:53] Krenair: whenever we catch any Exception while we're talking to the API we spit out this error message. Before we were catching it the app would crash, now it emits a misleading error message [17:25:30] yeah :/ [17:25:49] guess there needs to be a way to see the actual exception that occured [17:25:52] occurred* [17:26:50] Krenair: yeah. I think we need to expose some more diagnostics somehow. Would you create a Phab task for this? [17:28:15] ok [17:31:02] 3MediaWiki-Page-protection, Wikipedia-App-Android-App: autoconfirmed users unable to edit semiprotected page via mobile - https://phabricator.wikimedia.org/T85528#949033 (10Krenair) I noticed that (while logged in), I can't seem to edit any wiki's MediaWiki namespace pages. When I click the lock icon, it says "T... [17:48:46] joakino: full screen terminal makes me focus a whole bunch better [17:48:50] i have missed it [17:49:14] joakino: very nice work with your events map in Mantle's view :) [17:49:26] phuedx: yeah its awesome [17:49:28] like iterm2 [17:49:36] FlorianSW: yeah i'm very happy [17:49:52] FlorianSW: i'm going to start searching through views and do small improvements [17:50:15] yeah :) [17:54:07] joakino: did that get merged? [17:54:29] hey phuedx FlorianSW joakino :) [17:54:33] yo [17:54:44] hi jdlrobson :) [17:55:05] phuedx: yea [17:55:10] (03CR) 10Bmansurov: "I think we should take care of situations where the result is null. If we are not expecting a null, then nothing to worry. If a null is a " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [17:55:12] joakino: \o/ [17:55:13] morning/evening jdlrobson [17:55:23] "mevening" [17:55:24] i miss europe :-/ [17:55:33] if it wasn't so cold right now i'd be there in a flash.. [17:55:57] i want mulled wine. bet you have loads of that FlorianSW can't find any in San Francisco [17:56:03] this ain't cold [17:56:11] it's crisp [17:56:13] ;) [17:56:57] haha [17:57:07] lol :D [17:57:21] it's not cold, it's normal :P [17:57:58] :P [17:58:36] jdlrobson: you can make your own mulled wine in SF, too ;) [17:59:05] (03CR) 10Jdlrobson: Introduce Schema class (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [17:59:10] mulled wine party in january? [17:59:20] phuedx: YES [17:59:22] (03PS2) 10Jdlrobson: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 [17:59:59] phuedx: joakino also i'm desperately trying to convince other members of the team that we should do this when you come ->http://www.yelp.com/biz/real-escape-room-san-francisco [18:00:10] they are worried about claustrophobia though [18:00:20] also FlorianSW did you think more about Lyon hackathon? [18:00:26] i'm keen to go especially if you'll be there :-) [18:00:46] (03CR) 10jenkins-bot: [V: 04-1] Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [18:01:18] jdlrobson: lol that is cool XD [18:01:23] (03PS3) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 [18:01:40] jdlrobson: does the room shrink ? [18:01:42] joakino: i think it would be a fun team activity [18:01:52] joakino: nah. It basically involves tearing a room apart looking for clues [18:01:55] then working together [18:02:03] jdlrobson: while drunk? [18:02:10] joakino: it could be made that way.. ;-) [18:02:14] bar first then the room [18:02:16] like your thinking [18:02:17] haha [18:02:53] kaldari also wants to take us out on his boat [18:03:40] jdlrobson: i haven't had time to think about it, but france would be much easier as Mexico (Wikimania, where i definitly can not come :() and May sounds like a good time [18:04:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [18:04:22] gonna go give george a bath and get him to bed [18:04:30] FlorianSW: :-) :-) [18:05:08] jdlrobson: kaldari i'm in on all of it [18:06:01] joakino: :-) [18:07:24] FlorianSW: Are you in contact with the German chapter? They may be able to give you a scholarship to go to the hackathon. [18:07:49] The Dutch chapter gave me a scholarship for last year's hackathon in Amsterdam (I was still a volunteer then) [18:08:06] Deskana: no, but thanks for the tip :) [18:08:22] Deskana: hah i was just talking to kaldari about that :) [18:08:43] jdlrobson: :-D [18:08:46] I'm sure we can find away to get some of your travel expenses covered if that makes it more possible for you to come - on the basis of your contributions alone :) [18:08:57] I'd second that. [18:08:59] Deskana: i could mail qgil [18:09:15] jdlrobson: CC me so that I can offer my support. :) [18:09:20] kaldari: https://www.mediawiki.org/wiki/Lyon_Hackathon_2015 [18:09:38] Deskana, got your email, that was just what I was expecting thanks [18:09:42] Germany to France isn't really far, it wouldn't even cost that much for a flight/train ride + hostel accommodation [18:09:53] (03PS4) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 [18:10:00] Krenair: Thank you! [18:10:01] some of them I didn't really want to close myself in case you guys did actually want them [18:10:24] jdlrobson, Deskana, kaldari: :´-) [18:11:43] FlorianSW: i pm'ed qgil will keep you in the loop when i know more [18:12:24] jdlrobson: big, big, big, biggest!!!! thanks! [18:12:37] \o/ [18:13:07] hey jdlrobson, how do I "host it on a labs account/local tunnel"? [18:13:31] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/graphs/contributors [18:13:43] 146 commits! [18:19:01] (03CR) 10Kaldari: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [18:20:23] FlorianSW: I think the Lyon hackathon is being sponsored by WMFr, but I'm not sure. They usually provide scholarships for volunteers, but they haven't posted any information yet :( [18:20:49] bmansurov: which one? [18:21:00] (03PS6) 10BearND: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant) [18:21:09] (03PS4) 10BearND: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [18:21:23] (03PS3) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 [18:21:43] bmansurov: and what do you need to host? [18:21:55] kaldari: 1 sec. Let me get a link [18:22:36] kaldari: so I created a patch: https://gerrit.wikimedia.org/r/#/c/182108/ and want to show it to Jared, who doesn't have a local dev env. [18:23:54] bmansurov: the easiest thing to do is to run a local tunnel. The down side is you have to keep your local machine on that branch until they've looked at it (unless you have multiple hosts running on your machine). [18:24:13] kaldari: that's fine, how do I do it? [18:24:19] (03CR) 10jenkins-bot: [V: 04-1] Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant) [18:24:21] (03CR) 10jenkins-bot: [V: 04-1] Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [18:24:48] bmansurov: The easiest way to set up a secure local tunnel is probably by installing and running ngrok: https://ngrok.com/ [18:25:15] kaldari: thanks! [18:25:22] and happy new year ;) [18:25:34] (03CR) 10Jdlrobson: Hygiene: Use Schema class for all event logging (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [18:26:04] bmansurov: It will give you an ngrok hostname that you can share. You may have to edit your LocalSettings.php file to reflect the hostname though. [18:26:17] kaldari: ok [18:26:34] bmansurov: Specifically $wgServer = XXX [18:26:42] cool [18:29:41] joakino: ping [18:30:09] FlorianSW: pong? [18:30:52] joakino: correct :D no, with the events map, can i get the jQuery object triggered the event? Normally i can get it with $( this ), but this seems to not work? [18:31:57] FlorianSW: you can do this the traditional way, the handler receives a Event parameter (ev), so ev.target is the dom node that captured the event [18:32:25] FlorianSW: so $(ev.target) is the dom element [18:32:34] ah, yes, you're right *facepalm* [18:32:37] thanks :) [18:38:56] joakino: could we make the events map run in the context of this? [18:39:37] (03PS2) 10Jdlrobson: Hygiene: Remove unused active property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182119 [18:39:58] (03PS3) 10Jdlrobson: Hygiene: Remove unused active property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182119 [18:40:08] (03CR) 10Jdlrobson: [C: 032] "dependency was unnecessary" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182119 (owner: 10Jdlrobson) [18:40:34] jdlrobson: if by this you mean the view, that's what is happening, if you mean the dom element, we can do it but then a method of the view running on something other than the views this makes no sense [18:40:56] jdlrobson: if for some cases it is annoying inline event handling is always available [18:40:56] (03PS5) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 [18:40:58] (03PS1) 10Jdlrobson: Hygiene: Introduce SchemaMobileWebUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182201 [18:41:00] this = dom element occurred on [18:41:00] (03PS1) 10Jdlrobson: Hygiene: Use Schema for wikigrok event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 [18:41:02] (03PS1) 10Jdlrobson: Hygiene: Introduce SchemaMobileWebEditing for editing EventLogging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 [18:41:04] (03PS1) 10Jdlrobson: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 [18:41:06] (03PS1) 10Jdlrobson: Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 [18:41:08] (03PS1) 10Jdlrobson: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182206 [18:41:17] joakino: mm i see. [18:41:29] (03PS2) 10Jdlrobson: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182206 [18:41:56] (03Abandoned) 10Jdlrobson: Hygiene: Fix JSDuck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182206 (owner: 10Jdlrobson) [18:42:05] (03PS2) 10Jdlrobson: Hygiene: Fix jsdoc errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182183 (owner: 10Jhernandez) [18:42:11] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix jsdoc errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182183 (owner: 10Jhernandez) [18:42:13] (03Merged) 10jenkins-bot: Hygiene: Remove unused active property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182119 (owner: 10Jdlrobson) [18:44:09] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 (owner: 10Jdlrobson) [18:44:49] (03Merged) 10jenkins-bot: Hygiene: Fix jsdoc errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182183 (owner: 10Jhernandez) [18:45:14] joakino: https://gerrit.wikimedia.org/r/#/c/182178/ am looking at this - isn't in the opposite though? since they are instances of String etc [18:45:25] jscs doc has a "strictNativeCase" value for checkTypes [18:45:31] and capitalizedNativeCase [18:45:37] (03CR) 10Kaldari: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [18:45:51] i don't care either way - any standard is better than no standard :) [18:45:56] jdlrobson: but between {} we have the type, right? [18:46:07] {Type} Name of var [18:46:33] ah true dat [18:46:44] jdlrobson: yeah i guess it doesn't matter, i just saw it different in different places and made them equal [18:46:47] anyway joakino you missed a few :) [18:47:00] jdlrobson: damn vim search [18:47:03] i'll post the jscs config value [18:47:18] jdlrobson: oki! [18:47:50] (03PS1) 10Jdlrobson: Hygiene: Enforce capitalizedNativeCase for types in jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 [18:48:26] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson) [18:48:28] (03CR) 10Jdlrobson: [C: 032] "As https://gerrit.wikimedia.org/r/#/c/182207/ shows though a few have been missed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182178 (owner: 10Jhernandez) [18:49:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Enforce capitalizedNativeCase for types in jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 (owner: 10Jdlrobson) [18:49:30] i'm going to leave for today soon [18:49:41] tomorrow nochevieja! [18:49:56] (03Merged) 10jenkins-bot: Standarize jsdoc param types [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182178 (owner: 10Jhernandez) [18:50:33] joakino: see you! have lots of grapes :D [18:52:05] (03PS6) 10Jdlrobson: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 [18:52:37] (03Abandoned) 10Jdlrobson: Hygiene: Use Schema class for all event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181020 (owner: 10Jdlrobson) [18:52:49] (03PS2) 10Jdlrobson: Hygiene: Introduce SchemaMobileWebUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182201 [18:52:55] (03PS2) 10Jdlrobson: Hygiene: Use Schema for wikigrok event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 [18:53:02] (03PS2) 10Jdlrobson: Hygiene: Introduce SchemaMobileWebEditing for editing EventLogging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 [18:56:36] (03PS4) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 [18:57:34] bb people [19:00:52] (03PS2) 10Jdlrobson: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 [19:01:36] (03CR) 10Dr0ptp4kt: [C: 032] Enable $wgAllowSiteCSSOnRestrictedPages [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182112 (owner: 10Jhobs) [19:02:13] (03Merged) 10jenkins-bot: Enable $wgAllowSiteCSSOnRestrictedPages [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182112 (owner: 10Jhobs) [19:03:02] (03PS3) 10Jdlrobson: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 [19:03:04] (03PS2) 10Jdlrobson: Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 [19:04:17] (03CR) 10Florianschmidtwelzow: Add Possibility to add categories to a page (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [19:04:43] Deskana, remind me what was said about reload and forward buttons [19:05:01] not many people would actually use them? [19:06:14] (03PS6) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [19:06:44] (03PS1) 10Dr0ptp4kt: Revert "Enable $wgAllowSiteCSSOnRestrictedPages" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182214 [19:07:55] (03CR) 10jenkins-bot: [V: 04-1] Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [19:08:00] (03PS1) 10BearND: Update pom.xml to have fixed version of MW API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182215 [19:08:51] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add Possibility to add categories to a page (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [19:10:42] router just survived having water poured over it [19:15:00] phuedy: what router model? :) [19:16:00] phuedx: ^ [19:16:10] some crappy bt thing [19:16:22] which i have a little more respect for now [19:16:30] :P [19:16:52] (03PS7) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [19:20:48] (03CR) 10Yurik: "That was a very bad idea initially :)" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182214 (owner: 10Dr0ptp4kt) [19:21:03] (03CR) 10Yurik: [C: 032] Revert "Enable $wgAllowSiteCSSOnRestrictedPages" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182214 (owner: 10Dr0ptp4kt) [19:21:32] (03Merged) 10jenkins-bot: Revert "Enable $wgAllowSiteCSSOnRestrictedPages" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182214 (owner: 10Dr0ptp4kt) [19:21:40] (03CR) 10Dr0ptp4kt: "I concur." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182214 (owner: 10Dr0ptp4kt) [19:23:29] MaxSem: how you mean this comment? :confused: https://gerrit.wikimedia.org/r/#/c/182175/1/wmf-config/mobile.php [19:25:09] first of all, what do you mean by "special wikis"? are there any ordinary wikis? if we enable editing on non-"special" wikis, this comment will becme obsolete [19:25:42] so my advice is to comment if needed the per-wiki entries in IS [19:25:52] but not in mobile.php [19:27:22] hey, if anybody's bored/looking for a 10-second task, please fix the wikigrok about page: https://trello.com/c/j80AbttF/61-0-5-fix-wikigrok-about-page-text [19:27:26] kthx :) [19:30:07] (03PS9) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [19:31:01] kaldari: "error reporting" sounds so robotic. how about "suggest an improvement" or something? [19:31:08] (03PS1) 10Florianschmidtwelzow: Hygiene: Add missing doc for Watchstar.events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182229 [19:31:29] (03CR) 10jenkins-bot: [V: 04-1] Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [19:31:38] "suggested improvement" is probably a better thing to put on the talk page, too [19:32:00] (03PS1) 10Bmansurov: Polish: make log out button on boundary square [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 [19:33:15] (03PS10) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [19:33:24] Maryana: one sec... [19:34:36] (03CR) 10jenkins-bot: [V: 04-1] Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [19:37:27] jhobs: packing up, will be back online as internet access allows. ttyl [19:38:05] (03CR) 10Jhobs: "Initial patch abandoned in favor of 182227 (I learned where configs go!)" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182214 (owner: 10Dr0ptp4kt) [19:39:27] (03PS1) 10Bmansurov: Update WikiGrok about text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182232 [19:41:02] yurikR: I submitted that mw-config patch: https://gerrit.wikimedia.org/r/#/c/182227 [19:41:14] jhobs, yep, saw it [19:41:15] thx [19:41:26] yurikR: thanks for showing me the correct way of doing it [19:42:08] (03CR) 10Florianschmidtwelzow: Error reporting interface for alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [19:43:11] yurikR: unrelated: I think now is a good time to cease all Lua development on Module:Portal (besides hotfixes) in favor of working on Module:Portal-1 and then switching to Portal-1 in the extension during our next big "release." Thoughts? [19:44:31] since we have the "&portal=" feature [19:44:59] jhobs, sorry, meeting, sec [19:45:12] yurikR: np, get to it when you have time, or don't and we can discuss at 1:30 [19:46:15] (03PS11) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [19:50:59] (03PS1) 10Jdlrobson: Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 [19:51:01] (03PS1) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [19:52:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson) [19:53:53] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [19:54:33] (03CR) 10Kaldari: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [19:56:21] (03CR) 10Florianschmidtwelzow: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [20:03:07] (03CR) 10Bmansurov: [C: 032] Hygiene: Remove unnecessary uses of getTokenWithEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182120 (owner: 10Jdlrobson) [20:03:10] (03PS2) 10Jdlrobson: Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 [20:03:12] (03PS2) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [20:03:14] (03PS1) 10Jdlrobson: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 [20:04:29] (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary uses of getTokenWithEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182120 (owner: 10Jdlrobson) [20:04:40] (03PS3) 10Jdlrobson: Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 [20:04:42] (03PS3) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [20:04:44] (03PS2) 10Jdlrobson: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 [20:06:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [20:06:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson) [20:07:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson) [20:07:13] (03CR) 10Bmansurov: [C: 032] Hygiene: Add missing doc for Watchstar.events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182229 (owner: 10Florianschmidtwelzow) [20:07:36] (03CR) 10Kaldari: Fix naming issue to restore ability to switch between editors (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 (owner: 10Jdlrobson) [20:07:48] (03CR) 10Kaldari: [C: 04-1] Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 (owner: 10Jdlrobson) [20:08:37] (03Merged) 10jenkins-bot: Hygiene: Add missing doc for Watchstar.events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182229 (owner: 10Florianschmidtwelzow) [20:11:12] (03CR) 10Bmansurov: [C: 031] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [20:12:39] (03CR) 10Bmansurov: [C: 031] Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 (owner: 10Jdlrobson) [20:31:53] Deskana bear_nd|brb do you know a problem, that a search query (typed in on the software keyboard) doesn't appear in the search input? [20:32:19] i thought i still opened a ticket for that (or maybe just asked one of you) :/ [20:32:39] FlorianSW: i've noticed something like that a while ago on my 2.3 device [20:33:06] Galaxy Ace 2 so i assume it's some 2.3 version iirc [20:33:31] I've experienced these kinds of issues on 2.3 devices as well, although it was on mobile web [20:33:36] FlorianSW: What version of the app is used? [20:33:45] The issue in my case was that it wasn't selecting the field properly [20:33:59] If you tapped the field again, the keyboard worked [20:34:25] bear_nd: 03.11.14 (2.0), here the ticket: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7942371#9417633 (german) [20:35:08] ah, i have a 2.3 device h ere, too, i think... somewhere... [20:37:40] "it's not enough space to install Wikipedia" *grr* [20:41:10] FlorianSW: I've fired up my 2.3 device, but have a hard time reproducing it (same version) [20:41:52] bear_nd: i'm trying it on my device too, atm [20:44:56] bear_nd: hmm, can't reproduce :/ [20:45:15] bear_nd: maybe only on some pages? [20:46:55] FlorianSW: i doubt that [20:47:30] jhobs, deployed CSS thing [20:47:55] yurikR: sweet, thanks [20:48:16] bear_nd: ok, i answer him, that we can't reproduce it easily and ask for his android version (maybe he use a custom ROM) and if he observed this problem on all pages or only on special ones. [20:48:22] thanks bear_nd [20:51:09] jhobs, re switch - whichever is more comfortable for you. I would do minor changes in the current, unless the change is "complex", in which case use a new module [20:53:20] yurikR: yeah but I think developing only on the new module now would make it easier for us to kind of logically separate our "major releases" instead of having one gigantic version history [20:53:56] jhobs, up to you [20:54:21] jhobs, i believe in minor dev iterations, instead of "major releases" [21:28:55] jhobs, don't forget to change the image, its too large. I will connect in about 10 min [21:29:12] yurikR: yeah I just added a phab task for that recently [21:29:53] jhobs, just copy/paste the URL to a smaller file, takes a sec :) [21:29:59] commons will help you [21:30:17] yurikR: there is no smaller file atm, I have to make one, unless there's some dynamic way of doing that already [21:30:56] jhobs, you can link to a resized version (thumb) [21:31:14] jhobs, need to switch location to connect to the meeting [21:43:23] (03PS4) 10Jdlrobson: Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 [21:43:25] (03PS4) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [21:43:27] (03PS3) 10Jdlrobson: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 [21:43:29] (03PS1) 10Jdlrobson: Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 [21:43:31] (03PS1) 10Jdlrobson: Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [21:43:33] (03PS1) 10Jdlrobson: Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 [21:49:49] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [22:07:29] (03PS2) 10Jdlrobson: Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 [22:07:31] (03PS1) 10Jdlrobson: Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 [22:08:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [22:10:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson) [22:11:33] (03CR) 10Jdlrobson: Fix notification overlay back behaviour (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [22:12:45] (03PS2) 10Jdlrobson: Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 [22:13:03] still not merged and still very serious bug that should be fixed asap (monday lightning deploy me hopes) ^ kaldari [22:13:08] (03PS1) 10Bmansurov: Fix image pinch zoom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182295 [22:13:38] jdlrobso_: will look at [22:14:46] (03CR) 10Florianschmidtwelzow: Fix notification overlay back behaviour (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [22:14:55] (03CR) 10Florianschmidtwelzow: [C: 031] Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [22:15:49] (03CR) 10jenkins-bot: [V: 04-1] Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [22:17:58] (03CR) 10Jdlrobson: [C: 04-1] Polish: make log out button on boundary square (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov) [22:19:12] (03CR) 10Jdlrobson: [C: 032] Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [22:20:31] (03CR) 10Bmansurov: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [22:21:44] (03PS3) 10Jdlrobson: Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 [22:22:03] (03Merged) 10jenkins-bot: Add jscsc rule "disallowImplicitTypeConversion" and fix existing errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [22:23:26] (03CR) 10Bmansurov: Polish: make log out button on boundary square (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov) [22:26:31] (03Abandoned) 10Deskana: [WIP] Floating action button for saving pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/178147 (owner: 10Deskana) [22:32:40] (03CR) 10Kaldari: [C: 032] Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 (owner: 10Jdlrobson) [22:34:30] (03Merged) 10jenkins-bot: Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182113 (owner: 10Jdlrobson) [22:38:16] (03CR) 10Jdlrobson: [C: 04-1] Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [22:38:49] (03PS3) 10Jdlrobson: Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 [22:43:41] (03CR) 10Kaldari: [C: 04-1] Fix notification overlay back behaviour (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [22:50:03] (03CR) 10Kaldari: [C: 04-1] Change navigation easing function (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov) [22:52:21] (03PS4) 10Bmansurov: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 [22:52:58] (03PS5) 10Bmansurov: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 [23:03:14] Deskana, around? [23:04:45] (03CR) 10Kaldari: [C: 031] "Fixes it on iOS, still need to test on Android." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182295 (owner: 10Bmansurov) [23:06:11] (03PS4) 10Jdlrobson: Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 [23:08:08] Krenair: Yep! What's up? [23:08:24] android app query about reload and forward buttons [23:08:29] I think that was asked about before [23:08:42] don't remember what the response was though [23:09:32] Krenair: What's the context? Can you show me the ticket? [23:09:50] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7708915 [23:10:55] the first thing, page text search is in the beta. when is that coming to stable? [23:11:30] Krenair: Hopefully mid-Jan. Pull to refresh is also in beta and should be coming mid Jan. [23:11:49] forward button? [23:13:17] No plans right now. [23:13:33] It's not trivial because although Android has a built-in back button, there is no built-in forward button. [23:13:42] And we use left and right swipe for menus [23:15:37] 3MobileFrontend-stable, Mobile-Web: Text does not appear in the place of icons when images are disabled - https://phabricator.wikimedia.org/T69726#949886 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Closing then. Please open a new clear bug if there is anything left to do. [23:16:57] (03CR) 10Bmansurov: [C: 04-1] Error reporting interface for alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [23:22:34] (03CR) 10Bmansurov: Fix notification overlay back behaviour (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [23:26:00] (03CR) 10Bmansurov: Hygiene: Introduce Skin.js (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson) [23:27:28] (03CR) 10Kaldari: Fix notification overlay back behaviour (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [23:32:21] kaldari: are you messing around w/wikigrok on beta labs? it's not working anymore :-/ [23:32:35] :( [23:33:08] (03CR) 10Bmansurov: Hygiene: Move isTestA to Schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [23:33:26] bmansurov: nope because it is static [23:33:32] like getSessionId [23:35:04] Maryana: hmm, it's definitely broken [23:40:03] (03CR) 10Jdlrobson: Hygiene: Move isTestA to Schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [23:42:50] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [23:42:57] (03CR) 10Bmansurov: [C: 031] Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [23:43:37] (03CR) 10Jdlrobson: [C: 04-1] "test issues WikiGrokDialogB and MobileFrontend photo - global failure" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson) [23:48:46] (03CR) 10Kaldari: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [23:50:12] (03CR) 10Bmansurov: Error reporting interface for alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari)