[00:13:22] 3MobileFrontend-Feature-requests: Add mobile editing support to Windows phone (IE9) - https://phabricator.wikimedia.org/T57599#949999 (10Jdlrobson) Shall we WONTFIX this based on users then? @jhernandez @maxsem [00:14:24] 3MobileFrontend-Feature-requests: Add mobile editing support to Windows phone (IE9) - https://phabricator.wikimedia.org/T57599#950001 (10MaxSem) @MPinchuk? [00:14:53] 3MobileFrontend-Feature-requests: Add mobile editing support to Windows phone (IE9) - https://phabricator.wikimedia.org/T57599#950002 (10MaxSem) Eh, @Maryana [00:15:22] jdlrobson: any thoughts on bmansurov's comment at https://gerrit.wikimedia.org/r/#/c/182128/4/javascripts/OverlayManager.js? I'm fine merging it as is. [00:16:58] (03PS12) 10Kaldari: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 [00:18:45] (03CR) 10Jdlrobson: Fix notification overlay back behaviour (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [00:19:01] (03CR) 10Kaldari: [C: 04-1] "Just waiting on +1 from Jared now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov) [00:20:13] (03CR) 10Kaldari: [C: 032] Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [00:21:36] (03Merged) 10jenkins-bot: Fix notification overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182128 (owner: 10Jdlrobson) [00:35:39] (03CR) 10Kaldari: [C: 032] Fix image pinch zoom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182295 (owner: 10Bmansurov) [00:40:16] (03Merged) 10jenkins-bot: Fix image pinch zoom [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182295 (owner: 10Bmansurov) [00:41:04] (03CR) 10Kaldari: [C: 032] Update WikiGrok about text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182232 (owner: 10Bmansurov) [00:42:43] (03Merged) 10jenkins-bot: Update WikiGrok about text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182232 (owner: 10Bmansurov) [00:47:46] (03CR) 10Bmansurov: [C: 031] Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [00:58:22] Deskana, someone had problems with search on beta - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8044569 [00:58:33] not particularly helpful [01:01:25] (03CR) 10Bmansurov: [C: 032] Login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182116 (owner: 10Jdlrobson) [01:03:16] (03Merged) 10jenkins-bot: Login form tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182116 (owner: 10Jdlrobson) [01:03:23] (03CR) 10Kaldari: [C: 04-1] "NPM wants you to go ahead and fix the bad cases." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 (owner: 10Jdlrobson) [01:05:10] jdlrobson, MaxSem: I can't feel my fingers or toes anymore. I have to go home before I get frostbite. [01:05:14] (03CR) 10Jdlrobson: "yup this was mostly for joaquin" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 (owner: 10Jdlrobson) [01:34:16] (03PS1) 10Jdlrobson: WIP: Refactor Nearby as an Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 [01:35:10] Krenair: We did refactor how search works a little, but what he is saying is kind of useless. [01:35:29] Krenair: I wish he gave an example. [01:35:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor Nearby as an Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson) [01:37:40] ok [01:49:31] Deskana, reply on https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7708915 [01:50:13] Krenair: I'm not sure where my Android device is right now. I'll take a look later. [01:50:23] ok [01:51:19] (03PS1) 10Jdlrobson: Enable user profile on desktop. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 [01:51:26] (03CR) 10jenkins-bot: [V: 04-1] Enable user profile on desktop. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 (owner: 10Jdlrobson) [01:52:33] (03PS2) 10Jdlrobson: Enable user profile on desktop. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 [03:31:52] (03CR) 10MZMcBride: "I completely agree with the idea that "Special pages that only work on mobile are bad," and like MatmaRex, I'm really glad to see mobile a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 (owner: 10Jdlrobson) [04:13:43] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [06:34:54] 3MobileFrontend-Feature-requests: Emulate mobile view on desktop preview page - https://phabricator.wikimedia.org/T85587#950339 (10tstarling) 3NEW [06:55:06] 3MobileFrontend-Feature-requests: Emulate mobile view on desktop preview page - https://phabricator.wikimedia.org/T85587#950346 (10MZMcBride) I think https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/078995.html is related. I gave this some thought in October and I came to the conclusion that we mig... [06:56:24] 3MobileFrontend-Feature-requests: Emulate mobile view on desktop preview page - https://phabricator.wikimedia.org/T85587#950348 (10MZMcBride) [08:12:24] morning! [10:05:01] morning all [10:05:08] * phuedx is just brewing a cup of coffee [10:08:37] hi phuedx [10:08:45] hey joakino [10:09:14] phuedx i've sent an email to mobile-l and tech, when you can, is it understandable? [10:11:15] I mean, can you check if it is clear? (me cannot english 😩) [10:13:18] bbiab [10:21:02] joakino: sure, i'm reading it now [10:21:11] do you want a formal code review? ;) [10:29:50] joakino: nice writin' [10:30:04] since it's written in markdown, you could totally add it to the repository as is :) [10:30:11] (and it'd display nicely on github) [10:38:23] phuedx: i put it in a gist https://gist.github.com/joakin/470d8655977a9bbc97c2 [11:17:04] phuedx: is there a way to get @ mentions completion on phabricator? [11:17:12] joakino: there will be [11:17:15] 3MobileFrontend-Feature-requests: Add mobile editing support to Windows phone (IE9) - https://phabricator.wikimedia.org/T57599#950515 (10Jhernandez) From what I have from the October/November stats: ``` Browser by major version: IE Mobile 10 → 0.97% IE Mobile 11 → 0.62%... [11:17:19] but not right now [11:27:37] (03CR) 10Jhernandez: [C: 04-1] Hygiene: Introduce Schema class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [11:40:19] (03PS7) 10Jhernandez: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [11:41:14] (03CR) 10Jhernandez: "I've corrected the initialize and added tests." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [11:43:05] (03PS3) 10Jhernandez: Hygiene: Introduce SchemaMobileWebUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182201 (owner: 10Jdlrobson) [11:44:55] (03PS3) 10Jhernandez: Hygiene: Use Schema for wikigrok event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 (owner: 10Jdlrobson) [11:45:32] (03PS3) 10Jhernandez: Hygiene: Introduce SchemaMobileWebEditing for editing EventLogging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 (owner: 10Jdlrobson) [11:45:52] (03PS4) 10Jhernandez: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson) [11:46:28] (03CR) 10Jhernandez: [C: 031] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [11:47:08] (03CR) 10Jhernandez: [C: 032] Hygiene: Introduce SchemaMobileWebUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182201 (owner: 10Jdlrobson) [11:57:22] (03CR) 10Jhernandez: [C: 04-1] "pageId seems to have disappeared and I'm getting a warning in the console. Look at the comments" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 (owner: 10Jdlrobson) [12:02:18] (03CR) 10Jhernandez: [C: 031] "Looks good, but I've noticed something missing from the old schema to the new. Comments" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 (owner: 10Jdlrobson) [12:17:06] (03CR) 10Jhernandez: "I think we are not actually logging past events? See comments." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson) [12:17:31] (03CR) 10Jhernandez: [C: 04-1] "Forgot to -1 so you see it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson) [12:21:19] (03CR) 10Jhernandez: "I agree on the null thing bmansurov." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182127 (owner: 10Bmansurov) [13:14:20] (03PS2) 10Phuedx: Run 'this page has issues' on category pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 (owner: 10Jdlrobson) [13:14:47] back from lunchy lunch [13:43:28] (03CR) 10Phuedx: [C: 04-1] "The mobile-frontend-meta-data-issues-categories message isn't registered with the mobile.issues module." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 (owner: 10Jdlrobson) [13:44:34] (03PS3) 10Phuedx: Run 'this page has issues' on category pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 (owner: 10Jdlrobson) [13:50:50] (03CR) 10Phuedx: [C: 032] Run 'this page has issues' on category pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 (owner: 10Jdlrobson) [13:52:10] (03Merged) 10jenkins-bot: Run 'this page has issues' on category pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182124 (owner: 10Jdlrobson) [14:13:18] hello all :) (all is good, i'm seeing only phuedx) [14:13:24] hey FlorianSW [14:13:29] i'm good thanks [14:13:32] how're you? [14:13:41] i think joakino's out to lunch [14:14:52] phuedx: i'm fine :) Last day of the year :Ü [14:14:54] *:P [14:15:07] inorite [15:11:53] (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [15:13:37] 3Wikipedia-App-Android-App: Split Chinese into Traditional/Simplified in menus? - https://phabricator.wikimedia.org/T85615#950763 (10Krenair) 3NEW [15:14:23] (03PS17) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [15:40:36] (03CR) 10Phuedx: [C: 031] Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [15:40:53] (03CR) 10Phuedx: "Code looks good and I've kicked the tyres." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [16:21:17] bear_nd: you know the search bar problem yesterday? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7942371&OTRSAgentInterface=10eb7022469a2bd219d226d6b83f9ed44a the beta app works :) [16:21:42] FlorianSW: have you been able to repro it on a device? [16:21:57] bear_nd: no [16:22:00] unhappily [16:23:59] FlorianSW: i just hope Jan 15 comes soon ;) [16:24:35] bear_nd: :P [16:28:00] 3Wikipedia-App-Android-App: Split Chinese into Traditional/Simplified in menus? - https://phabricator.wikimedia.org/T85615#950911 (10bearND) Any OTRS links? [16:33:04] 3Wikipedia-App-Android-App: Split Chinese into Traditional/Simplified in menus? - https://phabricator.wikimedia.org/T85615#950926 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8033492 [16:40:23] (03CR) 10Phuedx: [C: 032] Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [16:42:21] (03Merged) 10jenkins-bot: Hygiene: Introduce Schema class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [16:42:27] (03Merged) 10jenkins-bot: Hygiene: Introduce SchemaMobileWebUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182201 (owner: 10Jdlrobson) [16:53:23] (03CR) 10Phuedx: "Ping… anyone!?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174828 (owner: 10Jforrester) [16:53:49] (03Abandoned) 10Phuedx: Make getWikiGrokVersion promise-based [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177773 (owner: 10Phuedx) [16:53:54] (03Abandoned) 10Phuedx: Add and register the WikiGrokExperiment experiment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177775 (owner: 10Phuedx) [16:54:02] (03Abandoned) 10Phuedx: Retire WikiGrokAbTest in favour of PlanOut [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/177774 (owner: 10Phuedx) [17:01:58] (03PS2) 10Dr0ptp4kt: Enhance unsupported HTTPS options [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/181194 [17:14:59] (03PS16) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [17:15:45] (03Abandoned) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [17:17:03] Deskana: bummer [17:43:47] (03PS4) 10Phuedx: Hygiene: Use Schema for wikigrok event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 (owner: 10Jdlrobson) [17:44:40] helllooo [17:44:44] (03CR) 10Phuedx: "PS4 restores the pageId parameter. The events are now valid." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 (owner: 10Jdlrobson) [17:49:44] hullo [17:53:34] (03PS5) 10Jdlrobson: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 [17:53:48] phuedx: how are you celebrating the new day? [17:54:26] we're seeing family [17:54:47] and sleeping! [17:54:49] woo! [17:55:46] (03CR) 10Jdlrobson: [C: 04-1] Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [17:56:01] phuedx: \o/ [17:56:38] jdlrobson: and you? [17:56:46] also, is the office closed on friday? [17:57:02] phuedx: yup [17:57:05] long weekend [17:57:10] phuedx: i'm not really sure yet [17:57:16] probably going to go on a road trip tomorrow to find sun [17:57:24] i hear it is somewhere down in south california [17:58:39] I heard it's snowing down there. [18:03:52] bear_nd: Do you want to do the standup or shall we just cancel it? [18:08:25] Deskana: anyone else around? [18:08:40] The heating in the office is broken so I'm at home. [18:08:46] I don't seen Brion or Adam on IRC. [18:08:53] Monte and Dmitry are still both off. [18:11:25] Deskana: Adam said he's on his way but may be late. Eiter way is fine with me. I can tell you what I've been working on on IRC. Made some good progress on https://trello.com/c/3WxaCmLy/1-3-tweet-a-fact-generate-an-image-based-around-a-quote-and-the-lead-image. [18:11:48] Deskana: going to push a WIP patch later today [18:11:55] Sweet! [18:13:03] Deskana: there's just issues with details, like what happens when the text is too long (ellipsizing while drawing a text on a canvas is a pain). [18:13:31] Can you do something like check the length of the string before you draw it? [18:13:47] If it's longer than 140, cut it off then draw it afterwards? [18:13:58] Deskana: sure, we could add a fixed length limit. That would be easy [18:14:33] Alright, I'll join the hangout. [18:14:39] It won't take long anyway. :) [18:15:21] (03PS13) 10Jdlrobson: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [18:15:23] (03PS1) 10Jdlrobson: Hygiene: Nit picks to ErrorReportOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182370 [18:15:34] (03CR) 10Jdlrobson: [C: 032] Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [18:15:56] (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow) [18:16:30] (03PS18) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 [18:18:03] (03Merged) 10jenkins-bot: Error reporting interface for alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182082 (owner: 10Kaldari) [18:18:26] gonna get george to bed [18:18:47] Deskana: sorry, just went downstairs to grab something [18:18:59] bear_nd: We finished. :P [18:19:11] ok [18:19:19] bear_nd: I can rejoin if you want to chat about something [18:19:34] Deskana: no, that's fine [18:21:21] (03Abandoned) 10Jdlrobson: Upstream icons to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174866 (owner: 10Robmoen) [18:22:31] Deskana: are we going to have the design meeting this PM? [18:23:20] Deskana: I assume the iteration review tomorrow is cancelled [18:23:32] (03CR) 10Jdlrobson: [C: 04-1] "postRender only runs once when the editor is first created (since render is never called again) thus I don't think this is a huge memory l" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 (owner: 10Robmoen) [18:23:44] bear_nd: Both are cancelled. [18:23:52] * Deskana checks that they're actually cancelled [18:24:08] Hmm, strange. [18:24:15] They're not on my calendar but they are on yours. [18:24:53] Deskana: i can fix that by removing them from mine :P [18:24:58] That works. [18:25:04] I'll send out an email to make sure everyone knows. [18:25:49] getting a bunch of Diffusion spam in my inbox right now [18:26:17] Me too [18:26:49] it's like it's replaying every commit I've made, still a hundred to go [18:31:11] (03Abandoned) 10Jdlrobson: Provide VisualEditor regardless of device size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174828 (owner: 10Jforrester) [18:36:20] (03PS2) 10Jdlrobson: Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 [18:36:52] (03CR) 10Jdlrobson: Hygiene: prep work for collections work (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [18:37:00] (03CR) 10Jdlrobson: [C: 04-1] "@phuedx could you give me a hand?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [18:39:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [18:40:57] tfinc: just saw snowflakes in vegas :) [18:41:17] mhurd: oh yeah, hows the temp ? [18:42:33] (03CR) 10Kaldari: [C: 031] Hygiene: Nit picks to ErrorReportOverlay (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182370 (owner: 10Jdlrobson) [18:44:50] tfinc: 30’s! decided today would be a nice rest/laundry day. i’m holed up in a coffee shop until 4 - going to do some refactoring while i over-caffeinate [18:45:15] (03CR) 10Kaldari: [C: 032] Hygiene: Nit picks to ErrorReportOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182370 (owner: 10Jdlrobson) [18:47:16] (03Merged) 10jenkins-bot: Hygiene: Nit picks to ErrorReportOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182370 (owner: 10Jdlrobson) [19:00:24] jdlrobson: what's up? [19:00:32] by that i mean, what can i help you with? [19:04:38] phuedx: i just don't like PHP :) [19:04:48] hah [19:04:51] phuedx: wondered if you wanted to get that patch into a mergeable state [19:04:58] https://gerrit.wikimedia.org/r/181428 < also bmansurov fancy clearing this one up? [19:04:59] sure, i'll pick it up [19:05:18] mhurd: nice, stay warm and enjoy your time away [19:05:38] tfinc: will do! [19:05:48] jdlrobson: sure [19:05:49] have climbed every day except today [19:06:18] phuedx: did you see my nearby as an overlay patch ? [19:06:35] i'm excited about that :-) [19:06:39] jdlrobson: i think so [19:06:41] did i? [19:06:41] been bugging me for ages [19:06:52] https://gerrit.wikimedia.org/r/182334 [19:06:54] yes i did [19:06:57] :) [19:06:57] basically i want to kill Special:Nearby [19:09:19] oh no [19:13:27] bmansurov: oh no? [19:14:45] ;) oh no "kill" [19:45:53] (03CR) 10Kaldari: Hygiene: Introduce Schema class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182147 (owner: 10Jdlrobson) [19:46:27] jdlrobson: https://gerrit.wikimedia.org/r/#/c/182147/7/javascripts/Schema.js [19:49:38] (03PS3) 10Phuedx: Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [19:49:46] jdlrobson: ^ that should do it [19:51:25] and by that i mean, it works, and it's what i suggested [19:57:54] (03CR) 10Kaldari: Hygiene: Make inNamespace a method of Page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [19:58:04] phuedx: :D [19:58:27] phuedx: can we extend it to have a concept of private though? [19:58:39] i'm mostly doing this to provide a basis to work from for the Collection stuff [19:59:06] i understand that, i'd suggest changing the name of the collection to PrivateMobilePageCollection [19:59:10] that it's there by name [19:59:17] ah like it [19:59:21] because there's nothing to implement [19:59:24] yet [19:59:28] win! [19:59:37] phuedx: ok i'm happy with the patch [19:59:41] in current form [19:59:46] (03CR) 10Jdlrobson: [C: 031] Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson) [20:02:32] (03PS3) 10Dr0ptp4kt: Enhance unsupported HTTPS options [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/181194 [20:08:26] (03CR) 10MaxSem: Hygiene: Use Config object for global configuration vars (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow) [20:10:35] jdlrobson: i've made large enough changes to that patch that i'm not willing to merge it [20:10:40] ping others? [20:11:19] (03CR) 10Kaldari: [C: 04-1] Hygiene: Introduce Skin.js (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson) [20:15:14] (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object for global configuration vars (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow) [20:15:50] (03CR) 10Kaldari: [C: 032] Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [20:16:06] phuedx: okay :) [20:20:59] MaxSem: for what was this line introduced? https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/phpunit/MobileContextTest.php#L25 [20:21:11] it prevents of using singleton inside MobileContext class [20:21:26] (for change: https://gerrit.wikimedia.org/r/#/c/181683/5/includes/MobileContext.php) [20:25:51] FlorianSW, http://git.wikimedia.org/commit/mediawiki%2Fextensions%2FMobileFrontend.git/d38b4ba341f07b05ede636444770caae4edf2fdd [20:26:46] can just make this function non-static to avoid a global state leak [20:28:21] let me check [20:30:00] (03PS6) 10Florianschmidtwelzow: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [20:30:01] MaxSem: yap ^ [20:31:05] grmbl [20:31:29] ? [20:31:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow) [20:31:45] (03PS2) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 [20:31:57] (03PS5) 10Jdlrobson: Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 [20:32:18] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [20:32:38] grr [20:32:48] heading off [20:32:51] g'night folks [20:32:52] my main worry is that any change that can alter the precise moment of context creation can break the shit in random places simply because mf is messing too much with too many things in mw [20:33:38] see y'all in the new year [20:34:24] (03CR) 10jenkins-bot: [V: 04-1] Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson) [20:35:24] (03Merged) 10jenkins-bot: Hygiene: Make inNamespace a method of Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182237 (owner: 10Jdlrobson) [20:39:16] (03PS3) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 [20:39:26] see ya phuedx [20:40:51] (03CR) 10jenkins-bot: [V: 04-1] Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson) [20:42:34] (03CR) 10Jdlrobson: Hygiene: Introduce Skin.js (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson) [20:42:41] (03PS2) 10Jdlrobson: Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 [20:42:47] (03PS2) 10Jdlrobson: Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [20:42:49] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson) [20:42:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [20:44:51] (03PS5) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [20:45:02] (03PS4) 10Jdlrobson: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 [20:45:07] (03PS3) 10Jdlrobson: Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 [20:45:56] (03CR) 10Kaldari: "This change breaks all the Watchstar qunit tests for me. Not sure why it still passes on Jenkins." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [20:46:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson) [20:46:26] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson) [20:47:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson) [20:47:50] (03PS3) 10Jdlrobson: Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 [20:49:27] (03PS6) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [20:49:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson) [20:50:04] (03PS5) 10Jdlrobson: Hygiene: Use Schema for wikigrok event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 [20:50:11] (03PS4) 10Jdlrobson: Hygiene: Introduce SchemaMobileWebEditing for editing EventLogging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 [20:50:17] (03PS6) 10Jdlrobson: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 [20:50:23] (03PS4) 10Jdlrobson: Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 [20:51:06] (03CR) 10Kaldari: "Nevermind, I had to update Mantle." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180835 (owner: 10Jhernandez) [20:51:20] (03PS7) 10Jdlrobson: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 [20:51:33] (03PS5) 10Jdlrobson: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 [20:51:39] (03PS4) 10Jdlrobson: Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 [20:51:45] (03PS3) 10Jdlrobson: Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [20:51:53] (03PS3) 10Jdlrobson: Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 [20:57:05] (03PS4) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 [20:58:29] (03CR) 10Jdlrobson: Polish: make log out button on boundary square (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov) [21:44:42] jdlrobson: and make sure $wgImageMagickConvertCommand matches the output of which convert [21:51:59] (03PS2) 10Jdlrobson: Hygiene: Enforce capitalizedNativeCase for types in jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 [21:55:20] kaldari: can you update https://phabricator.wikimedia.org/T74796 ? [21:56:01] 3MobileFrontend-beta, Mobile-Web: Wikgrok A and B trigger API request on every page load - https://phabricator.wikimedia.org/T74796#951349 (10kaldari) 5Open>3Resolved a:3kaldari This is no longer an issue. [22:01:03] 3Mobile-Web, MobileFrontend-stable: Remove display:block from CtaDrawer - https://phabricator.wikimedia.org/T78586#951354 (10Jdlrobson) Florian, since the issue is with the entire area being clickable just wrap the link in div's and let's remove the display: block; Keep the buttons positioned center and on singl... [22:04:02] (03PS1) 10Jdlrobson: Remove outline on overlay buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182382 [22:14:34] bear_nd: hey! [22:15:03] mhurd: hola! [22:15:46] bear_nd: hey could i pester you to attach a screenshot of what the android app looks like when the lead image is the placeholder globe? to this card: https://trello.com/c/Fmcftrli/96-lead-image [22:16:24] mhurd: sure. np. do you remember a good page for that? [22:17:00] bear_nd: oh any one if you can just set a breakpoint [22:17:13] mhurd: good idea [22:17:17] before the retreived image replaces the placeholder [22:18:12] context - i grabbed the image from the android repo, but i’m doing positioning and gradients slightly differently, so seeing it in context would be great [22:19:04] MaxSem: Do you mean my change? [22:19:09] or generaly? [22:19:52] your change has this potential, too. guess we should just merge it and see if something breaks on labs [22:22:42] mhurd: I've uploaded one. Is this what you were looking for? [22:22:53] MaxSem: hmm, i can't really follow :/ i don't see such a problem in the change? [22:23:06] mhurd: is dark mode ok? [22:23:30] bear_nd: oops i do need the day mode - no dark mode on ios yet :) [22:24:07] (03PS6) 10Florianschmidtwelzow: Hygiene: Remove anchor links from ctaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 [22:24:14] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove anchor links from ctaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 (owner: 10Florianschmidtwelzow) [22:26:18] mhurd: ok, replace it with a day mode one [22:26:25] (03PS7) 10Florianschmidtwelzow: Hygiene: Remove anchor links from ctaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173283 [22:26:35] bear_nd: thanks so much!!! [22:26:47] np [22:42:09] (03PS7) 10Florianschmidtwelzow: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [22:43:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow) [22:56:43] (03PS8) 10Florianschmidtwelzow: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [22:59:26] (03PS1) 10Dr0ptp4kt: Update documentation and shell perms for tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182384 [23:01:05] (03PS1) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 [23:01:46] (03CR) 10Jhobs: [C: 031] Update documentation and shell perms for tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182384 (owner: 10Dr0ptp4kt) [23:02:44] (03CR) 10Dr0ptp4kt: [C: 032] Update documentation and shell perms for tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182384 (owner: 10Dr0ptp4kt) [23:03:34] (03Merged) 10jenkins-bot: Update documentation and shell perms for tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/182384 (owner: 10Dr0ptp4kt) [23:31:59] (03PS9) 10Florianschmidtwelzow: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 [23:46:37] (03CR) 10Legoktm: [C: 031] Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow) [23:51:01] (03PS1) 10Jdlrobson: WIP: Allow browsing of images on mobile. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182390 [23:51:58] 3MobileFrontend-Feature-requests: Should be possible to navigate between images on page - https://phabricator.wikimedia.org/T85643#951488 (10Jdlrobson) 3NEW [23:55:01] 3MobileFrontend-beta, MobileFrontend-Feature-requests: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#951503 (10Jdlrobson) @Florian feel free to grab this one.. [23:56:17] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#948112 (10Jdlrobson) [23:56:19] 3MobileFrontend-Feature-requests: Setup infinite scroll on Watchlist - https://phabricator.wikimedia.org/T74650#951510 (10Jdlrobson) [23:59:45] 3MobileFrontend-beta, MobileFrontend-Feature-requests: Can't easily add new section to user talk page - https://phabricator.wikimedia.org/T72614#951520 (10Florian) a:5Jdlrobson>3Florian I'll take a look on it :)