[01:37:30] <cafed00d>	 im trying to run the wikipedia ios app in xcode and I'm running into the following error: Command /bin/sh failed with exit code 99
[01:37:52] <cafed00d>	 I've installed all the deps.. grunt cli and inkscape
[01:37:59] <cafed00d>	 can somebidy help me resolve this
[01:39:16] <Krenair>	 I think mhurd or brion would be able to help with the iOS app, but they're not around at the moment
[01:46:57] <cafed00d>	 oh ok.. i'll try again later then.. thanks!
[08:54:13] <joakino>	 morning!
[09:20:44] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "Seems to work fine" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 (owner: 10Jdlrobson)
[09:22:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Use Schema for wikigrok event logging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182202 (owner: 10Jdlrobson)
[09:27:37] <grrrit-wm>	 (03CR) 10Jhernandez: "Looks good, but why has mobileMode: M.getMode() disappeared? Is it not important any more?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 (owner: 10Jdlrobson)
[09:29:58] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] "Looks good, but why has `mobileMode: M.getMode()` disappeared? ( https://gerrit.wikimedia.org/r/#/c/182204/4/javascripts/loggingSchemas/Mo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson)
[10:03:46] <phuedx>	 yo
[10:06:44] <joakino>	 hi phuedx
[10:06:54] <phuedx>	 hey joakino 
[10:07:33] <joakino>	 phuedx: how is everything?
[10:07:45] * joakino misses holidays
[10:10:08] <phuedx>	 my things are good
[10:10:28] <phuedx>	 most of my family have had a pretty nasty cold
[10:10:40] <phuedx>	 :/
[10:10:43] <phuedx>	 how're you?
[10:12:53] <joakino>	 phuedx: i've caught one a couple of days ago, still pretty bad
[10:13:10] <joakino>	 recovering :)
[10:25:14] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson)
[10:30:32] <grrrit-wm>	 (03CR) 10Phuedx: "The mobileMode parameter is a default that is initialised in the Schema class (see http://git.wikimedia.org/blob/mediawiki%2Fextensions%2F" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson)
[10:30:44] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 (owner: 10Jdlrobson)
[10:30:50] <grrrit-wm>	 (03CR) 10Phuedx: "The mobileMode parameter is a default that is initialised in the Schema class (see http://git.wikimedia.org/blob/mediawiki%2Fextensions%2F" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 (owner: 10Jdlrobson)
[10:30:57] <phuedx>	 joakino: ^
[10:31:49] <joakino>	 phuedx: oh Jebus i missed that
[10:31:55] <joakino>	 thanks!
[10:32:14] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "I missed that, thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 (owner: 10Jdlrobson)
[10:33:27] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] "I missed that, thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson)
[10:33:44] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "The message isn't particularly friendly (what's a form field?)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[10:33:52] <grrrit-wm>	 (03CR) 10Phuedx: Hygiene: Give a better error message in TalkAddOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[10:34:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Introduce SchemaMobileWebEditing for editing EventLogging [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182203 (owner: 10Jdlrobson)
[10:34:27] <grrrit-wm>	 (03CR) 10Phuedx: "Didn't mean to -1, though I'd still like to discuss the wording." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[10:35:59] <grrrit-wm>	 (03CR) 10Phuedx: "Is this used anywhere? I don't see any dependencies." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182395 (owner: 10Florianschmidtwelzow)
[10:38:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Introduce MobileWebClickTracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson)
[10:48:08] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 032] ":D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 (owner: 10Jdlrobson)
[10:48:40] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "+1 for a better wording :) If there are suggestions, please comment, i'm not sure, what the best message would be :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[10:49:48] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Remove outline on overlay buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182382 (owner: 10Jdlrobson)
[10:50:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Enforce capitalizedNativeCase for types in jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182207 (owner: 10Jdlrobson)
[10:51:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove outline on overlay buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182382 (owner: 10Jdlrobson)
[10:54:43] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "it's used everytime you use M.getCurrentPage().inNamespace(). Actually it will use the default value of namespaceNumber (0), which probabl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182395 (owner: 10Florianschmidtwelzow)
[10:57:15] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] "Yowza! Nice catch!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182395 (owner: 10Florianschmidtwelzow)
[10:59:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Add namespaceNumber for getCurrentPage() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182395 (owner: 10Florianschmidtwelzow)
[11:00:21] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] "Looks good. In fact in alpha the logout icon is too small: http://i.imgur.com/czorxF2.png (beta left, alpha right)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov)
[11:00:51] <phuedx>	 ugh
[11:00:58] <phuedx>	 that set of schema commits is huge
[11:01:28] <joakino>	 phuedx: yeap
[11:01:41] <joakino>	 phuedx: btw was it you who split them into smaller pieces?
[11:01:47] <phuedx>	 no
[11:01:59] <phuedx>	 i asked jon to do so
[11:02:17] <joakino>	 oh I thought I read somewhere Jon congratulating you on the splitting
[11:02:22] <phuedx>	 oh
[11:02:25] <phuedx>	 well it wasn't me!
[11:02:48] <joakino>	 i would have loved to see how he handled that, to see if it is as I would do it or there are better ways
[11:03:23] <phuedx>	 https://gerrit.wikimedia.org/r/#/c/182205/4 doesn't seem to be merged yet :/
[11:03:46] <phuedx>	 it feels like there are a lot more commits in the chain than the original change needed :/
[11:04:45] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 (owner: 10Jdlrobson)
[11:04:53] <joakino>	 phuedx: yeah jenkins...
[11:05:15] <joakino>	 phuedx: they are mostly small, except the mobilewebclicktracking
[11:05:15] <grrrit-wm>	 (03CR) 10Phuedx: "Ping @jenkins-bot!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 (owner: 10Jdlrobson)
[11:05:36] <joakino>	 phuedx: but yeah it was a pain to review properly, i was a couple of hours (if not more) with that the 31st
[11:07:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove log method from mw.mobileFrontend object [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182205 (owner: 10Jdlrobson)
[11:19:19] <grrrit-wm>	 (03PS8) 10Jhernandez: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[11:20:12] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] "Fixed escapeHash (also loads from util)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[11:20:35] <grrrit-wm>	 (03PS6) 10Jhernandez: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson)
[11:21:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson)
[11:22:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[11:22:59] <grrrit-wm>	 (03PS5) 10Esanders: Remove border-box rule from reset.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 
[11:28:00] <grrrit-wm>	 (03CR) 10Jhernandez: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[11:31:18] <grrrit-wm>	 (03PS9) 10Jhernandez: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[11:48:13] <grrrit-wm>	 (03CR) 10Jhernandez: [C: 031] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[11:48:36] <grrrit-wm>	 (03PS7) 10Jhernandez: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson)
[11:53:24] <joakino>	 i'm out for trip/lunch, i'll connect in a few hours
[12:11:44] <wikibugs>	 3MobileFrontend-stable, VisualEditor, VisualEditor-MediaWiki-Mobile: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#954688 (10Jdforrester-WMF) p:5Triage>3Normal a:3Esanders
[12:29:59] <wikibugs>	 3Editing, MobileFrontend-beta, VisualEditor, VisualEditor-MediaWiki-Mobile: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#954777 (10Jdforrester-WMF) p:5Triage>3Normal
[13:36:20] <phuedx>	 back from lunch
[15:10:54] <grrrit-wm>	 (03PS1) 10Dbrant: Fix possible crash when typing search text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182814 
[15:17:36] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Don't export activities (except PageActivity) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182146 (owner: 10BearND)
[15:18:12] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Update pom.xml to have fixed version of MW API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182215 (owner: 10BearND)
[15:22:47] <wikibugs>	 3Wikipedia-App-Android-App: StringIndexOutOfBoundsException in LicenseActivity - https://phabricator.wikimedia.org/T85510#955112 (10Dbrant) 5Open>3Resolved a:3Dbrant
[15:28:35] <grrrit-wm>	 (03CR) 10Dbrant: [C: 032] Refactor: replace all usages of "Persistance" with "Persistence". [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182696 (owner: 10Deskana)
[15:29:57] <grrrit-wm>	 (03PS7) 10Dbrant: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 
[15:31:01] <grrrit-wm>	 (03PS5) 10Dbrant: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 
[15:33:47] <grrrit-wm>	 (03PS5) 10Dbrant: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 (owner: 10BearND)
[15:34:32] <grrrit-wm>	 (03PS2) 10Dbrant: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 (owner: 10BearND)
[15:37:51] <grrrit-wm>	 (03PS2) 10Dbrant: Fix possible crash when typing search text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182814 
[15:42:24] <grrrit-wm>	 (03CR) 10Phuedx: [C: 031] "This is good enough for alpha." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson)
[15:44:55] <grrrit-wm>	 (03Abandoned) 10Dbrant: use default browser instead of chooser when appropriate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159198 (owner: 10NightlyNexus)
[15:49:18] <grrrit-wm>	 (03Abandoned) 10Dbrant: Fixed SSL fallback logic for users in China [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163830 (owner: 10Zhaofeng Li)
[15:51:23] <grrrit-wm>	 (03Abandoned) 10Dbrant: [WIP] Add first-time editing onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 (owner: 10Dbrant)
[15:52:54] <grrrit-wm>	 (03Abandoned) 10BearND: Back button goes back to calling activity from onboarding activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/180401 (owner: 10BearND)
[15:54:17] <FlorianSW>	 bearND, Deskana|Away can you take a look at the screenshot attached at the last message here: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8053336;&OTRSAgentInterface=10eea97fc48a0f107f1b1c17c1a5eab760
[15:54:38] <FlorianSW>	 The problem is, that the checkboxes are black on a black background, for me it seems to be a problem with the customROM?
[15:56:02] <dbrant>	 FlorianSW: hmm, I'm actually able to reproduce it on one of my devices.
[15:56:26] <FlorianSW>	 ah, hi dbrant :) The same device?
[15:56:44] <FlorianSW>	 i have checked on htc one, but let me try s4 mini, too :)
[15:57:04] <dbrant>	 FlorianSW: not the same device, but same OS version
[15:58:43] <FlorianSW>	 dbrant: hmm, two 4.4.2 devices without problems (there is a light grey border when a checkbox isn't checked)
[15:58:56] <dbrant>	 curious.
[15:58:58] <FlorianSW>	 should i file a bug for it?
[15:59:27] <dbrant>	 FlorianSW: yep, since I'm seeing it too.
[16:00:20] <FlorianSW>	 ok, thanks dbrant 
[16:00:24] <FlorianSW>	 :)
[16:03:09] <wikibugs>	 3Wikipedia-App-Android-App: Unchecked checkboxes aren't visible in dark theme - https://phabricator.wikimedia.org/T85809#955234 (10Florian) 3NEW
[16:03:12] <FlorianSW>	 dbrant: ^^
[16:03:19] <dbrant>	 thx!
[16:12:48] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[16:16:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Introduce util module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182238 (owner: 10Jdlrobson)
[16:17:39] <FlorianSW>	 phuedx: i'm testing https://gerrit.wikimedia.org/r/#/c/182334 but it seems, that there is a problem somewhere :/ If i click on the nearby button the hash #/nearby/page/Berlin (my testpage) is added, but there is no overlay, are there special dependencies i haven't seen?
[16:19:48] <phuedx>	 FlorianSW: wait one sec, i may have missed something
[16:21:13] <phuedx>	 FlorianSW: in alpha?
[16:26:05] <FlorianSW>	 phuedx: yes, alpha, and the button is there :/
[16:26:43] <FlorianSW>	 but not the overlay (i added a simple log to the console for all three overlayManager routes, but there is nothing (init.js is loaded)).
[16:28:40] <phuedx>	 the button in the main menu is #/nearby/0 for me
[16:28:44] <phuedx>	 (which works)
[16:29:18] <FlorianSW>	 phuedx: i tested the nearby button on a page, let me check th eone in navbar
[16:29:57] <FlorianSW>	 phuedx: ok, that works :/
[16:30:15] <phuedx>	 FlorianSW: you're right
[16:30:24] <phuedx>	 there's a route that's missing from nearby/init.js
[16:30:39] <phuedx>	 /nearby/page/<title>
[16:30:54] <phuedx>	 there's /nearby/page/<title>/<index>
[16:30:58] <phuedx>	 but the index isn't optional
[16:32:15] <FlorianSW>	 uhh, right
[16:32:33] <FlorianSW>	 yeah, with index it works 
[16:32:55] <FlorianSW>	 phuedx: i comment it on change, ok?
[16:33:09] <phuedx>	 FlorianSW: sure, nice catch
[16:33:30] <phuedx>	 i didn't think to look at the secondary action buttons, only the main menu
[16:35:00] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "thanks for phuedx helping to find the offset problem :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson)
[16:35:14] <FlorianSW>	 phuedx: and i haven't checked navbar, but secondary actions :P
[16:35:27] <phuedx>	 we're a code reviewing team!
[16:35:45] <FlorianSW>	 yeah :D
[16:38:15] <phuedx>	 ok
[16:38:18] <phuedx>	 brb
[16:38:32] <phuedx>	 children are sick
[16:38:42] <phuedx>	 have to help with dinner
[16:40:25] <FlorianSW>	 phuedx: hope your children get's well soon :)
[17:15:58] <wikibugs>	 3MobileFrontend-Feature-requests: Emulate mobile view on desktop preview page - https://phabricator.wikimedia.org/T85587#955428 (10Jdlrobson) Thanks for the clarifications. I imagine in the editor preview it would be useful to be able to toggle skin/screen resolutions easily. My main concern in a nutshell is abo...
[17:16:21] <Krenair>	 FlorianSW, dbrant: another dark theme visibility issue: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8054915
[17:18:17] <jdlrobson>	 hey phuedx 
[17:18:23] <jdlrobson>	 happy new year and all that jazz
[17:18:27] <jdlrobson>	 same to you FlorianSW :D
[17:19:03] <FlorianSW>	 hey jdlrobson, happy new year for you, too :P and for phuedx, too, i forgot :)
[17:19:55] <FlorianSW>	 Krenair: we should ask for the android  version, because i can't reproduce on 4.4.2, dbrant?
[17:20:22] <dbrant>	 FlorianSW: Krenair: i can't reproduce it on any version :(
[17:20:51] <FlorianSW>	 dbrant, Krenair i think device and sw-information would help to investigate in the first step :)
[17:21:03] <Krenair>	 ok, shall I ask for that then? dbrant?
[17:21:17] <phuedx>	 yo
[17:21:24] <phuedx>	 hey jdlrobson, same to you
[17:21:59] <dbrant>	 Krenair: yeah, that might help. Seems to be restricted to 5.0.
[17:22:46] <Krenair>	 so we want specific version of lollipop and device details?
[17:23:21] <dbrant>	 Krenair: yep, device model and exact version.
[17:24:10] <FlorianSW>	 Krenair, dbrant can replicate it on nexus 7 android 5.0.2
[17:24:32] <dbrant>	 oh, good
[17:24:35] <FlorianSW>	 *5.0.1
[17:24:42] <Krenair>	 I thought you said he couldn't on any version?
[17:24:51] <dbrant>	 < I couldn't
[17:25:04] <FlorianSW>	 4.4.2 htc one :)
[17:25:10] <FlorianSW>	 and galaxy s4 mini
[17:25:21] <FlorianSW>	 i forgot my nexus 7 :P
[17:26:39] <jdlrobson>	 phuedx: i'm still confused about standups kristenlans am i supposed to go to the one this morning?
[17:28:03] <phuedx>	 no idea
[17:28:06] <phuedx>	 none
[17:28:06] <phuedx>	 zip
[17:28:20] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix possible crash when typing search text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182814 (owner: 10Dbrant)
[17:31:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix possible crash when typing search text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182814 (owner: 10Dbrant)
[17:32:33] <FlorianSW>	 wikibugs doesn't add information about bugs in Mobile-web?
[17:32:45] <grrrit-wm>	 (03PS6) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 
[17:32:47] <grrrit-wm>	 (03PS8) 10BearND: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant)
[17:32:49] <grrrit-wm>	 (03PS3) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 
[17:32:49] <FlorianSW>	 jdlrobson, phuedx, Maryana: ^
[17:32:51] <grrrit-wm>	 (03PS6) 10BearND: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant)
[17:33:03] <wikibugs>	 3Wikipedia-App-Android-App: NPE crashes from onBeforeExecute while searching - https://phabricator.wikimedia.org/T85429#955463 (10Krenair) 5Open>3Resolved a:3Krenair Assuming this is resolved.
[17:33:10] <kristenlans>	 Hey there jdlrobson I was thinking that everyone attends todays standup since we have stuff to talk about/wrap up frm the last couple of sprints. THen we can discuss how standups shoudl go goign forward. I liked your idea of M/t/Th for collections/readership stuff.
[17:33:57] <grrrit-wm>	 (03CR) 10Phuedx: [C: 032] Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson)
[17:34:16] <jdlrobson>	 kristenlans: okay cos you trolled us whilst you were gone
[17:34:28] <jdlrobson>	 kristenlans: joaquin, rob and i were removed from all the standup invites
[17:34:45] <jdlrobson>	 :-)
[17:35:08] <kristenlans>	 jdlrobson: oh no! I meant for you guys to be removed from 01/017/15 onward. hmmmm, sorry about that
[17:35:31] <kristenlans>	 01/07/15, that is
[17:35:59] <Maryana>	 howdy, gang
[17:36:22] <kristenlans>	 Maryana: Yo! Happy new year
[17:36:27] <FlorianSW>	 happy new year Maryana :)
[17:36:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove need for #notifications element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182240 (owner: 10Jdlrobson)
[17:36:57] <jdlrobson>	 Maryana: you still in texas?
[17:37:19] <Maryana>	 happy new year!
[17:37:22] <Maryana>	 yeah, i'm in austin
[17:37:26] <Maryana>	 flying back this evening
[17:37:56] <Maryana>	 how was megacation, kristenlans ? :)
[17:39:53] <kristenlans>	 Maryana: woah, it was mega! 50% loafing/50% adventuring
[17:40:16] <Maryana>	 nice
[17:42:28] <joakino>	 hi hi
[17:46:41] <FlorianSW>	 hi joakino and happy new year :P
[17:47:00] <jdlrobson>	 hey joakino :)
[17:47:21] <joakino>	 hy jdlrobson FlorianSW happy new year to you too :D
[17:48:49] <FlorianSW>	 http://www.autoguide.com/auto-news/2015/01/self-driving-audi-a7-heads-to-ces-from-silicon-valley.html german automobile engineer power :)
[17:50:31] <grrrit-wm>	 (03CR) 10Phuedx: "This looks OK. See inline for a thing about code vs. configuration for the tablet modules." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson)
[17:50:55] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 
[17:50:57] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 
[17:50:59] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 
[17:51:01] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Introduce Skin.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 
[17:51:55] <jdlrobson>	 phuedx: agreed. My plan is to make a skin config but haven't quite worked out how that will work for skins which do not define it.
[17:52:10] <jdlrobson>	 so skin = new Skin( mw.config.get( 'wgSkinConfig' ) )
[17:52:16] <jdlrobson>	 (core change would be nice.. :-))
[17:52:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson)
[17:53:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Thanks @bmansurov much less mysterious now :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov)
[17:54:13] <grrrit-wm>	 (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182844 
[17:54:25] <grrrit-wm>	 (03CR) 10Phuedx: "Shouldn't isTestA be deprecated? I'll kick the tyres momentarily." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson)
[17:54:51] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "If @MaxSem doesn't +2 this I will merge this by the end of the day as this as being sitting around too long." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[17:55:20] <phuedx>	 jdlrobson: yeah skin = new Skin( skinConfig ) where skinConfig defaults to mw.config.get ... would be grand
[17:55:49] <jdlrobson>	 phuedx: and yeh maybe we want to kill isTestA but it's currently on the Edit schema so we'd need to update our schema too
[17:55:57] <jdlrobson>	 (actually i was thinking about rewriting most of our schemas)
[17:56:12] <jdlrobson>	 we should have an AnonSchema and UserLoggedInSchema
[17:56:17] <jdlrobson>	 which use the same base defaults
[17:58:00] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182844 (owner: 10BearND)
[18:00:53] <joakino>	 rmoen: https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.abvfhue9msa07tgt4d9v4s0u1g?authuser=1
[18:02:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182844 (owner: 10BearND)
[18:03:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Polish: make log out button on boundary square [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov)
[18:15:48] <rmoen>	 joakino: ty, for some reason it was crossed off my calendar ;/
[18:15:56] <grrrit-wm>	 (03CR) 10Bmansurov: "@Jhernandez, you're right. That's the side effect of how icons are rendered in alpha." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182231 (owner: 10Bmansurov)
[18:16:12] <joakino>	 rmoen: yea kristenlans was playing with us haha
[18:17:52] <grrrit-wm>	 (03CR) 10Jdlrobson: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[18:25:22] <grrrit-wm>	 (03CR) 10BearND: "Great suggestion. Now I think that having a specialized file name (within a fixed folder) sounds great. I would like to see that as depend" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181440 (owner: 10Deskana)
[18:32:29] <grrrit-wm>	 (03Abandoned) 10Deskana: Some tweaks to image sharing functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181440 (owner: 10Deskana)
[18:33:36] <kristenlans>	 maxsem do you guys have a meeting room?
[18:34:41] <bearND>	 Deskana: I meant using a variable file name (e.g. based on the original image file name) but a fixed folder. So we can blow the folder contents away before sharing a new image.
[18:35:04] <Deskana>	 bearND: Ah, okay, I only skimmed. Go for it!
[18:35:41] <kristenlans>	 https://etherpad.wikimedia.org/p/MobileWeb-Retrospective
[18:36:44] <wikibugs>	 3Wikipedia-App-Android-App: Image sometimes scales instead of doing parallax scrolling - https://phabricator.wikimedia.org/T85832#955697 (10Deskana) 3NEW
[18:38:18] <Deskana>	 dbrant, bearND: ^
[18:38:57] <dbrant>	 Deskana: thx! I've seen it myself in several other articles... I think I know of a solution
[18:40:40] <Deskana>	 I kind of half fixed it by putting image1.setScaleType(ImageView.ScaleType.FIT_START); into the onScrollChanged method
[18:40:57] <Deskana>	 But as I said, that caused it to then scale when it was doing the parallax before ^_^
[18:41:15] <wikibugs>	 3Wikipedia-App-Android-App: Unchecked checkboxes aren't visible in dark theme - https://phabricator.wikimedia.org/T85809#955724 (10Dbrant) The checkboxes in the PreferenceActivity don't seem to be inheriting the correct style for the current theme (whether it's light or dark)!  That's a little puzzling. Will nee...
[18:50:44] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[18:52:59] <grrrit-wm>	 (03CR) 10BearND: [C: 04-1] "On 2.3 I get a NoSuchMethodException when starting the app." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant)
[18:54:48] <mhurd>	 dr0ptp4kt: can you add me to the data layer review invite? i could use refresher :)
[18:58:01] <dr0ptp4kt>	 mhurd: will do
[18:59:08] <Deskana>	 dr0ptp4kt: Me too! I'd like to come as an interested observer. (Not with my PM hat on)
[18:59:18] <Deskana>	 Feel free to say no if you wanted to keep it small.
[18:59:22] <dr0ptp4kt>	 Deskana: will do
[18:59:47] <Deskana>	 mhurd, dr0ptp4kt: Let's grab lunch at 12, as well? :)
[19:00:15] <mhurd>	 Deskana: dr0ptp4kt sure, i’m free
[19:00:27] <dr0ptp4kt>	 Deskana: mhurd cool
[19:01:05] <grrrit-wm>	 (03PS19) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[19:03:14] <mhurd>	 dbrant: bearND do you show lead image even if it’s not a png/jpg? the “torque” article, for example, which uses a gif
[19:03:44] <dbrant>	 mhurd: we do
[19:03:52] <mhurd>	 dbrant: does it animate?
[19:04:01] <dbrant>	 mhurd: it does not.
[19:04:09] <dbrant>	 :(
[19:04:41] <mhurd>	 dbrant: for torque, the image looks pixelated… how does it look for you guys?
[19:05:16] <dbrant>	 mhurd: yep, a bit pixelated
[19:12:56] <wikibugs>	 3Wikipedia-App-General-or-Unknown: Tracking: API issues blocking Wikipedia app development - https://phabricator.wikimedia.org/T75616#955838 (10Chad)
[19:16:33] <Deskana>	 tfinc: Can Elena have one of those Nexus 5s to do her Android testing?
[19:17:08] <tfinc>	 Deskana: will this be replacing the busted Samsung ?
[19:17:15] <Deskana>	 tfinc: Yeah.
[19:17:19] <tfinc>	 or do we need to re-order that phone ?
[19:18:01] <Deskana>	 tfinc: She doesn't need to test on Samsung specifically, so a Nexus will do her.
[19:18:41] <Deskana>	 tfinc: Although that Samsung was (according to the device list) our only Samsung, and Samsung handles things so differently sometimes (compat library issues, overflow menu differences) that having one handy for testing is... well, handy.
[19:19:13] <Deskana>	 tfinc: I wouldn't need to be that specific model, though. Whatever's most cost efficient.
[19:19:31] <jdlrobso_>	 phuedx: https://www.youtube.com/watch?v=81MWIsj2Kmc
[19:21:30] <Deskana>	 Brass Eye. Amazing show.
[19:21:35] <Deskana>	 I love this bit the most: https://www.youtube.com/watch?v=Fc1P-AEaEp8
[19:21:51] <tfinc>	 Deskana: likely a variation on the Galaxy. either way. shoot me and email with this stuff and then it'll happen 
[19:21:58] <Deskana>	 tfinc: Roger!
[19:22:36] <grrrit-wm>	 (03PS7) 10Dbrant: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 
[19:30:50] <grrrit-wm>	 (03CR) 10BearND: "Pretty hacky but it works. Would you add a comment?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant)
[19:33:18] <joakino>	 phuedx: i don't even have it on the calendar
[19:33:47] <phuedx>	 joakino: ?
[19:33:52] <RoanKattouw>	 Who's in charge of SWATs and deployments for mobile web? jdlrobso_ , perhaps?
[19:34:00] <joakino>	 phuedx: this meeting that starts now
[19:34:18] <RoanKattouw>	 As ryasmeen pointed out, https://gerrit.wikimedia.org/r/#/c/182113/3 needs to be cherry-picked to wmf13 and SWATted for mobile VE to work
[19:34:18] <phuedx>	 that's cause you're not part of the team!
[19:34:20] <joakino>	 RoanKattouw: kaldari or jdlrobso_ maybe
[19:35:04] <phuedx>	 joakino: https://plus.google.com/hangouts/_/wikimedia.org/sprint i think
[19:35:32] <joakino>	 thx
[19:35:39] <joakino>	 im gonna rest a bit
[19:35:54] <joakino>	 late meetings on the epiphany day... wohoo
[19:37:30] <FlorianSW>	 RoanKattouw: i think MaxSem can help, too
[19:38:07] * Deskana Googles "Epiphany day"
[19:38:24] * Deskana is evidently a bad Catholic
[19:38:55] <RoanKattouw>	 Oh yes, of course
[19:39:10] <RoanKattouw>	 MaxSem is a prolific SWATter and on the mobile team
[19:39:22] <RoanKattouw>	 But he's not in this channel? Is he still on vacation today?
[19:40:08] <Deskana>	 I saw him around the office before.
[19:40:15] <kaldari>	 RoanKattouw, joakino: I'll take care of that after our sprint kickoff.
[19:40:38] <RoanKattouw>	 Deskana: Oooooh, looks like Epiphany is what's called Driekoningen ("Three Kings") back here
[19:40:56] <RoanKattouw>	 For concepts like these, no amount of explanation is going to tell me what something is as easily as looking up the name of the article in another language
[19:41:06] <kaldari>	 RoanKattouw: Max is retired from SWATting, so it's just me now
[19:41:09] <RoanKattouw>	 Especially if the names are completely unrelated to each other
[19:41:16] <RoanKattouw>	 kaldari: OK cool
[19:41:31] <mhurd>	 dbrant: have a couple minutes?
[19:41:40] <dbrant>	 mhurd: yep!
[19:41:48] <RoanKattouw>	 We SWATted a VE patch to make mobile VE work again this morning, but then it just started breaking for a different reason instead :D but it looks like Jon already fixed that too, so we just need that backport and we should be set
[19:42:20] <kaldari>	 RoanKattouw: Cool. Thanks for the ping.
[19:42:49] <RoanKattouw>	 Thanks for looking into it. I'll probably be asleep/away by the time the SWAT rolls around, but please let ryasmeen know when it's deployed
[19:44:01] <kaity>	 RoanKattouw: he's here today
[19:44:23] <kaldari>	 kaity: You coming to the sprint kickoff meeting?
[19:44:57] <kaldari>	 RoanKattouw: will do.
[19:45:41] <RoanKattouw>	 Thanks
[20:05:16] <grrrit-wm>	 (03PS1) 10Dbrant: Fix parallax scrolling when lead image is thinner than viewport. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182870 (https://bugzilla.wikimedia.org/85832) 
[20:05:54] <kristenlans>	 http://hatjitsu.wmflabs.org/57163
[20:09:06] <grrrit-wm>	 (03CR) 10Robmoen: [C: 04-1] "-1 for EditorOverylayBase looking for VE. See inline suggestion to avoid this." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[20:09:40] <rmoen>	 brb, pizza time
[20:10:54] <Krenair>	 dbrant, bearND: any idea about these? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8056040 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7751898 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7656584
[20:12:14] <dbrant>	 Krenair: no idea :(
[20:12:26] <Krenair>	 could it be an android issue?
[20:12:33] <Krenair>	 or something other than the app itself?
[20:13:06] <joakino>	 having tonight https://en.wikipedia.org/wiki/King_cake before opening presents (similar to this one https://es.m.wikipedia.org/wiki/Rosc%C3%B3n_de_Reyes#/image/Archivo:Rosc%C3%B3n_de_Reyes_-_Mallorquina.jpg ) before opening presents :D
[20:14:05] <dbrant>	 Krenair: that could be likely (there's nothing in the stack trace that points to our app).  It would help to know what they were doing when it crashed.
[20:14:29] <Krenair>	 There's quite a lot of stack traces that make no reference to our code...
[20:14:40] <grrrit-wm>	 (03PS2) 10Dbrant: Fix parallax scrolling when lead image is thinner than viewport. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182870 
[20:17:06] <Krenair>	 jdlrobson, I saw you suggested 'membership' in https://phabricator.wikimedia.org/T85830 - did you see what https://en.wikipedia.org/wiki/Wikimedia_Foundation#History has to say about this?
[20:17:40] <Krenair>	 maybe I just took it too literally though?
[20:21:40] <Krenair>	 dbrant, bearND I also saw https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7858784 and https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7942527
[20:23:34] <dbrant>	 Krenair: not sure about those, either;  but those are only from 8/13
[20:23:54] <kristenlans>	 https://etherpad.wikimedia.org/p/L
[20:24:07] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "The form should be disabled until some text is entered. It seems like you should be able to prevent this error from occurring rather than " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[20:24:29] <kaldari>	 http://www.reelfilm.com/l.htm
[20:25:03] <grrrit-wm>	 (03CR) 10Jdlrobson: Refactor Nearby feature as overlay in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson)
[20:26:36] <grrrit-wm>	 (03PS5) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 
[20:26:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson)
[20:27:51] <grrrit-wm>	 (03PS1) 10Dbrant: Don't show lead image if it's a .GIF [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182877 
[20:28:53] <grrrit-wm>	 (03PS6) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 
[20:29:36] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Hygiene: requirePaddingNewlinesBeforeKeywords for function keyword. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/174398 (owner: 10Jdlrobson)
[20:30:54] <phuedx>	 g'night folks
[20:31:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson)
[20:37:32] <bearND>	 bearND|lunch
[20:47:39] <Krenair>	 dbrant, some of those crashes have come up for other people before if you search google
[20:48:49] <Krenair>	 dbrant, for the second one, https://code.google.com/p/android/issues/detail?id=18990 said "WebView related issues are fixed."
[20:49:17] <Krenair>	 (second group of crashes that I mentioned, I mean)
[20:54:36] <dbrant>	 Krenair: yep, there are no easy fixes or workarounds for issues with the WebView itself. (cf. egl-related crashes)
[20:54:47] <Krenair>	 ok
[20:55:11] <Krenair>	 In that case is there no point filing them in phabricator?
[20:55:25] <Krenair>	 what should be done to get them out of the otrs queue?
[20:56:43] <dbrant>	 Krenair: well, it might still be a good idea to 'track' them in phabricator, in case a workaround is invented...
[20:56:45] <wikibugs>	 3MobileFrontend-Feature-requests: Assess ≡ (hamburger menu) vs. W symbol et al. for site drawer - https://phabricator.wikimedia.org/T65978#956158 (10Nemo_bis)
[20:57:01] <Krenair>	 okay
[20:58:04] <Krenair>	 dbrant, when they are actually filed upstream, we can add the 'upstream' project so they don't show up in otherwise useful searches etc.
[20:59:20] <dbrant>	 Krenair: ok, cool
[21:05:11] <grrrit-wm>	 (03PS8) 10Dbrant: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 
[21:08:17] <grrrit-wm>	 (03CR) 10Dbrant: "@BearND Good find. I did what was suggested in that thread, which is to use an inner class for all Bus-related methods. Although, in all " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant)
[21:08:50] <aharoni>	 yo
[21:09:10] <aharoni>	 In the message "Mobile-frontend-errorreport-instructions", what does "Please do not report missing items" mean?
[21:09:57] <tfinc>	 Deskana: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals/Q3
[21:14:00] <bearND>	 bearND
[21:22:51] <mhurd>	 MaxSem: does this ( https://wikitech.wikimedia.org/wiki/Deployments ) mean the mobileview wikidata descriptions go live tomorrow?
[21:24:34] <MaxSem>	 no
[21:24:48] <MaxSem>	 when was it merged?
[21:24:59] <mhurd>	 MaxSem: no idea
[21:31:15] <joakino>	 gnight guys!
[21:31:24] <joakino>	 gonna eat my king cake
[21:31:28] <joakino>	 have a nice day
[21:32:57] <jdlrobson>	 aharoni: worth poking kaldari
[21:33:05] <jdlrobson>	 or raising a bug if he doesn't answer :)
[21:33:37] <jdlrobson>	 https://gerrit.wikimedia.org/r/181754 < rmoen fancy +2ng this?
[21:37:31] <rmoen>	 jdlrobson: looking now
[21:39:05] <kristenlans>	 jdlrobson rmoen would you be ok with 9:4 standup? Earlier for joakino and avoids a few scheduling clashes.
[21:39:17] <kristenlans>	 ^ 9:45
[21:39:27] <grrrit-wm>	 (03PS7) 10Jdlrobson: Refactor Nearby feature as overlay in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 
[21:39:28] <jdlrobson>	 sure.
[21:39:58] <rmoen>	 kristenlans: sure ;)
[21:40:32] <rmoen>	 brb, need to reboot
[21:42:05] <kaldari>	 jdlrobson: Why was the new Skin code added as part of the capitalizedNativeCase hygiene patch? Was that just an accident? https://gerrit.wikimedia.org/r/#/c/182207/
[21:42:23] <jdlrobson>	 kaldari: it was? ergg yeh that's accidental :-/
[21:42:52] <jdlrobson>	 kaldari: i'll revert 
[21:43:02] <jdlrobson>	 and then re-prepare the introduction patch
[21:43:12] <kaldari>	 jdlrobson: thanks!
[21:46:56] <jdlrobson>	 kaldari: mmm.. not that easy.. seems https://gerrit.wikimedia.org/r/#/c/182237/5 got merged
[21:47:38] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Use Skin for loading wide screen modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 
[21:47:40] <grrrit-wm>	 (03CR) 10Robmoen: [C: 04-1] "small nitpick. Spinning up vagrant to test." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson)
[21:47:50] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 
[21:48:28] <kaldari>	 jdlrobson: in that case, just submit a patch to delete Skin.js and then readd it in the Skin-related patch that isn't merged yet.
[21:48:53] <jdlrobson>	 kaldari: i'm saying it's not that easy..
[21:48:59] <jdlrobson>	 the skin code is now tied to the namespace code
[21:49:14] <jdlrobson>	 i'd need to revert https://gerrit.wikimedia.org/r/#/c/182237/5 as well
[21:49:18] <jdlrobson>	 it's more hassle than worth
[21:52:17] <grrrit-wm>	 (03CR) 10Jdlrobson: Add Possibility to add categories to a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[21:52:27] <kaldari>	 jdlrobson: OK, I guess just leave it then. Put please add a mention of the capitalizedNativeCase patch in the commit message for the Skin-related code.
[21:53:03] <kaldari>	 so there is a trail to follow at least
[21:53:31] <kaldari>	 kaity: Do you know when Jared is going to be in?
[21:57:00] <jdlrobson>	 mmm i broke my vagrant again. doh
[21:57:09] <jdlrobson>	 > vagrant up = Couldn't open file /Users/jrobson/git/vagrant/base
[21:57:11] <jdlrobson>	 MaxSem: ?
[21:57:25] <jdlrobson>	 default: Downloading: base
[21:57:25] <jdlrobson>	 An error occurred while downloading the remote file.
[21:57:32] <MaxSem>	 what did ya do?
[21:57:40] <jdlrobson>	 vagrant destroy
[21:57:44] <jdlrobson>	 vagrant up
[21:58:34] <MaxSem>	 d'oh
[21:59:05] <MaxSem>	 didn't i tell you to avoid recreation at the first sight of a problem? :p
[21:59:35] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 
[21:59:37] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 
[21:59:40] <kristenlans>	 Deskana are you up for a 3-3:30 check-in/iOS backlog pruning?
[21:59:42] <jdlrobson>	 MaxSem: anyway.. how can i fix it
[21:59:57] <Deskana>	 kristenlans: If I'm free on my calendar, then yes!
[22:00:11] <kristenlans>	 👍
[22:01:19] <kristenlans>	 Deskana: done :-)
[22:02:26] <kaldari>	 jdlrobson: actually I don't see anything problematic about deleting Skin.js. Nothing is using it currently.
[22:02:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson)
[22:10:28] <aharoni>	 hi kaldari
[22:10:31] <aharoni>	 In the message "Mobile-frontend-errorreport-instructions", what does "Please do not report missing items" mean?
[22:10:43] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Fix parallax scrolling when lead image is thinner than viewport. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182870 (owner: 10Dbrant)
[22:10:52] <grrrit-wm>	 (03PS7) 10Jdlrobson: Refactor: Introduce and use Skin for loading wide screen modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 
[22:10:54] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Remove Skin.js erroneously added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182931 
[22:11:41] <kaldari>	 aharoni: it means don't complain about information that is missing from an article. I'll see if I can improve the qqq message there.
[22:11:51] <mhurd>	 MaxSem: https://trello.com/c/XaPEs6Jl/31-add-width-constrained-article-image-parameter-to-mobileview-api
[22:11:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix parallax scrolling when lead image is thinner than viewport. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182870 (owner: 10Dbrant)
[22:12:19] <aharoni>	 kaldari: I'd say "missing information".
[22:12:56] <kaldari>	 aharoni: all of those messages are for an experimental feature anyway. I forget, how do I mark them as optional to translate?
[22:13:57] <aharoni>	 kaldari: in the translatewiki repo
[22:14:03] <aharoni>	 grep for "optional"
[22:14:23] <aharoni>	 but I don't think that you should mark those as optional
[22:14:34] <aharoni>	 is this experiment running in all languages?
[22:16:08] <kaldari>	 aharoni: it's only in alpha mode, so it's more a proof of concept at this point (not even an actual experiment), but yes, it's running in all languages, so I guess I should have them translated anyway.
[22:16:48] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 
[22:16:48] <kaldari>	 aharoni: also, what do you think about having the paragraph tags in that message. Is that OK?
[22:16:55] <grrrit-wm>	 (03PS7) 10Jdlrobson: Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 
[22:17:11] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 
[22:17:21] <grrrit-wm>	 (03PS5) 10Jdlrobson: Refactor: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 
[22:18:01] <grrrit-wm>	 (03CR) 10Dbrant: [C: 04-1] "95% there! A few notes inline. And also:" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 (owner: 10BearND)
[22:18:26] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Don't show lead image if it's a .GIF (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182877 (owner: 10Dbrant)
[22:19:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't show lead image if it's a .GIF [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182877 (owner: 10Dbrant)
[22:20:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson)
[22:20:41] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "qunit issues" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson)
[22:20:57] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Hygiene: Remove Skin.js erroneously added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182931 (owner: 10Jdlrobson)
[22:21:51] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Refactor: Introduce and use Skin for loading wide screen modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson)
[22:23:29] <dbrant>	 mhurd: I went ahead and made a patch that doesn't show the lead image if it's a GIF. That was a good call.
[22:23:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove Skin.js erroneously added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182931 (owner: 10Jdlrobson)
[22:23:42] <mhurd>	 dbrant: cool! i’ll do same :)
[22:24:09] <dbrant>	 mhurd:  It would be ideal to get the MIME type of the lead image somehow... but for now I'm just checking if the file name ends with ".gif"
[22:24:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor: Introduce and use Skin for loading wide screen modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182289 (owner: 10Jdlrobson)
[22:24:25] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:24:58] <grrrit-wm>	 (03PS20) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[22:26:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:26:58] <jdlrobson>	 rmoen: feel free to make the whitespace fix and merge
[22:27:03] <jdlrobson>	 my vagrant is being reinstalled
[22:27:05] <grrrit-wm>	 (03PS21) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[22:27:05] <jdlrobson>	 gonna take a while
[22:27:41] <rmoen>	 jdlrobson: will do. i'm going through the change still, just got my vagrant up
[22:28:55] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Looks good but haven't tested yet. A few thoughts I had whilst browsing." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:29:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:29:57] <rmoen>	 ahhh vagrant so slugish
[22:33:01] <grrrit-wm>	 (03PS1) 10Bmansurov: Make WikiGrok not depend on WikiData API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 
[22:33:09] <rmoen>	 ahh i have to destroy it, this is not acceptable
[22:33:23] <aharoni>	 kaldari: it's better to avoid markup in translatable messages.
[22:34:30] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: jscs should apply to test files as well. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182940 
[22:35:20] <kaldari>	 jdlrobson: does anything else need to be SWAT deployed besides https://gerrit.wikimedia.org/r/#/c/182113/ ?
[22:35:52] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/182128/ < kaldari probably
[22:36:43] <kaldari>	 jdlrobson: Oh yeah, that's probably worth deploying
[22:37:52] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Hygiene: jscs should apply to test files as well. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182940 (owner: 10Jdlrobson)
[22:39:39] <grrrit-wm>	 (03CR) 10Robmoen: [C: 031] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:39:55] <grrrit-wm>	 (03PS1) 10Bmansurov: Documentation: Fix typos and remove an unsupported tag. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182942 
[22:40:34] <rmoen>	 jdlrobson: anything else you need reviewed as I'm spinning a new vagrant? Otherwise I'll just go down the code review list
[22:42:16] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Yeah, that sounds like a much better solution :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[22:43:26] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Documentation: Fix typos and remove an unsupported tag. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182942 (owner: 10Bmansurov)
[22:43:44] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 
[22:45:27] <grrrit-wm>	 (03PS1) 10Kaldari: Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182943 
[22:45:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[22:45:44] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:45:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Documentation: Fix typos and remove an unsupported tag. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182942 (owner: 10Bmansurov)
[22:48:10] <grrrit-wm>	 (03PS1) 10Kaldari: Fix notification overlay back behaviour [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182944 
[22:49:21] <grrrit-wm>	 (03CR) 10Robmoen: "Looks good. Haven't tested though. Also, could you link to the phab task in the commit message? I failed to find in phabricator" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[22:50:19] <grrrit-wm>	 (03PS22) 10Florianschmidtwelzow: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 
[22:51:19] <FlorianSW>	 rmoen: there is no phab task iirc (for change https://gerrit.wikimedia.org/r/#/c/182396/
[22:51:44] <rmoen>	 FlorianSW: oh i was looking at the branch name and it looked like it once had a bug
[22:51:59] <rmoen>	 Was thinking it would have been moved to phab
[22:52:03] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182943 (owner: 10Kaldari)
[22:52:33] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-2] Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182943 (owner: 10Kaldari)
[22:52:48] <FlorianSW>	 rmoen: ah, no :P I needed a name and usually i prefix it with bug/ without think about it :) (it's the change number in this case, because i started this change new from master)
[22:53:13] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 
[22:53:17] <rmoen>	 kaldari: merging these cherry picks
[22:53:31] <kaldari>	 rmoen: We usually don't merge deployment patches until immediately before deployment windows
[22:53:39] <rmoen>	 oh ok
[22:53:53] <rmoen>	 i guess that is the SWAT'rs job ?
[22:53:59] <kaldari>	 rmoen: yeah
[22:54:16] <jdlrobson>	 sigh this is sooo slow
[22:54:17] <Krenair>	 Hmm. I've been hearing conflicting things about that :)
[22:54:48] <rmoen>	 kaldari: the VE one i was particularly interested in because of my previous involvement.  Glad i said something. I wont touch the others
[22:55:24] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "needs testing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[22:55:24] <rmoen>	 jdlrobson: vagrant? 
[22:55:29] <jdlrobson>	 rmoen: yup
[22:55:48] <rmoen>	 jdlrobson: i hear you, i'm hoping a destroy and full update fixes the slowness
[22:57:25] <jdlrobson>	 i have an instance but MobileFrontend is not enabling itself now
[22:57:33] <jdlrobson>	 rmoen: that's what i'm doing
[22:57:36] <jdlrobson>	 and what is taking ages :)
[22:57:50] <rmoen>	 jdlrobson: indeed.  It will be worth it if it works
[22:58:01] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] "> I'm not convinced by the jump-to-list-item behaviour when the item's index is 0 as it hides the overlay controls" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182334 (owner: 10Jdlrobson)
[23:03:33] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 
[23:03:34] <Deskana>	 kristenlans: I'm in the hangout now! Sorry for the delay.
[23:04:47] <jdlrobson>	 ^ rmoen
[23:06:14] <grrrit-wm>	 (03PS1) 10Kaldari: Changing 'items' to 'information' per aharoni suggestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182950 
[23:06:46] <grrrit-wm>	 (03CR) 10Amire80: [C: 032] Changing 'items' to 'information' per aharoni suggestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182950 (owner: 10Kaldari)
[23:08:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Changing 'items' to 'information' per aharoni suggestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182950 (owner: 10Kaldari)
[23:08:09] <grrrit-wm>	 (03CR) 10Robmoen: [C: 031] "Quickly skimmed through, code looks good. Will test when vagrant is back up." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 (owner: 10Bmansurov)
[23:08:22] <rmoen>	 jdlrobson: looking
[23:09:35] <rmoen>	 jdlrobson: I still need to test the watchlist, before destroying vagrant i was getting mixed results.  as soon as the new instance is up it will be the first thing i do
[23:10:03] <rmoen>	 brb
[23:12:09] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Make WikiGrok not depend on WikiData API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 (owner: 10Bmansurov)
[23:13:13] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Disable Save button on TalkSectionAddOverlay while no content (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[23:13:40] <grrrit-wm>	 (03PS3) 10Jdlrobson: Enable user profile on desktop. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 
[23:14:16] <kaity>	 kaldari: Jared's sick from holiday travel but will hopefully be back tomorrow?
[23:14:23] <kaldari>	 thanks
[23:14:54] <jdlrobson>	 FlorianSW: you there?
[23:15:05] <FlorianSW>	 jdlrobson: i'm here :)
[23:16:50] <jdlrobson>	 FlorianSW: sent you a private message :)
[23:17:11] <FlorianSW>	 jdlrobson: reading it
[23:21:52] <grrrit-wm>	 (03CR) 10Jaredzimmerman: [C: 031] "looks good to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[23:25:47] <kaldari>	 bmansurov: last minute change to the WikiGrok API stuff per Moiz....
[23:25:52] <rmoen>	 jdlrobson: any luck?  Mine is running about 30 seconds per request..
[23:26:03] <bmansurov>	 kaldari: which card?
[23:26:43] <kaldari>	 bmansurov: https://trello.com/c/YZnl6oFE/14-3-make-wikigrok-not-dependent-on-wikidata-api
[23:27:22] <kaldari>	 bmansurov: instead of not showing the property label at all when the label is 'instance of', Moiz wants us to set the label to "Type".
[23:27:38] <bmansurov>	 kaldari: ok 
[23:27:53] <jdlrobson>	 still pretty slow even with destruction and rebuild
[23:28:06] <kaldari>	 bmansurov: sorry for the last minute change. The rest of the code looks good and seems to work, so I'll merge once that is changed.
[23:28:31] <bmansurov>	 kaldari: np, i'll push an update soon
[23:29:02] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Needs a last minute copy change per Moiz. Instead of not showing the property label at all when the label is 'instance of', Moiz wants us " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 (owner: 10Bmansurov)
[23:29:04] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson)
[23:29:42] <rmoen>	 jdlrobson: mine is a bit more bearable
[23:30:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: prep work for collections work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181754 (owner: 10Jdlrobson)
[23:34:12] <grrrit-wm>	 (03PS2) 10Bmansurov: Make WikiGrok not depend on WikiData API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 
[23:35:48] <grrrit-wm>	 (03PS8) 10Robmoen: Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson)
[23:36:31] <kaldari>	 bmansurov: Did you figure out how to compare patches in gerrit?
[23:36:46] <bmansurov>	 kaldari: yes, thanks. I had to change the dropdown ;)
[23:36:57] <kaldari>	 bmansurov: cool
[23:38:02] <rmoen>	 jdlrobson: was there an earlier conversation today about Skin.js that I should be aware of for reviewing skin refactors ? 
[23:38:43] <rmoen>	 I vaguely recall someone saying something about it in chat, but my log is gone
[23:39:41] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Make WikiGrok not depend on WikiData API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 (owner: 10Bmansurov)
[23:41:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make WikiGrok not depend on WikiData API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182939 (owner: 10Bmansurov)
[23:45:26] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Add Possibility to add categories to a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[23:55:37] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 
[23:55:39] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 
[23:57:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson)
[23:57:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson)
[23:58:22] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 
[23:58:48] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957