[00:00:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson)
[00:09:10] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 
[00:11:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[00:11:46] <grrrit-wm>	 (03PS8) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[00:12:12] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] "This needs still some work :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[00:13:48] <grrrit-wm>	 (03PS7) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 
[00:13:55] <grrrit-wm>	 (03PS4) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 
[00:20:51] <grrrit-wm>	 (03PS1) 10Jdlrobson: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 
[00:20:57] <grrrit-wm>	 (03PS1) 10Bmansurov: Preload next page when WikiGrok C is shown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 
[00:22:58] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[00:23:21] <grrrit-wm>	 (03PS6) 10Jdlrobson: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[00:23:35] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[00:23:41] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[00:29:27] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson)
[00:29:37] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Disable Save button on TalkSectionAddOverlay while no content (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[00:30:33] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 
[00:45:47] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (owner: 10Jdlrobson)
[00:50:28] <grrrit-wm>	 (03CR) 10Bmansurov: Hygiene: Disable Save button on TalkSectionAddOverlay while no content (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[00:52:16] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[00:55:34] <grrrit-wm>	 (03PS2) 10Bmansurov: Make WikiGrok Roulette preload the next page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 
[00:57:57] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182943 (owner: 10Kaldari)
[00:58:22] <grrrit-wm>	 (03CR) 10Aude: [V: 032] Fix naming issue to restore ability to switch between editors [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182943 (owner: 10Kaldari)
[00:58:33] <grrrit-wm>	 (03CR) 10Aude: [C: 032 V: 032] Fix notification overlay back behaviour [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182944 (owner: 10Kaldari)
[01:07:23] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Enable user profile on desktop. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 (owner: 10Jdlrobson)
[01:43:19] <grrrit-wm>	 (03PS1) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 
[01:47:31] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Make it possible for alpha to reimplement personal urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182982 
[01:47:33] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Remove unused method. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182983 
[01:47:35] <grrrit-wm>	 (03PS1) 10Jdlrobson: WIP: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 
[06:26:16] <grrrit-wm>	 (03PS23) 10Robmoen: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[06:26:43] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] "Working as should. Add $wgMFEditorOptions['skipPreview'] = true; to LocalSettings.php to test." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[06:47:30] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] "Awesome. At first the commit message threw me because this isn't in SkinMinervaAlpha. But it makes sense with your dependent commit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182982 (owner: 10Jdlrobson)
[06:49:24] <grrrit-wm>	 (03CR) 10Robmoen: [C: 032] Hygiene: Remove unused method. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182983 (owner: 10Jdlrobson)
[07:04:27] <grrrit-wm>	 (03CR) 10Robmoen: Hygiene: Disable Save button on TalkSectionAddOverlay while no content (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[09:28:51] <joakino>	 good morning!
[10:01:06] <phuedx>	 yo
[10:58:10] <grrrit-wm>	 (03CR) 10Phuedx: "What's stopping this from being [NOTAWIP]?" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/177448 (owner: 10MaxSem)
[11:02:24] <phuedx>	 fuck i need another coffee
[11:59:04] <grrrit-wm>	 (03CR) 10Phuedx: "I like the approach. The implementation of WikiGrokRoulette isn't quite right though." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 (owner: 10Bmansurov)
[12:25:10] <grrrit-wm>	 (03CR) 10Phuedx: [C: 04-1] "The #getSuggestions API doesn't quite make sense." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov)
[12:35:31] <phuedx>	 gonna head off for lunc
[12:35:34] <phuedx>	 *lunch
[13:17:16] <grrrit-wm>	 (03PS2) 10Jhernandez: WIP: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[13:18:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[13:43:33] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Don't show duplicate messages in LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183028 
[13:45:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't show duplicate messages in LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183028 (owner: 10Florianschmidtwelzow)
[13:52:04] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Don't show duplicate messages in LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183028 
[14:17:41] <joakino>	 out for lunch!
[15:13:45] <grrrit-wm>	 (03PS9) 10Dbrant: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 
[15:39:27] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[15:39:34] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[15:40:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change navigation easing function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182108 (owner: 10Bmansurov)
[15:50:05] <grrrit-wm>	 (03PS1) 10Phuedx: Disable red links in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 
[15:50:07] <grrrit-wm>	 (03PS1) 10Phuedx: Remove the red links configuration variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183039 
[15:56:34] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[15:56:48] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "kick jenkins into life" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 (owner: 10Jdlrobson)
[15:56:55] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[15:57:16] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "kick jenkins into life" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182982 (owner: 10Jdlrobson)
[15:57:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "kick jenkins into life" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182983 (owner: 10Jdlrobson)
[15:57:40] <wikibugs>	 3MobileFrontend-Feature-requests: Provide toclimit-2 and .toclevel-1 support in tablet table of contents - https://phabricator.wikimedia.org/T73726#957494 (10phuedx) @Jdlrobson: Should this be resolved as wont-fix?
[15:58:06] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Rename ResourceLoaderParsedMessageModule to MFResourceLoaderParsedMessageModule" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson)
[15:59:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide a possibility to skip preview in mobile frontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/179863 (owner: 10Florianschmidtwelzow)
[15:59:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enable user profile on desktop. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 (owner: 10Jdlrobson)
[16:00:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Use Config object for global configuration vars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181683 (owner: 10Florianschmidtwelzow)
[16:00:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Make it possible for alpha to reimplement personal urls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182982 (owner: 10Jdlrobson)
[16:02:24] <wikibugs>	 3Mobile-Web, MobileFrontend-Feature-requests: Provide a possibility to suppress preview in mobile frontend. - https://phabricator.wikimedia.org/T78504#957518 (10Jdlrobson) 5Open>3Resolved
[16:02:46] <wikibugs>	 3Mobile-Web, MobileFrontend-stable: Special:Userprofile does not currently work on desktop. - https://phabricator.wikimedia.org/T74323#957524 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson
[16:04:53] <phuedx>	 taking a break
[16:05:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove unused method. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182983 (owner: 10Jdlrobson)
[16:09:57] <wikibugs>	 3MediaWiki-Special-pages, MobileFrontend-stable: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#957550 (10MZMcBride) 3NEW
[16:29:28] <grrrit-wm>	 (03PS8) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 
[16:31:31] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, Editing, VisualEditor, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#957622 (10Catrope) ```Uncaught TypeError: boolean is not a function in Overlay.extend.hide```. It's trying to call...
[16:35:17] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[16:37:02] <wikibugs>	 3MobileFrontend-Feature-requests: Provide toclimit-2 and .toclevel-1 support in tablet table of contents - https://phabricator.wikimedia.org/T73726#957635 (10Jdlrobson) 5declined>3Resolved a:3Jdlrobson Since this can be done with css in MediaWiki:Mobile.css closing this as resolved.
[16:37:19] <grrrit-wm>	 (03PS9) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 
[16:37:21] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Hygiene: Use SkinMinerva::$mobileContext instead of MobileContext::singleton() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 
[16:39:03] <RoanKattouw>	 jdlrobson: Looks like that _hasChanged fix didn't fix everything, the back arrow is still broken https://phabricator.wikimedia.org/T85481#957622
[16:39:52] <jdlrobson>	 RoanKattouw: mmm is it fixed on master?
[16:40:00] <jdlrobson>	 maybe a patch got missed. there's been lots of refactorings
[16:40:00] <RoanKattouw>	 I don't think so
[16:40:17] <RoanKattouw>	 The bug is filed against beta labs, which runs master
[16:40:23] <jdlrobson>	 RoanKattouw: there should be no call to_hasChanged
[16:40:32] <RoanKattouw>	 I've only seen it in wmf13 because I was testing something unrelated
[16:40:36] <RoanKattouw>	 So maybe it's broken differently in beta labs, lemme check
[16:40:54] <jdlrobson>	 i just grepped master and _hasChanged is always a variable
[16:41:44] <RoanKattouw>	 Hah, I stand corrected, it works
[16:41:55] <RoanKattouw>	 In master, that is
[16:41:59] <RoanKattouw>	 We're probably still missing a patch in wmf13
[16:42:16] <RoanKattouw>	 Oh I see, the bug was filed on Dec29
[16:42:21] <jdlrobson>	 RoanKattouw: works on beta labs for me yeh
[16:42:23] <jdlrobson>	 mmm
[16:42:32] <jdlrobson>	 ergg cherry picks are always a nightmare to work out
[16:42:43] <RoanKattouw>	 Yeah
[16:42:49] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, Editing, VisualEditor, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#957657 (10Catrope) I stand corrected, this is now fixed in master. The error above is in wmf13, so we seem to have...
[16:42:50] <RoanKattouw>	 You could also manually fix it in the wmf13 branch I guess?
[16:43:05] <RoanKattouw>	 It's just that wmf13 is going to a bunch of wikis today and to everyone tomorrow, so we'd rather not ship it broken
[16:43:19] <jdlrobson>	 yep it's missing a patch
[16:43:57] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/181698/ < RoanKattouw
[16:44:42] <RoanKattouw>	 Hmm
[16:44:47] <wikibugs>	 3VisualEditor-MediaWiki-Mobile, Editing, VisualEditor, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#957659 (10Jdlrobson) https://gerrit.wikimedia.org/r/#/c/181698/ also needs to get deployed.
[16:46:21] <jdlrobson>	 but that has merge conflicts :-/
[16:51:12] <phuedx>	 whoops
[16:51:13] <grrrit-wm>	 (03CR) 10Legoktm: Hygiene: Use Config object for global variables in MinervaTemplate (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[16:51:21] <phuedx>	 i've been back for a while now…
[16:53:05] <RoanKattouw>	 jdlrobson: Yeah I feel like it's been partially cherry-picked already
[16:53:14] <RoanKattouw>	 Like, maybe something that depends on it was cherry-picked
[17:05:04] <grrrit-wm>	 (03PS8) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 
[17:05:11] <grrrit-wm>	 (03PS5) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 
[17:23:01] <kristenlans>	 Morning joakino! Did you catch that standup is 9:45 PST (I think 6:45 your time)? We discussed after you were done for the day yesterday so wanted to make sure you were aware.
[17:36:34] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Use SkinMinerva::$mobileContext instead of MobileContext::singleton() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow)
[17:40:19] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Disable red links in beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[17:40:59] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "3rd parties might be using these (I know Quim is/was for instance). The globals should be kept intact." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183039 (owner: 10Phuedx)
[17:41:39] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Use Config object for global variables in MinervaTemplate (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[17:42:36] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Use SkinMinerva::$mobileContext instead of MobileContext::singleton() (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow)
[17:43:18] <joakino>	 kristenlans: i'm aware now :D
[17:43:20] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Please add tests. This code is already very brittle." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov)
[17:43:25] <joakino>	 kristenlans: luckily i came back in time
[17:44:33] <grrrit-wm>	 (03PS3) 10Robmoen: WIP: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[17:45:22] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 04-1] Disable red links in beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[17:45:47] <kristenlans>	 rmoen standing! ;-)
[17:45:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[17:49:08] <grrrit-wm>	 (03CR) 10Phuedx: Disable red links in beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[17:49:31] <grrrit-wm>	 (03Abandoned) 10Phuedx: Remove the red links configuration variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183039 (owner: 10Phuedx)
[17:52:10] <grrrit-wm>	 (03PS9) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[17:53:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[17:57:06] <grrrit-wm>	 (03PS1) 10Alex Monk: Hygiene: Make _hasChanged public [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183059 
[17:58:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make _hasChanged public [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183059 (owner: 10Alex Monk)
[18:03:55] <jdlrobson>	 joakino_: how long are you around for today?
[18:04:03] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[18:06:31] <grrrit-wm>	 (03PS10) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[18:08:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[18:09:07] <jdlrobson>	 MaxSem: so joakino_ and i need to pull out text extracts for a list of things in PHP. Is getting a text extract a cheap function call? Do we store it on saves or is it generated dynamically each time you hit the api? Any issues with just making an internal API call in PHP?
[18:09:17] <jdlrobson>	 Also MaxSem https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=extracts&format=json&exsentences=4&exintro=&exsectionformat=plain&pageids=59%7C10%7C12%7C35 only seems to return the extract of the first page id?
[18:09:35] <jdlrobson>	 https://phabricator.wikimedia.org/T78707 < rmoen you still working on this?
[18:10:11] <rmoen>	 jdlrobson: yep
[18:10:24] <rmoen>	 jdlrobson: i have a wip in gerrit for a fix.  Needs a little cleanup
[18:11:39] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Disable Save button on TalkSectionAddOverlay while no content (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[18:15:33] <joakino>	 hi?
[18:15:33] <joakino>	 jdlrobson: im back... modem -> router -> electricity -> wifi emitter ... everything failed xd
[18:16:03] <grrrit-wm>	 (03CR) 10Catrope: "recheck" [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183059 (owner: 10Alex Monk)
[18:16:28] <RoanKattouw>	 jdlrobson: So Alex submitted https://gerrit.wikimedia.org/r/#/c/183059/ for wmf13 which he says fixes it, can we get that scheduled for the afternoon SWAT today?
[18:16:52] <RoanKattouw>	 jdlrobson: I would do that myself but 1) it's MobileFrontend code that I don't really understand, and 2) it'll be 1am my time and I'd like to be in bed then
[18:17:16] <jdlrobson>	 RoanKattouw: sure. kaldari or MaxSem we should be able to do this right ^ ?
[18:17:31] <RoanKattouw>	 I was going to ping kaldari directly but he's not on IRC
[18:17:33] <joakino>	 jdlrobson: would you mind commenting on the patch the things I've done wrong that you will change so that I can learn from the mistakes? I'll keep a close eye on the patch
[18:17:34] <joakino>	 it's been fun
[18:18:33] <RoanKattouw>	 Oh but MaxSem is here
[18:22:46] <jdlrobson>	 joakino: course
[18:22:57] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 
[18:23:00] <joakino>	 thx!
[18:25:59] <grrrit-wm>	 (03PS11) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[18:27:05] <FlorianSW>	 joakino: jdlrobson: can you take a look on https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm/1628/console -> i ran make tests before i uploaded the ps to review, but there wasn't these erros. Now the question is: why? Is there any difference i miss? :(
[18:27:25] <jdlrobson>	 FlorianSW: did you run `make jscs` ?
[18:27:40] <jdlrobson>	 these are all jscs errors
[18:27:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow)
[18:28:08] <FlorianSW>	 not manually, i thought it's included in make tests? :o
[18:28:21] <jdlrobson>	 mmm. try running `make installhooks`
[18:28:34] <jdlrobson>	 you have to run it separately or use the hook
[18:28:41] <jdlrobson>	 make tests just does qunit
[18:29:15] <FlorianSW>	 oh, yeah, i see, damn. Thanks for pointing it out .)
[18:29:19] <jdlrobson>	 kaldari: so we need to check https://gerrit.wikimedia.org/r/#/c/183059/ fixes the VE problem and swat deploy it
[18:29:19] <FlorianSW>	 * :)
[18:29:30] <jdlrobson>	 for RoanKattouw who is going to sleep quite rightly
[18:29:34] <jdlrobson>	 since it is past 1am
[18:31:33] <kaldari>	 will do
[18:32:07] <rmoen>	 I'm about to abandon vagrant for a development environment.  Perhaps for testing.  But for dev it is hideously slow.  
[18:32:28] <rmoen>	 anyone else feel the same way? 
[18:33:18] <grrrit-wm>	 (03PS3) 10Bmansurov: Make WikiGrok Roulette preload the next page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 
[18:34:00] <phuedx>	 nope, but then i really dislike modifying my base system
[18:34:07] <phuedx>	 rmoen ^
[18:34:25] <phuedx>	 i'll take the perf hit for tidiness 
[18:34:26] <rmoen>	 Testing every feature in alpha/beta/stable/ before and after a patch makes a simple task a cumbersome one
[18:34:37] <grrrit-wm>	 (03PS4) 10Jhernandez: WIP: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[18:34:49] <rmoen>	 phuedx: i'm not keen on modifying my base system either
[18:35:03] <grrrit-wm>	 (03CR) 10Jhernandez: "maybe fixed phplint errors?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[18:35:13] <rmoen>	 i usually use vm of ubuntu server
[18:36:05] <jdlrobson>	 rmoen: why are you testing in all 3? Just test in stable to check nothing breaks and the one the feature is aimed at
[18:36:20] <jdlrobson>	 stable is the only one we really need to keep stable :)
[18:36:40] <RoanKattouw>	 kaldari, jdlrobson: Well, it's not 1am just yet, I'll be around for a few more hours. But it will be 1am when the SWAT starts (4pm PST) so I can't be the contact person on the deployments page for this
[18:36:49] <rmoen>	 jdlrobson: sorry didn't mean to imply that i'm always testing in all three, but sometimes I do and its crippling
[18:37:01] <grrrit-wm>	 (03PS1) 10Dbrant: Don't duplicate history entries; instead, move them to top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183064 
[18:42:38] <joakino>	 rmoen: set up a docker image with all installed and pass it around? :D
[18:42:56] <rmoen>	 joakino: that's a good idea
[18:42:59] <joakino>	 git like filesystem upgrades
[18:43:30] <joakino>	 rmoen: should be doable by somebody who has experience doing manually what mediawiki vagrant does, but probably pretty cumbersome
[18:43:31] <rmoen>	 I will try that tonight
[18:43:33] <grrrit-wm>	 (03PS3) 10Jdlrobson: Don't show duplicate messages in LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183028 (owner: 10Florianschmidtwelzow)
[18:44:25] <joakino>	 hey yall i'm trying to get to run make phplint locally but i have to set up codesniffer but http://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer is not of much help
[18:44:37] <joakino>	 any ideas? do i have to run it from the vagrant vm?
[18:45:23] <phuedx>	 rmoen, jdlrobson: vagrant should make it as simple as changing the vm provider
[18:45:28] <phuedx>	 … to use docker rather than virtualbox
[18:47:09] <joakino>	 i'm looking forward to the mediawiki vagrant session in a few weeks
[18:47:36] <grrrit-wm>	 (03PS12) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 
[18:47:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Don't show duplicate messages in LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183028 (owner: 10Florianschmidtwelzow)
[18:47:56] <rmoen>	 http://localhost:8080/w/load.php?debug=false&lang=en&modules=mediawiki.ui.button%2Cicon%7Cmobile.pagelist.styles%7Cskins.minerva.alpha.styles%7Cskins.minerva.chrome.styles%7Cskins.minerva.content.styles%7Cskins.minerva.content.styles.beta%7Cskins.minerva.drawers.styles%7Cskins.minerva.icons.images%2Cstyles%7Cskins.minerva.tablet.styles%7Cskins.minerva.tablet.styles.beta&only=styles&skin=minerva&target=mobile&*  Takes 33 s
[18:47:57] <rmoen>	 econds to load.  ;/
[18:48:07] <grrrit-wm>	 (03PS4) 10Bmansurov: Make WikiGrok Roulette preload the next page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 
[18:48:17] <jdlrobson>	 rmoen: that sounds like the issue i had...
[18:48:22] <jdlrobson>	 did you update core recently?
[18:48:33] <rmoen>	 I've done a complete update yesterday
[18:48:39] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Use SkinMinerva::$mobileContext instead of MobileContext::singleton() (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow)
[18:48:59] <rmoen>	 jdlrobson: how did you fix it? 
[18:49:05] <jdlrobson>	 rmoen: https://phabricator.wikimedia.org/T78733
[18:49:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't show duplicate messages in LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183028 (owner: 10Florianschmidtwelzow)
[18:50:39] <jdlrobson>	 rmoen: mine is still broken
[18:50:44] <jdlrobson>	 gonna have another investigation now
[18:51:58] <rmoen>	 jdlrobson: so its cssjanus 1.1.1 ? 
[18:52:33] <jdlrobson>	 i still haven't identified the exact commit :/
[18:53:29] <jdlrobson>	 rmoen: i suspect https://gerrit.wikimedia.org/r/#/c/175485/ though
[18:53:34] <mhurd>	 brion: have a sec?
[18:55:53] <FlorianSW>	 jdlrobson: if this commit is missing you should see a fatal error exception in every less resource delivered through resourceloader iirc
[18:56:06] <jdlrobson>	 FlorianSW: ?
[18:56:35] <rmoen>	 jdlrobson: hmm yeah reverting that commit, reduces that load to 3 seconds
[18:56:46] <FlorianSW>	 you wrote, that your local mw is broken?
[18:57:08] <FlorianSW>	 and i thought you mean, that styles doesn't work anymore
[18:58:27] <grrrit-wm>	 (03PS2) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 
[18:58:44] <grrrit-wm>	 (03PS2) 10Phuedx: Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 
[18:59:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov)
[19:00:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[19:01:18] <Maryana>	 dbrant: kaldari - meeting time :)
[19:01:58] <grrrit-wm>	 (03PS3) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 
[19:02:19] <moizsyed>	 bearND: hey
[19:02:30] <bearND>	 moizsyed: hey
[19:03:05] <moizsyed>	 bearND: we need to add dr0ptp4kt to our meeting for tweet-a-fact
[19:03:30] <bearND>	 moizsyed: ok, will add him
[19:03:30] <grrrit-wm>	 (03PS3) 10Phuedx: Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 
[19:03:42] <moizsyed>	 bearND: hes not available for that time slow tho
[19:04:29] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] Hygiene: Make _hasChanged public [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183059 (owner: 10Alex Monk)
[19:04:57] <bearND>	 moizsyed: are you ok with 2:30?
[19:06:32] <phuedx>	 g'night folks
[19:06:41] <jdlrobson>	 rmoen: to debug - switch lessphp to 0.4.0 in composer.json, then vagrant ssh
[19:06:46] <jdlrobson>	 and composer update
[19:06:46] <joakino>	 i'm heading out, have a couple of hours car trip home
[19:06:51] <joakino>	 gnight all
[19:06:57] <jdlrobson>	 then debug the less issue - i susspect that's the issue
[19:07:00] <rmoen>	 night
[19:07:50] <rmoen>	 jdlrobson: i suspect you are correct as reverting https://gerrit.wikimedia.org/r/#/c/175485/ resolved the loading issue
[19:07:59] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[19:08:16] <jdlrobson>	 rmoen: kill ui.less
[19:08:54] <moizsyed>	 bearND: yeah that works, thanks!
[19:09:23] <bearND>	 moizsyed: cool. updated invitation
[19:09:50] <jdlrobson>	 i reverted back to 0.5.0 and lag gone
[19:09:51] <jdlrobson>	 weird
[19:11:37] <jdlrobson>	 rmoen: on master try the steps in last comment https://phabricator.wikimedia.org/T78733
[19:11:52] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 031] Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[19:14:09] <grrrit-wm>	 (03PS2) 10Robmoen: wip: Fix for header covering edit pencil in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181123 
[19:14:14] <rmoen>	 jdlrobson: can you think of any reason why skins.minerva.alpha.styles are not overriding ? in the above patch ^^ 
[19:14:54] <rmoen>	 SkinStyles appear to be loading correctly, i've even tried reversing the order
[19:16:16] <jdlrobson>	 if it's in SkinMinervaAlpha::getSkinStyles() it should be loading
[19:16:22] <jdlrobson>	 if it's not you have a less error somewhere
[19:16:28] <jdlrobson>	 check if http request includes it
[19:16:57] <rmoen>	 Yeah its loading.  Its just not overriding.  ( crossed out )
[19:18:30] <rmoen>	 specifically the border-right property on #page-actions
[19:19:56] <rmoen>	 jdlrobson: ok i got it.. that was silly
[19:25:12] <wikibugs>	 3Mobile-Web, MobileFrontend-stable: Login form duplicate messages in stable when directly visit Special:EditWatchlist whilst anon - https://phabricator.wikimedia.org/T73771#957931 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson Thanks @Florian !
[19:50:09] <kaity>	 hey kristenlans
[19:50:40] <kaity>	 did the cards for image styling on tablet and other designerly stuff go back to the backlog?
[19:51:22] <kaity>	 oh nevermind found them on the next sprint!
[19:52:30] <kristenlans>	 kaity: correct :-)
[19:58:08] <grrrit-wm>	 (03PS3) 10Robmoen: Fix for header covering edit pencil in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181123 
[20:00:30] <rmoen>	 brb food
[20:05:58] <leila>	 hi Maryana. are we meeting?
[20:08:22] <Maryana>	 leila: yep. dario ran to get some lunch first
[20:08:38] <leila>	 hokay, I'll stick around then. thanks, Maryana
[20:08:40] <Maryana>	 i'll be there in a sec :)
[20:09:59] <wikibugs>	 3Mobile-Web, MobileFrontend-beta: Failed to load resource: the server responded with a status of 404 (Not Found) - https://phabricator.wikimedia.org/T85637#958024 (10Florian) a:3Florian
[20:14:26] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Hygiene: Load icons from correct place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183084 
[20:27:08] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] Always enable red links in alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[20:28:41] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 
[20:39:24] <Krinkle>	 paul Irish (Google Chrome communications) has some feedback regarding m.wikipedia.org in #wikimedia-dev
[20:41:25] <Krenair>	 <paul_irish> hiya. i work on the Chrome team and have collaborated with Krinkle in the past. We want to improve the experience for Chrome users accessing m.wikipedia.org and have some questions about the zero-rating on some mobile carriers
[20:41:29] <Krenair>	 <paul_irish> would love to make an email intro to someone on your side.. who's a good contact? :)
[20:44:53] <FlorianSW>	 Krenair: i think for wikipedia zero (i read out, that there are question about wp zero, not the mobile site itself?) the Wikipedia Zero team would be the best contact: https://www.mediawiki.org/wiki/Wikipedia_Zero
[20:45:26] <Krenair>	 yeah it's being handled, thanks FlorianSW 
[20:46:33] <FlorianSW>	 ok, great :)
[20:49:43] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Work in progress: new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 
[21:09:11] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "untested but looks good" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow)
[21:11:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Similar to the editor overlay the save button should appear disabled to be consistent with our over workflows." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[21:12:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "haven't tested and minor improvement suggestion" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[21:16:52] <wikibugs>	 3Mobile-Web, MobileFrontend-alpha: Wikidata Infobox should properly format dates - https://phabricator.wikimedia.org/T85960#958208 (10Jdlrobson) 3NEW
[21:18:28] <grrrit-wm>	 (03CR) 10Bmansurov: [C: 032] Hygiene: Load icons from correct place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183084 (owner: 10Florianschmidtwelzow)
[21:18:42] <wikibugs>	 3MediaWiki-Special-pages, MobileFrontend-Feature-requests: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#958214 (10Jdlrobson)
[21:19:59] <wikibugs>	 3Mobile-Web, MobileFrontend-beta: "center" does not center non-thumb image on tablets - https://phabricator.wikimedia.org/T76945#958219 (10Jdlrobson)
[21:20:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Load icons from correct place [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183084 (owner: 10Florianschmidtwelzow)
[21:23:19] <Deskana>	 dbrant, bearND: How's it going, gentlemen? Need anything from me?
[21:24:00] <bearND>	 Deskana: good. Don't need anything atm. But thanks for asking.
[21:24:02] <dbrant>	 Deskana: not presently; just getting back in the groove.
[21:25:25] <Deskana>	 Excellent.
[21:26:21] <wikibugs>	 3Mobile-Web, MobileFrontend-beta: Failed to load resource: the server responded with a status of 404 (Not Found) - https://phabricator.wikimedia.org/T85637#958233 (10Jdlrobson) 5Open>3Resolved Although fixed @Florian can you do a follow up? The reason this broke was that the icons module didn't expect anythi...
[21:26:38] <grrrit-wm>	 (03CR) 10Jdlrobson: "Although fixed @Florian can you do a follow up? The reason this broke was that the icons module didn't expect anything else to use it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183084 (owner: 10Florianschmidtwelzow)
[21:28:01] <grrrit-wm>	 (03PS4) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 
[21:30:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen)
[21:32:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix for header covering edit pencil in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181123 (owner: 10Robmoen)
[21:33:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix for header covering edit pencil in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181123 (owner: 10Robmoen)
[21:34:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Seems kinda weird having a RedLinksTest.php file no?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx)
[21:35:17] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "??" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[21:35:40] <jdlrobson>	 MaxSem: https://gerrit.wikimedia.org/r/181123
[21:35:45] <jdlrobson>	 ignore
[21:35:46] <jdlrobson>	 MaxSem:  https://gerrit.wikimedia.org/r/183038
[21:36:00] <jdlrobson>	 MaxSem: can you take a look at https://gerrit.wikimedia.org/r/183038
[21:37:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Ignore. For some reason I have 2 repositories on my local machine so I wasn't seeing what this looked like. Sorry about that!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[21:39:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Disable Save button on TalkSectionAddOverlay while no content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[21:43:08] <grrrit-wm>	 (03CR) 10Jdlrobson: WIP: Add Special:MobileCollections to alpha left nav (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[21:43:36] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Ah, nevermind :) Thanks for merging!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182396 (owner: 10Florianschmidtwelzow)
[21:46:04] <grrrit-wm>	 (03PS1) 10Florianschmidtwelzow: Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 
[21:46:47] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Sure :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183084 (owner: 10Florianschmidtwelzow)
[21:48:07] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow)
[21:50:22] <grrrit-wm>	 (03PS10) 10Florianschmidtwelzow: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 
[21:51:49] <grrrit-wm>	 (03CR) 10MZMcBride: "Special:UserProfile being discussed at <https://phabricator.wikimedia.org/T85929>." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182337 (owner: 10Jdlrobson)
[21:55:39] <wikibugs>	 3MediaWiki-Special-pages, MobileFrontend-Feature-requests: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#958272 (10MZMcBride)
[21:56:12] <wikibugs>	 3MediaWiki-Special-pages, MobileFrontend-Feature-requests: Special:UserProfile shouldn't live in MobileFrontend - https://phabricator.wikimedia.org/T85929#957550 (10MZMcBride) {T50667} is related.
[21:59:01] <kaldari>	 doesn’t look like that new patch fixes the VE problem.
[21:59:02] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: WIP: Add Special:MobileCollections to alpha left nav (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[21:59:27] <kaldari>	 jdlrobson: ^
[22:03:43] <kaldari>	 jdlrobson: hmm, actually maybe it does. Seems to be working on beta labs, but my local instance is still broken….
[22:04:24] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-2] "For all that is holy, pleasepleaseplease let's not turn MobileFrontend into a god repository." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson)
[22:05:17] <kaldari>	 jdlrobson: nevermind. I had to do a submodule update in VE for it to work :P
[22:06:04] <dr0ptp4kt>	 dbrant: bearND - one/both of you guys able to spend 30-60 minutes friday to go over the current design and implementation of eventlogging in the android app? hoping to verify good conformance on approach as more eventlogging things are added to the ios app
[22:07:50] <dbrant>	 dr0ptp4kt: sure, anytime after the prioritization mtg
[22:08:05] <dr0ptp4kt>	 dbrant: thx
[22:15:43] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "A/B test bucketing shouldn't be part of EventLogging, IMO. We might have A/B tests that don't even use EventLogging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson)
[22:26:07] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson)
[22:28:40] <grrrit-wm>	 (03CR) 10Bmansurov: Refactor: Move position fixed emulation / viewport classes to skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson)
[22:29:34] <flyingclimber>	 dbrant: still waiting on hangouts ...
[22:37:55] <kristenlans>	 Maryana or MaxSem: do you happen to have Jon Robson in your line of sight?
[22:38:27] <Maryana>	 kristenlans: sadly not :(
[22:38:29] <MaxSem>	 nowpe
[22:42:58] <jdlrobson>	 kristenlans: got sidetracked
[22:43:36] <kristenlans>	 jdlrobson: by guy with the good coffee? 😜
[22:46:18] <grrrit-wm>	 (03CR) 10Kaldari: Refactor: Move position fixed emulation / viewport classes to skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson)
[22:47:13] <wikibugs>	 3Mobile-Web, MobileFrontend-alpha: Overlaycontent overlaps Close button in Overlays (alpha) - https://phabricator.wikimedia.org/T85647#958375 (10bmansurov) Hi @Florian, how can I reproduce it? I don't see it on master. May it be related to browser cache?
[23:24:48] <grrrit-wm>	 (03PS5) 10Robmoen: Scrollable reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 
[23:29:40] <leila>	 hi kaldari. 
[23:29:58] <kaldari>	 leila: hello!
[23:29:58] <leila>	 can you remind me how many pages we will be showing WikiGrok on when it goes live next week?
[23:31:30] <Deskana>	 Maryana: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals/Q3
[23:31:37] <kaldari>	 leila: hmm, good question. I honestly don’t remember, but I can look it up in the database in a little while.
[23:32:09] <leila>	 I'll look it up then, don't worry. I'll ping you if I can't find it kaldari. thanks. 
[23:32:38] <dr0ptp4kt>	 moizsyed: forgot to get the app names - which strong apps on iOS have the extended text selection context menu pattern you'd recommend?
[23:34:10] <moizsyed_>	 dr0ptp4kt: Instapaper has "highlight"
[23:34:10] <dr0ptp4kt>	 moizsyed_: gotta change connection. brb
[23:34:20] <dr0ptp4kt>	 moizsyed_: right on. brb
[23:35:48] <dr0ptp4kt>	 moizsyed_: i'm back, in case you have more
[23:35:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (owner: 10Florianschmidtwelzow)
[23:36:15] <dr0ptp4kt>	 moizsyed_: but one will do
[23:42:56] <bmansurov>	 kaldari: hey, I'm trying to make my local wiki multilingual and was wondering whether the translate extension is what I need. Do you know?
[23:44:58] <kaldari>	 bmansurov: What do you mean by making it multilingual? You can change the language in LocalSettings.php or with uselang=XX. There isn’t really a way to make a wiki truly multilingual though.
[23:45:22] <bmansurov>	 kaldari: I something like https://m.mediawiki.org/wiki/Bugzilla/zh#/languages where zh is the language
[23:45:32] <kaldari>	 one sec...
[23:47:33] <kaldari>	 bmansurov: ah, that’s the interlanguage links. There are two ways you can do that....
[23:51:01] <kaldari>	 bmansurov: You can either set up multiple wikis on your local machine, each with a different language, or you can link your pages to pages on other MediaWiki wikis, but in either case, it’s still one language per wiki. The possible wikis you can interwiki-link to are defined in the interwiki table in the database (which you have to populate manually as if it were 1996). Then you create the interwiki links in the Wikitext of the page, e.g. 
[23:51:02] <kaldari>	 [[:piratetalk:Booty]]...
[23:51:54] <bmansurov>	 kaldari: thanks
[23:52:03] <kaldari>	 bmansurov: https://www.mediawiki.org/wiki/Manual:Interwiki and https://www.mediawiki.org/wiki/Manual:Interwiki_table
[23:52:38] <kaldari>	 bmansurov: You can also cheat by using https://www.mediawiki.org/wiki/Extension:InterwikiMap
[23:52:41] <bmansurov>	  👍
[23:53:25] <Deskana>	 piratetalk.wikimedia.org: This webpage is not available
[23:53:26] <Deskana>	 :(
[23:53:46] <kaldari>	 Deskana: time for an incubator proposal!
[23:53:54] <Deskana>	 Yarrrr
[23:54:15] <Deskana>	 en-pa - Pirate English
[23:54:22] <Deskana>	 (Does it already have a language code?)
[23:55:23] <grrrit-wm>	 (03CR) 10Jdlrobson: Refactor: Move position fixed emulation / viewport classes to skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson)
[23:55:42] <jdlrobson>	 is jenkins backed up again?
[23:56:19] <Deskana>	 Mobile web peeps
[23:56:21] <kaldari>	 Deskana: Looks like it used to have an article, but someone deleted it!! https://en.wikipedia.org/wiki/Pirate_talk
[23:56:23] <Deskana>	 There's a bug report here: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Watchlist_on_Wikipedia_for_Android_mobile_phones_is_no_longer_under_the_top_right_left_pull_down_menu
[23:56:37] <Deskana>	 This person says the watchlist is missing from their menu.