[00:03:07] some js error? [00:24:15] moizsyed_: can you please install the trello app on your phone if you haven't? I always feel like you never get notifications from me [00:24:28] jdlrobson: oh noo [00:24:32] jdlrobson: what do you need? [00:25:48] jdlrobson: ? [00:26:15] jdlrobson: Do you remember why https://gerrit.wikimedia.org/r/#/c/177092/ was made? An issue or a particular page that was rendering wrong? [00:27:49] jdlrobson: answered your question on trello [00:28:52] 3MobileFrontend-alpha, Mobile-Web: Overlaycontent overlaps Close button in Overlays (alpha) - https://phabricator.wikimedia.org/T85647#958589 (10Florian) 5Open>3Invalid a:3Florian Hmm, can't reproduce anymore :/ Maybe i had an old git commit or something else (i'm sure i cleared browser cache). [00:28:55] moizsyed_: just a general comment - i feel like i poke you a lot and never get responses :) [00:29:32] prtksxna: errr rmoen do you remember? [00:29:42] jdlrobson: alright, i'll try to be more responsive [00:29:48] it makes sense though prtksxna [00:30:01] jdlrobson rmoen: I can't see any example on the styleguide and it caused https://phabricator.wikimedia.org/T85778 [00:30:51] prtksxna: looking [00:31:02] Thanks rmoen! [00:32:24] prtksxna: yes, it was made because the icon image wouldn't always be inline with the element. Is this causing an issue? [00:33:15] rmoen: Where can I see an example of this? Yup, the one that I just linked to [00:36:37] dr0ptp4kt: have a sec? [00:36:43] mhurd: yes [00:38:28] prtksxna: I cannot reproduce the example... would have been helpful if I included it in the commit message [00:38:50] rmoen: :( [00:38:54] prtksxna: I think it can be reverted [00:39:45] prtksxna: I think it has to do with absolutely positioned elements with top 0 [00:40:32] prtksxna: do you want me to make a patch to revert? [00:42:49] rmoen: I'll do that [00:43:10] prtksxna: thanks [00:51:17] (03CR) 10Kaldari: [C: 032] Hygiene: Make _hasChanged public [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183059 (owner: 10Alex Monk) [00:53:23] (03Merged) 10jenkins-bot: Hygiene: Make _hasChanged public [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183059 (owner: 10Alex Monk) [01:04:21] Deskana: on iOS, the equivalent of share intent lets you know if the share completed (boolean) as well as the type of share, a string value (e.g., @"com.apple.UIKit.activity.PostToTwitter") [01:07:07] (03PS1) 10MaxSem: Fix campaigns picking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183179 [01:08:13] kaldari, we need ^^^ tomorrow [01:18:25] (03CR) 10Kaldari: [C: 032] Fix campaigns picking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183179 (owner: 10MaxSem) [01:19:04] (03Merged) 10jenkins-bot: Fix campaigns picking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183179 (owner: 10MaxSem) [01:25:24] jdlrobso_, ryasmeen: VE is fixed on 1.25wmf13 now. Just tested it on test.wiki. [01:32:24] (03PS1) 10MaxSem: Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 [01:32:53] (03PS5) 10Jdlrobson: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 [01:34:01] (03PS1) 10Kaldari: Fix campaigns picking [extensions/WikiGrok] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183187 [01:34:51] (03CR) 10jenkins-bot: [V: 04-1] WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [01:35:28] (03CR) 10Kaldari: [C: 032] Fix campaigns picking [extensions/WikiGrok] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183187 (owner: 10Kaldari) [01:49:17] (03Merged) 10jenkins-bot: Fix campaigns picking [extensions/WikiGrok] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183187 (owner: 10Kaldari) [01:56:53] can i just say how much i love going to trello and seeing david bowie's face? [01:56:57] because it is a lot [02:02:50] Deskana: https://gerrit.wikimedia.org/r/#/c/180895/ [02:13:31] (03PS2) 10MaxSem: Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 [03:23:16] (03PS9) 10BearND: Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 [03:23:19] (03PS9) 10BearND: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant) [03:23:20] (03PS6) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 [03:23:23] (03PS10) 10BearND: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [04:01:04] greets [04:01:57] is wikibugs a bot for reporting issues? was looking around the wiki mobile engineering site and came across this and twitter.. thought [04:02:06] i'd check here first to see if anyone was alive heh [04:02:55] nvm, guess I missed it heh [04:14:45] CyberNigma: wikibugs just reports issues. It's write only. [04:16:27] gotcha thx.. I missed the piece directing me to phabricator so I went over there to report a bug/create task... [04:17:38] was setting up a new win8 computer for someone and swapped the language over to Filipino and realized the app went to the wrong site (there is no fil.wikipedia.org as they opted to use tl.wikipedia.org which is Tagalog, the common language over there). so wanted to report it... doing so now :-) [04:18:30] CyberNigma: Android or iOS? [04:18:35] Win8 [04:18:53] technically under Unofficial-Apps-Wikipedia-or-Windows-8 [04:18:56] CyberNigma: not much going on with Win8 app [04:19:09] yeah, from the project name that's what I guessed [04:20:10] but if you're using it, that's cool. I guess if a lot of people are using it then it may get some support in the future [04:20:11] I was looking to see if there were any situations similar in other languages where they may have redirected one url to another where there are two languages used in the same manner.. fil.wikipedia.org->tl.wikipedia.org, but didn't see any.. most cases it would be en-us or similar [04:20:37] I installed it so she could use it.. I typically use a browser on my desktop :-) [04:21:35] it's an odd situation. Filipino is their official language but it's almost identical to the common language of Tagalog.. Win8 though uses FIL and I guess passes that along.. look at the gitrepo, but haven't seen what the push policy is there yet [04:22:05] probably something MSoft should fix actually.. nobody really looks for Filipino.. they typically look for Tagalog heh... [04:23:02] I just looked at the Android app: there is no Filipino, but there is Tagalog [04:23:18] lol that's interesting [04:23:59] I haven't looked at the code, but it's probable that the app queries the OS instead of something like a mapping.. and android may push TL instead of FIL [04:24:32] if I have time when I get back this weekend I'll take a look.. perhaps throwing a snippet of code in the comments that fixes it will convince someone to take a look at it :-) [04:25:02] are you using the Read In.. function in the android app? [04:25:32] to display languages? for the win8 one it just appears to be configured in the OS, not a separate language setting in the app. [04:26:13] and Read In kills it in win8 heh [04:27:44] on Android we have a list of supported wiki languages (~287 or so). In the Android app there are actually two places you can change the language: in the nav drawer "More" menu and in the upper right (overflow) "Read in other languages" [04:28:50] the Wiki language in the More menu sets the search language, and the Read in other languages gives all the languages that the current page is available in [04:28:50] ahh gotcha.. guess I couldv'e just installed it on a device here and looked at it to compare heh.. don't have the tablet sitting with me that has it on android.. [04:29:34] that may be why the Read In is causing it to exit on the win8 version.. it thinks it is offline because it cannot find fil.wikipedia.org and Read In probably isn't expecting that [04:29:58] I've got an ios version around here somewhere.. probably similar to the android one though [04:30:36] iOS is roughly similar to Android but not the same code [04:31:10] oh yeah, definitely not.. [04:31:28] well, the Read in functionality should be very similar though [04:37:43] yeah looking at the metro code it literally just grabs the language from the OS, cleans it, and builds the URL.. [04:39:40] 3VisualEditor, Editing, VisualEditor-MediaWiki-Mobile, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#958787 (10Ryasmeen) Verified the fix in Betalabs and test2 [04:40:04] now I see what you meant :-) [04:40:10] 3VisualEditor, Editing, VisualEditor-MediaWiki-Mobile, MobileFrontend-beta: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#958789 (10Ryasmeen) 5Open>3Resolved [04:46:47] thanks for the input and take care.. we'll see where it goes.. [05:43:58] (03PS7) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 [06:53:00] (03PS8) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 [06:53:57] (03PS9) 10BearND: Create image using text snippet [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 [10:12:57] yo [10:16:55] good morning! [10:19:32] (03CR) 10Phuedx: "I agree that it's a behaviour test rather than a unit test and perhaps should be organised differently. I shall have a thinky-think." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [10:19:47] hey joakino [10:19:50] how're you? [10:20:15] better, almost recovered from the cold completely [10:20:18] and you phuedx [10:20:27] really tired :/ [10:20:50] i slept from 9 pm to 8:30 am [10:20:57] which hasn't happened in a /long/ time [10:26:07] phuedx: you might consider having a nap to recover [10:26:30] hashar: on it! [10:26:33] zZzZ [10:27:33] it's a nap or code review [10:27:35] hrrm [10:27:42] nap! [10:27:55] whenever you wake up you will be much more efficient at reviewing code :D [10:29:10] i might need to take a nap to recover from my nap [10:31:51] The meta-nap! [10:32:38] * metanap lures phuedx [10:32:49] so… sleepy… [10:32:54] must… [10:32:59] resist… [10:33:04] the metanap… [10:33:25] :P [10:35:30] joakino: is there really only one meeting tonight? (standup) [10:36:26] phuedx: i don't have any more marked [10:36:34] woo [10:36:35] 😁 [10:36:45] bouldering toniiiiiiitttaaa! [10:37:39] cool [10:50:33] (03PS5) 10Phuedx: Make WikiGrok Roulette preload the next page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 (owner: 10Bmansurov) [10:51:03] joakino: i'm planning on going bouldering when i'm in sf [10:51:07] if you're at all interested [10:54:10] (03CR) 10Phuedx: Make WikiGrok Roulette preload the next page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 (owner: 10Bmansurov) [10:54:43] (03CR) 10Phuedx: Make WikiGrok Roulette preload the next page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 (owner: 10Bmansurov) [10:54:59] (03CR) 10Phuedx: [C: 032] "Nice work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 (owner: 10Bmansurov) [10:57:47] (03Merged) 10jenkins-bot: Make WikiGrok Roulette preload the next page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182969 (owner: 10Bmansurov) [10:59:28] phuedx: i've just tried on mountain a couple of times, so i don't have even the shoes [10:59:34] do they rent them? [11:00:14] yup [11:03:05] phuedx: cool, then i can go with you :D [11:03:10] \o/ [11:05:44] coffee time [11:15:25] phuedx: for bouldering reach out to Gabriel Wicke / Tomasz Finc [11:15:33] phuedx: they boulder twice per week iirc [11:26:20] on the one hand, i am happy that i have coffee [11:26:27] on the other, i am sad that i've run out of those beans [11:26:30] they were delish [11:49:40] (03CR) 10Phuedx: [C: 04-1] "The code itself could do with tidying up and the tests aren't exhaustive." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [12:10:26] (03CR) 10Phuedx: [C: 04-1] Maintenance script to refresh old versions of questions (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [12:13:06] (03PS3) 10Phuedx: Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [12:20:14] (03CR) 10Phuedx: [C: 031] "I've run this locally and saw what I expected: the wikigrok_questions table is empty but there's nothing in it because I don't have a Wiki" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [12:26:33] (03CR) 10Jhernandez: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [12:36:34] (03CR) 10Jhernandez: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [13:11:57] (03PS6) 10Jhernandez: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [13:13:07] (03CR) 10Jhernandez: "@jdlrobson I think the views / models separation makes sense and seems very clear to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [13:13:40] (03CR) 10jenkins-bot: [V: 04-1] WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [13:31:45] (03CR) 10Jhernandez: "It says there is a lint error at includes/models/MobileCollection.php:40 but I can't reproduce locally, php -l includes/models/MobileColle" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [14:27:46] (03CR) 10Florianschmidtwelzow: [C: 04-1] WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [14:28:03] joakino: ^ [14:47:03] yo [14:47:06] back from baby thing [14:47:18] also, a little bit edgy from drinking too much coffee [15:14:24] thx FlorianSW [15:14:39] with which versions of php are we compatible? [15:17:39] joakino: https://www.mediawiki.org/wiki/Compatibility#PHP :) [15:17:56] that's why jenkins test against php 5.3 iirc [15:19:05] FlorianSW: 👍👍 [15:20:03] :) [15:22:49] (03PS7) 10Jhernandez: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [15:24:01] FlorianSW: ^ https://gerrit.wikimedia.org/r/#/c/182984/7/includes/models/MobileCollection.php [15:24:06] like that? [15:25:06] joakino: yap :) if you only need query-pages, you could overwrite $data instead of using pagesData as a new var [15:26:02] FlorianSW: i'm against reusing/reassigning variables, but yeah, wouldn't do much harm here [15:27:55] joakino: yes, normally it's more confusing to reassign vars, but i think here it wouldn't be a big deal [15:38:21] 3MobileFrontend-Feature-requests: Document JavaScript code in javascripts/common - https://phabricator.wikimedia.org/T46127#959661 (10Aklapper) [15:38:24] 3MobileFrontend-Feature-requests: Document $wgMFAnonymousEditing better - https://phabricator.wikimedia.org/T62567#959662 (10Aklapper) [15:51:10] 3MobileFrontend-beta, VisualEditor, Editing, VisualEditor-MediaWiki-Mobile: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#959797 (10Jdforrester-WMF) [16:43:29] (03CR) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [16:50:35] (03PS2) 10Jdlrobson: Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [16:50:41] (03CR) 10Jdlrobson: [C: 031] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [16:50:46] (03CR) 10Jdlrobson: [C: 032] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [16:51:17] (03PS9) 10Jdlrobson: Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 [16:51:25] (03CR) 10Jdlrobson: [C: 032] Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [16:51:40] (03PS3) 10Jdlrobson: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 [16:52:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [16:53:24] (03CR) 10jenkins-bot: [V: 04-1] Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [16:55:29] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [17:07:48] (03CR) 10Phuedx: Make WikiGrok v B support multiple campaigns at the same time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [17:23:32] (03PS1) 10Dbrant: Full swipeable image gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 [17:24:30] heya dbrant. What do you think about the share a fact patches? [17:26:49] bearND: hey!! looking really good. And I like the refactor! Does this include the stuff you discussed with Moiz? [17:27:10] bearND, dbrant https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8059793 [17:27:46] halfak: these days mhurd is really the boulder king [17:28:09] eh, hashar & phuedx [17:28:37] dbrant: yes, it includes most of the stuff discussed. One thing that we discussed is left but I'm not sure if that's feasible. Basically, can we reuse the exact image from the lead image (same cropping, same title, and description overlayed). Right know I'm doing my own layout. [17:28:51] gwicke: ta [17:30:27] Krenair: hmm, looks like someone got to selectively removed a permission. I guess we should catch the SecurityException. [17:30:40] (cc: dbrant ^) [17:31:26] Deskana: no descriptions yet... [17:32:22] (03PS1) 10BearND: Use ic_message icon for share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183276 [17:33:42] dbrant: r u ok to merge the slew of share a fact patches? If so, I'll start merging yours. [17:34:46] bearND: I don't see why not! As before, we can iron out kinks afterwards. [17:35:34] dbrant: yeah, and with the refactor it's pretty much contained, and easy to disable if we need to [17:35:42] bearND: yep! [17:36:01] (03CR) 10BearND: [C: 032] Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant) [17:36:03] Deskana: hmm not seeing the descriptions patch here: https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf14 [17:36:20] (03Merged) 10jenkins-bot: Add custom menu item to WebView context mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181081 (owner: 10Dbrant) [17:36:36] (03CR) 10BearND: [C: 032] Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [17:36:56] (03Merged) 10jenkins-bot: Get selected text from the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181261 (owner: 10Dbrant) [17:38:19] (03CR) 10Dbrant: [C: 032] Share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/181223 (owner: 10BearND) [17:47:52] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [17:55:28] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [17:55:33] * jdlrobson waves [17:55:52] (03CR) 10Jdlrobson: [C: 032] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [17:57:08] (03Abandoned) 10Jhernandez: WIP: Enable wikigrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180446 (owner: 10Jhernandez) [17:57:30] (03Abandoned) 10Jhernandez: WIP: Style wikigrok for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180447 (owner: 10Jhernandez) [17:57:51] (03PS3) 10Jdlrobson: Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [17:57:57] (03CR) 10Jdlrobson: [C: 032] Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [17:58:25] (03Abandoned) 10Jhernandez: WIP: Implement a view that features an event map for declarative event definitions. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180834 (owner: 10Jhernandez) [17:58:37] hi jdlrobson [17:58:47] hey hey [17:59:12] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [17:59:14] (03CR) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [17:59:26] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [17:59:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [18:00:00] hey jdlrobson what did maxsem mean about turning mf into a god repository? [18:00:31] in here https://gerrit.wikimedia.org/r/#/c/182984/ [18:00:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [18:00:47] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [18:02:26] (03CR) 10Jdlrobson: [C: 04-1] Make WikiGrok v B support multiple campaigns at the same time (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [18:03:48] (03CR) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [18:03:59] looks like our qunit tests got broken some how [18:05:50] thats so weird, shouldnt jenkins have caught that? [18:06:42] wikigrok B [18:06:44] i think i know why [18:06:50] joakino_: there was probably a core change [18:07:14] yeh i got it [18:07:18] mw.config.get( 'wgArticlePath' ).replace [18:07:24] with that variable? [18:08:23] joakino_: fix on way [18:08:28] no [18:08:33] it's because QUnit got upgraded [18:09:13] jdlrobson: is there a link to changelog or relevant upgrade info? [18:09:56] https://github.com/jquery/qunit/blob/1.16.0/History.md [18:10:25] can anyone else contact gerrit? [18:11:49] phuedx: wfm [18:12:11] phuedx: same [18:12:20] poop [18:12:21] i'm so intrigued, why are my async tests broken xd [18:12:25] what did i do [18:14:53] hi kristenlans just FYI, you can track automated test builds at https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/ and https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/ [18:15:38] kristenlans: ...if you want. I usually check them Monday and/or Tuesday, and Jon looks at them, but the more eyes the better I think. [18:17:27] (03PS1) 10Jdlrobson: Don't cache strictEqual and deepEqual - causing errors with QUnit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183281 [18:17:33] ^ joakino_ weird [18:17:36] ^ phuedx also [18:17:42] let's get that merged asap [18:17:52] chrismcmahon: thanks for that I'll take a peek ^ [18:18:07] jdlrobson: i'm getting different output too when renaming setup to beforeEach and teardown to afterEach [18:18:09] what a mess [18:18:16] wha!? [18:18:43] phuedx: qunit tests are broknen in master because qunit upgrade [18:19:07] (probably) [18:19:21] phuedx: not sure why that was happening [18:19:27] ^ joakino_ try the patch does it fix for you? [18:19:33] ok, i understand that the tests are broken [18:19:36] but that appears to be the reason [18:19:38] but that fix seems… odd [18:19:47] phuedx: yeh i'm trying to think why that would happen [18:19:58] but the fix works.. [18:20:02] for me at least [18:20:22] 3Mobile-Apps, Wikipedia-App-Android-App: The mobile app should display hatnotes in article sections - https://phabricator.wikimedia.org/T85985#960186 (10Krenair) [18:20:31] (03PS4) 10Phuedx: Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 [18:20:38] kristenlans: and I'm always available to answer any questions about those builds and those tests [18:20:39] jdlrobson: let me update core, with my outdated one i'm getting wikigrok errors [18:20:49] * phuedx doesn't want to update core [18:21:02] * jdlrobson is investigating broken watchlist [18:21:44] jdlrobson: are you a-verifying? [18:21:51] (03CR) 10jenkins-bot: [V: 04-1] Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [18:22:26] * phuedx makes a note to recheck ^ when qunit is fix0red [18:23:00] phuedx: i suspect i broke this but don't understand how, and how it got merged :) [18:23:08] phuedx: watchlist is definitely broken [18:23:31] hrrrm [18:23:48] your changes to the watchlist got a lot of eyes [18:24:44] jdlrobson: your patch fixed a bunch of errors, but i'm some wikigrokdialogb errors remain [18:24:57] are you seeing those? [18:25:13] joakino_: nope. no errors yet [18:25:18] phuedx: seems related to page images [18:25:19] fix on way [18:25:25] did PageImages change recently? [18:25:49] git blame [18:25:56] also, git doesn't have a "praise" [18:26:07] git isn't a positive tool [18:27:00] (03CR) 10Jhernandez: [C: 032] "Black magic vodoo that works" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183281 (owner: 10Jdlrobson) [18:27:37] (03PS1) 10Jdlrobson: Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) [18:28:02] phuedx: add an alias to gitconfig praise=blame xD [18:28:26] far to much effort [18:28:32] also, i blame all of you anyway [18:28:51] <^d> `git config --global alias.praise blame` [18:28:52] (03Merged) 10jenkins-bot: Don't cache strictEqual and deepEqual - causing errors with QUnit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183281 (owner: 10Jdlrobson) [18:28:57] <^d> That's a fun one, actually [18:29:01] <^d> I'm going to add it to mine [18:29:29] (03PS11) 10Jdlrobson: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [18:29:34] (03PS4) 10Jdlrobson: Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [18:29:43] svn had "praise" and "blame" iirc [18:29:46] (03PS4) 10Jdlrobson: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 [18:29:53] (03PS2) 10Jdlrobson: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) [18:30:07] (03PS3) 10Jdlrobson: Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [18:30:14] (03CR) 10Jdlrobson: Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [18:30:18] (03CR) 10Jdlrobson: [C: 032] Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [18:30:35] jdlrobson: i don't see how that's different at first glance [18:30:38] https://gerrit.wikimedia.org/r/183282 [18:30:39] has it always been that way? [18:30:40] ^ phuedx [18:30:48] phuedx: you talking about that patch? [18:31:01] (03CR) 10jenkins-bot: [V: 04-1] Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) (owner: 10Jdlrobson) [18:31:06] oh wait, nm [18:31:11] (03PS2) 10Jdlrobson: Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) [18:31:16] it's a patch on what's already gone before [18:31:26] lol [18:31:40] "if there's no image, then it's not a page" [18:31:45] Deskana: this one? https://phabricator.wikimedia.org/T85985 [18:31:47] <- idiot [18:32:17] (03PS3) 10Jdlrobson: Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) [18:32:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [18:33:27] Deskana bearnd dbrant: https://trello.com/c/fh2bYVYd/19-bug-t85985-the-mobile-app-should-display-hatnotes-in-article-sections [18:33:30] phuedx, jdlrobson etc: with mf and core master, i'm getting broken qunit tests still https://gist.github.com/joakin/d6ee92f14d696d963534 [18:33:41] kristenlans: Deskana: since we haven't had time during recent standups for triaging (and the list is ever-growing), would you like to have a separate session to take care of those? [18:33:48] can you guys try QUNIT_DEBUG=true grunt qunit:all [18:34:05] joakino_: mmm not sure why mw.config.get( 'wgArticlePath' ) would not exist [18:34:06] dbrant that sounds like a very good idea :D [18:34:15] 3Mobile-Apps, Wikipedia-App-Android-App: The mobile app should display hatnotes in article sections - https://phabricator.wikimedia.org/T85985#960218 (10KLans_WMF) You can follow the progress of this bug here: https://trello.com/c/fh2bYVYd/19-bug-t85985-the-mobile-app-should-display-hatnotes-in-article-sections [18:34:28] dbrant I can set up a session [18:34:46] (03CR) 10jenkins-bot: [V: 04-1] Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) (owner: 10Jdlrobson) [18:34:46] kristenlans: great! [18:36:53] dbrant, kristenlans: Yes please! [18:37:15] (03CR) 10jenkins-bot: [V: 04-1] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [18:37:58] Deskana will you be filled with HANGER if I schedule it from 12-1 PT today? :D [18:38:22] kristenlans: I would very much prefer to avoid that, yes. You don't want to watch me eat my lunch. ;) [18:38:49] (03Merged) 10jenkins-bot: Hygiene: Don't use images/ in less code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183145 (https://phabricator.wikimedia.org/T85637) (owner: 10Florianschmidtwelzow) [18:39:11] Deskana OK, in that case we may have to wait until Friday [18:42:26] 3Wikipedia-App-Android-App: Unable to start activity ComponentInfo{org.wikipedia/org.wikipedia.page.PageActivity}: android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#960249 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8056615 - res... [18:42:47] 3Wikipedia-App-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#960250 (10Krenair) [18:43:05] (03PS4) 10Jdlrobson: Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) [18:43:19] (03CR) 10Jdlrobson: [C: 031] Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [18:43:32] (03CR) 10Jdlrobson: [C: 032] Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [18:43:40] (03CR) 10Jdlrobson: [C: 031] Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [18:43:46] (03CR) 10Jdlrobson: [C: 032] Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [18:44:01] (03PS5) 10Jdlrobson: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 [18:45:15] dbrant, bearND: My other question was... how do you guys feel about a production release on the 15th? [18:45:23] dbrant, bearND: Lead images, image viewer, and read more. [18:45:39] (03CR) 10Jdlrobson: "@kaldari Why would we have an A/B test without event logging. That seems very strange. Even so, currently the only thing using A/B testing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [18:45:55] (03PS10) 10Jdlrobson: Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 [18:46:01] (03CR) 10Jdlrobson: [C: 031] Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [18:46:01] Deskana: bearND: I would feel elated. [18:46:08] (03CR) 10Jdlrobson: [C: 032] Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [18:46:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [18:47:12] * Deskana goes to write the schemas. [18:48:28] (03PS6) 10Jdlrobson: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 [18:48:34] (03Merged) 10jenkins-bot: Hygiene: Use Config object for global variables in MinervaTemplate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181684 (owner: 10Florianschmidtwelzow) [18:48:36] (03Merged) 10jenkins-bot: Hygiene: Move Talk-related stuff to SkinMinervaBeta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183050 (owner: 10Florianschmidtwelzow) [18:48:38] (03Merged) 10jenkins-bot: Refactor: Move position fixed emulation / viewport classes to skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182291 (owner: 10Jdlrobson) [18:49:08] (03Abandoned) 10Jdlrobson: Apply mobile modifications inside minerva desktop skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178888 (owner: 10Jdlrobson) [18:49:37] 3Wikipedia-App-Android-App: Link to mobile Zero FAQ instead of desktop - https://phabricator.wikimedia.org/T85062#960306 (10dr0ptp4kt) a:5dr0ptp4kt>3None [18:49:54] (03Abandoned) 10Jdlrobson: Make mobile pages available on desktop regardless of styling implications [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178757 (owner: 10Jdlrobson) [18:50:05] java.io.FileNotFoundException: /data/data/org.wikipedia/files/styles.css: open failed: ENOSPC (No space left on device) [18:50:10] some of these exceptions are very weird [18:50:45] ENOSPC... so therefore throw FileNotFoundException? :/ [18:50:54] 3MobileFrontend-Feature-requests: Examine discoverability and usability of search on low-JS devices - https://phabricator.wikimedia.org/T66926#960324 (10dr0ptp4kt) [18:51:10] 3MobileFrontend-Feature-requests: Non-javascript based editing - https://phabricator.wikimedia.org/T66923#960326 (10dr0ptp4kt) [18:51:22] 3MobileFrontend-Feature-requests: Add button to "expand all" sections of a page (Mobile view) - https://phabricator.wikimedia.org/T47951#960330 (10dr0ptp4kt) [18:52:51] Maryana phuedx bmansurov kaldari: I was just going to ask if you guys wanted to take a spin through the rest of the bugs, but it looks like someone is triaging befre my very eyes! https://phabricator.wikimedia.org/project/board/67/ [18:53:03] yep, we are triaging :) [18:53:12] 👏 [18:53:18] we cleaned out the signoff column, too. just left things that need to be tested in prod today after the train goes out [18:53:37] hhhhawhhaaaaT!? yeeeah! [18:54:08] Deskana: dbrant: I think we should ready for prod release on jan 15 [18:54:19] lol at hhhhaw.... [18:55:34] (03PS4) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 [18:56:05] (03PS4) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 [18:56:10] kaldari Maryana: let's make sure https://gerrit.wikimedia.org/r/#/c/183282/ gets merged asap before the train leaves [18:56:22] or has it already left? [18:56:41] oh it's cut already feck [18:57:06] basdlkhasdfj [18:57:36] (03PS1) 10Brion VIBBER: Fix for broken deletion in view history list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183297 [18:59:15] (03CR) 10Phuedx: "… DAMN!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) (owner: 10Jdlrobson) [18:59:21] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [18:59:24] (03CR) 10Phuedx: [C: 032] Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) (owner: 10Jdlrobson) [18:59:32] sorry jdlrobson ^ [19:02:47] (03Merged) 10jenkins-bot: Fix mobile watchlist rendering when SpecialMobileEditWatchlist::images hook fails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183282 (https://phabricator.wikimedia.org/T86030) (owner: 10Jdlrobson) [19:03:56] gotta go get george to bed [19:10:32] (03CR) 10Bmansurov: Scrollable reference drawers (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [19:16:23] bearND: I have some comments on your final big tweet-a-fact patch; would you prefer to amend that patch, or have it merged and then make another patch to address any issues? [19:19:48] dbrant: depends on the comment. I can't see any yet. [19:20:47] dbrant: if it's about the white background variant in the design, Moiz told me and Adam that this was an early design, and is not needed [19:21:48] bearND: no, it's regarding the face offset; the images with faces don't seem to be aligned correctly [19:22:22] dbrant: Let's do that as a separate patch [19:22:25] (03PS1) 10Brion VIBBER: Fix for duplicated section/image info on refresh [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183302 [19:22:38] dbrant, bearND: Schema's done! https://meta.wikimedia.org/wiki/Schema:MobileWikiAppShareAFact [19:23:01] dbrant, bearND: The only "gotcha" in there is that Dario wants us to include the revid of the page the user is viewing, which is information that we don't currently collect. [19:23:21] brion: able to spare 5 minutes? [19:23:25] sure [19:23:32] dbrant, bearND: But, mobileview can actually give us that information. So we can either request it on every page load, or we can fire off a special request when someone taps share. [19:24:23] dbrant, bearND: We'd just need to add "revision" to the pageprops that we request to get it back through action=mobileview. [19:24:27] Deskana: if we can get the revid from mobileview, then it's not a problem [19:25:33] (03CR) 10Dbrant: [C: 032] "merging, with any remaining issues to be fixed in subsequent patch(es)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/182385 (owner: 10BearND) [19:25:34] kristenlans: can you rename https://trello.com/b/dJyJhmfS/mobile-web-readership-backlog to Collections backlog for my sanity [19:25:47] i keep clicking through to the wrong trello boards and it's driving me mad [19:27:00] Deskana: thanks for the schema! I agree, revid shouldn't be a problem [19:27:59] dbrant: do you have a list of issues for share a fact? Or some examples where the lead image is not properly adjusted for face detection? [19:28:17] bearND: yep! I'll send an email [19:34:44] (03CR) 10Dbrant: [C: 032] Use ic_message icon for share a fact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183276 (owner: 10BearND) [19:35:02] jdlrobson: will do. Also talked to wikigrok team abotu renaming mobile web boards to wikigrok. Thumbs up on that. [19:37:29] i'm heading out [19:37:35] have a nice day yall [19:38:09] (03PS2) 10Brion VIBBER: Fix for duplicated section/image info on refresh [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183302 [19:38:10] (03PS2) 10Brion VIBBER: Fix for broken deletion in view history list [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183297 [19:38:24] later joakino [19:40:35] (03PS1) 10Deskana: Add "?source=app" to the end of all share a fact URLs per Analytics. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183306 [19:40:50] DarTar: ^ [19:40:53] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183297 (owner: 10Brion VIBBER) [19:41:02] Deskana: awesome [19:41:14] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183302 (owner: 10Brion VIBBER) [19:42:29] Deskana: hmm is that the right way of appending parameters? [19:42:59] wondering about cases where other params would be passed [19:43:06] msg jdlrobson hey, just read your email about the RFC. one thing you and I didn't discuss, but Im curious about: are we committing to building desktop interface for this? [19:44:35] DarTar: For now it's fine IMO since we don't append any other parameters, so we can switch to a more robust way when we use more. But dbrant or bearND will tell me when they do code review. :) [19:45:35] Deskana: cool [19:47:37] bearND: got 2 minutes for batcave? [19:53:41] dbrant: bearND do you guys have an article you use for testing super long titles w/lead image styling or do you just fake a long title? [19:53:57] hey phuedx, do you need help setting up wikidata? [19:54:07] mhurd: protip -- prefix search for "lopado" [19:54:43] dbrant: omg [19:55:33] dbrant: i'll be there in a bit [20:02:50] dbrant: could you send me a screenshot of how that crazy long page title ends up looking on android? [20:02:54] (03Abandoned) 10Robmoen: Bind events only once in _fixIosHeader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/173468 (owner: 10Robmoen) [20:04:32] (03PS4) 10Robmoen: Small style tweaks to reference drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 [20:09:30] dbrant: saving the lopado article... ;) Amazing title [20:09:40] :D [20:10:14] dbrant: bearND it’s nutty! [20:11:20] dbrant, bearND: any plans to change the app icon? [20:12:36] Krenair: not anytime soon. [20:12:57] to make it more material design-y [20:13:06] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8058028 suggests it [20:15:11] Krenair: dbrant: would love to get a newer icon. Probably should send his email witht he proposed icon to violetto [20:17:31] Krenair: bearND: Sure, if the designers have time for it. It wouldn't be any work for us. [20:17:38] (03CR) 10Robmoen: "See response in PS2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen) [20:17:54] (03CR) 10Robmoen: Small style tweaks to reference drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178355 (owner: 10Robmoen) [20:28:23] lopado... sounds like an adventurous dish that dbrant would enjoy eating :P [20:29:11] MaxSem: Did your patch for having the descriptions in action=mobileview go live? [20:29:28] kristenlans: "a dish compounded of all kinds of dainties..." definitely up my alley. [20:29:46] MaxSem: It doesn't seem to be in the release notes. [20:29:57] lolwut? [20:30:10] what release notes? [20:30:40] 3Wikipedia-App-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#960681 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7811832 - 鐢\ Qī䃺誙,6X*8ٟⲯǡ/layoutactivity_about.xml https://ticket.wikimedia.or... [20:30:44] MaxSem: https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf13 [20:31:13] MaxSem: Oh, it's going live in wmf14. [20:31:30] mhurd: It's coming next week, not this week. See here: https://www.mediawiki.org/wiki/MediaWiki_1.25/wmf14 [20:31:44] Deskana: no! [20:32:39] crap crap crap [20:34:14] * Deskana hugs mhurd [20:34:36] Deskana: well, testflight next week i guess? [20:35:20] :-/ [20:35:28] I've not actually seen a version of the app in a loooong time. [20:35:34] I'm not sure I can wait another week. [20:35:49] Can we push one out that just uses the placeholder description? [20:36:54] Deskana: yeah. maybe for now i’ll just not even show the placeholder - the testflight release notes can say “descriptions coming next week” or some such [20:37:16] Sure [20:38:03] mhurd: got a few min. to chat about plenary mtg? [20:38:11] Deskana: k. brion’s data import should be ready today/tomorrow. i’ll comment out my lead image descrips for now. [20:38:14] dbrant: ya [20:39:02] Deskana: gonna knock out the rest of that last lead image acceptance criteria this afternoon [20:39:09] Excellent [20:39:14] GO GO GADGET TESTFLIGHT [20:39:24] Deskana: yes! [20:39:28] (03PS5) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 [20:39:34] Deskana, have I shown you https://etherpad.wikimedia.org/p/mobile-app-otrs-feedback ? [20:40:00] Krenair: You have not! What is it? [20:40:17] mostly tickets by language [20:40:43] and I had a couple of groups at the top, just the google issues left there now [20:40:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [20:41:38] Deskana was inspector gadget a thing in the UK? [20:41:57] kristenlans: Yep. [20:42:29] kristenlans: American TV shows are generally very prevalent in children's TV channels. [20:42:37] kristenlans: Even more so now than when I grew up. [20:59:29] kaldari: fyi, I'm getting data from mobile logs to estimate the worst case scenario in terms of the number of impressions per second we will need EL to handle without sampling. I'll get back to the thread in Analytics once I have the data. [20:59:47] dbrant: holy fuck your gallery viewer patch [20:59:50] dat patch [21:00:40] Deskana: ;) [21:02:14] (03PS1) 10Bmansurov: Conform to schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183321 (https://phabricator.wikimedia.org/T85963) [21:02:55] leila: Thanks. Judging by nuria’s email, it sounds like we are going to the surfing the edge of safety. [21:03:10] the=be [21:03:38] that's my gut feeling, too, but I want to be sure since sampling is another layer of extra work. Ideally, if we sample, we want to sample by userToken, and I'm not sure how easy that is. [21:04:25] kaldari, ^. [21:04:43] leila: it shouldn’t be too difficult, but if we’re going to do it, we need to implement and test it ASAP. [21:04:56] dbrant: I noticed a few strange images in there, like the feature article icon and pictures of speakers presumably used to indicate sound files. Can we take those out? They're not really meaningful in this context. [21:05:21] yeah, that's another thing, kaldari. my code is running in Hadoop now. I should have something for you in 2 hours. will update. [21:06:10] 3Wikipedia-App-Android-App: EGL-related crashes - https://phabricator.wikimedia.org/T74530#960791 (10Krenair) EGL_BAD_ALLOC - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8060286 [21:06:13] Deskana: I'm not sure what criteria to use for weeding out irrelevant images from the gallery... [21:06:19] leila: I’m leaning towards doing sampling just to be on the safe side, but I wonder if that will make things any more difficult for you and dartar for analyzing the data. [21:06:49] dbrant: Indeed. [21:07:11] kristenlans: are we meeting? [21:07:15] Deskana: I'm using a minimum width/height, but a lot of the "logo"-type images are svg... [21:07:32] leila_meeting: as we would only want to sample the page_impression and widget_impression events, meaning most of the workflow records would not have the complete funnel recorded. [21:07:39] ah oops [21:07:41] dbrant: It's hacky but we could use a specific exclude list to at least deal with some of them. Many of these icons are the same across projects... [21:07:51] dbrant: That might catch like 60% of them at least. [21:07:56] kristenlans: we're having trouble with the A/V in R37 [21:08:23] Maryana oops [21:08:26] I'm in now [21:08:30] but yeh adon't see you [21:08:38] dbrant: The obvious example of this is: https://en.wikipedia.org/wiki/File:Cscr-featured.png [21:09:05] dbrant: If that sounds doable then I can make a list of ones to exclude. [21:09:29] kaity can you see me in the hangout? [21:10:28] Deskana: it's doable... but surely there must be some kind of metadata item that tells us whether it's a "true" page image... [21:10:29] Maryana want me to see if there's another room> [21:10:42] lunch.errands.and.stuff.bbiab.etc [21:10:52] .com [21:11:14] dbrant: Hah, you'd think, but I'd be surprised. [21:11:42] guillom: You wouldn't happen to know, would you? [21:12:19] guillom: It might be easier if I showed you what I'm talking about. Are you in the office? [21:12:45] Deskana: actually, how does MediaViewer on desktop do it? it seems to handle irrelevant images better. [21:13:15] dbrant: Good point. [21:16:28] Deskana: Argh, I just went to hide into the quiet room. Are you looking to weed out presentational images from content images? [21:17:00] guillom: Basically, yes. [21:17:20] guillom: Things like the FA star, images of speakers for sounds, etc. [21:17:21] I don't know of specific metadata for those, but I'd look into the noprint class, and whether or not they have a suppressed link (lilnk=) [21:17:42] I mean, [[file:foo|...|link=]] [21:18:32] Ah but those are probably included via templates. Hmm. [21:18:57] .noprint might be the most useful, but I don't know if it's used consistently for this purpose. [21:20:23] Deskana: sounds like it would need to be implemented at the API level, since we're asking the API to give us a list of images. [21:20:45] Eurgh, right. [21:21:33] 3MobileFrontend-beta, VisualEditor-MediaWiki-Mobile, Editing, VisualEditor: Back arrow appears before other VE controls in MobileFrontend but does nothing - https://phabricator.wikimedia.org/T85481#960883 (10Jdforrester-WMF) a:3Jdlrobson [21:24:03] marktraceur suggested checking whether the href of the link matches the title of the image [21:24:08] dbrant ^ [21:24:36] which link? [21:24:57] dbrant: Unless you do |link= every thumbnail in mediawiki has a link wrapping it [21:25:13] So find the nearest and get its href [21:25:29] Then you get to create a Title from a URL [21:25:43] Not sure if we did that ourselves. Maybe mw.Title has a constructor for it. [21:26:09] Problem is that we're using the API to retrieve the list of images (not looking at the html). [21:26:17] Oh.p [21:26:22] What API call? [21:26:47] Oh, parse [21:26:49] Interesting [21:26:53] prop=imageinfo & generator=images [21:26:59] ...also interesting [21:27:12] Actually faster than what we do [21:27:25] At least for the client :) [21:27:34] Do you have an example query handy? [21:27:58] * dbrant rummages [21:29:30] marktraceur: http://en.wikipedia.org/w/api.php?action=query&prop=imageinfo&iiprop=dimensions|mime&titles=Barack%20Obama&generator=images&gimlimit=200 [21:29:33] I think I get the idea...maybe you should add a param to the API module that lets you exclude maintenance images [21:29:52] Heh, we went for the same example article [21:30:00] always a good standby [21:30:24] right, so it doesn't look like the API has such a parameter (yet) [21:30:29] True [21:30:33] You'd need to add it [21:30:42] It definitely seems like a core concept [21:31:21] dbrant: I *think* it's as simple as adding it to the action=parse&prop=images module, which is the generator you're using [21:31:48] marktraceur: indeed... we'll look into that [21:32:15] dbrant: Add me as a reviewer, I'd be happy to see this merged quickly :) [21:32:28] Or just pester me on IRC, I like that better anyway [21:32:37] marktraceur: sure, thx! [21:35:09] (03PS2) 10Dbrant: Full swipeable image gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 [21:35:31] (03CR) 10jenkins-bot: [V: 04-1] Full swipeable image gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 (owner: 10Dbrant) [21:36:46] (03PS3) 10Dbrant: Full swipeable image gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 [21:49:11] (03PS1) 10Bmansurov: Fix mobile image viewer and back button behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183372 (https://phabricator.wikimedia.org/T85636) [21:58:03] dbrant, bearND: Facts about Dan, brought to you by Tweet a Fact: https://twitter.com/danjgarry/status/552907064503042048 [21:58:56] :) very nice! [22:02:07] 3Wikipedia-App-Android-App: Image viewer should not display pictures like the feature article star in the gallery view - https://phabricator.wikimedia.org/T86073#961035 (10Deskana) 3NEW [22:02:46] Deskana: nice idea. This is usinig the old bits, though. The new version would not have so much space between the text and the wordmark [22:03:28] 3Wikipedia-App-Android-App: Image viewer should not display pictures like the feature article star in the gallery view - https://phabricator.wikimedia.org/T86073#961035 (10Deskana) Tracked here: https://trello.com/c/kliX5YR7/21-image-viewer-should-not-display-pictures-like-the-feature-article-star-in-the-gallery... [22:03:59] Deskana: dbrant: I wonder why it doesn't pick up the image for the lead image [22:04:08] moizsyed: hey, what's your username in phabricator? [22:04:14] i mean Deskana's photo [22:04:14] (03PS8) 10Jdlrobson: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 [22:04:16] (03PS1) 10Jdlrobson: Hygiene: Create models folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183376 [22:04:18] (03PS1) 10Jdlrobson: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 [22:04:41] moizsyed: Can you upload an SVG here: https://phabricator.wikimedia.org/T85578 thanks [22:04:46] bearND: for which page? [22:04:47] (03CR) 10Jdlrobson: [C: 04-1] "Please add a test so this regression doesn't happen again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183372 (https://phabricator.wikimedia.org/T85636) (owner: 10Bmansurov) [22:05:03] dbrant: for [[User:Deskana (WMF)]] [22:05:34] (03CR) 10jenkins-bot: [V: 04-1] WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [22:05:44] dbrant: Deskana: the edit button is behind the photo [22:05:58] The template looks pretty awful on the app. [22:06:32] Deskana: indeed [22:06:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create models folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183376 (owner: 10Jdlrobson) [22:07:23] kaldari: Moiz mentioned something about there being technical blockers to having Wikidata descriptions in search on mobile web. What are those? [22:07:33] (03CR) 10Jdlrobson: [C: 04-1] Conform to schema (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183321 (https://phabricator.wikimedia.org/T85963) (owner: 10Bmansurov) [22:07:34] kaldari: The search API now returns those descriptions in it if you set the right parameter. [22:07:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 (owner: 10Jdlrobson) [22:07:48] (03PS2) 10Jdlrobson: Hygiene: Create models folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183376 [22:08:08] jdlrobson: Maybe you know? ^ [22:08:28] (03PS2) 10Jdlrobson: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 [22:09:00] Deskana: mmm? i'm not sure. MaxSem is our local expert on any kind of blocker. [22:09:19] if you can do it with the API it's probably ok though [22:09:28] provided it's one api request [22:09:37] Yep, it is [22:09:39] Deskana: Yes, I believe that’s correct. There shouldn’t be a blocker currently, AFAIK. [22:09:51] yep [22:11:40] (03PS6) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 [22:12:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 (owner: 10Jdlrobson) [22:13:47] jdlrobson: hey, got a minute to chat? [22:13:51] gwicke: yup! [22:16:01] (03PS2) 10Bmansurov: Conform to schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183321 (https://phabricator.wikimedia.org/T85963) [22:21:05] (03CR) 10Robmoen: [C: 032] Hygiene: Create models folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183376 (owner: 10Jdlrobson) [22:22:36] (03Merged) 10jenkins-bot: Hygiene: Create models folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183376 (owner: 10Jdlrobson) [22:23:09] hey guys, i can haz https://gerrit.wikimedia.org/r/#/c/183186/ reviewed please? :) [22:23:53] (03CR) 10Jdlrobson: [C: 032] Conform to schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183321 (https://phabricator.wikimedia.org/T85963) (owner: 10Bmansurov) [22:25:11] (03Merged) 10jenkins-bot: Conform to schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183321 (https://phabricator.wikimedia.org/T85963) (owner: 10Bmansurov) [22:26:05] jdlrobson: there are some not-very-SOA notes about Content representation / UI / skins at https://phabricator.wikimedia.org/T86028 [22:26:19] (03PS4) 10Dbrant: Full swipeable image gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 [22:26:36] probably better discussed in another track's session [22:27:05] (03CR) 10Robmoen: [C: 04-1] Hygiene: Add helper methods to MobileUI (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 (owner: 10Jdlrobson) [22:27:27] (03PS3) 10Jdlrobson: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 [22:28:28] (03PS4) 10Jdlrobson: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 [22:28:42] (03PS5) 10Jdlrobson: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 [22:29:10] (03PS6) 10Jdlrobson: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 [22:30:26] (03CR) 10Robmoen: [C: 032] Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 (owner: 10Jdlrobson) [22:34:12] (03PS1) 10Jdlrobson: Hygiene: Remove misleading FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183388 [22:35:49] BTWs [22:35:52] C рождеством! [22:36:00] (03Merged) 10jenkins-bot: Hygiene: Add helper methods to MobileUI [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183377 (owner: 10Jdlrobson) [22:37:14] (03CR) 10Robmoen: [C: 031] "Reading through all the dismantle stuff. Want to go through all of it prior to merging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [22:38:23] (03PS2) 10Robmoen: Hygiene: Remove misleading FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183388 (owner: 10Jdlrobson) [22:38:41] (03CR) 10Robmoen: [C: 032] Hygiene: Remove misleading FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183388 (owner: 10Jdlrobson) [22:40:12] (03Merged) 10jenkins-bot: Hygiene: Remove misleading FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183388 (owner: 10Jdlrobson) [22:46:46] (03CR) 10Bmansurov: "I suppose this needs browser tests. Do you mind if we get this merged and I will submit a follow up patch later? I think it may take me so" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183372 (https://phabricator.wikimedia.org/T85636) (owner: 10Bmansurov) [22:47:15] jdlrobson: ^ [22:47:33] qunit test should suffice bmansurov [22:47:58] jdlrobson: is it possible to make the browser go back and forth in qunit? [22:49:28] bmansurov: of course.. you can either manipulate the hash or you can simulate what happens. I'm not sure why your fix works without a test [22:49:39] i assume this.$details is being accessed before defined but by what function? [22:49:45] Overlay.prototype.postRender ? [22:49:47] yep [22:50:23] why does Overlay.prototype.postRender interact with $details ? [22:50:37] anyway just write a test that invokes that code path [22:50:44] you shouldn't need to use browser back/forth [22:50:50] just mimic what they are doing [22:51:03] ok [23:05:46] Deskana are you in product check-inright now? [23:07:27] (03PS9) 10Robmoen: WIP [DONOTMERGE]: Add Special:MobileCollections to alpha left nav [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182984 (owner: 10Jdlrobson) [23:12:37] (03CR) 10MaxSem: Always enable red links in alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [23:15:08] kaldari: is it right, that wikibugs bot doesn't inform us here in irc, if the project Mobile web is added (without any other MF related project)? [23:17:49] (03PS1) 10Florianschmidtwelzow: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183389 (https://phabricator.wikimedia.org/T86031) [23:20:20] FlorianSW: Not sure, but it seems like it should [23:23:48] kaldari: https://gerrit.wikimedia.org/r/#/c/183391/1 [23:25:36] FlorianSW: Isn’t it ‘Mobile-Web’? [23:25:52] kaldari: damn, you're right :/ [23:26:22] * FlorianSW no, Florian, no need to copy the project name [23:27:18] hey guys, we *NEED* https://gerrit.wikimedia.org/r/#/c/183186/ running in prod ASAP [23:30:50] violetto_, hey [23:31:27] Krenair: hi [23:31:45] violetto_, please could you check https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8058028 ? [23:32:29] MaxSem: OK, I’ll take a look [23:32:52] thanks! [23:34:41] rmoen: shit. that shouldn't have been merged :/Add helper methods to MobileUI [23:35:06] jdlrobso_: why ? [23:35:19] rmoen: tis bad code [23:35:27] it's creating mw-ui-mw-ui-constructive class [23:35:34] ew [23:35:38] :/ [23:35:52] follow up on way [23:36:02] lmk and i'll +2 :) [23:37:29] (03PS1) 10Jdlrobson: Regression: MobileUI follow up [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183395 [23:37:32] ^ [23:39:16] (03CR) 10Jdlrobson: [C: 032] Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183389 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [23:39:38] (03PS1) 10Florianschmidtwelzow: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) [23:40:30] 3Mobile-Web: Anon user click tracking is not recorded correctly - https://phabricator.wikimedia.org/T85963#961191 (10Jdlrobson) 5Open>3Resolved [23:40:46] Krenair: it's taking a while to reset my password, or i might have one to access [23:40:49] 3Mobile-Web: MobileFrontend Watchlist List view displays nothing - https://phabricator.wikimedia.org/T86030#961193 (10Jdlrobson) 5Open>3Resolved [23:40:54] (03PS2) 10Bmansurov: Fix mobile image viewer and back button behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183372 (https://phabricator.wikimedia.org/T85636) [23:41:35] (03Merged) 10jenkins-bot: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183389 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [23:41:52] violetto_, ah, that's annoying. :/ don't let it take up too much time. you should definitely have access... [23:41:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [23:42:34] jdlrobso_: if you merge https://gerrit.wikimedia.org/r/#/c/183396/ the cherry pick, too, i can shedule the backport for now (in 20 minutes) :) [23:44:00] (03CR) 10Jdlrobson: [C: 04-1] Scrollable reference drawers (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/178338 (owner: 10Robmoen) [23:44:17] (03PS5) 10Jdlrobson: Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [23:45:14] (03CR) 10Jdlrobson: [C: 031] "Nice." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [23:46:10] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [23:46:25] jdlrobso_: hmm any links on wiki in regards to collections ? [23:46:26] (03PS2) 10Jdlrobson: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [23:47:23] 3Mobile-Web: Mistake in Create Account does not generate error message - https://phabricator.wikimedia.org/T86031#961214 (10Jdlrobson) 5Open>3Resolved [23:47:26] jdlrobso_: not seeing it listed as a goal: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals [23:47:45] (03CR) 10jenkins-bot: [V: 04-1] Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [23:48:45] (03CR) 10Kaldari: [C: 04-1] Maintenance script to refresh old versions of questions (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [23:48:52] (03CR) 10Jdlrobson: [C: 032] Fix mobile image viewer and back button behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183372 (https://phabricator.wikimedia.org/T85636) (owner: 10Bmansurov) [23:50:05] (03CR) 10MaxSem: Maintenance script to refresh old versions of questions (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [23:50:16] (03Merged) 10jenkins-bot: Fix mobile image viewer and back button behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183372 (https://phabricator.wikimedia.org/T85636) (owner: 10Bmansurov) [23:51:44] kaldari: https://phabricator.wikimedia.org/T78800 needs a lightning deploy [23:51:51] ^ cc. Maryana MaxSem [23:51:57] (03PS4) 10MaxSem: Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 [23:52:01] (possibly - up to maryana) [23:52:04] kaldari, ^^^ [23:52:10] ehh alpha [23:52:49] let it simmer til the next train rolls through [23:52:51] do we really need to swat alpha fixes? [23:53:01] concur [23:54:17] I reluctantly agree. It’s an unfortunately breakage, but not SWAT-worthy. [23:57:26] 3Mobile-Web: Overlay icons misaligned in alpha - https://phabricator.wikimedia.org/T86041#961242 (10Jdlrobson) Note this also effects the hamburger icon @maryana when you close the overlay. @Prtksxna any idea how to fix this? [23:59:36] (03PS5) 10MaxSem: Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186