[00:02:48] 3Mobile-Web: Overlay icons misaligned in alpha - https://phabricator.wikimedia.org/T86041#961248 (10Jdlrobson) Problematic rule in mobile is: .overlay-header .overlay-action a, .overlay-header button { min-height: 3.35em; } [00:03:15] (03CR) 10Kaldari: [C: 032] Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [00:03:28] w00t, thanks! [00:03:43] (03Merged) 10jenkins-bot: Maintenance script to refresh old versions of questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183186 (owner: 10MaxSem) [00:04:43] (03PS1) 10MaxSem: Maintenance script to refresh old versions of questions [extensions/WikiGrok] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183398 [00:04:52] (03CR) 10MaxSem: [C: 032] Maintenance script to refresh old versions of questions [extensions/WikiGrok] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183398 (owner: 10MaxSem) [00:05:10] (03PS1) 10MaxSem: Maintenance script to refresh old versions of questions [extensions/WikiGrok] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183399 [00:05:16] (03CR) 10MaxSem: [C: 032] Maintenance script to refresh old versions of questions [extensions/WikiGrok] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183399 (owner: 10MaxSem) [00:05:18] (03Merged) 10jenkins-bot: Maintenance script to refresh old versions of questions [extensions/WikiGrok] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183398 (owner: 10MaxSem) [00:05:20] (03CR) 10BearND: [C: 032] "Pretty cool. Just need to find a way to filter more images." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 (owner: 10Dbrant) [00:05:45] (03Merged) 10jenkins-bot: Maintenance script to refresh old versions of questions [extensions/WikiGrok] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183399 (owner: 10MaxSem) [00:08:05] (03Merged) 10jenkins-bot: Full swipeable image gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183274 (owner: 10Dbrant) [00:08:17] (03PS2) 10BearND: Don't duplicate history entries; instead, move them to top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183064 (https://phabricator.wikimedia.org/T76951) (owner: 10Dbrant) [00:08:31] (03CR) 10BearND: [C: 032] Don't duplicate history entries; instead, move them to top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183064 (https://phabricator.wikimedia.org/T76951) (owner: 10Dbrant) [00:08:54] (03CR) 10Jdlrobson: [C: 04-1] "Nice!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [00:09:08] (03Merged) 10jenkins-bot: Don't duplicate history entries; instead, move them to top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183064 (https://phabricator.wikimedia.org/T76951) (owner: 10Dbrant) [00:10:22] (03CR) 10Jdlrobson: Add Possibility to add categories to a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [00:11:29] Deskana: quick Q about https://gerrit.wikimedia.org/r/#/c/183306/: is app sufficient of do we need to distiguish between Android and iOS? [00:11:59] Krenair: hope you're still around! i wasn't able to access it, my pw reset email never arrived [00:12:01] bearND: For the purposes of this tracking (i.e. clickthrough), app is sufficient. [00:12:05] yep [00:12:11] what was the issue about, what about a screenshot? [00:12:13] Deskana: ok, thanks [00:12:16] Krenair: [00:12:35] bearND: For clickthrough purposes distinguishing between platforms isn't necessary because they should hopefully be outputting very similar things. [00:12:37] (03PS2) 10BearND: Add "?source=app" to the end of all share a fact URLs per Analytics. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183306 (owner: 10Deskana) [00:12:52] (03PS1) 10Deskana: No longer emit log message when the app install ID is accessed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183402 [00:12:54] (03CR) 10BearND: [C: 032] Add "?source=app" to the end of all share a fact URLs per Analytics. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183306 (owner: 10Deskana) [00:13:24] (03Merged) 10jenkins-bot: Add "?source=app" to the end of all share a fact URLs per Analytics. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183306 (owner: 10Deskana) [00:15:05] (03PS2) 10BearND: No longer emit log message when the app install ID is accessed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183402 (owner: 10Deskana) [00:15:09] (03CR) 10BearND: [C: 032] No longer emit log message when the app install ID is accessed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183402 (owner: 10Deskana) [00:15:35] (03Merged) 10jenkins-bot: No longer emit log message when the app install ID is accessed. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183402 (owner: 10Deskana) [00:19:27] (03CR) 10Kaldari: "@Jdlrobson: I think it would make more sense to put this (and Schema.getSessionId) in M.user." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [00:20:15] violetto_, it was about changing the android app logo [00:20:17] to be more material design-y [00:20:42] i see [00:21:01] violetto_, can you check your inbox again for me? [00:21:10] Krenair: moizsyed can help you with that [00:21:22] Krenair: he's working in the apps team, i'll ping him [00:22:17] moizsyed: you around? [00:23:20] violetto_: hey whats up [00:23:31] Krenair: sorry, i didnt see your earlier msg [00:23:34] whats up [00:23:49] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8058028 moizsyed [00:24:36] moizsyed: i haven't been able to log in, maybe you can help Krenair [00:24:50] violetto_: i cant seem to log in either [00:25:07] I don't think moizsyed has access [00:25:14] Krenair: ok [00:25:22] hang on, i just got the email [00:25:29] :) [00:26:34] moizsyed: https://www.dropbox.com/s/qed98a9qe8cl47f/Screenshot%202015-01-07%2016.26.15.png?dl=0 [00:26:58] Krenair: moizsyed i don't think there's a need to change the icon because of new material UI, but you can make that call [00:27:12] (03CR) 10Jdlrobson: Add Possibility to add categories to a page (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [00:27:41] Krenair: yeah i agree with violetto_... no need to change the icon [00:27:50] um [00:28:15] Krenair: whoops, im not allowed to? [00:28:23] definitely not [00:29:28] Krenair: also, i think Vibha Bamba should be included in this discussion too, shes the lead designer on mobile apps [00:29:43] in the trash it goes! [00:30:31] ok [00:31:24] (I don't have a particular opinion on this, I'm pretty much just the messenger here) [00:32:01] Krenair: alright, can you send both vibha and me and email about this... [00:32:09] sure, I'll forward it to you [00:32:13] Krenair: thanks [00:34:38] Deskana: what’s the cheapest call to retrieve a Wikidata label for an article in language foo from the foowiki API? [00:35:04] label and/or description [00:35:28] ideally the same method you guys use for search on the app [00:35:29] moizsyed, done [00:35:40] Krenair: thanks [00:36:46] DarTar: https://en.wikipedia.org/w/api.php?action=query&prop=pageterms&titles=Barack_Obama [00:36:59] DarTar: Titles can be pipe-separated as normal [00:37:05] Deskana: excellent, thanks [00:37:13] If you just want the label or description... [00:37:25] jdlrobso_: you have a sec to discuss MobileUI.php? [00:38:37] DarTar: https://en.wikipedia.org/w/api.php?action=query&prop=pageterms&wbptterms=description&titles=Barack_Obama [00:39:02] Deskana: awesome [00:43:32] DarTar: You can use that pageterms module with generators if you want to augment other queries with descriptions, e.g. search results [00:43:58] sure [00:45:29] (03PS1) 10Kaldari: Fix Sign-up button on Mobile Sign-up page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183407 [00:45:44] jdlrobso_: ^ [01:00:26] (03CR) 10Bmansurov: "It's weird. mw-ui-constructive works fine here. constructive class doesn't exist though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183407 (owner: 10Kaldari) [01:00:47] kaldari.. if you looked at the code review quee... https://gerrit.wikimedia.org/r/183395 [01:00:51] you could have saved yourself some time [01:01:32] (03CR) 10Jdlrobson: "https://gerrit.wikimedia.org/r/183395 fixes this and also fixes up a problem with options page doing its own thing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183407 (owner: 10Kaldari) [01:02:05] ^ cc rmoen [01:02:21] jdlrobso_: or you could have saved me the time by replying to my question above :P [01:02:36] i'm trying to ignore people right now i have my head down coding [01:02:45] i mentioned this issue up above [01:03:18] jdlrobso_: oh well. At least it’s fixed... [01:04:37] (03PS2) 10Robmoen: Regression: MobileUI follow up [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183395 (owner: 10Jdlrobson) [01:04:59] (03CR) 10Robmoen: [C: 032] Regression: MobileUI follow up [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183395 (owner: 10Jdlrobson) [01:05:09] (03CR) 10Kaldari: [C: 032] Regression: MobileUI follow up [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183395 (owner: 10Jdlrobson) [01:05:35] (03Abandoned) 10Kaldari: Fix Sign-up button on Mobile Sign-up page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183407 (owner: 10Kaldari) [01:07:49] (03Merged) 10jenkins-bot: Regression: MobileUI follow up [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183395 (owner: 10Jdlrobson) [01:14:30] dbrant|bbl: bearND: http://en.wikipedia.org/w/index.php?title=Special:LongPages [01:16:14] dbrant|bbl: bearND: from this found a great search term for finding articles with long titles a lead image. the term is “list of accidents” [01:18:55] mhurd: cool. thanks. If you are looking for more: "Grammy Award for best latin rock"... (was linked from the home page a couple of days ago). I was using that to test share a fact [01:26:04] 3Mobile-Web: No refresh icon on Special:Nearby in alpha - https://phabricator.wikimedia.org/T85578#961645 (10bmansurov) Anyone knows moiz's username here? Maybe we should create a trello card and ping him there. [01:26:40] bmansurov: my username on phabricator is MSyed [01:33:53] 3Mobile-Web: No refresh icon on Special:Nearby in alpha - https://phabricator.wikimedia.org/T85578#961652 (10bmansurov) @MSyed could you please upload an SVG? thanks [01:34:00] moizsyed: thanks i left a comment in the patch for you [01:34:04] kaldari: let's have a quick chat about what we should do with sampling. [01:34:39] We can sample the incoming traffic, sample per userToken, or make WikiGrok live only on a subset of the pages. [01:35:47] leila: OK [01:35:51] I’ll come by.... [01:36:02] I'm in the Caltrain station. :-\ [01:36:09] you wanna do it here, or Hangout a bit later? [01:36:18] kaldari, ^. [01:36:43] leila: here is fine [01:37:04] I was thinking of just filtering based on the user token [01:37:25] that's the best way in terms of the analysis if you can do that smoothly [01:38:00] leila: sampling the incoming traffic would be complicated, as you would have a hard time keeping info for a single user together. [01:38:19] leila: what do you think about showing on a subset of pages? [01:38:29] yeah, that's great. so let's go ahead with sampling userTokens [01:39:41] that can also work, kaldari. the downside of that is that if we don't do it wisely, we will end up removing high traffic pages, and that's not good since we want to see if many people interact with the widget, whether they will converge to the correct answer. [01:39:49] leila: would we want to just filter out those high-traffic events for 90% of users or hide WikiGrok entirely for 90% of users? [01:39:53] basically high traffic pages are the most interesting pages. [01:40:40] Maryana: ^ [01:40:43] lemme think kaldari. [01:42:05] let's go with turning it off for 90% users on very high traffic pages. [01:43:02] if we show it only to 10% of users, the results for lower traffic pages will be unrealistically bad, though in terms of consistency, turning it off to 90% of users independent of page is better. We will deal with consistency in the analysis. [01:43:05] can we do that? we don't know which pages will be very highly trafficked a priori.. [01:43:13] leila: Maryana favors disabling WikiGrok for 90% of users (so that at least the funnel info will be complete for those users) [01:43:41] leila, Maryana: Yeah, no idea how we would limit it to high-traffic pages [01:44:07] that's a good point, too, kaldari. thinking ... [01:44:20] yeah, that australian terrorist guy was the #1 hit during the last test… how would we know what page is going to be that during the next test period? :) [01:44:24] I need to think through this for a little bit. do you want to start implementing tonight, kaldari? [01:44:41] leila: no, not tonite :) [01:45:07] want to talk tomorrow? [01:45:38] yeah, let me think through this and we talk early morning tomorrow (as early as you and kaldari will be available) [01:45:49] sounds good [01:45:52] I'll send an email tonight if I converge but in-person talking is easier [01:46:18] we'll be in at 9 for our team health check, but not free until 10:30 i think [01:46:45] I'll get there around 8:15 so if you get in earlier, we can talk earlier, if not, after 10:30 [01:46:51] woah [01:46:55] too early ;) [01:47:01] you haven't seen the 7:30 days, Maryana. ;-) [01:47:07] ahhh [01:47:10] that is not a real time [01:47:17] hahaha! love it! [01:47:58] okay, signing off now. see you tomorrow. [01:55:54] 3Mobile-Web: jscs should apply to test files as well. - https://phabricator.wikimedia.org/T85876#961686 (10bmansurov) a:3bmansurov [02:04:23] (03PS1) 10Deskana: Change Wikipedia Zero FAQ to point to mobile version of site instead. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) [02:26:25] (03PS1) 10Bmansurov: WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) [02:27:46] (03CR) 10jenkins-bot: [V: 04-1] WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [02:29:17] (03PS1) 10Bmansurov: WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 [02:30:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (owner: 10Bmansurov) [02:34:51] (03PS2) 10Bmansurov: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) [02:35:32] (03CR) 10Bmansurov: "It doesn't depend on Regression: MobileUI follow up (MERGED), my bad" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (owner: 10Bmansurov) [02:37:34] (03PS2) 10Bmansurov: WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) [02:37:53] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [02:40:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [02:51:48] (03PS6) 10Jdlrobson: wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [02:53:46] (03CR) 10jenkins-bot: [V: 04-1] wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [03:06:57] (03PS1) 10Dbrant: Fix possible crash when pinch/zooming in gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 [05:51:28] 3Mobile-Web, Scrum-of-Scrums, MediaWiki-extensions-ZeroBanner, MediaWiki-extensions-Flow, UI-Standardization: Dismantle Mantle - https://phabricator.wikimedia.org/T85890#961838 (10Spage) Flow uses Lightncandy to deliver handlebars templates, but as I understand it the #UI-Standardization effort is only adding mu... [06:10:54] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#961843 (10Jdlrobson) @jhernandez this could be useful to explore, with the purpose of getting familiar with how the watchlist API works and how w... [06:29:44] 3Mobile-Web: Mobile image viewer and back button behaviour - https://phabricator.wikimedia.org/T85636#961866 (10Jdlrobson) 5Open>3Resolved [06:54:10] (03CR) 10BearND: [C: 04-1] "You could also change to mobile site for other foundation URLs, like terms_of_use_url and potentially privacy_policy_url." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) (owner: 10Deskana) [07:17:12] (03CR) 10BearND: "Have you been able to repro the issue? I've tried on my 5.0 device but couldn't." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 (owner: 10Dbrant) [07:17:42] (03PS1) 10BearND: Image share improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183441 [07:20:13] (03CR) 10jenkins-bot: [V: 04-1] Image share improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183441 (owner: 10BearND) [07:20:33] (03PS1) 10BearND: Remove old translation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183442 [07:24:31] (03PS2) 10BearND: Image share improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183441 [09:38:19] morning! [09:43:51] morning [10:29:09] 3Mobile-Web: Overlay icons misaligned in alpha - https://phabricator.wikimedia.org/T86041#962272 (10Prtksxna) There isn't any documentation on the styleguide about using the `mw-ui-icon` class with a `button`. Changing the element to `div` immediately solves the problem. So I tried to make a [[ https://gerrit.wi... [11:30:28] i really hate testing wikigrok [11:30:32] really really [11:53:14] phuedx: why exactly [11:53:30] because it's a pita to set up the data story [11:53:32] *store [11:53:40] oh yeah [11:54:04] i've managed for now with ann dallas and burrito as musical albums xD [11:54:17] but yep, i agree [11:56:59] going out to buy cigarretes [12:13:03] (03CR) 10Phuedx: Make WikiGrok v B support multiple campaigns at the same time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [12:13:10] (03CR) 10Phuedx: [C: 032] Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [12:13:54] (03CR) 10Phuedx: "Tested with a few "active" campaigns as well as duplicating the output of wikiGrokCampaigns.getAllSuggestions. LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [12:14:39] (03Merged) 10jenkins-bot: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [13:03:46] gonna go get lunch [13:53:41] 3Wikipedia-App-Android-App: IllegalArgumentException: pointerIndex out of range crashes - https://phabricator.wikimedia.org/T86166#962694 (10Krenair) 3NEW [14:46:03] (03PS2) 10Dbrant: Fix possible crash when pinch/zooming in gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 [14:50:03] (03PS3) 10Dbrant: Fix possible crash when pinch/zooming in gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 (https://phabricator.wikimedia.org/T86166) [14:57:19] (03CR) 10Dbrant: "@BearND The HackyViewPager in some of the other examples also implements additional 'locking' functionality that we don't need. (that's wh" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 (https://phabricator.wikimedia.org/T86166) (owner: 10Dbrant) [14:59:30] 3Wikipedia-App-Android-App: IllegalArgumentException: pointerIndex out of range crashes - https://phabricator.wikimedia.org/T86166#962931 (10Dbrant) https://gerrit.wikimedia.org/r/183426 [14:59:52] 3Wikipedia-App-Android-App: Image sometimes scales instead of doing parallax scrolling - https://phabricator.wikimedia.org/T85832#962937 (10Dbrant) 5Open>3Resolved a:3Dbrant [15:05:34] 3Wikipedia-App-Android-App: Exclude main page from history? - https://phabricator.wikimedia.org/T76951#962947 (10Dbrant) 5Open>3Resolved a:3Dbrant [15:06:01] (03CR) 10Phuedx: [C: 031] "This LGTM. The affected modules seem to work a-ok. Gonna add the rest of the team so someone else can kick the tyres too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [15:06:22] 3Wikipedia-App-Android-App: NPE crash from leadimages.LeadImagesHandler.beginLayout - https://phabricator.wikimedia.org/T78501#962952 (10Dbrant) 5Open>3Resolved a:3Dbrant [15:17:26] Might be in the wrong place, but a question for anyone kind enough to help out: [15:17:45] I have a website, and now moving to building an app that will allow it to auto play video natively (scrapped from youtube at thee moment) on mobile devices (currently it is NOT mobile friendly.) Is Cordova the right way to go about it? The site is simple: http://lunch.tv - it just is a compilation of videos. Any advice would be super helpful. [15:25:29] (03PS3) 10Phuedx: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [15:25:31] (03PS7) 10Phuedx: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [15:27:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [15:27:42] (03CR) 10jenkins-bot: [V: 04-1] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [15:31:36] (03CR) 10Phuedx: "PS3 is a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [15:56:59] (03CR) 10Dbrant: [C: 032] Image share improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183441 (owner: 10BearND) [15:57:20] (03Merged) 10jenkins-bot: Image share improvements [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183441 (owner: 10BearND) [15:57:44] (03CR) 10Dbrant: [C: 032] Remove old translation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183442 (owner: 10BearND) [16:01:36] (03PS6) 10Dbrant: [WIP] Widgets. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/175225 [16:01:42] (03CR) 10BearND: [C: 031] "@Deskana Once you're able to verify the fix feel free to merge." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 (https://phabricator.wikimedia.org/T86166) (owner: 10Dbrant) [16:04:56] (03CR) 10Bmansurov: Make WikiGrok v B support multiple campaigns at the same time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182981 (owner: 10Bmansurov) [16:11:49] (03PS3) 10Dbrant: Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 [16:16:18] (03PS4) 10Dbrant: Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 [16:26:10] (03PS4) 10Phuedx: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [16:27:30] (03CR) 10jenkins-bot: [V: 04-1] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [16:35:24] Morning phuedx and joakino. Did you guys see any mail go by from me yesterday about the team health check this AM? [16:35:42] afternoon kristenlans [16:35:44] yarrrp [16:35:54] did we have to fill in a thing? i forget [16:36:08] ah ok, phew. It's not in my sentmail :-/ [16:36:17] No prep required :-) [16:36:43] best kind of meeting [16:36:53] sit back and enjoy the ride [16:43:09] hi kristenlans phuedx [16:43:29] kristenlans: what do we do with the collections standup then? [16:43:56] joakino, yes good question. I was thinking we could do a quick one after? [16:44:07] (03PS1) 10Phuedx: Make OO a JSHint global [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 [16:44:14] joakino: ^ [16:44:20] kristenlans: it collides with the story prioritization meeting right? [16:44:22] collections? [16:44:26] that's not important [16:44:40] SKIP IT [16:45:47] phuedx: i'm getting a gerrit server error :S [16:45:58] allright now [16:46:23] 3Wikipedia-App-Android-App: SecurityException when requesting location - https://phabricator.wikimedia.org/T86198#963236 (10bearND) 3NEW [16:47:12] (03CR) 10Jhernandez: [C: 032] Make OO a JSHint global [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:47:59] wait [16:48:07] i got that wrong :/ [16:48:11] lol [16:48:17] the dependent commit hasn't been merged [16:48:20] but it will be ;) [16:48:25] preemptive fixing [16:48:51] joakino, yeah we'd have to squeeze it in between the two. After the story prioritization meetign could work too, but I was relucatant to make your day even longer than it already will be :-) [16:48:53] derp derp [16:50:03] kristenlans: if we're going to do it afterwards i'd need to know, i have an overlapping meeting that I have to move [16:50:16] (03PS2) 10Jdlrobson: Make OO a JSHint global [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:50:24] (03PS3) 10Jdlrobson: Hygiene: Make OO a JSHint global [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:50:32] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make OO a JSHint global [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:50:45] hi jdlrobson [16:50:49] hey jdlrobson [16:50:56] hey just about to rush out and catch bus to office :) [16:50:59] i borked the order of things, but it shouldn't matter to much [16:51:02] *too [16:51:10] (03CR) 10Deskana: [C: 032] "The crash typically happened when zooming in all the way on an image, then zooming out. I only ever got it to happen on certain images. Th" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183426 (https://phabricator.wikimedia.org/T86166) (owner: 10Dbrant) [16:51:10] * phuedx waits for the drawwwp [16:51:22] phuedx: ! [16:51:28] ah OK. How about we try to take the last ten mins of the story prio mtg. At that point we may also have a better sense of what's in store fro the second half of sprint zero [16:51:34] ^joakino [16:51:41] ok see you in a bit! hopefully ill get the fast bus! [16:52:14] 3Wikipedia-App-Android-App: IllegalArgumentException: pointerIndex out of range crashes - https://phabricator.wikimedia.org/T86166#963275 (10Dbrant) 5Open>3Resolved a:3Dbrant [16:52:17] 3MobileFrontend-Feature-requests: Generalise infinite scroll code on uploads page so that Special:Watchlist can also use it - https://phabricator.wikimedia.org/T85491#963277 (10Jhernandez) I'm on it, extracting the infinite scroll to then reuse it in the watchlist & others [16:52:58] kristenlans: i'm fine with that, its been a couple of weird days anyways [16:53:19] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:54:05] joakino: cool. [16:57:26] (03PS5) 10BearND: Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 (owner: 10Dbrant) [16:57:38] dbrant: ready to merge ^ ? [16:58:29] (03CR) 10Phuedx: [C: 032] "Self-merge given two C+2's from Jhernandez and Jdlrobson and jenkins-bot being AWOL." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:58:38] bearND: go for it. we'll get feedback from Vibha later [16:58:45] ok [16:58:50] phuedx: lol ^ [16:59:01] (03CR) 10BearND: [C: 032] Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 (owner: 10Dbrant) [16:59:05] inorite [16:59:12] took a while for them to turn up to the show [16:59:46] (03Merged) 10jenkins-bot: Hygiene: Make OO a JSHint global [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183532 (owner: 10Phuedx) [16:59:57] i've just realised i'm sitting in the dark staring at a super-bright screen [17:00:28] (03PS5) 10Phuedx: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [17:00:30] (03PS8) 10Phuedx: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [17:00:45] (03Merged) 10jenkins-bot: Make references collapsible (and collapse by default) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/176936 (owner: 10Dbrant) [17:00:52] phuedx: https://justgetflux.com/ [17:01:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [17:05:46] (03PS3) 10Bmansurov: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) [17:07:11] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:09:44] (03PS1) 10BearND: Catch SecurityException when requesting location [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183534 (https://phabricator.wikimedia.org/T86198) [17:15:28] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1diG8Yc80aGibhIp9Lce3w8Pk4xMHM9N6Bq31KojYZSk/edit#gid=0 [17:17:41] (03CR) 10Dbrant: [C: 032] Catch SecurityException when requesting location [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183534 (https://phabricator.wikimedia.org/T86198) (owner: 10BearND) [17:17:51] https://etherpad.wikimedia.org/p/mobile_web_health_check [17:19:05] 3Wikipedia-App-Android-App: SecurityException when requesting location - https://phabricator.wikimedia.org/T86198#963371 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:21:04] (03PS1) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) [17:21:33] https://www.mediawiki.org/wiki/Team_Practices_Group/Health_check_survey [17:21:33] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1diG8Yc80aGibhIp9Lce3w8Pk4xMHM9N6Bq31KojYZSk/edit#gid=0 [17:21:46] (03PS6) 10Phuedx: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [17:21:48] (03PS9) 10Phuedx: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [17:22:22] (03PS3) 10Bmansurov: WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) [17:23:33] (03PS1) 10Dbrant: Event logging for Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 [17:26:26] (03CR) 10jenkins-bot: [V: 04-1] WIP: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:28:01] https://www.youtube.com/watch?v=QrGrOK8oZG8 damn this tv show [17:28:54] (03PS2) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) [17:30:20] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:33:21] 3Mobile-Web: Overlay icons misaligned in alpha - https://phabricator.wikimedia.org/T86041#963416 (10Jdlrobson) a:3Jdlrobson Awesome. I think I can work this out now.. [17:46:24] hi jdlrobson :) [17:50:10] errr joakino JonKatz_ rmoen kristenlans standup? [17:50:28] jdlrobson: no!, health check [17:50:29] (03CR) 10BearND: [C: 04-1] "minor nit" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 (owner: 10Dbrant) [17:50:32] we're in chambers [17:50:33] joakino: wah? [17:50:48] jdlrobson: lol 3Flr - R37 - Chambers (L [17:50:59] we've been at it for 40 min xD [17:51:56] jdlrobson: https://docs.google.com/a/wikimedia.org/spreadsheets/d/1diG8Yc80aGibhIp9Lce3w8Pk4xMHM9N6Bq31KojYZSk/edit#gid=0 [17:52:08] 3Mobile-Web: MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210#963618 (10Anomie) 3NEW [18:05:05] (03PS2) 10Dbrant: Event logging for Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 [18:05:51] (03PS3) 10BearND: Event logging for Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 (owner: 10Dbrant) [18:05:59] (03CR) 10BearND: [C: 032] Event logging for Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 (owner: 10Dbrant) [18:23:21] (03PS1) 10Dbrant: No longer hide hatnotes in non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) [18:23:48] dbrant: can you give me an example of an article w hat notes in non lead section? [18:24:23] mhurd: there's one mentioned in the bug -- https://phabricator.wikimedia.org/T85985 [18:24:26] dbrant: if you have one close at hand from testing [18:24:29] ah perfect [18:24:30] thanks! [18:25:39] (03CR) 10Florianschmidtwelzow: "> The UI feels a bit strange though." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [18:26:30] bearND: I thought you left me a comment on Trello but I can't find it now. [18:27:38] bearND: Did you have a question? :) [18:31:25] Deskana: sorry, I had one but then I deleted it because I already figured it out [18:31:36] Okay, great. [18:35:50] g'night folks [18:36:05] gonna get george to bed [18:38:19] tfinc: I'm not sure about how to reschedule in the calendar, i'm free from 11:30am onwards [18:38:34] joakino: just change the time in the invite [18:38:52] tfinc: it is saying that it will only be reflected on my calendar :s [18:39:03] reload so that you pickup the modify bit [18:39:19] k [18:40:04] (03PS2) 10Brion VIBBER: Work in progress: new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [18:40:32] tfinc: alright done [18:40:45] nope xd [18:41:38] i think it needs another room [18:48:38] Deskana: fyi, minor inconsistency in Schema:MobileWikiAppShareAFact: revId + pageid, one is camel case the other is not [18:48:57] bearND: revId was added by Dario, that might be why ;) [18:49:12] bearND: Let's check some other schemas to see what our conventions are here [18:50:24] bearND: https://meta.wikimedia.org/w/index.php?title=Schema:MobileWikiAppShareAFact&diff=10915291&oldid=10908780 [18:50:49] Deskana: ok, thanks [18:57:17] mhurd: dbrant: kaldari: remember to get your plenary and break out sessions into phab today. jdlrobson: thanks for getting yours in [18:58:47] (03PS2) 10Deskana: Change URLs to point to mobile version of sites specifically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) [18:58:57] tfinc: will do [19:00:07] (03PS1) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) [19:00:28] (03PS3) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) [19:01:17] kaldari: what's the rough estimate of pages affected for the reader test again? [19:01:47] Maryana: 150,000-200,000 [19:02:00] rad, thanks [19:02:43] bearND [19:02:53] it's that time [19:02:56] kristenlans: coming [19:03:40] https://etherpad.wikimedia.org/p/MobileAppRetrospective [19:08:40] (03PS1) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) [19:09:02] DarTar: Some time soon we need to discuss transitioning from the MobileWebWikiGrokResponse schema to recording the responses in the MediaWiki database, but it can wait for now. [19:09:21] kaldari: yup, after the test? [19:09:28] yeah [19:14:14] mhurd: hiding svg's is working awesomely [19:14:30] dbrant: :) [19:16:02] (03PS1) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) [19:27:13] (03PS1) 10Dbrant: Improve list of media items shown in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183569 (https://phabricator.wikimedia.org/T86073) [19:27:59] (03PS1) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) [19:29:14] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 (owner: 10Dbrant) [19:30:30] (03PS1) 10Anomie: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 [19:30:56] (03PS2) 10Dbrant: No longer hide hatnotes in non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) [19:31:00] (03PS1) 10Bmansurov: Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) [19:31:15] (03PS1) 10Anomie: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/183608 [19:31:17] (03PS1) 10Anomie: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/183609 [19:31:21] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:32:22] (03CR) 10Dbrant: [C: 032] Event logging for Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183540 (owner: 10Dbrant) [19:32:44] (03PS4) 10Bmansurov: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) [19:34:14] (03PS4) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) [19:34:44] (03PS2) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) [19:34:53] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:34:55] (03PS2) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) [19:35:12] (03PS2) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) [19:35:26] (03PS2) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) [19:35:46] (03PS2) 10Bmansurov: Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) [19:36:13] (03CR) 10Deskana: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) (owner: 10Deskana) [19:37:23] jdlrobson, kaldari, rmoen, joakino, phuedx I would appreciate it if you guys can review jscs for tests patches I submitted ^. It would be great if we can merge those before code changes too much. thanks [19:37:43] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:38:18] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:39:31] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:40:02] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:40:49] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:41:10] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [19:52:00] rmoen: will read your draft after lunch [19:52:01] hope that's cool [19:56:00] jdlrobson: for sure, i'm making lunch too [19:56:16] bb [20:01:40] (03PS1) 10Mhurd: Work in progress. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183615 [20:02:24] (03PS2) 10Mhurd: Lead image styling! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183615 [20:06:10] (03PS1) 10Brion VIBBER: Fix for selecting 'recent' items not in current day [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183616 [20:07:07] i'm gonna head out, will be back for a meetng later but i'm done for today [20:07:13] good night! [20:10:04] (03PS1) 10Dbrant: Don't show progress bar on top of ToC onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183618 (https://phabricator.wikimedia.org/T76932) [20:11:29] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183616 (owner: 10Brion VIBBER) [20:16:13] brion: can i assume that page id and revision id fit into a Java int (<2 billion)? [20:16:26] bearND: ….. for now [20:16:36] however revision ID could break through 2G at some point [20:16:50] lemme check the current vals [20:17:02] brion: i've seen some in the 600 millions [20:17:27] yeah, best to use a Long for safety [20:17:37] brion: ok, thanks [20:18:08] note that in PHP we use the ‘int’ type but on 64-bit linux that’s a 64-bit integer [20:18:17] and php has very sloppy typing anyway :D [20:18:33] i’m pretty sure we’ve retired out all 32-bit servers years ago [20:27:57] (03PS4) 10Bmansurov: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) [20:28:22] (03PS5) 10Bmansurov: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) [20:28:41] (03PS5) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) [20:28:54] (03PS3) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) [20:29:03] (03PS3) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) [20:29:16] (03PS3) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) [20:29:28] (03PS3) 10Bmansurov: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) [20:29:31] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:29:39] (03PS3) 10Bmansurov: Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) [20:29:43] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:30:47] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:31:44] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:31:54] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:32:37] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:33:20] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:38:12] (03PS1) 10Brion VIBBER: largestImageVariant handling changed to check for caching presence [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183624 [20:42:28] (03PS1) 10Bmansurov: Documentation: remove a wrong tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 [20:42:57] (03PS2) 10Brion VIBBER: largestImageVariant handling changed to check for caching presence [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183624 [20:43:12] (03PS1) 10Dbrant: Handle the Search button on older devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183627 (https://phabricator.wikimedia.org/T69324) [20:53:09] 3Mobile-Web: Use strict mode in javascript files - https://phabricator.wikimedia.org/T86231#964193 (10bmansurov) 3NEW [20:53:36] (03PS13) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [20:56:07] (03PS1) 10Brion VIBBER: Record thumbnail and lead-image URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183631 [20:56:52] (03PS1) 10Jdlrobson: Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) [20:58:55] Deskana: can prob fix the file page edit pencil at same time as adding gallery stuffs… [20:59:17] mhurd: Cool. Not urgent, so that sounds fine. [20:59:21] Deskana: maybe add as acceptance criteria to gallery card? [21:00:08] (03PS2) 10Brion VIBBER: Record thumbnail and lead-image URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183631 [21:00:43] (03CR) 10Jdlrobson: [C: 04-1] "This makes it a global method. I think it was trying to make it clear it's a static method of that class." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 (owner: 10Bmansurov) [21:01:21] (03CR) 10Jdlrobson: Apply jscs to specials test file (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [21:01:56] (03PS14) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [21:04:04] (03CR) 10Bmansurov: Apply jscs to specials test file (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [21:05:56] kaldari - ping [21:06:06] we're talking about tablet wikigrok in r31 [21:06:10] come help [21:06:14] arg [21:11:24] (03CR) 10Bmansurov: "That method does not belong to that class. I think I should add @ignore." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 (owner: 10Bmansurov) [21:13:38] (03PS2) 10Bmansurov: Documentation: remove wrong tags [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 [21:26:43] (03CR) 10Brion VIBBER: [C: 032] "merrrrge! fixing coming on as other commits" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183615 (owner: 10Mhurd) [21:27:15] (03PS3) 10Brion VIBBER: largestImageVariant handling changed to check for caching presence [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183624 [21:27:23] (03PS3) 10Brion VIBBER: Record thumbnail and lead-image URLs [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183631 [21:33:54] (03PS1) 10Bmansurov: Fix FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183644 [21:35:54] mhurd, brion, dr0ptp4kt: Sign up for this workshop held by yours truly at the dev summit if you're interested: https://www.mediawiki.org/wiki/MediaWiki_Developer_Summit_2015#Developing_mobile_apps.21 [21:36:10] mhurd, brion, dr0ptp4kt: One of you would need to do the iOS side of stuff anyway ;-) [21:36:14] (03PS1) 10Brion VIBBER: Return stub image objects when asked for by name [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183646 [21:37:10] 3Mobile-Web: Main menu should be represented as a View incorporated in Skin - https://phabricator.wikimedia.org/T86238#964309 (10Jdlrobson) 3NEW [21:37:14] whee [21:37:39] 3Mobile-Web: Main menu should be represented as a View incorporated in Skin - https://phabricator.wikimedia.org/T86238#964309 (10Jdlrobson) [21:37:54] (03PS6) 10Jdlrobson: WIP: Refactor: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 [21:37:56] (03PS1) 10Jdlrobson: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 [21:37:58] (03PS1) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [21:39:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [21:40:07] Deskana: mind if we change the type of pageID and revID from string to integer? [21:40:19] bearND: Herp! [21:40:40] Deskana: ok, I'll make the change [21:40:46] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor: Modules must now request page from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182294 (owner: 10Jdlrobson) [21:40:46] bearND: Thanks. :) [21:41:06] This is what happens when I spend some time doing some PHP. [21:41:18] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183624 (owner: 10Brion VIBBER) [21:41:19] I start spewing out weakly typed statements. [21:41:30] "Is it a string or an integer?" "Yes" [21:41:33] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183631 (owner: 10Brion VIBBER) [21:41:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [21:41:46] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183646 (owner: 10Brion VIBBER) [21:42:42] Deskana: another question/comment: can't get the highlighted text when the user starts highlighting due to our hack to get it relies on the clipboard (and we only use that later after the user actually clicked on our share icon) [21:43:21] bearND: That's okay. Can we still detect discrete highlighting events? [21:43:26] Deskana: added myself [21:44:11] Deskana: not in our current code; would have to research that. [21:44:38] bearND: So it's not possible to record action=highlight either? [21:45:11] Deskana: yes, we can record that the user highlighted something, just not what [21:45:27] bearND: Okay, sorry, I misunderstood. That's fine. [21:46:02] Deskana: I'll add an Android specific comment to the schema for that [21:46:23] Deskana: should we make text optional, or should I just use ""? [21:46:27] empty string [21:46:58] Probably best to make it optional [21:47:21] Deskana: sounds good [21:49:16] (03PS3) 10Brion VIBBER: Work in progress: new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [21:50:19] (03PS1) 10Bmansurov: Hygiene fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 [21:50:59] (03PS2) 10Bmansurov: Hygiene fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 [21:51:13] 3Wikipedia-App-Android-App: Text sometimes hard to read in images created by new Android sharing feature - https://phabricator.wikimedia.org/T86240#964356 (10Deskana) [21:56:57] mhurd: do we have the onboarding list for our new hires starting Monday ? [21:58:42] tfinc: will by end of day [21:59:49] dr0ptp4kt: ^ per the new hire onboarding, are there any additions/modifications to the onboarding list you’ve been using that you think we should make for the new guys? [22:01:27] 3Wikipedia-App-Android-App: Faces not aligned properly in shared images. - https://phabricator.wikimedia.org/T86242#964373 (10Dbrant) 3NEW [22:01:49] mhurd: add a 20 minute touchpoint with qa [22:01:49] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#964379 (10bearND) 3NEW [22:03:21] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#964395 (10Jdlrobson) 3NEW [22:03:52] (03PS2) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [22:03:54] (03PS2) 10Jdlrobson: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 [22:03:56] (03PS1) 10Jdlrobson: Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 [22:05:19] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#964395 (10Jdlrobson) [22:05:43] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#964411 (10Jdlrobson) [22:06:22] 3Mobile-Web: Move overlayManager and router as defined modules using M.define - https://phabricator.wikimedia.org/T86246#964413 (10Jdlrobson) 3NEW [22:06:41] 3Mobile-Web: mw.mobileFrontend should have a minimal amount of methods - https://phabricator.wikimedia.org/T86245#964395 (10Jdlrobson) [22:07:46] 3Mobile-Web: Make require and define functions on mw.mobileFrontend testable - https://phabricator.wikimedia.org/T46264#964425 (10Jdlrobson) [22:07:49] (03PS4) 10Brion VIBBER: Work in progress: new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [22:08:00] (03CR) 10Bmansurov: [C: 032] Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 (owner: 10Jdlrobson) [22:08:01] 3Mobile-Web: Make require and define functions on mw.mobileFrontend testable - https://phabricator.wikimedia.org/T46264#520388 (10Jdlrobson) [22:08:19] (03PS2) 10Jdlrobson: Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 [22:08:24] (03CR) 10Jdlrobson: [C: 032] Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 (owner: 10Jdlrobson) [22:08:30] (03PS3) 10Jdlrobson: Hygiene: Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 [22:10:59] MaxSem: any pointers on how https://gerrit.wikimedia.org/r/#/c/183370/ should work? [22:11:27] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#964429 (10Dbrant) This is because we're rejecting prefix results if there's fewer than 5 of them. I've seen this issue in other searches, such as "cnidar" -- I would expect to see the phylum "cnidari... [22:11:56] kaldari: let me answer to nuria's email [22:12:14] (03PS5) 10Brion VIBBER: Work in progress: new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [22:12:19] leila: What are you planning to say? [22:12:42] she said yesterday that she doesn't feel comfortable with events going over 400/sec [22:12:58] it's important for us to get all the data we can at this point [22:13:22] I'm trying to figure out if we can get away with sampling [22:13:26] leila: the code has to be finalized and merged before 4pm, BTW [22:13:37] yeah [22:13:43] let me see what I can do [22:13:49] how much time do you need? [22:14:00] leila: are you guys on the other side of the office? [22:14:04] yeah [22:14:05] ;-) [22:14:08] I’ll come over [22:14:08] walking to your desk [22:14:34] 3Wikipedia-App-Android-App: Faces not aligned properly in shared images. - https://phabricator.wikimedia.org/T86242#964432 (10Dbrant) tracked: https://trello.com/c/PpJbnGNd/24-faces-not-aligned-properly-in-shared-images [22:14:41] (03PS1) 10BearND: Event logging for ShareAFact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183708 [22:17:29] 3Wikipedia-App-iOS-App: [iOS app] Long math formulas are cut off - https://phabricator.wikimedia.org/T68680#964448 (10Deskana) 5Open>3Resolved a:3Deskana We double-checked this and it appears to be resolved. Please re-open this if you're still experiencing the issue. [22:19:54] 3Wikipedia-App-iOS-App: Wikipedia App: [iOS] After removing a page from "Recents" section, loading that same article from Search or Saved Pages does not activate the page navigation at the bottom for that article - https://phabricator.wikimedia.org/T74987#964467 (10Deskana) @Ryasmeen We believe this is fixed n... [22:23:32] 3Wikipedia-App-iOS-App: iOS App: App sometimes loads cached versions of pages instead of loading new ones - https://phabricator.wikimedia.org/T70230#964503 (10Deskana) To clarify, only these navigation events should remember your scroll position: [ ] Navigating to a page via recent [ ] Navigating to a page via s... [22:25:36] (03CR) 10Bmansurov: [C: 04-1] "Please update the extensions/MobileFrontend/MobileFrontend.php and remove Mantle related stuff from there too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [22:26:25] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#964547 (10bearND) Unless @Manybubbles has a better idea I suggest combining the prefix results and the full text results (while removing dups). [22:27:49] (03CR) 10MaxSem: Always enable red links in alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [22:27:53] (03PS6) 10Brion VIBBER: Old->new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [22:28:07] 3Wikipedia-App-iOS-App: iOS App: make "Username", "Password" and "Confirm password" fields required in order to submit account creation request - https://phabricator.wikimedia.org/T68944#964556 (10Deskana) [22:32:07] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#964584 (10bearND) @Manybubbles: It seems to me that the search generator finds only complete words. What happened to search suggestions? Here is the API request we sent off for the above search term... [22:35:01] (03CR) 10Bmansurov: [C: 04-1] Add tests for define and require methods (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [22:43:51] (03PS1) 10Brion VIBBER: Fix our navigation time update hack for back/forward [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183711 [22:44:14] (03CR) 10Bmansurov: [C: 04-1] Hygiene: move loadModule to its own module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [22:50:56] (03CR) 10Bmansurov: [C: 031] "While you're at it I think you can define 'pageApi' (an instance of PageApi) in the PageApi.js file and then not expose the PageApi class." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [22:59:19] dbrant|brb: mhurd: kaldari: how are you DevSummit thoughts coming together? anything that i can do to help ? [22:59:27] mhurd: thanks on the onboarding [22:59:34] (03PS1) 10Kaldari: Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183712 [23:00:34] tfinc: coming along. ok to ping you in a bit to read it over? [23:00:43] mhurd: sure [23:01:10] tfinc: Besides the plenary, how many break-out sessions are we responsible for and do we need to introduce all of them through the plenary? [23:01:15] (03CR) 10Bmansurov: [C: 04-1] "This change breaks icons in alpha. http://imgur.com/ugqmL8e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [23:01:36] Hey Deskana! I checked https://phabricator.wikimedia.org/T74987 in the latest beta build (4.0.5.8), its still broken I see [23:01:49] kaldari: no set number, we can use as many as we need and think would be useful [23:02:05] kaldari: not everything has to be connect with the plenary but it would be nice to have a bridge [23:02:09] connected* [23:02:20] tfinc: got it [23:03:00] (03PS1) 10MaxSem: Show for anons by default, import classes [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183713 [23:03:09] kaldari, ^^^ [23:04:09] ryasmeen: Yeah, when our next TestFlight build goes out I'd appreciate if you could test it then. :) [23:06:58] (03CR) 10Kaldari: [C: 032] Show for anons by default, import classes [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183713 (owner: 10MaxSem) [23:07:24] (03Merged) 10jenkins-bot: Show for anons by default, import classes [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183713 (owner: 10MaxSem) [23:08:26] (03CR) 10MaxSem: [C: 032] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183712 (owner: 10Kaldari) [23:09:46] (03Merged) 10jenkins-bot: Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183712 (owner: 10Kaldari) [23:11:19] (03PS1) 10MaxSem: Show for anons by default, import classes [extensions/WikiGrok] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183719 [23:11:28] (03CR) 10MaxSem: [C: 032] Show for anons by default, import classes [extensions/WikiGrok] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183719 (owner: 10MaxSem) [23:11:55] (03Merged) 10jenkins-bot: Show for anons by default, import classes [extensions/WikiGrok] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183719 (owner: 10MaxSem) [23:12:01] okay Deskana, will do :) [23:12:08] (03PS1) 10MaxSem: Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 [23:12:17] (03CR) 10MaxSem: [C: 032] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:14:48] (03CR) 10jenkins-bot: [V: 04-1] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:19:11] (03CR) 10Bmansurov: [C: 04-1] "Minor typos, etc." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [23:21:31] dbrant: i’m writing up some stuff. i’ll paste back into ether pad in 30 min or so. lost some text when my connection flaked so i took it offline for a bit... [23:22:16] mhurd: ok, I'll add my stuff to it, as well [23:24:35] (03CR) 10MaxSem: [C: 04-2] "recheck" [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:24:43] (03CR) 10MaxSem: [C: 032] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:29:09] (03CR) 10jenkins-bot: [V: 04-1] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:29:54] jdlrobson, any ideas why ^^^ is failing? [23:30:02] jdlrobson, ergh [23:30:15] sorry for colors:) [23:32:35] kaldari: https://gerrit.wikimedia.org/r/183281 [23:32:45] bearND: Are we just using the default font for the Tweet a Fact cards? [23:33:03] Deskana: default serif font [23:33:25] Deskana: default font would be san-serif [23:33:28] sans [23:33:37] bearND: Great. Thanks. [23:35:13] Deskana: fyi, right now I'm trying to get the same image at the top of it as used for the lead image. So I get the correct face adjustment and title/description treatment [23:35:27] (03PS1) 10Kaldari: Allow query string overrides even when user isn't in sample [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183726 [23:35:37] bearND: Sweet. [23:35:44] jdlrobson: https://gerrit.wikimedia.org/r/#/c/183726/ [23:36:05] (03PS1) 10MaxSem: Don't cache strictEqual and deepEqual - causing errors with QUnit [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183727 [23:36:13] (03CR) 10MaxSem: [C: 032] Don't cache strictEqual and deepEqual - causing errors with QUnit [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183727 (owner: 10MaxSem) [23:38:00] (03Merged) 10jenkins-bot: Don't cache strictEqual and deepEqual - causing errors with QUnit [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183727 (owner: 10MaxSem) [23:38:08] jdlrobson: https://gerrit.wikimedia.org/r/#/c/183726/ [23:38:24] (03PS2) 10MaxSem: Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 [23:38:40] (03CR) 10MaxSem: [C: 04-2] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:38:46] (03CR) 10MaxSem: [C: 032] Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:40:05] (03CR) 10Jdlrobson: [C: 032] Allow query string overrides even when user isn't in sample [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183726 (owner: 10Kaldari) [23:40:51] MaxSem: so we need to cherry-pick this too: https://gerrit.wikimedia.org/r/#/c/183726/ [23:41:07] 3Mobile-Web: modes.js should be moved into a Context.js to be consistent with PHP - https://phabricator.wikimedia.org/T85572#964748 (10bmansurov) a:3bmansurov [23:41:42] (03Merged) 10jenkins-bot: Throttling WikiGrok to 16% of users for upcoming reader test [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183720 (owner: 10MaxSem) [23:44:18] (03Merged) 10jenkins-bot: Allow query string overrides even when user isn't in sample [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183726 (owner: 10Kaldari) [23:46:16] (03PS1) 10MaxSem: Allow query string overrides even when user isn't in sample [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183730 [23:46:25] (03CR) 10MaxSem: [C: 032] Allow query string overrides even when user isn't in sample [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183730 (owner: 10MaxSem) [23:49:25] dbrant, bearND: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8054915 [23:50:34] (03Merged) 10jenkins-bot: Allow query string overrides even when user isn't in sample [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183730 (owner: 10MaxSem) [23:50:48] Krenair: that is already fixed in the beta app [23:50:49] Krenair: the screenshot is *not* the new app [23:51:07] MaxSem: We will need https://gerrit.wikimedia.org/r/#/c/181208/ as well [23:51:22] ok, I'll tell them to try beta [23:51:40] (but thanks for getting that info!) [23:52:32] (03PS1) 10BearND: Fix crash in Find in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183737 [23:52:34] (03PS1) 10BearND: Enable ShareAFact only in alpha releases [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183738 [23:59:14] kaldari, where are you? [23:59:25] mhurd: we could just post our comments separately in the phab thread... [23:59:41] OuKB: elevator to 6