[00:00:28] OuKB: don’t forget https://gerrit.wikimedia.org/r/#/c/181208/ as well in the submodule update [00:00:31] dbrant: would you have time in 45 min or so to sync up a bit first? [00:01:20] mhurd: yep, sure [00:01:22] dbrant: i have meeting for next half hr, but then i’m free. i think i’d need about 15 more minutes to wrap up what i’ve been writing… [00:06:00] (03CR) 10Dbrant: [C: 032] Enable ShareAFact only in alpha releases [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183738 (owner: 10BearND) [00:15:25] dr0ptp4kt: Have you ever written unit tests in MediaWiki? I got some review of that patch that I made for core and it suggested I add unit tests, but I'm a bit lost where to start. [00:17:28] (03CR) 10Dbrant: [C: 032] Event logging for ShareAFact [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183708 (owner: 10BearND) [00:23:29] (03CR) 10Dbrant: [C: 032] Fix crash in Find in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183737 (owner: 10BearND) [00:30:55] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: VisualEditor broken for MobileFrontend - https://phabricator.wikimedia.org/T78710#964864 (10Etonkovidova) VE works in Mobile betalabs/test2. [00:32:49] 3Mobile-Web, VisualEditor: Mobile VisualEditor won't load (this.getSurface(...) is undefined) - https://phabricator.wikimedia.org/T85897#964866 (10Etonkovidova) [00:33:29] 3VisualEditor-MediaWiki-Mobile, Mobile-Web, VisualEditor: [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web - https://phabricator.wikimedia.org/T84897#964867 (10Etonkovidova) [00:39:11] (03PS1) 10Mhurd: Small tweaks per Vibha to lead image styling layout. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183751 [00:44:21] 3Editing, Mobile-Web, VisualEditor: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing - https://phabricator.wikimedia.org/T85480#964896 (10Etonkovidova) [00:44:23] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Will upload a new ps tomorrow i think :)" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [00:46:06] (03PS3) 10Bmansurov: Documentation updates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 [00:59:49] 3Mobile-Web: Language menu (of pages) should show variants based on page language instead of site language - https://phabricator.wikimedia.org/T68159#964950 (10kaldari) This sounds like 2 completely different bugs. Please split off a separate bug for Issue #1. [01:00:44] mhurd: sync? [01:00:51] dbrant: 5min? [01:00:54] almost done... [01:01:00] yep [01:04:22] 3Mobile-Web: Language menu (of pages) should show variants based on page language instead of site language - https://phabricator.wikimedia.org/T68159#964961 (10Jdlrobson) 5Open>3Invalid a:3Jdlrobson Yeh this seems to have got confusing and unactionable :-(. If there is still an issue(s) could you raise pha... [01:16:49] (03CR) 10Bmansurov: Add Possibility to add categories to a page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [01:17:04] (03CR) 10Bmansurov: [C: 031] "sorry, didn't mean to -1." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [01:18:02] (03CR) 10Bmansurov: [C: 04-1] "heh, i guess, i'm tired. i'll +1 after you push your changes ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 (owner: 10Florianschmidtwelzow) [01:23:13] (03PS1) 10Dbrant: Add back-button behavior to Share context. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183753 [01:25:02] (03CR) 10jenkins-bot: [V: 04-1] Add back-button behavior to Share context. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183753 (owner: 10Dbrant) [01:26:26] (03PS2) 10Dbrant: Add back-button behavior to Share context. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183753 [01:29:01] 3Mobile-Web: Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER) - https://phabricator.wikimedia.org/T86281#965014 (10Krinkle) 3NEW [01:33:00] (03PS1) 10Bmansurov: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [01:40:30] mhurd: dbrant: thanks for getting your info in. i'll be reviewing tonight [01:40:37] kaity|away: how is yours looking ? [01:41:08] err [01:41:22] kaldari: jdlrobson: how go your additions for mobile web ? [01:41:38] ? [01:43:02] kaldari: https://phabricator.wikimedia.org/T85151 [01:43:49] tfinc: sorry, working on wikigrok deployment [01:44:09] kaldari: ok. i'll be online later to review what we have so let me know if you need anything else from me [02:02:02] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: The Wikipedia app should handle Wiktionary links better - https://phabricator.wikimedia.org/T86283#965061 (10Deskana) 3NEW [02:03:31] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: The Wikipedia app should handle Wiktionary links better - https://phabricator.wikimedia.org/T86283#965061 (10Deskana) p:5Triage>3Low Not a priority right now. [02:07:00] (03PS1) 10Kaldari: Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183761 [02:07:22] MaxSem: https://gerrit.wikimedia.org/r/#/c/183761/ [02:07:58] (03PS1) 10MaxSem: Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183762 [02:08:06] (03CR) 10MaxSem: [C: 032] Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183762 (owner: 10MaxSem) [02:08:47] (03PS1) 10MaxSem: Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183763 [02:08:55] (03CR) 10MaxSem: [C: 032] Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183763 (owner: 10MaxSem) [02:10:28] (03Merged) 10jenkins-bot: Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183762 (owner: 10MaxSem) [02:10:30] (03CR) 10jenkins-bot: [V: 04-1] Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183763 (owner: 10MaxSem) [02:19:49] MaxSem: https://gerrit.wikimedia.org/r/#/c/183766/ [02:26:07] (03CR) 10MaxSem: [C: 04-2] Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183763 (owner: 10MaxSem) [02:26:22] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183763 (owner: 10MaxSem) [02:37:52] (03Merged) 10jenkins-bot: Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/183763 (owner: 10MaxSem) [02:57:49] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#965105 (10Manybubbles) > @Manybubbles: It seems to me that the search generator finds only complete words. What happened to search suggestions? When you switched to the generator you lost it. Looks... [05:00:55] (03CR) 10Jdlrobson: Hygiene: Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 (owner: 10Jdlrobson) [05:01:07] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 (owner: 10Jdlrobson) [05:03:11] (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary init function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183704 (owner: 10Jdlrobson) [06:20:41] (03PS2) 10BearND: Improve list of media items shown in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183569 (https://phabricator.wikimedia.org/T86073) (owner: 10Dbrant) [06:20:50] (03CR) 10BearND: [C: 032] Improve list of media items shown in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183569 (https://phabricator.wikimedia.org/T86073) (owner: 10Dbrant) [06:23:09] (03Merged) 10jenkins-bot: Improve list of media items shown in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183569 (https://phabricator.wikimedia.org/T86073) (owner: 10Dbrant) [06:37:32] (03CR) 10BearND: [C: 04-1] "See my comment in https://gerrit.wikimedia.org/r/#/c/183555/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) (owner: 10Dbrant) [06:38:16] (03PS3) 10BearND: Change URLs to point to mobile version of sites specifically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) (owner: 10Deskana) [06:38:21] (03CR) 10BearND: [C: 032] Change URLs to point to mobile version of sites specifically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) (owner: 10Deskana) [06:39:46] (03Merged) 10jenkins-bot: Change URLs to point to mobile version of sites specifically. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183411 (https://phabricator.wikimedia.org/T85062) (owner: 10Deskana) [06:47:49] (03PS2) 10BearND: Don't show progress bar on top of ToC onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183618 (https://phabricator.wikimedia.org/T76932) (owner: 10Dbrant) [06:48:12] (03CR) 10BearND: [C: 032] Don't show progress bar on top of ToC onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183618 (https://phabricator.wikimedia.org/T76932) (owner: 10Dbrant) [06:48:31] (03Merged) 10jenkins-bot: Don't show progress bar on top of ToC onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183618 (https://phabricator.wikimedia.org/T76932) (owner: 10Dbrant) [06:56:16] (03CR) 10BearND: [C: 04-1] Handle the Search button on older devices. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183627 (https://phabricator.wikimedia.org/T69324) (owner: 10Dbrant) [06:58:36] 3Wikipedia-App-Android-App: Link to mobile Zero FAQ instead of desktop - https://phabricator.wikimedia.org/T85062#965301 (10Deskana) 5Open>3Resolved a:3Deskana [06:58:47] 3Wikipedia-App-Android-App: Opening ToC for the first time on a very slow connection causes loading indicator to show on top of ToC onboarding - https://phabricator.wikimedia.org/T76932#965303 (10Deskana) 5Open>3Resolved a:3Deskana [07:00:49] (03PS3) 10BearND: Add back-button behavior to Share context. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183753 (owner: 10Dbrant) [07:01:04] (03CR) 10BearND: [C: 032] "Good call!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183753 (owner: 10Dbrant) [07:01:27] (03Merged) 10jenkins-bot: Add back-button behavior to Share context. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183753 (owner: 10Dbrant) [09:45:03] yo [09:52:03] hi phuedx [09:52:16] hey joakino [10:36:42] phuedx: lol look at the first comment [10:36:43] https://gerrit.wikimedia.org/r/#/c/183766/ [10:40:24] lol lol lol [10:55:20] i don't even... [10:55:44] that patch is old and was merged to mantle a week or so ago [11:11:33] (03CR) 10Phuedx: "This patch should be abandoned now, right?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183761 (owner: 10Kaldari) [11:12:22] joakino: so what did you do before wmf? [11:12:36] curious given what we were talking about last night during the meeting [11:13:10] i worked for ohim for a few years, the trademarks and designs office of the EU [11:13:58] doing the same sort of thing? [11:14:14] y'know, https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z was down to one page yesterday [11:15:27] phuedx: doing frontend web development, javascript applications, etc [11:15:31] pretty frontend focused [11:18:54] i'll help out later, i'm with something since yesterday [11:20:07] joakino: sorry, i wasn't asking you to stop what you're doing [11:20:12] i was grumbling [11:20:43] phuedx: yea i know, but i feel bad since in the last 2 or 3 days i haven't had much time to review [11:20:57] new stuff!!! [11:21:10] a bit chaotic now [11:25:38] (03CR) 10Phuedx: "I haven't tested this yet but I've got to ask: why isn't the BC layer inside of the ApiResult class? That way you might not have to manage" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [11:29:42] (03CR) 10Phuedx: [C: 032] "The @ignore is fine as the futureLog method is also tagged with it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 (owner: 10Bmansurov) [11:31:54] (03Merged) 10jenkins-bot: Documentation updates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183626 (owner: 10Bmansurov) [12:13:01] (03CR) 10Phuedx: [C: 04-1] "A couple of minors inline." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [12:33:14] (03PS1) 10Jhernandez: WIP: Implement infinite scroll independently [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 [12:53:44] lolz // PHP is stupid. strict test to avoid issues when page '0' is watched. [13:13:52] (03PS2) 10Phuedx: Fix FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183644 (owner: 10Bmansurov) [13:14:14] (03CR) 10Phuedx: "PS2 updates the commit message." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183644 (owner: 10Bmansurov) [13:21:40] (03CR) 10Phuedx: [C: 032] Fix FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183644 (owner: 10Bmansurov) [13:22:15] out for lunch [13:23:03] (03Merged) 10jenkins-bot: Fix FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183644 (owner: 10Bmansurov) [14:34:32] (03PS5) 10Phuedx: Run JSCS agains the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [14:35:32] (03CR) 10Phuedx: "… I forgot to change the Change-Id. Whoops!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [14:35:48] (03PS1) 10Phuedx: Run JSCS agains the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) [14:36:02] (03CR) 10jenkins-bot: [V: 04-1] Run JSCS agains the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [14:36:54] (03PS2) 10Dbrant: Handle the Search button on older devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183627 (https://phabricator.wikimedia.org/T69324) [14:37:23] (03PS6) 10Phuedx: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [14:37:57] (03CR) 10Phuedx: "… I'm a professional." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [14:38:28] (03CR) 10jenkins-bot: [V: 04-1] Run JSCS agains the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [14:38:46] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [14:39:24] (03CR) 10Phuedx: [C: 04-2] "Head on over to Ic5b06195041716f06ae7fef065629ad15f2107e8 to take part in the chatty-chats." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [14:48:47] (03PS3) 10Dbrant: No longer hide hatnotes in non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) [14:49:31] (03CR) 10Dbrant: "@BearND good call!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) (owner: 10Dbrant) [15:15:06] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#965756 (10Addshore) For example https://upload.wikimedia.org/wikipedia/commons/thumb/c/c9/Fuerteventura_sun... [16:58:48] (03PS3) 10BearND: Handle the Search button on older devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183627 (https://phabricator.wikimedia.org/T69324) (owner: 10Dbrant) [16:58:54] (03CR) 10BearND: [C: 032] Handle the Search button on older devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183627 (https://phabricator.wikimedia.org/T69324) (owner: 10Dbrant) [17:01:17] (03Merged) 10jenkins-bot: Handle the Search button on older devices. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183627 (https://phabricator.wikimedia.org/T69324) (owner: 10Dbrant) [17:02:04] (03PS4) 10BearND: No longer hide hatnotes in non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) (owner: 10Dbrant) [17:02:12] (03CR) 10BearND: [C: 032] No longer hide hatnotes in non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) (owner: 10Dbrant) [17:02:20] (03CR) 10Bmansurov: Hygiene fixes (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [17:02:34] (03Merged) 10jenkins-bot: No longer hide hatnotes in non-lead sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183553 (https://phabricator.wikimedia.org/T85985) (owner: 10Dbrant) [17:03:16] (03PS1) 10Dbrant: Fix a few issues in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183877 (https://phabricator.wikimedia.org/T68612) [17:05:56] 3Wikipedia-App-Android-App: Handle the "Search" key (on 2.x devices) - https://phabricator.wikimedia.org/T69324#966015 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:06:30] 3Mobile-Apps, Wikipedia-App-Android-App: The mobile app should display hatnotes in article sections - https://phabricator.wikimedia.org/T85985#966017 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:06:53] 3Wikipedia-App-Android-App: Image viewer should not display pictures like the feature article star in the gallery view - https://phabricator.wikimedia.org/T86073#966019 (10Dbrant) 5Open>3Resolved a:3Dbrant [17:10:20] (03CR) 10Bmansurov: Hygiene fixes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [17:13:07] (03PS2) 10Dbrant: Fix a few issues in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183877 (https://phabricator.wikimedia.org/T68612) [17:27:55] (03CR) 10Jdlrobson: Apply jscs to specials test file (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:28:36] (03PS6) 10Jdlrobson: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:29:12] (03CR) 10Jdlrobson: [C: 04-1] "This will have to be merged last as it won't merge until the errors are fixed :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:29:50] (03PS7) 10Jdlrobson: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:30:08] (03PS8) 10Jdlrobson: Hygiene: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:30:15] jdlrobson: yes we should start merging with this patch https://gerrit.wikimedia.org/r/#/c/183602/ [17:31:22] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:31:29] (03PS6) 10Jdlrobson: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:31:37] (03PS7) 10Jdlrobson: Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:32:26] (03PS4) 10Jdlrobson: Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:32:32] (03PS5) 10Jdlrobson: Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:32:42] (03PS4) 10Jdlrobson: Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:32:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:32:56] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:33:40] (03PS8) 10Jdlrobson: Hygiene: Apply jscs to editor, issues, language, lastEdited [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:34:46] (03Merged) 10jenkins-bot: Hygiene: Apply jscs to first level test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183412 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:35:33] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs to editor, issues, language, lastEdited [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:35:40] (03PS6) 10Jdlrobson: Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:35:52] (03PS7) 10Jdlrobson: Hygiene: Apply jscs to mediaViewer,nearby,preferred languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:36:52] (03Merged) 10jenkins-bot: Hygiene: Apply jscs to editor, issues, language, lastEdited [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183538 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:36:55] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs to mediaViewer,nearby,preferred languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:37:10] (03PS5) 10Jdlrobson: Hygiene: Apply jscs to references,search and talk tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:37:18] (03PS6) 10Jdlrobson: Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:37:23] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Apply jscs to some module test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:37:26] (03PS8) 10Jdlrobson: Hygiene: Apply jscs to mediaViewer,nearby,preferred languages tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:37:35] (03CR) 10Jdlrobson: [C: 031] Hygiene: Apply jscs to mediaViewer,nearby,preferred languages tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:37:42] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs to mediaViewer,nearby,preferred languages tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:38:34] (03PS7) 10Jdlrobson: Hygiene: Apply jscs rules to search,talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:38:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Apply jscs rules to search,talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:38:57] (03PS4) 10Jdlrobson: Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:39:03] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:39:12] (03PS5) 10Jdlrobson: Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:39:14] (03Merged) 10jenkins-bot: Hygiene: Apply jscs to mediaViewer,nearby,preferred languages tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183559 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:39:46] (03CR) 10Jdlrobson: [C: 032] Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:39:53] (03PS6) 10Jdlrobson: Hygiene: Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:39:59] (03CR) 10Jdlrobson: [C: 031] Hygiene: Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:40:05] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:40:40] (03PS4) 10Jdlrobson: Hygiene: Apply jscs rules to wikigrok,lists,watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:40:45] (03PS5) 10Jdlrobson: Hygiene: Apply jscs rules to wikigrok,lists,watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:40:56] (03PS4) 10Jdlrobson: Hygiene" Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:41:00] (03PS5) 10Jdlrobson: Hygiene" Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:41:49] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs rules to wikigrok,lists,watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:42:20] (03Merged) 10jenkins-bot: Hygiene: Apply jscs to toggling and uploads tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183565 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:42:22] (03CR) 10Jdlrobson: [C: 032] Hygiene" Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:42:46] (03CR) 10BearND: [C: 032] "Minor comment inline. LGTM." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183877 (https://phabricator.wikimedia.org/T68612) (owner: 10Dbrant) [17:43:36] (03Merged) 10jenkins-bot: Fix a few issues in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183877 (https://phabricator.wikimedia.org/T68612) (owner: 10Dbrant) [17:43:46] (03Merged) 10jenkins-bot: Hygiene: Apply jscs rules to wikigrok,lists,watchstar tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183570 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:44:18] (03Merged) 10jenkins-bot: Hygiene" Apply jscs to specials test file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:50:18] (03CR) 10Jdlrobson: [C: 04-1] "Can you make the commit message headline a bit clearer?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [17:50:53] (03PS2) 10Jhernandez: WIP: Implement infinite scroll independently [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 [17:52:03] (03PS3) 10Bmansurov: Hygiene: optional arguments, jQuery selectors, hasOwnProperty and other fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 [17:54:38] (03CR) 10Jdlrobson: Hygiene: optional arguments, jQuery selectors, hasOwnProperty and other fixes (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [17:55:02] (03CR) 10Jdlrobson: "See my comments" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [17:55:17] (03PS7) 10Jdlrobson: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:55:28] (03CR) 10Jdlrobson: "Just waiting on other patch so we can merge" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:56:51] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [17:57:52] (03CR) 10Jdlrobson: "@bmansurov No that will be in a separate patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [17:58:26] (03CR) 10Jdlrobson: "(https://gerrit.wikimedia.org/r/182957 hasnt been merged yet so the dependency remains)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [18:03:21] (03CR) 10Jdlrobson: [C: 031] "Nice! However merges (probably me) must check this doesn't have caching problems before doing so using /dev-scripts/cachedpage.sh" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [18:03:52] bmansurov: see my comment on https://gerrit.wikimedia.org/r/182956 [18:04:09] be patient for the Mantle references being removed ;-) I'm hoping @kaldari will have time today [18:05:13] (03CR) 10Jdlrobson: [C: 031] "looks fine but someone will need to check it out and check none of the core apis we use for our main workflows are not impacted" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [18:05:54] (03Abandoned) 10Kaldari: Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183761 (owner: 10Kaldari) [18:06:07] (03CR) 10Jdlrobson: Add tests for define and require methods (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [18:06:20] 3Wikipedia-App-Android-App: Unchecked checkboxes aren't visible in dark theme - https://phabricator.wikimedia.org/T85809#966219 (10bearND) Cannot repro on my 2.3 and 5.0 devices, only on 4.1.1. [18:08:31] (03PS7) 10Jdlrobson: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) [18:09:32] (03PS3) 10Jdlrobson: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 [18:09:33] (03CR) 10Jdlrobson: Hygiene: move loadModule to its own module (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [18:09:43] (03PS3) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [18:10:19] bmansurov: https://gerrit.wikimedia.org/r/#/c/183562/ is gonna need a rebase and please remove -1 from https://gerrit.wikimedia.org/r/182956 [18:10:21] 3Wikipedia-App-Android-App: Does not display "Main article" or "See also" templates - https://phabricator.wikimedia.org/T85375#966229 (10bearND) 5Open>3Resolved a:3bearND fixed by https://gerrit.wikimedia.org/r/#/c/183553/ [18:10:25] heading to meeting back soon [18:12:34] (03CR) 10Anomie: "If by that you mean things hitting api.php with format=json, there shouldn't be any changes due to any of the patches that come up when yo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183589 (owner: 10Anomie) [18:16:43] (03CR) 10Bmansurov: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [18:17:43] dbrant [18:17:48] join the cool club [18:18:28] kristenlans: mtg w tomasz [18:21:46] dbrant 10-4 [18:22:43] (03PS4) 10Bmansurov: Hygiene: optional arguments, jQuery selectors, hasOwnProperty and other fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 [18:25:06] (03PS8) 10Bmansurov: Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) [18:25:08] (03PS8) 10Bmansurov: Hygiene: Apply jscs rules to search,talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) [18:26:30] (03CR) 10jenkins-bot: [V: 04-1] Apply jscs to test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [18:27:16] (03CR) 10Krinkle: [C: 04-1] Apply jscs to test files (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [18:27:31] (03CR) 10Phuedx: Hygiene: optional arguments, jQuery selectors, hasOwnProperty and other fixes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [18:27:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Apply jscs rules to search,talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [18:28:40] (03PS9) 10Bmansurov: Hygiene: Enable jscs for test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) [18:29:41] (03CR) 10Phuedx: Hygiene" Apply jscs to specials test file (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183602 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [18:30:10] bbiab [18:30:19] jdlrobson, bmansurov: i forgot to post this comment to that change [18:30:22] (03PS9) 10Bmansurov: Hygiene: Apply jscs rules to search, talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) [18:30:22] "So here's one way of specifying a different configuration for a different set of files: https://gerrit.wikimedia.org/r/#/c/183854/" [18:30:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Enable jscs for test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [18:31:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Apply jscs rules to search, talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [18:32:02] bearND, kristenlans: You two were stuck in a loop saying bye to each other this time. [18:32:24] Yes! [18:32:43] We need to start recording those and make a dance song mashup [18:32:45] And, sorry I keep being late to the standup. This train used to be pretty good for getting me to the standup on time but given that it's failed every single time this week I guess I'm going to have to get an earlier one. [18:33:34] jdlrobson, bmansurov: basically, jscs can load javascript configuration files [18:33:47] so you create a js config file that reads a base file and modifies it slightly [18:34:04] because, annoyingly, jscs won't accept jsDoc: false as a setting :( [18:34:23] kristenlans: Deskana: hope we can get some good recordings so we can play some at the dev summit [18:34:28] phuedx: looks good, we need to remove the first jscs comment line in test files and apply your patch [18:34:47] bmansurov: it was annoyingly hard to figure out [18:34:56] brion: Here's the patch: https://gerrit.wikimedia.org/r/#/c/182886/ [18:34:59] brion: Thank you! :) [18:35:00] phuedx: i hear you [18:35:12] i'm fairly certain the jscs javascript config file thing is undocumented [18:35:18] i didn't see it mentioned [18:36:16] (03PS10) 10Bmansurov: Hygiene: Apply jscs rules to search, talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) [18:37:30] bmansurov: i'd rather you get the test stuff merged [18:37:31] phuedx: I think we just followed jscs-jsdoc extension readme [18:37:47] bmansurov: don't get me started on that… [18:38:10] phuedx: ;) I've left two patches to merge, then we'll merge yours [18:38:19] cool.io [18:38:32] i wish i owned that domain [18:38:40] i'd be paralysed by the number of things i could do with it [18:38:45] but it'd be cool.io [18:40:06] jdlrobson: are you a-merging those test patches [18:40:09] ? [18:40:26] phuedx, jdlrobson can we merge https://gerrit.wikimedia.org/r/#/c/183703/2 ? I've addressed your comments [18:40:51] i'll take another look [18:40:54] jdlrobson: ^ [18:41:09] thanks [18:43:37] (03CR) 10Bmansurov: [C: 032] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [18:44:19] bmansurov: re: the force parameter, remove it in a separate patch if you want [18:44:32] phuedx: i will [18:46:21] noted on the patch [18:46:40] (03CR) 10Bmansurov: [C: 032] Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [18:55:20] (03PS15) 10Florianschmidtwelzow: Add Possibility to add categories to a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180880 [18:58:21] (03CR) 10Brion VIBBER: [C: 032] Small tweaks per Vibha to lead image styling layout. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183751 (owner: 10Mhurd) [18:59:53] (03CR) 10Phuedx: [C: 032] Hygiene: optional arguments, jQuery selectors, hasOwnProperty and other fixes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [18:59:56] (03PS2) 10Brion VIBBER: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182087 (owner: 10BearND) [19:00:11] (03Abandoned) 10Brion VIBBER: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182087 (owner: 10BearND) [19:01:10] alright folks [19:01:12] g'night [19:01:21] have lovely weekends y'all [19:01:58] (03PS3) 10Brion VIBBER: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (https://phabricator.wikimedia.org/T85243) (owner: 10Deskana) [19:05:06] (03Merged) 10jenkins-bot: Hygiene: optional arguments, jQuery selectors, hasOwnProperty and other fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183703 (owner: 10Bmansurov) [19:08:28] https://etherpad.wikimedia.org/p/app_q3_planning [19:10:52] (03PS4) 10Brion VIBBER: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (https://phabricator.wikimedia.org/T85243) (owner: 10Deskana) [19:11:23] (03CR) 10Brion VIBBER: "Ok this version might work. Or it might explode. Need monte to review the network changes :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (https://phabricator.wikimedia.org/T85243) (owner: 10Deskana) [19:21:04] * Ironholds high-fives jdlrobson [19:22:38] Ironholds: :-) please do feed me this sort of data. I'd join a mailing list or subscribe to a blog/wiki page purely to get these points of information [19:22:55] agreed! I think that could be really cool. [19:22:58] whole point of research is to fuel development no rather than guess work? [19:23:26] I'd love to get, like, halfak, haitham, asaf, a few others, just pumping out every bit of localised trivia they discover somewhere. [19:23:41] jdlrobson, here's one I've got off the top of my head; mobile usage tanks in Indonesia on the weekend. [19:24:01] Because it's an Islamic country, but it's unique in Islamic countries in still following the Sabbath, culturally, rather than just doing Friday prayers. [19:24:02] awww [19:24:15] (03CR) 10Florianschmidtwelzow: [C: 031] "+1 to bmansurov's comment :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [19:24:23] conversation fork time Ironholds! [19:24:37] yup! [19:24:38] you missed: [19:24:43] jdlrobson, here's one I've got off the top of my head; mobile usage tanks in Indonesia on the weekend. [19:24:45] Because it's an Islamic country, but it's unique in Islamic countries in still following the Sabbath, culturally, rather than just doing Friday prayers. [19:24:58] DarTar, ^ btw [19:25:01] remember the trend we saw in Indonesia? That's why. [19:25:22] it acts uniquely within the generalised pool of "predominently Muslim cultures" in terms of temporal availability. [19:26:31] (and, well, uniquely within the pool of "countries") [19:27:36] Ironholds: see mail thread "Central repository of research results" [19:27:48] I don't see it yet :(. What list? [19:28:09] rmoen: nice wikitech post [19:28:16] rmoen: keen to see what people say [19:28:31] Ironholds: i just sent it to staff [19:28:32] jdlrobson: thanks for your input on making it happen [19:28:42] i'm excited to see the response [19:28:43] yay! [19:28:46] rmoen: i did have a thought actually that might blow your mind [19:29:11] blow on [19:29:20] rmoen: "hey wikidata give me all things that are an instance of https://www.wikidata.org/wiki/Q3220391" [19:29:34] rmoen: hey wikidata whats the share url property for that thing? [19:29:43] awesome [19:29:51] rmoen: how many users does that thing have? is it popular [19:30:25] might be a good approach to being agnostic to services [19:30:27] cc joakino [19:31:39] jdlrobson: that seems like it could be acceptable from the community [19:31:51] objective data from wikidata which is community based [19:32:16] great idea 👍😁 [19:32:59] jdlrobson: we will probably need to add that data ourselves [19:33:51] jdlrobson, MaxSem: with change https://gerrit.wikimedia.org/r/#/c/183763/ we break all icons in alpha for two wmf versions (for 11 days on wikipedias). Maybe we should commit a change to use less for alpha icons on wmf13 and wmf14? [19:36:03] FlorianSW: yeh our plan was to investigate that today for a fix for monday [19:36:10] kaldari hit some issues during deployment [19:36:22] and this was the easiest fix to make. Thanks for the reminder i'll chat to him now [19:36:49] ok :) it's just alpha, but 11 days feels strange with a broken ui without icons :P [19:39:31] alright i'm calling it for today [19:39:42] i'm really tired of fighting php pagelist and the api [19:39:51] have a nice weekend yall [19:40:06] 👋😘 [19:40:47] see you joakino! :) [19:41:13] (03PS1) 10MaxSem: Revert "Hygiene: Organise our long list of globals" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183894 [19:41:21] (03CR) 10jenkins-bot: [V: 04-1] Revert "Hygiene: Organise our long list of globals" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183894 (owner: 10MaxSem) [19:41:35] MaxSem: …. [19:41:37] $wgMFEnableWikiGrok = true; [19:41:37] $wgMFEnableWikiGrokOnAllDevices = true; [19:41:38] $wgWikiGrokDebug = true; [19:41:40] $wgMFUseWikibaseDescription = true; [19:41:40] $wgMFEnableWikiGrokInSidebar = true; [19:42:23] and $wgWikiGrokSlowCampaigns = [19:42:39] (03CR) 10Jdlrobson: [C: 04-2] "As discussing IRL Max this shouldn't be reverted without discussion. I personally find it more useful as MobileFrontend.php was becoming a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183894 (owner: 10MaxSem) [19:43:40] jdlrobson: re your question about Hindi, [19:43:47] moizsyed, I would absolutely (a) pay for the hosting for and (b) populate howwikiyouare.org [19:43:48] JFYI [19:44:15] Ironholds: haha, awesome [19:44:27] all-staff hackathon project? [19:44:30] all-staff hackathon project [19:44:40] sure! [19:44:41] jdlrobson: I don't have real data, but my impression from my visits to India is that people don't even imagine that computers can be used in any other language except English, even though the support for fonts is not that bad. [19:44:48] I wish anybody had any real data. [19:45:01] aharoni, that sounds like something for us to dig into! [19:45:17] Ironholds: it's more of a social research, [19:45:29] rather than EventLogging or anything like that, [19:45:37] but I'll welcome anything you can come up with. [19:45:44] totally! [19:45:57] I'm thinking Abbey would be interested as heck [19:46:18] Since my first visit to India in 2011 that's one of the things that I've been curious about, more than almost anything else. [19:47:17] I tried to talk to CIS as well - Indian "Center for Internet Society", which is in some kind of a partnership with Wikimedia. I thought that maybe an organization with such a name would know it, but they don't. [19:47:35] Internet ^and^Society [19:47:44] hi kaldari. do you expect the issues with MobileWebUIClickTracking schema affect the test on Monday? [19:48:35] leila: I wouldn’t expect it to [19:49:00] aharoni, you know who we should talk to? [19:49:00] ok, cool, kaldari. and do you want to do some QA today in the afternoon? [19:49:15] the OII folks. They do a TON of localised work about internet penetration and variation [19:49:32] specifically we should reach out to Han-Teng Liao and Heather Ford. [19:50:18] Ironholds: http://www.oii.ox.ac.uk/people/?id=286 ? [19:53:20] leila: yes [19:54:11] aharoni, yup [19:54:26] thanks [19:54:28] 3Wikipedia-App-Android-App, Mobile-Apps: The mobile app should display hatnotes in article sections - https://phabricator.wikimedia.org/T85985#966540 (10Krenair) [19:54:29] 3Wikipedia-App-Android-App: Does not display "Main article" or "See also" templates - https://phabricator.wikimedia.org/T85375#966541 (10Krenair) [19:54:32] aharoni: Ironholds it would be good if we could record things we notice (making sure to cite them as personal experience) when we travel to other countries [19:54:36] just as in your mail thread [19:54:37] brb lunch [19:58:17] aharoni, if you want to get a sense of search in other languages, Google Trends will give you a quick estimate [19:59:36] If you pick couple regional topics (elections, controversial political cases, etc), you can compare the search trend in English vs languages spoken in India. [20:14:13] (03PS1) 10Brion VIBBER: Fail gracefully instead of crashing when failing to save cached image [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183899 [20:20:24] (03PS1) 10Brion VIBBER: Use more human-readable directory names for articles [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183901 [20:23:46] Pffft, humans [20:27:52] bmansurov: please update core and check https://gerrit.wikimedia.org/r/#/c/183632/ again [20:27:55] it fixes icon in alpha.. [20:28:08] (03CR) 10Jdlrobson: "i suspect you are running an old version of core... can you recheck?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [20:29:43] (03PS2) 10Jdlrobson: Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) [20:29:55] 3MobileFrontend-alpha: cannot upload a photo - https://phabricator.wikimedia.org/T86348#966682 (10bmansurov) 3NEW [20:30:22] kaldari: https://gerrit.wikimedia.org/r/182956 can we get this merged today :( [20:30:34] it's blocking a bunch of patches that have +2s from rolling out [20:30:47] bmansurov has a habit of merging follow ups but not the first of the patches :-) [20:31:28] jdlrobson: Yes, I’ll review it today. Just had to get the WikiGrok stuff wrapped up first, but that’s done now. [20:31:30] domino effect ;) [20:31:42] deskana mhurd may be a few minutes late [20:32:13] kaldari: should be super quick to review - all i'm doing is copying and pasting code from one repository to another [20:33:17] kristenlans: Are you joining the hangout? :) [20:33:26] (03CR) 10Jdlrobson: [C: 032] Hygiene: Apply jscs rules to search, talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:33:28] deskana I will be [20:33:33] bearND: We're starting the bug triage if you want to join. You are optional, so it's up to you. :-) [20:33:33] (03PS1) 10Bmansurov: Fix pinch zoom on images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183904 (https://phabricator.wikimedia.org/T76620) [20:33:46] Deskana: coming... [20:35:18] (03PS10) 10Jdlrobson: Hygiene: Enable jscs for test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:35:33] (03CR) 10Jdlrobson: [C: 032] Hygiene: Enable jscs for test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:35:38] (03Merged) 10jenkins-bot: Hygiene: Apply jscs rules to search, talk, references tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183562 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:35:53] https://phabricator.wikimedia.org/project/board/67/ [20:36:20] 3Mobile-Web: jscs should apply to test files as well. - https://phabricator.wikimedia.org/T85876#966699 (10Jdlrobson) 5Open>3Resolved [20:36:50] (03Merged) 10jenkins-bot: Hygiene: Enable jscs for test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183413 (https://phabricator.wikimedia.org/T85876) (owner: 10Bmansurov) [20:37:07] (03CR) 10Bmansurov: [C: 031] "Looks good after updating core." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [20:37:58] (03CR) 10Jdlrobson: [C: 032] "Fix Max's comment in follow up. Let's get this moving along." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [20:38:30] 3Mobile-Web: Still issues with pinch zoom on images - https://phabricator.wikimedia.org/T76620#966703 (10bmansurov) a:3bmansurov [20:39:33] (03Merged) 10jenkins-bot: Always enable red links in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183038 (owner: 10Phuedx) [20:40:32] (03PS1) 10MaxSem: WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 [20:40:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: new extension registration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (owner: 10MaxSem) [20:41:59] (03Abandoned) 10MaxSem: Revert "Hygiene: Organise our long list of globals" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183894 (owner: 10MaxSem) [20:43:18] https://phabricator.wikimedia.org/maniphest/query/2nXSSP340QH3/#R [20:45:17] 3Wikipedia-App-Android-App: find in page nearly unusable in landscape orientation - https://phabricator.wikimedia.org/T78244#966724 (10Deskana) 5stalled>3Open p:5Triage>3Volunteer? [20:45:35] 3Wikipedia-App-Android-App: find in page nearly unusable in landscape orientation - https://phabricator.wikimedia.org/T78244#966728 (10KLans_WMF) 5Open>3stalled [20:47:26] (03CR) 10Bmansurov: [C: 032] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [20:49:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [20:49:06] (03CR) 10jenkins-bot: [V: 04-1] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [20:49:08] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [20:49:10] 3Wikipedia-App-iOS-App: Integrate Testflight SDK to make iOS betas easier to install - https://phabricator.wikimedia.org/T78714#966733 (10Deskana) p:5Triage>3Normal [20:50:05] jdlrobson: do you want me to fix up the tests in https://gerrit.wikimedia.org/r/#/c/182956/ ? [20:51:13] bmansurov: sure that would be helpful [20:52:49] 3Wikipedia-App-Android-App, Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#966748 (10KLans_WMF) p:5Low>3Triage [20:53:43] 3Wikipedia-App-iOS-App: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#966755 (10Deskana) [20:53:52] 3Wikipedia-App-iOS-App: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#936246 (10Deskana) Appears to be an issue with the iOS app. [20:54:30] 3Wikipedia-App-iOS-App: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#966760 (10Deskana) Thoughts, @mhurd? [20:54:33] (03PS10) 10Bmansurov: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [20:54:37] 3Wikipedia-App-iOS-App: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#966762 (10Deskana) p:5Triage>3Normal [20:55:14] 3Wikipedia-App-Android-App: navigating to a saved page should always try using cached copy as last resort before network error - https://phabricator.wikimedia.org/T85065#966763 (10Deskana) p:5Triage>3High [20:55:32] (03CR) 10Bmansurov: [C: 032] Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [20:55:54] 3Wikipedia-App-Android-App: navigating to a saved page should always try using cached copy as last resort before network error - https://phabricator.wikimedia.org/T85065#937947 (10Deskana) Tracked here: https://trello.com/c/B8ggC5RW/26-navigating-to-a-saved-page-should-always-try-using-cached-copy-as-last-resort... [20:57:01] 3Wikipedia-App-Android-App: Add Extension:Echo integration for logged in users? - https://phabricator.wikimedia.org/T85075#966769 (10Deskana) p:5Triage>3Volunteer? [20:57:31] 3Wikipedia-App-iOS-App: Mobile app edit inserting JSON blob - https://phabricator.wikimedia.org/T84997#966775 (10Mhurd) Hmm I don't see those json keys in any of the app source... [20:58:13] (03Merged) 10jenkins-bot: Hygiene: Move JavaScript from Mantle to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182956 (owner: 10Jdlrobson) [20:58:36] 3Wikipedia-App-Android-App: pages should indicate whether they have been saved no matter how you got there - https://phabricator.wikimedia.org/T85066#966778 (10Deskana) p:5Triage>3Low Tracked here: https://trello.com/c/B8ggC5RW/26-navigating-to-a-saved-page-should-always-try-using-cached-copy-as-last-resort-... [20:59:48] (03CR) 10Jdlrobson: [C: 032] "Still a bit weird that the description bar at bottom doesn't hide when you zoom. Would be good if this disappeared when you start zooming." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183904 (https://phabricator.wikimedia.org/T76620) (owner: 10Bmansurov) [20:59:57] 3Wikipedia-App-Android-App, Mobile-Apps: Suggestions to improve Saved pages function - https://phabricator.wikimedia.org/T85107#966788 (10Deskana) p:5Triage>3Low [21:00:13] (03PS8) 10Jdlrobson: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) [21:00:22] (03CR) 10Jdlrobson: [C: 032] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [21:00:24] 3Wikipedia-App-Android-App, Mobile-Apps: Suggestions to improve Saved pages function - https://phabricator.wikimedia.org/T85107#938647 (10Deskana) @Florian Maybe you want to try to tackle this? ;-) [21:00:52] 3Analytics, Wikipedia-App-iOS-App, MediaWiki-extensions-UniversalLanguageSelector, Mobile-Apps, Language-Engineering, Mobile-Web, Wikipedia-App-Android-App: there should be a comparison of clicks count on interlanguage on different platforms - https://phabricator.wikimedia.org/T78351#966795 (10Deskana) p:5Triag... [21:01:28] (03PS4) 10Jdlrobson: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 [21:01:36] (03CR) 10jenkins-bot: [V: 04-1] Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [21:01:38] 3Wikipedia-App-Android-App: main page last modified time confusing - https://phabricator.wikimedia.org/T78005#966799 (10Deskana) p:5Triage>3Volunteer? [21:02:08] 3Wikipedia-App-Android-App: main page last modified time confusing - https://phabricator.wikimedia.org/T78005#833600 (10Deskana) Maybe we'll just hide this completely on the main page. [21:03:08] (03Merged) 10jenkins-bot: Fix pinch zoom on images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183904 (https://phabricator.wikimedia.org/T76620) (owner: 10Bmansurov) [21:03:25] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Donation link in app? - https://phabricator.wikimedia.org/T85320#966820 (10Deskana) 5Open>3stalled [21:03:50] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Donation link in app? - https://phabricator.wikimedia.org/T85320#943962 (10Deskana) p:5Triage>3Normal This, if it is handled, will be handled by Fundraising and not the Mobile Apps Team. [21:04:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [21:06:54] 3Wikipedia-App-Android-App, MediaWiki-extensions-Collection: Export as PDF from mobile app? - https://phabricator.wikimedia.org/T85373#966869 (10Deskana) 5Open>3declined a:3Deskana Given that we have saved pages, I'm not clear what the use case is for exporting to PDF as compared to reading the page offli... [21:07:50] 3Wikipedia-App-Android-App: UnsupportedOperationException in MenuWrapperFactory.wrapSupportMenu - https://phabricator.wikimedia.org/T78738#966890 (10Deskana) 5Open>3stalled We need to wait for the support library to fix this. [21:07:55] 3Wikipedia-App-Android-App: UnsupportedOperationException in MenuWrapperFactory.wrapSupportMenu - https://phabricator.wikimedia.org/T78738#966893 (10Deskana) p:5Triage>3Normal [21:08:55] 3Wikipedia-App-Android-App, MediaWiki-Page-protection: autoconfirmed users unable to edit semiprotected page via mobile - https://phabricator.wikimedia.org/T85528#966906 (10Deskana) p:5Triage>3Normal We're not able to reproduce this, so we're going to have trouble fixing it. [21:09:32] 3Wikipedia-App-Android-App, MediaWiki-Page-protection: autoconfirmed users unable to edit semiprotected page via mobile - https://phabricator.wikimedia.org/T85528#966916 (10Deskana) 5Open>3stalled [21:10:27] MaxSem: $wgMFEnableWikiGrokForAnons = true; [21:11:10] (03PS5) 10Jdlrobson: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 [21:12:05] (03PS9) 10Jdlrobson: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) [21:12:16] (03CR) 10Jdlrobson: [C: 032] "fixed jscs complaints" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [21:12:23] (03PS6) 10Jdlrobson: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 [21:12:28] (03CR) 10Jdlrobson: [C: 032] Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [21:13:23] (03CR) 10Jdlrobson: WIP: new extension registration (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183906 (owner: 10MaxSem) [21:14:36] (03CR) 10Jdlrobson: "This is great. Maybe split the watchlist patch out into a separate patch so we can add that separately?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [21:14:40] (03Merged) 10jenkins-bot: Add tests for define and require methods [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [21:14:54] MaxSem: mw.config.get( 'wgWikiGrokCampaigns' ); [21:14:55] {"correct":true,"prop":"instance of","propid":"P2","value":"idiot","valueid":"Q4"} [21:15:00] 3Wikipedia-App-Android-App: Trikot color missing in dark mode - https://phabricator.wikimedia.org/T85646#966936 (10Deskana) p:5Triage>3Low This is a composite image, which makes this a mess. Given that this is night mode only and @Dbrant says it's pretty tricky to fix, lowering priority. [21:16:32] (03Merged) 10jenkins-bot: Hygiene: move loadModule to its own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183647 (owner: 10Jdlrobson) [21:16:47] 3Mobile-Web: Make require and define functions on mw.mobileFrontend testable - https://phabricator.wikimedia.org/T46264#966942 (10Jdlrobson) 5Open>3Resolved [21:18:52] (03CR) 10Mhurd: [C: 04-1 V: 04-1] "I get two compile errors. In OldDataSchemaBundle..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 (owner: 10Brion VIBBER) [21:19:10] (03PS7) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 [21:19:12] (03PS1) 10Jdlrobson: Remove Mantle dependency from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183977 (https://phabricator.wikimedia.org/T85890) [21:19:35] (03PS6) 10Jdlrobson: Hygiene: Move isTestA to Schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [21:23:54] MaxSem: Made a card for it: https://trello.com/c/dhFeLqhc/40-2-make-wikigrok-response-api-pass-the-campaign-name [21:24:00] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183899 (owner: 10Brion VIBBER) [21:24:14] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183901 (owner: 10Brion VIBBER) [21:24:25] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: You should be able to load more items on Special:Nearby - https://phabricator.wikimedia.org/T78654#966978 (10Deskana) p:5Triage>3Volunteer? [21:24:43] MaxSem: I might be able to get to it today after I QA the WikiGrok data collection for Monday [21:24:52] (03PS5) 10Mhurd: Do not send X-WMF-UUID header if the user has opted out of EventLogging. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (https://phabricator.wikimedia.org/T85243) (owner: 10Deskana) [21:25:01] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/182090 (https://phabricator.wikimedia.org/T85243) (owner: 10Deskana) [21:25:43] (03CR) 10Kaldari: Add tests for define and require methods (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182968 (https://phabricator.wikimedia.org/T46264) (owner: 10Jdlrobson) [21:25:49] 3Wikipedia-App-Android-App: Split Chinese into Traditional/Simplified in menus? - https://phabricator.wikimedia.org/T85615#966984 (10Deskana) p:5Triage>3Volunteer? [21:27:00] jdlrobson, bmansurov: I’ve tried to review 3 different patches in the past hour and they’ve all been merged before I was done. Any suggestions for doing this differently? [21:27:09] 3Wikipedia-App-Android-App, MediaWiki-extensions-Collection: Export as PDF from mobile app? - https://phabricator.wikimedia.org/T85373#966993 (10cscott) Well, saving as PDF is actually pretty trivial; just embed the equivalent of the "Download as PDF" link from the main site. But I agree that saving mobile-form... [21:28:09] kaldari: short term solution maybe to leave a note saying that you're reviewing it. that happened to me before and it's frustrating [21:28:28] (03PS7) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [21:28:30] (03PS1) 10Jdlrobson: Hygiene: Remove duplicate test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183982 [21:28:32] (03PS1) 10Jdlrobson: Hygiene: Documentation update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183983 [21:28:42] bmansurov: that’s a good idea [21:29:13] and we need a better mechanism to stop a patch from reviewing [21:29:17] 3Wikipedia-App-iOS-App, Wikipedia-App-General-or-Unknown: Animated Gif cannot be "thumbed" - https://phabricator.wikimedia.org/T85759#966996 (10Deskana) p:5Triage>3Low As the product manager for mobile apps, I can't speak to the gif not appearing when you uploaded it. That would require more investigation by... [21:29:32] kaldari: if I put -1 and someone else puts +2, does it get merged? [21:29:36] kaldari: yeh it's happened to me before. in my ideal world we wouldn't be able to merge any patch to master until it is X hours old and there would be an expectation that if you haven't reviewed it within X times you've missed your chance. [21:29:51] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:30:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Documentation update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183983 (owner: 10Jdlrobson) [21:30:29] 3Wikipedia-App-Android-App: Faces not aligned properly in shared images. - https://phabricator.wikimedia.org/T86242#967000 (10KLans_WMF) p:5Triage>3Normal [21:30:30] jdlrobson, kaldari: or maybe put a -1 before someone starts reviewing and then change the score after the review is done [21:30:49] 3Wikipedia-App-Android-App: Text sometimes hard to read in images created by new Android sharing feature - https://phabricator.wikimedia.org/T86240#967003 (10KLans_WMF) p:5Triage>3Normal [21:30:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove duplicate test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183982 (owner: 10Jdlrobson) [21:31:53] (03CR) 10Kaldari: [C: 04-1] Hygiene: Move isTestA to mw.user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:31:56] (03PS1) 10MaxSem: Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 [21:32:03] kaldari, ^ [21:32:34] (03CR) 10jenkins-bot: [V: 04-1] Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 (owner: 10MaxSem) [21:33:54] (03CR) 10Kaldari: [C: 031] Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 (owner: 10MaxSem) [21:34:25] kaldari, jdlrobson, bmansurov: any idea why jenkins qunit fails here? https://gerrit.wikimedia.org/r/#/c/183396/ :/ [21:34:45] (03CR) 10Kaldari: Hygiene: Move isTestA to mw.user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:35:22] 3Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#967012 (10Jdlrobson) 3NEW [21:35:46] FlorianSW: jenkins is acting up I think [21:35:46] (03CR) 10Jdlrobson: "Sorry for the delay - I've suggested some steps here https://phabricator.wikimedia.org/T86366 to remedy this problem" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/180775 (https://phabricator.wikimedia.org/T85068) (owner: 10Esanders) [21:36:36] mhurd: looking at those compile errs... [21:36:37] probably something didn’t get committed :D [21:37:09] (03PS2) 10MaxSem: Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 [21:38:30] (03PS7) 10Brion VIBBER: Old->new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [21:39:43] (03CR) 10Brion VIBBER: "Ok, some of the files were missing from the commit. Blagh!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 (owner: 10Brion VIBBER) [21:40:42] 3Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#967042 (10Jdlrobson) See also: T85068 [21:40:49] (03CR) 10Bmansurov: [C: 031] "looks good, needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [21:40:56] (03PS1) 10Kaldari: Adding documentation to try to explain what an MF module is [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183986 [21:41:44] jdlrobson: A tiny follow-up for you: https://gerrit.wikimedia.org/r/#/c/183986/ [21:43:20] 3Wikipedia-App-Android-App: UnsupportedOperationException in MenuWrapperFactory.wrapSupportMenu - https://phabricator.wikimedia.org/T78738#967049 (10Krenair) Should this be tagged Upstream? [21:47:19] (03PS1) 10Jdlrobson: Turn off universal box-sizing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) [21:47:40] (03CR) 10Jdlrobson: [C: 032] Adding documentation to try to explain what an MF module is [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183986 (owner: 10Kaldari) [21:47:53] (03Abandoned) 10Jdlrobson: Hygiene: Documentation update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183983 (owner: 10Jdlrobson) [21:48:40] (03CR) 10jenkins-bot: [V: 04-1] Turn off universal box-sizing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson) [21:49:27] (03Merged) 10jenkins-bot: Adding documentation to try to explain what an MF module is [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183986 (owner: 10Kaldari) [21:52:11] 3Wikipedia-App-Android-App, Wikipedia-App-iOS-App: Donation link in app? - https://phabricator.wikimedia.org/T85320#967068 (10Krenair) Okay, so add the FR project and reopen this? [21:52:51] 3Wikipedia-App-Android-App: NPE crashes from android.webkit.WebViewDatabase.initDatabase - https://phabricator.wikimedia.org/T85653#967069 (10Krenair) upstream? [21:59:33] 3Mobile-Web: Revisit box-sizing: border-box for everything in MobileFrontend - https://phabricator.wikimedia.org/T86366#967012 (10Jdforrester-WMF) [22:00:56] (03CR) 10Mhurd: [C: 04-1 V: 04-1] "Almost! The first error went away, but still getting "file not found" for #import "SchemaConverter.h"" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 (owner: 10Brion VIBBER) [22:02:07] leila: Ready to help QA when you are [22:03:59] mhurd: still getting file not found on the SchemaConverter.h? [22:04:16] might try the ol’ delete derived files just in case :D [22:04:35] brion: i thought i did… will try again [22:05:22] brion: hmm still getting not found [22:05:36] hmmmmmm [22:05:41] lemme check out a fresh copy [22:09:31] mhurd: works on a fresh checkout plus the patchset 7 for me [22:09:49] * brion checks for absolute paths hidden somewhere [22:10:00] brion: pulling it fresh again to double check [22:15:31] brion: hhmmm still no file… so weird! [22:15:37] o_O [22:15:47] Eurgh, we probably should've added a session token to the image gallery EL. [22:15:54] mhurd: what’s the exact err again? [22:16:02] kaldari, can we do this in an hour? I'm in the middle of something at the moment. [22:16:09] sure [22:16:17] thanks, I'll ping you, kaldari. [22:16:27] brion: WebViewController.m line 58 SchemaConverter.h file not found [22:16:35] weird [22:16:48] mhurd: and you see SchemaConverter under ‘Data’ in the Wikipedia project? [22:17:11] brion: hmm i see the file name, but it’s red! [22:17:36] suspicious [22:17:43] it should totally be there if you updated to the patchset [22:17:44] is the file there? [22:17:48] maybe xcode got confused [22:18:04] aaaaaaaaaaaahhhhhhhhhhhhrrrrrrrrrrr [22:18:38] some of the project files seem to have it relative to ‘apps-ios-wikipedia’ instead of against the dir [22:18:50] i wonder if your dir is differently named that’s confusing it [22:18:54] speaking of xcode, has anyone tried http://www.jetbrains.com/objc/ ? [22:19:26] lemme convert those to project-relative [22:19:36] MaxSem: haven’t but i might take a try [22:22:00] (03PS8) 10Brion VIBBER: Old->new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 [22:22:06] mhurd: ok try that [22:22:14] brion: k… checking... [22:22:14] just updates the paths in the project file :P [22:24:24] brion: oh! i think it’s compiling! :) [22:27:20] \o/ [22:27:46] brion: you are a gentleman and a scholar sir [22:27:58] :D [22:28:16] brion: seems to work great! just imported a slew of pages i’d browsed/saved on old branch. [22:28:54] Will it ever end? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7785722 [22:29:10] (03PS9) 10Mhurd: Old->new data importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 (owner: 10Brion VIBBER) [22:29:19] (03PS2) 10Mhurd: Fix our navigation time update hack for back/forward [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183711 (owner: 10Brion VIBBER) [22:29:25] wooo [22:29:39] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183091 (owner: 10Brion VIBBER) [22:29:45] dbrant|brb: Looking at the gallery EL, didn't we decide we'd go with changeImage actions instead of swipeRight and swipeLeft actions? [22:29:53] (03CR) 10Mhurd: [C: 032 V: 032] "Yup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/183711 (owner: 10Brion VIBBER) [22:30:07] brion: MERGE EVERYTHING! [22:30:13] :DDD [22:32:22] (03PS1) 10Deskana: Add gallerySessionToken to GalleryFunnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183993 [22:34:28] Deskana: doesn't that provide the same thing? [22:34:39] or... I may have misunderstood slightly [22:35:41] dbrant: Well, we had some chat about this in the estimation meeting and although I suggested separate activities it was suggested that we use a single unified action. [22:36:05] dbrant: I didn't really care either way because it doesn't affect my data analysis too much (adding in an OR isn't exactly hard), but I agreed with the consensus [22:36:17] bearND: Do you remember this or am I making it up? ^_^ [22:36:46] Deskana: well then I'll update it! [22:37:15] dbrant: Wait a sec to see what bearND says. [22:37:24] dbrant: Also, if you update, you may want to review this first, I just added a session token: https://gerrit.wikimedia.org/r/#/c/183993/ [22:48:56] 3Mobile-Web: Still issues with pinch zoom on images - https://phabricator.wikimedia.org/T76620#967273 (10Jdlrobson) 5Open>3Resolved [22:51:12] dbrant|bbl, I guess you are the right person for this: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8063124 [22:53:29] (03PS3) 10MaxSem: Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 [22:57:06] Deskana: dbrant|bbl: sorry about the late response, was deep in email land. Yes, now that you mention it, I do remember us talking about a changeImage action [22:58:10] 3Wikipedia-App-Android-App: Crashes caused by android.content.res.Resources$NotFoundException - https://phabricator.wikimedia.org/T76952#967395 (10Krenair) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8062814 - res/layout/group_toc_intro.xml [23:02:16] dbrant|bbl: I don't think it particularly needs to be changed, honestly. [23:05:21] JonKatz: thanks for getting that song on a loop in my head :P [23:06:04] EVERYTHING IS AWESOME!!!!! EVERYTHING IS COOL WHEN YOU'RE PART OF THE TEAM!!!! [23:11:34] tfinc: getting ready to send out onboarding emails to corey/brian. do you know if their wmf email accts are ready? [23:12:01] (03PS1) 10Kaldari: Revising WikiGrok loading conditions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 [23:12:18] mhurd: they are [23:12:41] (03PS1) 10Deskana: Add "about" to the snippet_share_info string. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184001 [23:12:54] kristenlans: ah! just saw the email! [23:18:55] mhurd, you can actually check for existence of all wmf google apps accounts if you have one yourself [23:19:04] or check the directory [23:19:36] Krenair: ah. i shoud have done that. was being lazy :) [23:20:50] (03PS2) 10Kaldari: Revising WikiGrok loading conditions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 [23:20:57] (03CR) 10BearND: [C: 04-1] Add "about" to the snippet_share_info string. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184001 (owner: 10Deskana) [23:24:07] Deskana: moizsyed_, dr0ptp4kt and I had some discussion about the string for ShareAFact a couple of days ago. I think this was chosen as a more generic solution but I hope I got it right. Whatever moizsyed_ and you agree on is fine with me as long as it also works for the main page. [23:24:24] ^^ [23:26:06] bearND: ShareAFact is ok [23:26:22] bearND: will talk to Deskana more about it [23:27:49] jdlrobson: I'm just going through my list & am wondering if you have something for micro contributions scheduled [23:28:15] moizsyed_: sorry, was talking about the intro text as changed in https://gerrit.wikimedia.org/r/#/c/184001/1/wikipedia/res/values/strings.xml [23:28:54] bearND: oh ok [23:46:29] kaldari, I'm ready whenever you are. [23:47:16] Deskana, https://meta.wikimedia.org/w/index.php?diff=10923428&oldid=10917750&rcid=5844265 [23:50:05] (03CR) 10Bmansurov: Revising WikiGrok loading conditions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 (owner: 10Kaldari) [23:52:02] (03CR) 10Kaldari: [C: 04-1] "Don't merge until client-side code in MF is updated." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 (owner: 10MaxSem) [23:55:16] Deskana, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8063092# [23:55:38] leila: I’m ready [23:55:53] here or Hangout, kaldari? [23:56:04] leila: here is probably fine for now [23:56:20] cool. so is doing the test as before? [23:56:43] pretty much [23:57:14] https://en.m.wikipedia.org/wiki/Brad_Pitt?wikigrokversion=A for example [23:57:23] loaded in a small window [23:57:32] let's do it, Brad! ;-) [23:57:35] testing