[00:00:41] bmansurov: What was that patch we need to SWAT deploy on monday? [00:00:50] 1 sec [00:00:54] to fix eventlogging [00:01:09] kaldari: https://gerrit.wikimedia.org/r/#/c/183321/ [00:01:22] thanks! [00:01:29] np [00:03:15] (03PS1) 10Kaldari: Conform to schema [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184006 (https://phabricator.wikimedia.org/T85963) [00:03:38] (03PS1) 10Kaldari: Conform to schema [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184007 (https://phabricator.wikimedia.org/T85963) [00:06:39] kaldari, is it on for logged in users only? [00:07:43] leila: at the moment yes, unfortunately [00:08:07] I see. when will it be on for logged out? [00:08:08] leila: We should have switched that yesterday during the deployment, but forgot :( [00:08:15] leila: Monday [00:08:17] (we need to test it again when it's open for them) [00:08:31] I suggest in this case to test everything on Monday [00:09:16] I'll do few basic tests right now, but since we have to redo everything for logged-in and logged-out once it's on for logged-out (just to make sure it hasn't caused problems for logged-ins), it's better to do it all at once on Monday [00:09:21] what do you think, kaldari? [00:09:26] leila: well, the strange thing is that the EventLogging doesn’t seem to be working at all currently [00:09:49] I can get things logged in the first table, but not in Response [00:09:53] lemme dig more. [00:10:13] do you think it's related to the issue with the schema there were some emails about this morning, kaldari? [00:10:28] could be, I’m looking now... [00:12:27] bmansurov: it looks like you only fixed the schema error for 1 schema. The others have the same issue. [00:15:55] Krenair: Want me to respond to that? [00:16:13] Well I'm not about to disagree with them :) [00:17:08] leila: yeah, looks like it’s a similar problem. Let’s try again on Monday [00:17:09] kaldari, this is weird. I was able to test once, and now when I'm logged in, from Firefox and Chrome, I don't see the widget any more. [00:17:26] shouldn't I see the widget, kaldari? [00:18:20] leila: yes, if you’re using the query string overrides [00:20:11] leila: try loading https://en.m.wikipedia.org/w/index.php?title=Brad_Pitt&wikigrokversion=A in a small window. Any luck? [00:20:49] it's working now. I'm not sure what was going on. trying to see if I can reproduce it (all extensions are disabled, and the screen is small. I haven't changed it) [00:20:55] kaldari, ^ [00:25:33] Krenair: Actually there's a very practical argument against what he's suggesting; if we let the app be pointed at arbitrary wikis then we'll be in violation of Google/Apple's policy on mature content in the app. [00:25:54] Krenair: Also our app is dependent on the MobileFrontend extension and a variety of others. [00:26:07] Krenair: Can you unlock the ticket so I can reply to him? [00:26:24] done [00:26:48] I'm aware of the MF extension dependency, I don't really consider it an issue. [00:26:48] (03CR) 10Kaldari: Revising WikiGrok loading conditions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 (owner: 10Kaldari) [00:28:16] I'm not aware of how Google's policy on this kind of thing works, but I'm surprised we're comply with a policy on mature content at all [00:28:26] we comply* [00:29:16] I guess they don't allow internet browsers either? [00:29:23] Krenair: w/apple’s as well [00:29:44] Krenair: it’s surprising, that is, that we’re in compliance. [00:30:38] yep, we definitelt have some indecent content out there: https://en.wikipedia.org/wiki/George_W._Bush [00:30:48] ^_^ [00:30:50] Krenair: maybe some good will to wikipedia helped [00:31:14] The fact that we launch external links in browsers rather than loading arbitrary content in our web view helps [00:31:15] kaldari: I'm not very familiar with that code, I thought that class was the base class [00:31:47] We show image thumbnails though. [00:31:58] bmansurov: no problem. I can fix it real fast. [00:32:04] cool [00:32:07] I am reminded of https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8053269 [00:32:49] Krenair: I'm not saying Apple's guidelines make any sense. ;-) [00:33:12] So what do they do about web browsers? [00:33:42] I don't know. If you're curious, you should ask them. [00:33:51] They may just apply rules unevenly. [00:35:00] What about other apps that allow connections to arbitrary hosts? [00:35:05] They allow my IRC client. [00:35:26] Don't ask me, ask them! It's their rules. :-) [00:35:26] Email clients, etc. [00:35:28] I could go on [00:35:52] But it's not clear why you think you would be affected by such rules when the most obvious others would not [00:37:21] Actually it's about risk/reward. [00:37:31] The product that we're building is the Wikipedia app. [00:37:50] Whereas we're opening a can of worms if we start trying to support arbitrary wikis. [00:38:00] We need to focus on our core competency. [00:38:02] Which makes not much sense given a large part of it is basically a MediaWiki client. [00:38:21] I don't think I even need to mention the other Wikimedia projects that you're supposed to be supporting. [00:38:52] * Deskana sighs. [00:38:59] We're too small of a team to do everything. [00:39:27] I'd rather do one thing well than do many things badly. [00:39:30] Our priorities reflect that. [00:48:32] (03PS1) 10Kaldari: Fixing EventLogging classes so they don't fail schema validation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184011 [00:48:46] bmansurov: ^ [00:49:02] ok [00:50:04] (03CR) 10Bmansurov: [C: 032] Fixing EventLogging classes so they don't fail schema validation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184011 (owner: 10Kaldari) [00:52:12] (03Merged) 10jenkins-bot: Fixing EventLogging classes so they don't fail schema validation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184011 (owner: 10Kaldari) [00:59:23] mhurd: did you change anything in the welcome letter ? [00:59:27] on wiki [01:02:27] nuria: Looks like I don’t have permission to read the beta labs event logging logs again :( [01:03:06] kaldari: what's the problem with this? https://trello.com/c/yclbilCd/16-3-make-wikigrok-v-b-support-multiple-campaigns-at-the-same-time [01:03:40] bmansurov: That’s weird. I guess it didn’t save my comments... [01:04:34] bmansurov: The only problem is that is only passing the 1 randomly chosen campaign name, regardless of which campaign tags are actually displayed or submitted... [01:05:45] kaldari: passing? to event logging db? [01:05:56] bmansurov: we need to start passing the campaign name as part of each claim submission, rather than part of the overall meta-response. See https://gerrit.wikimedia.org/r/#/c/183984/ also. [01:06:37] bmansurov: Not your fault. I should have made that clear in the acceptance criteria. [01:07:23] kaldari: I see, WikiGrokResponseApi needs a little tweak [01:07:31] kaldari: I'll submit a patch [01:07:38] Yeah [01:08:14] bmansurov: The dialog classes might also need to be modified to make sure each claim tag submission includes which campaign is was from. [01:08:47] kaldari: sure, also the field name stays the same, right? campaign_name [01:09:38] bmansurov: Looks like Max is changing it to ‘campaign’ instead of ‘campaign_name’ [01:09:46] https://gerrit.wikimedia.org/r/#/c/183984/3/includes/api/ApiResponse.php [01:09:52] and that 'campaign' is part of each claim? [01:09:57] yeah [01:10:02] i see [01:14:13] (03PS1) 10Bmansurov: Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 [01:14:15] kaldari: ^ [01:15:40] (03CR) 10jenkins-bot: [V: 04-1] Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 (owner: 10Bmansurov) [01:15:55] bmansurov: wow, that was fast! [01:16:03] :) [01:16:05] kaldari: i forgot about tests [01:16:07] ;( [01:20:37] (03PS2) 10Bmansurov: Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 [01:23:14] (03PS2) 10Deskana: Rework prose in Share a Fact slightly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184001 [01:23:50] bearND: Moiz and I just reworked the prose, so he's signed off on that patch ^ [01:24:06] Deskana: cool! :) Thanks! [01:24:20] (03CR) 10BearND: [C: 032] Rework prose in Share a Fact slightly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184001 (owner: 10Deskana) [01:25:38] (03Merged) 10jenkins-bot: Rework prose in Share a Fact slightly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184001 (owner: 10Deskana) [01:26:24] kaldari: that applies to version a too? [01:26:38] or should I keep campaign_name for version a? [01:26:45] bearND: Thanks! [01:29:08] (03PS1) 10Kaldari: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184015 [01:29:41] (03PS3) 10Bmansurov: Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 [01:29:43] (03PS2) 10Kaldari: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184015 [01:30:55] mhurd: new ios-beta stays on the Wikipedia logo [01:30:57] (03PS4) 10Bmansurov: Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 [01:31:07] and then crashes [01:31:25] iPhone 6, iOS 8.1.2 :) [01:32:26] deleting and installing again seem to help, if you get other complaints you know what to do [01:36:27] bmansurov: Should fix it for version A as well [01:36:35] sjoerddebruin: ah! there could be an issue with the code which converts the old data format to the new one… [01:36:39] kaldari: i did ;) [01:36:47] :) [01:37:17] bmansurov: I can’t wait until we get to ditch one of the WikiGrok versions [01:37:39] kaldari: i bet version a is not going to live long [01:37:49] 3MediaWiki-extensions-Thanks, MobileFrontend-Feature-requests: Need option to switch off "Thanks" - https://phabricator.wikimedia.org/T74903#967751 (10Quiddity) [01:37:58] bmansurov: I hope not :P [01:38:33] it's just subset of version b, we can make version b serve similar questions [01:38:50] yeah [01:39:17] mhurd: face dectection seems great. [01:39:28] 3MediaWiki-extensions-Thanks, MobileFrontend-Feature-requests: Need option to switch off "Thanks" on mobile web - https://phabricator.wikimedia.org/T74903#967753 (10Mattflaschen) [01:45:14] sjoerddebruin: woohoo! :) [01:45:39] Only downside is that they are still in the infobox, so double [01:45:55] sjoerddebruin: we’ll track down the import crash on monday. also found a weird padding issue on ios 8.0 on ipod… [01:54:57] (03PS1) 10Ori.livneh: MWException -> Exception [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/184062 [01:56:28] (03PS1) 10Ori.livneh: MWException -> Exception [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184069 [01:56:44] 3MediaWiki-extensions-Thanks, Mobile-Web: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#967765 (10Quiddity) Re-opening, I see no Thank button in Firefox or Opera (e.g. [[https://en.m.wikipedia.org/wiki/Special:MobileDiff/589569887 |this random diff]]). I get this error in webcons... [01:57:33] 3MediaWiki-extensions-Thanks, Mobile-Web: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#967768 (10Quiddity) 5Resolved>3Open [02:06:34] (03CR) 10Mattflaschen: "This broke the Thanks extension (https://phabricator.wikimedia.org/T77929#967765). See also https://gerrit.wikimedia.org/r/#/c/178287/ (a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182204 (owner: 10Jdlrobson) [02:07:25] 3MediaWiki-extensions-Thanks, Mobile-Web: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#967777 (10Mattflaschen) a:5Florian>3Jdlrobson Caused by https://gerrit.wikimedia.org/r/#/c/182204/ . [02:15:34] 3MediaWiki-extensions-Thanks, Mobile-Web: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#967788 (10Florian) a:5Jdlrobson>3Florian On it. [02:37:47] 3Wikipedia-App-Android-App: Tweet a fact quotation marker needs to be localized - https://phabricator.wikimedia.org/T86394#967799 (10Tfinc) 3NEW [02:40:26] 3Wikipedia-App-Android-App: Share a Fact quote should be flipped in RTL context - https://phabricator.wikimedia.org/T86395#967805 (10Deskana) [02:40:59] 3Wikipedia-App-Android-App: Share a Fact quote should be flipped in RTL context - https://phabricator.wikimedia.org/T86395#967805 (10Deskana) {F27307} Example of it doing it wrong. The quote actually begins at the right of the top line due to Hebrew being an RTL language, but the quote is at the top left instead. [03:55:31] 3Mobile-Web: special:uploads not rendering on production - https://phabricator.wikimedia.org/T86400#967902 (10Jdlrobson) 3NEW [12:32:57] 3Wikipedia-App-Android-App: android.database.sqlite.SQLiteDiskIOException: error code 10: disk I/O error - https://phabricator.wikimedia.org/T86438#968292 (10Krenair) 3NEW [12:37:42] 3Wikipedia-App-Android-App: SecurityException: Neither user nor current process has android.permission.WAKE_LOCK - https://phabricator.wikimedia.org/T86440#968305 (10Krenair) 3NEW [12:39:14] 3Wikipedia-App-Android-App: NPE crash from android.view.SurfaceView.onAttachedToWindow - https://phabricator.wikimedia.org/T86441#968312 (10Krenair) 3NEW [12:47:15] 3Wikipedia-App-Android-App: OutOfMemoryError crashes from some IO/string building code - https://phabricator.wikimedia.org/T86442#968320 (10Krenair) 3NEW [13:29:10] hi all [13:42:46] hi [13:42:49] hi [13:42:54] hi [13:43:31] I am looking for help about mobilefrontend on mw 1.24.1