[02:15:42] (03PS4) 10Yurik: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt) [09:23:25] yo [09:54:55] I had forgotten to connect [09:54:57] good morning! [10:09:03] hey joakino [10:09:14] hi phuedx :) [10:43:53] (03PS5) 10Phuedx: Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 (owner: 10Bmansurov) [10:47:05] (03CR) 10Phuedx: [C: 032] Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 (owner: 10Bmansurov) [10:47:22] (03CR) 10Phuedx: "Tested with I383d403593708ca4990187a4e7f17c0c11c4ae04. LGTM." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 (owner: 10Bmansurov) [10:48:43] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [10:48:51] (03CR) 10Hashar: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [10:48:59] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [10:50:09] (03Merged) 10jenkins-bot: Pass campaign name as part of each claim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184013 (owner: 10Bmansurov) [11:05:42] (03CR) 10Phuedx: [C: 032] Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 (owner: 10MaxSem) [11:06:28] (03Merged) 10jenkins-bot: Require a campaign field in WikiGrok responses [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/183984 (owner: 10MaxSem) [11:25:19] (03PS2) 10Phuedx: Run JSCS agains the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) [11:37:12] (03CR) 10Phuedx: [C: 031] Don't return a value from Schema.log [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184280 (owner: 10Ori.livneh) [11:46:38] (03CR) 10Phuedx: [C: 031] MWException -> Exception [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184069 (owner: 10Ori.livneh) [12:01:42] gonna go for lunch with george [12:03:38] 3Wikipedia-App-Android-App: Get Wikipedia app on f-droid - https://phabricator.wikimedia.org/T67460#970502 (10yuvipanda) [12:36:49] enjoy! [13:20:11] (03PS3) 10Jhernandez: WIP: Implement infinite scroll independently [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 [13:21:08] (03PS4) 10Jhernandez: WIP: Implement infinite scroll independently [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 [13:56:03] 3MobileFrontend-beta: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#970744 (10Aklapper) @Jdlrobson: Adding #MobileFrontend-beta project as the MobileFrontend-stable project was archived for reasons unknown to me, and its description was not updated where to fil... [14:29:43] ^ jdlrobson is phabricating at 6 am? [14:43:36] phuedx: i think it was aklapper commenting to jdlrobson [14:43:44] we tag those issues mobile-web right? [14:45:06] 3Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#970825 (10Jhernandez) [14:46:09] damn [14:46:12] misread that line [14:46:19] i thought that this is how jdlrobson does it [14:46:39] 3Mobile-Web: commons images are always "Last updated 0 seconds ago" - https://phabricator.wikimedia.org/T84906#933630 (10Jhernandez) @Aklapper I think we are using the Mobile-Web tag as the main tag for MobileFrontend issues https://phabricator.wikimedia.org/tag/mobile-web/ https://phabricator.wikimedia.org/pro... [14:47:02] (03CR) 10Phuedx: "I still don't understand what this is used for. Have I missed something? Can't we just remove it?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [14:47:09] phuedx: what do you think about that comment ^ [14:47:20] oops, above the code review :s [14:48:34] ? [14:48:43] joakino: that comment is fine (i think you're right) [14:48:57] 👍 [15:27:29] (03CR) 10Dbrant: [C: 032] Add gallerySessionToken to GalleryFunnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/183993 (owner: 10Deskana) [15:27:53] (03PS5) 10Jhernandez: Implement infinite scroll independently from PhotoList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 [15:27:55] (03PS1) 10Jhernandez: WIP: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 [15:28:29] đŸș [15:29:55] (03CR) 10Jhernandez: "I've split the watchlist part out, since it is quite more messy and makes sense." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [15:30:28] hashar: and 🚬 [15:30:30] phuedx: joakino: I am going to migrate the mobile extensions jobs [15:30:41] to a single job that tests a bunch of extensions together [15:31:03] ie clone Echo JsonConfig Mantle MobileApp MobileFrontend VisualEditor WikiGrok ZeroBanner ZeroPortal [15:31:03] and run the mw/core extensions tests :] [15:31:20] sounds good [15:31:35] but it may be blame-fest when a problem comes [15:31:57] joakino: 🐛 <-- bug! [15:31:59] that one is rather nice [15:32:09] maybe run that one auto, and keep the individual ones for blaming? [15:32:37] (03CR) 10Phuedx: [C: 04-1] "There's a subtle positioning bug around the notifications badge/button/thing:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [15:32:39] emojis FTW đŸ’© [15:33:36] I will post the long explanation on the mobile list [15:33:37] but in short [15:34:01] for branches <= REL1_24 we keep one job per extension which only run that extension tests [15:34:18] with master wmf branches and REL1_25+ we get a single job shared by all extensions which clone them all [15:34:25] (03PS3) 10Phuedx: Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [15:36:03] and ^^^ that is the first change using the new jobs [15:36:23] (03CR) 10Phuedx: "PS3 fixes the bug." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [15:42:49] the Jenkins job takes a bit of time to warm up since it clones a bunch of extension (and core which is rather long) [15:42:57] but it passes ! https://gerrit.wikimedia.org/r/#/c/183632/ [15:46:40] hashar: cool [15:46:47] gotta write about it now :] [15:47:08] hashar: so if one extension breaks something in core? the patches in all extensions will be -1d until that extension is fixed [15:51:25] joakino: indeed [15:51:33] though the breakage would have to pass the test in the first place [15:51:55] if one send a patch to Mantle which breaks MobileFrontend [15:52:03] previously the patch would pass the test [15:52:06] and get merged [15:52:15] now, MobileFrontend will complain (assuming it has a patch) [15:54:19] damn need to announce it on wikitech-l [15:54:21] hashar: ahh ok, so for most cases it's not an issue [15:54:25] hashar: that will leave fewer bugs for me to find :-) [15:54:37] joakino: hopefully [15:54:54] I am not sure how we will handle deprecations in core though [15:55:12] since as soon as we deprecate a mediawiki/core api call, the job will fail till all extensions are adjusted/updated [15:55:29] chrismcmahon: I will present it during the mw summit in a couple weeks [15:57:31] (03CR) 10Phuedx: [C: 031] Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [16:05:16] (03CR) 10Bmansurov: [C: 031] Run JSCS agains the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [16:05:41] (03PS3) 10Phuedx: Run JSCS against the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) [16:49:48] joakino: chrismcmahonbrb the job works properly :-] I have announced it on wikitech-l https://lists.wikimedia.org/pipermail/wikitech-l/2015-January/080065.html [16:50:56] 👍 [17:02:34] hashar: that is very cool :-) [17:04:28] heading back home *wave* [17:30:38] bgerstle, coreyfloyd: Welcome, gentlemen! [17:30:50] Hey Deskana! :wave: [17:32:02] how goes it? [17:33:06] what time is standup? [17:33:37] bgerstle: It clashes with your HR orientation, unfortunately. [17:33:50] i see [17:34:35] kristenlans will be giving you invites to all of our meetings at some point, but I've added you to the standup for now. [17:34:59] Oh, and the mobile showcase! [17:35:15] Those are good! We have one every month, so it's quite lucky that there's one on your first daty [17:36:05] ah, nice [17:36:39] \o [17:38:09] going AFK to walk the dogs and grab a bit before meetings :dog: [17:38:15] s/bit/bite/ [17:38:39] * brion waves [17:42:58] hmm need to charge. brb [17:56:28] kristenlans: i didn't notice, yes i'm added :) [17:56:36] hey joakino so offset on any kind of pagination usually works based on passing it the title [17:56:37] i don't know how i missed it with such background... lol [17:56:54] jdlrobson: but what's the number in front of it? it doesn't seem to be the id [17:57:35] jdlrobson: and also it is the first result after the query made, so how do i get the continue parameter from the query made from php [17:57:59] the number in front? [17:58:05] * jdlrobson gets code [17:58:44] jdlrobson: "gwrcontinue": "0|Burrito" [17:58:55] mm. I guess that's namespace? [17:59:08] oh yeah [17:59:11] oh god, API-talk [17:59:12] jdlrobson: i'm dumb [17:59:20] Ironholds: lolz [17:59:28] * Ironholds PTSDs the hell outta here [17:59:29] joakino: api makes you dumb [17:59:38] jdlrobson: now, how the frak do I guess the first item in the next page? that is certainly impossible xd [17:59:48] maybe print it to the html somehow from php? [18:00:38] isn't that what continue's value is for? [18:00:42] see https://www.mediawiki.org/wiki/API:Raw_Query_Continue [18:01:48] joakino: :-/ [18:01:56] joakino: so far there is no concept of order in watchlist [18:02:14] our work will hopefully introduce modified date which will be a start :-) [18:02:18] it's alphabetical though... [18:02:33] We ran into issues with the query continue stuff. [18:02:39] Because the ordering can change between your first and second queries. [18:02:49] holy shit [18:02:50] That'll be especially true if you're using last modified as the ordering. [18:03:08] It's less true for things like search where the ordering is "relevancy to the query"... but it still happens [18:03:15] You sometimes miss results, or get the same result back from the first and second query [18:03:27] Deskana: so, no changes to the Gallery schema? (re: swipe left/right) [18:03:40] Ironholds: jdlrobson: the thing is php queries, and prints to html the first "page", and then from JS i have to request the 2nd page on scroll, but i need the continue parameter from the query made in php (if there is any) [18:03:54] dbrant: No, I think it's fine. It's just an OR in the SQL queries. :-) [18:04:05] Deskana: very good! [18:04:05] jdlrobson: Ironholds: or I can do an extra api call at the beginning (not cool? [18:04:17] Deskana: that sounds horrible [18:05:10] kristenlans: can't seem to connect to the hangout [18:05:19] joakino: Yes, indeed. We decided that in the absence of any better solution we'd just de-duplicate, stick our fingers in our ears, and say "LALALALA NOTHING'S WRONG"... [18:05:26] joakino: Like this: http://40.media.tumblr.com/8f0b223fcfef4ef79b8ccc9eac5d708f/tumblr_miadpnO4iR1rgz9z1o1_500.jpg [18:05:32] joakino: It's... freeing. [18:06:12] dbrant: Although I was thinking that we may need sampling... [18:06:21] hahah [18:07:50] so, jdlrobson, to poke at code check out this patch, and try it, https://gerrit.wikimedia.org/r/#/c/184352/ , obviously the first page is loaded *again* the first time you scroll [18:08:13] joakino: will do just taking a look at the RFC for collections [18:08:24] jdlrobson: ok, no hurries [18:09:31] dbrant: I think the recommended number of events per second was fewer than 400. I suspect this could go over that. [18:10:50] Deskana: a fair point indeed [18:11:33] mhurd: morning, how are our new recruits looking today? [18:12:09] coreyfloyd: bgerstle|afk: hey guys! :) [18:12:29] mhurd tfinc hey! at benefits orientation, ttyl [18:12:32] 3Mobile-Web: Editing messed up in iOS 8 when you scroll - https://phabricator.wikimedia.org/T86553#971209 (10kaldari) 3NEW [18:12:39] bgerstle|afk: greetings, welcome! [18:12:57] tfinc: just pulled up their calendars. lools like they’ve been added to some calendar events already [18:13:00] coreyfloyd: welcome! [18:13:09] dbrant: Maybe we should be edgy mofos and only sample in production...? [18:13:22] dbrant: Since beta has an implicit sampling rate in it anyway due to being smaller? :-) [18:13:27] Deskana: yes!! [18:13:34] bgerstle|afk: sounds good! [18:15:58] dbrant: I'll make a card in a bit. [18:17:32] (03PS7) 10Jdlrobson: wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 [18:18:46] (03CR) 10Jdlrobson: [C: 031] "@MaxSem" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184069 (owner: 10Ori.livneh) [18:19:06] 3Mobile-Web: special:uploads not rendering on production - https://phabricator.wikimedia.org/T86400#971259 (10Florian) a:3Florian [18:21:23] (03PS1) 10Jdlrobson: Hygiene: Remove jscs comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184386 [18:21:30] (03PS4) 10Jdlrobson: Update how jscs runs on the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [18:21:48] (03PS2) 10Jdlrobson: Hygiene: Remove jscs comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184386 [18:22:14] (03CR) 10jenkins-bot: [V: 04-1] wIP: Infobox item editing using oojs-ui [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/181225 (owner: 10Jdlrobson) [18:22:27] (03PS8) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 [18:22:35] (03CR) 10Jdlrobson: "BUELLER" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [18:24:20] (03CR) 10Jdlrobson: [C: 04-1] "@ori Actually we do..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184280 (owner: 10Ori.livneh) [18:24:51] (03CR) 10Jdlrobson: [C: 031] "Provided jenkins passes on https://gerrit.wikimedia.org/r/#/c/184386/ this can be merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [18:27:10] https://phabricator.wikimedia.org/maniphest/query/2nXSSP340QH3/#R [18:27:31] joakino: owch watchlist raw [18:27:46] 3Wikipedia-App-Android-App: GalleryActivity does not animate gifs - https://phabricator.wikimedia.org/T85766#971274 (10KLans_WMF) p:5Triage>3Normal [18:28:09] 3Wikipedia-App-Android-App: Search results missing some prefix results - https://phabricator.wikimedia.org/T86243#971275 (10KLans_WMF) p:5Triage>3Normal [18:28:15] joakino: seems to work though? You just need to pass it the last item in the list to start with? [18:28:49] 3Wikipedia-App-Android-App: Unchecked checkboxes aren't visible in dark theme - https://phabricator.wikimedia.org/T85809#971277 (10KLans_WMF) p:5Triage>3High [18:29:09] Hi and welcome, bgerstle|afk and coreyfloyd [18:29:11] $( '.page-list li' ).last().attr( 'title' ) < joakino [18:30:27] jdlrobson: but then that item will be repeated? I can remove it manually and ask for LIMIT+1 though [18:30:32] that could work [18:30:35] what a hack xd [18:31:29] (03PS1) 10Kaldari: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184388 (https://phabricator.wikimedia.org/T86031) [18:31:58] kristenlans: ergg the meeting got scheduled for the quiet room [18:32:00] that's no good [18:32:06] uhoh [18:32:08] no other rooms free it seems :/ [18:32:20] I wish it was noted on the calendar that it is a quiet room :-/ [18:32:26] (03PS3) 10Kaldari: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [18:32:58] jdlrobso_: crap [18:33:00] kristenlans, joakino: AFAIK it's not the quiet room in the morning, so having a meeting in there is fine. [18:33:17] jdlrobso_: ^ [18:33:17] kristenlans: yeh it also has no hangout equipment [18:33:39] kristenlans: i don't even know why it's still on the calendar. it annoys me. [18:33:43] jdlrobso_: you guys may have to huddle around the old laptop then. Does that work? [18:33:52] jdlrobso_: Yeah that shoudl take it off the calednar [18:33:55] kristenlans: looks like we will have to [18:34:13] Deskana: so if the android app isn’t yet able to present prefix and full text results at the same time, i don’t see how those metrics showing “0 results” dropped from ~19 to ~16% is accurate. [18:34:20] (03CR) 10Bmansurov: [C: 032 V: 032] Update how jscs runs on the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [18:34:29] (03CR) 10Bmansurov: [C: 032 V: 032] Hygiene: Remove jscs comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184386 (owner: 10Jdlrobson) [18:34:49] mhurd: That's because when there are no prefix results, it displays full text results, and often there are full text results for queries that give nothing with prefix. [18:35:12] 3Mobile-Apps, Wikipedia-App-Android-App: Android: Image info and Image file page displayed info in English - https://phabricator.wikimedia.org/T86388#971284 (10bearND) [18:35:52] 3Mobile-Apps, Wikipedia-App-Android-App: Android: 'Read more', 'More information', 'Quick facts' are not translated when switching to a different language - https://phabricator.wikimedia.org/T86387#971285 (10bearND) [18:35:53] kaldari: are we supposed to review code that's not on master? this one for example: https://gerrit.wikimedia.org/r/#/c/184007/ [18:36:07] (03Merged) 10jenkins-bot: Update how jscs runs on the test files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183854 (https://phabricator.wikimedia.org/T85876) (owner: 10Phuedx) [18:36:29] Deskana: ah, so when prefix doesn’t find anything you’re delaying logging that nothing was found until after the fail-over to a zero-results full text search? [18:36:36] mhurd: Exactly, yes. [18:36:42] gotcha [18:36:49] bmansurov: No, anything that's for a deployment branch has already been reviewed. [18:37:07] kaldari: ok thanks [18:38:17] gotta run to pharmacy, bbiab to continue on that import bug [18:38:27] mhurd: Yep, just checked, there's a (if results.size() > 0) in the logging on the title search [18:38:36] mhurd: That accounts for the fail-over behaviour. [18:38:53] Deskana: good to keep in mind for the ios version [18:39:08] dbrant: Have you added Read more to the showcase list? [18:39:48] bearND: nope; but didn't we demo it last time? [18:40:22] dbrant: that's what I thought, too. I was just wondering why it's there. Maybe that's old stuff [18:40:35] bearND: yeah I think that's all from the last one [18:40:57] mornin' kaldari. I'm in R32 if you want to chat about QA [18:40:59] hello @all :) [18:41:04] dbrant, bearND: That etherpad was last modified on 15th December. [18:41:10] (03Merged) 10jenkins-bot: Hygiene: Remove jscs comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184386 (owner: 10Jdlrobson) [18:41:18] bearND: I hope you're going to show off share a fact! :-) [18:41:21] Deskana: thanks! [18:41:23] dbrant: ok, I guess I'll show the Gallery and ShareAFact. Anything else? [18:42:16] bearND: no, those should be enough [18:42:24] ok [18:42:39] leila: Unfortunately, all the response recording is going to be broken until the SWAT deployment at 4, so we're going to have to do the QA at the last minute (or start the test tomorrow). [18:42:43] Maryana: ^ [18:43:10] eek [18:43:22] But we should be able to QA the interaction funnel at least [18:43:38] brion: so, is there a page on enwiki with a WebM video in it? All I can find seem to be theora. [18:43:40] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184394 [18:43:58] jdlrobson, kaldari, bmansurov: Maybe i'm wrong, but jsduck doesn't support a @see tag, right? https://gerrit.wikimedia.org/r/#/c/182968/9/javascripts/modules.js [18:44:03] bgerstle|afk: coreyfloyd i just sent an invite for a hangout this afternoon for more onboardy bits [18:44:09] kaldari: whether we start the test today/tomorrow isn't too big of a deal. i don't want us all to stress ourselves out too much :) [18:44:10] Maryana: This is related to the failure that we discovered on Friday when QAing (that bmansurov fixed with an unrelated patch) [18:44:23] at least that's the message of my local tests for git review (and the doc doesn't mention a see tag) :/ [18:44:23] dbrant: https://en.wikipedia.org/wiki/WebM ;-) [18:44:26] Okay, kaldari. We can do it starting 4pm, hopefully there are no major issues and we can finish it in an hour. [18:44:42] dbrant: I knew I could rely on Wikipedians to be sufficiently meta so as to include a webm video in the webm article. [18:44:49] leila: Yeah, that's my hope [18:45:03] leila: kaldari - fingers crossed [18:45:06] Deskana: touchĂ©! [18:45:20] totally, Maryana! :-) [18:45:25] i've got a meeting from 3:30-4:30 so i'll be a little late to the QA party [18:45:34] i'm hoping everything will be perfect by then :D [18:46:03] hope is what brings us to here everyday Maryana. ;-) [18:46:27] (03PS1) 10BearND: Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184395 [18:46:34] bearND: woohoo! [18:46:36] hope & capri sun [18:47:27] FlorianSW: I think you're right [18:47:52] bmansurov: then i will use --no-custom-scripts now and will upload a follow up :) [18:47:57] mhurd: looks like there haven't been any changes in iOS string for several weeks. I only get a few new translations of the old strings [18:48:06] (03PS1) 10Florianschmidtwelzow: Don't break Special:Uploads when uploads not enabled for the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) [18:48:16] FlorianSW: sure, but aren't those tags related to jsdoc, not jsduck? [18:48:17] bearND: that sounds right :) [18:48:45] dr0ptp4kt: invite sent [18:49:05] bmansurov: then you need to put it into the docblock :) [18:49:11] mhurd: accepted [18:49:35] bmansurov: ah, wait [18:49:42] bmansurov: hmm, you're right :/ [18:52:12] (03CR) 10Bmansurov: [C: 031] Revising WikiGrok loading conditions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184000 (owner: 10Kaldari) [18:52:53] (03CR) 10MaxSem: [C: 032] Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [18:53:01] (03PS1) 10Kaldari: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184399 [18:53:16] (03CR) 10MaxSem: [C: 032] Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184388 (https://phabricator.wikimedia.org/T86031) (owner: 10Kaldari) [18:53:46] (03CR) 10MaxSem: [C: 032] Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184399 (owner: 10Kaldari) [18:53:55] (03CR) 10Bmansurov: [C: 04-1] "Dependency is outdated" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183977 (https://phabricator.wikimedia.org/T85890) (owner: 10Jdlrobson) [18:54:11] (03CR) 10MaxSem: [C: 032] Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184015 (owner: 10Kaldari) [18:54:37] (03CR) 10MaxSem: [C: 032] Conform to schema [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184007 (https://phabricator.wikimedia.org/T85963) (owner: 10Kaldari) [18:54:50] (03CR) 10MaxSem: [C: 032] Conform to schema [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184006 (https://phabricator.wikimedia.org/T85963) (owner: 10Kaldari) [18:54:56] (03Merged) 10jenkins-bot: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183396 (https://phabricator.wikimedia.org/T86031) (owner: 10Florianschmidtwelzow) [18:56:04] bmansurov: https://github.com/senchalabs/jsduck/issues/558 [18:57:15] FlorianSW: yeah, so everything on the right panel at https://github.com/senchalabs/jsduck/wiki/Custom-tags is ok to use [18:57:50] (03CR) 10MaxSem: [C: 032] MWException -> Exception [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184069 (owner: 10Ori.livneh) [18:58:09] yeah, or we just use the seetag example, krinkle posted (it's used in VE, e.g.) [18:58:37] (03PS1) 10Deskana: Make page-level sharing use the same strings as Share a Fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184401 [18:59:20] FlorianSW: can you share krinkle's link? I don't see it [18:59:42] bmansurov: the example is in the bug, VE is here: https://github.com/wikimedia/VisualEditor/blob/master/.docs/CustomTags.rb [19:00:09] ok [19:00:17] (03Merged) 10jenkins-bot: Hygiene: Only omit warning messages on LoginForm [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184388 (https://phabricator.wikimedia.org/T86031) (owner: 10Kaldari) [19:00:20] (03Merged) 10jenkins-bot: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184399 (owner: 10Kaldari) [19:00:22] (03Merged) 10jenkins-bot: Make WikiGrok v B support multiple campaigns at the same time [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184015 (owner: 10Kaldari) [19:00:24] (03Merged) 10jenkins-bot: Conform to schema [extensions/MobileFrontend] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184007 (https://phabricator.wikimedia.org/T85963) (owner: 10Kaldari) [19:00:27] (03Merged) 10jenkins-bot: Conform to schema [extensions/MobileFrontend] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/184006 (https://phabricator.wikimedia.org/T85963) (owner: 10Kaldari) [19:01:51] coreyfloyd: bgerstle: ping me if you have any questions/comments etc. looking forward to hangout this afternoon! [19:04:04] 3Wikipedia-App-Android-App: Playback of video in media gallery. - https://phabricator.wikimedia.org/T86558#971405 (10Dbrant) 3NEW [19:04:07] (03Merged) 10jenkins-bot: MWException -> Exception [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184069 (owner: 10Ori.livneh) [19:06:12] kristenlans: do we have a hygiene column in phab? [19:06:27] I swear we did... [19:06:46] i thought we did, too, but now i'm not seeing one :) [19:07:25] Seems liek it woudl eb useful, feel free to make one; ping me if you can't and I'llm make one [19:07:31] butterfingers [19:07:41] ok, kaldari is making one [19:08:59] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184394 (owner: 10BearND) [19:09:12] (03PS1) 10Florianschmidtwelzow: Hygiene: add @see tag to jsduck [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 [19:09:18] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184394 (owner: 10BearND) [19:10:10] 3Wikipedia-App-Android-App: Playback of video in media gallery. - https://phabricator.wikimedia.org/T86558#971423 (10brion) So the good news is, WebM videos should play natively in Android 2.3 and up, and all our Theora videos are cross-converted into WebM as well. I've got some JavaScript code in the demo page... [19:12:04] kaldari|2: to be prepared in advance, if we miss today's deployment window, when is the next one? [19:12:13] (03PS1) 10BearND: Add tests for two string parameters [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184406 [19:12:43] asking since 50 min may not be enough for QA given the issues that needed to be fixed, kaldari|2. [19:12:43] Deskana: do you have the response to the play store we discussed friday? [19:12:46] leila: 4pm tomorrow [19:13:07] okay, that's good. thanks kaldari|2 [19:19:20] bmansurov: if you run jsduck, do you get a warning like "Warning: extensions/MobileFrontend/javascripts/Skin.js:16: @inheritdoc - parent member not found"? [19:19:36] FlorianSW: on master? [19:19:41] yap [19:20:13] FlorianSW: yeah I do [19:21:03] ok, i will open a bug, can't figure out, why :/ the bad thing: we never used @inheritdoc to inherit a doc from view :/ (at least i haven't found any) [19:22:02] FlorianSW: I think we do inherit from View, let me check [19:22:20] brion: I don't seem to get 'transcodestatus' data for any of the video files I've tried... [19:22:28] hmmmm [19:22:53] FlorianSW: check for example the PageList.js file line 88 [19:23:29] hmm :/ [19:23:44] but not for defaults :) [19:23:58] yeah [19:25:29] dbrant: aha [19:25:35] dbrant: transcodestatus only works on commons [19:25:41] lemme see if there’s another way that you don’t have to special-case [19:25:44] brion: doh... [19:26:37] 3Mobile-Web: JSDuck Warning and missing inheritance from view - https://phabricator.wikimedia.org/T86565#971499 (10Florian) 3NEW [19:26:42] bmansurov: ^ [19:26:57] dbrant: ok looks like ‘videoinfo’ with ‘derivatives’ works via the content wikis [19:27:01] FlorianSW: cool [19:27:02] dbrant: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=videoinfo&format=json&viprop=derivatives&titles=File%3AMonks%20at%20Mahagandhayon%20Monastery%2C%20Amarapura%2C%20Mandalay%2C%20Myanmar%20-%2020141207.webm [19:28:13] 3Wikipedia-App-Android-App: Playback of video in media gallery. - https://phabricator.wikimedia.org/T86558#971512 (10brion) Per IRC discussion we found that the 'transcodestatus' only works on Commons directly; rather than special-casing, recommend using 'videoinfo' 'derivatives' option to get them, eg: https:/... [19:28:52] brion: aha, excellent! thanks [19:29:24] beware there may be json oddities like numbers in string type on occasion :D [19:29:47] i’m not sure how well tested the videoinfo api module is :D [19:33:02] Deskana, I'd be surprised if you guys would be interested in this, but here: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8068429 [19:33:38] Hi coreyfloyd and bgerstle! [19:33:41] Krenair: ahahahaha!!! [19:33:58] indeed. [19:34:15] Krenair: ...additional $500,000 in monthly revenue! lolol [19:34:33] was tempting to throw it straight into spam [19:34:38] Krenair: i like the “8 times more user engagement” part. seems a very specific multiplier... [19:36:31] (03PS5) 10Yurik: Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt) [19:36:49] (03CR) 10jenkins-bot: [V: 04-1] Show noscript HTTPS to HTTP tap if HTTPS charged [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/180800 (owner: 10Dr0ptp4kt) [19:38:49] 3Wikipedia-App-iOS-App: iOS-regression: 4.0.6 - Cannot save editing changes - https://phabricator.wikimedia.org/T86569#971560 (10Etonkovidova) 3NEW [19:41:33] MaxSem: gah! there was another conflict for the api walkthrough. moved to 10 if that’s ok [19:41:42] ok [19:46:17] (03CR) 10MaxSem: [C: 031] Don't break Special:Uploads when uploads not enabled for the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [19:53:48] mhurd: I've ticked off all my items for coreyfloyd and bgerstle. [19:54:11] Deskana: woohoo! [19:54:38] mhurd: I added one for getting them to subscribe to wikitech-l, and also clarified that the subscription should happen with their Wikimedia email addresses. [19:54:44] mhurd: Otherwise, the list was excellent. Thanks. :-) [19:58:20] (03PS1) 10Kaldari: Hygiene: Make mobileoption DOM consistant between cleint-side and server-side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 [20:00:41] 3Mobile-Web: JSDuck Warning and missing inheritance from view - https://phabricator.wikimedia.org/T86565#971638 (10bmansurov) a:3bmansurov [20:04:32] 3Wikipedia-App-iOS-App: iOS-regression: 4.0.6 - the pie chart 'Geographical distribution' in 'English language' article not displayed correctly - https://phabricator.wikimedia.org/T86572#971653 (10Etonkovidova) 3NEW [20:06:41] MaxSem, bmansurov, phuedx: I have a conflicting meeting, so can't go to showcase, but if anyone wants to, you could showcase the 'Report an error' feature at the bottom of each article in alpha. [20:07:23] kaldari|2: ok [20:11:38] (03PS1) 10Dbrant: [WIP] Play videos in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 [20:28:48] 3Mobile-Web: MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210#971754 (10kaldari) a:3MaxSem [20:29:21] gtg [20:29:24] have a nice day [20:30:47] l8r joakino [20:36:17] (03PS1) 10Bmansurov: Fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184423 (https://phabricator.wikimedia.org/T86565) [20:36:26] FlorianSW: ^ [20:37:11] jdlrobson2: jon jon jon! :-D [20:37:18] jdlrobson2: the mobile related extensions are now tested together! [20:38:28] bmansurov: ah, that sounds reasonable :P Do you want to grep for it and add inheritdoc for all defaults where it's missing? :) [20:38:51] FlorianSW: yeah, coming in a follow up patch [20:39:25] bmansurov: ok :) [20:39:31] (03CR) 10Florianschmidtwelzow: [C: 031] ":)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184423 (https://phabricator.wikimedia.org/T86565) (owner: 10Bmansurov) [20:41:07] 3Wikipedia-App-Android-App: Image description, when hidden, sometimes is still visible right at the bottom of the page - https://phabricator.wikimedia.org/T86577#971816 (10Ciencia_Al_Poder) [20:43:46] kaldari|2: jdlrobson2 maryana any idea who put WikidataInfobox on mobile showcase agenda? or who shoudl demo it? :P [20:44:01] i think jon did [20:44:20] but we're all trapped in a dev summit meeting [20:44:34] don't worry, he'll be demoing that work at the dev summit, hopefully :) [20:45:06] Cool. Also on the agenda are state of aplha and wikidata.org. I think we'll probably need to skip those too. [20:47:44] (03CR) 10Jdlrobson: [C: 032] Fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184423 (https://phabricator.wikimedia.org/T86565) (owner: 10Bmansurov) [20:49:02] (03Merged) 10jenkins-bot: Fix jsduck warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184423 (https://phabricator.wikimedia.org/T86565) (owner: 10Bmansurov) [20:51:19] (03CR) 10Jdlrobson: [C: 04-1] "Would be great to get the VE team to split that out into a submodule so we can share the same code and any updates to it..." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 (owner: 10Florianschmidtwelzow) [21:07:47] 3Mobile-Web: Editing messed up in iOS 8 when you scroll - https://phabricator.wikimedia.org/T86553#971910 (10Maryana) I hit this over the weekend but am not able to replicate it anymore, so *hopefully* it was just a glitch in the matrix. [21:15:23] brion: heya! could you add corey/brian to the gerrit “Group apps-ios-wikipedia”? [21:15:36] lemme see if i can figure out how :D [21:16:49] https://gerrit.wikimedia.org/r/#/admin/groups/619,members [21:16:51] those forms should probably be enabled for you, brion [21:16:53] (03PS1) 10Bmansurov: Hygiene: Update deprecated jscs tag and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184434 [21:17:00] brion: their emails are bgerstle@wikimedia.org and cfloyd@wikimedia.org [21:17:04] yeah that’s disabled for me :( [21:17:16] brion: me too! [21:17:31] ^d: hey want to resolve a gerrit problem for us? ;) [21:22:32] (03CR) 10Jdlrobson: [C: 031] "We should add browser test to stop this happening again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [21:24:50] (03CR) 10Jdlrobson: [C: 04-1] Don't break Special:Uploads when uploads not enabled for the user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [21:25:48] (03CR) 10Jdlrobson: "I want server side templates :-(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 (owner: 10Kaldari) [21:27:05] (03CR) 10Florianschmidtwelzow: Don't break Special:Uploads when uploads not enabled for the user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [21:28:56] (03PS8) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [21:29:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:29:31] (03CR) 10Jdlrobson: "@phuedx schema still uses so it's still in our code.. we can always delete it later but i'd rather we found a way to make it a free featur" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:30:24] (03PS2) 10Florianschmidtwelzow: Don't break Special:Uploads when uploads not enabled for the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) [21:30:43] (03CR) 10Jdlrobson: [C: 04-1] "could you explain if something is broken in commit? If nothing is I'd rather we waited till server side templates. This is bound to fall o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 (owner: 10Kaldari) [21:31:16] (03PS9) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [21:31:23] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:31:57] (03CR) 10Florianschmidtwelzow: "let me open a bug for it and abandon this, until we have feedback. Krinkle said, that the see tag is used in various wmf projects, so it w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 (owner: 10Florianschmidtwelzow) [21:33:04] bgerstle: coreyfloyd gerrit ssh://mhurd@gerrit.wikimedia.org:29418/apps/ios/wikipedia.git (fetch) [21:33:05] gerrit ssh://mhurd@gerrit.wikimedia.org:29418/apps/ios/wikipedia.git (push) [21:40:50] jdlrobson: ping :) [21:45:20] (03PS10) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [21:46:18] 3VisualEditor, Mobile-Web: [jsduck] Various custom tags should be easily shareable between projects - https://phabricator.wikimedia.org/T86587#972038 (10Florian) 3NEW [21:46:47] do we have any statistics on screen size? [21:47:32] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [21:49:22] (03PS2) 10Jdlrobson: Hygiene: Remove duplicate test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183982 [21:49:54] (03PS1) 10Fjalapeno: Adding line at bottom of readme - testing gerrit [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184485 [21:50:45] (03CR) 10Florianschmidtwelzow: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [21:51:01] (03PS2) 10Bmansurov: Hygiene: Update deprecated jsduck tag and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184434 [21:51:17] MaxSem: ^ [21:51:23] (03CR) 10Jdlrobson: [C: 031] "needs testing but looking good." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [21:51:34] hmmmm [21:51:37] mmmmmmm [21:55:33] TimStarling: not that i know of. What is the question you are trying to answer? [21:55:48] in theory event logging could be used to track this but it all depends on the question :-) [21:56:04] (also we could make good guesses about screen resolutions based on device widths/heights if necessary) [21:56:44] (for instance we could piggy back off NavigationTiming [21:56:53] dbrant, bearND: How does 12pm on Thursday sound for a production release of lead images, image viewer, and read more? [21:57:07] I'm mostly wondering about design principles, is there a target screen width or something? [21:57:12] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Update deprecated jsduck tag and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184434 (owner: 10Bmansurov) [21:57:18] Deskana: grand! [21:58:18] TimStarling: we tend to work off the basis of 320px and higher = phone, less than 320px is a variety of phones using opera mini and 768px + is a good threshold for tablet [21:58:26] this is mostly based on the market though and where our visitors are at [21:58:41] I have a meeting starting shortly so I can't follow this train of thought all the way through [21:59:06] (these seem to be the defacto standards on the web) [21:59:27] np TimStarling feel free to dump the chain of thought on me post your meeting :-) [22:00:17] mmm, there is also $wgMFDeviceWidth* [22:02:01] (03PS2) 10Jdlrobson: Turn off universal box-sizing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) [22:02:18] TimStarling: yup we have $wgMFDeviceWidth since we share it in JS and LESS [22:02:33] would be good to get that in core in some form (Flow use it too) [22:02:39] would be good to have a mediawiki standard [22:02:48] brb need to grab a coffee [22:03:54] MaxSem: Still no luck with sudo on deployment-prep [22:04:27] Deskana: dbrant: sounds great. We should do a beta release a few days before then, maybe tomorrow? [22:04:51] bearND, dbrant: Or this afternoon, if you're up for it? [22:05:08] Deskana: I would like to get some search changes in before [22:05:25] Deskana: bearND: I could do it first thing tomorrow morning. [22:05:35] Well, here's the thing. [22:05:52] If there's a problem with the search changes, then it absolutely cannot block the release of image viewer, read more, etc. [22:06:01] I'm coordinating with comms on this. [22:06:37] So, if there's a problem with the search stuff in beta, would you be happy checking out the version before the search changes, cherrypicking whatever is necessary onto that, then releasing that? [22:06:47] (03CR) 10Dr0ptp4kt: "I'm incredibly indifferent on these hyphens ;)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184485 (owner: 10Fjalapeno) [22:07:33] Deskana: I would use the word happy but it's acceptable [22:07:33] dbrant, bearND: If the above (or something else that accomplishes the same) is doable to you guys, then I have no objections. [22:07:57] I think so. [22:08:08] kaldari|2, added you to the nda sudo group [22:08:24] dbrant, bearND: Then, let's do it! [22:12:48] dbrant, bearND: The gallery view is going in, right? [22:13:07] Deskana: mos def [22:15:00] bgerstle, coreyfloyd: How's everything going, gentlemen? Need any help, or have any questions so far? [22:15:09] wrangling gerrit [22:16:54] 3Wikipedia-App-iOS-App: Pencil icon displayed on image file page - https://phabricator.wikimedia.org/T86594#972149 (10Etonkovidova) 3NEW [22:23:00] coreyfloyd: mine looks like this: MHurd (WMF) [22:24:45] Mine: CFloyd (WMF) [22:24:58] My personal ID: fjalapeno [22:31:37] (03PS1) 10Bgerstle: add test txt file [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184498 [22:31:47] ohai grrrit-wm [22:31:57] mhurd :point_up: [22:34:46] dr0ptp4kt: :point_up: :point_up: [22:35:01] can haz :-1: plz (never asked for a :-1: before) [22:36:10] (03CR) 10Dr0ptp4kt: "Foo meet bar." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184498 (owner: 10Bgerstle) [22:36:23] (03CR) 10Bgerstle: [C: 04-1] "rejecting as part of gerrit exercise" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184485 (owner: 10Fjalapeno) [22:36:35] sorry coreyfloyd :frown: [22:38:09] (03CR) 10Fjalapeno: [C: 031] "Amazed" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184498 (owner: 10Bgerstle) [22:38:20] (03Abandoned) 10MaxSem: Adding line at bottom of readme - testing gerrit [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184485 (owner: 10Fjalapeno) [22:38:40] what's with the colons, bgerstle? [22:38:42] ;P [22:38:51] are those some weird client's emoticons? [22:40:22] MaxSem: lol [22:43:22] coreyfloyd: bgerstle https://gerrit.wikimedia.org/r/#/c/183615/ [22:43:54] (03CR) 10Deskana: [C: 031] "Success!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184498 (owner: 10Bgerstle) [22:44:17] (03CR) 10Kaldari: [C: 04-1] "Is there any reason this should be in MF rather than core?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [22:47:42] bgerstle: You can abandon the change so that it's not merged by tapping the "Abandon Change" button in the UI. [22:47:48] k [22:48:01] bgerstle: Abandoning is not destructive. It can be unabandoned at any time. [22:48:12] TimStarling: would it be possible to discuss https://www.mediawiki.org/wiki/Requests_for_comment/Support_for_user-specific_page_lists_in_core at next RFC meeting? [22:48:20] (03Abandoned) 10Bgerstle: add test txt file [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184498 (owner: 10Bgerstle) [22:48:31] (03CR) 10Kaldari: [C: 04-1] Hygiene: Move isTestA to mw.user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [22:49:14] (03CR) 10Kaldari: [C: 032] Hygiene: Remove duplicate test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183982 (owner: 10Jdlrobson) [22:49:38] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update deprecated jsduck tag and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184434 (owner: 10Bmansurov) [22:50:00] kaldari|2: just posting a new patch as we speak [22:50:40] (03PS11) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [22:50:59] (03Merged) 10jenkins-bot: Hygiene: Remove duplicate test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183982 (owner: 10Jdlrobson) [22:51:02] (03Merged) 10jenkins-bot: Hygiene: Update deprecated jsduck tag and add missing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184434 (owner: 10Bmansurov) [22:51:18] jdlrobson2: yes [22:51:39] TimStarling: excellent. When is the next meeting? I will put it on my agenda [22:52:11] ( TimStarling i can't see a link to meetings on https://www.mediawiki.org/wiki/Requests_for_comment ) [22:52:19] sent you an invite [22:52:27] TimStarling: thanks [22:52:31] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [22:52:39] it's in the engineering calendar [22:53:12] bearND: hey, do you have a few mins to talk about share a fact [22:56:15] (03PS2) 10Kaldari: Hygiene: Make mobileoption DOM consistant between cleint-side and server-side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 [22:56:22] moizsyed: depends on how long it takes. got a meeting in a few minutes, should be available after 3:30 [22:56:38] (03PS3) 10Kaldari: Hygiene: Make mobileoption DOM consistant between cleint-side and server-side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 [22:56:58] jdlrobson2: Added an explanation about what this fixes: ^ [22:57:30] bearND: isnt after 3:30 a bit late for you? [22:57:44] bearND: we can do 3:30 to 4:00 if you want [22:57:50] moizsyed: no, I'm just 1 hour ahead of you [22:58:02] thanks kaldari|2. Are we any closer to Server side templates? [22:58:13] (03CR) 10Jdlrobson: [C: 032] Hygiene: Make mobileoption DOM consistant between cleint-side and server-side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 (owner: 10Kaldari) [22:58:28] (03PS12) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [22:58:35] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [22:58:43] jdlrobson2: Yes, Matt F says he's going to try to test lightncandy 0.18 with Flow this week. At that point I think we can merge it. [22:59:07] kaldari|2: \o/ can't wait to start dissecting our php [23:07:21] (03CR) 10Kaldari: [C: 031] "Looks good to me (although Jenkins doesn't like it)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [23:07:44] so about device widths etc. [23:08:25] I am basically wondering if there is a case for more responsive design in the desktop view [23:08:49] and/or more features in the mobile view [23:09:07] (03Merged) 10jenkins-bot: Hygiene: Make mobileoption DOM consistant between cleint-side and server-side [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184413 (owner: 10Kaldari) [23:09:12] TimStarling: I could possibly get you some data, manually. [23:09:20] TimStarling: Google Play gives us a breakdown of the devices that people use the app on. [23:09:27] TimStarling: We could Google those devices to find their resolutions. [23:09:51] TimStarling: Would that be useful? [23:09:52] the question comes down to whether there is a bright line between desktop and mobile or if it is a contiuum [23:10:11] and how many large screens are using the mobile site, and how many small screens are using the desktop site [23:10:28] "not many" and "not many" respectively. [23:10:41] although I still think the regexes we use to auto-redirect need to be better [23:10:45] Okay, sounds like what I'm offering isn't too relevant then. [23:12:19] (03CR) 10Kaldari: [C: 04-1] "Position of spinner after clicking notifications icon is still off in alpha. It's extra low instead of centered on where the bell used to " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [23:15:19] (03PS1) 10Jdlrobson: Regression: Fix broken upload workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184509 [23:20:14] (03CR) 10Jdlrobson: [C: 032] Don't break Special:Uploads when uploads not enabled for the user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [23:21:02] dbrant|bbl, bearND: Were you planning on pushing Tweet a Fact to beta tomorrow? [23:21:38] (03CR) 10Jdlrobson: "ergg good catch. i suspect more special casing. Will take a look. ( this is why i kept moaning about using mw-ui-icon classes)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) (owner: 10Jdlrobson) [23:22:56] (03Merged) 10jenkins-bot: Don't break Special:Uploads when uploads not enabled for the user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [23:23:13] 3Wikipedia-App-iOS-App, Wikipedia-App-Android-App: Implement logging to track user-perceived performance of page load times - https://phabricator.wikimedia.org/T86605#972377 (10Deskana) 3NEW [23:26:26] dr0ptp4kt: http://stackoverflow.com/a/9851728 this seems to have an “Extend the system-editing menu” snippet... [23:29:12] (03PS1) 10MaxSem: Fix false positives in tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184512 [23:29:25] kaldari|2, ^^ [23:30:28] (03CR) 10Kaldari: [C: 04-1] "Honestly, I think this is an ugly solution, but I'm not sure what's better. Would like to hear Esander's opinion." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson) [23:33:29] (03PS4) 10Jdlrobson: Fix icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183632 (https://phabricator.wikimedia.org/T86041) [23:34:15] (03CR) 10Jdlrobson: "Kaldari please chip in on Bug: T85068 - this is part of a 3 step process and I want to be sure you understand it/agree with it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson) [23:34:55] mhurd: thx, will tinker :) [23:36:22] (03CR) 10Jdlrobson: "I don't want to fight the core battle as part of this patch but would be a good topic at Dev summit since I know VE have their own version" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [23:37:31] kaldari|2: are you at your desk? [23:37:31] leila: yes [23:37:31] I'll drop by [23:37:37] (03CR) 10Kaldari: [C: 032] Fix false positives in tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184512 (owner: 10MaxSem) [23:37:52] (03PS9) 10Jdlrobson: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 [23:38:10] (03PS2) 10Jdlrobson: Remove Mantle dependency from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183977 (https://phabricator.wikimedia.org/T85890) [23:38:12] (03Merged) 10jenkins-bot: Fix false positives in tests [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184512 (owner: 10MaxSem) [23:38:52] (03PS3) 10Jdlrobson: Remove Mantle dependency from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183977 (https://phabricator.wikimedia.org/T85890) [23:40:15] (03PS13) 10Jdlrobson: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 [23:45:05] (03CR) 10Jdlrobson: "PageApi is used in tests and is an extendable class. There may be other things outside MobileFrontend that may want to use it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [23:46:20] (03PS4) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [23:47:43] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [23:48:26] (03PS5) 10Jdlrobson: Hygiene: Retrieve pageApi instance using module loader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 [23:56:11] (03CR) 10Jdlrobson: [C: 04-1] "sigh rebase. This is the 50th rebase issue i've hit today. we need to get existing stuff reviewed quickly." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [23:56:23] (03CR) 10Jdlrobson: "(50 might be an exaggeration ;-))" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) (owner: 10Bmansurov) [23:57:37] (03CR) 10Esanders: "I'm not sure what a 'view' is in mobile, but I think ultimately we should be aiming to have a solution where box-sizing is only ever set i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson)