[00:07:32] (03PS1) 10Bmansurov: Make checkboxes work on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 [00:07:46] dbrant|bbl: bearND nice article for lead image is “Domain (biology)” [00:07:52] (03PS2) 10Bmansurov: Make checkboxes work on Special:MobileOptions on Opera Mini [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 [00:11:30] (03CR) 10jenkins-bot: [V: 04-1] Make checkboxes work on Special:MobileOptions on Opera Mini [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 (owner: 10Bmansurov) [00:12:45] (03PS3) 10Bmansurov: Make checkboxes work on Special:MobileOptions on Opera Mini [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 [00:12:55] (03PS1) 10Mhurd: Fix for lead image title padding on iOS 8.0. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184523 [00:14:12] (03CR) 10Bmansurov: [C: 032] Remove Mantle dependency from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183977 (https://phabricator.wikimedia.org/T85890) (owner: 10Jdlrobson) [00:15:04] mhurd: nice. It's a featured picture and already cropped (see image title). That image probably doesn't even need to be cropped further. Looks like the frog is ready to jump at me, or tosomeone next to me. [00:16:06] bearND: yeah it’s beautiful [00:16:52] (03PS1) 10MaxSem: Improve API error checking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184524 [00:18:06] (03CR) 10Bmansurov: [C: 04-1] Hygiene: Move isTestA to mw.user (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [00:21:12] (03CR) 10Bmansurov: Hygiene: Retrieve pageApi instance using module loader (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183648 (owner: 10Jdlrobson) [00:23:37] (03CR) 10Bmansurov: [C: 032] Regression: Fix broken upload workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184509 (owner: 10Jdlrobson) [00:23:48] (03CR) 10Mhurd: "I updated the title padding to appear correctly (taking into account device orientation as well)." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184523 (owner: 10Mhurd) [00:24:06] (03PS1) 10MaxSem: Fix fatal [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184526 [00:24:48] (03CR) 10Kaldari: Hygiene: Move isTestA to mw.user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [00:25:26] dr0ptp4kt: if you have a some time for cr i tagged you on a small patch [00:28:27] (03PS14) 10Kaldari: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [00:28:40] (03CR) 10Kaldari: [C: 032] Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [00:36:25] Deskana: are we going to enable full text search for production for this week's release? [00:37:13] bearND: I think so. Our data shows that it's performing slightly better than prefixsearch. What do you think? [00:37:13] (03CR) 10Kaldari: [C: 032] Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [00:37:41] (03PS2) 10MaxSem: Fix fatal [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184526 [00:38:13] (03Merged) 10jenkins-bot: Regression: Fix broken upload workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184509 (owner: 10Jdlrobson) [00:39:18] (03Merged) 10jenkins-bot: Hygiene: Move isTestA to mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [00:42:45] Deskana: as long as the search team (backend) doesn't have an issue with this we should do it. We should consider a staged rollout for the production release. [00:43:22] bearND: I was thinking about that in the past but I'm not sure how to do a staged rollout in Google Play. It seems like you can target specific countries, but not on an APK-by-APK basis. [00:44:21] Deskana: I think it involves the alpha or beta testing feature of the Dev Console: https://support.google.com/googleplay/android-developer/answer/3131213?hl=en [00:44:37] Ahh, I see. [00:44:55] It looks like they need to join a Google Group for that though? [00:45:03] Deskana: basically publish to beta first, then from there promote a percentage [00:45:08] over time [00:45:08] Oh, no, I'm reading the wrong thing. [00:45:31] Deskana: 2nd section [00:46:15] It would be better to do this in a release after this one, since comms is contacting the press about this release and saying it'll be available Thursday afternoon. [00:46:41] Deskana: ah, ok. Makes sense [00:47:09] But, we could do it early next week or something. [00:47:16] Or, just dive in the deep end. ;-) [00:47:28] leila, Maryana: should be ready for testing now [00:47:45] * Maryana finishes last bite of cake [00:48:27] Deskana: we still have the remote kill option for full text search, so I guess it should be fine [00:48:38] (03PS2) 10Bmansurov: Move modes.js into context.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183754 (https://phabricator.wikimedia.org/T85572) [00:51:23] Deskana: fyi, there is another new search feature for production: recent search [00:51:33] Oh, indeed [00:52:04] Deskana: in case you're compiling a list of changes for the announcement [00:53:00] leila: look like it's actually recording data now [00:53:10] :) [00:55:12] kaldari|2: is this on for the world? [01:00:48] 3Mobile-Web: Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER) - https://phabricator.wikimedia.org/T86281#972586 (10bmansurov) @Krinkle, I cannot reproduce this. Can you please share a URL where this happens? Thanks. [01:01:09] (03CR) 10Dr0ptp4kt: [C: 032] Fix for lead image title padding on iOS 8.0. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184523 (owner: 10Mhurd) [01:01:33] (03CR) 10Dr0ptp4kt: [V: 032] Fix for lead image title padding on iOS 8.0. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184523 (owner: 10Mhurd) [01:03:22] (03CR) 10MaxSem: "Cough cough, we don't run JS on Mini, right?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 (owner: 10Bmansurov) [01:04:27] (03CR) 10Bmansurov: "We try to, but there are many limitations. This patch is a workaround." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 (owner: 10Bmansurov) [01:05:01] (03Merged) 10jenkins-bot: Hygiene: Move ResourceLoaderParsedMessageModule to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182957 (owner: 10Jdlrobson) [01:05:28] (03Merged) 10jenkins-bot: Remove Mantle dependency from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183977 (https://phabricator.wikimedia.org/T85890) (owner: 10Jdlrobson) [01:07:07] Deskana: have a minute for quick hangout? [01:08:01] 3Mobile-Web: Editing messed up in iOS 8 when you scroll - https://phabricator.wikimedia.org/T86553#972607 (10bmansurov) I tested this on iOS 8.1 simulator, but was not able to reproduce. [01:10:34] bmansurov, so have you tried https://gerrit.wikimedia.org/r/#/c/184518/ ? [01:11:09] OuKB: I did [01:11:21] eh [01:11:29] than it's a bug [01:11:42] OuKB: what's a bug? [01:11:44] because you were not supposed to get any js [01:11:53] at all;) [01:12:16] OuKB: why not? It worked both on Opera Mini on Android and Microemulator [01:13:05] because https://github.com/wikimedia/mediawiki/blob/master/resources/src/startup.js [01:14:11] dr0ptp4kt: i just got here. how can it be 5? [01:14:43] OuKB: where does it block other javascript files from executing? [01:14:47] mhurd: 4th dimension [01:15:23] mhurd: Sure. Batcave? [01:15:29] OuKB: it just doesn't load "jQuery and the MediaWiki modules" [01:16:01] bmansurov, which means that you get no mw.loader and thus no other modules [01:16:24] kaldari|2, can you review https://gerrit.wikimedia.org/r/184526 and https://gerrit.wikimedia.org/r/184524 please? [01:16:39] OuKB: I don't know why it worked when I tested though [01:16:54] what was your ua? [01:17:00] jdlrobson2: What's the convention for naming templates in module definitions? Some start with uppercase and some start with lowercase. Is lowercase for partials? [01:17:12] OuKB: I suppose something Opera Mini something [01:17:32] OuKB: I had that code outside the self invoking function though [01:17:52] kaldari|2: if it's not on the coding conventions page there is no official convention. [01:18:08] jdlrobson2: is there an unofficial convention? [01:18:08] but yes i think partials should be lowercased [01:18:13] ok [01:18:15] bmansurov, http://whatsmyuseragent.com/ [01:18:27] kaldari|2: ctaDrawer.hogan should be CtaDrawer.hogan for example [01:19:17] (03CR) 10Kaldari: [C: 032] Fix fatal [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184526 (owner: 10MaxSem) [01:19:31] OuKB: Opera/9.80 (Android; Opera Mini/7.6.40`15/35.6497; U; en) Presto/2.8.119 Version/11.10 [01:19:49] (03Merged) 10jenkins-bot: Fix fatal [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184526 (owner: 10MaxSem) [01:21:31] bmansurov, puzzled... [01:23:51] OuKB: I cleared the cahce and now it's not working [01:24:03] :P [01:25:17] (03CR) 10Bmansurov: [C: 04-1] "Not working after clearing the cache." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 (owner: 10Bmansurov) [01:42:34] coreyfloyd: you’d better not be working! ;) [01:44:54] Deskana: so, shall I schedule the blog post that I'd drafted a while ago: https://meta.wikimedia.org/wiki/Wikimedia_Blog/Drafts/Big_updates_in_the_Wikipedia_Android_app! [01:45:04] (for Thurs) [01:49:32] dbrant: is that a market build thurs? [01:49:46] mhurd: yes! with all the things. [01:51:21] dbrant: so cool [01:54:24] (03CR) 10Jdlrobson: [C: 04-2] Make checkboxes work on Special:MobileOptions on Opera Mini (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 (owner: 10Bmansurov) [01:56:07] (03PS2) 10Dbrant: [WIP] Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [01:58:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [02:00:42] dbrant: looks like that non-lead-section-hatnotes being hidden bug is in mobile web css? [02:00:45] (03PS3) 10Dbrant: [WIP] Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [02:01:19] mhurd: it was just in the css of the MobileApp extension [02:01:49] dbrant: hmm i don’t think so perhaps… see https://en.m.wikipedia.org/wiki/Nobel_Prize_in_Physics#Laureates then see the desktop version [02:02:45] mhurd: hmm! well then you're correct. But it looks fine in the app now. [02:02:55] (and that's all i care about lol) [02:02:59] hehe [02:03:05] Deskana: ^ [02:04:02] Maryana: it looks like mobile web has this issue too: https://phabricator.wikimedia.org/T85985 [02:05:28] hm, i thought we did display hatnotes.. [02:05:53] oh, i see. not in sections. [02:06:29] woah. sidenote: this guy? https://en.m.wikipedia.org/wiki/Nobel_Prize_in_Physics <-- dead ringer for greg-g! [02:06:37] 3Continuous-Integration, Mobile-Web: [jsduck] Various custom tags should be easily shareable between projects - https://phabricator.wikimedia.org/T86587#972696 (10Jdlrobson) Seems related to #Mobile-Web and probably VE James since the code currently lives in VE... Would be great to break it out into its own exte... [02:11:28] dbrant: I'll show that to Comms! [02:11:57] Deskana: (it needs a few updates now too, of course) [02:20:23] dbrant: what did you do to show non lead hatnotes? since mobile web css is setting all hatnote’s display to none, are you using some negation class to show ‘em? [02:21:18] mhurd: see this patch - https://gerrit.wikimedia.org/r/183555 [02:21:27] dbrant: k [02:22:01] mhurd: it now applies display=none to a specific id [02:22:27] dbrant: but the mobile css, as least as of today, is already setting all hatnotes display to none… [02:23:12] mhurd: hmm, we must not be inheriting that part from mobile web. [02:23:22] dbrant: the css? [02:23:26] mhurd: https://gerrit.wikimedia.org/r/#/c/183555/ [02:23:26] hmm... [02:24:29] mhurd: dbrant: the issues_container id is populated by our JS. [02:25:32] dbrant: bearND just to confirm, on “Nobel_Prize_in_Physics#Laureates“ you actually see a hatnote? [02:25:38] yep [02:26:07] mhurd: I hope you've got the same for the iOS app. Then you can just update the css from MobileApp. [02:26:21] mhurd: if not then it might need some tweaking [02:26:42] dbrant: that’s what i’m so confused about - the css from MobileApp has hatnotes hidden [02:26:43] i mean the same issues_container [02:27:10] mhurd: when was the last time you updated it? [02:27:26] bearND: the app pulls fresh every 24 hrs [02:27:38] *ios app* [02:27:42] that patch might not have deployed yet... [02:28:01] dbrant: yeah [02:28:03] Where does it pull it from? [02:28:04] dbrant: which? [02:28:10] the one I linked above [02:29:08] dbrant: so i regularly see upstream css chages as mobile web tweaks things… are you seeing these on android too? [02:29:46] mhurd: on Android, we're still using prepackaged CSS. we're not actively pulling yet :( [02:30:04] (03PS2) 10Jdlrobson: WIP: Introduce ForeignApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182134 [02:30:29] dbrant: does it pull fresh when you do a build? [02:31:29] dbrant: just trying to figure out if ios app is pulling wrong css somehow, or if android is perhaps using stale css… [02:31:57] mhurd: we still do it manually, generally whenever we introduce a change in MobileApp. [02:32:44] (manually from vagrant, or beta labs) [02:33:05] 3Continuous-Integration, Mobile-Web: [jsduck] Various custom tags should be easily shareable between projects - https://phabricator.wikimedia.org/T86587#972707 (10Jdforrester-WMF) >>! In T86587#972696, @Jdlrobson wrote: > Seems related to #Mobile-Web and probably VE James since the code currently lives in VE...... [02:33:08] (we should probably start fetching for real soon) [02:33:13] dbrant: bearND can we maybe have a meeting tomorrow or tues to get this sorted out… either way something’s not quite right [02:33:33] mhurd: I think that's in order! [02:33:41] dbrant: sounds good. [02:34:29] (03PS4) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [02:35:45] dbrant: invite sent [02:36:14] 3Wikipedia-App-Android-App: Playback of video in media gallery. - https://phabricator.wikimedia.org/T86558#972709 (10Dbrant) https://gerrit.wikimedia.org/r/184416 [02:38:13] dbrant: prob won’t need full hr [02:38:25] i would think not [02:40:10] bearND: given that it’s more likely than not that the ios app is doing something silly, i limited the invite to dbrant and myself so as not to waste too many people’s time :) [02:44:33] 3Mobile-Web: Formatting of Thanks step is different in WikiGrok A and B - https://phabricator.wikimedia.org/T86613#972715 (10kaldari) 3NEW [02:45:00] mhurd: cool [03:07:42] (03PS1) 10Kaldari: Make WikiGrok A and B use same code for Thanks step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184542 [03:09:12] (03PS2) 10Kaldari: Make WikiGrok A and B use same code for Thanks step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184542 [03:10:35] (03PS3) 10Kaldari: Make WikiGrok A and B use same code for Thanks step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184542 [04:32:46] (03PS4) 10Kaldari: Make WikiGrok A and B use same code for Thanks step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184542 (https://phabricator.wikimedia.org/T86613) [05:36:19] (03PS1) 10Mhurd: Fix for assets file attribute sanity checker typo. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184549 [06:01:16] (03PS1) 10Mhurd: Cleared out some icon cruft. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184555 [06:08:23] (03CR) 10Mhurd: "This seems to make the icon generation script complete more quickly as well." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184555 (owner: 10Mhurd) [09:40:32] 3Continuous-Integration, Mobile-Web: [jsduck] Various custom tags should be easily shareable between projects - https://phabricator.wikimedia.org/T86587#973055 (10hashar) Could the CustomTags we use be made a ruby gem? This way we could have it added to Gemfile and have bundler install it for us. The invocation... [09:52:24] yo [10:56:26] (03CR) 10Jhernandez: [C: 04-1] "Do not merge, needs tests." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [12:09:04] (03PS2) 10Jhernandez: WIP: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 [12:09:06] (03PS6) 10Jhernandez: Implement infinite scroll independently from PhotoList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 [12:24:05] (03CR) 10Jhernandez: [C: 031] "Added tests, ready for review" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [12:37:21] 3Mobile-Web, MediaWiki-extensions-GoogleLogin: Login link redirect to default login (with MobileFrontend) - https://phabricator.wikimedia.org/T74909#973291 (10Florian) @Jdlrobson: in general: yes :) But i thought, that we can let this task open as a "Blocks" for T74910? [14:01:02] (03PS3) 10Jhernandez: WIP: Infinite scrolling on Special:EditWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184352 [14:32:11] (03CR) 10Dbrant: [C: 032] Add tests for two string parameters [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184406 (owner: 10BearND) [14:37:24] (03CR) 10Dbrant: [C: 032] Make page-level sharing use the same strings as Share a Fact. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184401 (owner: 10Deskana) [14:39:55] (03PS5) 10Dbrant: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) [16:08:20] * bearND waves at dbrant [16:08:49] bearND: hello! [16:09:08] dbrant: getting close to finishing up the search stuff [16:09:26] just needs more testing [16:10:22] bearND: oh good! so you think it could make it into beta today? [16:10:22] hello @all [16:11:24] dbrant: well, I'll let you take a look at the changes and then we can decide. I think it could use some more test time. [16:11:33] * bearND waves at FlorianSW [16:12:29] bearND: sure, no worries. I think it would also be fine to promote the *current* beta search functionality to production, and release that on Thurs. [16:28:02] (03PS1) 10Dbrant: Promote lead images to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184682 [16:31:09] (03PS1) 10Dbrant: Promote new search features to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184683 [17:28:12] (03CR) 10Phuedx: "@jdlrobson: there ain't no such thing as a free feature ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/182290 (owner: 10Jdlrobson) [17:34:19] (03CR) 10Bgerstle: [C: 031] "LGTM, if build succeeds on jenkins it's probably OK" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184555 (owner: 10Mhurd) [17:42:06] (03CR) 10Bgerstle: [C: 031] Fix for assets file attribute sanity checker typo. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184549 (owner: 10Mhurd) [17:49:44] (03CR) 10BearND: [C: 032] Promote lead images to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184682 (owner: 10Dbrant) [17:52:21] (03Merged) 10jenkins-bot: Promote lead images to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184682 (owner: 10Dbrant) [17:58:21] (03CR) 10BearND: [C: 032] "This will be fun rebasing my stuff after; oh well." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184683 (owner: 10Dbrant) [17:58:51] (03Merged) 10jenkins-bot: Promote new search features to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184683 (owner: 10Dbrant) [18:01:54] coreyfloyd, meeting [18:05:40] jdlrobson2: any ideas of why tests/qunit/modules/watchlist/test_Watchlist.js isn't being included in the tests? [18:05:44] hey joakino [18:05:48] its driving me nuts [18:06:01] joakino: yeh so the qunit tests stuff is magical and should probably be rethought [18:06:22] jdlrobson2: any incantations i can use to get my files included? xd [18:06:24] (03PS1) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 [18:06:31] so the way tests work is it looks at existing modules in Resources.php [18:06:39] it looks at all the files and then looks for identical file paths [18:06:50] so tests/qunit/modules/watchlist/test_Watchlist.js === javascripts/modules/watchlist/Watchlist.js [18:07:03] if that doesn't exist the test doesn't get loaded [18:07:30] * jdlrobson2 imagines a future where in module definitions in Resources.php we have a tests property that lists all test files [18:07:42] oh so probably a case of case sensitivity screw ups, thx jdlrobson2 [18:07:54] the entire Resources.php is a horrible mess I'd like to revisit :-/ [18:08:00] i just don't know how right now [18:08:21] we can definitely remove the magic if it makes things more obvious [18:09:15] jdlrobson2: that also makes it super annoying to add and move things, we will think about it [18:12:07] (03PS2) 10Mhurd: Fix for assets file attribute sanity checker typo. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184549 [18:14:14] (03CR) 10Mhurd: "Good point Brian! Amended." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184549 (owner: 10Mhurd) [18:15:34] jdlrobson2: extracts api ? looking at https://trello.com/c/gyQmr588/7-spike-extracts-api [18:16:52] bgerstle: i amended that assets file patch. good comments! [18:17:01] thanks [18:19:19] (03CR) 10Brion VIBBER: [C: 032] Manual import of iOS string translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184395 (owner: 10BearND) [18:21:34] rmoen: hey ready to tlk! [18:21:46] jdlrobson2: sure [18:21:56] joakino: would be good to setup an email thread around the magic in special pages/unit tests [18:22:01] we should revisit that [18:22:11] rmoen: so yeh - extracts api [18:22:27] https://trello.com/c/EjeXwekz/43-3-show-extracts-in-collections-page < rmoen [18:22:33] (03CR) 10Brion VIBBER: [C: 032] Cleared out some icon cruft. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184555 (owner: 10Mhurd) [18:22:42] basically we need to do some prep work to check that this is possible [18:22:57] (including checking about performance considerations [18:24:16] jdlrobson2: ahh i see [18:24:17] rmoen: i fleshed out the card https://trello.com/c/gyQmr588/7-spike-extracts-api [18:24:30] (03CR) 10Brion VIBBER: [C: 032] Fix for assets file attribute sanity checker typo. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184549 (owner: 10Mhurd) [18:25:03] jdlrobson2: cool ty [18:27:11] jdlrobson2: on https://trello.com/c/EjeXwekz/43-3-show-extracts-in-collections-page, 4th deliverable: show the first two sentences of an /s/collection/article ? [18:28:30] brb [18:29:26] rmoen: article yeh [18:30:16] joakino: rmoen i got us a nice trello background for the backlog [18:30:22] https://trello.com/b/dJyJhmfS/collections-backlog [18:30:51] jdlrobson2: lol [18:31:00] gotta collect 'em all [18:32:48] jdlrobson2: i'm old idk what these are :) [18:32:54] Pokemon ? [18:33:48] rmoen: yaa [18:34:00] lol^2 [18:34:17] joakino: https://lists.wikimedia.org/mailman/listinfo/wikitech-l [18:34:30] joakino: important list to subscribe to if you're not on it [18:34:40] jdlrobson2: yep i've subscribed now, reading robs thread now [18:34:41] (yay more email) [18:34:45] joakino: sweet [18:34:45] haha [18:37:55] phuedx: any preferences on food for team dinner? [18:39:48] jdlrobson2: thanks for the invite :) [18:49:27] kaldari|2: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileApp/b154d494f1544738acffe2624ed2292badb2d1a5/MobileApp.php [18:50:44] (03PS1) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184702 [18:51:25] dbrant: I figured out the timing issue. Let me know if you find any issues. [18:52:27] dbrant: wait. gotta fix the change id [18:52:51] (03Abandoned) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184702 (owner: 10BearND) [18:53:20] (03PS2) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 [18:53:48] dbrant: ok, that should be all in the same patch now [18:54:08] bearND: great! checking out... [18:54:57] dbrant: also look at the diffs between the two patch sets. Still not 100% sure about the force parameter on line 156 [18:55:20] in SearchResultsFragment.java [18:56:40] mhurd the other thing i was wondering when i looked at your PR was: why isn't that script just a .rb script? [18:56:47] instead of doing ruby -e on everything [18:56:56] that way you can also lint/test the ruby code [18:57:03] bgerstle: lol. good point :) [18:57:19] also, are you specifying all the svgs manually? [18:57:50] bgerstle: yeah it started as like one line and got cut-n-pasted out to a few [18:57:55] bgerstle: probably good to clean those up :D [18:58:10] brion don't be surprised if you see a gerrit review email then ;-) [18:58:15] excellent :D [18:58:18] dbrant: how many rows of search results to you get on your big tablet in portrait mode? [18:58:18] lemme see if i can clean that up real quck [18:58:20] quick* [18:58:35] bearND: let me try it... 1 min [18:59:43] mhurd brion where/when is that script run? [19:00:00] i.e. if i remove the hashbang at the top and rename the file to *.rb, will it cause problems? [19:00:21] bgerstle: i think it’s called from one of the build scripts in the xcode config [19:00:34] might have to tweak how it’s invoked [19:00:45] 3Mobile-Web: JSDuck Warning and missing inheritance from view - https://phabricator.wikimedia.org/T86565#974169 (10Jdlrobson) 5Open>3Resolved [19:00:54] hm, ok [19:01:54] kaldari|2: is this the change that fixes the lack of boldness in wikigrok? https://gerrit.wikimedia.org/r/#/c/184542/ [19:01:55] jdlrobson2: hey, how does :not(#noop) filter out IE8 and below? Can you explain? [19:02:02] bearND: I see 16 items (with the keyboard hidden) [19:02:16] bgerstle: ok i ….. *think* it should be fine if you switch it to .rb and add an appropriate hashbang [19:02:22] k [19:02:28] bgerstle: but update the filename in the ‘run script’ thingy in the ‘build phases’ under the ‘wikipedia’ target [19:02:32] ok [19:02:33] thanks [19:03:02] 3Mobile-Web: Thanks is broken again - https://phabricator.wikimedia.org/T86687#974176 (10Jdlrobson) 3NEW [19:03:04] dbrant: arrrggh, that's one more than I'm requesting from prefix search [19:03:10] bearND: lol [19:03:10] bgerstle: definitely go for it! [19:03:32] k [19:04:18] dbrant: I could pump the batch size up to 16, or 20. Or make it 20 for large devices only. what do you think? [19:05:03] bearND: why not 20 all the time, then [19:05:41] dbrant, bearND: What are you guys talking about? [19:05:56] bmansurov: since ie8 does not support :not that rule doesnt get applied [19:06:02] dbrant: yeah, that's probably good for now. I was hoping we could reuse the same number as MFE (for caching) but that's opportunistically [19:06:13] joakino: thanks [19:06:14] Deskana: search batch size [19:06:17] jdlrobson2: sorry was getting george to bed [19:06:36] which has been… hard [19:06:59] Deskana: now that I've combine prefix and full text search it would automatically kick off a full text search when it doesn't have enough results to fill the screen [19:07:57] (03CR) 10Kaldari: "@Jdlrobson: What are the 3 steps?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183987 (https://phabricator.wikimedia.org/T85068) (owner: 10Jdlrobson) [19:08:05] Deskana: This is why i was asking dbrant about the number of rows showing up on his 10" tablet in portrait mode. I was setting the batch size to 15, but on some big tablets it could show 16 [19:08:36] Deskana hey, so i sent a request for my IRC cloak, i'm guessing i'll get an email if there were issues or it was completed successfully? [19:08:52] bgerstle: Yeah. These things can sometimes take a little bit of time. [19:09:09] bearND: Huh, strange. [19:09:34] k, thanks [19:09:40] Deskana: that reminds me -- one other thing that's been sitting in beta for a while is syntax highlighting (of templates). Do we want to move that to production with this release? [19:10:33] dbrant: I'm on the fence. I'm okay with trying it out, but I'm wondering what our criteria for success of that test is. [19:14:50] Deskana: well there's really no way to 'instrument' its usage... But I would say it's at least better than the continuous color between template and text. [19:15:40] (03PS3) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 [19:16:44] dbrant: gtg, will be back in 30 min. [19:16:52] bearND: k [19:21:37] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#974248 (10Deskana) 3NEW [19:25:10] (03CR) 10Phuedx: [C: 032] "Events comment is just thinking out loud." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184542 (https://phabricator.wikimedia.org/T86613) (owner: 10Kaldari) [19:25:37] 3Wikipedia-App-iOS-App: Production release for iOS Wikipedia app in February (provisional) - https://phabricator.wikimedia.org/T86692#974271 (10Deskana) 3NEW [19:26:52] (03Merged) 10jenkins-bot: Make WikiGrok A and B use same code for Thanks step [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184542 (https://phabricator.wikimedia.org/T86613) (owner: 10Kaldari) [19:27:18] (03Abandoned) 10Bmansurov: Make checkboxes work on Special:MobileOptions on Opera Mini [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184518 (owner: 10Bmansurov) [19:28:07] 3Mobile-Web: Anon user click tracking is not recorded correctly - https://phabricator.wikimedia.org/T85963#974294 (10Milimetric) I attempted to do this, earnestly, but found it a bit worrying so I talked to Ori and some researchers. Ori and I are in agreement that this feature is not as good of an idea as analy... [19:30:03] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#974312 (10Deskana) [19:30:28] dbrant: Alright, we'll do it. I will keep an eye on feedback about it. We can't afford to spend time iterating on it given our focus is readership though, so if it doesn't work we'll have to just pull it. [19:30:39] dbrant: https://phabricator.wikimedia.org/T86690#974312 [19:30:50] Deskana: agreed! [19:31:18] dbrant: And by "pull it" I mean "put it back to beta only and think about it at some point further down the line [19:31:23] (right) [19:34:56] dbrant: Comms wants to know if you can submit the release before metrics. [19:35:10] dbrant: The earlier the better, it seems. [19:35:19] Deskana: totally. [19:35:37] dbrant: 9am SF time? [19:35:56] (03CR) 10Florianschmidtwelzow: Don't break Special:Uploads when uploads not enabled for the user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184396 (https://phabricator.wikimedia.org/T86400) (owner: 10Florianschmidtwelzow) [19:35:57] Deskana: sounds good [19:37:04] Deskana: any thoughts/notes on the blog post? [19:42:53] rarrrr view controller is not popping off the view stack [19:42:53] (03PS1) 10Brion VIBBER: [Work in progress] Activity indicator and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 [19:42:53] will poke it again after lunch [19:42:53] om nom nom nom [19:45:28] phuedx / rmoen / joakino how does urban putt minigolf sound? [19:46:38] i've never eaten there though so no idea if the foot is top notch [19:46:49] (03PS1) 10Dbrant: Promote syntax highlighting to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184717 [19:46:54] jdlrobson2: wtf is that [19:47:03] (03PS1) 10Florianschmidtwelzow: Hygiene: Don't add missleading class to SpecialUploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184718 [19:47:11] joakino: http://www.urbanputt.com/ [19:48:10] jdlrobson2: sounds awesome [19:48:14] http://www.yelp.com/biz_photos/urban-putt-san-francisco?select=OKzCYZQaAhLbxG6bca_2cg#RNmrbRAspHoEnDkPQKEMPA [19:48:24] (03CR) 10Bmansurov: [C: 031] Implement infinite scroll independently from PhotoList (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [19:48:34] dbrant: It seems they're writing their own blog post. [19:48:41] dbrant: Which is... weird. They've never done that before. [19:48:59] jdlrobson2: sounds good [19:49:15] phuedx: can combine social and food... ;- [19:49:27] i'm not sure i want that [19:49:34] i want to be left alone with my burger… [19:49:45] wait [19:49:46] ok [19:49:56] i didn't mean that to sound as weird as it did [19:50:07] sure, minigolf + food is cool [19:50:13] Deskana: ok then [19:50:24] dbrant: Sorry. :-( [19:54:11] jdlrobson2: i'm in for golf. Sorry, getting distracted with foods [19:54:23] no worries [19:54:41] joakino: did you have a look at the ForeignApi stuff? I'm just going to poke at it now as I want to be able to test your infinite scroll patch [19:56:00] jdlrobson2: what would that be? [19:56:04] (03CR) 10BearND: [C: 032] Promote syntax highlighting to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184717 (owner: 10Dbrant) [19:56:31] (03Merged) 10jenkins-bot: Promote syntax highlighting to Production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184717 (owner: 10Dbrant) [19:57:57] joakino: mmm? ForeignApi ? [19:58:36] dbrant: what's your gut feel on my search patch? [19:58:43] jdlrobson2: :/ no idea? [19:58:55] (03PS1) 10Mhurd: Tweaks to lead image text styling per Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184725 [19:59:00] (03PS6) 10BearND: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [19:59:11] (03PS1) 10Mhurd: Fix for css body class. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184726 [19:59:22] dbrant: oops, meant to rebase my patch, lol [19:59:35] (03PS4) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 [19:59:50] Everyone gets a rebase! [19:59:57] bearND: gut feel -- love it. The only thing that I'm concerned by is, we're still not getting "did you mean" results from the API, and I'd like to see how this patch will handle it. [20:00:21] bgerstle: coreyfloyd i’ll be on the hangout in a minute… [20:00:35] dbrant: yeah, I tested that by hard-coding it [20:00:44] just added a fake suggestion [20:01:01] mhurd k see you in a bit we're both here [20:01:40] bearND: yeah, I suppose I could try that, too [20:01:48] (03PS2) 10Mhurd: Fix for css body class. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184726 [20:03:47] right, gonna head off for the night [20:03:59] g'night folks [20:04:55] dbrant: you can change it in the FullSearchArticlesTask right where the suggestion gets set. When you test it you have to scroll down to force a full text search [20:06:04] bearND: Is the "did you mean" being requested separately? [20:06:39] Deskana: no, it's part of the full text search result [20:06:54] Oh! I thought the generator didn't give it anymore. [20:07:04] that's a bug [20:07:18] It is indeed, but it's one that I didn't think we resolved. [20:07:49] Deskana: also would like you to check out the search patch to experience the difference in search behavior. Try first on master and then with the same search terms with my patch [20:08:24] Deskana: yeah, the generator doesn't provide any yet, but once that is fixed the patch would show it [20:11:04] bearND: I'll finish eating then pull the patch. [20:14:33] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#974426 (10Dbrant) https://gerrit.wikimedia.org/r/184682 https://gerrit.wikimedia.org/r/184683 https://gerrit.wikimedia.org/r/184717 [20:14:49] Hmm. [20:14:56] The ALL CAPS bug seems to be back. [20:15:13] Wait. [20:15:18] 2.0-beta-2014-11-17 [20:15:19] wat [20:16:51] Deskana: that's a 5.0 thing. Older apks don't have the fix for it [20:19:51] (03PS2) 10Brion VIBBER: [Work in progress] Activity indicator and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 [20:20:55] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#974441 (10bearND) The description is missing full text search. Without https://gerrit.wikimedia.org/r/#/c/184692/3: It would either show prefix search results or full text search resu... [20:21:08] bearND: What I mean is, that's the APK that I just built from master. [20:22:53] hmmm [20:27:51] bearND: It's some weird bug with Android Studio I think. [20:28:32] bearND: When I rebuilt the APK, having changed nothing, it actually put the correct one on my device. [20:28:40] Deskana: which build variant are using? [20:28:48] bearND: I used betaDebug. [20:29:10] Deskana: ok, yeah, a rebuild should fix it [20:29:25] clear out the old apks that have different names [20:30:09] i mean the rebuild should clear out the old apks [20:31:39] Deskana: for this testing you may also want to check out the prodDebug variant [20:31:52] to make sure all the right features get into production [20:32:28] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#974472 (10Deskana) [20:33:51] bearND: Your patch can be a little strange for some things. For example, the query "brack obama" displays Barack Obama as the first result on master, but with your patch it displays a blank "Brack Obama" result (which is a redirect) above Barack Obama [20:34:06] bearND: Can you give me a few examples of queries that are a bit better? [20:34:23] 3Wikipedia-App-Android-App: Production release for Android Wikipedia app on 2015-01-15 - https://phabricator.wikimedia.org/T86690#974248 (10Deskana) >>! In T86690#974441, @bearND wrote: > The description is missing full text search. > Without https://gerrit.wikimedia.org/r/#/c/184692/3: > It would either show pr... [20:35:24] Deskana: "rebecca soln", then "rebecca solnit" [20:37:28] i can haz https://gerrit.wikimedia.org/r/#/c/184524/ ? :P [20:37:56] 3MediaWiki-extensions-Flow, MediaWiki-extensions-ZeroBanner, UI-Standardization, Scrum-of-Scrums, Mobile-Web: Dismantle Mantle - https://phabricator.wikimedia.org/T85890#974489 (10hashar) Would it be possible to have Mantle skip loading when it detects it is run with a sufficiently recent version of mediawiki/co... [20:38:01] (03CR) 10Krinkle: "Not for this commit, but please put the jsduck config in a jsduck.json file so that it is picked up by other consumers and clients for jsd" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 (owner: 10Florianschmidtwelzow) [20:40:46] (03CR) 10Krinkle: "Hm.. was this meant to be in a directory of sorts? Having a jsduckCustomTags.rb file in the repo root is a bit odd. Since it's not an conf" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184405 (owner: 10Florianschmidtwelzow) [20:40:54] bearND: Let's have a quick meeting some time to compare the two and figure out how to proceed. [20:41:46] bearND: My calendar is a nightmare today. Does 4:30pm SF time work for you? [20:41:51] Wait... [20:41:55] No, that doesn't work either. [20:41:55] Eurgh. [20:42:56] It'll have to be tomorrow. :-( [20:43:23] (03CR) 10Jdlrobson: [C: 032] Implement infinite scroll independently from PhotoList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [20:44:22] 3Mobile-Web: Broken unicode character in mobile footer (ZERO WIDTH NON-JOINER) - https://phabricator.wikimedia.org/T86281#974495 (10Krinkle) Nearly every page of every mobile page is affected in Chrome 42. Location: https://en.m.wiktionary.org/wiki/Wiktionary:Main_Page Browser: Google Chrome Canary 42 for Mac.... [20:45:58] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Don't add missleading class to SpecialUploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184718 (owner: 10Florianschmidtwelzow) [20:47:33] (03Merged) 10jenkins-bot: Implement infinite scroll independently from PhotoList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/183838 (owner: 10Jhernandez) [20:52:02] Deskana: ok. Then we shouldn't hold up today's beta. (cc: dbrant) [20:58:23] 3MediaWiki-extensions-Flow, MediaWiki-extensions-ZeroBanner, UI-Standardization, Scrum-of-Scrums, Mobile-Web: Dismantle Mantle - https://phabricator.wikimedia.org/T85890#974523 (10Jdlrobson) @hashar mobile is now not using Mantle for anything. The dependency has also been removed https://gerrit.wikimedia.org/r/1... [21:00:11] (03PS3) 10Brion VIBBER: [Work in progress] Activity indicator and background thread for conversion [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/184716 [21:01:31] anyone seen dbrant ? [21:03:36] jdlrobson2: he was here until a few minutes ago [21:05:47] 3MediaWiki-extensions-Thanks, Mobile-Web: Thanks button not loading on mobile - https://phabricator.wikimedia.org/T77929#974533 (10Qgil) [21:06:30] dbrant: jdlrobson2 was looking for you [21:07:50] bbiab [21:09:16] dbrant: move your camera a bit higher, your eyes are cut off [21:11:32] dbrant: Deskana: want me to start the beta build? [21:11:48] bearND: All good on my end. [21:12:53] 3Mobile-Web: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - https://phabricator.wikimedia.org/T69819#974555 (10bmansurov) a:3bmansurov [21:12:56] bearND: yes, please! [21:18:55] (03PS1) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184777 [21:23:18] (03CR) 10jenkins-bot: [V: 04-1] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184777 (owner: 10BearND) [21:25:19] FlorianSW: Hi, why did you revert your patch here? https://gerrit.wikimedia.org/r/#/c/165694/ [21:25:59] (03PS2) 10BearND: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184777 [21:26:05] bmansurov: breaks Flow, see https://phabricator.wikimedia.org/T73570 [21:27:43] (03CR) 10BearND: [C: 032] Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184777 (owner: 10BearND) [21:28:25] dbrant: Deskana: ok, rien ne va plus -- no more merges until the pending bump merge [21:28:31] FlorianSW: I see, but jdlrobson2 is not against it https://phabricator.wikimedia.org/T69819#943391 [21:28:43] FlorianSW: maybe we should revert your revert. What do you think? [21:28:49] (03Merged) 10jenkins-bot: Manual import of Android string translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184777 (owner: 10BearND) [21:28:53] bearND: Aye aye, captain. [21:30:25] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184782 [21:30:57] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184782 (owner: 10BearND) [21:31:20] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184782 (owner: 10BearND) [21:36:25] mhurd: https://docs.google.com/a/wikimedia.org/spreadsheets/d/11iDuWemW2V2uwpjWxhWjganO_jcPhF6oz8Ecn_Sh4rA/edit#gid=0 [21:36:25] kaldari: --^ [21:36:41] bearND, hey, if I open the main page in simple english I don't get the featured article etc. [21:41:53] Krenair: hmmm, I get some welcome text and "did you know..." section. Is this what you are seeing? [21:43:01] Heading to gym, back in about an hour. [21:55:54] moizsyed: okay, the text selection share feature is working. gotta do code cleanup, but it works! [21:56:15] dr0ptp4kt: nice! [21:56:52] moizsyed: mhurd found a nice post on stackoverflow that pointed to a useful wwdc video for this particular thing [21:57:05] (the context menu) [21:57:14] dr0ptp4kt: wow nice [22:04:01] dbrant: would you mind if we postpone the “hatnotes” hangout - foods are needed... [22:04:14] mhurd: sure! [22:06:01] dbrant: cool! i deleted the meeting for now… i’m 99% sure it was something silly i was doing… iron it out maybe tomorrow? [22:06:56] mhurd: totally! [22:08:05] dbrant: Deskana: beta is published [22:08:27] Krenair: are you still there? I had a netsplit earlier [22:08:30] Krenair: hmmm, I get some welcome text and "did you know..." section. Is this what you are seeing? [22:08:38] yes [22:08:54] yes [22:10:22] leila: any update? [22:11:06] bearND: awesome; thanks! [22:11:31] Krenair: I guess you could file a bug for that. I didn't even know this simple english site existed on wikipedia [22:11:49] really? [22:13:02] Krenair: ok, i think it's probably a mobileview thing. On Desktop I see the Selected Article of the day, but on mobile http://simple.m.wikipedia.org/wiki/Main_Page I don't [22:13:46] Krenair: so this should be fixed on the API level, and it also affects MFE [22:14:34] kaldari: I'm testing, currently in a staff meeting can't walk out [22:14:40] will update around 3-3:15pm. [22:15:03] FlorianSW: how can I make flow the talk provider on mobile? It works on the desktop version, but not on mobile. [22:15:51] (03CR) 10Kaldari: [C: 032] Improve API error checking [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/184524 (owner: 10MaxSem) [22:17:35] bmansurov: you normally just need to open the talk page :) The talk button should be the link to the talk page (you can get the link through the title object in php)... then i suggest to split up mobile.talk into a one that enables the talk button (just remove the hidden class, so maybe it can be a line into an generic module?) and another one, that provides the talk overlay (which will be load in SkinMinervaBeta.php with [22:17:42] you understand? :D [22:18:52] FlorianSW: so, without Flow talk button opens an overlay, right? How should it behave when flow is installed? [22:19:23] no, flow doesn't add an overlay :) It will replace the "normal" mediawiki own talk page :) [22:19:43] try it here: https://m.mediawiki.org/wiki/Talk:Flow [22:20:32] FlorianSW: yes, that's what I see locally too. But i'm interested in the Talk button behavior. So the problem is that we don't want to hide the button when Flow is installed and JS is disabled. [22:21:15] FlorianSW: What I don't understand is when flow is installed and when I click on the talk button, nothing happens. Is the button supposed to take me to the Talk page? [22:21:55] FlorianSW: I should say when JS is disabled above [22:22:05] bmansurov: actually not, iirc, because the button doesn't have a "real" link to the talk page, the default is #/talk/ (or nothing?) [22:22:19] bmansurov: ah, yes, fu** [22:22:29] FlorianSW: then why worry about Flow when hiding that button? [22:24:22] hmm, i think the problem is, that flow pages on mobile won't be able to load when we hide the button and show it in mobile.talk module (even if JS is enabled), because flow removes the mobile talk module [22:25:54] (03PS5) 10BearND: Combine title and full text search [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184692 [22:25:56] FlorianSW: ok thanks [22:26:05] bmansurov: i think the best way would be: [22:26:06] (03PS7) 10BearND: Video playback in Gallery. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184416 (https://phabricator.wikimedia.org/T86558) (owner: 10Dbrant) [22:26:28] 1. the talk page is a "normal" talk page -> add hidden class and remove in mobile.talk via JS [22:26:54] 2. if talk page is Flow: don't add a hidden class and talk button links to the talk page [22:27:02] bearND, what project? [22:28:37] FlorianSW: on 1 when is you say the talk page do you mean Talk:Abc? [22:29:15] Krenair: Not sure what the right project for Mobile Front end is. I see a "Mobile" project. FlorianSW, do you happen do know the phabricator project for MFE? [22:29:16] bmansurov: yes and no :P Flow is Talk:Abc, too, but another content model :) with "normal" talk pages, i mean talk pages without Flow :) [22:29:34] MediaWiki-extensions-MobileFrontend? [22:29:38] bearND, Krenair: Mobile-Web [22:29:42] hm, nope o.O [22:29:50] ok... [22:29:55] and probably MobileFrontend-(alpha|stable|beta|FeatureRequest) [22:29:56] FlorianSW: yeah, but what about the talk button on non-talk pages, i.e. /wiki/Abc? [22:29:56] 3Mobile-Web: Simple English Wikipedia front page is missing a lot - https://phabricator.wikimedia.org/T86712#974716 (10Krenair) 3NEW [22:29:58] FlorianSW: thanks [22:30:11] bmansurov: what is with it? [22:30:49] FlorianSW: Can the discussion button on non-talk pages be hidden in php and shown with js? Does that mess up flow? [22:31:20] the button should be always visible, when the talk page (of the article page) is flow (no "hidden" class), otherwise hide it and show it with JS :) [22:33:25] FlorianSW: which is what you had in your patch ;) [22:34:41] FlorianSW: also, that button link is #/talk so I'm not sure how it can take the user to the Flow talk page [22:34:42] bmansurov: no, my patch doesn't handle flow pages :) [22:35:25] bmansurov: it should be (in SkinMinerva.php) the link to the talk page (not #/talk) and should be changed to #/talk in mobile.talk. [22:35:41] FlorianSW: got it, thanks for patiently explaining [22:35:46] now i have a (maybe) better idea: Don't hide the button at all [22:36:03] link to the talk page (always) and with JS, change it to #/talk :) [22:36:26] Good idea [22:36:26] so you will be linked to the talk page without js (with and without Flow) :) [22:36:51] But if Flow is enabled, do we still want to show the overlay? [22:37:00] when JS is also enabled [22:37:34] it will not load :) mobile.talk is disabled by Flow, see https://github.com/wikimedia/mediawiki-extensions-Flow/blob/56e3ef2558b0e275eb19059e4f0a0d8d0d24e13f/Hooks.php#L443 [22:38:12] FlorianSW: oh yeah, forgot [22:38:21] :P [22:50:06] (03PS1) 10Dbrant: [WIP] Infobox/toolbar styling tweaks. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/184793 [22:55:53] (03PS1) 10Bmansurov: Add Talk button url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184795 (https://phabricator.wikimedia.org/T69819) [23:00:45] Doing some meeting cancelling for all hands/dev summit week. Sorry for calendar update spams :-/ [23:03:08] kaldari: are you around? [23:03:21] yes [23:03:35] walking to your desk [23:07:18] Maryana: Met with leila. All issues are resolved, so we can launch ~4. [23:07:32] \o/ [23:07:35] hugz [23:10:04] coreyfloyd: thanks for that onboarding mail. good feedback. [23:12:18] (03PS1) 10MaxSem: Kill obsolete profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 [23:13:18] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add Talk button url (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184795 (https://phabricator.wikimedia.org/T69819) (owner: 10Bmansurov) [23:14:58] (03CR) 10jenkins-bot: [V: 04-1] Kill obsolete profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 (owner: 10MaxSem) [23:15:51] (03PS2) 10Bmansurov: Add Talk button url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184795 (https://phabricator.wikimedia.org/T69819) [23:21:33] 3Mobile-Web: Simple English Wikipedia front page is missing a lot - https://phabricator.wikimedia.org/T86712#974808 (10MaxSem) 5Open>3Invalid a:3MaxSem That's something controlled by communities: https://www.mediawiki.org/wiki/Extension:MobileFrontend#Configuring_the_main_page [23:21:51] (03CR) 10Florianschmidtwelzow: [C: 031] Add Talk button url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184795 (https://phabricator.wikimedia.org/T69819) (owner: 10Bmansurov) [23:26:09] (03PS2) 10MaxSem: Kill obsolete profiling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184801 [23:29:08] tfinc: no problem. [23:41:42] 3MobileFrontend-alpha, Mobile-Web: Wikidata Infobox should properly format dates - https://phabricator.wikimedia.org/T85960#974840 (10bmansurov) a:3bmansurov [23:45:41] (03PS1) 10Bmansurov: User friendly dates for wikidata infobox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/184811 (https://phabricator.wikimedia.org/T85960) [23:52:03] 3Mobile-Web: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#974866 (10bmansurov) a:3bmansurov [23:59:25] 3Wikipedia-App-Android-App: Unchecked checkboxes aren't visible in dark theme - https://phabricator.wikimedia.org/T85809#974880 (10KLans_WMF) Tracked here: https://trello.com/c/7amUccn2/33-unchecked-checkboxes-aren-t-visible-in-dark-theme